- Devel - libvirt List Archives

[libvirt] Plans for next releases
by Daniel Veillard 27 Nov '15

27 Nov '15

Seems I forgot to send that mail earlier. I think we should enter freeze now is we want to push on the next week (and I'm away travelling 3-7 unlikely to have much time on this. If I can freeze now I can try to push 1.3.0 on Wed 2nd, otherwise we would have to wait Tuesday 8. On the other hand usually Dec and Jan are relatively low traffic and I end up doing one release mid-january and the forlowing one end of Feb, so delaying 1.3.0 a little bit may not be a bad idea. Also make dist is broken right now :) make[2]: Entering directory '/home/veillard/libvirt/src' make[2]: *** No rule to make target 'logging/libvirt_logd.aug', needed by 'distdir'. Stop. make[2]: Leaving directory '/home/veillard/libvirt/src' Makefile:2100: recipe for target 'distdir' failed What about a freeze on Wed 3 with a release on Tuesday 8 for 1.3.0 then 1.3.1 mid january and 1.3.2 end of Feb ? thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] [PATCH] logging: remove reference to non-existent augeas files
by Daniel P. Berrange 27 Nov '15

27 Nov '15

The libvirt_logd.aug and test_libvirt_logd.aug.in files have never existed so shouldn't be in EXTRA_DIST. It was a copy+paste mistake when closing virtlogd from virtlockd Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a "make dist" build-fix src/Makefile.am | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 3c98c38..52552fe 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2464,9 +2464,7 @@ EXTRA_DIST += \ locking/lockd.conf \ locking/libvirt_lockd.aug \ locking/test_libvirt_lockd.aug.in \ - logging/virtlogd.sysconf \ - logging/libvirt_logd.aug \ - logging/test_libvirt_logd.aug.in + logging/virtlogd.sysconf install-sysconfig: $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sysconfig -- 2.5.0

1 0

[libvirt] [PATCH v2] virtlogd: Fix build without DBus
by Martin Kletzander 27 Nov '15

27 Nov '15

The rule for virrotatingfiletest was defined in DBUS-only block even though the test does not use DBus at all. Also DBUS_CFLAGS and DBUS_LIBS are removed from the rules. The original error was: /usr/lib/gcc/x86_64-pc-linux-gnu/5.2.0/../../../../lib64/Scrt1.o: In function `_start': (.text+0x20): undefined reference to `main' Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index b449286f1fb3..e1e28eca93f1 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1062,6 +1062,11 @@ virnetdevmock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la virnetdevmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) +virrotatingfiletest_SOURCES = \ + virrotatingfiletest.c testutils.h testutils.c +virrotatingfiletest_CFLAGS = $(AM_CFLAGS) +virrotatingfiletest_LDADD = $(LDADDS) + if WITH_LINUX virusbtest_SOURCES = \ virusbtest.c testutils.h testutils.c @@ -1101,11 +1106,6 @@ virpolkittest_SOURCES = \ virpolkittest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) virpolkittest_LDADD = $(LDADDS) $(DBUS_LIBS) -virrotatingfiletest_SOURCES = \ - virrotatingfiletest.c testutils.h testutils.c -virrotatingfiletest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) -virrotatingfiletest_LDADD = $(LDADDS) $(DBUS_LIBS) - virsystemdtest_SOURCES = \ virsystemdtest.c testutils.h testutils.c virsystemdtest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) -- 2.6.3

2 1

[libvirt] [PATCH 00/34] Prepare for specific vcpu hot(un)plug - part 1
by Peter Krempa 27 Nov '15

27 Nov '15

This series is getting rather big. The target is to refactor the way libvirt stores info about vCPUs into a single structure (okay, two structures for the qemu driver. Part 1 is not yet completely there, well, not even halfway. Future work will involve fully allocating priv->vcpupids to the maxcpus size and moving around few other bits of data in cputune and other parts to the new structure. Yet another follow up work is then to add new APIs for vCPU hotplug, which will enable adding vCPUs sparsely (useful if you have NUMA). Since this refactor will result in tracking all vcpu-related data in one struct, the result will automagically fix a few bugs where we'd end up with invalid config after vcpu unplug or other operations. The changes can also be fetched at: git fetch git://pipo.sk/pipo/libvirt.git vcpu-refactor-part-1 Peter Krempa (34): hyperv: Allocate 'def' via virDomainDefNew openvz: Refactor extraction of vcpu count phyp: Refactor extraction of vcpu count xenapi: Refactor extraction of vcpu count conf: Use local copy of maxvcpus in virDomainVcpuParse conf: Drop useless check when parsing cpu scheduler info conf: Replace writes to def->maxvcpus with accessor conf: Extract update of vcpu count if maxvcpus is decreased conf: Add helper to check whether domain has offline vCPUs conf: Assume at least 1 maximum and current vCPU for every conf conf: Replace read access to def->maxvcpus with accessor conf: Replace writes to def->vcpus with accessor conf: Move vcpu count check into helper conf: Replace read accesses to def->vcpus with accessor conf: Turn def->maxvcpus into size_t qemu: domain: Add helper to access vm->privateData->agent qemu: Extract vCPU onlining/offlining via agent into a separate function qemu: qemuDomainSetVcpusAgent: re-check agent before calling it the again qemu: Split up vCPU hotplug and hotunplug qemu: cpu hotplug: Fix error handling logic qemu: monitor: Explain logic of qemuMonitorGetCPUInfo qemu: monitor: Remove weird return values from qemuMonitorSetCPU qemu: cpu hotplug: Move loops to qemuDomainSetVcpusFlags qemu: Refactor qemuDomainHotplugVcpus qemu: refactor qemuDomainHotunplugVcpus conf: turn def->vcpus into a structure conf: ABI: Split up and improve vcpu info ABI checking conf: Add helper to get pointer to a certain vCPU definition qemu: cgroup: Remove now unreachable check qemu: Drop checking vcpu threads in emulator bandwidth getter/setter qemu: Replace checking for vcpu<->pid mapping availability with a helper qemu: Add helper to retrieve vCPU pid qemu: driver: Refactor qemuDomainHelperGetVcpus qemu: cgroup: Don't use priv->ncpupids to iterate domain vCPUs src/conf/domain_audit.c | 2 +- src/conf/domain_conf.c | 207 ++++++++++++++--- src/conf/domain_conf.h | 22 +- src/hyperv/hyperv_driver.c | 12 +- src/libvirt_private.syms | 6 + src/libxl/libxl_conf.c | 6 +- src/libxl/libxl_driver.c | 38 +-- src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/lxc/lxc_native.c | 5 - src/openvz/openvz_conf.c | 14 +- src/openvz/openvz_driver.c | 31 +-- src/phyp/phyp_driver.c | 15 +- src/qemu/qemu_cgroup.c | 42 ++-- src/qemu/qemu_command.c | 25 +- src/qemu/qemu_domain.c | 47 ++++ src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 538 ++++++++++++++++++++++--------------------- src/qemu/qemu_monitor.c | 9 + src/qemu/qemu_monitor_json.c | 4 - src/qemu/qemu_monitor_text.c | 22 +- src/qemu/qemu_process.c | 22 +- src/test/test_driver.c | 38 +-- src/uml/uml_driver.c | 2 +- src/vbox/vbox_common.c | 19 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 34 +-- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c | 9 +- src/xen/xm_internal.c | 19 +- src/xenapi/xenapi_driver.c | 11 +- src/xenapi/xenapi_utils.c | 6 +- src/xenconfig/xen_common.c | 16 +- src/xenconfig/xen_sxpr.c | 26 ++- tests/openvzutilstest.c | 2 +- 35 files changed, 783 insertions(+), 478 deletions(-) -- 2.6.2

2 73

[libvirt] [PATCH] virtlogd: Fix build without DBus
by Martin Kletzander 27 Nov '15

27 Nov '15

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/Makefile.am | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index b449286f1fb3..e2fb3b7f3b67 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -172,7 +172,6 @@ test_programs = virshtest sockettest \ virkeycodetest \ virlockspacetest \ virlogtest \ - virrotatingfiletest \ virstringtest \ virportallocatortest \ sysinfotest \ @@ -210,6 +209,7 @@ endif WITH_LIBVIRTD if WITH_DBUS test_programs += virdbustest \ virsystemdtest \ + virrotatingfiletest \ $(NULL) if WITH_POLKIT1 test_programs += virpolkittest @@ -1112,7 +1112,9 @@ virsystemdtest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) virsystemdtest_LDADD = $(LDADDS) $(DBUS_LIBS) else ! WITH_DBUS -EXTRA_DIST += virdbustest.c virmockdbus.c virsystemdtest.c +EXTRA_DIST += \ + virdbustest.c virmockdbus.c \ + virsystemdtest.c virrotatingfiletest.c endif ! WITH_DBUS viruritest_SOURCES = \ -- 2.6.3

2 2

[libvirt] [PATCH] logging: avoid variables called 'daemon' due to function clash
by Daniel P. Berrange 27 Nov '15

27 Nov '15

With some versions of GLibC / GCC, a variable called 'daemon' will result in a warning about clashing with the function also named 'daemon'. Rename it to 'dmn' to avoid the clash. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a broken build fix. src/logging/log_daemon.c | 10 +++++----- src/logging/log_daemon.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index 3fda9ca..6da5876 100644 --- a/src/logging/log_daemon.c +++ b/src/logging/log_daemon.c @@ -127,12 +127,12 @@ virLogDaemonFree(virLogDaemonPtr logd) static void virLogDaemonInhibitor(bool inhibit, void *opaque) { - virLogDaemonPtr daemon = opaque; + virLogDaemonPtr dmn = opaque; if (inhibit) - virNetDaemonAddShutdownInhibition(daemon->dmn); + virNetDaemonAddShutdownInhibition(dmn->dmn); else - virNetDaemonRemoveShutdownInhibition(daemon->dmn); + virNetDaemonRemoveShutdownInhibition(dmn->dmn); } static virLogDaemonPtr @@ -177,9 +177,9 @@ virLogDaemonNew(virLogDaemonConfigPtr config, bool privileged) virLogHandlerPtr -virLogDaemonGetHandler(virLogDaemonPtr daemon) +virLogDaemonGetHandler(virLogDaemonPtr dmn) { - return daemon->handler; + return dmn->handler; } diff --git a/src/logging/log_daemon.h b/src/logging/log_daemon.h index b076a4f..8d55bb2 100644 --- a/src/logging/log_daemon.h +++ b/src/logging/log_daemon.h @@ -40,6 +40,6 @@ struct _virLogDaemonClient { extern virLogDaemonPtr logDaemon; -virLogHandlerPtr virLogDaemonGetHandler(virLogDaemonPtr daemon); +virLogHandlerPtr virLogDaemonGetHandler(virLogDaemonPtr dmn); #endif /* __VIR_LOG_DAEMON_H__ */ -- 2.5.0

1 0

[libvirt] [PATCH] virtlogd: Rename variable shadowing global declaration
by Martin Kletzander 27 Nov '15

27 Nov '15

This time the winner is variable named 'daemon'. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/logging/log_daemon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index 3fda9ca33c61..cc0559d7ff7b 100644 --- a/src/logging/log_daemon.c +++ b/src/logging/log_daemon.c @@ -127,12 +127,12 @@ virLogDaemonFree(virLogDaemonPtr logd) static void virLogDaemonInhibitor(bool inhibit, void *opaque) { - virLogDaemonPtr daemon = opaque; + virLogDaemonPtr logdmn = opaque; if (inhibit) - virNetDaemonAddShutdownInhibition(daemon->dmn); + virNetDaemonAddShutdownInhibition(logdmn->dmn); else - virNetDaemonRemoveShutdownInhibition(daemon->dmn); + virNetDaemonRemoveShutdownInhibition(logdmn->dmn); } static virLogDaemonPtr @@ -177,9 +177,9 @@ virLogDaemonNew(virLogDaemonConfigPtr config, bool privileged) virLogHandlerPtr -virLogDaemonGetHandler(virLogDaemonPtr daemon) +virLogDaemonGetHandler(virLogDaemonPtr logdmn) { - return daemon->handler; + return logdmn->handler; } -- 2.6.3

2 1

[libvirt] libvirt-php 0.5.1 uneeded files
by Remi Collet 27 Nov '15

27 Nov '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Installing the new 0.5.1 version: libvirt-php.la libvirt-php.so -> libvirt-php.so.0.0.0 libvirt-php.so.0 -> libvirt-php.so.0.0.0 libvirt-php.so.0.0.0 This is not a versioned library but a PHP extension so having those have no sense. Only libvirt-php.so is needed. Notice: I think it will be simpler to switch to the standard PHP extension build system (phpize; configure; make) Especially, this will allow to use the --with-php-config option (an thus, build for not standard PHP, e.g. TS build or SCL build) Remi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlZYFIAACgkQYUppBSnxahgqCACg1pGNreKPBVqexNK5yH2VhbRb ZjUAnAuEIl14rIha7Ak70Vzh4LvLSPGy =CFD6 -----END PGP SIGNATURE-----

1 0

[libvirt] [PATCH] virtlogd: use PRIu64 to print 64bit types
by Guido Günther 26 Nov '15

26 Nov '15

Otherwise we fail on 32bit with: CC logging/virtlogd-log_daemon_dispatch.o logging/log_daemon_dispatch.c: In function 'virLogManagerProtocolDispatchDomainReadLogFile': logging/log_daemon_dispatch.c:120:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type 'uint64_t' [-Werror=format] --- src/logging/log_daemon_dispatch.c | 3 ++- tests/virrotatingfiletest.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/logging/log_daemon_dispatch.c b/src/logging/log_daemon_dispatch.c index 269255a..7391a6f 100644 --- a/src/logging/log_daemon_dispatch.c +++ b/src/logging/log_daemon_dispatch.c @@ -21,6 +21,7 @@ */ #include <config.h> +#include <inttypes.h> #include "rpc/virnetserver.h" #include "rpc/virnetserverclient.h" @@ -118,7 +119,7 @@ virLogManagerProtocolDispatchDomainReadLogFile(virNetServerPtr server ATTRIBUTE_ if (args->maxlen > VIR_LOG_MANAGER_PROTOCOL_STRING_MAX) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Requested data len %zu is larger than maximum %d"), + _("Requested data len %"PRIu64" is larger than maximum %d"), args->maxlen, VIR_LOG_MANAGER_PROTOCOL_STRING_MAX); goto cleanup; } diff --git a/tests/virrotatingfiletest.c b/tests/virrotatingfiletest.c index ed55e63..73f0c26 100644 --- a/tests/virrotatingfiletest.c +++ b/tests/virrotatingfiletest.c @@ -23,6 +23,7 @@ #include <stdio.h> #include <unistd.h> #include <fcntl.h> +#include <inttypes.h> #include "virrotatingfile.h" #include "virlog.h" @@ -57,7 +58,8 @@ static int testRotatingFileWriterAssertOneFileSize(const char *filename, fprintf(stderr, "File %s should not exist\n", filename); return -1; } else if (sb.st_size != size) { - fprintf(stderr, "File %s should be %zu bytes not %zu\n", + fprintf(stderr, "File %s should be %" PRIu64 + " bytes not %" PRIu64 "\n", filename, size, sb.st_size); return -1; } else { -- 2.6.2

2 6

[libvirt] [PATCH] virtlogd: cast maxlen to size_t
by Guido Günther 26 Nov '15

26 Nov '15

Otherwise we fail on 32bit with: CC logging/virtlogd-log_daemon_dispatch.o logging/log_daemon_dispatch.c: In function 'virLogManagerProtocolDispatchDomainReadLogFile': logging/log_daemon_dispatch.c:120:9: error: format '%zu' expects argument of type 'size_t', but argument 7 has type 'uint64_t' [-Werror=format] --- src/logging/log_daemon_dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_daemon_dispatch.c b/src/logging/log_daemon_dispatch.c index 269255a..70b5f1d 100644 --- a/src/logging/log_daemon_dispatch.c +++ b/src/logging/log_daemon_dispatch.c @@ -119,7 +119,7 @@ virLogManagerProtocolDispatchDomainReadLogFile(virNetServerPtr server ATTRIBUTE_ if (args->maxlen > VIR_LOG_MANAGER_PROTOCOL_STRING_MAX) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Requested data len %zu is larger than maximum %d"), - args->maxlen, VIR_LOG_MANAGER_PROTOCOL_STRING_MAX); + (size_t)args->maxlen, VIR_LOG_MANAGER_PROTOCOL_STRING_MAX); goto cleanup; } -- 2.6.2

2 2