- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] Couple of Coverity fixes
by Michal Privoznik 31 Mar '16

31 Mar '16

*** SOME BLURB HERE *** Michal Privoznik (2): virPerfReadEvent: Prefer saferead over read qemuProcessVerifyGuestCPU: Avoid coverity false positive src/qemu/qemu_process.c | 2 ++ src/util/virperf.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.7.3

3 6

[libvirt] build: workaround broken SASL header (again)
by Fabiano Fidêncio 31 Mar '16

31 Mar '16

Compilation for xdg-app failed due to a buggy SASL headers present on the used runtime (org.gnome.Sdk 3.18). In file included from rpc/virnetsaslcontext.h:24:0, from rpc/virnetsaslcontext.c:25: /usr/include/sasl/sasl.h:230:38: error: unknown type name 'size_t' typedef void *sasl_realloc_t(void *, size_t); ^ /usr/include/sasl/sasl.h:235:5: error: unknown type name 'sasl_realloc_t' sasl_realloc_t *, --- src/rpc/virnetsaslcontext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsaslcontext.h b/src/rpc/virnetsaslcontext.h index 54634d5..edc082f 100644 --- a/src/rpc/virnetsaslcontext.h +++ b/src/rpc/virnetsaslcontext.h @@ -21,9 +21,9 @@ #ifndef __VIR_NET_CLIENT_SASL_CONTEXT_H__ # define __VIR_NET_CLIENT_SASL_CONTEXT_H__ +# include "internal.h" # include <sasl/sasl.h> -# include "internal.h" # include "virobject.h" typedef struct _virNetSASLContext virNetSASLContext; -- 2.7.3

2 1

[libvirt] [PATCH] spec: fix trigger already defined issue on systems without systemd
by Jean-Marc LIGER 31 Mar '16

31 Mar '16

There is a trigger already defined issue when you try to rebuild libvirt >= 1.3.0 for el6 with copr and most probably koji. Regards, Jean-Marc diff -uri a/libvirt.spec.in b/libvirt.spec.in --- a/libvirt.spec.in 2016-03-01 04:21:48.000000000 +0100 +++ b/libvirt.spec.in 2016-03-11 14:57:43.347652313 +0100 @@ -1767,16 +1767,6 @@ fi %endif - %if %{with_systemd} - %else -%triggerpostun daemon -- libvirt-daemon < 1.2.1 -if [ "$1" -ge "1" ]; then - /sbin/service virtlockd reload > /dev/null 2>&1 || : - /sbin/service virtlogd reload > /dev/null 2>&1 || : - /sbin/service libvirtd condrestart > /dev/null 2>&1 -fi - %endif - # In upgrade scenario we must explicitly enable virtlockd/virtlogd # sockets, if libvirtd is already enabled and start them if # libvirtd is running, otherwise you'll get failures to start @@ -1789,6 +1779,12 @@ /bin/systemctl is-active libvirtd.service 1>/dev/null 2>&1 && /bin/systemctl start virtlogd.socket || : %else + %triggerpostun daemon -- libvirt-daemon < 1.2.1 + if [ "$1" -ge "1" ]; then + /sbin/service virtlockd reload > /dev/null 2>&1 || : + /sbin/service virtlogd reload > /dev/null 2>&1 || : + /sbin/service libvirtd condrestart > /dev/null 2>&1 + fi /sbin/chkconfig libvirtd 1>/dev/null 2>&1 && /sbin/chkconfig virtlogd on || : /sbin/service libvirtd status 1>/dev/null 2>&1 &&

2 2

[libvirt] [PATCH 0/7] docs: Some website tweaks
by Andrea Bolognani 31 Mar '16

31 Mar '16

Basically, the navigation menu is *way* too big, and takes the focus away from the actual content. Plus it's very easy for longish words to overflow it (see "Authentication" in the screenshots below). The headers are probably bigger than needed as well, so I've scaled them down. Using Wikipedia for comparison, you can see the new size is more comparable to what they use. Some other minor cleanups have been included as well. Before[1] and after[2] screenshots for your convenience. Cheers. [1] http://i.imgur.com/MZchAWD.png [2] http://i.imgur.com/BXepLTh.png Andrea Bolognani (7): docs: Adjust vertical whitespace in CSS docs: Remove empty CSS rule docs: Don't use <strong> in headers docs: Make menu entries smaller docs: Don't use bold text for menu entries docs: Use bold text for all headers docs: Make most headers a bit smaller docs/apps.html.in | 2 +- docs/generic.css | 15 +++++++++------ docs/libvirt.css | 30 ++++++------------------------ 3 files changed, 16 insertions(+), 31 deletions(-) -- 2.5.5

2 9

[libvirt] [PATCH] remote: Add flags to remote_protocol-structs
by Martin Kletzander 31 Mar '16

31 Mar '16

Caused by 3b6c8185328f. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the 'build-breaker' rule. src/remote_protocol-structs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 1257aac51dfb..6dddd52ab116 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -310,9 +310,11 @@ struct remote_domain_set_perf_events_args { u_int params_len; remote_typed_param * params_val; } params; + u_int flags; }; struct remote_domain_get_perf_events_args { remote_nonnull_domain dom; + u_int flags; }; struct remote_domain_get_perf_events_ret { struct { -- 2.8.0

1 0

[libvirt] libvirt python binding and strange errors in logs
by Vasiliy Tolstov 31 Mar '16

31 Mar '16

I'm use libvirt-python binding to export some metrics to ganglia from libvirt. python code http://paste.debian.net/422944/ when this script is running i get many erros in libvirtd.log like this: error : virNetSocketReadWire:1613 : End of file while reading data: Input/output error При этом открывается сокет: virNetSocketNew:277 : RPC_SOCKET_NEW: sock=0x7fced8036ae0 fd=27 errfd=-1 pid=0 localAddr=::1;16509, remoteAddr=::1;39962 As i understand libvirt try to determine client alive and fails, my code properly close libvirt connection, but may be it not freed? Or something else broken with my code? i'm use libvirt-python from 1.2.1 to 1.2.9 and libvirt from 1.3.0 to 1.3.3 -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

1 1

[libvirt] [PATCH] virDomain{Get, Set}PerfEvents: Tweak documentation
by Michal Privoznik 31 Mar '16

31 Mar '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 3e144b6..4f473c9 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -9695,11 +9695,13 @@ virDomainOpenChannel(virDomainPtr dom, * @domain: a domain object * @params: where to store perf events setting * @nparams: number of items in @params - * @flags: extra flags; not used yet, so callers should always pass 0 + * @flags: bitwise-OR of virDomainModificationImpact * - * Get all perf events setting. Possible fields returned in @params are - * defined by VIR_DOMAIN_PERF_* macros and new fields will likely be - * introduced in the future. + * Get all Linux perf events setting. Possible fields returned in + * @params are defined by VIR_PERF_EVENT_* macros and new fields + * will likely be introduced in the future. + * + * Linux perf events are performance analyzing tool in Linux. * * Returns -1 in case of failure, 0 in case of success. */ @@ -9743,9 +9745,13 @@ int virDomainGetPerfEvents(virDomainPtr domain, * @params: pointer to perf events parameter object * @nparams: number of perf event parameters (this value can be the same * less than the number of parameters supported) - * @flags: extra flags; not used yet, so callers should always pass 0 + * @flags: bitwise-OR of virDomainModificationImpact * - * Enable or disable the particular list of perf events you care about. + * Enable or disable the particular list of Linux perf events you + * care about. The @params argument should contain any subset of + * VIR_PERF_EVENT_ macros. + * + * Linux perf events are performance analyzing tool in Linux. * * Returns -1 in case of error, 0 in case of success. */ -- 2.7.3

1 0

[libvirt] [PATCH v4 0/5] migration: add multithread compression
by Nikolay Shirokovskiy 31 Mar '16

31 Mar '16

Add means to turn multithread compression on during migration. Add means to pass compression parameters in migration command. Changes from v3 =============== 1. HMP support is dropped. 2. Switch to a different implementation of setting migration parameters. Version 3 sets all parameters when configuring migration compression. If parameter is not specified explicitly it is set to hardcoded default value. New version set only explicitly specified parameters instead. This has some reproducibility drawbacks which are nevertheless could be overcomed and this issue will be addressed in another series. 3. Unspecified values are presented by bitset fields rather then specific values of parameters itself. This is a bit more tedious implementation to use but if we take it we can pass all parameter values checking to QEMU. 4. Misc minor changes on Jiri comments. Eli Qiao (1): qemumonitorjsontest: add test for getting multithread compress params Nikolay Shirokovskiy (2): migration: add compress method option qemu: migration: add compression options ShaoHe Feng (2): qemu monitor: add multithread compress parameters accessors virsh: add compression options for migration include/libvirt/libvirt-domain.h | 44 +++++++ src/qemu/qemu_driver.c | 29 ++++- src/qemu/qemu_migration.c | 246 ++++++++++++++++++++++++++++++++++----- src/qemu/qemu_migration.h | 30 +++++ src/qemu/qemu_monitor.c | 24 +++- src/qemu/qemu_monitor.h | 18 +++ src/qemu/qemu_monitor_json.c | 110 +++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 + tests/qemumonitorjsontest.c | 53 +++++++++ tools/virsh-domain.c | 83 +++++++++++++ tools/virsh.pod | 25 +++- 11 files changed, 628 insertions(+), 39 deletions(-) -- 1.8.3.1

3 20

[libvirt] [PATCH] host-validate: Improve CPU flags processing
by Andrea Bolognani 31 Mar '16

31 Mar '16

Instead of relying on substring search, tokenize the input and process each CPU flag separately. This ensures CPU flag detection will continue to work correctly even if we start looking for CPU flags whose name might appear as part of other CPU flags' names. The result of processing is stored in a virBitmap, which means we don't have to parse /proc/cpuinfo in its entirety for each single CPU flag we want to check. Moreover, use of the newly-introduced virHostValidateCPUFlag enumeration ensures we don't go looking for random CPU flags which might actually be simple typos. --- The concern was raised by John in https://www.redhat.com/archives/libvir-list/2016-March/msg01301.html when discussing a new check on the "sie" CPU flag. tools/virt-host-validate-common.c | 50 +++++++++++++++++++++++++++++---------- tools/virt-host-validate-common.h | 13 +++++++++- tools/virt-host-validate-qemu.c | 12 ++++++++-- 3 files changed, 60 insertions(+), 15 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 8ebf73e..57fa332 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -31,7 +31,6 @@ #endif /* HAVE_MNTENT_H */ #include <sys/stat.h> -#include "virutil.h" #include "viralloc.h" #include "virfile.h" #include "virt-host-validate-common.h" @@ -39,6 +38,10 @@ #define VIR_FROM_THIS VIR_FROM_NONE +VIR_ENUM_IMPL(virHostValidateCPUFlag, VIR_HOST_VALIDATE_CPU_FLAG_LAST, + "vmx", + "svm"); + static bool quiet; void virHostMsgSetQuiet(bool quietFlag) @@ -188,29 +191,47 @@ int virHostValidateNamespace(const char *hvname, } -bool virHostValidateHasCPUFlag(const char *name) +virBitmapPtr virHostValidateGetCPUFlags(void) { - FILE *fp = fopen("/proc/cpuinfo", "r"); - bool ret = false; + FILE *fp; + virBitmapPtr flags; - if (!fp) - return false; + if (!(fp = fopen("/proc/cpuinfo", "r"))) + return NULL; + + if (!(flags = virBitmapNewQuiet(VIR_HOST_VALIDATE_CPU_FLAG_LAST))) + return NULL; do { char line[1024]; + char *saveptr; + char *token; if (!fgets(line, sizeof(line), fp)) break; - if (strstr(line, name)) { - ret = true; - break; + if (!(token = strtok_r(line, " \t\n", &saveptr))) + continue; + + /* The line we're interested in is marked either as "flags" or + * as "Features" depending on the architecture, so check both + * prefixes. It's very unlikely that there will be no whitespace + * between the line name and the colon, but handle that as well */ + if (strcmp(token, "flags") && strcmp(token, "flags:") && + strcmp(token, "Features") && strcmp(token, "Features:")) + continue; + + while ((token = strtok_r(NULL, " \t\n", &saveptr))) { + int value; + + if ((value = virHostValidateCPUFlagTypeFromString(token)) >= 0) + ignore_value(virBitmapSetBit(flags, value)); } } while (1); VIR_FORCE_FCLOSE(fp); - return ret; + return flags; } @@ -359,15 +380,20 @@ int virHostValidateCGroupController(const char *hvname, int virHostValidateIOMMU(const char *hvname, virHostValidateLevel level) { + virBitmapPtr flags; struct stat sb; const char *bootarg = NULL; bool isAMD = false, isIntel = false; - if (virHostValidateHasCPUFlag("vmx")) + flags = virHostValidateGetCPUFlags(); + + if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) isIntel = true; - else if (virHostValidateHasCPUFlag("svm")) + else if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM)) isAMD = true; + virBitmapFree(flags); + virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); if (isIntel) { diff --git a/tools/virt-host-validate-common.h b/tools/virt-host-validate-common.h index d4c4759..26e006b 100644 --- a/tools/virt-host-validate-common.h +++ b/tools/virt-host-validate-common.h @@ -23,6 +23,8 @@ # define __VIRT_HOST_VALIDATE_COMMON_H__ # include "internal.h" +# include "virutil.h" +# include "virbitmap.h" typedef enum { VIR_HOST_VALIDATE_FAIL, @@ -32,6 +34,15 @@ typedef enum { VIR_HOST_VALIDATE_LAST, } virHostValidateLevel; +typedef enum { + VIR_HOST_VALIDATE_CPU_FLAG_VMX = 0, + VIR_HOST_VALIDATE_CPU_FLAG_SVM, + + VIR_HOST_VALIDATE_CPU_FLAG_LAST, +} virHostValidateCPUFlag; + +VIR_ENUM_DECL(virHostValidateCPUFlag); + extern void virHostMsgSetQuiet(bool quietFlag); extern void virHostMsgCheck(const char *prefix, @@ -53,7 +64,7 @@ extern int virHostValidateDeviceAccessible(const char *hvname, virHostValidateLevel level, const char *hint); -extern bool virHostValidateHasCPUFlag(const char *name); +extern virBitmapPtr virHostValidateGetCPUFlags(void); extern int virHostValidateLinuxKernel(const char *hvname, int version, diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c index a9f6c1e..b96b020 100644 --- a/tools/virt-host-validate-qemu.c +++ b/tools/virt-host-validate-qemu.c @@ -24,14 +24,20 @@ #include "virt-host-validate-qemu.h" #include "virt-host-validate-common.h" +#include "virbitmap.h" int virHostValidateQEMU(void) { + virBitmapPtr flags; int ret = 0; virHostMsgCheck("QEMU", "%s", ("for hardware virtualization")); - if (virHostValidateHasCPUFlag("svm") || - virHostValidateHasCPUFlag("vmx")) { + + flags = virHostValidateGetCPUFlags(); + + if (flags && + (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM) || + virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX))) { virHostMsgPass(); if (virHostValidateDeviceExists("QEMU", "/dev/kvm", VIR_HOST_VALIDATE_FAIL, @@ -48,6 +54,8 @@ int virHostValidateQEMU(void) _("Only emulated CPUs are available, performance will be significantly limited")); } + virBitmapFree(flags); + if (virHostValidateDeviceExists("QEMU", "/dev/vhost-net", VIR_HOST_VALIDATE_WARN, _("Load the 'vhost_net' module to improve performance " -- 2.5.5

2 4

[libvirt] [PATCH 0/6] Couple of perf events APIs fixes
by Michal Privoznik 31 Mar '16

31 Mar '16

I really like to see these in before release and thus APIs get written in the stone. One note though regarding the last patch: while writing it I've noticed couple of other getter APIs don't grab any job at all. I think they should grab _QUERY job though. So maybe those will need some fixing too. Michal Privoznik (6): remoteDomainGetPerfEvents: Re-indent virDomain{Get,Set}PerfEvents: Add @flags argument virsh: Prefer VIRSH_COMMON_OPT_DOMAIN_FULL over full enumeration virsh: Make perf accept event list separated by commas virDomain{Get,Set}PerfEvents: support --config --live --current virDomain{Get,Set}PerfEvents: Grab job daemon/remote.c | 2 +- include/libvirt/libvirt-domain.h | 6 ++- src/driver-hypervisor.h | 6 ++- src/libvirt-domain.c | 22 +++++---- src/qemu/qemu_driver.c | 99 +++++++++++++++++++++++++++++----------- src/remote/remote_driver.c | 12 +++-- src/remote/remote_protocol.x | 2 + tools/virsh-domain.c | 27 +++++++---- tools/virsh.pod | 25 ++++++---- 9 files changed, 141 insertions(+), 60 deletions(-) -- 2.7.3

2 13