- Devel - libvirt List Archives

[libvirt] [PATCH] docs: Clarify interface/target/@dev docs
by Jiri Denemark 01 Mar '16

01 Mar '16

https://bugzilla.redhat.com/show_bug.cgi?id=1313314 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c54b308..df8c06c 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4507,10 +4507,10 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This - name can be manually specified, however the name must not + name can be manually specified, however the name should not start with either 'vnet' or 'vif', which are prefixes reserved by libvirt and certain hypervisors. Manually specified - targets using these prefixes will be ignored. + targets using these prefixes may be ignored. -- 2.7.2

3 3

[libvirt] [PATCH v7 0/6] Global domain cpu.cfs_period_us and cpu.cfs_quota_us setup
by Alexander Burluka 01 Mar '16

01 Mar '16

This patchset implements an ability to specify values for domain top level cpu.cfs_period_us and cpu.cfs_quota_us cgroups. These parameters are opt-in and named "global_period" and "global_quota". Introduction of these settings gives management applications further choice of controlling CPU usage. Changes in v2: add XML validation test Changes in v3: remove unneccessary cgroup copying Changes in v4: fix little rebase error Changes in v5: rebase to version 1.3.1 Changes in v6: remove unnecessary check Changes in v7: rebase to current master Alexander Burluka (6): Add global period definitions Add global quota parameter necessary definitions Add error checking on global quota and period Add global_period and global_quota XML validation test Implement qemuSetupGlobalCpuCgroup Implement handling of per-domain bandwidth settings docs/schemas/domaincommon.rng | 10 +++ include/libvirt/libvirt-domain.h | 32 +++++++ src/conf/domain_conf.c | 37 +++++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_cgroup.c | 49 +++++++++++ src/qemu/qemu_cgroup.h | 1 + src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 97 +++++++++++++++++++++- src/qemu/qemu_process.c | 4 + tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 2 + .../qemuxml2xmloutdata/qemuxml2xmlout-cputune.xml | 2 + 11 files changed, 236 insertions(+), 3 deletions(-) -- 1.8.3.1

2 16

[libvirt] [PATCH] qemu: Don't always wait for SPICE to finish migration
by Jiri Denemark 01 Mar '16

01 Mar '16

When SPICE graphics is configured for a domain but we did not ask the client to switch to the destination, we should not wait for SPICE_MIGRATE_COMPLETED event (which will never come). https://bugzilla.redhat.com/show_bug.cgi?id=1151723 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_migration.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 8359b1a..0144792 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -137,6 +137,8 @@ struct qemuDomainJobObj { qemuDomainJobInfoPtr current; /* async job progress data */ qemuDomainJobInfoPtr completed; /* statistics data of a recently completed job */ bool abortJob; /* abort of the job requested */ + bool spiceMigration; /* we asked for spice migration and we + * should wait for it to finish */ bool spiceMigrated; /* spice migration completed */ }; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 704e182..64cbffa 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2415,7 +2415,8 @@ qemuMigrationWaitForSpice(virDomainObjPtr vm) bool wait_for_spice = false; size_t i = 0; - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SEAMLESS_MIGRATION)) + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SEAMLESS_MIGRATION) || + !priv->job.spiceMigration) return 0; for (i = 0; i < vm->def->ngraphics; i++) { @@ -2789,6 +2790,7 @@ qemuDomainMigrateGraphicsRelocate(virQEMUDriverPtr driver, QEMU_ASYNC_JOB_MIGRATION_OUT) == 0) { ret = qemuMonitorGraphicsRelocate(priv->mon, type, listenAddress, port, tlsPort, tlsSubject); + priv->job.spiceMigration = !ret; if (qemuDomainObjExitMonitor(driver, vm) < 0) ret = -1; } -- 2.7.2

2 2

[libvirt] [PATCH] qemu: Don't try to fetch migration stats on destination
by Jiri Denemark 01 Mar '16

01 Mar '16

Migration statistics are not available on the destination host and starting a query job during incoming migration is not allowed. Trying to do that would result in Timed out during operation: cannot acquire state change lock (held by remoteDispatchDomainMigratePrepare3Params) error. We should not even try to start the job. https://bugzilla.redhat.com/show_bug.cgi?id=1278727 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 45ff3c0..241de67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12901,9 +12901,16 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver, if (!priv->job.current || !priv->job.current->stats.status) fetch = false; - if (fetch && - qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) - return -1; + if (fetch) { + if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("migration statistics are available only on " + "the source host")); + return -1; + } + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) + return -1; + } if (!completed && !virDomainObjIsActive(vm)) { -- 2.7.2

2 2

[libvirt] [PATCH] Fix formatting in remote_protocol-structs
by Jiri Denemark 01 Mar '16

01 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/remote_protocol-structs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 11048b7..6c1cf5d 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -2503,7 +2503,7 @@ struct remote_domain_event_callback_device_added_msg { remote_nonnull_string devAlias; }; struct remote_connect_event_connection_closed_msg { - int reason; + int reason; }; struct remote_connect_get_cpu_model_names_args { remote_nonnull_string arch; -- 2.7.2

1 1

[libvirt] [PATCH] util: Fix build without polkit
by Jiri Denemark 01 Mar '16

01 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virpolkit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3bb60a5..3d2be61 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -329,13 +329,13 @@ int virPolkitCheckAuth(const char *actionid ATTRIBUTE_UNUSED, void -virPolkitAgentDestroy(virCommandPtr cmd ATTRIBUTE_UNUSED) +virPolkitAgentDestroy(virPolkitAgentPtr agent ATTRIBUTE_UNUSED) { return; /* do nothing */ } -virCommandPtr +virPolkitAgentPtr virPolkitAgentCreate(void) { virReportError(VIR_ERR_AUTH_FAILED, "%s", -- 2.7.2

1 1

[libvirt] [PATCH] qemu: enalbe hotplugging of macvtap device with multiqueue
by Shanzhi Yu 01 Mar '16

01 Mar '16

in commit 81a110, multiqueue for macvtap is enabled but forget to support hotplugging enabled Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index dc76268..b580283 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -892,10 +892,11 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, goto cleanup; } - /* Currently nothing besides TAP devices supports multiqueue. */ + /* Currently only TAP/macvtap devices supports multiqueue. */ if (net->driver.virtio.queues > 0 && !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_DIRECT)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Multiqueue network is not supported for: %s"), virDomainNetTypeToString(actualType)); -- 1.8.3.1

2 1

[libvirt] Wiki account
by Christophe Fergeau 01 Mar '16

01 Mar '16

Hey, I thought I already had a wiki account, but after a few failures to login or retrieve a password, it seems I don't, so I would like to get one for username 'teuf' Thanks, Christophe

2 1

[libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics
by Fabiano Fidêncio 01 Mar '16

01 Mar '16

Howdy! I've been trying to use libvirt-gobject and libvirt-gconfig, on virt-viewer, for accessing VMs and looking at their config, instead of using libvrit and parsing XML directly and turns out, that libvirt-gconfig is not exactly handful for a "read-only" use case (as virt-viewer's one). Let me try to explain pointing to some code as example and then I'll give my suggestions. For example, let's take a look on https://git.fedorahosted.org/cgit/virt-viewer.git/tree/src/virt-viewer.c#n4… In this function, the first thing done is to get the type of the graphic device (SPICE or VNC) and here is the first problem. There is no straightforward way for doing this on libvirt-gconfig (or is there?). Seems easier to continue getting the type using libxml and then use the specific spice/vnc functions for getting the properties. And here is the second problem, because I'll always need to have an if/else statement for getting the properties. Something like: if (g_str_equal(type, "vnc")) port = gvir_config_domain_graphics_vnc_get_port(domain); else if (g_str_equal(type, "spice")) port = gvir_config_domain_graphics_spice_get_port(domain); This kind of usage makes me think that libvirt-gconfig is missing some abstraction class, parent of GVirConfigDomainGraphics{Spice,Vnc,...) which could provide virtual functions like: gtype = gvir_config_domain_graphics_get_gtype(domain); port = gvir_config_domain_graphics_get_port(domain); Thinking a bit about it and taking a look in the GVirConfigDomainGraphics code, is possible to see a possibility for 2 new classes: GVirConfigDomainGraphicsLocal and GVirConfigDomainGraphicsRemote. Then we could have something like: GVirtConfigDomainGraphics |_ | GVirtConfigDomainGraphicsLocal | |_ | | GVirtConfigDomainGraphicsLocalDesktop | |_ | GVirtConfigDomainGraphicsLocalSdl |_ GVirtConfigDomainGraphicsRemote |_ | GVirtConfigDomainGraphicsRemoteSpice |_ | GVirtConfigDomainGraphicsRemoteVnc |_ GVirtConfigDomainGraphicsRemoteRdp I do know that Local and Remote are not exactly accurate names, but is the best that I could come up with. So, would be acceptable to introduce these two new classes and then have the specific graphics classes inheriting from those? Does this make sense for you, people? I'm more than happy in provide the code for this, but not before we discuss and set a decision about the approach. :-) I'm looking forward for some feedback. -- Fabiano Fidêncio

3 2

[libvirt] [PATCH v5 0/10] add close callback for drivers with persistent connection
by Nikolay Shirokovskiy 01 Mar '16

01 Mar '16

Currently close callback API can only inform us of closing the connection between remote driver and daemon. But what if a driver running in the daemon itself can have another persistent connection? In this case we want to be informed of that connection changes state too. This patch series extends meaning of current close callback API so that now it notifies of closing of any internal persistent connection. The overall approach is to move close callback support to drivers. Changes from v4: ================ 1. New patch "remote: factor out feature checks on connection open" to get rid of code dups. 2. "daemon: add connection close rpc" now checks if peer supports rpc for close callbacks. If it is not then we handle only disconnections to peer as before. Changes from v3: ================ Add patch [3] "close callback: make unregister clean after connect close event." Make register/unregister methods of connection close callback object return void. This solves the problem of patch [8] "daemon: add connection close rpc" ([7] in previous version) of consistent unregistering. All checks are moved outside of the methods. I hesitate whether to add or not means that track connection close callback object consinstency and finally decided to add (checks and warnings inside methods). The reason is that without these checks we get memory leaks which are rather difficult to find out. Unfortunately this change touch a number of patches as the first change is done in the first patch of the series. Changes from v2: ================ Split patches further to make it more comprehensible. Nikolay Shirokovskiy (10): factor out virConnectCloseCallbackDataPtr methods virConnectCloseCallbackData: fix connection object refcount close callback: make unregister clean after connect close event virConnectCloseCallbackData: factor out callback disarming close callback API: remove unnecessary locks virConnectCloseCallbackDataDispose: remove unnecessary locks close callback: move it to driver remote: factor out feature checks on connection open daemon: add connection close rpc vz: implement connection close notification daemon/libvirtd.h | 1 + daemon/remote.c | 85 ++++++++++++++++++++++ src/datatypes.c | 118 +++++++++++++++++++++++------- src/datatypes.h | 16 ++++- src/driver-hypervisor.h | 12 ++++ src/libvirt-host.c | 46 ++---------- src/libvirt_internal.h | 5 ++ src/remote/remote_driver.c | 167 ++++++++++++++++++++++++++++++++----------- src/remote/remote_protocol.x | 24 ++++++- src/remote_protocol-structs | 6 ++ src/vz/vz_driver.c | 59 +++++++++++++++ src/vz/vz_sdk.c | 4 ++ src/vz/vz_utils.h | 3 + 13 files changed, 433 insertions(+), 113 deletions(-) -- 1.8.3.1

2 23