- Devel - libvirt List Archives

[libvirt] [PATCH 0/7] Couple of -Os fixes
by Michal Privoznik 03 Mar '16

03 Mar '16

So while trying to bring down the size of my nss module, one of the things I've tried was compiling with -Os instead of -O3. Interesting errors pop up. Here are the fixes. If you think I should squash some patches together, I will gladly do that. Michal Privoznik (7): virCommandAddEnv: Drop inline virDomainNumatuneNodeSpecified: Drop inline virDomainChrRemove: Initialize @ret vbox: Initialize @rc qemuDomainBlockCommit: Initialize @baseSource virNetworkDefForwardIf: drop inline virStorageBackendLogicalMatchPoolSource: Initialize @thisSource src/conf/domain_conf.c | 2 +- src/conf/network_conf.c | 8 ++++++++ src/conf/network_conf.h | 8 +------- src/conf/numa_conf.c | 2 +- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 2 +- src/storage/storage_backend_logical.c | 2 +- src/util/vircommand.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_tmpl.c | 2 +- 10 files changed, 17 insertions(+), 14 deletions(-) -- 2.4.10

2 9

[libvirt] [PATCH] daemon: fixup refcounting in close callback handling
by Nikolay Shirokovskiy 03 Mar '16

03 Mar '16

remoteDispatchConnectCloseCallbackRegister introduced in f484310add53ebdc26a6fdcb88bc398750325b7e has problems. It refcounts network client object and in case of NOOP driver operations for close callback registering/unregistering (any driveres besides vz) nobody will unref it later. As a result client connection will not be disposed and driver connection will not be closed. The fix is easy. We don't need to refcount at all. We don't get dangling pointer because in remoteClientFreeFunc which is called upon disposing this network client object we unregistering close callback. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- daemon/remote.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 04d8ada..17783fa 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -3382,11 +3382,9 @@ remoteDispatchConnectCloseCallbackRegister(virNetServerPtr server ATTRIBUTE_UNUS goto cleanup; } - // on behalf of close callback - virObjectRef(client); if (virConnectRegisterCloseCallback(priv->conn, remoteRelayConnectionClosedEvent, - client, virObjectFreeCallback) < 0) + client, NULL) < 0) goto cleanup; priv->closeRegistered = true; -- 1.8.3.1

2 1

[libvirt] [PATCH] Reject migration with both --live and --offline when migration requested from other clients/API.
by Nitesh Konkar 03 Mar '16

03 Mar '16

--- src/libvirt-domain.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9491845..6a5034e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3616,6 +3616,13 @@ virDomainMigrate(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -3840,6 +3847,13 @@ virDomainMigrate2(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -4014,6 +4028,13 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer " -- 1.8.3.1

2 1

[libvirt] [PATCH v3] This patch gives an error when migration is attempted with both --live and --offline options.
by Nitesh Konkar 03 Mar '16

03 Mar '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 43c8436..b9f678f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9838,6 +9838,8 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) bool live_flag = false; virshCtrlData data = { .dconn = NULL }; + VSH_EXCLUSIVE_OPTIONS("live", "offline"); + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 1.8.3.1

3 3

[libvirt] [PATCH] util: Cleanup error path for virPolkitAgentCreate
by John Ferlan 02 Mar '16

02 Mar '16

More fallout from changing to using virPolkitAgent and handling error paths. Needed to clear the 'cmd' once stored and of course add the virCommandFree(cmd) in the error: label. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Found by coverity... Pushed as trivial... src/util/virpolkit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 44f2328..2038744 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -182,6 +182,7 @@ virPolkitAgentCreate(void) if (VIR_ALLOC(agent) < 0) goto error; agent->cmd = cmd; + cmd = NULL; virCommandAddArgFormat(cmd, "%lld", (long long int) getpid()); virCommandAddArg(cmd, "--notify-fd"); @@ -206,6 +207,7 @@ virPolkitAgentCreate(void) VIR_FORCE_CLOSE(pipe_fd[0]); VIR_FORCE_CLOSE(pipe_fd[1]); virPolkitAgentDestroy(agent); + virCommandFree(cmd); return NULL; } -- 2.5.0

1 0

[libvirt] [PATCH] datatypes.c: Replace 'close' with 'closeData'
by Michal Privoznik 02 Mar '16

02 Mar '16

Older compilers fail to see that 'close' is not used a function rather than a variable and produce the following error: cc1: warnings being treated as errors ../../src/datatypes.c: In function 'virConnectCloseCallbackDataReset': ../../src/datatypes.c:149: error: declaration of 'close' shadows a global declaration [-Wshadow] Replace all the 'close' occurrences with 'closeData' to resolve this. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/datatypes.c | 72 ++++++++++++++++++++++++++++----------------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 163db39..696e8c0 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -145,16 +145,16 @@ virConnectDispose(void *obj) } -static -void virConnectCloseCallbackDataReset(virConnectCloseCallbackDataPtr close) +static void +virConnectCloseCallbackDataReset(virConnectCloseCallbackDataPtr closeData) { - if (close->freeCallback) - close->freeCallback(close->opaque); + if (closeData->freeCallback) + closeData->freeCallback(closeData->opaque); - close->freeCallback = NULL; - close->opaque = NULL; - virObjectUnref(close->conn); - close->conn = NULL; + closeData->freeCallback = NULL; + closeData->opaque = NULL; + virObjectUnref(closeData->conn); + closeData->conn = NULL; } /** @@ -178,77 +178,77 @@ virNewConnectCloseCallbackData(void) return virObjectLockableNew(virConnectCloseCallbackDataClass); } -void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr closeData, virConnectPtr conn, virConnectCloseFunc cb, void *opaque, virFreeCallback freecb) { - virObjectLock(close); + virObjectLock(closeData); - if (close->callback != NULL) { + if (closeData->callback != NULL) { VIR_WARN("Attempt to register callback on armed" - " close callback object %p", close); + " close callback object %p", closeData); goto cleanup; return; } - close->conn = conn; - virObjectRef(close->conn); - close->callback = cb; - close->opaque = opaque; - close->freeCallback = freecb; + closeData->conn = conn; + virObjectRef(closeData->conn); + closeData->callback = cb; + closeData->opaque = opaque; + closeData->freeCallback = freecb; cleanup: - virObjectUnlock(close); + virObjectUnlock(closeData); } -void virConnectCloseCallbackDataUnregister(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataUnregister(virConnectCloseCallbackDataPtr closeData, virConnectCloseFunc cb) { - virObjectLock(close); + virObjectLock(closeData); - if (close->callback != cb) { + if (closeData->callback != cb) { VIR_WARN("Attempt to unregister different callback on " - " close callback object %p", close); + " close callback object %p", closeData); goto cleanup; } - virConnectCloseCallbackDataReset(close); - close->callback = NULL; + virConnectCloseCallbackDataReset(closeData); + closeData->callback = NULL; cleanup: - virObjectUnlock(close); + virObjectUnlock(closeData); } -void virConnectCloseCallbackDataCall(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataCall(virConnectCloseCallbackDataPtr closeData, int reason) { - virObjectLock(close); + virObjectLock(closeData); - if (!close->conn) + if (!closeData->conn) goto exit; VIR_DEBUG("Triggering connection close callback %p reason=%d, opaque=%p", - close->callback, reason, close->opaque); - close->callback(close->conn, reason, close->opaque); + closeData->callback, reason, closeData->opaque); + closeData->callback(closeData->conn, reason, closeData->opaque); - virConnectCloseCallbackDataReset(close); + virConnectCloseCallbackDataReset(closeData); exit: - virObjectUnlock(close); + virObjectUnlock(closeData); } virConnectCloseFunc -virConnectCloseCallbackDataGetCallback(virConnectCloseCallbackDataPtr close) +virConnectCloseCallbackDataGetCallback(virConnectCloseCallbackDataPtr closeData) { virConnectCloseFunc cb; - virObjectLock(close); - cb = close->callback; - virObjectUnlock(close); + virObjectLock(closeData); + cb = closeData->callback; + virObjectUnlock(closeData); return cb; } -- 2.4.10

1 1

[libvirt] after update to libvirt >= 1.2.9.3 no connection to libvirtd (time out) - bug 1308736
by Florian Hubold 02 Mar '16

02 Mar '16

Hi all, I've reported https://bugzilla.redhat.com/show_bug.cgi?id=1308736 two weeks ago, including the results of a git bisect. It would be greatly appreciated if someone could take a look, otherwise we can't push an update for CVE-2015-5313 for our stable distribution. Kind regards and thanks in advance

1 0

[libvirt] [PATCH] util: Fix missing initializer for agent
by John Ferlan 02 Mar '16

02 Mar '16

In virPolkitAgentCreate neglected to initialize agent to NULL. If there was an error in the pipe, then we jump to error and would have an issue. Found by coverity. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing as trivial src/util/virpolkit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3d2be61..44f2328 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -166,7 +166,7 @@ virPolkitAgentDestroy(virPolkitAgentPtr agent) virPolkitAgentPtr virPolkitAgentCreate(void) { - virPolkitAgentPtr agent; + virPolkitAgentPtr agent = NULL; virCommandPtr cmd = virCommandNewArgList(PKTTYAGENT, "--process", NULL); int pipe_fd[2] = {-1, -1}; struct pollfd pollfd; -- 2.5.0

1 0

[libvirt] Libvirt accepted to GSoC
by Michal Privoznik 01 Mar '16

01 Mar '16

Dear community, let me announce great news: Libvirt applied for this year's Google Summer of Code and got accepted [1]! You may recall that in previous years we created a joint organisation with QEMU/KVM folks and participated that way. However, since the number of libvirt students was growing and usually exceeded number of QEMU or KVM students combined it started to become more and more obvious that libvirt should no longer misuse hospitality of QEMU/KVM volunteers and try on its own. And it worked. In addition, QEMU/KVM organisation has been accepted too - join me in congratulating them and saying big thank you for all of the work that they have done for us in those previous years! The idea of splitting has been discussed here too [2]. What to do next? You can still propose ideas, and ideally add them to the list [3]. Or if you don't feel confident enough, drop me an e-mail and I'll take care of that. It's until 14th March that students are able to start filling in their proposals. And this is where this year differs from the previous ones - the deadline for proposals is 25th March. Without proposal no student can be accepted to the program. So you may help by spreading the word too. Happy coding! Michal 1: https://summerofcode.withgoogle.com/organizations/5982501017223168/ 2: https://www.redhat.com/archives/libvir-list/2016-January/msg01076.html 3: http://wiki.libvirt.org/page/Google_Summer_of_Code_2016

1 0

[libvirt] [PATCH] Libvirt: Add missing default value for config option max_queued_clients
by Jason J. Herne 01 Mar '16

01 Mar '16

Commit 1199edb1d4e3 added config option max_queued_clients and documented the default value as 1000 but never actually set that value. This patch sets the default value. This addresses an issue whereby the following error message is reported if too many migrations are started simultaneously: error: End of file while reading data: Ncat: Invalid argument.: Input/output error The problem is that too many ncat processes are spawned on the destination system. They all attempt to connect to the libvirt socket. Because the destination libvirtd cannot respond to the connect requests quickly enough we overrun the socket's pending connections queue. Signed-off-by: Jason J. Herne <jjherne(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- daemon/libvirtd-config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index c31c8b2..7a448f9 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -280,6 +280,7 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED) data->min_workers = 5; data->max_workers = 20; data->max_clients = 5000; + data->max_queued_clients = 1000; data->max_anonymous_clients = 20; data->prio_workers = 5; -- 1.9.1

2 1