- Devel - libvirt List Archives

[libvirt] Automatic Guest Resolution Adjustment not functional with GRsec guests
by bancfc＠openmailbox.org 10 Apr '16

10 Apr '16

A VM's QXL driver can no longer automatically adjust the screen resolution resize when running a GRsecurity kernel in the guest. The screen still responds to xrandr however but "scale display: always" in virt-manager doesn't work as it used to. What can be causing this?

2 2

[libvirt] [PATCH] qemu: fix build without gnutls installed
by Roman Bogorodskiy 10 Apr '16

10 Apr '16

Move including of gnutls/gnutls.h in qemu/qemu_domain.c under the "ifdef WITH_GNUTLS" check because otherwise it fails like this: CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo qemu/qemu_domain.c:50:10: fatal error: 'gnutls/gnutls.h' file not found in case if gnutls is not installed on the system. --- src/qemu/qemu_domain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 30dee4d..223154d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -47,9 +47,11 @@ #include "virprocess.h" #include "virrandom.h" #include "base64.h" -#include <gnutls/gnutls.h> -#if HAVE_GNUTLS_CRYPTO_H -# include <gnutls/crypto.h> +#ifdef WITH_GNUTLS +# include <gnutls/gnutls.h> +# if HAVE_GNUTLS_CRYPTO_H +# include <gnutls/crypto.h> +# endif #endif #include "logging/log_manager.h" #include "locking/domain_lock.h" -- 2.7.4

2 2

[libvirt] [PATCH] build: work around gcc 6.0 warnings
by Eric Blake 10 Apr '16

10 Apr '16

gcc 6.0 added an annoying warning: fdstream.c: In function 'virFDStreamWrite': fdstream.c:390:29: error: logical 'or' of equal expressions [-Werror=logical-op] if (errno == EAGAIN || errno == EWOULDBLOCK) { ^~ fdstream.c: In function 'virFDStreamRead': fdstream.c:440:29: error: logical 'or' of equal expressions [-Werror=logical-op] if (errno == EAGAIN || errno == EWOULDBLOCK) { ^~ This makes it impossible to build out-of-the-box on rawhide, and we aren't guaranteed that the gcc bug will be fixed in a timely manner: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69602 So work around it by further complicating the logic to thwart the compiler. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- This is a build-breaker fix for rawhide; but I'll wait for a day for any reasons why I should not push it during freeze. src/fdstream.c | 8 +++++--- src/rpc/virnetsshsession.c | 10 +++++++--- src/security/security_selinux.c | 5 +++-- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/fdstream.c b/src/fdstream.c index a85cf9d..1c34321 100644 --- a/src/fdstream.c +++ b/src/fdstream.c @@ -1,7 +1,7 @@ /* * fdstream.c: generic streams impl for file descriptors * - * Copyright (C) 2009-2012, 2014, 2016 Red Hat, Inc. + * Copyright (C) 2009-2012, 2014, 2016 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -387,7 +387,8 @@ static int virFDStreamWrite(virStreamPtr st, const char *bytes, size_t nbytes) retry: ret = write(fdst->fd, bytes, nbytes); if (ret < 0) { - if (errno == EAGAIN || errno == EWOULDBLOCK) { + if (errno == EAGAIN || + (EAGAIN != EWOULDBLOCK && errno == EWOULDBLOCK)) { ret = -2; } else if (errno == EINTR) { goto retry; @@ -437,7 +438,8 @@ static int virFDStreamRead(virStreamPtr st, char *bytes, size_t nbytes) retry: ret = read(fdst->fd, bytes, nbytes); if (ret < 0) { - if (errno == EAGAIN || errno == EWOULDBLOCK) { + if (errno == EAGAIN || + (EAGAIN != EWOULDBLOCK && errno == EWOULDBLOCK)) { ret = -2; } else if (errno == EINTR) { goto retry; diff --git a/src/rpc/virnetsshsession.c b/src/rpc/virnetsshsession.c index 406a831..d7d1c1a 100644 --- a/src/rpc/virnetsshsession.c +++ b/src/rpc/virnetsshsession.c @@ -1,7 +1,7 @@ /* * virnetsshsession.c: ssh network transport provider based on libssh2 * - * Copyright (C) 2012-2013 Red Hat, Inc. + * Copyright (C) 2012-2013, 2016 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -546,7 +546,9 @@ virNetSSHAuthenticateAgent(virNetSSHSessionPtr sess, return 0; /* key accepted */ if (ret != LIBSSH2_ERROR_AUTHENTICATION_FAILED && - ret != LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED && + (LIBSSH2_ERROR_AUTHENTICATION_FAILED != + LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED && + ret != LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED) && ret != LIBSSH2_ERROR_PUBLICKEY_UNVERIFIED) { libssh2_session_last_error(sess->session, &errmsg, NULL, 0); virReportError(VIR_ERR_AUTH_FAILED, @@ -674,7 +676,9 @@ virNetSSHAuthenticatePrivkey(virNetSSHSessionPtr sess, priv->filename, errmsg); if (ret == LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED || - ret == LIBSSH2_ERROR_AUTHENTICATION_FAILED) + (LIBSSH2_ERROR_PUBLICKEY_UNRECOGNIZED != + LIBSSH2_ERROR_AUTHENTICATION_FAILED && + ret == LIBSSH2_ERROR_AUTHENTICATION_FAILED)) return 1; else return -1; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 26d95d1..25f0bdf 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2008-2014 Red Hat, Inc. + * Copyright (C) 2008-2014, 2016 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -911,7 +911,8 @@ virSecuritySELinuxSetFileconHelper(const char *path, char *tcon, * hopefully sets one of the necessary SELinux virt_use_{nfs,usb,pci} * boolean tunables to allow it ... */ - if (setfilecon_errno != EOPNOTSUPP && setfilecon_errno != ENOTSUP && + if (setfilecon_errno != EOPNOTSUPP && + (EOPNOTSUPP != ENOTSUP && setfilecon_errno != ENOTSUP) && setfilecon_errno != EROFS) { virReportSystemError(setfilecon_errno, _("unable to set security context '%s' on '%s'"), -- 2.5.0

8 12

[libvirt] [PATCH] nss: properly include syms files to dist
by Roman Bogorodskiy 09 Apr '16

09 Apr '16

Explicitly add Linux and BSD syms files for nss to EXTRA_DIST instead of using the LIBVIRT_NSS_SYMBOL_FILE variable, because its value will point to either Linux or BSD syms file, but we need to ship both. --- tools/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 6005b8b..9cd62ae 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -473,8 +473,9 @@ lib_LTLIBRARIES = \ endif WITH_NSS -EXTRA_DIST += $(LIBVIRT_NSS_SYMBOL_FILE) \ - $(LIBVIRT_NSS_SOURCES) +EXTRA_DIST += $(LIBVIRT_NSS_SOURCES) \ + $(srcdir)/nss/libvirt_nss.syms \ + $(srcdir)/nss/libvirt_nss_bsd.syms clean-local: -rm -rf wireshark/src/libvirt -- 2.7.4

2 2

[libvirt] [PATCH] nss: fix typo in configure help string
by Roman Bogorodskiy 09 Apr '16

09 Apr '16

Servie -> Service Pushed as trivial. --- m4/virt-nss.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 3d6e8f4..bf5c416 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -20,7 +20,7 @@ dnl AC_DEFUN([LIBVIRT_CHECK_NSS],[ AC_ARG_WITH([nss-plugin], [AS_HELP_STRING([--with-nss-plugin], - [enable Name Servie Switch plugin for resolving guest IP addresses])], + [enable Name Service Switch plugin for resolving guest IP addresses])], [], [with_nss_plugin=check]) bsd_nss=no -- 2.7.4

1 0

[libvirt] [PATCH v2] Add macro for handling exponential backoff loops.
by Richard W.M. Jones 08 Apr '16

08 Apr '16

Since v1: - Rename the macro VIR_TIME_WHILE_WITH_BACKOFF. - Split out the variable initialization into a separate function that the user must call explicitly. - The macro is now an atomic C statement. An interesting observation about the qemu monitor socket: In some cases it appears almost instantaneously. In other runs it appears after 32-64ms. This latter case is what I expect because qemu startup takes ~50ms on my laptop. There seems to be no reason that I can discern for the difference between the runs. I've not observed the socket appearing anywhere in the middle, only at these two distinct time delays. Rich.

2 3

[libvirt] [PATCH] docs: Remove unused div.body CSS rule
by Andrea Bolognani 08 Apr '16

08 Apr '16

The 'body' CSS class is not used anywhere in the HTML files, so we can get rid of the definition as well. --- docs/generic.css | 5 ----- 1 file changed, 5 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index c0c6215..4f98b26 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -11,11 +11,6 @@ p:first-line { margin-right: 1em; } -div.body p:first-letter { - font-size: 1.2em; - font-weight: bold; -} - p, ul, ol, dl { padding: 0px; margin: 0px; -- 2.5.5

2 2

[libvirt] [PATCH 0/2] FreeBSD build fixes
by Andrea Bolognani 08 Apr '16

08 Apr '16

Applying these fixes building on FreeBSD, at least on my local builder (10.3-RELEASE). Cheers. Andrea Bolognani (2): configure: Move check for <gnutls/crypto.h> netdev: Use the correct pointer type for virSocketAddrFormat() configure.ac | 10 +++++----- src/util/virnetdev.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.5.5

2 4

[libvirt] [PATCH] util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL
by Peter Krempa 08 Apr '16

08 Apr '16

VIR_SOCKET_ADDR_VALID dereferences the pointer, thus if we pass NULL into virNetDevSetIPAddress it crashes. Regression introduced by b3d069872ce53eb. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325120 --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 712c3bc..0d030a3 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1129,7 +1129,7 @@ int virNetDevSetIPAddress(const char *ifname, unsigned int recvbuflen; /* The caller needs to provide a correct address */ - if (VIR_SOCKET_ADDR_FAMILY(addr) == AF_INET && !VIR_SOCKET_ADDR_VALID(peer)) { + if (VIR_SOCKET_ADDR_FAMILY(addr) == AF_INET && peer && !VIR_SOCKET_ADDR_VALID(peer)) { /* compute a broadcast address if this is IPv4 */ if (VIR_ALLOC(broadcast) < 0) return -1; -- 2.8.0

3 4

[libvirt] [PATCH v3 00/11] Introduce worker tuning APIs
by Erik Skultety 08 Apr '16

08 Apr '16

since v2: - all getters are now protected by threadpool mutex to prevent torn reads in concurrent execution - some checks in adminDispatchServerGetThreadpoolParameters were redundant, thus were optimizes out - fixed memory leak in adminDispatchServerGetThreadpoolParameters when allocating a newlist although typed params serialization already does that - fixed some cosmetic issues like exporting a function prototype one patch earlier than it should actually be introduced - a mistake that got there by interactive rebase Erik Skultety (11): po: Fix record ordering in POTFILES.in libvirt-host: Move virTypedParam* to libvirt-common admin: Enable usage of typed parameters util: Refactor thread creation by introducing virThreadPoolExpand util: Report system error when virThreadCreateFull fails util: Use a mutex when retrieving threadpool data util: Add more getters to threadpool parameters admin: Prepare admin protocol for future worker related procedures admin: Introduce virAdmServerGethreadPoolParameters admin: Introduce virAdmServerSetThreadPoolParameters virt-admin: Introduce srv-workertune command cfg.mk | 2 +- daemon/admin.c | 88 +++++++++++++ daemon/admin_server.c | 110 +++++++++++++++++ daemon/admin_server.h | 11 ++ include/libvirt/libvirt-admin.h | 71 +++++++++++ include/libvirt/libvirt-common.h.in | 185 ++++++++++++++++++++++++++++ include/libvirt/libvirt-host.h | 186 ---------------------------- po/POTFILES.in | 4 +- src/admin/admin_protocol.x | 54 +++++++- src/admin/admin_remote.c | 77 ++++++++++++ src/admin_protocol-structs | 45 +++++++ src/libvirt-admin.c | 83 +++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 2 + src/libvirt_private.syms | 4 + src/rpc/virnetserver.c | 37 ++++++ src/rpc/virnetserver.h | 13 ++ src/util/virthreadpool.c | 238 +++++++++++++++++++++++++----------- src/util/virthreadpool.h | 8 ++ tools/virt-admin.c | 132 ++++++++++++++++++++ 20 files changed, 1096 insertions(+), 257 deletions(-) -- 2.4.11

1 12