- Devel - libvirt List Archives

[libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter
by Nikolay Shirokovskiy 16 Mar '16

16 Mar '16

Usecase: 1. define domain with xml A where addresses are not set 2. migrate with '--xml A' You get ABI incompatibility because we comprare xmls with addresses set and not. This patch assign addresses in parameter xml so the comprasion is fair. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_migration.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1443d96..7cceaa1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2992,6 +2992,7 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, virDomainDefPtr def = NULL; qemuDomainObjPrivatePtr priv = vm->privateData; virCapsPtr caps = NULL; + virQEMUCapsPtr qemuCaps = NULL; unsigned int cookieFlags = QEMU_MIGRATION_COOKIE_LOCKSTATE; VIR_DEBUG("driver=%p, vm=%p, xmlin=%s, dname=%s," @@ -3105,6 +3106,13 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto cleanup; + if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, + def->emulator))) + goto cleanup; + + if (qemuDomainAssignAddresses(def, qemuCaps, NULL) < 0) + goto cleanup; + if (!qemuDomainDefCheckABIStability(driver, vm->def, def)) goto cleanup; @@ -3117,6 +3125,7 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, qemuMigrationCookieFree(mig); virObjectUnref(caps); virDomainDefFree(def); + virObjectUnref(qemuCaps); return rv; } -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu: Don't access uninitialized memory
by Martin Kletzander 16 Mar '16

16 Mar '16

In qemuConnectDomainXMLToNative() we set up the monitor, but we never memset() it to zeros. Thanks to the introduction of the logfile parameter of chardevs (and the logfile member of the struct), we started checking whether that's non-NULL and that exposed this old error. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a0d6596aef7b..e868b9f899e7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6950,7 +6950,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn, { virQEMUDriverPtr driver = conn->privateData; virDomainDefPtr def = NULL; - virDomainChrSourceDef monConfig; + virDomainChrSourceDef monConfig = {0}; virQEMUCapsPtr qemuCaps = NULL; bool monitor_json = false; virCommandPtr cmd = NULL; -- 2.7.3

2 2

[libvirt] [PATCH 0/3] Cosmetic changes to SPICE QEMU commandline
by Christophe Fergeau 16 Mar '16

16 Mar '16

Hey, I've been trying out the recently adding virgl support, which does not need any TCP port/address to be set (it's directly opening a local unix fd). While looking at QEMU command line in configs such as <graphics type="spice" autoport="no"/>, I've noticed that the QEMU command line gets some 'useless' arguments such as -spice port=0 or -spice addr=127.0.0.1 (without a port defined). This series changes the spice command line generation so that we don't add these arguments when not needed. Christophe

2 6

[libvirt] [PATCH v5 0/2] notify about reverting to a snapshot
by Dmitry Andreev 16 Mar '16

16 Mar '16

The original idea of this patch-set was to notify API clients about changes in domain configuration on revert to a snapshot. But in the last review Cole noticed that updated configuration doesn't saved to a file and libvirtd reboot drops changes. So in the patch-set v5 configuration is saved and event is emitted for all cases when persistent domain configuration was updated from a snapshot. Dmitry Andreev (2): Introduce new VIR_DOMAIN_EVENT_DEFINED_FROM_SNAPSHOT sub-event qemuDomainRevertToSnapshot: save domain configuration examples/object-events/event-test.c | 2 ++ include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c | 9 +++++++++ tools/virsh-domain.c | 3 ++- 4 files changed, 14 insertions(+), 1 deletion(-) -- 1.8.3.1

2 5

[libvirt] [PATCH] qemu: Don't overwrite DomainSave errors
by Cole Robinson 15 Mar '16

15 Mar '16

These functions already report fine grained errors, there's no benefit to overwriting the error here. --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index edf39d9..36c8fb5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17632,8 +17632,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("Saving live XML config failed")); goto endjob; } @@ -17659,8 +17657,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, conf_disk->blkdeviotune = info; ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Write to config file failed")); goto endjob; } } -- 2.5.0

2 2

[libvirt] [PATCH] nodedev: Shorten match condition
by Martin Kletzander 15 Mar '16

15 Mar '16

Just a cleanup I stumbled upon in one of my older branches I did when browsing through some code and forgot to send it. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/node_device_conf.c | 41 +++++++++++++++-------------------------- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index c04739f90121..0c9c348e3793 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1798,37 +1798,26 @@ virNodeDeviceCapMatch(virNodeDeviceObjPtr devobj, return false; } -#define MATCH(FLAG) (flags & (FLAG)) +#define MATCH(FLAG) ((flags & (VIR_CONNECT_LIST_NODE_DEVICES_CAP_ ## FLAG)) && \ + virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_ ## FLAG)) static bool virNodeDeviceMatch(virNodeDeviceObjPtr devobj, unsigned int flags) { /* filter by cap type */ - if (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP)) { - if (!((MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SYSTEM) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SYSTEM)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_PCI_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_INTERFACE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_INTERFACE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_NET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_TARGET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_TARGET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_STORAGE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_STORAGE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_FC_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_VPORTS)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_GENERIC)))) + if (flags & VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP) { + if (!(MATCH(SYSTEM) || + MATCH(PCI_DEV) || + MATCH(USB_DEV) || + MATCH(USB_INTERFACE) || + MATCH(NET) || + MATCH(SCSI_HOST) || + MATCH(SCSI_TARGET) || + MATCH(SCSI) || + MATCH(STORAGE) || + MATCH(FC_HOST) || + MATCH(VPORTS) || + MATCH(SCSI_GENERIC))) return false; } -- 2.7.3

2 1

[libvirt] [PATCH] Report error when both live and offline flags are used for migration.
by Nitesh Konkar 15 Mar '16

15 Mar '16

--- src/libvirt-domain.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9491845..dc11945 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3617,6 +3617,15 @@ virDomainMigrate(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3841,6 +3850,15 @@ virDomainMigrate2(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -4014,6 +4032,15 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer " -- 1.8.3.1

2 4

[libvirt] [PATCH 0/2] qemu: Support for QXL heads
by Martin Kletzander 15 Mar '16

15 Mar '16

So this is an old, tiny series that was posted some time ago; actually a lot of time ago. I complained because of two things. First one being that there are no tests, so this series has them in. The second one was that this could break migration from old code since the parameter was not used before. So I coded up a migration flag, handled all the special cases and then started testing it. And while testing it, I've found out that QEMU doesn't care at all about this parameter being there and there is no point in keeping it super-stable, especially when it can be changed on the fly. So I removed all that code and ended up with tiny series very similar to previous attempts by various people. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 ++++ .../qemuxml2argv-video-qxl-heads.args | 28 +++++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 8 ++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 8 files changed, 146 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml -- 2.7.2

2 6

[libvirt] github and gitlab mirrors are far behind
by Henning Schild 14 Mar '16

14 Mar '16

Hey, as the title says the mirrors are pretty far behind, probably something is broken there. Henning

1 0

[libvirt] User Behavior Tracking defenses in VMs
by bancfc＠openmailbox.org 14 Mar '16

14 Mar '16

Intended for qemu-discuss /cc/ libvir-list, whonix-devel, tor-dev *** Hello. I work on WhonixOS an anonymity distro based on Tor. This feature request is related to the topics of privacy and anonymity. Its a complex topic and probably not in your area of focus but I think it has important implications because security and privacy are very much related in today's hostile computing environment. Virtualization is useful in presenting an identical environment and set of "hardware" for each user which goes a long way in creating an anonymity set of systems. That way a system attacker, advertisers and online trackers would not be able to fingerprint a user or their hardware. The problem: Tracking techniques have become more sophisticated with time. They advanced from simple cookies to browser/device fingerprinting (which Tor Browser focuses on defeating) to user behavior fingerprinting. The latter is about profiling how a user types on a keyboard or uses a mouse [2]. Keystroke dynamics is a super creepy way to track users based on how long they press keys (dwell time) and the time between key presses (gap time). This is extremely accurate at identifying individuals because of how unique these measurements are. Advertising networks (Google, Facebook...) that fingeprprint users on both the clearnet and Tor can deanonymize users. This technique is already actively used in the wild [6][7]. Potential Solutions: Since input devices are all emulated its a great opportunity to stop this profiling technique. * A security researcher designed a proof of concept plugin for Chrome browser that mitigates this. Implementing something like the PoC addon in [1] known as KeyBoardPrivacy. Some random delay in milliseconds in a 50 millisecond range for dwell and gap times for the emulated keyboards is enough to skew the values to render this attack useless while not affecting performance. * The changes made to Tor Borwser to make JS timers more coarse grained but constant (250ms for keyboard events) were not enough to stop keystroke dynamics fingerprinting because a malicious script can evict the cache and allow extrapolation of true timing events within 1-5ms accuracy .[3][5] Their goal is to instead add jitter to the timers [4]. A similar solution proposed in [4] can be implemented in all QEMU-KVM timers to mitigate both attacks. [1] https://paul.reviews/behavioral-profiling-the-password-you-cant-change/ [2] http://jcarlosnorte.com/security/2016/03/06/advanced-tor-browser-fingerprin… [3] https://www.lightbluetouchpaper.org/2015/07/30/double-bill-password-hashing… [4] https://trac.torproject.org/projects/tor/ticket/16110 [5] https://trac.torproject.org/projects/tor/ticket/1517 [6] http://scraping.pro/no-captcha-recaptcha-challenge/ [7] https://nakedsecurity.sophos.com/2013/11/01/facebook-to-silent-track-users-…

1 0