- Devel - libvirt List Archives

[libvirt] [RFC] extend USB controller 'model' to support xen pvusb
by Chun Yan Liu 06 Jun '16

06 Jun '16

Hi, List, Currently libxl supports pvusb type USB controller hotplug and in creation time, I'd like to add the support in libvirt libxl driver too. According to current USB controller schema, we need to extend 'model' to support xen PVUSB type. Since libxl support USB controller of version 1.1 and version 2.0, we may add two models: "pvusb1" (pvusb type, version 1.1) and "pvusb2" (pvusb type, version 2.0). Do you have any opinions on that? If it is agreed, I'll try to implement. Thanks, Chunyan

1 0

[libvirt] Release of libvirt-1.3.5
by Daniel Veillard 04 Jun '16

04 Jun '16

Things didn't go as planned, I got stuck in travels etc, so I didn't push rc2 as expected earlier and I could not do any release on Friday. So I broke the rule and pushed today without an rc2, that's exceptional, but there was no negative feedback on RC1 and I didn't want to freeze development any longer, so the tree is open. Signed tarball and rpms are available at the usual place: ftp://libvirt.org/libvirt/ I also made a python binding release but it is virtually identical to 1.3.4 This is a very large release with more than 500 commits ! There is clear user visible new features, and an lot of code (and spec!) cleanups. Nonetheless libvirt-1.3.5.tar.gz is 5 Megabytes bigger than libvirt-1.3.4.tar.gz, likely due to a large update to localizations ! As usual a fair amount of bug fixes are included: Features: - admin: Introduce virAdmClientGetInfo API (Erik Skultety) - Various improvement on bhyve driver (Roman Bogorodskiy, Fabian Freyer) - Various improvement on libxl driver (Jim Fehlig, Chunyan Liu) Documentation: - Refresh po files from zanata (Daniel P. Berrange) - cpu: Fix documentation of cpuGetModels (Jiri Denemark) - docs: fix <spice><gl enable> since version (Ján Tomko) - docs: formatdomain: document virtio-mmio device addresses (Cole Robinson) - schemas: Improve outdated comment (Christophe Fergeau) - docs: Fix disk "volume" description (John Ferlan) - docs: fix version number in vlan tagging documentation (Laine Stump) - tools: virt-host-validate: fix missing translation marker (Bjoern Walk) - docs: Reformat the Controllers description (John Ferlan) - docs: clarify disk iothread support (John Ferlan) - docs: align spelling of S390 (Boris Fiuczynski) Portability: - virDomainChrGetDomainPtrsInternal: Return an integer (Michal Privoznik) - virSocketAddrIsPrivate: Work on 32bits platforms (Michal Privoznik) - makefile: fix build on systems where gnutls is not in /usr/include (Pavel Hrdina) - util: fix build without GNUTLS (Mikhail Feoktistov) - tests: qemu: test <address type='pci'/> with aarch64 (Cole Robinson) - tests: Link virtestmock with probes (Michal Privoznik) - libvit.spec.in: Add missing BuildRequires against sheepdog (Daniel P. Berrange) - libvirt.spec.in: remove client only build option (Daniel P. Berrange) - uml: only build on Linux (Roman Bogorodskiy) - virNetServerClientNewPostExecRestart: Avoid align problems (Michal Privoznik) - build: fix 32-bit build of admin (Eric Blake) Bug Fixes: - Fix building with -Og (Martin Kletzander) - virPerfEventIsEnabled: Don't crash on shut off domains (Michal Privoznik) - virDomainFormatSchedDef: Avoid false positive NULL dereference (Michal Privoznik) - ppc64Compute: Avoid possible NULL dereference (Michal Privoznik) - network: restart dnsmasq after adding/removing txt and srv records (Laine Stump) - QXL: fix reloading of vram64 attribute (Pavel Hrdina) - esxStorageVolGetXMLDesc: Lookup SCSI lun properly (Michal Privoznik) - qemuMonitorTextGetAllBlockStatsInfo: Fix line validation (Michal Privoznik) - lxc: Fix virLXCDomainObjBeginJob position in lxcDomainSetMemoryParameters (Katerina Koukiou) - esx: do not store escaped password in esxVI_Context. (Dawid Zamirski) - qemu: Fix error message when PCI bridge has index <= bus (Andrea Bolognani) - daemon: cleanup state drivers in order reverse to init order (Nikolay Shirokovskiy) - esx: use newer virtualHW version for 5.1+ hosts (Dawid Zamirski) - esx: Add VMCI device for virtualHW >= 7 (Dawid Zamirski) - esx: use lsilogic adapter type in vol create. (Dawid Zamirski) - libxl: default to qemu driver for network disks (Jim Fehlig) - lxc: Fix lxcDomainDestroyFlags endjob processing (John Ferlan) - qemu: Remove unused persistentAddrs (John Ferlan) - xenconfig: xm: check for driver on disk format (Joao Martins) - nwfilter: fix lock order deadlock (Maxim Nestratov) - maint: fix syntax-check sc_prohibit_int_ijk exclude rule (Pavel Hrdina) - vz: add error code for case if vm is already stopped (Mikhail Feoktistov) - storage: do not clear vols before volume upload (Ján Tomko) - util: Fix error path for virPCIGetVirtualFunctions (John Ferlan) - tests: Add forgotten backslash (Michal Privoznik) - qemu: bulk stats: Don't access possibly blocked storage (Peter Krempa) - qemu_cgroup: allow access to /dev/dri for virtio-vga (Ján Tomko) - Revert "qemu_hotplug: fix checking graphics ports" (Pavel Hrdina) - util: Remove disabling of autologin for iscsi-targets (Fritz Elfert) - xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl (Chunyan Liu) - libxl: Free migration cookie (John Ferlan) - qemu: command: Use -name guest= if available (Cole Robinson) - qemu: command: escape commas in chardev socket path (Cole Robinson) - qemu: command: escape commas in VNC socket path (Cole Robinson) - qemu: command: escape commas in secret master path (Cole Robinson) - qemu: command: escape commas in VM name (Cole Robinson) - admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew (Erik Skultety) - cpuGetModels: Fix memory leak on error (Jiri Denemark) - libxl: don't attempt to probe a non-existent emulator (Jim Fehlig) - network: log error when <bandwidth> is requested for hostdev interfaces (Laine Stump) - Call per-device post-parse callback even on implicit video (Ján Tomko) - util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL (Erik Skultety) - storage: Fix virStorageBackendDiskDeleteVol for device mapper (John Ferlan) - storage: Fix algorithm generating path names for devmapper (John Ferlan) - storage: Need to clear pool prior to calling the refreshPool (John Ferlan) - storage: Fix regression cloning volume into a logical pool (John Ferlan) - conf: log error when incorrect PCI root controller is added to domain (Laine Stump) - conf: don't redefine virDomainCapsDeviceHostdev (Roman Bogorodskiy) - conf: Fix error path in virNodeDevPCICapabilityParseXML (John Ferlan) - util: polkit: Fix polkit agent startup (Peter Krempa) - qemu: domain: Don't treat unknown storage type as not having backing chain (Peter Krempa) - qemu: Reject invalid block copy targets for <disk device='lun'> (Peter Krempa) - lxc: Fix wrong error message on disk hotplug (Peter Krempa) - domain_conf: fix migration/managedsave with usb keyboard (Pavel Hrdina) - qemu: Refresh RTC adjustment on qemuProcessReconnect (Michal Privoznik) - qemu: fix error message for default panic device (Boris Fiuczynski) - fdstream: don't raise error on SIGPIPE if abort requested (Cole Robinson) - daemon: stream: Don't force error when client aborts (Cole Robinson) - daemon: stream: set stream->closed on removal (Cole Robinson) - daemon: stream: don't update events if stream->closed (Cole Robinson) - daemon: stream: Close stream on send failure (Cole Robinson) - fdstream: Raise explicit error when iohelper gets SIGPIPE (Cole Robinson) - nwfilter: Save config to disk if we generated a UUID (Cole Robinson) - nwfilter: Fix potential locking problems on ObjLoad failure (Cole Robinson) - network: Fix segfault on daemon reload (Cole Robinson) - send default USB controller in xml to destination during migration (Shivaprasad G Bhat) - conf: storage: pool: reject name containing '/' (Cole Robinson) - conf: network: reject name containing '/' (Cole Robinson) - conf: domain: reject name containing '/' (Cole Robinson) - qemu: hotplug: Fix possible memory leak of props (John Ferlan) - qemu: process: Fix failure semantics for perf events (Peter Krempa) - qemu: process: Refresh ejectable media tray state on VM start (Peter Krempa) - tools: Fix connect command (Martin Kletzander) Improvements: - Drop virPerfGetEventFd (Michal Privoznik) - virNetDevBridgeGet: Don't require users to virNetDevSetupControl (Michal Privoznik) - apibuild: Substitute only pure number tokens (Michal Privoznik) - build: use gnulib's unsetenv (Michal Privoznik) - Turn 1<<31 into 1U<<31 (Michal Privoznik) - docs: Teach apibuild to deal with (1U << 31) too (Michal Privoznik) - maint: update to latest gnulib (Eric Blake) - spec: Advertise nvram paths of official fedora edk2 builds (Cole Robinson) - maint: update to latest gnulib (Eric Blake) - esx: add pciBridge devices when SCSI is used (Dawid Zamirski) - conf: permit auto-assignment of controller indexes (Laine Stump) - conf: make virDomainControllerFindUnusedIndex() more generally usable (Laine Stump) - conf/qemu: make IS_USB2_CONTROLLER globally available (Laine Stump) - libxl: add .domainInterfaceAddresses (Chunyan Liu) - security: label the slic_table (Ján Tomko) - qemu: format SLIC ACPI table command line (Ján Tomko) - conf: add <acpi><table> to <os> (Ján Tomko) - qemucapstest: replace caps-1.6.50 with updated caps-1.7.0 (Pavel Hrdina) - qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetSchedulerParametersFlags (Peter Krempa) - qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetBlockIoTune (Peter Krempa) - qemu: Refactor qemuDomainGetSchedulerParametersFlags (Peter Krempa) - conf: Change virDomainCputune member 'shares' to unsigned long long (Peter Krempa) - qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainGetSchedulerParametersFlags (Peter Krempa) - qemu: Refactor qemuDomainGetBlkioParameters (Peter Krempa) - qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainGetBlkioParameters (Peter Krempa) - qemu: Remove virDomainLiveConfigHelperMethod from qemuDomainSetMemoryParameters (Peter Krempa) - qemu: Refactor typed params assignment in qemuDomainGetBlockIoTune (Peter Krempa) - qemu: Replace virDomainLiveConfigHelperMethod in qemuDomainGetBlockIoTune (Peter Krempa) - qemu: monitor: Remove 'supportMaxOptions' argument from qemuMonitorGetBlockIoThrottle (Peter Krempa) - qemu: driver: Allow disk update of startupPolicy/snapshot for all disks (Peter Krempa) - qemu: driver: Move around code to avoid need to rollback (Peter Krempa) - Call qemuDomainObjEndJob when qemuCaps is null during hotplug (Shivaprasad G Bhat) - Unref the cfg in qemuDomainAttachHostPCIDevice() (Shivaprasad G Bhat) - qemu: Remove dead code (John Ferlan) - conf: nodedev: Set PCI_PHYSICAL_FUNCTION flag more carefully (Andrea Bolognani) - pci: Fix virPCIGetPhysicalFunction()'s callers (Andrea Bolognani) - pci: Document virPCIGetPhysicalFunction() (Andrea Bolognani) - pci: Initialize return location in virPCIGetPhysicalFunction() (Andrea Bolognani) - qemu: hotplug: wait for the tray to eject only for drives with a tray (Peter Krempa) - qemu: hotplug: Fix error reported when cdrom tray is locked (Peter Krempa) - qemu: hotplug: Extract code for waiting for tray eject (Peter Krempa) - qemu: process: Fix and improve disk data extraction (Peter Krempa) - qemu: Move and rename qemuDomainCheckEjectableMedia to qemuProcessRefreshDisks (Peter Krempa) - qemu: Extract more information about qemu drives (Peter Krempa) - qemu: Move struct qemuDomainDiskInfo to qemu_domain.h (Peter Krempa) - lxc: support <interface type='ethernet'> (Laine Stump) - lxc: completely rework reference counting (Katerina Koukiou) - lxc: use job functions in lxcDomainLxcOpenNamespace & lxcDomainSendProcessSignal (Katerina Koukiou) - qemucapstest: update caps for qemu-2.6.0 (Pavel Hrdina) - qemucapstest: update caps for qemu-2.5.0 (Pavel Hrdina) - qemucapstest: update caps for qemu-2.4.0 (Pavel Hrdina) - qemucapstest: update caps for qemu-2.1.1 (Pavel Hrdina) - qemucapstest: update caps for qemu-1.6.0 (Pavel Hrdina) - qemucapstest: update caps for qemu-1.5.3 (Pavel Hrdina) - qemucapstest: update caps for qemu-1.4.2 (Pavel Hrdina) - qemucapstest: update caps for qemu-1.3.1 (Pavel Hrdina) - qemucapstest: update caps for qemu-1.2.2 (Pavel Hrdina) - qemuxml2argvtest: skip test that depends on gnutls_cipher_encrypt() (Pavel Hrdina) - storage: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - nwfilter: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - libxl: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - bhyve: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - qemu: simplify addition of USB controller in qemuParseCommandLine (Laine Stump) - Deprecate QEMU_CAPS_PCIDEVICE (Ján Tomko) - Deprecate QEMU_CAPS_DEVICE (Ján Tomko) - Deprecate QEMU_CAPS_DRIVE_READONLY (Ján Tomko) - qemu: always assume QEMU_CAPS_DRIVE_READONLY (Ján Tomko) - tests: always assume QEMU_CAPS_DRIVE_READONLY (Ján Tomko) - tests: remove <readonly/> from IDE disks (Ján Tomko) - tests: remove disk-drive-fat test (Ján Tomko) - qemu: assume QEMU_CAPS_DEVICE almost everywhere (Ján Tomko) - qemu_command: assume QEMU_CAPS_DEVICE (Ján Tomko) - qemu: auto-assign addresses when <address type='pci'/> is specified (Laine Stump) - bhyve: auto-assign addresses when <address type='pci'/> is specified (Laine Stump) - conf: allow type='pci' addresses with no address attributes specified (Laine Stump) - conf: new functions to check if PCI address is wanted/present (Laine Stump) - conf: move virDomainDeviceInfo definition from domain_conf.h to device_conf.h (Laine Stump) - virtestmock: Mock stat() properly (Michal Privoznik) - tests: Drop VIR_MOCK_CALL_STAT (Michal Privoznik) - qemu: Utilize qemu secret objects for RBD auth/secret (John Ferlan) - tests: Allow multiple mock libraries (Peter Krempa) - qemu: Introduce qemuDomainSecretSetup (John Ferlan) - util: Introduce virCryptoGenerateRandom (John Ferlan) - util: Introduce encryption APIs (John Ferlan) - tests: Add mock for virRandomBytes (John Ferlan) - qemu: parse: Handle suffixes for -m memory (Nishith Shah) - qemu: parse: Use qemuParseCommandLineMem for -m memory (Nishith Shah) - qemu_command: refactor spice channel code (Pavel Hrdina) - qemu_process: separate graphics socket and address generation (Pavel Hrdina) - graphics: resolve address for listen type network in qemu_process (Pavel Hrdina) - qemu_command: move sasl parameter after port and addr definition (Pavel Hrdina) - domain_conf: introduce virDomainGraphicsListenDefFormatAddr (Pavel Hrdina) - graphics: rename gListen to glisten (Pavel Hrdina) - tests: cleanup vnc auto socket test (Pavel Hrdina) - qemu_domain: add a empty listen type address if we remove socket for VNC (Pavel Hrdina) - cpu: Rework CPU map loading (Jiri Denemark) - cpu_ppc64: Use array of models in CPU map (Jiri Denemark) - cpu_ppc64: Use array of vendors in CPU map (Jiri Denemark) - cpu_x86: Use array of features in CPU map (Jiri Denemark) - cpu_x86: Use array of vendors in CPU map (Jiri Denemark) - cpu_x86: Use array of models in CPU map (Jiri Denemark) - Do not mask QEMU_CAPS_DEVICE in qemuBuildDriveStr (Ján Tomko) - Introduce qemuDiskBusNeedsDeviceArg (Ján Tomko) - Assume QEMU_CAPS_DEVICE in qemuBuildDiskDriveCommandLine (Ján Tomko) - Remove DISK_BUS_XEN support from qemuBuildDiskDriveCommandLine (Ján Tomko) - qemu: always add -nodefaults (Ján Tomko) - qemu: process: Drop !QEMU_CAPS_DEVICE code (Cole Robinson) - Remove qemuProcessInitPCIAddresses with dependencies (Ján Tomko) - qemu: driver: Fix function header alignment of some functions (Peter Krempa) - conf: disk: Rename virDomainDiskDefValidate to virDomainDiskDefParseValidate (Peter Krempa) - util: Remove need for STATIC_ANALYSIS check (John Ferlan) - util: Adjust return for virPCIGetDeviceAddressFromSysfsLink (John Ferlan) - util: Remove need for ret in virPCIGetPhysicalFunction (John Ferlan) - tests: nodeinfotest: Remove virSaveLastError() usage (Cole Robinson) - More usage of virGetLastErrorMessage (Jovanka Gulicoska) - tests: More usage of virGetLastErrorMessage() (Jovanka Gulicoska) - lxc: use job functions in lxcDomain* functions that perform modify actions. (Katerina Koukiou) - lxc: use job functions in lxcDomain* functions that do query operations. (Katerina Koukiou) - lxc: add job functions in lxcDomainSetAutostart (Katerina Koukiou) - lxc: use job functions in lxcDomain{AttachDeviceFlags, DetachDeviceFlags, UpdateDeviceFlags} (Katerina Koukiou) - lxc: use job functions in lxcDomain{Suspend, Resume} (Katerina Koukiou) - lxc: use job functions in lxcDomainSetMemoryFlags (Katerina Koukiou) - lxc: use job functions in lxcDomain{CreateXMLWithFiles, CreateWithFiles} (Katerina Koukiou) - lxc: Add job support to lxc driver (Katerina Koukiou) - qemu: driver: Separate bulk stats worker for block devices (Peter Krempa) - qemu: driver: Remove unnecessary flag in qemuDomainGetStatsBlock (Peter Krempa) - perf: add support to perf event for MBM (Qiaowei Ren) - Separate virDomainDefParseBootOptions (Ján Tomko) - vz: cleanup: define vz format of uuids (Nikolay Shirokovskiy) - vz: implement p2p migration (Nikolay Shirokovskiy) - vz: implement managed migration (Nikolay Shirokovskiy) - vz: fix const correctness case (Nikolay Shirokovskiy) - vz: save session uuid on login (Nikolay Shirokovskiy) - virt-admin: Introduce commands srv-clients-info and srv-clients-set (Erik Skultety) - admin: Introduce virAdmServerSetClientLimits (Erik Skultety) - admin: Introduce virAdmServerGetClientLimits (Erik Skultety) - admin: Introduce some public constants related to server's client limits (Erik Skultety) - virnetserver: Introduce server's client-related limits getters (Erik Skultety) - qemu: address: Remove QEMU_CAPS_DEVICE usage (Cole Robinson) - tests: qemuargv2xmltest: Drop disk for s390 aes tests (Cole Robinson) - qemu: Call virDomainDefPostParse via CONFIG hotplug (Cole Robinson) - qemu: Assign device addresses in PostParse (Cole Robinson) - domain: Add virDomainDefAssignAddressesCallback (Cole Robinson) - vz: drop prlsdkDomainHasSnapshots (Nikolay Shirokovskiy) - vz: add domain snapshots functionality (Nikolay Shirokovskiy) - iscsi: Remove initiatoriqn from virISCSIScanTargets (John Ferlan) - iscsi: Add exit status checking for virISCSIGetSession (John Ferlan) - util: Add exitstatus parameter to virCommandRunRegex (John Ferlan) - tests: Try different usable GIC versions (Andrea Bolognani) - tests: Prepare to have different usable GIC versions (Andrea Bolognani) - qemu: Add virQEMUCapsSetGICCapabilities() (Andrea Bolognani) - qemu: Automatically choose usable GIC version (Andrea Bolognani) - qemu: Add virQEMUCapsSupportsGICVersion() (Andrea Bolognani) - Change return value of VIR_APPEND*INPLACE* to void (Jiri Denemark) - Remove virDomainRNGInsert (Jiri Denemark) - xlconfigtest: add test case for type=vif in xl format (Chunyan Liu) - extract XEN_CONFIG_FORMAT_XM/XL to xen_common.h (Chunyan Liu) - bhyve: implement virConnectIsSecure (Fabian Freyer) - bhyve: Implement virConnectIsEncrypted (Fabian Freyer) - spec: Remove %defattr usage (Cole Robinson) - Revert "vz: handle sourceless cdroms" (Maxim Nestratov) - qemu: hotplug: Report error if we hit tray status timeout (Cole Robinson) - admin: include: Rename argument dmn to conn in virAdmConnectListServers (Erik Skultety) - vz: make error path code idiomatic (Nikolay Shirokovskiy) - vz: fix template ct creation (Mikhail Feoktistov) - vz: fix error message for readonly fs (Nikolay Shirokovskiy) - vz: handle sourceless cdroms (Mikhail Feoktistov) - vz: fix vzCheckUnsupportedDisks format checks for cdroms (Nikolay Shirokovskiy) - vz: remove check for auto file format for disks (Nikolay Shirokovskiy) - domain_conf: cleanup virDomainGraphicsListenDefParseXML (Pavel Hrdina) - graphics: make address attribute for listen type='address' optional (Pavel Hrdina) - domain_conf: parse listen attribute while parsing listen elements (Pavel Hrdina) - graphics: don't parse listens if socket attribute is present (Pavel Hrdina) - conf: Allow all volume modes for disk type='lun' sources (Peter Krempa) - qemu: Drop QEMU_CAPS_VIRTIO_BLK_SG_IO (Andrea Bolognani) - qemu: Drop QEMU_CAPS_CPU_HOST (Andrea Bolognani) - qemu: Drop QEMU_CAPS_PCI_ROMBAR (Andrea Bolognani) - qemu: More qemu_monitor_json cleanups (John Ferlan) - bhyve: implement virConnectIsAlive (Fabian Freyer) - qemu: command: Add qemuBufferEscapeComma (Cole Robinson) - qemu: alias: Remove QEMU_CAPS_DEVICE (Cole Robinson) - cpu: Properly report errors when parsing CPU map XML (Jiri Denemark) - cpu_x86: Check vendor early (Jiri Denemark) - cpu_x86: Don't ignore parsing errors in x86ModelLoad (Jiri Denemark) - cpu_x86: Don't ignore parsing errors in x86FeatureLoad (Jiri Denemark) - cpu_x86: Don't ignore parsing errors in x86VendorLoad (Jiri Denemark) - cpu_x86: Simplify insertions into a linked list (Jiri Denemark) - cpu_x86: Remove comparisons to NULL (Jiri Denemark) - cpu_x86: Use for loop in x86Decode (Jiri Denemark) - cpu_x86: Rename cleanup labels (Jiri Denemark) - cpu_x86: Compare CPU candidates in a separate function (Jiri Denemark) - cpu_x86: Rename struct virCPUx86DataIterator (Jiri Denemark) - cpu_x86: Rename enum compare_result (Jiri Denemark) - cpu_x86: Rename struct x86_map (Jiri Denemark) - cpu_x86: Rename struct x86_model (Jiri Denemark) - cpu_x86: Rename struct x86_kvm_feature (Jiri Denemark) - cpu_x86: Rename struct x86_feature (Jiri Denemark) - cpu_x86: Rename struct x86_vendor (Jiri Denemark) - qemu: command: Ignore QEMU_CAPS_DEVICE when building drive alias (Cole Robinson) - cpu: Add support for clflushopt and tsc_adjust Intel features (Alexander Burluka) - secret: Alter virSecretGetSecretString (John Ferlan) - qemu: domain: Fix names for functions that clear security info (Peter Krempa) - util: string: Introduce helper to determine whether a byte buffer is printable (John Ferlan) - util: string: Introduce virStringEncodeBase64 (Peter Krempa) - secret: util: Refactor virSecretGetSecretString (Peter Krempa) - util: alloc: Introduce freeing helpers that clear the memory before freeing (Peter Krempa) - capabilities: Advertise cpuselection if -cpu host is usable (Jiri Denemark) - qemuaincapstest: Give better names to test data files (Jiri Denemark) - domaincapstest: Give better names to test data files (Jiri Denemark) - domaincapstest: Use arch strings (Jiri Denemark) - tests: Introduce check-file-access.pl (Michal Privoznik) - virtestmock: Print invalid file accesses into a file (Michal Privoznik) - tests: Introduce global mock library (Michal Privoznik) - virmock.h: Introduce VIR_MOCK_CALL_STAT (Michal Privoznik) - securityselinuxhelper: Adapt to virmock.h (Michal Privoznik) - nssmock: Adapt to virmock.h (Michal Privoznik) - vircgroupmock: Adapt to virmock.h (Michal Privoznik) - virpcimock: Adapt to virmock.h (Michal Privoznik) - qemu: remove ATTRIBUTE_UNUSED in connectGetType (Fabian Freyer) - bhyve: implement virConnectGetType (Fabian Freyer) - xlconfigtests: use qemu-xen in all test data files (Jim Fehlig) - virt-aa-helper: remove replace_string and use virStringReplace instead (Pavel Hrdina) - virfile: Introduce virFileRemoveLastComponent (Michal Privoznik) - leave out the default USB controller only on i440fx during migration (Shivaprasad G Bhat) - qemu: domain: Fix name of macro defining AES IV length (Peter Krempa) - qemu: Change from SecretIV or _IV to SecretAES or _AES (John Ferlan) - Fix tests to include video ram size (Ján Tomko) - Fill out default vram in DeviceDefPostParse (Ján Tomko) - Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse (Ján Tomko) - spec: Fix broken indentation reported by syntax-check (Erik Skultety) - libvirt.spec.in: remove all changelog entries (Daniel P. Berrange) - libvirt.spec.in: use explicit --with-xxx for all features (Daniel P. Berrange) - libvirt.spec.in: remove nss plugin conditional (Daniel P. Berrange) - libvirt.spec.in: remove libnl conditional (Daniel P. Berrange) - libvirt.spec.in: remove macvtap conditional (Daniel P. Berrange) - libvirt.spec.in: remove libpcap conditional (Daniel P. Berrange) - libvirt.spec.in: remove nwfilter driver conditional (Daniel P. Berrange) - libvirt.spec.in: remove nodedev conditional (Daniel P. Berrange) - libvirt.spec.in: remove most storage conditionals (Daniel P. Berrange) - libvirt.spec.in: remove network driver conditiaonl (Daniel P. Berrange) - libvirt.spec.in: remove interface driver conditional (Daniel P. Berrange) - libvirt.spec.in: remove selinux conditional (Daniel P. Berrange) - libvirt.spec.in: remove yajl conditional (Daniel P. Berrange) - libvirt.spec.in: remove polkit conditional (Daniel P. Berrange) - libvirt.spec.in: remove sasl conditionals (Daniel P. Berrange) - libvirt.spec.in: remove dtrace conditional (Daniel P. Berrange) - libvirt.spec.in: remove audit conditional (Daniel P. Berrange) - libvirt.spec.in: remove netcf conditional (Daniel P. Berrange) - libvirt.spec.in: remove udev conditional (Daniel P. Berrange) - libvirt.spec.in: remove capng conditional (Daniel P. Berrange) - libvirt.spec.in: remove apparmor conditional (Daniel P. Berrange) - libvirt.spec.in: remove hal conditional (Daniel P. Berrange) - libvirt.spec.in: remove avahi conditional (Daniel P. Berrange) - libvirt.spec.in: remove libvirtd conditional (Daniel P. Berrange) - libvirt.spec.in: remove conditional for driver modules (Daniel P. Berrange) - libvirt.spec.in: drop Fedora < 20 and RHEL < 6 (Daniel P. Berrange) - libvirt.spec.in: explicitly disable xenapi & vz drivers (Daniel P. Berrange) - headers: Remove unnecessary keyword extern from function declaration (Erik Skultety) - conf: make virDomainDefAddController() public (Laine Stump) - libxl: support migration stream V2 in migration (Jim Fehlig) - libxl: support Xen migration stream V2 in save/restore (Jim Fehlig) - libxl: switch to using libxl_domain_create_restore from v4.4 API (Jim Fehlig) - qemu: Add extra checks for secret destroy API's (John Ferlan) - util: set vlan tag for macvtap passthrough mode on SRIOV VFs (Laine Stump) - seclabeltest: Update to use VIRT_TEST_MAIN (Michal Privoznik) - virt-admin: Introduce client-disconnect command (Erik Skultety) - admin: Introduce virAdmClientClose API (Erik Skultety) - admin: Remove flags checking from virAdmConnectOpen public API (Erik Skultety) - admin: Remove flags checking from public API entry points (Erik Skultety) - qemu_hotplug: fix checking graphics ports (Pavel Hrdina) - qemu_process: merge graphics code into qemuProcessSetupGraphics (Pavel Hrdina) - graphics: generate fake ports also for tests (Pavel Hrdina) - qemu_process: separate graphics port reservation (Pavel Hrdina) - configure: split out UML driver checks (Roman Bogorodskiy) - admin: Clean up error path in adminServerListClients (John Ferlan) - Use virGetLastErrorMessage to avoid Coverity message (John Ferlan) - qemu: command: unconditionally allow accel3d='no' (Cole Robinson) - domaincaps: Report video modelType (Cole Robinson) - domaincaps: Report graphics type enum (Cole Robinson) - qemu: command: Remove unnecessary label in qemuCheckDiskConfig (Peter Krempa) - conf: Kill now unused virDomainDiskSourceIsBlockType (Peter Krempa) - qemu: command: Use more appropriate checking function for block devices (Peter Krempa) - qemu: Support <disk device='lun'> for iSCSI direct mapped volumes (Peter Krempa) - util: Replace virDomainDiskSourceIsBlockType with a new helper (Peter Krempa) - qemu_monitor_json: Follow refactor (Michal Privoznik) - virsh: blkdeviotune: accept human readable values for bytes (Nishith Shah) - genericxml2xml: add several graphics tests (Pavel Hrdina) - qemu_hotplug: cleanup error messages in qemuDomainChangeGraphics (Pavel Hrdina) - qemu_process: handle port allocation for VNC the same way as for Spice (Pavel Hrdina) - qemu_process: move listen code out of qemuProcessSetupGraphics (Pavel Hrdina) - graphics: use enums instead of int (Pavel Hrdina) - virCgroupValidateMachineGroup: Reflect change in CGroup struct naming (Michal Privoznik) - domaincapstest: Add tests for QEMU 2.6 (Jiri Denemark) - qemucapabilitiestest: Add tests for aarch64 and ppc64le (Jiri Denemark) - domaincapstest: Use default machine type (Jiri Denemark) - qemucapabilitiestest: Rename *.caps to *.xml (Jiri Denemark) - qemucapabilitiestest: Test all capabilities (Jiri Denemark) - qemucapabilitiestest: Reorder flags in caps files (Jiri Denemark) - qemucapabilitiestest: Reindent *.caps files (Jiri Denemark) - qemucapabilitiestest: Uses consistent names (Jiri Denemark) - qemu: Export caps cache APIs for tests (Jiri Denemark) - qemu: Separate formatting from saving into caps cache (Jiri Denemark) - qemucapabilitiestest: Prepare for testing non-x86_64 archs (Jiri Denemark) - tests: Refactor domaincapstest (Jiri Denemark) - qemu: Introduce qemuDomainSecretIV (John Ferlan) - qemu: Separate network URI command building code (John Ferlan) - qemu: Move qemuDomainSecretDestroy to qemuProcessLaunch (John Ferlan) - qemu: Move qemuDomainSecretPrepare to qemuProcessPrepareDomain (John Ferlan) - qemu: Split out the master key create and write (John Ferlan) - qemu: Adjust names of qemuDomainSecretInfoType enums (John Ferlan) - rpc: use virNetMessageClearPayload in client (Cole Robinson) - rpc: Clear more in virNetMessageClearPayload (Cole Robinson) - rpc: Add virNetMessageClearPayload (Cole Robinson) - virNetServerClientNewPostExecRestart: Drop useless typecasts (Michal Privoznik) - Add qemucapsprobe in .gitignore (Jiri Denemark) - tests: Add qemucapsprobe helper (Jiri Denemark) - virjson: Make pretty format more compact (Jiri Denemark) - qemu: Make qemuMonitorJSONIOProcessLine available for tests (Jiri Denemark) - qemu: Make virQEMUCapsNewForBinary usable from tests (Jiri Denemark) - tests: Decouple preload code from main() (Jiri Denemark) - tests: Create a shared library with qemu driver (Jiri Denemark) - bhyve: implement domainShutdown (Roman Bogorodskiy) - bhyve: drop virProcessKillPainfully() from destroy (Roman Bogorodskiy) - virsh: Pass the correct live/config xml to virshDomainDetachInterface. (Nitesh Konkar) - virsh: Introduce virshDomainDetachInterface function (Nitesh Konkar) - admin: Add a check to reject negative argument for number of typed params (Erik Skultety) - tools: virt-host-validate: HW virt support on s390 (Bjoern Walk) - tools: virt-host-validate: improve error handling (Bjoern Walk) - tools: virt-host-validate: fix CPU flag detection (Bjoern Walk) - qemu: Add 'iothread' to command line for supported controller (John Ferlan) - qemu: Use switch for qemuCheckIOThreads (John Ferlan) - conf: Add support for virtio-scsi iothreads (John Ferlan) - Pull latest translations from zanata (Daniel P. Berrange) - libvirt.spec: remove duplicate files from -docs package (Daniel P. Berrange) - virsh: volume: Add --bytes to 'vol-info' (Peter Krempa) - daemon: Add VIR_ERR_NO_SERVER and VIR_ERR_NO_CLIENT to daemonErrorLogFilter (Erik Skultety) - conf: Move virDomainControllerModelTypeToString (John Ferlan) - qemu: Add capability for virtio-scsi iothreads (John Ferlan) - spec: Rename %{init_scripts} -> %{with_init_script} (Andrea Bolognani) - spec: Type --with-init-script correctly (Andrea Bolognani) - configure: Remove nested conditionals in LIBVIRT_CHECK_INIT_SCRIPT (Andrea Bolognani) - configure: Change RHEL default from systemd+redhat to systemd (Andrea Bolognani) - maint: Ignore all .init, .service and .socket files (Andrea Bolognani) - virt-admin: Introduce command client-info (Erik Skultety) - admin: Introduce virAdmClientGetInfo API (Erik Skultety) - virnetserverclient: Add an internal method to retrieve client's identity (Erik Skultety) - virneserverclient: Introduce virNetServerClientHasSASLSession (Erik Skultety) - virnetsocket: Provide socket address format in a more standard form (Erik Skultety) - admin: include: Introduce some client's identity related typed params macros (Erik Skultety) - admin: Introduce virAdmServerLookupClient (Erik Skultety) - qemu_monitor_json: Follow our coding style (Michal Privoznik) - maint: Don't ignore libvirtd.pod any longer (Andrea Bolognani) - gitignore: ignore virt(log|lock)d.(service|socket) (Cole Robinson) - daemon: add option to read host uuid from /etc/machine-id (Nikolay Shirokovskiy) - util: factor out reading file into preallocated buffer (Nikolay Shirokovskiy) - qemu: support configuring usb3 controller port count (Cole Robinson) - qemu: caps: introduce QEMU_CAPS_NEC_USB_XHCI_PORTS (Cole Robinson) - qemu: parse: Use virControllerDefNew (Cole Robinson) - qemu_monitor_json: Drop redundant checks (Michal Privoznik) - qemuMonitorJSONQueryRxFilter: Validate qemu reply prior parsing it (Michal Privoznik) - Remove useless os.machine NULL check (Ján Tomko) - Introduce qemuDomainMachineIsVirt (Ján Tomko) - Rewrite the condition in qemuDomainAssignARMVirtioMMIOAddresses (Ján Tomko) - Remove useless variable in qemuDomainAssignAddresses (Ján Tomko) - Return void in qemuDomainAssignARMVirtioMMIOAddresses (Ján Tomko) - Invert condition in qemuDomainDefAddDefaultDevices (Ján Tomko) - Use qemuDomainMachineIs helpers when adding default devices (Ján Tomko) - qemu: Introduce qemuMonitorGetRTCTime (Michal Privoznik) - virt-admin: Introduce srv-clients-list command (Erik Skultety) - admin: Introduce listing clients (Erik Skultety) - rpc: virnetserverclient: Implement client connection transport retrieval (Erik Skultety) - include: admin: export connection transport constants (Erik Skultety) - rpc: virnetserver: Support retrieval of a list of clients (Erik Skultety) - rpc: gendispatch: Tune it to support client structure (Erik Skultety) - admin: Introduce virAdmClient client-side object (Erik Skultety) - rpc: virnetserverclient: Introduce new attribute conn_time to client (Erik Skultety) - rpc: virnetserverclient: Identify clients by an integer ID (Erik Skultety) - configure: Introduce LIBVIRT_{CHECK,RESULT}_INIT_SCRIPT (Andrea Bolognani) - configure: Add systemd detection to --with-init-script=check (Andrea Bolognani) - configure: Improve --with-init-script=check (Andrea Bolognani) - tests: add tests for panic device model s390 (Boris Fiuczynski) - qemu: add default panic device to S390 guests (Boris Fiuczynski) - qemu: add panic device support for S390 (Boris Fiuczynski) - qemu: merge S390 and S390X default device creation (Boris Fiuczynski) - rpc: protocol: Clarify VIR_NET_ERROR usage with streams (Cole Robinson) - fdstream: Report error with virProcessTranslateStatus (Cole Robinson) - fdstream: separate out virCommandPtr cleanup (Cole Robinson) - nwfilter: Push configFile building into LoadConfig (Cole Robinson) - conf: format runtime DAC seclabel, unless MIGRATABLE (Cole Robinson) - conf: Parse more of our nodedev XML (Martin Kletzander) - schemas: Update nodedev schema to match reality (Martin Kletzander) - Move capability formatting together (Martin Kletzander) - Change virDevicePCIAddress to virPCIDeviceAddress (Martin Kletzander) - qemu: hotplug: Adjust error path for attach hostdev scsi disk (John Ferlan) - qemu: hotplug: Adjust error path for attach virtio disk (John Ferlan) - qemu: hotplug: Adjust error path for attach scsi disk (John Ferlan) - qemu: Use qemuDomainSecretInfoPtr in qemuBuildNetworkDriveURI (John Ferlan) - qemu: Introduce qemuDomainSecretHostdevPrepare and Destroy (John Ferlan) - qemu: Introduce qemuDomainHostdevPrivatePtr (John Ferlan) - qemu: Introduce qemuDomainSecretPrepare and Destroy (John Ferlan) - qemu: Introduce qemuDomainSecretInfo (John Ferlan) - Adapt augeas profile to handle negative int values. (Cédric Bosdonnat) - qemu: monitor: Kill legacy PCI hotplug code (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachControllerDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachNetDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachHostPCIDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachControllerDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachVirtioDiskDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachHostPCIDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachNetDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachVirtioDiskDevice (Peter Krempa) - qemu: monitor: Kill legacy USB monitor code (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachHostUSBDevice (Peter Krempa) - qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachUSBMassStorageDevice (Peter Krempa) - qemu: remove default case from few typecasted enums (Peter Krempa) - qemu: process: Don't needlesly clear the perf events in qemuDomainPerfRestart (Peter Krempa) - util: perf: Adhere to coding style of error checks in qemuDomainSetPerfEvents (Peter Krempa) - util: perf: Adhere to coding style of error checks in virPerfEventEnable (Peter Krempa) - util: perf: Use 'error' label in virPerfCmtEnable (Peter Krempa) - qemu: perf: Don't ignore perf setup if allocation fails (Peter Krempa) - qemu: hotplug: Allow update of disk default snapshot location (Peter Krempa) - qemu: domain: Check few more fields for when changing disk source (Peter Krempa) - qemu: domain: Fix error message in qemuDomainDiskChangeSupported (Peter Krempa) - qemu: hotplug: Skip waiting for tray opening if qemu doesn't notify us (Peter Krempa) - virStream{Recv,Send}All: Increase client buffer (Michal Privoznik) - virnetclientstream: Process stream messages later (Michal Privoznik) - Revert "rpc: Fix slow volume download (virsh vol-download)" (Michal Privoznik) - Post-release version bump to 1.3.5 (John Ferlan) Cleanups: - Revert "qemu_cgroup: allow access to /dev/dri for virtio-vga" (Ján Tomko) Thanks everybody who helped with this release, be it by providing ideas bugs, patches, reviews, doc or localizations, hopefully I didn't mess it by rushing that release out ... Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

Re: [libvirt] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr
by Eduardo Habkost 03 Jun '16

03 Jun '16

(CCing libvirt folks) BTW: On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: [...] > > /* Special cases: */ > > if (!strcmp(name, "xlevel")) { > > numvalue = strtoul(val, &err, 0); > > if (!*val || *err) { > > error_setg(errp, "bad numerical value %s", val); > > return; > > } > > if (numvalue < 0x80000000) { > > error_report("xlevel value shall always be >= 0x80000000" > > ", fixup will be removed in future versions"); > > numvalue += 0x80000000; > > snprintf(num, sizeof(num), "%" PRIu32, numvalue); > > val = num; [...] > > } else if (!strcmp(name, "hv-spinlocks")) { > > const int min = 0xFFF; > > > > numvalue = strtoul(val, &err, 0); > > if (!*val || *err) { > > error_setg(errp, "bad numerical value %s", val); > > return; > > } > > if (numvalue < min) { > > error_report("hv-spinlocks value shall always be >= 0x%x" > > ", fixup will be removed in future versions", > > min); > > numvalue = min; > > } Those "fixup will be removed in future versions" warnings are present since QEMU 1.7. Assuming that libvirt never allowed those invalid values to be used in the configuration (did it?), I believe we can safely remove the hv-spinlocks and xlevel fixups in QEMU 2.7. The hv-spinlocks setter already rejects invalid values. We just need to make x86_cpu_realizefn() reject invalid xlevel values. -- Eduardo

4 8

[libvirt] [PATCH] Fix building with -Og
by Martin Kletzander 03 Jun '16

03 Jun '16

When building using -Og, gcc sees that some variables can be used uninitialized It can be debatable whether it is possible with our codeflow, but functions should be self-contained and initializations are always good. The return instead of goto is due to actualType being used in the cleanup. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/lxc/lxc_driver.c | 2 +- src/nwfilter/nwfilter_ebiptables_driver.c | 2 +- src/util/virbitmap.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 67f14fe766a5..f0948eae774e 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4275,7 +4275,7 @@ lxcDomainAttachDeviceNetLive(virConnectPtr conn, if (!priv->initpid) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("Cannot attach disk until init PID is known")); - goto cleanup; + return -1; } if (virLXCProcessValidateInterface(net) < 0) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 423d069e1b26..b7be2917e29e 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -1570,7 +1570,7 @@ iptablesCreateRuleInstanceStateCtrl(virFirewallPtr fw, const char *ifname, virNWFilterVarCombIterPtr vars) { - int rc; + int rc = 0; bool directionIn = false; char chainPrefix[2]; bool maySkipICMP, inout = false; diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 9283aef1735b..4ca59f9d6227 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -817,7 +817,7 @@ virBitmapLastSetBit(virBitmapPtr bitmap) ssize_t i; int unusedBits; ssize_t sz; - unsigned long bits; + unsigned long bits = 0; unusedBits = bitmap->map_len * VIR_BITMAP_BITS_PER_UNIT - bitmap->max_bit; -- 2.8.3

3 4

[libvirt] [PATCH 0/9] Add runnability info to query-cpu-definitions
by Eduardo Habkost 03 Jun '16

03 Jun '16

This series extends query-cpu-definitions to include two extra fields: "runnable", and "unavailable-features". This will return information based on the current machine and accelerator only. In the future we may extend these mechanisms to allow querying other machines and other accelerators without restarting QEMU, but it will require some reorganization of QEMU's main code. This series is based on my 'x86-next' branch, at: git://github.com/ehabkost/qemu.git x86-next Cc: David Hildenbrand <dahi(a)linux.vnet.ibm.com> Cc: Michael Mueller <mimu(a)linux.vnet.ibm.com> Cc: Christian Borntraeger <borntraeger(a)de.ibm.com> Cc: Cornelia Huck <cornelia.huck(a)de.ibm.com> Cc: Jiri Denemark <jdenemar(a)redhat.com> Cc: libvir-list(a)redhat.com Eduardo Habkost (9): target-i386: Move TCG initialization check to tcg_x86_init() target-i386: Move TCG initialization to realize time target-i386: Call cpu_exec_init() on realize target-i386: List CPU models using subclass list target-i386: Move warning code outside x86_cpu_filter_features() target-i386: Define CPUID filtering functions before x86_cpu_list() qmp: Add runnability information to query-cpu-definitions target-i386: Use "-" instead of "_" on all feature names target-i386: Return runnability information on query-cpu-definitions qapi-schema.json | 10 +- target-i386/cpu-qom.h | 4 + target-i386/cpu.c | 275 +++++++++++++++++++++++++++++++++--------------- target-i386/translate.c | 6 ++ 4 files changed, 207 insertions(+), 88 deletions(-) -- 2.5.5

6 46

[libvirt] [PATCH] storage: Adjust qemu-img switches check
by John Ferlan 03 Jun '16

03 Jun '16

Since we support QEMU 0.12 and later, checking for support of specific flags added prior to that isn't necessary. Thus start with the base of having the "-o options" available for the qemu-img create option and then determine whether we have the compat option for qcow2 files (which would be necessary up through qemu 2.0 where the default changes to compat 0.11). NOTE: Keeping old tests around since it's still possible to create in the old format. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/storage/storage_backend.c | 66 ++++++++++++++++--------------------------- 1 file changed, 24 insertions(+), 42 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 3a23cd7..eaa6f65 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -869,9 +869,19 @@ virStoragePloopResize(virStorageVolDefPtr vol, return ret; } +/* Flag values shared w/ storagevolxml2argvtest.c. + * Since it's still possible to provide the old format args, just + * keep them; however, prefix with an "X_" (similar to qemu_capabilities.c) + * to indicate the are older. + * + * QEMU_IMG_BACKING_FORMAT_OPTIONS (added in qemu 0.11) + * QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT + * was made necessary due to 2.0 change to change the default + * qcow2 file format from 0.10 to 1.1. + */ enum { - QEMU_IMG_BACKING_FORMAT_NONE = 0, - QEMU_IMG_BACKING_FORMAT_FLAG, + X_QEMU_IMG_BACKING_FORMAT_NONE = 0, + X_QEMU_IMG_BACKING_FORMAT_FLAG, QEMU_IMG_BACKING_FORMAT_OPTIONS, QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT, }; @@ -904,46 +914,18 @@ virStorageBackendQemuImgSupportsCompat(const char *qemuimg) static int virStorageBackendQEMUImgBackingFormat(const char *qemuimg) { - char *help = NULL; - char *start; - char *end; - char *tmp; - int ret = -1; - int exitstatus; - virCommandPtr cmd = virCommandNewArgList(qemuimg, "-h", NULL); - - virCommandAddEnvString(cmd, "LC_ALL=C"); - virCommandSetOutputBuffer(cmd, &help); - virCommandClearCaps(cmd); - - /* qemuimg doesn't return zero exit status on -h, - * therefore we need to provide pointer for storing - * exit status, although we don't parse it any later */ - if (virCommandRun(cmd, &exitstatus) < 0) - goto cleanup; + /* As of QEMU 0.11 the [-o options] support was added via qemu + * commit id '9ea2ea71', so we start with that base and figure + * out what else we have */ + int ret = QEMU_IMG_BACKING_FORMAT_OPTIONS; + + /* QEMU 2.0 changed to using a format that only QEMU 1.1 and newer + * understands. Since we still support QEMU 0.12 and newer, we need + * to be able to handle the previous format as can be set via a + * compat=0.10 option. */ + if (virStorageBackendQemuImgSupportsCompat(qemuimg)) + ret = QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT; - if ((start = strstr(help, " create ")) == NULL || - (end = strstr(start, "\n")) == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("unable to parse qemu-img output '%s'"), - help); - goto cleanup; - } - if (((tmp = strstr(start, "-F fmt")) && tmp < end) || - ((tmp = strstr(start, "-F backing_fmt")) && tmp < end)) { - ret = QEMU_IMG_BACKING_FORMAT_FLAG; - } else if ((tmp = strstr(start, "[-o options]")) && tmp < end) { - if (virStorageBackendQemuImgSupportsCompat(qemuimg)) - ret = QEMU_IMG_BACKING_FORMAT_OPTIONS_COMPAT; - else - ret = QEMU_IMG_BACKING_FORMAT_OPTIONS; - } else { - ret = QEMU_IMG_BACKING_FORMAT_NONE; - } - - cleanup: - virCommandFree(cmd); - VIR_FREE(help); return ret; } @@ -1196,7 +1178,7 @@ virStorageBackendCreateQemuImgCmdFromVol(virConnectPtr conn, VIR_FREE(opts); } else { if (info.backingPath) { - if (imgformat == QEMU_IMG_BACKING_FORMAT_FLAG) + if (imgformat == X_QEMU_IMG_BACKING_FORMAT_FLAG) virCommandAddArgList(cmd, "-F", backingType, NULL); else VIR_DEBUG("Unable to set backing store format for %s with %s", -- 2.5.5

1 1

[libvirt] [PATCH 0/3] Clean up some virstorageencryption code
by John Ferlan 03 Jun '16

03 Jun '16

While working through adding luks support for libvirt, I have a few patches that aren't really germane to adding support and rather than drop a large patch series when I'm done - I figured I'd post a few adjustments. In the long run the encryption code probably doesn't work, but I'm trying to move it to the side at least. John Ferlan (3): util: Clean up code formatting in virstorageencryption storage: Split out setting default secret for encryption storage: Split out a helper for encryption checks src/storage/storage_backend.c | 80 ++++++++++++++++++++++++++-------------- src/storage/storage_backend_fs.c | 79 ++++++++++++++++++++++++--------------- src/util/virstorageencryption.c | 58 ++++++++++++++--------------- 3 files changed, 128 insertions(+), 89 deletions(-) -- 2.5.5

1 4

[libvirt] [PATCH 0/2] Fix a virperf related crasher
by Michal Privoznik 03 Jun '16

03 Jun '16

I've ran into a crasher. Worse crasher over RO connection. Michal Privoznik (2): Drop virPerfGetEventFd virPerfEventIsEnabled: Don't crash on shut off domains src/libvirt_private.syms | 1 - src/util/virperf.c | 22 +++------------------- src/util/virperf.h | 3 --- 3 files changed, 3 insertions(+), 23 deletions(-) -- 2.8.3

2 4

[libvirt] Plan for the next release
by Daniel Veillard 03 Jun '16

03 Jun '16

I will be travelling end of this week and most of next week, but I think we can still try to get a release for June 1st, I suggest: - enter freeze this Thrusday 26 - Push an rc2 over the week-end - try to push the 1.3.5 release on Wed June 1st I hope this works for everybody ! Thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH v3] virDomainChrGetDomainPtrsInternal: Return an integer
by Michal Privoznik 03 Jun '16

03 Jun '16

There's this problem on the recent gcc-6.1: In file included from conf/domain_conf.c:37:0: conf/domain_conf.c: In function 'virDomainChrPreAlloc': conf/domain_conf.c:14109:35: error: potential null pointer dereference [-Werror=null-dereference] return VIR_REALLOC_N(*arrPtr, *cntPtr + 1); ^~ ./util/viralloc.h:158:73: note: in definition of macro 'VIR_REALLOC_N' # define VIR_REALLOC_N(ptr, count) virReallocN(&(ptr), sizeof(*(ptr)), (count), \ ^~~~~ conf/domain_conf.c: In function 'virDomainChrRemove': conf/domain_conf.c:14133:21: error: potential null pointer dereference [-Werror=null-dereference] for (i = 0; i < *cntPtr; i++) { ^~~~~~~ GCC basically fails to see, that the virDomainChrGetDomainPtrsInternal will never actually return NULL because it's never called over a domain char device with _LAST type. But to make it shut up, lets turn this function into returning an integer and check in the callers if a zero value value was returned. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v2: - Yet another improvement as suggested in review of v2 src/conf/domain_conf.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7d46d0b..9f9fdf2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14038,7 +14038,7 @@ virDomainChrFind(virDomainDefPtr def, /* Return the address within vmdef to be modified when working with a * chrdefptr of the given type. */ -static void +static int ATTRIBUTE_RETURN_CHECK virDomainChrGetDomainPtrsInternal(virDomainDefPtr vmdef, virDomainChrDeviceType type, virDomainChrDefPtr ***arrPtr, @@ -14048,28 +14048,30 @@ virDomainChrGetDomainPtrsInternal(virDomainDefPtr vmdef, case VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL: *arrPtr = &vmdef->parallels; *cntPtr = &vmdef->nparallels; - break; + return 0; case VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL: *arrPtr = &vmdef->serials; *cntPtr = &vmdef->nserials; - break; + return 0; case VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE: *arrPtr = &vmdef->consoles; *cntPtr = &vmdef->nconsoles; - break; + return 0; case VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL: *arrPtr = &vmdef->channels; *cntPtr = &vmdef->nchannels; - break; + return 0; case VIR_DOMAIN_CHR_DEVICE_TYPE_LAST: - *arrPtr = NULL; - *cntPtr = NULL; break; } + + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unknown char device type: %d"), type); + return -1; } @@ -14085,14 +14087,13 @@ virDomainChrGetDomainPtrs(const virDomainDef *vmdef, size_t *cntVar = NULL; /* Cast away const; we add it back in the final assignment. */ - virDomainChrGetDomainPtrsInternal((virDomainDefPtr) vmdef, type, - &arrVar, &cntVar); - if (arrVar) { + if (virDomainChrGetDomainPtrsInternal((virDomainDefPtr) vmdef, type, + &arrVar, &cntVar) < 0) { + *arrPtr = NULL; + *cntPtr = 0; + } else { *arrPtr = (const virDomainChrDef **) *arrVar; *cntPtr = *cntVar; - } else { - *arrPtr = NULL; - *cntPtr = 0; } } @@ -14104,7 +14105,9 @@ virDomainChrPreAlloc(virDomainDefPtr vmdef, virDomainChrDefPtr **arrPtr = NULL; size_t *cntPtr = NULL; - virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, &arrPtr, &cntPtr); + if (virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, + &arrPtr, &cntPtr) < 0) + return -1; return VIR_REALLOC_N(*arrPtr, *cntPtr + 1); } @@ -14116,7 +14119,9 @@ virDomainChrInsertPreAlloced(virDomainDefPtr vmdef, virDomainChrDefPtr **arrPtr = NULL; size_t *cntPtr = NULL; - virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, &arrPtr, &cntPtr); + if (virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, + &arrPtr, &cntPtr) < 0) + return; VIR_APPEND_ELEMENT_INPLACE(*arrPtr, *cntPtr, chr); } @@ -14128,7 +14133,9 @@ virDomainChrRemove(virDomainDefPtr vmdef, virDomainChrDefPtr ret = NULL, **arrPtr = NULL; size_t i, *cntPtr = NULL; - virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, &arrPtr, &cntPtr); + if (virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, + &arrPtr, &cntPtr) < 0) + return NULL; for (i = 0; i < *cntPtr; i++) { ret = (*arrPtr)[i]; -- 2.8.3

2 1