- Devel - libvirt List Archives

[libvirt] [PATCH 0/5] qemu: Improve VM file logging using virtlogd
by Peter Krempa 07 Jun '16

07 Jun '16

Patch 4/5 fixes a bug that was introduced with virtlogd. Rest of the patches add infrastructure for logging singular events to the vm log file. Peter Krempa (5): log: handler: Add new API to append to logging files log: daemon: Add remote protocol handling for the log appending API qemu: domain: Implement helper for one-shot log entries to the VM log file qemu: process: Append the "shutting down" message using the new APIs qemu: migration: Add VM log entry on start of migration src/libvirt_private.syms | 1 + src/logging/log_daemon_dispatch.c | 26 ++++++++++++++++ src/logging/log_handler.c | 50 +++++++++++++++++++++++++++++++ src/logging/log_handler.h | 8 +++++ src/logging/log_manager.c | 34 +++++++++++++++++++++ src/logging/log_manager.h | 8 +++++ src/logging/log_protocol.x | 20 ++++++++++++- src/qemu/qemu_domain.c | 62 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 5 ++++ src/qemu/qemu_migration.c | 7 +++++ src/qemu/qemu_process.c | 11 ++----- 11 files changed, 223 insertions(+), 9 deletions(-) -- 2.8.3

2 10

[libvirt] [PATCH 0/3] Speed up schema testing
by Ján Tomko 07 Jun '16

07 Jun '16

Currently, we spawn a new xmllint process for every tested XML file. Fortunately, xmllint accepts multiple files on its command line. Use xargs on XML files we expect to be valid and only fall back to file-by-file check if that fails (or if VIR_TEST_EXPENSIVE was requested). This speeds up successfully passing domainschematest 32x (from ~13s to ~0.5s) and make check over 2x (over 16s to ~8s), making it even more fun to use with git rebase -x. Ján Tomko (3): schematestutils: split out file-by-file schema checking schematestutils: split out check_one_file schematestutils: Add check_schema_quick tests/schematestutils.sh | 79 ++++++++++++++++++++++++++++++++++++------------ 1 file changed, 59 insertions(+), 20 deletions(-) -- 2.7.3

2 4

[libvirt] [PATCH] util: Perform proper virRandomBytes return value checking
by John Ferlan 07 Jun '16

07 Jun '16

Document the return value of virRandomBytes as 0 or some errno value and then make sure all callers make the proper checks. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/util/vircrypto.c | 2 +- src/util/virrandom.c | 2 ++ tests/vircryptotest.c | 6 ++++-- tests/virrandomtest.c | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/vircrypto.c b/src/util/vircrypto.c index 4f288f0..8452936 100644 --- a/src/util/vircrypto.c +++ b/src/util/vircrypto.c @@ -301,7 +301,7 @@ virCryptoGenerateRandom(size_t nbytes) /* If we don't have gnutls_rnd(), we will generate a less cryptographically * strong master buf from /dev/urandom. */ - if ((ret = virRandomBytes(buf, nbytes)) < 0) { + if ((ret = virRandomBytes(buf, nbytes))) { virReportSystemError(ret, "%s", _("failed to generate byte stream")); VIR_FREE(buf); return NULL; diff --git a/src/util/virrandom.c b/src/util/virrandom.c index 62a0e31..41daa40 100644 --- a/src/util/virrandom.c +++ b/src/util/virrandom.c @@ -167,6 +167,8 @@ uint32_t virRandomInt(uint32_t max) * * Generate a stream of random bytes from /dev/urandom * into @buf of size @buflen + * + * Returns 0 on success or an errno on failure */ int virRandomBytes(unsigned char *buf, diff --git a/tests/vircryptotest.c b/tests/vircryptotest.c index 72265d9..e7b7de5 100644 --- a/tests/vircryptotest.c +++ b/tests/vircryptotest.c @@ -87,9 +87,11 @@ testCryptoEncrypt(const void *opaque) VIR_ALLOC_N(iv, ivlen) < 0) goto cleanup; - if (virRandomBytes(enckey, enckeylen) < 0 || - virRandomBytes(iv, ivlen) < 0) + if (virRandomBytes(enckey, enckeylen) || + virRandomBytes(iv, ivlen)) { + fprintf(stderr, "Failed to generate random bytes\n"); goto cleanup; + } if (virCryptoEncryptData(data->algorithm, enckey, enckeylen, iv, ivlen, data->input, data->inputlen, diff --git a/tests/virrandomtest.c b/tests/virrandomtest.c index 367bdc7..687ebd9 100644 --- a/tests/virrandomtest.c +++ b/tests/virrandomtest.c @@ -40,7 +40,7 @@ testRandomBytes(const void *unused ATTRIBUTE_UNUSED) if (VIR_ALLOC_N(data, datalen) < 0) return -1; - if (virRandomBytes(data, datalen) < 0) { + if (virRandomBytes(data, datalen)) { fprintf(stderr, "Failed to generate random bytes"); goto cleanup; } -- 2.5.5

2 1

[libvirt] [PATCH] Reindent virNetDevSendEthtoolIoctl
by Ján Tomko 07 Jun '16

07 Jun '16

--- src/util/virnetdev.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) Pushed as trivial. diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index e6c57ac..af122f5 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3213,15 +3213,15 @@ virNetDevSendEthtoolIoctl(int fd, struct ifreq *ifr) ret = ioctl(fd, SIOCETHTOOL, ifr); if (ret != 0) { switch (errno) { - case EINVAL: /* kernel doesn't support SIOCETHTOOL */ - VIR_DEBUG("ethtool ioctl: invalid request"); - break; - case EOPNOTSUPP: /* kernel doesn't support specific feature */ - VIR_DEBUG("ethtool ioctl: request not supported"); - break; - default: - virReportSystemError(errno, "%s", _("ethtool ioctl error")); - break; + case EINVAL: /* kernel doesn't support SIOCETHTOOL */ + VIR_DEBUG("ethtool ioctl: invalid request"); + break; + case EOPNOTSUPP: /* kernel doesn't support specific feature */ + VIR_DEBUG("ethtool ioctl: request not supported"); + break; + default: + virReportSystemError(errno, "%s", _("ethtool ioctl error")); + break; } } -- 2.7.3

1 0

[libvirt] [PATCH] Reindent comment of virNetDevFeatureAvailable
by Ján Tomko 07 Jun '16

07 Jun '16

--- src/util/virnetdev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) Pushed as trivial. diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 7db4497..5ad61fe 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3241,14 +3241,14 @@ virNetDevSendEthtoolIoctl(const char *ifname, void *cmd) /** -* virNetDevFeatureAvailable -* This function checks for the availability of a network device feature -* -* @ifname: name of the interface -* @cmd: reference to an ethtool command structure -* -* Returns 0 if not found, 1 on success, and -1 on failure. -*/ + * virNetDevFeatureAvailable + * This function checks for the availability of a network device feature + * + * @ifname: name of the interface + * @cmd: reference to an ethtool command structure + * + * Returns 0 if not found, 1 on success, and -1 on failure. + */ static int virNetDevFeatureAvailable(const char *ifname, struct ethtool_value *cmd) { -- 2.7.3

1 0

[libvirt] [PATCH] spec: Advertise nvram paths of official fedora edk2 builds
by Cole Robinson 07 Jun '16

07 Jun '16

Fedora now ships edk2 firmware in its official repos, so adapt the nvram path list to match. Eventually we can remove the nightly links as well once some integration kinks have been worked out, and documentation updated. Move the macro building into the %build target, which lets us build up a shell variable and make things a bit more readable https://bugzilla.redhat.com/show_bug.cgi?id=1335395 --- libvirt.spec.in | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c7fcf85..8b88eef 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -192,12 +192,6 @@ %define qemu_group qemu -# Advertise OVMF and AAVMF from nightly firmware repo -%if 0%{?fedora} - %define arg_loader_nvram --with-loader-nvram="/usr/share/edk2.git/ovmf-x64/OVMF_CODE-pure-efi.fd:/usr/share/edk2.git/ovmf-x64/OVMF_VARS-pure-efi.fd:/usr/share/edk2.git/aarch64/QEMU_EFI-pflash.raw:/usr/share/edk2.git/aarch64/vars-template-pflash.raw" -%endif - - %if 0%{?fedora} || 0%{?rhel} >= 7 %define with_systemd_macros 1 %else @@ -1097,6 +1091,18 @@ rm -rf .git %define arg_selinux_mount --with-selinux-mount="/selinux" %endif +%if 0%{?fedora} + # Nightly firmware repo x86/OVMF + LOADERS="/usr/share/edk2.git/ovmf-x64/OVMF_CODE-pure-efi.fd:/usr/share/edk2.git/ovmf-x64/OVMF_VARS-pure-efi.fd" + # Nightly firmware repo aarch64/AAVMF + LOADERS="$LOADERS:/usr/share/edk2.git/aarch64/QEMU_EFI-pflash.raw:/usr/share/edk2.git/aarch64/vars-template-pflash.raw" + # Fedora official x86/OVMF + LOADERS="$LOADERS:/usr/share/edk2/ovmf/OVMF_CODE.fd:/usr/share/edk2/ovmf/OVMF_VARS.fd" + # Fedora official aarch64/AAVMF + LOADERS="$LOADERS:/usr/share/edk2/aarch64/QEMU_EFI-pflash.raw:/usr/share/edk2/aarch64/vars-template-pflash.raw" + %define arg_loader_nvram --with-loader-nvram="$LOADERS" +%endif + # place macros above and build commands below this comment %if 0%{?enable_autotools} -- 2.7.4

2 3

[libvirt] [PATCH] qemu: process: Allow VIR_QEMU_PROCESS_START_NEW in qemuProcessLaunch
by Peter Krempa 07 Jun '16

07 Jun '16

The new flag was not added to virCheckFlags in commit '0d1c17aa' causing a regression where VMs were not able to start. --- Pushed under the trivial rule. src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2f5829c..66bc4b1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5062,7 +5062,8 @@ qemuProcessLaunch(virConnectPtr conn, * but doesn't hurt to check */ virCheckFlags(VIR_QEMU_PROCESS_START_COLD | VIR_QEMU_PROCESS_START_PAUSED | - VIR_QEMU_PROCESS_START_AUTODESTROY, -1); + VIR_QEMU_PROCESS_START_AUTODESTROY | + VIR_QEMU_PROCESS_START_NEW, -1); cfg = virQEMUDriverGetConfig(driver); -- 2.8.3

1 0

[libvirt] [PATCH REPOST 0/4] Couple of random and crypto adjustments
by John Ferlan 07 Jun '16

07 Jun '16

Originally posted : http://www.redhat.com/archives/libvir-list/2016-May/msg01650.html Updated to current head and reposted. John Ferlan (4): util: Add range parameters to virRandomBytes storage: Use virRandomBytes for virStorageGenerateQcowPassphrase util: Alter virCryptoEncryptData for non GNUTLS builds util: Adjust virCryptoEncryptData code to use macros src/storage/storage_backend.c | 10 +++-- src/util/vircrypto.c | 88 +++++++++++++++++++++++++---------------- src/util/virrandom.c | 13 ++++-- src/util/virrandom.h | 3 +- src/util/virstorageencryption.c | 42 +++++++------------- src/util/virstorageencryption.h | 4 +- src/util/viruuid.c | 2 +- tests/qemuxml2argvmock.c | 2 +- tests/vircryptotest.c | 4 +- tests/virrandommock.c | 10 +++-- tests/virrandomtest.c | 32 +++++++++++---- 11 files changed, 124 insertions(+), 86 deletions(-) -- 2.5.5

2 9

[libvirt] [PATCH v6 0/2] qemu: Support for QXL heads
by Martin Kletzander 07 Jun '16

07 Jun '16

v6: - Change heads when migrating (revert v2) - https://www.redhat.com/archives/libvir-list/2016-June/msg00106.html v5: - Just a rebase, plus v4 had some hunk in that didn't belong there so this one's cleaner to look at - https://www.redhat.com/archives/libvir-list/2016-April/msg00721.html v4: - Added test case without "heads=" - Don't consolidate 'size_t i, j' declarations - https://www.redhat.com/archives/libvir-list/2016-March/msg01436.html v3: - rebase on top of current master in order to cleanly apply - https://www.redhat.com/archives/libvir-list/2016-March/msg01198.html v2: - don't change heads when migrating - https://www.redhat.com/archives/libvir-list/2016-March/msg00811.html v1: - https://www.redhat.com/archives/libvir-list/2016-March/msg00410.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 *** BLURB HERE *** Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 5 +++ src/qemu/qemu_capabilities.h | 4 ++ src/qemu/qemu_command.c | 8 ++++ src/qemu/qemu_migration.c | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 + .../qemuxml2argv-video-qxl-heads.args | 28 +++++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++++++++ .../qemuxml2argv-video-qxl-noheads.args | 24 +++++++++++ .../qemuxml2argv-video-qxl-noheads.xml | 39 ++++++++++++++++++ tests/qemuxml2argvtest.c | 16 ++++++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++++++++ .../qemuxml2xmlout-video-qxl-noheads.xml | 39 ++++++++++++++++++ tests/qemuxml2xmltest.c | 3 ++ 15 files changed, 266 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-noheads.xml -- 2.8.3

2 5

[libvirt] [PATCH v2 0/3] Adjust qemu-img switches and checks
by John Ferlan 07 Jun '16

07 Jun '16

v1:http://www.redhat.com/archives/libvir-list/2016-June/msg00081.html (patches 4, 6, and 7) Patch 4 is now patch 1 Patch 6 was reviewed, but this patch alters it not need backingType Patch 7 reworked to accommodate patch 1 changes John Ferlan (3): storage: Adjust qemu-img switches check storage: Create helper to set backing for CreateQemuImg code storage: Create helper to set options for CreateQemuImg code src/storage/storage_backend.c | 223 ++++++++++----------- tests/storagevolxml2argvdata/qcow2-flag.argv | 2 - .../qcow2-nobacking-convert-flag.argv | 2 - .../qcow2-nobacking-convert-none.argv | 2 - .../qcow2-nobacking-flag.argv | 1 - .../qcow2-nobacking-none.argv | 1 - tests/storagevolxml2argvdata/qcow2-none.argv | 1 - tests/storagevolxml2argvtest.c | 22 +- 8 files changed, 107 insertions(+), 147 deletions(-) delete mode 100644 tests/storagevolxml2argvdata/qcow2-flag.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-convert-flag.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-convert-none.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-flag.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-none.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-none.argv -- 2.5.5

2 5