- Devel - libvirt List Archives

[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user
by Nikolay Shirokovskiy 02 Nov '16

02 Nov '16

So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v1: 1. drop 1 patch. Avoiding default label in switches is desired style. 2. drop 2 patch. I do not investigate enough to touch that place. 3. fix 3 patch a) as suggested by Jiri * fix leaks * s/hint/error/g * don't show <NULL> in error message * take suggested code simplifications b) extra * print error string from qemu to log in case we have to drop it Nikolay Shirokovskiy (1): qemu: report block job errors from qemu to the user src/qemu/qemu_blockjob.c | 13 +++++++++-- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration.c | 54 +++++++++++++++++++++++++++++++------------- src/qemu/qemu_monitor.c | 5 ++-- src/qemu/qemu_monitor.h | 4 +++- src/qemu/qemu_monitor_json.c | 4 +++- src/qemu/qemu_process.c | 4 ++++ 10 files changed, 68 insertions(+), 25 deletions(-) -- 1.8.3.1

2 4

[libvirt] [PATCH] Post-release version bump to 2.5.0
by Jiri Denemark 02 Nov '16

02 Nov '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dfc536f..9785e66 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [2.4.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [2.5.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.10.2

1 0

[libvirt] Release of libvirt-2.4.0
by Daniel Veillard 02 Nov '16

02 Nov '16

It's out ! Not hearing any negative feedback on the release candidates I went ahead, this is tagged in git and signed tarball and rpms are now at the usual place: ftp://libvirt.org/libvirt/ I also made a libvirt-python release though it is virtually identical to 2.3.0, to be found at: ftp://libvirt.org/libvirt/python/ this release is on the small side, leass than 250 commits were pulled in, mostly bugfixes and incremental improvement. Main user visible one being the one for I/O throtling and tuning: Documentation: - docs: remove obsolete library.xen file (Daniel P. Berrange) - doc: update virsh domstats documentation for vcpu statistics (Viktor Mihajlovski) - doc: Describe the VCPU states returned by virsh vcpuinfo (Viktor Mihajlovski) - virsh: Fix typos in manpage (Nitesh Konkar) - virsh: Fix commas in manpage to enhance readability. (Nitesh Konkar) - docs: Alter descriptions of perf cpu_cycles (John Ferlan) - docs: Add PCP as monitoring application (Marko Myllynen) - docs: Fix typo in libvirt-domain.h parameter description (John Ferlan) Portability: - virLogDefineOutputs: Fix build without syslog.h (Michal Privoznik) - virt-yajl: Fix detection of yajl requirements (Martin Kletzander) Bug Fixes: - vsh: Pass correct values for command line completion (John Ferlan) - vsh: Using VSH_REQUIRE_OPTION rather than virReportError (Kothapally Madhu Pavan) - network: fix endless loop when starting network with multiple IPs and no dhcp (Laine Stump) - qemu_driver: unlink new domain cfg file when rollback (Chen Hanxiao) - qemu: Fix crash during qemuStateCleanup (Nikolay Shirokovskiy) - daemon: Fix crash during daemon cleanup (Nikolay Shirokovskiy) - qemu: Forbid pinning vCPUs for TCG domain (Chen Hanxiao) - Recreate the USB address cache at reconnect (Ján Tomko) - Fix crash on usb-serial hotplug (Ján Tomko) - virsh: Fix on_shutdown to on_poweroff (Martin Kletzander) - qemu, lxc: Raise error message when resuming running domain (Sławek Kapłoński) - qemu: Fix depedency order in qemuRemoveDiskDevice (John Ferlan) - qemu: Move TLS object remove from DetachChr to RemoveChr (John Ferlan) - libxl: fix leaking of allocated migration ports (Jim Fehlig) - domain: fix migration to older libvirt (Pavel Hrdina) - domain_conf: fix memory leak in virDomainDefAddConsoleCompat (Pavel Hrdina) - bhyve: Need to add parameter to virDomainChrDefNew (John Ferlan) - networkValidate: Forbid new-line char in network name (Sławek Kapłoński) - qemu: always generate the same alias for tls-creds-x509 object (Pavel Hrdina) - qemu_hotplug: fix crash in hot(un)plugging chardev devices (Pavel Hrdina) - util: Alter return value of virReadFCHost and fix mem leak (John Ferlan) - schema: smbios: allow any strings (Peter Krempa) - qemu: command: escape smbios entry strings (Peter Krempa) - testNodeGetCellsFreeMemory: Fix off by one error (Michal Privoznik) - virsh: vcpuinfo: Report proper vcpu numbers and data for offline VMs (Peter Krempa) - virsh: Fix xpath queries for retrieving vcpu count (Peter Krempa) - conf: Fix virDomainShmemDefFind (Martin Kletzander) - qemu: migration: Disallow migration of read only disk (Corey S. McQuay) - tests: Need to initialize data (John Ferlan) - vsh: Fix some issues in auto completion code (John Ferlan) - util: Resolve memory leaks in virLogParse{Output|Filter} (John Ferlan) - tools: Exclude Xen dom0 from libvirt-guests.sh list (Stefan Bader) - tools: Ignore newlines in libvirt-guests.sh guest list (Stefan Bader) - qemu: fix command line building for iommu devices (Daniel P. Berrange) - qemu: monitor: Properly configure backend for UDP chardevs (Peter Krempa) - qemu: attach: Close monitor socket on connection failure (Peter Krempa) - qemu: Don't strictly require JSON monitor for vCPU detection (Peter Krempa) Improvements: - qemu: Minimalize global driver accesses (Michal Privoznik) - vz: remove Bridged network name and rename Routed (Maxim Nestratov) - vz: support type=bridge network interface type correctly (Maxim Nestratov) - Do not try to release virtio serial addresses (Ján Tomko) - Return directly from qemuDomainAttachChrDeviceAssignAddr (Ján Tomko) - Introduce virDomainVirtioSerialAddrAutoAssign again (Ján Tomko) - Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign (Ján Tomko) - wireshark: Rename plugindir to ws_plugindir (Andrea Bolognani) - wireshark: Inject $(prefix) at the right time (Andrea Bolognani) - wireshark: Strip prefix correctly (Andrea Bolognani) - wireshark: Hoist $ws_prefix declaration (Andrea Bolognani) - wireshark: Introduce $ws_modversion (Andrea Bolognani) - qemu: Add support for using AES secret for SCSI hotplug (Gema Gomez) - qemu: Add secret object hotplug for TCP chardev TLS (John Ferlan) - qemu: Add a secret object to/for a char source dev (John Ferlan) - qemu: Need to remove TLS object in RemoveRNGDevice (John Ferlan) - virsh: Add _length parameters to virsh output (John Ferlan) - virsh: Create macros to add IOTUNE values (John Ferlan) - qemu: Add the length options to the iotune command line (John Ferlan) - conf: Add support for blkiotune "_length" options (John Ferlan) - qemu: Add length for bps/iops throttling parameters to driver (John Ferlan) - caps: Add new capability for the bps/iops throttling length (John Ferlan) - include: Add new definitions for duration for bps/iops throttling (John Ferlan) - qemu: Introduce qemuDomainSetBlockIoTuneDefaults (John Ferlan) - qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune (John Ferlan) - qemu: Return real error message for block_set_io_throttle (John Ferlan) - qemu: Create a macro to handle setting bytes/iops iotune values (John Ferlan) - virQEMUCapsReset: also clear out hostCPUModel (Ján Tomko) - qemu: add vcpu.n.halted to vcpu domain stats (Viktor Mihajlovski) - qemu: Add domain support for VCPU halted state (Viktor Mihajlovski) - qemu: Add monitor support for CPU halted state (Viktor Mihajlovski) - qemu: replace calls to virDomainPCIAddressReserveNext*() with static function (Laine Stump) - conf: make virDomainPCIAddressGetNextSlot() a local static function (Laine Stump) - qemu: use virDomainPCIAddressReserveNextAddr in qemuDomainAssignDevicePCISlots (Laine Stump) - conf: new function virDomainPCIAddressReserveNextAddr() (Laine Stump) - domain: Add optional 'tls' attribute for TCP chardev (Pavel Hrdina) - domain_conf: remove union for one member from redirdev struct (Pavel Hrdina) - qemu: Add TLS hotplug for qemuDomainAttachRNGDevice (John Ferlan) - qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Clean up error path in qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug (John Ferlan) - conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr' (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru' (John Ferlan) - xenFormatXLDisk: Unify commas pattern for arguments (Michal Privoznik) - qemu: change first arg of qemuDomainAttachChrDeviceAssignAddr() (Laine Stump) - qemu: make error message in qemuDomainPCIAddressSetCreate more clear. (Laine Stump) - qemu: remove superfluous setting of addrs->nbuses (Laine Stump) - conf: add typedef for anonymous enum used for memballoon device model (Laine Stump) - qemu: replace "def->nets[i]" with "net" and "def->sounds[i]" with "sound" (Laine Stump) - qemu: replace a lot of "def->controllers[i]" with equivalent "cont" (Laine Stump) - conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef (John Ferlan) - Introduce virDomainChrSourceDefNew for virDomainChrDefPtr (John Ferlan) - vmx: Use the allocator virDomainChrDefNew (John Ferlan) - qemuBuildHostNetStr: remove dead code (Ján Tomko) - qemuBuildHostNetStr: do not start options with a comma (Ján Tomko) - qemuBuildHostNetStr: use type_sep earlier (Ján Tomko) - vz: set something in disk driver name (Nikolay Shirokovskiy) - vz: add serial number to disk devices (Nikolay Shirokovskiy) - vz: set localhost as vnc address (Mikhail Feoktistov) - virt-wireshark.m4: Defer $(prefix) substitution (Michal Privoznik) - network: Use new util function to check name (Sławek Kapłoński) - virxml: Add function to check if string contains some illegal chars (Sławek Kapłoński) - qemu: Introduce qemuDomainChardevPrivatePtr (John Ferlan) - conf: Introduce {default|chardev}_tls_x509_secret_uuid (John Ferlan) - xl: fix 8126d870 broken test (Cédric Bosdonnat) - spec: Drop support for Fedora < 23 (Andrea Bolognani) - xl: don't output (null) target in domxml-to-native (Cédric Bosdonnat) - qemu_command: create prefixed alias to separate variable (Pavel Hrdina) - qemu_alias: introduce qemuAliasChardevFromDevAlias helper (Pavel Hrdina) - qemu: Remove unnecessary NULL arg check (John Ferlan) - qemu: Add 'verify-peer=yes' test for chardev TCP TLS (John Ferlan) - qemu: Remove unnecessary cfg fetch/unref (John Ferlan) - conf: Explain some code in more detail (Andrea Bolognani) - conf: restrict what type of buses will accept a pci-bridge (Laine Stump) - conf: Honour flags in virDomainPanicDefParseXML (Martin Kletzander) - schema: Allow alias for panic device (Martin Kletzander) - qemu_hotplug: Support interface type of vhost-user hotplug (Michal Privoznik) - qemuBuildHostNetStr: Support VIR_DOMAIN_NET_TYPE_VHOSTUSER (Michal Privoznik) - qemuBuildVhostuserCommandLine: Unify -netdev creation (Michal Privoznik) - qemuBuildVhostuserCommandLine: Reuse qemuBuildChrChardevStr (Michal Privoznik) - qemuBuildChrChardevStr: Introduce @nowait argument (Michal Privoznik) - qemuBuildHostNetStr: Explicitly enumerate net types (Michal Privoznik) - qemuDomainAttachNetDevice: Explicitly list allowed types for hotplug (Michal Privoznik) - qemuDomainAttachNetDevice: Move hostdev handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move from if-else forest to switch (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move vhostuser handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move hostdev handling a bit further (Michal Privoznik) - virDomainNetGetActualType: Return type is virDomainNetType (Michal Privoznik) - virDomainNetDefParseXML: Realign (Michal Privoznik) - qemu: command: Don't bother reporting errors in smbios formatters (Peter Krempa) - qemu: command: Fix up coding style of smbios commandine formatters (Peter Krempa) - src: Treat PID as signed (Michal Privoznik) - virsh: Be explicit that vol-resize is an offline operation. (Ivan Baldo) - testOpenDefault: Rename loop variable (Michal Privoznik) - qemu_command: add support to use virtio as secondary video device (Pavel Hrdina) - qemu_command: introduce enum of secondary models for video device (Pavel Hrdina) - qemu_command: cleanup qemuBuildVideoCommandLine (Pavel Hrdina) - qemu_command: properly detect which model to use for video device (Pavel Hrdina) - qemu_capabilities: check for existence of virtio-vga (Pavel Hrdina) - qemu_command: pass only video device to qemuBuildVgaVideoCommand (Pavel Hrdina) - qemu_command: separate code for video device via -vga attribute (Pavel Hrdina) - qemu_process: always check capabilities for video devices (Pavel Hrdina) - qemu_process: move video validation out of qemu_command (Pavel Hrdina) - qemu_domain: move video validation out of qemu_command (Pavel Hrdina) - qemu_capabilities: detect properties for virtio-gpu-device (Pavel Hrdina) - qemu_capabilities: rename QEMU_CAPS_VIRTIO_GPU_VIRGL (Pavel Hrdina) - qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated (Pavel Hrdina) - qemu_capabilities: join capabilities for qxl and qxl-vga devices (Pavel Hrdina) - tests: fix some QXL capability combinations that don't make sense (Pavel Hrdina) - qemu_command: remove xenner leftover from video device code (Pavel Hrdina) - qemu_process: move qemuProcessStartValidateGraphics to correct place (Pavel Hrdina) - virsh: Extract fallback handling in cmdVcpuinfo (Peter Krempa) - virsh: Extract cpumap formatting in cmdVcpuinfo (Peter Krempa) - virsh: domain: Fix broken indentation in virshCPUCountCollect (Peter Krempa) - util: bitmap: Make bitmaps const in virBitmapNewData and virBitmapDataToString (Peter Krempa) - libvirt-guests: Weaken dependency on libvirtd (Andrea Bolognani) - qemu: Disable migration with ivshmem (Martin Kletzander) - conf: Don't complicate find loop (Martin Kletzander) - Clean timer in virObjectEventStateFlush (Martin Kletzander) - De-duplicate code into virObjectEventStateCleanupTimer() (Martin Kletzander) - Reference state when using it as opaque (Martin Kletzander) - Change virDomainEventState to virObjectLockable (Martin Kletzander) - qemu: Reuse virDomainDeGetVcpusTopology to calculate total vcpu count (Peter Krempa) - conf: Sanitize cpu topology numbers (Peter Krempa) - util: Remove need for local 'nelems' (John Ferlan) - tests: Prefer virGetLastErrorMessage in testSELinuxLabeling (John Ferlan) - conf: Remove incorrect check when encoding shmem audit message (John Ferlan) - network: add dnsmasq option 'dhcp-authoritative' (Martin Wilck) - Don't update timer if there's none. (Martin Kletzander) - examples: Distribute all systemtap scripts. (Luyao Huang) - virlog: Split parsing and setting priority (Erik Skultety) - virlog: Remove functions that aren't used anywhere anymore (Erik Skultety) - daemon: Split filter parsing and filter defining (Erik Skultety) - daemon: Split output parsing and output defining (Erik Skultety) - virlog: Introduce virLogSetFilters (Erik Skultety) - virlog: Introduce virLogSetOutputs (Erik Skultety) - virlog: Introduce virLogParseFilters (Erik Skultety) - virlog: Introduce virLogParseOutputs (Erik Skultety) - virlog: Introduce virLogParseFilter (Erik Skultety) - virlog: Introduce virLogParseOutput (Erik Skultety) - virlog: Take a special care of syslog when setting new set of log outputs (Erik Skultety) - virlog: Introduce virLogNewOutputTo* as a replacement for virLogAddOutputTo* (Erik Skultety) - virlog: Introduce virLogDefineFilters (Erik Skultety) - virlog: Introduce virLogDefineOutputs (Erik Skultety) - virlog: Introduce virLogFindOutput (Erik Skultety) - virlog: Introduce virLogFilterNew (Erik Skultety) - virlog: Introduce virLogOutputNew (Erik Skultety) - virlog: Store the journald fd within the output object (Erik Skultety) - virlog: Rename virLogParse* to virLogParseAndDefine* (Erik Skultety) - virlog: Remove unused macro IS_SPACE (Erik Skultety) - virsh domdisplay: introduce '--all' for showing all possible graphical displays (Chen Hanxiao) - util: Check/ignore already disabled event (John Ferlan) - util: Clear up some perf error messages (John Ferlan) - private_syms: add virLogFilterListFree to libvirt_private.syms (Erik Skultety) - m4: Drop PKG_PROG_PKG_CONFIG compatibility code (Andrea Bolognani) - docs/Makefile.am: build hvsupport.html earlier (Ján Tomko) - docs/Makefile.am: remove redundant variables (Ján Tomko) - qemu: monitor: Simplify construction of chardev backends (Peter Krempa) - tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev (Peter Krempa) - tests: qemumonitorjson: Don't do multiple tests in one virTestRun (Peter Krempa) - tests: qemu: Add support for testing aguments on monitor verbatim (Peter Krempa) - conf: Sanitize formatting of UDP chardev source (Peter Krempa) - conf: Add a formatting macro for all the blkiotune values (John Ferlan) - qemu: Adjust how supportMaxOptions is used. (John Ferlan) - qemu: Convert from shorthand to longer throttling names (John Ferlan) - tests: Add blkdeviotune-max xml2xmltest (John Ferlan) - include: Update description for <iotune> max params (John Ferlan) - qemu: allow 32 slots on pcie-expander-bus, not just 1 (Laine Stump) - vsh: Fix warnings in command line completer (Jiri Denemark) - qemu: Create helper qemuMonitorJSONGetBlockDevDevice (John Ferlan) - qemu: Create helper qemuMonitorJSONGetBlockDev (John Ferlan) - qemu: Create common code for JSON "query-block" call (John Ferlan) - util: Introduce virJSONValueObjectStealArray (John Ferlan) - rbd: Move the encryption check in build (John Ferlan) - rbd: Change to using heap allocated state contexts (John Ferlan) - rbd: Change virStorageBackendRBDCloseRADOSConn to be static void (John Ferlan) - qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags (Peter Krempa) - lib: Introduce VIR_DOMAIN_VCPU_HOTPLUGGABLE for virDomainSetVcpusFlags (Peter Krempa) - Don't drop expired lease while reading custom leases file (Nehal J Wani) - NSS: Add explicit check to not report expired lease (Nehal J Wani) - remote: Increase bound limit for virDomainGetBlockIoTune (John Ferlan) - remote: Fix erroneous usage of constant (John Ferlan) thanks everybody for your help with the release, be it patch, docs, raising issues, commenting, reviewing patches, localizations, etc... Enjoy the release ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] libvirt label qemu process problem
by zhunxun＠gmail.com 01 Nov '16

01 Nov '16

I found that when using souce code to install libvirt,it labeled qemu process with label "unconfined_u:unconfined_r:svirt_t:s0:c53,c366" instead of "system_u:system_r:svirt_t:s0:c53,c366",is this a bug??can anyone explain it ?? thanks! zhunxun(a)gmail.com

2 1

[libvirt] [PATCH] docs: remove obsolete library.xen file
by Daniel P. Berrange 01 Nov '16

01 Nov '16

The library.xen file contains a braindump of thoughts dating from the very first days of libvirt, when it was briefly called libxen. This is not useful and potentially misleading or confusing for people. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- cfg.mk | 2 +- docs/library.xen | 100 ------------------------------------------------------- 2 files changed, 1 insertion(+), 101 deletions(-) delete mode 100644 docs/library.xen diff --git a/cfg.mk b/cfg.mk index 9546853..a4305a8 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1220,7 +1220,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \ ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$ exclude_file_name_regexp--sc_prohibit_empty_first_line = \ - ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/(vmwarever|virhostcpu)data/.*)$$ + ^(README|daemon/THREADS\.txt|src/esx/README|tests/(vmwarever|virhostcpu)data/.*)$$ exclude_file_name_regexp--sc_prohibit_useless_translation = \ ^tests/virpolkittest.c diff --git a/docs/library.xen b/docs/library.xen deleted file mode 100644 index 2e1b2c5..0000000 --- a/docs/library.xen +++ /dev/null @@ -1,100 +0,0 @@ - - About a libxen library - ====================== - -Functional description: ------------------------ - - Small C library to be able to control Xen Linux guest, i.e. - provide the following operations for Xen guest domains running Linux - from domain 0 code linked to the library (running as root): - - start - - stop - - suspend - - resume - - monitor - More advanced features should be allowed as future extensions, but - are not expected to be provided in first shipment. - - Open enough Licence that customers can link their apps to it (LGPL) - - Small and contained enough that we can use it as a way to - provide API and ABI stability in spite if the evolution of Xen - existing API and hypervisor calls. - -The current state of Xen userland: ----------------------------------- - - the existing Xen 3.0 userland code is mostly based on tiny C functions -using direct hypervisor calls (or /proc/xen/ interfaces) and a lot of -Python code on top driving the hypervisor. - The C code is relatively hairy, functions with 10 parameters or more -are not uncommon, and it is very low level usually without comment about -the function or its arguments. They are usually only called once in the -whole tree by the python bindings. In essence it looks like the Xen project -was not implemented with the idea of reusing that part of the code by -applications. - Indeed most of the userland code coming with Xen is built on Python, -like xend the xen daemon running on domain 0 or the xenstored daemon which -manage the state of the domains launched. - -Rebuilding a library ?: ------------------------ - - Providing a library at the C level to drive domain execution is in a -very large part a rimplementation of existing code but in a different way -and somehow with different goals for the code. The existing Licence (GPL) -makes it uneasy, we can't copy GPL code to put it in a LGPL'ed library, -and rewriting everything while looking at the Xen code will inevitably -lead to code similarities especially with this kind of system code. Plus -we will still need to run xend and probably xenstored to not diverge -completely from Xen existing code base. - -The IBM way: ------------- - - Here is supposition about code that I can't instanciate except by looking -at said code but it looks that IBM also needed a C programmatic API to -manage the Xen domain definitions. Their solution was to build (Rusty -Russell did this) an LGPL C API connecting directly to the xenstore -daemon (./tools/xenstore/*). In a way this is quite more fragile as it depends -on the whole existing stack of the Xen code, but it isolate the API -from the implementation details of the current Xen source (API in -./tools/xenstore/xs.h). The goal seems to be more about testing and controlling -the xen store daemon, but it shows a different approach to decouple client -API/ABI from the Xen existing code. - -Open question: ---------------- - - To what extent should libxen be a rewrite or an isolation layer around -some of the existing code ? - - Rewrite: - - Pros: - - avoid the GPL Licence problem potentially more users - - allow do build a cleaner more stable layer - - the existing code is frightening - Cons: - - awful lot of work debugging very hard - - will still require existing Xen code to be running - - splitting interfaces is hard politically and lower the - Open Source efforts toward the project - - Wrappers on top of existing code: - - Pros: - - much smaller code rewrite - - benefits from the bugfixes injected by other patchers upstream - Cons: - - Licence constraint GPL only for apps - - API/ABI isolation may not be easier in that way - - Potentially the API could be implemented as a layer on top of the existing -libxc C code library and then progressively migrating out the existing -dependence to Xen code as the interfaces stabilize. - -Daniel Veillard <veillard(a)redhat.com> - -Mon Oct 24 18:40:19 CEST 2005 -- 2.9.3

2 2

[libvirt] [PATCH 0/2] Add support for preallocated fd memory
by Jaroslav Safka 01 Nov '16

01 Nov '16

Hi, we would like to introduce 3 new elements source,access and allocation in memoryBacking element. <memoryBacking> <source type="file|anonymous"/> <access Mode="shared|private"/> <allocation mode="immediate|ondemand"/> </memoryBacking> If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu -numa node,memdev=mem Should be added to the qemu commandline If access is shared then the share=on parameter should be added to the memory-backend-file e.g. -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu,share=on Also token memAccess in numa cell is used (if not present, default value from memoryBacking is used) Jaroslav Safka (2): Add support for preallocated fd memory Add support for preallocated fd memory docs/schemas/domaincommon.rng | 30 ++++ src/conf/domain_conf.c | 138 +++++++++++++----- src/conf/domain_conf.h | 33 +++++ src/qemu/qemu_command.c | 156 ++++++++++++++++----- src/qemu/qemu_command.h | 4 + .../qemuxml2argv-fd-memory-no-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-no-numa-topology.xml | 91 ++++++++++++ .../qemuxml2argv-fd-memory-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-numa-topology.xml | 94 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology2.args | 36 +++++ .../qemuxml2argv-fd-memory-numa-topology2.xml | 95 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology3.args | 39 ++++++ .../qemuxml2argv-fd-memory-numa-topology3.xml | 96 +++++++++++++ .../qemuxml2argv-memorybacking-set.xml | 32 +++++ .../qemuxml2argv-memorybacking-unset.xml | 32 +++++ tests/qemuxml2argvtest.c | 42 ++++++ .../qemuxml2xmlout-memorybacking-set.xml | 40 ++++++ .../qemuxml2xmlout-memorybacking-unset.xml | 40 ++++++ tests/qemuxml2xmltest.c | 3 + 19 files changed, 1001 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-set.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-unset.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-set.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-unset.xml -- 2.7.4 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

2 3

[libvirt] [PATCH] domain_event.c: Fix a typo
by Kothapally Madhu Pavan 01 Nov '16

01 Nov '16

Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/conf/domain_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63ae9e1..f1249ad 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -1839,7 +1839,7 @@ virDomainEventDispatchDefaultFunc(virConnectPtr conn, virDomainEventJobCompletedPtr ev; ev = (virDomainEventJobCompletedPtr) event; - ((virConnectDomainEventJobCompletedCallback) cb)(conn, dom, + ((virConnectDomainEventJobCompletedCallback)cb)(conn, dom, ev->params, ev->nparams, cbopaque);

2 2

[libvirt] [PATCH v2 python 0/2] fix crash in libvirt_virDomainPin*
by Konstantin Neumoin 01 Nov '16

01 Nov '16

this small patch set: * move common logic of all libvirt_virDomainPin* functions to new helper in util module. * add check for pycpumap length. Changes since v1: - add new helper in util module. Konstantin Neumoin (2): minor clean-up for libvirt_virDomainPin* add check for pycpumap length libvirt-override.c | 131 +++++------------------------------------------------ libvirt-utils.c | 63 ++++++++++++++++++++++++++ libvirt-utils.h | 5 ++ 3 files changed, 79 insertions(+), 120 deletions(-) -- 2.5.5

2 5

[libvirt] VLAN-based direct interface
by Ed Swierk 01 Nov '16

01 Nov '16

In my setup, the network interfaces of several KVM-based VMs all communicate with the outside world via a single host interface, which is in turn connected to an external switch that handles all network policy to/from/between VMs. Traffic between the host and the switch is segregated by VLAN ID, one per vNIC. When I spin up a new VM with one vNIC assigned (say) VLAN ID 101, I run ip link add link eth0 name eth0.101 type vlan id 101. In the libvirt config I write <interface type='direct' trustGuestRxFilters='yes'> <source dev='eth0.101' mode='passthrough'/> <model type='virtio'/> </interface> This causes libvirt to create a macvtap interface attached to eth0.101 in passthrough mode. So far, so good. The guest OS thinks it has a plain old NIC on an untagged switch port. When the guest OS joins an IPv6 link-local solicited-node multicast group, QEMU tells libvirt to add the corresponding multicast MAC address to the macvtap interface. I can even run a trunk port all the way through to the VM, with traffic double-tagged through the switch-host hop. Trouble arises if I change the model from virtio to e1000, to support an application that doesn't (yet) have virtio drivers. QEMU doesn't expose state via query-rx-filter for e1000 interfaces, so libvirt can't sync multicast MAC addresses from the guest to the macvtap interface, so the guest can't talk IPv6. Ideally QEMU would support query-rx-filter for e1000 and other NIC models. But for my application all the careful syncing of guest rx filter state is overkill: I need the macvtap interface to pass all traffic between the guest and host with no filtering at all. I can achieve this simply by enabling promiscuous mode on the macvtap interface. But libvirt creates the interface, and I don't see any way to get libvirt to enable promiscuous mode and leave it enabled. It wouldn't be hard to add another configuration flag that tells libvirt to just put the macvtap interface into promiscuous mode and skip syncing guest rx filters. Perhaps add another value for trustGuestRxFilters, like 'promisc'? However just solving that minor problem seems like piling one hack on top of another: taking a normal interface and attaching a VLAN interface to it, then attaching a macvtap interface to that, and beating the mac out of the macvtap until it behaves like a dumb bridge (or, attaching a bridge to the VLAN interface, creating a tap interface, and enslaving the tap to the bridge, old-school). What I'm really after is just another kind of direct interface that attaches to a host interface, but instead of directing traffic to the guest by MAC address it uses the VLAN ID (and also adds/strips the tag). libvirt could implement this by automating all the steps I just described. Or if the kernel ever sprouts the VLAN equivalent of the macvtap driver (vlanvtap?), libvirt could just use that. Any opinions on first-class support for a VLAN-based direct interface, versus just allowing configuration of promiscuous mode on a macvtap direct interface? --Ed

1 0

[libvirt] [PATCH v3.1 00/10] Implementation of QEMU vhost-scsi
by Eric Farman 01 Nov '16

01 Nov '16

This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host setup via targetcli (SCSI LUN(s) are already defined to host): # targetcli targetcli shell version 2.1.fb35 Copyright 2011-2013 by Datera, Inc and others. For help on commands, type 'help'. /> backstores/block create write_back=false name=disk1 \ dev=/dev/disk/by-id/dm-name-36005076306ffc7630000000000002211 Created block storage object disk1 using /dev/disk/by-id/dm-name-36005076306ffc7630000000000002211. /> vhost/ create Created target naa.5001405df3e54061. Created TPG 1. /> vhost/naa.5001405df3e54061/tpg1/luns create /backstores/block/disk1 Created LUN 0. /> exit Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v3.1: - Rebase - Rebased to current master (31 October) - Included the prereq for the subsystem type in switch statements (oops!) v3: https://www.redhat.com/archives/libvir-list/2016-October/msg01201.html - Rebase - Rebased to current master (26 October) - Comments - Added an early patch to do some additional typecasting in the switch statements of hostdev.subsys.type - Did some reordering of patches, to hopefully flow better - Implemented an activeHostHostdevs list, which is used by the cgroup and security codepaths - doc changes -- s/2.2/2.5/ and s/HBI/HBA/ - Added a "none" protocol type for scsi_host hostdevs (which is invalid) - Restored the apparmor and selinux codepaths that got lost from v1 - Added a proper check for a valid scsi_host protocol, and saving that value within the HostdevDef struct - Fixed a compiler warning with call to virDomainPCIAddressEnsureAddr - Removed the rest of vhostfdSize, since multiple fd's are not allowed by QEMU - Fixed cleanup of vhostfd in error from building -device string - Moved the "conf" chunk from "hotplug" patch to "introduce" patch - Added xml2xml test - Added a proper calculation of "address" in virDomainAuditHostdev - Added a virFileExists check before open(/dev/vhost-scsi) - Addressed a number of lines >80 characters - Things *NOT* done (later?) - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (10): Cleanup switch statements on the hostdev subsystem type qemu: Introduce vhost-scsi capability Introduce a "scsi_host" hostdev type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi test docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 102 ++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 19 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 50 +++- src/qemu/qemu_command.c | 79 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 10 + src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 160 +++++++++++ src/security/security_apparmor.c | 24 +- src/security/security_dac.c | 46 ++++ src/security/security_selinux.c | 51 +++- src/util/virhost.c | 301 +++++++++++++++++++++ src/util/virhost.h | 72 +++++ src/util/virhostdev.c | 155 +++++++++++ src/util/virhostdev.h | 16 ++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml | 1 + tests/qemuxml2xmltest.c | 3 + 41 files changed, 1294 insertions(+), 14 deletions(-) create mode 100644 src/util/virhost.c create mode 100644 src/util/virhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml -- 1.9.1

1 10