- Devel - libvirt List Archives

[libvirt] [PATCH] Remove reference to enum that never existed
by Daniel P. Berrange 14 Dec '16

14 Dec '16

The virDomainSendProcessSignal method says the flags values come from virDomainProcessSignalFlag, but this enum has never existed. No flags are needed for this method. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed under trivial docs rule. src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index b287a39..dd9b800 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6866,7 +6866,7 @@ virDomainSendKey(virDomainPtr domain, * @domain: pointer to domain object * @pid_value: a positive integer process ID, or negative integer process group ID * @signum: a signal from the virDomainProcessSignal enum - * @flags: one of the virDomainProcessSignalFlag values + * @flags: currently unused, pass 0 * * Send a signal to the designated process in the guest * -- 2.9.3

1 0

[libvirt] [PATCH] virjson: Remove const from virJSONValueObjectForeachKeyValue
by Jiri Denemark 14 Dec '16

14 Dec '16

Almost none of our virJSONValue*Get* functions accept const virJSONValue pointers and it wouldn't even make sense since we sometimes modify what we get. And because there is no reason for preventing callers of virJSONValueObjectForeachKeyValue from modifying the values they get in each iteration we can just stop doing it. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virjson.c | 2 +- src/util/virjson.h | 4 ++-- src/util/virqemu.c | 16 ++++++++-------- src/util/virqemu.h | 10 +++++----- src/util/virstoragefile.c | 2 +- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index b42211c0d..3804e7e97 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1321,7 +1321,7 @@ virJSONValueObjectIsNull(virJSONValuePtr object, * during iteration and -1 on generic errors. */ int -virJSONValueObjectForeachKeyValue(const virJSONValue *object, +virJSONValueObjectForeachKeyValue(virJSONValuePtr object, virJSONValueObjectIteratorFunc cb, void *opaque) { diff --git a/src/util/virjson.h b/src/util/virjson.h index 5b4f17253..122de96c5 100644 --- a/src/util/virjson.h +++ b/src/util/virjson.h @@ -172,10 +172,10 @@ char *virJSONValueToString(virJSONValuePtr object, bool pretty); typedef int (*virJSONValueObjectIteratorFunc)(const char *key, - const virJSONValue *value, + virJSONValuePtr value, void *opaque); -int virJSONValueObjectForeachKeyValue(const virJSONValue *object, +int virJSONValueObjectForeachKeyValue(virJSONValuePtr object, virJSONValueObjectIteratorFunc cb, void *opaque); diff --git a/src/util/virqemu.c b/src/util/virqemu.c index 7849d8b3e..2e9e65f9e 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -42,7 +42,7 @@ struct virQEMUCommandLineJSONIteratorData { static int virQEMUBuildCommandLineJSONRecurse(const char *key, - const virJSONValue *value, + virJSONValuePtr value, virBufferPtr buf, virQEMUBuildCommandLineJSONArrayFormatFunc arrayFunc, bool nested); @@ -51,7 +51,7 @@ virQEMUBuildCommandLineJSONRecurse(const char *key, int virQEMUBuildCommandLineJSONArrayBitmap(const char *key, - const virJSONValue *array, + virJSONValuePtr array, virBufferPtr buf) { ssize_t pos = -1; @@ -81,10 +81,10 @@ virQEMUBuildCommandLineJSONArrayBitmap(const char *key, int virQEMUBuildCommandLineJSONArrayNumbered(const char *key, - const virJSONValue *array, + virJSONValuePtr array, virBufferPtr buf) { - const virJSONValue *member; + virJSONValuePtr member; char *prefix = NULL; size_t i; int ret = 0; @@ -114,7 +114,7 @@ virQEMUBuildCommandLineJSONArrayNumbered(const char *key, /* internal iterator to handle nested object formatting */ static int virQEMUBuildCommandLineJSONIterate(const char *key, - const virJSONValue *value, + virJSONValuePtr value, void *opaque) { struct virQEMUCommandLineJSONIteratorData *data = opaque; @@ -140,7 +140,7 @@ virQEMUBuildCommandLineJSONIterate(const char *key, static int virQEMUBuildCommandLineJSONRecurse(const char *key, - const virJSONValue *value, + virJSONValuePtr value, virBufferPtr buf, virQEMUBuildCommandLineJSONArrayFormatFunc arrayFunc, bool nested) @@ -225,7 +225,7 @@ virQEMUBuildCommandLineJSONRecurse(const char *key, * Returns 0 on success -1 on error. */ int -virQEMUBuildCommandLineJSON(const virJSONValue *value, +virQEMUBuildCommandLineJSON(virJSONValuePtr value, virBufferPtr buf, virQEMUBuildCommandLineJSONArrayFormatFunc array) { @@ -264,7 +264,7 @@ virQEMUBuildObjectCommandlineFromJSON(const char *type, char * -virQEMUBuildDriveCommandlineFromJSON(const virJSONValue *srcdef) +virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef) { virBuffer buf = VIR_BUFFER_INITIALIZER; char *ret = NULL; diff --git a/src/util/virqemu.h b/src/util/virqemu.h index f3c2b6956..539d62ab1 100644 --- a/src/util/virqemu.h +++ b/src/util/virqemu.h @@ -30,16 +30,16 @@ # include "virstorageencryption.h" typedef int (*virQEMUBuildCommandLineJSONArrayFormatFunc)(const char *key, - const virJSONValue *array, + virJSONValuePtr array, virBufferPtr buf); int virQEMUBuildCommandLineJSONArrayBitmap(const char *key, - const virJSONValue *array, + virJSONValuePtr array, virBufferPtr buf); int virQEMUBuildCommandLineJSONArrayNumbered(const char *key, - const virJSONValue *array, + virJSONValuePtr array, virBufferPtr buf); -int virQEMUBuildCommandLineJSON(const virJSONValue *value, +int virQEMUBuildCommandLineJSON(virJSONValuePtr value, virBufferPtr buf, virQEMUBuildCommandLineJSONArrayFormatFunc array); @@ -47,7 +47,7 @@ char *virQEMUBuildObjectCommandlineFromJSON(const char *type, const char *alias, virJSONValuePtr props); -char *virQEMUBuildDriveCommandlineFromJSON(const virJSONValue *src); +char *virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr src); void virQEMUBuildBufferEscapeComma(virBufferPtr buf, const char *str); void virQEMUBuildLuksOpts(virBufferPtr buf, diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index f750e121a..9ec005d50 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2990,7 +2990,7 @@ static const struct virStorageSourceJSONDriverParser jsonParsers[] = { static int virStorageSourceParseBackingJSONDeflattenWorker(const char *key, - const virJSONValue *value, + virJSONValuePtr value, void *opaque) { virJSONValuePtr retobj = opaque; -- 2.11.0

2 1

[libvirt] [PATCH] libxl: add QED disk format support
by Cédric Bosdonnat 14 Dec '16

14 Dec '16

If libxl has QED disk format support, then pass the feature over to the user. --- src/libxl/libxl_conf.c | 11 +++++++++++ src/xenconfig/xen_xl.c | 6 ++++++ 2 files changed, 17 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 288712f65..02945ae1a 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -745,6 +745,12 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk) x_disk->format = LIBXL_DISK_FORMAT_RAW; x_disk->backend = LIBXL_DISK_BACKEND_TAP; break; +#ifdef LIBXL_HAVE_QED + case VIR_STORAGE_FILE_QED: + x_disk->format = LIBXL_DISK_FORMAT_QED; + x_disk->backend = LIBXL_DISK_BACKEND_QDISK; + break; +#endif default: virReportError(VIR_ERR_INTERNAL_ERROR, _("libxenlight does not support disk format %s " @@ -762,6 +768,11 @@ libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk) case VIR_STORAGE_FILE_QCOW2: x_disk->format = LIBXL_DISK_FORMAT_QCOW2; break; +#ifdef LIBXL_HAVE_QED + case VIR_STORAGE_FILE_QED: + x_disk->format = LIBXL_DISK_FORMAT_QED; + break; +#endif case VIR_STORAGE_FILE_VHD: x_disk->format = LIBXL_DISK_FORMAT_VHD; break; diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index bcdd35527..98436982a 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -393,6 +393,12 @@ xenParseXLDisk(virConfPtr conf, virDomainDefPtr def) case LIBXL_DISK_FORMAT_EMPTY: break; + +#ifdef LIBXL_HAVE_QED + case LIBXL_DISK_FORMAT_QED: + disk->src->format = VIR_STORAGE_FILE_QED; + break; +#endif } switch (libxldisk->backend) { -- 2.11.0

1 0

[libvirt] [PATCH V3 0/2] Allow hot plugged host CPUs
by Viktor Mihajlovski 14 Dec '16

14 Dec '16

This is a rework of the original patch allowing to use all host CPUs if the cpuset controller is not configured by libvirt. The major enhancement is that we won't try to retrieve the online host CPU map on platforms where this is not supported and just fall back to the old behavior. V3: - Added new function (in seperate patch) to find out whether the host CPU online map can be retrieved gracefully V2: - Avoid memory leak Viktor Mihajlovski (2): util: Allow to query the presence of host CPU bitmaps qemu: Allow use of hot plugged host CPUs if no affinity set src/libvirt_private.syms | 1 + src/qemu/qemu_process.c | 33 ++++++++++++++++++++++++--------- src/util/virhostcpu.c | 10 ++++++++++ src/util/virhostcpu.h | 1 + 4 files changed, 36 insertions(+), 9 deletions(-) -- 1.9.1

3 7

[libvirt] [PATCH] Avoid variable named 'stat'
by Daniel P. Berrange 14 Dec '16

14 Dec '16

Using a variable named 'stat' clashes with the system function 'stat()' causing compiler warnings on some platforms cc1: warnings being treated as errors ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow] Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix. src/qemu/qemu_monitor_text.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index a2a5885..bc83218 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -601,7 +601,7 @@ int qemuMonitorTextGetVirtType(qemuMonitorPtr mon, static int parseMemoryStat(char **text, unsigned int tag, - const char *search, virDomainMemoryStatPtr stat) + const char *search, virDomainMemoryStatPtr mstat) { char *dummy; unsigned long long value; @@ -625,8 +625,8 @@ static int parseMemoryStat(char **text, unsigned int tag, case VIR_DOMAIN_MEMORY_STAT_AVAILABLE: value >>= 10; } - stat->tag = tag; - stat->val = value; + mstat->tag = tag; + mstat->val = value; return 1; } return 0; -- 2.9.3

1 0

[libvirt] [PATCH] docs: Use href_base in absolute links
by Martin Kletzander 14 Dec '16

14 Dec '16

That way all links work even if you click them in a subdirectory. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- docs/page.xsl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/page.xsl b/docs/page.xsl index fcb51916ce25..1d662c670686 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -104,9 +104,9 @@ </div> <div id="jumplinks"> <ul> - <li><a href="downloads.html">Download</a></li> - <li><a href="contribute.html">Contribute</a></li> - <li><a href="docs.html">Learn</a></li> + <li><a href="{$href_base}downloads.html">Download</a></li> + <li><a href="{$href_base}contribute.html">Contribute</a></li> + <li><a href="{$href_base}docs.html">Learn</a></li> </ul> </div> <div id="search"> @@ -122,8 +122,8 @@ <div id="contact"> <h3>Contact</h3> <ul> - <li><a href="contact.html#email">email</a></li> - <li><a href="contact.html#irc">irc</a></li> + <li><a href="{$href_base}contact.html#email">email</a></li> + <li><a href="{$href_base}contact.html#irc">irc</a></li> </ul> </div> <div id="community"> @@ -136,7 +136,7 @@ </ul> </div> <div id="conduct"> - Participants in the libvirt project agree to abide by <a href="governance.html#codeofconduct">the project code of conduct</a> + Participants in the libvirt project agree to abide by <a href="{$href_base}governance.html#codeofconduct">the project code of conduct</a> </div> <br class="clear"/> </div> -- 2.11.0

2 1

[libvirt] [PATCH jenkins-ci] Add libvirt-go to build
by Daniel P. Berrange 14 Dec '16

14 Dec '16

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- jobs/go.yaml | 71 ++++++++++++++++++++++++++++++++++++++++++++++++ projects/libvirt-go.yaml | 14 ++++++++++ 2 files changed, 85 insertions(+) create mode 100644 jobs/go.yaml create mode 100644 projects/libvirt-go.yaml diff --git a/jobs/go.yaml b/jobs/go.yaml new file mode 100644 index 0000000..ce6f79b --- /dev/null +++ b/jobs/go.yaml @@ -0,0 +1,71 @@ + +- job-template: + id: go-build-job + name: '{name}-{branch}-build' + project-type: matrix + description: '{title} Build' + autogen_args: '' + workspace: '{name}-{branch}' + block-downstream: true + block-upstream: true + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 1000 + scm: + - git: + url: git://n64.pufty.ci.centos.org/{name}.git + branches: + - origin/{branch} + clean: + after: true + skip-tag: true + wipe-workspace: false + triggers: + - reverse: + jobs: '{obj:parent_jobs}' + - pollscm: + cron: "H/20 * * * *" + axes: + - axis: + name: systems + type: slave + values: '{obj:machines}' + builders: + - shell: | + go build -v + publishers: + - email: + recipients: '{obj:spam}' + notify-every-unstable-build: true + send-to-individuals: false + +- job-template: + id: go-check-job + name: '{name}-{branch}-check' + project-type: matrix + description: '{title} Check' + check_env: '' + workspace: '{name}-{branch}' + block-downstream: true + block-upstream: true + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 1000 + triggers: + - reverse: + jobs: '{obj:parent_jobs}' + axes: + - axis: + name: systems + type: slave + values: '{obj:machines}' + builders: + - shell: | + go test -tags api + publishers: + - email: + recipients: '{obj:spam}' + notify-every-unstable-build: true + send-to-individuals: false diff --git a/projects/libvirt-go.yaml b/projects/libvirt-go.yaml new file mode 100644 index 0000000..8ad7a2e --- /dev/null +++ b/projects/libvirt-go.yaml @@ -0,0 +1,14 @@ + +- project: + name: libvirt-go + machines: + - libvirt-centos-7 + - libvirt-fedora-23 + - libvirt-fedora-24 + - libvirt-fedora-rawhide + title: Libvirt Go + jobs: + - go-build-job: + parent_jobs: 'libvirt-master-build' + - go-check-job: + parent_jobs: 'libvirt-go-master-build' -- 2.9.3

2 2

[libvirt] [PATCH] Deal with gnutls 3.5.6 regression
by Daniel P. Berrange 14 Dec '16

14 Dec '16

I was not originally planning to do anything for the gnutls 3.5.6 regression: https://www.redhat.com/archives/libvir-list/2016-November/msg00816.html but there's still no immediate sign of the new 3.5.7 release, so while I still don't want to workaround the bug in libvirt, we can at least blacklist that version of gnutls in the test suite, so 'make check' passes on affected systems while we're waiting for 3.5.7 to arrive. Daniel P. Berrange (1): tests: blacklist gnutls 3.5.6 for wildcard tests tests/virnettlssessiontest.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.9.3

3 6

[libvirt] [PATCH] qemu: Fix virQEMUCapsFindTarget on ppc64le
by Jiri Denemark 13 Dec '16

13 Dec '16

virQEMUCapsFindTarget is supposed to find an alternative QEMU binary if qemu-system-$GUEST_ARCH doesn't exist. The alternative is using host architecture when it is compatible with $GUEST_ARCH. But a special treatment has to be applied for ppc64le since the QEMU binary is always called qemu-system-ppc64. Broken by me in v2.2.0-171-gf2e71550d. https://bugzilla.redhat.com/show_bug.cgi?id=1403745 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_capabilities.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 081afc566..f4ca84e98 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -482,13 +482,13 @@ static virArch virQEMUCapsFindTarget(virArch hostarch, virArch guestarch) { + if (virQEMUCapsGuestIsNative(hostarch, guestarch)) + guestarch = hostarch; + /* Both ppc64 and ppc64le guests can use the ppc64 target */ if (ARCH_IS_PPC64(guestarch)) guestarch = VIR_ARCH_PPC64; - if (virQEMUCapsGuestIsNative(hostarch, guestarch)) - guestarch = hostarch; - return guestarch; } -- 2.11.0

2 3

[libvirt] [PATCH 0/2] Fix copy-pasta errors in config loading for aux daemons
by Peter Krempa 13 Dec '16

13 Dec '16

Apparently the option is not configured very often since nobody figured it out until now. Peter Krempa (2): lock: Fix loading of config file for the lock daemon log: Fix loading of conf file for log daemon src/locking/lock_daemon_config.c | 2 +- src/logging/log_daemon_config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.11.0

2 3