- Devel - libvirt List Archives

[libvirt] [PATCH 0/9] Add Jansson support
by Ján Tomko 12 Apr '18

12 Apr '18

Prefer Jansson, but allow fallback/choice of yajl. Support for yajl can hopefully be dropped after we ditch CentOS 6 which has no Jansson. Ján Tomko (9): virmacmaptest: depend on yajl for 'empty' test virjsontest: Use a more stable floating point number for testing configure: rename LIBVIRT_*_YAJL to LIBVIRT_*_JSON Introduce WITH_JSON Introduce JSON_CFLAGS and JSON_LIBS virt-json.m4: generalize yajl dependency build: link setuid_rpc_client against JSON_LIBS virjson: add support for Jansson virt-json.m4: simplify QEMU check configure.ac | 10 +- m4/virt-json.m4 | 86 ++++++++++++++++ m4/virt-yajl.m4 | 55 ----------- src/Makefile.am | 9 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 4 +- src/util/Makefile.inc.am | 4 +- src/util/virjson.c | 219 +++++++++++++++++++++++++++++++++++++++++ tests/Makefile.am | 12 +-- tests/cputest.c | 16 +-- tests/libxlxml2domconfigtest.c | 4 +- tests/qemuagenttest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/qemucaps2xmltest.c | 2 +- tests/qemucommandutiltest.c | 2 +- tests/qemuhelptest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 2 +- tests/virjsontest.c | 2 +- tests/virmacmaptest.c | 3 + tests/virmocklibxl.c | 4 +- tests/virnetdaemontest.c | 2 +- tests/virstoragetest.c | 4 +- 23 files changed, 354 insertions(+), 96 deletions(-) create mode 100644 m4/virt-json.m4 delete mode 100644 m4/virt-yajl.m4 -- 2.16.1

3 22

[libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object
by Michal Privoznik 12 Apr '18

12 Apr '18

In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into virObject. Well, this requires 'virObject' member to be stored on the first position of the struct. This adjustment is missing in the original commit leading to all sorts of funny memleaks and data corruptions. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 89a7131fdb..1426f115ed 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -57,6 +57,7 @@ # include "virtypedparam.h" # include "virsavecookie.h" # include "virresctrl.h" +# include "virobject.h" /* forward declarations of all device types, required by * virDomainDeviceDef @@ -1180,6 +1181,7 @@ typedef virDomainChrSourceReconnectDef *virDomainChrSourceReconnectDefPtr; /* The host side information for a character device. */ struct _virDomainChrSourceDef { + virObject parent; int type; /* virDomainChrType */ virObjectPtr privateData; union { -- 2.16.1

5 5

[libvirt] [dbus PATCH 0/6] More methods for Domain interface
by Katerina Koukiou 12 Apr '18

12 Apr '18

Katerina Koukiou (6): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface data/org.libvirt.Domain.xml | 28 +++++++- src/domain.c | 166 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 10 +++ 3 files changed, 201 insertions(+), 3 deletions(-) -- 2.15.0

1 3

[libvirt] [jenkins-ci PATCH] guests: Clean up packages after update
by Andrea Bolognani 12 Apr '18

12 Apr '18

The package cache can grow to eat up a lot of disk space, and not removing unused packages can lead to upgrade issues down the line for fast moving distributions such as Fedora Rawhide. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/base.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 53cbd65..f419433 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -117,6 +117,25 @@ when: - package_format == 'pkg' +- name: Clean up packages after update + command: yum clean packages -y + args: + warn: no + when: + - package_format == 'rpm' + +- name: Clean up packages after update + apt: + autoclean: yes + autoremove: yes + when: + - package_format == 'deb' + +- name: Clean up packages after update + shell: pkg clean -y && pkg autoremove -y + when: + - package_format == 'pkg' + - name: Configure hostname hostname: name: '{{ inventory_hostname }}' -- 2.14.3

3 4

[libvirt] [dbus PATCH 0/6] More methods for Domain Interface
by Katerina Koukiou 12 Apr '18

12 Apr '18

Katerina Koukiou (6): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface data/org.libvirt.Domain.xml | 28 +++++++- src/domain.c | 166 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 10 +++ 3 files changed, 201 insertions(+), 3 deletions(-) -- 2.15.0

1 6

[libvirt] [jenkins-ci PATCH] guests: Fix intltool-update on FreeBSD
by Andrea Bolognani 12 Apr '18

12 Apr '18

The tool became completely unusable after the switch to Perl 5.26; workaround the issue while we wait for a proper solution. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Using regexes to match regexes: it's regexception. guests/tasks/kludges.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml index d0ff6cb..4dd06a4 100644 --- a/guests/tasks/kludges.yml +++ b/guests/tasks/kludges.yml @@ -46,3 +46,16 @@ command: cap_mkdb /etc/login.conf when: - loginconf.changed + +# FreeBSD switched to Perl 5.26, which makes a long existing warning in +# intltool-update turn into an error and causes jobs to fail. While we +# wait for the port to be fixed, we can patch things up ourselves. +# +# See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227444 +- name: Fix intltool-update + replace: + path: /usr/local/bin/intltool-update + regexp: '^(.*) !~ /\\\$\{\?\$2\}\?/;$' + replace: '\1 !~ /\\$\\{?$2}?/;' + when: + - os_name == 'FreeBSD' -- 2.14.3

2 1

[libvirt] [PATCH jenkins-ci] Run "make check" for osinfo-db
by Daniel P. Berrangé 12 Apr '18

12 Apr '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- projects/osinfo-db.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/projects/osinfo-db.yaml b/projects/osinfo-db.yaml index 0dd73b5..7f83722 100644 --- a/projects/osinfo-db.yaml +++ b/projects/osinfo-db.yaml @@ -17,8 +17,12 @@ command: | $MAKE -j{smp} all $MAKE install OSINFO_DB_TARGET="--system" - - generic-rpm-job: + - generic-check-job: parent_jobs: 'osinfo-db-master-build' + command: | + $MAKE -j{smp} check + - generic-rpm-job: + parent_jobs: 'osinfo-db-master-check' machines: - libvirt-centos-7 - libvirt-fedora-26 -- 2.14.3

3 2

[libvirt] path for user provided all-guest-read-only content
by Christian Ehrhardt 12 Apr '18

12 Apr '18

Feel free to read [1] for context, here the quote that made me poll for opinions: "it would be nice in the future to have some standardized path for user provided guest-read-only stuff" The TL;DR of their case is: - extra info they want to pass, but is not part of libvirts guest description (qemu-cmdline in their case) - apparmor blocks their access to an unknown path There are no reliable paths today to put data for a guest. Guests are names with their ID in the paths - so even knowing the guest name - they are not predictable (for example /var/lib/libvirt/qemu/domain-1-guestname/ might be different next time). Due to that I can see their use-case for "let all read from there", but OTOH "let all" always feels wrong at first from a security POV. Therefore i wanted to poll for opinions on this before suggesting any change. [1]: https://github.com/coreos/bugs/issues/2083#issuecomment-380404427 -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

2 1

[libvirt] [PATCH] vbox: Make vboxCommonDriver static
by Michal Privoznik 12 Apr '18

12 Apr '18

This is a global variable, but it isn't accessible from outside of the file its declared in. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed as trivial. src/vbox/vbox_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 3bcca43d32..b5f8456f8d 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -7978,7 +7978,7 @@ vboxDomainSendKey(virDomainPtr dom, * Function Tables */ -virHypervisorDriver vboxCommonDriver = { +static virHypervisorDriver vboxCommonDriver = { .name = "VBOX", .connectOpen = vboxConnectOpen, /* 0.6.3 */ .connectClose = vboxConnectClose, /* 0.6.3 */ -- 2.16.1

1 0

[libvirt] virNetSocketNewListenTCP tries just one address
by Olaf Hering 11 Apr '18

11 Apr '18

To rescue this bug from the noise in a subthread: If a hostname resolves to more than one address and the host currently configured itself for just IPv4, doing a bind() to some IPv6 address will fail. As a result an error is returned instead of continuing with the next item in 'runp'. > Mär 20 09:35:52 macintyre-old libvirtd[4527]: 2018-03-20 08:35:52.521+0000: 4531: error : virNetSocketNewListenTCP:389 : Unable to bind to port: Cannot assign requested address After further debugging: 27672 16:04:46.774906 socket(PF_INET6, SOCK_STREAM, IPPROTO_TCP) = 35 27672 16:04:46.775041 setsockopt(35, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0 27672 16:04:46.775172 setsockopt(35, SOL_IPV6, IPV6_V6ONLY, [1], 4) = 0 27672 16:04:46.775302 bind(35, {sa_family=AF_INET6, sin6_port=htons(49152), inet_pton(AF_INET6, "2620:113:80c0:8000:10:161:8:197", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0}, 28) = -1 EADDRNOTAVAIL (Cannot assign requested address) 27672 16:04:46.775455 gettid() = 27672 27672 16:04:46.775590 write(4, "2018-03-20 15:04:46.775+0000: 27672: error : virNetSocketNewListenTCP:389 : Unable to bind to port: Cannot assign requested address\n", 132) = 132 27672 16:04:46.775742 gettid() = 27672 27672 16:04:46.775875 write(4, "2018-03-20 15:04:46.775+0000: 27672: info : virObjectUnref:350 : OBJECT_UNREF: obj=0x7fa4bc003530\n", 98) = 98 27672 16:04:46.776026 gettid() = 27672 So for some reason libvirtd tries to bind to ipv6 even if the host does not have that ipv6 address at this point, only the link-local address. Not sure if there is a way to detect that within libvirt. Perhaps it should just move on with the runp list and try the next one? Olaf

3 6