- Devel - libvirt List Archives

[libvirt] [PATCHv2] Remove redundant virFileIsExecutable check
by Radostin Stoyanov 13 Apr '18

13 Apr '18

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since commit 9ae992f, virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov <rstoyanov1(a)gmail.com> --- src/bhyve/bhyve_capabilities.c | 4 ---- src/qemu/qemu_capabilities.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 381cc0de3..e13085b1d 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -179,8 +179,6 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) binary = virFindFileInPath("grub-bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; cmd = virCommandNew(binary); virCommandAddArg(cmd, "--help"); @@ -315,8 +313,6 @@ virBhyveProbeCaps(unsigned int *caps) binary = virFindFileInPath("bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; if ((ret = bhyveProbeCapsRTC_UTC(caps, binary))) goto out; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 27180e850..13c6c85d8 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -653,7 +653,7 @@ virQEMUCapsFindBinary(const char *format, ret = virFindFileInPath(binary); VIR_FREE(binary); - if (ret && virFileIsExecutable(ret)) + if (ret) goto out; VIR_FREE(ret); -- 2.14.3

2 1

[libvirt] [dbus PATCH v2 00/22] More APIs for Domain Interface
by Katerina Koukiou 13 Apr '18

13 Apr '18

Changes from v1: Added some more APIs. Katerina Koukiou (22): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface Introduce virtDBusDomainJobTypeToString function Implement GetJobInfo method for Domain interface Implement AbortJob for Domain interface Implement MigrateSetMaxDowntime method for Domain interface Implement MigrateGetMaxDowntime method for Domain Interface Implement ManagedSave method for Domain Interface Implement HasManagedSaveImage method for Domain Interface Implement ManagedSaveRemove method for Domain Interface Implement SetVcpus method for Domain Interface Implement GetMemoryParameters method for Domain Interface Implement GetBlkioParameters method for domain Interface Implement Updated property for Domain Interface Implement MigrateGetMaxSpeed method for Domain Interface Implement MigrateSetMaxSpeed method for Domain Interface Implement SetMemory method for Domain Interface Implement GetSchedulerParameters method for Domain Interface data/org.libvirt.Domain.xml | 111 +++++++- src/domain.c | 599 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 37 ++- 3 files changed, 742 insertions(+), 5 deletions(-) -- 2.15.0

2 40

[libvirt] [PATCH] Remove redundant virFileIsExecutable check
by Radostin Stoyanov 13 Apr '18

13 Apr '18

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since the commit 9ae992f virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov <rstoyanov1(a)gmail.com> --- src/bhyve/bhyve_capabilities.c | 4 ---- src/qemu/qemu_capabilities.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 381cc0de3..e13085b1d 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -179,8 +179,6 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) binary = virFindFileInPath("grub-bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; cmd = virCommandNew(binary); virCommandAddArg(cmd, "--help"); @@ -315,8 +313,6 @@ virBhyveProbeCaps(unsigned int *caps) binary = virFindFileInPath("bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; if ((ret = bhyveProbeCapsRTC_UTC(caps, binary))) goto out; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 27180e850..5ebc72f6f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -653,7 +653,7 @@ virQEMUCapsFindBinary(const char *format, ret = virFindFileInPath(binary); VIR_FREE(binary); - if (ret && virFileIsExecutable(ret)) + if (ret == NULL) goto out; VIR_FREE(ret); -- 2.14.3

2 2

[libvirt] [PATCH] tests: remove FLAG_JSON from xml2argvtest
by Ján Tomko 12 Apr '18

12 Apr '18

Unused as of commit <1e9a083>. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. tests/qemuxml2argvtest.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 3a328e02a2..472f7b28fe 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -265,8 +265,7 @@ static virStorageDriver fakeStorageDriver = { typedef enum { FLAG_EXPECT_FAILURE = 1 << 0, FLAG_EXPECT_PARSE_ERROR = 1 << 1, - FLAG_JSON = 1 << 2, - FLAG_FIPS = 1 << 3, + FLAG_FIPS = 1 << 2, } virQemuXML2ArgvTestFlags; struct testInfo { @@ -462,9 +461,6 @@ testCompareXMLToArgv(const void *data) virSetConnectSecret(conn); virSetConnectStorage(conn); - if (virQEMUCapsGet(info->qemuCaps, QEMU_CAPS_MONITOR_JSON)) - flags |= FLAG_JSON; - if (virQEMUCapsGet(info->qemuCaps, QEMU_CAPS_ENABLE_FIPS)) flags |= FLAG_FIPS; -- 2.16.1

1 0

[libvirt] [PATCH 0/8] Simplify & standarize more parts of driver URI handling
by Daniel P. Berrangé 12 Apr '18

12 Apr '18

The motivating goal of this series was/is to make it possible to answer whether there is any driver registered to handle a given URI scheme without having to call into the drivers. Ultimately this ended up being a nice simplification and cleanup of driver URI opening code, removing repetative logic from all drivers. Daniel P. Berrangé (8): xen: encourage use of xen:///system URI as preferred format lxc: allow use of lxc:///system URI as preferred format driver: introduce a driver method for probing default URIs driver: allow drivers to indicate if they permit remote connections driver: declare supported URI schemes in virConnectDriver struct driver: ensure NULL URI isn't passed to drivers with whitelisted URIs driver: enforce a non-NULL URI scheme driver: ensure URI path is non-NULL to simplify drivers docs/drvlxc.html.in | 34 ++++++------- docs/drvxen.html.in | 14 +++--- docs/hvsupport.pl | 6 +-- docs/remote.html.in | 6 +-- docs/uri.html.in | 16 +++---- examples/lxcconvert/virt-lxc-convert | 2 +- src/bhyve/bhyve_driver.c | 48 +++++++++---------- src/driver-hypervisor.h | 4 ++ src/driver.h | 8 ++++ src/esx/esx_driver.c | 31 +----------- src/hyperv/hyperv_driver.c | 24 +--------- src/interface/interface_backend_netcf.c | 47 +++++++----------- src/interface/interface_backend_udev.c | 47 +++++++----------- src/libvirt.c | 69 +++++++++++++++++++++++--- src/libxl/libxl_driver.c | 58 +++++++++++----------- src/lxc/lxc_driver.c | 56 ++++++++++------------ src/lxc/lxc_process.c | 4 +- src/network/bridge_driver.c | 47 +++++++----------- src/node_device/node_device_driver.c | 45 +++++++---------- src/node_device/node_device_hal.c | 2 + src/node_device/node_device_udev.c | 2 + src/nwfilter/nwfilter_driver.c | 35 +++++--------- src/openvz/openvz_driver.c | 70 +++++++++++++-------------- src/phyp/phyp_driver.c | 9 +--- src/qemu/qemu_driver.c | 85 +++++++++++++++------------------ src/remote/remote_driver.c | 74 +++++++++++++--------------- src/secret/secret_driver.c | 47 +++++++----------- src/storage/storage_driver.c | 47 +++++++----------- src/test/test_driver.c | 18 ++----- src/uml/uml_driver.c | 71 +++++++++++++-------------- src/vbox/vbox_common.c | 26 ++++------ src/vbox/vbox_driver.c | 18 ++----- src/vmware/vmware_driver.c | 29 ++++------- src/vz/vz_driver.c | 25 ++-------- src/xenapi/xenapi_driver.c | 6 +-- tools/libvirt-guests.sysconf | 2 +- tools/virsh.pod | 4 +- tools/virt-login-shell.c | 2 +- 38 files changed, 489 insertions(+), 649 deletions(-) -- 2.14.3

2 13

[libvirt] CfP for VHPC ‘18 - Papers due May 15 (extended) for the 13th Virtualization in High-Performance Cloud Computing Workshop
by VHPC 18 12 Apr '18

12 Apr '18

*Please accept our apologies if you receive multiple copies of this Call for Papers====================================================================CALL FOR PAPERS 13th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '18)held in conjunction with the International Supercomputing Conference - High Performance,June 24-28, 2018, Frankfurt, Germany.(Springer LNCS Proceedings) ====================================================================Date: June 28, 2018Workshop URL: http://vhpc.org <http://vhpc.org>Paper Submission Deadline: May 15, 2018 (extended)Springer LNCS, rolling abstract submissionAbstract/Paper Submission Link: https://edas.info/newPaper.php?c=24355 <https://edas.info/newPaper.php?c=24355>Special Track: GPU - Accelerator Virtualization Call for PapersVirtualization technologies constitute a key enabling factor for flexible resource managementin modern data centers, and particularly in cloud environments. Cloud providers need tomanage complex infrastructures in a seamless fashion to support the highly dynamic andheterogeneous workloads and hosted applications customers deploy. Similarly, HPCenvironments have been increasingly adopting techniques that enable flexible managementof vast computing and networking resources, close to marginal provisioning cost, which isunprecedented in the history of scientific and commercial computing.Various virtualization technologies contribute to the overall picture in different ways: machinevirtualization, with its capability to enable consolidation of multiple underutilized servers withheterogeneous software and operating systems (OSes), and its capability to live-migrate afully operating virtual machine (VM) with a very short downtime, enables novel and dynamicways to manage physical servers; OS-level virtualization (i.e., containerization), with itscapability to isolate multiple user-space environments and to allow for their coexistencewithin the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; I/O Virtualization allows physical network interfaces to take traffic from multiple VMs or containers; network virtualization, with its capability to create logical network overlays that are independent of theunderlying physical topology is furthermore enabling virtualization of HPC infrastructures. PublicationAccepted papers will be published in a Springer LNCS proceedings volume.Topics of InterestThe VHPC program committee solicits original, high-quality submissions related tovirtualization across the entire software stack with a special focus on the intersection of HPCand the cloud.Major Topics- Virtualization in supercomputing environments, HPC clusters, HPC in the cloud and grids- OS-level virtualization and containers (LXC, Docker, rkt, Singularity, Shifter, i.a.)- Lightweight/specialized operating systems in conjunction with virtual machines- Novel unikernels and use cases for virtualized HPC environments- Performance improvements for or driven by unikernels- Tool support for unikernels: configuration/build environments, debuggers, profilers- Hypervisor extensions to mitigate side-channel attacks ([micro-]architectural timing attacks, privilege escalation)- VM & Container trust and security- Containers inside VMs with hypervisor isolation- GPU virtualization operationalization- Approaches to GPGPU virtualization including API remoting and hypervisor abstraction- Optimizations of virtual machine monitor platforms and hypervisors- Hypervisor support for heterogeneous resources (GPUs, co-processors, FPGAs, etc.)- Virtualization support for emerging memory technologies- Virtualization in enterprise HPC and microvisors- Software defined networks and network virtualization- Management, deployment of virtualized environments and orchestration (Kubernetes i.a.)- Workflow-pipeline container-based composability - Checkpointing facilitation utilizing containers and VMs - Emerging topics including multi-kernel approaches and NUMA in hypervisors- Operating MPI in containers/VMs and Unikernels - Virtualization in data intensive computing (big data) - HPC convergence- Adaptation of HPC technologies in the cloud (high performance networks, RDMA, etc.)- Performance measurement, modelling and monitoring of virtualized/cloud workloads- Latency-and jitter sensitive workloads in virtualized/containerized environments- I/O virtualization (including applications, SR-IOV, i.a.) - Hybrid local facility + cloud compute and based storage systems, cloudbursting- FPGA and many-core accelerator virtualization- Job scheduling/control/policy and container placement in virtualized environments- Cloud reliability, fault-tolerance and high-availability- QoS and SLA in virtualized environments- IaaS platforms, cloud frameworks and APIs- Energy-efficient and power-aware virtualization- Configuration management tools for containers (including in OpenStack, Ansible, i.a.)- ARM-based hypervisors, ARM virtualization extensionsSpecial Track: GPU - Accelerator VirtualizationGPU virtualization technologies, performance and benchmarking, integration withworkflow scheduling systems, integration to cluster managers.GPUs are taking on many HPC workload areas, especially in deep learning withinmachine learning. In addition, a lot of workload is being pushed to elastic environments utilizing various virtualization technologies on different levels like hypervisors (e.g. VMWare, Xen, KVM), kernel (Docker, Kubernetes) or on the resource managerlevel (YARN, Mesos). In this track we invite submissions addressing these problems. Suggested Themes and Topics:Technology - What technologies and best practices exist for GPU - hardware accelerator virtualization and usage of hardware accelerators in virtual environments on the hypervisor, kernel or resource manager levelDevelopers - Real-life experience when addressing HPC/ML/DL problems with GPUs or hardware accelerators in virtual environmentsPerformance - Performance comparisons between different technologies / solutionsThe Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims tobring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchangeof knowledge and experience, enabling research to ultimately provide novelsolutions for virtualized computing systems of tomorrow.The workshop will be one day in length, composed of 20 min paper presentations, eachfollowed by 10 min discussion sections, plus lightning talks that are limited to 5 minutes.Presentations may be accompanied by interactive demonstrations.KeynotesGregory M. Kurtzer, CEO Syslabs Inc. Singularity: Application containers using operating system environment virtualization.Josh Simons, HPC Chief Technologist, VMWare, Inc. Practical Aspects of On-Premises Virtualized High Performance Computing.Important DatesMay 15, 2018 (extended) - Paper submission deadline (Springer LNCS)May 30, 2018 - Acceptance notification June 28, 2018 - Workshop DayJuly 12, 2018 - Camera-ready version dueChairMichael Alexander (chair), Institute of Science and Technology, AustriaAnastassios Nanos (co-chair), OnApp, UKRomeo Kienzler (co-chair), IBM, SwitzerlandProgram committeeStergios Anastasiadis, University of Ioannina, Greece Jakob Blomer, CERN, Europe Eduardo César, Universidad Autonoma de Barcelona, SpainStephen Crago, USC ISI, USATommaso Cucinotta, St. Anna School of Advanced Studies, ItalyChristoffer Dall, Columbia University, USAFrançois Diakhaté, CEA, FrancePatrick Dreher, MIT, USA Kyle Hale, Northwestern University, USA Brian Kocoloski, University of Pittsburgh, USAUday Kurkure, VMware, USAJohn Lange, University of Pittsburgh, USAGiuseppe Lettieri, University of Pisa, ItalyQing Liu, Oak Ridge National Laboratory, USANikos Parlavantzas, IRISA, FranceKevin Pedretti, Sandia National Laboratories, USAAmer Qouneh, Western New England University, USA Carlos Reaño, Technical University of Valencia, SpainBorja Sotomayor, University of Chicago, USA Anata Tiwari, San Diego Supercomputer Center, USAKurt Tutschku, Blekinge Institute of Technology, Sweden Yasuhiro Watashiba, Osaka University, JapanChao-Tung Yang, Tunghai University, Taiwan Andrew Younge, Sandia National Laboratory, USANa Zhang, VMware, USAPaper Submission-PublicationPapers submitted to the workshop will be reviewed by at least twomembers of the program committee and external reviewers. Submissionsshould include abstract, keywords, the e-mail address of thecorresponding author, and must not exceed 10 pages, including tablesand figures at a main font size no smaller than 11 point. Submissionof a paper should be regarded as a commitment that, should the paperbe accepted, at least one of the authors will register and attend theconference to present the work. Accepted papers will be published in aSpringer LNCS volume.The format must be according to the Springer LNCS Style. Initialsubmissions are in PDF; authors of accepted papers will be requestedto provide source files.Format Guidelines:ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip <ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip>Abstract, Paper Submission Link:https://edas.info/newPaper.php?c=24355 <https://edas.info/newPaper.php?c=24355>Lightning Talks Lightning Talks are non-paper track, synoptical in nature and are strictly limited to 5 minutes.They can be used to gain early feedback on ongoing research, for demonstrations, to present research results, early research ideas, perspectives and positions of interest to the community. Submit abstract via the main submission link. General InformationThe workshop is one day in length and will be held in conjunction with the InternationalSupercomputing Conference - High Performance (ISC) 2018, June 24-28, Frankfurt, Germany.*

1 0

[libvirt] [jenkins-ci PATCH] jobs: Unset $CC for Go and MinGW jobs
by Andrea Bolognani 12 Apr '18

12 Apr '18

We want $CC to be set so that ccache is used by default, but some jobs (Go and MinGW) don't like that very much. Later on, we might consider building a link farm so that we can use ccache without having to set $CC; for the time being, work around the issue at the job level. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- jobs/autotools.yaml | 7 +++++++ jobs/go.yaml | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/jobs/autotools.yaml b/jobs/autotools.yaml index 98bb1b0..b882803 100644 --- a/jobs/autotools.yaml +++ b/jobs/autotools.yaml @@ -223,6 +223,10 @@ - shell: | {global_env} {local_env} + # The way we perform MinGW builds doesn't play well with the $CC + # variable containing whitespace, so we have to unset it here. + export CC= + mkdir -p build32 cd build32 @@ -235,6 +239,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + mkdir -p build64 cd build64 diff --git a/jobs/go.yaml b/jobs/go.yaml index 29a9f51..2634cb2 100644 --- a/jobs/go.yaml +++ b/jobs/go.yaml @@ -42,6 +42,11 @@ - shell: | {global_env} {local_env} + # go doesn't handle the $CC variable containing whitespace + # correctly, so we have to make sure it's unset when building. + # See https://github.com/golang/go/issues/11685 + export CC= + go build -v publishers: - email: @@ -80,6 +85,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + go test $TEST_ARGS publishers: - email: -- 2.14.3

2 1

[libvirt] [PATCH] qemu: use target.port for isa-serial
by Thilo Cestonaro 12 Apr '18

12 Apr '18

A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. Signed-off-by: Thilo Cestonaro <thilo.cestonaro(a)ts.fujitsu.com> --- Forgot to sign off! Here with Signed-off-by. src/qemu/qemu_command.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 514c3ab2e..5f770404b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10291,6 +10291,22 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrSerialTargetModelTypeToString(serial->targetModel), serial->info.alias, serial->info.alias); + switch ((virDomainChrSerialTargetModel) serial->targetModel) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL: + if (serial->target.port != -1) + virBufferAsprintf(&cmd, ",index=%d", serial->target.port); + break; + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_NONE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_USB_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PCI_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SPAPR_VTY: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PL011: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPLMCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_LAST: + break; + } + if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) goto error; -- 2.15.1

3 2

[libvirt] [jenkins-ci PATCH 00/10] guests: Improve enviroment handling
by Andrea Bolognani 12 Apr '18

12 Apr '18

The basic goal is to move all environment configuration that affects builds to a single place which is tracked along with all other changes to the CI environment. Patch 8/10 also happens to fix build of packages that depend on libvirt-perl on FreeBSD now that they've switched to Perl 5.26, though we haven't run into this specific problem yet due to other issues in the CI enviroment ;) Andrea Bolognani (10): guests: Rename compat -> kludges guests: Enable ~/.bashrc on FreeBSD guests: Add custom shell profile guests: Move ccache configuration to shell profile guests: Move make configuration to shell profile guests: Move $PATH configuration to shell profile guests: Add more enviroment variables to shell profile guests: Move Perl configuration to shell profile guests: Add Python configuration to shell profile guests: Remove per-host make variable guests/group_vars/all/main.yml | 15 ++++++++++--- guests/host_vars/libvirt-centos-6/main.yml | 3 +++ guests/host_vars/libvirt-centos-7/main.yml | 3 +++ guests/host_vars/libvirt-debian-8/main.yml | 3 +++ guests/host_vars/libvirt-debian-9/main.yml | 3 +++ guests/host_vars/libvirt-debian-sid/main.yml | 3 +++ guests/host_vars/libvirt-fedora-26/main.yml | 3 +++ guests/host_vars/libvirt-fedora-27/main.yml | 3 +++ guests/host_vars/libvirt-fedora-rawhide/main.yml | 3 +++ guests/host_vars/libvirt-freebsd-10/main.yml | 4 +++- guests/host_vars/libvirt-freebsd-11/main.yml | 4 +++- guests/host_vars/libvirt-freebsd-current/main.yml | 4 +++- guests/host_vars/libvirt-ubuntu-14/main.yml | 3 +++ guests/host_vars/libvirt-ubuntu-16/main.yml | 3 +++ guests/site.yml | 2 +- guests/tasks/{compat.yml => kludges.yml} | 18 +++++++++++++++ guests/tasks/users.yml | 27 +++++++++++------------ guests/templates/bash_profile | 1 + guests/templates/bashrc | 15 +++++++++++++ jobs/defaults.yaml | 6 ----- 20 files changed, 99 insertions(+), 27 deletions(-) rename guests/tasks/{compat.yml => kludges.yml} (59%) create mode 100644 guests/templates/bash_profile create mode 100644 guests/templates/bashrc -- 2.14.3

3 32

[libvirt] [PATCH 00/10] Add support for VM Generation ID (vmgenid)
by John Ferlan 12 Apr '18

12 Apr '18

As a result of the RFC: https://www.redhat.com/archives/libvir-list/2018-March/msg01214.html Patches to support changes for https://bugzilla.redhat.com/show_bug.cgi?id=1149445 The first patch isn't necessarily related, but since it I was looking at the all the virUUIDGenerate calls, I figured I'd include it here. It can be consider separately. I did leave in the possibility that someone can supply a GUID in the XML; however, that can be removed - requiring that just the <genid/> exists and forcing every usage to generate the GUID. The spec isn't 100% clear on whether that's a valid use. One area which I'm still a little bit fuzzy on is the snapshot functionality. The transitions while running won't work unless/until the qemu command to set the genid GUID value are accepted. It'd be tough to fail, but according to how I've read the spec it'd be required to change the GUID value and since we cannot do so, failure is the only option. John Ferlan (10): Check return status for virUUIDGenerate conf: Modify last arg to virDomainDefCopy qemu: Add flags to qemuDomainMigratableDefCheckABIStability conf: Add VM Generation ID to virDomainDef conf: Add flag to regenerate genid for virDomainDefCopy conf: Add VM Generation ID parse/format support qemu: Add VM Generation ID device capability qemu: Handle genid processing during startup/launch qemu: Add VM Generation ID to qemu command line docs: Add news article for VM Generation ID docs/formatdomain.html.in | 29 ++++++ docs/news.xml | 12 +++ docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 81 +++++++++++++++- src/conf/domain_conf.h | 19 +++- src/conf/network_conf.c | 2 +- src/conf/secret_conf.c | 2 +- src/libxl/libxl_domain.c | 4 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 31 ++++++ src/qemu/qemu_domain.c | 23 +++-- src/qemu/qemu_domain.h | 6 +- src/qemu/qemu_driver.c | 31 ++++-- src/qemu/qemu_migration.c | 4 +- src/qemu/qemu_process.c | 110 +++++++++++++++++++++- src/qemu/qemu_process.h | 1 + src/test/test_driver.c | 6 +- src/xenconfig/xen_common.c | 2 +- tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemuxml2argvdata/genid-auto.args | 21 +++++ tests/qemuxml2argvdata/genid-auto.xml | 32 +++++++ tests/qemuxml2argvdata/genid.args | 21 +++++ tests/qemuxml2argvdata/genid.xml | 32 +++++++ tests/qemuxml2argvtest.c | 4 + tests/qemuxml2xmloutdata/genid-active.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-auto-active.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-auto-inactive.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-inactive.xml | 32 +++++++ tests/qemuxml2xmltest.c | 5 +- 33 files changed, 585 insertions(+), 37 deletions(-) create mode 100644 tests/qemuxml2argvdata/genid-auto.args create mode 100644 tests/qemuxml2argvdata/genid-auto.xml create mode 100644 tests/qemuxml2argvdata/genid.args create mode 100644 tests/qemuxml2argvdata/genid.xml create mode 100644 tests/qemuxml2xmloutdata/genid-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-inactive.xml create mode 100644 tests/qemuxml2xmloutdata/genid-inactive.xml -- 2.13.6

3 16