- Devel - libvirt List Archives

[libvirt] [jenkins-ci PATCH] jobs: Unset $CC for Go and MinGW jobs
by Andrea Bolognani 12 Apr '18

12 Apr '18

We want $CC to be set so that ccache is used by default, but some jobs (Go and MinGW) don't like that very much. Later on, we might consider building a link farm so that we can use ccache without having to set $CC; for the time being, work around the issue at the job level. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- jobs/autotools.yaml | 7 +++++++ jobs/go.yaml | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/jobs/autotools.yaml b/jobs/autotools.yaml index 98bb1b0..b882803 100644 --- a/jobs/autotools.yaml +++ b/jobs/autotools.yaml @@ -223,6 +223,10 @@ - shell: | {global_env} {local_env} + # The way we perform MinGW builds doesn't play well with the $CC + # variable containing whitespace, so we have to unset it here. + export CC= + mkdir -p build32 cd build32 @@ -235,6 +239,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + mkdir -p build64 cd build64 diff --git a/jobs/go.yaml b/jobs/go.yaml index 29a9f51..2634cb2 100644 --- a/jobs/go.yaml +++ b/jobs/go.yaml @@ -42,6 +42,11 @@ - shell: | {global_env} {local_env} + # go doesn't handle the $CC variable containing whitespace + # correctly, so we have to make sure it's unset when building. + # See https://github.com/golang/go/issues/11685 + export CC= + go build -v publishers: - email: @@ -80,6 +85,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + go test $TEST_ARGS publishers: - email: -- 2.14.3

2 1

[libvirt] [PATCH] qemu: use target.port for isa-serial
by Thilo Cestonaro 12 Apr '18

12 Apr '18

A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. Signed-off-by: Thilo Cestonaro <thilo.cestonaro(a)ts.fujitsu.com> --- Forgot to sign off! Here with Signed-off-by. src/qemu/qemu_command.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 514c3ab2e..5f770404b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10291,6 +10291,22 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrSerialTargetModelTypeToString(serial->targetModel), serial->info.alias, serial->info.alias); + switch ((virDomainChrSerialTargetModel) serial->targetModel) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL: + if (serial->target.port != -1) + virBufferAsprintf(&cmd, ",index=%d", serial->target.port); + break; + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_NONE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_USB_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PCI_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SPAPR_VTY: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PL011: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPLMCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_LAST: + break; + } + if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) goto error; -- 2.15.1

3 2

[libvirt] [jenkins-ci PATCH 00/10] guests: Improve enviroment handling
by Andrea Bolognani 12 Apr '18

12 Apr '18

The basic goal is to move all environment configuration that affects builds to a single place which is tracked along with all other changes to the CI environment. Patch 8/10 also happens to fix build of packages that depend on libvirt-perl on FreeBSD now that they've switched to Perl 5.26, though we haven't run into this specific problem yet due to other issues in the CI enviroment ;) Andrea Bolognani (10): guests: Rename compat -> kludges guests: Enable ~/.bashrc on FreeBSD guests: Add custom shell profile guests: Move ccache configuration to shell profile guests: Move make configuration to shell profile guests: Move $PATH configuration to shell profile guests: Add more enviroment variables to shell profile guests: Move Perl configuration to shell profile guests: Add Python configuration to shell profile guests: Remove per-host make variable guests/group_vars/all/main.yml | 15 ++++++++++--- guests/host_vars/libvirt-centos-6/main.yml | 3 +++ guests/host_vars/libvirt-centos-7/main.yml | 3 +++ guests/host_vars/libvirt-debian-8/main.yml | 3 +++ guests/host_vars/libvirt-debian-9/main.yml | 3 +++ guests/host_vars/libvirt-debian-sid/main.yml | 3 +++ guests/host_vars/libvirt-fedora-26/main.yml | 3 +++ guests/host_vars/libvirt-fedora-27/main.yml | 3 +++ guests/host_vars/libvirt-fedora-rawhide/main.yml | 3 +++ guests/host_vars/libvirt-freebsd-10/main.yml | 4 +++- guests/host_vars/libvirt-freebsd-11/main.yml | 4 +++- guests/host_vars/libvirt-freebsd-current/main.yml | 4 +++- guests/host_vars/libvirt-ubuntu-14/main.yml | 3 +++ guests/host_vars/libvirt-ubuntu-16/main.yml | 3 +++ guests/site.yml | 2 +- guests/tasks/{compat.yml => kludges.yml} | 18 +++++++++++++++ guests/tasks/users.yml | 27 +++++++++++------------ guests/templates/bash_profile | 1 + guests/templates/bashrc | 15 +++++++++++++ jobs/defaults.yaml | 6 ----- 20 files changed, 99 insertions(+), 27 deletions(-) rename guests/tasks/{compat.yml => kludges.yml} (59%) create mode 100644 guests/templates/bash_profile create mode 100644 guests/templates/bashrc -- 2.14.3

3 32

[libvirt] [PATCH 00/10] Add support for VM Generation ID (vmgenid)
by John Ferlan 12 Apr '18

12 Apr '18

As a result of the RFC: https://www.redhat.com/archives/libvir-list/2018-March/msg01214.html Patches to support changes for https://bugzilla.redhat.com/show_bug.cgi?id=1149445 The first patch isn't necessarily related, but since it I was looking at the all the virUUIDGenerate calls, I figured I'd include it here. It can be consider separately. I did leave in the possibility that someone can supply a GUID in the XML; however, that can be removed - requiring that just the <genid/> exists and forcing every usage to generate the GUID. The spec isn't 100% clear on whether that's a valid use. One area which I'm still a little bit fuzzy on is the snapshot functionality. The transitions while running won't work unless/until the qemu command to set the genid GUID value are accepted. It'd be tough to fail, but according to how I've read the spec it'd be required to change the GUID value and since we cannot do so, failure is the only option. John Ferlan (10): Check return status for virUUIDGenerate conf: Modify last arg to virDomainDefCopy qemu: Add flags to qemuDomainMigratableDefCheckABIStability conf: Add VM Generation ID to virDomainDef conf: Add flag to regenerate genid for virDomainDefCopy conf: Add VM Generation ID parse/format support qemu: Add VM Generation ID device capability qemu: Handle genid processing during startup/launch qemu: Add VM Generation ID to qemu command line docs: Add news article for VM Generation ID docs/formatdomain.html.in | 29 ++++++ docs/news.xml | 12 +++ docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 81 +++++++++++++++- src/conf/domain_conf.h | 19 +++- src/conf/network_conf.c | 2 +- src/conf/secret_conf.c | 2 +- src/libxl/libxl_domain.c | 4 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 31 ++++++ src/qemu/qemu_domain.c | 23 +++-- src/qemu/qemu_domain.h | 6 +- src/qemu/qemu_driver.c | 31 ++++-- src/qemu/qemu_migration.c | 4 +- src/qemu/qemu_process.c | 110 +++++++++++++++++++++- src/qemu/qemu_process.h | 1 + src/test/test_driver.c | 6 +- src/xenconfig/xen_common.c | 2 +- tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemuxml2argvdata/genid-auto.args | 21 +++++ tests/qemuxml2argvdata/genid-auto.xml | 32 +++++++ tests/qemuxml2argvdata/genid.args | 21 +++++ tests/qemuxml2argvdata/genid.xml | 32 +++++++ tests/qemuxml2argvtest.c | 4 + tests/qemuxml2xmloutdata/genid-active.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-auto-active.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-auto-inactive.xml | 32 +++++++ tests/qemuxml2xmloutdata/genid-inactive.xml | 32 +++++++ tests/qemuxml2xmltest.c | 5 +- 33 files changed, 585 insertions(+), 37 deletions(-) create mode 100644 tests/qemuxml2argvdata/genid-auto.args create mode 100644 tests/qemuxml2argvdata/genid-auto.xml create mode 100644 tests/qemuxml2argvdata/genid.args create mode 100644 tests/qemuxml2argvdata/genid.xml create mode 100644 tests/qemuxml2xmloutdata/genid-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-inactive.xml create mode 100644 tests/qemuxml2xmloutdata/genid-inactive.xml -- 2.13.6

3 16

[libvirt] [PATCH 0/9] Add Jansson support
by Ján Tomko 12 Apr '18

12 Apr '18

Prefer Jansson, but allow fallback/choice of yajl. Support for yajl can hopefully be dropped after we ditch CentOS 6 which has no Jansson. Ján Tomko (9): virmacmaptest: depend on yajl for 'empty' test virjsontest: Use a more stable floating point number for testing configure: rename LIBVIRT_*_YAJL to LIBVIRT_*_JSON Introduce WITH_JSON Introduce JSON_CFLAGS and JSON_LIBS virt-json.m4: generalize yajl dependency build: link setuid_rpc_client against JSON_LIBS virjson: add support for Jansson virt-json.m4: simplify QEMU check configure.ac | 10 +- m4/virt-json.m4 | 86 ++++++++++++++++ m4/virt-yajl.m4 | 55 ----------- src/Makefile.am | 9 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 4 +- src/util/Makefile.inc.am | 4 +- src/util/virjson.c | 219 +++++++++++++++++++++++++++++++++++++++++ tests/Makefile.am | 12 +-- tests/cputest.c | 16 +-- tests/libxlxml2domconfigtest.c | 4 +- tests/qemuagenttest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/qemucaps2xmltest.c | 2 +- tests/qemucommandutiltest.c | 2 +- tests/qemuhelptest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 2 +- tests/virjsontest.c | 2 +- tests/virmacmaptest.c | 3 + tests/virmocklibxl.c | 4 +- tests/virnetdaemontest.c | 2 +- tests/virstoragetest.c | 4 +- 23 files changed, 354 insertions(+), 96 deletions(-) create mode 100644 m4/virt-json.m4 delete mode 100644 m4/virt-yajl.m4 -- 2.16.1

3 22

[libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object
by Michal Privoznik 12 Apr '18

12 Apr '18

In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into virObject. Well, this requires 'virObject' member to be stored on the first position of the struct. This adjustment is missing in the original commit leading to all sorts of funny memleaks and data corruptions. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 89a7131fdb..1426f115ed 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -57,6 +57,7 @@ # include "virtypedparam.h" # include "virsavecookie.h" # include "virresctrl.h" +# include "virobject.h" /* forward declarations of all device types, required by * virDomainDeviceDef @@ -1180,6 +1181,7 @@ typedef virDomainChrSourceReconnectDef *virDomainChrSourceReconnectDefPtr; /* The host side information for a character device. */ struct _virDomainChrSourceDef { + virObject parent; int type; /* virDomainChrType */ virObjectPtr privateData; union { -- 2.16.1

5 5

[libvirt] [dbus PATCH 0/6] More methods for Domain interface
by Katerina Koukiou 12 Apr '18

12 Apr '18

Katerina Koukiou (6): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface data/org.libvirt.Domain.xml | 28 +++++++- src/domain.c | 166 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 10 +++ 3 files changed, 201 insertions(+), 3 deletions(-) -- 2.15.0

1 3

[libvirt] [jenkins-ci PATCH] guests: Clean up packages after update
by Andrea Bolognani 12 Apr '18

12 Apr '18

The package cache can grow to eat up a lot of disk space, and not removing unused packages can lead to upgrade issues down the line for fast moving distributions such as Fedora Rawhide. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/base.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 53cbd65..f419433 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -117,6 +117,25 @@ when: - package_format == 'pkg' +- name: Clean up packages after update + command: yum clean packages -y + args: + warn: no + when: + - package_format == 'rpm' + +- name: Clean up packages after update + apt: + autoclean: yes + autoremove: yes + when: + - package_format == 'deb' + +- name: Clean up packages after update + shell: pkg clean -y && pkg autoremove -y + when: + - package_format == 'pkg' + - name: Configure hostname hostname: name: '{{ inventory_hostname }}' -- 2.14.3

3 4

[libvirt] [dbus PATCH 0/6] More methods for Domain Interface
by Katerina Koukiou 12 Apr '18

12 Apr '18

Katerina Koukiou (6): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface data/org.libvirt.Domain.xml | 28 +++++++- src/domain.c | 166 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 10 +++ 3 files changed, 201 insertions(+), 3 deletions(-) -- 2.15.0

1 6

[libvirt] [jenkins-ci PATCH] guests: Fix intltool-update on FreeBSD
by Andrea Bolognani 12 Apr '18

12 Apr '18

The tool became completely unusable after the switch to Perl 5.26; workaround the issue while we wait for a proper solution. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Using regexes to match regexes: it's regexception. guests/tasks/kludges.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml index d0ff6cb..4dd06a4 100644 --- a/guests/tasks/kludges.yml +++ b/guests/tasks/kludges.yml @@ -46,3 +46,16 @@ command: cap_mkdb /etc/login.conf when: - loginconf.changed + +# FreeBSD switched to Perl 5.26, which makes a long existing warning in +# intltool-update turn into an error and causes jobs to fail. While we +# wait for the port to be fixed, we can patch things up ourselves. +# +# See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227444 +- name: Fix intltool-update + replace: + path: /usr/local/bin/intltool-update + regexp: '^(.*) !~ /\\\$\{\?\$2\}\?/;$' + replace: '\1 !~ /\\$\\{?$2}?/;' + when: + - os_name == 'FreeBSD' -- 2.14.3

2 1