- Devel - libvirt List Archives

[libvirt] [PATCH 0/9] virClassNew rework
by Michal Privoznik 17 Apr '18

17 Apr '18

4 29

[libvirt] [PATCH] virsh: Clear vsh last error during virshCommandOptVolBy
by John Ferlan 17 Apr '18

17 Apr '18

https://bugzilla.redhat.com/show_bug.cgi?id=1529256 If one of the virStorageVolLookupBy{Key|Name|Path} succeeds and we have a @vol, then clear the last libvirt error; otherwise, a subsequent "other" failure may cause vshReportError to erroneously report the wrong error as well as a reported 'vshError' error that caused the failure. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh-volume.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index bacbec0d27..9d6ebd2325 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -129,6 +129,8 @@ virshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd, else vshError(ctl, _("failed to get vol '%s', specifying --%s " "might help"), n, pooloptname); + } else { + vshResetLibvirtError(); } /* If the pool was specified, then make sure that the returned -- 2.13.6

2 1

[libvirt] [PATCH 0/2] Trivial fixes
by Radostin Stoyanov 16 Apr '18

16 Apr '18

Radostin Stoyanov (2): lxc: s/subtreee/subtree/ lxc: Clean up /.oldroot src/lxc/lxc_container.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.14.3

3 5

[libvirt] [PATCH] qemu_domain: Don't leak @paths in qemuDomainNamespaceSetupDisk
by Michal Privoznik 16 Apr '18

16 Apr '18

Introduced in d3db304d2e4. Instead of returning immediately we need to jump onto cleanup label where @paths is freed. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7000de6a91..6e18886d07 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11199,7 +11199,7 @@ qemuDomainNamespaceSetupDisk(virDomainObjPtr vm, } if (qemuDomainNamespaceMknodPaths(vm, paths, npaths) < 0) - return -1; + goto cleanup; ret = 0; cleanup: -- 2.16.1

1 0

[libvirt] [PATCH 0/3] qemu: use FD passing for monitor (and other unix sockets)
by Daniel P. Berrangé 16 Apr '18

16 Apr '18

This series makes use of the chardev fd passing arriving in QEMU 2.12 to get rid of the startup race wrt opening the QEMU monitor. The same thing benefits the agent too but I've not tackled that yet. Daniel P. Berrangé (3): qemu: probe for -chardev 'fd' parameter for FD passing qemu: support passing pre-opened UNIX socket listen FD qemu: don't retry connect() if doing FD passing src/qemu/qemu_capabilities.c | 4 ++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 58 ++++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_monitor.c | 54 ++++++++++++++++++++++++----------------- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_process.c | 27 +++++++++++++++------ tests/qemumonitortestutils.c | 1 + 7 files changed, 114 insertions(+), 32 deletions(-) -- 2.14.3

3 9

[libvirt] [PATCH 0/2] A couple of openvz fixups
by John Ferlan 16 Apr '18

16 Apr '18

Patch 1 came from "the next part" of the code when I determined that the Unref was unnecessary Patch 2 is a result of Jim Fehlig's review that openvzDomainGetHostname doesn't really need the error/cleanup logic. John Ferlan (2): openvz: Remove unnecessary Unref in openvzLoadDomains openvz: Clean up openvzDomainGetHostname src/openvz/openvz_conf.c | 1 - src/openvz/openvz_driver.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) -- 2.13.6

2 4

[libvirt] [dbus PATCH] maint: rename test directory to tests
by Pavel Hrdina 16 Apr '18

16 Apr '18

Our ci.centos.org expects the project uses 'tests' name. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- .travis.yml | 2 +- Makefile.am | 2 +- configure.ac | 2 +- {test => tests}/Makefile.am | 0 {test => tests}/conftest.py | 0 {test => tests}/libvirttest.py | 0 {test => tests}/test_connect.py | 0 {test => tests}/test_domain.py | 0 {test => tests}/test_network.py | 0 {test => tests}/travis-run | 0 10 files changed, 3 insertions(+), 3 deletions(-) rename {test => tests}/Makefile.am (100%) rename {test => tests}/conftest.py (100%) rename {test => tests}/libvirttest.py (100%) rename {test => tests}/test_connect.py (100%) rename {test => tests}/test_domain.py (100%) rename {test => tests}/test_network.py (100%) rename {test => tests}/travis-run (100%) diff --git a/.travis.yml b/.travis.yml index 71c2e9c..d60eaf2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ dist: trusty language: c sudo: true -script: test/travis-run +script: tests/travis-run env: - ARCH=amd64 - ARCH=i386 diff --git a/Makefile.am b/Makefile.am index a890ff1..16f57b2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,5 @@ -SUBDIRS = data src test +SUBDIRS = data src tests ACLOCAL_AMFLAGS = -I m4 diff --git a/configure.ac b/configure.ac index ea2c330..6f166f2 100644 --- a/configure.ac +++ b/configure.ac @@ -75,5 +75,5 @@ AC_CONFIG_FILES([run], AC_OUTPUT(Makefile data/Makefile src/Makefile - test/Makefile + tests/Makefile libvirt-dbus.spec) diff --git a/test/Makefile.am b/tests/Makefile.am similarity index 100% rename from test/Makefile.am rename to tests/Makefile.am diff --git a/test/conftest.py b/tests/conftest.py similarity index 100% rename from test/conftest.py rename to tests/conftest.py diff --git a/test/libvirttest.py b/tests/libvirttest.py similarity index 100% rename from test/libvirttest.py rename to tests/libvirttest.py diff --git a/test/test_connect.py b/tests/test_connect.py similarity index 100% rename from test/test_connect.py rename to tests/test_connect.py diff --git a/test/test_domain.py b/tests/test_domain.py similarity index 100% rename from test/test_domain.py rename to tests/test_domain.py diff --git a/test/test_network.py b/tests/test_network.py similarity index 100% rename from test/test_network.py rename to tests/test_network.py diff --git a/test/travis-run b/tests/travis-run similarity index 100% rename from test/travis-run rename to tests/travis-run -- 2.14.3

1 1

[libvirt] [jenkins-ci PATCH] guests: Only attempt to fix intltool-update if it exists
by Andrea Bolognani 16 Apr '18

16 Apr '18

If we're running against a freshly-provisioned FreeBSD guest, intltool won't have been installed yet and attempts to fix it will fail. Make sure the file exists. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/kludges.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml index 4dd06a4..0ad61a7 100644 --- a/guests/tasks/kludges.yml +++ b/guests/tasks/kludges.yml @@ -52,6 +52,13 @@ # wait for the port to be fixed, we can patch things up ourselves. # # See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227444 +- name: Look for intltool-update + stat: + path: /usr/local/bin/intltool-update + register: intltoolupdate + when: + - os_name == 'FreeBSD' + - name: Fix intltool-update replace: path: /usr/local/bin/intltool-update @@ -59,3 +66,4 @@ replace: '\1 !~ /\\$\\{?$2}?/;' when: - os_name == 'FreeBSD' + - intltoolupdate.stat.exists -- 2.14.3

2 4

[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
by Andrea Bolognani 16 Apr '18

16 Apr '18

The icotool command is used to manipulate Windows icon files. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e074648..6af5065 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -173,6 +173,10 @@ mappings: hal: FreeBSD: hal + icoutils: + default: icoutils + CentOS6: + intltool: default: intltool diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml index 6f3dbf9..54c96fe 100644 --- a/guests/vars/projects/virt-viewer.yml +++ b/guests/vars/projects/virt-viewer.yml @@ -3,6 +3,7 @@ packages: - glib2 - gtk-vnc - gtk3 + - icoutils - intltool - libgovirt - libxml2 -- 2.14.3

2 2

[libvirt] [jenkins-ci PATCH] guests: Set remote_user at the playbook level
by Andrea Bolognani 16 Apr '18

16 Apr '18

This is very convenient for developers using the 'test' flavor, because it ensures $ ./lcitool update all still works by logging in as root, but at the same time ad-hoc invocations such as $ ansible all -m shell -a 'cd libvirt && $MAKE -j check' and custom playbooks log in as the 'test' user instead, and as such have all the usual environment variables ($MAKE, $PYTHON, $PATH, $VIRT_PREFIX and friends) available to them, which makes testing changes locally a breeze. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/group_vars/all/main.yml | 2 -- guests/site.yml | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/group_vars/all/main.yml b/guests/group_vars/all/main.yml index 2bdb7b3..4e05c66 100644 --- a/guests/group_vars/all/main.yml +++ b/guests/group_vars/all/main.yml @@ -1,6 +1,4 @@ --- -ansible_user: root - # This password is only used to access the guest the very first time # Ansible is used: afterwards, the user's SSH key will have been installed # in the guest and SSH password authentication will have been disabled diff --git a/guests/site.yml b/guests/site.yml index 26127be..520aea7 100644 --- a/guests/site.yml +++ b/guests/site.yml @@ -1,5 +1,6 @@ --- - hosts: all + remote_user: root gather_facts: no tasks: @@ -8,6 +9,7 @@ - include: tasks/bootstrap.yml - hosts: all + remote_user: root vars_files: - vars/mappings.yml -- 2.14.3

2 1