- Devel - libvirt List Archives

[libvirt] [PATCHv2 0/3] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 28 May '18

28 May '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Once this patchset gets merged, https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGe… can be removed. - Changes since v1: All the "values" from virConfGetValueString() are freed Fabiano Fidêncio (3): xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: convert to typesafe virConf accessors src/vmx/vmx.c | 196 ++++++-------- src/xenconfig/xen_common.c | 637 ++++++++++++++++++++++----------------------- src/xenconfig/xen_xm.c | 268 ++++++++++--------- 3 files changed, 512 insertions(+), 589 deletions(-) -- 2.14.3

2 11

[libvirt] [PATCH v2 00/12] Introduce virDomainDetachDeviceAlias
by Michal Privoznik 27 May '18

27 May '18

v2 of: https://www.redhat.com/archives/libvir-list/2018-May/msg01530.html diff to v1: - The semantic is changed a bit. Now it's "send request" only, and users have to listen for DEVICE_DELETED event. They would have to do that anyway. - Couple of more fixes related to asynchronous behaviour Michal Privoznik (12): Introduce virDomainDetachDeviceAlias API remote: Implement virDomainDetachDeviceAlias virsh: Expose virDomainDetachDeviceAlias qemuDomainRemoveChrDevice: Release device address qemuDomainDetachShmemDevice: Don't release shmem address twice qemuDomainDetachWatchdog: Don't release watchdog address twice qemu_hotplug: Use more gotos in qemuDomainDetach*Device qemuDomainDetachDeviceLiveAndConfig: Don't use driver->caps directly qemuDomainDetachDeviceLiveAndConfig: Avoid overwriting @ret qemu_hotplug: Allow asynchronous detach qemu: Implement virDomainDetachDeviceAlias news: Document new API introduction docs/news.xml | 8 ++ include/libvirt/libvirt-domain.h | 3 + src/driver-hypervisor.h | 6 + src/libvirt-domain.c | 53 ++++++++ src/libvirt_public.syms | 5 + src/qemu/qemu_driver.c | 162 +++++++++++++++++++---- src/qemu/qemu_hotplug.c | 278 +++++++++++++++++++++++++-------------- src/qemu/qemu_hotplug.h | 33 +++-- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 16 ++- src/remote_protocol-structs | 6 + tests/qemuhotplugtest.c | 13 +- tools/virsh-domain.c | 72 ++++++++++ tools/virsh.pod | 12 ++ 14 files changed, 525 insertions(+), 143 deletions(-) -- 2.16.1

2 25

[libvirt] [PATCH] nwfilter: fix IP address learning
by Daniel P. Berrangé 26 May '18

26 May '18

In a previous commit: commit d4bf8f415074759baf051644559e04fe78888f8b Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Feb 14 09:43:59 2018 +0000 nwfilter: handle missing switch enum cases Ensure all enum cases are listed in switch statements, or cast away enum type in places where we don't wish to cover all cases. Reviewed-by: John Ferlan <jferlan(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> we changed a switch in the nwfilter learning thread so that it had explict cases for all enum entries. Unfortunately the parameters in the method had been declared with incorrect type. The "howDetect" parameter does *not* accept "enum howDetect" values, rather it accepts a bitmask of "enum howDetect" values, so it should have been an "int" type. The caller always passes DETECT_STATIC|DETECT_DHCP, so essentially the IP addressing learning was completely broken by the above change, as it never matched any switch case, hitting the default leading to EINVAL. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/nwfilter/nwfilter_learnipaddr.c | 13 ++++++------- src/nwfilter/nwfilter_learnipaddr.h | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c index cc3bfd971c..061b39d72b 100644 --- a/src/nwfilter/nwfilter_learnipaddr.c +++ b/src/nwfilter/nwfilter_learnipaddr.c @@ -144,7 +144,7 @@ struct _virNWFilterIPAddrLearnReq { char *filtername; virHashTablePtr filterparams; virNWFilterDriverStatePtr driver; - enum howDetect howDetect; + int howDetect; /* bitmask of enum howDetect */ int status; volatile bool terminate; @@ -442,23 +442,22 @@ learnIPAddressThread(void *arg) if (techdriver->applyDHCPOnlyRules(req->ifname, &req->macaddr, NULL, false) < 0) { + VIR_DEBUG("Unable to apply DHCP only rules"); req->status = EINVAL; goto done; } virBufferAddLit(&buf, "src port 67 and dst port 68"); break; - case DETECT_STATIC: + default: if (techdriver->applyBasicRules(req->ifname, &req->macaddr) < 0) { + VIR_DEBUG("Unable to apply basic rules"); req->status = EINVAL; goto done; } virBufferAsprintf(&buf, "ether host %s or ether dst ff:ff:ff:ff:ff:ff", macaddr); break; - default: - req->status = EINVAL; - goto done; } if (virBufferError(&buf)) { @@ -693,7 +692,7 @@ learnIPAddressThread(void *arg) * once its IP address has been detected * @driver : the network filter driver * @howDetect : the method on how the thread is supposed to detect the - * IP address; must choose any of the available flags + * IP address; bitmask of "enum howDetect" flags. * * Instruct to learn the IP address being used on a given interface (ifname). * Unless there already is a thread attempting to learn the IP address @@ -711,7 +710,7 @@ virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver, const char *filtername, virHashTablePtr filterparams, virNWFilterDriverStatePtr driver, - enum howDetect howDetect) + int howDetect) { int rc; virThread thread; diff --git a/src/nwfilter/nwfilter_learnipaddr.h b/src/nwfilter/nwfilter_learnipaddr.h index 06fea5bff8..753aabc594 100644 --- a/src/nwfilter/nwfilter_learnipaddr.h +++ b/src/nwfilter/nwfilter_learnipaddr.h @@ -43,7 +43,7 @@ int virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver, const char *filtername, virHashTablePtr filterparams, virNWFilterDriverStatePtr driver, - enum howDetect howDetect); + int howDetect); bool virNWFilterHasLearnReq(int ifindex); int virNWFilterTerminateLearnReq(const char *ifname); -- 2.17.0

2 2

[libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 25 May '18

25 May '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Fabiano Fidêncio (3): xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: convert to typesafe virConf accessors src/vmx/vmx.c | 197 +++++------- src/xenconfig/xen_common.c | 631 ++++++++++++++++++------------------- src/xenconfig/xen_xm.c | 268 ++++++++-------- 3 files changed, 504 insertions(+), 592 deletions(-) -- 2.17.0

1 4

[libvirt] [PATCH] tools: virsh: Add virshCellnoCompleter.
by Roland Schulz 25 May '18

25 May '18

Signed-off-by: Roland Schulz <schullzroll(a)gmail.com> --- tools/virsh-completer.c | 59 +++++++++++++++++++++++++++++++++++++++++ tools/virsh-completer.h | 3 +++ tools/virsh-host.c | 3 +++ 3 files changed, 65 insertions(+) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index 5713a887e..ce152226f 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -756,3 +756,62 @@ virshNodedevEventNameCompleter(vshControl *ctl ATTRIBUTE_UNUSED, virStringListFree(ret); return NULL; } + + +char ** +virshCellnoCompleter(vshControl *ctl, + const vshCmd *cmd ATTRIBUTE_UNUSED, + unsigned int flags) +{ + xmlXPathContextPtr ctxt = NULL; + virshControlPtr priv = ctl->privData; + unsigned int ncells = 0; + xmlNodePtr *cells = NULL; + xmlDocPtr doc = NULL; + size_t i = 0; + char *cap_xml = NULL; + char *cellid = NULL; + char **ret = NULL; + + virCheckFlags(0, NULL); + + if (!priv->conn || virConnectIsAlive(priv->conn) <= 0) + goto error; + + if (!(cap_xml = virConnectGetCapabilities(priv->conn))) + goto error; + + if (!(doc = virXMLParseStringCtxt(cap_xml, _("capabilities"), &ctxt))) + goto error; + + ncells = virXPathNodeSet("/capabilities/host/topology/cells/cell", ctxt, &cells); + if (ncells <= 0) + goto error; + + if (VIR_ALLOC_N(ret, ncells + 1)) + goto error; + + for (i = 0; i < ncells; i++) { + VIR_FREE(cellid); + cellid = virXMLPropString(cells[i], "id"); + if (VIR_STRDUP(ret[i], cellid) < 0) + goto error; + } + + cleanup: + xmlXPathFreeContext(ctxt); + VIR_FREE(cells); + xmlFreeDoc(doc); + VIR_FREE(cap_xml); + VIR_FREE(cellid); + + return ret; + + error: + if (ret) { + for (i = 0; i < ncells; i++) + VIR_FREE(ret[i]); + } + VIR_FREE(ret); + goto cleanup; +} diff --git a/tools/virsh-completer.h b/tools/virsh-completer.h index 86632ee91..ee7eec68c 100644 --- a/tools/virsh-completer.h +++ b/tools/virsh-completer.h @@ -94,4 +94,7 @@ char ** virshNodedevEventNameCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); +char ** virshCellnoCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); #endif diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 12c13f522..991c0f50a 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -149,6 +149,7 @@ static const vshCmdInfo info_freecell[] = { static const vshCmdOptDef opts_freecell[] = { {.name = "cellno", .type = VSH_OT_INT, + .completer = virshCellnoCompleter, .help = N_("NUMA cell number") }, {.name = "all", @@ -274,6 +275,7 @@ static const vshCmdInfo info_freepages[] = { static const vshCmdOptDef opts_freepages[] = { {.name = "cellno", .type = VSH_OT_INT, + .completer = virshCellnoCompleter, .help = N_("NUMA cell number") }, {.name = "pagesize", @@ -483,6 +485,7 @@ static const vshCmdOptDef opts_allocpages[] = { }, {.name = "cellno", .type = VSH_OT_INT, + .completer = virshCellnoCompleter, .help = N_("NUMA cell number") }, {.name = "add", -- 2.17.0

3 2

[libvirt] [tck PATCH 0/3] Some misc fixes
by Daniel P. Berrangé 25 May '18

25 May '18

Just random things i found while testing the TCK against current git Daniel P. Berrangé (3): scripts: avoid using multicast MAC addresses scripts: strip quotes from URI before checking it scripts: fix block info test conditions scripts/domain/121-block-info.t | 5 ++--- scripts/domain/215-nic-hotplug-many.t | 6 +++--- scripts/nwfilter/nwfilter2vmtest.sh | 2 +- scripts/nwfilter/nwfilter_concurrent.sh | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) -- 2.17.0

2 4

[libvirt] [PATCH v2 0/8] Fix some issues with rng grammar for output XML's,
by John Ferlan 25 May '18

25 May '18

v1: https://www.redhat.com/archives/libvir-list/2018-May/msg01455.html Update patches to add data into schema for examples that I could generate. For the vpxmigr and vzmigr, I wasn't sure what the capabilityschemadata should look like, so I left those out. Those are only validate in the "right" environment when virCapabilitiesAddHostMigrateTransport is called. John Ferlan (8): schema: Add physical sizing grammer for storagevol grammar schema: Remove xenmigr from host migrate transport capability schema,tests: Use vpxmigr for host migrate transport capability schema: Add rdma for host migrate transport capability schema: Add vzmigr for host migrate transport capability schema: Add microcode to capability grammar schema: Fix capability grammar for pagesElem schema: Add missing block data for nodedev docs/schemas/capability.rng | 42 +++++++++++++++------- docs/schemas/nodedev.rng | 13 +++++++ docs/schemas/storagevol.rng | 5 +++ tests/capabilityschemadata/caps-qemu-kvm.xml | 1 + tests/capabilityschemadata/caps-test2.xml | 4 +++ tests/capabilityschemadata/caps-test3.xml | 7 ++++ tests/nodedevschemadata/DVD_with_media.xml | 2 ++ ...ge_serial_3600c0ff000d7a2a5d463ff4902000000.xml | 2 ++ ..._serial_SATA_HTS721010G9SA00_MPCZ12Y0GNGWSE.xml | 2 ++ tests/nodedevxml2xmltest.c | 22 ++++++++++++ tests/storagevolschemadata/qcow2-no-source.xml | 1 + tests/vmx2xmltest.c | 2 +- 12 files changed, 89 insertions(+), 14 deletions(-) -- 2.14.3

3 10

[libvirt] [REPOSTv2 PATCH v3 0/6] Add support for VM Generation ID (vmgenid)
by John Ferlan 25 May '18

25 May '18

Second reposting of: https://www.redhat.com/archives/libvir-list/2018-May/msg00813.html To update patches with more conflicts for patch 2 (capabilities) and patch 6 (news) Cover from the v3 posting: v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2: * Essentially handle comments from code review of original series from comments received for patch 6: https://www.redhat.com/archives/libvir-list/2018-April/msg02240.html It's a somewhat simplified approach removing the ABI checks and the adjustment to the genid value as part of domain def copy. * (NEW) Patch 5 - add a 'genid' domain capability (similar to how Cole added support for vmcoreinfo). Since the apps need a way to determine whether this is enabled, this seems to be the best way. John Ferlan (6): conf: Add VM Generation ID parse/format support qemu: Add VM Generation ID device capability qemu: Alter VM Generation ID for specific startup/launch transitions qemu: Add VM Generation ID to qemu command line domcaps: Add 'genid' to domain capabilities docs: Add news article for VM Generation ID docs/formatdomain.html.in | 27 +++++++++++ docs/formatdomaincaps.html.in | 7 ++- docs/news.xml | 13 ++++++ docs/schemas/domaincaps.rng | 7 +++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_capabilities.c | 3 ++ src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 54 ++++++++++++++++++++++ src/conf/domain_conf.h | 5 ++ src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 24 ++++++++++ src/qemu/qemu_driver.c | 17 +++++-- src/qemu/qemu_process.c | 46 +++++++++++++++++- src/qemu/qemu_process.h | 1 + tests/domaincapsschemadata/basic.xml | 1 + tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenfv.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argvdata/genid-auto.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid-auto.xml | 32 +++++++++++++ tests/qemuxml2argvdata/genid.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid.xml | 32 +++++++++++++ tests/qemuxml2argvtest.c | 4 ++ tests/qemuxml2xmloutdata/genid-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmltest.c | 5 +- 53 files changed, 500 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/genid-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid-auto.xml create mode 100644 tests/qemuxml2argvdata/genid.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid.xml create mode 100644 tests/qemuxml2xmloutdata/genid-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-inactive.xml create mode 100644 tests/qemuxml2xmloutdata/genid-inactive.xml -- 2.14.3

2 21

[libvirt] [jenkins-ci PATCH] guests: Don't backup files when changing them
by Andrea Bolognani 25 May '18

25 May '18

Since our entire guest state is fully reproducible, keeping backups around is not very useful; moreover, on CentOS 6 it results in us hitting https://github.com/ansible/ansible/issues/31982 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/bootloader.yml | 2 -- guests/tasks/jenkins.yml | 1 - guests/tasks/users.yml | 2 -- 3 files changed, 5 deletions(-) diff --git a/guests/tasks/bootloader.yml b/guests/tasks/bootloader.yml index face3dd..3de8c0d 100644 --- a/guests/tasks/bootloader.yml +++ b/guests/tasks/bootloader.yml @@ -19,7 +19,6 @@ path: /etc/default/grub regexp: '^{{ item.key }}=.*$' line: '{{ item.key }}="{{ item.value }}"' - backup: yes with_items: - { key: 'GRUB_TIMEOUT', value: '1' } - { key: 'GRUB_CMDLINE_LINUX_DEFAULT', value: 'console=ttyS0' } @@ -45,7 +44,6 @@ regexp: '^{{ item.key }}=.*$' line: '{{ item.key }}="{{ item.value }}"' create: yes - backup: yes with_items: - { key: 'console', value: 'comconsole' } - { key: 'autoboot_delay', value: '1' } diff --git a/guests/tasks/jenkins.yml b/guests/tasks/jenkins.yml index 10aeec7..9076c34 100644 --- a/guests/tasks/jenkins.yml +++ b/guests/tasks/jenkins.yml @@ -23,7 +23,6 @@ lineinfile: path: /etc/rc.local create: yes - backup: yes regexp: '^nohup.*jenkins.*java.*slave\.jar.*&$' line: "nohup {{ su }} - jenkins -c '{{ java }} -jar /home/jenkins/slave.jar -jnlpUrl \"{{ jenkins_url }}\" -secret \"{{ jenkins_secret }}\"' >/var/log/jenkins.log 2>&1 &" insertbefore: '^exit .*$' diff --git a/guests/tasks/users.yml b/guests/tasks/users.yml index 033ca2a..0aa6230 100644 --- a/guests/tasks/users.yml +++ b/guests/tasks/users.yml @@ -17,7 +17,6 @@ regexp: '^#*\s*PermitRootLogin\s*.*$' line: 'PermitRootLogin without-password' state: present - backup: yes - name: '{{ flavor }}: Create user account' user: @@ -46,7 +45,6 @@ path: '{{ sudoers }}' line: '{{ flavor }} ALL=(ALL) NOPASSWD: ALL' state: present - backup: yes validate: 'visudo -cf %s' when: - flavor == 'test' -- 2.17.0

2 1

[libvirt] [PATCH] spec: Enable libssh on future RHEL
by Jiri Denemark 25 May '18

25 May '18

Future RHEL will certainly be modern enough to support libssh. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0e4a84c98c..5e1e1df3f0 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -191,7 +191,7 @@ %endif # Enable libssh transport for new enough distros -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?rhel} > 7 %define with_libssh 0%{!?_without_libssh:1} %endif -- 2.17.0

2 1