- Devel - libvirt List Archives

[libvirt] [PATCH 00/12] Various storage_util adjustments
by John Ferlan 15 May '18

15 May '18

Essentially fallout and preparatory steps needed in order to alter the code to allow using qemu-img for creation of qcow[2] encrypted volume. The following series: https://www.redhat.com/archives/libvir-list/2018-April/msg01578.html is the impetus for these changes. What will follow once more testing is done are the adjustments to be able to qemu-img create a qcow[2] encrypted volume and changes to allow qemu-img convert to also work. Currently create is broken for qcow[2] encryption and convert is broken for both qcow[2] and luks encryption. Patches 1&2 could be combined, but since some like separated adjustments like that, I kept them separate. John Ferlan (12): storage_util: Some code cleanup storage_util: Cleanup usage of target.encryption storage_util: Remove unnecessary check storage_util: Rename virQEMUBuildLuksOpts storage_util: Generate the qcow secret earlier storage_util: Move secretPath generation storage_util: Remove luks distinction from secret path and alias storage_util: Split backing_fmt set in storageBackendCreateQemuImgOpts storage_util: Split preallocate set in storageBackendCreateQemuImgOpts storage_util: Move @type into _virStorageBackendQemuImgInfo storage_util: Introduce storageBackendCreateQemuImgSetInput storage_util: Introduce storageBackendDoCreateQemuImg src/libvirt_private.syms | 2 +- src/storage/storage_util.c | 252 +++++++++++++++++++++++++++------------------ src/util/virqemu.c | 8 +- src/util/virqemu.h | 6 +- 4 files changed, 158 insertions(+), 110 deletions(-) -- 2.14.3

3 30

[libvirt] [PATCH 00/13] Fix XML for persistent reservations and refactor
by Peter Krempa 15 May '18

15 May '18

The XML design for the PR stuff is slightly weird so fix it and refactor the code so that it will be much easier to use it with the blockdev infrastructure. Peter Krempa (13): qemu: hotplug: Fix spacing around addition operator qemu: alias: Allow passing alias of parent when generating PR manager alias qemu: command: Fix comment for qemuBuildPRManagerInfoProps qemu: Move validation of PR manager support util: storage: Drop pointless 'enabled' form PR definition util: storage: Drop virStoragePRDefIsEnabled util: storage: Allow passing <source> also for managed PR case qemu: Assign managed PR path when preparing storage source qemu: process: Change semantics of functions starting PR daemon qemu: command: Move check whether PR manager object props need to be built conf: domain: Add helper to check whether a domain def requires use of PR util: storage: Store PR manager alias in the definition qemu: hotplug: Replace qemuDomainDiskNeedRemovePR docs/formatdomain.html.in | 21 ++-- docs/schemas/storagecommon.rng | 3 - src/conf/domain_conf.c | 21 ++++ src/conf/domain_conf.h | 3 + src/libvirt_private.syms | 2 +- src/qemu/qemu_alias.c | 4 +- src/qemu/qemu_alias.h | 2 +- src/qemu/qemu_command.c | 61 +++------- src/qemu/qemu_command.h | 6 +- src/qemu/qemu_domain.c | 66 ++++++++--- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_hotplug.c | 83 +++----------- src/qemu/qemu_process.c | 40 ++----- src/qemu/qemu_process.h | 5 +- src/util/virstoragefile.c | 124 ++++++++------------- src/util/virstoragefile.h | 5 +- tests/qemustatusxml2xmldata/modern-in.xml | 4 + .../disk-virtio-scsi-reservations.xml | 4 +- tests/qemuxml2xmltest.c | 2 +- 19 files changed, 191 insertions(+), 268 deletions(-) -- 2.16.2

3 26

[libvirt] [dbus PATCH] tests: Add test_storage.py into test_programs
by Pavel Hrdina 15 May '18

15 May '18

Commit <bc58af85e6> forgot to list the test. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule. tests/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 089ade5..5e224f8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -5,7 +5,8 @@ test_helpers = \ test_programs = \ test_connect.py \ test_domain.py \ - test_network.py + test_network.py \ + test_storage.py EXTRA_DIST = \ $(test_helpers) \ -- 2.17.0

1 0

[libvirt] [jenkins-ci PATCH v2 0/3] Enable out-of-the-box parallel make
by Andrea Bolognani 15 May '18

15 May '18

Changes from [v1]: * turns out some versions of ExtUtils::MakeMaker output Makefiles that are not entirely compatible with parallel make, which forces us to introduce an exception in the relevant template and shuffle patches around. [v1] https://www.redhat.com/archives/libvir-list/2018-May/msg00732.html Andrea Bolognani (3): jobs: Enable parallel make everywhere jobs: Drop explicit parallel make usage guests: Set MAKEFLAGS for out-of-the-box parallel make guests/templates/bashrc | 2 ++ jobs/autotools.yaml | 10 +++++----- jobs/defaults.yaml | 1 - jobs/perl-makemaker.yaml | 12 +++++++----- projects/libvirt.yaml | 4 ++-- projects/osinfo-db.yaml | 4 ++-- 6 files changed, 18 insertions(+), 15 deletions(-) -- 2.17.0

2 5

[libvirt] [PATCH] xenconfig: xm: Fix checking for extra in parser
by Filip Alac 15 May '18

15 May '18

Parser assumed extra was always present when root was specified. Fixed by handling root and extra separately. --- src/xenconfig/xen_xm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 8ef68bbc..4becb40b 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -91,10 +91,13 @@ xenParseXMOS(virConfPtr conf, virDomainDefPtr def) if (xenConfigGetString(conf, "root", &root, NULL) < 0) return -1; - if (root) { + if (root && extra) { if (virAsprintf(&def->os.cmdline, "root=%s %s", root, extra) < 0) return -1; - } else { + } else if (root) { + if (virAsprintf(&def->os.cmdline, "root=%s", root) < 0) + return -1; + } else if (extra) { if (VIR_STRDUP(def->os.cmdline, extra) < 0) return -1; } -- 2.17.0

3 4

[libvirt] [PATCH] virDomainMemoryDefParseXML: Don't leak discard
by Michal Privoznik 15 May '18

15 May '18

==1589== 7 bytes in 2 blocks are definitely lost in loss record 34 of 261 ==1589== at 0x4C2AF0F: malloc (vg_replace_malloc.c:299) ==1589== by 0x8A82794: xmlStrndup (in /usr/lib64/libxml2.so.2.9.8) ==1589== by 0x5DD8392: virXMLPropString (virxml.c:510) ==1589== by 0x5E12427: virDomainMemoryDefParseXML (domain_conf.c:15704) ==1589== by 0x5E207DE: virDomainDefParseXML (domain_conf.c:20351) ==1589== by 0x5E2184F: virDomainDefParseNode (domain_conf.c:20636) ==1589== by 0x5E216A1: virDomainDefParse (domain_conf.c:20580) ==1589== by 0x5E21747: virDomainDefParseFile (domain_conf.c:20606) ==1589== by 0x112F5F: testCompareXMLToArgv (qemuxml2argvtest.c:493) ==1589== by 0x138780: virTestRun (testutils.c:180) ==1589== by 0x117129: mymain (qemuxml2argvtest.c:937) ==1589== by 0x13A83C: virTestMain (testutils.c:1120) Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d38a775f21..338fbc0e61 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15710,6 +15710,7 @@ virDomainMemoryDefParseXML(virDomainXMLOptionPtr xmlopt, def->discard = val; } + VIR_FREE(tmp); /* source */ if ((node = virXPathNode("./source", ctxt)) && -- 2.16.1

2 1

[libvirt] [PATCH] util: fix misleading command for virObjectLock
by Daniel P. Berrangé 15 May '18

15 May '18

It only accepts a virObjecLockable, not a virObjecRWLockable Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virobject.c b/src/util/virobject.c index 9fb0328d58..a597ff4f54 100644 --- a/src/util/virobject.c +++ b/src/util/virobject.c @@ -408,7 +408,7 @@ virObjectGetRWLockableObj(void *anyobj) /** * virObjectLock: - * @anyobj: any instance of virObjectLockable or virObjectRWLockable + * @anyobj: any instance of virObjectLockable * * Acquire a lock on @anyobj. The lock must be released by * virObjectUnlock. -- 2.17.0

2 1

[libvirt] [PATCH] tests: Link mocks with libvirt.so
by Michal Privoznik 15 May '18

15 May '18

In a lot of our mocks (if not all of them) we use our internal APIs (e.g. VIR_ALLOC). So far, we're relying on test binary that links with the mock to drag in libvirt.so. Well, this works only partially. Firstly, whatever binary we execute from tests will fail (e.g. as Martin reported on the list ./qemucapsprobe fails to execute qemu). Secondly, if there's a program that tries to validate linking (like valgrind is doing) it fails because of unresolved symbols. Because of that we have to link our mocks with libvirt.so. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 621480dd0c..ac92190845 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -81,7 +81,8 @@ LDADDS = \ ../src/libvirt.la MOCKLIBS_LIBS = \ - $(GNULIB_LIBS) + $(GNULIB_LIBS) \ + ../src/libvirt.la EXTRA_DIST = \ .valgrind.supp \ -- 2.16.1

2 2

[libvirt] [PATCH v2 00/12] Some fixes and improvement for virsh completion in non interactive mode
by Lin Ma 15 May '18

15 May '18

This patch series is about some fixes and improvement for virsh completion in non interactive mode. Some of them probably don't make sense, I sent them out for suggestions. v2->v1: * Add a new patch for centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h * rename the helper function from virDomainEventGetName virshDomainEventGetName Follow Peter Krempa's suggestion: * Drop the original patch#10 which about introduce some VIR_DOMAIN_EVENT_* macros * code formatting fix * centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL * centralize the definition of macro VIRSH_COMMON_OPT_DOMAIN_OT_ARGV_FULL * refactor some code in patch#10 for using same array, handle the case when '--event' and '--all' are provided together through command line. * Due to the helper function is only used for virsh, unnecessary to be publiced, I move it from src/conf/domain_event.c to tools/virsh-util.c Lin Ma (12): virsh: Move the definition of macro VIRSH_COMMON_OPT_DOMAIN_FULL to virsh.h virsh: Add domain name completion to 'migrate-postcopy' command virsh: Conditionally Ignore the first entry in list of completions virsh: Create macros for VSH_OT_STRING "domain" option virsh: Apply macro for current VSH_OT_STRING "domain" options vshReadlineParse: Ignore vshReadlineOptionsGenerator for VSH_OT_ARGV options virsh: Create macros for VSH_OT_ARGV "domain" option virsh: Apply macro for current VSH_OT_ARGV "domain" options vshReadlineOptionsGenerator: Add already provided VSH_OT_ARGV options to list virsh: Enable multiple --event flags to 'event' command virsh: add helper for returning event name string virsh: Add event name completion to 'event' command tools/virsh-completer.c | 37 ++++++++++++ tools/virsh-completer.h | 3 + tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 135 ++++++++++++++++++++----------------------- tools/virsh-snapshot.c | 3 - tools/virsh-util.c | 60 +++++++++++++++++++ tools/virsh-util.h | 3 + tools/virsh.h | 26 +++++++++ tools/vsh.c | 12 +++- 9 files changed, 203 insertions(+), 85 deletions(-) -- 2.15.1

2 32

[libvirt] [PATCH 0/9] Some virsh completion fixes
by Lin Ma 15 May '18

15 May '18

patch 1 is not about completion, I merge it into this patch set for easy review because it's a tiny fix. Lin Ma (9): virsh: Remove 'id' text from help message for 'domrename' command virsh: Only return active domain names for 'reset' command virsh: Only return active domain names for block* command virsh-network: Create macros for VSH_OT_STRING "network" option virsh-network: Add network name completion to 'net-event' command virsh-network: Add macro VIRSH_COMMON_OPT_NETWORK_FULL virsh-network: Add network name completion to 'net-uuid' command virsh: Introduce virshDomainBlockTargetCompleter virsh: Add target name completion for block device options tools/virsh-completer.c | 48 ++++++++++++++++++++++++++++++++++++++++++++ tools/virsh-completer.h | 4 ++++ tools/virsh-domain-monitor.c | 2 ++ tools/virsh-domain.c | 23 ++++++++++++++------- tools/virsh-network.c | 47 +++++++++++++++++++++++++------------------ 5 files changed, 97 insertions(+), 27 deletions(-) -- 2.16.2

1 0