- Devel - libvirt List Archives

[libvirt] [jenkins-ci PATCH 0/3] Introduce variants and use them for MinGW
by Andrea Bolognani 17 Apr '18

17 Apr '18

Andrea Bolognani (3): jobs: Introduce variants jobs: Tweak autotools-mingw-job template jobs: Drop autotools-mingw-job jobs/autotools.yaml | 94 ++++------------------------------------------ jobs/defaults.yaml | 17 +++++++++ jobs/generic.yaml | 16 ++++---- jobs/go.yaml | 8 ++-- jobs/perl-makemaker.yaml | 12 +++--- jobs/perl-modulebuild.yaml | 12 +++--- jobs/python-distutils.yaml | 12 +++--- projects/libvirt-glib.yaml | 12 +++++- projects/libvirt.yaml | 12 +++++- projects/virt-viewer.yaml | 12 +++++- 10 files changed, 88 insertions(+), 119 deletions(-) -- 2.14.3

2 6

[libvirt] [PATCH v2 0/5] virClassNew rework
by Michal Privoznik 17 Apr '18

17 Apr '18

2 9

[libvirt] [PATCH] domain: avoid slash characters to the new domain name.
by Julio Faracco 17 Apr '18

17 Apr '18

The 'domrename' command needs to check if the new domain name contains the slash character. This character is not accepted by libvirt XML definition because it is an invalid char (see Cole's commit b1fc6a7b7). This commit enhace the 'domrename' command adding this check. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1333232 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/internal.h | 9 +++++++++ src/libvirt-domain.c | 1 + 2 files changed, 10 insertions(+) diff --git a/src/internal.h b/src/internal.h index 1760e3b69..e976b1caa 100644 --- a/src/internal.h +++ b/src/internal.h @@ -484,6 +484,15 @@ goto label; \ } \ } while (0) +# define virCheckNonSlashGoto(argname, label) \ + do { \ + if (strchr(argname, '/')) { \ + virReportInvalidArg(ctl, \ + _("name %s cannot contain '/'"), \ + argname); \ + goto label; \ + } \ + } while (0) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 63d2ae23d..47bc59b11 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8536,6 +8536,7 @@ virDomainRename(virDomainPtr dom, virResetLastError(); virCheckDomainReturn(dom, -1); virCheckNonEmptyStringArgGoto(new_name, error); + virCheckNonSlashGoto(new_name, error); virCheckReadOnlyGoto(dom->conn->flags, error); if (dom->conn->driver->domainRename) { -- 2.14.1

2 2

[libvirt] [PATCHv2 0/4] qemu: enable sandbox whitelist by default
by Ján Tomko 17 Apr '18

17 Apr '18

v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01965.html https://bugzilla.redhat.com/show_bug.cgi?id=1492597 v2: * also deny resource control * split out and refactor the command line building * be explicit about denying the obsolete syscalls Ján Tomko (4): Introduce QEMU_CAPS_SECCOMP_BLACKLIST Introduce qemuBuildSeccompSandboxCommandLine Refactor qemuBuildSeccompSandboxCommandLine qemu: deny privilege elevation and spawn in seccomp src/qemu/qemu.conf | 7 ++-- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 46 +++++++++++++++++----- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemuxml2argvdata/minimal-sandbox.args | 29 ++++++++++++++ tests/qemuxml2argvdata/minimal-sandbox.xml | 34 ++++++++++++++++ tests/qemuxml2argvtest.c | 11 ++++++ 12 files changed, 123 insertions(+), 12 deletions(-) create mode 100644 tests/qemuxml2argvdata/minimal-sandbox.args create mode 100644 tests/qemuxml2argvdata/minimal-sandbox.xml -- 2.16.1

3 14

[libvirt] [jenkins-ci PATCH v2 0/6] Mostly drop CentOS 6
by Andrea Bolognani 17 Apr '18

17 Apr '18

Changes from [v1]: * instead of dropping CentOS 6 altogether, simply stop building pretty much all projects on it; * introduce a new job type specifically for whatever little stuff we need to ensure still works on CentOS 6; * the end result is still a nice cleanup thanks to not repeating the list of machines all over the place; moreover, the message about our support of the OS is very clear because it disappears from all but one page on the CI web interface. [v1] https://www.redhat.com/archives/libvir-list/2018-April/msg00453.html Andrea Bolognani (6): jobs: Introduce autotools-website-job guests: Introduce libvirt+website project projects: Add libvirt-master-website job projects: Stop building on CentOS 6 guests: Drop projects from CentOS 6 jobs: Introduce {all_machines} and {rpm_machines} guests/host_vars/libvirt-centos-6/main.yml | 5 +-- guests/vars/projects/libvirt+website.yml | 5 +++ jobs/autotools.yaml | 67 ++++++++++++++++++++++++++++++ jobs/defaults.yaml | 14 +++++++ projects/libosinfo.yaml | 16 +------ projects/libvirt-cim.yaml | 7 +--- projects/libvirt-glib.yaml | 16 +------ projects/libvirt-go-xml.yaml | 10 +---- projects/libvirt-go.yaml | 10 +---- projects/libvirt-perl.yaml | 17 +------- projects/libvirt-python.yaml | 18 +------- projects/libvirt.yaml | 34 +++++++-------- projects/osinfo-db-tools.yaml | 16 +------ projects/osinfo-db.yaml | 16 +------ projects/virt-viewer.yaml | 16 +------ 15 files changed, 119 insertions(+), 148 deletions(-) create mode 100644 guests/vars/projects/libvirt+website.yml -- 2.14.3

2 26

[libvirt] [PATCH v2 0/5] Enable memory-backend-file.discard-data
by Michal Privoznik 17 Apr '18

17 Apr '18

diff to v1: - Merged two patches into one (5/7 and 6/7 from the original series) - reworked last patch - 1/7 from the original series is pushed now Michal Privoznik (5): qemu_capabilities: s/ObjectProps/DeviceProps/g qemu_capabilities: Separate out device props fetching qemu_monitor: Introduce qemuMonitorGetObjectProps qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD qemu: Enable memory-backend-file.discard-data whenever possible src/qemu/qemu_capabilities.c | 267 +++++---- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 62 ++- src/qemu/qemu_monitor_json.h | 4 + .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 +- .../caps_2.10.0.aarch64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 +- .../caps_2.10.0.x86_64.replies | 540 +++++++++--------- tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 26 +- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 2 +- .../caps_2.12.0.aarch64.replies | 24 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 24 +- .../caps_2.12.0.x86_64.replies | 612 +++++++++++---------- tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 3 +- .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 +- .../caps_2.6.0.aarch64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.s390x.replies | 28 +- tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 536 +++++++++--------- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 +- 50 files changed, 1452 insertions(+), 1128 deletions(-) -- 2.16.1

4 9

[libvirt] [PATCH 0/6] qemu: Add support for 'write-cache' disk frontend argument (blockdev-add saga)
by Peter Krempa 17 Apr '18

17 Apr '18

'write-cache' is one of the booleans the 'cache' attribute of -drive translates to. Since we are getting rid of -drive this needs to be implemented in a different way. Peter Krempa (6): tests: utils: Allow parsing test capability file without virCaps tests: qemuxm2argv: Add infrastructure for testing with real qemuCaps qemu: domain: Add helper for translating disk cachemode to qemu flags qemu: caps: Add capability for 'write-cache' parameter of disk frontends qemu: Format 'write-cache' parameter for disk frontends tests: qemuxml2argv: Test formatting of 'write-cache' parameter src/qemu/qemu_capabilities.c | 5 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 27 ++++++++ src/qemu/qemu_domain.c | 75 ++++++++++++++++++++++ src/qemu/qemu_domain.h | 6 ++ tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemuxml2argvdata/disk-drive-write-cache.args | 45 +++++++++++++ tests/qemuxml2argvdata/disk-drive-write-cache.xml | 45 +++++++++++++ tests/qemuxml2argvtest.c | 32 +++++++++ tests/testutilsqemu.c | 21 ++++-- tests/testutilsqemu.h | 3 + 26 files changed, 270 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.args create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.xml -- 2.16.2

3 24

[libvirt] [jenkins-ci PATCH] guests: Force use of nodebug kernel on Rawhide
by Andrea Bolognani 17 Apr '18

17 Apr '18

The nodebug kernel provides much better performance than the standard Rawhide kernel, so we want to use it; however, it can sometimes lag behind a bit, which might cause it to be replaced with the regular one when performing a system update. To work around the issue, perform the update in two steps: first with all repositories enabled but excluding the kernel packages, then only the kernel packages but with all repositories except fedora-rawhide-kernel-nodebug disabled. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/base.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 616db0a..70d5abc 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -104,6 +104,24 @@ state: latest when: - package_format == 'rpm' + - not ( os_name == 'Fedora' and + os_version == 'Rawhide' ) + +- name: Update installed packages + command: dnf update --refresh --exclude 'kernel*' -y + args: + warn: no + when: + - os_name == 'Fedora' + - os_version == 'Rawhide' + +- name: Update installed packages + command: dnf update --disablerepo='*' --enablerepo=fedora-rawhide-kernel-nodebug 'kernel*' -y + args: + warn: no + when: + - os_name == 'Fedora' + - os_version == 'Rawhide' - name: Update installed packages apt: -- 2.14.3

2 1

[libvirt] [PATCH] tests: remove double space
by Ján Tomko 17 Apr '18

17 Apr '18

Commit 70255fa5 introduced a double space before the newline-escaping backslash and broke syntax check. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a trivial build-breaker fix. tests/qemuxml2argvtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 43f07efc1..509fe776e 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -668,7 +668,7 @@ mymain(void) testCompareXMLToArgv, &info) < 0) \ ret = -1; \ if (virTestRun("QEMU XML-2-startup-XML " name, \ - testCompareXMLToStartupXML, &info) < 0) \ + testCompareXMLToStartupXML, &info) < 0) \ ret = -1; \ virObjectUnref(info.qemuCaps); \ virObjectUnref(info.vm); \ -- 2.16.1

3 2

[libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0
by Ján Tomko 17 Apr '18

17 Apr '18

v2: * Change the version from 1.3.0 to 1.5.0 * Mention this breaks RHEL 6 QEMU and list the versions in relevant long-term releases Some of the patches are very big, available in my repo: https://repo.or.cz/libvirt/jtomko.git/shortlog/refs/heads/caps_cleanup_v2 git fetch git://repo.or.cz/libvirt/jtomko.git caps_cleanup_v2: Ján Tomko (44): qemuxml2argvtest: Fix q35-virt-manager capabilities Delete bogus cpu-host-passthrough test Force QMP capability probing Require QEMU 1.5.0 The following patches are nearly identical to v1: * rebased on the 1.3.1 and 1.4.2 caps deletion * luks-disks-source-qcow2.args is fixed Deprecate QEMU_CAPS_PCI_MULTIFUNCTION Deprecate QEMU_CAPS_NETDEV Clean up qemuDomainAttachNetDevice Remove unused qemuDomainNetVLAN Remove qemuDomainSupportsNetdev Deprecate QEMU_CAPS_MONITOR_JSON Deprecate QEMU_CAPS_NO_USER_CONFIG Deprecate QEMU_CAPS_MEM_PATH Deprecate QEMU_CAPS_DRIVE_SERIAL Deprecate QEMU_CAPS_SDL Deprecate QEMU_CAPS_RTC Deprecate QEMU_CAPS_RTC_TD_HACK Deprecate QEMU_CAPS_VHOST_NET Deprecate QEMU_CAPS_NODEFCONFIG Deprecate QEMU_CAPS_BOOT_MENU Deprecate QEMU_CAPS_FSDEV Deprecate QEMU_CAPS_NAME_PROCESS Deprecate QEMU_CAPS_SMBIOS_TYPE Deprecate QEMU_CAPS_VGA_NONE Deprecate QEMU_CAPS_DRIVE_AIO Deprecate QEMU_CAPS_CHARDEV_SPICEVMC Deprecate QEMU_CAPS_DEVICE_SPICEVMC Deprecate QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC Deprecate QEMU_CAPS_NO_SHUTDOWN Deprecate QEMU_CAPS_DRIVE_CACHE_UNSAFE Deprecate QEMU_CAPS_FSDEV_READONLY Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ Deprecate QEMU_CAPS_FSDEV_WRITEOUT Deprecate QEMU_CAPS_DRIVE_IOTUNE Deprecate QEMU_CAPS_WAKEUP Deprecate QEMU_CAPS_NETDEV_BRIDGE Deprecate QEMU_CAPS_SECCOMP_SANDBOX Deprecate QEMU_CAPS_DTB Deprecate QEMU_CAPS_IPV6_MIGRATION Deprecate QEMU_CAPS_MACHINE_OPT Deprecate QEMU_CAPS_DUMP_GUEST_CORE Deprecate QEMU_CAPS_VNC_SHARE_POLICY Deprecate QEMU_CAPS_HOST_PCI_MULTIDOMAIN Deprecate QEMU_CAPS_DISPLAY Deprecate QEMU_CAPS_MACHINE_USB_OPT cfg.mk | 2 +- src/qemu/qemu_capabilities.c | 936 +-------- src/qemu/qemu_capabilities.h | 74 +- src/qemu/qemu_capspriv.h | 17 +- src/qemu/qemu_command.c | 690 ++---- src/qemu/qemu_domain.c | 16 - src/qemu/qemu_domain.h | 6 - src/qemu/qemu_driver.c | 48 +- src/qemu/qemu_hotplug.c | 147 +- src/qemu/qemu_interface.c | 4 +- src/qemu/qemu_interface.h | 1 - src/qemu/qemu_migration.c | 10 +- src/qemu/qemu_process.c | 23 +- tests/Makefile.am | 8 +- .../qemucapabilitiesdata/caps_1.2.2.x86_64.replies | 1886 ----------------- tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 172 -- .../qemucapabilitiesdata/caps_1.3.1.x86_64.replies | 2141 ------------------- tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 196 -- .../qemucapabilitiesdata/caps_1.4.2.x86_64.replies | 2191 -------------------- tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 198 -- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 35 - tests/qemucapabilitiestest.c | 3 - tests/qemucapsprobe.c | 2 +- tests/qemuhelpdata/qemu-0.12.1 | 198 -- tests/qemuhelpdata/qemu-0.12.1-device | 62 - tests/qemuhelpdata/qemu-1.0 | 253 --- tests/qemuhelpdata/qemu-1.0-device | 148 -- tests/qemuhelpdata/qemu-1.1.0 | 269 --- tests/qemuhelpdata/qemu-1.1.0-device | 170 -- tests/qemuhelpdata/qemu-1.2.0 | 272 --- tests/qemuhelpdata/qemu-kvm-0.12.3 | 215 -- tests/qemuhelpdata/qemu-kvm-0.12.3-device | 63 - tests/qemuhelpdata/qemu-kvm-0.13.0 | 242 --- tests/qemuhelpdata/qemu-kvm-0.13.0-device | 90 - tests/qemuhelpdata/qemu-kvm-1.2.0 | 277 --- tests/qemuhelptest.c | 437 ---- .../aarch64-aavmf-virtio-mmio.args | 14 +- tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 9 +- [... lots of .args files ...] tests/qemuxml2argvdata/watchdog.args | 9 +- tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 9 +- tests/qemuxml2argvtest.c | 744 +++---- tests/qemuxml2xmltest.c | 119 +- 670 files changed, 4582 insertions(+), 14981 deletions(-) delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml delete mode 100644 tests/qemuhelpdata/qemu-0.12.1 delete mode 100644 tests/qemuhelpdata/qemu-0.12.1-device delete mode 100644 tests/qemuhelpdata/qemu-1.0 delete mode 100644 tests/qemuhelpdata/qemu-1.0-device delete mode 100644 tests/qemuhelpdata/qemu-1.1.0 delete mode 100644 tests/qemuhelpdata/qemu-1.1.0-device delete mode 100644 tests/qemuhelpdata/qemu-1.2.0 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3-device delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0-device delete mode 100644 tests/qemuhelpdata/qemu-kvm-1.2.0 delete mode 100644 tests/qemuhelptest.c delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.args delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.xml -- 2.16.1

4 102

[libvirt] [PATCH] tests: mock qemuInterfaceOpenVhostNet
by Ján Tomko 17 Apr '18

17 Apr '18

This functions contains logic that tries to use vhost for virtio interfaces, even if <driver name='vhost'/> was not supplied. In this case, a failure is non-fatal. On my system, /dev/vhost-net was not accessible to the user running 'make check', but we should not depend on that. Mock it to prevent accessing /dev/vhost-net and return some predictable file descriptor numbers instead. Introduced by commit c1f684e - deprecate QEMU_CAPS_VHOST_NET. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Reported-by: Jiří Denemark <jdenemar(a)redhat.com> --- tests/qemuxml2argvdata/user-aliases.args | 2 +- tests/qemuxml2argvmock.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/tests/qemuxml2argvdata/user-aliases.args b/tests/qemuxml2argvdata/user-aliases.args index d887d53fa..774c599b5 100644 --- a/tests/qemuxml2argvdata/user-aliases.args +++ b/tests/qemuxml2argvdata/user-aliases.args @@ -51,7 +51,7 @@ id=ua-myEncryptedDisk1 \ if=none,id=drive-ua-WhatAnAwesomeCDROM,media=cdrom,readonly=on,cache=none \ -device ide-drive,bus=ide.1,unit=0,drive=drive-ua-WhatAnAwesomeCDROM,\ id=ua-WhatAnAwesomeCDROM \ --netdev tap,fd=3,id=hostua-CheckoutThisNIC \ +-netdev tap,fd=3,id=hostua-CheckoutThisNIC,vhost=on,vhostfd=44 \ -device virtio-net-pci,netdev=hostua-CheckoutThisNIC,id=ua-CheckoutThisNIC,\ mac=52:54:00:d6:c0:0b,bus=pci.0,addr=0x3 \ -netdev socket,listen=127.0.0.1:1234,id=hostua-WeCanAlsoDoServerMode \ diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index 177b24e0a..adab5c911 100644 --- a/tests/qemuxml2argvmock.c +++ b/tests/qemuxml2argvmock.c @@ -36,6 +36,7 @@ #include "virstring.h" #include "virtpm.h" #include "virutil.h" +#include "qemu/qemu_interface.h" #include <time.h> #include <unistd.h> @@ -188,3 +189,21 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path ATTRIBUTE_UNUSED, { return VIR_STRDUP(*ifname, "vhost-user0"); } + +int +qemuInterfaceOpenVhostNet(virDomainDefPtr def ATTRIBUTE_UNUSED, + virDomainNetDefPtr net, + int *vhostfd, + size_t *vhostfdSize) +{ + size_t i; + + if (!(net->model && STREQ(net->model, "virtio"))) { + *vhostfdSize = 0; + return 0; + } + + for (i = 0; i < *vhostfdSize; i++) + vhostfd[i] = STDERR_FILENO + 42 + i; + return 0; +} -- 2.16.1

2 1

[libvirt] [PATCH] tests: Don't touch /dev/vhost-net in qemuxml2argvtest
by Martin Kletzander 17 Apr '18

17 Apr '18

The code is trying to open /dev/vhost-net from the host machine and if the current user has access to it, the command line will end up having two more options for an interface (,vhost=on,vhostfd=X where X is next free file descriptor). Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/qemuxml2argvmock.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index 177b24e0a953..11626e2794c1 100644 --- a/tests/qemuxml2argvmock.c +++ b/tests/qemuxml2argvmock.c @@ -20,6 +20,10 @@ #include <config.h> +#include <sys/types.h> +#include <sys/stat.h> +#include <fcntl.h> + #include "internal.h" #include "viralloc.h" #include "vircommand.h" @@ -188,3 +192,35 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path ATTRIBUTE_UNUSED, { return VIR_STRDUP(*ifname, "vhost-user0"); } + +static int (*real_open)(const char *path, int flags, ...); + +static void init_syms(void) +{ + if (real_open) + return; + + VIR_MOCK_REAL_INIT(open); +} + +int open(const char *path, int flags, ...) +{ + va_list ap; + mode_t mode = 0; + + init_syms(); + + if (STREQ(path, "/dev/vhost-net")) + return -1; + + /* The mode argument is mandatory when O_CREAT is set in flags, + * otherwise the argument is ignored. + */ + if (flags & O_CREAT) { + va_start(ap, flags); + mode = (mode_t) va_arg(ap, int); + va_end(ap); + } + + return real_open(path, flags, mode); +} -- 2.17.0

3 4

[libvirt] [PATCH] tests: Fix up test numbering in qemuxml2argvtest
by Martin Kletzander 17 Apr '18

17 Apr '18

Due to conditional execution of virTestRun(), the testCounter was incremented only if all the cases were run. When using VIR_TEST_RANGE=x-y, first x/2 of the increments were skipped and that made figuring out a precise case a PITA. Moving the condition into the test function makes it way nicer to find out the test numbers to use in VIR_TEST_RANGE. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tests/qemuxml2argvtest.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 7f1855782442..51adaabe1cc3 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -410,6 +410,9 @@ testCompareXMLToStartupXML(const void *data) char *actual = NULL; int ret = -1; + if (!info->vm) + return EXIT_AM_SKIP; + if (virAsprintf(&xml, "%s/qemuxml2startupxmloutdata/%s.xml", abs_srcdir, info->name) < 0) goto cleanup; @@ -664,8 +667,8 @@ mymain(void) if (virTestRun("QEMU XML-2-ARGV " name, \ testCompareXMLToArgv, &info) < 0) \ ret = -1; \ - if (info.vm && virTestRun("QEMU XML-2-startup-XML " name, \ - testCompareXMLToStartupXML, &info) < 0) \ + if (virTestRun("QEMU XML-2-startup-XML " name, \ + testCompareXMLToStartupXML, &info) < 0) \ ret = -1; \ virObjectUnref(info.qemuCaps); \ virObjectUnref(info.vm); \ -- 2.17.0

2 1

[libvirt] [jenkins-ci PATCH 0/4] MinGW builds tweaks and fixes
by Andrea Bolognani 17 Apr '18

17 Apr '18

Foreshadowed in https://www.redhat.com/archives/libvir-list/2018-April/msg01162.html Andrea Bolognani (4): guests: Add libvirt-glib+mingw project guests: Add virt-viewer+mingw project guests: Add icoutils dependency to virt-viewer+mingw guests: Rename gtk-vnc mapping to gtk-vnc2 guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ guests/vars/mappings.yml | 6 +++++- .../{libvirt-glib.yml => libvirt-glib+mingw.yml} | 2 -- guests/vars/projects/libvirt-glib.yml | 4 ---- .../{virt-viewer.yml => virt-viewer+mingw.yml} | 7 +------ guests/vars/projects/virt-viewer.yml | 24 +--------------------- 6 files changed, 9 insertions(+), 36 deletions(-) copy guests/vars/projects/{libvirt-glib.yml => libvirt-glib+mingw.yml} (87%) copy guests/vars/projects/{virt-viewer.yml => virt-viewer+mingw.yml} (88%) -- 2.14.3

2 8

[libvirt] [PATCH] tools: fix check_guests_shutdown loop
by Christian Ehrhardt 17 Apr '18

17 Apr '18

The recent fix to libvirt-guests.sh.in works for what it intended to fix (variable scope) but failed to adapt the loop in check_guests_shutdown correctly. Due to that it currently might detect all guests as "Failed to determine state of guest" by bad var content or just assumes they are shut down by picking up an empty variable. This commit fixes loop to use the passed value and the call in the loop to actually use the variable assigned in the iterated. Fixes: 7e476356 "tools: fix variable scope in in check_guests_shutdown" Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- tools/libvirt-guests.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index fcada31..28fe506 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -336,8 +336,8 @@ check_guests_shutdown() guests_to_check=$2 guests_shutting_down= - for guest in $guests; do - if ! guest_is_on "$uri" "$guests_to_check" >/dev/null 2>&1; then + for guest in $guests_to_check; do + if ! guest_is_on "$uri" "$guest" >/dev/null 2>&1; then eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore." echo continue -- 2.7.4

2 1

[libvirt] [PATCH v2 00/73] qemu: Refactor migration parameters
by Jiri Denemark 17 Apr '18

17 Apr '18

This series changes the way we handle migration parameters and capabilities with several goals: - make it all consistent and avoid storing the same parameters in several structs - reduce the number of QMP commands we use for setting migration capabilities - concentrate the logic in a separate file and make the code for migration parameters and capabilities in qemu_migration.c less complicated - reset all parameters and capabilities at the end of migration - make adding new parameters and capabilities easier Version 2: - qemuDomainCheckMigrationCapabilities is moved to qemu_migration_params.c (rather than to qemu_migration.c) - supported migration capabilities are sent via migration cookie so that some caps may be automatically enabled only when both sides support them Jiri Denemark (73): qemu: Rename qemuMigrationAnyCapsGet as qemuMigrationCapsGet qemu: Rename qemuMigrationParams qemu: New file for all APIs related to migration parameters qemu: Move qemuDomainCheckMigrationCapabilities qemu: Move qemuMigrationCapsGet qemu: Reindent qemuMigrationParamsSetEmptyTLS qemu: Make qemuMigrationParamsFree follow common pattern qemu: Allocate struct for migration parameters qemu: Drop qemuMigrationParamsClear qemu: Move qemuMigrationCompression struct qemu: Introduce qemuMigrationParams struct qemu: Reset migration parameters in qemuMigrationSrcCleanup qemu: Store original migration params in job qemu: Typedef struct qemuDomainJobObj qemu: Pass job object to qemuProcessRecoverMigration{In,Out} qemu: Reset all migration parameters qemu: Drop qemuMigrationParamsCheckSetupTLS qemu: Drop qemuMigrationParamsCheckTLSCreds qemu: Rename qemuMigrationParamsSetEmptyTLS qemu: Rename qemuMigrationParamsAddTLSObjects qemu: Set tlsHostname inside qemuMigrationParamsEnableTLS qemu: Hide cfg inside qemuMigrationParamsEnableTLS qemu: Rename qemuMigrationParamsSet qemu: Hide internals of qemuMigrationParams struct qemu: Introduce qemuMonitorSetMigrationCapabilities qemu: Set migration caps via migration params APIs qemu: Do not use qemuMonitorSetMigrationCapability qemu: Drop unused qemuMonitorSetMigrationCapability qemu: Add support for xbzrle-cache-size migration parameter qemu: Set XBZRLE cache size via migration parameters qemu: Move ParamsCheck closer to ParamsApply on Dst side qemu: Move ParamsCheck closer to ParamsApply on Src side qemu: Check supported caps in qemuMigrationParamsCheck qemu: Introduce qemuMigrationParty enum qemu: Use qemuMigrationParamsFromFlags everywhere qemu: Hide qemuMigrationParamsNew qemu: Drop qemuMigrationParamsSetPostCopy qemu: Set always-on migration caps in ParamsCheck qemu: Set migration capabilities automatically qemu: Call qemuMigrationAnyCompressionParse only from driver qemu: Generalize macro for getting VIR_MIGRATE_* typed params qemu: Drop qemuMigrationParamsSetCapability qemu: Move qemuMigrationParamsSetCompression qemu: Move qemuMigrationAnyCompression* qemu: Hide qemuMigrationParamsSetCompression qemu: Replace qemuMigrationAnyCompressionDump qemu: Drop qemuMigrationCompression structure qemu: Introduce qemuMigrationParamsFetch qemu: Limit usage of qemuMonitorMigrationParams qemumonitorjsontest: Drop migration params test util: Introduce virJSONValueObjectStealObject qemu: Move migration parameters JSON parsing qemu: Move migration parameters JSON formatting qemu: Export qemuMigrationParams{To,From}JSON for tests qemu: Move qemuMonitorMigrationParams structure qemu: Refactor qemuMigrationParams qemu: Move migration capabilities JSON formatting qemu: Move qemuMonitorMigrationCaps enum qemu: Add support for sending capabilities in migration cookie qemu: Check remote caps when enabling always-on capabilities qemu: Generalize qemuMigrationParamsGetDowntimeLimit qemu: Set migration parameters automatically qemu: Properly reset migration params when libvirtd restarts tests: Add tests for QEMU migration parameters qemumigparamstest: Add basic test data qemumigparamstest: Add test data for TLS parameters qemu: Store API flags for async jobs in qemuDomainJobObj qemu: Properly avoid cancelling memory-only dump qemu: Drop priv->job.dump_memory_only bool qemu: Drop priv->job.postcopyEnabled bool qemu: Store API flags for async jobs in status XML qemu: Don't delete TLS objects unless TLS migration was requested qemuxml2xmltest: Add status XML tests for migration params po/POTFILES.in | 1 + src/libvirt_private.syms | 1 + src/qemu/Makefile.inc.am | 3 + src/qemu/qemu_domain.c | 110 +- src/qemu/qemu_domain.h | 25 +- src/qemu/qemu_driver.c | 175 ++- src/qemu/qemu_migration.c | 926 ++--------- src/qemu/qemu_migration.h | 66 +- src/qemu/qemu_migration_cookie.c | 136 +- src/qemu/qemu_migration_cookie.h | 15 + src/qemu/qemu_migration_params.c | 1351 +++++++++++++++++ src/qemu/qemu_migration_params.h | 156 ++ src/qemu/qemu_migration_paramspriv.h | 35 + src/qemu/qemu_monitor.c | 76 +- src/qemu/qemu_monitor.h | 56 +- src/qemu/qemu_monitor_json.c | 133 +- src/qemu/qemu_monitor_json.h | 9 +- src/qemu/qemu_process.c | 30 +- src/qemu/qemu_process.h | 3 +- src/util/virjson.c | 8 + src/util/virjson.h | 2 + tests/Makefile.am | 12 + tests/qemumigparamsdata/basic.json | 9 + tests/qemumigparamsdata/basic.reply | 12 + tests/qemumigparamsdata/basic.xml | 11 + tests/qemumigparamsdata/empty.json | 3 + tests/qemumigparamsdata/empty.reply | 5 + tests/qemumigparamsdata/empty.xml | 4 + tests/qemumigparamsdata/tls-enabled.json | 11 + tests/qemumigparamsdata/tls-enabled.reply | 14 + tests/qemumigparamsdata/tls-enabled.xml | 13 + tests/qemumigparamsdata/tls-hostname.json | 11 + tests/qemumigparamsdata/tls-hostname.reply | 14 + tests/qemumigparamsdata/tls-hostname.xml | 13 + tests/qemumigparamsdata/tls.json | 11 + tests/qemumigparamsdata/tls.reply | 14 + tests/qemumigparamsdata/tls.xml | 13 + tests/qemumigparamsdata/unsupported.json | 3 + tests/qemumigparamsdata/unsupported.reply | 7 + tests/qemumigparamsdata/unsupported.xml | 4 + tests/qemumigparamstest.c | 242 +++ tests/qemumonitorjsontest.c | 123 +- .../migration-in-params-in.xml | 400 +++++ .../migration-in-params-out.xml | 1 + .../migration-out-nbd-out.xml | 450 +++++- .../migration-out-params-in.xml | 414 +++++ .../migration-out-params-out.xml | 1 + tests/qemuxml2xmltest.c | 2 + 48 files changed, 3766 insertions(+), 1368 deletions(-) create mode 100644 src/qemu/qemu_migration_params.c create mode 100644 src/qemu/qemu_migration_params.h create mode 100644 src/qemu/qemu_migration_paramspriv.h create mode 100644 tests/qemumigparamsdata/basic.json create mode 100644 tests/qemumigparamsdata/basic.reply create mode 100644 tests/qemumigparamsdata/basic.xml create mode 100644 tests/qemumigparamsdata/empty.json create mode 100644 tests/qemumigparamsdata/empty.reply create mode 100644 tests/qemumigparamsdata/empty.xml create mode 100644 tests/qemumigparamsdata/tls-enabled.json create mode 100644 tests/qemumigparamsdata/tls-enabled.reply create mode 100644 tests/qemumigparamsdata/tls-enabled.xml create mode 100644 tests/qemumigparamsdata/tls-hostname.json create mode 100644 tests/qemumigparamsdata/tls-hostname.reply create mode 100644 tests/qemumigparamsdata/tls-hostname.xml create mode 100644 tests/qemumigparamsdata/tls.json create mode 100644 tests/qemumigparamsdata/tls.reply create mode 100644 tests/qemumigparamsdata/tls.xml create mode 100644 tests/qemumigparamsdata/unsupported.json create mode 100644 tests/qemumigparamsdata/unsupported.reply create mode 100644 tests/qemumigparamsdata/unsupported.xml create mode 100644 tests/qemumigparamstest.c create mode 100644 tests/qemustatusxml2xmldata/migration-in-params-in.xml create mode 120000 tests/qemustatusxml2xmldata/migration-in-params-out.xml mode change 120000 => 100644 tests/qemustatusxml2xmldata/migration-out-nbd-out.xml create mode 100644 tests/qemustatusxml2xmldata/migration-out-params-in.xml create mode 120000 tests/qemustatusxml2xmldata/migration-out-params-out.xml -- 2.17.0

3 148

[libvirt] [PATCH v1 0/7] Enable memory-backend-file.discard-data
by Michal Privoznik 17 Apr '18

17 Apr '18

Qemu introduced this in 11ae6ed8affdd13. A small refactor is needed however. Michal Privoznik (7): qemu: Rename qemuMonitorGetObjectProps to qemuMonitorGetDeviceProps qemu_capabilities: s/ObjectProps/DeviceProps/g qemu_capabilities: Separate out device props fetching qemu_monitor: Introduce qemuMonitorGetObjectProps qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD tests: Update qemucapabilitiesdata qemu: Enable memory-backend-file.discard-data whenever possible src/qemu/qemu_capabilities.c | 269 +++++---- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 + src/qemu/qemu_monitor.c | 21 +- src/qemu/qemu_monitor.h | 5 +- src/qemu/qemu_monitor_json.c | 62 ++- src/qemu/qemu_monitor_json.h | 6 +- .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 +- .../caps_2.10.0.aarch64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 +- .../caps_2.10.0.x86_64.replies | 540 +++++++++--------- tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 26 +- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 2 +- .../caps_2.12.0.aarch64.replies | 24 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 24 +- .../caps_2.12.0.x86_64.replies | 612 +++++++++++---------- tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 3 +- .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 +- .../caps_2.6.0.aarch64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.s390x.replies | 28 +- tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies | 28 +- tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.replies | 32 +- tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 536 +++++++++--------- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 +- 50 files changed, 1458 insertions(+), 1135 deletions(-) -- 2.16.1

2 15

[libvirt] [PATCH] docs: index.html.in: Fix a typo in "virtualization platforms" link
by Erik Skultety 17 Apr '18

17 Apr '18

This was pointing to an .html.in file rather than to the intended html document. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed under the trivial rule. docs/index.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/index.html.in b/docs/index.html.in index 4783c39e3..1f9f44839 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -28,7 +28,7 @@ The libvirt project: </p> <ul> - <li>is a toolkit to manage <a href="platforms.html.in">virtualization platforms</a></li> + <li>is a toolkit to manage <a href="platforms.html">virtualization platforms</a></li> <li>is accessible from C, Python, Perl, Java and more</li> <li>is licensed under open source licenses</li> <li>supports <a href="drvqemu.html">KVM</a>, -- 2.14.3

1 0

[libvirt] [PATCH 0/9] virClassNew rework
by Michal Privoznik 17 Apr '18

17 Apr '18

4 29

[libvirt] [PATCH] virsh: Clear vsh last error during virshCommandOptVolBy
by John Ferlan 17 Apr '18

17 Apr '18

https://bugzilla.redhat.com/show_bug.cgi?id=1529256 If one of the virStorageVolLookupBy{Key|Name|Path} succeeds and we have a @vol, then clear the last libvirt error; otherwise, a subsequent "other" failure may cause vshReportError to erroneously report the wrong error as well as a reported 'vshError' error that caused the failure. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh-volume.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index bacbec0d27..9d6ebd2325 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -129,6 +129,8 @@ virshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd, else vshError(ctl, _("failed to get vol '%s', specifying --%s " "might help"), n, pooloptname); + } else { + vshResetLibvirtError(); } /* If the pool was specified, then make sure that the returned -- 2.13.6

2 1

[libvirt] [PATCH 0/2] Trivial fixes
by Radostin Stoyanov 16 Apr '18

16 Apr '18

Radostin Stoyanov (2): lxc: s/subtreee/subtree/ lxc: Clean up /.oldroot src/lxc/lxc_container.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.14.3

3 5

[libvirt] [PATCH] qemu_domain: Don't leak @paths in qemuDomainNamespaceSetupDisk
by Michal Privoznik 16 Apr '18

16 Apr '18

Introduced in d3db304d2e4. Instead of returning immediately we need to jump onto cleanup label where @paths is freed. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7000de6a91..6e18886d07 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11199,7 +11199,7 @@ qemuDomainNamespaceSetupDisk(virDomainObjPtr vm, } if (qemuDomainNamespaceMknodPaths(vm, paths, npaths) < 0) - return -1; + goto cleanup; ret = 0; cleanup: -- 2.16.1

1 0

[libvirt] [PATCH 0/3] qemu: use FD passing for monitor (and other unix sockets)
by Daniel P. Berrangé 16 Apr '18

16 Apr '18

This series makes use of the chardev fd passing arriving in QEMU 2.12 to get rid of the startup race wrt opening the QEMU monitor. The same thing benefits the agent too but I've not tackled that yet. Daniel P. Berrangé (3): qemu: probe for -chardev 'fd' parameter for FD passing qemu: support passing pre-opened UNIX socket listen FD qemu: don't retry connect() if doing FD passing src/qemu/qemu_capabilities.c | 4 ++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 58 ++++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_monitor.c | 54 ++++++++++++++++++++++++----------------- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_process.c | 27 +++++++++++++++------ tests/qemumonitortestutils.c | 1 + 7 files changed, 114 insertions(+), 32 deletions(-) -- 2.14.3

3 9

[libvirt] [PATCH 0/2] A couple of openvz fixups
by John Ferlan 16 Apr '18

16 Apr '18

Patch 1 came from "the next part" of the code when I determined that the Unref was unnecessary Patch 2 is a result of Jim Fehlig's review that openvzDomainGetHostname doesn't really need the error/cleanup logic. John Ferlan (2): openvz: Remove unnecessary Unref in openvzLoadDomains openvz: Clean up openvzDomainGetHostname src/openvz/openvz_conf.c | 1 - src/openvz/openvz_driver.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) -- 2.13.6

2 4

[libvirt] [dbus PATCH] maint: rename test directory to tests
by Pavel Hrdina 16 Apr '18

16 Apr '18

Our ci.centos.org expects the project uses 'tests' name. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- .travis.yml | 2 +- Makefile.am | 2 +- configure.ac | 2 +- {test => tests}/Makefile.am | 0 {test => tests}/conftest.py | 0 {test => tests}/libvirttest.py | 0 {test => tests}/test_connect.py | 0 {test => tests}/test_domain.py | 0 {test => tests}/test_network.py | 0 {test => tests}/travis-run | 0 10 files changed, 3 insertions(+), 3 deletions(-) rename {test => tests}/Makefile.am (100%) rename {test => tests}/conftest.py (100%) rename {test => tests}/libvirttest.py (100%) rename {test => tests}/test_connect.py (100%) rename {test => tests}/test_domain.py (100%) rename {test => tests}/test_network.py (100%) rename {test => tests}/travis-run (100%) diff --git a/.travis.yml b/.travis.yml index 71c2e9c..d60eaf2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ dist: trusty language: c sudo: true -script: test/travis-run +script: tests/travis-run env: - ARCH=amd64 - ARCH=i386 diff --git a/Makefile.am b/Makefile.am index a890ff1..16f57b2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,5 @@ -SUBDIRS = data src test +SUBDIRS = data src tests ACLOCAL_AMFLAGS = -I m4 diff --git a/configure.ac b/configure.ac index ea2c330..6f166f2 100644 --- a/configure.ac +++ b/configure.ac @@ -75,5 +75,5 @@ AC_CONFIG_FILES([run], AC_OUTPUT(Makefile data/Makefile src/Makefile - test/Makefile + tests/Makefile libvirt-dbus.spec) diff --git a/test/Makefile.am b/tests/Makefile.am similarity index 100% rename from test/Makefile.am rename to tests/Makefile.am diff --git a/test/conftest.py b/tests/conftest.py similarity index 100% rename from test/conftest.py rename to tests/conftest.py diff --git a/test/libvirttest.py b/tests/libvirttest.py similarity index 100% rename from test/libvirttest.py rename to tests/libvirttest.py diff --git a/test/test_connect.py b/tests/test_connect.py similarity index 100% rename from test/test_connect.py rename to tests/test_connect.py diff --git a/test/test_domain.py b/tests/test_domain.py similarity index 100% rename from test/test_domain.py rename to tests/test_domain.py diff --git a/test/test_network.py b/tests/test_network.py similarity index 100% rename from test/test_network.py rename to tests/test_network.py diff --git a/test/travis-run b/tests/travis-run similarity index 100% rename from test/travis-run rename to tests/travis-run -- 2.14.3

1 1

[libvirt] [jenkins-ci PATCH] guests: Only attempt to fix intltool-update if it exists
by Andrea Bolognani 16 Apr '18

16 Apr '18

If we're running against a freshly-provisioned FreeBSD guest, intltool won't have been installed yet and attempts to fix it will fail. Make sure the file exists. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/kludges.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml index 4dd06a4..0ad61a7 100644 --- a/guests/tasks/kludges.yml +++ b/guests/tasks/kludges.yml @@ -52,6 +52,13 @@ # wait for the port to be fixed, we can patch things up ourselves. # # See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227444 +- name: Look for intltool-update + stat: + path: /usr/local/bin/intltool-update + register: intltoolupdate + when: + - os_name == 'FreeBSD' + - name: Fix intltool-update replace: path: /usr/local/bin/intltool-update @@ -59,3 +66,4 @@ replace: '\1 !~ /\\$\\{?$2}?/;' when: - os_name == 'FreeBSD' + - intltoolupdate.stat.exists -- 2.14.3

2 4

[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project
by Andrea Bolognani 16 Apr '18

16 Apr '18

The icotool command is used to manipulate Windows icon files. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e074648..6af5065 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -173,6 +173,10 @@ mappings: hal: FreeBSD: hal + icoutils: + default: icoutils + CentOS6: + intltool: default: intltool diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml index 6f3dbf9..54c96fe 100644 --- a/guests/vars/projects/virt-viewer.yml +++ b/guests/vars/projects/virt-viewer.yml @@ -3,6 +3,7 @@ packages: - glib2 - gtk-vnc - gtk3 + - icoutils - intltool - libgovirt - libxml2 -- 2.14.3

2 2

[libvirt] [jenkins-ci PATCH] guests: Set remote_user at the playbook level
by Andrea Bolognani 16 Apr '18

16 Apr '18

This is very convenient for developers using the 'test' flavor, because it ensures $ ./lcitool update all still works by logging in as root, but at the same time ad-hoc invocations such as $ ansible all -m shell -a 'cd libvirt && $MAKE -j check' and custom playbooks log in as the 'test' user instead, and as such have all the usual environment variables ($MAKE, $PYTHON, $PATH, $VIRT_PREFIX and friends) available to them, which makes testing changes locally a breeze. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/group_vars/all/main.yml | 2 -- guests/site.yml | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/group_vars/all/main.yml b/guests/group_vars/all/main.yml index 2bdb7b3..4e05c66 100644 --- a/guests/group_vars/all/main.yml +++ b/guests/group_vars/all/main.yml @@ -1,6 +1,4 @@ --- -ansible_user: root - # This password is only used to access the guest the very first time # Ansible is used: afterwards, the user's SSH key will have been installed # in the guest and SSH password authentication will have been disabled diff --git a/guests/site.yml b/guests/site.yml index 26127be..520aea7 100644 --- a/guests/site.yml +++ b/guests/site.yml @@ -1,5 +1,6 @@ --- - hosts: all + remote_user: root gather_facts: no tasks: @@ -8,6 +9,7 @@ - include: tasks/bootstrap.yml - hosts: all + remote_user: root vars_files: - vars/mappings.yml -- 2.14.3

2 1

[libvirt] [jenkins-ci PATCH v2] guests: Clean up packages after update
by Andrea Bolognani 16 Apr '18

16 Apr '18

The package cache can grow to eat up a lot of disk space, and not removing unused packages can lead to upgrade issues down the line for fast moving distributions such as Fedora Rawhide. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * call 'yum autoremove' when possible. [v1] https://www.redhat.com/archives/libvir-list/2018-April/msg00970.html guests/tasks/base.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 53cbd65..616db0a 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -117,6 +117,34 @@ when: - package_format == 'pkg' +- name: Clean up packages after update + command: yum clean packages -y + args: + warn: no + when: + - package_format == 'rpm' + +- name: Clean up packages after update + command: yum autoremove -y + args: + warn: no + when: + - package_format == 'rpm' + - not ( os_name == 'CentOS' and + os_version == '6' ) + +- name: Clean up packages after update + apt: + autoclean: yes + autoremove: yes + when: + - package_format == 'deb' + +- name: Clean up packages after update + shell: pkg clean -y && pkg autoremove -y + when: + - package_format == 'pkg' + - name: Configure hostname hostname: name: '{{ inventory_hostname }}' -- 2.14.3

2 1

[libvirt] [jenkins-ci PATCH] guests: Introduce libvirt+mingw project
by Andrea Bolognani 16 Apr '18

16 Apr '18

Instead of cramming the dependencies that we need for a MinGW build of libvirt along with those we need for a native build, create a new project for the former. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/host_vars/libvirt-fedora-rawhide/main.yml | 1 + guests/vars/projects/libvirt+mingw.yml | 28 ++++++++++++++++++++++++ guests/vars/projects/libvirt.yml | 24 -------------------- 3 files changed, 29 insertions(+), 24 deletions(-) create mode 100644 guests/vars/projects/libvirt+mingw.yml diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host_vars/libvirt-fedora-rawhide/main.yml index 3f69f80..c905fb0 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -5,6 +5,7 @@ PYTHONPATH: $VIRT_PREFIX/lib64/python3.6/site-packages projects: - libosinfo - libvirt + - libvirt+mingw - libvirt-cim - libvirt-dbus - libvirt-glib diff --git a/guests/vars/projects/libvirt+mingw.yml b/guests/vars/projects/libvirt+mingw.yml new file mode 100644 index 0000000..0dacb30 --- /dev/null +++ b/guests/vars/projects/libvirt+mingw.yml @@ -0,0 +1,28 @@ +--- +packages: + - mingw32-curl + - mingw32-dbus + - mingw32-dlfcn + - mingw32-gcc + - mingw32-gettext + - mingw32-gnutls + - mingw32-libssh2 + - mingw32-libxml2 + - mingw32-openssl + - mingw32-pkg-config + - mingw32-portablexdr + - mingw32-readline + - mingw64-curl + - mingw64-dbus + - mingw64-dlfcn + - mingw64-gcc + - mingw64-gettext + - mingw64-gnutls + - mingw64-libssh2 + - mingw64-libxml2 + - mingw64-openssl + - mingw64-pkg-config + - mingw64-portablexdr + - mingw64-readline + - rpcgen + - xsltproc diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 598dfc4..ad42fd5 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -36,30 +36,6 @@ packages: - libudev - libxml2 - lvm2 - - mingw32-curl - - mingw32-dbus - - mingw32-dlfcn - - mingw32-gcc - - mingw32-gettext - - mingw32-gnutls - - mingw32-libssh2 - - mingw32-libxml2 - - mingw32-openssl - - mingw32-pkg-config - - mingw32-portablexdr - - mingw32-readline - - mingw64-curl - - mingw64-dbus - - mingw64-dlfcn - - mingw64-gcc - - mingw64-gettext - - mingw64-gnutls - - mingw64-libssh2 - - mingw64-libxml2 - - mingw64-openssl - - mingw64-pkg-config - - mingw64-portablexdr - - mingw64-readline - netcf - numad - openwsman -- 2.14.3

2 1

[libvirt] [dbus PATCH] tests: Avoid hidding TimeoutError in main loop
by Katerina Koukiou 16 Apr '18

16 Apr '18

Currently the error was not propagated from the timeout handler properly, and we had PASSED tests even with timeouts. Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- test/libvirttest.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/libvirttest.py b/test/libvirttest.py index 7168e66..d1b71cc 100644 --- a/test/libvirttest.py +++ b/test/libvirttest.py @@ -60,11 +60,14 @@ class BaseTestClass(): def timeout(): self.loop.quit() del self.loop - raise TimeoutError() + self.timeout = True + self.timeout = False self.loop = GLib.MainLoop() GLib.timeout_add(2000, timeout) self.loop.run() + if self.timeout: + raise TimeoutError() def domain(self): path = self.connect.ListDomains(0)[0] -- 2.15.0

2 1

[libvirt] [PATCHv3 0/6] Use query-cpus-fast instead of query-cpus
by Viktor Mihajlovski 16 Apr '18

16 Apr '18

The QEMU monitor commmand query-cpus is deprecated starting with QEMU 2.12.0 because it can adversely affect the performance of a running virtual machine. This series enables libvirt to use the new query-cpus-fast interface if supported by the local QEMU instance and is required in order to support QEMU once the interface has been removed. query-cpus-fast doesn't return the halted state for a virtual CPU, meaning that the vcpu.<n>.halted value won't be reported with 'virsh domstats' anymore. This is OK, as stats values are not guaranteed to be reported under all circumstances and on all architectures. Upstream discussion consensus was that the halted state was problematic anyway, as it had different semantics per architecture. The only known exploitation happened for s390, for this architecture the halted state will be computed based on an architecture-specific cpu value returned in query-cpus-fast. v2 -> v3: ========= Patch changes: 1/6: - formatting changes as requested by John Ferlan - updated the qemucapabilitiestest XML files - dropped A/R-bys (due to change above) 2/6: - fixed comment to also account for query-cpus-fast 3/6: - updated json monitor tests to account for props returned by query-cpus and query-cpus-fast - updated json monitor tests to handle the halted property (moved here from patch 5) 4/6: - removed stale text (about callbacks) from commit message - simplified qemuMonitorJSONExtractCPUArchInfo call - enhanced sample JSON response in comment - fixed inter-function spacing 5/6: - kept s390-specific tests and moved the rest to patch 3 - reformatted the JSON responses (indented "props") - dropped R-b v1 -> v2: ========= Patch changes: 1/6: - add Acked-by: Peter Krempa 2/6: - evaluate capability outside of monitor code (changes signatures of qemuMonitorGetCPUInfo and qemuMonitorGetCpuHalted) - remove ternary expressions as requested by review - remove Reviewed-bys due to code changes 3/6 - adapt test cases to changes above - remove Reviewed-bys due to code changes 4/6 - replace callbacks for architecture data extraction with direct function calls - remove Reviewed-bys due to code changes Viktor Mihajlovski (6): qemu: add capability detection for query-cpus-fast qemu: use query-cpus-fast in JSON monitor tests: add qemumonitorjson tests for query-cpus-fast qemu: add architecture-specific CPU info handling tests: add testcase for s390 query-cpus-fast qemu: refresh vcpu halted state only via query-cpus-fast src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.c | 23 +++- src/qemu/qemu_monitor.c | 30 +++-- src/qemu/qemu_monitor.h | 7 +- src/qemu/qemu_monitor_json.c | 133 +++++++++++++++++++-- src/qemu/qemu_monitor_json.h | 3 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + .../qemumonitorjson-cpuinfo-ppc64-hotplug-4.data | 8 ++ .../qemumonitorjson-cpuinfo-s390-fast-cpus.json | 25 ++++ .../qemumonitorjson-cpuinfo-s390-fast-hotplug.json | 21 ++++ .../qemumonitorjson-cpuinfo-s390-fast.data | 19 +++ ...emumonitorjson-cpuinfo-x86-basic-pluggable.data | 5 + ...qemumonitorjson-cpuinfo-x86-full-fast-cpus.json | 126 +++++++++++++++++++ ...umonitorjson-cpuinfo-x86-full-fast-hotplug.json | 115 ++++++++++++++++++ .../qemumonitorjson-cpuinfo-x86-full-fast.data | 109 +++++++++++++++++ .../qemumonitorjson-cpuinfo-x86-node-full.data | 2 + tests/qemumonitorjsontest.c | 123 +++++++++++++++---- tests/qemumonitortestutils.c | 7 ++ tests/qemumonitortestutils.h | 1 + 23 files changed, 706 insertions(+), 58 deletions(-) create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-s390-fast-cpus.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-s390-fast-hotplug.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-s390-fast.data create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-cpus.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast-hotplug.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-x86-full-fast.data -- 1.9.1

3 11

[libvirt] [PATCH] qemu: remove obsolete qemuMonitorMigrateToCommand
by Daniel P. Berrangé 15 Apr '18

15 Apr '18

The last use of qemuMonitorMigrateToCommand was removed years back in commit 2e90c9daf9eabe15d826a48c06607acb9d18fda6 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Fri Nov 6 16:50:26 2015 +0000 qemu: assume support for all migration protocols except rdma Prior to that commit, 'exec:' to used to replicate the 'unix:' protocol by spawning 'nc'. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_monitor.c | 31 ------------------------------- src/qemu/qemu_monitor.h | 4 ---- 2 files changed, 35 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 7b647525b3..22f05222db 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2730,37 +2730,6 @@ qemuMonitorMigrateToHost(qemuMonitorPtr mon, } -int -qemuMonitorMigrateToCommand(qemuMonitorPtr mon, - unsigned int flags, - const char * const *argv) -{ - char *argstr; - char *dest = NULL; - int ret = -1; - VIR_DEBUG("argv=%p flags=0x%x", argv, flags); - - QEMU_CHECK_MONITOR(mon); - - argstr = virArgvToString(argv); - if (!argstr) - goto cleanup; - - if (virAsprintf(&dest, "exec:%s", argstr) < 0) - goto cleanup; - - if (mon->json) - ret = qemuMonitorJSONMigrate(mon, flags, dest); - else - ret = qemuMonitorTextMigrate(mon, flags, dest); - - cleanup: - VIR_FREE(argstr); - VIR_FREE(dest); - return ret; -} - - int qemuMonitorMigrateCancel(qemuMonitorPtr mon) { diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index d04148e568..9556a51341 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -784,10 +784,6 @@ int qemuMonitorMigrateToHost(qemuMonitorPtr mon, const char *hostname, int port); -int qemuMonitorMigrateToCommand(qemuMonitorPtr mon, - unsigned int flags, - const char * const *argv); - int qemuMonitorMigrateCancel(qemuMonitorPtr mon); int qemuMonitorGetDumpGuestMemoryCapability(qemuMonitorPtr mon, -- 2.14.3

2 1

[libvirt] [PATCH] apparmor: add rules to use qemu_bridge_helper
by Christian Ehrhardt 14 Apr '18

14 Apr '18

Due to mediation of socket and signal activity currently qemu:///session connections calling qemu_bridge_helper fail. We need the profile for libvirtd itself and the subprofile for qemu-bridge-helper to be able to talk/notify to each other via unix socket and signals. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1754871 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- examples/apparmor/usr.sbin.libvirtd | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/examples/apparmor/usr.sbin.libvirtd b/examples/apparmor/usr.sbin.libvirtd index be4fabf..3102cab 100644 --- a/examples/apparmor/usr.sbin.libvirtd +++ b/examples/apparmor/usr.sbin.libvirtd @@ -65,6 +65,10 @@ signal (read, send) peer=libvirt-*, signal (send) set=("kill", "term") peer=unconfined, + # For communication/control to qemu-bridge-helper + unix (send, receive) type=stream addr=none peer=(label=/usr/sbin/libvirtd//qemu_bridge_helper), + signal (send) set=("term") peer=/usr/sbin/libvirtd//qemu_bridge_helper, + # Very lenient profile for libvirtd since we want to first focus on confining # the guests. Guests will have a very restricted profile. / r, @@ -112,6 +116,10 @@ network inet stream, + # For communication/control from libvirtd + unix (send, receive) type=stream addr=none peer=(label=/usr/sbin/libvirtd), + signal (receive) set=("term") peer=/usr/sbin/libvirtd, + /dev/net/tun rw, /etc/qemu/** r, owner @{PROC}/*/status r, -- 2.7.4

3 3

[libvirt] [PATCH] acl: remove various left over Xen ACL whitelist entries
by Daniel P. Berrangé 13 Apr '18

13 Apr '18

The legacy xen driver is removed, so these ACLL hacks can be removed too now. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/check-aclrules.pl | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl index 5b6c711dc8..374abaa722 100755 --- a/src/check-aclrules.pl +++ b/src/check-aclrules.pl @@ -61,26 +61,12 @@ my %whitelist = ( "interfaceClose" => 1, ); -# Temp hack - remove it once xen driver is fixed +# XXX this vzDomainMigrateConfirm3Params looks +# bogus - determine why it doesn't have a valid +# ACL check. my %implwhitelist = ( - "xenUnifiedDomainRestore" => 1, - "xenUnifiedDomainRestoreFlags" => 1, - "xenUnifiedDomainMigratePrepare" => 1, - "xenUnifiedNodeDeviceDettach" => 1, - "xenUnifiedNodeDeviceDetachFlags" => 1, - "xenUnifiedNodeDeviceReset" => 1, - "xenUnifiedDomainIsActive" => 1, - "xenUnifiedDomainIsPersistent" => 1, - "xenUnifiedDomainIsUpdated" => 1, - "xenUnifiedDomainOpenConsole" => 1, "vzDomainMigrateConfirm3Params" => 1, ); -my %filterimplwhitelist = ( - "xenUnifiedConnectListDomains" => 1, - "xenUnifiedConnectNumOfDomains" => 1, - "xenUnifiedConnectListDefinedDomains" => 1, - "xenUnifiedConnectNumOfDefinedDomains" => 1, - ); my $lastfile; @@ -234,8 +220,7 @@ while (<>) { } if (exists $filtered{$api} && - !exists $aclfilters{$impl} && - !exists $filterimplwhitelist{$impl}) { + !exists $aclfilters{$impl}) { print "$ARGV:$. Missing ACL filter in function '$impl' for '$api'\n"; $status = 1; } -- 2.14.3

2 1

[libvirt] [PATCH 0/2] Fix vmware driver for VMware Fusion 10
by Rainer Müller 13 Apr '18

13 Apr '18

These changes were required to get VMware Fusion working at all. I tested with VMware Fusion 10.1.1 on macOS 10.12 Sierra. I am not sure whether calling virCapabilitiesInitCaches() makes sense at all on macOS. This function looks highly specific to Linux as it relies on /sys/devices/system, so it should probably be wrapped with an appropriate #ifdef. I do not feel proficient enough with the libvirt internals to make this change, though. Rainer Müller (2): vmware: Fix initialization of VMware Fusion vmware: Failures in cache info init are non-fatal src/vmware/vmware_conf.c | 7 ++++++- src/vmware/vmware_driver.c | 9 ++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) -- 2.16.3

2 5

[libvirt] [PATCH jenkins-ci 0/2] Enable virt-viewer mingw build
by Daniel P. Berrangé 13 Apr '18

13 Apr '18

Daniel P. Berrangé (2): Enable mingw build for libvirt-glib project Enable mingw build for virt-viewer project guests/vars/mappings.yml | 72 +++++++++++++++++++++++++++++++++++ guests/vars/projects/libvirt-glib.yml | 2 + guests/vars/projects/virt-viewer.yml | 24 ++++++++++++ projects/libvirt-glib.yaml | 4 ++ projects/virt-viewer.yaml | 4 ++ 5 files changed, 106 insertions(+) -- 2.14.3

2 16

[libvirt] [RFC] passing standard input to host bootloaders
by Fabian Freyer 13 Apr '18

13 Apr '18

Hello list, Some host boot loaders, e.g. grub-bhyve when using the bhyve driver, take commands on stdin. While there is the <bootloader_args> tag to set arbitrary command line tags, there is no <bootloader_stdin> or similar to provide standard input to the boot loader. Typical input could be something along the lines of e.g. the following grub commands: kernel (cd)/path/to/vmlinuz some-cmdline initrd (root)/path/to/host/initrd boot Using e.g. the (root) device is especially useful on the bhyve driver when creating diskless VMs. Before I start implementing this, I’d appreciate some feedback on the following two points: 1) should this be an attr on the <bootloader> tag, e.g. <bootloader_stdin=“/path/to/file”>/path/to/bootloader</bootloader> or rather, as there already exists a <bootloader_args> tag a separate <bootloader_stdin> tag? 2) should the input be passed verbatim in the domain def, e.g. using a CDATA block or from a file? Should this be user-specified, e.g. in an attr? <bootloader_stdin from=“/path/to/file”/> <bootloader_stdin> <![CDATA[ kernel (host)/path/to/kernel with cmdline initrd (host)/path/to/ramdisk boot ]]> </bootloader_stdin> Regards, Fabian

1 0

[libvirt] [PATCH] Add function that raises error if domain is not active
by Clementine Hayat 13 Apr '18

13 Apr '18

Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c. It calls virDomainObjIsActive, raises error and returns. There is a lot of occurence of this pattern and it will save 3 lines on each call. Knowing that there is over 100 occurences, it will remove 300 lines from the code base. Signed-off-by: Clementine Hayat <clem(a)lse.epita.fr> --- Patch proposed for gsoc2018. src/conf/domain_conf.c | 11 +++++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 96 +++++++++------------------------------- 4 files changed, 34 insertions(+), 76 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d23182f18..86d28c26a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6003,6 +6003,17 @@ virDomainDefValidate(virDomainDefPtr def, return 0; } +int +virDomainObjCheckIsActive(virDomainObjPtr dom) +{ + if (!virDomainObjIsActive(dom)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + return -1; + } + return 0; +} + /** * virDomainDeviceLoadparmIsValid diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index bbaa24137..8de4c4145 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2722,6 +2722,8 @@ virDomainObjIsActive(virDomainObjPtr dom) return dom->def->id != -1; } +int virDomainObjCheckIsActive(virDomainObjPtr dom); + int virDomainDefSetVcpusMax(virDomainDefPtr def, unsigned int vcpus, virDomainXMLOptionPtr xmlopt); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index cab324c4d..d90df3583 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -474,6 +474,7 @@ virDomainNostateReasonTypeFromString; virDomainNostateReasonTypeToString; virDomainObjAssignDef; virDomainObjBroadcast; +virDomainObjCheckIsActive; virDomainObjCopyPersistentDef; virDomainObjEndAPI; virDomainObjFormat; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index fcd79bd71..22cc9bddb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3537,11 +3537,8 @@ qemuDomainSaveFlags(virDomainPtr dom, const char *path, const char *dxml, if (virDomainSaveFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto cleanup; - } ret = qemuDomainSaveInternal(driver, vm, path, compressed, compressedpath, dxml, flags); @@ -3595,11 +3592,9 @@ qemuDomainManagedSave(virDomainPtr dom, unsigned int flags) if (virDomainManagedSaveEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto cleanup; - } + if (!vm->persistent) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("cannot do managed save for transient domain")); @@ -3939,11 +3934,8 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, VIR_DOMAIN_JOB_OPERATION_DUMP) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; priv->job.current->statsType = QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP; @@ -4054,11 +4046,8 @@ qemuDomainScreenshot(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } /* Well, even if qemu allows multiple graphic cards, heads, whatever, * screenshot command does not */ @@ -4165,11 +4154,8 @@ processWatchdogEvent(virQEMUDriverPtr driver, goto cleanup; } - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } flags |= cfg->autoDumpBypassCache ? VIR_DUMP_BYPASS_CACHE: 0; if ((ret = doCoreDump(driver, vm, dumpfile, flags, @@ -10841,11 +10827,8 @@ qemuDomainBlockResize(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } if (!(disk = virDomainDiskByName(vm->def, path, false))) { virReportError(VIR_ERR_INVALID_ARG, @@ -11001,11 +10984,8 @@ qemuDomainBlockStats(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } if (qemuDomainBlocksStatsGather(driver, vm, path, &blockstats) < 0) goto endjob; @@ -11058,11 +11038,8 @@ qemuDomainBlockStatsFlags(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } if ((nstats = qemuDomainBlocksStatsGather(driver, vm, path, &blockstats)) < 0) @@ -11128,11 +11105,8 @@ qemuDomainInterfaceStats(virDomainPtr dom, if (virDomainInterfaceStatsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto cleanup; - } if (!(net = virDomainNetFind(vm->def, device))) goto cleanup; @@ -11484,11 +11458,8 @@ qemuDomainMemoryStatsInternal(virQEMUDriverPtr driver, int ret = -1; long rss; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) return -1; - } if (vm->def->memballoon && vm->def->memballoon->model == VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO) { @@ -11638,11 +11609,8 @@ qemuDomainMemoryPeek(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } if (virAsprintf(&tmp, "%s/qemu.mem.XXXXXX", cfg->cacheDir) < 0) goto endjob; @@ -13294,11 +13262,8 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) return -1; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto cleanup; - } if (!priv->job.current) { jobInfo->status = QEMU_DOMAIN_JOB_STATUS_NONE; @@ -13426,11 +13391,8 @@ static int qemuDomainAbortJob(virDomainPtr dom) if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_ABORT) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; @@ -13493,11 +13455,8 @@ qemuDomainMigrateSetMaxDowntime(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MIGRATION_OP) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; @@ -13538,11 +13497,8 @@ qemuDomainMigrateGetMaxDowntime(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; qemuDomainObjEnterMonitor(driver, vm); @@ -13591,11 +13547,8 @@ qemuDomainMigrateGetCompressionCache(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; @@ -13642,11 +13595,8 @@ qemuDomainMigrateSetCompressionCache(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MIGRATION_OP) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; @@ -13704,11 +13654,8 @@ qemuDomainMigrateSetMaxSpeed(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MIGRATION_OP) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } VIR_DEBUG("Setting migration bandwidth to %luMbs", bandwidth); qemuDomainObjEnterMonitor(driver, vm); @@ -13779,11 +13726,8 @@ qemuDomainMigrateStartPostCopy(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MIGRATION_OP) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); + if (virDomainObjCheckIsActive(vm) < 0) goto endjob; - } priv = vm->privateData; -- 2.17.0

6 6

[libvirt] [dbus PATCH v3 00/20] More APIs for Domain Interface
by Katerina Koukiou 13 Apr '18

13 Apr '18

Changes from v2: Adjusted to reviews. Katerina Koukiou (20): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface Implement GetJobInfo method for Domain interface Implement AbortJob for Domain interface Implement MigrateSetMaxDowntime method for Domain interface Implement MigrateGetMaxDowntime method for Domain Interface Implement ManagedSave method for Domain Interface Implement HasManagedSaveImage method for Domain Interface Implement ManagedSaveRemove method for Domain Interface Implement SetVcpus method for Domain Interface Implement GetMemoryParameters method for Domain Interface Implement GetBlkioParameters method for domain Interface Implement Updated property for Domain Interface Implement MigrateGetMaxSpeed method for Domain Interface Implement MigrateSetMaxSpeed method for Domain Interface Implement SetMemory method for Domain Interface Implement GetSchedulerParameters method for Domain Interface data/org.libvirt.Domain.xml | 110 +++++++- src/domain.c | 605 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 37 ++- 3 files changed, 747 insertions(+), 5 deletions(-) -- 2.15.0

2 25

[libvirt] [PATCH v5 00/10] x86: Secure Encrypted Virtualization (AMD)
by Brijesh Singh 13 Apr '18

13 Apr '18

This patch series provides support for launching an encrypted guest using AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV feature allows the memory contents of a virtual machine (VM) to be transparently encrypted with a key unique to the guest VM. At very high level the flow looks this: 1. mgmt tool calls virConnectGetDomainCapabilities. This returns an XML document that includes the following <feature> ... <sev supported='yes'> <cbitpos> </cbitpos> <reduced-phys-bits> </reduced-phys-bits> <pdh> </pdh> <cert-chain> </cert-chain> </feature> If <sev> is provided then we indicate that hypervisor is capable of launching SEV guest. 2. (optional) mgmt tool can provide the PDH and Cert-chain to guest owner in case if guest owner wish to establish a secure connection with SEV firmware to negotiate a key used for validating the measurement. 3. mgmt tool requests to start a guest calling virCreateXML(), passing VIR_DOMAIN_START_PAUSED. The xml would include <launch-security type='sev'> <cbitpos> </cbitpos> /* the value is same as what is obtained via virConnectGetDomainCapabilities() <reduced-phys-bits> </reduced-phys-bits> /* the value is same as what is obtained via virConnectGetDomainCapabilities() <dh-cert> .. </dh> /* guest owners diffie-hellman key */ (optional) <session> ..</session> /* guest owners session blob */ (optional) <policy> ..</policy> /* guest policy */ (optional) </launch-security> 4. Libvirt generate the QEMU cli arg to enable the SEV feature, a typical args looks like this: # $QEMU .. -machine memory-encryption=sev0 \ -object sev-guest,id=sev0,dh-cert-file=<file>.... 5. Libvirt generates lifecycle VIR_DOMAIN_EVENT_SUSPENDED_PAUSED event 6. mgmt tool gets the VIR_DOMAIN_EVENT_SUSPENDED_PAUSED and calls virDomainGetLaunchSecretInfo() to retrieve the measurement of encrypted memory. 7. (optional) mgmt tool can provide the measurement value to guest owner, which can validate the measurement and gives GO/NO-GO answer. If mgmt tool gets GO then it resumes the guest otherwise it calls destroy() to kill the guest. 8. mgmt tool resumes the guest TODO: * SEV guest require to use DMA apis for the virtio devices. In order to use the DMA apis the virtio devices must have this tag <driver iommu=on ats=on> It is a bit unclear to me where these changes need to go. Do we need to modify the libvirt to automatically add these when SEV is enabled or we ask mgmt tool to make sure that it creates XML with right tag to enable the DMA APIs for virtio devices. I am looking for some suggestions. Using these patches we have succesfully booted and tested a guest both with and without SEV enabled. SEV Firmware API spec is available at: https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf Changes since v4: * add /dev/sev in shared device list Changes since v3: * rename QEMU_CAPS_SEV -> QEMU_CAPS_SEV_GUEST * update caps_2.12.0.x86_64.replies to include query-sev-capabilities data Changes since v2: * make cbitpos, policy and reduced-phys-bits as unsigned int * update virDomainGetLaunchSecurityInfo to accept virTypedParameterPtr *params instead of virTypedParameterPtr params. Changes since v1: * rename <sev> -> <launch-security> for domain * add more information about policy and other fields in domaincaps.html * split the domain_conf support in two patches * add virDomainGetLaunchInfo() to retrieve the SEV measurement * extend virsh command to show the domain's launch security information * add test cases to validate newly added <launch-security> element * fix issues reported with 'make check' and 'make syntax-check' The complete git tree is available at: https://github.com/codomania/libvirt/tree/v5 Brijesh Singh (9): qemu: provide support to query the SEV capability qemu: introduce SEV feature in hypervisor capabilities conf: introduce launch-security element in domain qemu/cgroup: add /dev/sev in shared devices list qemu: add support to launch SEV guest libvirt: add new public API to get launch security info remote: implement the remote protocol for launch security qemu_driver: add support to launch security info virsh: implement new command for launch security Xiaogang Chen (1): tests: extend tests to include sev specific tag parsing docs/drvqemu.html.in | 1 + docs/formatdomain.html.in | 120 +++++++++++++++++++++ docs/formatdomaincaps.html.in | 40 +++++++ docs/schemas/domaincaps.rng | 20 ++++ docs/schemas/domaincommon.rng | 39 +++++++ include/libvirt/libvirt-domain.h | 17 +++ src/conf/domain_capabilities.c | 20 ++++ src/conf/domain_capabilities.h | 14 +++ src/conf/domain_conf.c | 110 +++++++++++++++++++ src/conf/domain_conf.h | 26 +++++ src/driver-hypervisor.h | 7 ++ src/libvirt-domain.c | 48 +++++++++ src/libvirt_public.syms | 5 + src/qemu/qemu.conf | 2 +- src/qemu/qemu_capabilities.c | 40 +++++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_capspriv.h | 4 + src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_command.c | 35 ++++++ src/qemu/qemu_driver.c | 66 ++++++++++++ src/qemu/qemu_monitor.c | 17 +++ src/qemu/qemu_monitor.h | 6 ++ src/qemu/qemu_monitor_json.c | 105 ++++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 58 ++++++++++ src/remote/remote_daemon_dispatch.c | 47 ++++++++ src/remote/remote_driver.c | 42 +++++++- src/remote/remote_protocol.x | 20 +++- src/remote_protocol-structs | 11 ++ tests/genericxml2xmlindata/sev.xml | 20 ++++ tests/genericxml2xmloutdata/sev.xml | 22 ++++ tests/genericxml2xmltest.c | 2 + .../caps_2.12.0.x86_64.replies | 10 ++ tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 3 +- tests/qemuxml2argvdata/sev.args | 24 +++++ tests/qemuxml2argvdata/sev.xml | 35 ++++++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmloutdata/sev.xml | 39 +++++++ tests/qemuxml2xmltest.c | 2 + tools/virsh-domain.c | 84 +++++++++++++++ 40 files changed, 1166 insertions(+), 5 deletions(-) create mode 100644 tests/genericxml2xmlindata/sev.xml create mode 100644 tests/genericxml2xmloutdata/sev.xml create mode 100644 tests/qemuxml2argvdata/sev.args create mode 100644 tests/qemuxml2argvdata/sev.xml create mode 100644 tests/qemuxml2xmloutdata/sev.xml -- 2.7.4

3 39

[libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c
by Sukrit Bhatnagar 13 Apr '18

13 Apr '18

This patch adds virQEMUBuildBufferEscapeComma to properly escape commas in user provided data fields for qemu command line processing. Signed-off-by: Sukrit Bhatnagar <skrtbhtngr(a)gmail.com> --- Thank you for the helpful feedback and apologies for the delay. Changes in v3: virQEMUBuildBufferEscapeComma was applied to: - src->hosts->socket in qemuBuildNetworkDriveURI - src->path, src->configFile in qemuBuildNetworkDriveStr - disk->blkdeviotune.group_name in qemuBuildDiskThrottling - net->data.socket.address, net->data.socket.localaddr in qemuBuildHostNetStr - dev->data.file.path in qemuBuildChrChardevStr - graphics->data.spice.rendernode in qemuBuildGraphicsSPICECommandLine - smartcard->data.cert.file[i], smartcard->data.cert.database in qemuBuildSmartcardCommandLine Changes in v2: virQEMUBuildBufferEscapeComma was applied to: - info->romfile in qemuBuildRomStr - disk->vendor, disk->product in qemuBuildDriveDevStr - fs->src->path in qemuBuildFSStr - fs->dst in qemuBuildFSDevStr - connect= in qemuBuildHostNetStr - fileval handling in qemuBuildChrChardevStr - TYPE_DEV, TYPE_PIPE handling in qemuBuildChrChardevStr - cfg->vncTLSx509certdir in qemuBuildGraphicsVNCCommandLine - cfg->spiceTLSx509certdir in qemuBuildGraphicsSPICECommandLine - loader->path, loader->nvram usage in qemuBuildDomainLoaderCommandLine Link to v2: https://www.redhat.com/archives/libvir-list/2018-March/msg00965.html When I tried to change src->path in qemuBuildNetworkDriveStr for this portion 961 } else if (src->nhosts == 1) { 962 if (virAsprintf(&ret, "sheepdog:%s:%u:%s", 963 src->hosts->name, src->hosts->port, 964 src->path) < 0) 965 goto cleanup; 966 } else { make check reported the following error. 141) QEMU XML-2-ARGV disk-drive-network-sheepdog ... In '/home/skrtbhtngr/libvirt/tests/qemuxml2argvdata/disk-drive-network-sheepdog.args': Offset 0 Expect [LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none /usr/bin/qemu-system-i686 -name QEMUGuest1 -S -M pc -m 214 -smp 1,sockets=1,cores=1,threads=1 -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 -nographic -nodefaults -chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,server,nowait -mon chardev=charmonitor,id=monitor,mode=readline -no-acpi -boot c -usb -drive file=/dev/HostVG/QEMU,,Guest,,,,1,format=raw,if=none,id=drive-ide0-0-0 -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -drive file=sheepdog:example.org:6000:image,,with,,commas,format=raw,if=none,id=drive-virtio-disk0 -device virtio-blk-pci,bus=pci.0,addr=0x3,drive=drive-virtio-disk0,id=virtio-disk0 ] Actual [LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none /usr/bin/qemu-system-i686 -name QEMUGuest1 -S -M pc -m 214 -smp 1,sockets=1,cores=1,threads=1 -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 -nographic -nodefaults -chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,server,nowait -mon chardev=charmonitor,id=monitor,mode=readline -no-acpi -boot c -usb -drive file=/dev/HostVG/QEMU,,Guest,,,,1,format=raw,if=none,id=drive-ide0-0-0 -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -drive file=sheepdog:example.org:6000:image,,,,with,,,,commas,format=raw,if=none,id=drive-virtio-disk0 -device virtio-blk-pci,bus=pci.0,addr=0x3,drive=drive-virtio-disk0,id=virtio-disk0 ] ... FAILED In disk-drive-network-sheepdog.args: ... -drive file=sheepdog:example.org:6000:image,,with,,commas,format=raw,if=none,\ ... I was not quite sure how to handle this part. Adding virQEMUBuildBufferEscapeComma there is escaping the twin commas in the file name again. I have left that part unchanged. src/qemu/qemu_command.c | 111 +++++++++++++++++++++++++----------------------- 1 file changed, 59 insertions(+), 52 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6f76f18ab..26b36551c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -844,14 +844,18 @@ qemuBuildNetworkDriveURI(virStorageSourcePtr src, qemuDomainSecretInfoPtr secinfo) { virURIPtr uri = NULL; - char *ret = NULL; + char *ret = NULL, *socket = NULL; + virBuffer buf = VIR_BUFFER_INITIALIZER; if (!(uri = qemuBlockStorageSourceGetURI(src))) goto cleanup; - if (src->hosts->socket && - virAsprintf(&uri->query, "socket=%s", src->hosts->socket) < 0) - goto cleanup; + if (src->hosts->socket) { + virQEMUBuildBufferEscapeComma(&buf, src->hosts->socket); + socket = virBufferContentAndReset(&buf); + if (virAsprintf(&uri->query, "socket=%s", socket) < 0) + goto cleanup; + } if (qemuBuildGeneralSecinfoURI(uri, secinfo) < 0) goto cleanup; @@ -860,6 +864,8 @@ qemuBuildNetworkDriveURI(virStorageSourcePtr src, cleanup: virURIFree(uri); + virBufferFreeAndReset(&buf); + return ret; } @@ -868,8 +874,9 @@ static char * qemuBuildNetworkDriveStr(virStorageSourcePtr src, qemuDomainSecretInfoPtr secinfo) { - char *ret = NULL; + char *ret = NULL, *path = NULL, *file = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; + virBuffer bufTemp = VIR_BUFFER_INITIALIZER; size_t i; switch ((virStorageNetProtocol) src->protocol) { @@ -914,8 +921,10 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, goto cleanup; } - if (src->path) - virBufferAsprintf(&buf, ":exportname=%s", src->path); + if (src->path) { + virBufferAddLit(&buf, ":exportname="); + virQEMUBuildBufferEscapeComma(&buf, src->path); + } if (virBufferCheckError(&buf) < 0) goto cleanup; @@ -945,7 +954,9 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, } if (src->nhosts == 0) { - if (virAsprintf(&ret, "sheepdog:%s", src->path) < 0) + virQEMUBuildBufferEscapeComma(&bufTemp, src->path); + path = virBufferContentAndReset(&bufTemp); + if (virAsprintf(&ret, "sheepdog:%s", path) < 0) goto cleanup; } else if (src->nhosts == 1) { if (virAsprintf(&ret, "sheepdog:%s:%u:%s", @@ -967,8 +978,9 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, src->path); goto cleanup; } - - virBufferStrcat(&buf, "rbd:", src->volume, "/", src->path, NULL); + virQEMUBuildBufferEscapeComma(&bufTemp, src->path); + path = virBufferContentAndReset(&bufTemp); + virBufferStrcat(&buf, "rbd:", src->volume, "/", path, NULL); if (src->snapshot) virBufferEscape(&buf, '\\', ":", "@%s", src->snapshot); @@ -994,8 +1006,11 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, } } - if (src->configFile) - virBufferEscape(&buf, '\\', ":", ":conf=%s", src->configFile); + if (src->configFile) { + virQEMUBuildBufferEscapeComma(&bufTemp, src->configFile); + file = virBufferContentAndReset(&bufTemp); + virBufferEscape(&buf, '\\', ":", ":conf=%s", file); + } if (virBufferCheckError(&buf) < 0) goto cleanup; @@ -1022,6 +1037,7 @@ qemuBuildNetworkDriveStr(virStorageSourcePtr src, } cleanup: + virBufferFreeAndReset(&bufTemp); virBufferFreeAndReset(&buf); return ret; @@ -1630,6 +1646,8 @@ qemuBuildDiskThrottling(virDomainDiskDefPtr disk, virBufferAsprintf(buf, ",throttling." _label "=%llu", \ disk->blkdeviotune._field); \ } + virBuffer bufTemp = VIR_BUFFER_INITIALIZER; + char *name = NULL; IOTUNE_ADD(total_bytes_sec, "bps-total"); IOTUNE_ADD(read_bytes_sec, "bps-read"); @@ -1647,8 +1665,9 @@ qemuBuildDiskThrottling(virDomainDiskDefPtr disk, IOTUNE_ADD(size_iops_sec, "iops-size"); if (disk->blkdeviotune.group_name) { - virBufferEscapeString(buf, ",throttling.group=%s", - disk->blkdeviotune.group_name); + virQEMUBuildBufferEscapeComma(&bufTemp, disk->blkdeviotune.group_name); + name = virBufferContentAndReset(&bufTemp); + virBufferEscapeString(buf, ",throttling.group=%s", name); } IOTUNE_ADD(total_bytes_sec_max_length, "bps-total-max-length"); @@ -1657,6 +1676,8 @@ qemuBuildDiskThrottling(virDomainDiskDefPtr disk, IOTUNE_ADD(total_iops_sec_max_length, "iops-total-max-length"); IOTUNE_ADD(read_iops_sec_max_length, "iops-read-max-length"); IOTUNE_ADD(write_iops_sec_max_length, "iops-write-max-length"); + + virBufferFreeAndReset(&bufTemp); #undef IOTUNE_ADD } @@ -3651,27 +3672,25 @@ qemuBuildHostNetStr(virDomainNetDefPtr net, break; case VIR_DOMAIN_NET_TYPE_SERVER: - virBufferAsprintf(&buf, "socket%clisten=%s:%d,", - type_sep, + virBufferAsprintf(&buf, "socket%clisten=", type_sep); + virQEMUBuildBufferEscapeComma(&buf, net->data.socket.address ? net->data.socket.address - : "", - net->data.socket.port); + : ""); + virBufferAsprintf(&buf, ":%d,", net->data.socket.port); break; case VIR_DOMAIN_NET_TYPE_MCAST: - virBufferAsprintf(&buf, "socket%cmcast=%s:%d,", - type_sep, - net->data.socket.address, - net->data.socket.port); + virBufferAsprintf(&buf, "socket%cmcast=", type_sep); + virQEMUBuildBufferEscapeComma(&buf, net->data.socket.address); + virBufferAsprintf(&buf, ":%d,", net->data.socket.port); break; case VIR_DOMAIN_NET_TYPE_UDP: - virBufferAsprintf(&buf, "socket%cudp=%s:%d,localaddr=%s:%d,", - type_sep, - net->data.socket.address, - net->data.socket.port, - net->data.socket.localaddr, - net->data.socket.localport); + virBufferAsprintf(&buf, "socket%cudp=", type_sep); + virQEMUBuildBufferEscapeComma(&buf, net->data.socket.address); + virBufferAsprintf(&buf, ":%d,localaddr=", net->data.socket.port); + virQEMUBuildBufferEscapeComma(&buf, net->data.socket.localaddr); + virBufferAsprintf(&buf, ":%d,", net->data.socket.localport); break; case VIR_DOMAIN_NET_TYPE_USER: @@ -4954,9 +4973,10 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager, bool chardevStdioLogd) { virBuffer buf = VIR_BUFFER_INITIALIZER; + virBuffer bufTemp = VIR_BUFFER_INITIALIZER; bool telnet; char *charAlias = NULL; - char *ret = NULL; + char *ret = NULL, *path = NULL; if (!(charAlias = qemuAliasChardevFromDevAlias(alias))) goto cleanup; @@ -4990,9 +5010,11 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager, _("append not supported in this QEMU binary")); goto cleanup; } + virQEMUBuildBufferEscapeComma(&bufTemp, dev->data.file.path); + path = virBufferContentAndReset(&bufTemp); if (qemuBuildChrChardevFileStr(chardevStdioLogd ? logManager : NULL, cmd, def, &buf, - "path", dev->data.file.path, + "path", path, "append", dev->data.file.append) < 0) goto cleanup; break; @@ -8150,8 +8172,8 @@ qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, _("This QEMU doesn't support spice OpenGL rendernode")); goto error; } - - virBufferAsprintf(&opt, "rendernode=%s,", graphics->data.spice.rendernode); + virBufferAddLit(&opt, "rendernode="); + virQEMUBuildBufferEscapeComma(&opt, graphics->data.spice.rendernode); } } @@ -8771,7 +8793,6 @@ qemuBuildSmartcardCommandLine(virLogManagerPtr logManager, virDomainSmartcardDefPtr smartcard; char *devstr; virBuffer opt = VIR_BUFFER_INITIALIZER; - const char *database; const char *contAlias = NULL; if (!def->nsmartcards) @@ -8814,29 +8835,15 @@ qemuBuildSmartcardCommandLine(virLogManagerPtr logManager, virBufferAddLit(&opt, "ccid-card-emulated,backend=certificates"); for (i = 0; i < VIR_DOMAIN_SMARTCARD_NUM_CERTIFICATES; i++) { - if (strchr(smartcard->data.cert.file[i], ',')) { - virBufferFreeAndReset(&opt); - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("invalid certificate name: %s"), - smartcard->data.cert.file[i]); - return -1; - } - virBufferAsprintf(&opt, ",cert%zu=%s", i + 1, - smartcard->data.cert.file[i]); + virBufferAsprintf(&opt, ",cert%zu=", i + 1); + virQEMUBuildBufferEscapeComma(&opt, smartcard->data.cert.file[i]); } if (smartcard->data.cert.database) { - if (strchr(smartcard->data.cert.database, ',')) { - virBufferFreeAndReset(&opt); - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("invalid database name: %s"), - smartcard->data.cert.database); - return -1; - } - database = smartcard->data.cert.database; + virBufferAddLit(&opt, ",db="); + virQEMUBuildBufferEscapeComma(&opt, smartcard->data.cert.database); } else { - database = VIR_DOMAIN_SMARTCARD_DEFAULT_DATABASE; + virBufferAsprintf(&opt, ",db=%s", VIR_DOMAIN_SMARTCARD_DEFAULT_DATABASE); } - virBufferAsprintf(&opt, ",db=%s", database); break; case VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH: -- 2.16.2

2 3

[libvirt] [PATCHv2] Remove redundant virFileIsExecutable check
by Radostin Stoyanov 13 Apr '18

13 Apr '18

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since commit 9ae992f, virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov <rstoyanov1(a)gmail.com> --- src/bhyve/bhyve_capabilities.c | 4 ---- src/qemu/qemu_capabilities.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 381cc0de3..e13085b1d 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -179,8 +179,6 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) binary = virFindFileInPath("grub-bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; cmd = virCommandNew(binary); virCommandAddArg(cmd, "--help"); @@ -315,8 +313,6 @@ virBhyveProbeCaps(unsigned int *caps) binary = virFindFileInPath("bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; if ((ret = bhyveProbeCapsRTC_UTC(caps, binary))) goto out; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 27180e850..13c6c85d8 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -653,7 +653,7 @@ virQEMUCapsFindBinary(const char *format, ret = virFindFileInPath(binary); VIR_FREE(binary); - if (ret && virFileIsExecutable(ret)) + if (ret) goto out; VIR_FREE(ret); -- 2.14.3

2 1

[libvirt] [dbus PATCH v2 00/22] More APIs for Domain Interface
by Katerina Koukiou 13 Apr '18

13 Apr '18

Changes from v1: Added some more APIs. Katerina Koukiou (22): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Introduce virtDBusDomainMemoryStatTypeToString helper function Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement DetachDevice method for Domain Interface Introduce virtDBusDomainJobTypeToString function Implement GetJobInfo method for Domain interface Implement AbortJob for Domain interface Implement MigrateSetMaxDowntime method for Domain interface Implement MigrateGetMaxDowntime method for Domain Interface Implement ManagedSave method for Domain Interface Implement HasManagedSaveImage method for Domain Interface Implement ManagedSaveRemove method for Domain Interface Implement SetVcpus method for Domain Interface Implement GetMemoryParameters method for Domain Interface Implement GetBlkioParameters method for domain Interface Implement Updated property for Domain Interface Implement MigrateGetMaxSpeed method for Domain Interface Implement MigrateSetMaxSpeed method for Domain Interface Implement SetMemory method for Domain Interface Implement GetSchedulerParameters method for Domain Interface data/org.libvirt.Domain.xml | 111 +++++++- src/domain.c | 599 +++++++++++++++++++++++++++++++++++++++++++- test/test_domain.py | 37 ++- 3 files changed, 742 insertions(+), 5 deletions(-) -- 2.15.0

2 40

[libvirt] [PATCH] Remove redundant virFileIsExecutable check
by Radostin Stoyanov 13 Apr '18

13 Apr '18

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since the commit 9ae992f virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov <rstoyanov1(a)gmail.com> --- src/bhyve/bhyve_capabilities.c | 4 ---- src/qemu/qemu_capabilities.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 381cc0de3..e13085b1d 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -179,8 +179,6 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) binary = virFindFileInPath("grub-bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; cmd = virCommandNew(binary); virCommandAddArg(cmd, "--help"); @@ -315,8 +313,6 @@ virBhyveProbeCaps(unsigned int *caps) binary = virFindFileInPath("bhyve"); if (binary == NULL) goto out; - if (!virFileIsExecutable(binary)) - goto out; if ((ret = bhyveProbeCapsRTC_UTC(caps, binary))) goto out; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 27180e850..5ebc72f6f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -653,7 +653,7 @@ virQEMUCapsFindBinary(const char *format, ret = virFindFileInPath(binary); VIR_FREE(binary); - if (ret && virFileIsExecutable(ret)) + if (ret == NULL) goto out; VIR_FREE(ret); -- 2.14.3

2 2

[libvirt] [PATCH] tests: remove FLAG_JSON from xml2argvtest
by Ján Tomko 12 Apr '18

12 Apr '18

Unused as of commit <1e9a083>. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. tests/qemuxml2argvtest.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 3a328e02a2..472f7b28fe 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -265,8 +265,7 @@ static virStorageDriver fakeStorageDriver = { typedef enum { FLAG_EXPECT_FAILURE = 1 << 0, FLAG_EXPECT_PARSE_ERROR = 1 << 1, - FLAG_JSON = 1 << 2, - FLAG_FIPS = 1 << 3, + FLAG_FIPS = 1 << 2, } virQemuXML2ArgvTestFlags; struct testInfo { @@ -462,9 +461,6 @@ testCompareXMLToArgv(const void *data) virSetConnectSecret(conn); virSetConnectStorage(conn); - if (virQEMUCapsGet(info->qemuCaps, QEMU_CAPS_MONITOR_JSON)) - flags |= FLAG_JSON; - if (virQEMUCapsGet(info->qemuCaps, QEMU_CAPS_ENABLE_FIPS)) flags |= FLAG_FIPS; -- 2.16.1

1 0

[libvirt] [PATCH 0/8] Simplify & standarize more parts of driver URI handling
by Daniel P. Berrangé 12 Apr '18

12 Apr '18

The motivating goal of this series was/is to make it possible to answer whether there is any driver registered to handle a given URI scheme without having to call into the drivers. Ultimately this ended up being a nice simplification and cleanup of driver URI opening code, removing repetative logic from all drivers. Daniel P. Berrangé (8): xen: encourage use of xen:///system URI as preferred format lxc: allow use of lxc:///system URI as preferred format driver: introduce a driver method for probing default URIs driver: allow drivers to indicate if they permit remote connections driver: declare supported URI schemes in virConnectDriver struct driver: ensure NULL URI isn't passed to drivers with whitelisted URIs driver: enforce a non-NULL URI scheme driver: ensure URI path is non-NULL to simplify drivers docs/drvlxc.html.in | 34 ++++++------- docs/drvxen.html.in | 14 +++--- docs/hvsupport.pl | 6 +-- docs/remote.html.in | 6 +-- docs/uri.html.in | 16 +++---- examples/lxcconvert/virt-lxc-convert | 2 +- src/bhyve/bhyve_driver.c | 48 +++++++++---------- src/driver-hypervisor.h | 4 ++ src/driver.h | 8 ++++ src/esx/esx_driver.c | 31 +----------- src/hyperv/hyperv_driver.c | 24 +--------- src/interface/interface_backend_netcf.c | 47 +++++++----------- src/interface/interface_backend_udev.c | 47 +++++++----------- src/libvirt.c | 69 +++++++++++++++++++++++--- src/libxl/libxl_driver.c | 58 +++++++++++----------- src/lxc/lxc_driver.c | 56 ++++++++++------------ src/lxc/lxc_process.c | 4 +- src/network/bridge_driver.c | 47 +++++++----------- src/node_device/node_device_driver.c | 45 +++++++---------- src/node_device/node_device_hal.c | 2 + src/node_device/node_device_udev.c | 2 + src/nwfilter/nwfilter_driver.c | 35 +++++--------- src/openvz/openvz_driver.c | 70 +++++++++++++-------------- src/phyp/phyp_driver.c | 9 +--- src/qemu/qemu_driver.c | 85 +++++++++++++++------------------ src/remote/remote_driver.c | 74 +++++++++++++--------------- src/secret/secret_driver.c | 47 +++++++----------- src/storage/storage_driver.c | 47 +++++++----------- src/test/test_driver.c | 18 ++----- src/uml/uml_driver.c | 71 +++++++++++++-------------- src/vbox/vbox_common.c | 26 ++++------ src/vbox/vbox_driver.c | 18 ++----- src/vmware/vmware_driver.c | 29 ++++------- src/vz/vz_driver.c | 25 ++-------- src/xenapi/xenapi_driver.c | 6 +-- tools/libvirt-guests.sysconf | 2 +- tools/virsh.pod | 4 +- tools/virt-login-shell.c | 2 +- 38 files changed, 489 insertions(+), 649 deletions(-) -- 2.14.3

2 13

[libvirt] CfP for VHPC ‘18 - Papers due May 15 (extended) for the 13th Virtualization in High-Performance Cloud Computing Workshop
by VHPC 18 12 Apr '18

12 Apr '18

*Please accept our apologies if you receive multiple copies of this Call for Papers====================================================================CALL FOR PAPERS 13th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '18)held in conjunction with the International Supercomputing Conference - High Performance,June 24-28, 2018, Frankfurt, Germany.(Springer LNCS Proceedings) ====================================================================Date: June 28, 2018Workshop URL: http://vhpc.org <http://vhpc.org>Paper Submission Deadline: May 15, 2018 (extended)Springer LNCS, rolling abstract submissionAbstract/Paper Submission Link: https://edas.info/newPaper.php?c=24355 <https://edas.info/newPaper.php?c=24355>Special Track: GPU - Accelerator Virtualization Call for PapersVirtualization technologies constitute a key enabling factor for flexible resource managementin modern data centers, and particularly in cloud environments. Cloud providers need tomanage complex infrastructures in a seamless fashion to support the highly dynamic andheterogeneous workloads and hosted applications customers deploy. Similarly, HPCenvironments have been increasingly adopting techniques that enable flexible managementof vast computing and networking resources, close to marginal provisioning cost, which isunprecedented in the history of scientific and commercial computing.Various virtualization technologies contribute to the overall picture in different ways: machinevirtualization, with its capability to enable consolidation of multiple underutilized servers withheterogeneous software and operating systems (OSes), and its capability to live-migrate afully operating virtual machine (VM) with a very short downtime, enables novel and dynamicways to manage physical servers; OS-level virtualization (i.e., containerization), with itscapability to isolate multiple user-space environments and to allow for their coexistencewithin the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; I/O Virtualization allows physical network interfaces to take traffic from multiple VMs or containers; network virtualization, with its capability to create logical network overlays that are independent of theunderlying physical topology is furthermore enabling virtualization of HPC infrastructures. PublicationAccepted papers will be published in a Springer LNCS proceedings volume.Topics of InterestThe VHPC program committee solicits original, high-quality submissions related tovirtualization across the entire software stack with a special focus on the intersection of HPCand the cloud.Major Topics- Virtualization in supercomputing environments, HPC clusters, HPC in the cloud and grids- OS-level virtualization and containers (LXC, Docker, rkt, Singularity, Shifter, i.a.)- Lightweight/specialized operating systems in conjunction with virtual machines- Novel unikernels and use cases for virtualized HPC environments- Performance improvements for or driven by unikernels- Tool support for unikernels: configuration/build environments, debuggers, profilers- Hypervisor extensions to mitigate side-channel attacks ([micro-]architectural timing attacks, privilege escalation)- VM & Container trust and security- Containers inside VMs with hypervisor isolation- GPU virtualization operationalization- Approaches to GPGPU virtualization including API remoting and hypervisor abstraction- Optimizations of virtual machine monitor platforms and hypervisors- Hypervisor support for heterogeneous resources (GPUs, co-processors, FPGAs, etc.)- Virtualization support for emerging memory technologies- Virtualization in enterprise HPC and microvisors- Software defined networks and network virtualization- Management, deployment of virtualized environments and orchestration (Kubernetes i.a.)- Workflow-pipeline container-based composability - Checkpointing facilitation utilizing containers and VMs - Emerging topics including multi-kernel approaches and NUMA in hypervisors- Operating MPI in containers/VMs and Unikernels - Virtualization in data intensive computing (big data) - HPC convergence- Adaptation of HPC technologies in the cloud (high performance networks, RDMA, etc.)- Performance measurement, modelling and monitoring of virtualized/cloud workloads- Latency-and jitter sensitive workloads in virtualized/containerized environments- I/O virtualization (including applications, SR-IOV, i.a.) - Hybrid local facility + cloud compute and based storage systems, cloudbursting- FPGA and many-core accelerator virtualization- Job scheduling/control/policy and container placement in virtualized environments- Cloud reliability, fault-tolerance and high-availability- QoS and SLA in virtualized environments- IaaS platforms, cloud frameworks and APIs- Energy-efficient and power-aware virtualization- Configuration management tools for containers (including in OpenStack, Ansible, i.a.)- ARM-based hypervisors, ARM virtualization extensionsSpecial Track: GPU - Accelerator VirtualizationGPU virtualization technologies, performance and benchmarking, integration withworkflow scheduling systems, integration to cluster managers.GPUs are taking on many HPC workload areas, especially in deep learning withinmachine learning. In addition, a lot of workload is being pushed to elastic environments utilizing various virtualization technologies on different levels like hypervisors (e.g. VMWare, Xen, KVM), kernel (Docker, Kubernetes) or on the resource managerlevel (YARN, Mesos). In this track we invite submissions addressing these problems. Suggested Themes and Topics:Technology - What technologies and best practices exist for GPU - hardware accelerator virtualization and usage of hardware accelerators in virtual environments on the hypervisor, kernel or resource manager levelDevelopers - Real-life experience when addressing HPC/ML/DL problems with GPUs or hardware accelerators in virtual environmentsPerformance - Performance comparisons between different technologies / solutionsThe Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims tobring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchangeof knowledge and experience, enabling research to ultimately provide novelsolutions for virtualized computing systems of tomorrow.The workshop will be one day in length, composed of 20 min paper presentations, eachfollowed by 10 min discussion sections, plus lightning talks that are limited to 5 minutes.Presentations may be accompanied by interactive demonstrations.KeynotesGregory M. Kurtzer, CEO Syslabs Inc. Singularity: Application containers using operating system environment virtualization.Josh Simons, HPC Chief Technologist, VMWare, Inc. Practical Aspects of On-Premises Virtualized High Performance Computing.Important DatesMay 15, 2018 (extended) - Paper submission deadline (Springer LNCS)May 30, 2018 - Acceptance notification June 28, 2018 - Workshop DayJuly 12, 2018 - Camera-ready version dueChairMichael Alexander (chair), Institute of Science and Technology, AustriaAnastassios Nanos (co-chair), OnApp, UKRomeo Kienzler (co-chair), IBM, SwitzerlandProgram committeeStergios Anastasiadis, University of Ioannina, Greece Jakob Blomer, CERN, Europe Eduardo César, Universidad Autonoma de Barcelona, SpainStephen Crago, USC ISI, USATommaso Cucinotta, St. Anna School of Advanced Studies, ItalyChristoffer Dall, Columbia University, USAFrançois Diakhaté, CEA, FrancePatrick Dreher, MIT, USA Kyle Hale, Northwestern University, USA Brian Kocoloski, University of Pittsburgh, USAUday Kurkure, VMware, USAJohn Lange, University of Pittsburgh, USAGiuseppe Lettieri, University of Pisa, ItalyQing Liu, Oak Ridge National Laboratory, USANikos Parlavantzas, IRISA, FranceKevin Pedretti, Sandia National Laboratories, USAAmer Qouneh, Western New England University, USA Carlos Reaño, Technical University of Valencia, SpainBorja Sotomayor, University of Chicago, USA Anata Tiwari, San Diego Supercomputer Center, USAKurt Tutschku, Blekinge Institute of Technology, Sweden Yasuhiro Watashiba, Osaka University, JapanChao-Tung Yang, Tunghai University, Taiwan Andrew Younge, Sandia National Laboratory, USANa Zhang, VMware, USAPaper Submission-PublicationPapers submitted to the workshop will be reviewed by at least twomembers of the program committee and external reviewers. Submissionsshould include abstract, keywords, the e-mail address of thecorresponding author, and must not exceed 10 pages, including tablesand figures at a main font size no smaller than 11 point. Submissionof a paper should be regarded as a commitment that, should the paperbe accepted, at least one of the authors will register and attend theconference to present the work. Accepted papers will be published in aSpringer LNCS volume.The format must be according to the Springer LNCS Style. Initialsubmissions are in PDF; authors of accepted papers will be requestedto provide source files.Format Guidelines:ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip <ftp://ftp.springer.de/pub/tex/latex/llncs/latex2e/llncs2e.zip>Abstract, Paper Submission Link:https://edas.info/newPaper.php?c=24355 <https://edas.info/newPaper.php?c=24355>Lightning Talks Lightning Talks are non-paper track, synoptical in nature and are strictly limited to 5 minutes.They can be used to gain early feedback on ongoing research, for demonstrations, to present research results, early research ideas, perspectives and positions of interest to the community. Submit abstract via the main submission link. General InformationThe workshop is one day in length and will be held in conjunction with the InternationalSupercomputing Conference - High Performance (ISC) 2018, June 24-28, Frankfurt, Germany.*

1 0

[libvirt] [jenkins-ci PATCH] jobs: Unset $CC for Go and MinGW jobs
by Andrea Bolognani 12 Apr '18

12 Apr '18

We want $CC to be set so that ccache is used by default, but some jobs (Go and MinGW) don't like that very much. Later on, we might consider building a link farm so that we can use ccache without having to set $CC; for the time being, work around the issue at the job level. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- jobs/autotools.yaml | 7 +++++++ jobs/go.yaml | 8 ++++++++ 2 files changed, 15 insertions(+) diff --git a/jobs/autotools.yaml b/jobs/autotools.yaml index 98bb1b0..b882803 100644 --- a/jobs/autotools.yaml +++ b/jobs/autotools.yaml @@ -223,6 +223,10 @@ - shell: | {global_env} {local_env} + # The way we perform MinGW builds doesn't play well with the $CC + # variable containing whitespace, so we have to unset it here. + export CC= + mkdir -p build32 cd build32 @@ -235,6 +239,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + mkdir -p build64 cd build64 diff --git a/jobs/go.yaml b/jobs/go.yaml index 29a9f51..2634cb2 100644 --- a/jobs/go.yaml +++ b/jobs/go.yaml @@ -42,6 +42,11 @@ - shell: | {global_env} {local_env} + # go doesn't handle the $CC variable containing whitespace + # correctly, so we have to make sure it's unset when building. + # See https://github.com/golang/go/issues/11685 + export CC= + go build -v publishers: - email: @@ -80,6 +85,9 @@ - shell: | {global_env} {local_env} + # See above + export CC= + go test $TEST_ARGS publishers: - email: -- 2.14.3

2 1

[libvirt] [PATCH] qemu: use target.port for isa-serial
by Thilo Cestonaro 12 Apr '18

12 Apr '18

A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. Signed-off-by: Thilo Cestonaro <thilo.cestonaro(a)ts.fujitsu.com> --- Forgot to sign off! Here with Signed-off-by. src/qemu/qemu_command.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 514c3ab2e..5f770404b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10291,6 +10291,22 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrSerialTargetModelTypeToString(serial->targetModel), serial->info.alias, serial->info.alias); + switch ((virDomainChrSerialTargetModel) serial->targetModel) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL: + if (serial->target.port != -1) + virBufferAsprintf(&cmd, ",index=%d", serial->target.port); + break; + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_NONE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_USB_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PCI_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SPAPR_VTY: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PL011: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPLMCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_LAST: + break; + } + if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) goto error; -- 2.15.1

3 2