- Devel - libvirt List Archives

[libvirt] Shared memoryBacking
by Marc-André Lureau 11 Jul '18

11 Jul '18

Hi, While trying to add vhost-user-gpu support to libvirt, I am wondering how the guest should be configured to enable domain memory sharing. Naively, I thought this alone should work: <memoryBacking> <access mode='shared'/> </memoryBacking> But it doesn't seem to produce memory-backend-file share=on or memory-backend-memfd (the later would be better for my case) Any opinion on how to change that? thanks -- Marc-André Lureau

1 0

[libvirt] [PATCH v2 0/7] Enable vfio-pci 'property' for mediated device
by Erik Skultety 11 Jul '18

11 Jul '18

RFC here: https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html Since v1 [1]: - remodeled egl-headless to be a standalone graphics element instead of a result of some automagic with graphic's <gl> element - pushed the first 5 simple fixes that were RB'd - fixed some nits raised during review [1] https://www.redhat.com/archives/libvir-list/2018-June/msg01740.html Erik Skultety (7): qemu: caps: Introduce a capability for egl-headless conf: Introduce a new graphics display type 'headless' qemu: caps: Add vfio-pci.display capability conf: Introduce virDomainGraphicsDefHasOpenGL helper conf: Introduce new <hostdev> attribute 'display' qemu: command: Enable formatting vfio-pci.display option onto cmdline docs: Update news about the VNC console enablement for mdevs docs/formatdomain.html.in | 52 ++++++++- docs/news.xml | 10 ++ docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 67 ++++++++++- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 1 + src/qemu/qemu_capabilities.c | 8 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 59 +++++++++- src/qemu/qemu_domain.c | 122 ++++++++++++++++++++- src/qemu/qemu_driver.c | 2 + src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_process.c | 4 + src/vmx/vmx.c | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 2 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 + tests/qemuxml2argvdata/graphics-egl-headless.args | 26 +++++ tests/qemuxml2argvdata/graphics-egl-headless.xml | 31 ++++++ .../qemuxml2argvdata/graphics-sdl-egl-headless.xml | 35 ++++++ .../graphics-spice-egl-headless.args | 31 ++++++ .../graphics-spice-egl-headless.xml | 36 ++++++ .../graphics-spice-invalid-egl-headless.xml | 37 +++++++ .../graphics-vnc-egl-headless.args | 28 +++++ .../qemuxml2argvdata/graphics-vnc-egl-headless.xml | 37 +++++++ .../hostdev-mdev-display-missing-graphics.xml | 35 ++++++ .../hostdev-mdev-display-spice-egl-headless.args | 32 ++++++ .../hostdev-mdev-display-spice-egl-headless.xml | 40 +++++++ .../hostdev-mdev-display-spice-opengl.args | 31 ++++++ .../hostdev-mdev-display-spice-opengl.xml | 41 +++++++ .../hostdev-mdev-display-vnc-egl-headless.args | 32 ++++++ .../hostdev-mdev-display-vnc-egl-headless.xml | 40 +++++++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.args | 31 ++++++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.xml | 39 +++++++ tests/qemuxml2argvdata/hostdev-mdev-display.xml | 39 +++++++ tests/qemuxml2argvtest.c | 48 ++++++++ .../graphics-spice-egl-headless.xml | 44 ++++++++ .../graphics-vnc-egl-headless.xml | 42 +++++++ .../hostdev-mdev-display-active.xml | 47 ++++++++ .../hostdev-mdev-display-inactive.xml | 47 ++++++++ tests/qemuxml2xmltest.c | 4 + 50 files changed, 1202 insertions(+), 10 deletions(-) create mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.args create mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/graphics-sdl-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/graphics-spice-invalid-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.args create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-egl-headless.xml create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-egl-headless.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-active.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-inactive.xml -- 2.14.4

2 18

[libvirt] [PATCH v3 0/5] Making libvirt aware of a server need
by Marcos Paulo de Souza 11 Jul '18

11 Jul '18

Hi guys, this is the third version of the patchset to add a new member to virConnectDriver in order to simplfy the check for a server. Now, libvirt does the work inside virConnectOpenInternal after getting the correct driver from the URI. v2: https://www.redhat.com/archives/libvir-list/2018-July/msg00501.html v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00393.html Changes from v2: * patch 2: Move check for remoteOnly member just before calling connectOpen * (only patch 2 changed in v2) Changes from v1: * Adapted the code following ideas from Matthias Bolte Marcos Paulo de Souza (5): driver.h: Add remoteOnly member to virConnectDriver struct libvirt.c: Return error when remoteOnly is set but server is empty esx_driver: Set remoteOnly member of virConnectDriver hyperv_driver: Set remoteOnly member of virConnectDriver phyp_driver: Set remoteOnly member of virConnectDriver src/driver.h | 2 ++ src/esx/esx_driver.c | 8 +------- src/hyperv/hyperv_driver.c | 8 +------- src/libvirt.c | 7 +++++++ src/phyp/phyp_driver.c | 7 +------ 5 files changed, 12 insertions(+), 20 deletions(-) -- 2.17.1

2 7

[libvirt] [PATCH python] Implement virDomainGetStateParams API
by Bjoern Walk 11 Jul '18

11 Jul '18

From: Marc Hartmayer <mhartmay(a)linux.ibm.com> This patch adds the Python binding for the virDomainGetStateParams API. The Python side can be generated automatically, the C side not. Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com> --- generator.py | 1 + libvirt-override-api.xml | 6 ++++++ libvirt-override.c | 38 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/generator.py b/generator.py index bd7ff112..1f6ffb9a 100755 --- a/generator.py +++ b/generator.py @@ -495,6 +495,7 @@ skip_impl = ( 'virConnectBaselineHypervisorCPU', 'virDomainGetLaunchSecurityInfo', 'virNodeGetSEVInfo', + 'virDomainGetStateParams', ) lxc_skip_impl = ( diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 4e8d6c03..c49e244c 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -746,5 +746,11 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virDomainGetStateParams' file='python'> + <info>Extract domain state. Each state is accompanied by a reason (if known) and optional detailed information.</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='flags' type='unsigned int' info='extra flags; not used yet, so callers should always pass 0'/> + <return type='char *' info="dictionary of state data"/> + </function> </symbols> </api> diff --git a/libvirt-override.c b/libvirt-override.c index e74c7dda..355b9fd5 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -9881,6 +9881,41 @@ libvirt_virNodeGetSEVInfo(PyObject *self ATTRIBUTE_UNUSED, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(4, 6, 0) +static PyObject * +libvirt_virDomainGetStateParams(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) +{ + PyObject *pyobj_domain; + virDomainPtr domain; + virTypedParameterPtr params = NULL; + int nparams = 0; + unsigned int flags; + int i_retval; + PyObject *ret = NULL; + + if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetStateParams", + &pyobj_domain, &flags)) + return NULL; + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virDomainGetStateParams(domain, &params, &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (i_retval < 0) { + ret = VIR_PY_NONE; + goto cleanup; + } + + ret = getPyVirTypedParameter(params, nparams); +cleanup: + virTypedParamsFree(params, nparams); + return ret; +} +#endif /* LIBVIR_CHECK_VERSION(4, 6, 0) */ + + /************************************************************************ * * * The registration stuff * @@ -10124,6 +10159,9 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetLaunchSecurityInfo", libvirt_virDomainGetLaunchSecurityInfo, METH_VARARGS, NULL}, {(char *) "virNodeGetSEVInfo", libvirt_virNodeGetSEVInfo, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(4, 6, 0) + {(char *) "virDomainGetStateParams", libvirt_virDomainGetStateParams, METH_VARARGS, NULL}, +#endif /* LIBVIR_CHECK_VERSION(4, 6, 0) */ {NULL, NULL, 0, NULL} }; -- 2.17.0

1 0

[libvirt] [PATCH] storage: prefer using newDef to save configfile
by Shichangkuo 11 Jul '18

11 Jul '18

When re-defining an active storage pool, the configfile has not changed. This issue was introduced by bfcd8fc9, storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using newDef to save configfile. Signed-off-by: Changkuo Shi <shi.changkuo(a)h3c.com> --- src/storage/storage_driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index b0de96d..fab3c5b 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -844,13 +844,14 @@ storagePoolDefineXML(virConnectPtr conn, if (!(obj = virStoragePoolObjAssignDef(driver->pools, newDef))) goto cleanup; - newDef = NULL; + newDef = virStoragePoolObjGetNewDef(obj); def = virStoragePoolObjGetDef(obj); - if (virStoragePoolObjSaveDef(driver, obj, def) < 0) { + if (virStoragePoolObjSaveDef(driver, obj, newDef ? newDef : def) < 0) { virStoragePoolObjRemove(driver->pools, obj); virObjectUnref(obj); obj = NULL; + newDef = NULL; goto cleanup; } @@ -860,6 +861,7 @@ storagePoolDefineXML(virConnectPtr conn, VIR_INFO("Defining storage pool '%s'", def->name); pool = virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); + newDef = NULL; cleanup: if (event) -- 1.7.9.5 ------------------------------------------------------------------------------------------------------------------------------------- 本邮件及其附件含有新华三集团的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from New H3C, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

2 3

[libvirt] [PATCH 0/2] qemu: Support vhost-vsock-ccw
by Boris Fiuczynski 11 Jul '18

11 Jul '18

Support the vhost-vsock-ccw device on S390. Boris Fiuczynski (2): qemu: Add ccw support for vhost-vsock news: Update for vhost-vsock-ccw support docs/news.xml | 8 +++++ src/qemu/qemu_command.c | 15 +++++++-- src/qemu/qemu_domain_address.c | 7 +++- .../vhost-vsock-ccw-auto.args | 27 ++++++++++++++++ .../qemuxml2argvdata/vhost-vsock-ccw-auto.xml | 25 +++++++++++++++ tests/qemuxml2argvdata/vhost-vsock-ccw.args | 27 ++++++++++++++++ tests/qemuxml2argvdata/vhost-vsock-ccw.xml | 32 +++++++++++++++++++ tests/qemuxml2argvtest.c | 4 +++ .../vhost-vsock-ccw-auto.xml | 32 +++++++++++++++++++ tests/qemuxml2xmloutdata/vhost-vsock-ccw.xml | 1 + tests/qemuxml2xmltest.c | 5 +++ 11 files changed, 180 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw-auto.args create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw-auto.xml create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw.args create mode 100644 tests/qemuxml2argvdata/vhost-vsock-ccw.xml create mode 100644 tests/qemuxml2xmloutdata/vhost-vsock-ccw-auto.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-vsock-ccw.xml -- 2.17.0

2 4

[libvirt] [PATCH v2 0/2] Change virFileIsCDROM to check cdrom status
by Han Han 11 Jul '18

11 Jul '18

v1 link: https://www.redhat.com/archives/libvir-list/2018-July/msg00103.html Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to store cdrom status. In libvirt, it gives general Input/Output error when reading a not ready cdrom backend vol. This error should be replaced with warning just like the warning of lacking backing file. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/storage/storage_util.c | 15 ++++++++++++- src/util/virfile.c | 44 ++++++++++++++++++++++++++++++++------ src/util/virfile.h | 11 +++++++++- 5 files changed, 65 insertions(+), 11 deletions(-) -- 2.17.1

2 5

[libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status
by Han Han 11 Jul '18

11 Jul '18

Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to store cdrom status. In libvirt, it gives general Input/Output error when reading a not ready cdrom backend vol. This error should be replaced with warning just like the warning of lacking backing file. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/storage/storage_util.c | 15 ++++++++++++- src/util/virfile.c | 44 ++++++++++++++++++++++++++++++++------ src/util/virfile.h | 11 +++++++++- 5 files changed, 65 insertions(+), 11 deletions(-) -- 2.17.1

1 3

[libvirt] [dbus PATCH v2] gitignore: add tests/.pytest_cache
by Anya Harter 10 Jul '18

10 Jul '18

Signed-off-by: Anya Harter <aharter(a)redhat.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index ca9e4e1..b2021d4 100644 --- a/.gitignore +++ b/.gitignore @@ -44,3 +44,4 @@ vgcore.* /src/org.libvirt.service /tests/test_util +**/.pytest_cache -- 2.17.1

2 3

[libvirt] [PATCH 0/2] Add function to check cdrom status
by Han Han 10 Jul '18

10 Jul '18

In libvirt, it gives general Input/Output error when reading a not ready cdrom. This error could be more detailed on cdrom, such as drive not ready, no disc, trey open, no information. These patches provide private API virFileCdromStatus to check cdrom storage backend status and improve error handling of virStorageBackendVolOpen on cdrom. Han Han (2): util: Introduce virFileCdromStatus storage: Improve error handling on cdrom backend src/libvirt_private.syms | 1 + src/storage/storage_util.c | 38 ++++++++++++++++++++++++++++ src/util/virfile.c | 52 ++++++++++++++++++++++++++++++++++++++ src/util/virfile.h | 10 ++++++++ 4 files changed, 101 insertions(+) -- 2.17.1

3 10

[libvirt] auto generated golang dbus binding for libvirt
by Vasiliy Tolstov 10 Jul '18

10 Jul '18

Hi. Thanks for dbus based interface to libvirt. Now i'm able to automatic generate bindings for go https://godoc.org/sdstack.com/sdstack/go-libvirt Code generator is ugly (gen.go and template.tpl) but package already able to do basic operations. Thanks again for you work. -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 2

[libvirt] [PATCH 0/2] qemu: migration: Fix crash when adding TLS objects
by Peter Krempa 10 Jul '18

10 Jul '18

Thankfully no other caller of qemuMonitorAddObject uses double pointers so the checks are correct. Peter Krempa (2): qemu: hotplug: Do not try to add secret object for TLS if it does not exist qemu: monitor: Make qemuMonitorAddObject more robust against programming errors src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_monitor.c | 22 ++++++++++++++++------ src/qemu/qemu_monitor.h | 3 ++- 3 files changed, 19 insertions(+), 8 deletions(-) -- 2.16.2

2 5

[libvirt] [PATCH python] spec: Remove Group: and %defattr
by Cole Robinson 10 Jul '18

10 Jul '18

These are only needed for RHEL5 builds, which are no longer supported https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org… https://fedoraproject.org/wiki/RPMGroups Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- libvirt-python.spec.in | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 9697ea8..f3940cc 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -38,7 +38,6 @@ Release: 1%{?dist}%{?extra_release} Source0: http://libvirt.org/sources/python/%{name}-%{version}.tar.gz Url: http://libvirt.org License: LGPLv2+ -Group: Development/Libraries BuildRequires: libvirt-devel == %{version} %if %{with_python2} %if %{py2_versioned_deps} @@ -77,7 +76,6 @@ of recent versions of Linux (and other OSes). Summary: The libvirt virtualization API python2 binding Url: http://libvirt.org License: LGPLv2+ -Group: Development/Libraries %{?python_provide:%python_provide python2-libvirt} Provides: libvirt-python = %{version}-%{release} Obsoletes: libvirt-python <= 3.6.0-1%{?dist} @@ -94,7 +92,6 @@ of recent versions of Linux (and other OSes). Summary: The libvirt virtualization API python3 binding Url: http://libvirt.org License: LGPLv2+ -Group: Development/Libraries %{?python_provide:%python_provide python3-libvirt} Provides: libvirt-python3 = %{version}-%{release} Obsoletes: libvirt-python3 <= 3.6.0-1%{?dist} @@ -145,7 +142,6 @@ CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build %if %{with_python2} %files -n python2-libvirt -%defattr(-,root,root) %doc ChangeLog AUTHORS NEWS README COPYING COPYING.LESSER examples/ %{python_sitearch}/libvirt.py* %{python_sitearch}/libvirt_qemu.py* @@ -156,7 +152,6 @@ CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build %if %{with_python3} %files -n python3-libvirt -%defattr(-,root,root) %doc ChangeLog AUTHORS NEWS README COPYING COPYING.LESSER examples/ %{python3_sitearch}/libvirt.py* %{python3_sitearch}/libvirtaio.py* -- 2.17.1

2 1

[libvirt] [PATCH] conf: virDomainDefValidateInternal prohibit some characters in shmem name
by Simon Kobyda 10 Jul '18

10 Jul '18

XML shmem name will not include characters '/', '.' or '..', as shmem name is used in a path https://bugzilla.redhat.com/show_bug.cgi?id=1192400 --- src/conf/domain_conf.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7ab2953d83..3f580525bb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6107,6 +6107,8 @@ virDomainDefLifecycleActionValidate(const virDomainDef *def) static int virDomainDefValidateInternal(const virDomainDef *def) { + size_t i; + if (virDomainDefCheckDuplicateDiskInfo(def) < 0) return -1; @@ -6136,6 +6138,17 @@ virDomainDefValidateInternal(const virDomainDef *def) return -1; } + for (i = 0; i < def->nshmems; i++) { + if (strchr(def->shmems[i]->name, '/')) + return -1; + + if (strchr(def->shmems[i]->name, '.')) + return -1; + + if (strstr(def->shmems[i]->name, "..")) + return -1; + } + if (virDomainDefLifecycleActionValidate(def) < 0) return -1; -- 2.17.1

4 3

[libvirt] [PATCH 0/4] qemu: move rerror/werror to -device
by Peter Krempa 10 Jul '18

10 Jul '18

This series requires the qemu 3.0.0 capabilities that I've sent with https://www.redhat.com/archives/libvir-list/2018-July/msg00454.html Peter Krempa (4): tests: qemuxml2argv: Unify all tests for disk error policy tests: qemuxml2argv: Add CAPS_LATEST version for the disk error policy test qemu: capabilities: Add capability for werror/rerror for 'usb-device' frontend qemu: command: Format rerror/werror with -device instead of -drive src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 +++- tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + .../disk-drive-error-policy-enospace.args | 30 ---------------- .../disk-drive-error-policy-enospace.xml | 37 ------------------- .../disk-drive-error-policy-stop.args | 30 ---------------- .../disk-drive-error-policy-stop.xml | 37 ------------------- ...t-rignore.args => disk-drive-error-policy.args} | 9 +++-- .../disk-drive-error-policy.x86_64-latest.args | 41 ++++++++++++++++++++++ ...ort-rignore.xml => disk-drive-error-policy.xml} | 13 ++++--- tests/qemuxml2argvtest.c | 5 ++- .../disk-drive-error-policy-enospace.xml | 41 ---------------------- .../disk-drive-error-policy-stop.xml | 41 ---------------------- ...ort-rignore.xml => disk-drive-error-policy.xml} | 13 ++++--- tests/qemuxml2xmltest.c | 4 +-- 16 files changed, 77 insertions(+), 234 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-drive-error-policy-enospace.args delete mode 100644 tests/qemuxml2argvdata/disk-drive-error-policy-enospace.xml delete mode 100644 tests/qemuxml2argvdata/disk-drive-error-policy-stop.args delete mode 100644 tests/qemuxml2argvdata/disk-drive-error-policy-stop.xml rename tests/qemuxml2argvdata/{disk-drive-error-policy-wreport-rignore.args => disk-drive-error-policy.args} (73%) create mode 100644 tests/qemuxml2argvdata/disk-drive-error-policy.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-drive-error-policy-wreport-rignore.xml => disk-drive-error-policy.xml} (75%) delete mode 100644 tests/qemuxml2xmloutdata/disk-drive-error-policy-enospace.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-drive-error-policy-stop.xml rename tests/qemuxml2xmloutdata/{disk-drive-error-policy-wreport-rignore.xml => disk-drive-error-policy.xml} (78%) -- 2.16.2

2 6

[libvirt] [PATCH v2 0/6] Couple of PR fixes and improvements
by Michal Privoznik 10 Jul '18

10 Jul '18

v2 of: https://www.redhat.com/archives/libvir-list/2018-July/msg00243.html Diff to v1: - Dropped 4/7 from the original series, as it's no longer needed - Reworked alias matching, instead of iterating through all disks trying to find a matching alias, retval of qemuDomainGetManagedPRAlias() is compared directly - The PR_MANAGER_STATUS_CHANGED event handling is done from worker pool rather than event loop. Patches 1 and 3 were ACKed already. Michal Privoznik (6): qemuProcessStartPRDaemonHook: Try to set NS iff domain was started with one qemuDomainValidateStorageSource: Relax PR validation virStoragePRDefFormat: Suppress path formatting for migratable XML qemu: Wire up PR_MANAGER_STATUS_CHANGED event qemu_monitor: Introduce qemuMonitorJSONGetPRManagerInfo qemu: Fetch pr-helper process info on reconnect src/conf/domain_conf.c | 3 +- src/qemu/qemu_domain.c | 20 +++---- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 17 ++++++ src/qemu/qemu_monitor.c | 40 ++++++++++++++ src/qemu/qemu_monitor.h | 20 +++++++ src/qemu/qemu_monitor_json.c | 106 +++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 4 ++ src/qemu/qemu_process.c | 128 +++++++++++++++++++++++++++++++++++++++++-- src/util/virstoragefile.c | 6 +- src/util/virstoragefile.h | 3 +- 11 files changed, 326 insertions(+), 22 deletions(-) -- 2.16.4

2 12

[libvirt] [PATCH 0/9] qemu: Disk-related cleanups a refactors
by Peter Krempa 10 Jul '18

10 Jul '18

Collection of patches which make sense without the rest of the -blockdev series. Peter Krempa (9): qemu: domain: Remove code assuming disk format probing qemu: domain: Reject copy_on_read for read-only disks tests: Remove disk from 'serial-unix-chardev' test qemu: command: Rename and export qemuDiskBusNeedsDeviceArg qemu: hotplug: Add warning regarding SD hotplug qemu: command: Split out formatting of disk source commandline qemu: command: Don't generate disk drive alias manually for floppies qemu: command: Refactor floppy controller command formatting qemu: command: Rename qemuBuildDriveDevStr to qemuBuildDiskDeviceStr src/qemu/qemu_command.c | 139 ++++++++++++--------- src/qemu/qemu_command.h | 11 +- src/qemu/qemu_domain.c | 25 ++-- src/qemu/qemu_hotplug.c | 5 +- tests/qemuxml2argvdata/serial-unix-chardev.args | 2 - .../serial-unix-chardev.x86_64-latest.args | 2 - tests/qemuxml2argvdata/serial-unix-chardev.xml | 5 - 7 files changed, 104 insertions(+), 85 deletions(-) -- 2.16.2

2 19

[libvirt] [dbus PATCH 00/15] Implement Interface APIs
by Anya Harter 10 Jul '18

10 Jul '18

https://libvirt.org/html/libvirt-libvirt-interface.html The following functions have been implemented: - virConnectListAllInterfaces (connect method) - virInterfaceChangeBegin (connect method) - virInterfaceChangeCommit (connect method) - virInterfaceChangeRollback (connect method) - virInterfaceCreate (interface method) - virInterfaceDefineXML (connect method) - virInterfaceDestroy (interface method) - virInterfaceGetMACString (property) - virInterfaceGetName (property) - virInterfaceGetXMLDesc (interface method) - virInterfaceIsActive (property) - virInterfaceLookupByMACString (connect method) - virInterfaceLookupByName (connect method) - virInterfaceUndefine (interface method) Anya Harter (15): Introduce Interface Interface Implement Name property for Interface Interface Implement MACString property for Interface Interface Implement Active property for Interface Interface Implement ListInterfaces method for Connect Interface Implement InterfaceDefineXML method for Connect Interface Implement InterfaceChangeBegin method for Connect Interface Implement InterfaceChangeCommit method for Connect Interface Implement InterfaceChangeRollback method for Connect Interface Implement InterfaceLookupByName method for Connect Interface Implement InterfaceLookupByMACString method for Connect Interface Implement Create method for Interface Interface Implement Destroy method for Interface Interface Implement Undefine method for Interface Interface Implement GetXMLDesc method for Interface Interface data/Makefile.am | 1 + data/org.libvirt.Connect.xml | 40 ++++++ data/org.libvirt.Interface.xml | 41 ++++++ src/Makefile.am | 2 + src/connect.c | 198 ++++++++++++++++++++++++++ src/connect.h | 1 + src/interface.c | 249 +++++++++++++++++++++++++++++++++ src/interface.h | 9 ++ src/util.c | 35 +++++ src/util.h | 15 ++ 10 files changed, 591 insertions(+) create mode 100644 data/org.libvirt.Interface.xml create mode 100644 src/interface.c create mode 100644 src/interface.h -- 2.17.1

2 22

[libvirt] [PATCH] storage_util: Prefer generic FICLONE over btrfs/xfs defines
by Michal Privoznik 10 Jul '18

10 Jul '18

After my change to the original patch that resulted in commit 8ed874b39b3 it was brought to my attention that all three defines are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE. Therefore we should prefer generic FICLONE over 'specific' defines for btrfs/xfs. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/storage/storage_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index da99043e0a..715d5c2f88 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -46,14 +46,14 @@ # include <selinux/selinux.h> #endif -#if HAVE_LINUX_BTRFS_H +#ifdef FICLONE +# define REFLINK_IOC_CLONE FICLONE +#elif HAVE_LINUX_BTRFS_H # include <linux/btrfs.h> # define REFLINK_IOC_CLONE BTRFS_IOC_CLONE #elif HAVE_XFS_XFS_H # include <xfs/xfs.h> # define REFLINK_IOC_CLONE XFS_IOC_CLONE -#elif defined(FICLONE) -# define REFLINK_IOC_CLONE FICLONE #endif #include "datatypes.h" -- 2.16.4

2 1

[libvirt] [dbus PATCH] test_connect: fix methods to follow naming conventions
by Anya Harter 10 Jul '18

10 Jul '18

Signed-off-by: Anya Harter <aharter(a)redhat.com> --- tests/test_connect.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_connect.py b/tests/test_connect.py index 7084397..2299b8a 100755 --- a/tests/test_connect.py +++ b/tests/test_connect.py @@ -22,7 +22,7 @@ class TestConnect(libvirttest.BaseTestClass): self.main_loop() - def test_comnect_domain_define_xml(self): + def test_connect_domain_define_xml(self): def domain_defined(path, event, detail): if event != libvirttest.DomainEvent.DEFINED: return @@ -84,7 +84,7 @@ class TestConnect(libvirttest.BaseTestClass): sysinfo = self.connect.GetSysinfo(0) assert isinstance(sysinfo, dbus.String) - def test_list_networks(self): + def test_connect_list_networks(self): networks = self.connect.ListNetworks(0) assert isinstance(networks, dbus.Array) assert len(networks) == 1 -- 2.17.1

2 1

[libvirt] [dbus PATCH] connect: fix gchar declaration in connect.h
by Anya Harter 10 Jul '18

10 Jul '18

so that gchar *nodeDevPath; line appears in alphabetical order with the rest of the lines Signed-off-by: Anya Harter <aharter(a)redhat.com> --- src/connect.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connect.h b/src/connect.h index b81b6a8..0b9ae10 100644 --- a/src/connect.h +++ b/src/connect.h @@ -12,9 +12,9 @@ struct virtDBusConnect { GDBusConnection *bus; const gchar *uri; const gchar *connectPath; - gchar *nodeDevPath; gchar *domainPath; gchar *networkPath; + gchar *nodeDevPath; gchar *nwfilterPath; gchar *secretPath; gchar *storagePoolPath; -- 2.17.1

2 1

[libvirt] [PATCH] news: Update for 4.5.0 release
by Andrea Bolognani 10 Jul '18

10 Jul '18

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I've CC'd all those who introduced the changes mentioned below, both to give them a chance to point out any mistake I might have made and to possibly annoy them into updating the release notes themselves next time :) docs/news.xml | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 468d34093a..65c23e51b6 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -61,6 +61,16 @@ Support specifying extended TSEG size for SMM in QEMU. </description> </change> + <change> + <summary> + qemu: Add support for SEV guests + </summary> + <description> + SEV (Secure Encrypted Virtualization) is a feature available on AMD + CPUs that encrypts the guest memory and makes it inaccessible even + to the host OS. + </description> + </change> </section> <section title="Removed features"> <change> @@ -76,6 +86,24 @@ secret objects, but that support was never added to libvirt. </description> </change> + <change> + <summary> + Make GnuTLS mandatory + </summary> + <description> + Building without GnuTLS is no longer possible. + </description> + </change> + <change> + <summary> + qemu: Remove allow_disk_format_probing configuration option + </summary> + <description> + The option represented a security risk when used with malicious + disk images, so users were recommended against enabling it; with + this release, it's been removed altogether. + </description> + </change> </section> <section title="Improvements"> <change> @@ -130,6 +158,41 @@ or virStorageVolCreateXMLFrom. </description> </change> + <change> + <summary> + qemu: Add support for vsock hot (un)plug and cold (un)plug + </summary> + </change> + <change> + <summary> + qemu: Add support for NBD over TLS + </summary> + <description> + Securely accessing NBD volumes no longer requires tunnelling over + SSH or another secure protocol: the native TLS support can now be + used instead. + </description> + </change> + <change> + <summary> + qemu: Implement FD passing for Unix sockets + </summary> + <description> + Instead of having QEMU open the socket and then connecting to it, + which is inherently racy, starting with QEMU 2.12 we can open the + socket ourselves and pass it to QEMU, avoiding race conditions. + </description> + </change> + <change> + <summary> + virsh: Introduce --nowait option for domstat command + </summary> + <description> + When this option is specified, virsh will try to fetch the guest + stats but abort instead of stalling if they can't be retrieved right + away. + </description> + </change> </section> <section title="Bug fixes"> <change> @@ -143,6 +206,26 @@ us getting to the worker pool initialization. </description> </change> + <change> + <summary> + qemu: Fix domain resume after failed migration + </summary> + <description> + Recent versions of QEMU activate block devices before the guest CPU + has been started, which makes it impossible to roll back a failed + migration. Use the <code>late-block-activate</code> migration + capability if supported to avoid the issue. + </description> + </change> + <change> + <summary> + vmx: Permit guests to have an odd number of vCPUs + </summary> + <description> + This was forbidden in the past, but current versions of ESX can + deal with a guest configured as such. + </description> + </change> </section> </release> <release version="v4.4.0" date="2018-06-04"> -- 2.17.1

5 8

[libvirt] [PATCH 0/5] Making libvirt aware of a server need
by Marcos Paulo de Souza 10 Jul '18

10 Jul '18

Hi guys, this is basically a second version of [1], but I rewrote the patch following Matthias ideas [2]. It really seems a cleaner change, but, feel free to suggest any other change that could make the code better. I did a lot of tests using virsh tool, so when using the ESX driver without a proper server, it returns a error. I could not test hyperv and phyp. Thanks, [1]: https://www.redhat.com/archives/libvir-list/2018-July/msg00393.html [2]: https://www.redhat.com/archives/libvir-list/2018-July/msg00400.html Marcos Paulo de Souza (5): driver.h: Add remoteOnly member to virConnectDriver struct libvirt.c: Return error when remoteOnly is set but server is empty esx_driver: Set remoteOnly member of virConnectDriver hyperv_driver: Set remoteOnly member of virConnectDriver phyp_driver: Set remoteOnly member of virConnectDriver src/driver.h | 2 ++ src/esx/esx_driver.c | 8 +------- src/hyperv/hyperv_driver.c | 8 +------- src/libvirt.c | 5 +++++ src/phyp/phyp_driver.c | 7 +------ 5 files changed, 10 insertions(+), 20 deletions(-) -- 2.17.1

1 6

[libvirt] [PATCH 0/5] Introduce new video model type 'none'
by Erik Skultety 09 Jul '18

09 Jul '18

Historically, we've always been adding a default video device onto the cmdline whenever a graphical framebuffer was requested but a video device was missing. With the appearance of mdev vgpus, having an emulated video device is suboptimal, especially with spice where the streaming client will by default open multiple windows, one for each video device (or 'head' in this case). Therefore, we should have a mechanism to disable the 'default video device addition' and this series does that by introducing a new video model 'none'. This can be applied and tried independently, however, it truly only makes sense on top of [1]. [1] https://www.redhat.com/archives/libvir-list/2018-June/msg01740.html Erik Skultety (5): qemu: address: Handle all the video devices within a single loop conf: Introduce virDomainVideoDefClear helper conf: Introduce virDomainDefPostParseVideo helper qemu: validate: Enforce compile time switch type checking for videos conf: Introduce new video type 'none' docs/formatdomain.html.in | 10 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 86 +++++++++++++++++----- src/conf/domain_conf.h | 4 +- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 13 +++- src/qemu/qemu_domain.c | 6 +- src/qemu/qemu_domain_address.c | 20 +++-- tests/domaincapsschemadata/full.xml | 1 + .../video-invalid-multiple-devices.xml | 33 +++++++++ tests/qemuxml2argvdata/video-none-device.args | 27 +++++++ tests/qemuxml2argvdata/video-none-device.xml | 39 ++++++++++ tests/qemuxml2argvtest.c | 4 +- tests/qemuxml2xmloutdata/video-none-device.xml | 42 +++++++++++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 255 insertions(+), 33 deletions(-) create mode 100644 tests/qemuxml2argvdata/video-invalid-multiple-devices.xml create mode 100644 tests/qemuxml2argvdata/video-none-device.args create mode 100644 tests/qemuxml2argvdata/video-none-device.xml create mode 100644 tests/qemuxml2xmloutdata/video-none-device.xml -- 2.14.4

2 11

[libvirt] [PATCH v1 00/11] Enable vfio-pci 'property' for mediated device
by Erik Skultety 09 Jul '18

09 Jul '18

See the RFC here: https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html Since RFC: - split graphics 'gl' to a standalone structure since it's now SPICE, SDL, *and* VNC that will support it - egl-headless support for VNC, since VNC doesn't support OpenGL natively like SPICE does - added a new attribute 'native' for spice which will instruct libvirt to use '-display egl-headless' instead of libvirt trying to figure this on out by itself, since egl-headless might have other uses besides mdev with VNC - dropped formatting of the 'display' attribute to the domain XML if it had the default value, so it will only be formatted if user explicitly set it (previously patch 6) - minor adjustments like splitting the second patch into 2 (now 2 and 3) - more cleanup Erik Skultety (11): conf: Remove a redundant model/address-type check in mdev post parse qemu: command: Move graphics iteration to its own function qemu: command: Add virReportEnumRangeError to BuildHostdevCommandline conf: Replace error label with cleanup in virDomainGraphicsDefParseVNCXML qemu: command: Fix building of the SDL display command line conf: Make graphics's GL a standalone structure conf: Allow usage of the <gl> element with VNC graphics conf: Introduce new <gl> attribute 'native' for SPICE qemu: caps: Add vfio-pci.display capability conf: Introduce new <hostdev> attribute 'display' qemu: command: Enable formatting vfio-pci.display option onto cmdline docs/formatdomain.html.in | 33 ++- docs/schemas/domaincommon.rng | 28 ++- src/conf/domain_conf.c | 230 ++++++++++++++------- src/conf/domain_conf.h | 14 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 10 +- src/qemu/qemu_command.c | 189 +++++++++++------ src/qemu/qemu_domain.c | 79 ++++++- src/security/security_dac.c | 7 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../qemuxml2argvdata/graphics-sdl-fullscreen.args | 2 +- tests/qemuxml2argvdata/graphics-sdl.args | 2 +- .../qemuxml2argvdata/graphics-spice-gl-native.args | 26 +++ .../qemuxml2argvdata/graphics-spice-gl-native.xml | 25 +++ .../graphics-spice-gl-non-native.args | 27 +++ .../graphics-spice-gl-non-native.xml | 24 +++ tests/qemuxml2argvdata/graphics-vnc-gl-invalid.xml | 37 ++++ tests/qemuxml2argvdata/graphics-vnc-gl.args | 28 +++ tests/qemuxml2argvdata/graphics-vnc-gl.xml | 37 ++++ .../hostdev-mdev-display-missing-graphics.xml | 35 ++++ .../hostdev-mdev-display-spice-egl-headless.args | 32 +++ .../hostdev-mdev-display-spice-egl-headless.xml | 41 ++++ .../hostdev-mdev-display-spice-opengl.args | 31 +++ .../hostdev-mdev-display-spice-opengl.xml | 41 ++++ .../hostdev-mdev-display-vnc-egl-headless.args | 32 +++ .../hostdev-mdev-display-vnc-egl-headless.xml | 41 ++++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.args | 31 +++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.xml | 39 ++++ tests/qemuxml2argvdata/hostdev-mdev-display.xml | 39 ++++ .../qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 2 +- tests/qemuxml2argvtest.c | 38 ++++ .../hostdev-mdev-display-active.xml | 47 +++++ .../hostdev-mdev-display-inactive.xml | 47 +++++ .../video-virtio-gpu-spice-gl.xml | 2 +- tests/qemuxml2xmltest.c | 2 + 40 files changed, 1143 insertions(+), 163 deletions(-) create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-native.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-native.xml create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-non-native.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-gl-non-native.xml create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl-invalid.xml create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl.args create mode 100644 tests/qemuxml2argvdata/graphics-vnc-gl.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-active.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-inactive.xml -- 2.14.4

4 30

[libvirt] [PATCH] spec: Explicitly require matching libvirt-libs
by Jiri Denemark 09 Jul '18

09 Jul '18

All drivers now link directly to libvirt.so rather than getting the symbols from the daemon. Let's explicitly mention this dependency in the spec file. Theoretically, the automatic libvirt.so.0(LIBVIRT_PRIVATE_4.5.0) dependency should take care of everything, but rpmdiff complains it would like to see an explicit dependency on the exact libvirt-libs version too. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: The rpmdiff check may also be wrong, but I figured the explicit requires statement makes some sense and can't harm in any case. libvirt.spec.in | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 720870e2b1..6f0d399064 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -544,6 +544,7 @@ Network filter configuration files for cleaning guest traffic %package daemon-driver-network Summary: Network driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: dnsmasq >= 2.41 Requires: radvd Requires: iptables @@ -560,6 +561,7 @@ bridge capabilities. %package daemon-driver-nwfilter Summary: Nwfilter driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: iptables %if 0%{?rhel} && 0%{?rhel} < 7 Requires: iptables-ipv6 @@ -575,6 +577,7 @@ iptables and ip6tables capabilities %package daemon-driver-nodedev Summary: Nodedev driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} # needed for device enumeration %if 0%{?fedora} || 0%{?rhel} >= 7 Requires: systemd >= 185 @@ -591,6 +594,7 @@ capabilities. %package daemon-driver-interface Summary: Interface driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %if (0%{?fedora} || 0%{?rhel} >= 7) Requires: netcf-libs >= 0.2.2 %endif @@ -604,6 +608,7 @@ netcf library %package daemon-driver-secret Summary: Secret driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %description daemon-driver-secret The secret driver plugin for the libvirtd daemon, providing @@ -612,6 +617,7 @@ an implementation of the secret key APIs. %package daemon-driver-storage-core Summary: Storage driver plugin including base backends for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: nfs-utils # For mkfs Requires: util-linux @@ -628,6 +634,7 @@ iSCSI, and multipath storage. %package daemon-driver-storage-logical Summary: Storage driver plugin for lvm volumes Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: lvm2 %description daemon-driver-storage-logical @@ -638,6 +645,7 @@ volumes using lvm. %package daemon-driver-storage-disk Summary: Storage driver plugin for disk Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: parted Requires: device-mapper @@ -649,6 +657,7 @@ volumes using the host disks. %package daemon-driver-storage-scsi Summary: Storage driver plugin for local scsi devices Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %description daemon-driver-storage-scsi The storage driver backend adding implementation of the storage APIs for scsi @@ -658,6 +667,7 @@ host devices. %package daemon-driver-storage-iscsi Summary: Storage driver plugin for iscsi Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: iscsi-initiator-utils %description daemon-driver-storage-iscsi @@ -668,6 +678,7 @@ volumes using the host iscsi stack. %package daemon-driver-storage-mpath Summary: Storage driver plugin for multipath volumes Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: device-mapper %description daemon-driver-storage-mpath @@ -679,6 +690,7 @@ multipath storage using device mapper. %package daemon-driver-storage-gluster Summary: Storage driver plugin for gluster Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %if 0%{?fedora} Requires: glusterfs-client >= 2.0.1 %endif @@ -696,6 +708,7 @@ volumes using libgfapi. %package daemon-driver-storage-rbd Summary: Storage driver plugin for rbd Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %description daemon-driver-storage-rbd The storage driver backend adding implementation of the storage APIs for rbd @@ -707,6 +720,7 @@ volumes using the ceph protocol. %package daemon-driver-storage-sheepdog Summary: Storage driver plugin for sheepdog Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Requires: sheepdog %description daemon-driver-storage-sheepdog @@ -719,6 +733,7 @@ sheepdog volumes using. %package daemon-driver-storage-zfs Summary: Storage driver plugin for ZFS Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} # Support any conforming implementation of zfs Requires: /sbin/zfs Requires: /sbin/zpool @@ -760,6 +775,7 @@ parted and more. %package daemon-driver-qemu Summary: QEMU driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} # There really is a hard cross-driver dependency here Requires: libvirt-daemon-driver-network = %{version}-%{release} Requires: libvirt-daemon-driver-storage-core = %{version}-%{release} @@ -784,6 +800,7 @@ QEMU %package daemon-driver-lxc Summary: LXC driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} # There really is a hard cross-driver dependency here Requires: libvirt-daemon-driver-network = %{version}-%{release} %if 0%{?fedora} || 0%{?rhel} > 7 @@ -801,6 +818,7 @@ the Linux kernel %package daemon-driver-uml Summary: Uml driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %description daemon-driver-uml The UML driver plugin for the libvirtd daemon, providing @@ -813,6 +831,7 @@ User Mode Linux %package daemon-driver-vbox Summary: VirtualBox driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} %description daemon-driver-vbox The vbox driver plugin for the libvirtd daemon, providing @@ -825,6 +844,7 @@ VirtualBox %package daemon-driver-libxl Summary: Libxl driver plugin for the libvirtd daemon Requires: libvirt-daemon = %{version}-%{release} +Requires: libvirt-libs = %{version}-%{release} Obsoletes: libvirt-daemon-driver-xen < 4.3.0 %description daemon-driver-libxl -- 2.18.0

2 1

[libvirt] [PATCH 0/2] Usb and sata for virsh attach-disk --address
by Han Han 09 Jul '18

09 Jul '18

Add usb and sata support for attach-disk of address parameter in virsh. Han Han (2): virsh: usb support for virsh attach-disk --address virsh: sata support for virsh attach-disk --address tools/virsh-domain.c | 82 +++++++++++++++++++++++++++++++++++++++++++- tools/virsh.pod | 2 +- 2 files changed, 82 insertions(+), 2 deletions(-) -- 2.17.1

2 6

[libvirt] [RFC PATCH 0/4] Add new macro to check for existent server
by Marcos Paulo de Souza 09 Jul '18

09 Jul '18

Hello, I am trying to add a generic way to check for server, specially in drivers that needs the server to be declared. If there is better way to put the check, or a better way to check this setting, let me know. Thanks in advance! Marcos Paulo de Souza (4): driver.h: Add macro VIR_DRV_CONN_CHECK_SERVER esx_driver: Use VIR_DRV_CONN_CHECK_SERVER macro hyperv_driver: Use VIR_DRV_CONN_CHECK_SERVER macro phyp_driver: Use VIR_DRV_CONN_CHECK_SERVER macro src/driver.h | 9 +++++++++ src/esx/esx_driver.c | 7 +------ src/hyperv/hyperv_driver.c | 7 +------ src/phyp/phyp_driver.c | 6 +----- 4 files changed, 12 insertions(+), 17 deletions(-) -- 2.17.1

3 7

[libvirt] [PATCH] qemu: Fix typo in qemu_command.c
by Boris Fiuczynski 09 Jul '18

09 Jul '18

Rename qemuBulildFloppyCommandLineOptions into qemuBuildFloppyCommandLineOptions. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- src/qemu/qemu_command.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 32eb59b6ab..ea567262a9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2138,10 +2138,10 @@ qemuBuildDriveDevStr(const virDomainDef *def, static int -qemuBulildFloppyCommandLineOptions(virCommandPtr cmd, - const virDomainDef *def, - virDomainDiskDefPtr disk, - unsigned int bootindex) +qemuBuildFloppyCommandLineOptions(virCommandPtr cmd, + const virDomainDef *def, + virDomainDiskDefPtr disk, + unsigned int bootindex) { virBuffer fdc_opts = VIR_BUFFER_INITIALIZER; @@ -2252,8 +2252,8 @@ qemuBuildDiskCommandLine(virCommandPtr cmd, if (qemuDiskBusNeedsDeviceArg(disk->bus)) { if (disk->bus == VIR_DOMAIN_DISK_BUS_FDC) { - if (qemuBulildFloppyCommandLineOptions(cmd, def, disk, - bootindex) < 0) + if (qemuBuildFloppyCommandLineOptions(cmd, def, disk, + bootindex) < 0) return -1; } else { virCommandAddArg(cmd, "-device"); -- 2.17.0

2 1

[libvirt] [PATCH 0/4] Clean up QMP schema testing and add support for RBD auth for -blockdev
by Peter Krempa 09 Jul '18

09 Jul '18

QEMU recently added support for passing RBD credentials also for -blockdev/blockdev-add. First two patches remove the need for a separate stash for the QMP schema data, patch 3 adds new capabilities and finally the last patch adds the RBD auth support. Peter Krempa (4): tests: qemu: Use qmp schema data from the qemucapabilities test tests: remove qemuqapischema.json tests: qemucaps: Add test data for upcoming qemu 3.0.0 qemu: block: Add support for RBD authentication for blockdev src/qemu/qemu_block.c | 26 +- tests/Makefile.am | 1 - .../network-qcow2-backing-chain-cache-unsafe.json | 5 + ...etwork-qcow2-backing-chain-encryption_auth.json | 5 + .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 22718 +++++++++++++++++++ tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1213 + tests/qemucapabilitiestest.c | 1 + tests/qemumonitorjsontest.c | 13 +- tests/qemuqapischema.json | 11364 ---------- tests/testutilsqemuschema.c | 65 +- tests/testutilsqemuschema.h | 3 + 11 files changed, 24040 insertions(+), 11374 deletions(-) create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml delete mode 100644 tests/qemuqapischema.json -- 2.16.2

3 8

Re: [libvirt] [dbus PATCH] gitignore: add tests/.pytest_cache
by Andrea Bolognani 09 Jul '18

09 Jul '18

[re-adding libvirt-list] On Mon, 2018-07-09 at 09:23 -0400, Anya Harter wrote: > On 07/09/2018 04:34 AM, Andrea Bolognani wrote: > > On Thu, 2018-07-05 at 13:48 -0400, Anya Harter wrote: > > > +/tests/.pytest_cache > > > > When does the directory (or file?) get created? I just ran 'make > > test' but it's not there for me. > > The tests/.pytest_cache/ directory is created when make check is run and > the test suite fails. > > Additionally, a .pytest_cache/ directory is created in the home > directory if ./run tests/<testfile> fails. s/home directory/top-level directory of the project/ ;) > If you want I can give you a patch that breaks the test suite and > creates the directories in the two ways above. No need: I verified the above on my own, and in that light... > > Either way, this looks like it should be a more generic exclude > > pattern like the one we already have for __pycache__ directories > > instead of being limited to tests/. ... this suggestion was spot-on, as adding the pattern you suggested would take care of the failed 'make check' case but not of the failed './run tests/...' case. Looking forward to v2 :) -- Andrea Bolognani / Red Hat / Virtualization

1 0

[libvirt] [PATCH] domain_nwfilter: Return early if net has no name in virDomainConfNWFilterTeardownImpl
by Michal Privoznik 09 Jul '18

09 Jul '18

This function is called from various clean up paths (e.g. from qemuBuildInterfaceCommandLine). However, depending on the stage the interface creation process failed at, net->ifname might still be not filled in when control jumps to cleanup label. If that is the case return early (avoiding useless error message produced in virNWFilterBindingLookupByPortDev) as there is no NWFilter to tear down anyway. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_nwfilter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c index 24b5f42ddd..f39c8a1f9b 100644 --- a/src/conf/domain_nwfilter.c +++ b/src/conf/domain_nwfilter.c @@ -133,6 +133,9 @@ virDomainConfNWFilterTeardownImpl(virConnectPtr conn, { virNWFilterBindingPtr binding; + if (!net->ifname) + return; + binding = virNWFilterBindingLookupByPortDev(conn, net->ifname); if (!binding) return; -- 2.16.4

2 1

[libvirt] [PATCH v2 0/2] qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast'
by Peter Krempa 09 Jul '18

09 Jul '18

Peter Krempa (2): qemu: monitor: Remove qemuMonitorJSONExtractCPUArchInfo wrapper qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast' src/qemu/qemu_monitor_json.c | 31 +++++++++---------------------- 1 file changed, 9 insertions(+), 22 deletions(-) -- 2.16.2

2 4

[libvirt] [PATCH 0/6] Couple of important fixes
by Michal Privoznik 09 Jul '18

09 Jul '18

I think the most important fix is 2/6 as it might touch live user data. Also, I haven't run 'make check-access' in a while. If I did I would have noticed new paths being accessed. I'll try to update white list (in a separate patch set) and hopefully we can then enable by default and threat its errors as fatal. Michal Prívozník (6): qemuBuildSCSIiSCSIHostdevDrvStr: Don't leak @netsource and @srcprops qemuxml2argvtest: Don't spawn session daemon Forget last daemon/ dir artefacts virtestmock: Track connect() too check-file-access: Allow specifying action virtestmock: Track action Makefile.am | 2 +- run.in | 2 +- src/driver.h | 2 +- src/qemu/qemu_command.c | 6 ++--- tests/check-file-access.pl | 32 ++++++++++++++++++---- tests/file_access_whitelist.txt | 15 +++++++---- tests/libvirtd-fail | 4 +-- tests/qemuxml2argvmock.c | 7 +++++ tests/virtestmock.c | 59 ++++++++++++++++++++++++++++++----------- 9 files changed, 95 insertions(+), 34 deletions(-) -- 2.16.4

3 12

[libvirt] [PATCH] qemu: monitor: Note change in output of query-cpus-fast
by Peter Krempa 09 Jul '18

09 Jul '18

We did not use the field that has changed but note it in the code which extracts the data for future reference. Especially since there is an example of the output. https://bugzilla.redhat.com/show_bug.cgi?id=1598829 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3e90279b71..41abb920ab 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1645,6 +1645,9 @@ qemuMonitorJSONExtractCPUArchInfo(virJSONValuePtr jsoncpu, * ...}, * {...} * ] + * + * Note that since QEMU 2.13.0 the "arch" output member of the + * "query-cpus-fast" command is replaced by "target". */ static int qemuMonitorJSONExtractCPUInfo(virJSONValuePtr data, -- 2.16.2

2 2

[libvirt] [PATCH 0/2] Adding reflink support for XFS and others.
by Julio Faracco 09 Jul '18

09 Jul '18

This serie add XFS library to use the macro for reflink (clone). This is the case where BTRFS is not available but XFS is. In case of both is unavailable, the code will use FICLONE from filesystem library if it is defined. This implementation is similar to copy command. If you run a copy and trace the syscalls, you will see that ioctl uses BTRFS_IOC_CLONE or FICLONE to create a reflink. Julio Faracco (2): configure: Adding XFS library/headers check. storage: Rename btrfsCloneFile to support other filesystems. configure.ac | 7 +++++++ src/storage/storage_util.c | 20 ++++++++++++++------ 2 files changed, 21 insertions(+), 6 deletions(-) -- 2.17.1

4 6

[libvirt] [dbus PATCH] gitignore: Add trailing slashes to directory patterns
by Andrea Bolognani 09 Jul '18

09 Jul '18

This makes it explicit that they're meant to ignore entire directories rather than single files. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitignore | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index ca9e4e1..45a1eb4 100644 --- a/.gitignore +++ b/.gitignore @@ -7,9 +7,9 @@ *Makefile *Makefile.in *~ -.deps -.libs -__pycache__ +.deps/ +.libs/ +__pycache__/ vgcore.* /AUTHORS -- 2.17.1

1 0

[libvirt] [dbus PATCH] gitignore: add tests/.pytest_cache
by Anya Harter 09 Jul '18

09 Jul '18

Signed-off-by: Anya Harter <aharter(a)redhat.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index ca9e4e1..c41c82c 100644 --- a/.gitignore +++ b/.gitignore @@ -44,3 +44,4 @@ vgcore.* /src/org.libvirt.service /tests/test_util +/tests/.pytest_cache -- 2.17.1

2 1

[libvirt] [PATCH python] fix build with older libvirt missing virNWFilterBindingPtr
by Daniel P. Berrangé 09 Jul '18

09 Jul '18

While we correctly disable all public API bindings that rely on virNWFilterBindingPtr, the generator is still creating a helper function that needs it - libvirt_virNWFilterBinding_pointer. Making this helper conditional is a little hairy, so just provide a trivial typedef to keep it happy. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- typewrappers.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/typewrappers.h b/typewrappers.h index 1570c6a..4423774 100644 --- a/typewrappers.h +++ b/typewrappers.h @@ -27,6 +27,10 @@ typedef ssize_t Py_ssize_t; #endif +#if !LIBVIR_CHECK_VERSION(4, 5, 0) +typedef struct _virNWFilterBinding *virNWFilterBindingPtr; +#endif + #define PyvirConnect_Get(v) (((v) == Py_None) ? NULL : \ (((PyvirConnect_Object *)(v))->obj)) -- 2.17.1

1 0

[libvirt] [PATCH] examples: Remove config.h from hellolibvirt and openauth
by Marcos Paulo de Souza 09 Jul '18

09 Jul '18

These two examples do not use any definition from config.h, and by removing it these examples can be compiled standalone. Signed-off-by: Marcos Paulo de Souza <marcos.souza.org(a)gmail.com> --- When trying to remove config.h from domtop and domsuspend, a later inclusion of unistd.h complains about the missing config.h. This unistd.h come from gnulib, so I need more time to check why this header would complain, so for now just these examples are a good start ... examples/hellolibvirt/hellolibvirt.c | 2 -- examples/openauth/openauth.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c index 02c4401987..bfb12846e6 100644 --- a/examples/hellolibvirt/hellolibvirt.c +++ b/examples/hellolibvirt/hellolibvirt.c @@ -2,8 +2,6 @@ * hypervisor and gather a few bits of information about domains. * Similar API's exist for storage pools, networks, and interfaces. */ -#include <config.h> - #include <stdio.h> #include <stdlib.h> #include <libvirt/libvirt.h> diff --git a/examples/openauth/openauth.c b/examples/openauth/openauth.c index eef46d5f52..efd21c374f 100644 --- a/examples/openauth/openauth.c +++ b/examples/openauth/openauth.c @@ -1,8 +1,6 @@ /* This is a copy of the hellolibvirt example demonstaring how to use * virConnectOpenAuth with a custom auth callback */ -#include <config.h> - #include <stdio.h> #include <stdlib.h> #include <string.h> -- 2.17.1

2 1

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31
by Ivan.Mishonov＠redhat.com 09 Jul '18

09 Jul '18

From: Ivan Mishonov <ivan(a)conquex.com> There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31 src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.18.0

2 2

[libvirt] [PATCH 0/2] Minor fixes for virTypedParams(De)Serialize
by Marc Hartmayer 07 Jul '18

07 Jul '18

Some minor fixes and two questions: * Is the first method, which is described in the documentation for virTypedParamsDeserialize, in sync with the actual code? ("Older APIs do not rely on deserializer allocating memory for @params, ...") * Do we also have to set *nparams = 0 in case of an error and the user has allocated the memory? (virTypedParamsDeserialize) Marc Hartmayer (2): virTypedParamsSerialize: minor fixes virTypedParamsDeserialize: minor fixes src/util/virtypedparam.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) -- 2.13.4

4 15

[libvirt] [RFCv2 PATCH 0/5] Introduce RDT memory bandwidth allocation support
by bing.niu＠intel.com 07 Jul '18

07 Jul '18

From: Bing Niu <bing.niu(a)intel.com> This series is to introduce RDT memory bandwidth allocation support by extending current virresctrl implementation. The Memory Bandwidth Allocation (MBA) feature provides indirect and approximate control over memory bandwidth available per-core. This feature provides a method to control applications which may be over-utilizing bandwidth relative to their priority in environments such as the data-center. The details can be found in Intel's SDM 17.19.7. Kernel supports MBA through resctrl file system same as CAT. Each resctrl group have a MB parameter to control how much memory bandwidth it can utilize in unit of percentage. In this series, MBA is enabled by enhancing existing virresctrl implementation. The policy employed for MBA is similar with CAT: The sum of each MBA group's bandwidth dose not exceed 100%. The enhancement of virresctrl include two parts: Part 1: Add two new structures virResctrlInfoMB and virResctrlAllocMB for collecting host system MBA capability and domain memory bandwidth allocation. Those two structures are the extension of existing virResctrlInfo and virResctrlAlloc. With them, virresctrl framework can support MBA and CAT concurrently. Each virResctrlAlloc represent a resource allocation including CAT, or MBA, or CAT&MBA. The policy of MBA is that: total memory bandwidth of each resctrl group, created by virresctrl, does not exceed to 100%. Part 2: On XML part, add new elements to host capabilities query and domain allocation to support memory bandwidth allocation. ---------------------------------------------------------------------------------------------- For host capabilities XML, new XML format like below example, <host> ..... <memory> <node id='0' cpus='0-19'> <control granularity='10' min ='10' maxAllocs='8'/> </node> </memory> </host> granularity --- memory bandwidth granularity min --- minimum memory bandwidth allowed maxAllocs --- maximum concurrent memory bandwidth allocation allowed. ---------------------------------------------------------------------------------------------- For domain XML, new format as below example <domain type='kvm' id='2'> ...... <cputune> ...... <shares>1024</shares> <memorytune vcpus='0-1'> <node id='0' bandwidth='20'/> </memorytune> </cputune> ...... </domain> id --- node where memory bandwidth allocation will happen bandwidth --- bandwidth allocated in percentage ---------------------------------------------------------------------------------------------- Changelog: v1->v2: Jano's comment: 1. put renaming parts into separated patches. 2. set the initial return value as -1. 3. using full name in structure definition. 4. do not use VIR_CACHE_TYPE_LAST for memory bandwidth allocation formatting. Pavel's comment: 1. add host capabilities XML for memory bandwidth allocation. 2. do not mix use cachetune section in XML for memory bandwidth allocation in domain XML. define a dedicated one for memory bandwidth allocation. Bing Niu (5): util: Rename and packing parts of virresctrl util: Add memory bandwidth support to resctrl conf: rename cachetune to restune conf: Introduce cputune/memorytune to support memory bandwidth allocation conf: add memory bandwidth allocation capability of host src/conf/capabilities.c | 112 +++++++++++ src/conf/capabilities.h | 11 ++ src/conf/domain_conf.c | 304 ++++++++++++++++++++++++++--- src/conf/domain_conf.h | 10 +- src/libvirt_private.syms | 4 +- src/qemu/qemu_process.c | 18 +- src/util/virresctrl.c | 496 ++++++++++++++++++++++++++++++++++++++++++++--- src/util/virresctrl.h | 35 +++- 8 files changed, 918 insertions(+), 72 deletions(-) -- 2.7.4

3 16

[libvirt] [PATCH 0/9] Resolve libvirtd hang on termination with connected long running client
by John Ferlan 07 Jul '18

07 Jul '18

RFC: https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html Adjustments since RFC... Patches 1&2: No change, were already R-B'd Patch 3: Removed code as noted in code review, update commit message Patch 4: From old series removed, see below for more details Patch 9: no change NB: Patches 5-8 and 10 from Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> are removed as they seemed to not be necessary Replaced the former patch 4 with series of patches to (slowly) provide support to disable new connections, handle removing waiting jobs, causing the waiting workers to quit, and allow any running jobs to complete. As it turns out, waiting for running jobs to complete cannot be done from the virNetServerClose callbacks because that means the event loop processing done during virNetServerRun will not allow any currently long running worker job thread a means to complete. So when virNetDaemonQuit is called as a result of the libvirtd signal handlers for SIG{QUIT|INT|TERM}, instead of just causing virNetServerRun to quit immediately, alter to using a quitRequested flag and then use that quitRequested flag to check for long running worker threads before causing the event loop to quit resulting in libvirtd being able to run through the virNetDaemonClose processing. John Ferlan (9): libvirtd: Alter refcnt processing for domain server objects libvirtd: Alter refcnt processing for server program objects netserver: Remove ServiceToggle during ServerDispose util: Introduce virThreadPoolDrain rpc: Introduce virNetServerQuitRequested rpc: Introduce virNetServerWorkerCount rpc: Alter virNetDaemonQuit processing docs: Add news article for libvirtd issue APPLY ONLY FOR TESTING PURPOSES daemon/libvirtd.c | 43 +++++++++++++++++++++++--------- docs/news.xml | 12 +++++++++ src/libvirt_private.syms | 1 + src/libvirt_remote.syms | 2 ++ src/qemu/qemu_driver.c | 5 ++++ src/rpc/virnetdaemon.c | 45 +++++++++++++++++++++++++++++++++- src/rpc/virnetserver.c | 52 ++++++++++++++++++++++++++++++++++++--- src/rpc/virnetserver.h | 4 +++ src/util/virthreadpool.c | 64 ++++++++++++++++++++++++++++++++++++++++-------- src/util/virthreadpool.h | 2 ++ 10 files changed, 204 insertions(+), 26 deletions(-) -- 2.13.6

5 29

[libvirt] [PATCHv1 00/12] BaselineHypervisorCPU using QEMU QMP exchanges
by Chris Venteicher 06 Jul '18

06 Jul '18

Some architectures (S390) depend on QEMU to compute baseline CPU model and expand a models feature set. Interacting with QEMU requires starting the QEMU process and completing one or more query-cpu-model-baseline QMP exchanges with QEMU in addition to a query-cpu-model-expansion QMP exchange to expand all features in the model. See "s390x CPU models: exposing features" patch set on Qemu-devel for discussion of QEMU aspects. This is part of resolution of: https://bugzilla.redhat.com/show_bug.cgi?id=1511999 Signed-off-by: Chris Venteicher <cventeic(a)redhat.com> Chris Venteicher (12): qemu_monitor_json: qemuMonitorCPUModelInfo / JSON conversion qemu_monitor: Introduce qemuMonitorCPUModelInfoInit and qemuMonitorCPUModelInfoFreeContents qemu_monitor: Introduce qemuMonitorGetCPUModelBaseline (query-cpu-model-baseline) qemu_monitor: Indicate when CPUModelInfo props report migratablity qemu_monitor: CPUModelExpansion on CPUModel with both name and properties cpu_conf: Calculate virCPUDef List Length function qemu_capabilities: virCPUDef / qemuMonitorCPUModelInfo conversions qemu_capabilities: QMPCommandPtr without shadow qmperr qemu_capabilities: Persist QEMU instance over multiple QMP Cmds qemu_capabilities: Introduce virQEMUCapsNewQMPCommandConnection qemu_capabilities: Introduce virQEMUCapsQMPBaselineCPUModel (baseline using QEMU) qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP src/conf/cpu_conf.c | 15 ++ src/conf/cpu_conf.h | 3 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 335 +++++++++++++++++++++++++++++------ src/qemu/qemu_capabilities.h | 33 ++++ src/qemu/qemu_driver.c | 66 ++++++- src/qemu/qemu_monitor.c | 90 +++++++++- src/qemu/qemu_monitor.h | 16 +- src/qemu/qemu_monitor_json.c | 226 +++++++++++++++++++---- src/qemu/qemu_monitor_json.h | 14 +- tests/cputest.c | 7 +- 11 files changed, 683 insertions(+), 123 deletions(-) -- 2.17.1

2 20

[libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode
by Daniel P. Berrangé 06 Jul '18

06 Jul '18

When support was adding for passing a pre-opened listener socket to UNIX chardevs, it accidentally passed the listener socket for client mode chardevs too with predictable amounts of fail resulting. Expand the unit test coverage to validate that we are only doing FD passing when operating in server mode. Reported-by: Richard W.M. Jones <rjones(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_command.c | 3 +- .../qemuxml2argvdata/serial-unix-chardev.args | 2 ++ .../serial-unix-chardev.x86_64-latest.args | 36 +++++++++++++++++++ .../qemuxml2argvdata/serial-unix-chardev.xml | 4 +++ tests/qemuxml2argvtest.c | 1 + 5 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/serial-unix-chardev.x86_64-latest.args diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 82d8030a33..32eb59b6ab 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5083,7 +5083,8 @@ qemuBuildChrChardevStr(virLogManagerPtr logManager, break; case VIR_DOMAIN_CHR_TYPE_UNIX: - if ((flags & QEMU_BUILD_CHARDEV_UNIX_FD_PASS) && + if (dev->data.nix.listen && + (flags & QEMU_BUILD_CHARDEV_UNIX_FD_PASS) && virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS)) { if (qemuSecuritySetSocketLabel(secManager, (virDomainDefPtr)def) < 0) goto cleanup; diff --git a/tests/qemuxml2argvdata/serial-unix-chardev.args b/tests/qemuxml2argvdata/serial-unix-chardev.args index 584f4a1dd1..873d3263c6 100644 --- a/tests/qemuxml2argvdata/serial-unix-chardev.args +++ b/tests/qemuxml2argvdata/serial-unix-chardev.args @@ -26,4 +26,6 @@ server,nowait \ -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ -chardev socket,id=charserial0,path=/tmp/serial.sock \ -device isa-serial,chardev=charserial0,id=serial0 \ +-chardev socket,id=charserial1,path=/tmp/serial-server.sock,server,nowait \ +-device isa-serial,chardev=charserial1,id=serial1 \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/serial-unix-chardev.x86_64-latest.args b/tests/qemuxml2argvdata/serial-unix-chardev.x86_64-latest.args new file mode 100644 index 0000000000..ce7a7f80d7 --- /dev/null +++ b/tests/qemuxml2argvdata/serial-unix-chardev.x86_64-latest.args @@ -0,0 +1,36 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-i686 \ +-name guest=QEMUGuest1,debug-threads=on \ +-S \ +-object secret,id=masterKey0,format=raw,\ +file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ +-machine pc,accel=tcg,usb=off,dump-guest-core=off \ +-m 214 \ +-realtime mlock=off \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=charmonitor,fd=1729,server,nowait \ +-mon chardev=charmonitor,id=monitor,mode=control \ +-rtc base=utc \ +-no-shutdown \ +-no-acpi \ +-boot strict=on \ +-device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \ +-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ +-device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 \ +-chardev socket,id=charserial0,path=/tmp/serial.sock \ +-device isa-serial,chardev=charserial0,id=serial0 \ +-chardev socket,id=charserial1,fd=1729,server,nowait \ +-device isa-serial,chardev=charserial1,id=serial1 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x2 \ +-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\ +resourcecontrol=deny \ +-msg timestamp=on diff --git a/tests/qemuxml2argvdata/serial-unix-chardev.xml b/tests/qemuxml2argvdata/serial-unix-chardev.xml index 04f83779ce..af513d6445 100644 --- a/tests/qemuxml2argvdata/serial-unix-chardev.xml +++ b/tests/qemuxml2argvdata/serial-unix-chardev.xml @@ -25,6 +25,10 @@ <source mode='connect' path='/tmp/serial.sock'/> <target port='0'/> </serial> + <serial type='unix'> + <source mode='bind' path='/tmp/serial-server.sock'/> + <target port='1'/> + </serial> <console type='unix'> <source mode='connect' path='/tmp/serial.sock'/> <target port='0'/> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 2d52f352b0..3be5af03aa 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1335,6 +1335,7 @@ mymain(void) QEMU_CAPS_CHARDEV_FILE_APPEND); DO_TEST("serial-unix-chardev", QEMU_CAPS_DEVICE_ISA_SERIAL); + DO_TEST_CAPS_LATEST("serial-unix-chardev"); DO_TEST("serial-tcp-chardev", QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("serial-udp-chardev", -- 2.17.1

2 2

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31
by Ivan Mishonov 06 Jul '18

06 Jul '18

From: Ivan Mishonov <ivan(a)conquex.com> There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31 src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.18.0

1 1

[libvirt] [PATCH 0/3] Fix regression with vhostuser and chardev FD passing
by Daniel P. Berrangé 05 Jul '18

05 Jul '18

QEMU has a validation bug which prevents vhostuser accepting the chardev when it uses FD passing, despite it being functionally correct. While the QEMU bug is being fixed, we need to avoid hitting this problem with existing QEMU releases. The easiest way todo this is to simply disable FD passing for the chardev used with vhostuser only. Daniel P. Berrangé (3): qemu: remove chardevStdioLogd param from vhostuser code path qemu: consolidate parameters of qemuBuildChrChardevStr into flags qemu: don't use chardev FD passing for vhostuser backend src/qemu/qemu_command.c | 117 ++++++++++++++-------- tests/qemuxml2argvdata/net-vhostuser.args | 3 +- tests/qemuxml2argvtest.c | 2 +- 3 files changed, 75 insertions(+), 47 deletions(-) -- 2.17.1

2 6

[libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP
by Olaf Hering 05 Jul '18

05 Jul '18

Currently virNetSocketNewListenTCP bails out early under the following conditions: - the hostname resolves to at least one IPv4 and at least one IPv6 address - the local interfaces have that one IPv4 address assigned, but not any of the IPv6 addresses - the local interfaces have just IPv6 link-local addresses In this case the resolver returns not only the IPv4 addresses but also IPv6. Binding the IPv6 address will obviously fail. But this terminates the entire loop, even if binding to IPv4 succeeded. To fix this error, just keep going and loop through all returned addresses. In case none of the attempts to bind to some address succeeded, try to report some appropriate error. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- v3: more whitespace fixes, as suggested by Daniel P. Berrang�� v2: whitespace fixes, as suggested by John Ferlan src/rpc/virnetsocket.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 7087abec9c..3a055acd39 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -382,11 +382,8 @@ int virNetSocketNewListenTCP(const char *nodename, #endif if (bind(fd, runp->ai_addr, runp->ai_addrlen) < 0) { - if (errno != EADDRINUSE) { - virReportSystemError(errno, "%s", _("Unable to bind to port")); - goto error; - } - addrInUse = true; + if (errno == EADDRINUSE) + addrInUse = true; VIR_FORCE_CLOSE(fd); runp = runp->ai_next; continue; @@ -409,14 +406,14 @@ int virNetSocketNewListenTCP(const char *nodename, fd = -1; } - if (nsocks == 0 && familyNotSupported) { - virReportSystemError(EAFNOSUPPORT, "%s", _("Unable to bind to port")); - goto error; - } - - if (nsocks == 0 && - addrInUse) { - virReportSystemError(EADDRINUSE, "%s", _("Unable to bind to port")); + if (nsocks == 0) { + if (familyNotSupported) + errno = EAFNOSUPPORT; + else if (addrInUse) + errno = EADDRINUSE; + else + errno = EDESTADDRREQ; + virReportSystemError(errno, "%s", _("Unable to bind to port")); goto error; }

3 7

[libvirt] [PATCH 0/5] AUTHORS: Cleanups and fixes
by Andrea Bolognani 05 Jul '18

05 Jul '18

Comparing the generated AUTHORS file before and after these changes: AUTHORS | 51 +-------------------------------------------------- 1 file changed, 1 insertion(+), 50 deletions(-) There would be plenty of room for additional deduplication, but that's how far I can get based on concrete data as opposed to relying on (more or less educated) guesses. Andrea Bolognani (5): AUTHORS: Remove unnecessary remark AUTHORS: Fix entries disagreeing with mailmap mailmap: Fix consolidation rules mailmap: Consolidate current and past maintainers AUTHORS: Avoid duplicated entries .mailmap | 16 +++++++++++++--- AUTHORS.in | 6 ++---- Makefile.am | 18 +++++++++++++----- 3 files changed, 28 insertions(+), 12 deletions(-) -- 2.17.1

3 7