- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: cgroup: Fix crash if starting nographics guest
by Cole Robinson 01 Oct '13

01 Oct '13

We can dereference graphics[0] even if guest has no graphics device configured. I screwed this up in a216e6487255d3b65d97c7ec1fa5da63dbced902 --- src/qemu/qemu_cgroup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index f95c7f2..ace7e35 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -490,9 +490,10 @@ qemuSetupDevicesCgroup(virQEMUDriverPtr driver, if (vm->def->nsounds && ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) || - ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && + (vm->def->graphics && + ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && cfg->vncAllowHostAudio) || - (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)))) { + (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) { rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_SND_MAJOR, VIR_CGROUP_DEVICE_RW); virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR, -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu_hotplug: Allow QoS update in qemuDomainChangeNet
by Michal Privoznik 01 Oct '13

01 Oct '13

The qemuDomainChangeNet() is called when 'virsh update-device' is invoked on a NIC. Currently, we fail to update the QoS even though we have routines for that. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_hotplug.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f06930e..41b942f 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2062,8 +2062,6 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) || !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev), virDomainNetGetActualVirtPortProfile(newdev)) || - !virNetDevBandwidthEqual(virDomainNetGetActualBandwidth(olddev), - virDomainNetGetActualBandwidth(newdev)) || !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev), virDomainNetGetActualVlan(newdev))) { needReconnect = true; @@ -2081,6 +2079,18 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, goto cleanup; } + if (!virNetDevBandwidthEqual(virDomainNetGetActualBandwidth(olddev), + virDomainNetGetActualBandwidth(newdev))) { + if (virNetDevBandwidthSet(newdev->ifname, + virDomainNetGetActualBandwidth(newdev), + false) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot set bandwidth limits on %s"), + newdev->ifname); + goto cleanup; + } + needReplaceDevDef = true; + } if (needBridgeChange) { if (qemuDomainChangeNetBridge(dom->conn, vm, olddev, newdev) < 0) goto cleanup; -- 1.8.1.5

2 1

[libvirt] ANNOUNCE: libvirt 0.9.12.1 maintenance release
by Guido Günther 01 Oct '13

01 Oct '13

libvirt 0.9.12.1 maintenance release is now available. This is libvirt 0.9.12 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.12.1.tar.gz Checksums: md5sum: 65fb37b247281bcdd027f51e6d7d3847 sha1: 2710e415bed06043a75ebbf0a7de773ce0748250 sha256: e5d0055c8bde84620f65bfe6968acc39a1015ab17b735b951e982d67909f5484 Changes in this version: Prepare 0.9.12.1 (Guido Günther) Fix TLS tests with gnutls 3 (Daniel P. Berrange) build: avoid confusing make with raw name 'undefine' (Eric Blake) virsh: Fix POD syntax (Jiri Denemark) build: more workarounds for if_bridge.h (Eric Blake) build: allow building with newer glibc-headers and -O0 (Eric Blake) Fix race condition when destroying guests (Daniel P. Berrange) Don't ignore return value of qemuProcessKill (Daniel P. Berrange) conf: Remove console stream callback only when freeing console helper (Peter Krempa) conf: Remove callback from stream when freeing entries in console hash (Peter Krempa) storage: Need to also VIR_FREE(reg) (Luca Tettamanti) qemu: Add support for -no-user-config (Jiri Denemark) rpc: Fix crash on error paths of message dispatching (Peter Krempa) qemu: Fix off-by-one error while unescaping monitor strings (Peter Krempa) Revert "rpc: Discard non-blocking calls only when necessary" (Jiri Denemark) build: fix virnetlink on glibc 2.11 (Eric Blake) security: Fix libvirtd crash possibility (Martin Kletzander) daemon: Fix crash in virTypedParameterArrayClear (Jiri Denemark) For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Cheers, -- Guido

1 0

[libvirt] [PATCH] selinux: Only close the selabel_handle once
by Ján Tomko 01 Oct '13

01 Oct '13

On selinux driver initialization failure (missing/incorrectly formated contexts file), selabel_handle was closed twice. Introduced by 6159710. --- src/security/security_selinux.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 38de060..c408fa8 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -460,6 +460,7 @@ virSecuritySELinuxLXCInitialize(virSecurityManagerPtr mgr) error: # if HAVE_SELINUX_LABEL_H selabel_close(data->label_handle); + data->label_handle = NULL; # endif virConfFree(selinux_conf); VIR_FREE(data->domain_context); @@ -547,6 +548,7 @@ virSecuritySELinuxQEMUInitialize(virSecurityManagerPtr mgr) error: #if HAVE_SELINUX_LABEL_H selabel_close(data->label_handle); + data->label_handle = NULL; #endif VIR_FREE(data->domain_context); VIR_FREE(data->alt_domain_context); @@ -808,7 +810,8 @@ virSecuritySELinuxSecurityDriverClose(virSecurityManagerPtr mgr) return 0; #if HAVE_SELINUX_LABEL_H - selabel_close(data->label_handle); + if (data->label_handle) + selabel_close(data->label_handle); #endif virHashFree(data->mcs); -- 1.8.1.5

2 2

[libvirt] [PATCH] Fix handling of IPv6 listen addresses in cmdDomDisplay
by Ján Tomko 01 Oct '13

01 Oct '13

Use virSocketAddrIsWildcard instead of STREQ to check for the ANY address and put brackets around the address if it contains ':'. --- tools/virsh-domain.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index fa012d1..42c9920 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9043,6 +9043,7 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) int flags = 0; bool params = false; const char *xpath_fmt = "string(/domain/devices/graphics[@type='%s']/@%s)"; + virSocketAddr addr; if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) return false; @@ -9126,8 +9127,12 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, ":%s@", passwd); /* Then host name or IP */ - if (!listen_addr || STREQ((const char *)listen_addr, "0.0.0.0")) + if (!listen_addr || + (virSocketAddrParse(&addr, listen_addr, AF_UNSPEC) > 0 && + virSocketAddrIsWildcard(&addr))) virBufferAddLit(&buf, "localhost"); + else if (strchr(listen_addr, ':')) + virBufferAsprintf(&buf, "[%s]", listen_addr); else virBufferAsprintf(&buf, "%s", listen_addr); -- 1.8.1.5

2 2

[libvirt] [PATCH] LXC: Detect fs support. Mount only supported fs in containers
by Bogdan Purcareata 01 Oct '13

01 Oct '13

Some filesystems - specifically securityfs - are not supported in all systems running libvirt containers. When starting a container, mount only the filesystems that are supported on the host. Detection of filesystem support is done at runtime. Signed-off-by: Bogdan Purcareata <bogdan.purcareata(a)freescale.com> --- src/lxc/lxc_container.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index c60f5d8..eff9a24 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -509,6 +509,61 @@ static int lxcContainerChildMountSort(const void *a, const void *b) # define MS_SLAVE (1<<19) #endif +/* + * This function attempts to detect kernel support + * for a specific filesystem type. This is done by + * inspecting /proc/filesystems. + */ +static int lxcCheckFSSupport(const char *fs_type) +{ + FILE *fp = NULL; + int ret = -1; + const char *fslist = "/proc/filesystems"; + char *line = NULL; + const char *type; + + if (!fs_type) + return 1; + + VIR_DEBUG("Checking kernel support for %s", fs_type); + + VIR_DEBUG("Open %s", fslist); + if (!(fp = fopen(fslist, "r"))) { + if (errno == ENOENT) + + virReportSystemError(errno, + _("Unable to read %s"), + fslist); + goto cleanup; + } + + while (!feof(fp)) { + size_t n; + VIR_FREE(line); + if (getline(&line, &n, fp) <= 0) { + if (feof(fp)) + break; + + goto cleanup; + } + + type = strstr(line, fs_type); + if (type) { + ret = 1; + goto cleanup; + } + } + + VIR_DEBUG("No kernel support for %s", fs_type); + + ret = 0; + +cleanup: + VIR_FREE(line); + VIR_FORCE_FCLOSE(fp); + return ret; +} + static int lxcContainerGetSubtree(const char *prefix, char ***mountsret, size_t *nmountsret) @@ -855,17 +910,23 @@ static int lxcContainerMountBasicFS(bool userns_enabled) for (i = 0; i < ARRAY_CARDINALITY(lxcBasicMounts); i++) { virLXCBasicMountInfo const *mnt = &lxcBasicMounts[i]; const char *srcpath = NULL; + const char *dstpath = NULL; VIR_DEBUG("Processing %s -> %s", mnt->src, mnt->dst); srcpath = mnt->src; + dstpath = mnt->dst; /* Skip if mount doesn't exist in source */ if ((srcpath[0] == '/') && (access(srcpath, R_OK) < 0)) continue; + if ((access(dstpath, R_OK) < 0) || /* mount is not present on host */ + (!lxcCheckFSSupport(mnt->type))) /* no fs support in kernel */ + continue; + #if WITH_SELINUX if (STREQ(mnt->src, SELINUX_MOUNT) && (!is_selinux_enabled() || userns_enabled)) -- 1.7.11.7

3 2

[libvirt] networking restart after redefinition
by Mihamina Rakotomandimby 01 Oct '13

01 Oct '13

Hi all, Running Fedora 18 and the bundled libvirt and virt-tools. Desktop use. As I like to access my guests with a hostname and not a numerical IP address, I fix the IP addressing in the network configuration: http://pastebin.com/rfMKn40j Unfortunately, I cant find a way to add a host without loosing the whole networking, as when I add a ahost, I destroy and redefine the network. Restarting libvirtd is not the solution. How would you recommend to have networking UP after network redefinition? -- RMA.

2 2

[libvirt] [PATCH 0/2] Support IPv6 in port allocator
by Ján Tomko 01 Oct '13

01 Oct '13

Ján Tomko (2): Split out virHostHasIPv6 from qemuMigrationPrepareAny Bind to both IPv4 and v6 when checking port availability src/libvirt_private.syms | 1 + src/qemu/qemu_migration.c | 8 +------- src/util/virportallocator.c | 34 +++++++++++++++++++++++++++------- src/util/virutil.c | 14 ++++++++++++++ src/util/virutil.h | 1 + 5 files changed, 44 insertions(+), 14 deletions(-) -- 1.8.1.5

2 4

[libvirt] [PATCH] libvirt: hostdev SCSI AdapterId retrieval fix
by Boris Fiuczynski 01 Oct '13

01 Oct '13

Fixed the retrieval of the AdapterId from the AdapterName of the hostdev source so it does return an error instead of leaving the adapter_id uninitialized. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> Reviewed-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com> --- src/util/virscsi.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/util/virscsi.c b/src/util/virscsi.c index 43658c0..7aca9e6 100644 --- a/src/util/virscsi.c +++ b/src/util/virscsi.c @@ -88,16 +88,13 @@ static int virSCSIDeviceGetAdapterId(const char *adapter, unsigned int *adapter_id) { - if (STRPREFIX(adapter, "scsi_host")) { - if (virStrToLong_ui(adapter + strlen("scsi_host"), - NULL, 0, adapter_id) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Cannot parse adapter '%s'"), adapter); - return -1; - } - } - - return 0; + if (STRPREFIX(adapter, "scsi_host") && + virStrToLong_ui(adapter + strlen("scsi_host"), + NULL, 0, adapter_id) == 0) + return 0; + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Cannot parse adapter '%s'"), adapter); + return -1; } char * -- 1.8.3.1

2 3

[libvirt] Release of libvirt-1.1.3
by Daniel Veillard 01 Oct '13

01 Oct '13

As scheduled I made the 1.1.3 release today, the git tree is tagged and tarball and rpms are available at the usual place: ftp://libvirt.org/libvirt/ Overall a rather big release, with more than 300 patches included, with a lot of fixes many of them being leaks or report from Coverity, but also 3 security fixes. There is also a few features but listed but they are more about focused improvement than anything revolutionary, this should be considered a stabilization release, it should be good (Famous Last Words !) Features: - VMware: Initial VMware Fusion support and various improvements (Doug Goldstein) - libvirt: add new public API virConnectGetCPUModelNames (Giuseppe Scrivano) - various libxl driver improvements (Jim Fehlig) - LXC many container driver improvement (Chen Hanxiao, Gao Feng, Daniel P. Berrange) - ARM cpu improvements (Cole Robinson) Security: - Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296) (Daniel P. Berrange) - Add support for using 3-arg pkcheck syntax for process (CVE-2013-4311) (Daniel P. Berrange) - virFileNBDDeviceAssociate: Avoid use of uninitialized variable (Michal Privoznik) Documentation: - python: Document virNodeGetInfo bug (Michal Privoznik) - maint: fix comment typos (Eric Blake) - conf: Fix virNetworkAssignDef's comment. (lawrancejing) - fix virEventAddHandle return details (Jonathan Lebon) - fix XML for the RNG device example (Giuseppe Scrivano) - mention hostname subtlety (Eric Blake) - Add some notes about security considerations when using LXC (Daniel P. Berrange) - Repair the search on libvirt.org (Daniel Veillard) - api-docs: Fix description of virConnectGetType() API function (Michal Novotny) - Update docs about user namespace for LXC (Daniel P. Berrange) - docs, comments: minor typo fixes (Oskari Saarenmaa) - LXC: fix typos in lxc_container.c (Chen Hanxiao) - fix a typo in virt-login-shell.pod (Alex Jia) - Fix a typo in network XML docs (Ján Tomko) - Add OpenStack into references (Martin Kletzander) - examples: Add script to parse topology from capabilities output (Peter Krempa) Portability: - build: fix build --without-lxc (Eric Blake) - build: tweak vpath builds of net_rpc (Eric Blake) - fchosttest: Run the test only under linux (Michal Privoznik) - genprotocol.pl: Fix code on FreeBSD too (Michal Privoznik) - BSD: Ensure process creation timestamp is init'd (Doug Goldstein) - BSD: Ensure UNIX socket credentials are valid (Doug Goldstein) - build: fix testsuite building under cygwin (Eric Blake) - build: Fix VPATH build error for locking daemon (Viktor Mihajlovski) - build: fix use of rpc.h on cygwin (Eric Blake) - build: skip ld_preload tests on non-Linux systems (Eric Blake) - build: hoist system-specific checks before library checks (Eric Blake) - virsh: Don't shadow global variable "remove" in cmdMetadata (Peter Krempa) - conf: Avoid false positive of uninitialized variable use (Peter Krempa) - build: fix VPATH build of remote driver (Eric Blake) - build: make autobuild require rpm build deps (Eric Blake) - build: fix build with latest rawhide kernel headers (Eric Blake) - Explicitly link libvirt_net_rpc against SELINUX_LIBS (Guido Günther) - build: require libnl-3 if netcf uses it (Eric Blake) - build: fix regression in requiring yajl for new enough qemu (Eric Blake) - build: avoid obsolete AC_HELP_STRING (Eric Blake) - virsh: fix build on mingw, which lacks termios stuff (Eric Blake) - build: avoid stranded polkit file in client-only build (Eric Blake) - spec: fix rpm build when lxc disabled (Eric Blake) Bug Fixes: - lxc: do cleanup when failed to bind fs as read-only (Chen Hanxiao) - Fix max stream packet size for old clients (Daniel P. Berrange) - LXC: workaround machined uncleaned data with containers running systemd. (Cédric Bosdonnat) - virfile: safezero: align mmap offset to page size (Oskari Saarenmaa) - virscsi: hostdev SCSI AdapterId retrieval fix (Boris Fiuczynski) - virsh-volume: Add missing check when calling virStreamNew (Hongwei Bi) - virsh-domain: Free dom before return false in cmdDump (Hongwei Bi) - qemu: process: Silence coverity warning when rewinding log file (Peter Krempa) - Fix crash in libvirtd when events are registered & ACLs active (Daniel P. Berrange) - virsh: Fix domdisplay when domain only uses TLS (Christophe Fergeau) - qemu: Free all driver data in qemuStateCleanup (Jiri Denemark) - qemu: Don't leak reference to virQEMUDriverConfigPtr (Jiri Denemark) - rpc: Increase bound limit for virDomainGetJobStats (Jiri Denemark) - LXC: free dst before lxcDomainAttachDeviceDiskLive returns (Chen Hanxiao) - qemu: virDomainControllerFind may return 0 if controller found (Chen Hanxiao) - conf: Don't crash on invalid chardev source definition of RNGs and other (Peter Krempa) - Avoid use of uninitialized data in virnetmessagetest (Daniel P. Berrange) - Avoid crash on OOM in virnetmessagetest (Daniel P. Berrange) - Avoid crash on OOM in virportallocatortest (Daniel P. Berrange) - Avoid crash on OOM in virlockspacetest (Daniel P. Berrange) - Avoid crash on OOM in virbuftest (Daniel P. Berrange) - Avoid uninitialized data in qemuMonitorTestNew (Daniel P. Berrange) - Avoid double free in qemuMonitorCommonTestInit on OOM (Daniel P. Berrange) - Fix leak on OOM in qemuMonitorCommonTestNew (Daniel P. Berrange) - Don't ignore errors parsing nwfilter rules (Daniel P. Berrange) - Fix leak in virLockSpaceResourceFree (Daniel P. Berrange) - Fix leak of parser state in virJSONValueFromString (Daniel P. Berrange) - Fix double-free in virJSONParserHandleStartMap on OOM (Daniel P. Berrange) - Fix leak of iterators in virDBusMessageIterEncode (Daniel P. Berrange) - Fix leak of comment string if virConfAddEntry fails on OOM (Daniel P. Berrange) - Add missing check for OOM with virVMXEscapeHexPipe (Daniel P. Berrange) - Fix crash on OOM parsing storage pool XML (Daniel P. Berrange) - Fix double free of hostdev on OOM in xenParseSxprPCI (Daniel P. Berrange) - Don't clobber 'ret' in LXC XML test case (Daniel P. Berrange) - Fix crash on OOM in virDomainSnapshotDefParse (Daniel P. Berrange) - Don't clobber return value in virInterfaceDefParseProtoIPv6 (Daniel P. Berrange) - Fix handling of OOM when getting Xen dom ID (Daniel P. Berrange) - Fix crash on OOM in xenParseSxpr (Daniel P. Berrange) - virsh-domain: Add a missing check and fix leak in cmdScreenshot (Hongwei Bi) - Fix leak of serial value in xenFormatXM on OOM (Daniel P. Berrange) - Fix broken formatting on OOM in xenFormatXM (Daniel P. Berrange) - Fix crash on OOM in xenParseXM handling consoles (Daniel P. Berrange) - Fix leak of char device in xenParseXM (Daniel P. Berrange) - Fix leak of command line args in qemuParseCommandLine (Daniel P. Berrange) - Fix leak in qemuParseCommandLine on OOM (Daniel P. Berrange) - Fix leak in qemuStringToArgvEnv upon OOM (Daniel P. Berrange) - Fix missing jump to error cleanup in qemuParseCommandLineDisk (Daniel P. Berrange) - Fix leak in qemuParseCommandLineDisk on OOM (Daniel P. Berrange) - Fix leak on OOM in qemuBuildCommandLine dealing with sound card (Daniel P. Berrange) - Fix failure to honour OOM status in qemuParseNBDString (Daniel P. Berrange) - Avoid leak in qemuParseRBDString on failure of qemuAddRBDHost (Daniel P. Berrange) - Fix leak of address string in qemuDomainPCIAddressGetNextSlot (Daniel P. Berrange) - Fix leak in virDomainDefParseXML parsing vcpupin (Daniel P. Berrange) - Fix leak in virDomainVcpuPinDefParseXML parsing cpumask (Daniel P. Berrange) - Avoid leak if virDomainSoundCodecDefParseXML return error (Daniel P. Berrange) - Fix leak in virDomainVcpuPinDefArrayFree (Daniel P. Berrange) - Check return value of virDomainControllerInsert when parsing QEMU args (Daniel P. Berrange) - Honour error returned by virBitmapFormat (Daniel P. Berrange) - Add missing check for OOM when building boot menu args (Daniel P. Berrange) - Fix format specifier for OOM test fprintfs (Daniel P. Berrange) - Always open files in binary mode in virFDStreamOpenFileInternal (Claudio Bley) - Don't ignore allocation failure in virCommandAddEnvPassCommon (Daniel P. Berrange) - Fix reporting of errors in OOM injection code (Daniel P. Berrange) - Fix missing OOM check in qemuParseCommandLine when splitting strings (Daniel P. Berrange) - Fix error checking of qemuParseKeywords return status (Daniel P. Berrange) - Fix allocation of arglist in qemuStringToArgvEnv (Daniel P. Berrange) - Fix crash on OOM in qemuAddRBDHost (Daniel P. Berrange) - Fix crash on OOM in qemuDomainCCWAddressSetCreate() (Daniel P. Berrange) - Fix crash if OOM occurs when creating virConnectPtr (Daniel P. Berrange) - Fix crash on OOM in parsing CPU mask in domain XML (Daniel P. Berrange) - Fix crash on OOM when parsing disk security label (Daniel P. Berrange) - Fix typo in identity code which is pre-requisite for CVE-2013-4311 (Daniel P. Berrange) - Fix potential use of uninitialized value in virDomainGetVcpuPinInfo (Daniel P. Berrange) - qemu: Fix seamless SPICE migration (Martin Kletzander) - Don't dereference NULL in qemumonitorjsontest (Ján Tomko) - Add checking of dbus_message_iter_append_basic return value (Daniel P. Berrange) - qemu: use "ide" as device name for implicit SATA controller on Q35 (Laine Stump) - qemu: Avoid dangling job in qemuDomainSetBlockIoTune (Jiri Denemark) - conf: Don't corrupt metadata on OOM (Peter Krempa) - qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827 (Peter Krempa) - qemu: Use "migratable" XML definition when doing external checkpoints (Peter Krempa) - qemu: Fix checking of ABI stability when restoring external checkpoints (Peter Krempa) - virsh: Fix a wrong check in cmdEcho() (Hongwei Bi) - Always free network and graphics cookies (Ján Tomko) - Free slicename in virSystemdCreateMachine (Ján Tomko) - Fix naming of permission for detecting storage pools (Daniel P. Berrange) - qemu: Fix checking of guest ABI compatibility when reverting snapshots (Peter Krempa) - netcf driver: use a single netcf handle for all connections (Laine Stump) - Fix launching of VMs on when only logind part of systemd is present (Daniel P. Berrange) - Fix polkit permission names for storage pools, vols & node devices (Daniel P. Berrange) - virsh domjobinfo: Do not return 1 if job is NONE (Jiri Denemark) - virDomainDefParseXML: set the argument of virBitmapFree to NULL after calling virBitmapFree (Liuji (Jeremy)) - cpu: Cleanup ppcCompute to avoid memory leak (Li Zhang) - qemu: don't leak vm on failure (Eric Blake) - LXC: Free variable vroot in lxcDomainDetachDeviceHostdevUSBLive() (Hongwei Bi) - qemu: don't leave shutdown inhibited on attach failure (Eric Blake) - libxl: Compile regular expression where it is used (Jim Fehlig) - Don't call regfree() if regcomp() fails (Jim Fehlig) - Use loop-control to allocate loop device. (Ian Main) - LXC: Don't mount securityfs when user namespace enabled (Gao feng) - Stop free'ing 'const char *' strings (Daniel P. Berrange) - conf: Don't deref NULL actual network in virDomainNetGetActualHostdev() (Peter Krempa) - libxl: Check for regcomp failure (Jim Fehlig) - libxl: Fix Coverity warning (Jim Fehlig) - Don't call VIR_ALLOC on def->uuid in parallels storage driver (Daniel P. Berrange) - qemu: Make domain renaming work during migration (Jiri Denemark) - AppArmorSetSecurityImageLabel: Avoid use of uninitialized variable (Michal Privoznik) - build: fix typo that broke 'make dist' (Eric Blake) - esx_driver: Resolve Coverity RESOURCE_LEAK on error paths (John Ferlan) - esx_vi: Resolve Coverity RESOURCE_LEAK in error path (John Ferlan) - test_virtlockd.aug.in: Use the correct file (Michal Privoznik) - virsh-console: Avoid using signal() in multithreaded application (Peter Krempa) - qemu: Handle huge number of queues correctly (Michal Privoznik) - Fix leaks in python bindings (Ján Tomko) - virsh-domain: Avoid killing ssh transport tunnels when cancelling job (Peter Krempa) - qemu: Fix networking for ARM guests (Cole Robinson) - qemu: Don't try to allocate PCI addresses for ARM (Cole Robinson) - Fix AM_LDFLAGS typo (Guido Günther) Improvements: - VMware: Add Fusion version test (Doug Goldstein) - VMware: Support more than 2 driver backends (Doug Goldstein) - Makefile.am: Always include rule to make org.libvirt.api.policy (Michal Privoznik) - event: Make debug message match function comments (Doug Goldstein) - lxc: fix a warning typo in virLXCControllerEventSend (Chen Hanxiao) - Distribute check-aclperms.pl (Guido Günther) - conf: clean up virDomainChrSourceDefParseXML (Peter Krempa) - spec: Clean up distribution of ChangeLog (and others) (Cole Robinson) - test: Allow specifying object runstate in driver XML (Cole Robinson) - Don't print all test suite errors to stderr in vmx2xmltest (Daniel P. Berrange) - qemu: prefer to put a Q35 machine's dmi-to-pci-bridge at 00:1E.0 (Laine Stump) - qemu: turn if into switch in qemuDomainValidateDevicePCISlotsQ35 (Laine Stump) - qemu: support ich9-intel-hda audio device (Laine Stump) - qemu: replace multiple strcmps with a switch on an enum (Laine Stump) - qemu: allow some PCI devices to be attached to PCIe slots (Laine Stump) - qemu: eliminate redundant if clauses in qemuCollectPCIAddress (Laine Stump) - bridge driver: don't masquerade local subnet broadcast/multicast packets (Laszlo Ersek) - util/viriptables: add/remove rules that short-circuit masquerading (Laszlo Ersek) - qemu: Wire up better early error reporting (Peter Krempa) - qemu: monitor: Produce better errors on monitor hangup (Peter Krempa) - qemu: monitor: Add infrastructure to access VM logs for better err msgs (Peter Krempa) - qemu_process: Make qemuProcessReadLog() more versatile and reusable (Peter Krempa) - maint: update to latest gnulib (Eric Blake) - test: fix call to virFDStreamOpenFile in testDomainScreenshot (Claudio Bley) - Add test case for virNetServerClient object identity code (Daniel P. Berrange) - Add a virNetSocketNewConnectSockFD method (Daniel P. Berrange) - python: add bindings for virConnectGetCPUModelNames (Giuseppe Scrivano) - virsh: add function to get the CPU models for an arch (Giuseppe Scrivano) - virConnectGetCPUModelNames: add the support for the test protocol (Giuseppe Scrivano) - virConnectGetCPUModelNames: add the support for qemu (Giuseppe Scrivano) - virConnectGetCPUModelNames: implement the remote protocol (Giuseppe Scrivano) - cpu: add function to get the models for an arch (Giuseppe Scrivano) - build: ensure 'make check' sees up-to-date config.h (Eric Blake) - docs: Load libvirt_access*.xml from build dir (Jiri Denemark) - LXC: Check the existence of dir before resolving symlinks (Chen Hanxiao) - LXC: follow the unit style of /proc/meminfo (Chen Hanxiao) - conf: Do better job when comparing features ABI compatibility (Peter Krempa) - VMware: Make version parsing testable and add tests (Doug Goldstein) - VMware: Store vmrun binary's path in the driver (Doug Goldstein) - VMware: Convert driver type defines to enum (Doug Goldstein) - virsh: add missing "async" option in opts_block_commit (Simone Gotti) - qemumonitorjsontest: Introduce DO_TEST_SIMPLE (Michal Privoznik) - qemumonitorjsontest: Test CPU state handling code (Michal Privoznik) - daemon: Remove more hardcoded paths from help output (Christophe Fergeau) - Fix LIBVIRTD_CONFIGURATION_FILE constant (Christophe Fergeau) - Ensure system identity includes process start time (Daniel P. Berrange) - Also store user & group ID values in virIdentity (Daniel P. Berrange) - daemon: Don't hardcode pki paths in help output (Christophe Fergeau) - daemon: Fix 'caert.pem' typo in privileged help output (Christophe Fergeau) - virsh: Add vshCompleter to each option (Tomas Meszaros) - Add forwarder attribute to <dns/> element (Diego Woitasen) - VMX: Add a VMWare Fusion 5 configuration for tests (Doug Goldstein) - VMX: Add support for 'auto detect' fileNames (Doug Goldstein) - Allow <source> for type=block to have no dev (Doug Goldstein) - maint: ignore recently-added test (Eric Blake) - tests: metadatatest: Quiesce errors on expected paths (Peter Krempa) - test: Refactor setting of dummy error handlers (Peter Krempa) - Add tftp protocol support for cdrom disk (Aline Manera) - Add ftps protocol support for cdrom disk (Aline Manera) - Add https protocol support for cdrom disk (Aline Manera) - tests: Add metadata tests (Peter Krempa) - test: Add <metadata> support into the test driver (Peter Krempa) - lxc: Add metadata modification APIs (Peter Krempa) - lib: Don't force the key argument when deleting metadata (Peter Krempa) - conf: allow to add XML metadata using the virDomainSetMetadata api (Peter Krempa) - conf: Add support for requesting of XML metadata via the API (Peter Krempa) - virsh-domain: Add command to allow modifications of XML metadata (Peter Krempa) - virsh-domain: use virXMLNodeToString instead of xmlNodeDump (Peter Krempa) - util: Add helper to convert libxml2 nodes to a string (Peter Krempa) - conf: Factor out setting of metadata to simplify code (Peter Krempa) - qemu: Factor out body of qemuDomainSetMetadata for universal use (Peter Krempa) - qemu: Factor out body of qemuDomainGetMetadata for universal use (Peter Krempa) - virsh-domain: Line up signal names array (Peter Krempa) - virsh-domain: Remove spurious ATTRIBUTE_UNUSED from cmdDesc (Peter Krempa) - Allow LUN type disks to have no source (Doug Goldstein) - cgroup: Move [qemu|lxc]GetCpuBWStatus to vicgroup.c and refactor it (Peter Krempa) - cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists() (Peter Krempa) - util: Declare that virFileExists shall honor errno (Peter Krempa) - virsh: move command maxvcpus from domain group to host group. (yangdongsheng) - tools: add missing 'interface' type and update man page (Alex Jia) - tests: Don't test user config file if ran as root (Martin Kletzander) - test-lib: Make case skipping possible (Martin Kletzander) - LXC: don't try to mount selinux filesystem when user namespace enabled (Gao feng) - rename "struct interface_driver" to virNetcfDriverState (Laine Stump) - Ensure root filesystem is recursively mounted readonly (Daniel P. Berrange) - Move array of mounts out of lxcContainerMountBasicFS (Daniel P. Berrange) - Fix virsystemdtest for previous commit (Daniel P. Berrange) - DBus: introduce virDBusIsServiceEnabled (Gao feng) - LXC: introduce lxcContainerUnmountForSharedRoot (Gao feng) - LXC: umount the temporary filesystem created by libvirt (Gao feng) - Add test for the nodemask double free crash (Ján Tomko) - Fix cgroups when all are mounted on /sys/fs/cgroup (Daniel P. Berrange) - qemu: endjob returns a bool (Eric Blake) - build: use automake subdir-objects (Eric Blake) - tests: check remaining .x files (Eric Blake) - build: use library rather than cross-directory compilation (Eric Blake) - build: avoid $(srcdir) in *_SOURCES (Eric Blake) - Add ARM v7 big-endian architecture (armv7b) (Yogesh Tillu) - qemu: avoid users specifying CPU features for non-x86 plaftorm. (Li Zhang) - qemu: recognize -machine accel=kvm when parsing native (Eric Blake) - qemu: only parse basename when determining emulator properties (Eric Blake) - spec: make client-only testing easier (Eric Blake) - build: shut up automake warnings (Eric Blake) - Change 'shortforward' to bool. (Ján Tomko) - Add '<nat>' element to '<forward>' network schemas (Ján Tomko) - cpu: Add cpu test cases for PPC CPU driver. (Li Zhang) - cpu: Implement guestData and update for PPC (Li Zhang) - qemu: Remove CPU features functions calling for non-x86 platform. (Li Zhang) - Stop calling virAllocN directly from ESX code (Daniel P. Berrange) - virDomainDeviceIsUSB: Drop check for USB controller (Liuji (Jeremy)) - Ensure 'arch' is always set in cpuArchNodeData (Daniel P. Berrange) - qemu: simplify list cleanup (Eric Blake) - libxl: Unconditionally call virSysinfoRead() on driver init (Jim Fehlig) - spec: default vbox according to libvirtd build (Eric Blake) - build: only install nwfilter examples when building nwfilter (Eric Blake) - build: only run fdstreamtest when libvirtd is built (Eric Blake) - virGet{User,Group}Ent() don't say success on fail (Doug Goldstein) - build: enforce makefile conditional style (Eric Blake) - Add missing 'libvirt_lxc_api' variable in pkg-config file (Daniel P. Berrange) - Fix coding style issues in daemon/remote.c (Nehal J Wani) - conf: Remove the actual hostdev when removing a network (Peter Krempa) - libxl: Use standard format for source file copyright notice (Jim Fehlig) - libxl: Add libxlDomObjFromDomain (Jim Fehlig) - libxl: Remove unnecessary driver locking (Jim Fehlig) - libxl: Move driver lock/unlock to libxl_conf (Jim Fehlig) - libxl: Add comments to libxlDriverPrivate fields (Jim Fehlig) - libxl: Use atomic ops for driver->nactive (Jim Fehlig) - libxl: Introduce libxlDriverConfig object (Jim Fehlig) - libxl: User per-domain ctx in libxlDomainGetInfo (Jim Fehlig) - libxl: libxl: Use per-domain ctx in libxlMakeDomCreateInfo (Jim Fehlig) - libxl: Add libxl_version_info to libxlDriverPrivate (Jim Fehlig) - libxl: Earlier detection of not running on Xen (Jim Fehlig) - libxl: Introduce libxl_domain.[ch] (Jim Fehlig) - libxl: Move detection of autoballoon to libxl_conf (Jim Fehlig) - virsh: Rename vshMakeStdinRaw to vshTTYMakeRaw and move it to virsh.c (Peter Krempa) - tools: rename console.[ch] to virsh-console.[ch] and fix coding style (Peter Krempa) - virsh: Remember terminal state when starting and add helpers (Peter Krempa) - VMX: Add cdrom-raw dev type from VMWare Fusion (Doug Goldstein) - VMX: Some serial ports are not actually connected (Doug Goldstein) - qemu: Support virtio-mmio transport for virtio on ARM (Cole Robinson) - domain_conf: Add disk bus=sd, wire it up for qemu (Cole Robinson) - qemu: Fix specifying char devs for ARM (Cole Robinson) - qemu: Don't add default memballoon device on ARM (Cole Robinson) - domain_conf: Add default memballoon in PostParse callbacks (Cole Robinson) - qemu: Set QEMU_AUDIO_DRV=none with -nographic (Cole Robinson) - Pass AM_LDFLAGS to driver modules too (Guido Günther) - qemu: Support setting the 'removable' flag for USB disks (Fred A. Kemp) - qemu: Add capability flag for usb-storage (Fred A. Kemp) - VMX: Create virVMXFormatDisk() from HD and CD-ROM (Doug Goldstein) Cleanup: - daemon: Avoid dead code in polkit auth (Jiri Denemark) So thanks everybody for your contributions, with code, comments, reports, documentation or fixes, and of course our localizations from Fedora Transifex team ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] FreeBSD-8.3 build failure for amd64/i386, build archive included
by Jason Helfman 01 Oct '13

01 Oct '13

Libvirt no longer builds on FreeBSD 8.3. I had brought this up awhile ago, but didn't have the resources to get the requested information. A fellow committer was able to build, and send me an archive of the complete build failure for analysis. Here is a link to build archive for investigation. http://people.freebsd.org/~jgh/files/libvirt_83amd64.tar.xz Please let me know if there is any information you need. Thanks! -jgh -- Jason Helfman | FreeBSD Committer jgh(a)FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve

5 12

[libvirt] [PATCH] VMware: Add Fusion version test
by Doug Goldstein 01 Oct '13

01 Oct '13

This adds a test for the version string of VMware Fusion. --- Not sure how but this was dropped from my series adding VMware Fusion that was added prior to 1.1.3-rc2. This should be safe for 1.1.3 and probably encouraged --- tests/vmwareverdata/fusion-5.0.3.txt | 3 +++ tests/vmwarevertest.c | 1 + 2 files changed, 4 insertions(+) create mode 100644 tests/vmwareverdata/fusion-5.0.3.txt diff --git a/tests/vmwareverdata/fusion-5.0.3.txt b/tests/vmwareverdata/fusion-5.0.3.txt new file mode 100644 index 0000000..9fae811 --- /dev/null +++ b/tests/vmwareverdata/fusion-5.0.3.txt @@ -0,0 +1,3 @@ + +VMware Fusion Information: +VMware Fusion 5.0.3 build-1040386 Release diff --git a/tests/vmwarevertest.c b/tests/vmwarevertest.c index f5ccb06..47c250c 100644 --- a/tests/vmwarevertest.c +++ b/tests/vmwarevertest.c @@ -88,6 +88,7 @@ mymain(void) } while (0) DO_TEST("ws", "workstation-7.0.0", 7000000); + DO_TEST("fusion", "fusion-5.0.3", 5000003); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 1.8.1.5

2 2

[libvirt] Entering freeze for libvirt-1.1.3
by Daniel Veillard 01 Oct '13

01 Oct '13

I'm a day late from suggested schedule, but I have now tagged rc1 in git and pushed the tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ My initial testing didn't revealed anything bad, but wider testing is obviously needed, i have heard of problem on FreeBSD by Jason, hopefully we can collect and fix those in time. I will probably make rc2 during the w.e. and depending on news push on Tuesday next week or a bit later the final 1.1.3 thanks for testing and reports ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

9 21

[libvirt] [PATCH 0/4] Introduction of qemucapabilitiestest
by Michal Privoznik 30 Sep '13

30 Sep '13

So far, we are testing our capabilities code only from the --help output. Which is sufficient for ancient qemus, but not sufficient for 99% of qemus, where the QMP is used. So far, only one (example) test case is being added. If the patch set is accepted, we can add much more test cases. Michal Privoznik (4): qemu_capabilities: Introduce virQEMUCapsInitQMPMonitor tests: Learn qemuMonitorTestNew optional greeting qemuMonitorTest: Make check for monitor command match optional tests: Introduce qemucapabilitiestest .gitignore | 1 + src/qemu/qemu_capabilities.c | 144 +- src/qemu/qemu_capabilities.h | 3 + tests/Makefile.am | 12 +- tests/qemucapabilitiesdata/caps_default.caps | 132 ++ tests/qemucapabilitiesdata/caps_default.replies | 2519 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 231 +++ tests/qemuhotplugtest.c | 2 +- tests/qemumonitortestutils.c | 23 +- tests/qemumonitortestutils.h | 5 +- 10 files changed, 2994 insertions(+), 78 deletions(-) create mode 100644 tests/qemucapabilitiesdata/caps_default.caps create mode 100644 tests/qemucapabilitiesdata/caps_default.replies create mode 100644 tests/qemucapabilitiestest.c -- 1.8.1.5

2 11

[libvirt] [PATCH] Fix max stream packet size for old clients
by Daniel P. Berrange 30 Sep '13

30 Sep '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> The libvirtd server pushes data out to clients. It does not know what protocol version the client might have, so must be conservative and use the old payload limits. ie send no more than 256kb of data per packet. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- daemon/stream.c | 2 +- src/rpc/virnetprotocol.x | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/daemon/stream.c b/daemon/stream.c index 87dfaf5..9e36e8a 100644 --- a/daemon/stream.c +++ b/daemon/stream.c @@ -708,7 +708,7 @@ daemonStreamHandleRead(virNetServerClientPtr client, daemonClientStream *stream) { char *buffer; - size_t bufferLen = VIR_NET_MESSAGE_PAYLOAD_MAX; + size_t bufferLen = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret; VIR_DEBUG("client=%p, stream=%p tx=%d closed=%d", diff --git a/src/rpc/virnetprotocol.x b/src/rpc/virnetprotocol.x index 131e40b..1eae7cb 100644 --- a/src/rpc/virnetprotocol.x +++ b/src/rpc/virnetprotocol.x @@ -50,6 +50,13 @@ */ const VIR_NET_MESSAGE_INITIAL = 65536; +/* + * Until we enlarged the message buffers, this was the max + * payload size. We need to remember this for compat with + * old clients. + */ +const VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX = 262144; + /* Maximum total message size (serialised). */ const VIR_NET_MESSAGE_MAX = 16777216; -- 1.8.3.1

2 1

Re: [libvirt] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID
by Eduardo Habkost 30 Sep '13

30 Sep '13

On Tue, Sep 24, 2013 at 01:04:14PM +0300, Gleb Natapov wrote: > On Tue, Sep 24, 2013 at 11:57:00AM +0200, Borislav Petkov wrote: > > On Mon, September 23, 2013 6:28 pm, Eduardo Habkost wrote: > > > On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote: > > >> From: Borislav Petkov <bp(a)suse.de> > > >> > > >> Add a kvm ioctl which states which system functionality kvm emulates. > > >> The format used is that of CPUID and we return the corresponding CPUID > > >> bits set for which we do emulate functionality. > > > > > > Let me check if I understood the purpose of the new ioctl correctly: the > > > only reason for GET_EMULATED_CPUID to exist is to allow userspace to > > > differentiate features that are native or that are emulated efficiently > > > (GET_SUPPORTED_CPUID) and features that are emulated not very > > > efficiently (GET_EMULATED_CPUID)? > > > > Not only that - emulated features are not reported in CPUID so they > > can be enabled only when specifically and explicitly requested, i.e. > > "+movbe". Basically, you want to emulate that feature for the guest but > > only for this specific guest - the others shouldn't see it. Then we may have a problem: some CPU models already have "movbe" included (e.g. Haswell), and patch 6/6 will make "-cpu Haswell" get movbe enabled even if it is being emulated. So if we really want to avoid enabling emulated features by mistake, we may need a new CPU flag in addition to "enforce" to tell QEMU that it is OK to enable emulated features (maybe "-cpu ...,emulate"?). > > > > > If that's the case, how do we decide how efficient emulation should be, > > > to deserve inclusion in GET_SUPPORTED_CPUID? I am guessing that the > > > criterion will be: if enabling it doesn't risk making performance worse, > > > it can get in GET_SUPPORTED_CPUID. > > > > Well, in the MOVBE case, supported means, the host can execute this > > instruction natively. Now, you guys say you can emulate x2apic very > > efficiently and I'm guessing emulating x2apic doesn't bring any > > emulation overhead, thus SUPPORTED_CPUID. > x2apic emulation has nothing to do with x2apic in a host. It is emulated > same way no matter if host has it or not. x2apic is not really cpu > feature, but apic one and apic is fully emulated by KVM anyway. But my question still stands: suppose we had x2apic emulation implemented but for some reason it was painfully slow, we wouldn't want to enable it by mistake. In this case, it would end up on EMULATED_CPUID and not on SUPPORTED_CPUID, right? > > > > > But for single instructions or group of instructions, the distinction > > should be very clear. > > > > At least this is how I see it but Gleb probably can comment too. > > > That's how I see it two. Basically you want to use movbe emulation (as > opposite of virtualization) only if you have binary kernel that compiled > for CPU with movbe (Borislav's use case), or you want to migrate > temporarily from movbe enabled host to non movbe host because downtime > is not an option. We should avoid enabling it "by mistake". "we should avoid enabling it 'by mistake'" sounds like a good criterion for including something on GET_EMULATED_CPUID instead of GET_SUPPORTED_CPUID. In that case, I believe QEMU should use GET_EMULATED_CPUID only if explicitly requested in the configuration/command-line (that's not what patch 6/6 does). -- Eduardo

2 7

[libvirt] [PATCH] LXC: workaround machined uncleaned data with containers running systemd.
by Cédric Bosdonnat 30 Sep '13

30 Sep '13

The problem is described by [0] but its effect on libvirt is that starting a container with a full distro running systemd after having stopped it simply fails. The container cleanup now calls the machined Terminate function to make sure that everything is in order for the next run. [0]: https://bugs.freedesktop.org/show_bug.cgi?id=68370 --- src/libvirt_private.syms | 2 ++ src/lxc/lxc_process.c | 8 +++++ src/util/virsystemd.c | 80 +++++++++++++++++++++++++++++++++++++++++------- src/util/virsystemd.h | 8 +++++ tests/virsystemdtest.c | 28 +++++++++++++++++ 6 files changed, 117 insertions(+), 12 deletions(-) 2nd version: * Removed the Makefile hack and added symbols to libvirt_private.syms instead * Added virSystemdMakeMachineName to factorize some code in Make and Terminate machine systemd functions. * Added tests for TerminateMachine and TerminateContainer cases. diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 48e4b04..4bc4d69 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1947,8 +1947,10 @@ virSysinfoSetup; # util/virsystemd.h virSystemdCreateMachine; +virSystemdMakeMachineName; virSystemdMakeScopeName; virSystemdMakeSliceName; +virSystemdTerminateMachine; # util/virthread.h diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 4835bd5..f92c613 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -50,6 +50,7 @@ #include "virstring.h" #include "viratomic.h" #include "virprocess.h" +#include "virsystemd.h" #define VIR_FROM_THIS VIR_FROM_LXC @@ -210,6 +211,13 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver, virCgroupFree(&priv->cgroup); } + /* Get machined to terminate the machine as it may not have cleaned it + * properly. See https://bugs.freedesktop.org/show_bug.cgi?id=68370 for + * the bug we are working around here. + */ + virSystemdTerminateMachine(vm->def->name, "lxc", true); + + /* now that we know it's stopped call the hook if present */ if (virHookPresent(VIR_HOOK_DRIVER_LXC)) { char *xml = virDomainDefFormat(vm->def, 0); diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index e72b7f0..1ba37cc 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -116,6 +116,27 @@ char *virSystemdMakeSliceName(const char *partition) return virBufferContentAndReset(&buf); } +char *virSystemdMakeMachineName(const char *name, + const char *drivername, + bool privileged) +{ + char *machinename = NULL; + char *username = NULL; + if (privileged) { + if (virAsprintf(&machinename, "%s-%s", drivername, name) < 0) + goto cleanup; + } else { + if (!(username = virGetUserName(geteuid()))) + goto cleanup; + if (virAsprintf(&machinename, "%s-%s-%s", username, drivername, name) < 0) + goto cleanup; + } + +cleanup: + VIR_FREE(username); + + return machinename; +} /** * virSystemdCreateMachine: @@ -142,7 +163,6 @@ int virSystemdCreateMachine(const char *name, DBusConnection *conn; char *machinename = NULL; char *creatorname = NULL; - char *username = NULL; char *slicename = NULL; ret = virDBusIsServiceEnabled("org.freedesktop.machine1"); @@ -152,15 +172,8 @@ int virSystemdCreateMachine(const char *name, conn = virDBusGetSystemBus(); ret = -1; - if (privileged) { - if (virAsprintf(&machinename, "%s-%s", drivername, name) < 0) - goto cleanup; - } else { - if (!(username = virGetUserName(geteuid()))) - goto cleanup; - if (virAsprintf(&machinename, "%s-%s-%s", username, drivername, name) < 0) - goto cleanup; - } + if (!(machinename = virSystemdMakeMachineName(name, drivername, privileged))) + goto cleanup; if (virAsprintf(&creatorname, "libvirt-%s", drivername) < 0) goto cleanup; @@ -236,9 +249,54 @@ int virSystemdCreateMachine(const char *name, ret = 0; cleanup: - VIR_FREE(username); VIR_FREE(creatorname); VIR_FREE(machinename); VIR_FREE(slicename); return ret; } + +int virSystemdTerminateMachine(const char *name, + const char *drivername, + bool privileged) +{ + int ret; + DBusConnection *conn; + char *machinename = NULL; + + ret = virDBusIsServiceEnabled("org.freedesktop.machine1"); + if (ret < 0) + return ret; + + conn = virDBusGetSystemBus(); + + ret = -1; + if (!(machinename = virSystemdMakeMachineName(name, drivername, privileged))) + goto cleanup; + + /* + * The systemd DBus API we're invoking has the + * following signature + * + * TerminateMachine(in s name); + * + * @name a host unique name for the machine. shows up + * in 'ps' listing & similar + */ + + VIR_DEBUG("Attempting to terminate machine via systemd"); + if (virDBusCallMethod(conn, + NULL, + "org.freedesktop.machine1", + "/org/freedesktop/machine1", + "org.freedesktop.machine1.Manager", + "TerminateMachine", + "s", + machinename) < 0) + goto cleanup; + + ret = 0; + +cleanup: + VIR_FREE(machinename); + return ret; +} diff --git a/src/util/virsystemd.h b/src/util/virsystemd.h index 414ae5a..d9845e1 100644 --- a/src/util/virsystemd.h +++ b/src/util/virsystemd.h @@ -29,6 +29,10 @@ char *virSystemdMakeScopeName(const char *name, const char *slicename); char *virSystemdMakeSliceName(const char *partition); +char *virSystemdMakeMachineName(const char *name, + const char *drivername, + bool privileged); + int virSystemdCreateMachine(const char *name, const char *drivername, bool privileged, @@ -38,4 +42,8 @@ int virSystemdCreateMachine(const char *name, bool iscontainer, const char *partition); +int virSystemdTerminateMachine(const char *name, + const char *drivername, + bool privileged); + #endif /* __VIR_SYSTEMD_H__ */ diff --git a/tests/virsystemdtest.c b/tests/virsystemdtest.c index e68b3ac..e6efebf 100644 --- a/tests/virsystemdtest.c +++ b/tests/virsystemdtest.c @@ -54,6 +54,18 @@ static int testCreateContainer(const void *opaque ATTRIBUTE_UNUSED) return 0; } +static int testTerminateContainer(const void *opaque ATTRIBUTE_UNUSED) +{ + if (virSystemdTerminateMachine("demo", + "lxc", + true) < 0) { + fprintf(stderr, "%s", "Failed to terminate LXC machine\n"); + return -1; + } + + return 0; +} + static int testCreateMachine(const void *opaque ATTRIBUTE_UNUSED) { unsigned char uuid[VIR_UUID_BUFLEN] = { @@ -77,6 +89,18 @@ static int testCreateMachine(const void *opaque ATTRIBUTE_UNUSED) return 0; } +static int testTerminateMachine(const void *opaque ATTRIBUTE_UNUSED) +{ + if (virSystemdTerminateMachine("demo", + "qemu", + false) < 0) { + fprintf(stderr, "%s", "Failed to terminate KVM machine\n"); + return -1; + } + + return 0; +} + static int testCreateNoSystemd(const void *opaque ATTRIBUTE_UNUSED) { unsigned char uuid[VIR_UUID_BUFLEN] = { @@ -184,8 +208,12 @@ mymain(void) if (virtTestRun("Test create container ", 1, testCreateContainer, NULL) < 0) ret = -1; + if (virtTestRun("Test terminate container ", 1, testTerminateContainer, NULL) < 0) + ret = -1; if (virtTestRun("Test create machine ", 1, testCreateMachine, NULL) < 0) ret = -1; + if (virtTestRun("Test terminate machine ", 1, testTerminateMachine, NULL) < 0) + ret = -1; if (virtTestRun("Test create no systemd ", 1, testCreateNoSystemd, NULL) < 0) ret = -1; if (virtTestRun("Test create bad systemd ", 1, testCreateBadSystemd, NULL) < 0) -- 1.8.4

2 1

[libvirt] [PATCH v2] virsh-domain: Free dom before return false in cmdDump
by Hongwei Bi 30 Sep '13

30 Sep '13

--- tools/virsh-domain.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8538125..fa012d1 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4488,7 +4488,7 @@ cmdDump(vshControl *ctl, const vshCmd *cmd) return false; if (vshCommandOptStringReq(ctl, cmd, "file", &to) < 0) - return false; + goto cleanup; if (vshCommandOptBool(cmd, "verbose")) verbose = true; -- 1.7.1

2 2

[libvirt] [PATCH v2] virsh-volume: Add missing check when calling virStreamNew
by Hongwei Bi 30 Sep '13

30 Sep '13

Check return value of virStreamNew when called by cmdVolUpload and cmdVolDownload. --- tools/virsh-volume.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 7dab532..0a66a6c 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -665,7 +665,11 @@ cmdVolUpload(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - st = virStreamNew(ctl->conn, 0); + if (!(st = virStreamNew(ctl->conn, 0))) { + vshError(ctl, _("cannot create a new stream")); + goto cleanup; + } + if (virStorageVolUpload(vol, st, offset, length, 0) < 0) { vshError(ctl, _("cannot upload to volume %s"), name); goto cleanup; @@ -775,7 +779,11 @@ cmdVolDownload(vshControl *ctl, const vshCmd *cmd) created = true; } - st = virStreamNew(ctl->conn, 0); + if (!(st = virStreamNew(ctl->conn, 0))) { + vshError(ctl, _("cannot create a new stream")); + goto cleanup; + } + if (virStorageVolDownload(vol, st, offset, length, 0) < 0) { vshError(ctl, _("cannot download from volume %s"), name); goto cleanup; -- 1.7.1

2 2

[libvirt] [PATCH v3 0/2] Libvirt Wireshark dissector
by Yuto KAWAMURA(kawamuray) 30 Sep '13

30 Sep '13

From: "Yuto KAWAMURA(kawamuray)" <kawamuray.dadada(a)gmail.com> Changes from version2: * Remove moduleinfo.h * Stop accessing internal XDR struct and just use free() Introduce Wireshark dissector plugin which adds support to Wireshark for dissecting libvirt RPC protocol. This feature was presented by Michal Privoznik year before last[1]. But it did only support dissecting packet headers. This time I enhanced that dissector to support dissecting packet payload. Furthermore, I provide code generator of dissector. So you can get fresh build of dissector from libvirt RPC specification file at any version you like. [1] http://www.redhat.com/archives/libvir-list/2011-October/msg00301.html Yuto KAWAMURA(kawamuray) (2): Introduce Libvirt Wireshark dissector Add sample output of Wireshark dissector Makefile.am | 3 +- cfg.mk | 8 +- configure.ac | 72 +- tools/wireshark/Makefile.am | 29 + tools/wireshark/README.md | 31 + tools/wireshark/samples/libvirt-sample.pdml | 206 ++++++ tools/wireshark/src/.gitignore | 4 + tools/wireshark/src/Makefile.am | 42 ++ tools/wireshark/src/packet-libvirt.c | 512 ++++++++++++++ tools/wireshark/src/packet-libvirt.h | 128 ++++ tools/wireshark/util/genxdrstub.pl | 1009 +++++++++++++++++++++++++++ tools/wireshark/util/make-dissector-reg | 198 ++++++ 12 files changed, 2236 insertions(+), 6 deletions(-) create mode 100644 tools/wireshark/Makefile.am create mode 100644 tools/wireshark/README.md create mode 100644 tools/wireshark/samples/libvirt-sample.pdml create mode 100644 tools/wireshark/src/.gitignore create mode 100644 tools/wireshark/src/Makefile.am create mode 100644 tools/wireshark/src/packet-libvirt.c create mode 100644 tools/wireshark/src/packet-libvirt.h create mode 100755 tools/wireshark/util/genxdrstub.pl create mode 100755 tools/wireshark/util/make-dissector-reg -- 1.8.1.5

2 3

[libvirt] [PATCH] virfile: safezero: align mmap offset to page size
by Oskari Saarenmaa 30 Sep '13

30 Sep '13

mmap's offset must be aligned to page size or mapping will fail. mmap-based safezero is only used if posix_fallocate isn't available. Signed-off-by: Oskari Saarenmaa <os(a)ohmu.fi> --- src/util/virfile.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 20ca89f..16f8101 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1038,9 +1038,16 @@ safezero(int fd, off_t offset, off_t len) int safezero(int fd, off_t offset, off_t len) { + static long pagemask = 0; + off_t map_skip; int r; char *buf; + /* align offset and length, rounding offset down and length up */ + if (pagemask == 0) + pagemask = ~(sysconf(_SC_PAGESIZE) - 1); + map_skip = offset - (offset & pagemask); + /* memset wants the mmap'ed file to be present on disk so create a * sparse file */ @@ -1048,12 +1055,13 @@ safezero(int fd, off_t offset, off_t len) if (r < 0) return -1; - buf = mmap(NULL, len, PROT_READ | PROT_WRITE, MAP_SHARED, fd, offset); + buf = mmap(NULL, len + map_skip, PROT_READ | PROT_WRITE, MAP_SHARED, + fd, offset - map_skip); if (buf == MAP_FAILED) return -1; - memset(buf, 0, len); - munmap(buf, len); + memset(buf + map_skip, 0, len); + munmap(buf, len + map_skip); return 0; } -- 1.8.3.1

2 1

[libvirt] Patch to launch virt-sandbox-containers with correct label.
by Dan Walsh 30 Sep '13

30 Sep '13

[sandbox PATCH] virt-sandbox patch to launch containers with proper

3 4

[libvirt] [PATCH] qemu_migrate: Fix assign the same port when migrating concurrently
by Wangyufei (A) 30 Sep '13

30 Sep '13

>From 6c2de34432db674072231ad66c9e8a0a600ede8a Mon Sep 17 00:00:00 2001 From: WangYufei <james.wangyufei(a)huawei.com> Date: Mon, 30 Sep 2013 11:48:43 +0800 Subject: [PATCH] qemu_migrate: Fix assign the same port when migrating concurrently When we migrate vms concurrently, there's a chance that libvirtd on destination assign the same port for different migrations, which will lead to migration failed during migration prepare phase on destination. So we use virPortAllocator here to solve the problem. Signed-off-by: WangYufei <james.wangyufei(a)huawei.com> --- src/qemu/qemu_command.h | 3 +++ src/qemu/qemu_conf.h | 6 +++--- src/qemu/qemu_driver.c | 6 ++++++ src/qemu/qemu_migration.c | 17 ++++++++++------- 4 files changed, 22 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 2e2acfb..3277ba4 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -51,6 +51,9 @@ # define QEMU_WEBSOCKET_PORT_MIN 5700 # define QEMU_WEBSOCKET_PORT_MAX 65535 +# define QEMU_MIGRATION_PORT_MIN 49152 +# define QEMU_MIGRATION_PORT_MAX 49215 + typedef struct _qemuBuildCommandLineCallbacks qemuBuildCommandLineCallbacks; typedef qemuBuildCommandLineCallbacks *qemuBuildCommandLineCallbacksPtr; struct _qemuBuildCommandLineCallbacks { diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index da29a2a..3176085 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -221,6 +221,9 @@ struct _virQEMUDriver { /* Immutable pointer, self-locking APIs */ virPortAllocatorPtr webSocketPorts; + /* Immutable pointer, self-locking APIs */ + virPortAllocatorPtr migrationPorts; + /* Immutable pointer, lockless APIs*/ virSysinfoDefPtr hostsysinfo; @@ -242,9 +245,6 @@ struct _qemuDomainCmdlineDef { char **env_value; }; -/* Port numbers used for KVM migration. */ -# define QEMUD_MIGRATION_FIRST_PORT 49152 -# define QEMUD_MIGRATION_NUM_PORTS 64 void qemuDomainCmdlineDefFree(qemuDomainCmdlineDefPtr def); diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e8bc04d..9437b5a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -688,6 +688,11 @@ qemuStateInitialize(bool privileged, cfg->webSocketPortMax)) == NULL) goto error; + if ((qemu_driver->migrationPorts = + virPortAllocatorNew(QEMU_MIGRATION_PORT_MIN, + QEMU_MIGRATION_PORT_MAX)) == NULL) + goto error; + if (qemuSecurityInit(qemu_driver) < 0) goto error; @@ -994,6 +999,7 @@ qemuStateCleanup(void) { virObjectUnref(qemu_driver->domains); virObjectUnref(qemu_driver->remotePorts); virObjectUnref(qemu_driver->webSocketPorts); + virObjectUnref(qemu_driver->migrationPorts); virObjectUnref(qemu_driver->xmlopt); diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 3a1aab7..82d90bf 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2493,7 +2493,6 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, const char *origname, unsigned long flags) { - static int port = 0; int this_port; char *hostname = NULL; const char *p; @@ -2521,8 +2520,9 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, * to be a correct hostname which refers to the target machine). */ if (uri_in == NULL) { - this_port = QEMUD_MIGRATION_FIRST_PORT + port++; - if (port == QEMUD_MIGRATION_NUM_PORTS) port = 0; + if (virPortAllocatorAcquire(driver->migrationPorts, + (unsigned short *)&this_port) < 0) + goto cleanup; /* Get hostname */ if ((hostname = virGetHostname()) == NULL) @@ -2578,9 +2578,9 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, if (uri->port == 0) { /* Generate a port */ - this_port = QEMUD_MIGRATION_FIRST_PORT + port++; - if (port == QEMUD_MIGRATION_NUM_PORTS) - port = 0; + if (virPortAllocatorAcquire(driver->migrationPorts, + (unsigned short *)&this_port) < 0) + goto cleanup; /* Caller frees */ if (virAsprintf(uri_out, "%s:%d", uri_in, this_port) < 0) @@ -2600,8 +2600,11 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, cleanup: virURIFree(uri); VIR_FREE(hostname); - if (ret != 0) + if (ret != 0) { VIR_FREE(*uri_out); + virPortAllocatorRelease(driver->migrationPorts, + (unsigned short)this_port); + } return ret; } -- 1.7.3.1.msysgit.0 Best Regards, -WangYufei

2 1

[libvirt] [PATCH v2 0/2] Libvirt Wireshark dissector
by Yuto KAWAMURA(kawamuray) 30 Sep '13

30 Sep '13

From: "Yuto KAWAMURA(kawamuray)" <kawamuray.dadada(a)gmail.com> Introduce Wireshark dissector plugin which adds support to Wireshark for dissecting libvirt RPC protocol. This feature was presented by Michal Privoznik year before last[1]. But it did only support dissecting packet headers. This time I enhanced that dissector to support dissecting packet payload. Furthermore, I provide code generator of dissector. So you can get fresh build of dissector from libvirt RPC specification file at any version you like. [1] http://www.redhat.com/archives/libvir-list/2011-October/msg00301.html Yuto KAWAMURA(kawamuray) (2): Introduce Libvirt Wireshark dissector Add sample output of Wireshark dissector Makefile.am | 3 +- cfg.mk | 6 +- configure.ac | 72 +- tools/wireshark/Makefile.am | 29 + tools/wireshark/README.md | 31 + tools/wireshark/samples/libvirt-sample.pdml | 206 ++++++ tools/wireshark/src/.gitignore | 4 + tools/wireshark/src/Makefile.am | 42 ++ tools/wireshark/src/moduleinfo.h | 37 + tools/wireshark/src/packet-libvirt.c | 513 ++++++++++++++ tools/wireshark/src/packet-libvirt.h | 128 ++++ tools/wireshark/util/genxdrstub.pl | 1010 +++++++++++++++++++++++++++ tools/wireshark/util/make-dissector-reg | 199 ++++++ 13 files changed, 2275 insertions(+), 5 deletions(-) create mode 100644 tools/wireshark/Makefile.am create mode 100644 tools/wireshark/README.md create mode 100644 tools/wireshark/samples/libvirt-sample.pdml create mode 100644 tools/wireshark/src/.gitignore create mode 100644 tools/wireshark/src/Makefile.am create mode 100644 tools/wireshark/src/moduleinfo.h create mode 100644 tools/wireshark/src/packet-libvirt.c create mode 100644 tools/wireshark/src/packet-libvirt.h create mode 100755 tools/wireshark/util/genxdrstub.pl create mode 100755 tools/wireshark/util/make-dissector-reg -- 1.8.1.5

3 5

[libvirt] qemu, numa: non-contiguous cpusets
by Borislav Petkov 30 Sep '13

30 Sep '13

Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example: x86_64-softmmu/qemu-system-x86_64 -smp 8 -numa node,nodeid=0,cpus=0\;2\;4-5 -numa node,nodeid=1,cpus=1\;3\;6-7 The ';' needs to be escaped from the shell but I'm open for better suggestions. Here's a diff: --- diff --git a/vl.c b/vl.c index 4e709d5c1c20..82a6c8451fb0 100644 --- a/vl.c +++ b/vl.c @@ -1261,9 +1261,27 @@ char *get_boot_devices_list(size_t *size) return list; } +static int __numa_set_cpus(unsigned long *map, int start, int end) +{ + if (end >= MAX_CPUMASK_BITS) { + end = MAX_CPUMASK_BITS - 1; + fprintf(stderr, + "qemu: NUMA: A max of %d VCPUs are supported\n", + MAX_CPUMASK_BITS); + return -EINVAL; + } + + if (end < start) { + return -EINVAL; + } + + bitmap_set(map, start, end-start+1); + return 0; +} + static void numa_node_parse_cpus(int nodenr, const char *cpus) { - char *endptr; + char *endptr, *ptr = (char *)cpus; unsigned long long value, endvalue; /* Empty CPU range strings will be considered valid, they will simply @@ -1273,7 +1291,8 @@ static void numa_node_parse_cpus(int nodenr, const char *cpus) return; } - if (parse_uint(cpus, &value, &endptr, 10) < 0) { +fromthetop: + if (parse_uint(ptr, &value, &endptr, 10) < 0) { goto error; } if (*endptr == '-') { @@ -1282,22 +1301,22 @@ static void numa_node_parse_cpus(int nodenr, const char *cpus) } } else if (*endptr == '\0') { endvalue = value; - } else { - goto error; - } + } else if (*endptr == ';') { + if (__numa_set_cpus(node_cpumask[nodenr], value, value) < 0) { + goto error; + } + endptr++; + if (*endptr == '\0') + return; - if (endvalue >= MAX_CPUMASK_BITS) { - endvalue = MAX_CPUMASK_BITS - 1; - fprintf(stderr, - "qemu: NUMA: A max of %d VCPUs are supported\n", - MAX_CPUMASK_BITS); - } + ptr = endptr; - if (endvalue < value) { + goto fromthetop; + } else { goto error; } - bitmap_set(node_cpumask[nodenr], value, endvalue-value+1); + __numa_set_cpus(node_cpumask[nodenr], value, endvalue); return; error: -- Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --

3 4