- Devel - libvirt List Archives

[libvirt] [PATCH 05/12] vshReadlineParse: Ignore vshReadlineOptionsGenerator for VSH_OT_ARGV options
by Lin Ma 04 May '18

04 May '18

Currently the VSH_OT_ARGV options don't support complete, But some of VSH_OT_ARGV options are gonna support complete in upcoming patches. Once applied the upcoming completion patches for VSH_OT_ARGV options, If we don't ignore VSH_OT_ARGV here, The vshReadlineOptionsGenerator will be called, Hence complete output will consist of the result by command completer + the result by option completer, It's confusing. e.g. $ virsh domstats --domain <TAB><TAB> --backing --interface --list-paused --perf --vcpu --balloon leap42.3 --list-persistent --raw win10 --block --list-active --list-running sles12sp3 --cpu-total --list-inactive --list-shutoff sles15 --enforce --list-other --list-transient --state After this patch and the upcoming completion patches: $ virsh domstats --domain <TAB><TAB> leap42.3 sles12sp3 sles15 win10 Signed-off-by: Lin Ma <lma(a)suse.com> --- tools/vsh.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 38058c874a..5a9916cbb0 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2824,7 +2824,9 @@ vshReadlineParse(const char *text, int state) if (!cmd) { list = vshReadlineCommandGenerator(text); } else { - if (!opt || (opt->type != VSH_OT_DATA && opt->type != VSH_OT_STRING)) + if (!opt || (opt->type != VSH_OT_DATA && + opt->type != VSH_OT_STRING && + opt->type != VSH_OT_ARGV)) list = vshReadlineOptionsGenerator(text, cmd, partial); if (opt && opt->completer) { -- 2.15.1

1 0

[libvirt] [PATCH 04/12] virsh: Apply macro for current VSH_OT_STRING "domain" options
by Lin Ma 04 May '18

04 May '18

These VSH_OT_STRING "domain" options support domain name completion now. Signed-off-by: Lin Ma <lma(a)suse.com> --- tools/virsh-domain.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8a63761fab..689f9d686b 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9601,10 +9601,8 @@ static const vshCmdInfo info_qemu_monitor_event[] = { }; static const vshCmdOptDef opts_qemu_monitor_event[] = { - {.name = "domain", - .type = VSH_OT_STRING, - .help = N_("filter by domain name, id or uuid") - }, + VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("filter by domain name, id or uuid"), + 0), {.name = "event", .type = VSH_OT_STRING, .help = N_("filter by event name") @@ -10157,11 +10155,7 @@ static const vshCmdOptDef opts_domxmltonative[] = { .flags = VSH_OFLAG_REQ, .help = N_("target config data type format") }, - {.name = "domain", - .type = VSH_OT_STRING, - .flags = VSH_OFLAG_REQ_OPT, - .help = N_("domain name, id or uuid") - }, + VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(0), {.name = "xml", .type = VSH_OT_STRING, .help = N_("xml data file to export from") @@ -13348,10 +13342,8 @@ static const vshCmdInfo info_event[] = { }; static const vshCmdOptDef opts_event[] = { - {.name = "domain", - .type = VSH_OT_STRING, - .help = N_("filter by domain name, id, or uuid") - }, + VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("filter by domain name, id or uuid"), + 0), {.name = "event", .type = VSH_OT_STRING, .help = N_("which event type to wait for") -- 2.15.1

1 0

[libvirt] [PATCH 01/12] virsh: Add domain name completion to 'migrate-postcopy' command
by Lin Ma 04 May '18

04 May '18

Signed-off-by: Lin Ma <lma(a)suse.com> --- tools/virsh-domain.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2b775fc4cc..6601f94a12 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11219,11 +11219,7 @@ static const vshCmdInfo info_migrate_postcopy[] = { }; static const vshCmdOptDef opts_migrate_postcopy[] = { - {.name = "domain", - .type = VSH_OT_DATA, - .flags = VSH_OFLAG_REQ, - .help = N_("domain name, id or uuid") - }, + VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = NULL} }; -- 2.15.1

1 0

[libvirt] [sandbox PATCH] maint: Drop autobuild.sh
by Andrea Bolognani 04 May '18

04 May '18

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-sandbox CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1] https://ci.centos.org/view/libvirt/ Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- autobuild.sh | 71 ------------------------------------------------------------ 1 file changed, 71 deletions(-) delete mode 100755 autobuild.sh diff --git a/autobuild.sh b/autobuild.sh deleted file mode 100755 index c176fea..0000000 --- a/autobuild.sh +++ /dev/null @@ -1,71 +0,0 @@ -#!/bin/sh - -set -e -set -v - -# Make things clean. -test -n "$1" && RESULTS=$1 || RESULTS=results.log -: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} - -test -f Makefile && make -k distclean || : - -rm -rf build -mkdir build -cd build - -../autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT \ - --enable-gtk-doc - -make -make install - -# set -o pipefail is a bashism; this use of exec is the POSIX alternative -exec 3>&1 -st=$( - exec 4>&1 >&3 - { make check syntax-check 2>&1 3>&- 4>&-; echo $? >&4; } | tee "$RESULTS" -) -exec 3>&- -test "$st" = 0 - -rm -f *.tar.gz -make dist - -if [ -n "$AUTOBUILD_COUNTER" ]; then - EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" -else - NOW=`date +"%s"` - EXTRA_RELEASE=".$USER$NOW" -fi - -if [ -f /usr/bin/rpmbuild ]; then - rpmbuild --nodeps \ - --define "extra_release $EXTRA_RELEASE" \ - --define "_sourcedir `pwd`" \ - -ba --clean libvirt-sandbox.spec -fi - -exit 0 -if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then - make distclean - - PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig" \ - CC="i686-pc-mingw32-gcc" \ - ../configure \ - --build=$(uname -m)-pc-linux \ - --host=i686-pc-mingw32 \ - --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" - - make - make install - - #set -o pipefail - #make check 2>&1 | tee "$RESULTS" - - if [ -f /usr/bin/rpmbuild ]; then - rpmbuild --nodeps \ - --define "extra_release $EXTRA_RELEASE" \ - --define "_sourcedir `pwd`" \ - -ba --clean mingw32-libvirt-sandbox.spec - fi -fi -- 2.14.3

2 5

[libvirt] [PATCH v3 0/6] Add support for VM Generation ID (vmgenid)
by John Ferlan 04 May '18

04 May '18

v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2: * Essentially handle comments from code review of original series from comments received for patch 6: https://www.redhat.com/archives/libvir-list/2018-April/msg02240.html It's a somewhat simplified approach removing the ABI checks and the adjustment to the genid value as part of domain def copy. * (NEW) Patch 5 - add a 'genid' domain capability (similar to how Cole added support for vmcoreinfo). Since the apps need a way to determine whether this is enabled, this seems to be the best way. John Ferlan (6): conf: Add VM Generation ID parse/format support qemu: Add VM Generation ID device capability qemu: Alter VM Generation ID for specific startup/launch transitions qemu: Add VM Generation ID to qemu command line domcaps: Add 'genid' to domain capabilities docs: Add news article for VM Generation ID docs/formatdomain.html.in | 27 +++++++++++ docs/formatdomaincaps.html.in | 7 ++- docs/news.xml | 13 ++++++ docs/schemas/domaincaps.rng | 7 +++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_capabilities.c | 3 ++ src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 54 ++++++++++++++++++++++ src/conf/domain_conf.h | 5 ++ src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 24 ++++++++++ src/qemu/qemu_driver.c | 17 +++++-- src/qemu/qemu_process.c | 46 +++++++++++++++++- src/qemu/qemu_process.h | 1 + tests/domaincapsschemadata/basic.xml | 1 + tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenfv.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argvdata/genid-auto.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid-auto.xml | 32 +++++++++++++ tests/qemuxml2argvdata/genid.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid.xml | 32 +++++++++++++ tests/qemuxml2argvtest.c | 4 ++ tests/qemuxml2xmloutdata/genid-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmltest.c | 5 +- 53 files changed, 500 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/genid-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid-auto.xml create mode 100644 tests/qemuxml2argvdata/genid.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid.xml create mode 100644 tests/qemuxml2xmloutdata/genid-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-inactive.xml create mode 100644 tests/qemuxml2xmloutdata/genid-inactive.xml -- 2.14.3

1 6

[libvirt] [PATCH] tests: domaincapstest: Fix after iothreads addition
by Cole Robinson 04 May '18

04 May '18

Introduced in 8525b9694. Some files weren't updated. I'm just guessing on the bhyve ones Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- Pushes as a build breaker tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + 5 files changed, 5 insertions(+) diff --git a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml index 70e36e97e9..055d05b568 100644 --- a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml +++ b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml @@ -2,6 +2,7 @@ <path>/usr/sbin/bhyve</path> <domain>bhyve</domain> <arch>x86_64</arch> + <iothreads supported='no'/> <os supported='yes'> <loader supported='no'/> </os> diff --git a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml index 19b76da456..b22ca43ba0 100644 --- a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml +++ b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml @@ -2,6 +2,7 @@ <path>/usr/sbin/bhyve</path> <domain>bhyve</domain> <arch>x86_64</arch> + <iothreads supported='no'/> <os supported='yes'> <loader supported='yes'> <value>/foo/bar</value> diff --git a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml index c278df038a..625a55e70c 100644 --- a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml +++ b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml @@ -2,6 +2,7 @@ <path>/usr/sbin/bhyve</path> <domain>bhyve</domain> <arch>x86_64</arch> + <iothreads supported='no'/> <os supported='yes'> <loader supported='yes'> <value>/foo/bar</value> diff --git a/tests/domaincapsschemadata/libxl-xenfv-usb.xml b/tests/domaincapsschemadata/libxl-xenfv-usb.xml index dfa992cb71..3f245e8961 100644 --- a/tests/domaincapsschemadata/libxl-xenfv-usb.xml +++ b/tests/domaincapsschemadata/libxl-xenfv-usb.xml @@ -4,6 +4,7 @@ <machine>xenfv</machine> <arch>x86_64</arch> <vcpu max='128'/> + <iothreads supported='no'/> <os supported='yes'> <loader supported='yes'> <value>/usr/lib/xen/boot/hvmloader</value> diff --git a/tests/domaincapsschemadata/libxl-xenpv-usb.xml b/tests/domaincapsschemadata/libxl-xenpv-usb.xml index 8277a9efdd..2bcd588c0f 100644 --- a/tests/domaincapsschemadata/libxl-xenpv-usb.xml +++ b/tests/domaincapsschemadata/libxl-xenpv-usb.xml @@ -4,6 +4,7 @@ <machine>xenpv</machine> <arch>x86_64</arch> <vcpu max='512'/> + <iothreads supported='no'/> <os supported='yes'> <loader supported='no'/> </os> -- 2.17.0

2 2

[libvirt] [PATCH 0/3] conf: <vmcoreinfo> tweaks
by Cole Robinson 03 May '18

03 May '18

Patch #1 changes the vmcoreinfo XML schema slightly to be more future proof, this is technically an API break but I'm not sure it matters, see the patch for more details. Patch #3 adds vmcoreinfo reporting to domain capabilities. The schema doesn't follow the typical pattern so if anyone has other ideas please comment Cole Robinson (3): conf: format/parse <vmcoreinfo> as tristate conf: Add a comment warning about boolean feature XML domain_capabilities: Report <vmcoreinfo> support docs/formatdomaincaps.html.in | 5 +++++ docs/schemas/domaincaps.rng | 7 +++++++ docs/schemas/domaincommon.rng | 6 +++++- src/conf/domain_capabilities.c | 2 ++ src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 6 ++++-- src/qemu/qemu_capabilities.c | 3 +++ tests/domaincapsschemadata/basic.xml | 1 + tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenfv.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + tests/qemuxml2xmloutdata/vmcoreinfo.xml | 2 +- 33 files changed, 53 insertions(+), 4 deletions(-) -- 2.17.0

2 7

[libvirt] [PATCH v5 0/2] Avoid slash characteres for 'domrename' command.
by Julio Faracco 03 May '18

03 May '18

The commits enhace the 'domrename' command of QEMU and Test drivers to avoid slashes chars inside the new domain name. Julio Faracco (2): qemu: avoid slash characters to the new domain name. test: avoid slash characters to the new domain name. src/qemu/qemu_driver.c | 6 ++++++ src/test/test_driver.c | 6 ++++++ 2 files changed, 12 insertions(+) -- 2.17.0

2 6

[libvirt] [PATCH 0/6] Complete cleanup of domain object usage
by John Ferlan 03 May '18

03 May '18

This should be the "last time" (famous last words) needing to alter this processing. I hope to get more than one pair of eyes looking at the series. I've looked at it long enough to feel comfortable with the changes, but I also know I probably have looked at it so long that I could have missed something! The first 3 patches set up the necessary infrastructure. Patches 4 & 5 are just something I found in libxl while doing this - they could be extracted and considered separately if need be; however, since I was thinking about @vm referencing - it just seemed to fit. Since I altered @vm it only seemed right to do the same for @conn. While it could be said that neither condition could happen - I figured better safe than sorry and I think it follows how this type of logic has been handled elsewhere in qemu. Patch 6 is where all the magic happens. I tried a few different ways to rework and split the Add/Remove processing, but either way I was left with rather ugly patches that required touching the same places, so I capitulated and combined them since there really is a delicate balance between those paths that have added a virObjectRef after the virDomainObjListAdd and those that just use virObjectUnlock on the returned ListAdd objects. Converting the latter to use Ref caused more "busy work" and equally large patches. The busy work was mosting around the processing required during ListAdd if something happened which resulted in ListRemove needing to be called. The "general change" is that instead of having ListAdd return an object with 2 refs and 1 lock it will now return an object with 3 refs and 1 lock. With that returned object, some drivers would perform an ObjectRef while others did not. For those that did not, they would use ObjectUnlock when done with the object so that when leaving whatever Create routine there was there would be at least 2 Refs on the object. The change here is to have them all be consistent. What follows is a "general description" of what was done for each. For bhyve, openvz, test, uml, and vmware (e.g. domain drivers that do not use virObjectRef on the returned virDomainObjListAdd object): Create/Add processing: -> Use EndAPI instead of ObjectUnlock -> Remove setting vm = NULL if the ListRemove was called to allow EndAPI processing to perform last Unref and Unlock NB: ListRemove would remove 2 refs and unlock, so it "worked", but would "consume" the returned object Undefine/Destroy processing: -> Alter ListRemove and ObjectLock to just be ListRemove allowing the EndAPI processing from a FindBy* to perform last Unref and Unlock For libxl, lxc, qemu, and vz (e.g. domain drivers that use virObjectRef on the returned virDomainObjListAdd object): Create/Add processing: -> Remove the ObjectRef -> Remove the ObjectLock when needing to call ListRemove to allow EndAPI processing to perform the last Unref and Unlock NB: ListRemove no longer Unlock's the returned object Undefine/Destroy processing: -> Alter ListRemove and ObjectLock to just be ListRemove allowing the EndAPI processing from a FindBy* to perform last Unref and Unlock NB: For the AutoDestroy type logic, no change is required since in the long run the object was left with the correct number of refs after create processing ran. The issue is more the direct mgmt of object during Add/Remove rather than mgmt of object once defined. John Ferlan (6): conf: Split FindBy{UUID|Name} into locked helpers conf: Use virDomainObjListFindBy*Locked for virDomainObjListAdd conf: Move and use virDomainObjListRemoveLocked libxl: Add refcnt for args->vm during migration libxl: Add refcnt for args->conn during migration conf: Clean up object referencing for Add and Remove src/bhyve/bhyve_driver.c | 21 ++---- src/conf/virdomainobjlist.c | 165 ++++++++++++++++++++++++++++---------------- src/libxl/libxl_driver.c | 64 ++++------------- src/libxl/libxl_migration.c | 41 ++++------- src/lxc/lxc_driver.c | 21 ++---- src/lxc/lxc_process.c | 17 +++-- src/openvz/openvz_conf.c | 2 +- src/openvz/openvz_driver.c | 20 ++---- src/qemu/qemu_domain.c | 17 +---- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_migration.c | 3 +- src/test/test_driver.c | 56 +++++---------- src/uml/uml_driver.c | 37 +++------- src/vmware/vmware_conf.c | 3 +- src/vmware/vmware_driver.c | 17 ++--- src/vz/vz_driver.c | 1 - src/vz/vz_sdk.c | 3 - 17 files changed, 192 insertions(+), 302 deletions(-) -- 2.13.6

3 20

[libvirt] [PATCH 0/3] Ditch qemu-img help scraping
by Ján Tomko 03 May '18

03 May '18

Ján Tomko (3): tests: delete most qemu-img test cases assuming FMT_OPTIONS tests: assume FMT_COMPAT for qemu-img tests storage: remove qemu-img help scraping src/storage/storage_util.c | 73 ++------------------- src/storage/storage_util.h | 1 - .../qcow2-convert-nobacking.argv | 2 - .../storagevolxml2argvdata/qcow2-from-logical.argv | 2 - .../qcow2-nobacking-convert-prealloc.argv | 2 - .../qcow2-nobacking-prealloc.argv | 2 - .../qcow2-nocapacity-convert-prealloc.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- tests/storagevolxml2argvdata/qcow2.argv | 2 - tests/storagevolxml2argvtest.c | 74 ++++++---------------- 10 files changed, 24 insertions(+), 138 deletions(-) delete mode 100644 tests/storagevolxml2argvdata/qcow2-convert-nobacking.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-from-logical.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-prealloc.argv delete mode 100644 tests/storagevolxml2argvdata/qcow2.argv -- 2.13.6

2 9

[libvirt] [PATCH] configure: remove bogus LIBVIRT_GETTEXT macro reference
by Daniel P. Berrangé 03 May '18

03 May '18

The LIBVIRT_GETTEXT macro was an artifact of patch development and was later renamed to LIBVIRT_CHECK_NLS. This cruft causes configure to print out ./configure: line 75084: LIBVIRT_GETTEXT: command not found but fortunately this is non-fatal Reported-by: Martin Kletzander <mkletzan(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as trivial fix configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 419a1aa2f5..cc005ea9e8 100644 --- a/configure.ac +++ b/configure.ac @@ -734,8 +734,6 @@ if test "$enable_test_locking" = "yes"; then fi AM_CONDITIONAL([WITH_CIL],[test "$enable_test_locking" = "yes"]) -LIBVIRT_GETTEXT - dnl Cygwin, MinGW and MSVC checks LIBVIRT_WIN_CHECK_COMMON LIBVIRT_WIN_CHECK_CYGWIN -- 2.14.3

1 0

[libvirt] [PATCH 00/14] nwfilter: refactor the driver to make it independent of virt drivers
by Daniel P. Berrangé 03 May '18

03 May '18

Today the nwfilter driver is entangled with the virt drivers in both directions. At various times when rebuilding filters nwfilter will call out to the virt driver to iterate over running guest's NICs. This has caused very complicated lock ordering rules to be required. If we are to split the virt drivers out into separate daemons we need to get rid of this coupling since we don't want the separate daemons calling each other, as that risks deadlock if all of the RPC workers are busy. The obvious way to solve this is to have the nwfilter driver remember all the filters it has active, avoiding the need to iterate over running guests. NB, these patches are all ready for review, but the last patch really should not be merged at this time. I need to do more work to be able to serialize the filter state to disk, so the nwfilter driver can keep track of it across daemon restarts. All except the last patch should be ok to merge though. Daniel P. Berrangé (14): nwfilter: remove pointless virNWFilterHashTable struct nwfilter: remove methods that are trivial wrappers for virHash APIs nwfilter: remove virNWFilterHashTable typedefs entirely nwfilter: make virNWFilterIPAddrLearnReq type private nwfilter: remove obsolete code related to firewalld nwfilter: fix leaking of filter parameters upon error nwfilter: introduce virNWFilterBinding to decouple from virDomainNet nwfilter: pass vm name in when instantiating filters nwfilter: convert the gentech driver code to use virNWFilterBinding nwfilter: convert IP address learning code to virNWFilterBinding nwfilter: convert DHCP address snooping code to virNWFilterBinding nwfilter: report an error if nic needs filtering by no driver is present nwfilter: keep track of active filter bindings nwfilter: remove virt driver callback layer for rebuilding filters src/conf/domain_conf.c | 8 +- src/conf/domain_conf.h | 2 +- src/conf/domain_nwfilter.c | 14 +- src/conf/domain_nwfilter.h | 6 +- src/conf/nwfilter_conf.c | 224 ++++++++--------- src/conf/nwfilter_conf.h | 67 ++--- src/conf/nwfilter_ipaddrmap.c | 15 +- src/conf/nwfilter_params.c | 127 +++------- src/conf/nwfilter_params.h | 33 +-- src/conf/virnwfilterobj.c | 4 +- src/conf/virnwfilterobj.h | 4 +- src/libvirt_private.syms | 8 +- src/lxc/lxc_driver.c | 28 --- src/lxc/lxc_process.c | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 153 +++++------- src/nwfilter/nwfilter_dhcpsnoop.h | 7 +- src/nwfilter/nwfilter_driver.c | 97 +++++--- src/nwfilter/nwfilter_driver.h | 2 - src/nwfilter/nwfilter_gentech_driver.c | 432 ++++++++++++++++++--------------- src/nwfilter/nwfilter_gentech_driver.h | 28 +-- src/nwfilter/nwfilter_learnipaddr.c | 113 ++++----- src/nwfilter/nwfilter_learnipaddr.h | 25 +- src/nwfilter/nwfilter_tech_driver.h | 2 +- src/qemu/qemu_driver.c | 25 -- src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_interface.c | 4 +- src/qemu/qemu_process.c | 2 +- src/uml/uml_conf.c | 2 +- src/uml/uml_driver.c | 29 --- tests/nwfilterxml2firewalltest.c | 36 +-- 30 files changed, 642 insertions(+), 863 deletions(-) -- 2.14.3

4 30

[libvirt] [PATCH v3 0/3] Support tpm-crb TPM interface for QEMU
by Stefan Berger 03 May '18

03 May '18

This patch series adds support for the recently added tpm-crb TPM interface for QEMU (2.12). Stefan Stefan Berger (3): tpm: Enable TPM CRB interface in the domain XML and test it qemu: Extend the capabilities with tpm-crb device tests: add test case for tpm-crb QEMU device command line docs/formatdomain.html.in | 6 +++- docs/schemas/domaincommon.rng | 5 +++- src/conf/domain_conf.c | 5 ++-- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 5 ++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 16 +++++++++- tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemuxml2argvdata/tpm-passthrough-crb.args | 26 ++++++++++++++++ tests/qemuxml2argvdata/tpm-passthrough-crb.xml | 32 ++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ tests/qemuxml2xmloutdata/tpm-passthrough-crb.xml | 36 +++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 13 files changed, 131 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/tpm-passthrough-crb.args create mode 100644 tests/qemuxml2argvdata/tpm-passthrough-crb.xml create mode 100644 tests/qemuxml2xmloutdata/tpm-passthrough-crb.xml -- 2.5.5

2 10

[libvirt] [perl PATCH] maint: Drop autobuild.sh
by Andrea Bolognani 03 May '18

03 May '18

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-perl CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1] https://ci.centos.org/view/libvirt/ Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- autobuild.sh | 74 ------------------------------------------------------------ 1 file changed, 74 deletions(-) delete mode 100755 autobuild.sh diff --git a/autobuild.sh b/autobuild.sh deleted file mode 100755 index 8a6d102..0000000 --- a/autobuild.sh +++ /dev/null @@ -1,74 +0,0 @@ -#!/bin/sh -# -# This script is used to Test::AutoBuild (http://www.autobuild.org) -# to perform automated builds of the Sys-Virt module - -NAME=Sys-Virt - -set -e - -test -n "$1" && RESULTS=$1 || RESULTS=results.log -: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} - -make -k realclean ||: -rm -rf MANIFEST blib pm_to_blib - -export TEST_MAINTAINER=1 - -perl Makefile.PL PREFIX=$AUTOBUILD_INSTALL_ROOT - -rm -f MANIFEST - -# Build the RPM. -make -make manifest - -if [ -z "$USE_COVER" ]; then - perl -MDevel::Cover -e '' 1>/dev/null 2>&1 && USE_COVER=1 || USE_COVER=0 -fi - -if [ -z "$SKIP_TESTS" -o "$SKIP_TESTS" = "0" ]; then - if [ "$USE_COVER" = "1" ]; then - cover -delete - export HARNESS_PERL_SWITCHES=-MDevel::Cover - fi - - # set -o pipefail is a bashism; this use of exec is the POSIX alternative - exec 3>&1 - st=$( - exec 4>&1 >&3 - { make test 2>&1 3>&- 4>&-; echo $? >&4; } | tee "$RESULTS" - ) - exec 3>&- - test "$st" = 0 - - if [ "$USE_COVER" = "1" ]; then - cover - mkdir blib/coverage - cp -a cover_db/*.html cover_db/*.css blib/coverage - mv blib/coverage/coverage.html blib/coverage/index.html - fi -fi - -make install - -rm -f $NAME-*.tar.gz -make dist - -if [ -f /usr/bin/rpmbuild ]; then - if [ -n "$AUTOBUILD_COUNTER" ]; then - EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" - else - NOW=`date +"%s"` - EXTRA_RELEASE=".$USER$NOW" - fi - rpmbuild --nodeps -ta --define "extra_release $EXTRA_RELEASE" --clean $NAME-*.tar.gz -fi - -# Skip debian pkg for now -exit 0 - -if [ -f /usr/bin/fakeroot ]; then - fakeroot debian/rules clean - fakeroot debian/rules DESTDIR=$HOME/packages/debian binary -fi -- 2.14.3

2 1

[libvirt] [python PATCH] maint: Drop autobuild.sh
by Andrea Bolognani 03 May '18

03 May '18

The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, libvirt-python CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1] https://ci.centos.org/view/libvirt/ Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- autobuild.sh | 30 ------------------------------ 1 file changed, 30 deletions(-) delete mode 100755 autobuild.sh diff --git a/autobuild.sh b/autobuild.sh deleted file mode 100755 index 5dffe96..0000000 --- a/autobuild.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/bin/sh - -set -ve - -: ${AUTOBUILD_INSTALL_ROOT="$HOME/builder"} - -rm -rf MANIFEST dist build - - -python2 setup.py sdist - -python2 setup.py build -python2 setup.py test -python2 setup.py install --root="$AUTOBUILD_INSTALL_ROOT" - -if test -f /usr/bin/python3 ; then - python3 setup.py build - python3 setup.py test - python3 setup.py install --root="$AUTOBUILD_INSTALL_ROOT" -fi - -type -p /usr/bin/rpmbuild > /dev/null 2>&1 || exit 0 - -if [ -n "$AUTOBUILD_COUNTER" ]; then - EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER" -else - NOW=`date +"%s"` - EXTRA_RELEASE=".$USER$NOW" -fi -rpmbuild --nodeps --define "extra_release $EXTRA_RELEASE" -ta --clean dist/*.tar.gz -- 2.14.3

2 1

[libvirt] [jenkins-ci PATCH 0/4] Introduce Fedora 28; drop Fedora 26
by Andrea Bolognani 03 May '18

03 May '18

It's that time of the year again :) Andrea Bolognani (4): guests: Add libvirt-fedora-28 projects: Add libvirt-fedora-28 projects: Remove libvirt-fedora-26 guests: Remove libvirt-fedora-26 .../host_vars/{libvirt-fedora-26 => libvirt-fedora-28}/install.yml | 2 +- guests/host_vars/{libvirt-fedora-26 => libvirt-fedora-28}/main.yml | 0 guests/inventory | 2 +- jobs/defaults.yaml | 4 ++-- projects/libvirt-dbus.yaml | 4 ++-- projects/libvirt-sandbox.yaml | 4 ++-- projects/libvirt-tck.yaml | 4 ++-- projects/libvirt.yaml | 4 ++-- projects/virt-manager.yaml | 6 +++--- 9 files changed, 15 insertions(+), 15 deletions(-) rename guests/host_vars/{libvirt-fedora-26 => libvirt-fedora-28}/install.yml (74%) rename guests/host_vars/{libvirt-fedora-26 => libvirt-fedora-28}/main.yml (100%) -- 2.14.3

2 6

[libvirt] [PATCH v3 0/9] tests: Fix 'make check' on FreeBSD
by Andrea Bolognani 03 May '18

03 May '18

Changes from [v2]: * introduce a wrapper around canonicalize_file_name() instead of moving to realpath(); * fix more usages of mode_t with va_arg(). Changes from [v1]: * drop the virnetsockettest changes, since the relationship between the errors seen on FreeBSD and IPv4 clients connecting to IPv6 sockets has turned out to be just a red herring; * fix the mocking instead of dropping test cases that don't work without it. [v2] https://www.redhat.com/archives/libvir-list/2018-April/msg02685.html [v1] https://www.redhat.com/archives/libvir-list/2018-April/msg02611.html Andrea Bolognani (9): util: Introduce virFileCanonicalizePath() tests: Mock virFileCanonicalizePath() all: Use virFileCanonicalizePath() instead of canonicalize_file_name() tests: Stop mocking canonicalize_file_name() syntax-check: Prohibit canonicalize_file_name() tests: Fix mode_t usage with va_arg() tests: Build virpcimock on non-Linux tests: Extend NUMA mocking tests: Drop DO_TEST_LINUX() cfg.mk | 10 ++++ src/libvirt_private.syms | 1 + src/storage/storage_backend_fs.c | 2 +- src/util/virfile.c | 15 +++++- src/util/virfile.h | 1 + src/util/virpci.c | 2 +- tests/nssmock.c | 2 +- tests/qemuxml2argvmock.c | 38 ++++++++++---- tests/qemuxml2argvtest.c | 46 ++++++----------- tests/vircgroupmock.c | 2 +- tests/virpcimock.c | 104 ++++++++++++++++++++++----------------- tests/virstoragetest.c | 10 ++-- tests/virtestmock.c | 8 +-- 13 files changed, 141 insertions(+), 100 deletions(-) -- 2.14.3

2 20

[libvirt] [PATCH] storagefile: conditional build of virStorageFileLoadBackendModule
by Daniel P. Berrangé 03 May '18

03 May '18

The virStorageFileLoadBackendModule method is only used if either fs or gluster storage is built in, which doesn't happen on mingw leading to warning of an unused static function. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as mingw build fix src/util/virstoragefilebackend.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefilebackend.c b/src/util/virstoragefilebackend.c index ac087dabac..eb3055ed67 100644 --- a/src/util/virstoragefilebackend.c +++ b/src/util/virstoragefilebackend.c @@ -45,7 +45,9 @@ VIR_LOG_INIT("storage.storage_source_backend"); static virStorageFileBackendPtr virStorageFileBackends[VIR_STORAGE_BACKENDS_MAX]; static size_t virStorageFileBackendsCount; -#define STORAGE_FILE_MODULE_DIR LIBDIR "/libvirt/storage-file" +#if WITH_STORAGE_DIR || WITH_STORAGE_FS || WITH_STORAGE_GLUSTER + +# define STORAGE_FILE_MODULE_DIR LIBDIR "/libvirt/storage-file" static int virStorageFileLoadBackendModule(const char *name, @@ -69,7 +71,7 @@ virStorageFileLoadBackendModule(const char *name, return ret; } - +#endif /* WITH_STORAGE_DIR || WITH_STORAGE_FS || WITH_STORAGE_GLUSTER */ static int virStorageFileBackendOnceInit(void) { -- 2.14.3

1 0

[libvirt] [dbus RFC PATCH 0/6] Remove all enum->string and string->enum code
by Katerina Koukiou 03 May '18

03 May '18

As mentioned in the patches commit message... Converting ENUMS to str can be user friendly though it can be problematic between libvirt versions. In particular when some translated type will introduce a new constant to the ENUM libvirt-dbus will fail with: size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative Since it's not main use case of livirt-dbus API to be invoked interactively by user, having all ENUM types passed as unsigned int is preferable to avoid the previous issue. Katerina Koukiou (6): Abandon usage of all *TypeToString functions in domain.c Abandon usage of all *TypeToString functions in connect.c Abandon usage of all *TypeToString functions in network.c Change DomainEvent argument from string to unsigned int Change NetworkEvent argument from string to unsigned int Remove virtDBusUtilEnum{From,From}String functions data/org.libvirt.Connect.xml | 6 +- data/org.libvirt.Domain.xml | 14 ++-- data/org.libvirt.Network.xml | 6 +- src/connect.c | 18 +---- src/domain.c | 172 ++++--------------------------------------- src/events.c | 40 +--------- src/network.c | 66 +---------------- src/util.c | 27 ------- src/util.h | 28 ------- tests/libvirttest.py | 20 +++++ tests/test_connect.py | 24 ++++-- tests/test_domain.py | 36 ++++++--- tests/test_network.py | 20 +++-- 13 files changed, 107 insertions(+), 370 deletions(-) -- 2.15.0

1 7

[libvirt] [qemu RFC v3 0/3] qapi: add "firmware.json"
by Laszlo Ersek 03 May '18

03 May '18

This version seeks to address the RFCv2 feedback. Changes are noted per patch. Cc: "Daniel P. Berrange" <berrange(a)redhat.com> Cc: David Gibson <dgibson(a)redhat.com> Cc: Eric Blake <eblake(a)redhat.com> Cc: Gerd Hoffmann <kraxel(a)redhat.com> Cc: Kashyap Chamarthy <kchamart(a)redhat.com> Cc: Markus Armbruster <armbru(a)redhat.com> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Thomas Huth <thuth(a)redhat.com> Thanks, Laszlo Laszlo Ersek (3): qapi: add SysEmuTarget to "common.json" qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget qapi: add "firmware.json" Makefile | 9 + Makefile.objs | 4 + qapi/common.json | 19 ++ qapi/firmware.json | 554 ++++++++++++++++++++++++++++++++++++++++++++++++++ qapi/misc.json | 6 +- qapi/qapi-schema.json | 1 + arch_init.c | 18 +- qmp.c | 5 + .gitignore | 4 + 9 files changed, 617 insertions(+), 3 deletions(-) create mode 100644 qapi/firmware.json -- 2.14.1.3.gb7cf6e02401b

3 10

[libvirt] [PATCH] tests: unlink libxl-driver.log
by Daniel P. Berrangé 03 May '18

03 May '18

The libxlxml2domconfigtest causes a libxl-driver.log file to be created which breaks make distchck if libxl is enabled. Delete the log file at the end of the test. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix for make distcheck tests/libxlxml2domconfigtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index d9287b59a8..0d2a7385e5 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -211,6 +211,8 @@ mymain(void) DO_TEST("multiple-ip"); DO_TEST("fullvirt-cpuid"); + unlink("libxl-driver.log"); + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.14.3

1 0

[libvirt] [dbus PATCH v2 0/9] NodeAPIs for Connect Interface
by Katerina Koukiou 03 May '18

03 May '18

Changes from v1: * Added tests were the test driver exported the relevant API * Removed NodeGetCellsFreeMemory which will be sent in seperate patchset * Adjusted other comments from review Katerina Koukiou (9): Implement NodeGetCPUStats method for Connect Interface Implement NodeGetFreeMemory method for Connect Interface Implement NodeGetInfo method for Connect Interface Implement NodeGetMemoryParameters method in Connect Interface Implement NodeGetMemoryStats method for Connect Interface Implement NodeGetSecurityModel method for Domain Interface Implement NodeSetMemoryParameters method for Connect Interface Implement NodeSuspendForDuration method for Connect Interface Implement NodeGetCPUMap method for Connect Interface data/org.libvirt.Connect.xml | 54 ++++++++ src/connect.c | 303 +++++++++++++++++++++++++++++++++++++++++++ tests/test_connect.py | 16 +++ 3 files changed, 373 insertions(+) -- 2.15.0

2 18

[libvirt] [PATCH 0/5] Improve translation handling
by Daniel P. Berrangé 03 May '18

03 May '18

This series aims to improve the way we handle translations. The key problems with our current approach - The pot & po files stored in GIT contain huge set of annotations about source file names & line numbers. These are out of date as soon as a change is commited to git following a translation refresh. This makes diffs impossible to meaningfully review, as they are 98% noise, 2% signal. - The po file messages are sorted by source location, so when we move code between files, or rename files, the po file message order changes for no good reason. This makes diffs even more impossible to review. - The po files contain entries for all messages even if most have no translation, bloating size of po/ data stored in git - Whenever 'make dist' is run, it alters all the pot and po files, so developers need to then reset their content to match git HEAD manually. This is caused by having auto-generated content (source file locations) mixed in with the static content (the actual translated strings) Overall the *.po files we store consume 100MB, and when I refresh content from Zanata, it results in git commits that are many 10's of MB in size and impossible todo any meaningful review on. After this series, we only minimized po files in git, with the redundated & outdated source locations info stripped. This stripped info is re-added automatically during build to create the real .po files, that we distribute, and/or upload to translators in Zanata. As a result the po directory is only 19MB in size, and when refreshing from Zanata, we have git commits that clearly show *only* the altered translations, nothing else. The importance of this cannot be overstated - by having these clear diffs I discovered a serious bug in the Zanata client that has been screwing up translations in every project that uses Zanata by adding bogus "fuzzy" annotations. Note that what I've posted here is a cut-down version of what will actually be pushed. I have cut out the 99 other patches that actally change the .po files. There's no meaningful way to review those commits because of the noise in the original .po files we're replacing. I have gone through manual steps, however, to validate that the .po files we generate from the new .mini.po files are identical to the original .po files we used to store, aside from the bogus fuzzy annotations due to broken Zanata. The diffstat shown below covers the full set of patches on the branch at: https://github.com/berrange/libvirt/commits/i18n-4 The killer statistic is: 418787 insertions(+), 4388281 deletions(-) Daniel P. Berrangé (5): po: provide custom make rules for po file management po: remove language list from zanata configuration po: add rules for integration with zanata po: stop storing libvirt.pot in git po: minimize & canonicalize translations stored in git .gitignore | 9 +- ABOUT-NLS | 1 + autogen.sh | 3 +- bootstrap.conf | 38 - build-aux/minimize-po.pl | 37 + configure.ac | 33 +- m4/virt-nls.m4 | 70 + po/Makefile.am | 107 + po/{POTFILES.in => POTFILES} | 0 po/README.md | 75 + po/af.mini.po | 20 + po/af.po | 46395 ------------------------------ po/am.mini.po | 20 + po/am.po | 46395 ------------------------------ po/anp.mini.po | 20 + po/anp.po | 46395 ------------------------------ po/ar.mini.po | 762 + po/ar.po | 46685 ------------------------------ po/{as.po => as.mini.po} | 54246 ++++++++++------------------------- po/ast.mini.po | 20 + po/ast.po | 46395 ------------------------------ po/bal.mini.po | 20 + po/bal.po | 46395 ------------------------------ po/be.mini.po | 21 + po/be.po | 46396 ------------------------------ po/bg.mini.po | 1204 + po/bg.po | 46733 ------------------------------ po/bn.mini.po | 761 + po/bn.po | 46684 ------------------------------ po/bn_IN.mini.po | 9131 ++++++ po/bn_IN.po | 46729 ------------------------------ po/bo.mini.po | 20 + po/bo.po | 46395 ------------------------------ po/br.mini.po | 20 + po/br.po | 46395 ------------------------------ po/brx.mini.po | 20 + po/brx.po | 46395 ------------------------------ po/bs.mini.po | 767 + po/bs.po | 46693 ------------------------------ po/ca.mini.po | 1618 ++ po/ca.po | 46555 ------------------------------ po/cs.mini.po | 4146 +++ po/cs.po | 46751 ------------------------------ po/cy.mini.po | 762 + po/cy.po | 46701 ------------------------------ po/da.mini.po | 982 + po/da.po | 46704 ------------------------------ po/de.mini.po | 22654 +++++++++++++++ po/de.po | 47656 ------------------------------- po/de_CH.mini.po | 20 + po/de_CH.po | 46395 ------------------------------ po/el.mini.po | 724 + po/el.po | 46857 ------------------------------ po/en_GB.mini.po | 22271 +++++++++++++++ po/en_GB.po | 47573 ------------------------------- po/eo.mini.po | 20 + po/eo.po | 46395 ------------------------------ po/es.mini.po | 22622 +++++++++++++++ po/es.po | 47748 ------------------------------- po/et.mini.po | 761 + po/et.po | 46684 ------------------------------ po/eu.mini.po | 761 + po/eu.po | 46684 ------------------------------ po/fa.mini.po | 20 + po/fa.po | 46395 ------------------------------ po/fi.mini.po | 1281 + po/fi.po | 46744 ------------------------------ po/fil.mini.po | 20 + po/fr.mini.po | 4258 +++ po/fr.po | 46907 ------------------------------ po/fur.mini.po | 20 + po/ga.mini.po | 21 + po/gl.mini.po | 761 + po/gl.po | 46700 ------------------------------ po/{gu.po => gu.mini.po} | 54191 ++++++++++------------------------- po/he.mini.po | 761 + po/he.po | 46684 ------------------------------ po/hi.mini.po | 13772 +++++++++ po/hi.po | 47013 ------------------------------- po/hr.mini.po | 21 + po/hr.po | 46396 ------------------------------ po/hu.mini.po | 987 + po/hu.po | 46709 ------------------------------ po/ia.mini.po | 20 + po/ia.po | 46395 ------------------------------ po/id.mini.po | 728 + po/id.po | 46691 ------------------------------ po/ilo.mini.po | 20 + po/ilo.po | 46395 ------------------------------ po/is.mini.po | 761 + po/is.po | 46684 ------------------------------ po/it.mini.po | 6588 +++++ po/it.po | 46663 ------------------------------ po/{ja.po => ja.mini.po} | 54737 ++++++++++------------------------- po/ka.mini.po | 761 + po/ka.po | 46684 ------------------------------ po/kk.mini.po | 20 + po/kk.po | 46395 ------------------------------ po/km.mini.po | 20 + po/km.po | 46395 ------------------------------ po/{kn.po => kn.mini.po} | 54156 ++++++++++------------------------- po/ko.mini.po | 12838 +++++++++ po/ko.po | 46723 ------------------------------ po/kw.mini.po | 21 + po/kw.po | 46396 ------------------------------ po/kw(a)kkcor.mini.po | 21 + po/kw(a)kkcor.po | 46396 ------------------------------ po/kw(a)uccor.mini.po | 21 + po/kw(a)uccor.po | 46396 ------------------------------ po/kw_GB.mini.po | 21 + po/kw_GB.po | 46396 ------------------------------ po/ky.mini.po | 20 + po/ky.po | 46395 ------------------------------ po/libvirt.pot | 46394 ------------------------------ po/lt.mini.po | 762 + po/lt.po | 46685 ------------------------------ po/lv.mini.po | 762 + po/lv.po | 46685 ------------------------------ po/mai.mini.po | 20 + po/mai.po | 46395 ------------------------------ po/mk.mini.po | 1138 + po/mk.po | 46724 ------------------------------ po/{ml.po => ml.mini.po} | 53963 ++++++++++------------------------- po/mn.mini.po | 20 + po/mn.po | 46395 ------------------------------ po/{mr.po => mr.mini.po} | 55484 +++++++++++------------------------- po/ms.mini.po | 189 + po/ms.po | 46580 ------------------------------ po/my.mini.po | 20 + po/nb.mini.po | 492 + po/nb.po | 46667 ------------------------------ po/nds.mini.po | 20 + po/nds.po | 46395 ------------------------------ po/ne.mini.po | 20 + po/ne.po | 46395 ------------------------------ po/nl.mini.po | 9868 +++++++ po/nl.po | 47062 ------------------------------- po/nn.mini.po | 761 + po/nn.po | 46684 ------------------------------ po/nso.mini.po | 761 + po/nso.po | 46684 ------------------------------ po/{or.po => or.mini.po} | 53161 +++++++++------------------------- po/{pa.po => pa.mini.po} | 53711 ++++++++++------------------------- po/pl.mini.po | 10274 +++++++ po/pl.po | 47166 ------------------------------- po/pt.mini.po | 1243 + po/pt.po | 46587 ------------------------------ po/pt_BR.mini.po | 22821 +++++++++++++++ po/pt_BR.po | 47565 ------------------------------- po/ro.mini.po | 762 + po/ro.po | 46685 ------------------------------ po/{ru.po => ru.mini.po} | 54065 ++++++++++------------------------- po/si.mini.po | 761 + po/si.po | 46684 ------------------------------ po/sk.mini.po | 761 + po/sk.po | 46684 ------------------------------ po/sl.mini.po | 762 + po/sl.po | 46685 ------------------------------ po/sq.mini.po | 24 + po/sq.po | 46399 ------------------------------ po/sr.mini.po | 2203 ++ po/sr.po | 46910 ------------------------------ po/sr(a)latin.mini.po | 2204 ++ po/sr(a)latin.po | 46911 ------------------------------ po/sv.mini.po | 2559 ++ po/sv.po | 46696 ------------------------------ po/{ta.po => ta.mini.po} | 54968 +++++++++++------------------------- po/{te.po => te.mini.po} | 53427 ++++++++++------------------------- po/tg.mini.po | 20 + po/tg.po | 46395 ------------------------------ po/th.mini.po | 761 + po/th.po | 46684 ------------------------------ po/tr.mini.po | 761 + po/tr.po | 46684 ------------------------------ po/tw.mini.po | 20 + po/tw.po | 46395 ------------------------------ po/{uk.po => uk.mini.po} | 62575 +++++++++++++++++------------------------ po/ur.mini.po | 761 + po/ur.po | 46684 ------------------------------ po/vi.mini.po | 8674 ++++++ po/vi.po | 47171 ------------------------------- po/wba.mini.po | 20 + po/wba.po | 46395 ------------------------------ po/yo.mini.po | 20 + po/yo.po | 46395 ------------------------------ po/zanata.xml | 99 - po/zh_CN.mini.po | 23613 ++++++++++++++++ po/zh_CN.po | 46701 ------------------------------ po/zh_HK.mini.po | 20 + po/zh_HK.po | 46395 ------------------------------ po/zh_TW.mini.po | 958 + po/zh_TW.po | 46725 ------------------------------ po/zu.mini.po | 761 + po/zu.po | 46684 ------------------------------ src/internal.h | 16 +- src/libvirt-admin.c | 2 + src/libvirt.c | 2 + src/util/virgettext.c | 3 +- tools/virt-host-validate.c | 4 +- 199 files changed, 418787 insertions(+), 4388281 deletions(-) -- 2.14.3

3 14

[libvirt] [PATCH 0/6] Split the storage file driver impls from the storage driver backends
by Daniel P. Berrangé 03 May '18

03 May '18

The storage driver backends currently register storage file backends as a side effect of initialization. This is fine right now while both run in the same libvirtd process, but in future the storage file backends will need to run in the hypervisor daemon which will be separate from the storage daemon. This small series splits them, makin the storage file backends be registered "on demand" Daniel P. Berrangé (6): util: create new virmodule.{c,h} files for dlopen support code storage: split gluster storage file code from storage driver backend storage: split fs storage file code from storage driver backend storage: fix virStorageFileGetBackingStoreStr error handling util: refactor storage file checks to allow error reporting storage: create separate loadable modules for storage file drivers libvirt.spec.in | 4 + src/driver.c | 133 +----------- src/driver.h | 3 - src/libvirt_driver_modules.syms | 1 - src/libvirt_private.syms | 3 + src/qemu/qemu_domain.c | 21 +- src/qemu/qemu_driver.c | 21 +- src/storage/Makefile.inc.am | 44 ++++ src/storage/storage_backend.c | 3 +- src/storage/storage_backend_fs.c | 210 +------------------ src/storage/storage_backend_gluster.c | 305 +--------------------------- src/storage/storage_backend_gluster.h | 2 +- src/storage/storage_file_fs.c | 251 +++++++++++++++++++++++ src/storage/storage_file_fs.h | 29 +++ src/storage/storage_file_gluster.c | 366 ++++++++++++++++++++++++++++++++++ src/storage/storage_file_gluster.h | 27 +++ src/util/Makefile.inc.am | 2 + src/util/virmodule.c | 163 +++++++++++++++ src/util/virmodule.h | 29 +++ src/util/virstoragefile.c | 123 ++++++++---- src/util/virstoragefile.h | 9 +- src/util/virstoragefilebackend.c | 72 +++++-- src/util/virstoragefilebackend.h | 9 +- 23 files changed, 1098 insertions(+), 732 deletions(-) create mode 100644 src/storage/storage_file_fs.c create mode 100644 src/storage/storage_file_fs.h create mode 100644 src/storage/storage_file_gluster.c create mode 100644 src/storage/storage_file_gluster.h create mode 100644 src/util/virmodule.c create mode 100644 src/util/virmodule.h -- 2.14.3

2 17

[libvirt] [PATCH] docs: Grammar and spelling fixes
by Ville Skyttä 03 May '18

03 May '18

Signed-off-by: Ville Skyttä <ville.skytta(a)iki.fi> --- docs/aclpolkit.html.in | 2 +- docs/api.html.in | 2 +- docs/contribute.html.in | 2 +- docs/downloads.html.in | 2 +- docs/drvbhyve.html.in | 2 +- docs/drvesx.html.in | 2 +- docs/drvlxc.html.in | 2 +- docs/errors.html.in | 2 +- docs/firewall.html.in | 2 +- docs/formatdomain.html.in | 12 ++++++------ docs/formatdomaincaps.html.in | 2 +- docs/internals/rpc.html.in | 2 +- docs/locking-sanlock.html.in | 2 +- docs/news.xml | 2 +- docs/storage.html.in | 2 +- docs/support.html.in | 2 +- 16 files changed, 21 insertions(+), 21 deletions(-) diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in index 0e3c8e9..98d06da 100644 --- a/docs/aclpolkit.html.in +++ b/docs/aclpolkit.html.in @@ -396,7 +396,7 @@ polkit.addRule(function(action, subject) { To achieve this we need to write a rule which checks whether the <code>connect_driver</code> attribute is <code>LXC</code> and the <code>domain_name</code> - attribute is <code>demo</code>, and match on a action + attribute is <code>demo</code>, and match on action name of <code>org.libvirt.api.domain.getattr</code>. Using the javascript rules format, this ends up written as diff --git a/docs/api.html.in b/docs/api.html.in index 27abed6..288b9ec 100644 --- a/docs/api.html.in +++ b/docs/api.html.in @@ -155,7 +155,7 @@ </ul> </li> <li>Enumeration [virConnectList..., virConnectNumOf...] - Used to enumerate a set of object available to an given + Used to enumerate a set of object available to a given hypervisor connection such as: <ul> <li> diff --git a/docs/contribute.html.in b/docs/contribute.html.in index 158c91c..42a1b2f 100644 --- a/docs/contribute.html.in +++ b/docs/contribute.html.in @@ -80,7 +80,7 @@ and future growth of the project, that there are a people who evangalise the work created by the project. This can take many forms, writing blog posts (about usage of features, - personal user experiances, areas for future work, and more), + personal user experiences, areas for future work, and more), syndicating docs and blogs via social media, giving user group and/or conference talks about libvirt.</li> <li>User assistance. Since documentation diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 8cca203..2956a4f 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -457,7 +457,7 @@ (first release in the middle of Jan, then skip the Feb release), giving a total of 11 releases a year. The Python and Perl modules will aim to release at the same time as the core libvirt module. Other modules have - independant ad-hoc releases with no fixed time schedle. + independent ad-hoc releases with no fixed time schedule. <h2><a id="numbering">Release numbering</a></h2> diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index 63260af..bde8298 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -239,7 +239,7 @@ to let a guest boot or start a guest using: <pre>start --console domname</pre> -NB: An bootloader configured to require user interaction will prevent +NB: A bootloader configured to require user interaction will prevent the domain from starting (and thus <code>virsh console</code> or <code>start --console</code> from functioning) until the user interacts with it manually on the VM host. Because users typically do not have access to the VM host, diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 417aca4..901d659 100644 --- a/docs/drvesx.html.in +++ b/docs/drvesx.html.in @@ -437,7 +437,7 @@ ethernet0.checkMACAddress = "false" <dl> <dt><code>auto</code></dt> <dd> - This isn't a actual controller model. If specified the ESX driver + This isn't an actual controller model. If specified the ESX driver tries to detect the SCSI controller model referenced in the <code>.vmdk</code> file and use it. Autodetection fails when a SCSI controller has multiple disks attached and the SCSI controller diff --git a/docs/drvlxc.html.in b/docs/drvlxc.html.in index 44c4960..6ee9ee8 100644 --- a/docs/drvlxc.html.in +++ b/docs/drvlxc.html.in @@ -429,7 +429,7 @@ be considered secure against exploits of the host OS. The sVirt SELinux driver provides a way to secure containers even when the "user" namespace is not used. The cost is that writing a policy to allow execution of arbitrary OS is not practical. The SELinux sVirt policy is typically -tailored to work with an simpler application confinement use case, +tailored to work with a simpler application confinement use case, as provided by the "libvirt-sandbox" project. diff --git a/docs/errors.html.in b/docs/errors.html.in index 8f4f7d4..ea42728 100644 --- a/docs/errors.html.in +++ b/docs/errors.html.in @@ -29,7 +29,7 @@ set specifically to a connection with call it with the error information</li><li>otherwise call <a href="html/libvirt-virterror.html#virDefaultErrorFunc">virDefaultErrorFunc</a> which is the default error function of the library issuing the error on stderr</li><li>save the error in the connection for later retrieval with <a href="html/libvirt-virterror.html#virConnGetLastError">virConnGetLastError</a></li></ol></li> - <li>otherwise like when failing to create an hypervisor connection: + <li>otherwise like when failing to create a hypervisor connection: <ol><li>if there is a global callback set with <a href="html/libvirt-virterror.html#virSetErrorFunc">virSetErrorFunc</a>, call it with the error information</li><li>otherwise call <a href="html/libvirt-virterror.html#virDefaultErrorFunc">virDefaultErrorFunc</a> which is the default error function of the library issuing the error diff --git a/docs/firewall.html.in b/docs/firewall.html.in index 11c3c81..0a50687 100644 --- a/docs/firewall.html.in +++ b/docs/firewall.html.in @@ -11,7 +11,7 @@ <ul> <li>The virtual network driver - This provides a isolated bridge device (ie no physical NICs + This provides an isolated bridge device (ie no physical NICs enslaved). Guest TAP devices are attached to this bridge. Guests can talk to each other and the host, and optionally the wider world. diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 8e864f7..b65fea0 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -622,7 +622,7 @@ <code>order</code> allows to specify the order to add the online vcpus. For hypervisors/platforms that require to insert multiple vcpus at once - the order may be duplicated accross all vcpus that need to be + the order may be duplicated across all vcpus that need to be enabled at once. Specifying order is not necessary, vcpus are then added in an arbitrary order. If order info is used, it must be used for all online vcpus. Hypervisors may clear or update ordering information @@ -4058,7 +4058,7 @@ pcie-switch-upstream-port, and of course for this to work properly, you will need to decrease the pcie-expander-bus' busNr accordingly so that there are enough unused bus - numbers above it to accomodate giving out one bus number for + numbers above it to accommodate giving out one bus number for the upstream-port and one for each downstream-port (in addition to the pcie-root-port and the pcie-expander-bus itself). @@ -4212,7 +4212,7 @@ <dd>This is the fully qualified path of the file associated with the lockspace. The offset specifies where the lease is stored within the file. If the lock manager does not - require a offset, just pass 0. + require an offset, just pass 0. </dd> </dl> @@ -4867,7 +4867,7 @@ (Since 0.10.0). For example, in order to work properly with both an 802.1Qbh switch and an Open vSwitch switch, you may choose to specify no type, but both - an <code>profileid</code> (in case the switch is 802.1Qbh) and + a <code>profileid</code> (in case the switch is 802.1Qbh) and an <code>interfaceid</code> (in case the switch is Open vSwitch) (you may also omit the other attributes, such as managerid, typeid, or profileid, to be filled in from the @@ -6174,7 +6174,7 @@ qemu-kvm -net nic,model=? /dev/null set to an empty string, then VNC access is disabled. The <code>keymap</code> attribute specifies the keymap to use. It is possible to set a limit on the validity of the password by giving - an timestamp <code>passwdValidTo='2010-04-09T15:51:00'</code> + a timestamp <code>passwdValidTo='2010-04-09T15:51:00'</code> assumed to be in UTC. The <code>connected</code> attribute allows control of connected client during password changes. VNC accepts <code>keep</code> value only since 0.9.3. @@ -6216,7 +6216,7 @@ qemu-kvm -net nic,model=? /dev/null <code>passwd</code> attribute is set to an empty string, then SPICE access is disabled. The <code>keymap</code> attribute specifies the keymap to use. It is possible to set a limit on - the validity of the password by giving an timestamp + the validity of the password by giving a timestamp <code>passwdValidTo='2010-04-09T15:51:00'</code> assumed to be in UTC. diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 6bfcaf6..027e115 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -81,7 +81,7 @@ <h3><a id="elementsCPUAllocation">CPU Allocation</a></h3> - Before any devices capability occurs, there might be a info on domain + Before any devices capability occurs, there might be info on domain wide capabilities, e.g. virtual CPUs: <pre> diff --git a/docs/internals/rpc.html.in b/docs/internals/rpc.html.in index fca9cb7..048192f 100644 --- a/docs/internals/rpc.html.in +++ b/docs/internals/rpc.html.in @@ -133,7 +133,7 @@ </dd> <dt><code>serial</code></dt> <dd> - This is an number that starts from 1 and increases + This is a number that starts from 1 and increases each time a method call packet is sent. A reply or stream packet will have a serial number matching the original method call packet serial. Events always diff --git a/docs/locking-sanlock.html.in b/docs/locking-sanlock.html.in index 9b36561..3ee9849 100644 --- a/docs/locking-sanlock.html.in +++ b/docs/locking-sanlock.html.in @@ -76,7 +76,7 @@ SANLOCKOPTS="-w 0" configuration file for each libvirt driver that is using sanlock. For QEMU, we will edit <code>/etc/libvirt/qemu-sanlock.conf</code> There is one mandatory parameter that needs to be set, - the <code>host_id</code>. This is a integer between + the <code>host_id</code>. This is an integer between 1 and 2000, which must be set to a unique value on each host running virtual machines. diff --git a/docs/news.xml b/docs/news.xml index d67d5a7..8018141 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -1206,7 +1206,7 @@ <description> The <code>vgaconf</code> attribute was added to <code>video</code>'s <code>driver</code> element. Possible values are: <code>on</code>, - <code>off</code>, and <code>io</code>. It controlls the way how + <code>off</code>, and <code>io</code>. It controls the way how bhyve exposes video devices to its guests; various guest OSes might require different settings to boot properly. </description> diff --git a/docs/storage.html.in b/docs/storage.html.in index 3f1aec1..1906aa6 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -759,7 +759,7 @@ This provides a pool based on Virtuozzo storage. Virtuozzo Storage is a highly available distributed software-defined storage with built-in replication and disaster recovery. More detailed information about - Virtuozzo storage and its managment can be found here: + Virtuozzo storage and its management can be found here: <a href="https://openvz.org/Virtuozzo_Storage">Virtuozzo Storage</a>). diff --git a/docs/support.html.in b/docs/support.html.in index 1a9438f..38f2f90 100644 --- a/docs/support.html.in +++ b/docs/support.html.in @@ -199,7 +199,7 @@ return an error indicating it is not supported. Likewise libvirt will make reasonable efforts to keep API calls working across hypervisor releases even if the underlying implementation changes. In cases where - this is impossible, an suitable error will be reported. The list of + this is impossible, a suitable error will be reported. The list of APIs which have implementations <a href="hvsupport.html">is detailed separately</a>. -- 2.14.1

2 1