- Devel - libvirt List Archives

[Libvir] [PATCH] properly check buffer size in virDomainXMLDevID
by Hugh Brock 12 Sep '07

12 Sep '07

As promised, a patch to protect the 80-character "device id" buffer from overflow by the unbounded "device=" XML attribute. Before, a large "device" attribute gave a stack overflow error; now it merely results in an obscure (but non-fatal) xend error like so: libvir: Xen Daemon error : POST operation failed: (xend.err "invalid literal for int() with base 10: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'") (the long string of "x"es was my way of overflowing the buffer). Please ACK... --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

2 3

[Libvir] unsigned long
by John Levon 12 Sep '07

12 Sep '07

I just saw an email about unsigned long and max memory fly by along with a comment like "32-bit will never have more than 'X' Gb" ... This raises an obvious question: is libvirt explictly not 32/64 clean? On Solaris we build everything 32-bit by default unless there is a reason for it to be 64-bit. If a 32-bit libvirt can't handle a 64-bit kernel, then we have a problem. IMO an API should *always* use explicitly-sized integers when they contain range or size values (or use size_t etc.). Not doing so is both dangerous and confusing... (Xen does indeed have this problem, so we run all their tools with native word size. Currently we always use a 32-bit libvirt for 'virt-install', and it does seem to work fine. It would be a pity for this to change). cheers john

3 6

[Libvir] [PATCH] Remove warning when dumping XML from an inactive domain with Xen < 3.1
by Richard W.M. Jones 12 Sep '07

12 Sep '07

# virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID < 0 and xendConfigVersion < 3 0 [ and dump proceeds as normal ] The patch just removes the false error message and makes a note that this still needs a real fix later. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 3

[Libvir] [PATCH] Fix enum virDrvOpenRemoteFlags
by Richard W.M. Jones 12 Sep '07

12 Sep '07

(Thanks Eduardo for pointing this one out ...) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 2

[Libvir] Removing virDomainRestart typedef
by Richard W.M. Jones 12 Sep '07

12 Sep '07

virDomainReboot takes a flag argument which is documented as: * @flags: extra flags for the reboot operation, not used yet In fact, the test driver (alone) allows a virDomainRestart typedef to be passed as a flag, although it's not clear to me that anything actually does pass it. Certainly removing virDomainRestart typedef from <libvirt.h> doesn't break the build, and 'make check' is also OK. The attached patch moves virDomainRestart typedef into the test driver, which is the only thing using it. Another possibility would be to go further and remove the parts of the test driver which "test" this undocumented feature. (Thanks to Tóth István for pointing out that this typedef is unused). Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] PATCH: Fix KVM / QEMU pxe boot config
by Daniel P. Berrange 12 Sep '07

12 Sep '07

The XML config for PXE boot is being parsed/formatted incorrectly by the KVM tools. It is using 'net' instead of 'network' for the <boot> tag. I had even made this mistake in the test suite :-) Patch is simple - also fixed a flaw in the test suite code Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] Start NUMA work
by Daniel Veillard 12 Sep '07

12 Sep '07

Okay enclosed is a first patch to add the new entry point for getting the available memeory in the NUMA cells: /** * virNodeGetCellFreeMemory: * @conn: pointer to the hypervisor connection * @freeMems: pointer to the array of unsigned long * @nbCells: number of entries available in freeMems * * This call allows to ask the amount of free memory in each NUMA cell. * The @freeMems array must be allocated by the caller and will be filled * with the amounts of free memory in kilobytes for each cell starting * from cell #0 and up to @nbCells -1 or the number of cell in the Node * (which can be found using virNodeGetInfo() see the nodes entry in the * structure). * * Returns the number of entries filled in freeMems, or -1 in case of error. */ int virNodeGetCellsFreeMemory(virConnectPtr conn, unsigned long *freeMems, int nbCells) based on the feedback, it seems it's better to provide an API checking a range of cells. This version suggest to always start at cell 0, it could be extended to start at a base cell number, not a big change, is it needed ? The patch adds it to the driver interfaces and put the entry point needed in the xen_internal.c module xenHypervisorNodeGetCellsFreeMemory() . From there it needs a new function (or set of functions) actually doing one hypercall to get the free mem for a NUMA cell, and the loop to fill the array @freeMems. The hard part is of course to set the definitions and code doing the hypercall: We will need to check the current hypercall version since this was added recently, see how xenHypervisorGetSchedulerType() does the versionning, we will have to write a similar routine , extend xen_op_v2_sys to add support for the availheap call structures, add the define for the availheap system call, glue the whole and call the new function from the loop in xenHypervisorNodeGetCellsFreeMemory() ... this can be a little fun to debug. Now for extending virConnectGetCapabilities() it is a bit messy not not that much. First it's implemented on Xen using xenHypervisorGetCapabilities, unfortunately it seems the easiest way to get the NUMA capabilities is by asking though xend. Calling xend_internals.c from xen_internals.c is not nice, but xenHypervisorGetCapabilities() is actually noty using any hypervisor call as far as I can see, it's all about opening/parsing files from /proc and /sys and returning the result as XML, so this could as well be done in the xend_internals (or xen_unified.c) module. so we will have a bit of surgery to do, but for the first steps of writing the patch I would not be too concerned by calling a function in xend_internal.c from xenHypervisorGetCapabilities (or xenHypervisorMakeCapabilitiesXML) we will just move those 2 in the end (only problem may be the access to hv_version variable). Hope this helps, I will not be online most of the week but I will try to help when possible :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 4

[Libvir] can't start windows guest domains
by Thomas Antony 11 Sep '07

11 Sep '07

Hi. I'm running F7 x86_64 with kernel 2.6.20-2931.fc7xen and libvirt-0.3.2-1.fc7. Since i updated to the latest versions i can't start any windows domains anymore. I thought undefine and reinstall the domains could resolve the problem, but i get the exact same error message. There is also a F7 x86_64 guest domain runnning fine on the same host. Why i can't start any windows domains anymore? [thomas@srv1 ~]$ sudo virt-install -d -n sbs -r 512 --vcpus=1 -f /dev/VolGroup01/sbs -w bridge:virbr0 --vnc -k DE -v --arch=i386 --os-type=windows --os-variant=win2k3 -c /var/www/html/install/SBS2003R2DE_DVD.iso Mon, 10 Sep 2007 20:38:28 DEBUG Path is block file: Assuming Block disk type. Disk /dev/VolGroup01/sbs is already in use by another guest! Do you really want to use the disk (yes or no)? y Starting install... libvir: Xen Daemon error : GET operation failed: libvir: Xen Daemon error : GET operation failed: Mon, 10 Sep 2007 20:38:31 DEBUG Creating guest from '<domain type='xen'> <name>sbs</name> <currentMemory>524288</currentMemory> <memory>524288</memory> <uuid>5f73764f-897c-401c-e9e5-17cb21333334</uuid> <os> <type arch='i386'>hvm</type> <loader>/usr/lib/xen/boot/hvmloader</loader> <boot dev='cdrom'/> </os> <features> <apic/><acpi/><pae/> </features> <on_poweroff>destroy</on_poweroff> <on_reboot>destroy</on_reboot> <on_crash>destroy</on_crash> <vcpu>1</vcpu> <devices> <emulator>/usr/lib64/xen/bin/qemu-dm</emulator> <console device='pty'/> <disk type='block' device='disk'> <source dev='/dev/VolGroup01/sbs'/> <target dev='hda'/> </disk> <disk type='file' device='cdrom'> <source file='/var/www/html/install/SBS2003R2DE_DVD.iso'/> <target dev='hdc'/> <readonly/> </disk> <interface type='bridge'> <source bridge='virbr0'/> <mac address='00:16:3e:33:eb:7b'/> </interface> <graphics type='vnc' port='-1' keymap='DE' /> </devices> </domain> ' libvir: Xen Daemon error : POST operation failed: (xend.err "Error creating domain: (12, 'Cannot allocate memory')") virDomainCreateLinux() failed POST operation failed: (xend.err "Error creating domain: (12, 'Cannot allocate memory')") Domain installation may not have been successful. If it was, you can restart your domain by running 'virsh start sbs'; otherwise, please restart your installation. Mon, 10 Sep 2007 20:38:31 ERROR virDomainCreateLinux() failed POST operation failed: (xend.err "Error creating domain: (12, 'Cannot allocate memory')") Traceback (most recent call last): File "/usr/bin/virt-install", line 474, in <module> main() File "/usr/bin/virt-install", line 438, in main dom = guest.start_install(conscb,progresscb) File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 710, in start_install return self._do_install(consolecb, meter) File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 727, in _do_install self.domain = self.conn.createLinux(install_xml, 0) File "/usr/lib64/python2.5/site-packages/libvirt.py", line 563, in createLinux if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self) libvirtError: virDomainCreateLinux() failed POST operation failed: (xend.err "Error creating domain: (12, 'Cannot allocate memory')") [thomas@srv1 ~]$ free total used free shared buffers cached Mem: 6154240 1312276 4841964 0 144660 600632 -/+ buffers/cache: 566984 5587256 Swap: 8323064 0 8323064 kind regards, Thomas

3 5

[Libvir] Extending libvirt to probe NUMA topology
by Ryan Harper 11 Sep '07

11 Sep '07

Hello all, I wanted to start a discussion on how we might get libvirt to be able to probe the NUMA topology of Xen and Linux (for QEMU/KVM). In Xen, I've recently posted patches for exporting topology into the [1]physinfo hypercall, as well adding a [2]hypercall to probe the Xen heap. I believe the topology and memory info is already available in Linux. With these, we have enough information to be able to write some simple policy above libvirt that can create guests in a NUMA-aware fashion. I'd like to suggest the following for discussion: (1) A function to discover topology (2) A function to check available memory (3) Specifying which cpus to use prior to domain start Thoughts? 1. http://lists.xensource.com/archives/html/xen-devel/2007-06/msg00298.html 2. http://lists.xensource.com/archives/html/xen-devel/2007-06/msg00299.html -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh(a)us.ibm.com

5 13

Re: [Libvir] Extending libvirt to probe NUMA topology
by beth kon 11 Sep '07

11 Sep '07

Daniel, I'm taking a stab at this work and want to be sure I'm taking the right approach. I'm new to xen and even newer to libvirt, so have a bit of a learning curve. For the topology information, I assume that this will be a call through xend, similar to xenDaemonNodeGetInfo. It would seem natural to somehow extend the xenDaemonNodeGetInfo with this additional information except that you suggested having the output in XML. Can you explain why you chose XML? -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

3 3

Re: [Libvir] Documentation errors and shortcomings
by Tóth István 11 Sep '07

11 Sep '07

Thanks for the replays > If an individual stats field isn't supported by the hypervisor, it > will be returned as ((long long) -1) [for various reasons we're using > long long here, but really we mean 64 bit signed int]. Thats very useful info, I spent quite a lot of time messing with BigIntegers, because I didn't want to loose the top bit. By the way, there are quite a few unisgned ints, and unsigned longs in the API. Am I right to assume that "unsigned int" is 32 bits, so It will only fit into a java long, and "unsigned long" is 64 bits, so it won't fit safely in any java primitive variable? (Apart form the stats members, as you wrote above) > Interesting, so you're using JNI direct access to the C library, right ? > I looked at this a few weeks ago, but it was looking like accessing using the > remote access would have made the Java bindings more platform independant > but I had troubles with the RPC/TLS support, and didn't go very far. Maybe > a JNI based solution is good enough for most potential Java users. I thought about that too, but then I read the stern warnings about not using the private on-the-wire protocol, so I settled on JNI. I think getting all the crypto and protocol stuff right would be more work than the JNI version, anyway. Of course since most people won't want to run the JVM as root, having to use a network URI is almost required through JNI, too. Also, I have found an other possible problem in the API/documentation: The Enum virDomainRestart is defined, but it is not referenced anywhere. Is it the flag parameter to reboot? (I've made the mistake of signing up for the digest version of the mailing list, so I can't directly reply, but I hope I won't mess up the threading) regards István

2 1

[Libvir] [PATCH] docs spelling fixes
by Eduardo Habkost 10 Sep '07

10 Sep '07

Small spelling fixes on docs/format.html. --- libvirt/docs/format.html 16 Jul 2007 21:30:30 -0000 1.25 +++ libvirt/docs/format.html 6 Sep 2007 17:29:51 -0000 @@ -59,7 +59,7 @@ </ul><p>The format of the devices and their type may grow over time, but the following should be sufficient for basic use:</p><p>A <code>disk</code> device indicates a block device, it can have two values for the type attribute either 'file' or 'block' corresponding to the 2 -options availble at the Xen layer. It has two mandatory children, and one +options available at the Xen layer. It has two mandatory children, and one optional one in no specific order:</p><ul><li>source with a file attribute containing the path in Domain 0 to the file or a dev attribute if using a block device, containing the device name ('hda5' or '/dev/hda5')</li> @@ -72,7 +72,7 @@ number of children in no specific order:</p><ul><li>source: indicating the bridge name</li> <li>mac: the optional mac address provided in the address attribute</li> <li>ip: the optional IP address provided in the address attribute</li> - <li>script: the script used to bridge the interfcae in the Domain 0</li> + <li>script: the script used to bridge the interface in the Domain 0</li> <li>target: and optional target indicating the device name.</li> </ul><p>A <code>console</code> element describes a serial console connection to the guest. It has no children, and a single attribute <code>tty</code> which @@ -237,11 +237,11 @@ <li>Virtual network <p>Provides a virtual network using a bridge device in the host. Depending on the virtual network configuration, the network may be - totally isolated,NAT'ing to aan explicit network device, or NAT'ing to + totally isolated, NAT'ing to an explicit network device, or NAT'ing to the default route. DHCP and DNS are provided on the virtual network in all cases and the IP range can be determined by examining the virtual network config with '<code>virsh net-dumpxml <network - name></code>'. There is one virtual network called'default' setup out + name></code>'. There is one virtual network called 'default'' setup out of the box which does NAT'ing to the default route and has an IP range of <code>192.168.22.0/255.255.255.0</code>. Each guest will have an associated tun device created with a name of vnetN, which can also be @@ -311,7 +311,7 @@ </li> <li>TCP tunnel <p>A TCP client/server architecture provides a virtual network. One VM - provides the server end of the netowrk, all other VMS are configured as + provides the server end of the network, all other VMS are configured as clients. All network traffic is routed between the VMs via the server. This mode is also available to unprivileged users. There is no default DNS or DHCP support and no outgoing network access. To provide outgoing @@ -411,7 +411,7 @@ </features> </guest></span> ... -</capabilities></pre><p>The fist block (in red) indicates the host hardware capbilities, currently +</capabilities></pre><p>The fist block (in red) indicates the host hardware capabilities, currently it is limited to the CPU properties but other information may be available, it shows the CPU architecture, and the features of the chip (the feature block is similar to what you will find in a Xen fully virtualized domain -- Eduardo

4 3

[Libvir] [PATCH] Allow modifying existing block device, making virDomainAttachDevice modify the device if it already exists
by Hugh Brock 10 Sep '07

10 Sep '07

The attached patch adds code to xend_internal.c:xenDomainAttachDevice that checks to see if the device mentioned in the passed-in XML already exists, and if so calls op_device_configure to modify the device. It is particularly useful for connecting and disconnecting a hardware cdrom device to an FV guest. I considered making new API a la virDomainModifyDevice, but decided overloading virDomainAttachDevice was cleaner (and didn't change existing API). I have tested the patch on f7 with xen 3.1 and a windows 2000 guest. Since the patch merely wraps Xen's device_configure call, we're not adding much risk of breakage. Please ACK. Take care, --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

3 4

[Libvir] Documentation errors and shortcomings
by Tóth István 10 Sep '07

10 Sep '07

Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have their arguments listed either on libvirt.org, or in the docs folder in the distribution list, even though there is a a documentation block in the actual source file. I guess it's some kind of problem with the tool used for generating the docs. 2. The virConnectGetCapabilities function docs says that it returns an opaque pointer to a struct, when in fact it returns an XML string describing the capabilities. 3. I have found no sanctioned way to actually get the data from DomainBlockStats and DomainInterfaceStats. The strucures are defined as _virDomainBlockStats and struct _virDomainInterfaceStats, and there is only an *Ptr type typedef-ed on them, as in the case of, say virConnectPtr, which IS really meant to be opaque. I believe that the fields of these structs ARE meant to be read by the applications linking the library, and are not really meant to be opaque. (or if they are, they should have some functions/macros that you can access their contents with) I think the right way to fix this would be simply to typedef them as typedef struct _virDomainBlockStats virDomainBlockStats; typedef struct _virDomainInterfaceStats DomainInterfaceStats; expose their fields in the documentation, and not call them opaque ( i.e. treat them just like virSchedParameter) best regards István

4 3

[Libvir] [PATCH] Support Sun's Compiler
by Mark Johnson 07 Sep '07

07 Sep '07

The following patch allows libvirt to be compiled with Sun's CC compiler. tested on today's CVS bits on a FC7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) Thanks, MRJ

2 3

[Libvir] Documentation errors and shortcomings
by Toth Istvan 07 Sep '07

07 Sep '07

Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have their arguments listed either on libvirt.org, or in the docs folder in the distribution list, even though there is a a documentation block in the actual source file. I guess it's some kind of problem with the tool used for generating the docs. 2. The virConnectGetCapabilities function docs says that it returns an opaque pointer to a struct, when in fact it returns an XML string describing the capabilities. 3. I have found no sanctioned way to actually get the data from DomainBlockStats and DomainInterfaceStats. The strucures are defined as _virDomainBlockStats and struct _virDomainInterfaceStats, and there is only an *Ptr type typedef-ed on them, as in the case of, say virConnectPtr, which IS really meant to be opaque. I believe that the fields of these structs ARE meant to be read by the applications linking the library, and are not really meant to be opaque. (or if they are, they should have some functions/macros that you can access their contents with) I think the right way to fix this would be simply to typedef them as typedef struct _virDomainBlockStats virDomainBlockStats; typedef struct _virDomainInterfaceStats DomainInterfaceStats; expose their fields in the documentation, and not call them opaque ( i.e. treat them just like virSchedParameter) best regards István

1 0

[Libvir] Documentation errors and shortcomings
by Toth Istvan 07 Sep '07

07 Sep '07

Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have their arguments listed either on libvirt.org, or in the docs folder in the distribution list, even though there is a a documentation block in the actual source file. I guess it's some kind of problem with the tool used for generating the docs. 2. The virConnectGetCapabilities function docs says that it returns an opaque pointer to a struct, when in fact it returns an XML string describing the capabilities. 3. I have found no sanctioned way to actually get the data from DomainBlockStats and DomainInterfaceStats. The strucures are defined as _virDomainBlockStats and struct _virDomainInterfaceStats, and there is only an *Ptr type typedef-ed on them, as in the case of, say virConnectPtr, which IS really meant to be opaque. I believe that the fields of these structs ARE meant to be read by the applications linking the library, and are not really meant to be opaque. (or if they are, they should have some functions/macros that you can access their contents with) I think the right way to fix this would be simply to typedef them as typedef struct _virDomainBlockStats virDomainBlockStats; typedef struct _virDomainInterfaceStats DomainInterfaceStats; expose their fields in the documentation, and not call them opaque ( i.e. treat them just like virSchedParameter) best regards István

1 0

[Libvir] Memory leak in XenHypervisorMakeCapabilitiesXML?
by beth kon 07 Sep '07

07 Sep '07

Hi. Seems to me there is a memory leak with the strdup function in xenHypervisorMakeCapabilitiesXML. Looking up the chain of calls leading to xenHypervisorMakeCapabilitiesXML, I don't see the required free for the hidden malloc in the strdup. The same problem may exist with other strdups in the code. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] build problem
by Mark Johnson 07 Sep '07

07 Sep '07

I'm having problems building the libvirt cvs bits (clean) on FC 7. I'm sure I'm doing something stupid?? I don't see xdr_qemud_packet_client anywhere in the source? Any ideas? Thanks, MRJ ../src/.libs/libvirt_la-qemu_internal.o: In function `qemuProcessRequest': /home/mrj/libvirt/src/qemu_internal.c:312: undefined reference to `xdr_qemud_packet_client' /home/mrj/libvirt/src/qemu_internal.c:375: undefined reference to `xdr_qemud_packet_server' collect2: ld returned 1 exit status make[3]: *** [xmlrpctest] Error 1 make[3]: Leaving directory `/home/mrj/libvirt.hg/tests' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/mrj/libvirt.hg/tests' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/mrj/libvirt.hg' make: *** [all] Error 2

2 2

[Libvir] libvirt statistics
by Richard W.M. Jones 06 Sep '07

06 Sep '07

[Using `pahole' and friends - see http://git.kernel.org/?p=linux/kernel/git/acme/pahole.git;a=summary and https://ols2006.108.redhat.com/2007/Reprints/melo-Reprint.pdf ] These are all on x86-64. You'll get slightly different results on a 32 bit arch. Largest structures, by size: qemud_vm_def: 16608 4 qemud_vm_os_def: 16436 1 _testConn: 14504 2 qemud_vm: 12368 2 qemud_network: 8240 0 qemud_vm_disk_def: 4376 2 qemud_driver: 4192 1 qemud_vm_net_def: 4136 2 xenXMConfCache: 4112 0 _virProxyFullPacket: 4096 0 _xmlParserCtxt: 696 5 _virDriver: 432 1 utsname: 390 0 _testDom: 360 0 _xmlXPathContext: 352 4 xenUnifiedDriver: 328 0 dirent: 280 0 _xmlSAXHandler: 256 1 _IO_FILE: 216 2 _xenUnifiedPrivate: 192 1 qemud_network_def: 192 2 _xmlDoc: 168 2 _virConnect: 168 0 _testNet: 156 0 Structures with holes which could be made smaller by packaging (third number is how many bytes you'd save per allocation): qemud_vm 12368 12360 8 qemud_vm_def 16608 16600 8 private_data 56 48 8 remote_domain_get_info_ret 40 32 8 XDR 48 40 8 xen_v0_vcpuinfo 40 32 8 _xmlValidCtxt 112 104 8 _xmlEntity 136 128 8 _xmlParserCtxt 696 672 24 _testConn 14504 14496 8 _xmlURI 80 72 8 _xmlXPathObject 72 56 16 _xmlXPathParserContext 80 72 8 _xmlXPathContext 352 336 16 _xmlError 88 80 8 _xmlAttr 96 88 8 _xmlDoc 168 160 8 _xmlNode 120 112 8 _IO_FILE 216 208 8 _virDomainInfo 40 32 8 Longest functions (NB: long functions are not a bad thing -- read Steve McConnell). qemudParseVMDef: 9680 doRemoteOpen: 6631 xenXMParseXMLToConfig: 5678 xenXMDomainFormatXML: 5678 xend_parse_sexp_desc: 5424 qemudBuildCommandLine: 5204 virDomainParseXMLDesc: 3503 qemudGenerateXML: 2556 __virErrorMsg: 2332 testOpenFromFile: 2210 call: 2206 qemudStartNetworkDaemon: 2105 virDomainParseXMLOSDescHVM: 2078 qemudParseNetworkDef: 2023 xenHypervisorMakeCapabilitiesXML: 1838 virDomainParseXMLDiskDesc: 1686 qemudStartVMDaemon: 1683 xenXMConfigCacheRefresh: 1547 xenXMParseXMLDisk: 1545 virConfParseValue: 1516 virConfParse: 1457 qemudScanConfigDir: 1396 testLoadNetwork: 1353 dhcpStartDhcpDaemon: 1259 virXen_getvcpusinfo: 1257 testLoadDomain: 1244 qemudDomainSave: 1194 virDomainParseXMLIfDesc: 1164 xenHypervisorInit: 1104 xenXMDomainDefineXML: 1083 iptablesAddRemoveRule: 1081 testOpen: 1075 Functions with the most variables (perhaps a better indicator of "complexity", I know that doRemoteOpen is a bloody complicated function for example): xenXMDomainFormatXML: 18 virDomainParseXMLDesc: 18 doRemoteOpen: 18 testLoadDomain: 17 xenHypervisorMakeCapabilitiesXML: 16 testLoadNetwork: 15 xenXMParseXMLDisk: 14 xenStoreLookupByName: 13 xend_parse_sexp_desc: 13 virDomainParseXMLDiskDesc: 13 testOpenFromFile: 12 qemudBuildCommandLine: 12 xenStoreDomainGetNetworkID: 10 xenDaemonDomainGetVcpus: 10 virDomainParseXMLOSDescHVM: 10 qemudParseInterfaceXML: 10 xenXMParseXMLVif: 9 xenXMParseXMLToConfig: 9 xenXMDomainDefineXML: 9 query_parse: 9 iptablesAddRemoveRule: 9 xenStoreListDomains: 8 xenHypervisorLookupDomainByUUID: 8 xenHypervisorInit: 8 xenDaemonListDomainsOld: 8 virDomainParseXMLOSDescPV: 8 virDomainParseXMLIfDesc: 8 testNetworkDumpXML: 8 testDomainDumpXML: 8 qemudNetworkIfaceConnect: 8 qemudGenerateXML: 8 qemudDomainSave: 8 Functions with more than one "goto" label: qemudAddIptablesRules: 10 doRemoteOpen: 4 xenDaemonOpen: 3 qemudStartNetworkDaemon: 3 qemudExtractVersionInfo: 3 xenXMDomainFormatXML: 2 xenHypervisorInit: 2 xend_parse_sexp_desc: 2 virParseXMLDevice: 2 __virGetNetwork: 2 __virGetDomain: 2 virDomainXMLDevID: 2 remoteForkDaemon: 2 query_parse: 2 qemudStartup: 2 qemudNetworkIfaceConnect: 2 qemudGenerateXML: 2 qemudBuildCommandLine: 2 negotiate_gnutls_on_connection: 2 Functions with the most parameters (in C these are dangerous because of C's lousy typechecking): __virRaiseError: 12 xenXMConfigSetIntFromXPath: 8 xenUnifiedDomainMigratePrepare: 8 xenDaemonDomainMigratePrepare: 8 __virDomainMigratePrepare: 8 remoteDomainMigratePrepare: 8 qemudReadMonitorOutput: 8 call: 8 xenXMConfigSetStringFromXPath: 7 xenUnifiedDomainMigratePerform: 7 xenDaemonDomainMigratePerform: 7 _virExec: 7 __virDomainMigratePerform: 7 remoteDomainMigratePerform: 7 xenUnifiedDomainMigrateFinish: 6 xend_op_ext2: 6 virXen_getvcpusinfo: 6 virExecNonBlock: 6 virExec: 6 virDomainParseXMLOSDescHVM: 6 __virDomainMigrateFinish: 6 virDomainMigrate: 6 remoteDomainMigrateFinish: 6 All global variables (nothing wrong with global variables, I say): extern unsigned int __invalid_size_argument_for_IOC; /* 0 */ struct qemu_feature_flags arch_info_i686_flags[4]; /* 0 */ struct qemu_feature_flags arch_info_x86_64_flags[3]; /* 0 */ struct qemud_driver * qemu_driver; /* 0 */ struct qemu_arch_info qemudArchs[7]; /* 1 */ extern struct _IO_FILE * stderr; /* 9 */ extern struct _IO_FILE * stdin; /* 23 */ extern struct _IO_FILE * stdout; /* 23 */ enum /**/ virDrvOpenRemoteFlags; /* 0 */ struct xenUnifiedDriver xenDaemonDriver; /* 1 */ struct xenUnifiedDriver xenHypervisorDriver; /* 1 */ struct xenUnifiedDriver xenProxyDriver; /* 1 */ struct xenUnifiedDriver xenStoreDriver; /* 1 */ struct xenUnifiedDriver xenXMDriver; /* 1 */ extern xmlFreeFunc xmlFree; /* 3 */ extern xmlMallocFunc xmlMalloc; /* 0 */ Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 3

[Libvir] feature sujestions
by Márcio Parise Boufleur 06 Sep '07

06 Sep '07

Hello, I'm a grad student from Brazil. I was looking for some interesting project to do as my final work and it I think that contributing to your project would be a great achievement to me. Do you have some kind list with feature suggestions? I am particularly interested in remote administration. I helped a colleague to write a graphical tool to administrate a remote Xen site last year. Thank you. MB -- Computers are useless; they can only give you answers! -- Picasso

5 7

[Libvir] Compiling libvirt v0.3.2 on centos5
by Meng Kuan 05 Sep '07

05 Sep '07

Hi, Here is what I did when I tried to upgrade the libvirt on my centos5 system to the latest version. sudo yum install python-devel xen-devel libxml2-devel readline- devel gnutls-devel wget ftp://libvirt.org/libvirt/libvirt-0.3.2-1.src.rpm sudo rpmbuild --rebuild libvirt-0.3.2-1.src.rpm ... ... RPM build errors: InstallSourcePackage: Header V3 DSA signature: NOKEY, key ID de95bc1f user veillard does not exist - using root user veillard does not exist - using root Installed (but unpackaged) file(s) found: /usr/share/doc/libvirt-0.3.2/html/FAQ.html /usr/share/doc/libvirt-0.3.2/html/Libxml2-Logo-90x34.gif /usr/share/doc/libvirt-0.3.2/html/examples.xml /usr/share/doc/libvirt-0.3.2/html/examples.xsl /usr/share/doc/libvirt-0.3.2/html/html/book1.html /usr/share/doc/libvirt-0.3.2/html/html/home.png /usr/share/doc/libvirt-0.3.2/html/html/index.html /usr/share/doc/libvirt-0.3.2/html/html/left.png /usr/share/doc/libvirt-0.3.2/html/html/libvirt-bridge.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-conf.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt- gnutls_1_0_compat.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-lib.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-libvirt.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-util.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-uuid.html /usr/share/doc/libvirt-0.3.2/html/html/libvirt-virterror.html /usr/share/doc/libvirt-0.3.2/html/html/right.png /usr/share/doc/libvirt-0.3.2/html/html/up.png /usr/share/doc/libvirt-0.3.2/html/info1.c /usr/share/doc/libvirt-0.3.2/html/libvir.html /usr/share/doc/libvirt-0.3.2/html/redhat.gif /usr/share/doc/libvirt-0.3.2/html/suspend.c /usr/share/doc/libvirt-python-0.3.2/TODO /usr/share/doc/libvirt-python-0.3.2/examples/basic.py /usr/share/doc/libvirt-python-0.3.2/examples/create.py /usr/share/doc/libvirt-python-0.3.2/examples/error.py /usr/share/doc/libvirt-python-0.3.2/examples/node.py /usr/share/doc/libvirt-python-0.3.2/examples/uuid.py I tried to get around this by putting the following in the ~/.rpmmacros file (according to this webpage http://www.rpm.org/ hintskinks/unpackaged/): _unpackaged_files_terminate_build 0 _missing_doc_files_terminate_build 0 However, that does not seem to help. Any ideas? Should I just install the binary packages instead of building from source? cheers, mengkuan

4 5

[Libvir] [PATCH]OpenVZ Enhancements - Cleaned up
by Shuveb Hussain 03 Sep '07

03 Sep '07

Hi, Attached are the OpenVZ driver enhancements. Cleanups have been done according to Daniel .V's suggestions. Please see my previous mail for summary. Cheers, Shuveb Hussain http://www.binarykarma.com

2 2

[Libvir] libvirt on Windows
by Ronald Long 31 Aug '07

31 Aug '07

I am trying to talk to a 4.0.1 Xen Hypervisor (not Xen underneath a Linux Distro) (via Python) from a Windows box. (Am able to successfully connect and communicate using the Xen API Python bindings). Looks like at the very least I need to build libvirtmon.la from the c sources. Am I just dealing with "beginneritis", or trying to do something (run from Windows) that hasn't been done before? thanks ronald

2 1

[Libvir] Ruby bindings for libvirt
by Meng Kuan 31 Aug '07

31 Aug '07

Hi, I am exploring the possibility of creating ruby bindings for libvirt. The only attempt I found after some searching is this: http://www.cs.ucsb.edu/~ckrintz/racelab/jisha/ Following the SWIG method as described in the above URL, I have gotten to the following point: [root@dell1 libvirt_ruby]# irb irb(main):001:0> require 'libvirt_ruby' => true irb(main):002:0> conn = Libvirt_ruby.virConnectOpenReadOnly("") => #<SWIG::TYPE_p__virConnect:0x2aaaaabc46c8> irb(main):003:0> dom = Libvirt_ruby.virDomainLookupByID(conn, 0) => #<SWIG::TYPE_p__virDomain:0x2aaaaabb5df8> irb(main):004:0> ret = Libvirt_ruby.virDomainGetInfo(dom, info) NameError: undefined local variable or method `info' for main:Object from (irb):4 irb(main):005:0> I am not sure how to create and pass in a ptr to a virDomainInfo struct object into the virDomainGetInfo call within ruby. Note that I was trying to following the info1.c example on the libvirt website: http://libvirt.org/examples/info1.c As you can tell, this is the first time I am trying to create any sort of language bindings for a C library. Some questions: 1. Is there a better way of creating ruby bindings for libvirt besides SWIG? If so, any pointers on what should be done? 2. Alternatively I can try to make my ruby code use libvirt-python bindings as a python library. Has anyone done so? Any problems with this approach? cheers, mengkuan

3 4

[Libvir] --without-*
by Mark Johnson 30 Aug '07

30 Aug '07

Hi all, Merging up to 0.3.2 on Solaris finally.. I had a couple of things on my list of hacked patches, and not being a configure expert I figured I would ask here... How hard it is to change the config logic to account for the various --without's. e.g. --without-qemu, o ./Makefile.in - SUBDIRS shouldn't include qemud o ./src/Makefile.in o am__objects_1 shouldn't include: o libvirt_la-bridge.lo o libvirt_la-iptables.lo o libvirt_la-qemu_driver.lo o libvirt_la-qemu_conf.lo o client sources, build rules, etc for the above. --without-test (Incuding srcs, rules, etc) o libvirt_la-test.lo, etc... --without-xen (Incuding srcs, rules, etc) o libvirt_la-xen_internal.lo o libvirt_la-xs_internal.lo o libvirt_la-xend_internal.lo --without-remote (Incuding srcs, rules, etc) o libvirt_la-remote_internal.lo o am_libvirt_la_OBJECTS shouldn't include am__objects_2 One other thing I was curious about... I noticed the remote code uses remote_protocol* out of the ./qemud dir.. I was just curious if I should expect that to move somewhere else soon, or if you were going to leave it there? Thanks, Mark.

2 2

[Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()
by Masayuki Sunou 30 Aug '07

30 Aug '07

Hi VirBufferVSprintf() loops endless when it receives over 2000 bytes, because the return value of vsnprintf() is more than "size - 1". It is because the maximum of "size" is 1999 bytes. --> the maximum of "buf->size - buf->use" = 2000 (1000(argument of virBufferGrow()) + 1000(set in virBufferGrow())) So, virBufferEscapeString() has the same problem. This patch sets to virBufferGrow() the size of the data which VirBufferVSprintf()(virBufferEscapeString()) received when it is over 1000 bytes. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/buf.c =================================================================== RCS file: /data/cvs/libvirt/src/buf.c,v retrieving revision 1.3 diff -u -p -r1.3 buf.c --- src/buf.c 9 Jul 2007 11:24:52 -0000 1.3 +++ src/buf.c 24 Aug 2007 05:56:37 -0000 @@ -159,7 +159,7 @@ virBufferContentAndFree (virBufferPtr bu int virBufferVSprintf(virBufferPtr buf, const char *format, ...) { - int size, count; + int size, count, grow_size; va_list locarg, argptr; if ((format == NULL) || (buf == NULL)) { @@ -172,7 +172,8 @@ virBufferVSprintf(virBufferPtr buf, cons locarg)) < 0) || (count >= size - 1)) { buf->content[buf->use] = 0; va_end(locarg); - if (virBufferGrow(buf, 1000) < 0) { + grow_size = (count > 1000) ? count : 1000; + if (virBufferGrow(buf, grow_size) < 0) { return (-1); } size = buf->size - buf->use - 1; @@ -198,7 +199,7 @@ virBufferVSprintf(virBufferPtr buf, cons int virBufferEscapeString(virBufferPtr buf, const char *format, const char *str) { - int size, count, len; + int size, count, len, grow_size; char *escaped, *out; const char *cur; @@ -248,7 +249,8 @@ virBufferEscapeString(virBufferPtr buf, while (((count = snprintf(&buf->content[buf->use], size, format, (char *)escaped)) < 0) || (count >= size - 1)) { buf->content[buf->use] = 0; - if (virBufferGrow(buf, 1000) < 0) { + grow_size = (count > 1000) ? count : 1000; + if (virBufferGrow(buf, grow_size) < 0) { free(escaped); return (-1); } ----------------------------------------------------------------------

2 2

[Libvir] ANNOUNCE: virt-top 0.3.2.5 released
by Richard W.M. Jones 29 Aug '07

29 Aug '07

I'm pleased to announce a new release of virt-top, which is a utility like 'top' that works for virtual machines. Many keys and command line options are the same as for ordinary top. Thanks to all the people who have been playing with it and sending me feedback. This version adds block device and network statistics (if supported by the hypervisor and libvirt). This version also fixes a bug where it would fail silently if unable to contact the hypervisor. Main page: http://et.redhat.com/~rjones/virt-top/ Source and binaries for several architectures available from: http://et.redhat.com/~rjones/virt-top/download.html If you have Fedora 7, this will probably work: yum --enablerepo=development install virt-top Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] TX/RX network stats are swapped
by Richard W.M. Jones 29 Aug '07

29 Aug '07

I noticed that the stats reported by virDomainInterfaceStats appeared to be swapped around. If the domain was downloading a lot of information, then tx_bytes would increase quickly (I'd expect rx_bytes to increase more if the domain was downloading). The problem is that xen_internal.c measures the TX/RX from the point of view of dom0. So that if dom0 is TRANSMITTING a lot of data up to the domain, then that domain is really RECEIVING it. Yes, I feel like an idiot ... Fix attached. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

[Libvir] [PATCH] Block device and network stats (version 2)
by Richard W.M. Jones 29 Aug '07

29 Aug '07

This patch adds block device and network stats. The main changes over the previous version are: * Remote support. * Change Xen network interface names to have the form "vif<domid>.<n>"[1]. Discussions about the previous version may be found starting here: https://www.redhat.com/archives/libvir-list/2007-August/thread.html#00064 I have left use of stdint.h / int64_t, since it wasn't clear to me what conclusion people had arrived at. I left the explicit structure size parameter to allow for future extensibility. Also attached is the output of: virsh -c xen+tls://amd/ domifstat fc6_1 vif2.0 Rich. [1] There is currently no way to get the interface name except to just know it -- that is the subject of a separate patch. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903 libvirt: virConnectOpen (name=xen+tls://amd/) libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: do_open: proceeding with name=xen+tls://amd/ libvirt: do_open: trying driver 0 (Test) ... libvirt: do_open: driver 0 Test returned DECLINED libvirt: do_open: trying driver 1 (QEMU) ... libvirt: do_open: driver 1 QEMU returned DECLINED libvirt: do_open: trying driver 2 (Xen) ... libvirt: do_open: driver 2 Xen returned DECLINED libvirt: do_open: trying driver 3 (remote) ... libvirt: do_open: driver 3 remote returned SUCCESS libvirt: do_open: network driver 0 Test returned DECLINED libvirt: do_open: network driver 1 QEMU returned DECLINED libvirt: do_open: network driver 2 remote returned SUCCESS libvirt: virDomainLookupByName (conn=0x130ee020, name=fc6_1) libvirt: virDomainInterfaceStats (domain=0x13129bd0, path=vif2.0, stats=0x7fff688e6e20, size=64) libvirt: virDomainFree (domain=0x13129bd0) libvirt: virConnectClose (conn=0x130ee020) vif2.0 rx_bytes 18591 vif2.0 rx_packets 113 vif2.0 rx_errs 0 vif2.0 rx_drop 0 vif2.0 tx_bytes 125319 vif2.0 tx_packets 962 vif2.0 tx_errs 0 vif2.0 tx_drop 0

5 17

[Libvir] [PATCH] Fix return value of virsh vncdisplay
by Masayuki Sunou 29 Aug '07

29 Aug '07

Hi Virsh vncdisplay always returns 1, because return value is not set in the case of normal end. ------------------------------------ # virsh vncdisplay test :0 # echo $? 1 ------------------------------------ This patch fixes it. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: libvirt/src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.100 diff -u -p -r1.100 virsh.c --- libvirt/src/virsh.c 21 Aug 2007 11:53:52 -0000 1.100 +++ libvirt/src/virsh.c 28 Aug 2007 06:33:03 -0000 @@ -2919,6 +2919,7 @@ cmdVNCDisplay(vshControl * ctl, vshCmd * } xmlXPathFreeObject(obj); obj = NULL; + ret = TRUE; cleanup: if (obj) ----------------------------------------------------------------------

2 1

[Libvir] [PATCH] Delete a harmful variable in xend_parse_sexp_desc()
by Masayuki Sunou 27 Aug '07

27 Aug '07

Hi Xend_parse_sexp_desc() of xend_internal.c declares a variable named "ret" to buffer SXP. However, it actually uses "buf.content" not "ret" and allocates memory to "buf" when size of "ret" became insufficient. --> virBufferAdd(&buf, ...);, virBufferVSprintf(&buf, ...) So freeing "ret" fails, because "ret" refers to an address unlike "buf.contents" As a result, a segmentation fault occurs. This patch fixes so that xend_parse_sexp_desc() uses "buf.contents" not "ret". Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.135 diff -u -p -r1.135 xend_internal.c --- src/xend_internal.c 21 Aug 2007 09:31:12 -0000 1.135 +++ src/xend_internal.c 27 Aug 2007 07:47:03 -0000 @@ -1346,7 +1346,6 @@ xend_parse_sexp_desc_os(virConnectPtr xe static char * xend_parse_sexp_desc(virConnectPtr conn, struct sexpr *root, int xendConfigVersion) { - char *ret; struct sexpr *cur, *node; const char *tmp; char *tty; @@ -1362,10 +1361,9 @@ xend_parse_sexp_desc(virConnectPtr conn, /* ERROR */ return (NULL); } - ret = malloc(4000); - if (ret == NULL) + buf.content = malloc(4000); + if (buf.content == NULL) return (NULL); - buf.content = ret; buf.size = 4000; buf.use = 0; @@ -1762,11 +1760,11 @@ xend_parse_sexp_desc(virConnectPtr conn, virBufferAdd(&buf, "</domain>\n", 10); buf.content[buf.use] = 0; - return (ret); + return (buf.content); error: - if (ret != NULL) - free(ret); + if (buf.content != NULL) + free(buf.content); return (NULL); } --------------------------------------------------------------------------------

2 1

[Libvir] OpenVZ driver enhancements
by Shuveb Hussain 24 Aug '07

24 Aug '07

Hi, I'm glad to make available patches for the OpenVZ driver that provide the following features: * virDomainDefineXML - Defines an OpenVZ domain and does not start it. Takes XML description of the domain as input. * virDomainCreateLinux - Starts a domain based on the provided XML description. There is no way to start a domain in OpenVZ without defining it. So, it is defined anyway, as of now. :-( There may be a way to get around this. We are looking into it. As of now, treat this as define + start. * virDomainUndefine - removes domain from OpenVZ management. Since OpenVZ manages the domain's root file system, it is also lost. This behaviour is different from Xen. The XML Format for OpenVZ: -------------------------- <domain type='openvz'> <name>108</name> <uuid>8dea22b31d52d8f32516782e98ab8fa0</uuid> <container> <filesystem> <template>fedora-core-3-i386-minimal</template> <quota level = 'first'>123</quota> <quota level = 'second' uid = '500'>534</quota> </filesystem> <network> <ipaddress>192.168.1.108</ipaddress> <hostname>fedora-minimal</hostname> <gateway>192.168.1.1</gateway> <nameserver>192.168.1.1</nameserver> <netmask>255.255.255.0</netmask> </network> <profile>vps.basic</profile> </container> </domain> The name is the VPS "ID". The VPS ID is not temporary in OpenVZ as in Xen. The "<template>" tag in the "<filesystem>" section tells libvirt which OS template cache to use to create the VPS file system. Quota is not implemented as yet. First and second level quotas are intended to be supported. The "<profile>" tag must be a valid profile name from which VPS parameter are inherited. Other things, I guess are self explanatory. Other issues: ------------- * Moved some static declarations from the header to the .c files. * Fixed a small bug that cause libvirtd to crash on remote client exit. Patches are against CVS head. Regards, -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

2 1

[Libvir] Libvirt with Gentoo and Udev
by Stefan Bottelier 22 Aug '07

22 Aug '07

Hello, I have the follow problem with libvirt and Gentoo. I will be use virt-manager for my xen server on my Gentoo machine, zo i have libvirt afcors to use. virt-manager are in the portage of Gentoo. When i start libvirt i get the follow message. libvir: QEMU error : failed to set bridge STP to on Failed to autostart network 'default': failed to set bridge STP to on So i watch in my /var/log/messages for the error. I see the follow Aug 20 17:51:04 localhost udev-net.sh: /etc/init.d/net.vnet0: does not exist or is not executable So i create the vnet0 bridge interface in gentoo. Then i will restart libvirt. I see in /var/log/messages the follow error rc-scripts: We only hotplug for ethernet interfaces if its possibale to run udev and gentoo with libvirt? Or is zombie the can help me with this problem of if this working on Gentoo ? Thanks , Stefan P.s the option of /etc/init.d/net.vnet0 start --verbose will not be working, http://forums.gentoo.org/viewtopic-t-577325.html

1 0

[Libvir] Release of libvirt-0.3.2
by Daniel Veillard 21 Aug '07

21 Aug '07

No releases for nearly a month, it was time to push a new one, so 0.3.2 is available from : ftp://libvirt.org/libvirt/ There is more changes that I initially though. I will probably make a new release within a week to update things which were left out from 0.3.2, * New features: - KVM migration and save/restore (Jim Paris) - added API for migration (Richard Jones) - added APIs for block device and interface statistic (Richard Jones). * Documentation: - examples for XML network APIs - fix typo and schedinfo synopsis in man page (Atsushi SAKAI) - hypervisor support page update (Richard Jones). * Bug fixes: - remove a couple of leaks in QEmu/KVM backend(Daniel berrange) - fix GnuTLS 1.0 compatibility (Richard Jones) - --config/-f option mistake for libvirtd (Richard Jones) - remove leak in QEmu backend (Jim Paris) - fix some QEmu communication bugs (Jim Paris) - UUID lookup though proxy fix - setvcpus checking bugs (with Atsushi SAKAI) - int checking in virsh parameters (with Masayuki Sunou) - deny devices attach/detach for < Xen 3.0.4 (Masayuki Sunou) - XenStore query memory leak (Masayuki Sunou) - virsh schedinfo cleanup (Saori Fukuta). * Improvement: - virsh new ttyconsole command - networking API implementation for test driver (Daniel berrange) - qemu/kvm feature reporting of ACPI/APIC (David Lutterkort) - checking of QEmu architectures (Daniel berrange) - improve devices XML errors reporting (Masayuki Sunou) - speedup of domain queries on Xen (Daniel berrange) - augment XML dumps with interface devices names (Richard Jones) - internal API to query drivers for features (Richard Jones). * Cleanups: - Improve virNodeGetInfo implementation (Daniel berrange) - general UUID code cleanup (Daniel berrange) - fix API generator file selection. thanks to everybody who helped contribute to this new release with ideas, reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] ANNOUNCE: ocaml-libvirt 0.3.2.0 (libvirt bindings for OCaml) released
by Richard W.M. Jones 21 Aug '07

21 Aug '07

The changes are: - virDomainMigrate supported - virDomainBlockStats, virDomainInterfaceStats supported - mlvirsh migrate - mlvirsh domblkstat and domifstat - now compiles with any libvirt >= 0.3.0 - uses autoconf to generate the ./configure script http://et.redhat.com/~rjones/ocaml-libvirt/ Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] Show Xen vif<domid>.<n> device name in domain XML
by Richard W.M. Jones 21 Aug '07

21 Aug '07

This patch changes the Xen domain XML so that it shows the target device (ie. vif<domid>.<n>), which you can then use to collect interface stats. For example: # virsh dumpxml fc6_1 ... <interface type='bridge'> <source bridge='xenbr0'/> <target dev='vif2.0'/> <mac address='00:16:3e:1a:2f:8c'/> <script path='vif-bridge'/> </interface> Note that this patch only adds to the XML, it doesn't change any XML that was being returned before. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 3

[Libvir] [PATCH] Cleanup xs_internal.c
by Masayuki Sunou 21 Aug '07

21 Aug '07

Hi Blanks and Tabs coexist in xs_internal.c. This patch replaces a tab by blanks in xs_internal.c. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou.

4 6

[Libvir] [PATCH] Update hvsupport page
by Richard W.M. Jones 21 Aug '07

21 Aug '07

The three independent patches attached update the hvsupport page: (1) Document that KVM now supports save & restore. [Q: This is just kvm, or any qemu?] (2) Document the introduction of virDomainMigrate call. (3) Document the introduction of virDomainBlockStats and virDomainInterfaceStats calls. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 2

[Libvir] [PATCH] Check availability of driver calls
by Richard W.M. Jones 21 Aug '07

21 Aug '07

This is a repost of a patch I sent before which adds the ability to check for driver features. This is completely internal to libvirt and does not add any public APIs. The original discussion is here: https://www.redhat.com/archives/libvir-list/2007-July/thread.html#00437 and continues here: https://www.redhat.com/archives/libvir-list/2007-August/thread.html#00000 Daniel Veillard said: >> +typedef int >> + (*virDrvSupportsFeature) (virConnectPtr conn, virDrvFeature feature); > >I would rather use , int features) where you OR the features, allows >to know in one call if you get what you want or not. My objection to that is here: https://www.redhat.com/archives/libvir-list/2007-August/msg00000.html Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

4 6

[Libvir] [PATCH] virDomainMigrate version 5 (repost)
by Richard W.M. Jones 20 Aug '07

20 Aug '07

This is a repost of version 5 patch. Previous discussion of version 5: https://www.redhat.com/archives/libvir-list/2007-July/thread.html#00357 Previous discussion of version 4: https://www.redhat.com/archives/libvir-list/2007-July/thread.html#00304 (This is separate from the feature patch, but in reality if the feature patch goes in, then I'd modify this patch slightly to make it use feature detection). Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

[Libvir] [PATCH] check the file name for --log
by Atsushi SAKAI 20 Aug '07

20 Aug '07

Hi, This patch fixes the trouble if execute virsh with virsh --log --debug. In this case FILE "--debug" is generated and --debug is off. This patch treat as error return if it uses the hyphen "-" at the head of log file name. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI

4 8

[Libvir] question about --quiet option
by Atsushi SAKAI 20 Aug '07

20 Aug '07

Hi, I have a question about virsh --quiet specification. It seems virsh --quiet option supress virsh interactive mode boot-message and vshPrintExtra only.(not includes vshPrint) This is supposed specification. Thanks Atsushi SAKAI

2 1

[Libvir] Re: [et-mgmt-tools] ANNOUNCE: virt-viewer release 0.0.1
by Daniel P. Berrange 20 Aug '07

20 Aug '07

On Fri, Aug 17, 2007 at 04:10:52PM +0200, Gerd Hoffmann wrote: > Hi, > > > To connect to the guest with ID 7 running under QEMU > > > > virt-viewer --connect qemu:///system 7 > > Can we *please* think about a standardized environment variable to set > the default for --connect and which all tools are looking at? Yes, this would be useful. > virsh has VIRSH_DEFAULT_CONNECT_URI for that. > > I'd like to have *one* variable used by *all* libvirt-based tools, > virt-viewer, virt-manager, virsh, ... We could simply reuse the virsh > variable, or we could pick some other name without virsh in there, > preferable also shorter and thus easier to remember. VIRT_URI maybe? We should probably apply the change to libvirt, so that if 'NULL' is used for the connect URI for virConnectOpen, and VIRT_CONNECT_URI is set, then NULL gets substituted with the value of the env variable. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 3

[Libvir] Set memory (decrease) from Virt Manager
by Bruce Evans 20 Aug '07

20 Aug '07

Hi, I am trying to lower the amount of memory for a Domain using the Virt manager. I am denied from doing this if I want to decrease the memory below 50MB, even though I can do it from virsh. There appears to be a low end limit of 50MB in the Virt Manager. If the current memory allocation is greater than 50MB, I can decrease the amount from Virt Manager, but can't go under 50MB. But if I use virsh, I can decrease the memory to, say, 13000KB and it works. The Virt Manger will show this new amount but will only enable the 'increase' icon in the 'Change Allocation option box. The 'decrease' icon is disabled. Is this a bug in Virt Manager? If not, why can't the memory be decreased below 50MB? Thanks, -Bruce Sun Microsystems Systems Virtualiztion

2 1

[Libvir] Stability of virsh / libvirt interfaces
by John Levon 17 Aug '07

17 Aug '07

This has probably been discussed before so apologies. What is the current status of the interfaces, especially libvirt and virsh? Are they guaranteed to be stable? Does this apply to every new interface as soon as a release is done? (I ask after noticing that virsh schedinfo can be used to *set* parameters!) thanks john

3 3

[Libvir] [PATCH] Fix some memory leaks of virsh schedinfo
by Saori Fukuta 17 Aug '07

17 Aug '07

Hi, There are some memory leaks at the virsh schedinfo command. So I fix them. (e.g.) When the virDomainSetSchedulerParameters failed, the allocated memory as params is not freed. # valgrind --leak-check=full virsh schedinfo PV_RH5_8 --weight 0 ==18879== Memcheck, a memory error detector. ==18879== Copyright (C) 2002-2006, and GNU GPL'd, by Julian Seward et al. *snip* ==18879== 92 bytes in 1 blocks are definitely lost in loss record 6 of 23 ==18879== at 0x40053C0: malloc (vg_replace_malloc.c:149) ==18879== by 0x80531D5: _vshMalloc (virsh.c:4201) ==18879== by 0x804BC44: cmdSchedinfo (virsh.c:1033) ==18879== by 0x80526CF: vshCommandRun (virsh.c:3839) ==18879== by 0x805452A: main (virsh.c:4741) ==18879== ==18879== LEAK SUMMARY: ==18879== definitely lost: 92 bytes in 1 blocks. ==18879== possibly lost: 0 bytes in 0 blocks. ==18879== still reachable: 14,234 bytes in 293 blocks. ==18879== suppressed: 0 bytes in 0 blocks. Signed-off-by: Saori Fukuta <fukuta.saori(a)jp.fujitsu.com> Thanks, Saori Fukuta

2 1

[Libvir] [PATCH] Fix some memory leaks in xs_internal.c
by Masayuki Sunou 17 Aug '07

17 Aug '07

Hi Some memory releases is missed in xs_internal.c. This patch fixes it. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/xs_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xs_internal.c,v retrieving revision 1.47 diff -u -p -r1.47 xs_internal.c --- src/xs_internal.c 10 Aug 2007 18:25:15 -0000 1.47 +++ src/xs_internal.c 17 Aug 2007 05:19:00 -0000 @@ -578,6 +578,8 @@ xenStoreListDomains(virConnectPtr conn, #endif ids[ret++] = (int) id; } + if (idlist) + free(idlist); return(ret); } @@ -637,11 +639,10 @@ xenStoreLookupByName(virConnectPtr conn, path = xs_get_domain_path(priv->xshandle, (unsigned int) id); if (!found) - return(NULL); + goto done; ret = virGetDomain(conn, name, NULL); if (ret == NULL) { - if (path != NULL) free(path); goto done; } ret->id = id; @@ -651,6 +652,8 @@ done: free(xenddomain); if (idlist != NULL) free(idlist); + if (path != NULL) + free(path); return(ret); } ----------------------------------------------------------------------

2 1

[Libvir] [PATCH] Check the version of Xen in xenDaemonAttachDevice()
by Masayuki Sunou 16 Aug '07

16 Aug '07

Hi When virsh attach-disk/attach-interface is executed in < Xen 3.0.4, the OS type of domain is NULL in xenDaemonAttachDevice(). As a result, the command becomes segmentation fault. This patch fixes it by checking the version of Xen in xenDaemonAttachDevice(). Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.132 diff -u -p -r1.132 xend_internal.c --- src/xend_internal.c 9 Aug 2007 20:19:12 -0000 1.132 +++ src/xend_internal.c 16 Aug 2007 07:38:42 -0000 @@ -3091,6 +3091,9 @@ xenDaemonAttachDevice(virDomainPtr domai priv = (xenUnifiedPrivatePtr) domain->conn->privateData; + if (domain->id < 0 && priv->xendConfigVersion < 3) + return(-1); + str = virDomainGetOSType(domain); if (strcmp(str, "linux")) hvm = 1; ----------------------------------------------------------------------

3 3

[Libvir] [PATCH] Check a value in vshCommandOptInt()
by Masayuki Sunou 16 Aug '07

16 Aug '07

Hi When the option which should set a number is set a character which is not a number, the value is changed into 0 in libvirt. It causes the movement not expected. ex) # virsh vcpupin dom_name A 0,1 => VCPU0 is pinned without the command becoming the error. This patch fixes it by checking the value in vshCommandOptInt(). Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.95 diff -u -p -r1.95 virsh.c --- src/virsh.c 14 Aug 2007 07:07:57 -0000 1.95 +++ src/virsh.c 16 Aug 2007 07:13:46 -0000 @@ -3699,12 +3699,16 @@ static int vshCommandOptInt(vshCmd * cmd, const char *name, int *found) { vshCmdOpt *arg = vshCommandOpt(cmd, name); - int res = 0; + int res = 0, num_found = TRUE; + char *end_p=NULL; if (arg) - res = atoi(arg->data); + res = strtol(arg->data, &end_p, 10); + if (arg->data == end_p) { + num_found = FALSE; + } if (found) - *found = arg ? TRUE : FALSE; + *found = (arg && num_found) ? TRUE : FALSE; return res; } ----------------------------------------------------------------------

2 1

[Libvir] Networking functions in libvirt
by Bruce Evans 15 Aug '07

15 Aug '07

Hello, I am now starting to investigate the networking driver callback functions in libvirt. struct _virNetworkDriver { virDrvOpen open; virDrvClose close; virDrvNumOfNetworks numOfNetworks; virDrvListNetworks listNetworks; virDrvNumOfDefinedNetworks numOfDefinedNetworks; virDrvListDefinedNetworks listDefinedNetworks; virDrvNetworkLookupByUUID networkLookupByUUID; virDrvNetworkLookupByName networkLookupByName; virDrvNetworkCreateXML networkCreateXML; virDrvNetworkDefineXML networkDefineXML; virDrvNetworkUndefine networkUndefine; virDrvNetworkCreate networkCreate; virDrvNetworkDestroy networkDestroy; virDrvNetworkDumpXML networkDumpXML; virDrvNetworkGetBridgeName networkGetBridgeName; virDrvNetworkGetAutostart networkGetAutostart; virDrvNetworkSetAutostart networkSetAutostart; }; My question is from the point of view of the Virtual Manager GUI. From the controls available in the GUI, what actions are intended to be done, via the network callback functions? Are the actions only client related? Create a vnet, vdisk, etc? Or are they also intended for server actions, create a switch service, disk service, etc? There is no example in the test.c program, so I don't have any example to look at. Also, is there any documentation describing the network callback functions? TIA, -Bruce Evans Sun Microsystems Systems Virtualization

2 1

[Libvir] [patch] virsh setvcpus range check for negative value case
by Atsushi SAKAI 15 Aug '07

15 Aug '07

Hi, This patch adds virsh setvcpus range check for negative value case. for example to the inactive domain virsh setvcpus -1 sets vcpus=4294967295 And cannot boot the inactive domain. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI

2 2

[Libvir] [PATCH] fix UUID lookup when using the proxy
by Daniel Veillard 14 Aug '07

14 Aug '07

Chasing a bug at Red Hat I noticed that the code never copied the UUID onto the packet sent to the proxy, which of course makes things harder. Finding why this still worked on 32bits hosts is left as an exercise for interested readers ! (of course I wrote that code on a 32 bits machine at the time) One line patch enclosed, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] fix SYNOPSIS of virsh --help schedinfo
by Atsushi SAKAI 14 Aug '07

14 Aug '07

fix SYNOPSIS of virsh --help schedinfo. from sched to schedinfo Thanks Atsushi SAKAI

2 1

[Libvir] several typo fixes on man virsh
by Atsushi SAKAI 14 Aug '07

14 Aug '07

Hi, several typo fixes on man virsh (uses ispell) interract -> interact suports -> supports privledges -> privileges synoposis -> synopsis documetnation -> documentation runable -> runnable Ouput -> Output guaruntee -> guarantee processus -> processes (2 typo) Detatch -> Detach dvices -> devices instanciated -> instantiated Thanks Atsushi SAKAI

2 1

[Libvir] [PATCH 0/7] QEMU/KVM save/restore support, take 3
by Jim Paris 14 Aug '07

14 Aug '07

Here's take 3 of the QEMU/KVM save/restore support. Thanks for your input. Changes since last time: - Remove escape sequence filtering, it's not necessary. - Clean up stdin handling in virExec, use -1 to signify unused - Add signal-safe read/write wrappers that handle EINTR and use them. - Add version and padding to image header, and check version on restore. - Include null-termination in XML data & length - Show name of conflicting domain in error message Everything seems to work well in my tests. I've run into a few rare cases where the migration doesn't work correctly (causing segfaults in the guest, or kvm to crash), but it's not libvirt's fault, and libvirt handles the failures well. (I suspect it's related to http://article.gmane.org/gmane.comp.emulators.kvm.devel/5583) Thanks, -jim

3 17

[Libvir] save/restore support for KVM
by Jim Paris 13 Aug '07

13 Aug '07

Hi, I've implemented save/restore support for KVM using the live migration feature. First, a few patches to KVM to fix bugs: Subject: [PATCH 1/3] qemu: fix freed pointer dereference http://article.gmane.org/gmane.comp.emulators.kvm.devel/5572 Subject: [PATCH 2/3] qemu: don't start a new migration if one is already in progress http://article.gmane.org/gmane.comp.emulators.kvm.devel/5575 Subject: [PATCH 3/3] qemu: reset buffer pointers after CR/LF http://article.gmane.org/gmane.comp.emulators.kvm.devel/5573 (If compatibility with old KVM is wanted, it might be possible to work around the kvm bugs in other ways, but I'm not sure). Then, another patch to KVM to support inbound migration from a filename. It already supports migration from stdin, but adding this seemed easier from a libvirt perspective. Subject: [PATCH] qemu: accept filename for incoming migration http://article.gmane.org/gmane.comp.emulators.kvm.devel/5590 Finally, the libvirt side. Some notes: - Arbitrary decisions about VM status: I pause the VM before starting migration, and destroy it once it's finished. Neither is required by KVM but I'd be concerned about the disk image state otherwise. Also, after resuming, the VM is still paused. I don't know how Xen behaves in this regard but the behavior here is easy enough to change. - I append the domain's UUID at the end of the migration image. This doesn't affect KVM at all (it ignores the extra data). Does that seem reasonable? It's unclear how the saved image is supposed to get associated with a particular VM configuration without doing something like this. - I added the migrateFrom field to the qemu_vm struct. Dunno if that's the best place. Could also add put it in qemu_vm_def, or add parameters to qemudStartVMDaemon, etc.. Patch against current CVS is below. Signed-off-by: Jim Paris <jim(a)jtan.com> -jim Index: src/qemu_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.c,v retrieving revision 1.10 diff -u -r1.10 qemu_conf.c --- src/qemu_conf.c 7 Aug 2007 13:02:35 -0000 1.10 +++ src/qemu_conf.c 9 Aug 2007 21:15:10 -0000 @@ -1518,7 +1518,8 @@ (vm->def->os.initrd[0] ? 2 : 0) + /* initrd */ (vm->def->os.cmdline[0] ? 2 : 0) + /* cmdline */ (vm->def->graphicsType == QEMUD_GRAPHICS_VNC ? 2 : - (vm->def->graphicsType == QEMUD_GRAPHICS_SDL ? 0 : 1)); /* graphics */ + (vm->def->graphicsType == QEMUD_GRAPHICS_SDL ? 0 : 1)) + /* graphics */ + (vm->migrateFrom[0] ? 3 : 0); /* migrateFrom */ snprintf(memory, sizeof(memory), "%d", vm->def->memory/1024); snprintf(vcpus, sizeof(vcpus), "%d", vm->def->vcpus); @@ -1767,6 +1768,15 @@ /* SDL is the default. no args needed */ } + if (vm->migrateFrom[0]) { + if (!((*argv)[++n] = strdup("-S"))) + goto no_memory; + if (!((*argv)[++n] = strdup("-incoming"))) + goto no_memory; + if (!((*argv)[++n] = strdup(vm->migrateFrom))) + goto no_memory; + } + (*argv)[++n] = NULL; return 0; Index: src/qemu_conf.h =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.h,v retrieving revision 1.6 diff -u -r1.6 qemu_conf.h --- src/qemu_conf.h 30 Jul 2007 09:59:06 -0000 1.6 +++ src/qemu_conf.h 9 Aug 2007 21:15:10 -0000 @@ -213,6 +213,7 @@ char configFile[PATH_MAX]; char autostartLink[PATH_MAX]; + char migrateFrom[PATH_MAX]; struct qemud_vm_def *def; /* The current definition */ struct qemud_vm_def *newDef; /* New definition to activate at shutdown */ Index: src/qemu_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_driver.c,v retrieving revision 1.14 diff -u -r1.14 qemu_driver.c --- src/qemu_driver.c 30 Jul 2007 09:59:06 -0000 1.14 +++ src/qemu_driver.c 9 Aug 2007 21:15:10 -0000 @@ -656,7 +656,7 @@ if (virExecNonBlock(conn, argv, &vm->pid, &vm->stdout, &vm->stderr) == 0) { vm->id = driver->nextvmid++; - vm->state = VIR_DOMAIN_RUNNING; + vm->state = vm->migrateFrom[0] ? VIR_DOMAIN_PAUSED : VIR_DOMAIN_RUNNING; driver->ninactivevms--; driver->nactivevms++; @@ -1852,29 +1852,151 @@ return 0; } +#define QEMUD_SAVE_MAGIC "LibvirtQemudUUID" -static int qemudDomainSave(virDomainPtr dom, - const char *path ATTRIBUTE_UNUSED) { +static int qemudDomainSave(virDomainPtr dom, + const char *path) { struct qemud_driver *driver = (struct qemud_driver *)dom->conn->privateData; struct qemud_vm *vm = qemudFindVMByID(driver, dom->id); + char *command, *info; + int fd; + if (!vm) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, "no domain with matching id %d", dom->id); + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + "no domain with matching id %d", dom->id); return -1; } + if (!qemudIsActiveVM(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, "domain is not running"); + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "domain is not running"); return -1; } - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, "save is not supported"); - return -1; + + if (strchr(path, '\'') || strchr(path, '\\') ) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "invalid filename"); + return -1; + } + + /* Pause */ + if (qemudDomainSuspend(dom) != 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "failed to pause domain"); + return -1; + } + + /* Migrate to file. */ + if (asprintf (&command, "migrate \"exec:dd of='%s' 2>/dev/null\"\n", + path) == -1) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "out of memory"); + return -1; + } + + if (qemudMonitorCommand(driver, vm, command, &info) < 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "migrate operation failed"); + free(command); + return -1; + } + + free(info); + free(command); + + /* Append the UUID, which we'll need in order to restore the domain. */ + if ((fd = open(path, O_APPEND|O_WRONLY)) < 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "failed to open '%s'", path); + return -1; + } + + if (write(fd, QEMUD_SAVE_MAGIC, sizeof(QEMUD_SAVE_MAGIC)) != + sizeof(QEMUD_SAVE_MAGIC)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "failed to write magic"); + close(fd); + return -1; + } + + if (write(fd, dom->uuid, VIR_UUID_BUFLEN) != VIR_UUID_BUFLEN) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "failed to write uuid"); + close(fd); + return -1; + } + close(fd); + + /* Shut it down */ + qemudShutdownVMDaemon(dom->conn, driver, vm); + if (!vm->configFile[0]) + qemudRemoveInactiveVM(driver, vm); + + return 0; } static int qemudDomainRestore(virConnectPtr conn, - const char *path ATTRIBUTE_UNUSED) { - /*struct qemud_driver *driver = (struct qemud_driver *)conn->privateData;*/ - qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, "restore is not supported"); - return -1; + const char *path) { + struct qemud_driver *driver = (struct qemud_driver *)conn->privateData; + unsigned char uuid[VIR_UUID_BUFLEN]; + unsigned char magic[sizeof(QEMUD_SAVE_MAGIC)]; + virDomainPtr dom; + struct qemud_vm *vm; + int fd; + + /* Find the UUID */ + if ((fd = open(path, O_RDONLY)) < 0) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + "cannot read domain image"); + return -1; + } + if (lseek(fd, 0 - (sizeof(magic) + sizeof(uuid)), SEEK_END) == -1) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + "failed to seek to end of domain image"); + close(fd); + return -1; + } + if (read(fd, magic, sizeof(magic)) != sizeof(magic)) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + "failed to read domain image"); + close(fd); + return -1; + } + if (memcmp(magic, QEMUD_SAVE_MAGIC, sizeof(magic))) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + "image magic is not correct"); + close(fd); + return -1; + } + if (read(fd, uuid, sizeof(uuid)) != sizeof(uuid)) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + "failed to read domain UUID from image"); + close(fd); + return -1; + } + close(fd); + + /* Find the domain & vm */ + dom = qemudDomainLookupByUUID(conn, uuid); + if (!dom) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INVALID_DOMAIN, + "no domain with matching uuid"); + return -1; + } + + vm = qemudFindVMByUUID(driver, dom->uuid); + if (!vm) { + qemudReportError(conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + "no vm with matching uuid"); + return -1; + } + + /* Set the migration source and start it up. */ + snprintf(vm->migrateFrom, sizeof(vm->migrateFrom), "file://%s", path); + vm->migrateFrom[sizeof(vm->migrateFrom)-1] = '\0'; + + return qemudStartVMDaemon(dom->conn, driver, vm); } @@ -1931,6 +2053,7 @@ return -1; } + vm->migrateFrom[0] = '\0'; return qemudStartVMDaemon(dom->conn, driver, vm); }

4 30

[Libvir] [PATCH] Block device and network stats
by Richard W.M. Jones 13 Aug '07

13 Aug '07

This is the implementation (currently Xen, local only). It includes a couple of virsh commands if you want to play with looking at the stats. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 6

[Libvir] PATCH: Fix paravirt FB with xm driver
by Daniel P. Berrange 10 Aug '07

10 Aug '07

The code for dealing with the paravirt framebuffer was missing code to deal with an explicit vncdisplay=N setting - only working for vncunused=1. It was also not flexible enough in processing the 2 different styles of FB config. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5

[Libvir] PATCH: Fix virtual neworks with xm driver
by Daniel P. Berrange 10 Aug '07

10 Aug '07

The virtual networks stuff was never added to the xm driver for Xen 3.0.3 or earlier. This means that if adding a virtual network the bridge device won't get defined in the config. This patch addreses this, and also fixes a tiny mem leak in the equivalent code in the xend driver. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] PATCH: Improve performance on Xen
by Daniel P. Berrange 10 Aug '07

10 Aug '07

The Xen implementations of virDomainLookupByID virDomainLookupByUUID virDomainLookupByName virDomainGetOSType all have sub-optimal performance since they speak to XenD. The lookupXXX functions all basically require 3 pieces of info in the end (name,id,uuid). They each get given one piece & have to lookup the other piece. Every running domain has to have an entry in XenStore on /local/domain/N where 'N' is the id. Under this location there is always a 'name' field. So if we have the id we can efficiently get the name. I just realized that the getdomaininfo hypercall struct contains the uuid and id. So for the ByID and ByUUID calls we can get all the info we need with a hypercall and a read of xenstore. This is very efficient compared to hitting XenD. As of Xen 3.1.0 hypervisor the flags in the getdomaininfo hypercall struct also mark whether the guest is HVM vs paraivrt, so we can also implement the GetOSType api with a single hypercall. That just leaves the ByName impl. The only way I can think of doing this is to scan /local/domain/N in xenstore until we find it. I'm going to try this, but I'm not convinced it'll be any significantly than talking to XenD. I may be surprised though. Any for the 3 improvements I have done, the 'virsh dominfo' call has improved when using either ID or UUID: Create a set of UUIDs & IDs # for i in `seq 1 500` ; do echo dominfo 73 ; done > ids.txt # for i in `seq 1 500` ; do echo dominfo 8f07fe28-753f-2729-d76d-bdbd892f949a ; done > uuids.txt Now before measurements: # time ./virsh < ids.txt > /dev/null real 0m17.317s user 0m0.144s sys 0m0.164s # time ./virsh < uuids.txt > /dev/null real 0m14.432s user 0m0.236s sys 0m0.460s Against the after measurements: # time ./virsh < demo.txt > /dev/null real 0m0.259s user 0m0.100s sys 0m0.072s # time ./virsh < demo.txt > /dev/null real 0m0.482s user 0m0.324s sys 0m0.108s A pretty good speedup really considering how frequently these calls are made if you're monitoring domains frequently. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5

[Libvir] Proposal: Block device and network stats
by Richard W.M. Jones 10 Aug '07

10 Aug '07

With the very timely question that has been raised about block and network device stats, I'm posting my proposed interface. I almost have this working for the Xen case on my test machine. The idea of this interface is to be optimised for the following case: * stats need to be fetched frequently (eg. once per second) * the layout of devices doesn't change often (ie. adding or removing devices from domains is very infrequent) * most domains have only a single block and single network device With the above assumptions, the idea is that you would use the API like this: (1) When the program starts up or (infrequently) is notified of a change or when a new domain appears, the program calls virDomainGetXMLDesc and parses out the //domain/devices/interface and //domain/devices/disk fields to get the list of network interfaces and block devices. So for each domain, you'll have two lists like this: dom[1]["blockdevs"] = ["xvda"] dom[1]["interfaces"] = ["virbr0"] (2) Frequently (eg. once per second) the program calls (in the above case): virDomainBlockStats (dom1, "xvda", &bstats, sizeof bstats); virDomainInterfaceStats (dom1, "virbr0", &istats, sizeof istats); (3) Since stats are cumulative the program must do its own subtraction and calculation in order to display throughput per second. The implementation goes directly from the name "xvda" to the backend device (/sys/devices/xen-backend/- [type]-[domid]-[major:minor]/statistics) for block devices, and slightly more complicatedly to a particular line in /proc/net/dev for network interfaces. (Note in the Xen case, the name "virbr0" is little more than a placeholder to mean "the zeroth interface for domain d"). In particular the current implementation doesn't cache anything. This should all work fine in the Linux / Xen case. libxenstat gives us sample code that we can copy for the Solaris / Xen case, but it would need testing from someone with access to such a machine. I don't think qemu supports stats at all. Initially we won't support stats for tap devices because there needs to be an upstream patch to support this (http://lists.xensource.com/archives/html/xen-changelog/2007-02/msg00278.html) The extra size parameter will allow us to extend the stats structures in future, maintaining binary backwards compatibility with existing clients. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 7

[Libvir] Xen physical host statistics
by Mindaugas Kiznis 10 Aug '07

10 Aug '07

Hello, - I am trying to make an application, which would connect to a remote xen host and fetch some information about total (physical) CPU usage, total memory usage, network and disk I/O. I have managed to do a remote statistics grabber for CPU and memory usage using libvirt. I couldn't find any source of information about libvirt ability to return I/O numbers. Also haven't found any other solution yet. Any suggestions? Thank you in advance! Best regards, Mindaugas Kiznis

3 4

[Libvir] PATCH: UUID code cleanup
by Daniel P. Berrange 09 Aug '07

09 Aug '07

Browsing the source I noticed we have many differents constants for UUID length, many ways of turning a UUID into a string, 2 ways of turning a string into a UUID (one with some scary signed <-> unsigned casting). This is just a result of the way the code evolved & I figured it could do with cleaning up a little. So I added a virUUIDFormat(const unsigned char uuid, char *uuidstr) method to the uuid.c, removed all the other equivalent code throughout and kiled all the duplicate constants. So now everything UUID related is in the one place uuid.c, while the constants are in libvirt/libvirt.h Its a surprisingly big patch, but it should not have any functional change with one exception. The XenD driver used to generate XML <uuid>...</uuid> tags without any '-' embedded in them. All other places use the '-' and technically the RFC requires them. Our parser is flexible enough to cope with, or without '-'. diffstat ~/libvirt-uuid-cleanup.patch proxy/Makefile.am | 2 - qemud/internal.h | 2 - src/libvirt.c | 34 +++------------------------- src/openvz_conf.c | 14 +++++------ src/openvz_conf.h | 3 -- src/qemu_conf.c | 20 ++++++---------- src/qemu_conf.h | 5 +--- src/test.c | 18 +++++---------- src/uuid.c | 57 +++++++++++++++++++++++++++++++++-------------- src/uuid.h | 13 ++++------ src/xend_internal.c | 62 +++++++++++++++++++--------------------------------- src/xm_internal.c | 31 +++++--------------------- src/xml.c | 61 --------------------------------------------------- src/xml.h | 1 14 files changed, 104 insertions(+), 219 deletions(-) Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 3

[Libvir] ANNOUNCE: Virt-top - a top-like utility for displaying virtualization stats
by Richard W.M. Jones 09 Aug '07

09 Aug '07

I'm pleased to announce the first release of virt-top, which is a top-like utility for displaying virtualization stats. It aims to look and feel very much like regular 'top', so as to be as familiar as possible for systems administrators. You can also use it as a pleasant replacement for xentop. It uses libvirt, so can display stats across a variety of different hypervisors and virtualization systems (not just Xen, although that is where the testing has gone so far). http://et.redhat.com/~rjones/virt-top/ The license is a combination of LGPL (for the library) and GPL (for the virt-top program). Current status -------------- You can view domains and use familiar keys like 'P'/'M'/... to sort by processor/memory/..., and 'd'/'s' to set the delay between updates. Also some common top command-line options are implemented. The man page is here: http://et.redhat.com/~rjones/virt-top/virt-top.txt There are a variety of source and binary RPMs available for Fedora users. I don't yet have a working Debian/Ubuntu package, but will have a go at making one tomorrow. The next thing I'll be working on is showing virtual and physical CPU usage of guests. After that I'm hoping to discuss extensions to libvirt to make other interesting statistics available to virt-top, in particular disk and network I/O stats. There are a few data collection artifacts which need to be investigated. In particular, %CPU sometimes goes over 100%. Obviously accurate data collection is an important goal for this tool. Memory usage is good: typical 'RES' (in regular top) for virt-top is just under 2.5 MB, and I've had it running for hours at a time without memory usage increasing, which seems to indicate that there aren't any major memory leaks. Development ----------- The program is currently very small: exactly 500 lines of code! If you want to dive in and send me patches they are most welcome, but remember that I'm trying to make this utility act as much like 'top' as possible, so if 'top' does it in a particular way, then I'd prefer virt-top to do the same thing. (May not apply to obscure top functionality, if top does something silly). If you're a systems administrator, not a programmer, and you'd like virt-top to have some particular feature, then please let me know, and I will be happy to review it and code it for you. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

4 10

[Libvir] libvirt daemon UNIX socket auth with PolicyKit
by Daniel P. Berrange 08 Aug '07

08 Aug '07

Currently our authentication model for local connections is using the basic UNIX file permissions, possibly with a setuid helper (in Xen case only). It can be summarized as - If app using libvirt is running as root => full access - Else => read only access The latter is enforced by fact that in Xen case libvirt_proxy only has impl for a handful of read only APIs, or in non-Xen case that the UNIX domain socket for the daemon /var/run/libvirt/libvirt-sock is mode 0700, while /var/run/libvirt/libvirt-sock-ro is 0777 & the daemon enforces based on which socket the client connects to. This is good because it allows non-root to at least monitor guest state while requiring root authentication for actually changing state. This is bad because it requires any app which wants to change state to run as root. ie we are required to launch virt-manager as root to gain ability to manage local guests. Problem with this include: - running the entire PyGTK & GTK & X codebase as root is undesirable - no integration with the DBus desktop session (gnome-vfs integartion) - no integration with the GNOME keyring (for VNC server passwords) - redundant (&dangerous) if all you want to do is manage remote libvirt hosts In summary what I really need for virt-manager is - Always run as non-root - Authenticate for local guest management (ie read+write) UNIX domain sockets already provide a way for each end to identify the PID and UID of the other end. This enables the libvirt daemon to determine the identity of the application on the other end. With this information the daemon merely needs to check this identity against some access control policy rules. Where to get/define these rules though ? Enter PolicyKit. http://lists.freedesktop.org/archives/hal/2006-March/004770.html http://lists.freedesktop.org/archives/hal/2007-June/008815.html PolicyKit is a freedesktop.org project to replace all the distro specific 'do admin stuff as root' hacks like consolehelper[1], sudo, gksudo with a standard mechanism. Most importantly this mechanism does not require that the application in question run as root, or ever gain root privileges. In addition this is completely configurable by the administrator in a application independant manner. How would the daemon use PolicyKit for authenticating clients on UNIX domain sockets - libvirtd defines two actions it can check called 'libvirt-local-monitor (read only monitoring of state), and 'libvirt-local-manage' (full read-write management). - Both libvirt-sock and libvirt-sock-ro are mode 0777 (ie all users) - A connection arrives on the UNIX domain socket either libvirt-sock-ro or libvirt-sock - libvirtd use SO_PEERCRED to get the PID of the client - If the connection is on libvirt-sock-ro 'action' is 'libvirt-local-monitor' Else if connection is on libvirt-sock 'action' is 'libvirt-local-manage' - Libvirt asks policy kit if PID is allowed to perform the 'action' -> Yes, connection proceeds -> No, connection is dropped NB, having two separate UNIX domain sockets is strictly speaking redundant now - the daemon could simply check each 'action' in turn - but keeping the separate sockets simplifies the code, because it minimises the diffs when PolicyKit is not enabled by the 'configure' script. How is policy determined by PolicyKit ? - libvirt RPM provides /usr/share/PolicyKit/policy/libvirt.policy - This file defines the two actions it supports 'libvirt-local-monitor' and 'libvirt-local-manage'. - For each action we define a default policy for an active desktop session, and an inactive desktop session. The sample policy is to allow 'libvirt-local-monitor' for any local desktop session, but only allow 'libvirt-local-manage' for the active session with the additional requirement that the user authenticate with PolicyKit using the root password. This basically replicates the existing security semantics, without requiring that we run virt-manager itself as root. This accomplishes the core goal. There are other benefits to PolicyKit though - the administrator can override the application provided default Policy. For example, could add a rule that says "if the user fred is logged into the local X session, allow them to do 'libvirt-local-manage' without any further prompts for root password" Since PolicyKit is a general framework, that rule could be generalized beyond just virt-manager "if the user fred is logged into the local X session, allow them to do any defined action without any further prompts for root password" Or going the other way the administrator can lock things down requiring a root password even for read only monitoring of VMs. Or a halfway house of requiring the user's own password (sudo equiv, instead of su equiva). If course this doesn't just apply to virt-manager either. This transparently 'just works' for virsh too & any other apps using libvirt - eg if policy grants 'libvirt-local-manage' then you can do full management whether virsh is root or not. This all talks about enforcement of policy from the daemon side. There is one outstanding question - if the policy so requires, where/how do we ask the user to enter their credentials. PolicyKit provides two mechanisms for this: - A command line tool polkit-grant which uses pam to authenticate you as root, or using your own user password. If successful you will have been granted the permission to perform that action for the remainder of the session. - A DBus service for triggering display of some UI for authenticating. There is a GNOME impl of this service & likely a KDE impl too. eg with virsh start off without any priveleges $ virsh --connect qemu:///system net-list libvir: Remote error : Connection reset by peer error: failed to connect to the hypervisor error: no valid connection $ polkit-grant --action libvirtd-local-manage2 Authentication is required. Password: Keep this privilege for the session? [no/session]? $ ./src/virsh --connect qemu:///system net-list --all Name State Autostart ----------------------------------------- default active yes One option is to have the libvirt library spawn polkit-grant if not finding any $DISPLAY, and call the DBus service (for UI prompt) if finding any. The other option is to punt this code upto the application - eg virt-manager always call the DBus service, while virsh always call polkit-grant. Finally, PolicyKit is new in Fedora 8 if you wish to try this out. The configure script is setup so that it automagically detects presence of PolicyKit and only turns it on at compile time if its available. The fallback is to continue current behaviour of restricting based on the socket permissions. http://fedoraproject.org/wiki/Releases/FeaturePolicyKit Finally, finally, if we enable PolicyKit support, then we should disable the Xen specific libvirt_proxy setuid binary, since it would subvert the policy for libvirt-local-monitor. IMHO we should just kill the setuid binary altogether, since we already require that the libvirt daemon be running for the networking APIs & this provides read-only access already which works for non-Xen drivers too. Attaching the patch implementing the proof of concept $ diffstat ~/libvirt-policykit.patch configure.in | 60 ++++++++++++++++++-- qemud/Makefile.am | 12 +++- qemud/internal.h | 23 ++++++- qemud/libvirtd.policy | 41 ++++++++++++++ qemud/qemud.c | 145 ++++++++++++++++++++++++++++++++++++++++++++------ qemud/remote.c | 6 +- 6 files changed, 258 insertions(+), 29 deletions(-) Oh, finally, finally, finally. PolicyKit is pretty new so I'd understand if there's some resistance to including it in an official libvirt release at this point. I think the patch is small enough that we could carry it as add-on in the Fedora RPMs only to start with untill its proved to be maintainable long term - I really need this for Fedora 8 to make virt-manager work sanely - ie not need to run as root. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 9

[Libvir] [PATCH] A variety of fixes for Debian, old versions of GnuTLS
by Richard W.M. Jones 07 Aug '07

07 Aug '07

Attached is a patch to get libvirt working on Debian/stable again. (1) Add ./configure option --disable-stack-protector. The stack protector feature is still enabled by default, but it causes no end of problems when compiling on Debian systems, apparently because of bugs in their gcc. So Debian users would be well advised to try disabling it if they have problems building. (2) Adds support for GnuTLS 1.0.x by detecting this version and enabling some simple compatibility macros. (3) In qemudDispatchClientEvent, a prototype shadowed a global function name. A simple name change to a parameter fixes it. (4) Debian (and likely non-Linux systems also) don't have the SIOCBRADDBR and related ioctls. If these are missing, then I've changed this to runtime errors. This means that these systems won't be able to start the network daemon, but other (non-network) features of libvirt continue to work. (5) Removed a warning in src/qemu_conf.c. Rich. PS. You need to drop the file gnutls_1_0_compat.h into src/ subdirectory. Sorry this file isn't in the proper patch but I don't have write access to CVS from the testing machine. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 3

[Libvir] [PATCH] Fix libvirtd --config / -f option
by Richard W.M. Jones 07 Aug '07

07 Aug '07

As well as fixing the --config/-f option for libvirtd, this also changes an abort() into a meaningful error message. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 4

[Libvir] ANNOUNCE: OCaml bindings 0.3.1.0 released
by Richard W.M. Jones 02 Aug '07

02 Aug '07

http://et.redhat.com/~rjones/ocaml-libvirt/ This removes use of the dangerous vir{Domain,Network}GetConnect functions and makes the relationship between domains, networks and connections explicit to the garbage collector. I've also added support for domain migration. mlvirtmanager displays the hostname when connected to multiple remote hosts (see screenshot attached). Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] check file format in virsh attach/detach-device
by Masayuki Sunou 02 Aug '07

02 Aug '07

Hi virsh attach/detach-devich does not check file format now. This patch checks config file format is XML or not. (in virsh attach/detach-device) If file format is not XML, just return the error with message. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks, Masayuki Sunou.

3 4

[Libvir] Proposal: Check availability of driver calls (repost)
by Richard W.M. Jones 01 Aug '07

01 Aug '07

-- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 9

[Libvir] Exporting calls just to libvirtd
by Richard W.M. Jones 31 Jul '07

31 Jul '07

With the two patches[1][2] I recently posted, the remote driver has started to make calls more directly into the drivers. Calls like driver->domainMigratePrepare in [2] are exposed to the remote driver, but shouldn't be exported for public use. However because libvirtd links to regular libvirt.so, the calls actually do need to be exported, so we export them as __virDomainMigratePrepare (etc) with the double underscore and exclusion from <libvirt.h> indicating that users of the published libvirt API should not call them. It seems we could avoid exporting them entirely with one of these methods: (a) Link libvirtd to the static libvirt.a. -- Probably violates a load of distro policy and removes some supposed benefits of dynamic linking. (b) Build a separate shared library with a different dynamic symbol table. -- Also removes one benefit of dynamic linking, because the two libraries are different despite having the same code in them. Any ideas if some advanced feature of ELF offers a way out here? Rich. [1]https://www.redhat.com/archives/libvir-list/2007-July/msg00444.html [2]https://www.redhat.com/archives/libvir-list/2007-July/msg00357.html -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] PATCH: Check for bogus default architecture
by Daniel P. Berrange 31 Jul '07

31 Jul '07

There was a missing check in the QEMU driver for a bogus architecture in the XML which could cause a crash. This wasn't a problem except for the fact that another bug in my recent virt-install 0.200.0 release passed a bogus architecture on 32-bit platforms :-( Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH: Overhaul the test driver
by Daniel P. Berrange 31 Jul '07

31 Jul '07

The test driver has suffered from quite alot of bitrot. Its got all sorts of checks in the driver entry points already done by libvirt.c, its got private data, redundantly pointing to private data, it doesn't implement any of the networking APIs, is missing alot of the newer domain APIs. So I've given it a thorough overhaul to remove alot of redundant code, clean up more, and add entry points for all the APIs except for VCPU pinning ones. The addition of the networking APIs means we no longer get errors thrown when trying to run tests without the libvirt daemon running, and means apps can actually do tests for their networking capabilities. docs/testnetdef.xml | 12 docs/testnetpriv.xml | 11 docs/testnode.xml | 2 src/driver.h | 1 src/libvirt.c | 17 src/qemu_driver.c | 1 src/remote_internal.c | 1 src/test.c | 1892 +++++++++++++++++++++++++++++++------------------- tests/virshtest.c | 465 +++--------- 9 files changed, 1382 insertions(+), 1020 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH Fix a couple of mem leaks
by Daniel P. Berrange 31 Jul '07

31 Jul '07

I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating correctness of parsing routines - its not really tried doing any validation of failure scenaarios. So I fear there's probably a number of error code paths where we don't cleanup properly, and/or don't reject invalid data. Its an area which should be addressed by someone with some copious free time ;-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] PATCH 0/2: Capabilities and features
by David Lutterkort 30 Jul '07

30 Jul '07

Hi, these two patches extend the features libvirt reports in the capabilities XML; in particular, features are now reported for the QEMU driver, and features for both Xen and QEMU include information on ACPI/APIC support. Tools that rely on feature reporting, in general, need to know whether a certain feature is on or off by default, and whether that can be toggled, because users will be asking for one of three things for their VM: * Feature X (e.g., ACPI) must be on/present in the VM * Feature X must not be on/present in the VM * It doesn't matter whether feature X is there or not For example, in QEMU, ACPI is on by default, but can be turned off. The APIC on the other hand, is always there and can't be turned off. That is now reported as <features> <acpi default="on" toggle="yes"/> <apic default="on" toggle="no"/> </features> It's unfortunate that the format for PAE (<pae/> vs. <nonpae/>) reporting doesn't fit into this scheme. I didn't want to start with having tags <X/> and <nonX/> for each feature; that means that parsers need to special case PAE. It's probably too late, but it would be nice if PAE was reported in a similar format, with <pae> correponding to <pae default="on" toggle="no"/>, <nonpae/> corresponding to <pae default="yes" toggle="no"/>, and having both together corresponding to <pae default="yes" toggle="yes"/>, but that's a separate discussion from these patches. David

4 12

[Libvir] [PATCH] virsh Range check in Credit Scheduler
by Atsushi SAKAI 30 Jul '07

30 Jul '07

Hi, Add Range check in Credit Scheduler. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI

6 20

[Libvir] [PATCH] add a ttyconsole command
by Daniel Veillard 26 Jul '07

26 Jul '07

It was pointed out that we have a vncdisplay command but none for extracting the TTY console device: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239687 the trivial associated patch adds it as well as the doc in the man page Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 4

[Libvir] PATCH: Separate QEMU impl of nodeinfo API
by Daniel P. Berrange 25 Jul '07

25 Jul '07

While fixing the QEMU nodeinfo API to correctly deal with case where CPU sockets have sparse numbering (eg sockets 0 & 3 are populated), I realized that OpenVZ doesn't have a nodeinfo API, and its requirements are basically identical to the QEMU driver's. So this patch moves the impl of the nodeinfo API into a nodeinfo.c file, and makes both the QEMU and OpenVZ driver call out to this shared impl. I also put #ifdef __linux__ around the impl since code reading /proc/cpuinfo is never going to work on any non-Linux platform. For non linux I just return -1 which'll get treated as not-implemented. If QEMU driver is ported to work on Solaris, the nodeinfo.c file can be easily extended for their custom impl. Finally I'm adding a testcase with a bunch of example /proc/cpuinfo files to validate correctness Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] [PATCH] Python bindings: Use virDomain/NetworkGetConnect instead of storing connection in domain/network object
by Richard W.M. Jones 24 Jul '07

24 Jul '07

Previously[1] I patched libvirt to add the virDomainGetConnect and virNetworkGetConnect functions. The rationale for these is explained here[2]. The attached patch makes the Python bindings use these functions instead of storing the connection object explicitly. Rich. [1]https://www.redhat.com/archives/libvir-list/2007-June/msg00365.html [2]https://www.redhat.com/archives/libvir-list/2007-June/msg00352.html

3 8

[Libvir] Release of libvirt-0.3.1
by Daniel Veillard 24 Jul '07

24 Jul '07

Quite a few things were fixed since 0.3.0, and it was looking like a new release at this point would be a good idea. Availbale at ftp://libvirt.org/libvirt/ * Documentation: - index to remote page - script to test certificates - IPv6 remote support docs (Daniel Berrange) - document VIRSH_DEFAULT_CONNECT_URI in virsh man page (David Lutterkort) - Relax-NG early grammar for the network XML (David Lutterkort) * Bug fixes: - leaks in disk XML parsing (Masayuki Sunou) - hypervisor alignment call problems on PPC64 (Christian Ehrhardt) - dead client registration in daemon event loop (Daniel Berrange) - double free in error handling (Daniel Berrange) - close on exec for log file descriptors in the daemon (Daniel Berrange) - avoid caching problem in remote daemon (Daniel Berrange) - avoid crash after QEmu domain failure (Daniel Berrange) * Improvements: - checks of x509 certificates and keys (Daniel Berrange) - error reports in the daemon (Daniel Berrange) - checking of Ethernet MAC addresses in XML configs (Masayuki Sunou) - support for a new clock switch between UTC and localtime (Daniel Berrange) - early version of OpenVZ support (Shuveb Hussain) - support for input devices on PS/2 and USB buses (Daniel Berrange) - more tests especially the QEmu support (Daniel Berrange) - range check in credit scheduler (with Saori Fukuta and Atsushi Sakai) - add support for listen VNC parameter un QEmu and fix command line arg (Daniel Berrange) * Cleanups: - debug tracing (Richard Jones) - removal of --with-qemud-pid-file (Richard Jones) - remove unused virDeviceMode - new util module for code shared between drivers (Shuveb Hussain) - xen header location detection (Richard Jones) thanks to everybody who helped for this release, with bug reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] PATCH: Make QEMU driver honour 'listen' flag for VNC
by Daniel P. Berrange 24 Jul '07

24 Jul '07

In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a particular IP address. THis patch adapts the code so that it honours the 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also re-enables the tests for this capability that I temporarily disabled. src/qemu_conf.c | 37 +++++++++++++----- src/qemu_conf.h | 1 tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args | 2 tests/qemuxml2argvtest.c | 4 - tests/qemuxml2xmltest.c | 2 5 files changed, 32 insertions(+), 14 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5

[Libvir] PATCH: Fix crash in cleanup when VM creation fails
by Daniel P. Berrange 24 Jul '07

24 Jul '07

If using the 'virDomainCreateLinux' call to create a VM, a so called 'transient' domain will be created - ie one without any config file. There is special code in the qemudShutdownVMDaemon method to cleanup the resources associated with such domains, in particuarly free'ing the struct qemud_vm object. Unfortunately in the virDomainCreateLinux codepath this is a problem, because we still need the 'struct qemud_vm' object in certain edge cases, and so the caller has to free it. We currently have a double free() in that scenario. This patch removes the call to qemudFreeVMDaemon from qemudShutdownVMDaemon. Instead it is now always the caller's responsibility to cleanup after transient domains. qemu_driver.c | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Remote daemon & virDomainFree interaction
by Daniel P. Berrange 24 Jul '07

24 Jul '07

In looking at a problem with domain object cleanup in virt-manager I came across a problem in the remote driver, well the internal driver API itself actually. Specifically the implmenetation of virDomainFree() never calls into the driver API - it simply uses virFreeDomain() release the memory associated with the virDomainPtr object. Couple this with the remote driver though, and virDomainPtr objects in the remote daemon never get released, because the virDomainFree call is never propagated over the wire to the server. Its quite easy to see this in practice. Simply add a printf to the impl of virDomainLookupByName which prints out the ref count. Then run either virsh or virt-manager for a while Get info QEMUGuest1 69 c7a5fdbd-edaf-9455-926a-d65c16db1809 Get info QEMUGuest1 70 c7a5fdbd-edaf-9455-926a-d65c16db1809 Get info QEMUGuest1 71 c7a5fdbd-edaf-9455-926a-d65c16db1809 We need to make virDomainFree call into the driver API, and also make sure that the remote driver implements it. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] [PATCH] virDomainMigrate version 4 (for discussion only!)
by Richard W.M. Jones 24 Jul '07

24 Jul '07

This is version 4 of the virDomainMigrate patch. It includes remote support, but no qemu, virsh or python yet. And it needs lots more testing which I intend to do more of tomorrow. Interface --------- The interface is now this: virDomainPtr virDomainMigrate (virDomainPtr domain, virConnectPtr dconn, unsigned long flags, const char *dname, const char *uri, unsigned long resource); The caller may set dname, uri and resource to 0/NULL and forget about them. Or else the caller may set, in particular, uri to allow for more complicated migration strategies (especially for qemu). https://www.redhat.com/archives/libvir-list/2007-July/msg00249.html Driver support -------------- As outlined in the diagram in this email: https://www.redhat.com/archives/libvir-list/2007-July/msg00264.html migration happens in two stages. Firstly we send a "prepare" message to the destination host. The destination host may reply with a cookie. It may also suggest a URI (in the current Xen implementation it just returns gethostname). Secondly we send a "perform" message to the source host. Correspondingly, there are two new driver API functions: typedef int (*virDrvDomainMigratePrepare) (virConnectPtr dconn, char **cookie, int *cookielen, const char *uri_in, char **uri_out, unsigned long flags, const char *dname, unsigned long resource); typedef int (*virDrvDomainMigratePerform) (virDomainPtr domain, const char *cookie, int cookielen, const char *uri, unsigned long flags, const char *dname, unsigned long resource); Remote support -------------- To make this work in the remote case I have had to export two private functions from the API which only remote should call: __virDomainMigratePrepare __virDomainMigratePerform The reason for this is that libvirtd is just linked to the regular libvirt.so, so can only make calls into libvirt through exported symbols in the dynamic symbol table. There are two corresponding wire messages (REMOTE_PROC_DOMAIN_MIGRATE_PREPARE and REMOTE_PROC_DOMAIN_MIGRATE_PERFORM) but they just do dumb argument shuffling, albeit rather complicated because of the number of arguments passed in and out. The complete list of messages which go across the wire during a migration is: client -- prepare --> destination host client <-- prepare reply -- destination host client -- perform --> source host client <-- perform reply -- source host client -- lookupbyname --> destination host client <-- lookupbyname reply -- destination host Xen URIs -------- Xen recognises the following forms of URI: hostname hostname:port tcp://hostname/ tcp://hostname:port/ Capabilities ------------ I have extended capabilities with <migration_features>. For Xen this is: <capabilities> <host> <migration_features> <live/> <uri_transports> <uri_transport>tcp</uri_transport> </uri_transports> </migration_features> Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

4 18

[Libvir] OpenVZ XML format and VPS properties get/set interface [long]
by Shuveb Hussain 24 Jul '07

24 Jul '07

Hi, I started a discussion on OpenVZ XML format a while ago. But let me do it again with more explanation about OpenVZ this time, so that others can understand how it is different and how this can best fit into the libvirt model of doing things. Terminology: Virtual Private Server (VPS), Virtual Environment (VE) and Domain are all the same. OpenVZ is a lot about providing QoS to its users. About 20 carefully chosen parameters regarding various resources such as memory, CPU, disk and network are chosen. These are then used to provide minimum guarantee on any system running OpenVZ. Most of the time, these are limits that can be set per Virtual Private Server(VPS). In Xen or QEMU, if a disk image is available(Xen needs an additional kernel), it is possible to run the domain. Then forget all about it after the domain is shutoff. This is not possible in OpenVZ. When a new VPS/VE/Domain needs to be created, it needs a file system. This needs to be created along with its related configuration files in specific locations. Only after this can it be started. There is a "destroy" command available in OpenVZ, which is different from the destroy in libvirt. This will completely erase the file system and remove the related config file as well. Since there are many configurable parameters, the OpenVZ tools provides 2 sample templates or profiles on which newly created Virtual Environments(VEs) can be based. So, during VPS creation, rather than taking a million parameters, the name of the profile is taken as an argument and the variables in the file are used to create the VE. These values can later on be overridden and also be optionally stored in the VE's private config file to ensure persistence across reboots. Since there are many parameters needed during VE creation, using the profile name is practical. So, in the proposed XML file, I'm using the profile name. OpenVZ has its own config file format. We are storing the UUID there in a comment, since UUIDs are not used by OpenVZ. While a VE is created, the easiest way to do it is using a so called template cache. This is just a tar file of a Linux distro FS that is used to create a new file system for a VE. There are no disk images. The VE root fs resides on the host file system as a bunch of files and directories. A few template caches are usually available, say one based on Debian, one based on Fedora Core and another based on Suse. The user can choose which one to use while creating a new VE. However, the name of the template cache is not stored anywhere once the VE filesystem is created. I think one more comment is needed in the per-VE config file for this, just as we are storing the UUID. Here is a sample template. This one is called vps.basic, comes with the OpenVZ tools: ----------------------------------------------------------------- ONBOOT="no" # UBC parameters (in form of barrier:limit) # Primary parameters AVNUMPROC="40:40" NUMPROC="65:65" NUMTCPSOCK="80:80" NUMOTHERSOCK="80:80" VMGUARPAGES="6144:2147483647" # Secondary parameters KMEMSIZE="2752512:2936012" TCPSNDBUF="319488:524288" TCPRCVBUF="319488:524288" OTHERSOCKBUF="132096:336896" DGRAMRCVBUF="132096:132096" OOMGUARPAGES="6144:2147483647" # Auxiliary parameters LOCKEDPAGES="32:32" SHMPAGES="8192:8192" PRIVVMPAGES="49152:53575" NUMFILE="2048:2048" NUMFLOCK="100:110" NUMPTY="16:16" NUMSIGINFO="256:256" DCACHESIZE="1048576:1097728" PHYSPAGES="0:2147483647" NUMIPTENT="128:128" # Disk quota parameters (in form of softlimit:hardlimit) DISKSPACE="1048576:1153434" DISKINODES="200000:220000" QUOTATIME="0" # CPU fair sheduler parameter CPUUNITS="1000" ------------------------------------------------------------ Here is the proposed XML format: <domain type='openvz'> <name>105</name> <uuid>8509a1d4-1569-4467-8b37-4e433a1ac7b1</uuid> <filesystem> <template>gentoo-20060317-i686-stage3</template> <quota level='first'>10737418240</quota> <quota level='second' uid='500'>5368709120</quota> </filesystem> <profile>vps.basic</profile> <devices> <interface> <ipaddress>192.168.1.105</ipaddress> </interface> </devices> <nameserver>192.168.1.1</nameserver> <hostname>fedora105</hostname> </domain> I don't think the "filesystem" tag can fit logically into "devices", since it has quota and other information. The "template" is the name of the template cache used to create the VE. One of the main reasons many people(especially hosting providers) use OpenVZ is since it can be used to provide service level agreements. There must be a way to set/get various VPS parameters from libvirt. I understand concerns about driver specific code in libvirt based clients like virt-manager. The capabilities paradigm will not fit here, since this is simply about various properties of the VE/domain, not the hardware or the VM capabilities. Please correct me, if I am wrong. So, how to we do it? Thanks and Regards, -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

5 14

[Libvir] [PATCH] virDomainMigrate (version 5) (for discussion only, but getting there)
by Richard W.M. Jones 23 Jul '07

23 Jul '07

This is a rolled up patch for virDomainMigrate, including virsh and Python fixes. Changes since last time: - VIR_MIGRATE_LIVE is exported to Python - 'resource' parameter is now named 'bandwidth' - there is now an extra domainMigrateFinish step It needs a bit more testing which I can't do today while I'm at the office. Rich.

2 1

[Libvir] [PATCH] Document VIRSH_DEFAULT_CONNECT_URI
by David Lutterkort 23 Jul '07

23 Jul '07

I keep forgetting the exact name of VIRSH_DEFAULT_CONNECT_URI - patch to add it to the man page attached. David

2 1

[Libvir] FW: [et-mgmt-tools] Release 0.200.0 of virtinst
by Daniel P. Berrange 20 Jul '07

20 Jul '07

FYI a new libvirt based tool for cloning VMs... ----- Forwarded message from "Daniel P. Berrange" <berrange(a)redhat.com> ----- > Date: Thu, 19 Jul 2007 03:16:56 +0100 > From: "Daniel P. Berrange" <berrange(a)redhat.com> > To: et-mgmt-tools(a)redhat.com > Subject: [et-mgmt-tools] Release 0.200.0 of virtinst > > I'm happy to announce the release of virtinst version 0.200.0 > > This release introduces the virt-clone tool which provides the ability > to clone an existing inactive guest. The disk images will be copied, > new MAC address, UUID and name will be given to the guest. Documentation > is improved with the addition of manual pages for both virt-install and > virt-clone. Validation of input parameters has been further enhanced, > and re-factored to allow sharing with virt-manager. The virt-install > tool can be used to boot live CD images, with or without underlying > storage. > > It is available for download from the usual place: > > http://virt-manager.org/download.html > > Or directly: > > http://virt-manager.org/download/sources/virtinst/virtinst-0.200.0.tar.gz > > Thanks to everyone who has participated in development & testing of the > code in this new release! > > Regards, > Dan. ----- End forwarded message ----- Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] [PATCH]0/3 OpenVZ driver : Some clean ups
by Shuveb Hussain 19 Jul '07

19 Jul '07

Hi, Here are some cleanups as per discussions on the list: Change log: * Make sure we are running on OpenVZ enebled kernel in the driver open() method * Some minor macro cleanups * Use generic UUID parsing rather than own and scanf() * Made private functions static * New files utils.[c,h] added that have 2 functions virExec and virExecNonBlock * Removed popen and used virExec in openvz_driver.c * qemu_driver.c updated to use new virExecNonBlock() functions instead of qemudExec, which is removed Thanks, -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

2 3

[Libvir] Xen reboot does not work with Sys::Virt perl binding
by Keck, Christian (ext) 19 Jul '07

19 Jul '07

Hello guys! I am using the perl bindings (Sys::Virt) to manage my virtual xen hosts. Because it directly maps the C api, I thought it's a good idea to ask you instead of the author of this module. Xen version is 3.0 with libvirt 0.1.9 on a red hat box. while calling the reboot method i get following error: libvirt error code: 0, message: Unknown problem In this case the virtual system does not reboot. But with shutdown method, which throw the same error, the system shuts down correctly. Here is my code: my $vmm = Sys::Virt->new(); my $dom = eval { $vmm->get_domain_by_name( $p->{ name } ) }; $dom->reboot(&Sys::Virt::Domain::REBOOT_RESTART); Is this a known issue? Thank you for your help. Best regards, Christian

2 2

[Libvir] RFC: format for mapping host devices to guest
by Daniel P. Berrange 19 Jul '07

19 Jul '07

I'm considering the problem of mapping host USB devices through to the guest as one of the 2 remaining bits of USB support needed (the other being the mapping disks through as USB mass storage). I have previously mentioned some ideas in this mail, though looking back on this I don't much like them https://www.redhat.com/archives/libvir-list/2007-March/msg00205.html Also, there was just the message about a desire to support mapping of PCI devices. The USB stuff I want todo with both Xen and QEMU. In Xen, USB device passthrough is based on: usbdevice=host:[bus id].[device id] eg usbdevice=host:003.001 Or usbdevice=host:[vendor id]:[product id] eg usbdevice=host:0483:2016 In QEMU, USB device passthrough is pretty much the same with command line args: -usbdevice host:[bus id].[device id] eg -usbdevice host:003.001 Or -usbdevice host:[vendor id]:[product id] eg -usbdevice host:0483:2016 Finally, in Xen, PCI device passthrough is done with pci=['pci device id',....] eg pci=['00:1f.3'] So we need some form of element under the <devices> section per device to map through. At minimum this will need the source device info. If we are to support unplugging of USB devices in QEMU it is neccessary to have the target device id - this is generated by QEMU when attaching the USB device. So to attach a device: <host bus='usb'> <source device="003.001"/> </host> Or <host bus='usb'> <source vendor='0483' product='2016'> </host> The first form is useful for live hotplug - where you know the exact device instance. The second form is useful for permanent config - you don't know what device id it'll have since it may be plugged into the host in any order. When splitting the XML back out, QEMU would fill in the target info giving us either: <host bus='usb'> <source dev='003.001'/> <target dev='001.005'/> </host> Or <host bus='usb'> <source vendor='0483' product='2016'/> <target dev='001.005'/> </host> This is suitable for giving to virDomainDetachDevice() - we use the target dev for the QEMU monitor 'usb-detach' command. Now PCI would be similar - no hotplug to worry about here though, and no need (or availability) or target info. So the XML would simply be <host bus='pci'> <source dev='00:1f.3'/> </host> NB I choose 'host' as the element name since we're basically giving the guest an arbitrary host device. My previous email had thought about calling it 'bus' but we're not really defining a bus in this context and there may very well be some scenario in the future where we do need to represent the concept of a 'bus' in the XML directly. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 3

[Libvir] [PATCH]3/3 OpenVZ driver : qemu_driver.c changes
by Shuveb Hussain 19 Jul '07

19 Jul '07

-- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

1 0

[Libvir] [PATCH]2/3 OpenVZ driver : generic utils
by Shuveb Hussain 19 Jul '07

19 Jul '07

-- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

1 0

[Libvir] [PATCH]1/3 OpenVZ driver : Cleanups
by Shuveb Hussain 19 Jul '07

19 Jul '07

Cleanup patch, also adds utils.c and utils.h to Makefile.am -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

1 0

[Libvir] PATCH: Fix accident close of monitor FD & leak of logfile FD to child
by Daniel P. Berrange 19 Jul '07

19 Jul '07

After the QEMU monitor filehandle has been successfully initialized, we then promptly close it ! It seems a 'return' statement accidentally got removed somewhere during previously refactoring. Second, the QEMU logfile does not have the close-on-exec flag set so the logfile is leaked to child processes. qemu_driver.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] XM config <-> XML config
by Arik Raffael Funke 19 Jul '07

19 Jul '07

Hi, I am using Fedora 7 with virt-manager to control my xen domains. I would like to delegate a pci device to one of my domU's. I know how this is done in the XM and sxp config files, but how is it done now? I read that libvirt can convert XM <-> XML and though I could export my current config to XM format, edit it and reimport. How is is done with libvirt? Thanks, Arik

2 3

[Libvir] PATCH: Support input devices in XML format
by Daniel P. Berrange 18 Jul '07

18 Jul '07

This patch is the first step towards supporting USB devices in libvirt XML format. As per the original thread some months back[1], I'm the grouping is being done based on device classes, rather than bus types. So this first patch is actually introducing the concept of 'input' devices. This is best illustrated by examples - PS2 mouse - automatically added when yuou turn on <graphics> in an HVM guest. <input type='mouse' bus='ps2'/> - Xen mouse - automatically added when you turn on <graphics> in a Xen paravirt guest (ie the paravirt input device) <input type='mouse' bus='xen'/> - USB mouse - have to actually ask for this. Not all that useful since its still using relative co-ordinates, but here for completeness. <input type='mouse' bus='usb'/> - USB tablet - have to actually ask for this. Very useful. Windows and Linux can both drive this in absolute co-ordinate mode. <input type='tablet' bus='usb'/> If it possible to omit the 'bus' attribute, in which case it'll automatically set up the device on the most appropriate bus for that type of device. So if you say type='mouse', it'll pick a ps2/xen bus. If you say type='tablet' it'll pick a usb bus. In my previous email[1] I suggested a possible 'model' attribute as well. I since discovered that Xen removed support for the summagraphics tablet completely, so adding a model at this time is a waste of time. We can always choose it add it later if we port to another virt manager here we need to distinguish devices on more than just a (type, bus) pair. As with the previous '<clock/>' element, it is intended that virt-install and virt-manager will automatically add a USB tablet if they you tell them you're installing Windows, or a recent Linux guest. It'll also be possible manally add post-install through the virt-manager UI. For the QEMU driver at least, I intend to make it possible to hot add & remove USB devices. This will appear as impl of virAttach/Detch methods for QEMU at least. Xen doesn't support hot add/remove of USB at this time. Finally, before I actually commit this I think it is well overdue to write some unit tests for the QEMU driver. So I'm going to do a test which chceks XML -> data struct -> QEMU command line, and XML -> data struct -> XML sequences of operations. This should let us exercise all the XML related code in QEMU which is a good start & helpful to avoid regressions. Regards, Dan. [1] http://www.redhat.com/archives/libvir-list/2007-March/msg00205.html -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 6

[Libvir] Asynchronous notifications of domain start/stop
by Richard W.M. Jones 18 Jul '07

18 Jul '07

I had some private discussions with a developer who wants to start using libvirt, but requires asynch notifications of domain start/stop (and other stuff, but this will do for the moment). Right now he's using XenStore watches. The alternative of polling didn't look very appealing for him. A rough API for this might look like this: typedef int virEventHandle; /* Register a callback to catch domain start events. */ virEventHandle virEventDomainStart (virConnectPtr, void (*f) (virConnectPtr, int domid)); /* Register a callback to catch domain stop events. */ virEventHandle virEventDomainStop (virConnectPtr, void (*f) (virConnectPtr, int domid)); /* Unregister any type of callback. */ int virEventCancel (virConnectPtr, virEventHandle handle); Implementation -------------- In the Xen case, we can use XenStore watches[1]. Callbacks from XenStore can be translated directly into event callbacks. In the qemu case, the daemon knows when the qemu instances that it manages come and go. In the qemu/remote case, asynch notifications are nominally supported by the protocol, but I haven't really looked at all the implications. Seems like we'd need to use MSG_OOB to signal the client process, and translate the SIGURG signal received into a callback. This is all tricky and Unix-specific though so if you have any better ideas ... We would also need to avoid mixing ordinary request/response with the notifications, which OOB takes care of. Rich. [1] http://wiki.xensource.com/xenwiki/XenBusDriver -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

4 17

[Libvir] virDomainConfigureDevice?
by Hugh Brock 18 Jul '07

18 Jul '07

I'm looking at ways to replicate xm block-configure at the libvirt level. xm block-configure is useful in that it allows you to change the back device for an HVM guest while the guest is still running; this permits you for example to change the CDROM without shutting down your guest or poking around in xenstore. Thus we can have an "eject" button on cdrom devices in virt-manager (or "eject" and "load" buttons, I guess), which we really need. The issue of course is that xm block-configure is specifically intended for block devices and takes arguments for the back device and the front device (among others). We would naturally prefer to accept a block of XML just as virDomainAttachDevice does and then parse it, determine if the device in question is of a type we can actually edit, determine if the new backdev is appropriate, and so on. None of this seems terribly hard, but before I go implement it, are there obvious pitfalls I'm not thinking? And given that virDomainAttachDevice is not implemented for qemud in libvirt (is it?), how do we handle the non-xen case? Thanks, --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

4 7