- Devel - libvirt List Archives

[PATCH 0/2] Fix mocking around networkxml2firewalltest
by Michal Privoznik 10 May '23

10 May '23

*** BLURB HERE *** Michal Prívozník (2): util: include virfirewall.h in virfirewalld.h virfirewallmock: Replace virFindFileInPath() with virFirewallDIsRegistered() src/util/virfirewalld.h | 2 ++ tests/virfirewallmock.c | 16 ++++------------ 2 files changed, 6 insertions(+), 12 deletions(-) -- 2.39.2

3 5

[RFC PATCH] hostdev:Introduce vDPA device to hostdev subsystem as a new subtype
by libai 10 May '23

10 May '23

The following is the xml of vdpa device: <devices> <hostdev mode='subsystem' type='vdpa'> <source dev='/dev/vhost-vdpa-0'/> </hostdev> </devices> And the command line passed to QEMU is as follows: -device {"driver":"vhost-vdpa-device-pci","vhostdev":"/dev/vhost-vdpa-0"} This solution is selected according to the previous discussion on the solution of supporting the vDPA device. For details, see the following: https://listman.redhat.com/archives/libvir-list/2023-March/239018.html Signed-off-by: libai <libai12(a)huawei.com> --- src/conf/domain_audit.c | 4 +++ src/conf/domain_conf.c | 47 +++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 6 +++++ src/conf/domain_validate.c | 1 + src/conf/virconftypes.h | 2 ++ src/qemu/qemu_command.c | 19 +++++++++++++ src/qemu/qemu_command.h | 3 +++ src/qemu/qemu_domain.c | 6 +++++ src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_migration.c | 2 ++ src/qemu/qemu_validate.c | 2 ++ src/security/security_dac.c | 2 ++ src/security/security_selinux.c | 2 ++ 13 files changed, 97 insertions(+) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ae875188bd..6906ce7ade 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -344,6 +344,7 @@ virDomainAuditHostdev(virDomainObj *vm, virDomainHostdevDef *hostdev, virDomainHostdevSubsysSCSI *scsisrc = &hostdev->source.subsys.u.scsi; virDomainHostdevSubsysSCSIVHost *hostsrc = &hostdev->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDev *mdevsrc = &hostdev->source.subsys.u.mdev; + virDomainHostdevSubsysVDPA *vdpasrc = &hostdev->source.subsys.u.vdpa; virUUIDFormat(vm->def->uuid, uuidstr); if (!(vmname = virAuditEncode("vm", vm->def->name))) { @@ -383,6 +384,9 @@ virDomainAuditHostdev(virDomainObj *vm, virDomainHostdevDef *hostdev, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: address = g_strdup(mdevsrc->uuidstr); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + address = g_strdup(vdpasrc->devpath); + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: VIR_WARN("Unexpected hostdev type while encoding audit message: %d", diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b03a3ff011..e8f6d1457b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1047,6 +1047,7 @@ VIR_ENUM_IMPL(virDomainHostdevSubsys, "scsi", "scsi_host", "mdev", + "vdpa", ); VIR_ENUM_IMPL(virDomainHostdevSubsysPCIBackend, @@ -2641,6 +2642,9 @@ virDomainHostdevDefClear(virDomainHostdevDef *def) case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: g_clear_pointer(&def->source.subsys.u.pci.origstates, virBitmapFree); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + VIR_FREE(def->source.subsys.u.vdpa.devpath); + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: @@ -6160,6 +6164,22 @@ virDomainHostdevSubsysMediatedDevDefParseXML(virDomainHostdevDef *def, return 0; } +static int +virDomainHostdevSubsysVDPADefParseXML(xmlNodePtr sourcenode, + virDomainHostdevDef *def) +{ + g_autofree char *devpath = NULL; + virDomainHostdevSubsysVDPA *vdpa = &def->source.subsys.u.vdpa; + + if(!(devpath = virXMLPropString(sourcenode, "dev"))) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Missing 'dev' attribute for element <source>")); + return -1; + } + vdpa->devpath = g_steal_pointer(&devpath); + return 0; +} + static int virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, xmlXPathContextPtr ctxt, @@ -6317,6 +6337,11 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if (virDomainHostdevSubsysMediatedDevDefParseXML(def, ctxt) < 0) return -1; break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (virDomainHostdevSubsysVDPADefParseXML(sourcenode, def) < 0) { + return -1; + } + break; default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -12979,6 +13004,7 @@ virDomainHostdevDefParseXML(virDomainXMLOption *xmlopt, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } @@ -14101,6 +14127,13 @@ virDomainHostdevMatchSubsys(virDomainHostdevDef *a, return 0; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: return virDomainHostdevMatchSubsysMediatedDev(a, b); + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (STREQ(a->source.subsys.u.vdpa.devpath, + b->source.subsys.u.vdpa.devpath)) { + return 1; + } else { + return 0; + } case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: return 0; } @@ -23290,6 +23323,16 @@ virDomainHostdevDefFormatSubsysMdev(virBuffer *buf, virXMLFormatElement(buf, "source", NULL, &sourceChildBuf); } +static void +virDomainHostdevDefFormatSubsysVDPA(virBuffer *buf, + virDomainHostdevDef *def) +{ + g_auto(virBuffer) sourceAttrBuf = VIR_BUFFER_INITIALIZER; + virDomainHostdevSubsysVDPA *vdpasrc = &def->source.subsys.u.vdpa; + virBufferAsprintf(&sourceAttrBuf, " dev='%s'", vdpasrc->devpath); + virXMLFormatElement(buf, "source", &sourceAttrBuf, NULL); +} + static int virDomainHostdevDefFormatSubsys(virBuffer *buf, @@ -23317,6 +23360,10 @@ virDomainHostdevDefFormatSubsys(virBuffer *buf, virDomainHostdevDefFormatSubsysMdev(buf, def); return 0; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + virDomainHostdevDefFormatSubsysVDPA(buf, def); + return 0; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: virReportEnumRangeError(virDomainHostdevSubsysType, def->source.subsys.type); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 511067a050..ade8b0edec 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -197,6 +197,7 @@ typedef enum { VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV, + VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST } virDomainHostdevSubsysType; @@ -289,6 +290,10 @@ struct _virDomainHostdevSubsysMediatedDev { virTristateSwitch ramfb; }; +struct _virDomainHostdevSubsysVDPA { + char *devpath; /* vDPA device path */ +}; + typedef enum { VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_NONE, VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_VHOST, @@ -323,6 +328,7 @@ struct _virDomainHostdevSubsys { virDomainHostdevSubsysSCSI scsi; virDomainHostdevSubsysSCSIVHost scsi_host; virDomainHostdevSubsysMediatedDev mdev; + virDomainHostdevSubsysVDPA vdpa; } u; }; diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index e04b85fee4..4af84c4f0c 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2214,6 +2214,7 @@ virDomainHostdevDefValidate(const virDomainHostdevDef *hostdev) } break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/conf/virconftypes.h b/src/conf/virconftypes.h index e07f967814..1756c54e7a 100644 --- a/src/conf/virconftypes.h +++ b/src/conf/virconftypes.h @@ -120,6 +120,8 @@ typedef struct _virDomainHostdevSubsys virDomainHostdevSubsys; typedef struct _virDomainHostdevSubsysMediatedDev virDomainHostdevSubsysMediatedDev; +typedef struct _virDomainHostdevSubsysVDPA virDomainHostdevSubsysVDPA; + typedef struct _virDomainHostdevSubsysPCI virDomainHostdevSubsysPCI; typedef struct _virDomainHostdevSubsysSCSI virDomainHostdevSubsysSCSI; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4ca93bf3dc..121214f4d5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4958,6 +4958,18 @@ qemuBuildHostdevMediatedDevProps(const virDomainDef *def, return g_steal_pointer(&props); } +virJSONValue * +qemuBuildHostdevVDPADevProps(virDomainHostdevDef *dev) +{ + g_autoptr(virJSONValue) props = NULL; + virDomainHostdevSubsysVDPA *vdpasrc = &dev->source.subsys.u.vdpa; + if (virJSONValueObjectAdd(&props, + "s:driver", "vhost-vdpa-device-pci", + "s:vhostdev", vdpasrc->devpath, + NULL) < 0) + return NULL; + return g_steal_pointer(&props); +} qemuBlockStorageSourceAttachData * qemuBuildHostdevSCSIDetachPrepare(virDomainHostdevDef *hostdev, @@ -5154,6 +5166,13 @@ qemuBuildHostdevCommandLine(virCommand *cmd, return -1; break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (!(devprops = qemuBuildHostdevVDPADevProps(hostdev))) + return -1; + if (qemuBuildDeviceCommandlineFromJSON(cmd, devprops, def, qemuCaps) < 0) + return -1; + break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 5fdb138030..dff18350b5 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -198,6 +198,9 @@ virJSONValue * qemuBuildHostdevMediatedDevProps(const virDomainDef *def, virDomainHostdevDef *dev); +virJSONValue * +qemuBuildHostdevVDPADevProps(virDomainHostdevDef *dev); + virJSONValue * qemuBuildRedirdevDevProps(const virDomainDef *def, virDomainRedirdevDef *dev); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 63b13b6875..0cd485a459 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10533,6 +10533,8 @@ qemuDomainGetHostdevPath(virDomainHostdevDef *dev, virDomainHostdevSubsysSCSI *scsisrc = &dev->source.subsys.u.scsi; virDomainHostdevSubsysSCSIVHost *hostsrc = &dev->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDev *mdevsrc = &dev->source.subsys.u.mdev; + virDomainHostdevSubsysVDPA *vdpasrc = &dev->source.subsys.u.vdpa; + g_autoptr(virUSBDevice) usb = NULL; g_autoptr(virSCSIDevice) scsi = NULL; g_autoptr(virSCSIVHostDevice) host = NULL; @@ -10603,6 +10605,10 @@ qemuDomainGetHostdevPath(virDomainHostdevDef *dev, if (!(tmpPath = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return -1; + perm = VIR_CGROUP_DEVICE_RW; + break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + tmpPath = g_strdup(vdpasrc->devpath); perm = VIR_CGROUP_DEVICE_RW; break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5072798cb7..7d89899223 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4546,6 +4546,7 @@ qemuDomainRemoveHostDevice(virQEMUDriver *driver, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: qemuDomainRemoveMediatedDevice(driver, vm, hostdev); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index ed41a03851..9220ef1ab1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1295,6 +1295,8 @@ qemuMigrationSrcIsAllowedHostdev(const virDomainDef *def) case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + /* The vDPA devices don't support migration for now */ + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: virReportError(VIR_ERR_OPERATION_UNSUPPORTED, _("cannot migrate a domain with <hostdev mode='subsystem' type='%1$s'>"), virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b8d5e9bd74..ea3d4e1a39 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2566,6 +2566,8 @@ qemuValidateDomainDeviceDefHostdev(const virDomainHostdevDef *hostdev, break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: return qemuValidateDomainMdevDef(hostdev, def, qemuCaps); + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: virReportEnumRangeError(virDomainHostdevSubsysType, diff --git a/src/security/security_dac.c b/src/security/security_dac.c index c7dc145621..24f3de5d15 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1313,6 +1313,7 @@ virSecurityDACSetHostdevLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; @@ -1469,6 +1470,7 @@ virSecurityDACRestoreHostdevLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index e3e6a6115f..5cb6612fbc 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -2265,6 +2265,7 @@ virSecuritySELinuxSetHostdevSubsysLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; @@ -2493,6 +2494,7 @@ virSecuritySELinuxRestoreHostdevSubsysLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; -- 2.33.0

1 0

[libvirt PATCH 0/5] qemu: Find helpers at runtime
by Andrea Bolognani 10 May '23

10 May '23

This removes the need to have them present in the build environment and makes things more flexible. Note that we currently *do not* have the helpers available in most CI environments, or have BuildRequires for them in the spec file. That only works for Fedora and RHEL because the hardcoded fallback paths happen to match those used on those distributions: everywhere else, the choice is to either ensure that the additional packages are installed in the build environment or to produce a build of libvirt that can't use the corresponding features out of the box. Andrea Bolognani (5): util: Small refactor util: Introduce virFileFindInPathFull() qemu: Find helpers at runtime meson: Stop looking for QEMU helpers qemu: Update documentation for qemu.conf keys meson.build | 24 --------------- src/libvirt_private.syms | 1 + src/qemu/qemu.conf.in | 8 +++-- src/qemu/qemu_conf.c | 4 +++ src/qemu/qemu_interface.c | 15 ++++++++-- src/qemu/qemu_process.c | 17 ++++++++--- src/qemu/test_libvirtd_qemu.aug.in | 4 +-- src/util/virfile.c | 47 ++++++++++++++++++++++++++---- src/util/virfile.h | 3 ++ 9 files changed, 83 insertions(+), 40 deletions(-) -- 2.40.1

2 6

[PATCH 0/3] Audio test cleanups
by Peter Krempa 09 May '23

09 May '23

Few things I've cleaned up before realizing that: https://gitlab.com/libvirt/libvirt/-/issues/473 can't really be solved without qemu assistance. Peter Krempa (3): qemuxml2xmlout: Replace symlinks of all 'audio-' tests by real files qemuxml2argvtest: Use real caps instead of fake caps for 'audio-default-*' cases qemuxml2xmltest: Modernize all 'audio-' cases ...gs => audio-default-sdl.x86_64-4.2.0.args} | 6 +- ... => audio-default-spice.x86_64-4.2.0.args} | 6 +- ...gs => audio-default-vnc.x86_64-4.2.0.args} | 6 +- tests/qemuxml2argvtest.c | 6 +- .../audio-alsa-best.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-alsa-best.xml | 1 - .../audio-alsa-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-alsa-full.xml | 1 - .../audio-alsa-minimal.x86_64-latest.xml | 39 ++++++++++++ .../qemuxml2xmloutdata/audio-alsa-minimal.xml | 1 - .../audio-coreaudio-best.x86_64-latest.xml | 46 ++++++++++++++ .../audio-coreaudio-best.xml | 1 - .../audio-coreaudio-full.x86_64-latest.xml | 46 ++++++++++++++ .../audio-coreaudio-full.xml | 1 - .../audio-coreaudio-minimal.x86_64-latest.xml | 39 ++++++++++++ .../audio-coreaudio-minimal.xml | 1 - .../audio-file-best.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-file-best.xml | 1 - .../audio-file-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-file-full.xml | 1 - .../audio-file-minimal.x86_64-latest.xml | 39 ++++++++++++ .../qemuxml2xmloutdata/audio-file-minimal.xml | 1 - .../audio-jack-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-jack-full.xml | 1 - .../audio-many-backends.x86_64-latest.xml | 61 ++++++++++++++++++- .../audio-none-best.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-none-best.xml | 1 - .../audio-none-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-none-full.xml | 1 - .../audio-none-minimal.x86_64-latest.xml | 39 ++++++++++++ .../qemuxml2xmloutdata/audio-none-minimal.xml | 1 - .../audio-oss-best.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-oss-best.xml | 1 - .../audio-oss-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-oss-full.xml | 1 - .../audio-oss-minimal.x86_64-latest.xml | 39 ++++++++++++ .../qemuxml2xmloutdata/audio-oss-minimal.xml | 1 - .../audio-pulseaudio-best.x86_64-latest.xml | 46 ++++++++++++++ .../audio-pulseaudio-best.xml | 1 - .../audio-pulseaudio-full.x86_64-latest.xml | 46 ++++++++++++++ .../audio-pulseaudio-full.xml | 1 - ...audio-pulseaudio-minimal.x86_64-latest.xml | 39 ++++++++++++ .../audio-pulseaudio-minimal.xml | 1 - .../audio-sdl-best.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-sdl-best.xml | 1 - .../audio-sdl-full.x86_64-latest.xml | 46 ++++++++++++++ tests/qemuxml2xmloutdata/audio-sdl-full.xml | 1 - .../audio-sdl-minimal.x86_64-latest.xml | 39 ++++++++++++ .../qemuxml2xmloutdata/audio-sdl-minimal.xml | 1 - .../audio-spice-best.x86_64-latest.xml | 53 ++++++++++++++++ tests/qemuxml2xmloutdata/audio-spice-best.xml | 1 - .../audio-spice-full.x86_64-latest.xml | 53 ++++++++++++++++ tests/qemuxml2xmloutdata/audio-spice-full.xml | 1 - .../audio-spice-minimal.x86_64-latest.xml | 46 ++++++++++++++ .../audio-spice-minimal.xml | 1 - tests/qemuxml2xmltest.c | 56 ++++++++--------- 56 files changed, 1215 insertions(+), 66 deletions(-) rename tests/qemuxml2argvdata/{audio-default-sdl.args => audio-default-sdl.x86_64-4.2.0.args} (86%) rename tests/qemuxml2argvdata/{audio-default-spice.args => audio-default-spice.x86_64-4.2.0.args} (86%) rename tests/qemuxml2argvdata/{audio-default-vnc.args => audio-default-vnc.x86_64-4.2.0.args} (86%) create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-file-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-file-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-file-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-file-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-file-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-file-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-jack-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-jack-full.xml mode change 120000 => 100644 tests/qemuxml2xmloutdata/audio-many-backends.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-none-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-none-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-none-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-none-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-none-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-none-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-oss-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-oss-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-oss-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-spice-best.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-spice-full.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-spice-minimal.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-minimal.xml -- 2.40.1

2 4

[PATCH 0/5] qemu: Clean up testing of sound devices and implement 'multichannel' support for 'usb-audio'
by Peter Krempa 09 May '23

09 May '23

Peter Krempa (5): docs: formatdomain: Use code blocks to emphasize various sound device options qemuxml2(argv|xml)test: Remove 'sound' case qemuxml2(argv|xml)test: Modernize 'sound-device' case conf: Register autoptr cleanup for 'virDomainSoundDef' and refactor virDomainSoundDefParseXML conf: qemu: Add support for multi-channel mode for 'usb' sound cards docs/formatdomain.rst | 55 ++++++++++--------- src/conf/domain_conf.c | 42 ++++++++++---- src/conf/domain_conf.h | 5 ++ src/conf/schemas/domaincommon.rng | 5 ++ src/qemu/qemu_command.c | 3 + ...ce.args => sound-device.x86_64-4.2.0.args} | 13 ++--- .../sound-device.x86_64-latest.args | 50 +++++++++++++++++ tests/qemuxml2argvdata/sound-device.xml | 12 +--- tests/qemuxml2argvdata/sound.args | 37 ------------- tests/qemuxml2argvdata/sound.xml | 34 ------------ tests/qemuxml2argvtest.c | 8 +-- ...ice.xml => sound-device.x86_64-latest.xml} | 17 +++--- tests/qemuxml2xmloutdata/sound.xml | 43 --------------- tests/qemuxml2xmltest.c | 8 +-- 14 files changed, 142 insertions(+), 190 deletions(-) rename tests/qemuxml2argvdata/{sound-device.args => sound-device.x86_64-4.2.0.args} (80%) create mode 100644 tests/qemuxml2argvdata/sound-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/sound.args delete mode 100644 tests/qemuxml2argvdata/sound.xml rename tests/qemuxml2xmloutdata/{sound-device.xml => sound-device.x86_64-latest.xml} (82%) delete mode 100644 tests/qemuxml2xmloutdata/sound.xml -- 2.40.0

2 6

[PATCH] qemu: Report domain name in unexpectedly closed monitor message
by Michal Privoznik 09 May '23

09 May '23

When QEMU closes the monitor suddenly, the following error message is reported: internal error: qemu unexpectedly closed the monitor: ... And this works. But other error messages produced in the same function include domain name too. Do that for the unexpectedly closed monitor message too. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_monitor.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 71ebd356ad..dacf161971 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -513,15 +513,18 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, if (error || mon->goteof) { if (hangup && mon->logFunc != NULL) { + g_autofree char *errmsg = NULL; + /* Check if an error message from qemu is available and if so, use * it to overwrite the actual message. It's done only in early * startup phases or during incoming migration when the message * from qemu is certainly more interesting than a * "connection reset by peer" message. */ - mon->logFunc(mon, - _("qemu unexpectedly closed the monitor"), - mon->logOpaque); + + errmsg = g_strdup_printf(_("QEMU unexpectedly closed the monitor (vm='%1$s')"), + mon->domainName); + mon->logFunc(mon, errmsg, mon->logOpaque); virCopyLastError(&mon->lastError); virResetLastError(); } -- 2.39.3

2 1

[PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file
by Michal Privoznik 09 May '23

09 May '23

For all our daemons, we provide VIRXXXD_ARGS env var in the unit file. The variable can then be overridden in corresponding file: EnvironmentFile=-@initconfdir@/virtxxxd The daemon is then executed as: ExecStart=@sbindir@/virtxxxd $VIRTXXXD_ARGS But virlogd is exception, for no good reason. And while there are probably no arguments we want to pass to virtlogd by default, just mimic what we do for say virtlockd, where we also don't pass any default argument. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/logging/virtlogd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in index 158124e4d3..e4aecd46a7 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -7,6 +7,7 @@ Documentation=man:virtlogd(8) Documentation=https://libvirt.org [Service] +Environment=VIRTLOGD_ARGS= EnvironmentFile=-@initconfdir@/virtlogd ExecStart=@sbindir@/virtlogd $VIRTLOGD_ARGS ExecReload=/bin/kill -USR1 $MAINPID -- 2.39.3

2 1

[RFC PATCH] hostdev:Introduce vDPA device to hostdev subsystem as a new subtype
by libai 06 May '23

06 May '23

The following is the xml of vdpa device: <devices> <hostdev mode='subsystem' type='vdpa'> <source dev='/dev/vhost-vdpa-0'/> </hostdev> </devices> And the command line passed to QEMU is as follows: -device {"driver":"vhost-vdpa-device-pci","vhostdev":"/dev/vhost-vdpa-0"} This solution is selected according to the previous discussion on the solution of supporting the vDPA device. For details, see the following: https://listman.redhat.com/archives/libvir-list/2023-March/239018.html Signed-off-by: libai <libai12(a)huawei.com> --- src/conf/domain_audit.c | 4 +++ src/conf/domain_conf.c | 47 +++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 6 +++++ src/conf/domain_validate.c | 1 + src/conf/virconftypes.h | 2 ++ src/qemu/qemu_command.c | 19 +++++++++++++ src/qemu/qemu_command.h | 3 +++ src/qemu/qemu_domain.c | 6 +++++ src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_migration.c | 2 ++ src/qemu/qemu_validate.c | 2 ++ src/security/security_dac.c | 2 ++ src/security/security_selinux.c | 2 ++ 13 files changed, 97 insertions(+) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ae875188bd..6906ce7ade 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -344,6 +344,7 @@ virDomainAuditHostdev(virDomainObj *vm, virDomainHostdevDef *hostdev, virDomainHostdevSubsysSCSI *scsisrc = &hostdev->source.subsys.u.scsi; virDomainHostdevSubsysSCSIVHost *hostsrc = &hostdev->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDev *mdevsrc = &hostdev->source.subsys.u.mdev; + virDomainHostdevSubsysVDPA *vdpasrc = &hostdev->source.subsys.u.vdpa; virUUIDFormat(vm->def->uuid, uuidstr); if (!(vmname = virAuditEncode("vm", vm->def->name))) { @@ -383,6 +384,9 @@ virDomainAuditHostdev(virDomainObj *vm, virDomainHostdevDef *hostdev, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: address = g_strdup(mdevsrc->uuidstr); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + address = g_strdup(vdpasrc->devpath); + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: VIR_WARN("Unexpected hostdev type while encoding audit message: %d", diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b03a3ff011..e8f6d1457b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1047,6 +1047,7 @@ VIR_ENUM_IMPL(virDomainHostdevSubsys, "scsi", "scsi_host", "mdev", + "vdpa", ); VIR_ENUM_IMPL(virDomainHostdevSubsysPCIBackend, @@ -2641,6 +2642,9 @@ virDomainHostdevDefClear(virDomainHostdevDef *def) case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: g_clear_pointer(&def->source.subsys.u.pci.origstates, virBitmapFree); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + VIR_FREE(def->source.subsys.u.vdpa.devpath); + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: @@ -6160,6 +6164,22 @@ virDomainHostdevSubsysMediatedDevDefParseXML(virDomainHostdevDef *def, return 0; } +static int +virDomainHostdevSubsysVDPADefParseXML(xmlNodePtr sourcenode, + virDomainHostdevDef *def) +{ + g_autofree char *devpath = NULL; + virDomainHostdevSubsysVDPA *vdpa = &def->source.subsys.u.vdpa; + + if(!(devpath = virXMLPropString(sourcenode, "dev"))) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Missing 'dev' attribute for element <source>")); + return -1; + } + vdpa->devpath = g_steal_pointer(&devpath); + return 0; +} + static int virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, xmlXPathContextPtr ctxt, @@ -6317,6 +6337,11 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if (virDomainHostdevSubsysMediatedDevDefParseXML(def, ctxt) < 0) return -1; break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (virDomainHostdevSubsysVDPADefParseXML(sourcenode, def) < 0) { + return -1; + } + break; default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -12979,6 +13004,7 @@ virDomainHostdevDefParseXML(virDomainXMLOption *xmlopt, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } @@ -14101,6 +14127,13 @@ virDomainHostdevMatchSubsys(virDomainHostdevDef *a, return 0; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: return virDomainHostdevMatchSubsysMediatedDev(a, b); + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (STREQ(a->source.subsys.u.vdpa.devpath, + b->source.subsys.u.vdpa.devpath)) { + return 1; + } else { + return 0; + } case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: return 0; } @@ -23290,6 +23323,16 @@ virDomainHostdevDefFormatSubsysMdev(virBuffer *buf, virXMLFormatElement(buf, "source", NULL, &sourceChildBuf); } +static void +virDomainHostdevDefFormatSubsysVDPA(virBuffer *buf, + virDomainHostdevDef *def) +{ + g_auto(virBuffer) sourceAttrBuf = VIR_BUFFER_INITIALIZER; + virDomainHostdevSubsysVDPA *vdpasrc = &def->source.subsys.u.vdpa; + virBufferAsprintf(&sourceAttrBuf, " dev='%s'", vdpasrc->devpath); + virXMLFormatElement(buf, "source", &sourceAttrBuf, NULL); +} + static int virDomainHostdevDefFormatSubsys(virBuffer *buf, @@ -23317,6 +23360,10 @@ virDomainHostdevDefFormatSubsys(virBuffer *buf, virDomainHostdevDefFormatSubsysMdev(buf, def); return 0; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + virDomainHostdevDefFormatSubsysVDPA(buf, def); + return 0; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: virReportEnumRangeError(virDomainHostdevSubsysType, def->source.subsys.type); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 511067a050..ade8b0edec 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -197,6 +197,7 @@ typedef enum { VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV, + VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST } virDomainHostdevSubsysType; @@ -289,6 +290,10 @@ struct _virDomainHostdevSubsysMediatedDev { virTristateSwitch ramfb; }; +struct _virDomainHostdevSubsysVDPA { + char *devpath; /* vDPA device path */ +}; + typedef enum { VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_NONE, VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_VHOST, @@ -323,6 +328,7 @@ struct _virDomainHostdevSubsys { virDomainHostdevSubsysSCSI scsi; virDomainHostdevSubsysSCSIVHost scsi_host; virDomainHostdevSubsysMediatedDev mdev; + virDomainHostdevSubsysVDPA vdpa; } u; }; diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index e04b85fee4..4af84c4f0c 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2214,6 +2214,7 @@ virDomainHostdevDefValidate(const virDomainHostdevDef *hostdev) } break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/conf/virconftypes.h b/src/conf/virconftypes.h index e07f967814..1756c54e7a 100644 --- a/src/conf/virconftypes.h +++ b/src/conf/virconftypes.h @@ -120,6 +120,8 @@ typedef struct _virDomainHostdevSubsys virDomainHostdevSubsys; typedef struct _virDomainHostdevSubsysMediatedDev virDomainHostdevSubsysMediatedDev; +typedef struct _virDomainHostdevSubsysVDPA virDomainHostdevSubsysVDPA; + typedef struct _virDomainHostdevSubsysPCI virDomainHostdevSubsysPCI; typedef struct _virDomainHostdevSubsysSCSI virDomainHostdevSubsysSCSI; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4ca93bf3dc..121214f4d5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4958,6 +4958,18 @@ qemuBuildHostdevMediatedDevProps(const virDomainDef *def, return g_steal_pointer(&props); } +virJSONValue * +qemuBuildHostdevVDPADevProps(virDomainHostdevDef *dev) +{ + g_autoptr(virJSONValue) props = NULL; + virDomainHostdevSubsysVDPA *vdpasrc = &dev->source.subsys.u.vdpa; + if (virJSONValueObjectAdd(&props, + "s:driver", "vhost-vdpa-device-pci", + "s:vhostdev", vdpasrc->devpath, + NULL) < 0) + return NULL; + return g_steal_pointer(&props); +} qemuBlockStorageSourceAttachData * qemuBuildHostdevSCSIDetachPrepare(virDomainHostdevDef *hostdev, @@ -5154,6 +5166,13 @@ qemuBuildHostdevCommandLine(virCommand *cmd, return -1; break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + if (!(devprops = qemuBuildHostdevVDPADevProps(hostdev))) + return -1; + if (qemuBuildDeviceCommandlineFromJSON(cmd, devprops, def, qemuCaps) < 0) + return -1; + break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 5fdb138030..dff18350b5 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -198,6 +198,9 @@ virJSONValue * qemuBuildHostdevMediatedDevProps(const virDomainDef *def, virDomainHostdevDef *dev); +virJSONValue * +qemuBuildHostdevVDPADevProps(virDomainHostdevDef *dev); + virJSONValue * qemuBuildRedirdevDevProps(const virDomainDef *def, virDomainRedirdevDef *dev); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 63b13b6875..0cd485a459 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10533,6 +10533,8 @@ qemuDomainGetHostdevPath(virDomainHostdevDef *dev, virDomainHostdevSubsysSCSI *scsisrc = &dev->source.subsys.u.scsi; virDomainHostdevSubsysSCSIVHost *hostsrc = &dev->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDev *mdevsrc = &dev->source.subsys.u.mdev; + virDomainHostdevSubsysVDPA *vdpasrc = &dev->source.subsys.u.vdpa; + g_autoptr(virUSBDevice) usb = NULL; g_autoptr(virSCSIDevice) scsi = NULL; g_autoptr(virSCSIVHostDevice) host = NULL; @@ -10603,6 +10605,10 @@ qemuDomainGetHostdevPath(virDomainHostdevDef *dev, if (!(tmpPath = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return -1; + perm = VIR_CGROUP_DEVICE_RW; + break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + tmpPath = g_strdup(vdpasrc->devpath); perm = VIR_CGROUP_DEVICE_RW; break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5072798cb7..7d89899223 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4546,6 +4546,7 @@ qemuDomainRemoveHostDevice(virQEMUDriver *driver, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: qemuDomainRemoveMediatedDevice(driver, vm, hostdev); break; + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: break; } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index ed41a03851..9220ef1ab1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1295,6 +1295,8 @@ qemuMigrationSrcIsAllowedHostdev(const virDomainDef *def) case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: + /* The vDPA devices don't support migration for now */ + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: virReportError(VIR_ERR_OPERATION_UNSUPPORTED, _("cannot migrate a domain with <hostdev mode='subsystem' type='%1$s'>"), virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b8d5e9bd74..ea3d4e1a39 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2566,6 +2566,8 @@ qemuValidateDomainDeviceDefHostdev(const virDomainHostdevDef *hostdev, break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: return qemuValidateDomainMdevDef(hostdev, def, qemuCaps); + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: + break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: default: virReportEnumRangeError(virDomainHostdevSubsysType, diff --git a/src/security/security_dac.c b/src/security/security_dac.c index c7dc145621..24f3de5d15 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1313,6 +1313,7 @@ virSecurityDACSetHostdevLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; @@ -1469,6 +1470,7 @@ virSecurityDACRestoreHostdevLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index e3e6a6115f..5cb6612fbc 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -2265,6 +2265,7 @@ virSecuritySELinuxSetHostdevSubsysLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; @@ -2493,6 +2494,7 @@ virSecuritySELinuxRestoreHostdevSubsysLabel(virSecurityManager *mgr, break; } + case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_VDPA: case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST: ret = 0; break; -- 2.33.0

1 0

[libvirt PATCH] .gitlab-ci.yml: Fix Leap 15.4 codestyle job
by Erik Skultety 05 May '23

05 May '23

Commit a3cc0e9ceb3e forgot to tweak the codestyle job so that we refer to Leap 15.4 as Leap 15 (with the recent change in lcitool). However, it was easy to miss as that job is not managed by the manifest. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- .gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3a36c0ef18..2378b1a39f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -118,10 +118,10 @@ codestyle_prebuilt_env: - .codestyle_job - .gitlab_native_build_job_prebuilt_env needs: - - job: x86_64-opensuse-leap-154-container + - job: x86_64-opensuse-leap-15-container optional: true variables: - NAME: opensuse-leap-154 + NAME: opensuse-leap-15 codestyle_local_env: extends: @@ -129,7 +129,7 @@ codestyle_local_env: - .gitlab_native_build_job_local_env variables: IMAGE: registry.opensuse.org/opensuse/leap:15.4 - NAME: opensuse-leap-154 + NAME: opensuse-leap-15 # This artifact published by this job is downloaded to push to Weblate -- 2.40.1

2 1

[libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
by Erik Skultety 05 May '23

05 May '23

This depends on the corresponding changes in libvirt-perl and libvirt-python: https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/92 https://gitlab.com/libvirt/libvirt-python/-/merge_requests/114 Once those are in, I'll provide a link to a fresh libvirt proof pipeline. Erik Skultety (4): ci: Add Fedora 38 target ci: Drop Fedora 36 target ci: Flip mingw jobs from Fedora 37 to Fedora 38 ci: integration: Flip QEMU upstream integration tests to Fedora 38 ...-mingw32.sh => fedora-38-cross-mingw32.sh} | 0 ...-mingw64.sh => fedora-38-cross-mingw64.sh} | 0 ci/buildenv/{fedora-36.sh => fedora-38.sh} | 0 ...ile => fedora-38-cross-mingw32.Dockerfile} | 2 +- ...ile => fedora-38-cross-mingw64.Dockerfile} | 2 +- ...ora-36.Dockerfile => fedora-38.Dockerfile} | 2 +- ci/gitlab/builds.yml | 76 ++++++------- ci/gitlab/containers.yml | 22 ++-- ci/integration.yml | 104 +++++++++--------- ci/manifest.yml | 17 +-- 10 files changed, 113 insertions(+), 112 deletions(-) rename ci/buildenv/{fedora-37-cross-mingw32.sh => fedora-38-cross-mingw32.sh} (100%) rename ci/buildenv/{fedora-37-cross-mingw64.sh => fedora-38-cross-mingw64.sh} (100%) rename ci/buildenv/{fedora-36.sh => fedora-38.sh} (100%) rename ci/containers/{fedora-37-cross-mingw32.Dockerfile => fedora-38-cross-mingw32.Dockerfile} (98%) rename ci/containers/{fedora-37-cross-mingw64.Dockerfile => fedora-38-cross-mingw64.Dockerfile} (98%) rename ci/containers/{fedora-36.Dockerfile => fedora-38.Dockerfile} (98%) -- 2.40.0

2 8

[PATCH] qemu: hotplug: Reorder setup of disk backend metadata
by Peter Krempa 05 May '23

05 May '23

The regular VM startup code first calls the setup of the disk backing chain as defined in the XML and then calls the function to load the rest of the backing chain from the image metadata. The hotplug code did it the other way around, thus causing a failure when attempting to attach a QCOW2 image via FD passing. Reorder the hotplug code to have the same order. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2193315 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_hotplug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 8c14540275..54b5a2c2c9 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -921,9 +921,6 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver, if (virDomainDiskTranslateSourcePool(disk) < 0) goto cleanup; - if (qemuDomainDetermineDiskChain(driver, vm, disk, NULL) < 0) - goto cleanup; - for (i = 0; i < vm->def->ndisks; i++) { if (virDomainDiskDefCheckDuplicateInfo(vm->def->disks[i], disk) < 0) goto cleanup; @@ -1007,6 +1004,9 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriver *driver, if (qemuDomainPrepareDiskSource(disk, priv, cfg) < 0) goto cleanup; + if (qemuDomainDetermineDiskChain(driver, vm, disk, NULL) < 0) + goto cleanup; + if (qemuHotplugAttachManagedPR(vm, disk->src, VIR_ASYNC_JOB_NONE) < 0) goto cleanup; -- 2.40.0

2 1

[libvirt PATCH 0/5] meson: Introduce initconfdir option
by Andrea Bolognani 05 May '23

05 May '23

Makes things nicer for those using distros that are not derived from RHEL or SUSE. Andrea Bolognani (5): meson: Introduce initconfdir option meson: Use initconfdir rpm: Set initconfdir explicitly meson: Move definition of os_release meson: Improve initconfdir defaults docs/manpages/libvirt-guests.rst | 2 +- docs/manpages/meson.build | 1 + libvirt.spec.in | 1 + meson.build | 20 +++++++++++++++++++- meson_options.txt | 1 + src/ch/virtchd.service.in | 2 +- src/interface/virtinterfaced.service.in | 2 +- src/libxl/virtxend.service.in | 2 +- src/locking/virtlockd.service.in | 2 +- src/logging/virtlogd.service.in | 2 +- src/lxc/virtlxcd.service.in | 2 +- src/meson.build | 1 + src/network/virtnetworkd.service.in | 2 +- src/node_device/virtnodedevd.service.in | 2 +- src/nwfilter/virtnwfilterd.service.in | 2 +- src/qemu/virtqemud.service.in | 2 +- src/remote/libvirtd.service.in | 2 +- src/remote/virtproxyd.service.in | 2 +- src/secret/virtsecretd.service.in | 2 +- src/storage/virtstoraged.service.in | 2 +- src/vbox/virtvboxd.service.in | 2 +- src/vz/virtvzd.service.in | 2 +- tools/libvirt-guests.service.in | 2 +- tools/libvirt-guests.sh.in | 5 +++-- tools/meson.build | 1 + tools/virt-pki-validate.in | 13 +++++++------ 26 files changed, 52 insertions(+), 27 deletions(-) -- 2.40.1

2 12

[libvirt PATCH] util: Improve comment for workaround
by Andrea Bolognani 04 May '23

04 May '23

Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/util/virfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 657e74e026..228482e8f8 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file) return NULL; /* Workaround for a bug in g_find_program_in_path() not returning absolute - * path as documented. This has been fixed in - * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127 + * path as documented. TODO drop it once we require GLib >= 2.69.0 */ return g_canonicalize_filename(path, NULL); } -- 2.40.1

2 1

[PATCH] qemu: Fix error message
by Andrea Bolognani 04 May '23

04 May '23

The spelling is slightly different from another otherwise identical error message in the same file. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index db47e4b5ba..7a7af2850e 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -252,7 +252,7 @@ qemuDBusStart(virQEMUDriver *driver, if (!virFileExists(sockpath)) { virReportError(VIR_ERR_OPERATION_TIMEOUT, - _("DBus daemon %1$s didn't show up"), + _("dbus-daemon %1$s didn't show up"), cfg->dbusDaemonName); goto cleanup; } -- 2.40.1

1 0

[PATCH v2 0/1] allow risc-v domains to use CPU definitions
by Daniel Henrique Barboza 04 May '23

04 May '23

Hi, The bulk of the changes from v1 is in the commit message. See version 1 [1] for more details. Changes from v1: - rewrote the commit message to reflect the actual problem - changed virCPUriscvUpdate() to virCPURiscv64Update() to be in line with the name convention of the driver - v1 link: https://listman.redhat.com/archives/libvir-list/2023-April/239687.html [1] https://listman.redhat.com/archives/libvir-list/2023-April/239687.html Daniel Henrique Barboza (1): cpu_riscv64.c: add update() implementation po/POTFILES | 1 + src/cpu/cpu_riscv64.c | 28 +++++++++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) -- 2.40.0

2 2

[PATCH 0/2] gitlab: Adapt name of CI job building the web page to 'pages'
by Peter Krempa 04 May '23

04 May '23

The subject is deliberately chosen so that it does not imply that we actually want to host libvirt.org via gitlab pages at this time. It's not possible as gitlab pages don't allow redirects to different domains: https://gitlab.com/gitlab-org/gitlab-pages/-/issues/601 The merit of this change was discussed here: https://gitlab.com/libvirt/libvirt-ocaml/-/merge_requests/23#note_1360494690 Along with this patch, a change to to the job deploying the page on libvirt.org will be needed. Peter Krempa (2): gitlab-ci: Configure website build to be published via gitlab pages docs: Add redirects configuration for gitlab pages .gitlab-ci.yml | 70 ++++++++++++++++++++++++++++++++++++------ docs/.gitlab_redirects | 38 +++++++++++++++++++++++ 2 files changed, 99 insertions(+), 9 deletions(-) create mode 100644 docs/.gitlab_redirects -- 2.40.0

1 2

[PATCH 0/1] fix risc-v QEMU domains in non-RISC-V hosts
by Daniel Henrique Barboza 03 May '23

03 May '23

Hi, For some reason didn't notice this was broken until recently. We're missing an API in the RISC-V CPU driver to allow QEMU TCG risc-v domains to run in non-native hosts. Daniel Henrique Barboza (1): cpu_riscv64.c: add update() implementation src/cpu/cpu_riscv64.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) -- 2.40.0

2 5

[libvirt PATCH] meson: Fix qemu_{user,group} defaults for Arch
by Andrea Bolognani 03 May '23

03 May '23

The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Proof that I'm not making this up: https://github.com/archlinux/svntogit-community/blob/83e66277ba6e08968496c8… meson.build | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index bad13c0c9d..09c3ab00f4 100644 --- a/meson.build +++ b/meson.build @@ -1614,20 +1614,18 @@ if not get_option('driver_qemu').disabled() qemu_group = 'wheel' else os_release = run_command('grep', '-E', '^ID(_LIKE)*=', '/etc/os-release', check: false).stdout() - if os_release.contains('arch') - qemu_user = 'nobody' - qemu_group = 'nobody' # RHEL and CentOS both have ID_LIKE=fedora, SLES has ID_LIKE=suse - elif (os_release.contains('fedora') or - os_release.contains('gentoo') or - os_release.contains('suse')) + if (os_release.contains('fedora') or + os_release.contains('gentoo') or + os_release.contains('suse')) qemu_user = 'qemu' qemu_group = 'qemu' # Ubuntu has ID_LIKE=debian so we need to handle it first elif os_release.contains('ubuntu') qemu_user = 'libvirt-qemu' qemu_group = 'kvm' - elif os_release.contains('debian') + elif (os_release.contains('arch') or + os_release.contains('debian')) qemu_user = 'libvirt-qemu' qemu_group = 'libvirt-qemu' else -- 2.40.1

2 1

[PATCH v1] use libexecdir as location for qemu-bridge-helper
by Olaf Hering 02 May '23

02 May '23

The current logic in meson.build assumes a fixed runtime path for qemu-bridge-helper in case this binary is not available during build. Since qemu-bridge-helper is not used during build it is not required to have it installed at build time. It is likely that both qemu and libvirt are built with the same --libexecdir option. So use this as the expected location for qemu-bridge-helper. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c2a2f306c1..6ca05e2f69 100644 --- a/meson.build +++ b/meson.build @@ -1653,7 +1653,7 @@ if not get_option('driver_qemu').disabled() if qemu_bridge_prog.found() qemu_bridge_path = qemu_bridge_prog.full_path() else - qemu_bridge_path = '/usr/libexec/qemu-bridge-helper' + qemu_bridge_path = libexecdir / 'qemu-bridge-helper' endif conf.set_quoted('QEMU_BRIDGE_HELPER', qemu_bridge_path)

2 2

Release of libvirt-9.3.0
by Jiri Denemark 02 May '23

02 May '23

The 9.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: Introduce support for ``igb`` network interface model ``igb`` is a successor to the ``e1000e`` network device using PCIe interface. It was introduced in QEMU 8.0 * qemu: Improve handling of maximum physical address configuration * Improvements * qemu: Change default machine type for ARM and RISC-V ARM and RISC-V architectures now use the ``virt`` machine type by default. The previous defaults were nearly unusable and had to be overridden in most cases. * Improve translatable strings format substitutions All translatable error messages with substitution strings were converted to use positional modifiers to allow translators to shuffle around words in the translation. The translations in Weblate were also updated to match. * qemu: Improve validation of ``watchdog`` devices Certain invalid configurations of ``watchdog`` device are now properly detected: - hotplug of always-present platform watchdogs is forbidden - ``iTCO`` watchdog can be configured only once - ``ib700`` watchdog is allowed only on ``i440fx`` machines * Improved output of ``virt-host-validate`` on ARM Our validation tool now parses the ``IORT`` data on ARM to properly detect presence of SMMU and other features. * Bug fixes * qemu: Fix inactive internal snapshots of VM with UEFI firmware Recent changes to UEFI firmware handling resulted into breaking support for inactive internal snapshots of VMs with UEFI which historically worked. (Although the intention was to disallow them together with active ones, but the check did not work properly.) Preserve existing functionality by allowing such snapshots explicitly. * qemu: Properly configure locked memory limit for VMs with ``<disk type='nvme'`` The NVMe driver in qemu requires some memory to be locked. This was not taken into account in the code which calculates the memory limits based on devices present in the configuration * Fix native build on win32 Various improvements to the build system now allow users to build the client library of libvirt on win32 natively. * qemu: Properly detect tray of hotplugged CD-ROM devices Media in a CD-ROM device which was hotplugged could not be changed as the presence of the tray was not detected properly on hotplug. Enjoy. Jirka

1 0

[PATCH] NEWS: Update news for the 9.3.0 release
by Peter Krempa 02 May '23

02 May '23

Update the news file mentioning important changes such as the change of translatable strings or the fix of inactive snapshots of VMs using uefi. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2a844ce40c..d0d78e2127 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v9.3.0 (unreleased) * **New features** + * qemu: Introduce support for ``igb`` network interface model + + ``igb`` is a successor to the ``e1000e`` network device using PCIe interface. + It was introduced in QEMU 8.0 + + * qemu: Improve handling of maximum physical address configuration + * **Improvements** * qemu: Change default machine type for ARM and RISC-V @@ -25,8 +32,54 @@ v9.3.0 (unreleased) The previous defaults were nearly unusable and had to be overridden in most cases. + * Improve translatable strings format substitutions + + All translatable error message with substitution strings were converted to + use positional modifiers to allow translators to shuffle around the + translated message. The translations pulled from Weblate were also updated to + match. + + * qemu: Improve validation of ``watchdog`` devices + + Certain invalid configurations of ``watchdog`` device are now properly + detected: + + - hotplug of always-present platform watchdogs is forbidden + - ``iTCO`` watchdog can be configured only once + - ``ib700`` watchdog is allowed only on ``i440fx`` machines + + * Improved output of ``virt-host-validate`` on ARM + + Our validation tool now parses the ``IORT`` data on ARM to properly detect + presence of SMMU and other features. + * **Bug fixes** + * qemu: Fix inactive internal snapshots of VM with UEFI firmware + + Recent changes to UEFI firmware handling resulted into breaking support + for inactive internal snapshots of VMs with UEFI which historically worked. + (Although the intention was to disallow them together with active ones, but + the check did not work properly.) + + Preserve existing functionality by allowing such snapshots explicitly. + + * qemu: Properly configure locked memory limit for VMs with ``<disk type='nvme'`` + + The NVMe driver in qemu requires some memory to be locked. This was not + taken into account in the code which calculates the memory limits based + on devices present in the configuration + + * Fix native build on win32 + + Various improvements to the build system now allow users to build the client + library of libvirt on win32 natively. + + * qemu: Properly detect tray of hotplugged CD-ROM devices + + Media in a CD-ROM device which was hotplugged could not be changed as the + presence of the tray was not detected properly on hotplug. + v9.2.0 (2023-04-01) =================== -- 2.40.0

2 1

[PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces
by Peter Maydell 02 May '23

02 May '23

The command line option '-singlestep' and its HMP equivalent the 'singlestep' command are very confusingly named, because they have nothing to do with single-stepping the guest (either via the gdb stub or by emulation of guest CPU architectural debug facilities). What they actually do is put TCG into a mode where it puts only one guest instruction into each translation block. This is useful for some circumstances such as when you want the -d debug logging to be easier to interpret, or if you have a finicky guest binary that wants to see interrupts delivered at something other than the end of a basic block. The confusing name is made worse by the fact that our documentation for these is so minimal as to be useless for telling users what they really do. This series: * changes the command line interface: for user-mode emulators, the new option is '-one-insn-per-tb', and for system mode emulators it is a TCG accel property '-accel tcg,one-insn-per-tb=on' * updates all the places which currently directly touch the 'singlestep' global variable to instead get the current accelerator and query/set the QOM property (except the one internal to TCG itself in curr_cflags()) * documents that the old -singlestep option is deprecated * adds a new HMP command 'one-insn-per-tb', and deprecates the old 'singlestep' command. (Strictly we don't need to deprecate HMP commands, but I'd already written the code for v1 of this series and it's a minor user convenience.) * moves the 'is one-insn-per-tb on?' info from 'info status' to 'info jit' * deprecates the 'singlestep' member of the QMP StatusInfo type, with no replacement. (We have a sketch of a design of how we might provide this in QMP if we need to, but I'm pretty sure nobody using QMP is actually using the info in the 'singlestep' field, especially since it's always been wrongly documented and there's no write interface, only a read one.) Changes v2->v3: * curr_cflags() is a hot path, so use a global variable so it doesn't have to fetch the current accelerator object. (NB: I haven't done the tcg_global_cflags thing suggested in review of v2; justification in the below-the-fold part of the patch 3 commit message notes.) * put the new line in test-hmp.c in its proper alphabetical order place in patch 8 * in patch 10 don't provide a replacement field in the QMP StatusInfo type, just deprecate the old one * I finally tested that bsd-user compiles, and fixed the missing-close-bracket error in that patch :-) Patches still needing review: 3, 7, 10 thanks -- PMM Peter Maydell (10): make one-insn-per-tb an accel option softmmu: Don't use 'singlestep' global in QMP and HMP commands accel/tcg: Use one_insn_per_tb global instead of old singlestep global linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' bsd-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' Document that -singlestep command line option is deprecated accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status' hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep' qapi/run-state.json: Fix missing newline at end of file hmp: Deprecate 'singlestep' member of StatusInfo docs/about/deprecated.rst | 39 +++++++++++++++++++++++++++++++++++++ docs/user/main.rst | 14 +++++++++++-- qapi/run-state.json | 16 +++++++++++---- accel/tcg/internal.h | 2 ++ include/exec/cpu-common.h | 2 -- include/monitor/hmp.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/monitor.c | 14 +++++++++++++ accel/tcg/tcg-all.c | 23 ++++++++++++++++++++++ bsd-user/main.c | 14 ++++++++----- linux-user/main.c | 18 +++++++++++------ softmmu/globals.c | 1 - softmmu/runstate-hmp-cmds.c | 25 ++++++++++++++++++------ softmmu/runstate.c | 10 +++++++++- softmmu/vl.c | 17 ++++++++++++++-- tests/qtest/test-hmp.c | 1 + hmp-commands.hx | 25 ++++++++++++++++++++---- qemu-options.hx | 12 ++++++++++-- tcg/tci/README | 2 +- 19 files changed, 201 insertions(+), 38 deletions(-) -- 2.34.1

4 29

[PATCH] virpci: Resolve leak in virPCIVirtualFunctionList cleanup
by Tim Shearer 02 May '23

02 May '23

Repeatedly querying an SR-IOV PCI device's capabilities exposes a memory leak caused by a failure to free the virPCIVirtualFunction array within the parent struct's g_autoptr cleanup. Valgrind output after getting a single interface's XML description 1000 times: ==325982== 256,000 bytes in 1,000 blocks are definitely lost in loss record 2,634 of 2,635 ==325982== at 0x4C3C096: realloc (vg_replace_malloc.c:1437) ==325982== by 0x59D952D: g_realloc (in /usr/lib64/libglib-2.0.so.0.5600.4) ==325982== by 0x4EE1F52: virReallocN (viralloc.c:52) ==325982== by 0x4EE1FB7: virExpandN (viralloc.c:78) ==325982== by 0x4EE219A: virInsertElementInternal (viralloc.c:183) ==325982== by 0x4EE23B2: virAppendElement (viralloc.c:288) ==325982== by 0x4F65D85: virPCIGetVirtualFunctionsFull (virpci.c:2389) ==325982== by 0x4F65753: virPCIGetVirtualFunctions (virpci.c:2256) ==325982== by 0x505CB75: virNodeDeviceGetPCISRIOVCaps (node_device_conf.c:2969) ==325982== by 0x505D181: virNodeDeviceGetPCIDynamicCaps (node_device_conf.c:3099) ==325982== by 0x505BC4E: virNodeDeviceUpdateCaps (node_device_conf.c:2677) ==325982== by 0x260FCBB2: nodeDeviceGetXMLDesc (node_device_driver.c:355) Signed-off-by: Tim Shearer <tshearer(a)adva.com> --- src/util/virpci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virpci.c b/src/util/virpci.c index 9e564e4a4f..cc2b07bbba 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2245,6 +2245,7 @@ virPCIVirtualFunctionListFree(virPCIVirtualFunctionList *list) g_free(list->functions[i].ifname); } + g_free(list->functions); g_free(list); } -- 2.31.1

2 1

None
by daggs 01 May '23

01 May '23

Greetings, I'm trying to boot a VM with pi of the on sound card and the gpu using libvirt[1] and qemu I have a script that loads the needed KVM mods, starts libvirt and press the HDD Then starts the VM with virus. I've configured qemu hooks to run scripts in the relevant events. In prepare, I disable active ui, unbind the screen and consoles, unload all the mods of the hw and load the vfio mods with the IDs of the devs and allow unsafe intrs. Then libvirt tries to start the VM and fails with the this error: error: Failed to start domain 'win_user_home' error: internal error: qemu unexpectedly closed the monitor: 2023-05-01T14:59:49.968252Z qemu-system-x86_64: -device {"driver":"vfio-pci","host":"0000:05:00.0","id":"hostdev0","bus":"pci.5","multifunction":true,"addr":"0x0"}: vfio 0000:05:00.0: failed to setup container for group 14: Failed to set iommu for container: Operation not permitted The GPU has its own iommu group[2] and I pass the soundcard too. Why am I getting this error? I did got the VM to start in earlier more simple setup with less devices so I know it boots. thanks, Dagg 1. xml file: <domain type='kvm'> <name>win_user_home</name> <uuid>f17be092-0fcb-47b6-b717-d4b8052ed289</uuid> <metadata> <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0"> <libosinfo:os id="http://microsoft.com/win/11"/> </libosinfo:libosinfo> </metadata> <memory unit='KiB'>24582834</memory> <currentMemory unit='KiB'>24582834</currentMemory> <vcpu placement='static'>12</vcpu> <os firmware='efi'> <type arch='x86_64' machine='pc-q35-7.1'>hvm</type> <firmware> <feature enabled='no' name='enrolled-keys'/> <feature enabled='yes' name='secure-boot'/> </firmware> <loader readonly='yes' secure='yes' type='pflash'>/usr/share/edk2-ovmf/OVMF_CODE.secboot.fd</loader> <nvram template='/usr/share/edk2-ovmf/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/win_user_home_VARS.fd</nvram> <boot dev='cdrom'/> <bootmenu enable='no'/> </os> <features> <acpi/> <apic/> <hyperv mode='custom'> <relaxed state='on'/> <vapic state='on'/> <spinlocks state='on' retries='8191'/> <vpindex state='on'/> <runtime state='on'/> <synic state='on'/> <reset state='on'/> <vendor_id state='on' value='wateverr'/> <frequencies state='on'/> </hyperv> <kvm> <hidden state='on'/> </kvm> <vmport state='off'/> <smm state='on'/> <ioapic driver='kvm'/> </features> <cpu mode='host-passthrough' check='none' migratable='on'> <topology sockets='1' dies='1' cores='6' threads='2'/> <cache level='3' mode='emulate'/> <feature policy='require' name='topoext'/> </cpu> <clock offset='utc'> <timer name='rtc' tickpolicy='catchup'/> <timer name='pit' tickpolicy='delay'/> <timer name='hpet' present='no'/> <timer name='kvmclock' present='yes'/> <timer name='hypervclock' present='yes'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <pm> <suspend-to-mem enabled='no'/> <suspend-to-disk enabled='no'/> </pm> <devices> <emulator>/usr/bin/qemu-system-x86_64</emulator> <disk type='block' device='disk'> <driver name='qemu' type='raw' cache='none' io='native' discard='unmap' detect_zeroes='unmap'/> <source dev='/dev/loop0p2'/> <target dev='vdb' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x03' slot='0x00' function='0x0'/> </disk> <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/home/virt_admin/Win11_22H2_EnglishInternational_x64v1.iso'/> <target dev='sda' bus='sata'/> <readonly/> <address type='drive' controller='0' bus='0' target='0' unit='1'/> </disk> <controller type='usb' index='0' model='qemu-xhci' ports='15'> <address type='pci' domain='0x0000' bus='0x02' slot='0x00' function='0x0'/> </controller> <controller type='sata' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x1f' function='0x2'/> </controller> <controller type='pci' index='0' model='pcie-root'/> <controller type='pci' index='1' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='1' port='0x8'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0' multifunction='on'/> </controller> <controller type='pci' index='2' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='2' port='0x9'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='pci' index='3' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='3' port='0xa'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> </controller> <controller type='pci' index='4' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='4' port='0xb'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x3'/> </controller> <controller type='pci' index='5' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='5' port='0xc'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x4'/> </controller> <controller type='pci' index='6' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='6' port='0xd'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x5'/> </controller> <controller type='pci' index='7' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='7' port='0xe'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x6'/> </controller> <interface type='bridge'> <mac address='52:54:00:85:5b:21'/> <source bridge='br0'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> </interface> <serial type='pty'> <target type='isa-serial' port='0'> <model name='isa-serial'/> </target> </serial> <console type='pty'> <target type='serial' port='0'/> </console> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <tpm model='tpm-tis'> <backend type='emulator' version='2.0'/> </tpm> <audio id='1' type='none'/> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x00' function='0x0'/> </source> <address type='pci' domain='0x0000' bus='0x05' slot='0x00' function='0x0' multifunction='on'/> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x00' function='0x1'/> </source> <address type='pci' domain='0x0000' bus='0x05' slot='0x00' function='0x1'/> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x07' slot='0x00' function='0x4'/> </source> <address type='pci' domain='0x0000' bus='0x07' slot='0x00' function='0x4'/> </hostdev> <watchdog model='itco' action='reset'/> <memballoon model='virtio'> <address type='pci' domain='0x0000' bus='0x04' slot='0x00' function='0x0'/> </memballoon> </devices> </domain> 2. iommu list: IOMMU Group 0: 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 1: 00:01.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse GPP Bridge [1022:1483] IOMMU Group 2: 00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 3: 00:03.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 4: 00:03.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse GPP Bridge [1022:1483] IOMMU Group 5: 00:04.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 6: 00:05.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 7: 00:07.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 8: 00:07.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse Internal PCIe GPP Bridge 0 to bus[E:B] [1022:1484] IOMMU Group 9: 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Host Bridge [1022:1482] IOMMU Group 10: 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse Internal PCIe GPP Bridge 0 to bus[E:B] [1022:1484] IOMMU Group 11: 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller [1022:790b] (rev 61) 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC Bridge [1022:790e] (rev 51) IOMMU Group 12: 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 0 [1022:1440] 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 1 [1022:1441] 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 2 [1022:1442] 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 3 [1022:1443] 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 4 [1022:1444] 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 5 [1022:1445] 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 6 [1022:1446] 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Matisse/Vermeer Data Fabric: Device 18h; Function 7 [1022:1447] IOMMU Group 13: 01:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] 500 Series Chipset USB 3.1 XHCI Controller [1022:43ee] 01:00.1 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] 500 Series Chipset SATA Controller [1022:43eb] 01:00.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] 500 Series Chipset Switch Upstream Port [1022:43e9] 02:08.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:43ea] 02:09.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device [1022:43ea] 03:00.0 Network controller [0280]: Intel Corporation Wi-Fi 6 AX200 [8086:2723] (rev 1a) 04:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8125 2.5GbE Controller [10ec:8125] (rev 04) IOMMU Group 14: 05:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP107 [GeForce GTX 1050 Ti] [10de:1c82] (rev a1) 05:00.1 Audio device [0403]: NVIDIA Corporation GP107GL High Definition Audio Controller [10de:0fb9] (rev a1) IOMMU Group 15: 06:00.0 Non-Essential Instrumentation [1300]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse PCIe Dummy Function [1022:148a] IOMMU Group 16: 07:00.0 Non-Essential Instrumentation [1300]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse Reserved SPP [1022:1485] IOMMU Group 17: 07:00.1 Encryption controller [1080]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse Cryptographic Coprocessor PSPCPP [1022:1486] IOMMU Group 18: 07:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Matisse USB 3.0 Host Controller [1022:149c] IOMMU Group 19: 07:00.4 Audio device [0403]: Advanced Micro Devices, Inc. [AMD] Starship/Matisse HD Audio Controller [1022:1487]

1 0

[PATCH v2 0/1] qemu: Allow sockets in long or deep paths.
by Nick Guenther 29 Apr '23

29 Apr '23

v1: https://listman.redhat.com/archives/libvir-list/2023-April/239441.html Address v1's cleanup bugs by using g_autofree and the concurrency bugs by forking a subprocess before chdir(). It works! I have been working on the other solution of putting paths in /var/run, from https://listman.redhat.com/archives/libvir-list/2023-April/239536.html, but so my attempts have ballooned out of control. I would like to offer this improved version of my original patch in the meantime. Plus there's the unclear impact of the other strategy on upgrades: https://listman.redhat.com/archives/libvir-list/2023-April/239470.html, which means even once that's implemented it will take a long time to vet. The chdir() approach cuts right to the point. I'm hoping you'll accept both approaches as complementary and worth adopting. Original issue: https://gitlab.com/libvirt/libvirt/-/issues/466 Cheers! Nick Guenther (1): qemu: Allow sockets in long or deep paths. src/qemu/qemu_command.c | 72 ++++++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 15 deletions(-) -- 2.34.1

2 3

[PATCH 0/2] tools: virsh-domain: display progress with enhanced granularity
by Shaleen Bathla 28 Apr '23

28 Apr '23

Changes since v1 ================================================================================ - Remove superfluous parenthesis - Update progress as 99.99 instead of 99.00 - Add comment for auto-round-off prevention logic for double Description ================================================================================== While working with active blockcommit using virsh/libvirt, we found that in case of heavy IO, the progress may stay stuck at 99% for quite a while. It will be much better if we show progress upto 2 decimal places more precise which should be sufficient for most scenarios for now. This will give a user, a better understanding of the progress of blockjob/blockcommit etc This patch intends to do exactly that by adding more granularity to blockjob/blockcommit etc progress. Shaleen Bathla (2): tools: virsh-domain: refactor variable initialization tools: virsh-domain: display progress with enhanced granularity tools/virsh-domain.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) -- 2.31.1

3 6

Entering freeze for libvirt-9.3.0
by Jiri Denemark 27 Apr '23

27 Apr '23

I have just tagged v9.3.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[libvirt PATCH v2 0/1] meson: Check header usability
by Andrea Bolognani 27 Apr '23

27 Apr '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/850846324 Changes from [v1]: * replace all uses of has_header() with check_header(). [v1] https://listman.redhat.com/archives/libvir-list/2023-April/239672.html Andrea Bolognani (1): meson: Check header usability meson.build | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.40.0

2 5

[libvirt PATCH] meson: Check usability of linux/kvm.h
by Andrea Bolognani 27 Apr '23

27 Apr '23

This fixes cross-building in some scenarios. Specifically, when building for armv7l on x86_64, has_header() will see the x86_64 version of the header and consider it usable. Later, when an attempt is made to actually use it, the compiler will quickly realize that things can't quite work. The reason why we haven't hit this in our CI is that we only ever install the foreign version of header files. When building the Debian package, however, some of the Debian-specific tooling will bring in the native version of the Linux headers in addition to the foreign one, causing Meson to misreport the header's availability status. Checking for its actual usability, as opposed to mere presence, is enough to make things work correctly in all cases. https://bugs.debian.org/1024504 Suggested-by: Helmut Grohne <helmut(a)subdivi.de> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- meson.build | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d35d5e076b..21a4bd5b37 100644 --- a/meson.build +++ b/meson.build @@ -614,7 +614,6 @@ headers = [ 'asm/hwcap.h', 'ifaddrs.h', 'libtasn1.h', - 'linux/kvm.h', 'mntent.h', 'net/ethernet.h', 'net/if.h', @@ -635,12 +634,24 @@ if host_machine.system() == 'freebsd' headers += 'libutil.h' endif +# headers for which we need to check actual usability. in most +# cases, checking for presence is enough (and it's way faster) +check_headers = [ + 'linux/kvm.h', +] + foreach name : headers if cc.has_header(name) conf.set('WITH_@0@'.format(name.underscorify().to_upper()), 1) endif endforeach +foreach name : check_headers + if cc.check_header(name) + conf.set('WITH_@0@'.format(name.underscorify().to_upper()), 1) + endif +endforeach + # check for kernel header required by src/util/virnetdevbridge.c if host_machine.system() == 'linux' if not cc.has_header('linux/sockios.h') -- 2.40.0

3 4

[PATCH] ci: Regenerate files
by Michal Privoznik 27 Apr '23

27 Apr '23

This removes minor version number from OpenSUSE LEAP target names and on CentOS Stream 9 installs flake8 from repositories, instead of pip. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- ci/buildenv/centos-stream-9.sh | 5 +---- .../{opensuse-leap-154.sh => opensuse-leap-15.sh} | 0 ci/containers/centos-stream-9.Dockerfile | 6 +----- ...leap-154.Dockerfile => opensuse-leap-15.Dockerfile} | 0 ci/gitlab/builds.yml | 10 +++++----- ci/gitlab/containers.yml | 4 ++-- ci/manifest.yml | 2 +- 7 files changed, 10 insertions(+), 17 deletions(-) rename ci/buildenv/{opensuse-leap-154.sh => opensuse-leap-15.sh} (100%) rename ci/containers/{opensuse-leap-154.Dockerfile => opensuse-leap-15.Dockerfile} (100%) diff --git a/ci/buildenv/centos-stream-9.sh b/ci/buildenv/centos-stream-9.sh index 79d74d9b2b..454e1f6322 100644 --- a/ci/buildenv/centos-stream-9.sh +++ b/ci/buildenv/centos-stream-9.sh @@ -68,9 +68,7 @@ function install_buildenv() { polkit \ python3 \ python3-docutils \ - python3-pip \ - python3-setuptools \ - python3-wheel \ + python3-flake8 \ qemu-img \ readline-devel \ rpcgen \ @@ -88,7 +86,6 @@ function install_buildenv() { ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/clang ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc - /usr/bin/pip3 install flake8 } export CCACHE_WRAPPERSDIR="/usr/libexec/ccache-wrappers" diff --git a/ci/buildenv/opensuse-leap-154.sh b/ci/buildenv/opensuse-leap-15.sh similarity index 100% rename from ci/buildenv/opensuse-leap-154.sh rename to ci/buildenv/opensuse-leap-15.sh diff --git a/ci/containers/centos-stream-9.Dockerfile b/ci/containers/centos-stream-9.Dockerfile index 6478031379..47e9008b72 100644 --- a/ci/containers/centos-stream-9.Dockerfile +++ b/ci/containers/centos-stream-9.Dockerfile @@ -69,9 +69,7 @@ RUN dnf distro-sync -y && \ polkit \ python3 \ python3-docutils \ - python3-pip \ - python3-setuptools \ - python3-wheel \ + python3-flake8 \ qemu-img \ readline-devel \ rpcgen \ @@ -92,8 +90,6 @@ RUN dnf distro-sync -y && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/clang && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc -RUN /usr/bin/pip3 install flake8 - ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" ENV LANG "en_US.UTF-8" ENV MAKE "/usr/bin/make" diff --git a/ci/containers/opensuse-leap-154.Dockerfile b/ci/containers/opensuse-leap-15.Dockerfile similarity index 100% rename from ci/containers/opensuse-leap-154.Dockerfile rename to ci/containers/opensuse-leap-15.Dockerfile diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index 545478d351..258d7a1da7 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -285,23 +285,23 @@ x86_64-fedora-rawhide-clang-local-env: RPM: skip -x86_64-opensuse-leap-154-prebuilt-env: +x86_64-opensuse-leap-15-prebuilt-env: extends: .native_build_job_prebuilt_env needs: - - job: x86_64-opensuse-leap-154-container + - job: x86_64-opensuse-leap-15-container optional: true allow_failure: false variables: - NAME: opensuse-leap-154 + NAME: opensuse-leap-15 RPM: skip -x86_64-opensuse-leap-154-local-env: +x86_64-opensuse-leap-15-local-env: extends: .native_build_job_local_env needs: [] allow_failure: false variables: IMAGE: registry.opensuse.org/opensuse/leap:15.4 - NAME: opensuse-leap-154 + NAME: opensuse-leap-15 RPM: skip diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml index 150df26519..5a02843ed9 100644 --- a/ci/gitlab/containers.yml +++ b/ci/gitlab/containers.yml @@ -77,11 +77,11 @@ x86_64-fedora-rawhide-container: NAME: fedora-rawhide -x86_64-opensuse-leap-154-container: +x86_64-opensuse-leap-15-container: extends: .container_job allow_failure: false variables: - NAME: opensuse-leap-154 + NAME: opensuse-leap-15 x86_64-opensuse-tumbleweed-container: diff --git a/ci/manifest.yml b/ci/manifest.yml index b68c7361ab..82b8463605 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -160,7 +160,7 @@ targets: freebsd-13: x86_64 - opensuse-leap-154: + opensuse-leap-15: jobs: - arch: x86_64 variables: -- 2.39.2

2 1

[libvirt PATCH 0/2] docs: Link to java.libvirt.org
by Andrea Bolognani 27 Apr '23

27 Apr '23

That's the new canonical location for information on libvirt-java. A server-side redirect will have to be created in order to keep existing external links working. Andrea Bolognani (2): docs: Link to java.libvirt.org docs: Drop java.rst docs/bindings.rst | 3 +- docs/docs.rst | 2 +- docs/java.rst | 127 ---------------------------------------------- docs/meson.build | 1 - 4 files changed, 3 insertions(+), 130 deletions(-) delete mode 100644 docs/java.rst -- 2.40.0

3 5

[PATCH 0/2] tools: virsh-domain: display progress with enhanced granularity
by Shaleen Bathla 27 Apr '23

27 Apr '23

While working with active blockcommit using virsh/libvirt, we found that in case of heavy IO, the progress may stay stuck at 99% for quite a while. It will be much better if we show progress upto 2 decimal places more precise which should be sufficient for most scenarios for now. This will give a user, a better understanding of the progress of blockjob/blockcommit etc This patch intends to do exactly that by adding more granularity to blockjob/blockcommit etc progress. Shaleen Bathla (2): tools: virsh-domain: refactor variable initialization tools: virsh-domain: display progress with enhanced granularity tools/virsh-domain.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) -- 2.31.1

3 4

[libvirt PATCH] run: add ability to set selinux context
by Jonathon Jongsma 26 Apr '23

26 Apr '23

When running libvirt from the build directory with the 'run' script, it will run as unconfined_t. This can result in unexpected behavior when selinux is enforcing due to the fact that the selinux policies are written assuming that libvirt is running with the system_u:system_r:virtd_t context. This patch adds a new --selinux option to the run script. When this option is specified, it will launch the specified binary using the 'runcon' utility to set its selinux context to the one mentioned above. Since this requires root privileges, setting the selinux context is not the default behavior and must be enabled with the command line switch. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- run.in | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 50 insertions(+), 6 deletions(-) diff --git a/run.in b/run.in index c6d3411082..4aa458b791 100644 --- a/run.in +++ b/run.in @@ -40,6 +40,7 @@ # # ---------------------------------------------------------------------- +import argparse import os import os.path import random @@ -59,15 +60,20 @@ def prepend(env, varname, extradir): here = "@abs_builddir@" -if len(sys.argv) < 2: - print("syntax: %s BINARY [ARGS...]" % sys.argv[0], file=sys.stderr) +parser = argparse.ArgumentParser(add_help=False) +parser.add_argument('--selinux', + action='store_true', + help='Run in the appropriate selinux context') + +opts, args = parser.parse_known_args() + +if len(args) < 1: + print("syntax: %s [--selinux] BINARY [ARGS...]" % sys.argv[0], file=sys.stderr) sys.exit(1) -prog = sys.argv[1] -args = sys.argv[1:] +prog = args[0] env = os.environ - prepend(env, "LD_LIBRARY_PATH", os.path.join(here, "src")) prepend(env, "PKG_CONFIG_PATH", os.path.join(here, "src")) prepend(env, "PATH", os.path.join(here, "tools")) @@ -130,10 +136,20 @@ def change_unit(name, action): return ret == 0 +def chcon(path, type): + ret = subprocess.call(["chcon", "-t", type, path]) + return ret == 0 + + +def restorecon(path): + ret = subprocess.call(["restorecon", path]) + return ret == 0 + + try_stop_units = [] if is_systemd_host(): maybe_stopped_units = [] - for arg in sys.argv: + for arg in args: name = os.path.basename(arg) if is_modular_daemon(name): # Only need to stop libvirtd or this specific modular unit @@ -149,6 +165,31 @@ if is_systemd_host(): if is_unit_active(unit): try_stop_units.append(unit) +if opts.selinux: + # if using a wrapper command like 'gdb', setting the selinux context + # won't work because the wrapper command will not be a valid entrypoint + # for the virtd_t context + if os.path.basename(prog) not in ["libvirtd", *modular_daemons]: + sys.exit("'{}' is not recognized as a valid libvirt daemon. Selinux " + "process context can only be set when using executing a " + "libvirt daemon directly without wrapper commands".format(prog)) + + progpath = os.path.abspath(prog) + if not progpath.startswith(os.path.abspath(here)): + sys.exit("Refusing to change selinux context of file outside build " + "directory: {}".format(prog)) + + # selinux won't allow us to transition to the virtd_t context from e.g. the + # user_home_t context (the likely label of the local executable file) + print("Setting file context of {} to virtd_exec_t...".format(progpath)) + if not chcon(progpath, "virtd_exec_t"): + sys.exit("Failed to change selinux context of binary") + + args = ['runcon', + '-u', 'system_u', + '-r', 'system_r', + '-t', 'virtd_t', *args] + if len(try_stop_units) == 0: # Run the program directly, replacing ourselves os.execvpe(prog, args, env) @@ -178,6 +219,9 @@ else: except Exception as e: print("%s" % e, file=sys.stderr) finally: + if opts.selinux: + print("Restoring selinux context...") + restorecon(prog) print("Re-starting original systemd units...") stopped_units.reverse() for unit in stopped_units: -- 2.39.2

2 6

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo
by Peter Maydell 25 Apr '23

25 Apr '23

On Tue, 25 Apr 2023 at 13:10, Markus Armbruster <armbru(a)redhat.com> wrote: > > Peter Maydell <peter.maydell(a)linaro.org> writes: > > > -# Notes: @singlestep is enabled through the GDB stub > > +# Notes: @singlestep is enabled on the command line with > > +# '-accel tcg,one-insn-per-tb=on', or with the HMP > > +# 'one-insn-per-tb' command. > > You're deleting "enabled through the GDB stub". Is this one of the > misstatements you alluded to in the commit message Yes -- this field has never been anything to do with GDB-enabled singlestep (or for that matter with emulation of any guest-CPU architecture singlestep functionality). I assume that whoever originally wrote that text was confused by the terrible name of the command line option/global variable. -- PMM

2 1

[PATCH] docs: Fix missing backtick in formatdomain.rst
by Martin Kletzander 25 Apr '23

25 Apr '23

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 8420f5f99c3a..3b9251547e84 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1209,7 +1209,7 @@ NUMA Node Tuning memory nodes, and it requires setting mode to 'restrictive' in ``memnode`` elements (see quirk below). This exists solely for the purpose of being able to request movement of such memory for a running domain using ``virsh - numatune`` or ``virDomainSetNumaParameters` and is not guaranteed to happen. + numatune`` or ``virDomainSetNumaParameters`` and is not guaranteed to happen. Attribute ``nodeset`` specifies the NUMA nodes, using the same syntax as attribute ``cpuset`` of element ``vcpu``. Attribute ``placement`` ( :since:`since 0.9.12` ) can be used to indicate the memory placement mode for -- 2.40.0

1 0

[PATCH v2 0/9] qemu: Move <hostdev> preparation into qemuDomainPrepareHostdev()
by Michal Privoznik 25 Apr '23

25 Apr '23

v2 of: https://listman.redhat.com/archives/libvir-list/2023-April/239378.html diff to v1: - More patches - Dropped qemuHostdevPreparePCIDevicesCheckSupport() completely - Dropped virQEMUCaps passing (patch 9/9) - Dropped even more checks effectively dead code Michal Prívozník (9): qemuDomainAttachHostDevice: Prepare device early and for all types qemu_domain: Move internals of qemuDomainPrepareHostdev() into a separate function qemu: Move <hostdev/> PCI backend setting into qemuDomainPrepareHostdev() qemuxml2argvtest: Drop needless PCI backend setting qemu: Deny all but VFIO PCI backends in hostdev prepare phase qemu_hotplug: Drop PCI backend check in qemuDomainAttachHostPCIDevice() qemu: Move <hostdev> SCSI path generation into qemuDomainPrepareHostdev() qemu: Remove empty functions qemu: Stop virQEMUCaps propagation into qemuHostdevPreparePCIDevices() src/qemu/qemu_domain.c | 167 ++++++++++++++++++++++++++++----------- src/qemu/qemu_driver.c | 56 ------------- src/qemu/qemu_hostdev.c | 67 +--------------- src/qemu/qemu_hostdev.h | 2 - src/qemu/qemu_hotplug.c | 43 ++-------- src/qemu/qemu_process.c | 60 +------------- src/qemu/qemu_process.h | 3 - tests/qemuxml2argvmock.c | 10 +++ tests/qemuxml2argvtest.c | 28 ------- 9 files changed, 142 insertions(+), 294 deletions(-) -- 2.39.2

3 20

[PATCH 0/2] lxc: Couple of almost trivial fixes
by Michal Privoznik 25 Apr '23

25 Apr '23

*** BLURB HERE *** Michal Prívozník (2): lxc: Make lxcCreateHostdevDef() less versatile lxc: Fix access to hostdev capabilities src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_hostdev.c | 4 ++-- src/lxc/lxc_native.c | 14 +++++--------- 3 files changed, 8 insertions(+), 12 deletions(-) -- 2.39.2

2 3

[PATCH v2] vfio/pci: Propagate ACPI notifications to user-space via eventfd
by Grzegorz Jaszczyk 25 Apr '23

25 Apr '23

To allow pass-through devices receiving ACPI notifications, permit to register ACPI notify handler (via introduced new ioctl) for a given device. The handler role is to receive and propagate such ACPI notifications to the user-space through the user provided eventfd. This allows VMM to receive and propagate them further to the VM, where the actual driver for pass-through device resides and can react to device specific notifications accordingly. The eventfd usage ensures VMM and device isolation: it allows to use a dedicated channel associated with the device for such events, such that the VMM has direct access. Since the eventfd counter is used as ACPI notification value placeholder, the eventfd signaling needs to be serialized in order to not end up with notification values being coalesced. Therefore ACPI notification values are buffered and signalized one by one, when the previous notification value has been consumed. Signed-off-by: Grzegorz Jaszczyk <jaz(a)semihalf.com> --- Changelog v1..v2: - The v2 implementation is actually completely different then v1: instead of using acpi netlink events for propagating ACPI notifications to the user space take advantage of eventfd, which can provide better VMM and device isolation: it allows to use a dedicated channel associated with the device for such events, such that the VMM has direct access. - Using eventfd counter as notification value placeholder was suggested in v1 and requires additional serialization logic introduced in v2. - Since the vfio-pci supports non-ACPI platforms address !CONFIG_ACPI case. - v1 discussion: https://patchwork.kernel.org/project/kvm/patch/20230307220553.631069-1-jaz@… --- drivers/vfio/pci/vfio_pci_core.c | 215 +++++++++++++++++++++++++++++++ include/linux/vfio_pci_core.h | 11 ++ include/uapi/linux/vfio.h | 15 +++ 3 files changed, 241 insertions(+) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index a5ab416cf476..ba8c49217875 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -10,6 +10,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/acpi.h> #include <linux/aperture.h> #include <linux/device.h> #include <linux/eventfd.h> @@ -679,6 +680,70 @@ void vfio_pci_core_disable(struct vfio_pci_core_device *vdev) } EXPORT_SYMBOL_GPL(vfio_pci_core_disable); +struct notification_queue { + int notification_val; + struct list_head notify_val_next; +}; + +#if IS_ENABLED(CONFIG_ACPI) +static void vfio_pci_core_acpi_notify(acpi_handle handle, u32 event, void *data) +{ + struct vfio_pci_core_device *vdev = (struct vfio_pci_core_device *)data; + struct vfio_acpi_notification *acpi_notify = vdev->acpi_notification; + struct notification_queue *entry; + + entry = kmalloc(sizeof(*entry), GFP_KERNEL); + if (!entry) + return; + + entry->notification_val = event; + INIT_LIST_HEAD(&entry->notify_val_next); + + mutex_lock(&acpi_notify->notification_list_lock); + list_add_tail(&entry->notify_val_next, &acpi_notify->notification_list); + mutex_unlock(&acpi_notify->notification_list_lock); + + schedule_work(&acpi_notify->acpi_notification_work); +} + +void vfio_pci_acpi_notify_close_device(struct vfio_pci_core_device *vdev) +{ + struct vfio_acpi_notification *acpi_notify = vdev->acpi_notification; + struct pci_dev *pdev = vdev->pdev; + struct acpi_device *adev = ACPI_COMPANION(&pdev->dev); + struct notification_queue *entry, *entry_tmp; + u64 cnt; + + if (!acpi_notify || !acpi_notify->acpi_notify_trigger) + return; + + acpi_remove_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY, + vfio_pci_core_acpi_notify); + + eventfd_ctx_remove_wait_queue(acpi_notify->acpi_notify_trigger, + &acpi_notify->wait, &cnt); + + flush_work(&acpi_notify->acpi_notification_work); + + mutex_lock(&acpi_notify->notification_list_lock); + list_for_each_entry_safe(entry, entry_tmp, + &acpi_notify->notification_list, + notify_val_next) { + list_del(&entry->notify_val_next); + kfree(entry); + } + mutex_unlock(&acpi_notify->notification_list_lock); + + eventfd_ctx_put(acpi_notify->acpi_notify_trigger); + + kfree(acpi_notify); + + vdev->acpi_notification = NULL; +} +#else +void vfio_pci_acpi_notify_close_device(struct vfio_pci_core_device *vdev) {} +#endif /* CONFIG_ACPI */ + void vfio_pci_core_close_device(struct vfio_device *core_vdev) { struct vfio_pci_core_device *vdev = @@ -705,6 +770,8 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev) vdev->req_trigger = NULL; } mutex_unlock(&vdev->igate); + + vfio_pci_acpi_notify_close_device(vdev); } EXPORT_SYMBOL_GPL(vfio_pci_core_close_device); @@ -882,6 +949,152 @@ int vfio_pci_core_register_dev_region(struct vfio_pci_core_device *vdev, } EXPORT_SYMBOL_GPL(vfio_pci_core_register_dev_region); +#if IS_ENABLED(CONFIG_ACPI) +static int vfio_pci_eventfd_wakeup(wait_queue_entry_t *wait, unsigned int mode, + int sync, void *key) +{ + struct vfio_acpi_notification *acpi_notify = + container_of(wait, struct vfio_acpi_notification, wait); + __poll_t flags = key_to_poll(key); + + /* + * eventfd_read signalize EPOLLOUT at the end of its function - this + * means previous eventfd with its notification value was consumed so + * the next notification can be signalized now if pending - schedule + * proper work. + */ + if (flags & EPOLLOUT) { + mutex_unlock(&acpi_notify->notification_lock); + schedule_work(&acpi_notify->acpi_notification_work); + } + + return 0; +} + +static void vfio_pci_ptable_queue_proc(struct file *file, + wait_queue_head_t *wqh, poll_table *pt) +{ + struct vfio_acpi_notification *acpi_notify = + container_of(pt, struct vfio_acpi_notification, pt); + + add_wait_queue(wqh, &acpi_notify->wait); +} + +static void acpi_notification_work_fn(struct work_struct *work) +{ + struct vfio_acpi_notification *acpi_notify; + struct notification_queue *entry; + + acpi_notify = container_of(work, struct vfio_acpi_notification, + acpi_notification_work); + + mutex_lock(&acpi_notify->notification_list_lock); + if (list_empty(&acpi_notify->notification_list) || !acpi_notify->acpi_notify_trigger) + goto out; + + /* + * If the previous eventfd was not yet consumed by user-space lets hold + * on and exit. The notification function will be rescheduled when + * signaling eventfd will be possible (when the EPOLLOUT will be + * signalized and unlocks notify_events). + */ + if (!mutex_trylock(&acpi_notify->notification_lock)) + goto out; + + entry = list_first_entry(&acpi_notify->notification_list, + struct notification_queue, notify_val_next); + + list_del(&entry->notify_val_next); + mutex_unlock(&acpi_notify->notification_list_lock); + + eventfd_signal(acpi_notify->acpi_notify_trigger, entry->notification_val); + + kfree(entry); + + return; +out: + mutex_unlock(&acpi_notify->notification_list_lock); +} + +static int vfio_pci_ioctl_acpi_notify_eventfd(struct vfio_pci_core_device *vdev, struct + vfio_irq_info __user *arg) +{ + struct file *acpi_notify_trigger_file; + struct vfio_acpi_notification *acpi_notify; + struct pci_dev *pdev = vdev->pdev; + struct acpi_device *adev = ACPI_COMPANION(&pdev->dev); + struct vfio_acpi_notify_eventfd entry; + struct eventfd_ctx *efdctx; + acpi_status status; + __poll_t events; + + if (!adev) + return -ENODEV; + + if (copy_from_user(&entry, arg, sizeof(entry))) + return -EFAULT; + + if (entry.notify_eventfd < 0) + return -EINVAL; + + efdctx = eventfd_ctx_fdget(entry.notify_eventfd); + if (IS_ERR(efdctx)) + return PTR_ERR(efdctx); + + vdev->acpi_notification = kzalloc(sizeof(*acpi_notify), GFP_KERNEL); + if (!vdev->acpi_notification) + return -ENOMEM; + + acpi_notify = vdev->acpi_notification; + + INIT_WORK(&acpi_notify->acpi_notification_work, acpi_notification_work_fn); + INIT_LIST_HEAD(&acpi_notify->notification_list); + + acpi_notify->acpi_notify_trigger = efdctx; + + mutex_init(&acpi_notify->notification_lock); + + /* + * Install custom wake-up handler to be notified whenever underlying + * eventfd is consumed by the user-space. + */ + init_waitqueue_func_entry(&acpi_notify->wait, vfio_pci_eventfd_wakeup); + init_poll_funcptr(&acpi_notify->pt, vfio_pci_ptable_queue_proc); + + acpi_notify_trigger_file = eventfd_fget(entry.notify_eventfd); + events = vfs_poll(acpi_notify_trigger_file, &acpi_notify->pt); + + status = acpi_install_notify_handler(adev->handle, ACPI_DEVICE_NOTIFY, + vfio_pci_core_acpi_notify, (void *)vdev); + + if (ACPI_FAILURE(status)) { + u64 cnt; + + pci_err(pdev, "Failed to install notify handler: %s", + acpi_format_exception(status)); + + eventfd_ctx_remove_wait_queue(acpi_notify->acpi_notify_trigger, + &acpi_notify->wait, &cnt); + + flush_work(&acpi_notify->acpi_notification_work); + + eventfd_ctx_put(acpi_notify->acpi_notify_trigger); + + kfree(acpi_notify); + + return -ENODEV; + } + + return 0; +} +#else +static int vfio_pci_ioctl_acpi_notify_eventfd(struct vfio_pci_core_device *vdev, struct + vfio_irq_info __user *arg) +{ + return -ENODEV; +} +#endif /* CONFIG_ACPI */ + static int vfio_pci_ioctl_get_info(struct vfio_pci_core_device *vdev, struct vfio_device_info __user *arg) { @@ -1398,6 +1611,8 @@ long vfio_pci_core_ioctl(struct vfio_device *core_vdev, unsigned int cmd, return vfio_pci_ioctl_reset(vdev, uarg); case VFIO_DEVICE_SET_IRQS: return vfio_pci_ioctl_set_irqs(vdev, uarg); + case VFIO_ACPI_NOTIFY_EVENTFD: + return vfio_pci_ioctl_acpi_notify_eventfd(vdev, uarg); default: return -ENOTTY; } diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h index 367fd79226a3..3711e8a1c6f0 100644 --- a/include/linux/vfio_pci_core.h +++ b/include/linux/vfio_pci_core.h @@ -49,6 +49,16 @@ struct vfio_pci_region { u32 flags; }; +struct vfio_acpi_notification { + struct eventfd_ctx *acpi_notify_trigger; + struct work_struct acpi_notification_work; + struct list_head notification_list; + struct mutex notification_list_lock; + struct mutex notification_lock; + poll_table pt; + wait_queue_entry_t wait; +}; + struct vfio_pci_core_device { struct vfio_device vdev; struct pci_dev *pdev; @@ -96,6 +106,7 @@ struct vfio_pci_core_device { struct mutex vma_lock; struct list_head vma_list; struct rw_semaphore memory_lock; + struct vfio_acpi_notification *acpi_notification; }; /* Will be exported for vfio pci drivers usage */ diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index 0552e8dcf0cb..d4b602d8f4b2 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -1622,6 +1622,21 @@ struct vfio_iommu_spapr_tce_remove { }; #define VFIO_IOMMU_SPAPR_TCE_REMOVE _IO(VFIO_TYPE, VFIO_BASE + 20) +/** + * VFIO_ACPI_NOTIFY_EVENTFD - _IOW(VFIO_TYPE, VFIO_BASE + 21, struct vfio_acpi_notify_eventfd) + * + * Register ACPI notify handler for a given device which will allow to receive + * and propagate ACPI notifications to the user-space through the user provided + * eventfd. + * + * Return: 0 on success, -errno on failure. + */ +struct vfio_acpi_notify_eventfd { + __s32 notify_eventfd; + __u32 reserved; +}; +#define VFIO_ACPI_NOTIFY_EVENTFD _IO(VFIO_TYPE, VFIO_BASE + 21) + /* ***************************************************************** */ #endif /* _UAPIVFIO_H */ -- 2.40.0.634.g4ca3ef3211-goog

2 3

[libvirt PATCHv2 0/3] qemu: support host-phys-bits-limit
by Ján Tomko 24 Apr '23

24 Apr '23

Ján Tomko (3): conf: cpu: add limit for maxphysaddr qemu: add support for setting host-phys-bits-limit qemu: allow forcing emulated maxphysaddr docs/formatdomain.rst | 10 ++++-- src/conf/cpu_conf.c | 13 ++++++++ src/conf/cpu_conf.h | 1 + src/conf/schemas/cputypes.rng | 5 +++ src/qemu/qemu_command.c | 8 ++++- src/qemu/qemu_validate.c | 7 ---- ...-phys-bits-emulate-bare.x86_64-latest.args | 33 +++++++++++++++++++ .../cpu-phys-bits-emulate-bare.xml | 20 +++++++++++ .../cpu-phys-bits-emulate3.err | 1 - .../cpu-phys-bits-emulate3.xml | 20 ----------- .../cpu-phys-bits-limit.x86_64-latest.args | 33 +++++++++++++++++++ .../qemuxml2argvdata/cpu-phys-bits-limit.xml | 20 +++++++++++ tests/qemuxml2argvtest.c | 3 +- ...u-phys-bits-emulate-bare.x86_64-latest.xml | 31 +++++++++++++++++ .../cpu-phys-bits-limit.x86_64-latest.xml | 31 +++++++++++++++++ tests/qemuxml2xmltest.c | 3 ++ 16 files changed, 207 insertions(+), 32 deletions(-) create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate-bare.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate-bare.xml delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.err delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.xml create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-limit.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-limit.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-emulate-bare.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-limit.x86_64-latest.xml -- 2.39.2

2 6

[PATCH 00/11] qemuhotplugtest: Various cleanups and improvements
by Michal Privoznik 24 Apr '23

24 Apr '23

While working on something else, I've taken a look at qemuhotplugtest and realized we can do various cleanups and improvements. The test still covers just live attach/detach/update, but after this it's prepared better to test also config attach/detach/update. Michal Prívozník (11): qemu: Replace @dom argument with @driver in qemuDomainUpdateDeviceLive() qemu: Move qemuDomainAttachDeviceLive() into qemu_hotplug.c qemu: Move qemuDomainUpdateDeviceLive() into qemu_hotplug.c qemuhotplugtest: Call qemuDomainDetachDeviceLive() directly qemuhotplugtest: Call qemuDomainAttachDeviceLive() directly qemuhotplugtest: Call qemuDomainUpdateDeviceLive() directly qemu_hotplug.h: Expose less functions qemuhotplugtest: Fix misleading comment on monitor unlock qemuhotplugtest: Don't overwrite vm->def->id in testQemuHotplugCheckResult() qemuhotplugtest: use g_autoptr(virDomainDeviceDef) qemuhotplugtest: Verify domain XML on UPDATE src/qemu/qemu_driver.c | 472 +--------------- src/qemu/qemu_hotplug.c | 525 +++++++++++++++++- src/qemu/qemu_hotplug.h | 68 +-- tests/qemuhotplugtest.c | 197 +------ ...hotplug-disk-cdrom+disk-cdrom-nochange.xml | 1 + .../qemuhotplug-disk-cdrom.xml | 30 +- ...graphics-spice+graphics-spice-nochange.xml | 1 + ...graphics-spice-listen-network-password.xml | 71 +++ ...imeout+graphics-spice-timeout-nochange.xml | 1 + ...imeout+graphics-spice-timeout-password.xml | 117 ++++ .../qemuhotplug-graphics-spice-timeout.xml | 50 +- .../qemuhotplug-graphics-spice.xml | 41 +- 12 files changed, 819 insertions(+), 755 deletions(-) create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-disk-cdrom+disk-cdrom-nochange.xml create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice+graphics-spice-nochange.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-listen-network+graphics-spice-listen-network-password.xml create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-nochange.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-password.xml -- 2.39.2

2 22

[libvirt PATCH] Move default Input bus logic to PostParse handling
by K Shiva 24 Apr '23

24 Apr '23

A new enum type "Default" has been added for Input bus. The logic that handled default input bus types in virDomainInputParseXML() has been moved to a new function virDomainInputDefPostParse() in domain_postparse.c Link to Issue: https://gitlab.com/libvirt/libvirt/-/issues/8 Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- src/conf/domain_conf.c | 27 +++------------------------ src/conf/domain_conf.h | 1 + src/conf/domain_postparse.c | 30 ++++++++++++++++++++++++++++++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain_address.c | 1 + src/qemu/qemu_hotplug.c | 2 ++ 6 files changed, 38 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b03a3ff011..22af3f1d8a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -905,6 +905,7 @@ VIR_ENUM_IMPL(virDomainInput, VIR_ENUM_IMPL(virDomainInputBus, VIR_DOMAIN_INPUT_BUS_LAST, + "default", "ps2", "usb", "xen", @@ -10693,7 +10694,6 @@ virDomainPanicDefParseXML(virDomainXMLOption *xmlopt, /* Parse the XML definition for an input device */ static virDomainInputDef * virDomainInputDefParseXML(virDomainXMLOption *xmlopt, - const virDomainDef *dom, xmlNodePtr node, xmlXPathContextPtr ctxt, unsigned int flags) @@ -10741,27 +10741,7 @@ virDomainInputDefParseXML(virDomainXMLOption *xmlopt, } } else { - if (dom->os.type == VIR_DOMAIN_OSTYPE_HVM) { - if ((def->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || - def->type == VIR_DOMAIN_INPUT_TYPE_KBD) && - (ARCH_IS_X86(dom->os.arch) || dom->os.arch == VIR_ARCH_NONE)) { - def->bus = VIR_DOMAIN_INPUT_BUS_PS2; - } else if (ARCH_IS_S390(dom->os.arch) || - def->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { - def->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; - } else if (def->type == VIR_DOMAIN_INPUT_TYPE_EVDEV) { - def->bus = VIR_DOMAIN_INPUT_BUS_NONE; - } else { - def->bus = VIR_DOMAIN_INPUT_BUS_USB; - } - } else if (dom->os.type == VIR_DOMAIN_OSTYPE_XEN || - dom->os.type == VIR_DOMAIN_OSTYPE_XENPVH) { - def->bus = VIR_DOMAIN_INPUT_BUS_XEN; - } else { - if ((dom->virtType == VIR_DOMAIN_VIRT_VZ || - dom->virtType == VIR_DOMAIN_VIRT_PARALLELS)) - def->bus = VIR_DOMAIN_INPUT_BUS_PARALLELS; - } + def->bus = VIR_DOMAIN_INPUT_BUS_DEFAULT; } if (virDomainDeviceInfoParseXML(xmlopt, node, ctxt, &def->info, flags) < 0) @@ -13766,7 +13746,7 @@ virDomainDeviceDefParse(const char *xmlStr, return NULL; break; case VIR_DOMAIN_DEVICE_INPUT: - if (!(dev->data.input = virDomainInputDefParseXML(xmlopt, def, node, + if (!(dev->data.input = virDomainInputDefParseXML(xmlopt, node, ctxt, flags))) return NULL; break; @@ -18872,7 +18852,6 @@ virDomainDefParseXML(xmlXPathContextPtr ctxt, for (i = 0; i < n; i++) { virDomainInputDef *input = virDomainInputDefParseXML(xmlopt, - def, nodes[i], ctxt, flags); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 511067a050..2a8fc6f90d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1510,6 +1510,7 @@ typedef enum { } virDomainInputType; typedef enum { + VIR_DOMAIN_INPUT_BUS_DEFAULT, VIR_DOMAIN_INPUT_BUS_PS2, VIR_DOMAIN_INPUT_BUS_USB, VIR_DOMAIN_INPUT_BUS_XEN, diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index b756e2cde8..7ef478e3e1 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -649,6 +649,33 @@ virDomainFSDefPostParse(virDomainFSDef *fs) return 0; } +static void +virDomainInputDefPostParse(virDomainInputDef *input, + const virDomainDef *def) +{ + if (input->bus == VIR_DOMAIN_INPUT_BUS_DEFAULT) { + if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) { + if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE || + input->type == VIR_DOMAIN_INPUT_TYPE_KBD) && + (ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) { + } else if (ARCH_IS_S390(def->os.arch) || + input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) { + input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO; + } else if (input->type == VIR_DOMAIN_INPUT_TYPE_EVDEV) { + input->bus = VIR_DOMAIN_INPUT_BUS_NONE; + } else { + input->bus = VIR_DOMAIN_INPUT_BUS_USB; + } + } else if (def->os.type == VIR_DOMAIN_OSTYPE_XEN || + def->os.type == VIR_DOMAIN_OSTYPE_XENPVH) { + input->bus = VIR_DOMAIN_INPUT_BUS_XEN; + } else { + if ((def->virtType == VIR_DOMAIN_VIRT_VZ || + def->virtType == VIR_DOMAIN_VIRT_PARALLELS)) + input->bus = VIR_DOMAIN_INPUT_BUS_PARALLELS; + } + } +} static int virDomainDeviceDefPostParseCommon(virDomainDeviceDef *dev, @@ -701,6 +728,9 @@ virDomainDeviceDefPostParseCommon(virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_LEASE: case VIR_DOMAIN_DEVICE_NET: case VIR_DOMAIN_DEVICE_INPUT: + virDomainInputDefPostParse(dev->data.input, def); + ret = 0; + break; case VIR_DOMAIN_DEVICE_SOUND: case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_GRAPHICS: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4ca93bf3dc..135e35f43a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4345,6 +4345,7 @@ qemuBuildInputCommandLine(virCommand *cmd, if (!(props = qemuBuildInputVirtioDevProps(def, input, qemuCaps))) return -1; + case VIR_DOMAIN_INPUT_BUS_DEFAULT: case VIR_DOMAIN_INPUT_BUS_PS2: case VIR_DOMAIN_INPUT_BUS_XEN: case VIR_DOMAIN_INPUT_BUS_PARALLELS: diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 7d3d072d5a..49c5e199fa 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -984,6 +984,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev, } return 0; + case VIR_DOMAIN_INPUT_BUS_DEFAULT: case VIR_DOMAIN_INPUT_BUS_PS2: case VIR_DOMAIN_INPUT_BUS_USB: case VIR_DOMAIN_INPUT_BUS_XEN: diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 5072798cb7..f7a41e376e 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3053,6 +3053,7 @@ qemuDomainAttachInputDevice(virDomainObj *vm, goto cleanup; break; + case VIR_DOMAIN_INPUT_BUS_DEFAULT: case VIR_DOMAIN_INPUT_BUS_PS2: case VIR_DOMAIN_INPUT_BUS_XEN: case VIR_DOMAIN_INPUT_BUS_PARALLELS: @@ -5799,6 +5800,7 @@ qemuDomainDetachPrepInput(virDomainObj *vm, *detach = input = vm->def->inputs[idx]; switch ((virDomainInputBus) input->bus) { + case VIR_DOMAIN_INPUT_BUS_DEFAULT: case VIR_DOMAIN_INPUT_BUS_PS2: case VIR_DOMAIN_INPUT_BUS_XEN: case VIR_DOMAIN_INPUT_BUS_PARALLELS: -- 2.40.0

3 2

[PATCH 0/4] qemu: Move <hostdev> preparation into qemuDomainPrepareHostdev()
by Michal Privoznik 21 Apr '23

21 Apr '23

Now, technically 2/4 is a v3 of: https://listman.redhat.com/archives/libvir-list/2023-April/239368.html but when reviewing it, I realized that we can move more code around and this ended up bigger cleanup. Michal Prívozník (3): qemuDomainAttachHostDevice: Prepare device early and for all types qemu: Move <hostdev> SCSI path generation into qemuDomainPrepareHostdev() qemu: Remove empty functions Zhenzhong Duan (1): qemu: Move <hostdev/> PCI backend setting into qemuDomainPrepareHostdev() src/qemu/qemu_domain.c | 22 ++++++++++++++++ src/qemu/qemu_driver.c | 56 --------------------------------------- src/qemu/qemu_hostdev.c | 16 +++++------ src/qemu/qemu_hotplug.c | 11 +++----- src/qemu/qemu_process.c | 57 ---------------------------------------- src/qemu/qemu_process.h | 3 --- tests/qemuxml2argvmock.c | 17 ++++++++++++ tests/qemuxml2argvtest.c | 28 -------------------- 8 files changed, 50 insertions(+), 160 deletions(-) -- 2.39.2

2 5

[PATCH] meson: Work around configure_file(copy:true) deprecation
by Michal Privoznik 21 Apr '23

21 Apr '23

In our meson scripts, we use configure_file(copy:true) to copy files from srcdir into builddir. However, as of meson-0.64.0, this is deprecated [1] in favor of using: fs = import('fs') fs.copyfile(in, out) Except, the submodule's new method wasn't introduced until 0.64.0. And since we can't bump the minimal meson version we require, we have to work with both: new and old versions. Now, the fun part: fs.copyfile() is not a drop in replacement as it returns different type (a custom_target object). This is incompatible with places where we store the configure_file() retval in a variable to process it further. While we could just replace 'copy:true' with a dummy 'configuration:...' (say 'configuration: configmake_conf') we can't do that for binary files (like src/fonts/ or src/images/). Therefore, places where we are not interested in the retval can be switched to fs.copyfile() and places where we are interested in the retval will just use a dummy 'configuration:'. Except, src/network/meson.build. In here we not just copy the file but also specify alternative install dir and that's not something that fs.copyfile() can handle. Yet, using 'copy: true' is viewed wrong [2]. 1: https://mesonbuild.com/Release-notes-for-0-64-0.html#fscopyfile-to-replace-… 2: https://github.com/mesonbuild/meson/pull/10042 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/css/meson.build | 6 +++++- docs/fonts/meson.build | 6 +++++- docs/images/meson.build | 6 +++++- docs/js/meson.build | 8 ++++++-- docs/logos/meson.build | 6 +++++- docs/meson.build | 6 +++++- meson.build | 3 +++ src/locking/meson.build | 8 ++++---- src/network/meson.build | 2 +- 9 files changed, 39 insertions(+), 12 deletions(-) diff --git a/docs/css/meson.build b/docs/css/meson.build index 384f6e789f..a2a2ccfb28 100644 --- a/docs/css/meson.build +++ b/docs/css/meson.build @@ -11,7 +11,11 @@ install_data(docs_css_files, install_dir: docs_html_dir / 'css') foreach file : docs_css_files # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'css') endforeach diff --git a/docs/fonts/meson.build b/docs/fonts/meson.build index 53a060b972..8f2b1c3d28 100644 --- a/docs/fonts/meson.build +++ b/docs/fonts/meson.build @@ -17,7 +17,11 @@ install_data(fonts, install_dir: docs_html_dir / 'fonts') foreach file : fonts # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'fonts') endforeach diff --git a/docs/images/meson.build b/docs/images/meson.build index 3c3cb5cce1..b9ab30fc91 100644 --- a/docs/images/meson.build +++ b/docs/images/meson.build @@ -17,7 +17,11 @@ install_data(docs_image_files, install_dir: docs_html_dir / 'images') foreach file : docs_image_files # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'images') endforeach diff --git a/docs/js/meson.build b/docs/js/meson.build index cbf2dc2633..9f77b0d85c 100644 --- a/docs/js/meson.build +++ b/docs/js/meson.build @@ -7,7 +7,11 @@ install_data(docs_js_files, install_dir: docs_html_dir / 'js') foreach file : docs_js_files # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif - install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'js') + install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'js') endforeach diff --git a/docs/logos/meson.build b/docs/logos/meson.build index c65fcdd8ed..c3f4c9f522 100644 --- a/docs/logos/meson.build +++ b/docs/logos/meson.build @@ -25,7 +25,11 @@ install_data(docs_logo_files, install_dir: docs_html_dir / 'logos') foreach file : docs_logo_files # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir / 'logos') endforeach diff --git a/docs/meson.build b/docs/meson.build index 864abf0ba5..caa47a1476 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -345,7 +345,11 @@ subdir('manpages') foreach file : docs_assets # This hack enables us to view the web pages # from within the uninstalled build tree - configure_file(input: file, output: file, copy: true) + if meson.version().version_compare('>=0.64.0') + fs.copyfile(file) + else + configure_file(input: file, output: file, copy: true) + endif install_web_files += '@0@:@1@'.format(meson.current_source_dir() / file, docs_html_dir) endforeach diff --git a/meson.build b/meson.build index a0682e8d0b..885fa53e50 100644 --- a/meson.build +++ b/meson.build @@ -11,6 +11,9 @@ project( ], ) +if meson.version().version_compare('>=0.64.0') + fs = import('fs') +endif # figure out if we are building from git diff --git a/src/locking/meson.build b/src/locking/meson.build index 72f7780438..57764b0da6 100644 --- a/src/locking/meson.build +++ b/src/locking/meson.build @@ -174,7 +174,7 @@ if conf.has('WITH_LIBVIRTD') qemu_lockd_conf = configure_file( input: 'lockd.conf', output: 'qemu-lockd.conf', - copy: true, + configuration: configmake_conf, ) virt_conf_files += qemu_lockd_conf virt_test_aug_files += { @@ -191,7 +191,7 @@ if conf.has('WITH_LIBVIRTD') libxl_lockd_conf = configure_file( input: 'lockd.conf', output: 'libxl-lockd.conf', - copy: true, + configuration: configmake_conf, ) virt_conf_files += libxl_lockd_conf endif @@ -203,7 +203,7 @@ if conf.has('WITH_LIBVIRTD') qemu_sanlock_conf = configure_file( input: 'sanlock.conf', output: 'qemu-sanlock.conf', - copy: true, + configuration: configmake_conf, ) virt_conf_files += qemu_sanlock_conf virt_test_aug_files += { @@ -220,7 +220,7 @@ if conf.has('WITH_LIBVIRTD') libxl_sanlock_conf = configure_file( input: 'sanlock.conf', output: 'libxl-sanlock.conf', - copy: true, + configuration: configmake_conf, ) virt_conf_files += libxl_sanlock_conf endif diff --git a/src/network/meson.build b/src/network/meson.build index d266bb225a..0888d1beac 100644 --- a/src/network/meson.build +++ b/src/network/meson.build @@ -84,7 +84,7 @@ if conf.has('WITH_NETWORK') configure_file( input: 'default.xml.in', output: '@BASENAME@', - copy: true, + configuration: configmake_conf, install: true, install_dir: confdir / 'qemu' / 'networks', ) -- 2.39.2

3 4

[libvirt PATCH v2 0/6] Fix compilation on msys2, update keycodemapdb
by marcandre.lureau＠redhat.com 21 Apr '23

21 Apr '23

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, libvirt fails to compile on msys2/win32. Also update keycodemapdb to fix CI build issues, and turn it into a subproject(), as that makes things simpler for meson. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/453 v2: - update based on Michal version - update keycodemapdb, make it a subproject() Marc-André Lureau (6): meson: don't look for unix paths on win32 keycodemapdb: update submodule for build fixes meson: don't hard code find_program() location meson: drop explicit python interpreter rpc/ssh: ssh_userauth_agent() is not supported on win32 Move src/keycodemapdb -> subprojects/keycodemapdb .gitmodules | 2 +- docs/manpages/meson.build | 4 ++-- docs/meson.build | 6 ++---- meson.build | 15 ++++++++++----- src/admin/meson.build | 4 ++-- src/esx/meson.build | 4 ++-- src/hyperv/meson.build | 2 +- src/keycodemapdb | 1 - src/meson.build | 8 ++++---- src/rpc/virnetlibsshsession.c | 10 +++++++++- src/util/meson.build | 8 ++++---- subprojects/keycodemapdb | 1 + 12 files changed, 38 insertions(+), 27 deletions(-) delete mode 160000 src/keycodemapdb create mode 160000 subprojects/keycodemapdb -- 2.40.0

3 10

[PATCH 0/3] qemu: migration: implement zstd compression
by Oleg Vasilev 20 Apr '23

20 Apr '23

QEMU now supports multifd-compression=zstd for migration with enabled multifd. Bring the support to libvirt as well. Claudio Fontana (1): qemu: migration: expose qemuMigrationParamsSetString Oleg Vasilev (2): qemu: migration: implement zstd compression tests: qemumigparams: test for zstd compression include/libvirt/libvirt-domain.h | 10 ++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 79 +++++++++++++++++--------- src/qemu/qemu_migration_params.h | 7 +++ tests/qemumigparamsdata/zstd.json | 4 ++ tests/qemumigparamsdata/zstd.reply | 7 +++ tests/qemumigparamsdata/zstd.xml | 6 ++ tests/qemumigparamstest.c | 90 +++++++++++++++++++++++++++--- tools/virsh-completer-domain.c | 2 +- tools/virsh-domain.c | 14 +++++ 10 files changed, 187 insertions(+), 33 deletions(-) create mode 100644 tests/qemumigparamsdata/zstd.json create mode 100644 tests/qemumigparamsdata/zstd.reply create mode 100644 tests/qemumigparamsdata/zstd.xml -- 2.40.0

2 4

[libvirt PATCH 0/4] Various cleanups
by Ján Tomko 20 Apr '23

20 Apr '23

Found by cppcheck. Ján Tomko (4): conf: domain: remove unreachable break qemu: command: join two adjacent conditions ch: pinVcpuLive: remove unused variable conf: storage: remove redundant condition src/ch/ch_driver.c | 5 ----- src/conf/domain_conf.c | 1 - src/conf/storage_conf.c | 22 +++++++++------------- src/qemu/qemu_command.c | 2 -- 4 files changed, 9 insertions(+), 21 deletions(-) -- 2.39.2

2 5

[PATCH 0/2] Small fixes for restrictive numatune mode
by Martin Kletzander 20 Apr '23

20 Apr '23

See individual commit messages for explanations (duh!) Martin Kletzander (2): qemu, ch: Move threads to cgroup dir before changing parameters docs: Clarify restrictive numatune mode docs/formatdomain.rst | 11 ++++++++++- src/ch/ch_process.c | 12 ++++++------ src/qemu/qemu_process.c | 10 +++++----- 3 files changed, 21 insertions(+), 12 deletions(-) -- 2.40.0

3 4

[PATCH 0/3] docs improvements
by Peter Krempa 20 Apr '23

20 Apr '23

Peter Krempa (3): kbase: debuglogs: Emphasize disabling daemon timeout in 'TL;DR' section docs: manpages: Clarify that only TLS/TCP remote access needs 'virtproxyd' docs: manpages: State that TCP connection is insecure in 'virtproxyd' man page docs/kbase/debuglogs.rst | 6 ++++-- docs/manpages/virtbhyved.rst | 4 ++-- docs/manpages/virtinterfaced.rst | 4 ++-- docs/manpages/virtlxcd.rst | 4 ++-- docs/manpages/virtnetworkd.rst | 4 ++-- docs/manpages/virtnodedevd.rst | 4 ++-- docs/manpages/virtnwfilterd.rst | 4 ++-- docs/manpages/virtproxyd.rst | 3 +++ docs/manpages/virtqemud.rst | 4 ++-- docs/manpages/virtsecretd.rst | 4 ++-- docs/manpages/virtstoraged.rst | 4 ++-- docs/manpages/virtvboxd.rst | 4 ++-- docs/manpages/virtvzd.rst | 4 ++-- docs/manpages/virtxend.rst | 4 ++-- 14 files changed, 31 insertions(+), 26 deletions(-) -- 2.39.2

2 4

[PATCH 0/7] Various watchdog fixes
by Martin Kletzander 20 Apr '23

20 Apr '23

Los blurbos aqui. Martin Kletzander (7): conf: Add missing empty lines before virDomainWatchdogDefParseXML qemu: Fix grammar and quoting in watchdog error message on hotplug qemu: Forbid device attach of existing platform watchdog qemu: Forbid ib700 watchdogs for non-i440fx machine types qemu: Check all watchdogs for iTCO duplicates qemu: Validate watchdog action compatibility per-device qemu: Forbid most duplicated watchdogs src/conf/domain_conf.c | 2 + src/qemu/qemu_driver.c | 13 +++++ src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_validate.c | 51 +++++++++++-------- tests/qemuhotplugtest.c | 3 ++ .../qemuhotplug-watchdog-reset.xml | 1 + ...plug-base-live+watchdog+watchdog-reset.xml | 1 + .../watchdog-q35-multiple.x86_64-latest.args | 4 +- .../watchdog-q35-multiple.xml | 2 +- .../watchdog-q35-multiple.x86_64-latest.xml | 4 +- 10 files changed, 58 insertions(+), 25 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-reset.xml create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog+watchdog-reset.xml -- 2.40.0

3 12

[libvirt PATCH] qemu: Allow sockets in long or deep paths.
by Nick Guenther 19 Apr '23

19 Apr '23

The qemu driver creates IPC sockets using absolute paths, but under POSIX socket paths are constrained pretty tightly. On systems with homedirs on an unusual mount point, like network homedirs, or just particularly long usernames, this could make starting VMs under qemu:///session impossible. Resolves https://gitlab.com/libvirt/libvirt/-/issues/466 Signed-off-by: Nick Guenther <nick.guenther(a)polymtl.ca> --- src/qemu/qemu_command.c | 52 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4ca93bf3dc..3f180d5fb6 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -53,6 +53,7 @@ #include "virmdev.h" #include "virutil.h" +#include <libgen.h> #include <sys/stat.h> #include <fcntl.h> @@ -4866,6 +4867,37 @@ qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) struct sockaddr_un addr; socklen_t addrlen = sizeof(addr); int fd; + char* wd = NULL; + char* socket_dir_c = NULL; + char* socket_name_c = NULL; + char* socket_dir = NULL; + char* socket_name = NULL; + + /* The path length is limited to what fits in sockaddr_un. + * It's pretty short: 108 on Linux, and this is too easy to hit. + * Work around this limit by using a *relative path*. + * + * background: https://stackoverflow.com/questions/34829600/why-is-the-maximal-path-length… + * + * docker added a different workaround: https://github.com/moby/moby/pull/13408 + */ + if ((wd = getcwd(NULL, 0)) == NULL) { + virReportSystemError(errno, "%s", + _("Unable to get working directory")); + goto error; + } + + socket_dir_c = strdup(dev->data.nix.path); // dirname edits the string given it, so it must be copied + socket_name_c = strdup(dev->data.nix.path); + + socket_dir = dirname(socket_dir_c); + socket_name = basename(socket_name_c); + + if (chdir(socket_dir) < 0) { + virReportSystemError(errno, "%s", + _("Unable to get change to socket directory")); + goto error; + } if ((fd = socket(AF_UNIX, SOCK_STREAM, 0)) < 0) { virReportSystemError(errno, "%s", @@ -4875,10 +4907,10 @@ qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) memset(&addr, 0, sizeof(addr)); addr.sun_family = AF_UNIX; - if (virStrcpyStatic(addr.sun_path, dev->data.nix.path) < 0) { + if (virStrcpyStatic(addr.sun_path, socket_name) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("UNIX socket path '%1$s' too long"), - dev->data.nix.path); + _("UNIX socket name '%1$s' too long"), + socket_name); goto error; } @@ -4909,9 +4941,23 @@ qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) if (virFileUpdatePerm(dev->data.nix.path, 0002, 0664) < 0) goto error; + /* restore working directory */ + if (chdir(wd) < 0) { + virReportSystemError(errno, "%s", + _("Unable to restore working directory")); + goto error; + } + + free(socket_name_c); + free(socket_dir_c); + free(wd); + return fd; error: + if (socket_name_c != NULL) { free(socket_name_c); } + if (socket_dir_c != NULL) { free(socket_dir_c); } + if (wd != NULL) { free(wd); } VIR_FORCE_CLOSE(fd); return -1; } -- 2.34.1

5 6

[PATCH 0/3] qemu: hotplug: Fix media change in a hotplugged cdrom
by Peter Krempa 19 Apr '23

19 Apr '23

We need to update private data to handle it properly. Peter Krempa (3): qemuProcessRefreshDisks: Properly compare tray status qemuProcessRefreshDisks: Extract update of a single disk qemu: hotplug: Update disk private data after hotplug src/qemu/qemu_hotplug.c | 21 ++++++++++++---- src/qemu/qemu_process.c | 55 ++++++++++++++++++++++++----------------- src/qemu/qemu_process.h | 3 +++ tests/qemuhotplugtest.c | 40 ++++++++++++++++++++---------- 4 files changed, 79 insertions(+), 40 deletions(-) -- 2.39.2

2 4

[PATCH 0/2] qemu_domain: Increase memlock limit for NVMe disks
by Michal Privoznik 19 Apr '23

19 Apr '23

*** BLURB HERE *** Michal Prívozník (2): qemu_domain: Increase memlock limit for NVMe disks qemumemlocktest: Introduce pc-hostdev-nvme test case src/qemu/qemu_domain.c | 35 +++++++++++++------ .../qemumemlock-pc-hostdev-nvme.xml | 24 +++++++++++++ tests/qemumemlocktest.c | 1 + 3 files changed, 50 insertions(+), 10 deletions(-) create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev-nvme.xml -- 2.39.2

2 4

[PATCH v3 00/25] Setup iothread polling attributes in the XML
by Peter Krempa 19 Apr '23

19 Apr '23

Previous version: https://listman.redhat.com/archives/libvir-list/2023-March/239164.html Changes: - patches 1 - 23 are new and do the following - refactors to typed param handling 1 - 15, 18 - addition of new typed param APIs needed for changing the type we use to store the poll parameters currently, 16, 17, 19 - conversion of the existing parameter handling for iothread poll attributes to unsigned long long 20 - 23 - patches 24 and 25 are patches 1 and 2 of the previous posting: - use unsigned long long to store the values and adjust the code Peter Krempa (25): virTypedParameterAssignValue: Drop 'copystr' parameter util: virtypedparam: Use proper enum type for all switch() statements virTypedParamsDeserialize: Remove unnecessary line breaks virTypedParameterAssignValueVArgs: Ensure proper typed param type in caller util: virtypedparam: Simplify error handling in virTypedParamListAdd* virtypedparam.h: Consistently use contemporary header style util: virtypedparam: Introduce virTypedParamListNew() util: typedparam: Introduce 'virTypedParamListConcat' qemuDomainGetStatsBlock: Don't directly access virTypedParamList util: virtypedparam: Introduce 'virTypedParamListFetch' Use 'virTypedParamListFetch' for extracting identity parameters list util: virtypedparam: Privatize definition of struct _virTypedParamList util: virtypedparam: Refactor return value of virTypedParamListStealParams util: virtypedparam: Store errors inside virTypedParamList util: virtypedparam: Remove return values from virTypedParamListAdd* APIs util: typedparam: Introduce virTypedParamListAddUnsigned util: virtypedparam: Introduce virTypedParamsGetUnsigned virTypedParamsValidate: Refactor variable declaration and cleanup virTypedParamsValidate: Allow typed params to be both _UINT and _ULLONG virsh: cmdIOThreadSet: Refactor to use virTypedParamList qemu: Remove iothread 'poll-' value validation qemu: Store all iothread's 'poll*' attributes as unsigned long long virsh: cmdIOThreadSet: Use bigger types for --poll-grow and --poll-shrink conf: Store the iothread 'poll' settings in the XML qemu: Use configured iothread poll parameters on startup docs/formatdomain.rst | 11 +- include/libvirt/libvirt-domain.h | 4 +- src/admin/admin_server.c | 118 ++--- src/conf/domain_conf.c | 41 +- src/conf/domain_conf.h | 7 + src/conf/schemas/domaincommon.rng | 19 + src/driver.c | 7 +- src/libvirt-domain.c | 14 +- src/libvirt_private.syms | 7 +- src/qemu/qemu_command.c | 18 + src/qemu/qemu_domainjob.c | 49 +-- src/qemu/qemu_driver.c | 409 ++++++------------ src/qemu/qemu_monitor.h | 4 +- src/qemu/qemu_monitor_json.c | 48 +- src/remote/remote_daemon_dispatch.c | 8 +- src/test/test_driver.c | 34 +- src/util/virtypedparam.c | 401 +++++++++++------ src/util/virtypedparam.h | 187 +++++--- ...othreads-ids-pool-sizes.x86_64-latest.args | 6 +- .../iothreads-ids-pool-sizes.xml | 12 +- tools/virsh-domain.c | 83 ++-- 21 files changed, 781 insertions(+), 706 deletions(-) -- 2.39.2

3 44

[PATCH 0/3] A couple of network related fixes
by Michal Privoznik 19 Apr '23

19 Apr '23

*** BLURB HERE *** Michal Prívozník (3): networkUpdateState: do not assume dnsmasq_caps conf: Initialize _virNetworkObj::dnsmasqPid to -1 in virNetworkObjNew() networkRefreshDhcpDaemon: Get dnsmasq's PID once src/conf/virnetworkobj.c | 1 + src/network/bridge_driver.c | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.39.2

3 5

Re: [libvirt] [RFC] support vhost-user-scsi configuration
by wangjian 18 Apr '23

18 Apr '23

On 2023/4/18 21:50, wangjian (AN) wrote: > > On 4/15/23 15:48, wangjian (AN) wrote: >> Hi Guys, >> >> >> >> Currently qemu and spdk already support vhost-user-scsi, but there is >> no vhost-user-scsi configuration in libvirt. >> >> We hope that libvirt supports the following configurations to >> facilitate docking with qemu. >> >> >> >> <controller type='scsi' index='0' model='vhost-user-scsi'> >> >> <driver queues='4'/> >> >> <source type='unix' path='/var/tmp/scsi'> >> >> <reconnect enabled='yes' timeout='3'/> >> >> </source> >> >> <address type='pci' domain='0x0000' bus='0x02' slot='0x02' >> function='0x0'/> >> >> </controller> >> >> >> >> The usage in qemu like this: >> >> -chardev socket,id=chr-vu-virtio-disk10,path=/var/tmp/scsi,reconnect=3 >> >> -device >> vhost-user-blk-pci,num-queues=4,bus=pci.2,addr=0x0,chardev=chr-vu-virt >> io-disk10,id=scsi0 >> >> >> >> Could anyone give some suggestions? >> > > That's very likely because nobody wrote patches for it. I do not think there was a discussion where we decided to deliberately not support it. > But I guess, what advantage there is in letting an external helper manage a <controller/> ? I though, vhost-user-* is ideal for individual devices rather than controllers. > > Meanwhile, for testing purposes (definitely NOT production), you can use qemu:command line passthrough: > > https://libvirt.org/kbase/qemu-passthrough-security.html > > Michal > In spdk, a vhost-user-blk controller will only be associated with one disk, and a vhost-user-blk controller will only be associated with one socket file. Therefore, for the vhost-user-blk disk, it is appropriate to use the vhost-user-blk disk associated socket file configuration in libvirt. But in spdk, a vhost-user-scsi controller will be associated with multiple disks, and a vhost-user-scsi controller will only be associated with one socket file. Therefore, we think that for vhost-user-scsi, it is appropriate to use the controller to associate the socket file configuration in libvirt.

1 0

[libvirt PATCH] conf: Restrict use of <portForward> to the passt backend
by Andrea Bolognani 18 Apr '23

18 Apr '23

That's already the case in practice, but it's a better experience for the user if we reject this configuration outright instead of silently ignoring part of it. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/conf/domain_validate.c | 9 +++++++++ ...t-user-slirp-portforward.x86_64-latest.err | 1 + .../net-user-slirp-portforward.xml | 20 +++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 31 insertions(+) create mode 100644 tests/qemuxml2argvdata/net-user-slirp-portforward.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/net-user-slirp-portforward.xml diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index ce6b8bf5a0..9c7ee6d75d 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2097,6 +2097,15 @@ virDomainNetDefValidate(const virDomainNetDef *net) } } + if (net->nPortForwards > 0 && + (net->type != VIR_DOMAIN_NET_TYPE_USER || + (net->type == VIR_DOMAIN_NET_TYPE_USER && + net->backend.type != VIR_DOMAIN_NET_BACKEND_PASST))) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("The <portForward> element can only be used with <interface type='user'> and its 'passt' backend")); + return -1; + } + switch (net->type) { case VIR_DOMAIN_NET_TYPE_VHOSTUSER: if (!virDomainNetIsVirtioModel(net)) { diff --git a/tests/qemuxml2argvdata/net-user-slirp-portforward.x86_64-latest.err b/tests/qemuxml2argvdata/net-user-slirp-portforward.x86_64-latest.err new file mode 100644 index 0000000000..f296db1e8c --- /dev/null +++ b/tests/qemuxml2argvdata/net-user-slirp-portforward.x86_64-latest.err @@ -0,0 +1 @@ +internal error: The <portForward> element can only be used with <interface type='user'> and its 'passt' backend diff --git a/tests/qemuxml2argvdata/net-user-slirp-portforward.xml b/tests/qemuxml2argvdata/net-user-slirp-portforward.xml new file mode 100644 index 0000000000..721f04c878 --- /dev/null +++ b/tests/qemuxml2argvdata/net-user-slirp-portforward.xml @@ -0,0 +1,20 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <interface type='user'> + <mac address='00:11:22:33:44:55'/> + <portForward proto='tcp'> + <range start='443' to='344'/> + </portForward> + <model type='virtio'/> + </interface> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 1808d9fc02..23e0c4054c 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1413,6 +1413,7 @@ mymain(void) DO_TEST_NOCAPS("net-user-addr"); DO_TEST_CAPS_LATEST("net-user-passt"); DO_TEST_CAPS_VER("net-user-passt", "7.2.0"); + DO_TEST_CAPS_LATEST_PARSE_ERROR("net-user-slirp-portforward"); DO_TEST_NOCAPS("net-virtio"); DO_TEST_NOCAPS("net-virtio-device"); DO_TEST_NOCAPS("net-virtio-disable-offloads"); -- 2.39.2

3 5

[PATCH 0/5] qemu: Fix chardev hotplug and deny <console/> live detach
by Michal Privoznik 18 Apr '23

18 Apr '23

While trying to make live detach of <console/> work, I've accumulated couple of patches. The most reasonable ones made it into this patch set as paches 1-4. And after nearly losing my sanity, I've decided it's not worth supporting live detach of <console/> since <serial/> works just fine. And that's what patch 5 does. If somebody thinks it's too harsh, I'm more than happy to review their patches that fix the problem. What problem? Well, for starters: https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c4 https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c8 Michal Prívozník (5): qemuDomainChrInsertPreAlloced: Fix adding implicit console qemuDomainChrRemove: Don't leak vmdef->consoles[0] qemuAssignDeviceChrAlias: Fix a crasher during <console/> hotplug qemuDomainRemoveChrDevice: Deal with qemuDomainChrRemove() failure qemu_hotplug: Deny live detach of <console/> src/qemu/qemu_alias.c | 1 + src/qemu/qemu_hotplug.c | 43 +++++++++++++++++++++++++++++------------ 2 files changed, 32 insertions(+), 12 deletions(-) -- 2.39.2

2 7

[PATCH] tests: viracpitest only works on little endian
by Boris Fiuczynski 18 Apr '23

18 Apr '23

Commit fc216db4fb789cbd309 introduced a mocked test with binary test data which fails on big endian machines. Therefore build the viracpitest test only on little endian machines. Fixes: fc216db4fb789cbd30917be036d0b94d965bdf7f Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- tests/meson.build | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 35adbc2d56..0082446029 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -269,7 +269,6 @@ tests += [ { 'name': 'storagevolxml2xmltest' }, { 'name': 'sysinfotest' }, { 'name': 'utiltest' }, - { 'name': 'viracpitest' }, { 'name': 'viralloctest' }, { 'name': 'virauthconfigtest' }, { 'name': 'virbitmaptest' }, @@ -308,6 +307,12 @@ tests += [ { 'name': 'virmigtest' }, ] +if host_machine.endian() == 'little' + tests += [ + { 'name': 'viracpitest' }, + ] +endif + if host_machine.system() == 'linux' tests += [ { 'name': 'fchosttest' }, -- 2.39.0

3 2

[PATCH V2 0/3] Change default machine type for ARM and RISC-V
by Jim Fehlig 18 Apr '23

18 Apr '23

It is difficult, if not impossible, to create usable ARM and RISC-V VMs using the current default machine types of 'integratorcp' and 'spike_v1.10'. Change the default to the more suitable 'virt' type. See the following thread for more details https://listman.redhat.com/archives/libvir-list/2023-March/238746.html V1: https://listman.redhat.com/archives/libvir-list/2023-April/239392.html Changes in V2: Change the default for more ARM and RISC-V architectures Reword NEWS entry Jim Fehlig (3): qemu: Change default machine type for ARM qemu: Change default machine type for RISC-V NEWS: Mention change of default machine type for ARM and RISC-V NEWS.rst | 6 ++++++ src/qemu/qemu_capabilities.c | 10 +++++----- tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 14 ++++++++++---- .../domaincapsdata/qemu_7.0.0-hvf.aarch64+hvf.xml | 6 ++++-- tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 14 ++++++++++---- tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 4 ++-- tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 8 ++++---- .../caps_7.0.0_aarch64+hvf.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 4 ++-- 19 files changed, 105 insertions(+), 61 deletions(-) -- 2.40.0

2 5

[PATCH 0/3] Change default machine type for aarch64 and riscv64
by Jim Fehlig 18 Apr '23

18 Apr '23

This series is a first attempt at changing the default machine type for aarch64 and riscv64. It is difficult, if not impossible, to create a working VM with the current defaults of 'integratorcp' and 'spike_v1.10', so let's change the default to type 'virt'. See the following thread for more details https://listman.redhat.com/archives/libvir-list/2023-March/238746.html On aarch64, the default CPU for machine type 'virt' is 'cortex-a15', which works fine for <domain type='qemu'>, but fails for type='kvm' 2023-04-14T21:03:03.392256Z qemu-system-aarch64: KVM is not supported for this guest CPU type Do we need to go a step further and define a default CPU (presumably host-passthrough) for machine type 'virt' for kvm domains on aarch64? TIA for comments and suggestions! Regards, Jim Jim Fehlig (3): qemu: Change default machine type for aarch64 qemu: Change default machine type for riscv64 NEWS: Mention change of default machine type for aarch64 and riscv64 NEWS.rst | 6 ++++++ src/qemu/qemu_capabilities.c | 4 ++-- tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 14 ++++++++++---- tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 14 ++++++++++---- .../domaincapsdata/qemu_7.0.0-hvf.aarch64+hvf.xml | 6 ++++-- tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 14 ++++++++++---- tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 4 ++-- tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 8 ++++---- .../caps_7.0.0_aarch64+hvf.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 8 ++++---- tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 4 ++-- 19 files changed, 102 insertions(+), 58 deletions(-) -- 2.40.0

2 8

[PATCH] kbase: debuglogs: Add a 'TL; DR' section for enabling logging in most common case
by Peter Krempa 17 Apr '23

17 Apr '23

The document grew a bit too much explaining all the mistakes we've seen the users do when configuring logging. Add a section distilling the configuration of the most basic scenario which we can refer to when upstream issues are reported. The scenario is for a runtime setting of logging into a file applied to the 'virtqemud' daemon. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/kbase/debuglogs.rst | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst index 53d70ee748..811ccf0102 100644 --- a/docs/kbase/debuglogs.rst +++ b/docs/kbase/debuglogs.rst @@ -16,6 +16,22 @@ server side that matters as nearly all interesting work takes place there. Moreover, libvirt catches stderr of all running domains. These can be useful as well. +TL;DR - Enable debug logs for most common scenario +=================================================== + +This applies to the most common scenario of ``system`` instance of +``virtqemud``. Log setting is not persisted, so a restart of ``virtqemud`` or +the system clears this setting:: + + # virt-admin -c virtqemud:///system daemon-log-outputs "3:journald 1:file:/var/log/libvirt/libvirtd.log" + # virt-admin -c virtqemud:///system daemon-log-filters "3:remote 4:event 3:util.json 3:util.object 3:util.dbus 3:util.netlink 3:node_device 3:rpc 3:access 1:*" + + # # optionally disable timeout of the daemon + # virt-admin -c virtqemud:///system daemon-timeout 0 + +For any other configuration please read the rest of the document. If you want +to persist the log level and log outputs settings edit +``/etc/libvirt/virtqemud.conf`` and look for ``log-filters`` and ``log-outputs`` Logging settings in libvirt =========================== -- 2.39.2

3 3

[PATCH 0/2] virsh: Introduce --xpath and --wrap to (dom)capabilities
by Michal Privoznik 17 Apr '23

17 Apr '23

*** BLURB HERE *** Michal Prívozník (2): virsh: Introduce --xpath and --wrap to capabilities virsh: Introduce --xpath and --wrap to domcapabilities docs/manpages/virsh.rst | 17 ++++++++++++++- tools/virsh-host.c | 46 ++++++++++++++++++++++++++++++++++------- 2 files changed, 54 insertions(+), 9 deletions(-) -- 2.39.2

2 3

[PATCH 0/3] Setup iothread polling attributes in the XML
by Peter Krempa 17 Apr '23

17 Apr '23

Peter Krempa (3): conf: Store the iothread 'poll' settings in the XML qemu: Use configured iothread poll parameters on startup docs: formatdomain: Properly indent example XML for setting 'metadata_cache' docs/formatdomain.rst | 53 +++++++++++-------- src/conf/domain_conf.c | 41 +++++++++++++- src/conf/domain_conf.h | 7 +++ src/conf/schemas/domaincommon.rng | 19 +++++++ src/qemu/qemu_command.c | 18 +++++++ src/qemu/qemu_driver.c | 30 ++++++----- ...othreads-ids-pool-sizes.x86_64-latest.args | 6 +-- .../iothreads-ids-pool-sizes.xml | 12 +++-- 8 files changed, 142 insertions(+), 44 deletions(-) -- 2.39.2

2 9

Plans for the next release
by Jiri Denemark 17 Apr '23

17 Apr '23

We are getting close to the next release of libvirt. To aim for the release on May 02 I suggest entering the freeze on Tuesday Apr 25 and tagging RC2 on Thursday Apr 27. I hope this works for everyone. Jirka

1 0

[libvirt PATCH] network: do not assume dnsmasq in networkUpdateState
by Ján Tomko 17 Apr '23

17 Apr '23

If we don't have dnsmasq, it's pointless to try to find its pidfile. Also, dnsmasqCapsGetBinaryPath would access a NULL pointer. Fixes: 4b68c982e283471575bacbf87302495864da46fe Foxes: https://gitlab.com/libvirt/libvirt/-/issues/456 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 3fa56bfc09..ee4bbd4a93 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -492,7 +492,7 @@ networkUpdateState(virNetworkObj *obj, virNetworkObjPortForEach(obj, networkUpdatePort, obj); /* Try and read dnsmasq pids of active networks */ - if (virNetworkObjIsActive(obj) && def->ips && (def->nips > 0)) { + if (dnsmasq_caps && virNetworkObjIsActive(obj) && def->ips && (def->nips > 0)) { pid_t dnsmasqPid; if (networkSetMacMap(cfg, obj) < 0) -- 2.39.2

3 5

[libvirt] [RFC] support vhost-user-scsi configuration
by wangjian (AN) 17 Apr '23

17 Apr '23

Hi Guys, Currently qemu and spdk already support vhost-user-scsi, but there is no vhost-user-scsi configuration in libvirt. We hope that libvirt supports the following configurations to facilitate docking with qemu. <controller type='scsi' index='0' model='vhost-user-scsi'> <driver queues='4'/> <source type='unix' path='/var/tmp/scsi'> <reconnect enabled='yes' timeout='3'/> </source> <address type='pci' domain='0x0000' bus='0x02' slot='0x02' function='0x0'/> </controller> The usage in qemu like this: -chardev socket,id=chr-vu-virtio-disk10,path=/var/tmp/scsi,reconnect=3 -device vhost-user-blk-pci,num-queues=4,bus=pci.2,addr=0x0,chardev=chr-vu-virtio-disk10,id=scsi0 Could anyone give some suggestions?

2 1

[PATCH v2] qemu: Fix domxml-to-native command failure
by Zhenzhong Duan 17 Apr '23

17 Apr '23

virsh command domxml-to-native failed with below error but start command succeed for same domain xml. "internal error: invalid PCI passthrough type 'default'" If host PCI device's driver attribute isn't defined in domain xml, qemu driver will choose a proper value based on host environment before starting qemu process. But this is missed in domxml-to-native command, add the same logic so domxml-to-native could pass and replace the relevant code in qemuHostdevPreparePCIDevicesCheckSupport() with an error report. Signed-off-by: Zhenzhong Duan <zhenzhong.duan(a)intel.com> --- v2: replace setting with an error report, suggested by Michal src/qemu/qemu_domain.c | 11 +++++++++++ src/qemu/qemu_hostdev.c | 8 ++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 63b13b6875c9..517c90f93f0a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11274,6 +11274,17 @@ qemuDomainPrepareHostdev(virDomainHostdevDef *hostdev, } } } + if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && + hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); + virDomainHostdevSubsysPCIBackendType *backend = &hostdev->source.subsys.u.pci.backend; + + if (*backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT && + supportsPassthroughVFIO && + virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) { + *backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO; + } + } return 0; } diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 45cd1066f0a5..305a323a0769 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -175,15 +175,15 @@ qemuHostdevPreparePCIDevicesCheckSupport(virDomainHostdevDef **hostdevs, case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT: if (supportsPassthroughVFIO && virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) { - *backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO; + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("qemuDomainPrepareHostdev() should have set backend " + "to VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO")); } else { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("host doesn't support passthrough of " "host PCI devices")); - return false; } - - break; + return false; case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO: if (!supportsPassthroughVFIO) { -- 2.25.1

3 2

Improve default machine type selection
by Jim Fehlig 14 Apr '23

14 Apr '23

If an explicit machine type is not specified in the VM config, the qemu driver will select the first machine type in the list of machine types for the specified accelerator. See virQEMUCapsGetPreferredMachine https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_capabilities… On my test machines, this works reasonably well for x86_64 where the first machine type is pc-i440fx-7.1. But for aarch64, the first machine is integratorcp, which is not very useful with maxCpus=1 and other limitations. Would it be possible to select a "better" default machine type? E.g. 'pc' for x86_64, 'virt' for aarch64, etc. I'm happy to work on this if folks deem it's a reasonable improvement. It would benefit tools like the libvirt terraform provider, which prefer to use something more generic like <type>hvm</type>. Regards, Jim

4 18

[PATCH] qemu: Fix incorrect command name in error messages
by Andrea Bolognani 14 Apr '23

14 Apr '23

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_monitor_json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3b42b28fa1..b2c0b20a11 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4813,7 +4813,7 @@ int qemuMonitorJSONGetMachines(qemuMonitor *mon, if (virJSONValueObjectHasKey(child, "numa-mem-supported")) { if (virJSONValueObjectGetBoolean(child, "numa-mem-supported", &info->numaMemSupported) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("qemu-machines reply has malformed " + _("query-machines reply has malformed " "'numa-mem-supported' data")); goto cleanup; } @@ -4841,7 +4841,7 @@ int qemuMonitorJSONGetMachines(qemuMonitor *mon, if (virJSONValueObjectGetBoolean(child, "acpi", &acpi) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("qemu-machines reply has malformed 'acpi data")); + _("query-machines reply has malformed 'acpi data")); goto cleanup; } -- 2.39.2

1 0

[PATCH v2 00/10] Deprecate/rename singlestep command line option, monitor interfaces
by Peter Maydell 14 Apr '23

14 Apr '23

The command line option '-singlestep' and its HMP equivalent the 'singlestep' command are very confusingly named, because they have nothing to do with single-stepping the guest (either via the gdb stub or by emulation of guest CPU architectural debug facilities). What they actually do is put TCG into a mode where it puts only one guest instruction into each translation block. This is useful for some circumstances such as when you want the -d debug logging to be easier to interpret, or if you have a finicky guest binary that wants to see interrupts delivered at something other than the end of a basic block. The confusing name is made worse by the fact that our documentation for these is so minimal as to be useless for telling users what they really do. This series: * changes the command line interface: for user-mode emulators, the new option is '-one-insn-per-tb', and for system mode emulators it is a TCG accel property '-accel tcg,one-insn-per-tb=on' * updates all the places which currently directly touch the 'singlestep' global variable to instead get the current accelerator and query/set the QOM property * documents that the old -singlestep option is deprecated * adds a new HMP command 'one-insn-per-tb', and deprecates the old 'singlestep' command. (Strictly we don't need to deprecate HMP commands, but I'd already written the code for v1 of this series and it's a minor user convenience.) * makes the HMP 'info status' output report "one insn per TB" instead of "single step mode" * adds a new 'one-insn-per-tb' member to the QMP StatusInfo type, and deprecates the old 'singlestep' field Notes: * I hope I have got the QMP changes and deprecation right, but that's probably the bit in most need of review from an expert * There's an argument for just dropping the reporting of one-insn-per-tb in QMP StatusInfo at all, except that (a) it's hard to know if anybody's really using it (b) then the info isn't reported to HMP 'info status', which wouldn't line up with HMP having a mechanism to get/set the value * I have written patch 3 on the assumption that curr_cflags() is not such a hot codepath that we can't afford to have a QOM cast macro in it; the alternative would be to keep it using a global variable but make the global be restricted to accel/tcg/internals.h. RTH: opinions welcome... * Still haven't tested on bsd-user, but the patch is identical to the linux-user change thanks -- PMM Peter Maydell (10): make one-insn-per-tb an accel option softmmu: Don't use 'singlestep' global in QMP and HMP commands tcg: Use one-insn-per-tb accelerator property in curr_cflags() linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' bsd-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' Document that -singlestep command line option is deprecated hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep' hmp: Report 'one-insn-per-tb', not 'single step mode', in 'info status' output qapi/run-state.json: Fix missing newline at end of file hmp: Deprecate 'singlestep' member of StatusInfo docs/about/deprecated.rst | 35 +++++++++++++++++++++++++++++++++++ docs/interop/qmp-intro.txt | 1 + docs/user/main.rst | 14 ++++++++++++-- qapi/run-state.json | 19 +++++++++++++++---- accel/tcg/internal.h | 16 ++++++++++++++++ include/exec/cpu-common.h | 3 --- include/monitor/hmp.h | 2 +- accel/tcg/cpu-exec.c | 5 +++-- accel/tcg/tcg-all.c | 32 ++++++++++++++++++-------------- bsd-user/main.c | 14 +++++++++----- linux-user/main.c | 18 ++++++++++++------ softmmu/globals.c | 1 - softmmu/runstate-hmp-cmds.c | 22 ++++++++++++++++++---- softmmu/runstate.c | 12 +++++++++++- softmmu/vl.c | 17 +++++++++++++++-- tests/qtest/test-hmp.c | 1 + hmp-commands.hx | 25 +++++++++++++++++++++---- qemu-options.hx | 12 ++++++++++-- tcg/tci/README | 2 +- 19 files changed, 199 insertions(+), 52 deletions(-) -- 2.34.1

6 34

[PATCH] security: do not remember/recall labels for VFIO MDEVs
by Eric Farman 13 Apr '23

13 Apr '23

Commit dbf1f68410 ("security: do not remember/recall labels for VFIO") rightly changed the DAC and SELinux labeling parameters to fix a problem with "VFIO hostdevs" but really only addressed the PCI codepaths. As a result, we can still encounter this with VFIO MDEVs such as vfio-ccw and vfio-ap, which can fail on a hotplug: [test@host ~]# mdevctl stop -u 11f2d2bc-4083-431d-a023-eff72715c4f0 [test@host ~]# mdevctl start -u 11f2d2bc-4083-431d-a023-eff72715c4f0 [test@host ~]# cat disk.xml <hostdev mode='subsystem' type='mdev' model='vfio-ccw'> <source> <address uuid='11f2d2bc-4083-431d-a023-eff72715c4f0'/> </source> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x3c51'/> </hostdev> [test@host ~]# virsh attach-device guest ~/disk.xml error: Failed to attach device from /home/test/disk.xml error: Requested operation is not valid: Setting different SELinux label on /dev/vfio/3 which is already in use Make the same changes as reported in commit dbf1f68410, for the mdev paths. Reported-by: Matthew Rosato <mjrosato(a)linux.ibm.com> Signed-off-by: Eric Farman <farman(a)linux.ibm.com> --- src/security/security_dac.c | 4 ++-- src/security/security_selinux.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 9be8f458d1..bceb6a5c24 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1310,7 +1310,7 @@ virSecurityDACSetHostdevLabel(virSecurityManager *mgr, if (!(vfiodev = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return -1; - ret = virSecurityDACSetHostdevLabelHelper(vfiodev, true, &cbdata); + ret = virSecurityDACSetHostdevLabelHelper(vfiodev, false, &cbdata); break; } @@ -1466,7 +1466,7 @@ virSecurityDACRestoreHostdevLabel(virSecurityManager *mgr, if (!(vfiodev = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return -1; - ret = virSecurityDACRestoreFileLabel(mgr, vfiodev); + ret = virSecurityDACRestoreFileLabelInternal(mgr, NULL, vfiodev, false); break; } diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index e43962435f..9c23735aa3 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -2217,7 +2217,7 @@ virSecuritySELinuxSetHostdevSubsysLabel(virSecurityManager *mgr, if (!(vfiodev = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return ret; - ret = virSecuritySELinuxSetHostdevLabelHelper(vfiodev, true, &data); + ret = virSecuritySELinuxSetHostdevLabelHelper(vfiodev, false, &data); break; } @@ -2445,7 +2445,7 @@ virSecuritySELinuxRestoreHostdevSubsysLabel(virSecurityManager *mgr, if (!(vfiodev = virMediatedDeviceGetIOMMUGroupDev(mdevsrc->uuidstr))) return -1; - ret = virSecuritySELinuxRestoreFileLabel(mgr, vfiodev, true); + ret = virSecuritySELinuxRestoreFileLabel(mgr, vfiodev, false); break; } -- 2.37.2

2 3

[RFC PATCH 0/8] Translatable string handling improvements
by Peter Krempa 13 Apr '23

13 Apr '23

Many things in libvirt attempt to construct error messages from various sub-strings which is not translation friednly. The beginning of the series refactors the cgroup code to avoid this practice. The end of this series is an example how the worst offender, virsh event handling code, can be improved to avoid the bad practice. I've found most cases using: git grep ' _([^"]' Unfortunateluy the better practice is a bit more verbose, thus RFC. Peter Krempa (8): virCgroupV1GetBlkioIo(Device)Serviced: Refactor extraction of cgroup data Don't translate strings used with VIR_DEBUG virshGraphicsAddressToString: Remove pointless translation vshPrint: Add version using 'va_list' virsh: event: Introduce virshEventPrintf virsh-domain-event: Make 'virshEventTrayChangePrint' translation friendly virsh-domain-event: Make 'virshEventWatchdogPrint' translation friendly virsh-domain-event: Make 'virshEventIOError(Reason)Print' translation friendly src/util/vircgroupv1.c | 264 ++++++++++++++++--------------------- src/util/virnetlink.c | 6 +- src/vz/vz_driver.c | 4 +- tools/virsh-domain-event.c | 223 +++++++++++++++++-------------- tools/vsh.c | 32 +++-- tools/vsh.h | 4 + 6 files changed, 274 insertions(+), 259 deletions(-) -- 2.39.2

3 12

[PATCH] qemu: Fix domxml-to-native command failure
by Zhenzhong Duan 13 Apr '23

13 Apr '23

virsh command domxml-to-native failed with below error but start command suceed for same domain xml. "internal error: invalid PCI passthrough type 'default'" If host pci device's driver attribute isn't defined in domain xml, qemu driver will choose a proper value based on host environment before starting qemu process. But this is missed in domxml-to-native command, add the same logic so domxml-to-native could pass. Signed-off-by: Zhenzhong Duan <zhenzhong.duan(a)intel.com> --- src/qemu/qemu_domain.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 63b13b6875c9..517c90f93f0a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11274,6 +11274,17 @@ qemuDomainPrepareHostdev(virDomainHostdevDef *hostdev, } } } + if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && + hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); + virDomainHostdevSubsysPCIBackendType *backend = &hostdev->source.subsys.u.pci.backend; + + if (*backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT && + supportsPassthroughVFIO && + virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) { + *backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO; + } + } return 0; } -- 2.25.1

3 2

[PATCH] conf: Introduce igb model for <interface>
by Akihiko Odaki 13 Apr '23

13 Apr '23

igb is a new network device which will be introduced with QEMU 8.0.0. It is a successor of e1000e so it has PCIe interface and is understands virtio-net headers as e1000e does. Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com> --- src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_domain_address.c | 3 ++- src/qemu/qemu_interface.c | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d16a247a45..25401f742f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -587,6 +587,7 @@ VIR_ENUM_IMPL(virDomainNetModel, "virtio", "e1000", "e1000e", + "igb", "virtio-transitional", "virtio-non-transitional", "usb-net", diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 9e281692ff..44b070ba0c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -954,6 +954,7 @@ typedef enum { VIR_DOMAIN_NET_MODEL_VIRTIO, VIR_DOMAIN_NET_MODEL_E1000, VIR_DOMAIN_NET_MODEL_E1000E, + VIR_DOMAIN_NET_MODEL_IGB, VIR_DOMAIN_NET_MODEL_VIRTIO_TRANSITIONAL, VIR_DOMAIN_NET_MODEL_VIRTIO_NON_TRANSITIONAL, VIR_DOMAIN_NET_MODEL_USB_NET, diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index b8d1969fbe..9f13f5f195 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -750,7 +750,8 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev, if (net->model == VIR_DOMAIN_NET_MODEL_VIRTIO_TRANSITIONAL) return pciFlags; - if (net->model == VIR_DOMAIN_NET_MODEL_E1000E) + if (net->model == VIR_DOMAIN_NET_MODEL_E1000E || + net->model == VIR_DOMAIN_NET_MODEL_IGB) return pcieFlags; /* the only time model can be "unknown" is for type='hostdev' diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index 264d5e060c..2aa4d53215 100644 --- a/src/qemu/qemu_interface.c +++ b/src/qemu/qemu_interface.c @@ -241,6 +241,7 @@ qemuInterfaceIsVnetCompatModel(const virDomainNetDef *net) { return (virDomainNetIsVirtioModel(net) || net->model == VIR_DOMAIN_NET_MODEL_E1000E || + net->model == VIR_DOMAIN_NET_MODEL_IGB || net->model == VIR_DOMAIN_NET_MODEL_VMXNET3); } -- 2.40.0

3 5

[PATCH] qemucapabilitiestest: Update x86_64 capabilities for qemu-8.0.0-rc3
by Peter Krempa 13 Apr '23

13 Apr '23

Notable changes: - 'query-cryptodev' command added - 'cxl-inject-uncorrectable-errors', 'cxl-inject-correctable-error' commands added - 'query-stats' returns data for 'cryptodev' - keyboard definions were updated - 'igb' device added Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_8.0.0_x86_64.replies | 3245 +++++++++-------- .../caps_8.0.0_x86_64.xml | 8 +- 2 files changed, 1821 insertions(+), 1432 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.replies b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.replies index dbb61b2533..41fc9fc6b3 100644 --- a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, + "micro": 93, "minor": 2, "major": 7 }, - "package": "v7.2.0-2146-g2946e1af27" + "package": "v8.0.0-rc3-28-g9d177b7f87" }, "id": "libvirt-2" } @@ -1538,41 +1538,41 @@ "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "229" + "arg-type": "230" }, { "name": "add-fd", - "ret-type": "231", + "ret-type": "232", "meta-type": "command", - "arg-type": "230" + "arg-type": "231" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "232" + "arg-type": "233" }, { "name": "query-fdsets", - "ret-type": "[233]", + "ret-type": "[234]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[235]", + "ret-type": "[236]", "meta-type": "command", - "arg-type": "234" + "arg-type": "235" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "236" + "arg-type": "237" }, { "name": "VFU_CLIENT_HANGUP", "meta-type": "event", - "arg-type": "237" + "arg-type": "238" }, { "name": "rtc-reset-reinjection", @@ -1582,19 +1582,19 @@ }, { "name": "query-sev", - "ret-type": "238", + "ret-type": "239", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "239", + "ret-type": "240", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "240", + "ret-type": "241", "meta-type": "command", "arg-type": "0" }, @@ -1602,29 +1602,29 @@ "name": "sev-inject-launch-secret", "ret-type": "0", "meta-type": "command", - "arg-type": "241" + "arg-type": "242" }, { "name": "query-sev-attestation-report", - "ret-type": "243", + "ret-type": "244", "meta-type": "command", - "arg-type": "242" + "arg-type": "243" }, { "name": "query-sgx", - "ret-type": "246", + "ret-type": "247", "meta-type": "command", "arg-type": "0" }, { "name": "query-sgx-capabilities", - "ret-type": "246", + "ret-type": "247", "meta-type": "command", "arg-type": "0" }, { "name": "xen-event-list", - "ret-type": "[247]", + "ret-type": "[248]", "meta-type": "command", "arg-type": "0" }, @@ -1632,46 +1632,46 @@ "name": "xen-event-inject", "ret-type": "0", "meta-type": "command", - "arg-type": "248" + "arg-type": "249" }, { "name": "query-audiodevs", - "ret-type": "[249]", + "ret-type": "[250]", "meta-type": "command", "arg-type": "0" }, { "name": "query-acpi-ospm-status", - "ret-type": "[250]", + "ret-type": "[251]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "251" + "arg-type": "252" }, { "name": "query-pci", - "ret-type": "[252]", + "ret-type": "[253]", "meta-type": "command", "arg-type": "0" }, { "name": "query-stats", - "ret-type": "[254]", + "ret-type": "[255]", "meta-type": "command", - "arg-type": "253" + "arg-type": "254" }, { "name": "query-stats-schemas", - "ret-type": "[256]", + "ret-type": "[257]", "meta-type": "command", - "arg-type": "255" + "arg-type": "256" }, { "name": "x-query-virtio", - "ret-type": "[257]", + "ret-type": "[258]", "meta-type": "command", "arg-type": "0", "features": [ @@ -1680,40 +1680,58 @@ }, { "name": "x-query-virtio-status", - "ret-type": "259", + "ret-type": "260", "meta-type": "command", - "arg-type": "258", + "arg-type": "259", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-status", - "ret-type": "261", + "ret-type": "262", "meta-type": "command", - "arg-type": "260", + "arg-type": "261", "features": [ "unstable" ] }, { "name": "x-query-virtio-vhost-queue-status", - "ret-type": "263", + "ret-type": "264", "meta-type": "command", - "arg-type": "262", + "arg-type": "263", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-element", - "ret-type": "265", + "ret-type": "266", "meta-type": "command", - "arg-type": "264", + "arg-type": "265", "features": [ "unstable" ] }, + { + "name": "query-cryptodev", + "ret-type": "[267]", + "meta-type": "command", + "arg-type": "0" + }, + { + "name": "cxl-inject-uncorrectable-errors", + "ret-type": "0", + "meta-type": "command", + "arg-type": "268" + }, + { + "name": "cxl-inject-correctable-error", + "ret-type": "0", + "meta-type": "command", + "arg-type": "269" + }, { "name": "0", "members": [ @@ -1733,7 +1751,7 @@ }, { "name": "status", - "type": "266" + "type": "270" } ], "meta-type": "object" @@ -1747,7 +1765,7 @@ }, { "name": "reason", - "type": "267" + "type": "271" } ], "meta-type": "object" @@ -1761,7 +1779,7 @@ }, { "name": "reason", - "type": "267" + "type": "271" } ], "meta-type": "object" @@ -1771,7 +1789,7 @@ "members": [ { "name": "action", - "type": "268" + "type": "272" } ], "meta-type": "object" @@ -1781,7 +1799,7 @@ "members": [ { "name": "action", - "type": "268" + "type": "272" } ], "meta-type": "object" @@ -1792,22 +1810,22 @@ { "name": "reboot", "default": null, - "type": "269" + "type": "273" }, { "name": "shutdown", "default": null, - "type": "270" + "type": "274" }, { "name": "panic", "default": null, - "type": "271" + "type": "275" }, { "name": "watchdog", "default": null, - "type": "268" + "type": "272" } ], "meta-type": "object" @@ -1817,12 +1835,12 @@ "members": [ { "name": "action", - "type": "272" + "type": "276" }, { "name": "info", "default": null, - "type": "273" + "type": "277" } ], "meta-type": "object" @@ -1832,12 +1850,12 @@ "members": [ { "name": "action", - "type": "272" + "type": "276" }, { "name": "info", "default": null, - "type": "273" + "type": "277" } ], "meta-type": "object" @@ -1847,15 +1865,15 @@ "members": [ { "name": "recipient", - "type": "274" + "type": "278" }, { "name": "action", - "type": "275" + "type": "279" }, { "name": "flags", - "type": "276" + "type": "280" } ], "meta-type": "object" @@ -2003,7 +2021,7 @@ { "name": "read-only-mode", "default": null, - "type": "277" + "type": "281" } ], "meta-type": "object" @@ -2225,7 +2243,7 @@ { "name": "io-status", "default": null, - "type": "278" + "type": "282" } ], "meta-type": "object" @@ -2266,12 +2284,12 @@ }, { "name": "stats", - "type": "279" + "type": "283" }, { "name": "driver-specific", "default": null, - "type": "280" + "type": "284" }, { "name": "parent", @@ -2324,7 +2342,7 @@ }, { "name": "io-status", - "type": "278" + "type": "282" }, { "name": "ready", @@ -2332,7 +2350,7 @@ }, { "name": "status", - "type": "281" + "type": "285" }, { "name": "auto-finalize", @@ -2400,7 +2418,7 @@ { "name": "mode", "default": null, - "type": "282" + "type": "286" } ], "meta-type": "object" @@ -2488,7 +2506,7 @@ { "name": "on-error", "default": null, - "type": "283" + "type": "287" }, { "name": "filter-node-name", @@ -2522,7 +2540,7 @@ }, { "name": "sync", - "type": "284" + "type": "288" }, { "name": "speed", @@ -2537,7 +2555,7 @@ { "name": "bitmap-mode", "default": null, - "type": "285" + "type": "289" }, { "name": "compress", @@ -2547,12 +2565,12 @@ { "name": "on-source-error", "default": null, - "type": "283" + "type": "287" }, { "name": "on-target-error", "default": null, - "type": "283" + "type": "287" }, { "name": "auto-finalize", @@ -2572,7 +2590,7 @@ { "name": "x-perf", "default": null, - "type": "286", + "type": "290", "features": [ "unstable" ] @@ -2589,7 +2607,7 @@ { "name": "mode", "default": null, - "type": "282" + "type": "286" } ], "meta-type": "object" @@ -2608,7 +2626,7 @@ }, { "name": "sync", - "type": "284" + "type": "288" }, { "name": "speed", @@ -2623,7 +2641,7 @@ { "name": "bitmap-mode", "default": null, - "type": "285" + "type": "289" }, { "name": "compress", @@ -2633,12 +2651,12 @@ { "name": "on-source-error", "default": null, - "type": "283" + "type": "287" }, { "name": "on-target-error", "default": null, - "type": "283" + "type": "287" }, { "name": "auto-finalize", @@ -2658,7 +2676,7 @@ { "name": "x-perf", "default": null, - "type": "286", + "type": "290", "features": [ "unstable" ] @@ -2721,7 +2739,7 @@ }, { "name": "detect_zeroes", - "type": "287" + "type": "291" }, { "name": "bps", @@ -2749,7 +2767,7 @@ }, { "name": "image", - "type": "288" + "type": "292" }, { "name": "bps_max", @@ -2823,7 +2841,7 @@ }, { "name": "cache", - "type": "289" + "type": "293" }, { "name": "write_threshold", @@ -2832,7 +2850,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[290]" + "type": "[294]" } ], "meta-type": "object" @@ -2842,11 +2860,11 @@ "members": [ { "name": "nodes", - "type": "[291]" + "type": "[295]" }, { "name": "edges", - "type": "[292]" + "type": "[296]" } ], "meta-type": "object" @@ -2884,12 +2902,12 @@ }, { "name": "sync", - "type": "284" + "type": "288" }, { "name": "mode", "default": null, - "type": "282" + "type": "286" }, { "name": "speed", @@ -2909,12 +2927,12 @@ { "name": "on-source-error", "default": null, - "type": "283" + "type": "287" }, { "name": "on-target-error", "default": null, - "type": "283" + "type": "287" }, { "name": "unmap", @@ -2924,7 +2942,7 @@ { "name": "copy-mode", "default": null, - "type": "293" + "type": "297" }, { "name": "auto-finalize", @@ -2995,7 +3013,7 @@ }, { "name": "bitmaps", - "type": "[294]" + "type": "[298]" } ], "meta-type": "object" @@ -3033,7 +3051,7 @@ }, { "name": "sync", - "type": "284" + "type": "288" }, { "name": "speed", @@ -3053,12 +3071,12 @@ { "name": "on-source-error", "default": null, - "type": "283" + "type": "287" }, { "name": "on-target-error", "default": null, - "type": "283" + "type": "287" }, { "name": "filter-node-name", @@ -3068,7 +3086,7 @@ { "name": "copy-mode", "default": null, - "type": "293" + "type": "297" }, { "name": "auto-finalize", @@ -3123,7 +3141,7 @@ { "name": "on-error", "default": null, - "type": "283" + "type": "287" }, { "name": "filter-node-name", @@ -3228,197 +3246,197 @@ "variants": [ { "case": "blkdebug", - "type": "298" + "type": "302" }, { "case": "blklogwrites", - "type": "299" + "type": "303" }, { "case": "blkverify", - "type": "300" + "type": "304" }, { "case": "blkreplay", - "type": "301" + "type": "305" }, { "case": "bochs", - "type": "302" + "type": "306" }, { "case": "cloop", - "type": "302" + "type": "306" }, { "case": "compress", - "type": "302" + "type": "306" }, { "case": "copy-before-write", - "type": "303" + "type": "307" }, { "case": "copy-on-read", - "type": "304" + "type": "308" }, { "case": "dmg", - "type": "302" + "type": "306" }, { "case": "file", - "type": "305" + "type": "309" }, { "case": "ftp", - "type": "306" + "type": "310" }, { "case": "ftps", - "type": "307" + "type": "311" }, { "case": "gluster", - "type": "308" + "type": "312" }, { "case": "host_cdrom", - "type": "305" + "type": "309" }, { "case": "host_device", - "type": "305" + "type": "309" }, { "case": "http", - "type": "309" + "type": "313" }, { "case": "https", - "type": "310" + "type": "314" }, { "case": "io_uring", - "type": "311" + "type": "315" }, { "case": "iscsi", - "type": "312" + "type": "316" }, { "case": "luks", - "type": "313" + "type": "317" }, { "case": "nbd", - "type": "314" + "type": "318" }, { "case": "nfs", - "type": "315" + "type": "319" }, { "case": "null-aio", - "type": "316" + "type": "320" }, { "case": "null-co", - "type": "316" + "type": "320" }, { "case": "nvme", - "type": "317" + "type": "321" }, { "case": "nvme-io_uring", - "type": "318" + "type": "322" }, { "case": "parallels", - "type": "302" + "type": "306" }, { "case": "preallocate", - "type": "319" + "type": "323" }, { "case": "qcow2", - "type": "320" + "type": "324" }, { "case": "qcow", - "type": "321" + "type": "325" }, { "case": "qed", - "type": "322" + "type": "326" }, { "case": "quorum", - "type": "323" + "type": "327" }, { "case": "raw", - "type": "324" + "type": "328" }, { "case": "rbd", - "type": "325" + "type": "329" }, { "case": "replication", - "type": "326" + "type": "330" }, { "case": "snapshot-access", - "type": "302" + "type": "306" }, { "case": "ssh", - "type": "327" + "type": "331" }, { "case": "throttle", - "type": "328" + "type": "332" }, { "case": "vdi", - "type": "302" + "type": "306" }, { "case": "vhdx", - "type": "302" + "type": "306" }, { "case": "virtio-blk-vfio-pci", - "type": "329" + "type": "333" }, { "case": "virtio-blk-vhost-user", - "type": "330" + "type": "334" }, { "case": "virtio-blk-vhost-vdpa", - "type": "331" + "type": "335" }, { "case": "vmdk", - "type": "322" + "type": "326" }, { "case": "vpc", - "type": "302" + "type": "306" }, { "case": "vvfat", - "type": "332" + "type": "336" } ], "members": [ { "name": "driver", - "type": "295" + "type": "299" }, { "name": "node-name", @@ -3428,12 +3446,12 @@ { "name": "discard", "default": null, - "type": "296" + "type": "300" }, { "name": "cache", "default": null, - "type": "297" + "type": "301" }, { "name": "read-only", @@ -3453,7 +3471,7 @@ { "name": "detect-zeroes", "default": null, - "type": "287" + "type": "291" } ], "meta-type": "object" @@ -3487,7 +3505,7 @@ }, { "name": "options", - "type": "333" + "type": "337" } ], "meta-type": "object" @@ -3505,7 +3523,7 @@ }, { "name": "options", - "type": "334" + "type": "338" }, { "name": "force", @@ -3562,11 +3580,11 @@ }, { "name": "operation", - "type": "335" + "type": "339" }, { "name": "action", - "type": "336" + "type": "340" }, { "name": "nospace", @@ -3585,7 +3603,7 @@ "members": [ { "name": "type", - "type": "337" + "type": "341" }, { "name": "device", @@ -3616,7 +3634,7 @@ "members": [ { "name": "type", - "type": "337" + "type": "341" }, { "name": "device", @@ -3646,11 +3664,11 @@ }, { "name": "operation", - "type": "335" + "type": "339" }, { "name": "action", - "type": "336" + "type": "340" } ], "meta-type": "object" @@ -3660,7 +3678,7 @@ "members": [ { "name": "type", - "type": "337" + "type": "341" }, { "name": "device", @@ -3686,7 +3704,7 @@ "members": [ { "name": "type", - "type": "337" + "type": "341" }, { "name": "id", @@ -3756,7 +3774,7 @@ }, { "name": "iothread", - "type": "338" + "type": "342" }, { "name": "force", @@ -3789,7 +3807,7 @@ "members": [ { "name": "type", - "type": "339" + "type": "343" }, { "name": "error", @@ -3893,7 +3911,7 @@ }, { "name": "status", - "type": "281" + "type": "285" } ], "meta-type": "object" @@ -3972,11 +3990,11 @@ }, { "name": "type", - "type": "337" + "type": "341" }, { "name": "status", - "type": "281" + "type": "285" }, { "name": "current-progress", @@ -3999,7 +4017,7 @@ "members": [ { "name": "addr", - "type": "340" + "type": "344" }, { "name": "tls-creds", @@ -4059,7 +4077,7 @@ { "name": "mode", "default": null, - "type": "341" + "type": "345" } ], "meta-type": "object" @@ -4070,25 +4088,25 @@ "variants": [ { "case": "nbd", - "type": "343" + "type": "347" }, { "case": "vhost-user-blk", - "type": "344" + "type": "348" }, { "case": "fuse", - "type": "345" + "type": "349" }, { "case": "vduse-blk", - "type": "346" + "type": "350" } ], "members": [ { "name": "type", - "type": "342" + "type": "346" }, { "name": "id", @@ -4131,7 +4149,7 @@ { "name": "mode", "default": null, - "type": "341" + "type": "345" } ], "meta-type": "object" @@ -4160,7 +4178,7 @@ }, { "name": "type", - "type": "342" + "type": "346" }, { "name": "node-name", @@ -4225,7 +4243,7 @@ { "name": "format", "default": null, - "type": "347" + "type": "351" } ], "meta-type": "object" @@ -4244,7 +4262,7 @@ { "name": "format", "default": null, - "type": "347" + "type": "351" } ], "meta-type": "object" @@ -4263,7 +4281,7 @@ }, { "name": "backend", - "type": "348" + "type": "352" } ], "meta-type": "object" @@ -4288,7 +4306,7 @@ }, { "name": "backend", - "type": "348" + "type": "352" } ], "meta-type": "object" @@ -4356,7 +4374,7 @@ { "name": "format", "default": null, - "type": "349" + "type": "353" } ], "meta-type": "object" @@ -4366,7 +4384,7 @@ "members": [ { "name": "status", - "type": "350" + "type": "354" }, { "name": "completed", @@ -4399,7 +4417,7 @@ "members": [ { "name": "formats", - "type": "[349]" + "type": "[353]" } ], "meta-type": "object" @@ -4424,55 +4442,55 @@ "variants": [ { "case": "nic", - "type": "352" + "type": "356" }, { "case": "user", - "type": "353" + "type": "357" }, { "case": "tap", - "type": "354" + "type": "358" }, { "case": "l2tpv3", - "type": "355" + "type": "359" }, { "case": "socket", - "type": "356" + "type": "360" }, { "case": "stream", - "type": "357" + "type": "361" }, { "case": "dgram", - "type": "358" + "type": "362" }, { "case": "vde", - "type": "359" + "type": "363" }, { "case": "bridge", - "type": "360" + "type": "364" }, { "case": "hubport", - "type": "361" + "type": "365" }, { "case": "netmap", - "type": "362" + "type": "366" }, { "case": "vhost-user", - "type": "363" + "type": "367" }, { "case": "vhost-vdpa", - "type": "364" + "type": "368" }, { "case": "none", @@ -4486,7 +4504,7 @@ }, { "name": "type", - "type": "351" + "type": "355" } ], "meta-type": "object" @@ -4530,15 +4548,15 @@ }, { "name": "multicast", - "type": "368" + "type": "372" }, { "name": "unicast", - "type": "368" + "type": "372" }, { "name": "vlan", - "type": "368" + "type": "372" }, { "name": "broadcast-allowed", @@ -4637,7 +4655,7 @@ }, { "name": "addr", - "type": "369" + "type": "373" } ], "meta-type": "object" @@ -4738,11 +4756,11 @@ }, { "name": "duplex", - "type": "370" + "type": "374" }, { "name": "autoneg", - "type": "371" + "type": "375" } ], "meta-type": "object" @@ -4780,15 +4798,15 @@ }, { "name": "key", - "type": "372" + "type": "376" }, { "name": "mask", - "type": "373" + "type": "377" }, { "name": "action", - "type": "374" + "type": "378" } ], "meta-type": "object" @@ -4946,7 +4964,7 @@ }, { "name": "options", - "type": "375" + "type": "379" } ], "meta-type": "object" @@ -4957,7 +4975,7 @@ "variants": [ { "case": "vnc", - "type": "378" + "type": "382" }, { "case": "spice", @@ -4967,7 +4985,7 @@ "members": [ { "name": "protocol", - "type": "376" + "type": "380" }, { "name": "password", @@ -4976,7 +4994,7 @@ { "name": "connected", "default": null, - "type": "377" + "type": "381" } ], "meta-type": "object" @@ -4987,7 +5005,7 @@ "variants": [ { "case": "vnc", - "type": "379" + "type": "383" }, { "case": "spice", @@ -4997,7 +5015,7 @@ "members": [ { "name": "protocol", - "type": "376" + "type": "380" }, { "name": "time", @@ -5026,7 +5044,7 @@ { "name": "format", "default": null, - "type": "380" + "type": "384" } ], "meta-type": "object" @@ -5069,12 +5087,12 @@ }, { "name": "mouse-mode", - "type": "381" + "type": "385" }, { "name": "channels", "default": null, - "type": "[382]" + "type": "[386]" } ], "meta-type": "object" @@ -5084,11 +5102,11 @@ "members": [ { "name": "server", - "type": "383" + "type": "387" }, { "name": "client", - "type": "383" + "type": "387" } ], "meta-type": "object" @@ -5098,11 +5116,11 @@ "members": [ { "name": "server", - "type": "384" + "type": "388" }, { "name": "client", - "type": "382" + "type": "386" } ], "meta-type": "object" @@ -5112,11 +5130,11 @@ "members": [ { "name": "server", - "type": "383" + "type": "387" }, { "name": "client", - "type": "383" + "type": "387" } ], "meta-type": "object" @@ -5136,7 +5154,7 @@ { "name": "family", "default": null, - "type": "385" + "type": "389" }, { "name": "service", @@ -5151,7 +5169,7 @@ { "name": "clients", "default": null, - "type": "[386]" + "type": "[390]" } ], "meta-type": "object" @@ -5170,20 +5188,20 @@ }, { "name": "server", - "type": "[387]" + "type": "[391]" }, { "name": "clients", - "type": "[386]" + "type": "[390]" }, { "name": "auth", - "type": "388" + "type": "392" }, { "name": "vencrypt", "default": null, - "type": "389" + "type": "393" }, { "name": "display", @@ -5208,11 +5226,11 @@ "members": [ { "name": "server", - "type": "390" + "type": "394" }, { "name": "client", - "type": "391" + "type": "395" } ], "meta-type": "object" @@ -5222,11 +5240,11 @@ "members": [ { "name": "server", - "type": "390" + "type": "394" }, { "name": "client", - "type": "386" + "type": "390" } ], "meta-type": "object" @@ -5236,11 +5254,11 @@ "members": [ { "name": "server", - "type": "390" + "type": "394" }, { "name": "client", - "type": "386" + "type": "390" } ], "meta-type": "object" @@ -5277,7 +5295,7 @@ "members": [ { "name": "keys", - "type": "[392]" + "type": "[396]" }, { "name": "hold-time", @@ -5302,7 +5320,7 @@ }, { "name": "events", - "type": "[393]" + "type": "[397]" } ], "meta-type": "object" @@ -5313,19 +5331,19 @@ "variants": [ { "case": "curses", - "type": "398" + "type": "402" }, { "case": "egl-headless", - "type": "399" + "type": "403" }, { "case": "dbus", - "type": "400" + "type": "404" }, { "case": "sdl", - "type": "401" + "type": "405" }, { "case": "default", @@ -5343,7 +5361,7 @@ "members": [ { "name": "type", - "type": "394" + "type": "398" }, { "name": "full-screen", @@ -5363,7 +5381,7 @@ { "name": "gl", "default": null, - "type": "395" + "type": "399" } ], "meta-type": "object" @@ -5374,13 +5392,13 @@ "variants": [ { "case": "vnc", - "type": "403" + "type": "407" } ], "members": [ { "name": "type", - "type": "402" + "type": "406" } ], "meta-type": "object" @@ -5391,13 +5409,13 @@ "variants": [ { "case": "vnc", - "type": "405" + "type": "409" } ], "members": [ { "name": "type", - "type": "404" + "type": "408" } ], "meta-type": "object" @@ -5408,27 +5426,27 @@ { "name": "status", "default": null, - "type": "406" + "type": "410" }, { "name": "ram", "default": null, - "type": "407" + "type": "411" }, { "name": "disk", "default": null, - "type": "407" + "type": "411" }, { "name": "vfio", "default": null, - "type": "408" + "type": "412" }, { "name": "xbzrle-cache", "default": null, - "type": "409" + "type": "413" }, { "name": "total-time", @@ -5478,12 +5496,12 @@ { "name": "compression", "default": null, - "type": "410" + "type": "414" }, { "name": "socket-address", "default": null, - "type": "[369]" + "type": "[373]" } ], "meta-type": "object" @@ -5508,7 +5526,7 @@ "members": [ { "name": "capability", - "type": "411" + "type": "415" }, { "name": "state", @@ -5583,17 +5601,17 @@ { "name": "tls-creds", "default": null, - "type": "338" + "type": "342" }, { "name": "tls-hostname", "default": null, - "type": "338" + "type": "342" }, { "name": "tls-authz", "default": null, - "type": "338" + "type": "342" }, { "name": "max-bandwidth", @@ -5641,7 +5659,7 @@ { "name": "multifd-compression", "default": null, - "type": "412" + "type": "416" }, { "name": "multifd-zlib-level", @@ -5656,7 +5674,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[413]" + "type": "[417]" } ], "meta-type": "object" @@ -5785,7 +5803,7 @@ { "name": "multifd-compression", "default": null, - "type": "412" + "type": "416" }, { "name": "multifd-zlib-level", @@ -5800,7 +5818,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[413]" + "type": "[417]" } ], "meta-type": "object" @@ -5839,7 +5857,7 @@ "members": [ { "name": "status", - "type": "406" + "type": "410" } ], "meta-type": "object" @@ -5859,11 +5877,11 @@ "members": [ { "name": "mode", - "type": "414" + "type": "418" }, { "name": "reason", - "type": "415" + "type": "419" } ], "meta-type": "object" @@ -5873,7 +5891,7 @@ "members": [ { "name": "state", - "type": "406" + "type": "410" } ], "meta-type": "object" @@ -5992,15 +6010,15 @@ "members": [ { "name": "mode", - "type": "414" + "type": "418" }, { "name": "last-mode", - "type": "414" + "type": "418" }, { "name": "reason", - "type": "415" + "type": "419" } ], "meta-type": "object" @@ -6040,7 +6058,7 @@ { "name": "mode", "default": null, - "type": "416" + "type": "420" } ], "meta-type": "object" @@ -6055,7 +6073,7 @@ }, { "name": "status", - "type": "417" + "type": "421" }, { "name": "start-time", @@ -6071,12 +6089,12 @@ }, { "name": "mode", - "type": "416" + "type": "420" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[418]" + "type": "[422]" } ], "meta-type": "object" @@ -6216,12 +6234,12 @@ "members": [ { "name": "actions", - "type": "[419]" + "type": "[423]" }, { "name": "properties", "default": null, - "type": "420" + "type": "424" } ], "meta-type": "object" @@ -6255,7 +6273,7 @@ }, { "name": "state", - "type": "421" + "type": "425" }, { "name": "vcpu", @@ -6294,7 +6312,7 @@ { "name": "enable", "default": null, - "type": "[422]" + "type": "[426]" } ], "meta-type": "object" @@ -6304,7 +6322,7 @@ "members": [ { "name": "qemu", - "type": "423" + "type": "427" }, { "name": "package", @@ -6339,31 +6357,31 @@ "variants": [ { "case": "builtin", - "type": "425" + "type": "429" }, { "case": "enum", - "type": "426" + "type": "430" }, { "case": "array", - "type": "427" + "type": "431" }, { "case": "object", - "type": "428" + "type": "432" }, { "case": "alternate", - "type": "429" + "type": "433" }, { "case": "command", - "type": "430" + "type": "434" }, { "case": "event", - "type": "431" + "type": "435" } ], "members": [ @@ -6373,7 +6391,7 @@ }, { "name": "meta-type", - "type": "424" + "type": "428" }, { "name": "features", @@ -6516,167 +6534,167 @@ "variants": [ { "case": "authz-list", - "type": "433" + "type": "437" }, { "case": "authz-listfile", - "type": "434" + "type": "438" }, { "case": "authz-pam", - "type": "435" + "type": "439" }, { "case": "authz-simple", - "type": "436" + "type": "440" }, { "case": "can-host-socketcan", - "type": "437" + "type": "441" }, { "case": "colo-compare", - "type": "438" + "type": "442" }, { "case": "cryptodev-backend", - "type": "439" + "type": "443" }, { "case": "cryptodev-backend-builtin", - "type": "439" + "type": "443" }, { "case": "cryptodev-backend-lkcf", - "type": "439" + "type": "443" }, { "case": "cryptodev-vhost-user", - "type": "440" + "type": "444" }, { "case": "dbus-vmstate", - "type": "441" + "type": "445" }, { "case": "filter-buffer", - "type": "442" + "type": "446" }, { "case": "filter-dump", - "type": "443" + "type": "447" }, { "case": "filter-mirror", - "type": "444" + "type": "448" }, { "case": "filter-redirector", - "type": "445" + "type": "449" }, { "case": "filter-replay", - "type": "446" + "type": "450" }, { "case": "filter-rewriter", - "type": "447" + "type": "451" }, { "case": "input-barrier", - "type": "448" + "type": "452" }, { "case": "input-linux", - "type": "449" + "type": "453" }, { "case": "iothread", - "type": "450" + "type": "454" }, { "case": "main-loop", - "type": "451" + "type": "455" }, { "case": "memory-backend-epc", - "type": "452" + "type": "456" }, { "case": "memory-backend-file", - "type": "453" + "type": "457" }, { "case": "memory-backend-memfd", - "type": "454" + "type": "458" }, { "case": "memory-backend-ram", - "type": "455" + "type": "459" }, { "case": "pr-manager-helper", - "type": "456" + "type": "460" }, { "case": "qtest", - "type": "457" + "type": "461" }, { "case": "rng-builtin", - "type": "458" + "type": "462" }, { "case": "rng-egd", - "type": "459" + "type": "463" }, { "case": "rng-random", - "type": "460" + "type": "464" }, { "case": "secret", - "type": "461" + "type": "465" }, { "case": "secret_keyring", - "type": "462" + "type": "466" }, { "case": "sev-guest", - "type": "463" + "type": "467" }, { "case": "thread-context", - "type": "464" + "type": "468" }, { "case": "throttle-group", - "type": "465" + "type": "469" }, { "case": "tls-creds-anon", - "type": "466" + "type": "470" }, { "case": "tls-creds-psk", - "type": "467" + "type": "471" }, { "case": "tls-creds-x509", - "type": "468" + "type": "472" }, { "case": "tls-cipher-suites", - "type": "469" + "type": "473" }, { "case": "x-remote-object", - "type": "470" + "type": "474" }, { "case": "x-vfio-user-server", - "type": "471" + "type": "475" }, { "case": "can-bus", @@ -6694,7 +6712,7 @@ "members": [ { "name": "qom-type", - "type": "432" + "type": "436" }, { "name": "id", @@ -6794,7 +6812,7 @@ "variants": [ { "case": "s390x", - "type": "474" + "type": "478" }, { "case": "aarch64", @@ -6933,11 +6951,11 @@ { "name": "props", "default": null, - "type": "472" + "type": "476" }, { "name": "target", - "type": "473" + "type": "477" } ], "meta-type": "object" @@ -7012,7 +7030,7 @@ "members": [ { "name": "arch", - "type": "473" + "type": "477" } ], "meta-type": "object" @@ -7136,7 +7154,7 @@ }, { "name": "policy", - "type": "475" + "type": "479" } ], "meta-type": "object" @@ -7159,7 +7177,7 @@ }, { "name": "props", - "type": "472" + "type": "476" }, { "name": "qom-path", @@ -7175,29 +7193,29 @@ "variants": [ { "case": "node", - "type": "477" + "type": "481" }, { "case": "dist", - "type": "478" + "type": "482" }, { "case": "cpu", - "type": "479" + "type": "483" }, { "case": "hmat-lb", - "type": "480" + "type": "484" }, { "case": "hmat-cache", - "type": "481" + "type": "485" } ], "members": [ { "name": "type", - "type": "476" + "type": "480" } ], "meta-type": "object" @@ -7258,29 +7276,29 @@ "variants": [ { "case": "dimm", - "type": "483" + "type": "487" }, { "case": "nvdimm", - "type": "483" + "type": "487" }, { "case": "virtio-pmem", - "type": "484" + "type": "488" }, { "case": "virtio-mem", - "type": "485" + "type": "489" }, { "case": "sgx-epc", - "type": "486" + "type": "490" } ], "members": [ { "name": "type", - "type": "482" + "type": "486" } ], "meta-type": "object" @@ -7343,11 +7361,11 @@ "members": [ { "name": "type", - "type": "489" + "type": "493" }, { "name": "model", - "type": "487" + "type": "491" } ], "meta-type": "object" @@ -7357,7 +7375,7 @@ "members": [ { "name": "model", - "type": "487" + "type": "491" } ], "meta-type": "object" @@ -7409,7 +7427,7 @@ "members": [ { "name": "mode", - "type": "490" + "type": "494" }, { "name": "filename", @@ -7464,11 +7482,11 @@ "variants": [ { "case": "block-node", - "type": "492" + "type": "496" }, { "case": "chardev", - "type": "493" + "type": "497" }, { "case": "migration", @@ -7478,7 +7496,7 @@ "members": [ { "name": "type", - "type": "491" + "type": "495" } ], "meta-type": "object" @@ -7579,7 +7597,7 @@ "meta-type": "object" }, { - "name": "229", + "name": "230", "members": [ { "name": "fdname", @@ -7589,7 +7607,7 @@ "meta-type": "object" }, { - "name": "230", + "name": "231", "members": [ { "name": "fdset-id", @@ -7605,7 +7623,7 @@ "meta-type": "object" }, { - "name": "231", + "name": "232", "members": [ { "name": "fdset-id", @@ -7619,7 +7637,7 @@ "meta-type": "object" }, { - "name": "232", + "name": "233", "members": [ { "name": "fdset-id", @@ -7634,12 +7652,12 @@ "meta-type": "object" }, { - "name": "[233]", - "element-type": "233", + "name": "[234]", + "element-type": "234", "meta-type": "array" }, { - "name": "233", + "name": "234", "members": [ { "name": "fdset-id", @@ -7647,13 +7665,13 @@ }, { "name": "fds", - "type": "[494]" + "type": "[498]" } ], "meta-type": "object" }, { - "name": "234", + "name": "235", "members": [ { "name": "option", @@ -7664,12 +7682,12 @@ "meta-type": "object" }, { - "name": "[235]", - "element-type": "235", + "name": "[236]", + "element-type": "236", "meta-type": "array" }, { - "name": "235", + "name": "236", "members": [ { "name": "option", @@ -7677,13 +7695,13 @@ }, { "name": "parameters", - "type": "[495]" + "type": "[499]" } ], "meta-type": "object" }, { - "name": "236", + "name": "237", "members": [ { "name": "offset", @@ -7697,7 +7715,7 @@ "meta-type": "object" }, { - "name": "237", + "name": "238", "members": [ { "name": "vfu-id", @@ -7719,7 +7737,7 @@ "meta-type": "object" }, { - "name": "238", + "name": "239", "members": [ { "name": "enabled", @@ -7743,7 +7761,7 @@ }, { "name": "state", - "type": "496" + "type": "500" }, { "name": "handle", @@ -7753,7 +7771,7 @@ "meta-type": "object" }, { - "name": "239", + "name": "240", "members": [ { "name": "data", @@ -7763,7 +7781,7 @@ "meta-type": "object" }, { - "name": "240", + "name": "241", "members": [ { "name": "pdh", @@ -7789,7 +7807,7 @@ "meta-type": "object" }, { - "name": "241", + "name": "242", "members": [ { "name": "packet-header", @@ -7808,7 +7826,7 @@ "meta-type": "object" }, { - "name": "242", + "name": "243", "members": [ { "name": "mnonce", @@ -7818,7 +7836,7 @@ "meta-type": "object" }, { - "name": "243", + "name": "244", "members": [ { "name": "data", @@ -7828,7 +7846,7 @@ "meta-type": "object" }, { - "name": "246", + "name": "247", "members": [ { "name": "sgx", @@ -7848,18 +7866,18 @@ }, { "name": "sections", - "type": "[497]" + "type": "[501]" } ], "meta-type": "object" }, { - "name": "[247]", - "element-type": "247", + "name": "[248]", + "element-type": "248", "meta-type": "array" }, { - "name": "247", + "name": "248", "members": [ { "name": "port", @@ -7871,7 +7889,7 @@ }, { "name": "type", - "type": "498" + "type": "502" }, { "name": "remote-domain", @@ -7893,7 +7911,7 @@ "meta-type": "object" }, { - "name": "248", + "name": "249", "members": [ { "name": "port", @@ -7903,45 +7921,45 @@ "meta-type": "object" }, { - "name": "[249]", - "element-type": "249", + "name": "[250]", + "element-type": "250", "meta-type": "array" }, { - "name": "249", + "name": "250", "tag": "driver", "variants": [ { "case": "none", - "type": "500" + "type": "504" }, { "case": "alsa", - "type": "501" + "type": "505" }, { "case": "dbus", - "type": "500" + "type": "504" }, { "case": "oss", - "type": "505" + "type": "509" }, { "case": "pa", - "type": "506" + "type": "510" }, { "case": "sdl", - "type": "507" + "type": "511" }, { "case": "spice", - "type": "500" + "type": "504" }, { "case": "wav", - "type": "509" + "type": "513" } ], "members": [ @@ -7951,7 +7969,7 @@ }, { "name": "driver", - "type": "499" + "type": "503" }, { "name": "timer-period", @@ -7962,12 +7980,12 @@ "meta-type": "object" }, { - "name": "[250]", - "element-type": "250", + "name": "[251]", + "element-type": "251", "meta-type": "array" }, { - "name": "250", + "name": "251", "members": [ { "name": "device", @@ -7980,7 +7998,7 @@ }, { "name": "slot-type", - "type": "510" + "type": "514" }, { "name": "source", @@ -7994,22 +8012,22 @@ "meta-type": "object" }, { - "name": "251", + "name": "252", "members": [ { "name": "info", - "type": "250" + "type": "251" } ], "meta-type": "object" }, { - "name": "[252]", - "element-type": "252", + "name": "[253]", + "element-type": "253", "meta-type": "array" }, { - "name": "252", + "name": "253", "members": [ { "name": "bus", @@ -8017,48 +8035,52 @@ }, { "name": "devices", - "type": "[511]" + "type": "[515]" } ], "meta-type": "object" }, { - "name": "253", + "name": "254", "tag": "target", "variants": [ { "case": "vcpu", - "type": "514" + "type": "518" }, { "case": "vm", "type": "0" + }, + { + "case": "cryptodev", + "type": "0" } ], "members": [ { "name": "target", - "type": "512" + "type": "516" }, { "name": "providers", "default": null, - "type": "[513]" + "type": "[517]" } ], "meta-type": "object" }, { - "name": "[254]", - "element-type": "254", + "name": "[255]", + "element-type": "255", "meta-type": "array" }, { - "name": "254", + "name": "255", "members": [ { "name": "provider", - "type": "515" + "type": "519" }, { "name": "qom-path", @@ -8067,52 +8089,52 @@ }, { "name": "stats", - "type": "[516]" + "type": "[520]" } ], "meta-type": "object" }, { - "name": "255", + "name": "256", "members": [ { "name": "provider", "default": null, - "type": "515" + "type": "519" } ], "meta-type": "object" }, { - "name": "[256]", - "element-type": "256", + "name": "[257]", + "element-type": "257", "meta-type": "array" }, { - "name": "256", + "name": "257", "members": [ { "name": "provider", - "type": "515" + "type": "519" }, { "name": "target", - "type": "512" + "type": "516" }, { "name": "stats", - "type": "[517]" + "type": "[521]" } ], "meta-type": "object" }, { - "name": "[257]", - "element-type": "257", + "name": "[258]", + "element-type": "258", "meta-type": "array" }, { - "name": "257", + "name": "258", "members": [ { "name": "path", @@ -8126,7 +8148,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "259", "members": [ { "name": "path", @@ -8136,7 +8158,7 @@ "meta-type": "object" }, { - "name": "259", + "name": "260", "members": [ { "name": "name", @@ -8156,15 +8178,15 @@ }, { "name": "guest-features", - "type": "518" + "type": "522" }, { "name": "host-features", - "type": "518" + "type": "522" }, { "name": "backend-features", - "type": "518" + "type": "522" }, { "name": "num-vqs", @@ -8172,7 +8194,7 @@ }, { "name": "status", - "type": "519" + "type": "523" }, { "name": "isr", @@ -8221,13 +8243,13 @@ { "name": "vhost-dev", "default": null, - "type": "520" + "type": "524" } ], "meta-type": "object" }, { - "name": "260", + "name": "261", "members": [ { "name": "path", @@ -8241,7 +8263,7 @@ "meta-type": "object" }, { - "name": "261", + "name": "262", "members": [ { "name": "name", @@ -8305,7 +8327,7 @@ "meta-type": "object" }, { - "name": "262", + "name": "263", "members": [ { "name": "path", @@ -8319,7 +8341,7 @@ "meta-type": "object" }, { - "name": "263", + "name": "264", "members": [ { "name": "name", @@ -8377,7 +8399,7 @@ "meta-type": "object" }, { - "name": "264", + "name": "265", "members": [ { "name": "path", @@ -8396,7 +8418,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "266", "members": [ { "name": "name", @@ -8408,15 +8430,66 @@ }, { "name": "descs", - "type": "[521]" + "type": "[525]" }, { "name": "avail", - "type": "522" + "type": "526" }, { "name": "used", - "type": "523" + "type": "527" + } + ], + "meta-type": "object" + }, + { + "name": "[267]", + "element-type": "267", + "meta-type": "array" + }, + { + "name": "267", + "members": [ + { + "name": "id", + "type": "str" + }, + { + "name": "service", + "type": "[528]" + }, + { + "name": "client", + "type": "[529]" + } + ], + "meta-type": "object" + }, + { + "name": "268", + "members": [ + { + "name": "path", + "type": "str" + }, + { + "name": "errors", + "type": "[530]" + } + ], + "meta-type": "object" + }, + { + "name": "269", + "members": [ + { + "name": "path", + "type": "str" + }, + { + "name": "type", + "type": "531" } ], "meta-type": "object" @@ -8427,7 +8500,7 @@ "meta-type": "builtin" }, { - "name": "266", + "name": "270", "members": [ { "name": "debug" @@ -8499,7 +8572,7 @@ ] }, { - "name": "267", + "name": "271", "members": [ { "name": "none" @@ -8551,7 +8624,7 @@ ] }, { - "name": "268", + "name": "272", "members": [ { "name": "reset" @@ -8587,7 +8660,7 @@ ] }, { - "name": "269", + "name": "273", "members": [ { "name": "reset" @@ -8603,7 +8676,7 @@ ] }, { - "name": "270", + "name": "274", "members": [ { "name": "poweroff" @@ -8619,7 +8692,7 @@ ] }, { - "name": "271", + "name": "275", "members": [ { "name": "pause" @@ -8643,7 +8716,7 @@ ] }, { - "name": "272", + "name": "276", "members": [ { "name": "pause" @@ -8663,28 +8736,28 @@ ] }, { - "name": "273", + "name": "277", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "525" + "type": "533" }, { "case": "s390", - "type": "526" + "type": "534" } ], "members": [ { "name": "type", - "type": "524" + "type": "532" } ], "meta-type": "object" }, { - "name": "274", + "name": "278", "members": [ { "name": "hypervisor" @@ -8700,7 +8773,7 @@ ] }, { - "name": "275", + "name": "279", "members": [ { "name": "ignore" @@ -8724,7 +8797,7 @@ ] }, { - "name": "276", + "name": "280", "members": [ { "name": "action-required", @@ -8738,7 +8811,7 @@ "meta-type": "object" }, { - "name": "277", + "name": "281", "members": [ { "name": "retain" @@ -8768,7 +8841,7 @@ "meta-type": "array" }, { - "name": "278", + "name": "282", "members": [ { "name": "ok" @@ -8788,7 +8861,7 @@ ] }, { - "name": "279", + "name": "283", "members": [ { "name": "rd_bytes", @@ -8897,41 +8970,41 @@ }, { "name": "timed_stats", - "type": "[527]" + "type": "[535]" }, { "name": "rd_latency_histogram", "default": null, - "type": "528" + "type": "536" }, { "name": "wr_latency_histogram", "default": null, - "type": "528" + "type": "536" }, { "name": "flush_latency_histogram", "default": null, - "type": "528" + "type": "536" } ], "meta-type": "object" }, { - "name": "280", + "name": "284", "tag": "driver", "variants": [ { "case": "file", - "type": "529" + "type": "537" }, { "case": "host_device", - "type": "529" + "type": "537" }, { "case": "nvme", - "type": "530" + "type": "538" }, { "case": "blkdebug", @@ -9113,13 +9186,13 @@ "members": [ { "name": "driver", - "type": "295" + "type": "299" } ], "meta-type": "object" }, { - "name": "281", + "name": "285", "members": [ { "name": "undefined" @@ -9171,7 +9244,7 @@ ] }, { - "name": "282", + "name": "286", "members": [ { "name": "existing" @@ -9187,7 +9260,7 @@ ] }, { - "name": "283", + "name": "287", "members": [ { "name": "report" @@ -9215,7 +9288,7 @@ ] }, { - "name": "284", + "name": "288", "members": [ { "name": "top" @@ -9243,7 +9316,7 @@ ] }, { - "name": "285", + "name": "289", "members": [ { "name": "on-success" @@ -9263,7 +9336,7 @@ ] }, { - "name": "286", + "name": "290", "members": [ { "name": "use-copy-range", @@ -9284,7 +9357,7 @@ "meta-type": "object" }, { - "name": "287", + "name": "291", "members": [ { "name": "off" @@ -9304,7 +9377,7 @@ ] }, { - "name": "288", + "name": "292", "members": [ { "name": "filename", @@ -9366,18 +9439,18 @@ { "name": "format-specific", "default": null, - "type": "531" + "type": "539" }, { "name": "backing-image", "default": null, - "type": "288" + "type": "292" } ], "meta-type": "object" }, { - "name": "289", + "name": "293", "members": [ { "name": "writeback", @@ -9395,12 +9468,12 @@ "meta-type": "object" }, { - "name": "[290]", - "element-type": "290", + "name": "[294]", + "element-type": "294", "meta-type": "array" }, { - "name": "290", + "name": "294", "members": [ { "name": "name", @@ -9436,12 +9509,12 @@ "meta-type": "object" }, { - "name": "[291]", - "element-type": "291", + "name": "[295]", + "element-type": "295", "meta-type": "array" }, { - "name": "291", + "name": "295", "members": [ { "name": "id", @@ -9449,7 +9522,7 @@ }, { "name": "type", - "type": "532" + "type": "540" }, { "name": "name", @@ -9459,12 +9532,12 @@ "meta-type": "object" }, { - "name": "[292]", - "element-type": "292", + "name": "[296]", + "element-type": "296", "meta-type": "array" }, { - "name": "292", + "name": "296", "members": [ { "name": "parent", @@ -9480,17 +9553,17 @@ }, { "name": "perm", - "type": "[533]" + "type": "[541]" }, { "name": "shared-perm", - "type": "[533]" + "type": "[541]" } ], "meta-type": "object" }, { - "name": "293", + "name": "297", "members": [ { "name": "background" @@ -9506,12 +9579,12 @@ ] }, { - "name": "[294]", - "element-type": "294", + "name": "[298]", + "element-type": "298", "meta-type": "array" }, { - "name": "294", + "name": "298", "members": [ { "type": "str" @@ -9523,7 +9596,7 @@ "meta-type": "alternate" }, { - "name": "295", + "name": "299", "members": [ { "name": "blkdebug" @@ -9719,7 +9792,7 @@ ] }, { - "name": "296", + "name": "300", "members": [ { "name": "ignore" @@ -9735,7 +9808,7 @@ ] }, { - "name": "297", + "name": "301", "members": [ { "name": "direct", @@ -9751,11 +9824,11 @@ "meta-type": "object" }, { - "name": "298", + "name": "302", "members": [ { "name": "image", - "type": "534" + "type": "542" }, { "name": "config", @@ -9795,36 +9868,36 @@ { "name": "inject-error", "default": null, - "type": "[535]" + "type": "[543]" }, { "name": "set-state", "default": null, - "type": "[536]" + "type": "[544]" }, { "name": "take-child-perms", "default": null, - "type": "[533]" + "type": "[541]" }, { "name": "unshare-child-perms", "default": null, - "type": "[533]" + "type": "[541]" } ], "meta-type": "object" }, { - "name": "299", + "name": "303", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "log", - "type": "534" + "type": "542" }, { "name": "log-sector-size", @@ -9845,49 +9918,49 @@ "meta-type": "object" }, { - "name": "300", + "name": "304", "members": [ { "name": "test", - "type": "534" + "type": "542" }, { "name": "raw", - "type": "534" + "type": "542" } ], "meta-type": "object" }, { - "name": "301", + "name": "305", "members": [ { "name": "image", - "type": "534" + "type": "542" } ], "meta-type": "object" }, { - "name": "302", + "name": "306", "members": [ { "name": "file", - "type": "534" + "type": "542" } ], "meta-type": "object" }, { - "name": "303", + "name": "307", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "target", - "type": "534" + "type": "542" }, { "name": "bitmap", @@ -9897,7 +9970,7 @@ { "name": "on-cbw-error", "default": null, - "type": "537" + "type": "545" }, { "name": "cbw-timeout", @@ -9908,11 +9981,11 @@ "meta-type": "object" }, { - "name": "304", + "name": "308", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "bottom", @@ -9923,7 +9996,7 @@ "meta-type": "object" }, { - "name": "305", + "name": "309", "members": [ { "name": "filename", @@ -9937,12 +10010,12 @@ { "name": "locking", "default": null, - "type": "538" + "type": "546" }, { "name": "aio", "default": null, - "type": "539" + "type": "547" }, { "name": "aio-max-batch", @@ -9969,7 +10042,7 @@ ] }, { - "name": "306", + "name": "310", "members": [ { "name": "url", @@ -10009,7 +10082,7 @@ "meta-type": "object" }, { - "name": "307", + "name": "311", "members": [ { "name": "url", @@ -10054,7 +10127,7 @@ "meta-type": "object" }, { - "name": "308", + "name": "312", "members": [ { "name": "volume", @@ -10066,7 +10139,7 @@ }, { "name": "server", - "type": "[369]" + "type": "[373]" }, { "name": "debug", @@ -10082,7 +10155,7 @@ "meta-type": "object" }, { - "name": "309", + "name": "313", "members": [ { "name": "url", @@ -10132,7 +10205,7 @@ "meta-type": "object" }, { - "name": "310", + "name": "314", "members": [ { "name": "url", @@ -10187,7 +10260,7 @@ "meta-type": "object" }, { - "name": "311", + "name": "315", "members": [ { "name": "filename", @@ -10197,11 +10270,11 @@ "meta-type": "object" }, { - "name": "312", + "name": "316", "members": [ { "name": "transport", - "type": "540" + "type": "548" }, { "name": "portal", @@ -10234,7 +10307,7 @@ { "name": "header-digest", "default": null, - "type": "541" + "type": "549" }, { "name": "timeout", @@ -10245,11 +10318,11 @@ "meta-type": "object" }, { - "name": "313", + "name": "317", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "key-secret", @@ -10260,11 +10333,11 @@ "meta-type": "object" }, { - "name": "314", + "name": "318", "members": [ { "name": "server", - "type": "369" + "type": "373" }, { "name": "export", @@ -10303,11 +10376,11 @@ "meta-type": "object" }, { - "name": "315", + "name": "319", "members": [ { "name": "server", - "type": "542" + "type": "550" }, { "name": "path", @@ -10347,7 +10420,7 @@ "meta-type": "object" }, { - "name": "316", + "name": "320", "members": [ { "name": "size", @@ -10368,7 +10441,7 @@ "meta-type": "object" }, { - "name": "317", + "name": "321", "members": [ { "name": "device", @@ -10382,7 +10455,7 @@ "meta-type": "object" }, { - "name": "318", + "name": "322", "members": [ { "name": "path", @@ -10392,11 +10465,11 @@ "meta-type": "object" }, { - "name": "319", + "name": "323", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "prealloc-align", @@ -10412,16 +10485,16 @@ "meta-type": "object" }, { - "name": "320", + "name": "324", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "backing", "default": null, - "type": "543" + "type": "551" }, { "name": "lazy-refcounts", @@ -10446,7 +10519,7 @@ { "name": "overlap-check", "default": null, - "type": "544" + "type": "552" }, { "name": "cache-size", @@ -10476,53 +10549,53 @@ { "name": "encrypt", "default": null, - "type": "545" + "type": "553" }, { "name": "data-file", "default": null, - "type": "534" + "type": "542" } ], "meta-type": "object" }, { - "name": "321", + "name": "325", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "backing", "default": null, - "type": "543" + "type": "551" }, { "name": "encrypt", "default": null, - "type": "546" + "type": "554" } ], "meta-type": "object" }, { - "name": "322", + "name": "326", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "backing", "default": null, - "type": "543" + "type": "551" } ], "meta-type": "object" }, { - "name": "323", + "name": "327", "members": [ { "name": "blkverify", @@ -10531,7 +10604,7 @@ }, { "name": "children", - "type": "[534]" + "type": "[542]" }, { "name": "vote-threshold", @@ -10545,17 +10618,17 @@ { "name": "read-pattern", "default": null, - "type": "547" + "type": "555" } ], "meta-type": "object" }, { - "name": "324", + "name": "328", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "offset", @@ -10571,7 +10644,7 @@ "meta-type": "object" }, { - "name": "325", + "name": "329", "members": [ { "name": "pool", @@ -10599,7 +10672,7 @@ { "name": "encrypt", "default": null, - "type": "548" + "type": "556" }, { "name": "user", @@ -10609,7 +10682,7 @@ { "name": "auth-client-required", "default": null, - "type": "[549]" + "type": "[557]" }, { "name": "key-secret", @@ -10619,21 +10692,21 @@ { "name": "server", "default": null, - "type": "[550]" + "type": "[558]" } ], "meta-type": "object" }, { - "name": "326", + "name": "330", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "mode", - "type": "551" + "type": "559" }, { "name": "top-id", @@ -10644,11 +10717,11 @@ "meta-type": "object" }, { - "name": "327", + "name": "331", "members": [ { "name": "server", - "type": "552" + "type": "560" }, { "name": "path", @@ -10662,13 +10735,13 @@ { "name": "host-key-check", "default": null, - "type": "553" + "type": "561" } ], "meta-type": "object" }, { - "name": "328", + "name": "332", "members": [ { "name": "throttle-group", @@ -10676,13 +10749,13 @@ }, { "name": "file", - "type": "534" + "type": "542" } ], "meta-type": "object" }, { - "name": "329", + "name": "333", "members": [ { "name": "path", @@ -10692,7 +10765,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "334", "members": [ { "name": "path", @@ -10702,7 +10775,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "335", "members": [ { "name": "path", @@ -10712,7 +10785,7 @@ "meta-type": "object" }, { - "name": "332", + "name": "336", "members": [ { "name": "dir", @@ -10747,64 +10820,64 @@ "meta-type": "array" }, { - "name": "333", + "name": "337", "tag": "driver", "variants": [ { "case": "file", - "type": "554" + "type": "562" }, { "case": "gluster", - "type": "555" + "type": "563" }, { "case": "luks", - "type": "556" + "type": "564" }, { "case": "nfs", - "type": "557" + "type": "565" }, { "case": "parallels", - "type": "558" + "type": "566" }, { "case": "qcow", - "type": "559" + "type": "567" }, { "case": "qcow2", - "type": "560" + "type": "568" }, { "case": "qed", - "type": "561" + "type": "569" }, { "case": "rbd", - "type": "562" + "type": "570" }, { "case": "ssh", - "type": "563" + "type": "571" }, { "case": "vdi", - "type": "564" + "type": "572" }, { "case": "vhdx", - "type": "565" + "type": "573" }, { "case": "vmdk", - "type": "566" + "type": "574" }, { "case": "vpc", - "type": "567" + "type": "575" }, { "case": "blkdebug", @@ -10942,22 +11015,22 @@ "members": [ { "name": "driver", - "type": "295" + "type": "299" } ], "meta-type": "object" }, { - "name": "334", + "name": "338", "tag": "driver", "variants": [ { "case": "luks", - "type": "568" + "type": "576" }, { "case": "qcow2", - "type": "569" + "type": "577" }, { "case": "blkdebug", @@ -11143,13 +11216,13 @@ "members": [ { "name": "driver", - "type": "295" + "type": "299" } ], "meta-type": "object" }, { - "name": "335", + "name": "339", "members": [ { "name": "read" @@ -11165,7 +11238,7 @@ ] }, { - "name": "336", + "name": "340", "members": [ { "name": "ignore" @@ -11185,7 +11258,7 @@ ] }, { - "name": "337", + "name": "341", "members": [ { "name": "commit" @@ -11229,7 +11302,7 @@ ] }, { - "name": "338", + "name": "342", "members": [ { "type": "str" @@ -11241,7 +11314,7 @@ "meta-type": "alternate" }, { - "name": "339", + "name": "343", "members": [ { "name": "read" @@ -11261,36 +11334,36 @@ ] }, { - "name": "340", + "name": "344", "tag": "type", "variants": [ { "case": "inet", - "type": "571" + "type": "579" }, { "case": "unix", - "type": "572" + "type": "580" }, { "case": "vsock", - "type": "573" + "type": "581" }, { "case": "fd", - "type": "574" + "type": "582" } ], "members": [ { "name": "type", - "type": "570" + "type": "578" } ], "meta-type": "object" }, { - "name": "341", + "name": "345", "members": [ { "name": "safe" @@ -11306,7 +11379,7 @@ ] }, { - "name": "342", + "name": "346", "members": [ { "name": "nbd" @@ -11330,7 +11403,7 @@ ] }, { - "name": "343", + "name": "347", "members": [ { "name": "name", @@ -11345,7 +11418,7 @@ { "name": "bitmaps", "default": null, - "type": "[294]" + "type": "[298]" }, { "name": "allocation-depth", @@ -11356,11 +11429,11 @@ "meta-type": "object" }, { - "name": "344", + "name": "348", "members": [ { "name": "addr", - "type": "369" + "type": "373" }, { "name": "logical-block-size", @@ -11376,7 +11449,7 @@ "meta-type": "object" }, { - "name": "345", + "name": "349", "members": [ { "name": "mountpoint", @@ -11390,13 +11463,13 @@ { "name": "allow-other", "default": null, - "type": "575" + "type": "583" } ], "meta-type": "object" }, { - "name": "346", + "name": "350", "members": [ { "name": "name", @@ -11426,7 +11499,7 @@ "meta-type": "object" }, { - "name": "347", + "name": "351", "members": [ { "name": "utf8" @@ -11442,108 +11515,108 @@ ] }, { - "name": "348", + "name": "352", "tag": "type", "variants": [ { "case": "file", - "type": "577" + "type": "585" }, { "case": "serial", - "type": "578" + "type": "586" }, { "case": "parallel", - "type": "578" + "type": "586" }, { "case": "pipe", - "type": "578" + "type": "586" }, { "case": "socket", - "type": "579" + "type": "587" }, { "case": "udp", - "type": "580" + "type": "588" }, { "case": "pty", - "type": "581" + "type": "589" }, { "case": "null", - "type": "581" + "type": "589" }, { "case": "mux", - "type": "582" + "type": "590" }, { "case": "msmouse", - "type": "581" + "type": "589" }, { "case": "wctablet", - "type": "581" + "type": "589" }, { "case": "braille", - "type": "581" + "type": "589" }, { "case": "testdev", - "type": "581" + "type": "589" }, { "case": "stdio", - "type": "583" + "type": "591" }, { "case": "console", - "type": "581" + "type": "589" }, { "case": "spicevmc", - "type": "584" + "type": "592" }, { "case": "spiceport", - "type": "585" + "type": "593" }, { "case": "qemu-vdagent", - "type": "586" + "type": "594" }, { "case": "dbus", - "type": "587" + "type": "595" }, { "case": "vc", - "type": "588" + "type": "596" }, { "case": "ringbuf", - "type": "589" + "type": "597" }, { "case": "memory", - "type": "589" + "type": "597" } ], "members": [ { "name": "type", - "type": "576" + "type": "584" } ], "meta-type": "object" }, { - "name": "349", + "name": "353", "members": [ { "name": "elf" @@ -11571,7 +11644,7 @@ ] }, { - "name": "350", + "name": "354", "members": [ { "name": "none" @@ -11595,12 +11668,12 @@ ] }, { - "name": "[349]", - "element-type": "349", + "name": "[353]", + "element-type": "353", "meta-type": "array" }, { - "name": "351", + "name": "355", "members": [ { "name": "none" @@ -11664,7 +11737,7 @@ ] }, { - "name": "352", + "name": "356", "members": [ { "name": "netdev", @@ -11695,7 +11768,7 @@ "meta-type": "object" }, { - "name": "353", + "name": "357", "members": [ { "name": "hostname", @@ -11755,7 +11828,7 @@ { "name": "dnssearch", "default": null, - "type": "[590]" + "type": "[598]" }, { "name": "domainname", @@ -11795,12 +11868,12 @@ { "name": "hostfwd", "default": null, - "type": "[590]" + "type": "[598]" }, { "name": "guestfwd", "default": null, - "type": "[590]" + "type": "[598]" }, { "name": "tftp-server-name", @@ -11811,7 +11884,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "358", "members": [ { "name": "ifname", @@ -11892,7 +11965,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "359", "members": [ { "name": "src", @@ -11965,7 +12038,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "360", "members": [ { "name": "fd", @@ -12001,11 +12074,11 @@ "meta-type": "object" }, { - "name": "357", + "name": "361", "members": [ { "name": "addr", - "type": "369" + "type": "373" }, { "name": "server", @@ -12021,23 +12094,23 @@ "meta-type": "object" }, { - "name": "358", + "name": "362", "members": [ { "name": "local", "default": null, - "type": "369" + "type": "373" }, { "name": "remote", "default": null, - "type": "369" + "type": "373" } ], "meta-type": "object" }, { - "name": "359", + "name": "363", "members": [ { "name": "sock", @@ -12063,7 +12136,7 @@ "meta-type": "object" }, { - "name": "360", + "name": "364", "members": [ { "name": "br", @@ -12079,7 +12152,7 @@ "meta-type": "object" }, { - "name": "361", + "name": "365", "members": [ { "name": "hubid", @@ -12094,7 +12167,7 @@ "meta-type": "object" }, { - "name": "362", + "name": "366", "members": [ { "name": "ifname", @@ -12109,7 +12182,7 @@ "meta-type": "object" }, { - "name": "363", + "name": "367", "members": [ { "name": "chardev", @@ -12129,7 +12202,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "368", "members": [ { "name": "vhostdev", @@ -12158,7 +12231,7 @@ "meta-type": "object" }, { - "name": "368", + "name": "372", "members": [ { "name": "normal" @@ -12183,36 +12256,36 @@ "meta-type": "array" }, { - "name": "369", + "name": "373", "tag": "type", "variants": [ { "case": "inet", - "type": "552" + "type": "560" }, { "case": "unix", - "type": "591" + "type": "599" }, { "case": "vsock", - "type": "592" + "type": "600" }, { "case": "fd", - "type": "590" + "type": "598" } ], "members": [ { "name": "type", - "type": "570" + "type": "578" } ], "meta-type": "object" }, { - "name": "370", + "name": "374", "members": [ { "name": "half" @@ -12228,7 +12301,7 @@ ] }, { - "name": "371", + "name": "375", "members": [ { "name": "off" @@ -12244,7 +12317,7 @@ ] }, { - "name": "372", + "name": "376", "members": [ { "name": "priority", @@ -12303,7 +12376,7 @@ "meta-type": "object" }, { - "name": "373", + "name": "377", "members": [ { "name": "in-pport", @@ -12344,7 +12417,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "378", "members": [ { "name": "goto-tbl", @@ -12380,16 +12453,16 @@ "meta-type": "object" }, { - "name": "375", + "name": "379", "tag": "type", "variants": [ { "case": "passthrough", - "type": "593" + "type": "601" }, { "case": "emulator", - "type": "594" + "type": "602" } ], "members": [ @@ -12401,7 +12474,7 @@ "meta-type": "object" }, { - "name": "376", + "name": "380", "members": [ { "name": "vnc" @@ -12417,7 +12490,7 @@ ] }, { - "name": "377", + "name": "381", "members": [ { "name": "keep" @@ -12437,7 +12510,7 @@ ] }, { - "name": "378", + "name": "382", "members": [ { "name": "display", @@ -12448,7 +12521,7 @@ "meta-type": "object" }, { - "name": "379", + "name": "383", "members": [ { "name": "display", @@ -12459,7 +12532,7 @@ "meta-type": "object" }, { - "name": "380", + "name": "384", "members": [ { "name": "ppm" @@ -12475,7 +12548,7 @@ ] }, { - "name": "381", + "name": "385", "members": [ { "name": "client" @@ -12495,12 +12568,12 @@ ] }, { - "name": "[382]", - "element-type": "382", + "name": "[386]", + "element-type": "386", "meta-type": "array" }, { - "name": "382", + "name": "386", "members": [ { "name": "host", @@ -12512,7 +12585,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "connection-id", @@ -12534,7 +12607,7 @@ "meta-type": "object" }, { - "name": "383", + "name": "387", "members": [ { "name": "host", @@ -12546,13 +12619,13 @@ }, { "name": "family", - "type": "385" + "type": "389" } ], "meta-type": "object" }, { - "name": "384", + "name": "388", "members": [ { "name": "host", @@ -12564,7 +12637,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "auth", @@ -12575,7 +12648,7 @@ "meta-type": "object" }, { - "name": "385", + "name": "389", "members": [ { "name": "ipv4" @@ -12603,12 +12676,12 @@ ] }, { - "name": "[386]", - "element-type": "386", + "name": "[390]", + "element-type": "390", "meta-type": "array" }, { - "name": "386", + "name": "390", "members": [ { "name": "host", @@ -12620,7 +12693,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "websocket", @@ -12640,12 +12713,12 @@ "meta-type": "object" }, { - "name": "[387]", - "element-type": "387", + "name": "[391]", + "element-type": "391", "meta-type": "array" }, { - "name": "387", + "name": "391", "members": [ { "name": "host", @@ -12657,7 +12730,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "websocket", @@ -12665,18 +12738,18 @@ }, { "name": "auth", - "type": "388" + "type": "392" }, { "name": "vencrypt", "default": null, - "type": "389" + "type": "393" } ], "meta-type": "object" }, { - "name": "388", + "name": "392", "members": [ { "name": "none" @@ -12720,7 +12793,7 @@ ] }, { - "name": "389", + "name": "393", "members": [ { "name": "plain" @@ -12764,7 +12837,7 @@ ] }, { - "name": "390", + "name": "394", "members": [ { "name": "host", @@ -12776,7 +12849,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "websocket", @@ -12791,7 +12864,7 @@ "meta-type": "object" }, { - "name": "391", + "name": "395", "members": [ { "name": "host", @@ -12803,7 +12876,7 @@ }, { "name": "family", - "type": "385" + "type": "389" }, { "name": "websocket", @@ -12813,67 +12886,67 @@ "meta-type": "object" }, { - "name": "[392]", - "element-type": "392", + "name": "[396]", + "element-type": "396", "meta-type": "array" }, { - "name": "392", + "name": "396", "tag": "type", "variants": [ { "case": "number", - "type": "596" + "type": "604" }, { "case": "qcode", - "type": "597" + "type": "605" } ], "members": [ { "name": "type", - "type": "595" + "type": "603" } ], "meta-type": "object" }, { - "name": "[393]", - "element-type": "393", + "name": "[397]", + "element-type": "397", "meta-type": "array" }, { - "name": "393", + "name": "397", "tag": "type", "variants": [ { "case": "key", - "type": "599" + "type": "607" }, { "case": "btn", - "type": "600" + "type": "608" }, { "case": "rel", - "type": "601" + "type": "609" }, { "case": "abs", - "type": "601" + "type": "609" } ], "members": [ { "name": "type", - "type": "598" + "type": "606" } ], "meta-type": "object" }, { - "name": "394", + "name": "398", "members": [ { "name": "default" @@ -12909,7 +12982,7 @@ ] }, { - "name": "395", + "name": "399", "members": [ { "name": "off" @@ -12933,7 +13006,7 @@ ] }, { - "name": "396", + "name": "400", "members": [ { "name": "grab-on-hover", @@ -12959,7 +13032,7 @@ "meta-type": "object" }, { - "name": "397", + "name": "401", "members": [ { "name": "left-command-key", @@ -12980,7 +13053,7 @@ "meta-type": "object" }, { - "name": "398", + "name": "402", "members": [ { "name": "charset", @@ -12991,7 +13064,7 @@ "meta-type": "object" }, { - "name": "399", + "name": "403", "members": [ { "name": "rendernode", @@ -13002,7 +13075,7 @@ "meta-type": "object" }, { - "name": "400", + "name": "404", "members": [ { "name": "rendernode", @@ -13028,18 +13101,18 @@ "meta-type": "object" }, { - "name": "401", + "name": "405", "members": [ { "name": "grab-mod", "default": null, - "type": "602" + "type": "610" } ], "meta-type": "object" }, { - "name": "402", + "name": "406", "members": [ { "name": "vnc" @@ -13051,7 +13124,7 @@ ] }, { - "name": "403", + "name": "407", "members": [ { "name": "tls-certs", @@ -13062,7 +13135,7 @@ "meta-type": "object" }, { - "name": "404", + "name": "408", "members": [ { "name": "vnc" @@ -13074,18 +13147,18 @@ ] }, { - "name": "405", + "name": "409", "members": [ { "name": "addresses", "default": null, - "type": "[369]" + "type": "[373]" } ], "meta-type": "object" }, { - "name": "406", + "name": "410", "members": [ { "name": "none" @@ -13149,7 +13222,7 @@ ] }, { - "name": "407", + "name": "411", "members": [ { "name": "transferred", @@ -13227,7 +13300,7 @@ "meta-type": "object" }, { - "name": "408", + "name": "412", "members": [ { "name": "transferred", @@ -13237,7 +13310,7 @@ "meta-type": "object" }, { - "name": "409", + "name": "413", "members": [ { "name": "cache-size", @@ -13271,7 +13344,7 @@ "meta-type": "object" }, { - "name": "410", + "name": "414", "members": [ { "name": "pages", @@ -13297,12 +13370,12 @@ "meta-type": "object" }, { - "name": "[369]", - "element-type": "369", + "name": "[373]", + "element-type": "373", "meta-type": "array" }, { - "name": "411", + "name": "415", "members": [ { "name": "xbzrle" @@ -13400,7 +13473,7 @@ ] }, { - "name": "412", + "name": "416", "members": [ { "name": "none" @@ -13420,12 +13493,12 @@ ] }, { - "name": "[413]", - "element-type": "413", + "name": "[417]", + "element-type": "417", "meta-type": "array" }, { - "name": "413", + "name": "417", "members": [ { "name": "node-name", @@ -13437,13 +13510,13 @@ }, { "name": "bitmaps", - "type": "[603]" + "type": "[611]" } ], "meta-type": "object" }, { - "name": "414", + "name": "418", "members": [ { "name": "none" @@ -13463,7 +13536,7 @@ ] }, { - "name": "415", + "name": "419", "members": [ { "name": "none" @@ -13487,7 +13560,7 @@ ] }, { - "name": "416", + "name": "420", "members": [ { "name": "page-sampling" @@ -13507,7 +13580,7 @@ ] }, { - "name": "417", + "name": "421", "members": [ { "name": "unstarted" @@ -13527,12 +13600,12 @@ ] }, { - "name": "[418]", - "element-type": "418", + "name": "[422]", + "element-type": "422", "meta-type": "array" }, { - "name": "418", + "name": "422", "members": [ { "name": "id", @@ -13546,84 +13619,84 @@ "meta-type": "object" }, { - "name": "[419]", - "element-type": "419", + "name": "[423]", + "element-type": "423", "meta-type": "array" }, { - "name": "419", + "name": "423", "tag": "type", "variants": [ { "case": "abort", - "type": "605" + "type": "613" }, { "case": "block-dirty-bitmap-add", - "type": "606" + "type": "614" }, { "case": "block-dirty-bitmap-remove", - "type": "607" + "type": "615" }, { "case": "block-dirty-bitmap-clear", - "type": "607" + "type": "615" }, { "case": "block-dirty-bitmap-enable", - "type": "607" + "type": "615" }, { "case": "block-dirty-bitmap-disable", - "type": "607" + "type": "615" }, { "case": "block-dirty-bitmap-merge", - "type": "608" + "type": "616" }, { "case": "blockdev-backup", - "type": "609" + "type": "617" }, { "case": "blockdev-snapshot", - "type": "610" + "type": "618" }, { "case": "blockdev-snapshot-internal-sync", - "type": "611" + "type": "619" }, { "case": "blockdev-snapshot-sync", - "type": "612" + "type": "620" }, { "case": "drive-backup", - "type": "613" + "type": "621" } ], "members": [ { "name": "type", - "type": "604" + "type": "612" } ], "meta-type": "object" }, { - "name": "420", + "name": "424", "members": [ { "name": "completion-mode", "default": null, - "type": "614" + "type": "622" } ], "meta-type": "object" }, { - "name": "421", + "name": "425", "members": [ { "name": "unavailable" @@ -13643,12 +13716,12 @@ ] }, { - "name": "[422]", - "element-type": "422", + "name": "[426]", + "element-type": "426", "meta-type": "array" }, { - "name": "422", + "name": "426", "members": [ { "name": "oob" @@ -13660,7 +13733,7 @@ ] }, { - "name": "423", + "name": "427", "members": [ { "name": "major", @@ -13678,7 +13751,7 @@ "meta-type": "object" }, { - "name": "424", + "name": "428", "members": [ { "name": "builtin" @@ -13714,21 +13787,21 @@ ] }, { - "name": "425", + "name": "429", "members": [ { "name": "json-type", - "type": "615" + "type": "623" } ], "meta-type": "object" }, { - "name": "426", + "name": "430", "members": [ { "name": "members", - "type": "[616]" + "type": "[624]" }, { "name": "values", @@ -13741,7 +13814,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "431", "members": [ { "name": "element-type", @@ -13751,11 +13824,11 @@ "meta-type": "object" }, { - "name": "428", + "name": "432", "members": [ { "name": "members", - "type": "[617]" + "type": "[625]" }, { "name": "tag", @@ -13765,23 +13838,23 @@ { "name": "variants", "default": null, - "type": "[618]" + "type": "[626]" } ], "meta-type": "object" }, { - "name": "429", + "name": "433", "members": [ { "name": "members", - "type": "[619]" + "type": "[627]" } ], "meta-type": "object" }, { - "name": "430", + "name": "434", "members": [ { "name": "arg-type", @@ -13800,7 +13873,7 @@ "meta-type": "object" }, { - "name": "431", + "name": "435", "members": [ { "name": "arg-type", @@ -13810,7 +13883,7 @@ "meta-type": "object" }, { - "name": "432", + "name": "436", "members": [ { "name": "authz-list" @@ -14000,23 +14073,23 @@ ] }, { - "name": "433", + "name": "437", "members": [ { "name": "policy", "default": null, - "type": "620" + "type": "628" }, { "name": "rules", "default": null, - "type": "[621]" + "type": "[629]" } ], "meta-type": "object" }, { - "name": "434", + "name": "438", "members": [ { "name": "filename", @@ -14031,7 +14104,7 @@ "meta-type": "object" }, { - "name": "435", + "name": "439", "members": [ { "name": "service", @@ -14041,7 +14114,7 @@ "meta-type": "object" }, { - "name": "436", + "name": "440", "members": [ { "name": "identity", @@ -14051,7 +14124,7 @@ "meta-type": "object" }, { - "name": "437", + "name": "441", "members": [ { "name": "if", @@ -14065,7 +14138,7 @@ "meta-type": "object" }, { - "name": "438", + "name": "442", "members": [ { "name": "primary_in", @@ -14112,24 +14185,44 @@ "meta-type": "object" }, { - "name": "439", + "name": "443", "members": [ { "name": "queues", "default": null, "type": "int" + }, + { + "name": "throttle-bps", + "default": null, + "type": "int" + }, + { + "name": "throttle-ops", + "default": null, + "type": "int" } ], "meta-type": "object" }, { - "name": "440", + "name": "444", "members": [ { "name": "queues", "default": null, "type": "int" }, + { + "name": "throttle-bps", + "default": null, + "type": "int" + }, + { + "name": "throttle-ops", + "default": null, + "type": "int" + }, { "name": "chardev", "type": "str" @@ -14138,7 +14231,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "445", "members": [ { "name": "addr", @@ -14153,7 +14246,7 @@ "meta-type": "object" }, { - "name": "442", + "name": "446", "members": [ { "name": "netdev", @@ -14162,7 +14255,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14177,7 +14270,7 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" }, { "name": "interval", @@ -14187,7 +14280,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "447", "members": [ { "name": "netdev", @@ -14196,7 +14289,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14211,7 +14304,7 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" }, { "name": "file", @@ -14226,7 +14319,7 @@ "meta-type": "object" }, { - "name": "444", + "name": "448", "members": [ { "name": "netdev", @@ -14235,7 +14328,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14250,7 +14343,7 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" }, { "name": "outdev", @@ -14265,7 +14358,7 @@ "meta-type": "object" }, { - "name": "445", + "name": "449", "members": [ { "name": "netdev", @@ -14274,7 +14367,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14289,7 +14382,7 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" }, { "name": "indev", @@ -14310,7 +14403,7 @@ "meta-type": "object" }, { - "name": "446", + "name": "450", "members": [ { "name": "netdev", @@ -14319,7 +14412,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14334,13 +14427,13 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" } ], "meta-type": "object" }, { - "name": "447", + "name": "451", "members": [ { "name": "netdev", @@ -14349,7 +14442,7 @@ { "name": "queue", "default": null, - "type": "622" + "type": "630" }, { "name": "status", @@ -14364,7 +14457,7 @@ { "name": "insert", "default": null, - "type": "623" + "type": "631" }, { "name": "vnet_hdr_support", @@ -14375,7 +14468,7 @@ "meta-type": "object" }, { - "name": "448", + "name": "452", "members": [ { "name": "name", @@ -14415,7 +14508,7 @@ "meta-type": "object" }, { - "name": "449", + "name": "453", "members": [ { "name": "evdev", @@ -14434,13 +14527,13 @@ { "name": "grab-toggle", "default": null, - "type": "624" + "type": "632" } ], "meta-type": "object" }, { - "name": "450", + "name": "454", "members": [ { "name": "aio-max-batch", @@ -14476,7 +14569,7 @@ "meta-type": "object" }, { - "name": "451", + "name": "455", "members": [ { "name": "aio-max-batch", @@ -14497,7 +14590,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "456", "members": [ { "name": "dump", @@ -14517,7 +14610,7 @@ { "name": "policy", "default": null, - "type": "475" + "type": "479" }, { "name": "prealloc", @@ -14557,7 +14650,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "457", "members": [ { "name": "dump", @@ -14577,7 +14670,7 @@ { "name": "policy", "default": null, - "type": "475" + "type": "479" }, { "name": "prealloc", @@ -14641,7 +14734,7 @@ "meta-type": "object" }, { - "name": "454", + "name": "458", "members": [ { "name": "dump", @@ -14661,7 +14754,7 @@ { "name": "policy", "default": null, - "type": "475" + "type": "479" }, { "name": "prealloc", @@ -14716,7 +14809,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "459", "members": [ { "name": "dump", @@ -14736,7 +14829,7 @@ { "name": "policy", "default": null, - "type": "475" + "type": "479" }, { "name": "prealloc", @@ -14776,7 +14869,7 @@ "meta-type": "object" }, { - "name": "456", + "name": "460", "members": [ { "name": "path", @@ -14786,7 +14879,7 @@ "meta-type": "object" }, { - "name": "457", + "name": "461", "members": [ { "name": "chardev", @@ -14801,7 +14894,7 @@ "meta-type": "object" }, { - "name": "458", + "name": "462", "members": [ { "name": "opened", @@ -14815,7 +14908,7 @@ "meta-type": "object" }, { - "name": "459", + "name": "463", "members": [ { "name": "opened", @@ -14833,7 +14926,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "464", "members": [ { "name": "opened", @@ -14852,7 +14945,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "465", "members": [ { "name": "loaded", @@ -14865,7 +14958,7 @@ { "name": "format", "default": null, - "type": "625" + "type": "633" }, { "name": "keyid", @@ -14891,7 +14984,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "466", "members": [ { "name": "loaded", @@ -14904,7 +14997,7 @@ { "name": "format", "default": null, - "type": "625" + "type": "633" }, { "name": "keyid", @@ -14924,7 +15017,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "467", "members": [ { "name": "sev-device", @@ -14969,7 +15062,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "468", "members": [ { "name": "cpu-affinity", @@ -14985,12 +15078,12 @@ "meta-type": "object" }, { - "name": "465", + "name": "469", "members": [ { "name": "limits", "default": null, - "type": "626" + "type": "634" }, { "name": "x-iops-total", @@ -15148,7 +15241,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "470", "members": [ { "name": "verify-peer", @@ -15163,7 +15256,7 @@ { "name": "endpoint", "default": null, - "type": "627" + "type": "635" }, { "name": "priority", @@ -15182,7 +15275,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "471", "members": [ { "name": "verify-peer", @@ -15197,7 +15290,7 @@ { "name": "endpoint", "default": null, - "type": "627" + "type": "635" }, { "name": "priority", @@ -15221,7 +15314,7 @@ "meta-type": "object" }, { - "name": "468", + "name": "472", "members": [ { "name": "verify-peer", @@ -15236,7 +15329,7 @@ { "name": "endpoint", "default": null, - "type": "627" + "type": "635" }, { "name": "priority", @@ -15265,7 +15358,7 @@ "meta-type": "object" }, { - "name": "469", + "name": "473", "members": [ { "name": "verify-peer", @@ -15280,7 +15373,7 @@ { "name": "endpoint", "default": null, - "type": "627" + "type": "635" }, { "name": "priority", @@ -15291,7 +15384,7 @@ "meta-type": "object" }, { - "name": "470", + "name": "474", "members": [ { "name": "fd", @@ -15305,11 +15398,11 @@ "meta-type": "object" }, { - "name": "471", + "name": "475", "members": [ { "name": "socket", - "type": "369" + "type": "373" }, { "name": "device", @@ -15319,7 +15412,7 @@ "meta-type": "object" }, { - "name": "472", + "name": "476", "members": [ { "name": "node-id", @@ -15355,7 +15448,7 @@ "meta-type": "object" }, { - "name": "473", + "name": "477", "members": [ { "name": "aarch64" @@ -15487,17 +15580,17 @@ ] }, { - "name": "474", + "name": "478", "members": [ { "name": "cpu-state", - "type": "628" + "type": "636" } ], "meta-type": "object" }, { - "name": "475", + "name": "479", "members": [ { "name": "default" @@ -15521,7 +15614,7 @@ ] }, { - "name": "476", + "name": "480", "members": [ { "name": "node" @@ -15549,7 +15642,7 @@ ] }, { - "name": "477", + "name": "481", "members": [ { "name": "nodeid", @@ -15580,7 +15673,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "482", "members": [ { "name": "src", @@ -15598,7 +15691,7 @@ "meta-type": "object" }, { - "name": "479", + "name": "483", "members": [ { "name": "node-id", @@ -15634,7 +15727,7 @@ "meta-type": "object" }, { - "name": "480", + "name": "484", "members": [ { "name": "initiator", @@ -15646,11 +15739,11 @@ }, { "name": "hierarchy", - "type": "629" + "type": "637" }, { "name": "data-type", - "type": "630" + "type": "638" }, { "name": "latency", @@ -15666,7 +15759,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "485", "members": [ { "name": "node-id", @@ -15682,11 +15775,11 @@ }, { "name": "associativity", - "type": "631" + "type": "639" }, { "name": "policy", - "type": "632" + "type": "640" }, { "name": "line", @@ -15696,7 +15789,7 @@ "meta-type": "object" }, { - "name": "482", + "name": "486", "members": [ { "name": "dimm" @@ -15724,47 +15817,47 @@ ] }, { - "name": "483", + "name": "487", "members": [ { "name": "data", - "type": "633" + "type": "641" } ], "meta-type": "object" }, { - "name": "484", + "name": "488", "members": [ { "name": "data", - "type": "634" + "type": "642" } ], "meta-type": "object" }, { - "name": "485", + "name": "489", "members": [ { "name": "data", - "type": "635" + "type": "643" } ], "meta-type": "object" }, { - "name": "486", + "name": "490", "members": [ { "name": "data", - "type": "636" + "type": "644" } ], "meta-type": "object" }, { - "name": "487", + "name": "491", "members": [ { "name": "name", @@ -15779,7 +15872,7 @@ "meta-type": "object" }, { - "name": "488", + "name": "492", "members": [ { "name": "incompatible" @@ -15803,7 +15896,7 @@ ] }, { - "name": "489", + "name": "493", "members": [ { "name": "static" @@ -15819,7 +15912,7 @@ ] }, { - "name": "490", + "name": "494", "members": [ { "name": "none" @@ -15839,7 +15932,7 @@ ] }, { - "name": "491", + "name": "495", "members": [ { "name": "block-node" @@ -15859,7 +15952,7 @@ ] }, { - "name": "492", + "name": "496", "members": [ { "name": "node-name", @@ -15869,7 +15962,7 @@ "meta-type": "object" }, { - "name": "493", + "name": "497", "members": [ { "name": "id", @@ -15879,12 +15972,12 @@ "meta-type": "object" }, { - "name": "[494]", - "element-type": "494", + "name": "[498]", + "element-type": "498", "meta-type": "array" }, { - "name": "494", + "name": "498", "members": [ { "name": "fd", @@ -15899,12 +15992,12 @@ "meta-type": "object" }, { - "name": "[495]", - "element-type": "495", + "name": "[499]", + "element-type": "499", "meta-type": "array" }, { - "name": "495", + "name": "499", "members": [ { "name": "name", @@ -15912,7 +16005,7 @@ }, { "name": "type", - "type": "637" + "type": "645" }, { "name": "help", @@ -15928,7 +16021,7 @@ "meta-type": "object" }, { - "name": "496", + "name": "500", "members": [ { "name": "uninit" @@ -15960,12 +16053,12 @@ ] }, { - "name": "[497]", - "element-type": "497", + "name": "[501]", + "element-type": "501", "meta-type": "array" }, { - "name": "497", + "name": "501", "members": [ { "name": "node", @@ -15979,7 +16072,7 @@ "meta-type": "object" }, { - "name": "498", + "name": "502", "members": [ { "name": "closed" @@ -16011,7 +16104,7 @@ ] }, { - "name": "499", + "name": "503", "members": [ { "name": "none" @@ -16051,33 +16144,33 @@ ] }, { - "name": "500", + "name": "504", "members": [ { "name": "in", "default": null, - "type": "638" + "type": "646" }, { "name": "out", "default": null, - "type": "638" + "type": "646" } ], "meta-type": "object" }, { - "name": "501", + "name": "505", "members": [ { "name": "in", "default": null, - "type": "639" + "type": "647" }, { "name": "out", "default": null, - "type": "639" + "type": "647" }, { "name": "threshold", @@ -16088,33 +16181,33 @@ "meta-type": "object" }, { - "name": "502", + "name": "506", "members": [ { "name": "in", "default": null, - "type": "640" + "type": "648" }, { "name": "out", "default": null, - "type": "640" + "type": "648" } ], "meta-type": "object" }, { - "name": "503", + "name": "507", "members": [ { "name": "in", "default": null, - "type": "638" + "type": "646" }, { "name": "out", "default": null, - "type": "638" + "type": "646" }, { "name": "latency", @@ -16125,33 +16218,33 @@ "meta-type": "object" }, { - "name": "504", + "name": "508", "members": [ { "name": "in", "default": null, - "type": "641" + "type": "649" }, { "name": "out", "default": null, - "type": "641" + "type": "649" } ], "meta-type": "object" }, { - "name": "505", + "name": "509", "members": [ { "name": "in", "default": null, - "type": "642" + "type": "650" }, { "name": "out", "default": null, - "type": "642" + "type": "650" }, { "name": "try-mmap", @@ -16172,17 +16265,17 @@ "meta-type": "object" }, { - "name": "506", + "name": "510", "members": [ { "name": "in", "default": null, - "type": "643" + "type": "651" }, { "name": "out", "default": null, - "type": "643" + "type": "651" }, { "name": "server", @@ -16193,33 +16286,33 @@ "meta-type": "object" }, { - "name": "507", + "name": "511", "members": [ { "name": "in", "default": null, - "type": "644" + "type": "652" }, { "name": "out", "default": null, - "type": "644" + "type": "652" } ], "meta-type": "object" }, { - "name": "508", + "name": "512", "members": [ { "name": "in", "default": null, - "type": "638" + "type": "646" }, { "name": "out", "default": null, - "type": "638" + "type": "646" }, { "name": "dev", @@ -16235,17 +16328,17 @@ "meta-type": "object" }, { - "name": "509", + "name": "513", "members": [ { "name": "in", "default": null, - "type": "638" + "type": "646" }, { "name": "out", "default": null, - "type": "638" + "type": "646" }, { "name": "path", @@ -16256,7 +16349,7 @@ "meta-type": "object" }, { - "name": "510", + "name": "514", "members": [ { "name": "DIMM" @@ -16272,12 +16365,12 @@ ] }, { - "name": "[511]", - "element-type": "511", + "name": "[515]", + "element-type": "515", "meta-type": "array" }, { - "name": "511", + "name": "515", "members": [ { "name": "bus", @@ -16293,11 +16386,11 @@ }, { "name": "class_info", - "type": "645" + "type": "653" }, { "name": "id", - "type": "646" + "type": "654" }, { "name": "irq", @@ -16315,42 +16408,46 @@ { "name": "pci_bridge", "default": null, - "type": "647" + "type": "655" }, { "name": "regions", - "type": "[648]" + "type": "[656]" } ], "meta-type": "object" }, { - "name": "512", + "name": "516", "members": [ { "name": "vm" }, { "name": "vcpu" + }, + { + "name": "cryptodev" } ], "meta-type": "enum", "values": [ "vm", - "vcpu" + "vcpu", + "cryptodev" ] }, { - "name": "[513]", - "element-type": "513", + "name": "[517]", + "element-type": "517", "meta-type": "array" }, { - "name": "513", + "name": "517", "members": [ { "name": "provider", - "type": "515" + "type": "519" }, { "name": "names", @@ -16361,7 +16458,7 @@ "meta-type": "object" }, { - "name": "514", + "name": "518", "members": [ { "name": "vcpus", @@ -16372,24 +16469,28 @@ "meta-type": "object" }, { - "name": "515", + "name": "519", "members": [ { "name": "kvm" + }, + { + "name": "cryptodev" } ], "meta-type": "enum", "values": [ - "kvm" + "kvm", + "cryptodev" ] }, { - "name": "[516]", - "element-type": "516", + "name": "[520]", + "element-type": "520", "meta-type": "array" }, { - "name": "516", + "name": "520", "members": [ { "name": "name", @@ -16397,18 +16498,18 @@ }, { "name": "value", - "type": "649" + "type": "657" } ], "meta-type": "object" }, { - "name": "[517]", - "element-type": "517", + "name": "[521]", + "element-type": "521", "meta-type": "array" }, { - "name": "517", + "name": "521", "members": [ { "name": "name", @@ -16416,12 +16517,12 @@ }, { "name": "type", - "type": "650" + "type": "658" }, { "name": "unit", "default": null, - "type": "651" + "type": "659" }, { "name": "base", @@ -16441,7 +16542,7 @@ "meta-type": "object" }, { - "name": "518", + "name": "522", "members": [ { "name": "transports", @@ -16461,7 +16562,7 @@ "meta-type": "object" }, { - "name": "519", + "name": "523", "members": [ { "name": "statuses", @@ -16476,7 +16577,7 @@ "meta-type": "object" }, { - "name": "520", + "name": "524", "members": [ { "name": "n-mem-sections", @@ -16496,19 +16597,19 @@ }, { "name": "features", - "type": "518" + "type": "522" }, { "name": "acked-features", - "type": "518" + "type": "522" }, { "name": "backend-features", - "type": "518" + "type": "522" }, { "name": "protocol-features", - "type": "652" + "type": "660" }, { "name": "max-queues", @@ -16530,12 +16631,12 @@ "meta-type": "object" }, { - "name": "[521]", - "element-type": "521", + "name": "[525]", + "element-type": "525", "meta-type": "array" }, { - "name": "521", + "name": "525", "members": [ { "name": "addr", @@ -16553,7 +16654,7 @@ "meta-type": "object" }, { - "name": "522", + "name": "526", "members": [ { "name": "flags", @@ -16571,7 +16672,7 @@ "meta-type": "object" }, { - "name": "523", + "name": "527", "members": [ { "name": "flags", @@ -16585,7 +16686,114 @@ "meta-type": "object" }, { - "name": "524", + "name": "[528]", + "element-type": "528", + "meta-type": "array" + }, + { + "name": "528", + "members": [ + { + "name": "cipher" + }, + { + "name": "hash" + }, + { + "name": "mac" + }, + { + "name": "aead" + }, + { + "name": "akcipher" + } + ], + "meta-type": "enum", + "values": [ + "cipher", + "hash", + "mac", + "aead", + "akcipher" + ] + }, + { + "name": "[529]", + "element-type": "529", + "meta-type": "array" + }, + { + "name": "529", + "members": [ + { + "name": "queue", + "type": "int" + }, + { + "name": "type", + "type": "661" + } + ], + "meta-type": "object" + }, + { + "name": "[530]", + "element-type": "530", + "meta-type": "array" + }, + { + "name": "530", + "members": [ + { + "name": "type", + "type": "662" + }, + { + "name": "header", + "type": "[int]" + } + ], + "meta-type": "object" + }, + { + "name": "531", + "members": [ + { + "name": "cache-data-ecc" + }, + { + "name": "mem-data-ecc" + }, + { + "name": "crc-threshold" + }, + { + "name": "retry-threshold" + }, + { + "name": "cache-poison-received" + }, + { + "name": "mem-poison-received" + }, + { + "name": "physical" + } + ], + "meta-type": "enum", + "values": [ + "cache-data-ecc", + "mem-data-ecc", + "crc-threshold", + "retry-threshold", + "cache-poison-received", + "mem-poison-received", + "physical" + ] + }, + { + "name": "532", "members": [ { "name": "hyper-v" @@ -16601,7 +16809,7 @@ ] }, { - "name": "525", + "name": "533", "members": [ { "name": "arg1", @@ -16627,7 +16835,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "534", "members": [ { "name": "core", @@ -16643,18 +16851,18 @@ }, { "name": "reason", - "type": "653" + "type": "663" } ], "meta-type": "object" }, { - "name": "[527]", - "element-type": "527", + "name": "[535]", + "element-type": "535", "meta-type": "array" }, { - "name": "527", + "name": "535", "members": [ { "name": "interval_length", @@ -16708,7 +16916,7 @@ "meta-type": "object" }, { - "name": "528", + "name": "536", "members": [ { "name": "boundaries", @@ -16722,7 +16930,7 @@ "meta-type": "object" }, { - "name": "529", + "name": "537", "members": [ { "name": "discard-nb-ok", @@ -16740,7 +16948,7 @@ "meta-type": "object" }, { - "name": "530", + "name": "538", "members": [ { "name": "completion-errors", @@ -16763,40 +16971,40 @@ "meta-type": "array" }, { - "name": "531", + "name": "539", "tag": "type", "variants": [ { "case": "qcow2", - "type": "655" + "type": "665" }, { "case": "vmdk", - "type": "656" + "type": "666" }, { "case": "luks", - "type": "657" + "type": "667" }, { "case": "rbd", - "type": "658" + "type": "668" }, { "case": "file", - "type": "659" + "type": "669" } ], "members": [ { "name": "type", - "type": "654" + "type": "664" } ], "meta-type": "object" }, { - "name": "532", + "name": "540", "members": [ { "name": "block-backend" @@ -16816,12 +17024,12 @@ ] }, { - "name": "[533]", - "element-type": "533", + "name": "[541]", + "element-type": "541", "meta-type": "array" }, { - "name": "533", + "name": "541", "members": [ { "name": "consistent-read" @@ -16845,7 +17053,7 @@ ] }, { - "name": "534", + "name": "542", "members": [ { "type": "49" @@ -16857,16 +17065,16 @@ "meta-type": "alternate" }, { - "name": "[535]", - "element-type": "535", + "name": "[543]", + "element-type": "543", "meta-type": "array" }, { - "name": "535", + "name": "543", "members": [ { "name": "event", - "type": "660" + "type": "670" }, { "name": "state", @@ -16876,7 +17084,7 @@ { "name": "iotype", "default": null, - "type": "661" + "type": "671" }, { "name": "errno", @@ -16902,16 +17110,16 @@ "meta-type": "object" }, { - "name": "[536]", - "element-type": "536", + "name": "[544]", + "element-type": "544", "meta-type": "array" }, { - "name": "536", + "name": "544", "members": [ { "name": "event", - "type": "660" + "type": "670" }, { "name": "state", @@ -16926,7 +17134,7 @@ "meta-type": "object" }, { - "name": "537", + "name": "545", "members": [ { "name": "break-guest-write" @@ -16942,7 +17150,7 @@ ] }, { - "name": "538", + "name": "546", "members": [ { "name": "auto" @@ -16962,7 +17170,7 @@ ] }, { - "name": "539", + "name": "547", "members": [ { "name": "threads" @@ -16982,7 +17190,7 @@ ] }, { - "name": "540", + "name": "548", "members": [ { "name": "tcp" @@ -16998,7 +17206,7 @@ ] }, { - "name": "541", + "name": "549", "members": [ { "name": "crc32c" @@ -17022,11 +17230,11 @@ ] }, { - "name": "542", + "name": "550", "members": [ { "name": "type", - "type": "662" + "type": "672" }, { "name": "host", @@ -17036,7 +17244,7 @@ "meta-type": "object" }, { - "name": "543", + "name": "551", "members": [ { "type": "49" @@ -17051,62 +17259,62 @@ "meta-type": "alternate" }, { - "name": "544", + "name": "552", "members": [ { - "type": "663" + "type": "673" }, { - "type": "664" + "type": "674" } ], "meta-type": "alternate" }, { - "name": "545", + "name": "553", "tag": "format", "variants": [ { "case": "aes", - "type": "666" + "type": "676" }, { "case": "luks", - "type": "667" + "type": "677" } ], "members": [ { "name": "format", - "type": "665" + "type": "675" } ], "meta-type": "object" }, { - "name": "546", + "name": "554", "tag": "format", "variants": [ { "case": "aes", - "type": "666" + "type": "676" } ], "members": [ { "name": "format", - "type": "668" + "type": "678" } ], "meta-type": "object" }, { - "name": "[534]", - "element-type": "534", + "name": "[542]", + "element-type": "542", "meta-type": "array" }, { - "name": "547", + "name": "555", "members": [ { "name": "quorum" @@ -17122,42 +17330,42 @@ ] }, { - "name": "548", + "name": "556", "tag": "format", "variants": [ { "case": "luks", - "type": "670" + "type": "680" }, { "case": "luks2", - "type": "671" + "type": "681" }, { "case": "luks-any", - "type": "672" + "type": "682" } ], "members": [ { "name": "format", - "type": "669" + "type": "679" }, { "name": "parent", "default": null, - "type": "548" + "type": "556" } ], "meta-type": "object" }, { - "name": "[549]", - "element-type": "549", + "name": "[557]", + "element-type": "557", "meta-type": "array" }, { - "name": "549", + "name": "557", "members": [ { "name": "cephx" @@ -17173,12 +17381,12 @@ ] }, { - "name": "[550]", - "element-type": "550", + "name": "[558]", + "element-type": "558", "meta-type": "array" }, { - "name": "550", + "name": "558", "members": [ { "name": "host", @@ -17192,7 +17400,7 @@ "meta-type": "object" }, { - "name": "551", + "name": "559", "members": [ { "name": "primary" @@ -17208,7 +17416,7 @@ ] }, { - "name": "552", + "name": "560", "members": [ { "name": "host", @@ -17252,12 +17460,12 @@ "meta-type": "object" }, { - "name": "553", + "name": "561", "tag": "mode", "variants": [ { "case": "hash", - "type": "674" + "type": "684" }, { "case": "none", @@ -17271,13 +17479,13 @@ "members": [ { "name": "mode", - "type": "673" + "type": "683" } ], "meta-type": "object" }, { - "name": "554", + "name": "562", "members": [ { "name": "filename", @@ -17290,7 +17498,7 @@ { "name": "preallocation", "default": null, - "type": "675" + "type": "685" }, { "name": "nocow", @@ -17306,11 +17514,11 @@ "meta-type": "object" }, { - "name": "555", + "name": "563", "members": [ { "name": "location", - "type": "308" + "type": "312" }, { "name": "size", @@ -17319,13 +17527,13 @@ { "name": "preallocation", "default": null, - "type": "675" + "type": "685" } ], "meta-type": "object" }, { - "name": "556", + "name": "564", "members": [ { "name": "key-secret", @@ -17335,27 +17543,27 @@ { "name": "cipher-alg", "default": null, - "type": "676" + "type": "686" }, { "name": "cipher-mode", "default": null, - "type": "677" + "type": "687" }, { "name": "ivgen-alg", "default": null, - "type": "678" + "type": "688" }, { "name": "ivgen-hash-alg", "default": null, - "type": "679" + "type": "689" }, { "name": "hash-alg", "default": null, - "type": "679" + "type": "689" }, { "name": "iter-time", @@ -17364,7 +17572,7 @@ }, { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17373,17 +17581,17 @@ { "name": "preallocation", "default": null, - "type": "675" + "type": "685" } ], "meta-type": "object" }, { - "name": "557", + "name": "565", "members": [ { "name": "location", - "type": "315" + "type": "319" }, { "name": "size", @@ -17393,11 +17601,11 @@ "meta-type": "object" }, { - "name": "558", + "name": "566", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17412,11 +17620,11 @@ "meta-type": "object" }, { - "name": "559", + "name": "567", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17430,22 +17638,22 @@ { "name": "encrypt", "default": null, - "type": "680" + "type": "690" } ], "meta-type": "object" }, { - "name": "560", + "name": "568", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "data-file", "default": null, - "type": "534" + "type": "542" }, { "name": "data-file-raw", @@ -17464,7 +17672,7 @@ { "name": "version", "default": null, - "type": "681" + "type": "691" }, { "name": "backing-file", @@ -17474,12 +17682,12 @@ { "name": "backing-fmt", "default": null, - "type": "295" + "type": "299" }, { "name": "encrypt", "default": null, - "type": "680" + "type": "690" }, { "name": "cluster-size", @@ -17489,7 +17697,7 @@ { "name": "preallocation", "default": null, - "type": "675" + "type": "685" }, { "name": "lazy-refcounts", @@ -17504,17 +17712,17 @@ { "name": "compression-type", "default": null, - "type": "682" + "type": "692" } ], "meta-type": "object" }, { - "name": "561", + "name": "569", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17528,7 +17736,7 @@ { "name": "backing-fmt", "default": null, - "type": "295" + "type": "299" }, { "name": "cluster-size", @@ -17544,11 +17752,11 @@ "meta-type": "object" }, { - "name": "562", + "name": "570", "members": [ { "name": "location", - "type": "325" + "type": "329" }, { "name": "size", @@ -17562,17 +17770,17 @@ { "name": "encrypt", "default": null, - "type": "683" + "type": "693" } ], "meta-type": "object" }, { - "name": "563", + "name": "571", "members": [ { "name": "location", - "type": "327" + "type": "331" }, { "name": "size", @@ -17582,11 +17790,11 @@ "meta-type": "object" }, { - "name": "564", + "name": "572", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17595,17 +17803,17 @@ { "name": "preallocation", "default": null, - "type": "675" + "type": "685" } ], "meta-type": "object" }, { - "name": "565", + "name": "573", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17624,7 +17832,7 @@ { "name": "subformat", "default": null, - "type": "684" + "type": "694" }, { "name": "block-state-zero", @@ -17635,11 +17843,11 @@ "meta-type": "object" }, { - "name": "566", + "name": "574", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17648,12 +17856,12 @@ { "name": "extents", "default": null, - "type": "[534]" + "type": "[542]" }, { "name": "subformat", "default": null, - "type": "685" + "type": "695" }, { "name": "backing-file", @@ -17663,7 +17871,7 @@ { "name": "adapter-type", "default": null, - "type": "686" + "type": "696" }, { "name": "hwversion", @@ -17684,11 +17892,11 @@ "meta-type": "object" }, { - "name": "567", + "name": "575", "members": [ { "name": "file", - "type": "534" + "type": "542" }, { "name": "size", @@ -17697,7 +17905,7 @@ { "name": "subformat", "default": null, - "type": "687" + "type": "697" }, { "name": "force-size", @@ -17708,11 +17916,11 @@ "meta-type": "object" }, { - "name": "568", + "name": "576", "members": [ { "name": "state", - "type": "688" + "type": "698" }, { "name": "new-secret", @@ -17743,12 +17951,12 @@ "meta-type": "object" }, { - "name": "569", + "name": "577", "members": [ { "name": "encrypt", "default": null, - "type": "689" + "type": "699" } ], "meta-type": "object" @@ -17759,7 +17967,7 @@ "meta-type": "builtin" }, { - "name": "570", + "name": "578", "members": [ { "name": "inet" @@ -17783,47 +17991,47 @@ ] }, { - "name": "571", + "name": "579", "members": [ { "name": "data", - "type": "552" + "type": "560" } ], "meta-type": "object" }, { - "name": "572", + "name": "580", "members": [ { "name": "data", - "type": "591" + "type": "599" } ], "meta-type": "object" }, { - "name": "573", + "name": "581", "members": [ { "name": "data", - "type": "592" + "type": "600" } ], "meta-type": "object" }, { - "name": "574", + "name": "582", "members": [ { "name": "data", - "type": "590" + "type": "598" } ], "meta-type": "object" }, { - "name": "575", + "name": "583", "members": [ { "name": "off" @@ -17843,7 +18051,7 @@ ] }, { - "name": "576", + "name": "584", "members": [ { "name": "file" @@ -17939,142 +18147,142 @@ ] }, { - "name": "577", + "name": "585", "members": [ { "name": "data", - "type": "690" + "type": "700" } ], "meta-type": "object" }, { - "name": "578", + "name": "586", "members": [ { "name": "data", - "type": "691" + "type": "701" } ], "meta-type": "object" }, { - "name": "579", + "name": "587", "members": [ { "name": "data", - "type": "692" + "type": "702" } ], "meta-type": "object" }, { - "name": "580", + "name": "588", "members": [ { "name": "data", - "type": "693" + "type": "703" } ], "meta-type": "object" }, { - "name": "581", + "name": "589", "members": [ { "name": "data", - "type": "694" + "type": "704" } ], "meta-type": "object" }, { - "name": "582", + "name": "590", "members": [ { "name": "data", - "type": "695" + "type": "705" } ], "meta-type": "object" }, { - "name": "583", + "name": "591", "members": [ { "name": "data", - "type": "696" + "type": "706" } ], "meta-type": "object" }, { - "name": "584", + "name": "592", "members": [ { "name": "data", - "type": "697" + "type": "707" } ], "meta-type": "object" }, { - "name": "585", + "name": "593", "members": [ { "name": "data", - "type": "698" + "type": "708" } ], "meta-type": "object" }, { - "name": "586", + "name": "594", "members": [ { "name": "data", - "type": "699" + "type": "709" } ], "meta-type": "object" }, { - "name": "587", + "name": "595", "members": [ { "name": "data", - "type": "700" + "type": "710" } ], "meta-type": "object" }, { - "name": "588", + "name": "596", "members": [ { "name": "data", - "type": "701" + "type": "711" } ], "meta-type": "object" }, { - "name": "589", + "name": "597", "members": [ { "name": "data", - "type": "702" + "type": "712" } ], "meta-type": "object" }, { - "name": "[590]", - "element-type": "590", + "name": "[598]", + "element-type": "598", "meta-type": "array" }, { - "name": "590", + "name": "598", "members": [ { "name": "str", @@ -18084,7 +18292,7 @@ "meta-type": "object" }, { - "name": "591", + "name": "599", "members": [ { "name": "path", @@ -18104,7 +18312,7 @@ "meta-type": "object" }, { - "name": "592", + "name": "600", "members": [ { "name": "cid", @@ -18118,27 +18326,27 @@ "meta-type": "object" }, { - "name": "593", + "name": "601", "members": [ { "name": "data", - "type": "703" + "type": "713" } ], "meta-type": "object" }, { - "name": "594", + "name": "602", "members": [ { "name": "data", - "type": "704" + "type": "714" } ], "meta-type": "object" }, { - "name": "595", + "name": "603", "members": [ { "name": "number" @@ -18154,7 +18362,7 @@ ] }, { - "name": "596", + "name": "604", "members": [ { "name": "data", @@ -18164,17 +18372,17 @@ "meta-type": "object" }, { - "name": "597", + "name": "605", "members": [ { "name": "data", - "type": "705" + "type": "715" } ], "meta-type": "object" }, { - "name": "598", + "name": "606", "members": [ { "name": "key" @@ -18198,37 +18406,37 @@ ] }, { - "name": "599", + "name": "607", "members": [ { "name": "data", - "type": "706" + "type": "716" } ], "meta-type": "object" }, { - "name": "600", + "name": "608", "members": [ { "name": "data", - "type": "707" + "type": "717" } ], "meta-type": "object" }, { - "name": "601", + "name": "609", "members": [ { "name": "data", - "type": "708" + "type": "718" } ], "meta-type": "object" }, { - "name": "602", + "name": "610", "members": [ { "name": "lctrl-lalt" @@ -18253,12 +18461,12 @@ "meta-type": "builtin" }, { - "name": "[603]", - "element-type": "603", + "name": "[611]", + "element-type": "611", "meta-type": "array" }, { - "name": "603", + "name": "611", "members": [ { "name": "name", @@ -18271,13 +18479,13 @@ { "name": "transform", "default": null, - "type": "709" + "type": "719" } ], "meta-type": "object" }, { - "name": "604", + "name": "612", "members": [ { "name": "abort" @@ -18336,17 +18544,17 @@ ] }, { - "name": "605", + "name": "613", "members": [ { "name": "data", - "type": "710" + "type": "720" } ], "meta-type": "object" }, { - "name": "606", + "name": "614", "members": [ { "name": "data", @@ -18356,7 +18564,7 @@ "meta-type": "object" }, { - "name": "607", + "name": "615", "members": [ { "name": "data", @@ -18366,7 +18574,7 @@ "meta-type": "object" }, { - "name": "608", + "name": "616", "members": [ { "name": "data", @@ -18376,7 +18584,7 @@ "meta-type": "object" }, { - "name": "609", + "name": "617", "members": [ { "name": "data", @@ -18386,7 +18594,7 @@ "meta-type": "object" }, { - "name": "610", + "name": "618", "members": [ { "name": "data", @@ -18396,7 +18604,7 @@ "meta-type": "object" }, { - "name": "611", + "name": "619", "members": [ { "name": "data", @@ -18406,7 +18614,7 @@ "meta-type": "object" }, { - "name": "612", + "name": "620", "members": [ { "name": "data", @@ -18416,7 +18624,7 @@ "meta-type": "object" }, { - "name": "613", + "name": "621", "members": [ { "name": "data", @@ -18426,7 +18634,7 @@ "meta-type": "object" }, { - "name": "614", + "name": "622", "members": [ { "name": "individual" @@ -18442,7 +18650,7 @@ ] }, { - "name": "615", + "name": "623", "members": [ { "name": "string" @@ -18482,12 +18690,12 @@ ] }, { - "name": "[616]", - "element-type": "616", + "name": "[624]", + "element-type": "624", "meta-type": "array" }, { - "name": "616", + "name": "624", "members": [ { "name": "name", @@ -18502,12 +18710,12 @@ "meta-type": "object" }, { - "name": "[617]", - "element-type": "617", + "name": "[625]", + "element-type": "625", "meta-type": "array" }, { - "name": "617", + "name": "625", "members": [ { "name": "name", @@ -18531,12 +18739,12 @@ "meta-type": "object" }, { - "name": "[618]", - "element-type": "618", + "name": "[626]", + "element-type": "626", "meta-type": "array" }, { - "name": "618", + "name": "626", "members": [ { "name": "case", @@ -18550,12 +18758,12 @@ "meta-type": "object" }, { - "name": "[619]", - "element-type": "619", + "name": "[627]", + "element-type": "627", "meta-type": "array" }, { - "name": "619", + "name": "627", "members": [ { "name": "type", @@ -18565,7 +18773,7 @@ "meta-type": "object" }, { - "name": "620", + "name": "628", "members": [ { "name": "deny" @@ -18581,12 +18789,12 @@ ] }, { - "name": "[621]", - "element-type": "621", + "name": "[629]", + "element-type": "629", "meta-type": "array" }, { - "name": "621", + "name": "629", "members": [ { "name": "match", @@ -18594,18 +18802,18 @@ }, { "name": "policy", - "type": "620" + "type": "628" }, { "name": "format", "default": null, - "type": "711" + "type": "721" } ], "meta-type": "object" }, { - "name": "622", + "name": "630", "members": [ { "name": "all" @@ -18625,7 +18833,7 @@ ] }, { - "name": "623", + "name": "631", "members": [ { "name": "before" @@ -18641,7 +18849,7 @@ ] }, { - "name": "624", + "name": "632", "members": [ { "name": "ctrl-ctrl" @@ -18673,7 +18881,7 @@ ] }, { - "name": "625", + "name": "633", "members": [ { "name": "raw" @@ -18689,7 +18897,7 @@ ] }, { - "name": "626", + "name": "634", "members": [ { "name": "iops-total", @@ -18790,7 +18998,7 @@ "meta-type": "object" }, { - "name": "627", + "name": "635", "members": [ { "name": "client" @@ -18806,7 +19014,7 @@ ] }, { - "name": "628", + "name": "636", "members": [ { "name": "uninitialized" @@ -18834,7 +19042,7 @@ ] }, { - "name": "629", + "name": "637", "members": [ { "name": "memory" @@ -18858,7 +19066,7 @@ ] }, { - "name": "630", + "name": "638", "members": [ { "name": "access-latency" @@ -18890,7 +19098,7 @@ ] }, { - "name": "631", + "name": "639", "members": [ { "name": "none" @@ -18910,7 +19118,7 @@ ] }, { - "name": "632", + "name": "640", "members": [ { "name": "none" @@ -18930,7 +19138,7 @@ ] }, { - "name": "633", + "name": "641", "members": [ { "name": "id", @@ -18969,7 +19177,7 @@ "meta-type": "object" }, { - "name": "634", + "name": "642", "members": [ { "name": "id", @@ -18992,7 +19200,7 @@ "meta-type": "object" }, { - "name": "635", + "name": "643", "members": [ { "name": "id", @@ -19031,7 +19239,7 @@ "meta-type": "object" }, { - "name": "636", + "name": "644", "members": [ { "name": "id", @@ -19058,7 +19266,7 @@ "meta-type": "object" }, { - "name": "637", + "name": "645", "members": [ { "name": "string" @@ -19082,7 +19290,7 @@ ] }, { - "name": "638", + "name": "646", "members": [ { "name": "mixing-engine", @@ -19112,7 +19320,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19123,7 +19331,7 @@ "meta-type": "object" }, { - "name": "639", + "name": "647", "members": [ { "name": "mixing-engine", @@ -19153,7 +19361,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19179,7 +19387,7 @@ "meta-type": "object" }, { - "name": "640", + "name": "648", "members": [ { "name": "mixing-engine", @@ -19209,7 +19417,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19225,7 +19433,7 @@ "meta-type": "object" }, { - "name": "641", + "name": "649", "members": [ { "name": "mixing-engine", @@ -19255,7 +19463,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19291,7 +19499,7 @@ "meta-type": "object" }, { - "name": "642", + "name": "650", "members": [ { "name": "mixing-engine", @@ -19321,7 +19529,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19347,7 +19555,7 @@ "meta-type": "object" }, { - "name": "643", + "name": "651", "members": [ { "name": "mixing-engine", @@ -19377,7 +19585,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19403,7 +19611,7 @@ "meta-type": "object" }, { - "name": "644", + "name": "652", "members": [ { "name": "mixing-engine", @@ -19433,7 +19641,7 @@ { "name": "format", "default": null, - "type": "712" + "type": "722" }, { "name": "buffer-length", @@ -19449,7 +19657,7 @@ "meta-type": "object" }, { - "name": "645", + "name": "653", "members": [ { "name": "desc", @@ -19464,7 +19672,7 @@ "meta-type": "object" }, { - "name": "646", + "name": "654", "members": [ { "name": "device", @@ -19488,27 +19696,27 @@ "meta-type": "object" }, { - "name": "647", + "name": "655", "members": [ { "name": "bus", - "type": "713" + "type": "723" }, { "name": "devices", "default": null, - "type": "[511]" + "type": "[515]" } ], "meta-type": "object" }, { - "name": "[648]", - "element-type": "648", + "name": "[656]", + "element-type": "656", "meta-type": "array" }, { - "name": "648", + "name": "656", "members": [ { "name": "bar", @@ -19540,7 +19748,7 @@ "meta-type": "object" }, { - "name": "649", + "name": "657", "members": [ { "type": "int" @@ -19555,7 +19763,7 @@ "meta-type": "alternate" }, { - "name": "650", + "name": "658", "members": [ { "name": "cumulative" @@ -19583,7 +19791,7 @@ ] }, { - "name": "651", + "name": "659", "members": [ { "name": "bytes" @@ -19607,7 +19815,7 @@ ] }, { - "name": "652", + "name": "660", "members": [ { "name": "protocols", @@ -19622,7 +19830,95 @@ "meta-type": "object" }, { - "name": "653", + "name": "661", + "members": [ + { + "name": "builtin" + }, + { + "name": "vhost-user" + }, + { + "name": "lkcf" + } + ], + "meta-type": "enum", + "values": [ + "builtin", + "vhost-user", + "lkcf" + ] + }, + { + "name": "662", + "members": [ + { + "name": "cache-data-parity" + }, + { + "name": "cache-address-parity" + }, + { + "name": "cache-be-parity" + }, + { + "name": "cache-data-ecc" + }, + { + "name": "mem-data-parity" + }, + { + "name": "mem-address-parity" + }, + { + "name": "mem-be-parity" + }, + { + "name": "mem-data-ecc" + }, + { + "name": "reinit-threshold" + }, + { + "name": "rsvd-encoding" + }, + { + "name": "poison-received" + }, + { + "name": "receiver-overflow" + }, + { + "name": "internal" + }, + { + "name": "cxl-ide-tx" + }, + { + "name": "cxl-ide-rx" + } + ], + "meta-type": "enum", + "values": [ + "cache-data-parity", + "cache-address-parity", + "cache-be-parity", + "cache-data-ecc", + "mem-data-parity", + "mem-address-parity", + "mem-be-parity", + "mem-data-ecc", + "reinit-threshold", + "rsvd-encoding", + "poison-received", + "receiver-overflow", + "internal", + "cxl-ide-tx", + "cxl-ide-rx" + ] + }, + { + "name": "663", "members": [ { "name": "unknown" @@ -19650,7 +19946,7 @@ ] }, { - "name": "654", + "name": "664", "members": [ { "name": "qcow2" @@ -19678,57 +19974,57 @@ ] }, { - "name": "655", + "name": "665", "members": [ { "name": "data", - "type": "714" + "type": "724" } ], "meta-type": "object" }, { - "name": "656", + "name": "666", "members": [ { "name": "data", - "type": "715" + "type": "725" } ], "meta-type": "object" }, { - "name": "657", + "name": "667", "members": [ { "name": "data", - "type": "716" + "type": "726" } ], "meta-type": "object" }, { - "name": "658", + "name": "668", "members": [ { "name": "data", - "type": "717" + "type": "727" } ], "meta-type": "object" }, { - "name": "659", + "name": "669", "members": [ { "name": "data", - "type": "718" + "type": "728" } ], "meta-type": "object" }, { - "name": "660", + "name": "670", "members": [ { "name": "l1_update" @@ -19928,7 +20224,7 @@ ] }, { - "name": "661", + "name": "671", "members": [ { "name": "read" @@ -19960,7 +20256,7 @@ ] }, { - "name": "662", + "name": "672", "members": [ { "name": "inet" @@ -19972,12 +20268,12 @@ ] }, { - "name": "663", + "name": "673", "members": [ { "name": "template", "default": null, - "type": "664" + "type": "674" }, { "name": "main-header", @@ -20028,7 +20324,7 @@ "meta-type": "object" }, { - "name": "664", + "name": "674", "members": [ { "name": "none" @@ -20052,7 +20348,7 @@ ] }, { - "name": "665", + "name": "675", "members": [ { "name": "aes" @@ -20068,7 +20364,7 @@ ] }, { - "name": "666", + "name": "676", "members": [ { "name": "key-secret", @@ -20079,7 +20375,7 @@ "meta-type": "object" }, { - "name": "667", + "name": "677", "members": [ { "name": "key-secret", @@ -20090,7 +20386,7 @@ "meta-type": "object" }, { - "name": "668", + "name": "678", "members": [ { "name": "aes" @@ -20102,7 +20398,7 @@ ] }, { - "name": "669", + "name": "679", "members": [ { "name": "luks" @@ -20122,7 +20418,7 @@ ] }, { - "name": "670", + "name": "680", "members": [ { "name": "key-secret", @@ -20132,7 +20428,7 @@ "meta-type": "object" }, { - "name": "671", + "name": "681", "members": [ { "name": "key-secret", @@ -20142,7 +20438,7 @@ "meta-type": "object" }, { - "name": "672", + "name": "682", "members": [ { "name": "key-secret", @@ -20152,7 +20448,7 @@ "meta-type": "object" }, { - "name": "673", + "name": "683", "members": [ { "name": "none" @@ -20172,11 +20468,11 @@ ] }, { - "name": "674", + "name": "684", "members": [ { "name": "type", - "type": "719" + "type": "729" }, { "name": "hash", @@ -20186,7 +20482,7 @@ "meta-type": "object" }, { - "name": "675", + "name": "685", "members": [ { "name": "off" @@ -20210,7 +20506,7 @@ ] }, { - "name": "676", + "name": "686", "members": [ { "name": "aes-128" @@ -20266,7 +20562,7 @@ ] }, { - "name": "677", + "name": "687", "members": [ { "name": "ecb" @@ -20290,7 +20586,7 @@ ] }, { - "name": "678", + "name": "688", "members": [ { "name": "plain" @@ -20310,7 +20606,7 @@ ] }, { - "name": "679", + "name": "689", "members": [ { "name": "md5" @@ -20346,28 +20642,28 @@ ] }, { - "name": "680", + "name": "690", "tag": "format", "variants": [ { "case": "qcow", - "type": "666" + "type": "676" }, { "case": "luks", - "type": "721" + "type": "731" } ], "members": [ { "name": "format", - "type": "720" + "type": "730" } ], "meta-type": "object" }, { - "name": "681", + "name": "691", "members": [ { "name": "v2" @@ -20383,7 +20679,7 @@ ] }, { - "name": "682", + "name": "692", "members": [ { "name": "zlib" @@ -20399,16 +20695,16 @@ ] }, { - "name": "683", + "name": "693", "tag": "format", "variants": [ { "case": "luks", - "type": "722" + "type": "732" }, { "case": "luks2", - "type": "723" + "type": "733" }, { "case": "luks-any", @@ -20418,13 +20714,13 @@ "members": [ { "name": "format", - "type": "669" + "type": "679" } ], "meta-type": "object" }, { - "name": "684", + "name": "694", "members": [ { "name": "dynamic" @@ -20440,7 +20736,7 @@ ] }, { - "name": "685", + "name": "695", "members": [ { "name": "monolithicSparse" @@ -20468,7 +20764,7 @@ ] }, { - "name": "686", + "name": "696", "members": [ { "name": "ide" @@ -20492,7 +20788,7 @@ ] }, { - "name": "687", + "name": "697", "members": [ { "name": "dynamic" @@ -20508,7 +20804,7 @@ ] }, { - "name": "688", + "name": "698", "members": [ { "name": "active" @@ -20524,12 +20820,12 @@ ] }, { - "name": "689", + "name": "699", "tag": "format", "variants": [ { "case": "luks", - "type": "724" + "type": "734" }, { "case": "qcow", @@ -20539,13 +20835,13 @@ "members": [ { "name": "format", - "type": "720" + "type": "730" } ], "meta-type": "object" }, { - "name": "690", + "name": "700", "members": [ { "name": "logfile", @@ -20575,7 +20871,7 @@ "meta-type": "object" }, { - "name": "691", + "name": "701", "members": [ { "name": "logfile", @@ -20595,7 +20891,7 @@ "meta-type": "object" }, { - "name": "692", + "name": "702", "members": [ { "name": "logfile", @@ -20609,7 +20905,7 @@ }, { "name": "addr", - "type": "340" + "type": "344" }, { "name": "tls-creds", @@ -20660,7 +20956,7 @@ "meta-type": "object" }, { - "name": "693", + "name": "703", "members": [ { "name": "logfile", @@ -20674,18 +20970,18 @@ }, { "name": "remote", - "type": "340" + "type": "344" }, { "name": "local", "default": null, - "type": "340" + "type": "344" } ], "meta-type": "object" }, { - "name": "694", + "name": "704", "members": [ { "name": "logfile", @@ -20701,7 +20997,7 @@ "meta-type": "object" }, { - "name": "695", + "name": "705", "members": [ { "name": "logfile", @@ -20721,7 +21017,7 @@ "meta-type": "object" }, { - "name": "696", + "name": "706", "members": [ { "name": "logfile", @@ -20742,7 +21038,7 @@ "meta-type": "object" }, { - "name": "697", + "name": "707", "members": [ { "name": "logfile", @@ -20762,7 +21058,7 @@ "meta-type": "object" }, { - "name": "698", + "name": "708", "members": [ { "name": "logfile", @@ -20782,7 +21078,7 @@ "meta-type": "object" }, { - "name": "699", + "name": "709", "members": [ { "name": "logfile", @@ -20808,7 +21104,7 @@ "meta-type": "object" }, { - "name": "700", + "name": "710", "members": [ { "name": "logfile", @@ -20828,7 +21124,7 @@ "meta-type": "object" }, { - "name": "701", + "name": "711", "members": [ { "name": "logfile", @@ -20864,7 +21160,7 @@ "meta-type": "object" }, { - "name": "702", + "name": "712", "members": [ { "name": "logfile", @@ -20885,7 +21181,7 @@ "meta-type": "object" }, { - "name": "703", + "name": "713", "members": [ { "name": "path", @@ -20901,7 +21197,7 @@ "meta-type": "object" }, { - "name": "704", + "name": "714", "members": [ { "name": "chardev", @@ -20911,7 +21207,7 @@ "meta-type": "object" }, { - "name": "705", + "name": "715", "members": [ { "name": "unmapped" @@ -21362,6 +21658,42 @@ }, { "name": "lang2" + }, + { + "name": "f13" + }, + { + "name": "f14" + }, + { + "name": "f15" + }, + { + "name": "f16" + }, + { + "name": "f17" + }, + { + "name": "f18" + }, + { + "name": "f19" + }, + { + "name": "f20" + }, + { + "name": "f21" + }, + { + "name": "f22" + }, + { + "name": "f23" + }, + { + "name": "f24" } ], "meta-type": "enum", @@ -21515,15 +21847,27 @@ "ac_refresh", "ac_bookmarks", "lang1", - "lang2" + "lang2", + "f13", + "f14", + "f15", + "f16", + "f17", + "f18", + "f19", + "f20", + "f21", + "f22", + "f23", + "f24" ] }, { - "name": "706", + "name": "716", "members": [ { "name": "key", - "type": "392" + "type": "396" }, { "name": "down", @@ -21533,11 +21877,11 @@ "meta-type": "object" }, { - "name": "707", + "name": "717", "members": [ { "name": "button", - "type": "725" + "type": "735" }, { "name": "down", @@ -21547,11 +21891,11 @@ "meta-type": "object" }, { - "name": "708", + "name": "718", "members": [ { "name": "axis", - "type": "726" + "type": "736" }, { "name": "value", @@ -21561,7 +21905,7 @@ "meta-type": "object" }, { - "name": "709", + "name": "719", "members": [ { "name": "persistent", @@ -21572,13 +21916,13 @@ "meta-type": "object" }, { - "name": "710", + "name": "720", "members": [ ], "meta-type": "object" }, { - "name": "711", + "name": "721", "members": [ { "name": "exact" @@ -21594,7 +21938,7 @@ ] }, { - "name": "712", + "name": "722", "members": [ { "name": "u8" @@ -21630,7 +21974,7 @@ ] }, { - "name": "713", + "name": "723", "members": [ { "name": "number", @@ -21646,21 +21990,21 @@ }, { "name": "io_range", - "type": "727" + "type": "737" }, { "name": "memory_range", - "type": "727" + "type": "737" }, { "name": "prefetchable_range", - "type": "727" + "type": "737" } ], "meta-type": "object" }, { - "name": "714", + "name": "724", "members": [ { "name": "compat", @@ -21698,22 +22042,22 @@ { "name": "encrypt", "default": null, - "type": "728" + "type": "738" }, { "name": "bitmaps", "default": null, - "type": "[729]" + "type": "[739]" }, { "name": "compression-type", - "type": "682" + "type": "692" } ], "meta-type": "object" }, { - "name": "715", + "name": "725", "members": [ { "name": "create-type", @@ -21729,34 +22073,34 @@ }, { "name": "extents", - "type": "[730]" + "type": "[740]" } ], "meta-type": "object" }, { - "name": "716", + "name": "726", "members": [ { "name": "cipher-alg", - "type": "676" + "type": "686" }, { "name": "cipher-mode", - "type": "677" + "type": "687" }, { "name": "ivgen-alg", - "type": "678" + "type": "688" }, { "name": "ivgen-hash-alg", "default": null, - "type": "679" + "type": "689" }, { "name": "hash-alg", - "type": "679" + "type": "689" }, { "name": "payload-offset", @@ -21772,24 +22116,24 @@ }, { "name": "slots", - "type": "[731]" + "type": "[741]" } ], "meta-type": "object" }, { - "name": "717", + "name": "727", "members": [ { "name": "encryption-format", "default": null, - "type": "669" + "type": "679" } ], "meta-type": "object" }, { - "name": "718", + "name": "728", "members": [ { "name": "extent-size-hint", @@ -21800,7 +22144,7 @@ "meta-type": "object" }, { - "name": "719", + "name": "729", "members": [ { "name": "md5" @@ -21820,7 +22164,7 @@ ] }, { - "name": "720", + "name": "730", "members": [ { "name": "qcow" @@ -21836,7 +22180,7 @@ ] }, { - "name": "721", + "name": "731", "members": [ { "name": "key-secret", @@ -21846,27 +22190,27 @@ { "name": "cipher-alg", "default": null, - "type": "676" + "type": "686" }, { "name": "cipher-mode", "default": null, - "type": "677" + "type": "687" }, { "name": "ivgen-alg", "default": null, - "type": "678" + "type": "688" }, { "name": "ivgen-hash-alg", "default": null, - "type": "679" + "type": "689" }, { "name": "hash-alg", "default": null, - "type": "679" + "type": "689" }, { "name": "iter-time", @@ -21877,7 +22221,7 @@ "meta-type": "object" }, { - "name": "722", + "name": "732", "members": [ { "name": "key-secret", @@ -21886,13 +22230,13 @@ { "name": "cipher-alg", "default": null, - "type": "676" + "type": "686" } ], "meta-type": "object" }, { - "name": "723", + "name": "733", "members": [ { "name": "key-secret", @@ -21901,17 +22245,17 @@ { "name": "cipher-alg", "default": null, - "type": "676" + "type": "686" } ], "meta-type": "object" }, { - "name": "724", + "name": "734", "members": [ { "name": "state", - "type": "688" + "type": "698" }, { "name": "new-secret", @@ -21942,7 +22286,7 @@ "meta-type": "object" }, { - "name": "725", + "name": "735", "members": [ { "name": "left" @@ -21986,7 +22330,7 @@ ] }, { - "name": "726", + "name": "736", "members": [ { "name": "x" @@ -22002,7 +22346,7 @@ ] }, { - "name": "727", + "name": "737", "members": [ { "name": "base", @@ -22016,12 +22360,12 @@ "meta-type": "object" }, { - "name": "728", + "name": "738", "tag": "format", "variants": [ { "case": "luks", - "type": "716" + "type": "726" }, { "case": "aes", @@ -22031,18 +22375,18 @@ "members": [ { "name": "format", - "type": "665" + "type": "675" } ], "meta-type": "object" }, { - "name": "[729]", - "element-type": "729", + "name": "[739]", + "element-type": "739", "meta-type": "array" }, { - "name": "729", + "name": "739", "members": [ { "name": "name", @@ -22054,18 +22398,18 @@ }, { "name": "flags", - "type": "[732]" + "type": "[742]" } ], "meta-type": "object" }, { - "name": "[730]", - "element-type": "730", + "name": "[740]", + "element-type": "740", "meta-type": "array" }, { - "name": "730", + "name": "740", "members": [ { "name": "filename", @@ -22093,12 +22437,12 @@ "meta-type": "object" }, { - "name": "[731]", - "element-type": "731", + "name": "[741]", + "element-type": "741", "meta-type": "array" }, { - "name": "731", + "name": "741", "members": [ { "name": "active", @@ -22122,12 +22466,12 @@ "meta-type": "object" }, { - "name": "[732]", - "element-type": "732", + "name": "[742]", + "element-type": "742", "meta-type": "array" }, { - "name": "732", + "name": "742", "members": [ { "name": "in-use" @@ -22156,6 +22500,15 @@ { "name": "device_add" }, + { + "name": "cxl-inject-correctable-error" + }, + { + "name": "cxl-inject-uncorrectable-errors" + }, + { + "name": "query-cryptodev" + }, { "name": "x-query-virtio-queue-element" }, @@ -23185,14 +23538,14 @@ "name": "pci-ipmi-kcs", "parent": "pci-device" }, - { - "name": "intel-iommu-iommu-memory-region", - "parent": "iommu-memory-region" - }, { "name": "xio3130-downstream", "parent": "pcie-slot" }, + { + "name": "intel-iommu-iommu-memory-region", + "parent": "iommu-memory-region" + }, { "name": "vhost-user-vsock-pci-non-transitional", "parent": "vhost-user-vsock-pci-base" @@ -23226,8 +23579,8 @@ "parent": "pci-device" }, { - "name": "pc-i440fx-6.0-machine", - "parent": "generic-pc-machine" + "name": "vhost-vsock-pci-non-transitional", + "parent": "vhost-vsock-pci-base" }, { "name": "vhost-user-i2c-device", @@ -23265,6 +23618,10 @@ "name": "pc-q35-7.2-machine", "parent": "generic-pc-machine" }, + { + "name": "pc-i440fx-6.0-machine", + "parent": "generic-pc-machine" + }, { "name": "qemu32-x86_64-cpu", "parent": "x86_64-cpu" @@ -23274,17 +23631,13 @@ "parent": "x86_64-cpu" }, { - "name": "vhost-vsock-pci-non-transitional", - "parent": "vhost-vsock-pci-base" + "name": "xen-gnttab", + "parent": "sys-bus-device" }, { "name": "usb-net", "parent": "usb-device" }, - { - "name": "xen-gnttab", - "parent": "sys-bus-device" - }, { "name": "CXL", "parent": "PCIE" @@ -23361,6 +23714,10 @@ "name": "pr-manager-helper", "parent": "pr-manager" }, + { + "name": "virtio-scsi-device", + "parent": "virtio-scsi-common" + }, { "name": "pc-i440fx-2.10-machine", "parent": "generic-pc-machine" @@ -23378,16 +23735,16 @@ "parent": "object" }, { - "name": "virtio-scsi-device", - "parent": "virtio-scsi-common" + "name": "Haswell-IBRS-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "pxb-pcie", "parent": "pci-device" }, { - "name": "Haswell-IBRS-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "cpu-cluster", + "parent": "device" }, { "name": "vhost-user-i2c-pci", @@ -23398,7 +23755,7 @@ "parent": "object" }, { - "name": "cpu-cluster", + "name": "xen-backend", "parent": "device" }, { @@ -23461,6 +23818,10 @@ "name": "virtio-mouse-pci", "parent": "virtio-mouse-pci-base-type" }, + { + "name": "vhost-vsock-device", + "parent": "vhost-vsock-common" + }, { "name": "pc-q35-5.0-machine", "parent": "generic-pc-machine" @@ -23517,17 +23878,17 @@ "name": "virtio-9p-pci-non-transitional", "parent": "virtio-9p-pci-base" }, - { - "name": "memory-backend-file", - "parent": "memory-backend" - }, { "name": "Nehalem-v2-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "vhost-vsock-device", - "parent": "vhost-vsock-common" + "name": "memory-backend-file", + "parent": "memory-backend" + }, + { + "name": "xen-disk", + "parent": "xen-block" }, { "name": "isa-pcspk", @@ -23561,6 +23922,10 @@ "name": "pc-q35-4.0.1-machine", "parent": "generic-pc-machine" }, + { + "name": "IvyBridge-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "virtio-blk-pci-non-transitional", "parent": "virtio-blk-pci-base" @@ -23573,10 +23938,6 @@ "name": "tcg-accel", "parent": "accel" }, - { - "name": "IvyBridge-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "isabus-bridge", "parent": "sys-bus-device" @@ -23701,14 +24062,14 @@ "name": "kvm-apic", "parent": "apic-common" }, - { - "name": "isa-pit", - "parent": "pit-common" - }, { "name": "kvm64-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "isa-pit", + "parent": "pit-common" + }, { "name": "Broadwell-v4-x86_64-cpu", "parent": "x86_64-cpu" @@ -23737,6 +24098,10 @@ "name": "Denverton-v2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "xen-bridge", + "parent": "sys-bus-device" + }, { "name": "vhost-user-gpu-pci", "parent": "vhost-user-gpu-pci-base-type" @@ -23777,14 +24142,14 @@ "name": "isa-serial", "parent": "isa-device" }, - { - "name": "x-remote-object", - "parent": "object" - }, { "name": "pc-q35-8.0-machine", "parent": "generic-pc-machine" }, + { + "name": "x-remote-object", + "parent": "object" + }, { "name": "core2duo-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -23801,6 +24166,10 @@ "name": "cirrus-vga", "parent": "pci-device" }, + { + "name": "main-loop", + "parent": "event-loop-base" + }, { "name": "kvm32-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -23834,8 +24203,8 @@ "parent": "x86_64-cpu" }, { - "name": "main-loop", - "parent": "event-loop-base" + "name": "xen-cdrom", + "parent": "xen-block" }, { "name": "Cooperlake-v2-x86_64-cpu", @@ -23889,6 +24258,10 @@ "name": "e1000-82545em", "parent": "e1000-base" }, + { + "name": "vhost-user-scsi", + "parent": "vhost-scsi-common" + }, { "name": "pxb-pcie-bus", "parent": "PCIE" @@ -23898,8 +24271,8 @@ "parent": "pci-device" }, { - "name": "vhost-user-scsi", - "parent": "vhost-scsi-common" + "name": "igbvf", + "parent": "pci-device" }, { "name": "PIIX4_PM", @@ -23941,6 +24314,10 @@ "name": "i440FX", "parent": "pci-device" }, + { + "name": "xen-bus", + "parent": "bus" + }, { "name": "Penryn-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -24069,6 +24446,10 @@ "name": "Dhyana-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "Nehalem-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "pc-i440fx-5.1-machine", "parent": "generic-pc-machine" @@ -24097,10 +24478,6 @@ "name": "i82559b", "parent": "pci-device" }, - { - "name": "Nehalem-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "usb-mouse", "parent": "usb-hid" @@ -24246,16 +24623,16 @@ "parent": "generic-pc-machine" }, { - "name": "vmcoreinfo", - "parent": "device" + "name": "chardev-braille", + "parent": "chardev" }, { "name": "vhost-vdpa-device-pci-non-transitional", "parent": "vhost-vdpa-device-pci-base" }, { - "name": "chardev-braille", - "parent": "chardev" + "name": "vmcoreinfo", + "parent": "device" }, { "name": "tpci200", @@ -24349,6 +24726,10 @@ "name": "nvme-bus", "parent": "bus" }, + { + "name": "xen-sysbus", + "parent": "bus" + }, { "name": "cs4231a", "parent": "isa-device" @@ -24793,6 +25174,10 @@ "name": "virtio-balloon-pci-transitional", "parent": "virtio-balloon-pci-base" }, + { + "name": "igb", + "parent": "pci-device" + }, { "name": "Haswell-v4-x86_64-cpu", "parent": "x86_64-cpu" @@ -24849,6 +25234,10 @@ "name": "qemu32-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "xen-sysdev", + "parent": "sys-bus-device" + }, { "name": "Haswell-noTSX-x86_64-cpu", "parent": "x86_64-cpu" @@ -24905,10 +25294,6 @@ "name": "adlib", "parent": "isa-device" }, - { - "name": "vhost-user-rng-pci", - "parent": "vhost-user-rng-pci-base" - }, { "name": "vhost-user-gpio-pci", "parent": "vhost-user-gpio-pci-base" @@ -24938,25 +25323,33 @@ "parent": "pci-device" }, { - "name": "Cascadelake-Server-v3-x86_64-cpu", + "name": "Cooperlake-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "Cooperlake-v1-x86_64-cpu", + "name": "Cascadelake-Server-v3-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "virtio-balloon-device", - "parent": "virtio-device" + "name": "vhost-user-rng-pci", + "parent": "vhost-user-rng-pci-base" }, { - "name": "Skylake-Server-x86_64-cpu", + "name": "Nehalem-IBRS-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "virtio-balloon-device", + "parent": "virtio-device" + }, { "name": "cfi.pflash01", "parent": "sys-bus-device" }, + { + "name": "Skylake-Server-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "pc-q35-2.7-machine", "parent": "generic-pc-machine" @@ -24965,10 +25358,6 @@ "name": "isa-parallel", "parent": "isa-device" }, - { - "name": "Nehalem-IBRS-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pentium2-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -32126,18 +32515,18 @@ }, { "hotpluggable-cpus": true, - "name": "pc-q35-7.2", + "name": "pc-i440fx-6.0", "numa-mem-supported": false, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, - "cpu-max": 288, + "cpu-max": 255, "deprecated": false, "default-ram-id": "pc.ram" }, { "hotpluggable-cpus": true, - "name": "pc-q35-4.0", - "numa-mem-supported": true, + "name": "pc-q35-7.2", + "numa-mem-supported": false, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, "cpu-max": 288, @@ -32146,11 +32535,11 @@ }, { "hotpluggable-cpus": true, - "name": "pc-i440fx-6.0", - "numa-mem-supported": false, + "name": "pc-q35-4.0", + "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, - "cpu-max": 255, + "cpu-max": 288, "deprecated": false, "default-ram-id": "pc.ram" }, @@ -40910,18 +41299,18 @@ }, { "hotpluggable-cpus": true, - "name": "pc-q35-7.2", + "name": "pc-i440fx-6.0", "numa-mem-supported": false, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, - "cpu-max": 288, + "cpu-max": 255, "deprecated": false, "default-ram-id": "pc.ram" }, { "hotpluggable-cpus": true, - "name": "pc-q35-4.0", - "numa-mem-supported": true, + "name": "pc-q35-7.2", + "numa-mem-supported": false, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, "cpu-max": 288, @@ -40930,11 +41319,11 @@ }, { "hotpluggable-cpus": true, - "name": "pc-i440fx-6.0", - "numa-mem-supported": false, + "name": "pc-q35-4.0", + "numa-mem-supported": true, "default-cpu-type": "qemu64-x86_64-cpu", "acpi": true, - "cpu-max": 255, + "cpu-max": 288, "deprecated": false, "default-ram-id": "pc.ram" }, diff --git a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml index 73924e1163..28e2c6427c 100644 --- a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml @@ -206,9 +206,9 @@ <flag name='virtio-gpu.blob'/> <flag name='rbd-encryption-layering'/> <flag name='rbd-encryption-luks-any'/> - <version>7002050</version> + <version>7002093</version> <microcodeVersion>43100244</microcodeVersion> - <package>v7.2.0-2146-g2946e1af27</package> + <package>v8.0.0-rc3-28-g9d177b7f87</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -1637,9 +1637,9 @@ <machine type='kvm' name='pc-q35-2.8' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='pc-i440fx-2.10' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> + <machine type='kvm' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='pc-q35-7.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='pc-q35-4.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> - <machine type='kvm' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='microvm' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='microvm.ram' acpi='yes'/> <machine type='kvm' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='kvm' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> @@ -3432,9 +3432,9 @@ <machine type='tcg' name='pc-q35-2.8' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='pc-i440fx-2.10' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> + <machine type='tcg' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='pc-q35-7.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='pc-q35-4.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> - <machine type='tcg' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='microvm' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='microvm.ram' acpi='yes'/> <machine type='tcg' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> <machine type='tcg' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram' acpi='yes'/> -- 2.39.2

2 1

[PATCH 0/3] virt-host-validate: Detect SMMU presence on ARMs by parsing IORT table
by Michal Privoznik 12 Apr '23

12 Apr '23

*** BLURB HERE *** Michal Prívozník (3): util: Introduce virAcpi module tests: Introduce viracpitest virt-host-validate: Detect SMMU presence on ARMs by parsing IORT table build-aux/syntax-check.mk | 2 +- po/POTFILES | 1 + src/libvirt_private.syms | 7 + src/util/meson.build | 1 + src/util/viracpi.c | 225 ++++++++++++++++++++++++++++ src/util/viracpi.h | 23 +++ src/util/viracpipriv.h | 59 ++++++++ tests/meson.build | 1 + tests/viracpidata/IORT_ampere | Bin 0 -> 2304 bytes tests/viracpidata/IORT_empty | Bin 0 -> 65 bytes tests/viracpidata/IORT_gigabyte | Bin 0 -> 10100 bytes tests/viracpidata/IORT_qualcom | Bin 0 -> 3560 bytes tests/viracpidata/IORT_virt_aarch64 | Bin 0 -> 128 bytes tests/viracpitest.c | 135 +++++++++++++++++ tools/virt-host-validate-common.c | 18 ++- 15 files changed, 468 insertions(+), 4 deletions(-) create mode 100644 src/util/viracpi.c create mode 100644 src/util/viracpi.h create mode 100644 src/util/viracpipriv.h create mode 100644 tests/viracpidata/IORT_ampere create mode 100644 tests/viracpidata/IORT_empty create mode 100644 tests/viracpidata/IORT_gigabyte create mode 100644 tests/viracpidata/IORT_qualcom create mode 100644 tests/viracpidata/IORT_virt_aarch64 create mode 100644 tests/viracpitest.c -- 2.39.2

4 15

[libvirt PATCH v4] Conf: Move validation of virDomainGraphicsListenDef out of Parser
by K Shiva 12 Apr '23

12 Apr '23

From: K Shiva Kiran <shiva_kr(a)riseup.net> In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- This is a v4 of: https://listman.redhat.com/archives/libvir-list/2023-April/239286.html This commit has been squashed with v3. diff to v3: - Dropped virDomainGraphicsListenDefValidate() as per suggestion - Moved the above's code to virDomainGraphicsDefListensValidate() - Moved an existing if() condition in virDomainGraphicsDefListensValidate() into the switch() statement of the freshly moved code src/conf/domain_conf.c | 30 +----------------------------- src/conf/domain_validate.c | 37 +++++++++++++++++++++++++++++++------ 2 files changed, 32 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70e4d52ee6..8df751cc46 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10986,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10998,13 +10997,11 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) { int ret = -1; - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); g_autofree char *address = virXMLPropString(node, "address"); g_autofree char *network = virXMLPropString(node, "network"); g_autofree char *socketPath = virXMLPropString(node, "socket"); @@ -11021,31 +11018,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11148,7 +11120,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..988f0854a5 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2631,14 +2631,39 @@ static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { size_t i; + const char *graphicsType = virDomainGraphicsTypeToString(def->type); for (i = 0; i < def->nListens; i++) { - if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK && - !def->listens[i].network) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("'network' attribute is required for " - "listen type 'network'")); - return -1; + switch (def->listens[i].type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + if (!def->listens[i].network) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("'network' attribute is required for " + "listen type 'network'")); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; } } -- 2.40.0

2 1

[libvirt PATCH 0/2] conf: Fix migration in some firmware autoselection scenarios
by Andrea Bolognani 12 Apr '23

12 Apr '23

See commit 2/2 for details. Andrea Bolognani (2): tests: Tweak input file conf: Fix migration in some firmware autoselection scenarios src/conf/domain_conf.c | 39 ++++++++++++++++++- ...are-manual-efi-features.x86_64-latest.args | 35 +++++++++++++++++ .../firmware-manual-efi-features.xml | 2 +- tests/qemuxml2argvtest.c | 6 ++- ...ware-manual-efi-features.x86_64-latest.xml | 36 +++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 6 files changed, 115 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-features.x86_64-latest.args create mode 100644 tests/qemuxml2xmloutdata/firmware-manual-efi-features.x86_64-latest.xml -- 2.39.2

2 7

[PATCH] qemu: Fix potential crash during driver cleanup
by Jim Fehlig 12 Apr '23

12 Apr '23

During qemu driver shutdown, objects are freed in qemuStateCleanup that could still be used by active worker threads, resulting in crashes. E.g. a worker thread could be processing a monitor EOF event after the security manager is already disposed Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007fd9a9a1e1fe in virSecurityManagerMoveImageMetadata (mgr=0x7fd948012160, pid=-1, src=src@entry=0x7fd98c072c90, dst=dst@entry=0x0) at ../../src/security/security_manager.c:468 #1 0x00007fd9646ff0f0 in qemuSecurityMoveImageMetadata (driver=driver@entry=0x7fd948043830, vm=vm@entry=0x7fd98c066db0, src=src@entry=0x7fd98c072c90, dst=dst@entry=0x0) at ../../src/qemu/qemu_security.c:182 #2 0x00007fd96462c7b0 in qemuBlockRemoveImageMetadata (driver=driver@entry=0x7fd948043830, vm=vm@entry=0x7fd98c066db0, diskTarget=0x7fd98c072530 "vda", src=<optimized out>) at ../../src/qemu/qemu_block.c:2628 #3 0x00007fd9646929d6 in qemuProcessStop (driver=driver@entry=0x7fd948043830, vm=vm@entry=0x7fd98c066db0, reason=reason@entry=VIR_DOMAIN_SHUTOFF_SHUTDOWN, asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_NONE, flags=<optimized out>) at ../../src/qemu/qemu_process.c:7585 #4 0x00007fd9646fc842 in processMonitorEOFEvent (vm=0x7fd98c066db0, driver=0x7fd948043830) at ../../src/qemu/qemu_driver.c:4794 #5 qemuProcessEventHandler (data=0x561a93febb60, opaque=0x7fd948043830) at ../../src/qemu/qemu_driver.c:4900 #6 0x00007fd9a9971a31 in virThreadPoolWorker (opaque=opaque@entry=0x561a93fb58e0) at ../../src/util/virthreadpool.c:163 (gdb) p mgr->drv $2 = (virSecurityDriverPtr) 0x0 Prior to commit 7cf76d4e3ab, the worker thread pool was freed before disposing any driver objects. Let's return to that pattern, but leave the other changes made by 7cf76d4e3ab. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b4fb7ec1df..28e470e4a2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1062,6 +1062,7 @@ qemuStateCleanup(void) if (!qemu_driver) return -1; + virThreadPoolFree(qemu_driver->workerPool); virObjectUnref(qemu_driver->migrationErrors); virLockManagerPluginUnref(qemu_driver->lockManager); virSysinfoDefFree(qemu_driver->hostsysinfo); @@ -1078,7 +1079,6 @@ qemuStateCleanup(void) ebtablesContextFree(qemu_driver->ebtables); VIR_FREE(qemu_driver->qemuImgBinary); virObjectUnref(qemu_driver->domains); - virThreadPoolFree(qemu_driver->workerPool); if (qemu_driver->lockFD != -1) virPidFileRelease(qemu_driver->config->stateDir, "driver", qemu_driver->lockFD); -- 2.40.0

2 1

Re: [PATCH] qemu-options.hx: Update descriptions of memory options for NUMA node
by Yohei Kojima 11 Apr '23

11 Apr '23

ping This patch updates an outdated description in qemu-options.hx . The patch reflects the changes in qemu behavior already described in another documentation, and it also changes paragraph structure for further readability. The original patch is: https://patchew.org/QEMU/TYZPR06MB5418D6B0175A49E8E76988439D8E9@TYZPR06MB54… On 2023/03/30 19:09, Yohei Kojima wrote: > This commit adds the following description: > 1. `memdev` option is recommended over `mem` option (see [1,2]) > 2. users must specify memory for all NUMA nodes (see [2]) > > This commit also separates descriptions for `mem` and `memdev` into two > paragraphs. The old doc describes legacy `mem` option first, and it was > a bit confusing. > > Related documantations: > [1] https://wiki.qemu.org/ChangeLog/5.1#Incompatible_changes > [2] https://www.qemu.org/docs/master/about/removed-features.html > > Signed-off-by: Yohei Kojima <y-koj(a)outlook.jp> > --- > qemu-options.hx | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 59bdf67a2c..174f0d0c2d 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -405,15 +405,22 @@ SRST > -numa node,nodeid=0 -numa node,nodeid=1 \ > -numa cpu,node-id=0,socket-id=0 -numa cpu,node-id=1,socket-id=1 > > - Legacy '\ ``mem``\ ' assigns a given RAM amount to a node (not supported > - for 5.1 and newer machine types). '\ ``memdev``\ ' assigns RAM from > - a given memory backend device to a node. If '\ ``mem``\ ' and > - '\ ``memdev``\ ' are omitted in all nodes, RAM is split equally between them. > - > - > - '\ ``mem``\ ' and '\ ``memdev``\ ' are mutually exclusive. > - Furthermore, if one node uses '\ ``memdev``\ ', all of them have to > - use it. > + '\ ``memdev``\ ' option assigns RAM from a given memory backend > + device to a node. It is recommended to use '\ ``memdev``\ ' option > + over legacy '\ ``mem``\ ' option. This is because '\ ``memdev``\ ' > + option provides better performance and more control over the > + backend's RAM (e.g. '\ ``prealloc``\ ' parameter of > + '\ ``-memory-backend-ram``\ ' allows memory preallocation). > + > + For compatibility reasons, legacy '\ ``mem``\ ' option is > + supported in 5.0 and older machine types. Note that '\ ``mem``\ ' > + and '\ ``memdev``\ ' are mutually exclusive. If one node uses > + '\ ``memdev``\ ', the rest nodes have to use '\ ``memdev``\ ' > + option, and vice versa. > + > + Users must specify memory for all NUMA nodes by '\ ``memdev``\ ' > + (or legacy '\ ``mem``\ ' if available). In QEMU 5.2, the support > + for '\ ``-numa node``\ ' without memory specified was removed. > > '\ ``initiator``\ ' is an additional option that points to an > initiator NUMA node that has best performance (the lowest latency or

1 0

[libvirt PATCH 0/3] RFC: fix compilation on msys2
by marcandre.lureau＠redhat.com 11 Apr '23

11 Apr '23

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, libvirt fails to compile on msys2/win32. Here is a few patches that solve it, but the way python scripts are being handled in general is a bit odd, so this is RFC. (fwiw, a lot of tests fail though, I can send the log if anyone is interested - or attach it to a gitlab issue) Fixes: https://gitlab.com/libvirt/libvirt/-/issues/453 Marc-André Lureau (3): meson: don't look for unix paths on win32 meson: drop explicit python interpreter rpc/ssh: ssh_userauth_agent() is not supported on win32 docs/manpages/meson.build | 4 ++-- docs/meson.build | 6 ++---- meson.build | 14 +++++++++----- src/admin/meson.build | 4 ++-- src/esx/meson.build | 4 ++-- src/hyperv/meson.build | 2 +- src/meson.build | 8 ++++---- src/rpc/virnetlibsshsession.c | 14 ++++++++++++-- src/util/meson.build | 4 ++-- 9 files changed, 36 insertions(+), 24 deletions(-) -- 2.39.2

3 9

[PATCH 00/21] qemu capability testing cleanups and improvements (part 5)
by Peter Krempa 11 Apr '23

11 Apr '23

This series applies on top of 'part 4' fetch everything from my repo: git fetch https://gitlab.com/pipo.sk/libvirt.git aarch-send In this part tests for the 'aarch64' platform are converted to use real capabilities. Peter Krempa (21): virDomainPCIAddressSetExtensionAlloc: Remove return value qemuxml2argvdata: Do not symlink output files for aarch64 gic tests qemuxml2argvtest: Use real capabilities in tests for picking the aarch64 GIC version qemuxml2argvtest: Convert DO_TEST_GIC to use real latest capabilities qemuxml2argvtest: Convert the rest of GIC tests to latest capabilities qemuxml2argvtest: Add real-caps versions of 'aarch64-virt-virtio' qemuxml2argvtest: Drop "aarch64-virt-2.6-virtio-pci-default" case qemuxml2argv: Test default aarch64 cofig without PCIe support qemuxml2argvtest: Modernize 'balloon-mmio-deflate' qemuxml2argvtest: Don't symlink output files for 'mach-virt-' cases qemuxml2argvtest: Modernize all 'mach-virt-' aarch64 test cases qemuxml2argvtest: Update 'aarch64-virtio-pci-manual-addresses' case qemuxml2*test: Drop fake-caps invocation of 'aarch64-virtio-pci-manual-addresses' qemuxml2(argv|xml)test: Modernize testing of USB controllers on aarch64 qemuxml2argvtest: Modernize the rest of 'aarch64' cases qemuxml2xmlout: Do not symlink output files for 'aarch64-gic' cases qemuxml2xmltest: Modernize 'aarch64-gic*' test cases qemuxml2xmloutdata: Don't symlink output data for 'mach-virt*' cases qemuxml2xmltest: Modernize 'mach-virt*' cases qemuxml2xmltest: Convert rest of 'aarch64' cases to real capabilities testutilsqemu: Drop fake capability testing infrastructure for 'aarch64' src/conf/domain_addr.c | 13 +- ...h64-aavmf-virtio-mmio.aarch64-latest.args} | 20 +- ...rch64-cpu-passthrough.aarch64-latest.args} | 26 +-- .../aarch64-gic-default-both.args | 33 ++- .../aarch64-gic-default-v2.args | 33 ++- .../aarch64-gic-default-v3.args | 33 ++- ...=> aarch64-gic-default.aarch64-4.2.0.args} | 14 +- ...> aarch64-gic-default.aarch64-latest.args} | 17 +- .../qemuxml2argvdata/aarch64-gic-default.args | 1 - tests/qemuxml2argvdata/aarch64-gic-host.args | 6 +- ...=> aarch64-gic-invalid.aarch64-latest.err} | 0 .../aarch64-gic-none-both.args | 33 ++- .../aarch64-gic-none-tcg.args | 6 +- .../qemuxml2argvdata/aarch64-gic-none-v2.args | 33 ++- .../qemuxml2argvdata/aarch64-gic-none-v3.args | 33 ++- ...gs => aarch64-gic-none.aarch64-4.2.0.args} | 8 +- .../aarch64-gic-none.aarch64-latest.args | 32 +++ tests/qemuxml2argvdata/aarch64-gic-none.args | 1 - ...> aarch64-gic-not-virt.aarch64-latest.err} | 0 tests/qemuxml2argvdata/aarch64-gic-v2.args | 6 +- tests/qemuxml2argvdata/aarch64-gic-v3.args | 6 +- .../aarch64-pci-serial.aarch64-latest.args | 38 +++ ...arch64-tpm-wrong-model.aarch64-latest.err} | 0 ...arch64-traditional-pci.aarch64-latest.args | 37 +++ .../aarch64-traditional-pci.args | 34 --- .../aarch64-usb-controller-qemu-xhci.args | 30 --- .../aarch64-usb-controller-qemu-xhci.xml | 16 -- ...arch64-usb-controller.aarch64-latest.args} | 11 +- ...ec-xhci.xml => aarch64-usb-controller.xml} | 6 + ...aarch64-video-default.aarch64-latest.args} | 13 +- ...4-video-virtio-gpu-pci.aarch64-latest.args | 37 +++ .../aarch64-video-virtio-gpu-pci.args | 35 --- .../aarch64-virt-2.6-virtio-pci-default.xml | 46 ---- ...ch64-virt-default-nic.aarch64-latest.args} | 10 +- ...ch64-virt-virtio-MMIO.aarch64.latest.args} | 20 +- ...=> aarch64-virt-virtio.aarch64-4.2.0.args} | 22 +- .../aarch64-virt-virtio.aarch64-latest.args | 55 +++++ ...o-pci-manual-addresses.aarch64-latest.args | 49 ++++ .../aarch64-virtio-pci-manual-addresses.xml | 4 +- .../balloon-mmio-deflate.aarch64-latest.args | 37 +++ ...h-virt-console-native.aarch64-latest.args} | 7 +- .../mach-virt-console-native.args | 1 - ...ch-virt-console-virtio.aarch64-latest.args | 37 +++ ...serial+console-native.aarch64-latest.args} | 12 +- .../mach-virt-serial+console-native.args | 1 - ...ch-virt-serial-compat.aarch64-latest.args} | 12 +- .../mach-virt-serial-compat.args | 1 - ...-serial-invalid-machine.x86_64-latest.err} | 0 ...ch-virt-serial-native.aarch64-latest.args} | 12 +- .../mach-virt-serial-pci.aarch64-latest.args | 37 +++ .../mach-virt-serial-usb.aarch64-latest.args | 37 +++ tests/qemuxml2argvtest.c | 217 +++++++----------- ...ch64-aavmf-virtio-mmio.aarch64-latest.xml} | 1 + ...arch64-gic-default-both.aarch64-latest.xml | 26 +++ .../aarch64-gic-default-both.xml | 1 - .../aarch64-gic-default-v2.aarch64-latest.xml | 26 +++ .../aarch64-gic-default-v2.xml | 1 - .../aarch64-gic-default-v3.aarch64-latest.xml | 26 +++ .../aarch64-gic-default-v3.xml | 1 - .../aarch64-gic-default.aarch64-latest.xml | 26 +++ .../aarch64-gic-default.xml | 1 - .../aarch64-gic-host.aarch64-latest.xml | 26 +++ tests/qemuxml2xmloutdata/aarch64-gic-host.xml | 1 - .../aarch64-gic-none-both.aarch64-latest.xml | 26 +++ .../aarch64-gic-none-both.xml | 1 - ...> aarch64-gic-none-tcg.aarch64-latest.xml} | 1 + .../aarch64-gic-none-v2.aarch64-latest.xml | 26 +++ .../aarch64-gic-none-v2.xml | 1 - .../aarch64-gic-none-v3.aarch64-latest.xml | 26 +++ .../aarch64-gic-none-v3.xml | 1 - .../aarch64-gic-none.aarch64-latest.xml | 26 +++ tests/qemuxml2xmloutdata/aarch64-gic-none.xml | 1 - .../aarch64-gic-v2.aarch64-latest.xml | 26 +++ tests/qemuxml2xmloutdata/aarch64-gic-v2.xml | 1 - .../aarch64-gic-v3.aarch64-latest.xml | 26 +++ tests/qemuxml2xmloutdata/aarch64-gic-v3.xml | 1 - ... => aarch64-pci-serial.aarch64-latest.xml} | 19 +- ...arch64-traditional-pci.aarch64-latest.xml} | 3 + .../aarch64-usb-controller.aarch64-latest.xml | 36 +++ ... aarch64-video-default.aarch64-latest.xml} | 22 +- ...4-video-virtio-gpu-pci.aarch64-latest.xml} | 4 +- ...o-pci-manual-addresses.aarch64-latest.xml} | 24 +- ...ch-virt-console-native.aarch64-latest.xml} | 4 + .../mach-virt-console-native.xml | 1 - ...ach-virt-console-virtio.aarch64-latest.xml | 44 ++++ ...-serial+console-native.aarch64-latest.xml} | 14 +- .../mach-virt-serial+console-native.xml | 1 - ...mach-virt-serial-compat.aarch64-latest.xml | 36 +++ ...mach-virt-serial-native.aarch64-latest.xml | 36 +++ .../mach-virt-serial-native.xml | 1 - ...> mach-virt-serial-pci.aarch64-latest.xml} | 19 +- ...> mach-virt-serial-usb.aarch64-latest.xml} | 3 + tests/qemuxml2xmltest.c | 153 ++++++------ tests/testutilsqemu.c | 6 - 94 files changed, 1396 insertions(+), 557 deletions(-) rename tests/qemuxml2argvdata/{aarch64-aavmf-virtio-mmio.args => aarch64-aavmf-virtio-mmio.aarch64-latest.args} (57%) rename tests/qemuxml2argvdata/{aarch64-virtio-pci-manual-addresses.args => aarch64-cpu-passthrough.aarch64-latest.args} (52%) mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-both.args mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v2.args mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v3.args rename tests/qemuxml2argvdata/{balloon-mmio-deflate.args => aarch64-gic-default.aarch64-4.2.0.args} (71%) rename tests/qemuxml2argvdata/{aarch64-pci-serial.args => aarch64-gic-default.aarch64-latest.args} (55%) delete mode 120000 tests/qemuxml2argvdata/aarch64-gic-default.args rename tests/qemuxml2argvdata/{aarch64-gic-invalid.err => aarch64-gic-invalid.aarch64-latest.err} (100%) mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-both.args mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v2.args mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v3.args rename tests/qemuxml2argvdata/{aarch64-cpu-passthrough.args => aarch64-gic-none.aarch64-4.2.0.args} (67%) create mode 100644 tests/qemuxml2argvdata/aarch64-gic-none.aarch64-latest.args delete mode 120000 tests/qemuxml2argvdata/aarch64-gic-none.args rename tests/qemuxml2argvdata/{aarch64-gic-not-virt.err => aarch64-gic-not-virt.aarch64-latest.err} (100%) create mode 100644 tests/qemuxml2argvdata/aarch64-pci-serial.aarch64-latest.args rename tests/qemuxml2argvdata/{aarch64-tpm-wrong-model.err => aarch64-tpm-wrong-model.aarch64-latest.err} (100%) create mode 100644 tests/qemuxml2argvdata/aarch64-traditional-pci.aarch64-latest.args delete mode 100644 tests/qemuxml2argvdata/aarch64-traditional-pci.args delete mode 100644 tests/qemuxml2argvdata/aarch64-usb-controller-qemu-xhci.args delete mode 100644 tests/qemuxml2argvdata/aarch64-usb-controller-qemu-xhci.xml rename tests/qemuxml2argvdata/{aarch64-usb-controller-nec-xhci.args => aarch64-usb-controller.aarch64-latest.args} (55%) rename tests/qemuxml2argvdata/{aarch64-usb-controller-nec-xhci.xml => aarch64-usb-controller.xml} (61%) rename tests/qemuxml2argvdata/{aarch64-video-default.args => aarch64-video-default.aarch64-latest.args} (54%) create mode 100644 tests/qemuxml2argvdata/aarch64-video-virtio-gpu-pci.aarch64-latest.args delete mode 100644 tests/qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args delete mode 100644 tests/qemuxml2argvdata/aarch64-virt-2.6-virtio-pci-default.xml rename tests/qemuxml2argvdata/{aarch64-virt-default-nic.args => aarch64-virt-default-nic.aarch64-latest.args} (56%) rename tests/qemuxml2argvdata/{aarch64-virt-virtio.args => aarch64-virt-virtio-MMIO.aarch64.latest.args} (58%) rename tests/qemuxml2argvdata/{aarch64-virt-2.6-virtio-pci-default.args => aarch64-virt-virtio.aarch64-4.2.0.args} (63%) create mode 100644 tests/qemuxml2argvdata/aarch64-virt-virtio.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-manual-addresses.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-mmio-deflate.aarch64-latest.args rename tests/qemuxml2argvdata/{mach-virt-serial-native.args => mach-virt-console-native.aarch64-latest.args} (67%) delete mode 120000 tests/qemuxml2argvdata/mach-virt-console-native.args create mode 100644 tests/qemuxml2argvdata/mach-virt-console-virtio.aarch64-latest.args rename tests/qemuxml2argvdata/{mach-virt-serial-pci.args => mach-virt-serial+console-native.aarch64-latest.args} (65%) delete mode 120000 tests/qemuxml2argvdata/mach-virt-serial+console-native.args rename tests/qemuxml2argvdata/{mach-virt-serial-usb.args => mach-virt-serial-compat.aarch64-latest.args} (64%) delete mode 120000 tests/qemuxml2argvdata/mach-virt-serial-compat.args rename tests/qemuxml2argvdata/{mach-virt-serial-invalid-machine.err => mach-virt-serial-invalid-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{mach-virt-console-virtio.args => mach-virt-serial-native.aarch64-latest.args} (62%) create mode 100644 tests/qemuxml2argvdata/mach-virt-serial-pci.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/mach-virt-serial-usb.aarch64-latest.args rename tests/qemuxml2xmloutdata/{aarch64-aavmf-virtio-mmio.xml => aarch64-aavmf-virtio-mmio.aarch64-latest.xml} (96%) create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-default-both.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-default-both.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-default-v2.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-default-v2.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-default-v3.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-default-v3.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-default.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-default.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-host.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-host.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-none-both.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-none-both.xml rename tests/qemuxml2xmloutdata/{aarch64-gic-none-tcg.xml => aarch64-gic-none-tcg.aarch64-latest.xml} (93%) create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-none-v2.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-none-v2.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-none-v3.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-none-v3.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-none.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-none.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-v2.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-v2.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/aarch64-gic-v3.xml rename tests/qemuxml2xmloutdata/{aarch64-pci-serial.xml => aarch64-pci-serial.aarch64-latest.xml} (70%) rename tests/qemuxml2xmloutdata/{aarch64-traditional-pci.xml => aarch64-traditional-pci.aarch64-latest.xml} (93%) create mode 100644 tests/qemuxml2xmloutdata/aarch64-usb-controller.aarch64-latest.xml rename tests/qemuxml2xmloutdata/{aarch64-video-default.xml => aarch64-video-default.aarch64-latest.xml} (67%) rename tests/qemuxml2xmloutdata/{aarch64-video-virtio-gpu-pci.xml => aarch64-video-virtio-gpu-pci.aarch64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{aarch64-virtio-pci-manual-addresses.xml => aarch64-virtio-pci-manual-addresses.aarch64-latest.xml} (68%) rename tests/qemuxml2xmloutdata/{mach-virt-serial-compat.xml => mach-virt-console-native.aarch64-latest.xml} (84%) delete mode 120000 tests/qemuxml2xmloutdata/mach-virt-console-native.xml create mode 100644 tests/qemuxml2xmloutdata/mach-virt-console-virtio.aarch64-latest.xml rename tests/qemuxml2xmloutdata/{mach-virt-console-virtio.xml => mach-virt-serial+console-native.aarch64-latest.xml} (68%) delete mode 120000 tests/qemuxml2xmloutdata/mach-virt-serial+console-native.xml create mode 100644 tests/qemuxml2xmloutdata/mach-virt-serial-compat.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/mach-virt-serial-native.aarch64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/mach-virt-serial-native.xml rename tests/qemuxml2xmloutdata/{mach-virt-serial-pci.xml => mach-virt-serial-pci.aarch64-latest.xml} (71%) rename tests/qemuxml2xmloutdata/{mach-virt-serial-usb.xml => mach-virt-serial-usb.aarch64-latest.xml} (93%) -- 2.39.2

2 22

[PATCHv2] storage_file_probe: change maximum len value in vmdk4GetBackingStore
by Anastasia Belova 11 Apr '23

11 Apr '23

desc length should be always less than VIR_STORAGE_MAX_HEADER. If len = VIR_STORAGE_MAX_HEADER, desc may be out of bounds. Fixes: 348b4e254b ("storage: always probe type with buffer") Signed-off-by: Anastasia Belova <abelova(a)astralinux.ru> --- v2: change Fixes: line src/storage_file/storage_file_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage_file/storage_file_probe.c b/src/storage_file/storage_file_probe.c index 9465af5d96..0dcc9c2c54 100644 --- a/src/storage_file/storage_file_probe.c +++ b/src/storage_file/storage_file_probe.c @@ -586,8 +586,8 @@ vmdk4GetBackingStore(char **res, return BACKING_STORE_INVALID; len = buf_size - 0x200; - if (len > VIR_STORAGE_MAX_HEADER) - len = VIR_STORAGE_MAX_HEADER; + if (len >= VIR_STORAGE_MAX_HEADER) + len = VIR_STORAGE_MAX_HEADER - 1; memcpy(desc, buf + 0x200, len); desc[len] = '\0'; start = strstr(desc, prefix); -- 2.30.2

2 1

[libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser
by K Shiva 06 Apr '23

06 Apr '23

In an effort to separate the validation steps from the Parse stage, a part of the validation of virDomainGraphicsListenDef has been moved to domain_validate.h. Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- This is a v3 of: https://listman.redhat.com/archives/libvir-list/2023-April/239265.html diff to v2: - Cleaned patch as to be directly applied onto master branch src/conf/domain_conf.c | 30 +----------------------------- src/conf/domain_validate.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 29 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70e4d52ee6..8df751cc46 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10986,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10998,13 +10997,11 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) { int ret = -1; - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); g_autofree char *address = virXMLPropString(node, "address"); g_autofree char *network = virXMLPropString(node, "network"); g_autofree char *socketPath = virXMLPropString(node, "socket"); @@ -11021,31 +11018,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11148,7 +11120,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..9a1a8ee156 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2627,6 +2627,39 @@ virDomainAudioDefValidate(const virDomainDef *def, return 0; } +static int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics) +{ + const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); + + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { @@ -2640,6 +2673,8 @@ virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) "listen type 'network'")); return -1; } + if (virDomainGraphicsListenDefValidate(&def->listens[i], def) < 0) + return -1; } return 0; -- 2.40.0

3 3

Re: [libvirt PATCH v4] Conf: Move validation of virDomainGraphicsListenDef out of Parser
by K Shiva 06 Apr '23

06 Apr '23

In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: Koninty Shiva Kiran <shiva_kr(a)riseup.net> --- src/conf/domain_conf.c | 30 +----------------------------- src/conf/domain_validate.c | 37 +++++++++++++++++++++++++++++++------ 2 files changed, 32 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70e4d52ee6..8df751cc46 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10986,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10998,13 +10997,11 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) { int ret = -1; - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); g_autofree char *address = virXMLPropString(node, "address"); g_autofree char *network = virXMLPropString(node, "network"); g_autofree char *socketPath = virXMLPropString(node, "socket"); @@ -11021,31 +11018,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11148,7 +11120,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..988f0854a5 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2631,14 +2631,39 @@ static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { size_t i; + const char *graphicsType = virDomainGraphicsTypeToString(def->type); for (i = 0; i < def->nListens; i++) { - if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK && - !def->listens[i].network) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("'network' attribute is required for " - "listen type 'network'")); - return -1; + switch (def->listens[i].type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + if (!def->listens[i].network) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("'network' attribute is required for " + "listen type 'network'")); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; } } -- 2.40.0

1 0

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser virDomainGraphicsListenDef out of Parser
by K Shiva 06 Apr '23

06 Apr '23

In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: Koninty Shiva Kiran <shiva_kr(a)riseup.net> --- Change to previous mail: https://listman.redhat.com/archives/libvir-list/2023-April/239286.html - Previously forgot to add full name under signoff, added it here src/conf/domain_conf.c | 30 +----------------------------- src/conf/domain_validate.c | 37 +++++++++++++++++++++++++++++++------ 2 files changed, 32 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70e4d52ee6..8df751cc46 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10986,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10998,13 +10997,11 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) { int ret = -1; - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); g_autofree char *address = virXMLPropString(node, "address"); g_autofree char *network = virXMLPropString(node, "network"); g_autofree char *socketPath = virXMLPropString(node, "socket"); @@ -11021,31 +11018,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11148,7 +11120,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..988f0854a5 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2631,14 +2631,39 @@ static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { size_t i; + const char *graphicsType = virDomainGraphicsTypeToString(def->type); for (i = 0; i < def->nListens; i++) { - if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK && - !def->listens[i].network) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("'network' attribute is required for " - "listen type 'network'")); - return -1; + switch (def->listens[i].type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + if (!def->listens[i].network) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("'network' attribute is required for " + "listen type 'network'")); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (def->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + def->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; } } -- 2.40.0

1 0

[libvirt PATCH] util: acpi: include unistd.h
by Ján Tomko 06 Apr '23

06 Apr '23

For lseek. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a build breaker fix. src/util/viracpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/viracpi.c b/src/util/viracpi.c index e66df99f03..c96b7c296b 100644 --- a/src/util/viracpi.c +++ b/src/util/viracpi.c @@ -22,6 +22,7 @@ #include <inttypes.h> #include <fcntl.h> +#include <unistd.h> #define LIBVIRT_VIRACPIPRIV_H_ALLOW #include "internal.h" -- 2.39.2

1 0

[PATCH] qemu: snapshot: Allow inactive internal snapshots with uefi
by Peter Krempa 06 Apr '23

06 Apr '23

Historically the snapshot code attempted to forbid internal snapshots with UEFI both in active and inactive case. Unfortunately due to the intricacies of UEFI probing this didn't really work for inactive VMs which made users rely on the feature. Now with the changes to store detected UEFI environment also in the inactive definition this broke the feature for those users. Since the varstore doesn't really change that much in the lifecycle of a VM it usually is okay to simply leave it as is. Restore the functionality for inactive snapshots by disabling the check. In the future when uefi snapshotting will be added the rest of the condition will also be removed. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/460 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_snapshot.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 12ddf19c48..91de8b0c31 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -749,11 +749,17 @@ qemuSnapshotPrepare(virDomainObj *vm, * - if the variable store is raw, the snapshot fails * - allowing a qcow2 image as the varstore would make it eligible to receive * the vmstate dump, which would make it huge - * - offline snapshot would not snapshot the varstore at all * - * Avoid the issues by forbidding internal snapshot with pflash completely. + * While offline snapshot would not snapshot the varstore at all, this used + * to work as auto-detected UEFI firmware was not present in the offline + * definition. Since in most cases the varstore doesn't change it's usually + * not an issue. Allow this as there are existing users of this case. + * + * Avoid the issues by forbidding internal snapshot with pflash if the + * VM is active. */ - if (found_internal && + if (active && + found_internal && virDomainDefHasOldStyleUEFI(vm->def)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("internal snapshots of a VM with pflash based " -- 2.39.2

2 1

[PATCH] viracpi: Fir error format string in virAcpiParseIORTNodeHeader()
by Michal Privoznik 06 Apr '23

06 Apr '23

Inside of virAcpiParseIORTNodeHeader() there's an virReportError() which reports size of a structure using sizeof() operator. Well, it's not well documented but the returned type of sizeof() is apparently size_t but the format string uses %lu. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker rule. Also verified this builds successfully on a 32bit ARM. src/util/viracpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viracpi.c b/src/util/viracpi.c index 74fff0f0ac..e66df99f03 100644 --- a/src/util/viracpi.c +++ b/src/util/viracpi.c @@ -102,7 +102,7 @@ virAcpiParseIORTNodeHeader(int fd, * least size of header itself. */ if (nodeHeader->len < sizeof(*nodeHeader)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("IORT table node type %1$s has invalid length: got %2$u, expected at least %3$lu"), + _("IORT table node type %1$s has invalid length: got %2$u, expected at least %3$zu"), NULLSTR(typeStr), (unsigned int)nodeHeader->len, sizeof(*nodeHeader)); return -1; } -- 2.39.2

1 0

[PATCH v2] Conf: Move validation of virDomainGraphicsListenDef out of Parser
by K Shiva 06 Apr '23

06 Apr '23

From: skran <shiva_kr(a)riseup.net> In an effort to separate the validation steps from the Parse stage, a part of the validation of virDomainGraphicsListenDef has been moved to domain_validate.h. Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- This is a v2 of: https://listman.redhat.com/archives/libvir-list/2023-April/239205.html diff to v1: - Made virDomainGraphicsListenDefValidate() static, called by virDomainGraphicsDefListensValidate() - Removed unused Parameter (*graphics) out of Parse Function definition i.e virDomainGraphicsListenParseXML() - Corrected code format src/conf/domain_conf.c | 9 ++--- src/conf/domain_validate.c | 68 ++++++++++++++++++++------------------ src/conf/domain_validate.h | 4 --- 3 files changed, 37 insertions(+), 44 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e0ac737bb..746bb4efdf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5836,7 +5836,7 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); - // Socket Validation + /* Socket Validation */ if (virDomainStorageNetHostSocketValidate(host, transport) < 0) goto cleanup; @@ -10975,7 +10975,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10987,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) @@ -11009,9 +11007,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - if (virDomainGraphicsListenDefValidate(def, graphics) == -1) - goto error; - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11114,7 +11109,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 10f8242c84..a84dbe8bc9 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2627,6 +2627,39 @@ virDomainAudioDefValidate(const virDomainDef *def, return 0; } +static int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics) +{ + const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); + + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { @@ -2640,6 +2673,8 @@ virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) "listen type 'network'")); return -1; } + if (virDomainGraphicsListenDefValidate(&def->listens[i], def) < 0) + return -1; } return 0; @@ -2669,39 +2704,6 @@ virDomainGraphicsDefValidate(const virDomainDef *def, return 0; } -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics) -{ - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); - - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - return 0; -} - static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index baeae4b2a3..7772a62e18 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -48,9 +48,5 @@ int virDomainDiskDefSourceLUNValidate(const virStorageSource *src); int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOption *xmlopt); -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics); - int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host, const char *transport); -- 2.40.0

3 3

[PATCH v2 0/3] virt-host-validate: Detect SMMU presence on ARMs by parsing IORT table
by Michal Privoznik 06 Apr '23

06 Apr '23

v2 of: https://listman.redhat.com/archives/libvir-list/2023-April/239251.html diff to v1: - Renamed couple of enum values, - fixed their string translations, - Other small nits pointed out by Andrea Michal Prívozník (3): util: Introduce virAcpi module tests: Introduce viracpitest virt-host-validate: Detect SMMU presence on ARMs by parsing IORT table build-aux/syntax-check.mk | 2 +- po/POTFILES | 1 + src/libvirt_private.syms | 7 + src/util/meson.build | 1 + src/util/viracpi.c | 226 ++++++++++++++++++++++++++++ src/util/viracpi.h | 23 +++ src/util/viracpipriv.h | 58 +++++++ tests/meson.build | 1 + tests/viracpidata/IORT_ampere | Bin 0 -> 2304 bytes tests/viracpidata/IORT_empty | Bin 0 -> 65 bytes tests/viracpidata/IORT_gigabyte | Bin 0 -> 10100 bytes tests/viracpidata/IORT_qualcomm | Bin 0 -> 3560 bytes tests/viracpidata/IORT_virt_aarch64 | Bin 0 -> 128 bytes tests/viracpitest.c | 135 +++++++++++++++++ tools/virt-host-validate-common.c | 18 ++- 15 files changed, 468 insertions(+), 4 deletions(-) create mode 100644 src/util/viracpi.c create mode 100644 src/util/viracpi.h create mode 100644 src/util/viracpipriv.h create mode 100644 tests/viracpidata/IORT_ampere create mode 100644 tests/viracpidata/IORT_empty create mode 100644 tests/viracpidata/IORT_gigabyte create mode 100644 tests/viracpidata/IORT_qualcomm create mode 100644 tests/viracpidata/IORT_virt_aarch64 create mode 100644 tests/viracpitest.c -- 2.39.2

2 4

[RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems
by Thomas Huth 05 Apr '23

05 Apr '23

Testing 32-bit host OS support takes a lot of precious time during the QEMU contiguous integration tests, and considering that many OS vendors stopped shipping 32-bit variants of their OS distributions and most hardware from the past >10 years is capable of 64-bit, keeping the 32-bit support alive is an inadequate burden for the QEMU project. Let's mark the 32-bit support as deprecated so we can drop it after a while - this will help us to cut down our limited CI minutes in the gitlab CI, for example. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/about/deprecated.rst | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9f1bbc495d..ce6463e72b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -181,9 +181,20 @@ As Debian 10 ("Buster") moved into LTS the big endian 32 bit version of MIPS moved out of support making it hard to maintain our cross-compilation CI tests of the architecture. As we no longer have CI coverage support may bitrot away before the deprecation process -completes. The little endian variants of MIPS (both 32 and 64 bit) are +completes. The little endian variants of MIPS are still a supported host architecture. +32-bit host operating systems (since 8.0) +''''''''''''''''''''''''''''''''''''''''' + +Testing 32-bit host OS support takes a lot of precious time during the QEMU +contiguous integration tests, and considering that many OS vendors stopped +shipping 32-bit variants of their OS distributions and most hardware from +the past >10 years is capable of 64-bit, keeping the 32-bit support alive +is an inadequate burden for the QEMU project. Thus QEMU will soon drop the +support for 32-bit host systems. + + QEMU API (QAPI) events ---------------------- -- 2.31.1

16 44

[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser
by skran 05 Apr '23

05 Apr '23

Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the *graphics def parameter from ParseXML function as it became unused after moving the validation out of the Parser. [2] I can't find a way to implement virDomainStorageNetHostSocketValidate() as static. Could you please point as to which function within domain_validate.h could be used to call this validation function? similar to virDomainGraphicsDefListensValidate() for [1]. [3] How do I obtain char *transport within the validation function without parameter passing? It's used only to report this error in the below snippet virReportError(VIR_ERR_XML_ERROR, _("transport '%1$s' does not support socket attribute"), transport); Do I use virXMLPropString(hostnode, "transport") after passing xmlNodePtr hostnode as a parameter? How do I obtain these in domain_validate.h. Thank you for your help! Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- src/conf/domain_conf.c | 9 ++--- src/conf/domain_validate.c | 68 ++++++++++++++++++++------------------ src/conf/domain_validate.h | 4 --- 3 files changed, 37 insertions(+), 44 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e0ac737bb..746bb4efdf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5836,7 +5836,7 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); - // Socket Validation + /* Socket Validation */ if (virDomainStorageNetHostSocketValidate(host, transport) < 0) goto cleanup; @@ -10975,7 +10975,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10987,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) @@ -11009,9 +11007,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - if (virDomainGraphicsListenDefValidate(def, graphics) == -1) - goto error; - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11114,7 +11109,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 10f8242c84..a84dbe8bc9 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2627,6 +2627,39 @@ virDomainAudioDefValidate(const virDomainDef *def, return 0; } +static int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics) +{ + const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); + + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { @@ -2640,6 +2673,8 @@ virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) "listen type 'network'")); return -1; } + if (virDomainGraphicsListenDefValidate(&def->listens[i], def) < 0) + return -1; } return 0; @@ -2669,39 +2704,6 @@ virDomainGraphicsDefValidate(const virDomainDef *def, return 0; } -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics) -{ - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); - - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - return 0; -} - static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index baeae4b2a3..7772a62e18 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -48,9 +48,5 @@ int virDomainDiskDefSourceLUNValidate(const virStorageSource *src); int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOption *xmlopt); -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics); - int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host, const char *transport); -- 2.40.0

2 1

[PATCH 0/2] libxl: Support custom EFI firmware path
by Jim Fehlig 05 Apr '23

05 Apr '23

libxl added support for specifying custom firmware paths long ago. This series adds support to the libxl driver and the XML to xl.cfg config converter. Jim Fehlig (2): libxl: Support specifying a custom firmware path libxl: Add support for custom firmware path in config converter src/libxl/libxl_conf.c | 14 ++-- src/libxl/xen_xl.c | 19 +++-- tests/libxlxml2domconfigdata/efi-hvm.json | 91 +++++++++++++++++++++++ tests/libxlxml2domconfigdata/efi-hvm.xml | 36 +++++++++ tests/libxlxml2domconfigtest.c | 1 + tests/xlconfigdata/test-fullvirt-ovmf.cfg | 1 + tests/xlconfigdata/test-fullvirt-ovmf.xml | 2 +- 7 files changed, 150 insertions(+), 14 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.json create mode 100644 tests/libxlxml2domconfigdata/efi-hvm.xml -- 2.39.1

3 5

[libvirt PATCH 00/20] introduce external snapshot revert support
by Pavel Hrdina 05 Apr '23

05 Apr '23

This implements virDomainRevertToSnapshot to work with external snapshots. In addition it modifies virDomainSnapshotDelete to work correctly when we revert to non-leaf snapshot. Gitlab repo with the patches: https://gitlab.com/phrdina/libvirt/-/tree/snapshot-revert-external Pavel Hrdina (20): libvirt_private: list virDomainMomentDefPostParse snapshot_conf: export virDomainSnapshotDiskDefClear snapshot_conf: use alternate domain definition in virDomainSnapshotDefAssignExternalNames snapshot_conf: introduce <revertDisks> metadata element qemu_snapshot: introduce qemuSnapshotDomainDefUpdateDisk qemu_snapshot: use virDomainDiskByName while updating domain def qemu_snapshot: introduce qemuSnapshotCreateQcow2Files qemu_snapshot: allow using alternate domain definition when creating qcow2 files qemu_snapshot: introduce external snapshot revert support qemu_snapshot: rename qemuSnapshotDeleteExternalPrepare qemu_snapshot: extract external snapshot delete prepare to function qemu_snapshot: add blockCommit to external snapshot delete prepare data qemu_snapshot: prepare data for non-active leaf external snapshot deletion qemu_snapshot: add support to delete external snapshot without block commit qemu_snapshot: delete: properly update parent snapshot with revert data qemu_snapshot: don't allow creating external snapshot after reverting virdomainmomentobjlist: introduce virDomainMomentIsAncestor qemu_snapshot: check only once if snapshot is external qemu_snapshot: add checks for external snapshot deletion qemu_snapshot: allow snapshot revert for external snapshots src/conf/schemas/domainsnapshot.rng | 7 + src/conf/snapshot_conf.c | 37 +- src/conf/snapshot_conf.h | 8 + src/conf/virdomainmomentobjlist.c | 21 + src/conf/virdomainmomentobjlist.h | 4 + src/libvirt_private.syms | 6 + src/qemu/qemu_snapshot.c | 621 ++++++++++++++++++++-------- 7 files changed, 538 insertions(+), 166 deletions(-) -- 2.39.2

2 41

Re: [PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser
by skran 04 Apr '23

04 Apr '23

Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the *graphics def parameter from ParseXML function as it became unused after moving the validation out of the Parser. [2] I can't find a way to implement virDomainStorageNetHostSocketValidate() as static. Could you please point as to which function within domain_validate.h could be used to call this validation function? similar to virDomainGraphicsDefListensValidate() for [1]. [3] How do I obtain char *transport within the validation function without parameter passing? It's used only to report this error in the below snippet virReportError(VIR_ERR_XML_ERROR, _("transport '%1$s' does not support socket attribute"), transport); Do I use virXMLPropString(hostnode, "transport") after passing xmlNodePtr hostnode as a parameter? How do I obtain these in domain_validate.h. Thank you for your help! Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- src/conf/domain_conf.c | 9 ++--- src/conf/domain_validate.c | 68 ++++++++++++++++++++------------------ src/conf/domain_validate.h | 4 --- 3 files changed, 37 insertions(+), 44 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1e0ac737bb..746bb4efdf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5836,7 +5836,7 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); - // Socket Validation + /* Socket Validation */ if (virDomainStorageNetHostSocketValidate(host, transport) < 0) goto cleanup; @@ -10975,7 +10975,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, /** * virDomainGraphicsListenDefParseXML: * @def: listen def pointer to be filled - * @graphics: graphics def pointer * @node: xml node of <listen/> element * @parent: xml node of <graphics/> element * @flags: bit-wise or of VIR_DOMAIN_DEF_PARSE_* @@ -10987,7 +10986,6 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node, */ static int virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, - virDomainGraphicsDef *graphics, xmlNodePtr node, xmlNodePtr parent, unsigned int flags) @@ -11009,9 +11007,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - if (virDomainGraphicsListenDefValidate(def, graphics) == -1) - goto error; - if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -11114,7 +11109,7 @@ virDomainGraphicsListensParseXML(virDomainGraphicsDef *def, def->listens = g_new0(virDomainGraphicsListenDef, nListens); for (i = 0; i < nListens; i++) { - if (virDomainGraphicsListenDefParseXML(&def->listens[i], def, + if (virDomainGraphicsListenDefParseXML(&def->listens[i], listenNodes[i], i == 0 ? node : NULL, flags) < 0) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 10f8242c84..a84dbe8bc9 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2627,6 +2627,39 @@ virDomainAudioDefValidate(const virDomainDef *def, return 0; } +static int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics) +{ + const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); + + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) { @@ -2640,6 +2673,8 @@ virDomainGraphicsDefListensValidate(const virDomainGraphicsDef *def) "listen type 'network'")); return -1; } + if (virDomainGraphicsListenDefValidate(&def->listens[i], def) < 0) + return -1; } return 0; @@ -2669,39 +2704,6 @@ virDomainGraphicsDefValidate(const virDomainDef *def, return 0; } -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics) -{ - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); - - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } - return 0; -} - static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index baeae4b2a3..7772a62e18 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -48,9 +48,5 @@ int virDomainDiskDefSourceLUNValidate(const virStorageSource *src); int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOption *xmlopt); -int -virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, - const virDomainGraphicsDef *graphics); - int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host, const char *transport); -- 2.40.0

1 0

[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser
by skran 04 Apr '23

04 Apr '23

I have implemented your corrections successfully. Thank you. Signed-off-by: K Shiva <shiva_kr(a)riseup.net> --- src/conf/domain_conf.c | 42 +++------------------------- src/conf/domain_validate.c | 56 ++++++++++++++++++++++++++++++++++++++ src/conf/domain_validate.h | 7 +++++ 3 files changed, 67 insertions(+), 38 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 70e4d52ee6..1e0ac737bb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5836,20 +5836,9 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); - if (host->transport == VIR_STORAGE_NET_HOST_TRANS_UNIX && - host->socket == NULL) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("missing socket for unix transport")); + // Socket Validation + if (virDomainStorageNetHostSocketValidate(host, transport) < 0) goto cleanup; - } - - if (host->transport != VIR_STORAGE_NET_HOST_TRANS_UNIX && - host->socket != NULL) { - virReportError(VIR_ERR_XML_ERROR, - _("transport '%1$s' does not support socket attribute"), - transport); - goto cleanup; - } if (host->transport != VIR_STORAGE_NET_HOST_TRANS_UNIX) { if (!(host->name = virXMLPropString(hostnode, "name"))) { @@ -11004,7 +10993,6 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, unsigned int flags) { int ret = -1; - const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); g_autofree char *address = virXMLPropString(node, "address"); g_autofree char *network = virXMLPropString(node, "network"); g_autofree char *socketPath = virXMLPropString(node, "socket"); @@ -11021,30 +11009,8 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } + if (virDomainGraphicsListenDefValidate(def, graphics) == -1) + goto error; if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..10f8242c84 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2669,6 +2669,39 @@ virDomainGraphicsDefValidate(const virDomainDef *def, return 0; } +int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics) +{ + const char *graphicsType = virDomainGraphicsTypeToString(graphics->type); + + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { @@ -2898,3 +2931,26 @@ virDomainDeviceDefValidate(const virDomainDeviceDef *dev, return 0; } + +int +virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host, + const char* transport) +{ + if (host->transport == VIR_STORAGE_NET_HOST_TRANS_UNIX && + host->socket == NULL) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("missing socket for unix transport")); + return -1; + } + + if (host->transport != VIR_STORAGE_NET_HOST_TRANS_UNIX && + host->socket != NULL) { + virReportError(VIR_ERR_XML_ERROR, + _("transport '%1$s' does not support socket attribute"), + transport); + return -1; + } + + + return 0; +} diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index fc441cef5b..baeae4b2a3 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -47,3 +47,10 @@ int virDomainDiskDefSourceLUNValidate(const virStorageSource *src); int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOption *xmlopt); + +int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics); + +int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host, + const char *transport); -- 2.40.0

2 1

[PATCH] coding style: Follow our own rule on comment style
by Michal Privoznik 04 Apr '23

04 Apr '23

In our coding style document we have examples of good and bad code, which we mark as: // Good // Bad respectively. But in the very same document we advocate for using C style of comments over C++. Follow our own advice and switch annotation to: /* Good */ /* Bad */ And while at it, align these annotations within their blocks for better readability. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/coding-style.rst | 76 +++++++++++++++++++++---------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 92f6099d82..fe5fe9a906 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -161,24 +161,24 @@ a single space following them before the opening bracket. E.g. :: - if(foo) // Bad - if (foo) // Good + if(foo) /* Bad */ + if (foo) /* Good */ Function implementations must **not** have any whitespace between the function name and the opening bracket. E.g. :: - int foo (int wizz) // Bad - int foo(int wizz) // Good + int foo (int wizz) /* Bad */ + int foo(int wizz) /* Good */ Function calls must **not** have any whitespace between the function name and the opening bracket. E.g. :: - bar = foo (wizz); // Bad - bar = foo(wizz); // Good + bar = foo (wizz); /* Bad */ + bar = foo(wizz); /* Good */ Function typedefs must **not** have any whitespace between the closing bracket of the function name and opening bracket of the @@ -186,16 +186,16 @@ arg list. E.g. :: - typedef int (*foo) (int wizz); // Bad - typedef int (*foo)(int wizz); // Good + typedef int (*foo) (int wizz); /* Bad */ + typedef int (*foo)(int wizz); /* Good */ There must not be any whitespace immediately following any opening bracket, or immediately prior to any closing bracket. E.g. :: - int foo( int wizz ); // Bad - int foo(int wizz); // Good + int foo( int wizz ); /* Bad */ + int foo(int wizz); /* Good */ Commas ------ @@ -206,8 +206,8 @@ syntax-check'. :: - call(a,b ,c);// Bad - call(a, b, c); // Good + call(a,b ,c); /* Bad */ + call(a, b, c); /* Good */ When declaring an enum or using a struct initializer that occupies more than one line, use a trailing comma. That way, future edits @@ -225,11 +225,11 @@ C99 allows trailing commas, remember that JSON and XDR do not. enum { VALUE_ONE, - VALUE_TWO // Bad + VALUE_TWO /* Bad */ }; enum { VALUE_THREE, - VALUE_FOUR, // Good + VALUE_FOUR, /* Good */ }; Semicolons @@ -243,10 +243,10 @@ not enforced, loop counters generally use post-increment. :: - for (i = 0 ;i < limit ; ++i) { // Bad - for (i = 0; i < limit; i++) { // Good - for (;;) { // ok - while (1) { // Better + for (i = 0 ;i < limit ; ++i) { /* Bad */ + for (i = 0; i < limit; i++) { /* Good */ + for (;;) { /* ok */ + while (1) { /* Better */ Empty loop bodies are better represented with curly braces and a comment, although use of a semicolon is not currently rejected. @@ -254,9 +254,9 @@ comment, although use of a semicolon is not currently rejected. :: while ((rc = waitpid(pid, &st, 0) == -1) && - errno == EINTR); // ok + errno == EINTR); /* ok */ while ((rc = waitpid(pid, &st, 0) == -1) && - errno == EINTR) { // Better + errno == EINTR) { /* Better */ /* nothing */ } @@ -271,19 +271,19 @@ single-\ *statement* loop: each has only one *line* in its body. :: - while (expr) // single line body; {} is optional + while (expr) /* single line body; {} is optional */ single_line_stmt(); :: while (expr(arg1, - arg2)) // indentation makes it obvious it is single line, - single_line_stmt(); // {} is optional (not enforced either way) + arg2)) /* indentation makes it obvious it is single line, */ + single_line_stmt(); /* {} is optional (not enforced either way) */ :: while (expr1 && - expr2) { // multi-line, at same indentation, {} required + expr2) { /* multi-line, at same indentation, {} required */ single_line_stmt(); } @@ -295,7 +295,7 @@ braces), thinking it is already a multi-statement loop: :: - while (true) // BAD! multi-line body with no braces + while (true) /* BAD! multi-line body with no braces */ /* comment... */ single_line_stmt(); @@ -303,7 +303,7 @@ Do this instead: :: - while (true) { // Always put braces around a multi-line body. + while (true) { /* Always put braces around a multi-line body. */ /* comment... */ single_line_stmt(); } @@ -325,8 +325,8 @@ To reiterate, don't do this: :: - if (expr) // BAD: no braces around... - while (expr_2) { // ... a multi-line body + if (expr) /* BAD: no braces around... */ + while (expr_2) { /* ... a multi-line body */ ... } @@ -356,11 +356,11 @@ longer, multi-line block be the ``else`` block. ... } else - x = y; // BAD: braceless "else" with braced "then", - // and short block last + x = y; /* BAD: braceless "else" with braced "then", + * and short block last */ if (expr) - x = y; // BAD: braceless "if" with braced "else" + x = y; /* BAD: braceless "if" with braced "else" */ else { ... ... @@ -375,7 +375,7 @@ rather than after the more involved block: :: if (!expr) { - x = y; // putting the smaller block first is more readable + x = y; /* putting the smaller block first is more readable */ } else { ... ... @@ -403,19 +403,19 @@ itself. void foo(int a, int b) - { // correct - function body + { /* correct - function body */ int 2d[][] = { - { // correct - complex initialization + { /* correct - complex initialization */ 1, 2, }, }; if (a) - { // BAD: compound brace on its own line + { /* BAD: compound brace on its own line */ do_stuff(); } - { // correct - nested scope + { /* correct - nested scope */ int tmp; - if (a < b) { // correct - hanging brace + if (a < b) { /* correct - hanging brace */ tmp = b; b = a; a = tmp; @@ -601,7 +601,7 @@ calling another function. x = y + 20; - char *z = NULL; // <=== + char *z = NULL; /* <=== */ ... } -- 2.39.2

2 1

(GSoC) Contributor Application
by Shiva 03 Apr '23

03 Apr '23

Greetings libvirt developers! My name is Shiva and I am interested in contributing to the project titled *"Metadata support for all object schemas". * My apologies for the delay in contact as this is my first time at GSoC and I have missed the dates. Is this the correct mailing list for GSoC Communication? If not please point me to the right one (libvir-users list?). As part of the requirements, I have successfully compiled libvirt on my Arch Linux system and have also created a Merge Request for my first bytesizedtask in request#245 <https://gitlab.com/libvirt/libvirt/-/merge_requests/245>. My understanding of the project is as follows: - Provide support for <metadata>, <title> and <description> tags for all object schemas including networks, nwfilters, interfaces, storage pools etc. - Add set and get metadata public API functions that interact with these tags. - Add an async event callback for each object that notifies of changes in these tags. Please correct me if I have gotten anything wrong. If there is an interview to be conducted, please provide me a schedule for it. I will be happy to provide any additional information. Thank You. SIncerely K Shiva Kiran GSoC Applicant

3 3

[PATCH 1/1] Partial fixes for Issue #7 titled 'Move validation checks out of domain XML parsing'
by skran 03 Apr '23

03 Apr '23

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3ab7cd2666..2a94566047 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5840,14 +5840,14 @@ virDomainStorageNetworkParseHost(xmlNodePtr hostnode, host->socket = virXMLPropString(hostnode, "socket"); if (host->transport == VIR_STORAGE_NET_HOST_TRANS_UNIX && - host->socket == NULL) { + virDomainStorageNetHostSocketValidate(host)) { virReportError(VIR_ERR_XML_ERROR, "%s", _("missing socket for unix transport")); goto cleanup; } if (host->transport != VIR_STORAGE_NET_HOST_TRANS_UNIX && - host->socket != NULL) { + !virDomainStorageNetHostSocketValidate(host)) { virReportError(VIR_ERR_XML_ERROR, _("transport '%1$s' does not support socket attribute"), transport); @@ -11024,30 +11024,8 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDef *def, VIR_XML_PROP_REQUIRED, &def->type) < 0) goto error; - switch (def->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'socket' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: - if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && - graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("listen type 'none' is not available for graphics type '%1$s'"), - graphicsType); - goto error; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: - break; - } + if (virDomainGraphicsListenDefValidate(def, graphics, graphicsType)) + goto error; if (def->type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) { if (address && addressCompat && STRNEQ(address, addressCompat)) { diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 9265fef4f9..b8b8f941cc 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2669,6 +2669,38 @@ virDomainGraphicsDefValidate(const virDomainDef *def, return 0; } +int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics, + const char *graphicsType) +{ + switch (def->type) { + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'socket' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: + if (graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE && + graphics->type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("listen type 'none' is not available for graphics type '%1$s'"), + graphicsType); + return -1; + } + break; + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: + break; + } + return 0; +} + static int virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) { @@ -2898,3 +2930,13 @@ virDomainDeviceDefValidate(const virDomainDeviceDef *dev, return 0; } + +int +virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host) + +{ + if (host->socket) + return 0; + else + return -1; +} diff --git a/src/conf/domain_validate.h b/src/conf/domain_validate.h index fc441cef5b..58ee9b7da5 100644 --- a/src/conf/domain_validate.h +++ b/src/conf/domain_validate.h @@ -47,3 +47,10 @@ int virDomainDiskDefSourceLUNValidate(const virStorageSource *src); int virDomainDefOSValidate(const virDomainDef *def, virDomainXMLOption *xmlopt); + +int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host); + +int +virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def, + const virDomainGraphicsDef *graphics, + const char *graphicsType); -- 2.40.0

3 2