- Devel - libvirt List Archives

[libvirt] [glib 1/5] gconfig: Allow schema to be NULL
by Zeeshan Ali 03 Nov '16

03 Nov '16

Validation (if attempted) should just fail in this case instead of crashing. --- libvirt-gconfig/libvirt-gconfig-object.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 6225de2..851e35c 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -209,6 +209,14 @@ void gvir_config_object_validate(GVirConfigObject *config, return; } + if (!priv->schema) { + gvir_config_set_error_literal(err, + GVIR_CONFIG_OBJECT_ERROR, + 0, + _("No XML schema associated with this config object")); + return; + } + rngParser = xmlRelaxNGNewParserCtxt(priv->schema); if (!rngParser) { gvir_config_set_error(err, -- 2.9.3

3 13

[libvirt] [PATCH] qemu: Reset post-copy capability after migration
by Jiri Denemark 02 Nov '16

02 Nov '16

Unlike other migration capabilities, post-copy is also set on the destination host which means it doesn't disappear once domain is migrated. As a result of that other functionality which internally uses migration to a file (virDomainManagedSave, virDomainSave, virDomainCoreDump) may fail after migration because the post-copy capability is still set. https://bugzilla.redhat.com/show_bug.cgi?id=1374718 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: We need a more generic way to store and reset migration capabilities and parameters on both sides of migration since we need to reset them in case migration fails. But it will need a little bit more work, so let's start with this simple patch fixing the most visible issue. I'll work on the generic solution later. src/qemu/qemu_migration.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1c4a80c..d4a55d8 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -6418,6 +6418,9 @@ qemuMigrationFinish(virQEMUDriverPtr driver, */ if (inPostCopy) VIR_FREE(priv->job.completed); + + qemuMigrationSetPostCopy(driver, vm, false, + QEMU_ASYNC_JOB_MIGRATION_IN); } qemuMigrationJobFinish(driver, vm); -- 2.10.2

2 2

[libvirt] [python PATCH] Post-release version bump to 2.5.0
by Pavel Hrdina 02 Nov '16

02 Nov '16

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as trivial. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..ed11e2e 100755 --- a/setup.py +++ b/setup.py @@ -307,7 +307,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '2.4.0', + version = '2.5.0', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.10.2

1 0

[libvirt] pci-assign fails with read error on config-space file
by Henning Schild 02 Nov '16

02 Nov '16

Hey, i am running an unusual setup where i assign pci devices behind the back of libvirt. I have two options to do that: 1. a wrapper script for qemu that takes care of suid-root and appends arguments for pci-assign 2. virsh qemu-monitor-command ... 'device_add pci-assign...' I know i should probably not be doing this, it is a workaround to introduce fine-grained pci-assignment in an openstack setup, where vendor and device id are not enough to pick the right device for a vm. In both cases qemu will crash with the following output: > qemu: hardware error: pci read failed, ret = 0 errno = 22 followed by the usual machine state dump. With strace i found it to be a failing read on the config space file of my device. /sys/bus/pci/devices/0000:xx:xx.x/config A few reads out of that file succeeded, as well as accesses on vendor etc. Manually launching a qemu with the pci-assign works without a problem, so i "blame" libvirt and the cgroup environment the qemu ends up in. So i put a bash into the exact same cgroup setup - next to a running qemu, expecting a dd or hexdump on the config-space file to fail. But from that bash i can read the file without a problem. Has anyone seen that problem before? Right now i do not know what i am missing, maybe qemu is hitting some limits configured for the cgroups or whatever. I can not use pci-assign from libvirt, but if i did would it configure cgroups in a different way or relax some limits? What would be a good next step to debug that? Right now i am looking at kernel event traces, but the machine is pretty big and so is the trace. That assignment used to work and i do not know how it broke, i have tried combinations of several kernels, versions of libvirt and qemu. (kernel 3.18 and 4.4, libvirt 1.3.2 and 2.0.0, and qemu 2.2.1 and 2.7) All combinations show the same problem, even the ones that work on other machines. So when it comes to software versions the problem could well be caused by a software update of another component, that i got with the package manager and did not compile myself. It is a debian 8.6 with all recent updates installed. My guess would be that systemd could have an influence on cgroups or limits causing such a problem. regards, Henning

5 7

[libvirt] [PATCH] Fill out more fields for PKG-INFO file
by Daniel P. Berrange 02 Nov '16

02 Nov '16

Ensure the description and license are set in PKG-INFO, and clarify the summary field. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- setup.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..5ad4101 100755 --- a/setup.py +++ b/setup.py @@ -311,7 +311,13 @@ setup(name = 'libvirt-python', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', - description = 'The libvirt virtualization API', + description = 'The libvirt virtualization API python binding', + long_description = + '''The libvirt-python package provides a module that permits applications +written in the Python programming language to call the interface +supplied by the libvirt library, to manage the virtualization capabilities +of recent versions of Linux (and other OSes).''', + license = 'LGPLv2+', ext_modules = _c_modules, py_modules = _py_modules, package_dir = { -- 2.9.3

2 1

[libvirt] [PATCH v3 0/6] New libssh transport
by Pino Toscano 02 Nov '16

02 Nov '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v2 to v3: - split into more commits - integrate all the issues spotted by Daniel P. Berrange and Peter Krempa - restore the specified order of authentication methods (as in libssh2) - add a related documentation fix - minor coding fixes Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (6): virNetSocket: allow to not close FD virerror: add error for libssh transport libssh_transport: add new libssh-based transport remote: expose a new libssh transport spec: enable libssh transport on Fedora docs: fix default value for sshauth option of libssh2/libssh config-post.h | 2 + configure.ac | 3 + docs/remote.html.in | 39 +- include/libvirt/virterror.h | 2 + libvirt.spec.in | 10 + m4/virt-libssh.m4 | 26 + po/POTFILES.in | 1 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 22 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 118 ++++ src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1458 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 80 +++ src/rpc/virnetsocket.c | 184 +++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 17 files changed, 2024 insertions(+), 18 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

2 12

[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user
by Nikolay Shirokovskiy 02 Nov '16

02 Nov '16

So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v1: 1. drop 1 patch. Avoiding default label in switches is desired style. 2. drop 2 patch. I do not investigate enough to touch that place. 3. fix 3 patch a) as suggested by Jiri * fix leaks * s/hint/error/g * don't show <NULL> in error message * take suggested code simplifications b) extra * print error string from qemu to log in case we have to drop it Nikolay Shirokovskiy (1): qemu: report block job errors from qemu to the user src/qemu/qemu_blockjob.c | 13 +++++++++-- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration.c | 54 +++++++++++++++++++++++++++++++------------- src/qemu/qemu_monitor.c | 5 ++-- src/qemu/qemu_monitor.h | 4 +++- src/qemu/qemu_monitor_json.c | 4 +++- src/qemu/qemu_process.c | 4 ++++ 10 files changed, 68 insertions(+), 25 deletions(-) -- 1.8.3.1

2 4

[libvirt] [PATCH] Post-release version bump to 2.5.0
by Jiri Denemark 02 Nov '16

02 Nov '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dfc536f..9785e66 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [2.4.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [2.5.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.10.2

1 0

[libvirt] Release of libvirt-2.4.0
by Daniel Veillard 01 Nov '16

01 Nov '16

It's out ! Not hearing any negative feedback on the release candidates I went ahead, this is tagged in git and signed tarball and rpms are now at the usual place: ftp://libvirt.org/libvirt/ I also made a libvirt-python release though it is virtually identical to 2.3.0, to be found at: ftp://libvirt.org/libvirt/python/ this release is on the small side, leass than 250 commits were pulled in, mostly bugfixes and incremental improvement. Main user visible one being the one for I/O throtling and tuning: Documentation: - docs: remove obsolete library.xen file (Daniel P. Berrange) - doc: update virsh domstats documentation for vcpu statistics (Viktor Mihajlovski) - doc: Describe the VCPU states returned by virsh vcpuinfo (Viktor Mihajlovski) - virsh: Fix typos in manpage (Nitesh Konkar) - virsh: Fix commas in manpage to enhance readability. (Nitesh Konkar) - docs: Alter descriptions of perf cpu_cycles (John Ferlan) - docs: Add PCP as monitoring application (Marko Myllynen) - docs: Fix typo in libvirt-domain.h parameter description (John Ferlan) Portability: - virLogDefineOutputs: Fix build without syslog.h (Michal Privoznik) - virt-yajl: Fix detection of yajl requirements (Martin Kletzander) Bug Fixes: - vsh: Pass correct values for command line completion (John Ferlan) - vsh: Using VSH_REQUIRE_OPTION rather than virReportError (Kothapally Madhu Pavan) - network: fix endless loop when starting network with multiple IPs and no dhcp (Laine Stump) - qemu_driver: unlink new domain cfg file when rollback (Chen Hanxiao) - qemu: Fix crash during qemuStateCleanup (Nikolay Shirokovskiy) - daemon: Fix crash during daemon cleanup (Nikolay Shirokovskiy) - qemu: Forbid pinning vCPUs for TCG domain (Chen Hanxiao) - Recreate the USB address cache at reconnect (Ján Tomko) - Fix crash on usb-serial hotplug (Ján Tomko) - virsh: Fix on_shutdown to on_poweroff (Martin Kletzander) - qemu, lxc: Raise error message when resuming running domain (Sławek Kapłoński) - qemu: Fix depedency order in qemuRemoveDiskDevice (John Ferlan) - qemu: Move TLS object remove from DetachChr to RemoveChr (John Ferlan) - libxl: fix leaking of allocated migration ports (Jim Fehlig) - domain: fix migration to older libvirt (Pavel Hrdina) - domain_conf: fix memory leak in virDomainDefAddConsoleCompat (Pavel Hrdina) - bhyve: Need to add parameter to virDomainChrDefNew (John Ferlan) - networkValidate: Forbid new-line char in network name (Sławek Kapłoński) - qemu: always generate the same alias for tls-creds-x509 object (Pavel Hrdina) - qemu_hotplug: fix crash in hot(un)plugging chardev devices (Pavel Hrdina) - util: Alter return value of virReadFCHost and fix mem leak (John Ferlan) - schema: smbios: allow any strings (Peter Krempa) - qemu: command: escape smbios entry strings (Peter Krempa) - testNodeGetCellsFreeMemory: Fix off by one error (Michal Privoznik) - virsh: vcpuinfo: Report proper vcpu numbers and data for offline VMs (Peter Krempa) - virsh: Fix xpath queries for retrieving vcpu count (Peter Krempa) - conf: Fix virDomainShmemDefFind (Martin Kletzander) - qemu: migration: Disallow migration of read only disk (Corey S. McQuay) - tests: Need to initialize data (John Ferlan) - vsh: Fix some issues in auto completion code (John Ferlan) - util: Resolve memory leaks in virLogParse{Output|Filter} (John Ferlan) - tools: Exclude Xen dom0 from libvirt-guests.sh list (Stefan Bader) - tools: Ignore newlines in libvirt-guests.sh guest list (Stefan Bader) - qemu: fix command line building for iommu devices (Daniel P. Berrange) - qemu: monitor: Properly configure backend for UDP chardevs (Peter Krempa) - qemu: attach: Close monitor socket on connection failure (Peter Krempa) - qemu: Don't strictly require JSON monitor for vCPU detection (Peter Krempa) Improvements: - qemu: Minimalize global driver accesses (Michal Privoznik) - vz: remove Bridged network name and rename Routed (Maxim Nestratov) - vz: support type=bridge network interface type correctly (Maxim Nestratov) - Do not try to release virtio serial addresses (Ján Tomko) - Return directly from qemuDomainAttachChrDeviceAssignAddr (Ján Tomko) - Introduce virDomainVirtioSerialAddrAutoAssign again (Ján Tomko) - Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign (Ján Tomko) - wireshark: Rename plugindir to ws_plugindir (Andrea Bolognani) - wireshark: Inject $(prefix) at the right time (Andrea Bolognani) - wireshark: Strip prefix correctly (Andrea Bolognani) - wireshark: Hoist $ws_prefix declaration (Andrea Bolognani) - wireshark: Introduce $ws_modversion (Andrea Bolognani) - qemu: Add support for using AES secret for SCSI hotplug (Gema Gomez) - qemu: Add secret object hotplug for TCP chardev TLS (John Ferlan) - qemu: Add a secret object to/for a char source dev (John Ferlan) - qemu: Need to remove TLS object in RemoveRNGDevice (John Ferlan) - virsh: Add _length parameters to virsh output (John Ferlan) - virsh: Create macros to add IOTUNE values (John Ferlan) - qemu: Add the length options to the iotune command line (John Ferlan) - conf: Add support for blkiotune "_length" options (John Ferlan) - qemu: Add length for bps/iops throttling parameters to driver (John Ferlan) - caps: Add new capability for the bps/iops throttling length (John Ferlan) - include: Add new definitions for duration for bps/iops throttling (John Ferlan) - qemu: Introduce qemuDomainSetBlockIoTuneDefaults (John Ferlan) - qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune (John Ferlan) - qemu: Return real error message for block_set_io_throttle (John Ferlan) - qemu: Create a macro to handle setting bytes/iops iotune values (John Ferlan) - virQEMUCapsReset: also clear out hostCPUModel (Ján Tomko) - qemu: add vcpu.n.halted to vcpu domain stats (Viktor Mihajlovski) - qemu: Add domain support for VCPU halted state (Viktor Mihajlovski) - qemu: Add monitor support for CPU halted state (Viktor Mihajlovski) - qemu: replace calls to virDomainPCIAddressReserveNext*() with static function (Laine Stump) - conf: make virDomainPCIAddressGetNextSlot() a local static function (Laine Stump) - qemu: use virDomainPCIAddressReserveNextAddr in qemuDomainAssignDevicePCISlots (Laine Stump) - conf: new function virDomainPCIAddressReserveNextAddr() (Laine Stump) - domain: Add optional 'tls' attribute for TCP chardev (Pavel Hrdina) - domain_conf: remove union for one member from redirdev struct (Pavel Hrdina) - qemu: Add TLS hotplug for qemuDomainAttachRNGDevice (John Ferlan) - qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Clean up error path in qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug (John Ferlan) - conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr' (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru' (John Ferlan) - xenFormatXLDisk: Unify commas pattern for arguments (Michal Privoznik) - qemu: change first arg of qemuDomainAttachChrDeviceAssignAddr() (Laine Stump) - qemu: make error message in qemuDomainPCIAddressSetCreate more clear. (Laine Stump) - qemu: remove superfluous setting of addrs->nbuses (Laine Stump) - conf: add typedef for anonymous enum used for memballoon device model (Laine Stump) - qemu: replace "def->nets[i]" with "net" and "def->sounds[i]" with "sound" (Laine Stump) - qemu: replace a lot of "def->controllers[i]" with equivalent "cont" (Laine Stump) - conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef (John Ferlan) - Introduce virDomainChrSourceDefNew for virDomainChrDefPtr (John Ferlan) - vmx: Use the allocator virDomainChrDefNew (John Ferlan) - qemuBuildHostNetStr: remove dead code (Ján Tomko) - qemuBuildHostNetStr: do not start options with a comma (Ján Tomko) - qemuBuildHostNetStr: use type_sep earlier (Ján Tomko) - vz: set something in disk driver name (Nikolay Shirokovskiy) - vz: add serial number to disk devices (Nikolay Shirokovskiy) - vz: set localhost as vnc address (Mikhail Feoktistov) - virt-wireshark.m4: Defer $(prefix) substitution (Michal Privoznik) - network: Use new util function to check name (Sławek Kapłoński) - virxml: Add function to check if string contains some illegal chars (Sławek Kapłoński) - qemu: Introduce qemuDomainChardevPrivatePtr (John Ferlan) - conf: Introduce {default|chardev}_tls_x509_secret_uuid (John Ferlan) - xl: fix 8126d870 broken test (Cédric Bosdonnat) - spec: Drop support for Fedora < 23 (Andrea Bolognani) - xl: don't output (null) target in domxml-to-native (Cédric Bosdonnat) - qemu_command: create prefixed alias to separate variable (Pavel Hrdina) - qemu_alias: introduce qemuAliasChardevFromDevAlias helper (Pavel Hrdina) - qemu: Remove unnecessary NULL arg check (John Ferlan) - qemu: Add 'verify-peer=yes' test for chardev TCP TLS (John Ferlan) - qemu: Remove unnecessary cfg fetch/unref (John Ferlan) - conf: Explain some code in more detail (Andrea Bolognani) - conf: restrict what type of buses will accept a pci-bridge (Laine Stump) - conf: Honour flags in virDomainPanicDefParseXML (Martin Kletzander) - schema: Allow alias for panic device (Martin Kletzander) - qemu_hotplug: Support interface type of vhost-user hotplug (Michal Privoznik) - qemuBuildHostNetStr: Support VIR_DOMAIN_NET_TYPE_VHOSTUSER (Michal Privoznik) - qemuBuildVhostuserCommandLine: Unify -netdev creation (Michal Privoznik) - qemuBuildVhostuserCommandLine: Reuse qemuBuildChrChardevStr (Michal Privoznik) - qemuBuildChrChardevStr: Introduce @nowait argument (Michal Privoznik) - qemuBuildHostNetStr: Explicitly enumerate net types (Michal Privoznik) - qemuDomainAttachNetDevice: Explicitly list allowed types for hotplug (Michal Privoznik) - qemuDomainAttachNetDevice: Move hostdev handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move from if-else forest to switch (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move vhostuser handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move hostdev handling a bit further (Michal Privoznik) - virDomainNetGetActualType: Return type is virDomainNetType (Michal Privoznik) - virDomainNetDefParseXML: Realign (Michal Privoznik) - qemu: command: Don't bother reporting errors in smbios formatters (Peter Krempa) - qemu: command: Fix up coding style of smbios commandine formatters (Peter Krempa) - src: Treat PID as signed (Michal Privoznik) - virsh: Be explicit that vol-resize is an offline operation. (Ivan Baldo) - testOpenDefault: Rename loop variable (Michal Privoznik) - qemu_command: add support to use virtio as secondary video device (Pavel Hrdina) - qemu_command: introduce enum of secondary models for video device (Pavel Hrdina) - qemu_command: cleanup qemuBuildVideoCommandLine (Pavel Hrdina) - qemu_command: properly detect which model to use for video device (Pavel Hrdina) - qemu_capabilities: check for existence of virtio-vga (Pavel Hrdina) - qemu_command: pass only video device to qemuBuildVgaVideoCommand (Pavel Hrdina) - qemu_command: separate code for video device via -vga attribute (Pavel Hrdina) - qemu_process: always check capabilities for video devices (Pavel Hrdina) - qemu_process: move video validation out of qemu_command (Pavel Hrdina) - qemu_domain: move video validation out of qemu_command (Pavel Hrdina) - qemu_capabilities: detect properties for virtio-gpu-device (Pavel Hrdina) - qemu_capabilities: rename QEMU_CAPS_VIRTIO_GPU_VIRGL (Pavel Hrdina) - qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated (Pavel Hrdina) - qemu_capabilities: join capabilities for qxl and qxl-vga devices (Pavel Hrdina) - tests: fix some QXL capability combinations that don't make sense (Pavel Hrdina) - qemu_command: remove xenner leftover from video device code (Pavel Hrdina) - qemu_process: move qemuProcessStartValidateGraphics to correct place (Pavel Hrdina) - virsh: Extract fallback handling in cmdVcpuinfo (Peter Krempa) - virsh: Extract cpumap formatting in cmdVcpuinfo (Peter Krempa) - virsh: domain: Fix broken indentation in virshCPUCountCollect (Peter Krempa) - util: bitmap: Make bitmaps const in virBitmapNewData and virBitmapDataToString (Peter Krempa) - libvirt-guests: Weaken dependency on libvirtd (Andrea Bolognani) - qemu: Disable migration with ivshmem (Martin Kletzander) - conf: Don't complicate find loop (Martin Kletzander) - Clean timer in virObjectEventStateFlush (Martin Kletzander) - De-duplicate code into virObjectEventStateCleanupTimer() (Martin Kletzander) - Reference state when using it as opaque (Martin Kletzander) - Change virDomainEventState to virObjectLockable (Martin Kletzander) - qemu: Reuse virDomainDeGetVcpusTopology to calculate total vcpu count (Peter Krempa) - conf: Sanitize cpu topology numbers (Peter Krempa) - util: Remove need for local 'nelems' (John Ferlan) - tests: Prefer virGetLastErrorMessage in testSELinuxLabeling (John Ferlan) - conf: Remove incorrect check when encoding shmem audit message (John Ferlan) - network: add dnsmasq option 'dhcp-authoritative' (Martin Wilck) - Don't update timer if there's none. (Martin Kletzander) - examples: Distribute all systemtap scripts. (Luyao Huang) - virlog: Split parsing and setting priority (Erik Skultety) - virlog: Remove functions that aren't used anywhere anymore (Erik Skultety) - daemon: Split filter parsing and filter defining (Erik Skultety) - daemon: Split output parsing and output defining (Erik Skultety) - virlog: Introduce virLogSetFilters (Erik Skultety) - virlog: Introduce virLogSetOutputs (Erik Skultety) - virlog: Introduce virLogParseFilters (Erik Skultety) - virlog: Introduce virLogParseOutputs (Erik Skultety) - virlog: Introduce virLogParseFilter (Erik Skultety) - virlog: Introduce virLogParseOutput (Erik Skultety) - virlog: Take a special care of syslog when setting new set of log outputs (Erik Skultety) - virlog: Introduce virLogNewOutputTo* as a replacement for virLogAddOutputTo* (Erik Skultety) - virlog: Introduce virLogDefineFilters (Erik Skultety) - virlog: Introduce virLogDefineOutputs (Erik Skultety) - virlog: Introduce virLogFindOutput (Erik Skultety) - virlog: Introduce virLogFilterNew (Erik Skultety) - virlog: Introduce virLogOutputNew (Erik Skultety) - virlog: Store the journald fd within the output object (Erik Skultety) - virlog: Rename virLogParse* to virLogParseAndDefine* (Erik Skultety) - virlog: Remove unused macro IS_SPACE (Erik Skultety) - virsh domdisplay: introduce '--all' for showing all possible graphical displays (Chen Hanxiao) - util: Check/ignore already disabled event (John Ferlan) - util: Clear up some perf error messages (John Ferlan) - private_syms: add virLogFilterListFree to libvirt_private.syms (Erik Skultety) - m4: Drop PKG_PROG_PKG_CONFIG compatibility code (Andrea Bolognani) - docs/Makefile.am: build hvsupport.html earlier (Ján Tomko) - docs/Makefile.am: remove redundant variables (Ján Tomko) - qemu: monitor: Simplify construction of chardev backends (Peter Krempa) - tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev (Peter Krempa) - tests: qemumonitorjson: Don't do multiple tests in one virTestRun (Peter Krempa) - tests: qemu: Add support for testing aguments on monitor verbatim (Peter Krempa) - conf: Sanitize formatting of UDP chardev source (Peter Krempa) - conf: Add a formatting macro for all the blkiotune values (John Ferlan) - qemu: Adjust how supportMaxOptions is used. (John Ferlan) - qemu: Convert from shorthand to longer throttling names (John Ferlan) - tests: Add blkdeviotune-max xml2xmltest (John Ferlan) - include: Update description for <iotune> max params (John Ferlan) - qemu: allow 32 slots on pcie-expander-bus, not just 1 (Laine Stump) - vsh: Fix warnings in command line completer (Jiri Denemark) - qemu: Create helper qemuMonitorJSONGetBlockDevDevice (John Ferlan) - qemu: Create helper qemuMonitorJSONGetBlockDev (John Ferlan) - qemu: Create common code for JSON "query-block" call (John Ferlan) - util: Introduce virJSONValueObjectStealArray (John Ferlan) - rbd: Move the encryption check in build (John Ferlan) - rbd: Change to using heap allocated state contexts (John Ferlan) - rbd: Change virStorageBackendRBDCloseRADOSConn to be static void (John Ferlan) - qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags (Peter Krempa) - lib: Introduce VIR_DOMAIN_VCPU_HOTPLUGGABLE for virDomainSetVcpusFlags (Peter Krempa) - Don't drop expired lease while reading custom leases file (Nehal J Wani) - NSS: Add explicit check to not report expired lease (Nehal J Wani) - remote: Increase bound limit for virDomainGetBlockIoTune (John Ferlan) - remote: Fix erroneous usage of constant (John Ferlan) thanks everybody for your help with the release, be it patch, docs, raising issues, commenting, reviewing patches, localizations, etc... Enjoy the release ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] libvirt label qemu process problem
by zhunxun＠gmail.com 01 Nov '16

01 Nov '16

I found that when using souce code to install libvirt,it labeled qemu process with label "unconfined_u:unconfined_r:svirt_t:s0:c53,c366" instead of "system_u:system_r:svirt_t:s0:c53,c366",is this a bug??can anyone explain it ?? thanks! zhunxun(a)gmail.com

2 1

[libvirt] [PATCH] docs: remove obsolete library.xen file
by Daniel P. Berrange 01 Nov '16

01 Nov '16

The library.xen file contains a braindump of thoughts dating from the very first days of libvirt, when it was briefly called libxen. This is not useful and potentially misleading or confusing for people. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- cfg.mk | 2 +- docs/library.xen | 100 ------------------------------------------------------- 2 files changed, 1 insertion(+), 101 deletions(-) delete mode 100644 docs/library.xen diff --git a/cfg.mk b/cfg.mk index 9546853..a4305a8 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1220,7 +1220,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \ ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$ exclude_file_name_regexp--sc_prohibit_empty_first_line = \ - ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/(vmwarever|virhostcpu)data/.*)$$ + ^(README|daemon/THREADS\.txt|src/esx/README|tests/(vmwarever|virhostcpu)data/.*)$$ exclude_file_name_regexp--sc_prohibit_useless_translation = \ ^tests/virpolkittest.c diff --git a/docs/library.xen b/docs/library.xen deleted file mode 100644 index 2e1b2c5..0000000 --- a/docs/library.xen +++ /dev/null @@ -1,100 +0,0 @@ - - About a libxen library - ====================== - -Functional description: ------------------------ - - Small C library to be able to control Xen Linux guest, i.e. - provide the following operations for Xen guest domains running Linux - from domain 0 code linked to the library (running as root): - - start - - stop - - suspend - - resume - - monitor - More advanced features should be allowed as future extensions, but - are not expected to be provided in first shipment. - - Open enough Licence that customers can link their apps to it (LGPL) - - Small and contained enough that we can use it as a way to - provide API and ABI stability in spite if the evolution of Xen - existing API and hypervisor calls. - -The current state of Xen userland: ----------------------------------- - - the existing Xen 3.0 userland code is mostly based on tiny C functions -using direct hypervisor calls (or /proc/xen/ interfaces) and a lot of -Python code on top driving the hypervisor. - The C code is relatively hairy, functions with 10 parameters or more -are not uncommon, and it is very low level usually without comment about -the function or its arguments. They are usually only called once in the -whole tree by the python bindings. In essence it looks like the Xen project -was not implemented with the idea of reusing that part of the code by -applications. - Indeed most of the userland code coming with Xen is built on Python, -like xend the xen daemon running on domain 0 or the xenstored daemon which -manage the state of the domains launched. - -Rebuilding a library ?: ------------------------ - - Providing a library at the C level to drive domain execution is in a -very large part a rimplementation of existing code but in a different way -and somehow with different goals for the code. The existing Licence (GPL) -makes it uneasy, we can't copy GPL code to put it in a LGPL'ed library, -and rewriting everything while looking at the Xen code will inevitably -lead to code similarities especially with this kind of system code. Plus -we will still need to run xend and probably xenstored to not diverge -completely from Xen existing code base. - -The IBM way: ------------- - - Here is supposition about code that I can't instanciate except by looking -at said code but it looks that IBM also needed a C programmatic API to -manage the Xen domain definitions. Their solution was to build (Rusty -Russell did this) an LGPL C API connecting directly to the xenstore -daemon (./tools/xenstore/*). In a way this is quite more fragile as it depends -on the whole existing stack of the Xen code, but it isolate the API -from the implementation details of the current Xen source (API in -./tools/xenstore/xs.h). The goal seems to be more about testing and controlling -the xen store daemon, but it shows a different approach to decouple client -API/ABI from the Xen existing code. - -Open question: ---------------- - - To what extent should libxen be a rewrite or an isolation layer around -some of the existing code ? - - Rewrite: - - Pros: - - avoid the GPL Licence problem potentially more users - - allow do build a cleaner more stable layer - - the existing code is frightening - Cons: - - awful lot of work debugging very hard - - will still require existing Xen code to be running - - splitting interfaces is hard politically and lower the - Open Source efforts toward the project - - Wrappers on top of existing code: - - Pros: - - much smaller code rewrite - - benefits from the bugfixes injected by other patchers upstream - Cons: - - Licence constraint GPL only for apps - - API/ABI isolation may not be easier in that way - - Potentially the API could be implemented as a layer on top of the existing -libxc C code library and then progressively migrating out the existing -dependence to Xen code as the interfaces stabilize. - -Daniel Veillard <veillard(a)redhat.com> - -Mon Oct 24 18:40:19 CEST 2005 -- 2.9.3

2 2

[libvirt] [PATCH 0/2] Add support for preallocated fd memory
by Jaroslav Safka 01 Nov '16

01 Nov '16

Hi, we would like to introduce 3 new elements source,access and allocation in memoryBacking element. <memoryBacking> <source type="file|anonymous"/> <access Mode="shared|private"/> <allocation mode="immediate|ondemand"/> </memoryBacking> If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu -numa node,memdev=mem Should be added to the qemu commandline If access is shared then the share=on parameter should be added to the memory-backend-file e.g. -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu,share=on Also token memAccess in numa cell is used (if not present, default value from memoryBacking is used) Jaroslav Safka (2): Add support for preallocated fd memory Add support for preallocated fd memory docs/schemas/domaincommon.rng | 30 ++++ src/conf/domain_conf.c | 138 +++++++++++++----- src/conf/domain_conf.h | 33 +++++ src/qemu/qemu_command.c | 156 ++++++++++++++++----- src/qemu/qemu_command.h | 4 + .../qemuxml2argv-fd-memory-no-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-no-numa-topology.xml | 91 ++++++++++++ .../qemuxml2argv-fd-memory-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-numa-topology.xml | 94 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology2.args | 36 +++++ .../qemuxml2argv-fd-memory-numa-topology2.xml | 95 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology3.args | 39 ++++++ .../qemuxml2argv-fd-memory-numa-topology3.xml | 96 +++++++++++++ .../qemuxml2argv-memorybacking-set.xml | 32 +++++ .../qemuxml2argv-memorybacking-unset.xml | 32 +++++ tests/qemuxml2argvtest.c | 42 ++++++ .../qemuxml2xmlout-memorybacking-set.xml | 40 ++++++ .../qemuxml2xmlout-memorybacking-unset.xml | 40 ++++++ tests/qemuxml2xmltest.c | 3 + 19 files changed, 1001 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-set.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-unset.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-set.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-unset.xml -- 2.7.4 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

2 3

[libvirt] [PATCH] domain_event.c: Fix a typo
by Kothapally Madhu Pavan 01 Nov '16

01 Nov '16

Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/conf/domain_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63ae9e1..f1249ad 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -1839,7 +1839,7 @@ virDomainEventDispatchDefaultFunc(virConnectPtr conn, virDomainEventJobCompletedPtr ev; ev = (virDomainEventJobCompletedPtr) event; - ((virConnectDomainEventJobCompletedCallback) cb)(conn, dom, + ((virConnectDomainEventJobCompletedCallback)cb)(conn, dom, ev->params, ev->nparams, cbopaque);

2 2

[libvirt] [PATCH v2 python 0/2] fix crash in libvirt_virDomainPin*
by Konstantin Neumoin 01 Nov '16

01 Nov '16

this small patch set: * move common logic of all libvirt_virDomainPin* functions to new helper in util module. * add check for pycpumap length. Changes since v1: - add new helper in util module. Konstantin Neumoin (2): minor clean-up for libvirt_virDomainPin* add check for pycpumap length libvirt-override.c | 131 +++++------------------------------------------------ libvirt-utils.c | 63 ++++++++++++++++++++++++++ libvirt-utils.h | 5 ++ 3 files changed, 79 insertions(+), 120 deletions(-) -- 2.5.5

2 5

[libvirt] VLAN-based direct interface
by Ed Swierk 31 Oct '16

31 Oct '16

In my setup, the network interfaces of several KVM-based VMs all communicate with the outside world via a single host interface, which is in turn connected to an external switch that handles all network policy to/from/between VMs. Traffic between the host and the switch is segregated by VLAN ID, one per vNIC. When I spin up a new VM with one vNIC assigned (say) VLAN ID 101, I run ip link add link eth0 name eth0.101 type vlan id 101. In the libvirt config I write <interface type='direct' trustGuestRxFilters='yes'> <source dev='eth0.101' mode='passthrough'/> <model type='virtio'/> </interface> This causes libvirt to create a macvtap interface attached to eth0.101 in passthrough mode. So far, so good. The guest OS thinks it has a plain old NIC on an untagged switch port. When the guest OS joins an IPv6 link-local solicited-node multicast group, QEMU tells libvirt to add the corresponding multicast MAC address to the macvtap interface. I can even run a trunk port all the way through to the VM, with traffic double-tagged through the switch-host hop. Trouble arises if I change the model from virtio to e1000, to support an application that doesn't (yet) have virtio drivers. QEMU doesn't expose state via query-rx-filter for e1000 interfaces, so libvirt can't sync multicast MAC addresses from the guest to the macvtap interface, so the guest can't talk IPv6. Ideally QEMU would support query-rx-filter for e1000 and other NIC models. But for my application all the careful syncing of guest rx filter state is overkill: I need the macvtap interface to pass all traffic between the guest and host with no filtering at all. I can achieve this simply by enabling promiscuous mode on the macvtap interface. But libvirt creates the interface, and I don't see any way to get libvirt to enable promiscuous mode and leave it enabled. It wouldn't be hard to add another configuration flag that tells libvirt to just put the macvtap interface into promiscuous mode and skip syncing guest rx filters. Perhaps add another value for trustGuestRxFilters, like 'promisc'? However just solving that minor problem seems like piling one hack on top of another: taking a normal interface and attaching a VLAN interface to it, then attaching a macvtap interface to that, and beating the mac out of the macvtap until it behaves like a dumb bridge (or, attaching a bridge to the VLAN interface, creating a tap interface, and enslaving the tap to the bridge, old-school). What I'm really after is just another kind of direct interface that attaches to a host interface, but instead of directing traffic to the guest by MAC address it uses the VLAN ID (and also adds/strips the tag). libvirt could implement this by automating all the steps I just described. Or if the kernel ever sprouts the VLAN equivalent of the macvtap driver (vlanvtap?), libvirt could just use that. Any opinions on first-class support for a VLAN-based direct interface, versus just allowing configuration of promiscuous mode on a macvtap direct interface? --Ed

1 0

[libvirt] [PATCH v3.1 00/10] Implementation of QEMU vhost-scsi
by Eric Farman 31 Oct '16

31 Oct '16

This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host setup via targetcli (SCSI LUN(s) are already defined to host): # targetcli targetcli shell version 2.1.fb35 Copyright 2011-2013 by Datera, Inc and others. For help on commands, type 'help'. /> backstores/block create write_back=false name=disk1 \ dev=/dev/disk/by-id/dm-name-36005076306ffc7630000000000002211 Created block storage object disk1 using /dev/disk/by-id/dm-name-36005076306ffc7630000000000002211. /> vhost/ create Created target naa.5001405df3e54061. Created TPG 1. /> vhost/naa.5001405df3e54061/tpg1/luns create /backstores/block/disk1 Created LUN 0. /> exit Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v3.1: - Rebase - Rebased to current master (31 October) - Included the prereq for the subsystem type in switch statements (oops!) v3: https://www.redhat.com/archives/libvir-list/2016-October/msg01201.html - Rebase - Rebased to current master (26 October) - Comments - Added an early patch to do some additional typecasting in the switch statements of hostdev.subsys.type - Did some reordering of patches, to hopefully flow better - Implemented an activeHostHostdevs list, which is used by the cgroup and security codepaths - doc changes -- s/2.2/2.5/ and s/HBI/HBA/ - Added a "none" protocol type for scsi_host hostdevs (which is invalid) - Restored the apparmor and selinux codepaths that got lost from v1 - Added a proper check for a valid scsi_host protocol, and saving that value within the HostdevDef struct - Fixed a compiler warning with call to virDomainPCIAddressEnsureAddr - Removed the rest of vhostfdSize, since multiple fd's are not allowed by QEMU - Fixed cleanup of vhostfd in error from building -device string - Moved the "conf" chunk from "hotplug" patch to "introduce" patch - Added xml2xml test - Added a proper calculation of "address" in virDomainAuditHostdev - Added a virFileExists check before open(/dev/vhost-scsi) - Addressed a number of lines >80 characters - Things *NOT* done (later?) - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (10): Cleanup switch statements on the hostdev subsystem type qemu: Introduce vhost-scsi capability Introduce a "scsi_host" hostdev type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi test docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 102 ++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 19 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 50 +++- src/qemu/qemu_command.c | 79 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 10 + src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 160 +++++++++++ src/security/security_apparmor.c | 24 +- src/security/security_dac.c | 46 ++++ src/security/security_selinux.c | 51 +++- src/util/virhost.c | 301 +++++++++++++++++++++ src/util/virhost.h | 72 +++++ src/util/virhostdev.c | 155 +++++++++++ src/util/virhostdev.h | 16 ++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml | 1 + tests/qemuxml2xmltest.c | 3 + 41 files changed, 1294 insertions(+), 14 deletions(-) create mode 100644 src/util/virhost.c create mode 100644 src/util/virhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml -- 1.9.1

1 10

[libvirt] [PATCH RESEND] qemu_driver: unlink new domain cfg file when rollback
by Chen Hanxiao 31 Oct '16

31 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> If we failed to unlink old dom cfg file, we goto rollback. But inside rollback, we fogot to unlink the new dom cfg file. This patch fixes this issue. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_driver.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e6f845d..3f4a2fb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19869,6 +19869,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, char *new_dom_name = NULL; char *old_dom_name = NULL; char *old_dom_cfg_file = NULL; + char *new_dom_cfg_file = NULL; virCheckFlags(0, ret); @@ -19882,6 +19883,11 @@ qemuDomainRenameCallback(virDomainObjPtr vm, goto cleanup; } + if (!(new_dom_cfg_file = virDomainConfigFile(cfg->configDir, + new_dom_name))) { + goto cleanup; + } + event_old = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_UNDEFINED, VIR_DOMAIN_EVENT_UNDEFINED_RENAMED); @@ -19909,6 +19915,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, cleanup: VIR_FREE(old_dom_cfg_file); + VIR_FREE(new_dom_cfg_file); VIR_FREE(old_dom_name); VIR_FREE(new_dom_name); qemuDomainEventQueue(driver, event_old); @@ -19922,6 +19929,10 @@ qemuDomainRenameCallback(virDomainObjPtr vm, vm->def->name = old_dom_name; old_dom_name = NULL; } + + if (virFileExists(new_dom_cfg_file)) + unlink(new_dom_cfg_file); + goto cleanup; } -- 1.8.3.1

4 4

[libvirt] [PATCH v3 0/9] Implementation of QEMU vhost-scsi
by Eric Farman 31 Oct '16

31 Oct '16

[Author note: Apologies for an extra release or two in between versions, I was sidetracked by another project. This is probably too close to the impending freeze for 2.4, so I just updated doc to 2.5 in anticipation. In rearranging the patches, I've inserted a cleanup patch at the head that was mentioned in the v2 review, and which could go separately.] This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v2.1->v3: - Rebase - Rebased to current master (26 October) - Comments - Added an early patch to do some additional typecasting in the switch statements of hostdev.subsys.type - Did some reordering of patches, to hopefully flow better - Implemented an activeHostHostdevs list, which is used by the cgroup and security codepaths - doc changes -- s/2.2/2.5/ and s/HBI/HBA/ - Added a "none" protocol type for scsi_host hostdevs (which is invalid) - Restored the apparmor and selinux codepaths that got lost from v1 - Added a proper check for a valid scsi_host protocol, and saving that value within the HostdevDef struct - Fixed a compiler warning with call to virDomainPCIAddressEnsureAddr - Removed the rest of vhostfdSize, since multiple fd's are not allowed by QEMU - Fixed cleanup of vhostfd in error from building -device string - Moved the "conf" chunk from "hotplug" patch to "introduce" patch - Added xml2xml test - Added a proper calculation of "address" in virDomainAuditHostdev - Added a virFileExists check before open(/dev/vhost-scsi) - Addressed a number of lines >80 characters - Things *NOT* done (later?) - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (9): qemu: Introduce vhost-scsi capability Introduce a "scsi_host" hostdev type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi test docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 91 ++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 19 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 39 +++ src/qemu/qemu_command.c | 79 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 10 + src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 160 +++++++++++ src/security/security_apparmor.c | 20 ++ src/security/security_dac.c | 46 ++++ src/security/security_selinux.c | 43 +++ src/util/virhost.c | 301 +++++++++++++++++++++ src/util/virhost.h | 72 +++++ src/util/virhostdev.c | 155 +++++++++++ src/util/virhostdev.h | 16 ++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml | 1 + tests/qemuxml2xmltest.c | 3 + 41 files changed, 1272 insertions(+), 2 deletions(-) create mode 100644 src/util/virhost.c create mode 100644 src/util/virhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml -- 1.9.1

2 11

[libvirt] [PATCH] vsh: Pass correct values for command line completion
by John Ferlan 31 Oct '16

31 Oct '16

Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to vshCmddefGetData, but that seems to be incorrect as those values are not initialized properly (something at least one compiler found). Instead the static 'const_opts_need_arg' and 'const_opts_seen' values should be passed. By passing unitialized values leads to not finding possible options for simpler commands (domfsfreeze for example), where if you're in a virsh shell using command line completion - you'll get a list of files in your current directory instead of two options --domain and --mountpoint (as would happen with this patch applied. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/vsh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 9558dad..17199ae 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2788,7 +2788,8 @@ vshReadlineParse(const char *text, int state) /* No -- option provided and some other token given * Try to find the default option. */ - if (!(opt = vshCmddefGetData(cmd, &opts_need_arg, &opts_seen)) + if (!(opt = vshCmddefGetData(cmd, &const_opts_need_arg, + &const_opts_seen)) || opt->type == VSH_OT_BOOL) goto error; opt_exists = true; -- 2.7.4

2 1

[libvirt] [PATCH v3] Fixes virsh save-restore/migration when memory detach not in LIFO
by Nitesh Konkar 31 Oct '16

31 Oct '16

Currently the migration stream references the memory blocks by name (which is supplied by libvirt) rather than by there order. With the current code that is assigning aliases for memory backend objects this won't happen and since qemu is treating the memory object links differently migration does not work in such case. This patch ensures slot number alocation for the memory modules beforehand and assign alias accordingly. This keeps slot numbers consistent with the aliases always. Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/conf/domain_conf.h | 1 + src/qemu/qemu_alias.c | 36 +++++++++++++++++++++++++----------- src/qemu/qemu_alias.h | 6 ++++-- src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_hotplug.c | 5 ++++- 5 files changed, 37 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index fd3ae8e..22b5fe1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2145,6 +2145,7 @@ struct _virDomainDef { virDomainBlkiotune blkio; virDomainMemtune mem; + virBitmapPtr memslotsptr; virDomainVcpuDefPtr *vcpus; size_t maxvcpus; diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c index cc83fec..8deb054 100644 --- a/src/qemu/qemu_alias.c +++ b/src/qemu/qemu_alias.c @@ -332,21 +332,34 @@ qemuAssignDeviceRNGAlias(virDomainDefPtr def, } -int -qemuAssignDeviceMemoryAlias(virDomainDefPtr def, - virDomainMemoryDefPtr mem) +void +qemuAssignDeviceMemorySlot(virDomainDefPtr def, + virDomainMemoryDefPtr mem) { size_t i; - int maxidx = 0; - int idx; + int minidx = 0; - for (i = 0; i < def->nmems; i++) { - if ((idx = qemuDomainDeviceAliasIndex(&def->mems[i]->info, "dimm")) >= maxidx) - maxidx = idx + 1; + if (mem->info.addr.dimm.base) { + minidx = mem->info.addr.dimm.slot; + } else { + for (i = 0; i < def->mem.memory_slots; i++) { + if (!virBitmapIsBitSet(def->memslotsptr, i)) { + minidx = i; + break; + } + } } - if (virAsprintf(&mem->info.alias, "dimm%d", maxidx) < 0) - return -1; + ignore_value(virBitmapSetBit(def->memslotsptr, minidx)); + mem->info.addr.dimm.slot = minidx; +} + + +int +qemuAssignDeviceMemoryAlias(virDomainMemoryDefPtr mem) +{ + if (virAsprintf(&mem->info.alias, "dimm%d", mem->info.addr.dimm.slot) < 0) + return -1; return 0; } @@ -475,7 +488,8 @@ qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) return -1; } for (i = 0; i < def->nmems; i++) { - if (virAsprintf(&def->mems[i]->info.alias, "dimm%zu", i) < 0) + qemuAssignDeviceMemorySlot(def, def->mems[i]); + if (virAsprintf(&def->mems[i]->info.alias, "dimm%d", def->mems[i]->info.addr.dimm.slot) < 0) return -1; } diff --git a/src/qemu/qemu_alias.h b/src/qemu/qemu_alias.h index 11d9fde..c6cb568 100644 --- a/src/qemu/qemu_alias.h +++ b/src/qemu/qemu_alias.h @@ -57,8 +57,10 @@ int qemuAssignDeviceRedirdevAlias(virDomainDefPtr def, int qemuAssignDeviceRNGAlias(virDomainDefPtr def, virDomainRNGDefPtr rng); -int qemuAssignDeviceMemoryAlias(virDomainDefPtr def, - virDomainMemoryDefPtr mems); +void qemuAssignDeviceMemorySlot(virDomainDefPtr def, + virDomainMemoryDefPtr); + +int qemuAssignDeviceMemoryAlias(virDomainMemoryDefPtr mems); int qemuAssignDeviceShmemAlias(virDomainDefPtr def, virDomainShmemDefPtr shmem, diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9b1a32e..263e78f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2386,6 +2386,9 @@ qemuDomainDefPostParse(virDomainDefPtr def, if (qemuDomainDefVcpusPostParse(def) < 0) goto cleanup; + if (def->mem.memory_slots) + def->memslotsptr = virBitmapNew(def->mem.memory_slots); + ret = 0; cleanup: virObjectUnref(qemuCaps); diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 72dd93b..5a3af10 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1898,7 +1898,9 @@ qemuDomainAttachMemory(virQEMUDriverPtr driver, if (qemuDomainDefValidateMemoryHotplug(vm->def, priv->qemuCaps, mem) < 0) goto cleanup; - if (qemuAssignDeviceMemoryAlias(vm->def, mem) < 0) + qemuAssignDeviceMemorySlot(vm->def, mem); + + if (qemuAssignDeviceMemoryAlias(mem) < 0) goto cleanup; if (virAsprintf(&objalias, "mem%s", mem->info.alias) < 0) @@ -4427,6 +4429,7 @@ qemuDomainDetachMemoryDevice(virQEMUDriverPtr driver, } mem = vm->def->mems[idx]; + ignore_value(virBitmapClearBit(vm->def->memslotsptr, memdef->info.addr.dimm.slot)); if (!mem->info.alias) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", -- 1.9.3

3 2

[libvirt] Entering freeze for libvirt-2.4.0
by Daniel Veillard 30 Oct '16

30 Oct '16

As planned I just tagged the release in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Not in my normal environment this week so I hadn't had a chance to test the build before pushing, sorry about this but things went smoothly, I noticed a warning in virsh however: CC virsh-virsh-host.o vsh.c: In function 'vshReadlineParse': vsh.c:516:9: warning: 'opts_need_arg' may be used uninitialized in this function [-Wmaybe-uninitialized] i = ffsl(*opts_need_arg) - 1; ^~~~~~~~~~~~~~~~~~~~ vsh.c:2658:14: note: 'opts_need_arg' was declared here uint64_t opts_need_arg, opts_seen; ^~~~~~~~~~~~~ that probably ought to be fixed for release. I hope to be able to push RC2 during the week-end and possibly the final 2.4.0 on the 1st Nov if all goes well. please give it some testing, thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] [PATCH v2] vsh: Using VSH_REQUIRE_OPTION rather than virReportError
by Kothapally Madhu Pavan 28 Oct '16

28 Oct '16

Correcting the error reporting method by using VSH_REQUIRE_OPTION instead of virReportError Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- tools/virsh-domain.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 050e7fb..e1cb2ac 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10443,6 +10443,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS("live", "offline"); VSH_EXCLUSIVE_OPTIONS("timeout-suspend", "timeout-postcopy"); + VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy"); if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; @@ -10474,12 +10475,6 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) } if (vshCommandOptBool(cmd, "postcopy-after-precopy")) { - if (!vshCommandOptBool(cmd, "postcopy")) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("--postcopy-after-precopy can only be used with " - "--postcopy")); - goto cleanup; - } iterEvent = virConnectDomainEventRegisterAny( priv->conn, dom, VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION,

2 1

[libvirt] [PATCH 00/17] Avoid races with udev
by Michal Privoznik 28 Oct '16

28 Oct '16

I've came across interesting bug recently. The problem was that user tried to start a domain, but qemu was denied access to some device. Even though we relabelled it initially. By debugging I found the root cause: while we were starting qemu, udev came and restored original security labels. Sigh. We have two options here: a) write out series of udev rules so that whenever it tries to relabel something our rule will stop it from doing so b) write a small helper binary that will udev call in order to: 1) detect whether device is in use by libvirt 2) get seclabel that was set by libvirt These patches implement the latter approach. While these patches make life easier for us, there is still a race when udev might restore the device's seclabel before we had chance to flush internal database of seclabels for the helper binary. This is something I'm currently focusing on. But before I get there, here are patches that makes the problem much more bearable. In case you want to try these patches, here are some scratch builds: https://mprivozn.fedorapeople.org/udev/ Also, you can find them on my branch: https://github.com/zippy2/libvirt/commits/udev_labels2 This beast is turned off by default, to turn it on you'll need to add: write_udev=1 to qemu.conf. Michal Privoznik (17): virseclabel.h: Include stdbool.h virseclabel: Introduce virSecurityDeviceLabelDefNewLabel security_dac: Pass manager to virSecurityDACSetImageLabel security_dac: Pass manager to virSecurityDACRestoreFileLabelInternal virudev: Introduce basic skeleton virudev: Implement virUdevMgrAddLabel and virUdevMgrRemoveAllLabels virudev: Introduce virUdevMgrDump tests: Introduce virudevtest virudev: Parse virUdevMgr from JSON virudev: Introduce virUdevMgrLookupLabels util: Introduce libvirt_udevhelper security: Wire up virUdevMgr qemu.conf: Introduce write_udev qemu: Wire up virUdevMgr qemu: Reload virUdevMgr on start virudevtest: Introduce device filtering qemu: Filter uninteresting paths for virUdevMgr libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + po/POTFILES.in | 2 + src/Makefile.am | 21 ++ src/libvirt_private.syms | 15 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 5 + src/qemu/qemu_conf.c | 3 + src/qemu/qemu_conf.h | 5 + src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 40 +- src/qemu/qemu_hotplug.c | 35 +- src/qemu/qemu_process.c | 47 ++- src/qemu/qemu_process.h | 3 + src/qemu/test_libvirtd_qemu.aug.in | 1 + src/security/security_dac.c | 103 ++++-- src/security/security_manager.c | 16 + src/security/security_manager.h | 5 + src/security/security_selinux.c | 47 ++- src/util/udevhelper.c | 137 +++++++ src/util/virseclabel.c | 14 + src/util/virseclabel.h | 6 + src/util/virudev.c | 588 ++++++++++++++++++++++++++++++ src/util/virudev.h | 63 ++++ tests/Makefile.am | 12 + tests/virudevmock.c | 29 ++ tests/virudevtest.c | 312 ++++++++++++++++ tests/virudevtestdata/complex.json | 30 ++ tests/virudevtestdata/empty.json | 5 + tests/virudevtestdata/simple-dac.json | 13 + tests/virudevtestdata/simple-selinux.json | 13 + 32 files changed, 1535 insertions(+), 54 deletions(-) create mode 100644 src/util/udevhelper.c create mode 100644 src/util/virudev.c create mode 100644 src/util/virudev.h create mode 100644 tests/virudevmock.c create mode 100644 tests/virudevtest.c create mode 100644 tests/virudevtestdata/complex.json create mode 100644 tests/virudevtestdata/empty.json create mode 100644 tests/virudevtestdata/simple-dac.json create mode 100644 tests/virudevtestdata/simple-selinux.json -- 2.8.4

5 35

[libvirt] [PATCH] network: fix endless loop when starting network with multiple IPs and no dhcp
by Laine Stump 28 Oct '16

28 Oct '16

(From the "How the Hell did I not see this?" files) commit 9065cfaa added the ability to disable DNS services for a libvirt virtual network. If neither DNS nor DHCP is needed for a network, then we don't need to start dnsmasq, so code was added to check for this. Unfortunately, it was written with a great lack of attention to detail (I can say that, because I was the author), and the loop that checked if DHCP is needed for the network would never end if the network had multiple IP addresses, and none of them had a <dhcp> section (which would have contained a <range> or <host> element). This patch rewrites the check to be more compact and (more importantly) finite. This bug was present in release 2.2.0 and 2.3.0, so will need to be backported to any relevant maintainence branches. Reported here: https://www.redhat.com/archives/libvirt-users/2016-October/msg00032.html https://www.redhat.com/archives/libvirt-users/2016-October/msg00045.html --- src/network/bridge_driver.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 9d7fc31..a3ee3f3 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1410,20 +1410,22 @@ networkStartDhcpDaemon(virNetworkDriverStatePtr driver, int ret = -1; dnsmasqContext *dctx = NULL; - if (!(ipdef = virNetworkDefGetIPByIndex(network->def, AF_UNSPEC, 0))) { - /* no IP addresses, so we don't need to run */ - ret = 0; - goto cleanup; - } - /* see if there are any IP addresses that need a dhcp server */ - for (i = 0; ipdef && !needDnsmasq; - ipdef = virNetworkDefGetIPByIndex(network->def, AF_UNSPEC, i + 1)) { + i = 0; + while ((ipdef = virNetworkDefGetIPByIndex(network->def, AF_UNSPEC, i))) { + i++; if (ipdef->nranges || ipdef->nhosts) needDnsmasq = true; } + if (i == 0) { + /* no IP addresses at all, so we don't need to run */ + ret = 0; + goto cleanup; + } + if (!needDnsmasq && network->def->dns.enable == VIR_TRISTATE_BOOL_NO) { + /* no DHCP services needed, and user disabled DNS service */ ret = 0; goto cleanup; } -- 2.7.4

2 1

[libvirt] [PATCH 00/10] qemu: agent: bugfix and improvments
by Nikolay Shirokovskiy 28 Oct '16

28 Oct '16

Patch 1 fixes the bug I dealt with. Patches 2-3 is a somewhat protection from similar bugs. Patches 5-6 drop error flag from the agent altogether, so now there are less places for bugs to lurk. Rest patches cleanup loop function. I think 1-3 can be dropped if 6 is approved. It is just 6 can be considered controversial. Nikolay Shirokovskiy (10): qemu: agent: unset error flag in EOF handler qemu: agent: dont set error after agent cleanup qemu: agent: clear error flag upon init qemu: agent: handle agent connection errors in one place qemu: agent: straigten up failed agent start case qemu: agent: drop agent error flag (6) qemu: agent: simplify io loop qemu: agent: exit early if error is already set qemu: agent: fix loop error messages qemu: agent: drop redundant referencing in loop src/qemu/qemu_agent.c | 183 ++++++++++++++++++------------------------- src/qemu/qemu_agent.h | 2 - src/qemu/qemu_domain.c | 41 +++++----- src/qemu/qemu_domain.h | 1 - src/qemu/qemu_driver.c | 9 +-- src/qemu/qemu_migration.c | 13 +-- src/qemu/qemu_process.c | 90 ++++----------------- tests/qemumonitortestutils.c | 1 - 8 files changed, 119 insertions(+), 221 deletions(-) -- 1.8.3.1

2 31

[libvirt] [RFC PATCH v2 1/1] qemu: host NUMA hugepage policy without guest NUMA
by Sam Bobroff 28 Oct '16

28 Oct '16

At the moment, guests that are backed by hugepages in the host are only able to use policy to control the placement of those hugepages on a per-(guest-)CPU basis. Policy applied globally is ignored. Such guests would use <memoryBacking><hugepages/></memoryBacking> and a <numatune> block with <memory mode=... nodeset=.../> but no <memnode .../> elements. This patch corrects this by, in this specific case, changing the QEMU command line from "-mem-prealloc -mem-path=..." (which cannot specify NUMA policy) to "-object memory-backend-file ..." (which can). Note: This is not visible to the guest and does not appear to create a migration incompatibility. Signed-off-by: Sam Bobroff <sam.bobroff(a)au1.ibm.com> --- Hello libvirt community, This patch is a RFC of an attempt to understand and fix a problem with NUMA memory placement policy being ignored in a specific situation. Previous discussion on this issue: https://www.redhat.com/archives/libvir-list/2016-October/msg00033.html https://www.redhat.com/archives/libvir-list/2016-October/msg00514.html (Sorry, this is a long description because the situation is complicated and there are several ways of approaching it and I need to explain my reasoning for choosing this specific method.) The issue I'm trying to fix: The problem is apparent when using this combination of features: * The guest is backed by hugepages in the host. * The backing memory is constrained by NUMA memory placement policy. * The guest either does not use NUMA nodes at all, or does but does not specify a per-node policy. The guest XML would therefore contain blocks similar to the following: <memoryBacking><hugepages/></memoryBacking> <numatune><memory mode='strict' nodeset='0'/></numatune> (And does not use <numatune><memnode ..>... .) (Policy works correctly without hugepages, or when memnode is used.) What happens is that the guest runs successfully but the NUMA memory placement policy is ignored, allowing memory to be allocated on any (host) node. Attempted solutions: The most obvious approach to me is a trivial patch to qemuBuildMemoryBackendStr(). The test that checks to see if a memory-backend is necessary (around line 3332 in qemu_command.c) is this: /* If none of the following is requested... */ if (!needHugepage && !userNodeset && !memAccess && !nodeSpecified && !force) { /* report back that using the new backend is not necessary * to achieve the desired configuration */ ret = 1; } else { This test does not consider the nodemask, so when no other reason exists to use a memory-backend (which is the case in point) the policy is lost. Adding nodemask to this test appears to easily fixe the issue. However: * It only works when the guest uses NUMA nodes (because otherwise the whole function is skipped at a higher level). * When the guest does use NUMA nodes, it causes a memory-backend object to be added to each one (when they did not previously have one) and this causes migration incompatability. So it seems worthwhile to look for other options. Other ways of controlling NUMA memory placement are numactl (libnuma) or cgroups but in practice neither can work in this situation due to the interaction of several features: * numactl and cgroups can only apply policy to all memory allocated by that thread. * When a guest is backed by hugepages, memory needs to be preallcated. * QEMU performs memory pre-allocation from it's main thread, not the VCPU threads. This seems to mean that policy applied to the QEMU VCPU threads does not apply to pre-allocated memory and policy applied to the QEMU main thread incorrectly applies to all of QEMU's allocations, not just the VCPU ones. My testing seems to confirm this. If that is true, then neither of those approaches can work (at least, not without changes to QEMU). At this point it appeared that the only ways to proceed would all require a migration-breaking change, so I started to look at QEMU to see if that could be worked around somehow. ... another option: While investigating QEMU I discovered that it is possible to use a QEMU memory backend object without attaching it to any guest NUMA node and when it is used that way it does not break migration. This is (to me at least) a new way of using a memory-backend object, but it appears to directly replace -mem-path and -mem-prealloc and additionally allow NUMA memory placement policy to be specified. (The ID field is still required even though it is not used.) For example, this... -m 4G -mem-path /dev/hugepages -mem-prealloc ... seems to be equavalent to this: -m 4G -object memory-backend-file,id=xxx,prealloc=yes,path=/dev/hugepages,size=4G But this is now possible as well: -m 4G -object memory-backend-file,id=xxx,prealloc=yes,path=/dev/hugepages,host-nodes=0-1,size=4G ... so it seems to be a way of solving this issue without breaking migration. Additionally, there seems to be code specifically in QEMU to prevent the migration data from changing in this case, which leads me to believe that this is an intended use of the option but I haven't directly consulted with the QEMU community. Implementation: My patch is based on this last case. It is intended to work by switching the "-mem-path" style argument to an un-attached memory-backend-file, which is why the change is done within qemuBuildMemPathStr(). In the case where QEMU doesn't support the needed option, I've opted to raise a warning rather than an error, because existing guests may have this configuration and although their policy is being ignored they do at least run and I assume it's important to maintain this. I realize that this policy can't be changed at run-time by libvirt, unlike policy set by cgroups or libnuma, but memory-backend objects are already in use in more common situations, and already have this limitation so I don't think this is adding significantly to that problem. Questions: So does this line of reasoning make sense? Is this a good way to fix it? Are there better solutions? Are there concerns with using memory-backend in this way: do I need to consult with the QEMU community before a libvirt patch that uses it could be accepted? Should the warning be an error? It seemed safest to me to only use the backend object when necessary, but there doesn't seem to be a reason to avoid using it whenever it is available. Is there one? Should I have done that instead? Thanks for reading! Sam. v2: Incorporated review feedback from Peter Krempa <pkrempa(a)redhat.com> and Martin Kletzander <mkletzan(a)redhat.com>. src/qemu/qemu_command.c | 56 +++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 47 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 405e118..0dea9fd 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7105,12 +7105,18 @@ qemuBuildSmpCommandLine(virCommandPtr cmd, static int qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg, - const virDomainDef *def, + virDomainDefPtr def, virQEMUCapsPtr qemuCaps, - virCommandPtr cmd) + virCommandPtr cmd, + virBitmapPtr auto_nodeset) { const long system_page_size = virGetSystemPageSizeKB(); char *mem_path = NULL; + virBitmapPtr nodemask = NULL; + const char *backendType = NULL; + char *backendStr = NULL; + virJSONValuePtr props = NULL; + int rv = -1; /* * No-op if hugepages were not requested. @@ -7135,18 +7141,50 @@ qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg, if (qemuGetHupageMemPath(cfg, def->mem.hugepages[0].size, &mem_path) < 0) return -1; - virCommandAddArgList(cmd, "-mem-prealloc", "-mem-path", mem_path, NULL); + if (virDomainNumatuneMaybeGetNodeset(def->numa, auto_nodeset, + &nodemask, -1) < 0) + return -1; + if (nodemask && virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_MEMORY_FILE)) { + if (qemuBuildMemoryBackendStr(virDomainDefGetMemoryInitial(def), + 0, -1, NULL, auto_nodeset, + def, qemuCaps, cfg, &backendType, + &props, false) < 0) + goto cleanup; + /* The memory-backend object created here is not going to be + * attached anywhere and there is only one so the ID can be hard coded. + * It acts like -mem-prealloc -mem-path ... but allows policy to be + * set. */ + if (!(backendStr = virQEMUBuildObjectCommandlineFromJSON(backendType, + "mem", + props))) + goto cleanup; + virCommandAddArgList(cmd, "-object", backendStr, NULL); + rv = 0; + cleanup: + virJSONValueFree(props); + VIR_FREE(backendStr); + } else { + if (nodemask) + /* Ideally this would be an error, but if it was it would + * break existing guests already using this configuration. */ + VIR_WARN("Memory file backend objects are " + "unsupported by QEMU binary. Global NUMA " + "hugepage policy will be ignored."); + virCommandAddArgList(cmd, "-mem-prealloc", "-mem-path", mem_path, NULL); + rv = 0; + } VIR_FREE(mem_path); - return 0; + return rv; } static int qemuBuildMemCommandLine(virCommandPtr cmd, virQEMUDriverConfigPtr cfg, - const virDomainDef *def, - virQEMUCapsPtr qemuCaps) + virDomainDefPtr def, + virQEMUCapsPtr qemuCaps, + virBitmapPtr auto_nodeset) { if (qemuDomainDefValidateMemoryHotplug(def, qemuCaps, NULL) < 0) return -1; @@ -7170,7 +7208,7 @@ qemuBuildMemCommandLine(virCommandPtr cmd, * there is no numa node specified. */ if (!virDomainNumaGetNodeCount(def->numa) && - qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0) + qemuBuildMemPathStr(cfg, def, qemuCaps, cmd, auto_nodeset) < 0) return -1; if (def->mem.locked && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_REALTIME_MLOCK)) { @@ -7307,7 +7345,7 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg, } if (!needBackend && - qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0) + qemuBuildMemPathStr(cfg, def, qemuCaps, cmd, auto_nodeset) < 0) goto cleanup; for (i = 0; i < ncells; i++) { @@ -9385,7 +9423,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (!migrateURI && !snapshot && qemuDomainAlignMemorySizes(def) < 0) goto error; - if (qemuBuildMemCommandLine(cmd, cfg, def, qemuCaps) < 0) + if (qemuBuildMemCommandLine(cmd, cfg, def, qemuCaps, nodeset) < 0) goto error; if (qemuBuildSmpCommandLine(cmd, def) < 0) -- 2.10.0.297.gf6727b0

1 0

[libvirt] [PATCH 5/5] docs: Add Qt Virtual machines manager and Qt Remote viewer
by Alexander Vasilenko 27 Oct '16

27 Oct '16

--- docs/apps.html.in | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 1a138b3..4efb318 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -208,6 +208,17 @@ to remote consoles supporting the VNC protocol. Also provides an optional mozilla browser plugin. </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager">qt-virt-manager</a></dt> + <dd> + The Qt GUI for create and control VMs and another virtual entities + (aka networks, storages, interfaces, secrets, network filters). + Contains integrated LXC/SPICE/VNC viewer for accessing the graphical or + text console associated with a virtual machine or container. + </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager/#virtual-machines-viewer">qt-remote-viewer</a></dt> + <dd> + The Qt VNC/SPICE viewer for access to remote desktops or VMs. + </dd> </dl> <h2><a name="iaas">Infrastructure as a Service (IaaS)</a></h2> -- 2.10.1

2 1

[libvirt] [PATCH 0/3] wireshark: Further build system fixes
by Andrea Bolognani 27 Oct '16

27 Oct '16

This takes care of the few remaining nits. All use cases I could think of are covered; if any more issues are discovered, we'll take care of them then. Andrea Bolognani (3): wireshark: Don't redefine ws_plugindir wireshark: Try a bunch of possible prefixes wireshark: Use ${exec_prefix} for $ws_plugindir m4/virt-wireshark.m4 | 23 ++++++++++++++++------- tools/Makefile.am | 1 - 2 files changed, 16 insertions(+), 8 deletions(-) -- 2.7.4

2 7

[libvirt] [RFC] Toward a better NEWS file
by Andrea Bolognani 27 Oct '16

27 Oct '16

Hi, there's an idea that has been kicking around in my head for a while, and I'd like to share it with the list to gather some feedback before I forget about it :) Right now, each entry in our NEWS file contains what is basically the output of git log \ --pretty=oneline \ vX.Y-1.0..vX.Y.0 with the commits organized somewhat arbitrarily into a bunch of sections with partially overlapping scopes. I believe the current form is less than useful, as it is too detailed for end users and distro packagers, who only care about the high-level user visible changes, and not detailed enough for developers, who are always going to refer to the proper git log anyway. Moreover, we ship a ChangeLog file that contains very detailed information already. Ideally, the NEWS file would contain a summary of notable changes (new APIs, significantly improved features, etc.) laid out in an easy to digest fashion, such that people who are not knee-deep into libvirt development can grasp them and hopefully get excited about upgrading to our latest and greatest release :) Of course, it would take an insane amount of time for any single one of us to turn the git log into such a document, and the result would still be sub-par because we simply can't expect anyone to have full insight in every single change to the project. My solution for this is to ask the people with the most knowledge of the changes - the authors themselves! The workflow I'm envisioning would look like this: * DV, at the same time as he announces that libvirt has entered freeze, will put out a Call for NEWS and ask people who have contributed code to the upcoming release to post a summary of their changes * the authors will go over git log \ --author=$(git config user.email) \ vX.Y-1.0..master and come up with a short (one-three sentences) summary for each of the changes, if they are notable. Commits that are part of a larger series would not be described on their own: a short summary of the series would be used instead, akin to the one you would put in your cover letter. To give a practical example: I've mostly been busy with reviews this cycle, but if I were to go over my commits since v2.3.0 right now I would write something like * Bug fix: don't restart libvirt-guests.service when libvirtd.service is restarted for commit 2273bbd, and omit both 61e1014 and a0da413 as they're neither notable enough on their own, nor part of a larger series: we'll always have a "various bug fixes and improvements" bullet point in a NEWS file entry to take care of that kind of small cleanups and improvements. * the authors would post the resulting summaries to the list. We could simply post them as regular patches to docs/news.html.in (potentially without requiring review before pushing them), or post them as plain text and have someone collect them and prepare a single commit * DV will tag the release and push the tarballs, and everyone will be able to enjoy the NEWS file :) Some light editoral work might be needed throughout the process, eg. fix typos or post one or two reminders during the freeze: I volunteer to take such tasks upon myself. I'm looking forward to feedback about this idea, especially from people who might be part of any community where anything like this is already happening. -- Andrea Bolognani / Red Hat / Virtualization

6 14

[libvirt] [PATCH 0/3] vz: nettype=bridge and other corrections
by Maxim Nestratov 27 Oct '16

27 Oct '16

Maxim Nestratov (3): vz: support type=bridge network interface type correctly vz: remove Bridged network name and rename Routed vz: add MIGRATION_V3 capability src/vz/vz_driver.c | 1 + src/vz/vz_sdk.c | 100 ++++++++--------------------------------------------- src/vz/vz_utils.h | 3 +- 3 files changed, 16 insertions(+), 88 deletions(-) -- 2.4.11

2 10

[libvirt] [REPOST] regarding cgroup v2 support in libvirt
by Tejun Heo 27 Oct '16

27 Oct '16

(reposting w/ libvir-list cc'd, sorry about the delay in reposting, was traveling and then on vacation) Hello, Daniel. How have you been? We (facebook) are deploying cgroup v2 and internally use libvirt to manage virtual machines, so I'm trying to add cgroup v2 support to libvirt. Because cgroup v2's resource configurations differ from v1 in varying degrees depending on the specific resource type, it unfortunately introduces new configurations (some completely new configs, others just a different range / format). This means that adding cgroup v2 support to libvirt requires adding new config options to it and maybe implementing some form of translation mechanism between overlapping configs. The upcoming systemd release includes all that's necessary to support v1/v2 compatibility so that users setting resource configs through systemd don't have to worry about whether v1 or v2 is in use. I'm wondering whether it would make sense to make libvirt use dbus calls to systemd to set resource configs when systemd is in use, so that it can piggyback on systemd's v1/v2 compatibility. It is true that, as libvirt can be used without systemd, libvirt will probably want its own direct implementation down the line, but I think there are benefits to going through systemd for resource settings in general given that hierarchy setup is already done through systemd when available. What do you think? Thanks! -- tejun

3 4

[libvirt] [PATCH] qemu_driver: don't set cpu pin for TCG domain
by Chen Hanxiao 27 Oct '16

27 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> We don't support pinning cpu for TCG domain. But we could set it by vcpupin command, which result in a failed startup. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_driver.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 93ea5e2..98cfcab 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5177,6 +5177,14 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0) goto endjob; + if ((def && def->virtType == VIR_DOMAIN_VIRT_QEMU) || + (persistentDef && persistentDef->virtType == VIR_DOMAIN_VIRT_QEMU)) + { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Virt type 'Qemu'(TCG) did not support CPU pin")); + goto endjob; + } + if (persistentDef && !(vcpuinfo = virDomainDefGetVcpu(persistentDef, vcpu))) { virReportError(VIR_ERR_INVALID_ARG, -- 1.8.3.1

2 3

[libvirt] [RFC PATCH] libxl: add tunnelled migration support
by Bob Liu 27 Oct '16

27 Oct '16

Tunnelled migration doesn't require any extra network connections beside the libvirt daemon. It's capable of strong encryption and is the default option in openstack-nova. This patch add the tunnelled migration(Tunnel3params) support to libxl. The data flow in the src side is: * libxlDoMigrateSend() -> pipe * libxlTunnel3MigrationFunc() poll pipe out and then write to dest stream. While in the dest side: Stream -> pipe -> 'recvfd of libxlDomainStartRestore' The usage is the same as p2p migration, execpt adding one more '--tunnelled' to the libvirt p2p migration command. Signed-off-by: Bob Liu <bob.liu(a)oracle.com> --- src/libxl/libxl_driver.c | 58 ++++++++++- src/libxl/libxl_migration.c | 241 +++++++++++++++++++++++++++++++++++++++++--- src/libxl/libxl_migration.h | 9 ++ 3 files changed, 292 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b66cb1f..a01bbff 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5918,6 +5918,61 @@ libxlDomainMigrateBegin3Params(virDomainPtr domain, } static int +libxlDomainMigratePrepareTunnel3Params(virConnectPtr dconn, + virStreamPtr st, + virTypedParameterPtr params, + int nparams, + const char *cookiein, + int cookieinlen, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int flags) +{ + libxlDriverPrivatePtr driver = dconn->privateData; + virDomainDefPtr def = NULL; + const char *dom_xml = NULL; + const char *dname = NULL; + const char *uri_in = NULL; + +#ifdef LIBXL_HAVE_NO_SUSPEND_RESUME + virReportUnsupportedError(); + return -1; +#endif + + virCheckFlags(LIBXL_MIGRATION_FLAGS, -1); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + goto error; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_XML, + &dom_xml) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, + &dname) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_URI, + &uri_in) < 0) + + goto error; + + if (!(def = libxlDomainMigrationPrepareDef(driver, dom_xml, dname))) + goto error; + + if (virDomainMigratePrepareTunnel3ParamsEnsureACL(dconn, def) < 0) + goto error; + + if (libxlDomainMigrationPrepareTunnel3(dconn, st, &def, cookiein, + cookieinlen, flags) < 0) + goto error; + + return 0; + + error: + virDomainDefFree(def); + return -1; +} + +static int libxlDomainMigratePrepare3Params(virConnectPtr dconn, virTypedParameterPtr params, int nparams, @@ -6017,7 +6072,7 @@ libxlDomainMigratePerform3Params(virDomainPtr dom, if (virDomainMigratePerform3ParamsEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (flags & VIR_MIGRATE_PEER2PEER) { + if ((flags & (VIR_MIGRATE_TUNNELLED | VIR_MIGRATE_PEER2PEER))) { if (libxlDomainMigrationPerformP2P(driver, vm, dom->conn, dom_xml, dconnuri, uri, dname, flags) < 0) goto cleanup; @@ -6501,6 +6556,7 @@ static virHypervisorDriver libxlHypervisorDriver = { .nodeDeviceReset = libxlNodeDeviceReset, /* 1.2.3 */ .domainMigrateBegin3Params = libxlDomainMigrateBegin3Params, /* 1.2.6 */ .domainMigratePrepare3Params = libxlDomainMigratePrepare3Params, /* 1.2.6 */ + .domainMigratePrepareTunnel3Params = libxlDomainMigratePrepareTunnel3Params, /* 2.3.1 */ .domainMigratePerform3Params = libxlDomainMigratePerform3Params, /* 1.2.6 */ .domainMigrateFinish3Params = libxlDomainMigrateFinish3Params, /* 1.2.6 */ .domainMigrateConfirm3Params = libxlDomainMigrateConfirm3Params, /* 1.2.6 */ diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 534abb8..88c9bb8 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -44,6 +44,7 @@ #include "libxl_migration.h" #include "locking/domain_lock.h" #include "virtypedparam.h" +#include "fdstream.h" #define VIR_FROM_THIS VIR_FROM_LIBXL @@ -484,6 +485,90 @@ libxlDomainMigrationPrepareDef(libxlDriverPrivatePtr driver, } int +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, + virStreamPtr st, + virDomainDefPtr *def, + const char *cookiein, + int cookieinlen, + unsigned int flags) +{ + libxlMigrationCookiePtr mig = NULL; + libxlDriverPrivatePtr driver = dconn->privateData; + virDomainObjPtr vm = NULL; + libxlMigrationDstArgs *args = NULL; + virThread thread; + int dataFD[2] = { -1, -1 }; + int ret = 0; + + if (libxlMigrationEatCookie(cookiein, cookieinlen, &mig) < 0) + goto error; + + if (mig->xenMigStreamVer > LIBXL_SAVE_VERSION) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("Xen migration stream version '%d' is not supported on this host"), + mig->xenMigStreamVer); + goto error; + } + + if (!(vm = virDomainObjListAdd(driver->domains, *def, + driver->xmlopt, + VIR_DOMAIN_OBJ_LIST_ADD_LIVE | + VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, + NULL))) + goto error; + + /* + * The data flow of tunnel3 migration in the dest side: + * stream -> pipe -> recvfd of libxlDomainStartRestore + */ + if (pipe(dataFD) < 0) + goto error; + + /* Stream data will be written to pipeIn */ + if (virFDStreamOpen(st, dataFD[1]) < 0) + goto error; + + if (libxlMigrationDstArgsInitialize() < 0) + goto error; + + if (!(args = virObjectNew(libxlMigrationDstArgsClass))) + goto error; + + args->conn = dconn; + args->vm = vm; + args->flags = flags; + args->migcookie = mig; + /* Receive from pipeOut */ + args->recvfd = dataFD[0]; + args->nsocks = 0; + if (virThreadCreate(&thread, false, libxlDoMigrateReceive, args) < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Failed to create thread for receiving migration data")); + goto error; + } + + goto done; + + error: + VIR_FORCE_CLOSE(dataFD[1]); + VIR_FORCE_CLOSE(dataFD[0]); + virObjectUnref(args); + /* Remove virDomainObj from domain list */ + if (vm) { + virDomainObjListRemove(driver->domains, vm); + vm = NULL; + } + ret = -1; + + done: + /* Nobody will close dataFD[1]? */ + if (vm) + virObjectUnlock(vm); + + return ret; +} + +int libxlDomainMigrationPrepare(virConnectPtr dconn, virDomainDefPtr *def, const char *uri_in, @@ -710,9 +795,90 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, return ret; } -/* This function is a simplification of virDomainMigrateVersion3Full - * excluding tunnel support and restricting it to migration v3 - * with params since it was the first to be introduced in libxl. +typedef struct _libxlTunnelMigrationThread libxlTunnelMigrationThread; +struct _libxlTunnelMigrationThread { + virThread thread; + virStreamPtr st; + int srcFD; +}; +#define TUNNEL_SEND_BUF_SIZE 65536 + +/* + * The data flow of tunnel3 migration in the src side: + * libxlDoMigrateSend() -> pipe + * libxlTunnel3MigrationFunc() polls pipe out and then write to dest stream. + */ +static void libxlTunnel3MigrationFunc(void *arg) +{ + libxlTunnelMigrationThread *data = (libxlTunnelMigrationThread *)arg; + char *buffer = NULL; + struct pollfd fds[1]; + int timeout = -1; + + if (VIR_ALLOC_N(buffer, TUNNEL_SEND_BUF_SIZE) < 0) { + virReportError(errno, "%s", _("poll failed in migration tunnel")); + return; + } + + fds[0].fd = data->srcFD; + for (;;) { + int ret; + + fds[0].events = POLLIN; + fds[0].revents = 0; + ret = poll(fds, ARRAY_CARDINALITY(fds), timeout); + if (ret < 0) { + if (errno == EAGAIN || errno == EINTR) + continue; + virReportError(errno, "%s", + _("poll failed in libxlTunnel3MigrationFunc")); + goto abrt; + } + + if (ret == 0) { + VIR_DEBUG("poll got timeout"); + break; + } + + if (fds[0].revents & (POLLIN | POLLERR | POLLHUP)) { + int nbytes; + + nbytes = read(data->srcFD, buffer, TUNNEL_SEND_BUF_SIZE); + if (nbytes > 0) { + /* Write to dest stream */ + if (virStreamSend(data->st, buffer, nbytes) < 0) { + virReportError(errno, "%s", + _("tunnelled migration failed to send to virStream")); + goto abrt; + } + } else if (nbytes < 0) { + virReportError(errno, "%s", + _("tunnelled migration failed to read from xen side")); + goto abrt; + } else { + /* EOF; transferred all data */ + break; + } + } + } + + if (virStreamFinish(data->st) < 0) + virReportError(errno, "%s", + _("tunnelled migration failed to finish stream")); + + cleanup: + VIR_FREE(buffer); + + return; + + abrt: + virStreamAbort(data->st); + goto cleanup; +} + +/* This function is a simplification of virDomainMigrateVersion3Full and + * restricting it to migration v3 with params since it was the first to be + * introduced in libxl. */ static int libxlDoMigrateP2P(libxlDriverPrivatePtr driver, @@ -737,6 +903,10 @@ libxlDoMigrateP2P(libxlDriverPrivatePtr driver, bool cancelled = true; virErrorPtr orig_err = NULL; int ret = -1; + /* For tunnel migration */ + virStreamPtr st = NULL; + libxlTunnelMigrationThread *libxlTunnelMigationThreadPtr = NULL; + int dataFD[2] = { -1, -1 }; dom_xml = libxlDomainMigrationBegin(sconn, vm, xmlin, &cookieout, &cookieoutlen); @@ -764,29 +934,62 @@ libxlDoMigrateP2P(libxlDriverPrivatePtr driver, VIR_DEBUG("Prepare3"); virObjectUnlock(vm); - ret = dconn->driver->domainMigratePrepare3Params - (dconn, params, nparams, cookieout, cookieoutlen, NULL, NULL, &uri_out, destflags); + if (flags & VIR_MIGRATE_TUNNELLED) { + if (!(st = virStreamNew(dconn, 0))) + goto cleanup; + ret = dconn->driver->domainMigratePrepareTunnel3Params + (dconn, st, params, nparams, cookieout, cookieoutlen, NULL, NULL, destflags); + } else { + ret = dconn->driver->domainMigratePrepare3Params + (dconn, params, nparams, cookieout, cookieoutlen, NULL, NULL, &uri_out, destflags); + } virObjectLock(vm); if (ret == -1) goto cleanup; - if (uri_out) { - if (virTypedParamsReplaceString(&params, &nparams, - VIR_MIGRATE_PARAM_URI, uri_out) < 0) { - orig_err = virSaveLastError(); + if (!(flags & VIR_MIGRATE_TUNNELLED)) { + if (uri_out) { + if (virTypedParamsReplaceString(&params, &nparams, + VIR_MIGRATE_PARAM_URI, uri_out) < 0) { + orig_err = virSaveLastError(); + goto finish; + } + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("domainMigratePrepare3 did not set uri")); goto finish; } - } else { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("domainMigratePrepare3 did not set uri")); - goto finish; } VIR_DEBUG("Perform3 uri=%s", NULLSTR(uri_out)); - ret = libxlDomainMigrationPerform(driver, vm, NULL, NULL, - uri_out, NULL, flags); + if (flags & VIR_MIGRATE_TUNNELLED) { + if (VIR_ALLOC(libxlTunnelMigationThreadPtr) < 0) + goto cleanup; + if (pipe(dataFD) < 0) { + virReportError(errno, "%s", _("Unable to make pipes")); + goto cleanup; + } + /* Read from pipe */ + libxlTunnelMigationThreadPtr->srcFD = dataFD[0]; + /* Write to dest stream */ + libxlTunnelMigationThreadPtr->st = st; + if (virThreadCreate(&libxlTunnelMigationThreadPtr->thread, true, + libxlTunnel3MigrationFunc, + libxlTunnelMigationThreadPtr) < 0) { + virReportError(errno, "%s", + _("Unable to create tunnel migration thread")); + goto cleanup; + } + virObjectUnlock(vm); + /* Send data to pipe */ + ret = libxlDoMigrateSend(driver, vm, flags, dataFD[1]); + virObjectLock(vm); + } else { + ret = libxlDomainMigrationPerform(driver, vm, NULL, NULL, + uri_out, NULL, flags); + } if (ret < 0) orig_err = virSaveLastError(); @@ -824,6 +1027,14 @@ libxlDoMigrateP2P(libxlDriverPrivatePtr driver, vm->def->name); cleanup: + if (libxlTunnelMigationThreadPtr) { + virThreadCancel(&libxlTunnelMigationThreadPtr->thread); + VIR_FREE(libxlTunnelMigationThreadPtr); + } + VIR_FORCE_CLOSE(dataFD[0]); + VIR_FORCE_CLOSE(dataFD[1]); + virObjectUnref(st); + if (ddomain) { virObjectUnref(ddomain); ret = 0; diff --git a/src/libxl/libxl_migration.h b/src/libxl/libxl_migration.h index 8a074a0..fcea558 100644 --- a/src/libxl/libxl_migration.h +++ b/src/libxl/libxl_migration.h @@ -29,6 +29,7 @@ # define LIBXL_MIGRATION_FLAGS \ (VIR_MIGRATE_LIVE | \ VIR_MIGRATE_PEER2PEER | \ + VIR_MIGRATE_TUNNELLED | \ VIR_MIGRATE_PERSIST_DEST | \ VIR_MIGRATE_UNDEFINE_SOURCE | \ VIR_MIGRATE_PAUSED) @@ -53,6 +54,14 @@ libxlDomainMigrationPrepareDef(libxlDriverPrivatePtr driver, const char *dname); int +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, + virStreamPtr st, + virDomainDefPtr *def, + const char *cookiein, + int cookieinlen, + unsigned int flags); + +int libxlDomainMigrationPrepare(virConnectPtr dconn, virDomainDefPtr *def, const char *uri_in, -- 2.6.5

2 2

[libvirt] [PATCH 0/6] Address assignment fixes
by Ján Tomko 27 Oct '16

27 Oct '16

Fixes a crash on usb-serial hotplug and missing addresses after libvirtd restart, and makes some code more readable. Ján Tomko (6): Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign Introduce virDomainVirtioSerialAddrAutoAssign again Return directly from qemuDomainAttachChrDeviceAssignAddr Also create the USB address cache for domains with all the USB addresses Fix crash on usb-serial hotplug Do not try to release virtio serial addresses src/conf/domain_addr.c | 41 +++++++++++++++++++++++++++++++++---- src/conf/domain_addr.h | 14 +++++++++++-- src/libvirt_private.syms | 2 ++ src/qemu/qemu_domain_address.c | 22 ++++++++++++++++---- src/qemu/qemu_hotplug.c | 46 +++++++++++++++++------------------------- 5 files changed, 87 insertions(+), 38 deletions(-) -- 2.7.3

2 13

[libvirt] libvirt compiles on RISC-V (RV64G)
by Richard W.M. Jones 27 Oct '16

27 Oct '16

I'm happy to announce that libvirt compiles fine from git on Fedora/RISC-V. This has little or no practical value at all, since RISC-V lacks such essentials such as virtualization, qemu etc. However I suppose you could use it as a remote client. # file src/.libs/libvirt.so.0.2004.0 src/.libs/libvirt.so.0.2004.0: ELF 64-bit LSB shared object, UCB RISC-V, version 1 (SYSV), dynamically linked, BuildID[sha1]=525ed42ce6d1284c6a909bd6f1b0d6181e88af7b, not stripped # file tools/.libs/virsh tools/.libs/virsh: ELF 64-bit LSB shared object, UCB RISC-V, version 1 (SYSV), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 2.6.32, BuildID[sha1]=67e2b69f9007c02137545fed1b7fd9b2871740ee, not stripped Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

2 4

[libvirt] [PATCH] Added the description for Qt Virtual machine manager and Qt Remote Viewer as libvirt related applications.
by F1ash 27 Oct '16

27 Oct '16

--- docs/apps.html.in | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 1a138b3..3098b73 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -208,6 +208,17 @@ to remote consoles supporting the VNC protocol. Also provides an optional mozilla browser plugin. </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager">qt-virt-manager</a></dt> + <dd> + The Qt GUI for create and control VMs and another virtual entities + (aka networks, storages, interfaces, secrets, network filters). + Contains integrated LXC/SPICE/VNC viewer for accessing the graphical or + text console associated with a virtual machine or container. + </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager">qt-remote-viewer</a></dt> + <dd> + The Qt VNC/SPICE viewer for access to remote desktops or VMs. + </dd> </dl> <h2><a name="iaas">Infrastructure as a Service (IaaS)</a></h2> -- 2.10.1

2 1

[libvirt] [PATCH] qemu: Minimalize global driver accesses
by Michal Privoznik 27 Oct '16

27 Oct '16

Whilst working on another issue, I've noticed that in some functions we have a local @driver variable among with access to global @qemu_driver variable. This makes no sense. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bacabd2..3495cbf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3831,7 +3831,7 @@ qemuDomainScreenshot(virDomainPtr dom, } unlink_tmp = true; - virSecurityManagerSetSavedStateLabel(qemu_driver->securityManager, vm->def, tmp); + virSecurityManagerSetSavedStateLabel(driver->securityManager, vm->def, tmp); qemuDomainObjEnterMonitor(driver, vm); if (qemuMonitorScreendump(priv->mon, tmp) < 0) { @@ -11449,7 +11449,7 @@ qemuDomainMemoryPeek(virDomainPtr dom, goto endjob; } - virSecurityManagerSetSavedStateLabel(qemu_driver->securityManager, vm->def, tmp); + virSecurityManagerSetSavedStateLabel(driver->securityManager, vm->def, tmp); priv = vm->privateData; qemuDomainObjEnterMonitor(driver, vm); -- 2.8.4

2 1

[libvirt] [PATCH] virsh: Fix on_shutdown to on_poweroff
by Martin Kletzander 27 Oct '16

27 Oct '16

The 'on_shutdown' was the name in Xen, there was never such option in libvirt's domain XML. Reported-by: Ruben Kerkhof <ruben(a)rubenkerkhof.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial. tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 8236a36fc2af..f278fecafde3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2398,7 +2398,7 @@ succeed, and may take a variable length of time depending on what services must be shutdown in the domain. The exact behavior of a domain when it shuts down is set by the -I<on_shutdown> parameter in the domain's XML definition. +I<on_poweroff> parameter in the domain's XML definition. If I<domain> is transient, then the metadata of any snapshots will be lost once the guest stops running, but the snapshot contents still -- 2.10.1

1 0

[libvirt] [PATCH 1/1] qemu: host NUMA hugepage policy without guest NUMA
by Sam Bobroff 27 Oct '16

27 Oct '16

At the moment, guests that are backed by hugepages in the host are only able to use policy to control the placement of those hugepages on a per-(guest-)CPU basis. Policy applied globally is ignored. Such guests would use <memoryBacking><hugepages/></memoryBacking> and a <numatune> block with <memory mode=... nodeset=.../> but no <memnode .../> elements. This patch corrects this by, in this specific case, changing the QEMU command line from "-mem-prealloc -mem-path=..." (which cannot specify NUMA policy) to "-object memory-backend-file ..." (which can). Note: This is not visible to the guest and does not appear to create a migration incompatibility. Signed-off-by: Sam Bobroff <sam.bobroff(a)au1.ibm.com> --- There was some discussion leading up to this patch, here: https://www.redhat.com/archives/libvir-list/2016-October/msg00033.html During that discussion it seemed that fixing this issue would cause migration incompatibility but after some careful testing, it appears that it only does when a memory-backend object is attached to a guest NUMA node and that is not the case here. If only one is created, and used globally (not attached via mem=<id>), the migration data does not seem to be changed and so it seems reasonable to try something like this patch. This patch does work for my test cases but I don't claim a deep understanding of the libvirt code so this is at least partly a RFC. Comments welcome :-) Cheers, Sam. src/qemu/qemu_command.c | 55 ++++++++++++++++++++++++++++++++++++++++--------- src/qemu/qemu_command.h | 2 +- 2 files changed, 46 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0804133..c28c8f2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3143,7 +3143,7 @@ qemuBuildMemoryBackendStr(unsigned long long size, int guestNode, virBitmapPtr userNodeset, virBitmapPtr autoNodeset, - virDomainDefPtr def, + const virDomainDefPtr def, virQEMUCapsPtr qemuCaps, virQEMUDriverConfigPtr cfg, const char **backendType, @@ -7129,12 +7129,18 @@ qemuBuildSmpCommandLine(virCommandPtr cmd, static int qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg, - const virDomainDef *def, + const virDomainDefPtr def, virQEMUCapsPtr qemuCaps, - virCommandPtr cmd) + virCommandPtr cmd, + virBitmapPtr auto_nodeset) { const long system_page_size = virGetSystemPageSizeKB(); char *mem_path = NULL; + virBitmapPtr nodemask = NULL; + const char *backendType = NULL; + char *backendStr = NULL; + virJSONValuePtr props; + int rv = -1; /* * No-op if hugepages were not requested. @@ -7159,18 +7165,47 @@ qemuBuildMemPathStr(virQEMUDriverConfigPtr cfg, if (qemuGetHupageMemPath(cfg, def->mem.hugepages[0].size, &mem_path) < 0) return -1; - virCommandAddArgList(cmd, "-mem-prealloc", "-mem-path", mem_path, NULL); + if (virDomainNumatuneMaybeGetNodeset(def->numa, auto_nodeset, + &nodemask, -1) < 0) + return -1; + if (nodemask && virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_MEMORY_FILE)) { + props = virJSONValueNewObject(); + if (qemuBuildMemoryBackendStr(virDomainDefGetMemoryInitial(def), + 0, -1, NULL, auto_nodeset, + def, qemuCaps, cfg, &backendType, + &props, false) < 0) + goto cleanup; + if (!(backendStr = virQEMUBuildObjectCommandlineFromJSON(backendType, + "mem", + props))) + goto cleanup; + virCommandAddArgList(cmd, "-object", backendStr, NULL); + rv = 0; +cleanup: + VIR_FREE(backendStr); + VIR_FREE(props); + } + else { + if (nodemask || 1) + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Memory file backend objects are " + "unsupported by QEMU binary. Global NUMA " + "hugepage policy will be ignored.")); + virCommandAddArgList(cmd, "-mem-prealloc", "-mem-path", mem_path, NULL); + rv = 0; + } VIR_FREE(mem_path); - return 0; + return rv; } static int qemuBuildMemCommandLine(virCommandPtr cmd, virQEMUDriverConfigPtr cfg, - const virDomainDef *def, - virQEMUCapsPtr qemuCaps) + const virDomainDefPtr def, + virQEMUCapsPtr qemuCaps, + virBitmapPtr auto_nodeset) { if (qemuDomainDefValidateMemoryHotplug(def, qemuCaps, NULL) < 0) return -1; @@ -7194,7 +7229,7 @@ qemuBuildMemCommandLine(virCommandPtr cmd, * there is no numa node specified. */ if (!virDomainNumaGetNodeCount(def->numa) && - qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0) + qemuBuildMemPathStr(cfg, def, qemuCaps, cmd, auto_nodeset) < 0) return -1; if (def->mem.locked && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_REALTIME_MLOCK)) { @@ -7331,7 +7366,7 @@ qemuBuildNumaArgStr(virQEMUDriverConfigPtr cfg, } if (!needBackend && - qemuBuildMemPathStr(cfg, def, qemuCaps, cmd) < 0) + qemuBuildMemPathStr(cfg, def, qemuCaps, cmd, auto_nodeset) < 0) goto cleanup; for (i = 0; i < ncells; i++) { @@ -9381,7 +9416,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver, if (!migrateURI && !snapshot && qemuDomainAlignMemorySizes(def) < 0) goto error; - if (qemuBuildMemCommandLine(cmd, cfg, def, qemuCaps) < 0) + if (qemuBuildMemCommandLine(cmd, cfg, def, qemuCaps, nodeset) < 0) goto error; if (qemuBuildSmpCommandLine(cmd, def) < 0) diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 2f2a6ff..1e97d76 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -126,7 +126,7 @@ int qemuBuildMemoryBackendStr(unsigned long long size, int guestNode, virBitmapPtr userNodeset, virBitmapPtr autoNodeset, - virDomainDefPtr def, + const virDomainDefPtr def, virQEMUCapsPtr qemuCaps, virQEMUDriverConfigPtr cfg, const char **backendType, -- 2.10.0.297.gf6727b0

3 12

[libvirt] on shutdown
by Ruben Kerkhof 26 Oct '16

26 Oct '16

Hi all, virsh(1) has this to say about virsh shutdown: "The exact behavior of a domain when it shuts down is set by the on_shutdown parameter in the domain's XML definition." on_shutdown isn't documented in https://libvirt.org/formatdomain.html Is the virsh(1) manpage wrong? Kind regards, Ruben Kerkhof

2 4

[libvirt] [PATCH] Resuming running domain raise error message now
by Sławek Kapłoński 26 Oct '16

26 Oct '16

This patch introduce raising XML error when user tries to resume domain (Qemu or LXC) which is already running. Closes bug: https://bugzilla.redhat.com/show_bug.cgi?id=1009008 Sławek Kapłoński (1): Resuming running domain raise error message src/lxc/lxc_driver.c | 8 +++++++- src/qemu/qemu_driver.c | 4 ++++ 2 files changed, 11 insertions(+), 1 deletion(-) -- 2.10.1

2 5

[libvirt] [PATCH 0/5] wireshark: Fix $(prefix) handling
by Andrea Bolognani 26 Oct '16

26 Oct '16

Well, almost :) There are still some cases that are not handled correctly, but at least this will unbreak 'make rpm' while I work on the rest. Tested by running 'make rpm' successfully on Fedora 23, Fedora 24 and Fedora rawhide. Andrea Bolognani (5): wireshark: Introduce $ws_modversion wireshark: Hoist $ws_prefix declaration wireshark: Strip prefix correctly wireshark: Inject $(prefix) at the right time wireshark: Rename plugindir to ws_plugindir m4/virt-wireshark.m4 | 29 ++++++++++++++++++----------- tools/Makefile.am | 2 +- 2 files changed, 19 insertions(+), 12 deletions(-) -- 2.7.4

3 8

[libvirt] [PATCH] virt-wireshark.m4: Defer $(prefix) substitution
by Michal Privoznik 26 Oct '16

26 Oct '16

The problem with evaluating $(prefix) in configure phase is that autoconf does a lot of magic with this variable. Firstly, if the --prefix argument is not set for the configure script, the variable will have value "NONE". Wait, wat? Secondly, even autoconf scripts then have special cases for when variable is "NONE". It's even worse - whenever they need to construct new path based on prefix, they save its current value, substitute it with proper value (like /usr/local/), do what they need and then restore the original value. Le sigh. This mad behaviour is, however, suppressed if there's --prefix on the configure command line. Now, the problem is that we tried to construct path for wireshark plugin in the m4 file. Based on the knowledge described above, we shouldn't do it and just construct the full path in Makefile later where prefix has proper value. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- m4/virt-wireshark.m4 | 2 +- tools/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-wireshark.m4 b/m4/virt-wireshark.m4 index f383e2b..e1e4a59 100644 --- a/m4/virt-wireshark.m4 +++ b/m4/virt-wireshark.m4 @@ -38,7 +38,7 @@ AC_DEFUN([LIBVIRT_CHECK_WIRESHARK],[ if test "x$ws_prefix" = "x" ; then ws_prefix="/usr"; fi - plugindir="${prefix}${plugindir#$ws_prefix}" + plugindir="${plugindir#$ws_prefix}" fi elif test "x$with_ws_plugindir" = "xno" || test "x$with_ws_plugindir" = "xyes"; then AC_MSG_ERROR([ws-plugindir must be used only with valid path]) diff --git a/tools/Makefile.am b/tools/Makefile.am index e7e42c3..08e1680 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -398,7 +398,7 @@ EXTRA_DIST += \ if WITH_WIRESHARK_DISSECTOR -ws_plugindir = $(plugindir) +ws_plugindir = $(prefix)$(plugindir) ws_plugin_LTLIBRARIES = wireshark/src/libvirt.la wireshark_src_libvirt_la_CPPFLAGS = \ -I wireshark/src $(WIRESHARK_DISSECTOR_CFLAGS) -- 2.8.4

4 6

[libvirt] [PATCH v11 0/5] Add native TLS encrypted chardev TCP support
by John Ferlan 26 Oct '16

26 Oct '16

v10: http://www.redhat.com/archives/libvir-list/2016-October/msg00866.html Changes since v10... This is essentially the adding the secret to/for the TLS chardev TCP. Lots of messy stuff. Patches 1-3 are new... In particular, I kept looking at the RNG removal code and kept thinking, something just doesn't look right when compared to the RemoveVirtioDisk code. If I'm incorrect with order of removal it's an easy enough change. Kept trying to think what depends on what and for the RNG it would seem a need a to unplug the backend before removing the front end object would be more logical. Patches 4-5 are the old patch 3-4. They (hopefully) encompass the previous review plus other things since discovered. John Ferlan (5): qemu: Move TLS object remove from DetachChr to RemoveChr qemu: Swap order of RNG hot unplug removal qemu: Need to remove TLS object in RemoveRNGDevice qemu: Add a secret object to/for a char source dev qemu: Add secret object hotplug for TCP chardev TLS src/qemu/qemu_command.c | 30 +++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 173 +++++++++++++++++- src/qemu/qemu_domain.h | 17 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_hotplug.c | 195 +++++++++++++++++---- src/qemu/qemu_hotplug.h | 9 +- src/qemu/qemu_process.c | 9 +- tests/qemuhotplugtest.c | 2 +- ...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++ ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 ++++++ tests/qemuxml2argvtest.c | 17 ++ 12 files changed, 495 insertions(+), 52 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml -- 2.7.4

2 16

[libvirt] [PATCH v5 00/15] Use more PCIe less legacy PCI
by Laine Stump 26 Oct '16

26 Oct '16

These are just the rebased versions of the patches from v4 that I haven't yet pushed, to make review easier. Patch 1 and 2 (and several others) are already ACKed, but included for completeness. Laine Stump (15): qemu: new functions qemuDomainMachineHasPCI[e]Root() qemu: new functions to calculate/set device pciConnectFlags qemu: set/use info->pciConnectFlags when validating/assigning PCI addresses qemu: set/use proper pciConnectFlags during hotplug qemu: set pciConnectFlags to 0 instead of PCI|HOTPLUGGABLE if device isn't PCI qemu: assign virtio devices to PCIe slot when appropriate qemu: assign e1000e network devices to PCIe slots when appropriate qemu: assign nec-xhci (USB3) controller to a PCIe address when appropriate qemu: only force an available legacy-PCI slot on domains with pci-root qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed [RFC] qemu: if pci-bridge is in PCIe config w/o dmi-to-pci-bridge, add it qemu: don't force-add a dmi-to-pci-bridge just on principle qemu: add a USB3 controller to Q35 domains by default qemu: try to put ich9 sound device at 00:1B.0 qemu: initially reserve one open pcie-root-port for hotplug src/conf/device_conf.h | 5 + src/conf/domain_addr.c | 112 ++- src/conf/domain_addr.h | 3 +- src/qemu/qemu_domain.c | 52 +- src/qemu/qemu_domain.h | 2 + src/qemu/qemu_domain_address.c | 805 +++++++++++++++++---- src/qemu/qemu_domain_address.h | 4 + src/qemu/qemu_hotplug.c | 20 +- tests/qemuxml2argvdata/qemuxml2argv-autoindex.args | 10 +- .../qemuxml2argv-bios-nvram-secure.args | 1 + .../qemuxml2argv-machine-smm-opt.args | 1 + tests/qemuxml2argvdata/qemuxml2argv-pcie-root.args | 3 +- .../qemuxml2argv-q35-default-devices-only.args | 23 + .../qemuxml2argv-q35-default-devices-only.xml | 18 + .../qemuxml2argv-q35-pcie-autoadd.args | 57 ++ .../qemuxml2argv-q35-pcie-autoadd.xml | 51 ++ tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 58 ++ tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.xml | 67 ++ .../qemuxml2argv-q35-pm-disable-fallback.args | 1 + .../qemuxml2argv-q35-pm-disable.args | 1 + .../qemuxml2argv-q35-virt-manager-basic.args | 56 ++ .../qemuxml2argv-q35-virt-manager-basic.xml | 76 ++ .../qemuxml2argv-q35-virtio-pci.args | 58 ++ .../qemuxml2argv-q35-virtio-pci.xml | 1 + tests/qemuxml2argvtest.c | 164 ++++- .../qemuxml2xmlout-autoindex.xml | 10 +- .../qemuxml2xmlout-pcie-root.xml | 4 - .../qemuxml2xmlout-q35-default-devices-only.xml | 45 ++ .../qemuxml2xmlout-q35-pcie-autoadd.xml | 148 ++++ .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 152 ++++ .../qemuxml2xmlout-q35-virt-manager-basic.xml | 121 ++++ .../qemuxml2xmlout-q35-virtio-pci.xml | 152 ++++ tests/qemuxml2xmltest.c | 136 +++- 33 files changed, 2189 insertions(+), 228 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie-autoadd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie-autoadd.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virt-manager-basic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virt-manager-basic.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pci.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-default-devices-only.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie-autoadd.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virtio-pci.xml -- 2.7.4

2 18

[libvirt] [PATCH] qemu: Fix depedency order in qemuRemoveDiskDevice
by John Ferlan 26 Oct '16

26 Oct '16

Need to remove the drive first, then the secobj and/or encobj if they exist. This is because the drive has a dependency on secobj (or the secret for the networked storage server) and/or the encobj (or the secret for the LUKS encrypted volume). Deleting either object first leaves an drive without it's respective objects. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 7a21dc6..30565d5 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3176,6 +3176,9 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver, qemuDomainObjEnterMonitor(driver, vm); + qemuMonitorDriveDel(priv->mon, drivestr); + VIR_FREE(drivestr); + /* If it fails, then so be it - it was a best shot */ if (objAlias) ignore_value(qemuMonitorDelObject(priv->mon, objAlias)); @@ -3186,8 +3189,6 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver, ignore_value(qemuMonitorDelObject(priv->mon, encAlias)); VIR_FREE(encAlias); - qemuMonitorDriveDel(priv->mon, drivestr); - VIR_FREE(drivestr); if (qemuDomainObjExitMonitor(driver, vm) < 0) return -1; -- 2.7.4

2 1

[libvirt] [PATCH v2 00/12] Add length (duration) params for iotune throttling
by John Ferlan 25 Oct '16

25 Oct '16

v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01090.html Differences since v1: Patches 1-5 are new... Patch 1 is essentially the former patch 8.5 added after initial review based on a review comment. Erik Skultety and I went back and forth on this one a few times and this is the result Patch 2 is a result of being frustrated by a generic error message when I know we could return whatever qemu gives us Patch 3 is simple code motion - the conf_disk is closer to usage now Patch 4 & 5 create and use the same algorithm to set the default values that weren't provided. Patches 6-7 have already been ACK'd... I've been waiting to push because they will interfere with libvirt-perl builds and since the 2.3.0 hasn't been published yet, I'm still holding onto them. Patch 8 is the former patch 8, but reworked mostly in qemu_driver.c, but also a change in qemu_monitor_json.c to use "P:" instead of "U:" for then length values. For _length a 0 is an invalid value, so we'll use it to mean "nothing changed" Patch 9 is the former patch 11 and is mostly intact, with major difference being the removal of the CHECK_IOTUNE_MAX_LENGTH macro (it was causing domain disappearance) Patch 10 is the former patch 12 and is unchanged. It also has been ACKd Patch 11-12 are new - it's the virsh code. John Ferlan (12): qemu: Create a macro to handle setting bytes/iops iotune values qemu: Return real error message for block_set_io_throttle qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune qemu: Introduce qemuDomainSetBlockIoTuneSetDefaults qemu: Use qemuDomainsetBlockIoTuneSetDefaults for config include: Add new definitions for duration for bps/iops throttling caps: Add new capability for the bps/iops throttling length qemu: Add length for bps/iops throttling parameters to driver conf: Add support for blkiotune "_length" options qemu: Add the length options to the iotune command line virsh: Create a macro to add IOTUNE values virsh: Add _length parameters to virsh output docs/formatdomain.html.in | 40 ++- docs/schemas/domaincommon.rng | 38 +++ include/libvirt/libvirt-domain.h | 102 ++++++ src/conf/domain_conf.c | 24 +- src/conf/domain_conf.h | 6 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 21 ++ src/qemu/qemu_driver.c | 341 +++++++++++---------- src/qemu/qemu_monitor.c | 7 +- src/qemu/qemu_monitor.h | 3 +- src/qemu/qemu_monitor_json.c | 39 ++- src/qemu/qemu_monitor_json.h | 3 +- .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 17 +- .../qemuxml2argv-blkdeviotune-max-length.args | 34 ++ .../qemuxml2argv-blkdeviotune-max-length.xml | 65 ++++ tests/qemuxml2argvtest.c | 4 + .../qemuxml2xmlout-blkdeviotune-max-length.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 196 +++++------- tools/virsh.pod | 21 ++ 26 files changed, 673 insertions(+), 298 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-max-length.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-max-length.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-blkdeviotune-max-length.xml -- 2.7.4

2 29

Re: [libvirt] question about rdma migration
by Michael R. Hines 25 Oct '16

25 Oct '16

Hi Roy, On 02/09/2016 03:57 AM, Roy Shterman wrote: > Hi, > > I tried to understand the rdma-migration in qemu code and i have two > questions about it: > > 1. I'm working with qemu-kvm using libvirt and i'm getting > > MEMLOCK max locked-in-memory address space 65536 65536 bytes > > in qemu process so I don't understand how can you use rdma-pin-all > with such low MEMLOCK. > > I found a solution in libvirt to lock all vm memory in advance and to > enlarge MEMLOCK. > It uses memoryBacking locking and memory tuning hard_limit of vm > memory but I couldn't find a usage of this in rdma-migration code. > You're absolutey right, the RDMA migration code itself doesn't set this lock limit explicitly because there are system-wide restrictions in both appArmour, /etc/security, as well as SELINUX that restrict applications from arbitrarily setting their maximum memory lock limits. The other problem is CGROUPS: If someone sets a cgroup control for maximum memory and forgets about that mlock() limits, then there will be a conflict. So, libvirt must have a policy to deal with all of these possibilities, not just handle a special case for RDMA migration. The only way "simple" way (without patching the problems above) to apply a higher lock limit to QEMU is to set the ulimit for libvirt (or for QEMU if starting QEMU manually) in your environment or the command line with $ ulimit # before attempting the migration, then the RDMA subsystem will be able to lock the memory successfully. The other option is to use /etc/security/limits.conf and set the option for a specific libvirt process user and make sure your libvirt/qemu are not running as root. QEMU itself also has a "mlock" option built into the command line, but it also suffers from the same problem --- you have to find a way (currently) to increase the limit before using the option. > 2. Do you have any comparison of IOPS and bandwidth between TCP > migration and rdma migration? > Yes, lots of comparisons. http://wiki.qemu.org/Features/RDMALiveMigration http://www.canturkisci.com/ETC/papers/IBMJRD2011/preprint.pdf > Regards, > Roy > >

5 15

[libvirt] [PATCH] qemu_driver: unlink new domain cfg file when rollbak
by Chen Hanxiao 25 Oct '16

25 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> If we failed to unlink old dom cfg file, we goto rollback. But inside rollback, we fogot to unlink the new dom cfg file. This patch fixes this issue. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_driver.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e6f845d..3f4a2fb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19869,6 +19869,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, char *new_dom_name = NULL; char *old_dom_name = NULL; char *old_dom_cfg_file = NULL; + char *new_dom_cfg_file = NULL; virCheckFlags(0, ret); @@ -19882,6 +19883,11 @@ qemuDomainRenameCallback(virDomainObjPtr vm, goto cleanup; } + if (!(new_dom_cfg_file = virDomainConfigFile(cfg->configDir, + new_dom_name))) { + goto cleanup; + } + event_old = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_UNDEFINED, VIR_DOMAIN_EVENT_UNDEFINED_RENAMED); @@ -19909,6 +19915,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, cleanup: VIR_FREE(old_dom_cfg_file); + VIR_FREE(new_dom_cfg_file); VIR_FREE(old_dom_name); VIR_FREE(new_dom_name); qemuDomainEventQueue(driver, event_old); @@ -19922,6 +19929,10 @@ qemuDomainRenameCallback(virDomainObjPtr vm, vm->def->name = old_dom_name; old_dom_name = NULL; } + + if (virFileExists(new_dom_cfg_file)) + unlink(new_dom_cfg_file); + goto cleanup; } -- 1.8.3.1

1 2

[libvirt] [PATCH python 1/1] fix crash in libvirt_virDomainPin*
by Konstantin Neumoin 25 Oct '16

25 Oct '16

If we pass large(more than cpunum) cpu mask to any libvirt_virDomainPin* methods, it could leads to crash. So we have to check tuple size and ignore extra tuple members. Signed-off-by: Konstantin Neumoin <kneumoin(a)virtuozzo.com> --- libvirt-override.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index fa3e2ca..83b760b 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -1327,7 +1327,7 @@ libvirt_virDomainPinVcpu(PyObject *self ATTRIBUTE_UNUSED, if (VIR_ALLOC_N(cpumap, cpumaplen) < 0) return PyErr_NoMemory(); - for (i = 0; i < tuple_size; i++) { + for (i = 0; i < MIN(cpunum, tuple_size); i++) { PyObject *flag = PyTuple_GetItem(pycpumap, i); bool b; @@ -1392,7 +1392,7 @@ libvirt_virDomainPinVcpuFlags(PyObject *self ATTRIBUTE_UNUSED, if (VIR_ALLOC_N(cpumap, cpumaplen) < 0) return PyErr_NoMemory(); - for (i = 0; i < tuple_size; i++) { + for (i = 0; i < MIN(cpunum, tuple_size); i++) { PyObject *flag = PyTuple_GetItem(pycpumap, i); bool b; @@ -1532,7 +1532,7 @@ libvirt_virDomainPinEmulator(PyObject *self ATTRIBUTE_UNUSED, if (VIR_ALLOC_N(cpumap, cpumaplen) < 0) return PyErr_NoMemory(); - for (i = 0; i < tuple_size; i++) { + for (i = 0; i < MIN(cpunum, tuple_size); i++) { PyObject *flag = PyTuple_GetItem(pycpumap, i); bool b; @@ -1738,7 +1738,7 @@ libvirt_virDomainPinIOThread(PyObject *self ATTRIBUTE_UNUSED, if (VIR_ALLOC_N(cpumap, cpumaplen) < 0) return PyErr_NoMemory(); - for (i = 0; i < tuple_size; i++) { + for (i = 0; i < MIN(cpunum, tuple_size); i++) { PyObject *flag = PyTuple_GetItem(pycpumap, i); bool b; -- 2.5.5

2 1

[libvirt] [PATCH v4 00/25] Use more PCIe less legacy PCI
by Laine Stump 25 Oct '16

25 Oct '16

The latest version of patches to auto-assign appropriate devices in PCIe-capable domains to PCIe slots rather than legacy PCI, and to also auto-add pcie-root-ports as necessary to make this easier. I *think* I've dealt with all of Andrea's great critiques of V3, either in my email responses or in these revised patches. Aside from fixing typos and formatting problems, I also moved several "little cosmetic fixes" out of the bigger functionality-changing patches, and also split out the most confusing part of patch 20 (previously patch 15 - the one that auto-adds pcie-root-port and dmi-to-pci-bridge controllers) into its own patch (doubly useful since the value of that part of the patch is dubious - it is now the [RFC] patch 21) As many of the simple costmetic patches as possible were pushed up to the front of the series (if they weren't already there). If those are ACKed on this round but others aren't, I'll push them immediately so I don't need to resubmit the whole series again. Some of these patches were ACKed last time, but I either had to change them further due to changes in other patches, or I couldn't push them because they have prerequisites that weren't ACKed. I've marked those in the subject line (I've also marked entirely new patches in the subject line). Laine Stump (25): qemu: new functions qemuDomainMachineHasPCI[e]Root() qemu: replace a lot of "def->controllers[i]" with equivalent "cont" qemu: replace "def->nets[i]" with "net" and "def->sounds[i]" with "sound" conf: add typedef for anonymous enum used for memballoon device model qemu: remove superfluous setting of addrs->nbuses qemu: make error message in qemuDomainPCIAddressSetCreate more clear. qemu: change first arg of qemuDomainAttachChrDeviceAssignAddr() conf: new function virDomainPCIAddressReserveNextAddr() qemu: use virDomainPCIAddressReserveNextAddr in qemuDomainAssignDevicePCISlots conf: make virDomainPCIAddressGetNextSlot() a local static function qemu: replace calls to virDomainPCIAddressReserveNext*() with static function qemu: new functions to calculate/set device pciConnectFlags qemu: set/use info->pciConnectFlags when validating/assigning PCI addresses qemu: set/use proper pciConnectFlags during hotplug qemu: set pciConnectFlags to 0 instead of PCI|HOTPLUGGABLE if device isn't PCI qemu: assign virtio devices to PCIe slot when appropriate qemu: assign e1000e network devices to PCIe slots when appropriate qemu: assign nec-xhci (USB3) controller to a PCIe address when appropriate qemu: only force an available legacy-PCI slot on domains with pci-root qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed [RFC] qemu: if pci-bridge is in PCIe config w/o dmi-to-pci-bridge, add it qemu: don't force-add a dmi-to-pci-bridge just on principle qemu: add a USB3 controller to Q35 domains by default qemu: try to put ich9 sound device at 00:1B.0 qemu: initially reserve one open pcie-root-port for hotplug src/conf/device_conf.h | 5 + src/conf/domain_addr.c | 163 ++- src/conf/domain_addr.h | 11 +- src/conf/domain_conf.h | 4 +- src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 52 +- src/qemu/qemu_domain.h | 2 + src/qemu/qemu_domain_address.c | 1097 +++++++++++++++----- src/qemu/qemu_domain_address.h | 4 + src/qemu/qemu_hotplug.c | 27 +- tests/qemuxml2argvdata/qemuxml2argv-autoindex.args | 10 +- .../qemuxml2argv-bios-nvram-secure.args | 1 + .../qemuxml2argv-machine-smm-opt.args | 1 + tests/qemuxml2argvdata/qemuxml2argv-pcie-root.args | 3 +- .../qemuxml2argv-q35-default-devices-only.args | 23 + .../qemuxml2argv-q35-default-devices-only.xml | 18 + .../qemuxml2argv-q35-pcie-autoadd.args | 57 + .../qemuxml2argv-q35-pcie-autoadd.xml | 51 + tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 58 ++ tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.xml | 67 ++ .../qemuxml2argv-q35-pm-disable-fallback.args | 1 + .../qemuxml2argv-q35-pm-disable.args | 1 + .../qemuxml2argv-q35-virt-manager-basic.args | 56 + .../qemuxml2argv-q35-virt-manager-basic.xml | 76 ++ .../qemuxml2argv-q35-virtio-pci.args | 58 ++ .../qemuxml2argv-q35-virtio-pci.xml | 1 + tests/qemuxml2argvtest.c | 164 ++- .../qemuxml2xmlout-autoindex.xml | 10 +- .../qemuxml2xmlout-pcie-root.xml | 4 - .../qemuxml2xmlout-q35-default-devices-only.xml | 45 + .../qemuxml2xmlout-q35-pcie-autoadd.xml | 148 +++ .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 152 +++ .../qemuxml2xmlout-q35-virt-manager-basic.xml | 121 +++ .../qemuxml2xmlout-q35-virtio-pci.xml | 152 +++ tests/qemuxml2xmltest.c | 136 ++- 35 files changed, 2417 insertions(+), 364 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-default-devices-only.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie-autoadd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie-autoadd.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virt-manager-basic.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virt-manager-basic.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pci.args create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-default-devices-only.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie-autoadd.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virtio-pci.xml -- 2.7.4

2 40

[libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests
by Andrea Bolognani 25 Oct '16

25 Oct '16

virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there, we'd like to start using it by default instead of virtio-mmio. Users and applications can already opt-in by explicitly using <address type='pci'/> inside the relevant elements, but that's kinda cumbersome and requires all users and management applications to adapt, which we'd really like to avoid. What we can do instead is use virtio-mmio only if the guest already has at least one virtio-mmio device, and use virtio-pci in all other situations. That means existing virtio-mmio guests will keep using the old addressing scheme, and new guests will automatically be created using virtio-pci instead. Users can still override the default in either direction. --- Sending this as an RFC for the time being because it clearly needs some more polish, but I wanted to get the idea out there sooner rather than later. It needs to be applied on top of Laine's PCI series[1]. [1] https://www.redhat.com/archives/libvir-list/2016-October/msg00699.html src/qemu/qemu_domain_address.c | 128 ++++++++++++++++++++- ...l2argv-aarch64-virt-2.6-virtio-pci-default.args | 14 ++- .../qemuxml2argv-aarch64-virtio-pci-default.args | 14 ++- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 24 +++- 4 files changed, 162 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index f27d1e3..7f07764 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -265,6 +265,118 @@ qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def, } +static bool +qemuDomainAnyDeviceHasAddressOfType(virDomainDefPtr def, + virDomainDeviceAddressType type) +{ + size_t i; + + for (i = 0; i < def->ndisks; i++) { + if (def->disks[i]->info.type == type) + return true; + } + + for (i = 0; i < def->ncontrollers; i++) { + if (def->controllers[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nfss; i++) { + if (def->fss[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nnets; i++) { + if (def->nets[i]->info.type == type) + return true; + } + + for (i = 0; i < def->ninputs; i++) { + if (def->inputs[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nsounds; i++) { + if (def->sounds[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nvideos; i++) { + if (def->videos[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nhostdevs; i++) { + if (def->hostdevs[i]->info->type == type) + return true; + } + + for (i = 0; i < def->nredirdevs; i++) { + if (def->redirdevs[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nsmartcards; i++) { + if (def->smartcards[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nserials; i++) { + if (def->serials[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nparallels; i++) { + if (def->parallels[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nchannels; i++) { + if (def->channels[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nconsoles; i++) { + if (def->consoles[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nhubs; i++) { + if (def->hubs[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nrngs; i++) { + if (def->rngs[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nshmems; i++) { + if (def->shmems[i]->info.type == type) + return true; + } + + for (i = 0; i < def->nmems; i++) { + if (def->mems[i]->info.type == type) + return true; + } + + if (def->memballoon && def->memballoon->info.type == type) + return true; + + if (def->watchdog && def->watchdog->info.type == type) + return true; + + if (def->nvram && def->nvram->info.type == type) + return true; + + if (def->tpm && def->tpm->info.type == type) + return true; + + return false; +} + + static void qemuDomainPrimeVirtioDeviceAddresses(virDomainDefPtr def, virDomainDeviceAddressType type) @@ -390,6 +502,8 @@ static void qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) { + bool usesMMIO; + if (def->os.arch != VIR_ARCH_ARMV7L && def->os.arch != VIR_ARCH_AARCH64) return; @@ -398,9 +512,17 @@ qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def, qemuDomainMachineIsVirt(def))) return; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_MMIO)) { - qemuDomainPrimeVirtioDeviceAddresses( - def, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); + /* We use virtio-mmio by default on mach-virt guests only if they already + * have at least one virtio-mmio device: in all other cases, we prefer + * virtio-pci */ + usesMMIO = qemuDomainAnyDeviceHasAddressOfType(def, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); + if (qemuDomainMachineHasPCIeRoot(def) && !usesMMIO) { + qemuDomainPrimeVirtioDeviceAddresses(def, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); + } else if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_MMIO)) { + qemuDomainPrimeVirtioDeviceAddresses(def, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); } } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args index 75db1a4..df03c6e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args @@ -21,14 +21,18 @@ QEMU_AUDIO_DRV=none \ -initrd /aarch64.initrd \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ --device virtio-serial-device,id=virtio-serial0 \ +-device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \ +-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \ +-device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \ +-device virtio-serial-pci,id=virtio-serial0,bus=pci.2,addr=0x2 \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ --device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ +-device virtio-blk-pci,bus=pci.2,addr=0x3,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-device virtio-net-pci,vlan=0,id=net0,mac=52:54:00:09:a4:37,bus=pci.2,addr=0x1 \ -net user,vlan=0,name=hostnet0 \ -serial pty \ -chardev pty,id=charconsole1 \ -device virtconsole,chardev=charconsole1,id=console1 \ --device virtio-balloon-device,id=balloon0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x4 \ -object rng-random,id=objrng0,filename=/dev/random \ --device virtio-rng-device,rng=objrng0,id=rng0 +-device virtio-rng-pci,rng=objrng0,id=rng0,bus=pci.2,addr=0x5 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args index b5b010c..f205d9a 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args @@ -21,14 +21,18 @@ QEMU_AUDIO_DRV=none \ -initrd /aarch64.initrd \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ --device virtio-serial-device,id=virtio-serial0 \ +-device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \ +-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \ +-device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \ +-device virtio-serial-pci,id=virtio-serial0,bus=pci.2,addr=0x2 \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ --device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ +-device virtio-blk-pci,bus=pci.2,addr=0x3,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-device virtio-net-pci,vlan=0,id=net0,mac=52:54:00:09:a4:37,bus=pci.2,addr=0x1 \ -net user,vlan=0,name=hostnet0 \ -serial pty \ -chardev pty,id=charconsole1 \ -device virtconsole,chardev=charconsole1,id=console1 \ --device virtio-balloon-device,id=balloon0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x4 \ -object rng-random,id=objrng0,filename=/dev/random \ --device virtio-rng-device,rng=objrng0,id=rng0 +-device virtio-rng-pci,rng=objrng0,id=rng0,bus=pci.2,addr=0x5 diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml index 7c3fc19..90659a1 100644 --- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml @@ -30,16 +30,30 @@ <disk type='file' device='disk'> <source file='/aarch64.raw'/> <target dev='vda' bus='virtio'/> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x03' function='0x0'/> </disk> <controller type='pci' index='0' model='pcie-root'/> <controller type='virtio-serial' index='0'> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x02' function='0x0'/> + </controller> + <controller type='pci' index='1' model='dmi-to-pci-bridge'> + <model name='i82801b11-bridge'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </controller> + <controller type='pci' index='2' model='pci-bridge'> + <model name='pci-bridge'/> + <target chassisNr='2'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> + </controller> + <controller type='pci' index='3' model='pcie-root-port'> + <model name='ioh3420'/> + <target chassis='3' port='0x10'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </controller> <interface type='user'> <mac address='52:54:00:09:a4:37'/> <model type='virtio'/> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x01' function='0x0'/> </interface> <serial type='pty'> <target port='0'/> @@ -51,11 +65,11 @@ <target type='virtio' port='1'/> </console> <memballoon model='virtio'> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x04' function='0x0'/> </memballoon> <rng model='virtio'> <backend model='random'>/dev/random</backend> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x05' function='0x0'/> </rng> </devices> </domain> -- 2.7.4

4 9

[libvirt] how to install and remove Libvirt cleanly
by zhunxun＠gmail.com 25 Oct '16

25 Oct '16

I just want to know how to uninstall Libvirt which installed by source code cleanly.because I found make uninstall can not remove all the installed file.so that I install it later failed. zhunxun(a)gmail.com

1 0

[libvirt] [PATCH 0/4] Add VCPU halted to domain statistics
by Viktor Mihajlovski 25 Oct '16

25 Oct '16

As a result of the discussions on https://www.redhat.com/archives/libvir-list/2016-October/msg00531.html: In order to be able to report the per VCPU halted condition as returned by the QEMU monitor this series extends the VCPU-specific domain statistics with a vcpu.n.halted value. This is done by - extending the monitor to pass back the halted condition for the vcpus - adding a new field to the private domain vcpu object reflecting the halted condition for the vcpu - modifying the driver code to report the new VCPU domain statistics value The halted condition is however not recorded in the internal XML format, since the state can change asynchronously (without notification). Patches 1/4 and 2/4 are taken without modifications from the original posting. In 4/4 I've only updated virsh.pod as I didn't want to touch libvirt-domain.c in this context just for documentation purposes. Viktor Mihajlovski (4): qemu: Add monitor support for CPU halted state qemu: Add domain support for VCPU halted state qemu: add vcpu.n.halted to vcpu domain stats doc: update virsh domstats documentation for vcpu statistics src/qemu/qemu_domain.c | 66 ++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 5 ++++ src/qemu/qemu_driver.c | 34 ++++++++++++++++++++--- src/qemu/qemu_monitor.c | 6 +++- src/qemu/qemu_monitor.h | 3 ++ src/qemu/qemu_monitor_json.c | 3 ++ src/qemu/qemu_monitor_text.c | 8 +++++- tests/qemumonitorjsontest.c | 8 +++--- tools/virsh.pod | 7 +++++ 9 files changed, 130 insertions(+), 10 deletions(-) -- 1.9.1

2 8

[libvirt] [jenkins-ci PATCH] jobs: change maintainer email address
by Pavel Hrdina 25 Oct '16

25 Oct '16

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as trivial. jobs/defaults.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml index 23d9ae7..b21bff3 100644 --- a/jobs/defaults.yaml +++ b/jobs/defaults.yaml @@ -9,4 +9,4 @@ MAKE='gmake' fi smp: 3 - spam: shajyan(a)redhat.com libvirt-ci(a)redhat.com + spam: ymankad(a)redhat.com libvirt-ci(a)redhat.com -- 2.10.1

1 0

[libvirt] [PATCH] libxl: fix leaking of allocated migration ports
by Jim Fehlig 25 Oct '16

25 Oct '16

Although the migration port is immediately released in the finish phase of migration, it was never set in the domain private object when allocated in the prepare phase. So libxlDomainMigrationFinish() always released a 0-initialized migrationPort, leaking any allocated port. After enough migrations to exhaust the migration port pool, migration would fail with error: internal error: Unable to find an unused port in range 'migration' (49152-49216) Fix it by setting libxlDomainObjPrivate->migrationPort to the port allocated in the prepare phase. While at it, also fix leaking an allocated port if the prepare phase fails. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_migration.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 534abb8..a471d2a 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -594,6 +594,7 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0) goto error; + priv->migrationPort = port; if (virAsprintf(uri_out, "tcp://%s:%d", hostname, port) < 0) goto error; } else { @@ -628,6 +629,7 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0) goto error; + priv->migrationPort = port; } else { port = uri->port; } @@ -690,6 +692,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, } VIR_FREE(socks); virObjectUnref(args); + virPortAllocatorRelease(driver->migrationPorts, priv->migrationPort); + priv->migrationPort = 0; /* Remove virDomainObj from domain list */ if (vm) { -- 2.9.2

2 2

[libvirt] [RFC PATCH v2] qemu: Use virtio-pci by default for mach-virt guests
by Andrea Bolognani 25 Oct '16

25 Oct '16

virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there, we'd like to start using it by default instead of virtio-mmio. Users and applications can already opt-in by explicitly using <address type='pci'/> inside the relevant elements, but that's kind of cumbersome and requires all users and management applications to adapt, which we'd really like to avoid. What we can do instead is use virtio-mmio only if the guest already has at least one virtio-mmio device, and use virtio-pci in all other situations. That means existing virtio-mmio guests will keep using the old addressing scheme, and new guests will automatically be created using virtio-pci instead. Users can still override the default in either direction. --- RFC: still needs polish (documentation, test cases) before it can be considered for merging, plus it builds on top of changes that haven't made it into master yet. Changes from v1: * use virDomainDeviceInfoIterate(), as suggested by Martin and Laine, which results in cleaner and more robust code src/qemu/qemu_domain_address.c | 39 ++++++++++++++++++++-- ...l2argv-aarch64-virt-2.6-virtio-pci-default.args | 14 +++++--- .../qemuxml2argv-aarch64-virtio-pci-default.args | 14 +++++--- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 24 ++++++++++--- 4 files changed, 73 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index f27d1e3..30b1ddf 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -386,6 +386,32 @@ qemuDomainAssignS390Addresses(virDomainDefPtr def, } +static int +qemuDomainCountVirtioMMIODevicesCallback(virDomainDefPtr def ATTRIBUTE_UNUSED, + virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, + virDomainDeviceInfoPtr info, + void *opaque) +{ + if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO) + (*((size_t *) opaque))++; + + return 0; +} + + +static size_t +qemuDomainCountVirtioMMIODevices(virDomainDefPtr def) +{ + size_t count = 0; + + virDomainDeviceInfoIterate(def, + qemuDomainCountVirtioMMIODevicesCallback, + &count); + + return count; +} + + static void qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) @@ -398,9 +424,16 @@ qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def, qemuDomainMachineIsVirt(def))) return; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_MMIO)) { - qemuDomainPrimeVirtioDeviceAddresses( - def, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); + /* We use virtio-mmio by default on mach-virt guests only if they already + * have at least one virtio-mmio device: in all other cases, we prefer + * virtio-pci */ + if (qemuDomainMachineHasPCIeRoot(def) && + qemuDomainCountVirtioMMIODevices(def) == 0) { + qemuDomainPrimeVirtioDeviceAddresses(def, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); + } else if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_MMIO)) { + qemuDomainPrimeVirtioDeviceAddresses(def, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO); } } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args index 75db1a4..df03c6e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args @@ -21,14 +21,18 @@ QEMU_AUDIO_DRV=none \ -initrd /aarch64.initrd \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ --device virtio-serial-device,id=virtio-serial0 \ +-device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \ +-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \ +-device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \ +-device virtio-serial-pci,id=virtio-serial0,bus=pci.2,addr=0x2 \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ --device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ +-device virtio-blk-pci,bus=pci.2,addr=0x3,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-device virtio-net-pci,vlan=0,id=net0,mac=52:54:00:09:a4:37,bus=pci.2,addr=0x1 \ -net user,vlan=0,name=hostnet0 \ -serial pty \ -chardev pty,id=charconsole1 \ -device virtconsole,chardev=charconsole1,id=console1 \ --device virtio-balloon-device,id=balloon0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x4 \ -object rng-random,id=objrng0,filename=/dev/random \ --device virtio-rng-device,rng=objrng0,id=rng0 +-device virtio-rng-pci,rng=objrng0,id=rng0,bus=pci.2,addr=0x5 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args index b5b010c..f205d9a 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args @@ -21,14 +21,18 @@ QEMU_AUDIO_DRV=none \ -initrd /aarch64.initrd \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ --device virtio-serial-device,id=virtio-serial0 \ +-device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \ +-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \ +-device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \ +-device virtio-serial-pci,id=virtio-serial0,bus=pci.2,addr=0x2 \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ --device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ +-device virtio-blk-pci,bus=pci.2,addr=0x3,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-device virtio-net-pci,vlan=0,id=net0,mac=52:54:00:09:a4:37,bus=pci.2,addr=0x1 \ -net user,vlan=0,name=hostnet0 \ -serial pty \ -chardev pty,id=charconsole1 \ -device virtconsole,chardev=charconsole1,id=console1 \ --device virtio-balloon-device,id=balloon0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x4 \ -object rng-random,id=objrng0,filename=/dev/random \ --device virtio-rng-device,rng=objrng0,id=rng0 +-device virtio-rng-pci,rng=objrng0,id=rng0,bus=pci.2,addr=0x5 diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml index 7c3fc19..90659a1 100644 --- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml @@ -30,16 +30,30 @@ <disk type='file' device='disk'> <source file='/aarch64.raw'/> <target dev='vda' bus='virtio'/> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x03' function='0x0'/> </disk> <controller type='pci' index='0' model='pcie-root'/> <controller type='virtio-serial' index='0'> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x02' function='0x0'/> + </controller> + <controller type='pci' index='1' model='dmi-to-pci-bridge'> + <model name='i82801b11-bridge'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </controller> + <controller type='pci' index='2' model='pci-bridge'> + <model name='pci-bridge'/> + <target chassisNr='2'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> + </controller> + <controller type='pci' index='3' model='pcie-root-port'> + <model name='ioh3420'/> + <target chassis='3' port='0x10'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </controller> <interface type='user'> <mac address='52:54:00:09:a4:37'/> <model type='virtio'/> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x01' function='0x0'/> </interface> <serial type='pty'> <target port='0'/> @@ -51,11 +65,11 @@ <target type='virtio' port='1'/> </console> <memballoon model='virtio'> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x04' function='0x0'/> </memballoon> <rng model='virtio'> <backend model='random'>/dev/random</backend> - <address type='virtio-mmio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x05' function='0x0'/> </rng> </devices> </domain> -- 2.7.4

2 1

[libvirt] [PATCH 00/11] clean up after "slot sharing" patches
by Laine Stump 24 Oct '16

24 Oct '16

Some of the patches that enabled sharing PCI slots by multiple pcie-root-ports made the idea of reserving an entire slot obsolete. To reduce confusion and misunderstandings, this patch series gets rid of the name "Slot" in all of the functions that reserve and release PCI addresses. None of these patches affect any functional change. This is a lot of patches, but each patch is trivial, I promise - most are simply renaming a single function, or changing one argument to some calls to a function. Laine Stump (11): conf: fix fromConfig argument to virDomainPCIAddressReserveAddr() conf: fix fromConfig argument to virDomainPCIAddressValidate() conf: rename virDomainPCIAddressGetNextSlot() to ...GetNextAddr() conf: eliminate virDomainPCIAddressReserveNextSlot() qemu: replace virDomainPCIAddressReserveAddr with virDomainPCIAddressReserveSlot conf: make virDomainPCIAddressReserveAddr() a static function conf: rename virDomainPCIAddressReserveAddr() to ...Internal() conf: rename virDomainPCIAddressReserveSlot() to ...Addr() qemu: remove qemuDomainPCIAddressReserveNextAddr() qemu: rename qemuDomainPCIAddressReserveNextSlot() to ...Addr() conf: eliminate virDomainPCIAddressReleaseSlot() in favor of ...Addr() src/bhyve/bhyve_device.c | 26 +++++++---- src/conf/domain_addr.c | 60 ++++++------------------ src/conf/domain_addr.h | 15 ------ src/libvirt_private.syms | 4 +- src/qemu/qemu_domain_address.c | 102 +++++++++++++++++++---------------------- 5 files changed, 78 insertions(+), 129 deletions(-) -- 2.7.4

1 11

[libvirt] [PATCH 0/8] aggregate multiple pcie-root-ports onto a single slot
by Laine Stump 24 Oct '16

24 Oct '16

These patches implement a reccomendation from Gerd Hoffman during discussion of Marcel Apfelbaum's proposed "PCIe devices placement guidelines" document on qemu-devel: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01381.html The basic idea is to put up to 8 pcie-root-ports on each slot of pcie-root, rather than libvirt's historical practice of assigning only a single device to each slot. This is done by defining a new pciConnectFlag - VIR_PCI_CONNECT_AGGREGATE_SLOT - which is set for any device that can be automatically placed together with other similarly flagged devices on multiple functions of the same slot. In this way we can auto-address up to 224 hotpluggable PCIe devices without needing to figure out how to automatically add upstream/downstream ports. Other types of devices could be given the same treatment, although it would make no sense for anything that you wanted to be hotplugable. In order for this all to work nicely and make sense, the PCI address reservation code has eliminated the "reserveEntireSlot" concept - if the first device assigned to a particular slot doesn't have the AGGREGATE_SLOT flag set, then it will be the only device allowed on that slot even though the address set only shows function 0 as being in use. After all of this change, using the term "Slot" in so many function names no longer makes sense; there is another patchset that I will post shortly that gets rid of all that "old inaccurate" naming. I made it separate because it isn't strictly necessary for the AGGREGATE_SLOT functionality. This series needs to be applied on top of my earlier series that adds support for plugging virtio devices into PCIe slots. Laine Stump (8): conf: use struct instead of int for each slot in virDomainPCIAddressBus conf: eliminate concept of "reserveEntireSlot" conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot() conf: start search for next unused PCI address at same slot as previous find conf: new function virDomainPCIAddressIsMulti() qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting conf: aggregate multiple devices on a slot when assigning PCI addresses conf: aggregate multiple pcie-root-ports onto a single slot src/conf/domain_addr.c | 290 ++++++++++++++------- src/conf/domain_addr.h | 48 +++- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 16 +- src/qemu/qemu_domain_address.c | 35 ++- .../qemuxml2argv-pcie-root-port.args | 5 +- .../qemuxml2argv-pcie-switch-upstream-port.args | 5 +- .../qemuxml2argv-q35-default-devices-only.args | 7 +- .../qemuxml2argv-q35-multifunction.args | 43 +++ .../qemuxml2argv-q35-multifunction.xml | 51 ++++ .../qemuxml2argv-q35-pcie-autoadd.args | 30 ++- tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 28 +- .../qemuxml2argv-q35-virt-manager-basic.args | 13 +- .../qemuxml2argv-q35-virtio-pci.args | 28 +- tests/qemuxml2argvtest.c | 25 ++ .../qemuxml2xmlout-pcie-root-port.xml | 2 +- .../qemuxml2xmlout-pcie-switch-upstream-port.xml | 4 +- .../qemuxml2xmlout-q35-default-devices-only.xml | 8 +- .../qemuxml2xmlout-q35-multifunction.xml | 120 +++++++++ .../qemuxml2xmlout-q35-pcie-autoadd.xml | 52 ++-- .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 48 ++-- .../qemuxml2xmlout-q35-virt-manager-basic.xml | 20 +- .../qemuxml2xmlout-q35-virtio-pci.xml | 48 ++-- tests/qemuxml2xmltest.c | 25 ++ 24 files changed, 676 insertions(+), 276 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-multifunction.xml -- 2.7.4

1 8

[libvirt] [PATCH] virQEMUCapsReset: also clear out hostCPUModel
by Ján Tomko 24 Oct '16

24 Oct '16

After succesfully reading an outdated caps cache from disk, calling virQEMUCapsReset did not properly clear out the host CPU model. This lead to a memory leak when the host CPU model pointer was overwritten later in virQEMUCapsNewForBinaryInternal. Introduced by commit 68c70118. --- src/qemu/qemu_capabilities.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9132469..130f1db 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3430,6 +3430,9 @@ virQEMUCapsReset(virQEMUCapsPtr qemuCaps) VIR_FREE(qemuCaps->gicCapabilities); qemuCaps->ngicCapabilities = 0; + + virCPUDefFree(qemuCaps->hostCPUModel); + qemuCaps->hostCPUModel = NULL; } -- 2.7.3

2 1

[libvirt] [PATCH 0/3] last part of TLS encryption for char devices
by Pavel Hrdina 24 Oct '16

24 Oct '16

Pavel Hrdina (3): qemu_hotplug: remove union for one member domain: Add optional 'tls' attribute for TCP chardev domain: fix migration to older libvirt docs/formatdomain.html.in | 28 +++++++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 67 +++++++++++++++++----- src/conf/domain_conf.h | 6 +- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 67 ++++++++++++++++++++++ src/qemu/qemu_domain.h | 8 +++ src/qemu/qemu_hotplug.c | 16 ++++-- src/qemu/qemu_process.c | 2 + ...uxml2argv-serial-tcp-tlsx509-chardev-notls.args | 30 ++++++++++ ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 50 ++++++++++++++++ tests/qemuxml2argvtest.c | 3 + ...xml2xmlout-serial-tcp-tlsx509-chardev-notls.xml | 1 + tests/qemuxml2xmltest.c | 1 + 14 files changed, 266 insertions(+), 22 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev-notls.xml -- 2.10.1

2 9

[libvirt] [PATCH] doc: Describe the VCPU states returned by virsh vcpuinfo
by Viktor Mihajlovski 24 Oct '16

24 Oct '16

Added a brief description of the VCPU states. Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com> --- tools/virsh.pod | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index 9e3a248..6d4fd07 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2536,6 +2536,55 @@ vCPUs, the running time, the affinity to physical processors. With I<--pretty>, cpu affinities are shown as ranges. +An example output is + + $ virsh vcpuinfo fedora + VCPU: 0 + CPU: 0 + State: running + CPU time: 7,0s + CPU Affinity: yyyy + + VCPU: 1 + CPU: 1 + State: running + CPU time: 0,7s + CPU Affinity: yyyy + +B<STATES> + +The State field displays the current operating state of a virtual CPU + +=over 4 + +=item B<offline> + +The virtual CPU is offline and not usable by the domain. +This state is not supported by all hypervisors. + +=item B<running> + +The virtual CPU is available to the domain and is operating. + +=item B<blocked> + +The virtual CPU is available to the domain but is waiting for a resource. +This state is not supported by all hypervisors, in which case I<running> +may be reported instead. + +=item B<no state> + +The virtual CPU state could not be determined. This could happen if +the hypervisor is newer than virsh. + +=item B<N/A> + +There's no information about the virtual CPU state available. This can +be the case if the domain is not running or the hypervisor does +not report the virtual CPU state. + +=back + =item B<vcpupin> I<domain> [I<vcpu>] [I<cpulist>] [[I<--live>] [I<--config>] | [I<--current>]] -- 1.9.1

2 2

[libvirt] [PATCH] domain_conf: fix memory leak in virDomainDefAddConsoleCompat
by Pavel Hrdina 24 Oct '16

24 Oct '16

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 748ffd5..6100c3d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3895,7 +3895,7 @@ virDomainDefAddConsoleCompat(virDomainDefPtr def) 0, def->nconsoles, chr) < 0) { - VIR_FREE(chr); + virDomainChrDefFree(chr); return -1; } -- 2.10.1

2 1

[libvirt] Race in log manager causes segfault
by Bjoern Walk 24 Oct '16

24 Oct '16

Hello, I am currently investigating a rare segfault in libvirt. I have attached a backtrace, the coredump is for s390x. I am currently trying to reproduce the segfault on x86 but it did not occur yet (timespan to short). This can be triggered by rapidly performing domain start/stop cycles in a tight loop and will trigger in the order of a couple weeks. I have come to the conclusion that there seems to be a race condition in the log manager client. When the log manager gets freed via virLogManagerFree() it (asynchronously) invokes virNetClientClose() and unrefs the associated client structure in virLogManager. If there are other threads waiting for data on the socket they will be woken up but because they rely on virLogManager holding a ref to the client we get a use-after-free. Can anyone verify this analysis and either provide a fix or at least give me some pointers in the right direction on how to further proceed for debugging? Should I open a bug for this? Best regards, Bjoern

1 0

[libvirt] Plans for next release 2.4.0
by Daniel Veillard 24 Oct '16

24 Oct '16

I will be in vacation this week, but should be able to make the release candidate on Thursday, which means that if I can make a CR2 release on the week-end, we should be able to push 2.4.0 around Nov 1st if everything looks good. There is a few tests who went red in https://ci.centos.org/view/libvirt-project/ maybe something to look at in the meantime, thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 0/4] Complete virDomainChrSourceDefPtr adjustments
by John Ferlan 24 Oct '16

24 Oct '16

Similar to _virDomainChrDef, alter _virDomainSmartcardDef and _virDomainRedirdevDef in order to use a virDomainChrSourceDefPtr. This includes modifying the relevant allocations for the source. Next, modify the virDomainRNGDef allocation to use virDomainChrSourceNew rather than a straight VIR_ALLOC. Finally, add the "missing" iterators for RNG and Redirdev. All this should set up what's necessary in order to handle adding the TLS chardev TCP for all chr, smartcard, rng, and redirdev devices. John Ferlan (4): conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru' conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr' conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation conf: Add iterators for RNG and Redirdev src/conf/domain_audit.c | 2 +- src/conf/domain_conf.c | 122 ++++++++++++++++++++++++++++++---------- src/conf/domain_conf.h | 22 +++++++- src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 4 +- src/qemu/qemu_hotplug.c | 2 +- src/security/security_selinux.c | 4 +- 7 files changed, 119 insertions(+), 39 deletions(-) -- 2.7.4

2 8

[libvirt] [PATCH 0/4] Add TLS for TCP chardev redirdev and rng backends
by John Ferlan 24 Oct '16

24 Oct '16

This "would" conflict with other TLS/TCP changes on list depending on order of commit, but it does work against the current top. The conflict would be limited to the new helper qemuDomainGetChardevTLSObjects and changing the 'if (!cfg->chardevTLS)' to the corresponding 'if dev->source.data.tcp.haveTLS != VIR_TRISTATE_BOOL_YES)' once Pavel's changes are in and of course removing the need to fetch 'cfg'. Then if my other changes related to making 'source' a pointer in the _virDomainChrDef is accepted, the 'source.' here would change to 'source->'. Essentially during the review process of adding a secret to access the TLS environment, it was determined that the backends for redirdev and rng weren't adding the TLS object on hotplug, even though the command line processing would add it. NB: Smartcard would be in the same category, but it doesn't support hotplug, so we're off the hook for that. John Ferlan (4): qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug qemu: Clean up error path in qemuDomainAttachRedirdevDevice qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice qemu: Add TLS hotplug for qemuDomainAttachRNGDevice src/qemu/qemu_hotplug.c | 125 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 99 insertions(+), 26 deletions(-) -- 2.7.4

2 8

[libvirt] 转发: Re: How libvirt address qemu command line args
by zhunxun＠gmail.com 23 Oct '16

23 Oct '16

zhunxun(a)gmail.com 发件人： zhunxun(a)gmail.com 发送时间： 2016-10-23 17:42 收件人： berrange 主题： Re: Re: [libvirt] How libvirt address qemu command line args Thanks，However,I have to use this method.Now I wander how get the VM xml contents in Libvirt source code,I try output some message in qemuProcessStart function like this ,but I get nothing,anyone can help me?? thanks! my code is : in qemuStartProcess function char *str=qemuDomainDefFormatXML(driver, vm->def, 0); FILE *op=fopen("/root/libvirt.log","a"); if(op!=NULL){ if(str!=NULL) fprintf(op,"str----cmd : %s\n",str); else fprintf(op,"str is null\n"); fclose(op); }else{ fprintf(op,"open file error!\n"); } zhunxun(a)gmail.com From: Daniel P. Berrange Date: 2016-10-19 15:35 To: Michal Privoznik CC: zhunxun(a)gmail.com; libvir-list Subject: Re: [libvirt] How libvirt address qemu command line args On Wed, Oct 19, 2016 at 10:17:21AM +0800, Michal Privoznik wrote: > On 18.10.2016 14:59, zhunxun(a)gmail.com wrote: > > Now I want to add some args about TPM to domain's XML,so I can start a domain by virt-manager or other virsh command,and then ,I would like to use sVIrt security context to label vTPM and correspondingVM,But I do not know how to get these XML args in libvirt. > > the key problem is that how can i get and recognize these args!!! > > related XML content : > > Usually, grepping the code for cmd name <-> XML element/attribute > translation is sufficient (esp. if you grep tests/) > > > > > <qemu:commandline> > > <qemu:arg value='-enable-kvm'/> > > Firstly, this is obsolete in favour of "-machine accel=kvm". In any > case, <domain type='kvm'/> will do the trick (libvirt will use whatever > is supported by qemu binary in your system). > > > <qemu:arg value='-drive'/> > > <qemu:arg value='file=/root/nvram_2.0-jin.qcow2,if=none,id=nvram0-0-0,format=qcow2'/> > > Okay, this is not supported by libvirt yet. We don't really have a way > how to specify NVRAM in anything other than a raw file. BTW: isn't qcow > too big gun for NVRAM? I mean, NVRAM has a fixed size of what ~190 KB? > QCOW header is about the same size. > > > <qemu:arg value='-device'/> > > <qemu:arg value='tpm-tis,tpmdev=tpm-tpm0,id=tpm0'/> > > <qemu:arg value='-tpmdev'/> > > <qemu:arg value='libtpms,id=tpm-tpm0,nvram=nvram0-0-0,startup=clear'/> > > I'm not sure there's a way how to put startup=clean on the cmd line. I'm > not even sure what it does. > And I have not idea what libtpms is either :-) > > > <qemu:arg value='-bios'/> > > <qemu:arg value='/root/xenSeabios/out/bios.bin'/> > > </qemu:commandline> > > On top of all that - QEMU is likely to fail to start since libvirt by default runs it as qemu:qemu user/group, and so it won't have permission to read any of the files in /root. If you have selinux/apparmour that will also block permission. This is an example of why usage of qemu:commandline is discouraged - it will always have problems with permissions if you pass files using it. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

1 0

[libvirt] [PATCH 0/3] Alter 'source' to be virDomainChrSourceDefPtr in _virDomainChrDef
by John Ferlan 21 Oct '16

21 Oct '16

Yes, it's absolutely terrifying; however, in order to "fix" problems noted during the review of the TLS chardev TCP 'properly' making the 'source' be a pointer and then moving the 'privateData' from _virDomainChrDef to _virDomainChrSourceDef will allow for setting of the 'secinfo' for the smartcard, rng, and redirdev backends that use a TCP channel. 95% of the changes obviously fell out of build issues from a 'make check syntax-check'. The remaining 5% of the changes are from sources I don't normally build; however, those were found by using cscope on the sources and finding references of "source\.{type|data|logfile|logappend} (IOW: virDomainChrSourceDef members). John Ferlan (3): vmx: Use the allocator virDomainChrDefNew Introduce virDomainChrSourceDefNew for virDomainChrDefPtr conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef src/bhyve/bhyve_command.c | 8 ++--- src/bhyve/bhyve_driver.c | 2 +- src/bhyve/bhyve_parse_command.c | 20 +++++------ src/conf/domain_audit.c | 4 +-- src/conf/domain_conf.c | 53 +++++++++++++++++---------- src/conf/domain_conf.h | 4 +-- src/libxl/libxl_conf.c | 42 +++++++++++----------- src/libxl/libxl_domain.c | 22 ++++++------ src/libxl/libxl_driver.c | 4 +-- src/lxc/lxc_driver.c | 4 +-- src/lxc/lxc_native.c | 2 +- src/lxc/lxc_process.c | 6 ++-- src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_command.c | 28 +++++++-------- src/qemu/qemu_domain.c | 16 ++++----- src/qemu/qemu_driver.c | 8 ++--- src/qemu/qemu_hotplug.c | 6 ++-- src/qemu/qemu_parse_command.c | 4 +-- src/qemu/qemu_process.c | 28 +++++++-------- src/security/security_dac.c | 4 +-- src/security/security_selinux.c | 4 +-- src/security/virt-aa-helper.c | 70 ++++++++++++++++++------------------ src/uml/uml_conf.c | 14 ++++---- src/uml/uml_driver.c | 12 +++---- src/vbox/vbox_common.c | 46 ++++++++++++------------ src/vmx/vmx.c | 78 ++++++++++++++++++++-------------------- src/vz/vz_sdk.c | 78 ++++++++++++++++++++-------------------- src/xen/xen_driver.c | 4 +-- src/xenconfig/xen_sxpr.c | 76 +++++++++++++++++++-------------------- src/xenconfig/xen_xl.c | 14 ++++---- tests/securityselinuxlabeltest.c | 14 ++++---- 31 files changed, 346 insertions(+), 331 deletions(-) -- 2.7.4

2 8

[libvirt] [PATCH 00/15] qemu: Add QMP schema introspection and use it to add gluster debug setting
by Peter Krempa 21 Oct '16

21 Oct '16

Add support for QMP schema introspection along with test data adding and fixup and use it to detect support for gluster debug setting in qemu. Thanks to Andrea and Pavel for gathering test data for me so I don't have to compile multiple qemu versions or deal with minority architectures. (I honoured them by granting them autorship on the patches) This series also includes the gluster posting from Prasanna which I've properly split, reordered and fixed. Andrea Bolognani (5): tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on ppc64le tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv2 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv3 Pavel Hrdina (3): tests: qemucaps: Add QMP introspection data for qemu 2.5.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.7.0 on x86 Peter Krempa (4): util: json: add helper to iterate and steal members of json array qemu: monitor: Add code to retrieve and store QMP schema data tests: qemucaps: Temporarily remove 'query-qmp-schema' from test data qemu: capabilities: Add support for QMP schema introspection Prasanna Kumar Kalever (3): qemu: capabilities: Detect support for gluster debug setting qemu: conf: add option for tuning debug logging level qemu: command: Add debug option for gluster volumes src/libvirt_private.syms | 1 + src/qemu/libvirtd_qemu.aug | 3 + src/qemu/qemu.conf | 20 + src/qemu/qemu_capabilities.c | 183 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 19 +- src/qemu/qemu_command.h | 1 + src/qemu/qemu_conf.c | 3 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_monitor.c | 11 + src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 67 + src/qemu/qemu_monitor_json.h | 3 + src/util/virjson.c | 36 + src/util/virjson.h | 6 + .../qemuargv2xml-disk-drive-network-gluster.args | 7 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 7545 ++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.replies | 8036 ++++++++++++++++++- .../caps_2.6.0-gicv2.aarch64.xml | 3 +- .../caps_2.6.0-gicv3.aarch64.replies | 8007 ++++++++++++++++++- .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../caps_2.6.0.ppc64le.replies | 8026 ++++++++++++++++++- tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 5 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 8005 +++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 8356 ++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + .../qemuxml2argv-disk-drive-network-gluster.args | 12 +- tests/qemuxml2argvtest.c | 3 +- 31 files changed, 48326 insertions(+), 48 deletions(-) 1000:1 ratio ;) -- 2.10.0

2 31

[libvirt] [PATCH] xenFormatXLDisk: Fix commas for arguments
by Michal Privoznik 21 Oct '16

21 Oct '16

instead of: virBufferAdd(buf, "arg1,"); virBufferAdd(buf, "arg2"); lets have: virBufferAdd(buf, "arg1"); virBufferAdd(buf, ",arg2"); Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/xenconfig/xen_xl.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 742f1ef..337f9dd 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1022,33 +1022,33 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) virBufferAddLit(&buf, "format="); switch (format) { case VIR_STORAGE_FILE_RAW: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); break; case VIR_STORAGE_FILE_VHD: - virBufferAddLit(&buf, "xvhd,"); + virBufferAddLit(&buf, "xvhd"); break; case VIR_STORAGE_FILE_QCOW: - virBufferAddLit(&buf, "qcow,"); + virBufferAddLit(&buf, "qcow"); break; case VIR_STORAGE_FILE_QCOW2: - virBufferAddLit(&buf, "qcow2,"); + virBufferAddLit(&buf, "qcow2"); break; /* set default */ default: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); } /* device */ - virBufferAsprintf(&buf, "vdev=%s,", disk->dst); + virBufferAsprintf(&buf, ",vdev=%s", disk->dst); /* access */ - virBufferAddLit(&buf, "access="); + virBufferAddLit(&buf, ",access="); if (disk->src->readonly) - virBufferAddLit(&buf, "ro,"); + virBufferAddLit(&buf, "ro"); else if (disk->src->shared) - virBufferAddLit(&buf, "!,"); + virBufferAddLit(&buf, "!"); else - virBufferAddLit(&buf, "rw,"); + virBufferAddLit(&buf, "rw"); if (disk->transient) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("transient disks not supported yet")); @@ -1057,18 +1057,18 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) /* backendtype */ if (driver) { - virBufferAddLit(&buf, "backendtype="); + virBufferAddLit(&buf, ",backendtype="); if (STREQ(driver, "qemu") || STREQ(driver, "file")) - virBufferAddLit(&buf, "qdisk,"); + virBufferAddLit(&buf, "qdisk"); else if (STREQ(driver, "tap")) - virBufferAddLit(&buf, "tap,"); + virBufferAddLit(&buf, "tap"); else if (STREQ(driver, "phy")) - virBufferAddLit(&buf, "phy,"); + virBufferAddLit(&buf, "phy"); } /* devtype */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) - virBufferAddLit(&buf, "devtype=cdrom,"); + virBufferAddLit(&buf, ",devtype=cdrom"); /* * target @@ -1082,7 +1082,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) goto cleanup; if (target) - virBufferAsprintf(&buf, "target=%s", target); + virBufferAsprintf(&buf, ",target=%s", target); if (virBufferCheckError(&buf) < 0) goto cleanup; -- 2.8.4

2 3

[libvirt] [PATCH 0/2] vz: add serial number to disk devices
by Nikolay Shirokovskiy 21 Oct '16

21 Oct '16

Only the first patch is really on the subject. The second one is bugfix that is included mainly because it touches the same place (and nice to have to test first patch too...) Nikolay Shirokovskiy (2): vz: add serial number to disk devices vz: set something in disk driver name src/vz/vz_sdk.c | 16 ++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) -- 1.8.3.1

2 5

[libvirt] [PATCH v2 0/3] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 21 Oct '16

21 Oct '16

Actually this is a combination of the two previous series https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html and https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html Maxim Nestratov (1): util: qemu: make qemuSafeSerialParamValue function usable by other drivers Nikolay Shirokovskiy (2): vz: set something in disk driver name vz: add serial number to disk devices src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 24 ++++++++++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 6 files changed, 47 insertions(+), 21 deletions(-) -- 2.4.11

1 4

[libvirt] [PATCH] bhyve: Need to add parameter to virDomainChrDefNew
by John Ferlan 21 Oct '16

21 Oct '16

Commit id '5f2a13278' missed this one. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as build breaker https://ci.centos.org/view/libvirt-project/job/libvirt-master-build/150/sys… src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index fd9384d..1a7de3d 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -287,7 +287,7 @@ bhyveParseBhyveLPCArg(virDomainDefPtr def, /* Only support com%d */ if (STRPREFIX(type, "com") && type[4] == 0) { - if (!(chr = virDomainChrDefNew())) + if (!(chr = virDomainChrDefNew(NULL))) goto error; chr->source.type = VIR_DOMAIN_CHR_TYPE_NMDM; -- 2.7.4

1 0

[libvirt] [PATCH 0/4] qemuBuildHostNetStr cleanups
by Ján Tomko 21 Oct '16

21 Oct '16

This is not a blurb. Ján Tomko (4): qemuBuildHostNetStr: use type_sep earlier qemuBuildHostNetStr: do not start options with a comma qemuBuildHostNetStr: move stray VIR_DOMAIN_NET_TYPE_INTERNAL qemuBuildHostNetStr: remove dead code src/qemu/qemu_command.c | 49 +++++++++++++++++++++---------------------------- 1 file changed, 21 insertions(+), 28 deletions(-) -- 2.7.3

2 8

[libvirt] [PATCH v10 0/4] Add native TLS encrypted chardev TCP support
by John Ferlan 21 Oct '16

21 Oct '16

v9: http://www.redhat.com/archives/libvir-list/2016-October/msg00726.html "Theorically speaking" patch #2 is "separate" from patches 1, 3, & 4. That is patch 3 and 4 are adding the secret uuid processing handling which is different than the enable/disable property logic for patch 2. I've left them all together though since just to be consistent with previous series. Differences in v10 ... Pushed the previous series 2/5 and 3/5 since they were ACK'd ... Create a new patch 1 to have helper qemuDomainSupportTLSChardevTCP It's mostly unnecessary without patch 2 though, but it made adding or "separating" patch 2 from patches 3 & 4 a whole lot easier... ... Modified former patch 1 (now patch 2) to accommodate for a paradigm where tls='yes' and chardev_tls=0 might be possible. The new helper is used to whether to add the TLS information or not. ... Modified former patch 4 (now patch 3) to accommodate for the changes Pavel has made to the code and to generate the secalias using the "charAlias" ... Modified former patch 4 (now patch 4) to use the "charAlias" as well and merge in Pavel's changes NOTE: Even though 'yes' is a now possibility, it is an option that's assuming chardev_tls=0 so I don't feel the issues raised during review of v8 regarding needing to consider a currently running 2.3.0 domain that still needs to work when 2.4.0 is applied. I believe it will be with the way the optional property is being used, thus with respect to the points in: http://www.redhat.com/archives/libvir-list/2016-October/msg00732.html The proposed qemuProcessPrepareDomain change is invalid since haveTLS is a tristate and chardevTLS is a bistate. This is what I meant about being a bit dangerous (e.g. BOOL_NO=2, BOOL_YES=1, and BOOL_ABSENT=0); however, "chardevTLS=1" is enabled (yes) and "chardevTLS=0" is disabled (absent). While it looks good when typing, when you get down to the details sometimes you find those 'gotchas'. Even if the shorthand logic were fixed, it's not going to be good to assume that setting the domain property or disabling the domain property is the desired action. The qemuProcessAttach is for qemu-attach and not the path that libvirt uses to reconnect to running domains (which is qemuProcessReconnect). There's so much broken from the qemu-attach right now - I doubt it really works at all. With respect to the reconnect processing (since that's really what you were thinking about)... There is no "options" provided/found in that code. New code could possibly "read" the '/proc/$pid/cmdline' file and look for 'tls-creds', but the only purpose of that would be to manage 'assumptions' with how the "tls='{yes|no}'" property is used. Altering virDomainChrSourceDefParseXML and virDomainChrSourceDefFormat to manage some new boolean 'tlsFromConfig' that I'm not sure could be set properly is something I think is outside these patches. John Ferlan (4): qemu: Introduce qemuDomainSupportTLSChardevTCP domain: Add optional 'tls' attribute for TCP chardev qemu: Add a secret object to/for a chardev tcp with secret qemu: Add secret object hotplug for TCP chardev TLS docs/formatdomain.html.in | 28 +++++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 22 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 33 ++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 133 ++++++++++++++++++++- src/qemu/qemu_domain.h | 18 ++- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 58 ++++++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_process.c | 4 +- tests/qemuhotplugtest.c | 2 +- ...uxml2argv-serial-tcp-tlsx509-chardev-notls.args | 30 +++++ ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 50 ++++++++ ...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++++ ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 ++++++++ tests/qemuxml2argvtest.c | 20 ++++ ...xml2xmlout-serial-tcp-tlsx509-chardev-notls.xml | 1 + tests/qemuxml2xmltest.c | 1 + 20 files changed, 483 insertions(+), 17 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev-notls.xml -- 2.7.4

2 15

[libvirt] [PATCH] vz: set localhost as vnc address
by Mikhail Feoktistov 21 Oct '16

21 Oct '16

We should set localhost as vnc address in case of empty string. Because Virtuozzo sets 0.0.0.0 as default vnc address. --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f2a5c96..7235172 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2967,7 +2967,7 @@ static int prlsdkApplyGraphicsParams(PRL_HANDLE sdkdom, glisten = virDomainGraphicsGetListen(gr, 0); pret = PrlVmCfg_SetVNCHostName(sdkdom, glisten && glisten->address ? - glisten->address : ""); + glisten->address : "127.0.0.1"); prlsdkCheckRetGoto(pret, cleanup); ret = 0; -- 1.8.3.1

3 2

[libvirt] [PATCH v4 0/3] Forbid new-line char in name of networks
by Sławek Kapłoński 20 Oct '16

20 Oct '16

v3: http://www.redhat.com/archives/libvir-list/2016-October/msg00627.html Differences in v4: * function to check string moved from src/util/virstring to src/util/virxml Sławek Kapłoński (3): util: Add function to check if string contains some illegal chars Use new util function to check network name Forbid new-line char in name of new networks src/conf/network_conf.c | 5 +---- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 3 +++ src/util/virxml.c | 28 ++++++++++++++++++++++++++++ src/util/virxml.h | 3 +++ 5 files changed, 36 insertions(+), 4 deletions(-) -- 2.10.0

2 8

[libvirt] [PATCH 0/2] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 20 Oct '16

20 Oct '16

The first patch is a preparation moving qemuSafeSerialParamValue to util, the second implements disk serial number setting in vz driver. Maxim Nestratov (2): util: qemu: make qemuSafeSerialParamValue function usable by other drivers vz: support setting disk serial number src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 19 +++++++++++++++++++ src/vz/vz_utils.c | 5 ----- 6 files changed, 39 insertions(+), 23 deletions(-) -- 2.4.11

2 4

[libvirt] [PATCH jenkins-ci] Remove builders for Fedora 21/22 and add 24
by Daniel P. Berrange 20 Oct '16

20 Oct '16

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a CI build fix due to RPM spec dropping 21/22 projects/libosinfo.yaml | 3 +-- projects/libvirt-cim.yaml | 3 +-- projects/libvirt-glib.yaml | 3 +-- projects/libvirt-perl.yaml | 3 +-- projects/libvirt-python.yaml | 3 +-- projects/libvirt-sandbox.yaml | 3 +-- projects/libvirt-tck.yaml | 3 +-- projects/libvirt.yaml | 9 +++------ projects/osinfo-db-tools.yaml | 3 +-- projects/osinfo-db.yaml | 3 +-- projects/virt-manager.yaml | 3 +-- projects/virt-viewer.yaml | 3 +-- 12 files changed, 14 insertions(+), 28 deletions(-) diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml index e48b6fb..49639f3 100644 --- a/projects/libosinfo.yaml +++ b/projects/libosinfo.yaml @@ -3,9 +3,8 @@ name: libosinfo machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: libosinfo make_env: | diff --git a/projects/libvirt-cim.yaml b/projects/libvirt-cim.yaml index 58cfb1a..d1705af 100644 --- a/projects/libvirt-cim.yaml +++ b/projects/libvirt-cim.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: libvirt CIM jobs: diff --git a/projects/libvirt-glib.yaml b/projects/libvirt-glib.yaml index 11c0ec9..38bcded 100644 --- a/projects/libvirt-glib.yaml +++ b/projects/libvirt-glib.yaml @@ -3,9 +3,8 @@ name: libvirt-glib machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt GLib jobs: diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml index d117d0f..2bad51d 100644 --- a/projects/libvirt-perl.yaml +++ b/projects/libvirt-perl.yaml @@ -3,9 +3,8 @@ name: libvirt-perl machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Perl jobs: diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index b4c9496..baca308 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Python jobs: diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml index 0dda524..eee249c 100644 --- a/projects/libvirt-sandbox.yaml +++ b/projects/libvirt-sandbox.yaml @@ -2,9 +2,8 @@ - project: name: libvirt-sandbox machines: - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Sandbox jobs: diff --git a/projects/libvirt-tck.yaml b/projects/libvirt-tck.yaml index 3a2e555..571f3ce 100644 --- a/projects/libvirt-tck.yaml +++ b/projects/libvirt-tck.yaml @@ -2,9 +2,8 @@ - project: name: libvirt-tck machines: - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt TCK jobs: diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml index 22a46ac..20de27c 100644 --- a/projects/libvirt.yaml +++ b/projects/libvirt.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt archive_format: xz @@ -17,9 +16,8 @@ - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide - libvirt-freebsd - autotools-syntax-check-job: @@ -28,9 +26,8 @@ - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide check_env: | export VIR_TEST_EXPENSIVE=1 diff --git a/projects/osinfo-db-tools.yaml b/projects/osinfo-db-tools.yaml index 9414ed8..bcb63da 100644 --- a/projects/osinfo-db-tools.yaml +++ b/projects/osinfo-db-tools.yaml @@ -3,9 +3,8 @@ name: osinfo-db-tools machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: osinfo database tools jobs: diff --git a/projects/osinfo-db.yaml b/projects/osinfo-db.yaml index 941326b..f48aa3f 100644 --- a/projects/osinfo-db.yaml +++ b/projects/osinfo-db.yaml @@ -3,9 +3,8 @@ name: osinfo-db machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: osinfo database jobs: diff --git a/projects/virt-manager.yaml b/projects/virt-manager.yaml index a66a016..737e37d 100644 --- a/projects/virt-manager.yaml +++ b/projects/virt-manager.yaml @@ -3,9 +3,8 @@ name: virt-manager machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Virtual Machine Manager jobs: diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml index e4ede56..d7b7108 100644 --- a/projects/virt-viewer.yaml +++ b/projects/virt-viewer.yaml @@ -3,9 +3,8 @@ name: virt-viewer machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Virt Viewer jobs: -- 2.7.4

1 0

[libvirt] [PATCH] xl: don't output (null) target in domxml-to-native
by Cédric Bosdonnat 20 Oct '16

20 Oct '16

When converting a domain xml containing a CDROM device without any attached source, don't add a target=(null) to the libxl config disk definition: xen doesn't like it at all and would fail to start the domain. --- src/xenconfig/xen_xl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index a06983e..db8cbf1 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1068,7 +1068,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) /* devtype */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) - virBufferAddLit(&buf, "devtype=cdrom,"); + virBufferAddLit(&buf, "devtype=cdrom"); /* * target @@ -1081,7 +1081,9 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) if (xenFormatXLDiskSrc(disk->src, &target) < 0) goto cleanup; - virBufferAsprintf(&buf, "target=%s", target); + if (target) { + virBufferAsprintf(&buf, ",target=%s", target); + } if (virBufferCheckError(&buf) < 0) goto cleanup; -- 2.10.1

4 4

[libvirt] [PATCH] support auth for qemu SCSI hotplug
by Gema Gomez 20 Oct '16

20 Oct '16

Hi all, commit fceeeda2 added support for adding key objects on hotplug based on a disk's secinfo for normal drives, but missed out SCSI drives. This patch adds the same support for SCSI drives, so that it's possible to hotplug SCSI drives requiring authentication (e.g. rbd-backed drives). Cheers, Gema Gema Gomez (1): qemu: hotplug: support auth for scsi hotplug src/qemu/qemu_hotplug.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) -- 2.10.0

2 4

[libvirt] [PATCH] cpu_conf: add comments about sockets in cpu_conf
by Chen Hanxiao 20 Oct '16

20 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> 'sockets' in output of `virsh capabilities' means the sockets per NUMA node, which is a special case. discuss in: https://www.redhat.com/archives/libvir-list/2012-March/msg01123.html Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/conf/cpu_conf.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h index e084392..95d6b3e 100644 --- a/src/conf/cpu_conf.h +++ b/src/conf/cpu_conf.h @@ -95,15 +95,15 @@ struct _virCPUFeatureDef { typedef struct _virCPUDef virCPUDef; typedef virCPUDef *virCPUDefPtr; struct _virCPUDef { - int type; /* enum virCPUType */ - int mode; /* enum virCPUMode */ - int match; /* enum virCPUMatch */ + int type; /* enum virCPUType */ + int mode; /* enum virCPUMode */ + int match; /* enum virCPUMatch */ virArch arch; char *model; - char *vendor_id; /* vendor id returned by CPUID in the guest */ - int fallback; /* enum virCPUFallback */ + char *vendor_id; /* vendor id returned by CPUID in the guest */ + int fallback; /* enum virCPUFallback */ char *vendor; - unsigned int sockets; + unsigned int sockets; /* sockets per NUMA node */ unsigned int cores; unsigned int threads; size_t nfeatures; -- 1.8.3.1

2 2

[libvirt] [PATCH 0/3] Make UEFI firmware config simpler
by Daniel P. Berrange 19 Oct '16

19 Oct '16

This series lets apps enabled UEFI for a guest by simply doing <loader firmware='uefi'/> with the other (existing) attributes being auto-filled with correct QEMU specific defaults. Daniel P. Berrange (3): firmware: include arch and features in firmware file list conf: add support for choosing firmware type qemu: add support for simpler UEFI config docs/formatdomain.html.in | 9 ++- docs/schemas/domaincommon.rng | 12 ++- src/conf/domain_conf.c | 70 ++++++++++++++-- src/conf/domain_conf.h | 11 +++ src/libvirt_private.syms | 1 + src/qemu/qemu.conf | 14 +++- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_conf.c | 12 ++- src/qemu/qemu_conf.h | 7 ++ src/qemu/qemu_domain.c | 60 ++++++++++++-- src/qemu/test_libvirtd_qemu.aug.in | 6 +- src/util/virfirmware.c | 94 +++++++++++++++++++--- src/util/virfirmware.h | 7 ++ .../qemuxml2argv-bios-firmware.args | 26 ++++++ .../qemuxml2argv-bios-firmware.xml | 41 ++++++++++ tests/qemuxml2argvtest.c | 1 + .../qemuxml2xmlout-bios-firmware.xml | 48 +++++++++++ tests/qemuxml2xmltest.c | 1 + tests/testutilsqemu.c | 30 ++++++- 19 files changed, 412 insertions(+), 44 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-bios-firmware.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-bios-firmware.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-firmware.xml -- 2.7.4

4 19

[libvirt] [PATCH v2] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- Changes from v1: * drop version checks that are now obsolete (thanks Dan) libvirt.spec.in | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..545990c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 @@ -167,7 +168,7 @@ %endif # Enable wireshark plugins for all distros shipping libvirt 1.2.2 or newer -%if 0%{?fedora} >= 21 +%if 0%{?fedora} %define with_wireshark 0%{!?_without_wireshark:1} %endif @@ -209,7 +210,7 @@ %if 0%{?fedora} >= 25 %define tls_priority "@LIBVIRT,SYSTEM" %else - %if 0%{?fedora} >= 21 + %if 0%{?fedora} %define tls_priority "@SYSTEM" %else %define tls_priority "NORMAL" -- 2.7.4

2 1

[libvirt] [PATCH] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- libvirt.spec.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..25dc31d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 -- 2.7.4

2 2

[libvirt] [PATCH v2 0/2] New libssh transport
by Pino Toscano 19 Oct '16

19 Oct '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (2): virNetSocket: allow to not close FD libssh_transport: add new libssh-based transport config-post.h | 2 + configure.ac | 3 + include/libvirt/virterror.h | 2 + m4/virt-libssh.m4 | 26 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 22 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 123 ++++ src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1424 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 80 +++ src/rpc/virnetsocket.c | 184 +++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 14 files changed, 1959 insertions(+), 4 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

3 10

[libvirt] [RFC] make virDomainQemuMonitorCommand work in any libvirt state
by Nikolay Shirokovskiy 19 Oct '16

19 Oct '16

Hi, all. We would like to use virDomainQemuMonitorCommand to query qemu independently of libvirt state. Currenly it is not possible. This API call takes job condition just like any other call and thus is unavailable on any lengthy(or stucked) synchronous job. I've already posted this question in list, just failed to find the reference. Somebody suggested to use proxy (and even an implementation) in between qemu and libvirt that can inject commands to qemu and filter replies. It is not really convinient. This way test setups will be different from production and we can not investigate problems in production environment. I'd like to drop acquiring job condition in the call as this function does not deal with libvirt state (except for the taint but is is ok, we will not mess things up here). But this is not enough, we need to make qemu monitor deal with many qemu commands simultaneously. Looks like it is quite a big change for test/debug case. But I guess eventually normal user cases can get benefits too from this monitor changes. For example all query API calls that query qemu directly can be changed to not to wait for some synchronous job finishing.(qemuDomainGetBlockJobInfo for example). Nikolay

4 4

[libvirt] [PATCH v3 0/2] Forbid new-line char in name of networks
by Sławek Kapłoński 19 Oct '16

19 Oct '16

v2: http://www.redhat.com/archives/libvir-list/2016-October/msg00451.html Differences in v3: * function to check string moved from src/util/virxml to src/util/virstring * validation if name of network contains \n char moved from parsing XML to functions responsible for create/define new networks Sławek Kapłoński (2): util: Add function to check if string contains some chars Forbid new-line char in name of new networks src/conf/network_conf.c | 2 +- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 6 ++++++ src/util/virstring.c | 9 +++++++++ src/util/virstring.h | 1 + 5 files changed, 18 insertions(+), 1 deletion(-) -- 2.10.0

2 8

[libvirt] How libvirt address qemu command line args
by zhunxun＠gmail.com 19 Oct '16

19 Oct '16

Now I want to add some args about TPM to domain's XML,so I can start a domain by virt-manager or other virsh command,and then ,I would like to use sVIrt security context to label vTPM and correspondingVM,But I do not know how to get these XML args in libvirt. the key problem is that how can i get and recognize these args!!! related XML content : <qemu:commandline> <qemu:arg value='-enable-kvm'/> <qemu:arg value='-drive'/> <qemu:arg value='file=/root/nvram_2.0-jin.qcow2,if=none,id=nvram0-0-0,format=qcow2'/> <qemu:arg value='-device'/> <qemu:arg value='tpm-tis,tpmdev=tpm-tpm0,id=tpm0'/> <qemu:arg value='-tpmdev'/> <qemu:arg value='libtpms,id=tpm-tpm0,nvram=nvram0-0-0,startup=clear'/> <qemu:arg value='-bios'/> <qemu:arg value='/root/xenSeabios/out/bios.bin'/> </qemu:commandline> zhunxun(a)gmail.com

3 2

[libvirt] [PATCH v2 0/3] fix hot(un)plug of chardev devices with TLS encryption
by Pavel Hrdina 19 Oct '16

19 Oct '16

Pavel Hrdina (3): qemu_alias: introduce qemuAliasChardevFromDevAlias helper qemu_command: create prefixed alias to separate variable qemu: always generate the same alias for tls-creds-x509 object src/qemu/qemu_alias.c | 16 +++++++++ src/qemu/qemu_alias.h | 3 ++ src/qemu/qemu_command.c | 41 ++++++++++++---------- src/qemu/qemu_hotplug.c | 23 +++++++----- ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 4 +-- .../qemuxml2argv-serial-tcp-tlsx509-chardev.args | 4 +-- 6 files changed, 60 insertions(+), 31 deletions(-) -- 2.10.1

2 5

[libvirt] Qemu: create empty cdrom
by Gromak Yuriy 19 Oct '16

19 Oct '16

Hello. Qemu is latest from master branch. Tryingto start a domain, which is connected toa blankcdrom: <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <target dev='sdb' bus='scsi'/> <readonly/> <address type='drive' controller='0' target='1' bus='0' unit='0'/> </disk> But I get an error: qemu-system-x86_64: -drive if=none,id=drive-scsi0-0-1-0,readonly=on,format=raw: Can't use 'raw' as a block driver for the protocol level.

3 2

[libvirt] qemu-guest-agent windows
by Umar Draz 18 Oct '16

18 Oct '16

Hello All, I have install qemu guest agent on windows 10, but unable to get the ip address using this command virsh qemu-agent-command myvm '{ "execute": "guest-network-get-interfaces" }' I am getting the following error on above command. ibvirt: QEMU Driver error : internal error: unable to execute QEMU agent command 'guest-network-get-interfaces': this feature or command is not currently supported but the same command successfully working on linux vms. Would you please help if there any other way to get the interfaces ip of windows vm Br. Umar

4 15

[libvirt] [PATCH] vsh: Using vshError rather than virReportError
by Kothapally Madhu Pavan 18 Oct '16

18 Oct '16

Correcting the error reporting method by using vshError instead of virReportError Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- tools/virsh-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 050e7fb..c9fabf2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10475,9 +10475,9 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptBool(cmd, "postcopy-after-precopy")) { if (!vshCommandOptBool(cmd, "postcopy")) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("--postcopy-after-precopy can only be used with " - "--postcopy")); + vshError(ctl, "%s", + _("argument unsupported: --postcopy-after-precopy can only " + "be used with --postcopy")); goto cleanup; } iterEvent = virConnectDomainEventRegisterAny(

3 2

[libvirt] [PATCH 0/2] fix hot(un)plug of chardev devices with TLS encryption
by Pavel Hrdina 18 Oct '16

18 Oct '16

Pavel Hrdina (2): qemu_command: create prefixed alias to separate variable qemu: always generate the same alias for tls-creds-x509 object src/qemu/qemu_command.c | 39 ++++++++++++---------- src/qemu/qemu_hotplug.c | 9 +++-- ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 4 +-- .../qemuxml2argv-serial-tcp-tlsx509-chardev.args | 4 +-- 4 files changed, 33 insertions(+), 23 deletions(-) -- 2.10.1

2 7

[libvirt] [PATCH v9 0/5] Add native TLS encrypted chardev TCP support
by John Ferlan 18 Oct '16

18 Oct '16

v8: http://www.redhat.com/archives/libvir-list/2016-October/msg00306.html Differences to v8 1. Alter patch 1 such that it's not choosing to add the tls object based on both a config and domain xml setting, rather that the decision point is to avoid adding the config setting if the domain is set to tls='no' 2. Alter patch 2 to remove the booleans - this impacts patch 4 and 5 insomuch as they need to key off whether the chardevTLSx509secretUUID is set or not. John Ferlan (5): domain: Add optional 'tls' attribute for TCP chardev conf: Introduce {default|chardev}_tls_x509_secret_uuid qemu: Introduce qemuDomainChardevPrivatePtr qemu: Add a secret object to/for a chardev tcp with secret qemu: Add the ability to hotplug a secret object for TCP chardev TLS docs/formatdomain.html.in | 21 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 51 ++++++-- src/conf/domain_conf.h | 5 +- src/libxl/libxl_domain.c | 2 +- src/lxc/lxc_native.c | 2 +- src/qemu/libvirtd_qemu.aug | 2 + src/qemu/qemu.conf | 24 ++++ src/qemu/qemu_command.c | 35 ++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_conf.c | 14 ++ src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.c | 143 ++++++++++++++++++++- src/qemu/qemu_domain.h | 30 ++++- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 64 ++++++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_parse_command.c | 4 +- src/qemu/qemu_process.c | 6 +- src/qemu/test_libvirtd_qemu.aug.in | 2 + src/vz/vz_sdk.c | 2 +- src/xenconfig/xen_sxpr.c | 2 +- src/xenconfig/xen_xl.c | 2 +- tests/qemuhotplugtest.c | 2 +- ...uxml2argv-serial-tcp-tlsx509-chardev-notls.args | 30 +++++ ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 50 +++++++ .../qemuxml2argv-serial-tcp-tlsx509-chardev.xml | 2 +- ...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++++ ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 +++++++ tests/qemuxml2argvtest.c | 21 +++ ...xml2xmlout-serial-tcp-tlsx509-chardev-notls.xml | 1 + .../qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml | 2 +- tests/qemuxml2xmltest.c | 1 + 33 files changed, 584 insertions(+), 37 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev-notls.xml -- 2.7.4

3 20

[libvirt] [PATCH] qemu_hotplug: fix crash in hot(un)plugging chardev devices
by Pavel Hrdina 18 Oct '16

18 Oct '16

We need to make sure that the chardev is serial and TCP. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_hotplug.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 14af4e1..1003d50 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1729,7 +1729,9 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver, if (qemuDomainChrPreInsert(vmdef, chr) < 0) goto cleanup; - if (cfg->chardevTLS) { + if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL && + dev->type == VIR_DOMAIN_CHR_TYPE_TCP && + cfg->chardevTLS) { if (qemuBuildTLSx509BackendProps(cfg->chardevTLSx509certdir, dev->data.tcp.listen, cfg->chardevTLSx509verify, @@ -4398,7 +4400,9 @@ int qemuDomainDetachChrDevice(virQEMUDriverPtr driver, sa_assert(tmpChr->info.alias); - if (cfg->chardevTLS && + if (tmpChr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL && + tmpChr->source.type == VIR_DOMAIN_CHR_TYPE_TCP && + cfg->chardevTLS && !(objAlias = qemuAliasTLSObjFromChardevAlias(tmpChr->info.alias))) goto cleanup; -- 2.10.1

3 3

[libvirt] [PATCH 0/3] Misc adjustments from recent code review
by John Ferlan 18 Oct '16

18 Oct '16

The following were all part of the review of the TCP chardev TLS series which were outside the realm of the specific changes for the series... http://www.redhat.com/archives/libvir-list/2016-October/msg00742.html 1. Removal of cfg from qemuProcessPrepareDomain should be separate patch 2. Setting chardevTLSx509verify should have been it's own patch... 3. !conn in qemuDomainSecretChardevPrepare not necessary - so that's true for the SecretDiskPrepare and SecretHostdevPrepare too John Ferlan (3): qemu: Remove unnecessary cfg fetch/unref qemu: Add 'verify-peer=yes' test for chardev TCP TLS qemu: Remove unnecessary NULL arg check src/qemu/qemu_domain.c | 5 +-- src/qemu/qemu_process.c | 2 -- ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 33 +++++++++++++++++ ...uxml2argv-serial-tcp-tlsx509-chardev-verify.xml | 41 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++ 5 files changed, 80 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-verify.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-verify.xml -- 2.7.4

3 5

[libvirt] [PULL 20/21] target-i386: Return runnability information on query-cpu-definitions
by Eduardo Habkost 17 Oct '16

17 Oct '16

Fill the "unavailable-features" field on the x86 implementation of query-cpu-definitions. Cc: Jiri Denemark <jdenemar(a)redhat.com> Cc: libvir-list(a)redhat.com Reviewed-by: Igor Mammedov <imammedo(a)redhat.com> Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com> --- target-i386/cpu.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 19b8cc4..754e575 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1945,6 +1945,27 @@ static inline void feat2prop(char *s) } } +/* Return the feature property name for a feature flag bit */ +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) +{ + /* XSAVE components are automatically enabled by other features, + * so return the original feature name instead + */ + if (w == FEAT_XSAVE_COMP_LO || w == FEAT_XSAVE_COMP_HI) { + int comp = (w == FEAT_XSAVE_COMP_HI) ? bitnr + 32 : bitnr; + + if (comp < ARRAY_SIZE(x86_ext_save_areas) && + x86_ext_save_areas[comp].bits) { + w = x86_ext_save_areas[comp].feature; + bitnr = ctz32(x86_ext_save_areas[comp].bits); + } + } + + assert(bitnr < 32); + assert(w < FEATURE_WORDS); + return feature_word_info[w].feat_names[bitnr]; +} + /* Compatibily hack to maintain legacy +-feat semantic, * where +-feat overwrites any feature set by * feat=on|feat even if the later is parsed after +-feat @@ -2030,6 +2051,59 @@ static void x86_cpu_parse_featurestr(const char *typename, char *features, } } +static void x86_cpu_load_features(X86CPU *cpu, Error **errp); +static int x86_cpu_filter_features(X86CPU *cpu); + +/* Check for missing features that may prevent the CPU class from + * running using the current machine and accelerator. + */ +static void x86_cpu_class_check_missing_features(X86CPUClass *xcc, + strList **missing_feats) +{ + X86CPU *xc; + FeatureWord w; + Error *err = NULL; + strList **next = missing_feats; + + if (xcc->kvm_required && !kvm_enabled()) { + strList *new = g_new0(strList, 1); + new->value = g_strdup("kvm");; + *missing_feats = new; + return; + } + + xc = X86_CPU(object_new(object_class_get_name(OBJECT_CLASS(xcc)))); + + x86_cpu_load_features(xc, &err); + if (err) { + /* Errors at x86_cpu_load_features should never happen, + * but in case it does, just report the model as not + * runnable at all using the "type" property. + */ + strList *new = g_new0(strList, 1); + new->value = g_strdup("type"); + *next = new; + next = &new->next; + } + + x86_cpu_filter_features(xc); + + for (w = 0; w < FEATURE_WORDS; w++) { + uint32_t filtered = xc->filtered_features[w]; + int i; + for (i = 0; i < 32; i++) { + if (filtered & (1UL << i)) { + strList *new = g_new0(strList, 1); + new->value = g_strdup(x86_cpu_feature_name(w, i)); + *next = new; + next = &new->next; + } + } + } + + object_unref(OBJECT(xc)); +} + /* Print all cpuid feature names in featureset */ static void listflags(FILE *f, fprintf_function print, const char **featureset) @@ -2122,6 +2196,8 @@ static void x86_cpu_definition_entry(gpointer data, gpointer user_data) info = g_malloc0(sizeof(*info)); info->name = x86_cpu_class_get_model_name(cc); + x86_cpu_class_check_missing_features(cc, &info->unavailable_features); + info->has_unavailable_features = true; entry = g_malloc0(sizeof(*entry)); entry->value = info; -- 2.7.4

1 0

[libvirt] [PULL 09/21] qmp: Add runnability information to query-cpu-definitions
by Eduardo Habkost 17 Oct '16

17 Oct '16

Add a new optional field to query-cpu-definitions schema: "unavailable-features". It will contain a list of QOM properties that prevent the CPU model from running in the current host. Cc: David Hildenbrand <dahi(a)linux.vnet.ibm.com> Cc: Michael Mueller <mimu(a)linux.vnet.ibm.com> Cc: Christian Borntraeger <borntraeger(a)de.ibm.com> Cc: Cornelia Huck <cornelia.huck(a)de.ibm.com> Cc: Jiri Denemark <jdenemar(a)redhat.com> Cc: libvir-list(a)redhat.com Reviewed-by: Eric Blake <eblake(a)redhat.com> Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com> --- qapi-schema.json | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index ded1179..5a8ec38 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3101,10 +3101,31 @@ # QEMU version, machine type, machine options and accelerator options. # A static model is always migration-safe. (since 2.8) # +# @unavailable-features: #optional List of properties that prevent +# the CPU model from running in the current +# host. (since 2.8) +# +# @unavailable-features is a list of QOM property names that +# represent CPU model attributes that prevent the CPU from running. +# If the QOM property is read-only, that means there's no known +# way to make the CPU model run in the current host. Implementations +# that choose not to provide specific information return the +# property name "type". +# If the property is read-write, it means that it MAY be possible +# to run the CPU model in the current host if that property is +# changed. Management software can use it as hints to suggest or +# choose an alternative for the user, or just to generate meaningful +# error messages explaining why the CPU model can't be used. +# If @unavailable-features is an empty list, the CPU model is +# runnable using the current host and machine-type. +# If @unavailable-features is not present, runnability +# information for the CPU is not available. +# # Since: 1.2.0 ## { 'struct': 'CpuDefinitionInfo', - 'data': { 'name': 'str', '*migration-safe': 'bool', 'static': 'bool' } } + 'data': { 'name': 'str', '*migration-safe': 'bool', 'static': 'bool', + '*unavailable-features': [ 'str' ] } } ## # @query-cpu-definitions: -- 2.7.4

1 0