- Devel - libvirt List Archives

[PATCH v2] RFC: audio: deprecate HMP audio commands
by marcandre.lureau＠redhat.com 15 Oct '25

15 Oct '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> The command is niche and better served by the host audio system. There is no QMP equivalent, fortunately. You can capture the audio stream via remote desktop protocols too (dbus, vnc, spice). Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- docs/about/deprecated.rst | 20 ++++++++++++++++++++ meson.build | 4 ++++ audio/audio-hmp-cmds.c | 7 +++++++ audio/meson.build | 5 +++-- hmp-commands-info.hx | 2 ++ hmp-commands.hx | 2 ++ 6 files changed, 38 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 98361f5832..a357f207cf 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -169,6 +169,26 @@ Use ``job-finalize`` instead. This argument has always been ignored. +Human Machine Protocol (HMP) commands +------------------------------------- + +``wavcapture`` (since 10.2) +'''''''''''''''''''''''''''' + +The ``wavcapture`` command is deprecated and will be removed in a future release. + +Use ``-audiodev wav`` or your host audio system to capture audio. + +``stopcapture`` (since 10.2) +'''''''''''''''''''''''''''' + +The ``stopcapture`` command is deprecated and will be removed in a future release. + +``info`` argument ``capture`` (since 10.2) +'''''''''''''''''''''''''''''''''''''''''' + +The ``info capture`` command is deprecated and will be removed in a future release. + Host Architectures ------------------ diff --git a/meson.build b/meson.build index afaefa0172..a4d8e33132 100644 --- a/meson.build +++ b/meson.build @@ -2354,6 +2354,10 @@ endif config_host_data = configuration_data() config_host_data.set('CONFIG_HAVE_RUST', have_rust) + +# HMP code deprecated since v10.2, to be removed +config_host_data.set('CONFIG_AUDIO_HMP', true) + audio_drivers_selected = [] if have_system audio_drivers_available = { diff --git a/audio/audio-hmp-cmds.c b/audio/audio-hmp-cmds.c index 8774c09f18..9129a02331 100644 --- a/audio/audio-hmp-cmds.c +++ b/audio/audio-hmp-cmds.c @@ -28,6 +28,7 @@ #include "monitor/monitor.h" #include "qapi/error.h" #include "qobject/qdict.h" +#include "qemu/error-report.h" static QLIST_HEAD (capture_list_head, CaptureState) capture_head; @@ -36,6 +37,8 @@ void hmp_info_capture(Monitor *mon, const QDict *qdict) int i; CaptureState *s; + warn_report_once("'info capture' is deprecated since v10.2, to be removed"); + for (s = capture_head.lh_first, i = 0; s; s = s->entries.le_next, ++i) { monitor_printf(mon, "[%d]: ", i); s->ops.info (s->opaque); @@ -48,6 +51,8 @@ void hmp_stopcapture(Monitor *mon, const QDict *qdict) int n = qdict_get_int(qdict, "n"); CaptureState *s; + warn_report_once("'stopcapture' is deprecated since v10.2, to be removed"); + for (s = capture_head.lh_first, i = 0; s; s = s->entries.le_next, ++i) { if (i == n) { s->ops.destroy (s->opaque); @@ -69,6 +74,8 @@ void hmp_wavcapture(Monitor *mon, const QDict *qdict) Error *local_err = NULL; AudioState *as = audio_state_by_name(audiodev, &local_err); + warn_report_once("'wavcapture' is deprecated since v10.2, to be removed"); + if (!as) { error_report_err(local_err); return; diff --git a/audio/meson.build b/audio/meson.build index 59f0a431d5..f0c97e5223 100644 --- a/audio/meson.build +++ b/audio/meson.build @@ -1,12 +1,13 @@ system_ss.add([spice_headers, files('audio.c')]) system_ss.add(files( - 'audio-hmp-cmds.c', 'mixeng.c', 'noaudio.c', 'wavaudio.c', - 'wavcapture.c', )) +# deprecated since v10.2, to be removed +system_ss.add(files('audio-hmp-cmds.c', 'wavcapture.c')) + system_ss.add(when: coreaudio, if_true: files('coreaudio.m')) system_ss.add(when: dsound, if_true: files('dsoundaudio.c', 'audio_win_int.c')) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 25b4aed51f..59f3446224 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -363,6 +363,7 @@ SRST Show host USB devices. ERST +#ifdef CONFIG_AUDIO_HMP { .name = "capture", .args_type = "", @@ -375,6 +376,7 @@ SRST ``info capture`` Show capture information. ERST +#endif { .name = "snapshots", diff --git a/hmp-commands.hx b/hmp-commands.hx index 15f6082596..6d59bc8f18 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -764,6 +764,7 @@ SRST ERST +#ifdef CONFIG_AUDIO_HMP { .name = "wavcapture", .args_type = "path:F,audiodev:s,freq:i?,bits:i?,nchannels:i?", @@ -798,6 +799,7 @@ SRST info capture ERST +#endif { .name = "memsave", -- 2.51.0

4 4

[PATCH] qemu: Drop reconnectBlockjobs from _qemuDomainObjPrivate struct
by Michal Privoznik 15 Oct '25

15 Oct '25

From: Michal Privoznik <mprivozn(a)redhat.com> The 'reconnectBlockjobs' member of the _qemuDomainObjPrivate struct is basically unused after v8.7.0-rc1~110. It's not even formatted into the status XML, just parsed. This makes needless noise. Just drop the member. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 7 ------- src/qemu/qemu_domain.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 60a4bcc64c..375e0e441a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1907,7 +1907,6 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivate *priv) priv->rememberOwner = false; - priv->reconnectBlockjobs = VIR_TRISTATE_BOOL_ABSENT; priv->allowReboot = VIR_TRISTATE_BOOL_ABSENT; g_clear_pointer(&priv->migrationCaps, virBitmapFree); @@ -3211,14 +3210,8 @@ qemuDomainObjPrivateXMLParseBlockjobs(virDomainObj *vm, { g_autofree xmlNodePtr *nodes = NULL; ssize_t nnodes = 0; - g_autofree char *active = NULL; - int tmp; size_t i; - if ((active = virXPathString("string(./blockjobs/@active)", ctxt)) && - (tmp = virTristateBoolTypeFromString(active)) > 0) - priv->reconnectBlockjobs = tmp; - if ((nnodes = virXPathNodeSet("./blockjobs/blockjob", ctxt, &nodes)) < 0) return -1; diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 5ccd3b2dbb..f4945f598a 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -195,9 +195,6 @@ struct _qemuDomainObjPrivate { /* If true virtlogd is used as stdio handler for character devices. */ bool chardevStdioLogd; - /* Tracks blockjob state for vm. Valid only while reconnecting to qemu. */ - virTristateBool reconnectBlockjobs; - /* Migration capabilities. Rechecked on reconnect, not to be saved in * private XML. */ virBitmap *migrationCaps; -- 2.51.0

2 1

[PATCH] RFC: audio: deprecate HMP audio commands
by marcandre.lureau＠redhat.com 15 Oct '25

15 Oct '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> The command is niche and better served by the host audio system. There is no QMP equivalent, fortunately. You can capture the audio stream via remote desktop protocols too (dbus, vnc, spice). Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- docs/about/deprecated.rst | 20 ++++++++++++++++++++ meson.build | 9 +++++++++ audio/meson.build | 7 +++++-- hmp-commands-info.hx | 2 ++ hmp-commands.hx | 4 +++- meson_options.txt | 3 +++ scripts/meson-buildoptions.sh | 3 +++ 7 files changed, 45 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 98361f5832..a357f207cf 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -169,6 +169,26 @@ Use ``job-finalize`` instead. This argument has always been ignored. +Human Machine Protocol (HMP) commands +------------------------------------- + +``wavcapture`` (since 10.2) +'''''''''''''''''''''''''''' + +The ``wavcapture`` command is deprecated and will be removed in a future release. + +Use ``-audiodev wav`` or your host audio system to capture audio. + +``stopcapture`` (since 10.2) +'''''''''''''''''''''''''''' + +The ``stopcapture`` command is deprecated and will be removed in a future release. + +``info`` argument ``capture`` (since 10.2) +'''''''''''''''''''''''''''''''''''''''''' + +The ``info capture`` command is deprecated and will be removed in a future release. + Host Architectures ------------------ diff --git a/meson.build b/meson.build index afaefa0172..0a2401e11e 100644 --- a/meson.build +++ b/meson.build @@ -2354,6 +2354,7 @@ endif config_host_data = configuration_data() config_host_data.set('CONFIG_HAVE_RUST', have_rust) +config_host_data.set('CONFIG_AUDIO_HMP', get_option('audio_hmp')) audio_drivers_selected = [] if have_system audio_drivers_available = { @@ -5105,3 +5106,11 @@ if not actually_reloc and (host_os == 'windows' or get_option('relocatable')) message('QEMU will have to be installed under ' + get_option('prefix') + '.') message('Use --disable-relocatable to remove this warning.') endif + +if get_option('audio_hmp') + message() + warning('DEPRECATED HMP audio commands') + message() + message('If you want to keep supporting this command, please') + message('contact the developers at qemu-devel(a)nongnu.org.') +endif diff --git a/audio/meson.build b/audio/meson.build index 59f0a431d5..ca2ef2a8f3 100644 --- a/audio/meson.build +++ b/audio/meson.build @@ -1,12 +1,15 @@ system_ss.add([spice_headers, files('audio.c')]) system_ss.add(files( - 'audio-hmp-cmds.c', + 'audio.c', 'mixeng.c', 'noaudio.c', 'wavaudio.c', - 'wavcapture.c', )) +if get_option('audio_hmp') + system_ss.add(files('audio-hmp-cmds.c', 'wavcapture.c')) +endif + system_ss.add(when: coreaudio, if_true: files('coreaudio.m')) system_ss.add(when: dsound, if_true: files('dsoundaudio.c', 'audio_win_int.c')) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 25b4aed51f..59f3446224 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -363,6 +363,7 @@ SRST Show host USB devices. ERST +#ifdef CONFIG_AUDIO_HMP { .name = "capture", .args_type = "", @@ -375,6 +376,7 @@ SRST ``info capture`` Show capture information. ERST +#endif { .name = "snapshots", diff --git a/hmp-commands.hx b/hmp-commands.hx index 15f6082596..414e2d2d1e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -764,6 +764,7 @@ SRST ERST +#ifdef CONFIG_AUDIO_HMP { .name = "wavcapture", .args_type = "path:F,audiodev:s,freq:i?,bits:i?,nchannels:i?", @@ -798,6 +799,7 @@ SRST info capture ERST +#endif { .name = "memsave", @@ -1090,7 +1092,7 @@ ERST SRST ``dump-guest-memory [-p]`` *filename* *begin* *length* - \ + \ ``dump-guest-memory [-z|-l|-s|-w]`` *filename* Dump guest memory to *protocol*. The file can be processed with crash or gdb. Without ``-z|-l|-s|-w``, the dump format is ELF. diff --git a/meson_options.txt b/meson_options.txt index 2836156257..d0fa75f1cf 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -39,6 +39,9 @@ option('coroutine_backend', type: 'combo', option('gdb', type: 'string', value: '', description: 'Path to GDB') +option('audio_hmp', type: 'boolean', value: true, + description: 'enable HMP commands for audio', deprecated: true) + # Everything else can be set via --enable/--disable-* option # on the configure script command line. After adding an option # here make sure to run "make update-buildoptions". diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index 3d0d132344..44ef7900f0 100644 --- a/scripts/meson-buildoptions.sh +++ b/scripts/meson-buildoptions.sh @@ -11,6 +11,7 @@ meson_options_help() { printf "%s\n" ' set block driver read-write whitelist (by default' printf "%s\n" ' affects only QEMU, not tools like qemu-img)' printf "%s\n" ' --datadir=VALUE Data file directory [share]' + printf "%s\n" ' --disable-audio-hmp enable HMP commands for audio' printf "%s\n" ' --disable-coroutine-pool coroutine freelist (better performance)' printf "%s\n" ' --disable-debug-info Enable debug symbols and other information' printf "%s\n" ' --disable-hexagon-idef-parser' @@ -244,6 +245,8 @@ _meson_option_parse() { --enable-attr) printf "%s" -Dattr=enabled ;; --disable-attr) printf "%s" -Dattr=disabled ;; --audio-drv-list=*) quote_sh "-Daudio_drv_list=$2" ;; + --enable-audio-hmp) printf "%s" -Daudio_hmp=true ;; + --disable-audio-hmp) printf "%s" -Daudio_hmp=false ;; --enable-auth-pam) printf "%s" -Dauth_pam=enabled ;; --disable-auth-pam) printf "%s" -Dauth_pam=disabled ;; --enable-gcov) printf "%s" -Db_coverage=true ;; -- 2.51.0

2 1

[PATCH v2 00/29] Introduce hyperv host-model mode
by Michal Privoznik 15 Oct '25

15 Oct '25

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/DFOD… diff to v1: - Validate dependencies across hv-* enlightenment (per QEMU docs), - Drop introduction of hv-time, since it's already present (as a timer), I've kept mode='host-model' in domain XML and <defaults/> in domcaps XML, since no one objected, yet. Michal Prívozník (29): docs: Fix QEMU version wrt hypervclock src: Drop needless typecast to virDomainTimerNameType conf: Introduce virDomainDefHasTimer() qemuxmlconfdata: Adjust hv-stimer related tests qemu_validate: Reflect dependencies of hv-synic qemu_validate: Reflect dependencies of hv-stimer qemu_validate: Reflect dependencies of hv-tlbflush qemu_validate: Reflect dependencies of hv-ipi qemu_validate: Reflect dependencies of hv-evmcs qemu_validate: Reflect dependencies of hv-tlbflush-direct NEWS: Document Hyper-V enlightenment validation virxml: Introduce virXPathTristateSwitch() virxml: Introduce virXPathTristateBool() qemu: Use virXPathTristateBool() domain_conf: Move format of hyperv features into a function domain_conf: Use virXMLFormatElement() to format hyperv features qemu_caps: Prefer VIR_DOMAIN_CAPS_ENUM_IS_SET() qemu_command: Move hyperv cmd line generation into a function qemu_command: Prefer virBufferAddLit() in qemuBuildCpuHypervCommandLine() libxl: Simplify setting HyperV features conf: More hyperv related members into a single struct docs: Drop remark on now unsupported version of QEMU conf: Report default hyperv values in domain capabilities qemu_capabilities: Format and parse new hyperv domcaps members qemu_capabilities: Fetch new hyperv domcaps qemu_caps: Introduce virQEMUCapsGetHypervCapabilities() conf: Introduce hyperv host-model mode qemu_process: Populate hyperv features for host-model NEWS: Document new host-model hyperv mode NEWS.rst | 11 + docs/formatdomain.rst | 8 +- docs/formatdomaincaps.rst | 9 +- src/conf/domain_capabilities.c | 61 ++++- src/conf/domain_capabilities.h | 11 + src/conf/domain_conf.c | 235 ++++++++++-------- src/conf/domain_conf.h | 20 +- src/conf/schemas/domaincaps.rng | 29 +++ src/conf/schemas/domaincommon.rng | 3 + src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 5 + src/libxl/libxl_conf.c | 70 +++--- src/libxl/xen_common.c | 2 +- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_capabilities.c | 107 +++++++- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 162 ++++++------ src/qemu/qemu_domain.c | 16 +- src/qemu/qemu_process.c | 80 +++++- src/qemu/qemu_validate.c | 74 +++++- src/util/virxml.c | 68 +++++ src/util/virxml.h | 10 + .../qemu_10.0.0-q35.x86_64+amdsev.xml | 7 + .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 7 + .../qemu_10.0.0-tcg.x86_64+amdsev.xml | 7 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 7 + .../qemu_10.0.0.x86_64+amdsev.xml | 7 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 7 + .../qemu_10.1.0-q35.x86_64+inteltdx.xml | 7 + .../domaincapsdata/qemu_10.1.0-q35.x86_64.xml | 7 + .../qemu_10.1.0-tcg.x86_64+inteltdx.xml | 7 + .../domaincapsdata/qemu_10.1.0-tcg.x86_64.xml | 7 + .../qemu_10.1.0.x86_64+inteltdx.xml | 7 + tests/domaincapsdata/qemu_10.1.0.x86_64.xml | 7 + .../domaincapsdata/qemu_10.2.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_10.2.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_10.2.0.x86_64.xml | 7 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 7 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 7 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 7 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 7 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 7 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 7 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 7 + .../qemu_9.2.0-q35.x86_64+amdsev.xml | 7 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 7 + .../qemu_9.2.0-tcg.x86_64+amdsev.xml | 7 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 7 + .../qemu_9.2.0.x86_64+amdsev.xml | 7 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 7 + .../caps_10.0.0_x86_64+amdsev.xml | 5 + .../caps_10.0.0_x86_64.xml | 5 + .../caps_10.1.0_x86_64+inteltdx.xml | 5 + .../caps_10.1.0_x86_64.xml | 5 + .../caps_10.2.0_x86_64.xml | 5 + .../caps_8.0.0_x86_64.xml | 5 + .../caps_8.1.0_x86_64.xml | 5 + .../caps_8.2.0_x86_64.xml | 5 + .../caps_9.0.0_x86_64.xml | 5 + .../caps_9.1.0_x86_64.xml | 5 + .../caps_9.2.0_x86_64+amdsev.xml | 5 + .../caps_9.2.0_x86_64.xml | 5 + .../hyperv-host-model.x86_64-latest.args | 32 +++ .../hyperv-host-model.x86_64-latest.xml | 33 +++ tests/qemuxmlconfdata/hyperv-host-model.xml | 27 ++ .../hyperv-passthrough.x86_64-latest.xml | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../hyperv-stimer-direct.x86_64-latest.xml | 4 +- .../qemuxmlconfdata/hyperv-stimer-direct.xml | 4 +- .../qemuxmlconfdata/hyperv.x86_64-latest.args | 2 +- .../qemuxmlconfdata/hyperv.x86_64-latest.xml | 4 +- tests/qemuxmlconfdata/hyperv.xml | 4 +- tests/qemuxmlconftest.c | 1 + 82 files changed, 1151 insertions(+), 267 deletions(-) create mode 100644 tests/qemuxmlconfdata/hyperv-host-model.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/hyperv-host-model.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/hyperv-host-model.xml -- 2.49.1

4 38

[PATCH 0/2] allow migrations with the ext transport
by Sergey Dyasli 14 Oct '25

14 Oct '25

Hello, I have a use case for live-migration where the socket of the destination libvirtd is proxied by an mTLS WebSocket proxy. Since there is no WebSocket support in Libvirt, I've decided to use the existing ext transport and point it to a proxy binary on the source host of live-migration. While doing that, I've discovered a couple of roadblocks: 1. There is no way of passing cmdline arguments to the ext program 2. Live-migrations using ext transport fail localhost checks This short series addresses those limitations. Sergey Dyasli (2): remote: allow passing cmd arguments to REMOTE_DRIVER_TRANSPORT_EXT remote: allow migrations with the ext transport src/libvirt-domain.c | 8 +++++--- src/remote/remote_driver.c | 30 ++++++++++++++++++++++++++---- src/util/viruri.c | 32 ++++++++++++++++++++++++++++++++ src/util/viruri.h | 2 ++ 4 files changed, 65 insertions(+), 7 deletions(-) -- 2.39.3

2 5

[PATCH 0/7] qemu: Node reactivation and 'manual' disk snapshot enhancements
by Peter Krempa 14 Oct '25

14 Oct '25

Peter Krempa (7): qemu: monitor: Track inactive state of block nodes in 'qemuBlockNamedNodeData' qemu: block: Introduce helper function to ensure that block nodes are active qemu: Re-activate block nodes before storage operations qemu: migration: Don't reactivate block nodes after migration failure any more qemu: snapshot: Deactivate block nodes on manually snapshotted disks qemu: snapshot: Allow snapshot consisting only of 'manual'-y handled disks docs: snapshot: Add a note that blockjobs ought to be avoided with 'manual' snapshots docs/formatsnapshot.rst | 7 ++- src/qemu/qemu_backup.c | 3 ++ src/qemu/qemu_block.c | 52 +++++++++++++++++++++ src/qemu/qemu_block.h | 4 ++ src/qemu/qemu_checkpoint.c | 12 +++++ src/qemu/qemu_driver.c | 9 ++++ src/qemu/qemu_migration.c | 53 ++------------------- src/qemu/qemu_monitor.h | 4 ++ src/qemu/qemu_monitor_json.c | 5 ++ src/qemu/qemu_snapshot.c | 91 +++++++++++++++++++++++++++++++++++- 10 files changed, 188 insertions(+), 52 deletions(-) -- 2.51.0

2 8

[RFC PATCH v4 0/5] Added virtio-net RSS with eBPF support.
by Andrew Melnychenko 14 Oct '25

14 Oct '25

This series of rfc patches adds support for loading the RSS eBPF program and passing it to the QEMU. Comments and suggestions would be useful. QEMU with vhost may work with RSS through eBPF. To load eBPF, the capabilities required that Libvirt may provide. eBPF program and maps may be unique for particular QEMU and Libvirt retrieves eBPF through qapi. For now, there is only "RSS" eBPF object in QEMU, in the future, there may be another one(g.e. network filters). That's why in Libvirt added logic to load and store any eBPF object that QEMU provides using qapi schema. One of the reasons why this series of patches is in RFC are tests. To this series of patches, the tests were added. For now, the tests are synthetic, the proper "reply" file should be generated with a new "caps" file. Currently, there are changes in caps-9.0.0* and caps-9.1.0 files. There was added support for ebpf_rss_fds feature, and request-ebpf command. So, overall, the tests are required for review, comment, and discussion how we want them to be implemented in the future. For virtio-net RSS, the document has not changed. ``` <interface type="network"> <model type="virtio"/> <driver queues="4" rss="on" rss_hash_report="off"/> <interface type="network"> ``` Simplified routine for RSS: * Libvirt retrieves eBPF "RSS" and load it. * Libvirt passes file descriptors to virtio-net with property "ebpf_rss_fds" ("rss" property should be "on" too). * if fds was provided - QEMU using eBPF RSS implementation. * if fds was not provided - QEMU tries to load eBPF RSS in own context and use it. * if eBPF RSS was not loaded - QEMU uses "in-qemu" RSS(vhost not supported). Changes since RFC v3: * changed tests a bit * refactored and rebased * removed "allowEBPF" from qemu config(now env is used for tests) Changes since RFC v2: * refactored and rebased. * applied changes according to the Qemu. * added basic test. Changes since RFC v1: * changed eBPF format saved in the XML cache. * refactored and checked with syntax test. * refactored patch hunks. Andrew Melnychenko (5): qemu_monitor: Added QEMU's "request-ebpf" support. qemu_capabilities: Added logic for retrieving eBPF objects from QEMU. qemu_interface: Added routine for loading the eBPF objects. qemu_command: Added "ebpf_rss_fds" support for virtio-net. tests: Added tests for eBPF blob loading. libvirt.spec.in | 3 + meson.build | 7 + meson_options.txt | 1 + src/qemu/meson.build | 1 + src/qemu/qemu_capabilities.c | 132 ++++++++++++ src/qemu/qemu_capabilities.h | 5 + src/qemu/qemu_command.c | 60 ++++++ src/qemu/qemu_domain.c | 4 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_interface.c | 87 ++++++++ src/qemu/qemu_interface.h | 7 + src/qemu/qemu_monitor.c | 9 + src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 27 +++ src/qemu/qemu_monitor_json.h | 4 + .../caps_9.0.0_sparc.replies | 95 +++++---- .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 3 + .../caps_9.0.0_x86_64.replies | 199 ++++++++++-------- .../caps_9.0.0_x86_64.xml | 4 + .../caps_9.1.0_x86_64.replies | 199 ++++++++++-------- .../caps_9.1.0_x86_64.xml | 4 + tests/qemuxml2argvmock.c | 24 +++ .../net-virtio-rss-bpf.x86_64-latest.args | 37 ++++ .../net-virtio-rss-bpf.x86_64-latest.xml | 46 ++++ tests/qemuxmlconfdata/net-virtio-rss-bpf.xml | 46 ++++ tests/qemuxmlconftest.c | 5 + 26 files changed, 792 insertions(+), 224 deletions(-) create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.xml -- 2.45.2

3 7

[PATCH 0/8] wireshark: Adapt to wireshark-4.6.0
by Michal Privoznik 14 Oct '25

14 Oct '25

There are only a handful of distros that offer newest wireshark (released just a couple of days ago). Well, there were some changes to the API so we have to adjust. See: https://gitlab.com/libvirt/libvirt/-/issues/82 See: https://bugs.gentoo.org/963985 Michal Prívozník (8): wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt() wireshark: Switch header files to #pragma once wireshark: Move WIRESHARK_VERSION macro definition wireshark: Fix int type of some virNetMessageHeader members wireshark: Don't special case retval of get_program_data() in dissect_libvirt_message() wireshark: Introduce and use vir_val_to_str() wireshark: Don't leak column strings wireshark: Adapt to wireshark-4.6.0 meson.build | 20 +++ tools/wireshark/src/meson.build | 1 + tools/wireshark/src/packet-libvirt.c | 207 ++++++++++++++++++++------- tools/wireshark/src/packet-libvirt.h | 14 ++ tools/wireshark/src/plugin.c | 17 --- tools/wireshark/util/genxdrstub.pl | 23 ++- 6 files changed, 199 insertions(+), 83 deletions(-) -- 2.49.1

3 19

[PATCH v3] libvirt-ci: remove obsolete RISC-V ports setup for Debian 13+
by yangzewei＠loongson.cn 13 Oct '25

13 Oct '25

From: yzewei <yangzewei(a)loongson.cn> This patch combines previous v1 and v2 patches, Please ignore previous patches v1 and v2. - Remove obsolete RISC-V ports setup for Debian 13+ Debian 13 and later officially support riscv64, so the old debian-ports archive keyring and sources.list configuration are no longer necessary. - Add validation to forbid RISC-V cross compilation on Debian < 13 Ensures that cross compiling for riscv64 on unsupported Debian releases fails early with a clear error message. Signed-off-by: yzewei <yangzewei(a)loongson.cn> --- lcitool/formatters.py | 15 --------------- lcitool/projects.py | 2 +- lcitool/util.py | 4 +++- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/lcitool/formatters.py b/lcitool/formatters.py index c26cf22a..af171fae 100644 --- a/lcitool/formatters.py +++ b/lcitool/formatters.py @@ -456,21 +456,6 @@ class BuildEnvFormatter(Formatter): "dpkg --add-architecture {cross_arch_deb}", ] ) - if target.cross_arch == "riscv64": - cross_commands.extend( - [ - "{nosync}{packaging_command} install debian-ports-archive-keyring", - "{nosync}echo 'deb http://ftp.ports.debian.org/debian-ports/ sid main' > /etc/apt/sources.list.d/ports.list", - "{nosync}echo 'deb http://ftp.ports.debian.org/debian-ports/ unreleased main' >> /etc/apt/sources.list.d/ports.list", - ] - ) - cross_commands.extend( - [ - "{nosync}{packaging_command} update", - "{nosync}{packaging_command} dist-upgrade -y", - "{nosync}{packaging_command} install --no-install-recommends -y dpkg-dev", - ] - ) if varmap["cross_pkgs"]: cross_commands.extend( [ diff --git a/lcitool/projects.py b/lcitool/projects.py index f1187cb2..0324f21a 100644 --- a/lcitool/projects.py +++ b/lcitool/projects.py @@ -270,7 +270,7 @@ class Project: target_name = f"{target_name}" else: try: - util.validate_cross_platform(target.cross_arch, osname) + util.validate_cross_platform(target.cross_arch, osname, osversion) except ValueError as ex: raise ProjectError(str(ex)) target_name = f"{target_name}-{target.cross_arch}-cross" diff --git a/lcitool/util.py b/lcitool/util.py index 3f5cb870..aedf3882 100644 --- a/lcitool/util.py +++ b/lcitool/util.py @@ -409,10 +409,12 @@ class DataDir: return result -def validate_cross_platform(cross_arch: str, osname: str) -> None: +def validate_cross_platform(cross_arch: str, osname: str, osversion: str) -> None: if osname not in ["Debian", "Fedora"]: raise ValueError(f"Cannot cross compile on {osname}") if osname == "Debian" and cross_arch.startswith("mingw"): raise ValueError(f"Cannot cross compile for {cross_arch} on {osname}") if osname == "Fedora" and not cross_arch.startswith("mingw"): raise ValueError(f"Cannot cross compile for {cross_arch} on {osname}") + if osname == "Debian" and cross_arch == "riscv64" and int(osversion.split('.')[0]) < 13: + raise ValueError(f"Cross compiling for {cross_arch} is not supported on Debian < 13") -- 2.43.0

2 1

[PATCH v2] libvirt-ci: forbid RISC-V cross compile on Debian < 13
by 杨泽伟 11 Oct '25

11 Oct '25

From 3c3ebcea07d20977f30baedcec50a859c1ac04a5 Mon Sep 17 00:00:00 2001 From: yzewei <yangzewei(a)loongson.cn> Date: Sat, 11 Oct 2025 09:39:29 +0800 Subject: [PATCH] This patch updates [PATCH v1] to add validation: RISC-V cross compilation is forbidden on Debian < 13. Signed-off-by: yzewei <yangzewei(a)loongson.cn> --- lcitool/projects.py | 2 +- lcitool/util.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lcitool/projects.py b/lcitool/projects.py index f1187cb2..0324f21a 100644 --- a/lcitool/projects.py +++ b/lcitool/projects.py @@ -270,7 +270,7 @@ class Project: target_name = f"{target_name}" else: try: - util.validate_cross_platform(target.cross_arch, osname) + util.validate_cross_platform(target.cross_arch, osname, osversion) except ValueError as ex: raise ProjectError(str(ex)) target_name = f"{target_name}-{target.cross_arch}-cross" diff --git a/lcitool/util.py b/lcitool/util.py index 3f5cb870..aedf3882 100644 --- a/lcitool/util.py +++ b/lcitool/util.py @@ -409,10 +409,12 @@ class DataDir: return result -def validate_cross_platform(cross_arch: str, osname: str) -> None: +def validate_cross_platform(cross_arch: str, osname: str, osversion: str) -> None: if osname not in ["Debian", "Fedora"]: raise ValueError(f"Cannot cross compile on {osname}") if osname == "Debian" and cross_arch.startswith("mingw"): raise ValueError(f"Cannot cross compile for {cross_arch} on {osname}") if osname == "Fedora" and not cross_arch.startswith("mingw"): raise ValueError(f"Cannot cross compile for {cross_arch} on {osname}") + if osname == "Debian" and cross_arch == "riscv64" and int(osversion.split('.')[0]) < 13: + raise ValueError(f"Cross compiling for {cross_arch} is not supported on Debian < 13") -- 2.43.0 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.

1 0