October 2026 - Devel - libvirt List Archives

Re: Property types changed in this series
by Markus Armbruster 22 Oct '26

22 Oct '26

Libvirt developers: does libvirt use member @type of the reply of qom-list, qom-list-properties, qom-list-get? I'm asking because Marc-André's work changes many values to add a more useful replacement. I think we should deprecate @type. I'd like to find out whether we need to preserve the values for the deprecation grace period. Markus Armbruster <armbru(a)redhat.com> writes: > I used qom-list-types and qom-list-properties to list all properties and > their types, then looked for changes. This can miss changes in > dynamically created properties; see the note on qom-list-properties in > qapi/qom.json. Moreover, I ran into a few QOM types where > qom-list-properties is broken. These are ast2700-a1, ast2700-a2, and several riscv CPUs. A fix for the latter has been queued. > 1. Close misses of QAPI type names change to actual QAPI type names > > old property type new property type > --------------------------------------------- > string str > uint64_t uint64 > uint64_t size > int32_t int32 > int size > uint32_t uint32 > [uint16] uint16List > NotifyVMexitOption NotifyVmexitOption > CXLFixedMemoryWindow CXLFixedMemoryWindowOptionsList > > 2. Incorrect QAPI type names change to correct ones > > old property type new property type > --------------------------------------------- > SgxEPC SgxEPCList > QAuthZListRule QAuthZListRuleList > X86CPUFeatureWordInfo X86CPUFeatureWordInfoList > bool Pca9552LedState > > 3. Less than useful QAPI type names change to more useful ones > > old property type new property type > --------------------------------------------- > str Pca9552PinState > str Pca9554PinState > > 4. Lazy crap > > old property type new property type > --------------------------------------------- > list link<arm-cpu>List > list strList > list uint16List > list uint32List > list uint64List > list uint8List > struct any > > I'm not sure the first one is what it should be. > > I need to have a closer look at the last one. > > 5. Inventive crap > > old property type new property type > --------------------------------------------- > busnr uint8 > guest statistics VirtioBalloonGuestStats > loadparm str > on|off|split OnOffSplit > struct tm StructTm > > 6. An odd duck > > old property type new property type > --------------------------------------------- > str int32 > > This is pci-device property addr. See PATCH 54. > > On the way, I noted properties with anti-social names: > > QOM type name property name > --------------------------------- > acpi-ged memhp container[0] > e500-spin e500 spin pv device[0]

2 1

[PATCH 1/1] daemon: install logrotate configurations for all daemons
by Partha Satapathy 22 Oct '26

22 Oct '26

From: Partha Sarathi Satapathy <partha.satapathy(a)oracle.com> The existing daemon logrotate configuration only covers libvirtd. File-based logs from modular daemons, such as virtqemud.log, are therefore not rotated. Parameterize libvirtd.logrotate.in with the daemon name and generate a configuration for each daemon in virt_daemons. Install each configuration in logrotate.d and package it in the same RPM subpackage as the corresponding daemon. Signed-off-by: Partha Satapathy <partha.satapathy(a)oracle.com> --- libvirt.spec.in | 14 ++++++++++++++ src/meson.build | 20 ++++++++++++++++++++ src/remote/libvirtd.logrotate.in | 2 +- src/remote/meson.build | 14 ++++---------- 4 files changed, 39 insertions(+), 11 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2411fd94c411..055f6a4b8d9c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -2152,6 +2152,7 @@ exit 0 %{_datadir}/augeas/lenses/tests/test_libvirt_lockd.aug %endif %attr(0755, root, root) %{_sbindir}/virtlockd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtlockd %{_mandir}/man8/virtlockd.8* %files daemon-plugin-lockd @@ -2165,6 +2166,7 @@ exit 0 %{_datadir}/augeas/lenses/virtlogd.aug %{_datadir}/augeas/lenses/tests/test_virtlogd.aug %attr(0755, root, root) %{_sbindir}/virtlogd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtlogd %{_mandir}/man8/virtlogd.8* %files daemon-proxy @@ -2178,6 +2180,7 @@ exit 0 %{_datadir}/augeas/lenses/virtproxyd.aug %{_datadir}/augeas/lenses/tests/test_virtproxyd.aug %attr(0755, root, root) %{_sbindir}/virtproxyd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtproxyd %{_mandir}/man8/virtproxyd.8* %files daemon-config-network @@ -2200,6 +2203,7 @@ exit 0 %{_unitdir}/virtinterfaced-ro.socket %{_unitdir}/virtinterfaced-admin.socket %attr(0755, root, root) %{_sbindir}/virtinterfaced +%config(noreplace) %{_sysconfdir}/logrotate.d/virtinterfaced %ghost %dir %attr(0700, root, root) %{_rundir}/libvirt/interface/ %{_libdir}/libvirt/connection-driver/libvirt_driver_interface.so %{_mandir}/man8/virtinterfaced.8* @@ -2216,6 +2220,7 @@ exit 0 %{_unitdir}/virtnetworkd-ro.socket %{_unitdir}/virtnetworkd-admin.socket %attr(0755, root, root) %{_sbindir}/virtnetworkd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtnetworkd %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/qemu/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/qemu/networks/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/qemu/networks/autostart @@ -2242,6 +2247,7 @@ exit 0 %{_unitdir}/virtnodedevd-ro.socket %{_unitdir}/virtnodedevd-admin.socket %attr(0755, root, root) %{_sbindir}/virtnodedevd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtnodedevd %ghost %dir %attr(0700, root, root) %{_rundir}/libvirt/nodedev/ %{_libdir}/libvirt/connection-driver/libvirt_driver_nodedev.so %{_mandir}/man8/virtnodedevd.8* @@ -2255,6 +2261,7 @@ exit 0 %{_unitdir}/virtnwfilterd-ro.socket %{_unitdir}/virtnwfilterd-admin.socket %attr(0755, root, root) %{_sbindir}/virtnwfilterd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtnwfilterd %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/nwfilter/ %ghost %dir %{_rundir}/libvirt/network/ %ghost %dir %attr(0700, root, root) %{_rundir}/libvirt/nwfilter-binding/ @@ -2277,6 +2284,7 @@ exit 0 %dir %attr(0755, root, root) %{_unitdir}/libvirtd.service.d/ %{_unitdir}/libvirtd.service.d/10-secret.conf %attr(0755, root, root) %{_sbindir}/virtsecretd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtsecretd %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/secrets/ %dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/secrets/ %ghost %dir %attr(0700, root, root) %{_rundir}/libvirt/secrets/ @@ -2294,6 +2302,7 @@ exit 0 %{_unitdir}/virtstoraged-ro.socket %{_unitdir}/virtstoraged-admin.socket %attr(0755, root, root) %{_sbindir}/virtstoraged +%config(noreplace) %{_sysconfdir}/logrotate.d/virtstoraged %attr(0755, root, root) %{_libexecdir}/libvirt_parthelper %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/storage/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/storage/autostart/ @@ -2348,6 +2357,7 @@ exit 0 %{_unitdir}/virtqemud-ro.socket %{_unitdir}/virtqemud-admin.socket %attr(0755, root, root) %{_sbindir}/virtqemud +%config(noreplace) %{_sysconfdir}/logrotate.d/virtqemud %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/qemu/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/qemu/autostart/ %dir %attr(0700, root, root) %{_localstatedir}/log/libvirt/qemu/ @@ -2389,6 +2399,7 @@ exit 0 %{_unitdir}/virtlxcd-ro.socket %{_unitdir}/virtlxcd-admin.socket %attr(0755, root, root) %{_sbindir}/virtlxcd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtlxcd %dir %attr(0700, root, root) %{_localstatedir}/log/libvirt/lxc/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/lxc/ %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/lxc/autostart/ @@ -2413,6 +2424,7 @@ exit 0 %{_unitdir}/virtxend-ro.socket %{_unitdir}/virtxend-admin.socket %attr(0755, root, root) %{_sbindir}/virtxend +%config(noreplace) %{_sysconfdir}/logrotate.d/virtxend %config(noreplace) %{_sysconfdir}/libvirt/libxl.conf %config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd.libxl %config(noreplace) %{_sysconfdir}/libvirt/libxl-lockd.conf @@ -2441,6 +2453,7 @@ exit 0 %{_unitdir}/virtvboxd-ro.socket %{_unitdir}/virtvboxd-admin.socket %attr(0755, root, root) %{_sbindir}/virtvboxd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtvboxd %{_libdir}/libvirt/connection-driver/libvirt_driver_vbox.so %{_mandir}/man8/virtvboxd.8* %endif @@ -2485,6 +2498,7 @@ exit 0 %if %{with_ch} %files daemon-driver-ch %attr(0755, root, root) %{_sbindir}/virtchd +%config(noreplace) %{_sysconfdir}/logrotate.d/virtchd %config(noreplace) %{_sysconfdir}/libvirt/virtchd.conf %{_datadir}/augeas/lenses/virtchd.aug %{_datadir}/augeas/lenses/tests/test_virtchd.aug diff --git a/src/meson.build b/src/meson.build index cab52ce7a30c..4fdc130bfa96 100644 --- a/src/meson.build +++ b/src/meson.build @@ -285,6 +285,26 @@ subdir('vbox') subdir('vmware') subdir('vz') +# Generate a logrotate configuration for every daemon built by this +# configuration. The driver-specific logrotate files for guest logs are +# installed by src/remote/meson.build. +foreach daemon : virt_daemons + daemon_logrotate_conf = configuration_data({ + 'daemon': daemon['name'], + 'localstatedir': localstatedir, + }) + daemon_logrotate = configure_file( + input: 'remote/libvirtd.logrotate.in', + output: '@0@.logrotate'.format(daemon['name']), + configuration: daemon_logrotate_conf, + ) + install_data( + daemon_logrotate, + install_dir: sysconfdir / 'logrotate.d', + rename: [ daemon['name'] ], + ) +endforeach + driver_sources = files( 'driver.c', diff --git a/src/remote/libvirtd.logrotate.in b/src/remote/libvirtd.logrotate.in index 4e02510c8bb8..f563b253d9a3 100644 --- a/src/remote/libvirtd.logrotate.in +++ b/src/remote/libvirtd.logrotate.in @@ -1,4 +1,4 @@ -@localstatedir@/log/libvirt/libvirtd.log { +@localstatedir@/log/libvirt/@daemon@.log { weekly missingok rotate 4 diff --git a/src/remote/meson.build b/src/remote/meson.build index 3525bc34b2de..01dcbe51639d 100644 --- a/src/remote/meson.build +++ b/src/remote/meson.build @@ -130,18 +130,12 @@ foreach name : libvirt_conf_files set_variable(name['virtd'].underscorify(), tmp) endforeach -logrotate_files = [ +driver_logrotate_files = [ 'libvirtd.qemu', 'libvirtd.lxc', 'libvirtd.libxl', ] -if conf.has('WITH_MONOLITHIC_LIBVIRTD') - logrotate_files += [ - 'libvirtd', - ] -endif - if conf.has('WITH_REMOTE') remote_driver_lib = static_library( 'virt_remote_driver', @@ -265,15 +259,15 @@ if conf.has('WITH_REMOTE') runstatedir / 'libvirt' / 'common', ] - logrotate_conf = configuration_data({ + driver_logrotate_conf = configuration_data({ 'localstatedir': localstatedir, }) - foreach name : logrotate_files + foreach name : driver_logrotate_files log_file = configure_file( input: '@0@.logrotate.in'.format(name), output: '@0@.logrotate'.format(name), - configuration: logrotate_conf, + configuration: driver_logrotate_conf, ) install_data( log_file, -- 2.52.0

3 4

[PATCH] NEWS: Mention emitting UNDEFINE event after successful migration
by Jim Fehlig 22 Oct '26

22 Oct '26

From: Jim Fehlig <jfehlig(a)suse.com> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 6ffc803118..a30bc9bc7b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,13 @@ v12.9.0 (unreleased) * **Improvements** + * qemu: Emit UNDEFINED event when undefining source after migration + + After successfully migrating a domain with the ``VIR_MIGRATE_UNDEFINE_SOURCE`` + flag, the QEMU driver now emits a ``VIR_DOMAIN_EVENT_UNDEFINED`` lifecycle + event on the source host. The event includes the newly added + VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED detail. + * **Bug fixes** -- 2.51.0

2 1

[PATCH v2] docs: Move RISC-V 'Z' CPU properties section to removed features
by Philippe Mathieu-Daudé 22 Oct '26

22 Oct '26

RISC-V 'Z' CPU properties were removed in commit 455c0fa9eef, for the release v10.1.0. Move the corresponding section from deprecated.rst to removed-features.rst, adjusting the wording accordingly. Fixes: 455c0fa9eef ("target/riscv: remove capital 'Z' CPU properties") Reviewed-by: Daniel Henrique Barboza <daniel.barboza(a)oss.qualcomm.com> Reviewed-by: Alistair Francis <alistair.francis(a)wdc.com> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)oss.qualcomm.com> --- docs/about/deprecated.rst | 24 ------------------------ docs/about/removed-features.rst | 7 +++++++ 2 files changed, 7 insertions(+), 24 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ccbc4219497..368fa1b4ed3 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -349,30 +349,6 @@ the addition of volatile memory support, it is now necessary to distinguish between persistent and volatile memory backends. As such, memdev is deprecated in favor of persistent-memdev. - -RISC-V CPU properties which start with capital 'Z' (since 8.2) -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - -All RISC-V CPU properties which start with capital 'Z' are being deprecated -starting in 8.2. The reason is that they were wrongly added with capital 'Z' -in the past. CPU properties were later added with lower-case names, which -is the format we want to use from now on. - -Users which try to use these deprecated properties will receive a warning -recommending to switch to their stable counterparts: - -- "Zifencei" should be replaced with "zifencei" -- "Zicsr" should be replaced with "zicsr" -- "Zihintntl" should be replaced with "zihintntl" -- "Zihintpause" should be replaced with "zihintpause" -- "Zawrs" should be replaced with "zawrs" -- "Zfa" should be replaced with "zfa" -- "Zfh" should be replaced with "zfh" -- "Zfhmin" should be replaced with "zfhmin" -- "Zve32f" should be replaced with "zve32f" -- "Zve64f" should be replaced with "zve64f" -- "Zve64d" should be replaced with "zve64d" - Block device options '''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 6a9944a0c79..225841bd9bb 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1038,6 +1038,13 @@ initial RISC-V QEMU port. Its usage was always been unclear: users don't know what to expect from a CPU called 'any', and in fact the CPU does not do anything special that isn't already done by the default CPUs rv32/rv64. +RISC-V CPU properties which start with capital 'Z' (removed in 10.1) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +All RISC-V CPU properties which start with capital 'Z' have been removed. +They were wrongly added with capital 'Z' in the past. CPU properties +with lower-case names are used instead. + Power8E and Power8NVL CPUs (removed in 11.1) '''''''''''''''''''''''''''''''''''''''''''' -- 2.55.0

3 2

[PATCH v1 1/1] qemu: add support for zero-page-detection migration parameter
by Tejus GK 21 Oct '26

21 Oct '26

QEMU supports a migration parameter to determine whether zero-page checking should be performed and if yes, where it should be performed (i.e., in the main migration thread or multifd threads). Add support for this parameter in libvirt. Signed-off-by: Tejus GK <tejus.gk(a)nutanix.com> --- include/libvirt/libvirt-domain.h | 11 +++++++++++ src/qemu/qemu_migration.c | 1 + src/qemu/qemu_migration_params.c | 8 ++++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 13 +++++++++++++ 5 files changed, 34 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 99208137c3..5a4875770b 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1468,6 +1468,17 @@ typedef enum { */ # define VIR_MIGRATE_PARAM_TLS_DESTINATION "tls.destination" +/** + * VIR_MIGRATE_PARAM_ZERO_PAGE_DETECTION: + * + * virDomainMigrate* params field: zero page detection method as + * VIR_TYPED_PARAM_STRING. Supported values are 'none', 'legacy', and + * 'multifd'. + * + * Since: 12.8.0 + */ +# define VIR_MIGRATE_PARAM_ZERO_PAGE_DETECTION "zero_page_detection" + /* Domain migration. */ virDomainPtr virDomainMigrate (virDomainPtr domain, virConnectPtr dconn, unsigned long flags, const char *dname, diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 4a43ab83b0..f25506e590 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -110,6 +110,7 @@ const virTypedParamValidationTemplate qemuMigrationParametersValidation[] = { { VIR_MIGRATE_PARAM_TLS_DESTINATION, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_DISKS_URI, VIR_TYPED_PARAM_STRING }, { VIR_MIGRATE_PARAM_BANDWIDTH_AVAIL_SWITCHOVER, VIR_TYPED_PARAM_ULLONG }, + { VIR_MIGRATE_PARAM_ZERO_PAGE_DETECTION, VIR_TYPED_PARAM_STRING}, { "", 0 } }; diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dd47516742..7064140379 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -131,6 +131,7 @@ VIR_ENUM_IMPL(qemuMigrationParam, "multifd-zstd-level", "avail-switchover-bandwidth", "direct-io", + "zero-page-detection", ); typedef struct _qemuMigrationParamsAlwaysOnItem qemuMigrationParamsAlwaysOnItem; @@ -274,6 +275,10 @@ static const qemuMigrationParamsTPMapItem qemuMigrationParamsTPMap[] = { .unit = 1024 * 1024, /* MiB/s */ .param = QEMU_MIGRATION_PARAM_AVAIL_SWITCHOVER_BANDWIDTH, .party = QEMU_MIGRATION_SOURCE}, + + {.typedParam = VIR_MIGRATE_PARAM_ZERO_PAGE_DETECTION, + .param = QEMU_MIGRATION_PARAM_ZERO_PAGE_DETECTION, + .party = QEMU_MIGRATION_SOURCE}, }; static const qemuMigrationParamInfoItem qemuMigrationParamInfo[] = { @@ -332,6 +337,9 @@ static const qemuMigrationParamInfoItem qemuMigrationParamInfo[] = { [QEMU_MIGRATION_PARAM_DIRECT_IO] = { .type = QEMU_MIGRATION_PARAM_TYPE_BOOL, }, + [QEMU_MIGRATION_PARAM_ZERO_PAGE_DETECTION] = { + .type = QEMU_MIGRATION_PARAM_TYPE_STRING, + }, }; G_STATIC_ASSERT(G_N_ELEMENTS(qemuMigrationParamInfo) == QEMU_MIGRATION_PARAM_LAST); diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h index b7a829b85a..131fe82fc0 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -67,6 +67,7 @@ typedef enum { QEMU_MIGRATION_PARAM_MULTIFD_ZSTD_LEVEL, QEMU_MIGRATION_PARAM_AVAIL_SWITCHOVER_BANDWIDTH, QEMU_MIGRATION_PARAM_DIRECT_IO, + QEMU_MIGRATION_PARAM_ZERO_PAGE_DETECTION, QEMU_MIGRATION_PARAM_LAST } qemuMigrationParam; diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2c64f19a19..519d8427bd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11432,6 +11432,10 @@ static const vshCmdOptDef opts_migrate[] = { .type = VSH_OT_INT, .help = N_("bandwidth (in MiB/s) available for the final phase of migration") }, + {.name = "zero-page-detection", + .type = VSH_OT_STRING, + .help = N_("zero page detection method for migration") + }, {.name = NULL} }; @@ -11733,6 +11737,15 @@ doMigrate(void *opaque) goto save_error; } + if ((rv = vshCommandOptString(ctl, cmd, "zero-page-detection", &opt)) < 0) { + goto out; + } else if (rv > 0) { + if (virTypedParamsAddString(&params, &nparams, &maxparams, + VIR_MIGRATE_PARAM_ZERO_PAGE_DETECTION, + opt) < 0) + goto save_error; + } + if ((rv = vshCommandOptInt(ctl, cmd, "comp-zlib-level", &intOpt)) < 0) { goto out; } else if (rv > 0) { -- 2.43.7

2 3

[PATCH] system: Remove deprecated '-name foo,debug-threads=...' option
by Philippe Mathieu-Daudé 20 Oct '26

20 Oct '26

'debug-threads' option for -name was deprecated in v11.0 (commit 1b65aeed2a0 "system: unconditionally enable thread naming") thus can now be removed. Signed-off-by: Philippe Mathieu-Daudé <philmd(a)oss.qualcomm.com> --- docs/about/deprecated.rst | 7 ------- docs/about/removed-features.rst | 9 +++++++-- system/vl.c | 11 ----------- tests/qtest/migration/framework.c | 4 ++-- tests/qtest/migration/precopy-tests.c | 2 +- qemu-options.hx | 7 +++---- 6 files changed, 13 insertions(+), 27 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ccbc4219497..08d86bec314 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -54,13 +54,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. -``debug-threads`` option for ``-name`` (since 11.0) -''''''''''''''''''''''''''''''''''''''''''''''''''' - -The ``debug-threads`` option of the ``-name`` argument is now -ignored. Thread naming is unconditionally enabled for all platforms -where it is supported. - ``-mon`` option (since 11.1) '''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 6a9944a0c79..cd4f3338bcc 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -578,6 +578,11 @@ kernel since 2001. None of the board types QEMU supports need Keeping 32-bit host support alive was a substantial burden for the QEMU project. Thus QEMU dropped all support for all 32-bit host systems. +``debug-threads`` option for ``-name`` (removed in 11.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Thread naming is unconditionally enabled for all platforms where it +is supported. User-mode emulator command line arguments ----------------------------------------- @@ -779,8 +784,8 @@ values could be assigned to integer device properties or vice versa. Removed with no replacement, as it reported only a limited set of threads (for example, it only reported source side of multifd threads, without reporting any destination threads, or non-multifd source -threads). For debugging purpose, please use ``-name -$VM,debug-threads=on`` instead. +threads). For debugging purpose, thread names are unconditionally +enabled where supported. ``migrate`` argument ``detach`` (removed in 11.0) '''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/system/vl.c b/system/vl.c index 468a9fc247a..e766402f7e1 100644 --- a/system/vl.c +++ b/system/vl.c @@ -403,11 +403,6 @@ static QemuOptsList qemu_name_opts = { .name = "process", .type = QEMU_OPT_STRING, .help = "Sets the name of the QEMU process, as shown in top etc", - }, { - .name = "debug-threads", - .type = QEMU_OPT_BOOL, - .help = "Enable thread names" - "(deprecated, always enabled where supported)", }, { /* End of list */ } }, @@ -556,12 +551,6 @@ static int parse_name(void *opaque, QemuOpts *opts, Error **errp) { const char *proc_name; - if (qemu_opt_get(opts, "debug-threads") && - !qemu_opt_get_bool(opts, "debug-threads", false)) { - fprintf(stderr, "Ignoring deprecated 'debug-threads=no' option, " \ - "thread naming is unconditionally enabled\n"); - } - qemu_name = qemu_opt_get(opts, "guest"); proc_name = qemu_opt_get(opts, "process"); diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c index b7aef6b21cb..fbe1e1f247d 100644 --- a/tests/qtest/migration/framework.c +++ b/tests/qtest/migration/framework.c @@ -413,7 +413,7 @@ int migrate_args(char **from, char **to, MigrateStart *args) cmd_source = g_strdup_printf("-accel kvm%s -accel tcg " "-machine %s,%s " - "-name source,debug-threads=on " + "-name source " "%s " "-serial file:%s/src_serial " "%s %s %s", @@ -433,7 +433,7 @@ int migrate_args(char **from, char **to, MigrateStart *args) cmd_target = g_strdup_printf("-accel kvm%s -accel tcg " "-machine %s,%s " - "-name target,debug-threads=on " + "-name target " "%s " "-serial file:%s/dest_serial " "-incoming defer " diff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/precopy-tests.c index d57ffcac234..3298bf026a1 100644 --- a/tests/qtest/migration/precopy-tests.c +++ b/tests/qtest/migration/precopy-tests.c @@ -807,7 +807,7 @@ static QTestState *dirtylimit_start_vm(void) bootpath = bootfile_create(qtest_get_arch(), tmpfs, false); cmd = g_strdup_printf("-accel kvm,dirty-ring-size=4096 " - "-name dirtylimit-test,debug-threads=on " + "-name dirtylimit-test " "-m 150M -smp 1 " "-serial file:%s/vm_serial " "-drive file=%s,format=raw ", diff --git a/qemu-options.hx b/qemu-options.hx index 2f6863180b0..7f75fe54a12 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1376,18 +1376,17 @@ SRST ERST DEF("name", HAS_ARG, QEMU_OPTION_name, - "-name string1[,process=string2][,debug-threads=on|off]\n" + "-name string1[,process=string2]\n" " set the name of the guest\n" " string1 sets the window title and string2 the process name\n" - " When debug-threads is enabled, individual threads are given a separate name\n" " NOTE: The thread names are for debugging and not a stable API.\n", QEMU_ARCH_ALL) SRST ``-name name`` Sets the name of the guest. This name will be displayed in the SDL window caption. The name will also be used for the VNC server. Also - optionally set the top visible process name in Linux. Naming of - individual threads can also be enabled on Linux to aid debugging. + where supported, set the top visible process name (individual threads + are always given a separate name to aid debugging). ERST DEF("uuid", HAS_ARG, QEMU_OPTION_uuid, -- 2.55.0

4 3

[libvirt PATCH] qemu: re-introduce debug-threads capability
by Ján Tomko 20 Oct '26

20 Oct '26

From: Ján Tomko <jtomko(a)redhat.com> The option is being removed from QEMU. Since QEMU 11.2 it has been a no-op and always enabled. Stop assuming it's always present so that running VMs won't break with the new QEMU versions. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 8 +++++--- tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml | 1 + .../qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml | 1 + tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_x86_64+sgx.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_11.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml | 1 + tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 1 + 41 files changed, 46 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index bc2b0412dc..9bbb0f6591 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -374,7 +374,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "chardev-logfile", /* X_QEMU_CAPS_CHARDEV_LOGFILE */ /* 215 */ - "debug-threads", /* X_QEMU_CAPS_NAME_DEBUG_THREADS */ + "debug-threads", /* QEMU_CAPS_NAME_DEBUG_THREADS */ "secret", /* X_QEMU_CAPS_OBJECT_SECRET */ "pxb", /* QEMU_CAPS_DEVICE_PXB */ "pxb-pcie", /* QEMU_CAPS_DEVICE_PXB_PCIE */ @@ -3628,6 +3628,7 @@ struct virQEMUCapsCommandLineProps { * in qemu and thus isn't being properly extended. Other means to detect * features should be used if possible. */ static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = { + { "name", "debug-threads", QEMU_CAPS_NAME_DEBUG_THREADS }, { "fsdev", "multidevs", QEMU_CAPS_FSDEV_MULTIDEVS }, { "machine", "hpet", QEMU_CAPS_MACHINE_HPET }, { "sandbox", NULL, QEMU_CAPS_SECCOMP_SANDBOX }, diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 28303fd8f0..95a3cc2f8d 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -348,7 +348,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */ X_QEMU_CAPS_CHARDEV_LOGFILE, /* -chardev logfile=xxxx */ /* 215 */ - X_QEMU_CAPS_NAME_DEBUG_THREADS, /* Is -name debug-threads= available */ + QEMU_CAPS_NAME_DEBUG_THREADS, /* Is -name debug-threads= available */ X_QEMU_CAPS_OBJECT_SECRET, /* -object secret */ QEMU_CAPS_DEVICE_PXB, /* -device pxb */ QEMU_CAPS_DEVICE_PXB_PCIE, /* -device pxb-pcie */ diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bcddb9c922..9adb18be4f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6969,7 +6969,8 @@ qemuAppendLoadparmMachineParm(virBuffer *buf, static int qemuBuildNameCommandLine(virCommand *cmd, virQEMUDriverConfig *cfg, - const virDomainDef *def) + const virDomainDef *def, + virQEMUCaps *qemuCaps) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; @@ -6982,7 +6983,8 @@ qemuBuildNameCommandLine(virCommand *cmd, if (cfg->setProcessName) virBufferAsprintf(&buf, ",process=qemu:%s", def->name); - virBufferAddLit(&buf, ",debug-threads=on"); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_NAME_DEBUG_THREADS)) + virBufferAddLit(&buf, ",debug-threads=on"); virCommandAddArgBuffer(cmd, &buf); @@ -10878,7 +10880,7 @@ qemuBuildCommandLine(virDomainObj *vm, virCommandAddEnvXDG(cmd, priv->libDir); } - if (qemuBuildNameCommandLine(cmd, cfg, def) < 0) + if (qemuBuildNameCommandLine(cmd, cfg, def, qemuCaps) < 0) return NULL; qemuBuildCompatDeprecatedCommandLine(cmd, cfg, def); diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml index 48629e494d..c3994e2129 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml @@ -54,6 +54,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml b/tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml index 70bf98c404..e332a96899 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml @@ -58,6 +58,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='virtio-vga'/> <flag name='ivshmem-plain'/> <flag name='ivshmem-doorbell'/> diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml b/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml index 25d73b6e1d..f483b7ac6a 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml @@ -33,6 +33,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml b/tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml index 53fd51122c..e417ec6c3f 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml index ad3fe67638..46f8c9ada9 100644 --- a/tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml b/tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml index 0d46b3b20e..cbebc0b9b4 100644 --- a/tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml @@ -34,6 +34,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml b/tests/qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml index 242215f7a8..2e6f605fd0 100644 --- a/tests/qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml +++ b/tests/qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml @@ -58,6 +58,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml index a2faddcced..254d5dad06 100644 --- a/tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml index 3bbba5ddb1..dc638b2bdf 100644 --- a/tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml @@ -61,6 +61,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml b/tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml index 530c0366ea..bc7b2c6907 100644 --- a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml +++ b/tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml @@ -60,6 +60,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml index b2cd261b99..f52aa62045 100644 --- a/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml index d77884f401..350427c1ab 100644 --- a/tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml @@ -61,6 +61,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_11.0.0_s390x.xml b/tests/qemucapabilitiesdata/caps_11.0.0_s390x.xml index 07ee859318..0e1de31062 100644 --- a/tests/qemucapabilitiesdata/caps_11.0.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_11.0.0_s390x.xml @@ -34,6 +34,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_11.0.0_x86_64+sgx.xml b/tests/qemucapabilitiesdata/caps_11.0.0_x86_64+sgx.xml index 108f4b0b86..109219d018 100644 --- a/tests/qemucapabilitiesdata/caps_11.0.0_x86_64+sgx.xml +++ b/tests/qemucapabilitiesdata/caps_11.0.0_x86_64+sgx.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml index 29fdaf20d8..e4a45e244c 100644 --- a/tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml index 31d4d2fd26..3634a37a8e 100644 --- a/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml @@ -61,6 +61,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_11.1.0_s390x.xml b/tests/qemucapabilitiesdata/caps_11.1.0_s390x.xml index aae4dd0b80..d440b07b4f 100644 --- a/tests/qemucapabilitiesdata/caps_11.1.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_11.1.0_s390x.xml @@ -34,6 +34,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml index 05e6749a17..ff7402ba11 100644 --- a/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml b/tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml index bf67b3d295..d0c53f804c 100644 --- a/tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml +++ b/tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml @@ -59,6 +59,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='ivshmem-plain'/> <flag name='ivshmem-doorbell'/> <flag name='vhost-scsi'/> diff --git a/tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml b/tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml index f40d77baa5..629fb1b86b 100644 --- a/tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml +++ b/tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml index 8d44ed71e0..bfa7125d99 100644 --- a/tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml @@ -70,6 +70,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml index fcbb68e415..0eb099635a 100644 --- a/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml @@ -70,6 +70,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml b/tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml index 65f73d1af8..3a43691165 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml @@ -30,6 +30,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml index c730dd7174..73b8f253f3 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml @@ -70,6 +70,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml index 1f0f68092d..a46ecaf067 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml @@ -57,6 +57,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml b/tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml index 254ec27545..f65ca505d0 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml @@ -60,6 +60,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='ivshmem-plain'/> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml index 95eb2dfa21..778193d6b2 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml @@ -57,6 +57,7 @@ <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='virtio-vga'/> <flag name='ivshmem-plain'/> <flag name='ivshmem-doorbell'/> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml b/tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml index 45ab66ec29..3f1f93184c 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml @@ -30,6 +30,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml index b46505d24b..908dc789d4 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml @@ -70,6 +70,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml b/tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml index 44ddfb0f76..51819e6907 100644 --- a/tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml +++ b/tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml @@ -12,6 +12,7 @@ <flag name='rng-random'/> <flag name='rng-egd'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='spice-rendernode'/> <flag name='nbd-tls'/> <flag name='pr-manager-helper'/> diff --git a/tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml index 2f361bd1c8..8b59aeb051 100644 --- a/tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml @@ -70,6 +70,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml index f04b2fd302..6bc824cae1 100644 --- a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml @@ -58,6 +58,7 @@ <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> <flag name='spice-gl'/> + <flag name='debug-threads'/> <flag name='virtio-vga'/> <flag name='ivshmem-plain'/> <flag name='ivshmem-doorbell'/> diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml b/tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml index 990fe255f6..b1e8e37147 100644 --- a/tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml @@ -33,6 +33,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml index 07d7562c84..f613955e15 100644 --- a/tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml b/tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml index c9e85ff9b3..1162e5a1b6 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml +++ b/tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml @@ -47,6 +47,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> <flag name='mptsas1068'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='query-cpu-model-expansion'/> diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml index a8f830076e..7ed1a57ae9 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml +++ b/tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml @@ -33,6 +33,7 @@ <flag name='virtio-tablet'/> <flag name='virtio-input-host'/> <flag name='virtio-balloon-pci.deflate-on-oom'/> + <flag name='debug-threads'/> <flag name='vhost-scsi'/> <flag name='query-cpu-model-expansion'/> <flag name='query-cpu-definitions'/> diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml b/tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml index f67222578d..c4a351d52c 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml +++ b/tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> diff --git a/tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml index efd3eeb9c7..834de87584 100644 --- a/tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml @@ -69,6 +69,7 @@ <flag name='mptsas1068'/> <flag name='spice-gl'/> <flag name='qxl.vram64_size_mb'/> + <flag name='debug-threads'/> <flag name='pxb'/> <flag name='pxb-pcie'/> <flag name='intel-iommu'/> -- 2.56.0

4 3

[PATCH 0/7] meson: improvements around "driver_XXXX" build options
by Daniel P. Berrangé 20 Oct '26

20 Oct '26

Daniel P. Berrangé (7): meson: group driver_XXX options meson: add dependency comment for driver_secret meson: add 'driver_nwfilter' option meson: add 'driver_nodedev' option meson: add 'driver_storage' option meson: rename driver_secrets to driver_secret rpm: add explicit driver_secret=enabled libvirt.spec.in | 9 ++++++++- meson.build | 34 +++++++++++++++++++++++++++------- meson_options.txt | 37 ++++++++++++++++++++++++------------- 3 files changed, 59 insertions(+), 21 deletions(-) -- 2.56.0

2 10

[PATCH V2] qemu: emit UNDEFINED event when undefining source after migration
by Jim Fehlig 20 Oct '26

20 Oct '26

From: Jim Fehlig <jfehlig(a)suse.com> When migrating with VIR_MIGRATE_UNDEFINE_SOURCE, qemuMigrationSrcConfirm() and qemuMigrationSrcPerformJob() delete the domain's persistent config on the source host but never emit a VIR_DOMAIN_EVENT_UNDEFINED lifecycle event. Applications relying solely on domain events never learn the domain was undefined on the source. Add a new UNDEFINED event detail named 'VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED", and include it when emitting an UNDEFINED event after a successful migration with VIR_MIGRATE_UNDEFINE_SOURCE flag. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- examples/c/misc/event-test.c | 3 +++ include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_migration.c | 10 ++++++++++ tools/virsh-domain-event.c | 3 ++- 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c index 601f5eafcf..3a601cce33 100644 --- a/examples/c/misc/event-test.c +++ b/examples/c/misc/event-test.c @@ -121,6 +121,9 @@ eventDetailToString(int event, case VIR_DOMAIN_EVENT_UNDEFINED_RENAMED: return "Renamed"; + case VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED: + return "Migrated"; + case VIR_DOMAIN_EVENT_UNDEFINED_LAST: break; } diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 99208137c3..890d11cf5e 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -5691,6 +5691,7 @@ typedef enum { typedef enum { VIR_DOMAIN_EVENT_UNDEFINED_REMOVED = 0, /* Deleted the config file (Since: 0.5.0) */ VIR_DOMAIN_EVENT_UNDEFINED_RENAMED = 1, /* Domain was renamed (Since: 1.2.19) */ + VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED = 2, /* Domain was migrated with VIR_MIGRATE_UNDEFINE_SOURCE flag (Since: 12.9.0) */ # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_EVENT_UNDEFINED_LAST /* (Since: 0.9.10) */ diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 797f83ca0d..76661de09a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4279,6 +4279,7 @@ qemuMigrationSrcConfirm(virQEMUDriver *driver, { qemuMigrationJobPhase phase; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); + virObjectEvent *event = NULL; int ret = -1; VIR_DEBUG("vm=%p, flags=0x%x, cancelled=%d", vm, flags, cancelled); @@ -4325,11 +4326,15 @@ qemuMigrationSrcConfirm(virQEMUDriver *driver, if (!cancelled && ret == 0 && flags & VIR_MIGRATE_UNDEFINE_SOURCE) { virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm); vm->persistent = 0; + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_UNDEFINED, + VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED); } qemuDomainRemoveInactive(vm, VIR_DOMAIN_UNDEFINE_TPM, true); } cleanup: + virObjectEventStateQueue(driver->domainEventState, event); virDomainObjEndAPI(&vm); return ret; } @@ -6328,6 +6333,7 @@ qemuMigrationSrcPerformJob(virQEMUDriver *driver, bool v3proto) { virObjectEvent *event = NULL; + virObjectEvent *undefine_event = NULL; int ret = -1; virErrorPtr orig_err = NULL; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); @@ -6419,6 +6425,9 @@ qemuMigrationSrcPerformJob(virQEMUDriver *driver, if (flags & VIR_MIGRATE_UNDEFINE_SOURCE) { virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm); vm->persistent = 0; + undefine_event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_UNDEFINED, + VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED); } qemuDomainRemoveInactive(vm, 0, true); } @@ -6427,6 +6436,7 @@ qemuMigrationSrcPerformJob(virQEMUDriver *driver, cleanup: virObjectEventStateQueue(driver->domainEventState, event); + virObjectEventStateQueue(driver->domainEventState, undefine_event); return ret; } diff --git a/tools/virsh-domain-event.c b/tools/virsh-domain-event.c index a541b155f4..40a72563a5 100644 --- a/tools/virsh-domain-event.c +++ b/tools/virsh-domain-event.c @@ -62,7 +62,8 @@ VIR_ENUM_DECL(virshDomainEventUndefined); VIR_ENUM_IMPL(virshDomainEventUndefined, VIR_DOMAIN_EVENT_UNDEFINED_LAST, N_("Removed"), - N_("Renamed")); + N_("Renamed"), + N_("Migrated")); VIR_ENUM_DECL(virshDomainEventStarted); VIR_ENUM_IMPL(virshDomainEventStarted, -- 2.51.0

2 1

[PATCH merged] qemu: fix symlink path comparison in namespace setup
by Michal Privoznik 20 Oct '26

20 Oct '26

From: sayaoailun <guojianwei007(a)126.com> When comparing symlink targets in qemuNamespaceMknodOne(), the code directly compares the raw symlink target (which may be a relative path) with data->target (which was normalized to an absolute path in qemuNamespaceMknodItemInit()). This causes false mismatches when the symlink uses a relative path. Fix this by normalizing the symlink target to an absolute path before comparison, using the same logic as qemuNamespaceMknodItemInit(). This fixes VM startup failure with LVM volumes that use relative symlinks, which reported 'Unable to remove symlink: Device or resource busy'. Signed-off-by: sayaoailun <guojianwei007(a)126.com> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_namespace.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index 4a063064f1..29fec2af45 100644 --- a/src/qemu/qemu_namespace.c +++ b/src/qemu/qemu_namespace.c @@ -1031,9 +1031,26 @@ qemuNamespaceMknodOne(qemuNamespaceMknodItem *data) if (isLink) { g_autofree char *target = NULL; + bool targetMatches = false; - if ((target = g_file_read_link(data->file, NULL)) && - STREQ(target, data->target)) { + if ((target = g_file_read_link(data->file, NULL))) { + /* Normalize relative path to absolute path for comparison, + * using the same logic as qemuNamespaceMknodItemInit(). */ + if (!g_path_is_absolute(target)) { + g_autofree char *fileTmp = g_strdup(data->file); + char *c = NULL; + + if ((c = strrchr(fileTmp, '/'))) + *(c + 1) = '\0'; + + target = g_strdup_printf("%s%s", fileTmp, target); + } + + if (STREQ(target, data->target)) + targetMatches = true; + } + + if (targetMatches) { VIR_DEBUG("Skipping symlink %s -> %s which exists and points to correct target", data->file, data->target); } else { -- 2.56.0

1 0