September 2023 - Devel - libvirt List Archives

[PATCH] NEWS: Document my contributions for upcoming release
by Michal Privoznik 29 Sep '23

29 Sep '23

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c17a1d002d..6f46e86ba8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -43,8 +43,20 @@ v9.8.0 (unreleased) stability of qemu. Therefore, when available, libvirt will use nbdkit as a backend for these network disks and export an NBD disk to qemu. + * virnetdevopenvswitch: Propagate OVS error messages + + When configuring OVS interfaces/bridges libvirt used to report its own + error messages instead of passing (more accurate) error messages from + `ovs-vsctl`. This is now changed. + * **Bug fixes** + * Various virtio-mem/virtio-pmem fixes + + It was discovered that libvirt did not validate some values wrt virtio-mem + and virtio-pmem memory devices, e.g. overlapping memory addresses or + alignment. + v9.7.0 (2023-09-01) =================== -- 2.41.0

2 1

[PATCH] NEWS: Fix placement of network metadata entry
by Michal Privoznik 29 Sep '23

29 Sep '23

The network metadata support is a new feature in the upcoming release, not a removed one. Place it accordingly. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 768e6fc326..c17a1d002d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,14 +15,14 @@ v9.8.0 (unreleased) * **Removed features** +* **New features** + * network: New metadata change event The network object now has a new event ID ``VIR_NETWORK_EVENT_ID_METADATA_CHANGE`` that can be used to get notifications upon changes in any of ``<title>``, ``<description>`` or ``<metadata>``. -* **New features** - * qemu: Add support for vDPA block devices With a new enough version of qemu, libvirt will allow you to assign vDPA block -- 2.41.0

2 1

Entering freeze for libvirt-9.8.0
by Jiri Denemark 29 Sep '23

29 Sep '23

I have just tagged v9.8.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[libvirt PATCH] rpm: Drop with_vz define
by Andrea Bolognani 28 Sep '23

28 Sep '23

Commit 56edf2fefe30 removed the last use. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 57cf46a16d..f3d21ccc8f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -128,7 +128,6 @@ %define with_vmware 0 %define with_libxl 0 %define with_hyperv 0 - %define with_vz 0 %define with_lxc 0 %endif -- 2.41.0

2 1

[libvirt PATCH v2 00/33] systemd: Improve units for services and sockets
by Andrea Bolognani 28 Sep '23

28 Sep '23

A grab bag of changes, ranging from very much functional ones to purely aesthetical ones. Changes from [v1] * patches 01-11 from the original series have been pushed; * patch 40 from the original series has been dropped; * patches 02 (cosmetic) and 31 (bug fix) have been added; * the templating mechanism has been completely overhauled, and now uses a Python script for performing service-specific unit customizations instead of meson's built-in templating capabilities; * as a result of the above, service-specific customizations are now stored in specific foo.{service,socket}.extra.in files instead of meson.build; * various other tweaks in response to review feedback. [v1] https://listman.redhat.com/archives/libvir-list/2023-September/242288.html Andrea Bolognani (33): systemd: Drop Conflicts from virtproxyd sockets systemd: Introduce service_in/service_out variables systemd: Make @service_in@ optional systemd: Introduce temporary libvirtd_socket*_in values systemd: Provide all input files explicitly systemd: Introduce common templates systemd: Use common templates by default systemd: Switch virtnodedevd to common templates systemd: Switch virtinterfaced to common templates systemd: Switch virtnwfilterd to common templates systemd: Switch virtsecretd to common templates systemd: Switch virtnetworkd to common templates systemd: Switch virtstoraged to common templates systemd: Switch virtvboxd to common templates systemd: Switch virtvzd to common templates systemd: Switch virtchd to common templates systemd: Switch virtxend to common templates systemd: Switch virtlxcd to common templates systemd: Switch virtqemud to common templates systemd: Switch virtproxyd to common templates systemd: Drop libvirtd_socket*_in values systemd: Drop @deps@ systemd: Drop parametrization from libvirtd sockets systemd: Make modular daemons conflict with libvirtd systemd: Replace Requires with BindTo+After for main socket systemd: Downgrade read-only/admin sockets to Wants systemd: Augment Requires/Wants with After systemd: Drop Before=libvirtd from virtlogd/virtlockd systemd: Drop Before=foo.service from sockets systemd: Add Also between sockets systemd: Add RemoveOnStop=yes to all sockets systemd: Improve and unify unit descriptions systemd: Move Documentation lines scripts/merge-systemd-units.py | 91 +++++++++++++++++++ scripts/meson.build | 1 + src/ch/meson.build | 4 +- src/ch/virtchd.service.extra.in | 22 +++++ src/ch/virtchd.service.in | 44 --------- src/interface/meson.build | 3 +- src/interface/virtinterfaced.service.in | 25 ----- src/libxl/meson.build | 6 +- src/libxl/virtxend.service.extra.in | 13 +++ src/libxl/virtxend.service.in | 32 ------- src/libxl/virtxend.socket.extra.in | 2 + src/locking/meson.build | 2 +- src/locking/virtlockd-admin.socket.in | 5 +- src/locking/virtlockd.service.in | 11 ++- src/locking/virtlockd.socket.in | 5 +- src/logging/meson.build | 2 +- src/logging/virtlogd-admin.socket.in | 5 +- src/logging/virtlogd.service.in | 11 ++- src/logging/virtlogd.socket.in | 5 +- src/lxc/meson.build | 4 +- src/lxc/virtlxcd.service.extra.in | 22 +++++ src/lxc/virtlxcd.service.in | 44 --------- src/meson.build | 41 +++++++-- src/network/meson.build | 4 +- src/network/virtnetworkd.service.extra.in | 2 + src/network/virtnetworkd.service.in | 26 ------ src/node_device/meson.build | 3 +- src/node_device/virtnodedevd.service.in | 25 ----- src/nwfilter/meson.build | 3 +- src/nwfilter/virtnwfilterd.service.in | 25 ----- src/qemu/meson.build | 4 +- src/qemu/virtqemud.service.extra.in | 30 ++++++ src/qemu/virtqemud.service.in | 48 ---------- src/remote/libvirtd-admin.socket.in | 15 +-- src/remote/libvirtd-ro.socket.in | 15 +-- src/remote/libvirtd-tcp.socket.in | 10 +- src/remote/libvirtd-tls.socket.in | 10 +- src/remote/libvirtd.service.in | 13 ++- src/remote/libvirtd.socket.in | 10 +- src/remote/meson.build | 13 +-- src/remote/virtproxyd.service.in | 25 ----- src/secret/meson.build | 3 +- src/secret/virtsecretd.service.in | 25 ----- src/storage/meson.build | 4 +- src/storage/virtstoraged.service.extra.in | 3 + src/storage/virtstoraged.service.in | 27 ------ src/vbox/meson.build | 4 +- src/vbox/virtvboxd.service.extra.in | 2 + src/vbox/virtvboxd.service.in | 26 ------ ...-admin.socket.in => virtd-admin.socket.in} | 9 +- ...bvirtd-ro.socket.in => virtd-ro.socket.in} | 9 +- ...irtd-tcp.socket.in => virtd-tcp.socket.in} | 6 +- ...irtd-tls.socket.in => virtd-tls.socket.in} | 6 +- src/virtd.service.in | 29 ++++++ .../libvirtd.socket.in => virtd.socket.in} | 8 +- src/vz/meson.build | 4 +- src/vz/virtvzd.service.extra.in | 2 + src/vz/virtvzd.service.in | 26 ------ 58 files changed, 367 insertions(+), 507 deletions(-) create mode 100755 scripts/merge-systemd-units.py create mode 100644 src/ch/virtchd.service.extra.in delete mode 100644 src/ch/virtchd.service.in delete mode 100644 src/interface/virtinterfaced.service.in create mode 100644 src/libxl/virtxend.service.extra.in delete mode 100644 src/libxl/virtxend.service.in create mode 100644 src/libxl/virtxend.socket.extra.in create mode 100644 src/lxc/virtlxcd.service.extra.in delete mode 100644 src/lxc/virtlxcd.service.in create mode 100644 src/network/virtnetworkd.service.extra.in delete mode 100644 src/network/virtnetworkd.service.in delete mode 100644 src/node_device/virtnodedevd.service.in delete mode 100644 src/nwfilter/virtnwfilterd.service.in create mode 100644 src/qemu/virtqemud.service.extra.in delete mode 100644 src/qemu/virtqemud.service.in delete mode 100644 src/remote/virtproxyd.service.in delete mode 100644 src/secret/virtsecretd.service.in create mode 100644 src/storage/virtstoraged.service.extra.in delete mode 100644 src/storage/virtstoraged.service.in create mode 100644 src/vbox/virtvboxd.service.extra.in delete mode 100644 src/vbox/virtvboxd.service.in copy src/{remote/libvirtd-admin.socket.in => virtd-admin.socket.in} (54%) copy src/{remote/libvirtd-ro.socket.in => virtd-ro.socket.in} (53%) copy src/{remote/libvirtd-tcp.socket.in => virtd-tcp.socket.in} (57%) copy src/{remote/libvirtd-tls.socket.in => virtd-tls.socket.in} (58%) create mode 100644 src/virtd.service.in copy src/{remote/libvirtd.socket.in => virtd.socket.in} (54%) create mode 100644 src/vz/virtvzd.service.extra.in delete mode 100644 src/vz/virtvzd.service.in -- 2.41.0

2 66

[libvirt PATCH] docs: Go bindings release at the same time as the C library
by Andrea Bolognani 28 Sep '23

28 Sep '23

The actual versioning policy[1] is a bit more nuanced, and in particular there are scenarios in which the monthly release is intentionally skipped, but overall it's not inaccurate to claim that the release cadence of the Go bindings follows the one of the C library. [1] https://gitlab.com/libvirt/libvirt-go-module/-/blob/master/VERSIONING.rst Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/downloads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index c7d4237f66..d3deec554d 100644 --- a/docs/downloads.rst +++ b/docs/downloads.rst @@ -261,7 +261,7 @@ The core libvirt module follows a time based plan, with releases made once a month on the 1st of each month give or take a few days. The only exception is at the start of the year where there are two 6 weeks gaps (first release in the middle of Jan, then skip the Feb release), giving a total of 11 releases a year. -The Python and Perl modules will aim to release at the same time as the core +The Python, Perl and Go modules will aim to release at the same time as the core libvirt module. Other modules have independent ad-hoc releases with no fixed time schedule. -- 2.41.0

2 1

[libvirt PATCH 00/42] systemd: Improve units for services and sockets
by Andrea Bolognani 27 Sep '23

27 Sep '23

A grab bag of changes, ranging from very much functional ones to purely aesthetical ones. Patches 01-05 fix a few inconsistencies that the units for virtlogd/virtlockd had compared to the ones for all other services. Patches 06-16 prepare the stage for the mass conversion of unit files to set of common templates; patches 17-32 are where the conversion actually happen. After this point, most units are based on the common templates, which will hopefully make it less painful to maintain them going forward. The remaining patches should prove this point. Patches 33-34 reorganize conflict relationships so that the nastiest interactions between modular daemons and libvirtd can no longer happen. Patches 35-42 contain a few additional improvements and cleanups. Andrea Bolognani (42): systemd: Add missing Also for admin socket systemd: Add missing WantedBy for virtlogd/virtlockd systemd: Add missing Service for virtlogd/virtlockd systemd: Set Type=notify for virtlogd/virtlockd systemd: Set @name@ for virtlogd/virtlockd systemd: Rename socket_in_def -> socket_in_default systemd: Rename @mode@ -> @sockmode@ systemd: Only set @sockmode@ once systemd: Drop unnecessary uses of @sockets@ systemd: Make @sockprefix@ optional systemd: Drop unnecessary uses of @sockprefix@ systemd: Make @service_in@ optional systemd: Introduce temporary libvirtd_socket*_in values systemd: Provide all input files explicitly systemd: Introduce common templates systemd: Use common templates by default systemd: Switch virtnodedevd to common templates systemd: Switch virtinterfaced to common templates systemd: Switch virtnwfilterd to common templates systemd: Switch virtsecretd to common templates systemd: Switch virtnetworkd to common templates systemd: Switch virtstoraged to common templates systemd: Switch virtproxyd to common templates systemd: Switch virtvboxd to common templates systemd: Switch virtvzd to common templates systemd: Switch virtchd to common templates systemd: Switch virtxend to common templates systemd: Switch virtlxcd to common templates systemd: Switch virtqemud to common templates systemd: Drop libvirtd_socket*_in values systemd: Drop @deps@ systemd: Drop parametrization from libvirtd sockets systemd: Drop Conflicts from virtproxyd sockets systemd: Make modular daemons conflict with libvirtd systemd: Replace Requires with BindTo+After for sockets systemd: Augment Requires/Wants with After systemd: Drop Before=libvirtd from virtlogd/virtlockd systemd: Drop Before=foo.service from sockets systemd: Add Also between sockets systemd: Drop BindTo/After between sockets systemd: Improve and unify unit descriptions systemd: Move Documentation lines src/ch/meson.build | 28 ++++++++++++--- src/ch/virtchd.service.in | 44 ----------------------- src/interface/meson.build | 5 +-- src/interface/virtinterfaced.service.in | 25 ------------- src/libxl/meson.build | 23 +++++++++--- src/libxl/virtxend.service.in | 32 ----------------- src/locking/meson.build | 3 +- src/locking/virtlockd-admin.socket.in | 6 ++-- src/locking/virtlockd.service.in | 14 +++++--- src/locking/virtlockd.socket.in | 5 +-- src/logging/meson.build | 3 +- src/logging/virtlogd-admin.socket.in | 6 ++-- src/logging/virtlogd.service.in | 14 +++++--- src/logging/virtlogd.socket.in | 5 +-- src/lxc/meson.build | 28 ++++++++++++--- src/lxc/virtlxcd.service.in | 44 ----------------------- src/meson.build | 46 ++++++++++++++---------- src/network/meson.build | 8 ++--- src/network/virtnetworkd.service.in | 26 -------------- src/node_device/meson.build | 5 +-- src/node_device/virtnodedevd.service.in | 25 ------------- src/nwfilter/meson.build | 5 +-- src/nwfilter/virtnwfilterd.service.in | 25 ------------- src/qemu/meson.build | 36 ++++++++++++++++--- src/qemu/virtqemud.service.in | 48 ------------------------- src/remote/libvirtd-admin.socket.in | 12 +++---- src/remote/libvirtd-ro.socket.in | 12 +++---- src/remote/libvirtd-tcp.socket.in | 8 ++--- src/remote/libvirtd-tls.socket.in | 8 ++--- src/remote/libvirtd.service.in | 14 +++++--- src/remote/libvirtd.socket.in | 12 +++---- src/remote/meson.build | 13 +++---- src/remote/virtproxyd.service.in | 25 ------------- src/secret/meson.build | 5 +-- src/secret/virtsecretd.service.in | 25 ------------- src/storage/meson.build | 9 ++--- src/storage/virtstoraged.service.in | 27 -------------- src/vbox/meson.build | 8 ++--- src/vbox/virtvboxd.service.in | 26 -------------- src/virtd-admin.socket.in | 17 +++++++++ src/virtd-ro.socket.in | 17 +++++++++ src/virtd-tcp.socket.in | 14 ++++++++ src/virtd-tls.socket.in | 14 ++++++++ src/virtd.service.in | 32 +++++++++++++++++ src/virtd.socket.in | 18 ++++++++++ src/vz/meson.build | 8 ++--- src/vz/virtvzd.service.in | 26 -------------- 47 files changed, 326 insertions(+), 533 deletions(-) delete mode 100644 src/ch/virtchd.service.in delete mode 100644 src/interface/virtinterfaced.service.in delete mode 100644 src/libxl/virtxend.service.in delete mode 100644 src/lxc/virtlxcd.service.in delete mode 100644 src/network/virtnetworkd.service.in delete mode 100644 src/node_device/virtnodedevd.service.in delete mode 100644 src/nwfilter/virtnwfilterd.service.in delete mode 100644 src/qemu/virtqemud.service.in delete mode 100644 src/remote/virtproxyd.service.in delete mode 100644 src/secret/virtsecretd.service.in delete mode 100644 src/storage/virtstoraged.service.in delete mode 100644 src/vbox/virtvboxd.service.in create mode 100644 src/virtd-admin.socket.in create mode 100644 src/virtd-ro.socket.in create mode 100644 src/virtd-tcp.socket.in create mode 100644 src/virtd-tls.socket.in create mode 100644 src/virtd.service.in create mode 100644 src/virtd.socket.in delete mode 100644 src/vz/virtvzd.service.in -- 2.41.0

3 76

[PATCH] virsh: Account for return values in virNodeGetFreePages
by Martin Kletzander 27 Sep '23

27 Sep '23

The function returns how many array items were filled in, but virsh never checked for anything other than errors. Just to make sure this does not report invalid data, even though the only possibility would be reporting 0 free pages, check the returned data so that possible errors are detected. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/virsh-host.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 21aca5f6dc83..411648197895 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -328,6 +328,8 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) bool cellno = vshCommandOptBool(cmd, "cellno"); bool pagesz = vshCommandOptBool(cmd, "pagesize"); virshControl *priv = ctl->privData; + bool pagesize_missing = false; + int rv = -1; VSH_EXCLUSIVE_OPTIONS_VAR(all, cellno); @@ -407,16 +409,22 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - if (virNodeGetFreePages(priv->conn, npages, pagesize, - cell, 1, counts, 0) < 0) + rv = virNodeGetFreePages(priv->conn, npages, pagesize, + cell, 1, counts, 0); + if (rv < 0) goto cleanup; + if (rv < npages) { + pagesize_missing = true; + vshError(ctl, _("Did not get all free page data for node %1$d"), cell); + continue; + } + vshPrint(ctl, _("Node %1$d:\n"), cell); for (j = 0; j < npages; j++) vshPrint(ctl, "%uKiB: %lld\n", pagesize[j], counts[j]); vshPrint(ctl, "%c", '\n'); } - } else { if (!cellno) { vshError(ctl, "%s", _("missing cellno argument")); @@ -443,14 +451,22 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) counts = g_new0(unsigned long long, 1); - if (virNodeGetFreePages(priv->conn, 1, pagesize, - cell, 1, counts, 0) < 0) + rv = virNodeGetFreePages(priv->conn, 1, pagesize, + cell, 1, counts, 0); + if (rv < 0) goto cleanup; + if (rv == 0) { + vshError(ctl, + "Could not get count of free %uKiB pages, no data returned", + *pagesize); + goto cleanup; + } + vshPrint(ctl, "%uKiB: %lld\n", *pagesize, counts[0]); } - ret = true; + ret = !pagesize_missing; cleanup: VIR_FREE(nodes); return ret; -- 2.42.0

2 1

[libvirt PATCH] gitpublish: Add suppresscc option
by Erik Skultety 27 Sep '23

27 Sep '23

send-email scans the commit messages to figure out the default set of addresses to put into CC, Acked-by/Reviewed-by, etc-by being among them. We're quite strict about CC-ing people on libvirt-list, since most developers are subscribed to the list anyway. Respect the rule by avoiding CCing people solely based on the fact that they've done review of any of previous revisions. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- I noticed this issue when sending https://listman.redhat.com/archives/libvir-list/2023-September/242173.html and publish automatically included Dan. I guess I could have overridden the CC explicitly to just include my own address and reduce the noise, but was too fast to hit send. .gitpublish | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitpublish b/.gitpublish index d37bf4174a..457c8c676b 100644 --- a/.gitpublish +++ b/.gitpublish @@ -2,3 +2,4 @@ base = master to = libvir-list(a)redhat.com prefix = libvirt PATCH +suppresscc = misc-by -- 2.41.0

2 2

[libvirt PATCH 0/2] Add vdpablock and nbdkit to NEWS
by Jonathon Jongsma 27 Sep '23

27 Sep '23

Jonathon Jongsma (2): news: document support for vdpa block devices news: document nbdkit support for network disks NEWS.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) -- 2.41.0

2 4