[libvirt PATCH v2 0/6] external snapshot revert fixes
by Pavel Hrdina
This fixes reverting external snapshots to not error out in cases where
it should work and makes it correctly load the memory state when
reverting to snapshot of running VM.
Last patch is not part of the fix, it is alternative solution to remove
the capability as we are close to releasing libvirt 9.7.0 in case the
code fixing reverting snapshots is considered too complex.
This v2 limits the impact only to snapshot code and no longer changes
anything in qemu_saveimage except for exporting one function and one
enum.
Pavel Hrdina (6):
qemu_snapshot: fix reverting external snapshot when not all disks are
included
qemu_saveimage: export virQEMUSaveFormat enum
qemu_saveimage: export qemuSaveImageGetCompressionCommand
qemu_snapshot: correctly load the saved memory state file
NEWS: document support for reverting external snapshots
Revert "capabilities: report full external snapshot support"
NEWS.rst | 8 ++
docs/formatcaps.rst | 7 -
src/conf/capabilities.c | 1 -
src/conf/capabilities.h | 1 -
src/conf/schemas/capability.rng | 5 -
src/qemu/qemu_capabilities.c | 1 -
src/qemu/qemu_saveimage.c | 19 +--
src/qemu/qemu_saveimage.h | 20 +++
src/qemu/qemu_snapshot.c | 127 +++++++++++++++---
.../qemucaps2xmloutdata/caps.aarch64+hvf.xml | 1 -
tests/qemucaps2xmloutdata/caps.aarch64.xml | 1 -
tests/qemucaps2xmloutdata/caps.ppc.xml | 1 -
tests/qemucaps2xmloutdata/caps.ppc64.xml | 1 -
tests/qemucaps2xmloutdata/caps.riscv64.xml | 1 -
tests/qemucaps2xmloutdata/caps.s390x.xml | 1 -
tests/qemucaps2xmloutdata/caps.sparc.xml | 1 -
tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml | 1 -
tests/qemucaps2xmloutdata/caps.x86_64.xml | 1 -
18 files changed, 138 insertions(+), 60 deletions(-)
--
2.41.0
8 months, 3 weeks
[libvirt PATCH] docs: remove archived projects from CI dashboard
by Daniel P. Berrangé
When the projects were archived, their pipelines were all purged, and
no new ones will be run. There is no point in continuing to display
them on the CI dashboard.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
docs/ci-dashboard.rst | 35 -----------------------------------
1 file changed, 35 deletions(-)
diff --git a/docs/ci-dashboard.rst b/docs/ci-dashboard.rst
index a7f4e71f96..50f39cd252 100644
--- a/docs/ci-dashboard.rst
+++ b/docs/ci-dashboard.rst
@@ -87,11 +87,6 @@ Object mappings
* - Project
- Pipeline
- * - libvirt-cim
- - .. image:: https://gitlab.com/libvirt/libvirt-cim/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-cim/pipelines
- :alt: libvirt-cim pipeline status
-
* - libvirt-dbus
- .. image:: https://gitlab.com/libvirt/libvirt-dbus/badges/master/pipeline.svg
:target: https://gitlab.com/libvirt/libvirt-dbus/pipelines
@@ -107,11 +102,6 @@ Object mappings
:target: https://gitlab.com/libvirt/libvirt-go-xml-module/pipelines
:alt: libvirt-go-xml-module pipeline status
- * - libvirt-snmp
- - .. image:: https://gitlab.com/libvirt/libvirt-snmp/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-snmp/pipelines
- :alt: libvirt-snmp pipeline status
-
Testing
-------
@@ -149,16 +139,6 @@ Documentation / websites
* - Project
- Pipeline
- * - libvirt-publican
- - .. image:: https://gitlab.com/libvirt/libvirt-publican/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-publican/pipelines
- :alt: libvirt-publican pipeline status
-
- * - libvirt-appdev-guide-python
- - .. image:: https://gitlab.com/libvirt/libvirt-appdev-guide-python/badges/master/pipe...
- :target: https://gitlab.com/libvirt/libvirt-appdev-guide-python/pipelines
- :alt: libvirt-appdev-guide-python pipeline status
-
* - libvirt-wiki
- .. image:: https://gitlab.com/libvirt/libvirt-wiki/badges/master/pipeline.svg
:target: https://gitlab.com/libvirt/libvirt-wiki/pipelines
@@ -190,26 +170,11 @@ Miscellaneous
:target: https://gitlab.com/libvirt/libvirt-console-proxy/pipelines
:alt: libvirt-console-proxy pipeline status
- * - libvirt-designer
- - .. image:: https://gitlab.com/libvirt/libvirt-designer/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-designer/pipelines
- :alt: libvirt-designer pipeline status
-
* - libvirt-devaddr
- .. image:: https://gitlab.com/libvirt/libvirt-devaddr/badges/master/pipeline.svg
:target: https://gitlab.com/libvirt/libvirt-devaddr/pipelines
:alt: libvirt-devaddr pipeline status
- * - libvirt-sandbox
- - .. image:: https://gitlab.com/libvirt/libvirt-sandbox/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-sandbox/pipelines
- :alt: libvirt-sandbox pipeline status
-
- * - libvirt-sandbox-image
- - .. image:: https://gitlab.com/libvirt/libvirt-sandbox-image/badges/master/pipeline.svg
- :target: https://gitlab.com/libvirt/libvirt-sandbox-image/pipelines
- :alt: libvirt-sandbox-image pipeline status
-
* - libvirt-security-notice
- .. image:: https://gitlab.com/libvirt/libvirt-security-notice/badges/master/pipeline...
:target: https://gitlab.com/libvirt/libvirt-security-notice/pipelines
--
2.41.0
8 months, 3 weeks
[PATCH] virsh: Fix net-desc --config output
by K Shiva Kiran
Fixes the following bug:
Command: `net-desc --config [--title] my_network`
Expected Output: Title/Description of persistent config
Output: Title/Description of live config
This was caused due to the usage of a single `flags` variable in
`virshGetNetworkDescription()` which ended up in a wrong enum being
passed to `virNetworkGetMetadata()` (enum being that of LIVE instead of
CONFIG).
Although the domain object has the same code, this didn't cause a problem
there because the enum values of `VIR_DOMAIN_INACTIVE_XML` and
`VIR_DOMAIN_METADATA_CONFIG` turn out to be the same (1 << 1), whereas
they are not for network equivalent ones (1 << 0, 1 << 1).
Signed-off-by: K Shiva Kiran <shiva_kr(a)riseup.net>
---
tools/virsh-network.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 49778d0f4f..8965d87c9c 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.c
@@ -366,7 +366,8 @@ static const vshCmdOptDef opts_network_desc[] = {
/* extract description or title from network xml */
static char *
virshGetNetworkDescription(vshControl *ctl, virNetworkPtr net,
- bool title, unsigned int flags)
+ bool title, unsigned int flags,
+ unsigned int queryflags)
{
char *desc = NULL;
g_autoptr(xmlDoc) doc = NULL;
@@ -394,7 +395,7 @@ virshGetNetworkDescription(vshControl *ctl, virNetworkPtr net,
}
/* fall back to xml */
- if (virshNetworkGetXMLFromNet(ctl, net, flags, &doc, &ctxt) < 0)
+ if (virshNetworkGetXMLFromNet(ctl, net, queryflags, &doc, &ctxt) < 0)
return NULL;
if (title)
@@ -454,7 +455,7 @@ cmdNetworkDesc(vshControl *ctl, const vshCmd *cmd)
g_autofree char *descNet = NULL;
g_autofree char *descNew = NULL;
- if (!(descNet = virshGetNetworkDescription(ctl, net, title, queryflags)))
+ if (!(descNet = virshGetNetworkDescription(ctl, net, title, flags, queryflags)))
return false;
if (!descArg)
@@ -515,7 +516,7 @@ cmdNetworkDesc(vshControl *ctl, const vshCmd *cmd)
vshPrintExtra(ctl, "%s", _("Network description updated successfully"));
} else {
- g_autofree char *desc = virshGetNetworkDescription(ctl, net, title, queryflags);
+ g_autofree char *desc = virshGetNetworkDescription(ctl, net, title, flags, queryflags);
if (!desc)
return false;
@@ -1128,7 +1129,7 @@ cmdNetworkList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED)
if (optTitle) {
g_autofree char *title = NULL;
- if (!(title = virshGetNetworkDescription(ctl, network, true, 0)))
+ if (!(title = virshGetNetworkDescription(ctl, network, true, 0, 0)))
goto cleanup;
if (vshTableRowAppend(table,
virNetworkGetName(network),
--
2.42.0
8 months, 3 weeks
[libvirt PATCH 0/7] external snapshot revert fixes
by Pavel Hrdina
This fixes reverting external snapshots to not error out in cases where
it should work and makes it correctly load the memory state when
reverting to snapshot of running VM.
Pavel Hrdina (7):
qemu_saveimage: extract starting process to qemuSaveImageStartProcess
qemuSaveImageStartProcess: allow setting reason for audit log
qemuSaveImageStartProcess: add snapshot argument
qemuSaveImageStartProcess: make it possible to use without header
qemu_snapshot: fix reverting external snapshot when not all disks are
included
qemu_snapshot: correctly load the saved memory state file
NEWS: document support for reverting external snapshots
NEWS.rst | 8 +++
src/qemu/qemu_saveimage.c | 111 ++++++++++++++++++++++++++------------
src/qemu/qemu_saveimage.h | 14 +++++
src/qemu/qemu_snapshot.c | 90 ++++++++++++++++++++-----------
4 files changed, 158 insertions(+), 65 deletions(-)
--
2.41.0
8 months, 3 weeks
