Re: [libvirt-users] Bug? virGetLastError() returns NULL after virDomainCreate() if Domain running already

> > There's nothing in there between calling virDomainCreate() and > virGetLastError(). There are no other threads, either. > > Anyway, I've fired up gdb now to see if I can find out where the error > object gets lost. I found out what is happening here: I am using a C++ wrapper class for virDomainPtr, to make it fit better with the RAII principles in that language. That means that, in the above code snippet, even though it's not actually visible because it happens in the constructor and destructor of a temporary object, the virDomainPtr for domain gets copied once, virDomainRef() gets called on it, and after the attempt to start the domain, virDomainFree() gets called. The problem is that virDomainFree() will unconditionally call virResetLastError().

With that info, I could work around the problem, however, I still think that, since virDomainFree() is a reference-counting free, it should only call virResetLastError() when the reference count has actually reached 0. In fact, it should probably even check whether the last error even belongs to the domain being deleted.