[libvirt] [PATCH] docs: bhyve: document autoport support
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+) It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change. If not, it's not a big deal to let it wait for the next release though. PS I've been semi-afk for last couple of weeks, hence the delay, sorry about that. 1: https://www.redhat.com/archives/libvir-list/2017-July/msg00704.html diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in index f083db91c..0cc9f0aa0 100644 --- a/docs/drvbhyve.html.in +++ b/docs/drvbhyve.html.in @@ -381,6 +381,14 @@ will be used. Please refer to the manual page and the <a href="https://wiki.freebsd.org/bhyve">bhyve wiki</a> for more details on using the <code>vgaconf</code> option.</p> +<p><span class="since">Since 3.6.0</span>, it's possible to use <code>autoport</code> +to let libvirt allocate VNC port automatically (instead of explicitly specifying +it with the <code>port</code> attribute):</p> + +<pre> + <graphics type='vnc' autoport='yes'> +</pre> + <h3><a name="clockconfig">Clock configuration</a></h3> <p>Originally bhyve supported only localtime for RTC. Support for UTC time was introduced in diff --git a/docs/news.xml b/docs/news.xml index ea21cbc3e..e84dea9ad 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -61,6 +61,16 @@ on separate PHBs (PCI Host Bridges). </description> </change> + <change> + <summary> + bhyve: Support autoport for VNC ports + </summary> + <description> + It's no longer necessary to explicitly specify VNC port for the bhyve + guests. With the autoport feature it will be allocated automatically. + Please refer to the bhyve driver documentation for examples. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.13.1
On 07/30/2017 12:07 PM, Roman Bogorodskiy wrote:
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+)
ACK and safe for the freeze.
It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change.
I think it's rather demanded. I mean, otherwise we would have an undocumented feature. Please push ASAP. Michal
On 08/01/2017 11:46 AM, Michal Privoznik wrote:
On 07/30/2017 12:07 PM, Roman Bogorodskiy wrote:
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+)
ACK and safe for the freeze.
It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change.
I think it's rather demanded. I mean, otherwise we would have an undocumented feature. Please push ASAP.
Ah, I have to discard this. I though the feature was already pushed and you want to have just the documentation in. But I was wrong. Anyway, ACK still stands, but it's a feature and as such is not safe for freeze. Sorry for the noise. Michal
Michal Privoznik wrote:
On 08/01/2017 11:46 AM, Michal Privoznik wrote:
On 07/30/2017 12:07 PM, Roman Bogorodskiy wrote:
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+)
ACK and safe for the freeze.
It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change.
I think it's rather demanded. I mean, otherwise we would have an undocumented feature. Please push ASAP.
Ah, I have to discard this. I though the feature was already pushed and you want to have just the documentation in. But I was wrong. Anyway, ACK still stands, but it's a feature and as such is not safe for freeze. Sorry for the noise.
Michal
Good, I'll push both commits after the freaze, thanks! Roman Bogorodskiy
Roman Bogorodskiy wrote:
Michal Privoznik wrote:
On 08/01/2017 11:46 AM, Michal Privoznik wrote:
On 07/30/2017 12:07 PM, Roman Bogorodskiy wrote:
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+)
ACK and safe for the freeze.
It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change.
I think it's rather demanded. I mean, otherwise we would have an undocumented feature. Please push ASAP.
Ah, I have to discard this. I though the feature was already pushed and you want to have just the documentation in. But I was wrong. Anyway, ACK still stands, but it's a feature and as such is not safe for freeze. Sorry for the noise.
Michal
Good, I'll push both commits after the freaze, thanks!
Updated the patch for 3.7.0 and pushed, thanks! Roman Bogorodskiy
On Sun, Jul 30, 2017 at 02:07:31PM +0400, Roman Bogorodskiy wrote:
- Update the driver page with the information about using autport for VNC ports - Add a news entry --- docs/drvbhyve.html.in | 8 ++++++++ docs/news.xml | 10 ++++++++++ 2 files changed, 18 insertions(+)
It's a freeze now, but I guess it won't hurt if I push the actual feature ACKed before the freeze [1] along with this docs change.
We do not have the concept of 'soft freeze' when already discussed features can go in. (although we might have bent the rule a few times in the past)
If not, it's not a big deal to let it wait for the next release though.
Personally, I'd rather wait. Jan
participants (3)
-
Ján Tomko -
Michal Privoznik -
Roman Bogorodskiy