Re: [libvirt] [PATCH 2/2] Use posix_fallocate() to allocate disk space on supported systems
On Thu, Mar 19, 2009 at 12:45:25PM +0530, Amit Shah wrote:
Make use of the safezero() function to allocate disk space instead
of safewrite() to write zeros. The safezero() function will use
posix_fallocate() on supported systems.
If progress activity is not requested (current behaviour), the new
safezero() function will allocate the file in one go.
If progress activity is requested, allocate in 512MiB chunks.
ACK, this looks good, assuming we change the non-fallocate() safezero()
impl to not allocate huge chunks of memory.
The 'static int track_allocation_progress' is fine as you have it - it
is a useful reminder that we need to expose this functionality via the
API, and we can move it as needed at that time.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|