On Fri, Jul 02, 2021 at 07:23:57AM -0400, Cleber Rosa wrote:
On Thu, Jul 1, 2021 at 2:05 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
Overall, I'm more enthusiastic about writing tests in Python than Perl, for the long term, but would also potentially like to write tests in Go too.
I'm wondering if we can't bridge the divide between what we have already in libvirt-tck, and what you're bringing to the table with avocado here. While we've not done much development with the TCK recently, there are some very valuable tests there, especially related to firewall support and I don't fancy rewriting them.
Thus my suggestion is that we:
- Put this avocado code into the libvirt-tck repository, with focus on the supporting infra for making it easy to write Python tests
One drawback would be the various supporting files for a perl+Python package. I mean, a Makefile.PL and a setup.py in the same repo can be a source of confusion. But, maybe I'm overreacting.
I don't think that's an issue. We're not actually trying to ship Perl modules or Python modules, we're providing an application that happens to use some Perl and Python and $whatever code. As such, I would not use either Makefile.PL or setup.py for this task. Instead I think we should just use meson to deal with it all, keeping it all private to the application. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|