On 02/27/2013 08:26 PM, TJ wrote:
On 28/02/13 03:15, Eric Blake wrote:
On 02/27/2013 07:18 PM, TJ wrote:
Signed-off-by: TJ <linux@iam.tj>
Can you use a full legal name, instead of a two-letter pseudonym?
TJ is my full name.
Whatever. It might be the pseudonym you prefer in open source, but I seriously doubt you come from a culture where your parents did not grant you a surname.
Your commit message is missing some substance, such as a summary of what is being added.
The first line of the commit message is in the email subject, and describes the commit.
"conf: DHCP - add state for DHCP Relay and On/Off switch"
The summary is nice, but we also want to see a sample of the XML that you are adding. See, for example, commit 1716e7a6.
Your patch is whitespace-damaged. Did you sent it with 'git send-email'?
Yes. It barfed first time and added 9 emails into one post! Second time it seemed to be OK.
I only see 2-10 on the second attempt. I didn't see a resend of 1. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org