27 Nov
2013
27 Nov
'13
2:25 p.m.
On 11/26/2013 11:43 PM, Osier Yang wrote:
On 27/11/13 12:00, Eric Blake wrote:
When attempting to backport gluster pools to an older version where there is no VIR_STRDUP, I got a crash from calling strdup(,NULL). Rather than relying on the current else branch safely doing nothing when there is no fd, it is easier to just skip it. While at it, there's no need to explicitly set perms.label to NULL after a VIR_FREE().
* src/storage/storage_backend.c (virStorageBackendUpdateVolTargetInfoFD): Minor optimization.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
ACK
Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org