- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses
by Michal Privoznik 18 Apr '19

18 Apr '19

This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg01111.html which caused regression to which a proposed fix is here: https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html One of the selling points was that having this check in virDomainDefCompatibleDevice() will fix the problem across all drivers. Well, turns out, some drivers don't care (e.g. lxc) and some have a different workflow and thus don't need that check. Michal Prívozník (4): conf: Expose virDomainSCSIDriveAddressIsUsed qemuhotplugtest: Don't plug a SCSI disk at unit 7 qemu_hotplug: Check for duplicate drive addresses Revert "domain_conf: check device address before attach" src/conf/domain_conf.c | 11 +---------- src/conf/domain_conf.h | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 6 ++++++ tests/qemuhotplugtest.c | 2 +- .../qemuhotplug-disk-scsi-2.xml | 2 +- ...-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++-- 7 files changed, 16 insertions(+), 14 deletions(-) -- 2.21.0

3 10

[libvirt] [PATCH 0/3] qemu: more firmware path improvements
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Daniel P. Berrangé (3): m4: allow default firmware list to be empty rpm: disable default firmware list on RHEL and Fedora >= 31 qemu: stop including real paths in nvram config option libvirt.spec.in | 6 +++++- m4/virt-loader-nvram.m4 | 16 ++++++++++------ src/qemu/qemu.conf | 11 +++++------ 3 files changed, 20 insertions(+), 13 deletions(-) -- 2.20.1

2 4

[libvirt] Why virsh domxml-to-native qemu-argv changes PCI slot number
by Tal Attaly 18 Apr '19

18 Apr '19

Hi, I have bridge type interface defined with slot 3 - <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> but after running virsh domxml-to-native qemu-argv I get slot 2- -netdev tap,fd=21,id=hostnet0 -device e1000,netdev=hostnet0,id=net0,mac=f2:ff:ff:ff:ff:07,bus=pci.0,addr=0x2 Any idea why it's happen and how to keep the slot number? Libvirt version is 4.5.0 here is the full domain XML - <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> <name>vm1</name> <uuid>dbad303e-fc1b-454e-8861-712bf1766a64</uuid> <memory unit='KiB'>4194304</memory> <currentMemory unit='KiB'>4194304</currentMemory> <vcpu placement='static'>1</vcpu> <os> <type arch='x86_64' machine='pc-i440fx-2.12'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact' check='partial'> <model fallback='allow'>SandyBridge-IBRS</model> </cpu> <clock offset='utc'> <timer name='rtc' tickpolicy='catchup'/> <timer name='pit' tickpolicy='delay'/> <timer name='hpet' present='no'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <pm> <suspend-to-mem enabled='no'/> <suspend-to-disk enabled='no'/> </pm> <devices> <emulator>/qemu/x86_64-softmmu/qemu-system-x86_64</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/vm.img'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> <controller type='usb' index='0' model='ich9-ehci1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x2'/> </controller> <controller type='ide' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='bridge'> <mac address='f2:ff:ff:ff:ff:07'/> <source bridge='br0:'/> <model type='e1000'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> <serial type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='isa-serial' port='0'> <model name='isa-serial'/> </target> </serial> <console type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='serial' port='0'/> </console> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <memballoon model='virtio'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </memballoon> </devices> <qemu:commandline> <qemu:env name='CONFIG_FILE' value='/opt/cfg/qemu.cfg'/> </qemu:commandline> </domain> Thanks, Tal

3 2

[libvirt] [PATCH v1 0/4] RFC CPU Model Comparison via QMP
by Collin Walling 18 Apr '19

18 Apr '19

This is a preview of the CPU comparison (and soon baseline) patches. Comments are welcome on all aspects, as they will help guide the development of the baseline implementation. The first couple of patches simply refactor code. The first introduces an XML -> CPU def helper to be used to extract the CPU definition prior to sending it to the comparison functions. The second patch refactors some of the code from CPU model expansion to be later used by comparison and baseline. Currently, only one of the functions from the refactoring is reused for comparison. The other two will come into play when baseline is implemented. The third is the typical "new capability" patch to introduce query-cpu-model-comparison and test data for s390x. The last patch implements the qemuMonitorJSON function for query-cpu-model-comparison and hooks it up to virsh hypervisor-cpu-compare. This is posted as an RFC to make sure these patches are set in the correct direction before tackling the baseline patches. Thanks! Collin Walling (4): cpu_conf: xml to cpu definition parse helper qemu: monitor: helper functions for CPU models qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON qemu: monitor: implement query-cpu-model-comparison src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 6 + src/cpu/cpu.c | 14 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 49 ++++ src/qemu/qemu_capabilities.h | 10 + src/qemu/qemu_driver.c | 10 + src/qemu/qemu_monitor.c | 22 ++ src/qemu/qemu_monitor.h | 10 + src/qemu/qemu_monitor_json.c | 223 +++++++++++++++--- src/qemu/qemu_monitor_json.h | 11 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + 17 files changed, 343 insertions(+), 49 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH] testQemuGetLatestCaps: Lower chances of hash collision
by Michal Privoznik 18 Apr '19

18 Apr '19

This function creates a list of paths to the latest capabilities and returns them in a hash table where key is an arch string and value is the path. Well, we know how many arches there are so might as well use that as initial hash size. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/testutilsqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index bce847ce5e..2d6a84d017 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -879,7 +879,7 @@ testQemuGetLatestCaps(void) virHashTablePtr capslatest; size_t i; - if (!(capslatest = virHashCreate(4, virHashValueFree))) + if (!(capslatest = virHashCreate(ARRAY_CARDINALITY(archs), virHashValueFree))) goto error; VIR_TEST_VERBOSE("\n"); -- 2.21.0

1 0

[libvirt] [PATCH] qemu.conf: Make nvram list obsolete
by Michal Privoznik 18 Apr '19

18 Apr '19

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..ecde8f0181 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,8 @@ # Location of master nvram file # +# This is now obsoleted by firmware auto selection feature. +# Prefer that before this. # When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain -- 2.21.0

2 1

[libvirt] [PATCH v2 00/11] conf: partial net model enum conversion
by Cole Robinson 18 Apr '19

18 Apr '19

v1 here: https://www.redhat.com/archives/libvir-list/2019-January/msg00763.html Changes since v1: - patch #7, case insensitive model input comparison - Add xml2xml testing - compile tested on freebsd12.0 This series partially converts the net->model value from a string to an enum. We wrap the existing ->model string in accessor functions, rename it to ->modelstr, add a ->model enum, and convert internal driver usage bit by bit. At the end, all driver code that is acting on specific network model values is comparing against an enum, not a string. This is only partial because of xen/libxl/xm and qemu drivers, which if they don't know anything particular about the model string will just place it on the qemu command line/xen config and see what happens. So basically if I were to pass in <model type='idontexist'/> qemu would turn that into -device idontexist,... That behavior is untouched by this series, as fully unwinding that will take some more work: * Figuring out all reasonable qemu + xen values that could actually result in a working VM config, and adding them to the enum * Figuring out a long term plan for disabling passthrough entirely. There's some discussion in the v1 thread about this. Some caveats: * vz driver is not compile tested. What's the sdk magic to actually get this building? * net model enum lookup is done case insensitive. this is to maintain the behavior of the vmx and virtualbox drivers, but it's different than all our other enum usage. Cole Robinson (11): tests: Add several net model passthrough tests conf: net: Add wrapper functions for <model> value conf: net: Rename 'model' to 'modelstr' conf: net: Add model enum, and netfront value vz: convert to net model enum bhyve: convert to net model enum qemu: Partially convert to net model enum conf: Make net model enum compare case insensitive vmx: convert to net model enum vbox: Convert to net enum model conf: Add VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING src/bhyve/bhyve_command.c | 15 +-- src/bhyve/bhyve_parse_command.c | 10 +- src/conf/domain_conf.c | 111 ++++++++++++++---- src/conf/domain_conf.h | 35 +++++- src/libvirt_private.syms | 4 + src/libxl/libxl_conf.c | 8 +- src/libxl/libxl_domain.c | 1 + src/qemu/qemu_command.c | 13 +- src/qemu/qemu_domain.c | 32 +++-- src/qemu/qemu_domain_address.c | 13 +- src/qemu/qemu_driver.c | 14 ++- src/qemu/qemu_hotplug.c | 15 ++- src/qemu/qemu_parse_command.c | 5 +- src/security/virt-aa-helper.c | 3 +- src/vbox/vbox_common.c | 29 ++--- src/vmx/vmx.c | 55 ++++----- src/vz/vz_driver.c | 7 +- src/vz/vz_sdk.c | 17 ++- src/xenconfig/xen_common.c | 31 ++--- src/xenconfig/xen_sxpr.c | 30 ++--- tests/qemuxml2argvdata/net-many-models.args | 39 ++++++ tests/qemuxml2argvdata/net-many-models.xml | 38 ++++++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/net-many-models.xml | 53 +++++++++ tests/qemuxml2xmltest.c | 1 + tests/xlconfigdata/test-net-fakemodel.cfg | 24 ++++ tests/xlconfigdata/test-net-fakemodel.xml | 39 ++++++ tests/xlconfigtest.c | 1 + .../test-paravirt-net-fakemodel.cfg | 13 ++ .../test-paravirt-net-fakemodel.xml | 40 +++++++ .../test-paravirt-net-modelstr.cfg | 13 ++ tests/xmconfigtest.c | 1 + .../xml2sexpr-fv-net-many-models.sexpr | 1 + .../xml2sexpr-fv-net-many-models.xml | 43 +++++++ tests/xml2sexprtest.c | 1 + 35 files changed, 586 insertions(+), 170 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-many-models.args create mode 100644 tests/qemuxml2argvdata/net-many-models.xml create mode 100644 tests/qemuxml2xmloutdata/net-many-models.xml create mode 100644 tests/xlconfigdata/test-net-fakemodel.cfg create mode 100644 tests/xlconfigdata/test-net-fakemodel.xml create mode 100644 tests/xmconfigdata/test-paravirt-net-fakemodel.cfg create mode 100644 tests/xmconfigdata/test-paravirt-net-fakemodel.xml create mode 100644 tests/xmconfigdata/test-paravirt-net-modelstr.cfg create mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.sexpr create mode 100644 tests/xml2sexprdata/xml2sexpr-fv-net-many-models.xml -- 2.20.1

3 24

[libvirt] [PATCH v3 0/4] Don't pm suspend guest if it's unable to wake up
by Michal Privoznik 17 Apr '19

17 Apr '19

This is v3 of: https://www.redhat.com/archives/libvir-list/2019-April/msg00690.html I've taken Daniel's patches and reworked them. Diff to v2: - Patches 1-2/3 are split into three patches - Capability is checked for when querying other capabilities - Fixed a small security issue in 3/3 Daniel Henrique Barboza (2): qemu_capabilities: Add QEMU_CAPS_QUERY_CURRENT_MACHINE qemuDomainPMSuspendForDuration: check for QEMU_CAPS_PM_WAKEUP_SUPPORT Michal Prívozník (2): qemu_monitor: Introduce handler for 'query-current-machine' command qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT src/qemu/qemu_capabilities.c | 26 ++++++++++ src/qemu/qemu_capabilities.h | 4 ++ src/qemu/qemu_driver.c | 21 ++++++++ src/qemu/qemu_monitor.c | 10 ++++ src/qemu/qemu_monitor.h | 9 ++++ src/qemu/qemu_monitor_json.c | 50 +++++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ .../caps_4.0.0.riscv32.replies | 11 ++++ .../caps_4.0.0.riscv32.xml | 2 + .../caps_4.0.0.riscv64.replies | 11 ++++ .../caps_4.0.0.riscv64.xml | 2 + .../caps_4.0.0.x86_64.replies | 11 ++++ .../caps_4.0.0.x86_64.xml | 2 + 13 files changed, 164 insertions(+) -- 2.21.0

3 14

[libvirt] [PATCH v2 0/3] Add 'label' arg to VIR_ENUM_IMPL
by Cole Robinson 17 Apr '19

17 Apr '19

4 9

[libvirt] On the content of 'nvram' section in /etc/libvirt/qemu.conf
by Kashyap Chamarthy 17 Apr '19

17 Apr '19

I learnt from Dan Berrangé that the 'nvram' section in `/etc/libvirt/qemu.conf` will now go away in light of all the work done in QEMU ('firmware.json', et al) and libvirt (the firmware auto-selection). But for my own education, can anyone confirm that the current content of 'nvram' is out of date in terms of mapping of OVMF binaries to their corresponding variable store ("VARS") files? Let's see what I mean. On my Fedora 29 box, in `/etc/libvirt/qemu.conf`, I see the following mapping of OVMF binaries to their correspoindg "VARS" file under the 'nvram' section: #nvram = [ # "/usr/share/OVMF/OVMF_CODE.fd:/usr/share/OVMF/OVMF_VARS.fd", # "/usr/share/OVMF/OVMF_CODE.secboot.fd:/usr/share/OVMF/OVMF_VARS.fd", # "/usr/share/AAVMF/AAVMF_CODE.fd:/usr/share/AAVMF/AAVMF_VARS.fd", # "/usr/share/AAVMF/AAVMF32_CODE.fd:/usr/share/AAVMF/AAVMF32_VARS.fd" #] Now let's enumerate the content of 'edk2-ovmf' package: $> rpm -ql edk2-ovmf /usr/share/OVMF /usr/share/OVMF/OVMF_CODE.fd /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_VARS.fd /usr/share/OVMF/OVMF_VARS.secboot.fd /usr/share/OVMF/UefiShell.iso /usr/share/doc/edk2-ovmf /usr/share/doc/edk2-ovmf/README /usr/share/doc/edk2-ovmf/ovmf-whitepaper-c770f8c.txt /usr/share/edk2 /usr/share/edk2/ovmf /usr/share/edk2/ovmf/EnrollDefaultKeys.efi /usr/share/edk2/ovmf/OVMF_CODE.fd /usr/share/edk2/ovmf/OVMF_CODE.secboot.fd /usr/share/edk2/ovmf/OVMF_VARS.fd /usr/share/edk2/ovmf/OVMF_VARS.secboot.fd /usr/share/edk2/ovmf/Shell.efi /usr/share/edk2/ovmf/UefiShell.iso /usr/share/licenses/edk2-ovmf /usr/share/licenses/edk2-ovmf/LICENSE.openssl /usr/share/licenses/edk2-ovmf/License.txt There is the /usr/share/edk2/ovmf/OVMF_VARS.secboot.fd file (which comes with the default UEFI keys enrolled). So, the mapping of OVMF binary to VARS file in the earlier mentioned 'nvram' section should have been: /usr/share/OVMF/OVMF_CODE.secboot.fd:/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd Yes? -- /kashyap

2 2