- Devel - libvirt List Archives

[libvirt] [PATCH v2 1/1] tests/virhostdevtest: remove virHostdevHostSupportsPassthroughKVM
by Daniel Henrique Barboza 03 May '19

03 May '19

virhostdevtest is using pci mock to emulate all PCI attach/detach operations. This means that that this test does not rely on KVM support of the host anymore and the tests in this file shouldn't be affected by it. Suggested-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- tests/virhostdevtest.c | 61 +++++++++--------------------------------- 1 file changed, 12 insertions(+), 49 deletions(-) diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 4e067b10d1..20eaca82e0 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -126,37 +126,6 @@ myInit(void) return -1; } -# if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -# else -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - return false; -} -# endif - static int testVirHostdevPreparePCIHostdevs_unmanaged(void) { @@ -483,12 +452,10 @@ testVirHostdevRoundtripUnmanaged(const void *opaque ATTRIBUTE_UNUSED) if (testVirHostdevDetachPCINodeDevice() < 0) goto out; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_unmanaged() < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_unmanaged() < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_unmanaged() < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_unmanaged() < 0) + goto out; if (testVirHostdevReAttachPCINodeDevice() < 0) goto out; @@ -512,12 +479,10 @@ testVirHostdevRoundtripManaged(const void *opaque ATTRIBUTE_UNUSED) { int ret = -1; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_managed(false) < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_managed(false) < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_managed(false) < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_managed(false) < 0) + goto out; ret = 0; @@ -544,12 +509,10 @@ testVirHostdevRoundtripMixed(const void *opaque ATTRIBUTE_UNUSED) if (testVirHostdevDetachPCINodeDevice() < 0) goto out; - if (virHostdevHostSupportsPassthroughKVM()) { - if (testVirHostdevPreparePCIHostdevs_managed(true) < 0) - goto out; - if (testVirHostdevReAttachPCIHostdevs_managed(true) < 0) - goto out; - } + if (testVirHostdevPreparePCIHostdevs_managed(true) < 0) + goto out; + if (testVirHostdevReAttachPCIHostdevs_managed(true) < 0) + goto out; if (testVirHostdevReAttachPCINodeDevice() < 0) goto out; -- 2.20.1

2 1

[libvirt] [PATCH] qemuConnectOpen: Drop unused @cfg and simplify
by Michal Privoznik 03 May '19

03 May '19

After 65a372d6e0 the @cfg variable is no longer used. This means we can drop it and therefore drop 'cleanup' label with it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c072bed1ce..30945d1545 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1094,44 +1094,37 @@ static virDrvOpenStatus qemuConnectOpen(virConnectPtr conn, virConfPtr conf ATTRIBUTE_UNUSED, unsigned int flags) { - virQEMUDriverConfigPtr cfg = NULL; - virDrvOpenStatus ret = VIR_DRV_OPEN_ERROR; virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); if (qemu_driver == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("qemu state driver is not active")); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } - cfg = virQEMUDriverGetConfig(qemu_driver); - if (virQEMUDriverIsPrivileged(qemu_driver)) { if (STRNEQ(conn->uri->path, "/system") && STRNEQ(conn->uri->path, "/session")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unexpected QEMU URI path '%s', try qemu:///system"), conn->uri->path); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } } else { if (STRNEQ(conn->uri->path, "/session")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("unexpected QEMU URI path '%s', try qemu:///session"), conn->uri->path); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } } if (virConnectOpenEnsureACL(conn) < 0) - goto cleanup; + return VIR_DRV_OPEN_ERROR; conn->privateData = qemu_driver; - ret = VIR_DRV_OPEN_SUCCESS; - cleanup: - virObjectUnref(cfg); - return ret; + return VIR_DRV_OPEN_SUCCESS; } static int qemuConnectClose(virConnectPtr conn) -- 2.21.0

2 1

[libvirt] [PATCH v2 0/8] CPU Model Baseline and Comparison for s390x
by walling＠linux.ibm.com 02 May '19

02 May '19

From: Collin Walling <walling(a)linux.ibm.com> Changelog: v1 - introduce baseline - split patches into small chunks - free'd lingering qemuMonitorCPUModelInfo pointer - when converting from virCPUDef -> virJSON, consider feature policy FORCED for enabled This is the second iteration of the CPU Model Comparison and Baseline patches for s390x. The previous version only showed comparison as a preview, and it can be found here: https://www.redhat.com/archives/libvir-list/2019-April/msg01046.html The first patch pull some code out of the CPU Model Expansion JSON function so that it can be later used for the Comparison and Baseline JSON functions. The rest of the patches follow this sequence: - introduce JSON monitor functions - introduce capability and update test files - hook up monitor functions to virsh command Thanks @Daniel, I added your Tested-by where I felt made most sense. Collin Walling (8): qemu_monitor: helper functions for CPU models qemu_monitor: implement query-cpu-model-baseline qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_BASELINE qemu_driver: hook up query-cpu-model-baseline qemu_monitor: implement query-cpu-model-comparison qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON cpu_conf: xml to cpu definition parse helper qemu_driver: hook up query-cpu-model-comparison src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 6 + src/cpu/cpu.c | 14 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 156 +++++++++++++ src/qemu/qemu_capabilities.h | 20 ++ src/qemu/qemu_driver.c | 38 +++ src/qemu/qemu_monitor.c | 44 ++++ src/qemu/qemu_monitor.h | 18 ++ src/qemu/qemu_monitor_json.c | 285 ++++++++++++++++++++--- src/qemu/qemu_monitor_json.h | 20 ++ tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 + 17 files changed, 595 insertions(+), 49 deletions(-) -- 2.7.4

3 18

[libvirt] [jenkins-ci PATCH] lcitool: use slirp networking if running non-root
by Daniel P. Berrangé 02 May '19

02 May '19

The virtual networks are only available to the system libvirt instance. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 0f60704..9d17f1a 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -511,9 +511,12 @@ class Application: facts["install_disk_size"], facts["install_storage_pool"], ) - network_arg = "network={},model=virtio".format( - facts["install_network"], - ) + if os.geteuid() == 0: + network_arg = "network={},model=virtio".format( + facts["install_network"], + ) + else: + network_arg = "user,model=virtio" # Different operating systems require different configuration # files for unattended installation to work, but some operating -- 2.21.0

1 1

[libvirt] [jenkins-ci PATCH] lcitool: check for virt-install existing
by Daniel P. Berrangé 02 May '19

02 May '19

This improves: $ ./lcitool install libvirt-fedora-29 ./lcitool: Failed to install 'libvirt-fedora-29': [Errno 2] No such file or directory To $ ./lcitool install libvirt-fedora-29 ./lcitool: Cannot find virt-install in $PATH Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index 0f60704..3be16c8 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -37,6 +37,23 @@ except ImportError: class Util: + @staticmethod + def which(program): + def is_exe(fpath): + return os.path.isfile(fpath) and os.access(fpath, os.X_OK) + + fpath, fname = os.path.split(program) + if fpath: + if is_exe(program): + return program + else: + for path in os.environ["PATH"].split(os.pathsep): + exe_file = os.path.join(path, program) + if is_exe(exe_file): + return exe_file + + return None + @staticmethod def get_base(): return os.path.dirname(os.path.abspath(__file__)) @@ -534,8 +551,12 @@ class Application: # a kernel argument extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) + vipath = Util.which("virt-install") + if vipath is None: + raise Exception("Cannot find virt-install in $PATH") + cmd = [ - "virt-install", + vipath, "--name", host, "--location", facts["install_url"], "--virt-type", facts["install_virt_type"], -- 2.21.0

2 1

[libvirt] [PATCH v3] qemu.conf: Make nvram list obsolete
by Michal Privoznik 02 May '19

02 May '19

Now that libvirt has firmware auto selection feature the nvram config knob is more or less obsolete. It still makes sense in cases where distro users are using does not provide FW descriptor files, therefore I'm not removing it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu.conf | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 334b4cd4ee..5a85789d81 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -740,6 +740,14 @@ # Location of master nvram file # +# This configuration option is obsolete. Libvirt will follow the +# QEMU firmware metadata specification to automatically locate +# firmware images. See docs/interop/firmware.json in the QEMU +# source tree. These metadata files are distributed alongside any +# firmware images intended for use with QEMU. +# +# ------------------------------------------ +# # When a domain is configured to use UEFI instead of standard # BIOS it may use a separate storage for UEFI variables. If # that's the case libvirt creates the variable store per domain -- 2.21.0

2 1

[libvirt] [PATCH 1/1] util/virhostdev: consolidate duplicated KVM support code
by Daniel Henrique Barboza 02 May '19

02 May '19

tests/virhostdevtest.c implements a function called 'virHostdevHostSupportsPassthroughKVM', that is equal to 'qemuHostdevHostSupportsPassthroughLegacy' that is declared inside qemu/qemu_hostdev.c. This patch removes the duplicated code from both files and and puts it inside util/virhostdev.c, under the name virHostdev...KVM, which represents what the code does better than using 'Legacy'. Based-on-work-of: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 6 +++--- src/qemu/qemu_hostdev.c | 34 +--------------------------------- src/qemu/qemu_hostdev.h | 1 - src/util/virhostdev.c | 31 +++++++++++++++++++++++++++++++ src/util/virhostdev.h | 1 + tests/virhostdevtest.c | 31 ------------------------------- 8 files changed, 38 insertions(+), 69 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a03cf0b645..a6747684ea 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2044,6 +2044,7 @@ virHostCPUStatsAssign; # util/virhostdev.h virHostdevFindUSBDevice; +virHostdevHostSupportsPassthroughKVM; virHostdevIsMdevDevice; virHostdevIsSCSIDevice; virHostdevManagerGetDefault; diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a0b2ca73fb..515db0112f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5152,7 +5152,7 @@ static int virQEMUCapsFillDomainDeviceHostdevCaps(virQEMUCapsPtr qemuCaps, virDomainCapsDeviceHostdevPtr hostdev) { - bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy(); + bool supportsPassthroughKVM = virHostdevHostSupportsPassthroughKVM(); bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); hostdev->supported = VIR_TRISTATE_BOOL_YES; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b2ac737d1f..c02482337a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13283,7 +13283,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, int ret = -1; virNodeDeviceDefPtr def = NULL; char *xml = NULL; - bool legacy = qemuHostdevHostSupportsPassthroughLegacy(); + bool kvm = virHostdevHostSupportsPassthroughKVM(); bool vfio = qemuHostdevHostSupportsPassthroughVFIO(); virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; @@ -13310,7 +13310,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, if (!driverName) { if (vfio) { driverName = "vfio"; - } else if (legacy) { + } else if (kvm) { driverName = "kvm"; } else { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", @@ -13329,7 +13329,7 @@ qemuNodeDeviceDetachFlags(virNodeDevicePtr dev, } virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_VFIO); } else if (STREQ(driverName, "kvm")) { - if (!legacy) { + if (!kvm) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("KVM device assignment is currently not " "supported on this system")); diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 4eb3f1d7f1..b6cb4d0980 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -132,44 +132,12 @@ qemuHostdevHostSupportsPassthroughVFIO(void) } -#if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -bool -qemuHostdevHostSupportsPassthroughLegacy(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -#else -bool -qemuHostdevHostSupportsPassthroughLegacy(void) -{ - return false; -} -#endif - - static bool qemuHostdevPreparePCIDevicesCheckSupport(virDomainHostdevDefPtr *hostdevs, size_t nhostdevs, virQEMUCapsPtr qemuCaps) { - bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy(); + bool supportsPassthroughKVM = virHostdevHostSupportsPassthroughKVM(); bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); size_t i; diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h index 41f254ab81..be6faa2c35 100644 --- a/src/qemu/qemu_hostdev.h +++ b/src/qemu/qemu_hostdev.h @@ -25,7 +25,6 @@ # include "qemu_conf.h" # include "domain_conf.h" -bool qemuHostdevHostSupportsPassthroughLegacy(void); bool qemuHostdevHostSupportsPassthroughVFIO(void); int qemuHostdevUpdateActiveMediatedDevices(virQEMUDriverPtr driver, diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 19ae001971..872528fdb2 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -2245,3 +2245,34 @@ virHostdevUpdateActiveDomainDevices(virHostdevManagerPtr mgr, return 0; } + +#if HAVE_LINUX_KVM_H +# include <linux/kvm.h> +bool +virHostdevHostSupportsPassthroughKVM(void) +{ + int kvmfd = -1; + bool ret = false; + + if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) + goto cleanup; + +# ifdef KVM_CAP_IOMMU + if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) + goto cleanup; + + ret = true; +# endif + + cleanup: + VIR_FORCE_CLOSE(kvmfd); + + return ret; +} +#else +bool +virHostdevHostSupportsPassthroughKVM(void) +{ + return false; +} +#endif diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h index 7263f320a2..32fa36cdef 100644 --- a/src/util/virhostdev.h +++ b/src/util/virhostdev.h @@ -203,4 +203,5 @@ int virHostdevPCINodeDeviceReset(virHostdevManagerPtr mgr, virPCIDevicePtr pci) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); +bool virHostdevHostSupportsPassthroughKVM(void); #endif /* LIBVIRT_VIRHOSTDEV_H */ diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index 4e067b10d1..1258338949 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -126,37 +126,6 @@ myInit(void) return -1; } -# if HAVE_LINUX_KVM_H -# include <linux/kvm.h> -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - int kvmfd = -1; - bool ret = false; - - if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) - goto cleanup; - -# ifdef KVM_CAP_IOMMU - if ((ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_IOMMU)) <= 0) - goto cleanup; - - ret = true; -# endif - - cleanup: - VIR_FORCE_CLOSE(kvmfd); - - return ret; -} -# else -static bool -virHostdevHostSupportsPassthroughKVM(void) -{ - return false; -} -# endif - static int testVirHostdevPreparePCIHostdevs_unmanaged(void) { -- 2.20.1

2 1

[libvirt] [PATCH] docs: Update drivers page to link to storage.html
by John Ferlan 01 May '19

01 May '19

Rather than duplicate a list of storage pool backends on the drivers.html page, let's just link directly to the storage driver page similar to how the node device driver is done. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- docs/drivers.html.in | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/docs/drivers.html.in b/docs/drivers.html.in index a66651df2f..4539eedbcd 100644 --- a/docs/drivers.html.in +++ b/docs/drivers.html.in @@ -6,7 +6,7 @@ <ul> <li><a href="#hypervisor">Hypervisor drivers</a></li> - <li><a href="#storage">Storage drivers</a></li> + <li><a href="storage.html">Storage drivers</a></li> <li><a href="drvnodedev.html">Node device driver</a></li> </ul> @@ -39,19 +39,5 @@ <li><a href="drvbhyve.html">Bhyve</a> - The BSD Hypervisor</li> </ul> - <h2><a id="storage">Storage drivers</a></h2> - - <ul> - <li><a href="storage.html#StorageBackendDir">Directory backend</a></li> - <li><a href="storage.html#StorageBackendFS">Local filesystem backend</a></li> - <li><a href="storage.html#StorageBackendNetFS">Network filesystem backend</a></li> - <li><a href="storage.html#StorageBackendLogical">Logical Volume Manager (LVM) backend</a></li> - <li><a href="storage.html#StorageBackendDisk">Disk backend</a></li> - <li><a href="storage.html#StorageBackendISCSI">iSCSI backend</a></li> - <li><a href="storage.html#StorageBackendSCSI">SCSI backend</a></li> - <li><a href="storage.html#StorageBackendMultipath">Multipath backend</a></li> - <li><a href="storage.html#StorageBackendRBD">RBD (RADOS Block Device) backend</a></li> - <li><a href="storage.html#StorageBackendSheepdog">Sheepdog backend</a></li> - </ul> </body> </html> -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Disable console device detach from live mode.
by Julio Faracco 30 Apr '19

30 Apr '19

Console Char devices cannot be attached as qemuDomainChrRemove() function suggests. After moved to async mode, qemuDomainRemoveChrDevice() is not part of the removal process. So, we need to check if device is able to be detached before calling removal procedures. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1447183 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_hotplug.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f3c5f44a23..2c65df6d7b 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -5844,6 +5844,14 @@ qemuDomainDetachDeviceChr(virQEMUDriverPtr driver, goto cleanup; } + if (tmpChr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE && + tmpChr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("detaching serial console is not supported")); + goto cleanup; + } + + /* guestfwd channels are not really -device rather than * -netdev. We need to treat them slightly differently. */ guestfwd = tmpChr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && -- 2.20.1

1 0

[libvirt] Entering freeze for libvirt-5.3.0
by Daniel Veillard 30 Apr '19

30 Apr '19

One day late but RC1 is tagged in git, and I pushed the signed tarball and rpms to the new usual place, it's the same dir, same content, just though https https://libvirt.org/sources/ Looks fine in my minimal testing, but give it a try especially on diverse system and architecture. The fact that https://ci.centos.org/view/libvirt/ is all green except for one edge case is also a good indication. So assuming everything goes as planned, I think RC2 should be cut on Tuesday and we can plan for a May 2nd final release is everything goes well. Give it a good testing, thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1