- Devel - libvirt List Archives

[libvirt] [PATCH] virStorageSourceChainHasManagedPR: Check propely
by Michal Privoznik 21 Jun '19

21 Jun '19

In the virStorageSourceChainHasManagedPR() function we iterate over whole backing chain trying to determine if one of the layers has managed PR configured. But due to a typo we in fact check the top layer only. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/util/virstoragefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 2b1c0a5b8e..f7495ab6da 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2083,7 +2083,7 @@ virStorageSourceChainHasManagedPR(virStorageSourcePtr src) virStorageSourcePtr n; for (n = src; virStorageSourceIsBacking(n); n = n->backingStore) { - if (virStoragePRDefIsManaged(src->pr)) + if (virStoragePRDefIsManaged(n->pr)) return true; } -- 2.21.0

2 1

[libvirt] [PATCH v2 0/7] Finish support for IA32_ARCH_CAPABILITIES MSR features
by Jiri Denemark 21 Jun '19

21 Jun '19

As promised in v1 this series contains a few additional patches which limit usage of MSR features to QEMU that supports "unavailable-features" CPU property. This series intentionally enables MSR features for all QEMU versions before restricting the usage to make this restriction more visible in the test results. Version 2: - all but 2 patches from version 1 were pushed - 5 new patches Jiri Denemark (7): conf: Introduce virCPUDefCheckFeatures cpu_x86: Turn virCPUx86DataIteratorInit into a function cpu_x86: Introduce virCPUx86FeatureIsMSR cpu_x86: Read CPU features from IA32_ARCH_CAPABILITIES MSR cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR features qemu: Forbid MSR features with old QEMU qemu: Drop MSR features from host-model with old QEMU src/conf/cpu_conf.c | 33 +++++++ src/conf/cpu_conf.h | 6 ++ src/cpu/cpu_x86.c | 96 +++++++++++++++++-- src/cpu/cpu_x86.h | 3 + src/cpu_map/x86_features.xml | 20 ++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 16 ++++ src/qemu/qemu_process.c | 29 +++++- .../x86_64-cpuid-Core-i7-7600U-enabled.xml | 1 + .../x86_64-cpuid-Core-i7-7600U-json.xml | 1 + ...86_64-cpuid-Xeon-Platinum-8268-enabled.xml | 1 + .../x86_64-cpuid-Xeon-Platinum-8268-guest.xml | 4 + .../x86_64-cpuid-Xeon-Platinum-8268-host.xml | 4 + .../x86_64-cpuid-Xeon-Platinum-8268-json.xml | 3 + .../qemu_4.1.0.x86_64.xml | 1 + 15 files changed, 207 insertions(+), 13 deletions(-) -- 2.22.0

3 17

[libvirt] [PATCH] rpc: add $(SASL_CFLAGS) to libvirt_net_rpc_server_la_CFLAGS
by Daniel P. Berrangé 21 Jun '19

21 Jun '19

The files for libvirt-net-rpc-server.la refernce the sasl/sasl.h system header but never used the $(SASL_CFLAGS) variable. This was never noticed previously because the $(AVAHI_CLFAGS) were set and these typically pulled in the same include directory. When mDNS/Avahi support was removed this exposed the bug which caused FreeBSD builds to break as /usr/local/include was no longer searched for headers. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix src/rpc/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index e5b830605a..b8ca53c69a 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -111,6 +111,7 @@ libvirt_net_rpc_server_la_SOURCES = \ libvirt_net_rpc_server_la_CFLAGS = \ $(DBUS_CFLAGS) \ $(XDR_CFLAGS) \ + $(SASL_CFLAGS) \ $(AM_CFLAGS) \ $(NULL) libvirt_net_rpc_server_la_LDFLAGS = \ -- 2.21.0

1 0

[libvirt] [PATCH 0/5] cgroups v2 fixes and improvements
by Pavel Hrdina 21 Jun '19

21 Jun '19

Pavel Hrdina (5): util: vircgroup: pass parent cgroup into virCgroupDetectControllersCB util: vircgroup: improve controller detection util: vircgroupv2: use any controller to create thread directory util: vircgroupv2: enable CPU controller only if it's available util: vircgroupv2: don't error out if enabling controller fails src/util/vircgroup.c | 32 ++++++++++++++++---------------- src/util/vircgroupbackend.h | 3 ++- src/util/vircgroupv1.c | 3 ++- src/util/vircgroupv2.c | 36 ++++++++++++++++++++++++------------ 4 files changed, 44 insertions(+), 30 deletions(-) -- 2.21.0

2 11

[libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses
by Ilias Stamatis 21 Jun '19

21 Jun '19

testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific guest interface in an attempt to return unique addresses *most of the time*. Additionally, properly handle IPv6 networks which were previously ignored completely. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 44 +++++++++++++++++++++++++++++++++++++----- 1 file changed, 39 insertions(+), 5 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2a0ffbc6c5..21bd95941e 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3414,6 +3414,10 @@ static int testDomainBlockStats(virDomainPtr domain, return ret; } + +static virNetworkObjPtr testNetworkObjFindByName(testDriverPtr privconn, const char *name); + + static int testDomainInterfaceAddresses(virDomainPtr dom, virDomainInterfacePtr **ifaces, @@ -3422,11 +3426,15 @@ testDomainInterfaceAddresses(virDomainPtr dom, { size_t i; size_t ifaces_count = 0; + size_t addr_offset; int ret = -1; char macaddr[VIR_MAC_STRING_BUFLEN]; virDomainObjPtr vm = NULL; virDomainInterfacePtr iface = NULL; virDomainInterfacePtr *ifaces_ret = NULL; + virSocketAddr addr; + virNetworkObjPtr net = NULL; + virNetworkDefPtr net_def = NULL; virCheckFlags(0, -1); @@ -3447,6 +3455,12 @@ testDomainInterfaceAddresses(virDomainPtr dom, goto cleanup; for (i = 0; i < vm->def->nnets; i++) { + if (!(net = testNetworkObjFindByName(dom->conn->privateData, + vm->def->nets[i]->data.network.name))) + goto cleanup; + + net_def = virNetworkObjGetDef(net); + if (VIR_ALLOC(iface) < 0) goto cleanup; @@ -3460,14 +3474,33 @@ testDomainInterfaceAddresses(virDomainPtr dom, if (VIR_ALLOC(iface->addrs) < 0) goto cleanup; - iface->addrs[0].type = VIR_IP_ADDR_TYPE_IPV4; - iface->addrs[0].prefix = 24; - if (virAsprintf(&iface->addrs[0].addr, "192.168.0.%zu", 1 + i) < 0) - goto cleanup; - iface->naddrs = 1; + iface->addrs[0].prefix = virSocketAddrGetIPPrefix(&net_def->ips->address, + &net_def->ips->netmask, + net_def->ips->prefix); + + if (net_def->ips->nranges > 0) + addr = net_def->ips->ranges[0].start; + else + addr = net_def->ips->address; + + /* try using different addresses per different inf and domain */ + addr_offset = 20 * (vm->def->id - 1) + i + 1; + + if (net_def->ips->family && STREQ(net_def->ips->family, "ipv6")) { + iface->addrs[0].type = VIR_IP_ADDR_TYPE_IPV6; + addr.data.inet6.sin6_addr.s6_addr[15] += addr_offset; + } else { + iface->addrs[0].type = VIR_IP_ADDR_TYPE_IPV4; + addr.data.inet4.sin_addr.s_addr = \ + htonl(ntohl(addr.data.inet4.sin_addr.s_addr) + addr_offset); + } + + if (!(iface->addrs[0].addr = virSocketAddrFormat(&addr))) + goto cleanup; VIR_APPEND_ELEMENT_INPLACE(ifaces_ret, ifaces_count, iface); + virNetworkObjEndAPI(&net); } VIR_STEAL_PTR(*ifaces, ifaces_ret); @@ -3475,6 +3508,7 @@ testDomainInterfaceAddresses(virDomainPtr dom, cleanup: virDomainObjEndAPI(&vm); + virNetworkObjEndAPI(&net); if (ifaces_ret) { for (i = 0; i < ifaces_count; i++) -- 2.22.0

2 5

[libvirt] [PATCH 0/4] cgroups: add support for BFQ scheduler
by Pavel Hrdina 21 Jun '19

21 Jun '19

Pavel Hrdina (4): util: vircgroup: introduce virCgroup(Get|Set)ValueRaw util: vircgroup: move virCgroupGetValueStr out of virCgroupGetValueForBlkDev util: vircgroupv1: add support for BFQ blkio files util: vircgroupv2: add support for BFQ files src/util/vircgroup.c | 70 +++++++++------- src/util/vircgrouppriv.h | 12 ++- src/util/vircgroupv1.c | 174 +++++++++++++++++++++++++++++---------- src/util/vircgroupv2.c | 156 +++++++++++++++++++++++++---------- 4 files changed, 292 insertions(+), 120 deletions(-) -- 2.21.0

2 5

[libvirt] [PATCH] docs: Space out entries in news.html
by Peter Krempa 21 Jun '19

21 Jun '19

The header for the news entry blends together with the text and other entries. This patch tries to space them out somewhat for better visual separation. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- You can see the difference here: https://github.com/pipo/libvirt/blob/screenshots/before.png https://github.com/pipo/libvirt/blob/screenshots/after.png docs/libvirt.css | 15 +++++++++++++++ docs/news-html.xsl | 13 +++++++++---- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index 4c7afc4042..e44ef616d8 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -591,3 +591,18 @@ td.enumvalue { .deprecatedhv { color: darkred; } + +ul.news-section { + margin-top: 0.5em; +} + +ul.news-section li dl dt { + margin: 0; +} + +ul.news-section li dl dd { + margin-left: 1em; + margin-right: 0; + margin-top: 0.5em; + margin-bottom: 0.5em; +} diff --git a/docs/news-html.xsl b/docs/news-html.xsl index 4d40798028..fb0178f9e2 100644 --- a/docs/news-html.xsl +++ b/docs/news-html.xsl @@ -58,7 +58,7 @@ <xsl:value-of select="@title"/> </strong> <xsl:if test="*"> - <ul> + <ul class="news-section"> <xsl:apply-templates select="change"/> </ul> </xsl:if> @@ -68,8 +68,14 @@  <xsl:template match="change"> <li> - <xsl:apply-templates select="summary"/> - <xsl:apply-templates select="description"/> + <dl> + <dt> + <xsl:apply-templates select="summary"/> + </dt> + <dd> + <xsl:apply-templates select="description"/> + </dd> + </dl> </li> </xsl:template> @@ -80,7 +86,6 @@  <xsl:template match="description"> - <br/> <xsl:apply-templates/> </xsl:template> -- 2.21.0

3 2

[libvirt] [PATCH] Revert "news: Document removal of qemu commandline parsing"
by Peter Krempa 21 Jun '19

21 Jun '19

Jano probably based his branch on top of mine and didn't notice when I moved the section up slightly and thus git applied it again. Keep only the instance followin the new features section. This reverts commit 9c68bb4a5c2c8c050e531533e5188a637ba1dd9f. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed under the trivial rule. docs/news.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 681e9a60a3..cada389092 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -67,18 +67,6 @@ </section> <section title="Bug fixes"> </section> - <section title="Removed features"> - <change> - <summary> - qemu: Remove support for virDomainQemuAttach and virConnectDomainXMLFromNative APIs - </summary> - <description> - The qemu implementations for the APIs mentioned above were removed - and the APIs now return error. The implementation was stale for a - long time and did not allow working with moder use of qemu in libvirt. - </description> - </change> - </section> </release> <release version="v5.4.0" date="2019-06-03"> <section title="Security"> -- 2.21.0

2 1

[libvirt] [PATCH] rpc: virnetlibsshsession: update deprecated functions
by Pavel Hrdina 21 Jun '19

21 Jun '19

In libssh 0.9.0 functions ssh_is_server_known and ssh_write_knownhost are marked as deprecated. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1722735 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- m4/virt-libssh.m4 | 8 ++++++++ src/rpc/virnetlibsshsession.c | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/m4/virt-libssh.m4 b/m4/virt-libssh.m4 index 01c3b75c72..132447da16 100644 --- a/m4/virt-libssh.m4 +++ b/m4/virt-libssh.m4 @@ -33,6 +33,14 @@ AC_DEFUN([LIBVIRT_CHECK_LIBSSH],[ [], [AC_DEFINE_UNQUOTED([ssh_get_server_publickey], [ssh_get_publickey], [ssh_get_publickey is deprecated and replaced by ssh_get_server_publickey.])]) + AC_CHECK_FUNC([ssh_session_is_known_server], + [], + [AC_DEFINE_UNQUOTED([ssh_session_is_known_server], [ssh_is_server_known], + [ssh_is_server_known is deprecated and replaced by ssh_session_is_known_server.])]) + AC_CHECK_FUNC([ssh_session_update_known_hosts], + [], + [AC_DEFINE_UNQUOTED([ssh_session_update_known_hosts], [ssh_write_knownhost], + [ssh_write_knownhost is deprecated and replaced by ssh_session_update_known_hosts.])]) CFLAGS="$old_CFLAGS" LIBS="$old_LIBS" fi diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c index 486437e7bf..093ac29071 100644 --- a/src/rpc/virnetlibsshsession.c +++ b/src/rpc/virnetlibsshsession.c @@ -284,7 +284,7 @@ virNetLibsshCheckHostKey(virNetLibsshSessionPtr sess) if (sess->hostKeyVerify == VIR_NET_LIBSSH_HOSTKEY_VERIFY_IGNORE) return 0; - state = ssh_is_server_known(sess->session); + state = ssh_session_is_known_server(sess->session); switch (state) { case SSH_SERVER_KNOWN_OK: @@ -378,7 +378,7 @@ virNetLibsshCheckHostKey(virNetLibsshSessionPtr sess) /* write the host key file, if specified */ if (sess->knownHostsFile) { - if (ssh_write_knownhost(sess->session) < 0) { + if (ssh_session_update_known_hosts(sess->session) < 0) { errmsg = ssh_get_error(sess->session); virReportError(VIR_ERR_LIBSSH, _("failed to write known_host file '%s': %s"), -- 2.21.0

3 3

[libvirt] [PATCH] Fix 'validate' typo in comments
by Jonathon Jongsma 20 Jun '19

20 Jun '19

Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d06e094b11..8604ba63d4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21375,7 +21375,7 @@ virDomainObjParseXML(xmlDocPtr xml, if (virDomainDefPostParse(obj->def, caps, flags, xmlopt, parseOpaque) < 0) goto error; - /* valdiate configuration */ + /* validate configuration */ if (virDomainDefValidate(obj->def, caps, flags, xmlopt) < 0) goto error; @@ -21465,7 +21465,7 @@ virDomainDefParseNode(xmlDocPtr xml, if (virDomainDefPostParse(def, caps, flags, xmlopt, parseOpaque) < 0) goto cleanup; - /* valdiate configuration */ + /* validate configuration */ if (virDomainDefValidate(def, caps, flags, xmlopt) < 0) goto cleanup; -- 2.20.1

2 1