- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] Colourize configure output
by Michal Privoznik 23 Sep '19

23 Sep '19

An example how configure looks like with these changes applied: https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247 Michal Prívozník (4): configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE virt-result.m4: Align string more generously configure: Colorize output virt-result.m4: Colourize summary printings configure.ac | 8 ++--- m4/virt-chrdev-lock-files.m4 | 2 +- m4/virt-colours.m4 | 62 ++++++++++++++++++++++++++++++++++++ m4/virt-debug.m4 | 2 +- m4/virt-default-editor.m4 | 2 +- m4/virt-dtrace.m4 | 2 +- m4/virt-host-validate.m4 | 2 +- m4/virt-init-script.m4 | 2 +- m4/virt-loader-nvram.m4 | 2 +- m4/virt-login-shell.m4 | 2 +- m4/virt-numad.m4 | 2 +- m4/virt-result.m4 | 21 ++++++++++-- 12 files changed, 93 insertions(+), 16 deletions(-) create mode 100644 m4/virt-colours.m4 -- 2.21.0

4 17

[libvirt] [PATCH 1/2] libvirt-rust: Fix bugs in Stream::recv
by Linus Färnstrand 23 Sep '19

23 Sep '19

* pass same size to virStreamRecv as the buffer has allocated * Handle -2 error case * Fix FFI declaration to take size_t instead of c_uint * Allow user to pass in buffer. To allow user to decide where to allocate it. And to be able to re-use the same buffer * Don't try to treat binary data as a string Signed-off-by: Linus Färnstrand <faern(a)faern.net> --- src/stream.rs | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/stream.rs b/src/stream.rs index 8333ee5..af6c8ec 100644 --- a/src/stream.rs +++ b/src/stream.rs @@ -18,6 +18,7 @@ extern crate libc; +use std::convert::TryFrom; use std::str; use error::Error; @@ -37,7 +38,7 @@ extern "C" { -> libc::c_int; fn virStreamRecv(c: sys::virStreamPtr, data: *mut libc::c_char, - nbytes: libc::c_uint) + nbytes: libc::size_t) -> libc::c_int; fn virStreamFree(c: sys::virStreamPtr) -> libc::c_int; fn virStreamAbort(c: sys::virStreamPtr) -> libc::c_int; @@ -116,14 +117,14 @@ impl Stream { } } - pub fn recv(&self, size: u32) -> Result<String, Error> { - unsafe { - let mut data: [libc::c_char; 2048] = ['\0' as i8; 2048]; - let ret = virStreamRecv(self.as_ptr(), data.as_mut_ptr(), size as libc::c_uint); - if ret == -1 { - return Err(Error::new()); - } - return Ok(c_chars_to_string!(data.as_ptr())); - } + pub fn recv(&self, buf: &mut [u8]) -> Result<usize, Error> { + let ret = unsafe { + virStreamRecv( + self.as_ptr(), + buf.as_mut_ptr() as *mut libc::c_char, + buf.len(), + ) + }; + usize::try_from(ret).map_err(|_| Error::new()) } } -- 2.21.0

2 3

[libvirt] [PATCH 0/3] use VIR_AUTOFREE() with strings in qemu_hotplug.c
by Daniel Henrique Barboza 23 Sep '19

23 Sep '19

Similar work to [1], but this time someone already changed the virQEMUDriverConfigPtr to use VIR_AUTOUNREF() in this file, which is less work pending to do, which is good. This change in particular will royally mess up with my rebases, but it's for a good cause. [1] https://www.redhat.com/archives/libvir-list/2019-September/msg00719.html Daniel Henrique Barboza (3): qemu_hotplug.c: use VIR_AUTOFREE() in strings 1/3 qemu_hotplug.c: use VIR_AUTOFREE() in strings 2/3 qemu_hotplug.c: use VIR_AUTOFREE() in strings 3/3 src/qemu/qemu_hotplug.c | 286 +++++++++++++--------------------------- 1 file changed, 95 insertions(+), 191 deletions(-) -- 2.21.0

2 6

[libvirt] [PATCH v2 0/2] a few cleanups in qemu_domain_address.c
by Daniel Henrique Barboza 23 Sep '19

23 Sep '19

Second round of these cleanups after the reviews from Eric. changes from v1: - fixed the commit message of patch 1 - ditched the virPCIAddressSet() approach - use direct assignment instead v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00823.html Daniel Henrique Barboza (2): qemu_domain_address.c: use VIR_AUTOFREE() in strings qemu_domain_address: use virPCIDeviceAddressEqual() in conditionals src/qemu/qemu_domain_address.c | 125 +++++++++++++++------------------ 1 file changed, 55 insertions(+), 70 deletions(-) -- 2.21.0

2 4

[libvirt] [PATCH] conf: reattach interface taps to correct bridge on restart
by Laine Stump 20 Sep '19

20 Sep '19

When the bridge re-attach handling was moved out of the network driver and into the hypervisor driver (commit b806a60e) as a part of the refactor to split the network driver into a separate daemon, the check was accidentally changed to only check for type='bridge'. The check for type in this case needs to check for type='network' as well. (at the time we thought that type='network' and type='bridge' could be conflated for interface actual type, but this turned out to be too problematic to do). Signed-off-by: Laine Stump <laine(a)redhat.com> --- (NB: I thought I remembered seeing a bugzilla report go by about this regression, but couldn't find it in any of the places I frequent (upstream, Fedora, or RHEL) If someone can locate it and wants to let me know the BZ#, I can add it to the commit message and update the report). (This fixes the reconnect of taps to their bridges, but the count maintained in the network object still isn't being updated in these cases. I've tried removing the !virUUIDIsValid() check in this same chunk, along with preserving the original port uuid if it's already valid in virDomainNetDefActualToNetworkPort(), and that results in fixing the usage count for type='network' when it's a libvirt-managed bridge or a macvtap passthrough pool, but leads to errors in other cases.) src/conf/domain_conf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 848c831330..24223bceb2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30971,13 +30971,16 @@ virDomainNetNotifyActualDevice(virConnectPtr conn, virDomainDefPtr dom, virDomainNetDefPtr iface) { + virDomainNetType actualType = virDomainNetGetActualType(iface); + if (!virUUIDIsValid(iface->data.network.portid)) { if (virDomainNetCreatePort(conn, dom, iface, VIR_NETWORK_PORT_CREATE_RECLAIM) < 0) return; } - if (virDomainNetGetActualType(iface) == VIR_DOMAIN_NET_TYPE_BRIDGE) { + if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { /* * NB: we can't notify the guest of any MTU change anyway, * so there is no point in trying to learn the actualMTU -- 2.21.0

2 1

[libvirt] [PATCH 0/2] a few cleanups in qemu_domain_address.c
by Daniel Henrique Barboza 20 Sep '19

20 Sep '19

First patch is the standard "use VIR_AUTOFREE() in strings" type of patch. Second one is something I tried it out and ended up cleaning some repetitive code, so I believe it's worth seeing what you think. Daniel Henrique Barboza (2): qemu_domain_address.c: use VIR_AUTOFREE() in strings virpci, qemu_domain_address: adding virPCIDeviceSetAddress src/libvirt_private.syms | 1 + src/qemu/qemu_domain_address.c | 126 +++++++++++++++------------------ src/util/virpci.c | 10 +++ src/util/virpci.h | 3 + 4 files changed, 70 insertions(+), 70 deletions(-) -- 2.21.0

2 5

[libvirt] [PATCH] remote: fix enablement of IP networking in virtproxyd
by Daniel P. Berrangé 20 Sep '19

20 Sep '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/remote/Makefile.inc.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index e05ae64169..e02c20d47c 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -237,7 +237,7 @@ virtproxyd_CFLAGS = \ $(REMOTE_DAEMON_CFLAGS) \ -DSOCK_PREFIX="\"libvirt\"" \ -DDAEMON_NAME="\"virtproxyd\"" \ - -DENABLE_IP \ + -DWITH_IP \ -DVIRTPROXYD \ $(NULL) virtproxyd_LDFLAGS = $(REMOTE_DAEMON_LD_FLAGS) -- 2.21.0

2 1

[libvirt] [PATCH 0/7] qemu: checkpoints: Collect most code in a single place
by Peter Krempa 20 Sep '19

20 Sep '19

The checkpoint code is quite complex and was dispersed in many places. Refactor it to be in one new separate file. I also plan to do the same to the snapshot code once this is dealt with. Additionally aggregating all the code in one place will allow refactoring and reuse in the incremental backup implementation. Peter Krempa (7): qemu: Move, rename and export qemuDomObjFromDomain conf: Drop pointless 'domain' argument from virDomainCheckpointRedefinePrep conf: Drop pointless 'domain' argument from virDomainSnapshotRedefinePrep qemu: driver: Remove misplaced qemuDomainObjEndJob in qemuDomainCheckpointGetXMLDesc qemu: driver: Move checkpoint-related code to qemu_checkpoint.c qemu: domain: Move checkpoint related code to qemu_checkpoint.c qemu: driver: Don't pull in qemu_monitor_json.h directly src/conf/checkpoint_conf.c | 7 +- src/conf/checkpoint_conf.h | 3 +- src/conf/snapshot_conf.c | 5 +- src/conf/snapshot_conf.h | 3 +- src/qemu/Makefile.inc.am | 2 + src/qemu/qemu_checkpoint.c | 646 ++++++++++++++++++++++++++++++++++ src/qemu/qemu_checkpoint.h | 55 +++ src/qemu/qemu_domain.c | 193 ++--------- src/qemu/qemu_domain.h | 16 +- src/qemu/qemu_driver.c | 686 ++++++++----------------------------- src/test/test_driver.c | 4 +- 11 files changed, 887 insertions(+), 733 deletions(-) create mode 100644 src/qemu/qemu_checkpoint.c create mode 100644 src/qemu/qemu_checkpoint.h -- 2.21.0

1 7

[libvirt] [PATCH python v2] Custom impl for virConnectSetIdentity which can't be generated
by Daniel P. Berrangé 20 Sep '19

20 Sep '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- generator.py | 1 + libvirt-override-api.xml | 7 +++++ libvirt-override.c | 64 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 72 insertions(+) diff --git a/generator.py b/generator.py index 433c1f2..913dab8 100755 --- a/generator.py +++ b/generator.py @@ -489,6 +489,7 @@ skip_impl = ( 'virDomainGetDiskErrors', 'virNodeGetMemoryParameters', 'virNodeSetMemoryParameters', + 'virConnectSetIdentity', 'virNodeGetCPUMap', 'virDomainMigrate3', 'virDomainMigrateToURI3', diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index b2a6259..7a0d4c5 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -796,5 +796,12 @@ <arg name='types' type='int' info='optional binary-OR of virDomainGuestInfoTypes'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virConnectSetIdentity' file='libvirt-host' module='libvirt-host'> + <info>Override the default identity information associated with the connection.</info> + <return type='int' info='0 if the identity change was accepted, -1 on error'/> + <arg name='conn' type='virConnectPtr' info='pointer to the hypervisor connection'/> + <arg name='params' type='virTypedParameterPtr' info='parameters containing the identity attributes'/> + <arg name='flags' type='unsigned int' info='currently unused, pass 0'/> + </function> </symbols> </api> diff --git a/libvirt-override.c b/libvirt-override.c index ff2cfdf..72edca9 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -10209,6 +10209,67 @@ libvirt_virDomainGetGuestInfo(PyObject *self ATTRIBUTE_UNUSED, } #endif /* LIBVIR_CHECK_VERSION(5, 7, 0) */ + +#if LIBVIR_CHECK_VERSION(5, 8, 0) +static virPyTypedParamsHint virPyConnectSetIdentityParams[] = { + { VIR_CONNECT_IDENTITY_USER_NAME, VIR_TYPED_PARAM_STRING }, + { VIR_CONNECT_IDENTITY_UNIX_USER_ID, VIR_TYPED_PARAM_ULLONG }, + { VIR_CONNECT_IDENTITY_GROUP_NAME, VIR_TYPED_PARAM_STRING }, + { VIR_CONNECT_IDENTITY_UNIX_GROUP_ID, VIR_TYPED_PARAM_ULLONG }, + { VIR_CONNECT_IDENTITY_PROCESS_ID, VIR_TYPED_PARAM_LLONG }, + { VIR_CONNECT_IDENTITY_PROCESS_TIME, VIR_TYPED_PARAM_ULLONG }, + { VIR_CONNECT_IDENTITY_SASL_USER_NAME, VIR_TYPED_PARAM_STRING }, + { VIR_CONNECT_IDENTITY_X509_DISTINGUISHED_NAME, VIR_TYPED_PARAM_STRING }, + { VIR_CONNECT_IDENTITY_SELINUX_CONTEXT, VIR_TYPED_PARAM_STRING }, +}; + +static PyObject * +libvirt_virConnectSetIdentity(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) +{ + virConnectPtr conn; + PyObject *pyobj_conn, *dict; + PyObject *ret = NULL; + int i_retval; + int nparams = 0; + unsigned int flags; + virTypedParameterPtr params = NULL; + + if (!PyArg_ParseTuple(args, + (char *)"OOI:virConnectSetIdentity", + &pyobj_conn, &dict, &flags)) + return NULL; + conn = (virConnectPtr) PyvirConnect_Get(pyobj_conn); + + if (!PyDict_Check(dict)) { + PyErr_Format(PyExc_TypeError, "migration params must be a dictionary"); + return NULL; + } + + if (virPyDictToTypedParams(dict, &params, &nparams, + virPyConnectSetIdentityParams, + VIR_N_ELEMENTS(virPyConnectSetIdentityParams)) < 0) { + return NULL; + } + + LIBVIRT_BEGIN_ALLOW_THREADS; + i_retval = virConnectSetIdentity(conn, params, nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (i_retval < 0) { + ret = VIR_PY_INT_FAIL; + goto cleanup; + } + + ret = VIR_PY_INT_SUCCESS; + + cleanup: + virTypedParamsFree(params, nparams); + return ret; +} +#endif /* LIBVIR_CHECK_VERSION(5, 8, 0) */ + + /************************************************************************ * * * The registration stuff * @@ -10467,6 +10528,9 @@ static PyMethodDef libvirtMethods[] = { #if LIBVIR_CHECK_VERSION(5, 7, 0) {(char *) "virDomainGetGuestInfo", libvirt_virDomainGetGuestInfo, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(5, 7, 0) */ +#if LIBVIR_CHECK_VERSION(5, 8, 0) + {(char *) "virConnectSetIdentity", libvirt_virConnectSetIdentity, METH_VARARGS, NULL}, +#endif /* LIBVIR_CHECK_VERSION(5, 8, 0) */ {NULL, NULL, 0, NULL} }; -- 2.21.0

2 1

[libvirt] [python PATCH 0/2] implement missing domain memory stats
by Pavel Hrdina 20 Sep '19

20 Sep '19

Pavel Hrdina (2): virDomainMemoryStats: include disk caches virDomainMemoryStats: include hugetlb pgalloc and pgfail libvirt-override.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.21.0

2 4