- Devel - libvirt List Archives

[libvirt] [PATCH] spec: fix indentation
by Ján Tomko 11 Dec '19

11 Dec '19

The recent specfile addition broke syntax-check: cppi: ../libvirt.spec.in: line 338: not properly indented cppi: ../libvirt.spec.in: line 341: not properly indented cppi: ../libvirt.spec.in: line 344: not properly indented Fixes: ac063cb2e76d64a907f96bf0b6a29da4eb484ebc Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Push under the 'are we still doing syntax-check?' rule libvirt.spec.in | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 01f28e62d6..4d75fbecaf 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -335,13 +335,13 @@ BuildRequires: device-mapper-devel # For XFS reflink clone support BuildRequires: xfsprogs-devel %if %{with_storage_rbd} -%if 0%{?fedora} || 0%{?rhel} > 7 -BuildRequires: librados-devel -BuildRequires: librbd-devel -%else -BuildRequires: librados2-devel -BuildRequires: librbd1-devel -%endif + %if 0%{?fedora} || 0%{?rhel} > 7 + BuildRequires: librados-devel + BuildRequires: librbd-devel + %else + BuildRequires: librados2-devel + BuildRequires: librbd1-devel + %endif %endif %if %{with_storage_gluster} BuildRequires: glusterfs-api-devel >= 3.4.1 -- 2.19.2

2 1

[libvirt] [jenkins-ci PATCH 0/1] jenkins: Start building on Ubuntu
by Andrea Bolognani 11 Dec '19

11 Dec '19

This patch is intended to start a slightly larger discussion about our plans for the CentOS CI environment going forward. At the moment, we have active builders for CentOS 7 Debian 9 Debian 10 Fedora 30 Fedora 31 Fedora Rawhide FreeBSD 11 FreeBSD 12 but we don't have builder for Debian sid FreeBSD -CURRENT Ubuntu 16.04 Ubuntu 18.04 despite them being fully supported in the libvirt-jenkins-ci repository. This makes sense for sid and -CURRENT, since the former covers the same "freshest Linux packages" angle that Rawhide already takes care of and the latter is often broken and not trivial to keep updated; both Ubuntu targets, however, should IMHO be part of the CentOS CI environment. Hence this series :) Moreover, we're in the process of adding CentOS 8 openSUSE Leap 15.1 openSUSE Tumbleweed as targets, of which the first two should also IMHO be added as they would provide useful additional coverage. The only reason why I'm even questioning whether this should be done is capacity for the hypervisor host: the machine we're running all builders on has CPUs: 8 Memory: 32 GiB Storage: 450 GiB and each of the guests is configured to use CPUs: 2 Memory: 2 GiB Storage: 20 GiB So while we're good, and actually have plenty of room to grow, on the memory and storage front, we're already overcommitting our CPUs pretty significantly, which I guess is at least part of the reason why builds take so long. Can we afford to add 50% more load on the machine without making it unusable? I don't know. But I think it would be worthwhile to at least try and see how it handles an additional 25%, which is exactly what this series does. In my opinion, as long as the machine can keep up with demand and not end up in a situation where it starts accumulating backlog jobs, it's fine if builds take longer: developers who want to run a relatively quick smoke test before posting patches can use Travis CI or 'make ci-check@...' locally for the purpose, whereas the role of CentOS CI in my eyes is to try and catch as many issues as possible after merge so that they don't end up in a release. But I realize others might see it differently, hence this lenghty cover letter :) Andrea Bolognani (1): jenkins: Start building on Ubuntu jenkins/jobs/defaults.yaml | 2 ++ jenkins/projects/libvirt-dbus.yaml | 1 + jenkins/projects/libvirt-sandbox.yaml | 2 ++ jenkins/projects/libvirt-tck.yaml | 2 ++ jenkins/projects/libvirt.yaml | 2 ++ jenkins/projects/virt-manager.yaml | 2 ++ 6 files changed, 11 insertions(+) -- 2.23.0

2 4

[libvirt] [jenkins-ci PATCH v2 0/8] Add CentOS 8 to libvirt-jenkins-ci
by Fabiano Fidêncio 11 Dec '19

11 Dec '19

In order to add CentOS 8 to jenkins-ci, we had to: - Adjust lcitool to generate unattended scripts based on templates instead of using the templates themselves, as a new parameter is expected on kickstart files for RHEL / CentOS 8 (or newer); - Enable the EPEL and PowerTools repos; Then, the following projects have been added: - libvirt - Some adjustments had to be done as some dependencies got removed from CentOS 8; - libvirt-glib - libvirt-dbus - Some adjustments had to be done as flake8 doesn't pull all the needed dependencies when installed on CentOS 8; - libvirt-go - libvirt-go-xml - libvirt-ocaml - libvirt-perl - libvirt-python - virt-viewer - Some adjustments had to be done as libgovirt-devel and gtk-vnc2-devel are not present anymore on CentOS 8; - osinfo-db-tools - oisnfo-db - libosinfo - virt-manager The projects which were not added due to missing dependencies are: - libvirt-cim - libvirt-sandbox - libvirt-tck Fabiano Fidêncio (8): lcitool: Generate the unattended script file lcitool: Use install_url in the unattended install files guests: Add CentOS 8 mappings: Adjustments for CentOS 8 guests: Install EPEL repo on all CentOS guests guests: Enable PowerTools repo on CentOS 8 guests guests: Add projects to CentOS 8 guests: Build projects on CentOS 8 guests/configs/kickstart.cfg | 6 +++++ guests/host_vars/libvirt-centos-8/docker.yml | 2 ++ guests/host_vars/libvirt-centos-8/install.yml | 2 ++ guests/host_vars/libvirt-centos-8/main.yml | 22 ++++++++++++++++ guests/inventory | 1 + guests/lcitool | 26 ++++++++++++++++++- guests/playbooks/build/jobs/defaults.yml | 2 ++ guests/playbooks/build/projects/libosinfo.yml | 1 + .../playbooks/build/projects/libvirt-dbus.yml | 2 ++ guests/playbooks/build/projects/libvirt.yml | 1 + .../build/projects/osinfo-db-tools.yml | 1 + .../playbooks/build/projects/virt-manager.yml | 3 +++ guests/playbooks/update/tasks/base.yml | 9 ++++++- guests/vars/mappings.yml | 4 +++ jenkins/jobs/defaults.yaml | 2 ++ jenkins/projects/libosinfo.yaml | 1 + jenkins/projects/libvirt-dbus.yaml | 2 ++ jenkins/projects/libvirt.yaml | 1 + jenkins/projects/osinfo-db-tools.yaml | 1 + jenkins/projects/virt-manager.yaml | 3 +++ 20 files changed, 90 insertions(+), 2 deletions(-) create mode 100644 guests/host_vars/libvirt-centos-8/docker.yml create mode 100644 guests/host_vars/libvirt-centos-8/install.yml create mode 100644 guests/host_vars/libvirt-centos-8/main.yml -- 2.23.0

2 20

[libvirt] [PATCH] docs: prefer to use rst2html5 instead of rst2html
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

Our website is written assuming HTML5 standard & doctype: commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Jul 26 18:01:25 2017 +0100 docs: switch to using HTML5 doctype declaration so we want the RST conversion to also use HTML5. Ubuntu 16.04 still only has the HTML4 generating tools though, so we have that as a fallback. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- m4/virt-external-programs.m4 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/m4/virt-external-programs.m4 b/m4/virt-external-programs.m4 index ed634a4c73..aad21c81bf 100644 --- a/m4/virt-external-programs.m4 +++ b/m4/virt-external-programs.m4 @@ -33,10 +33,13 @@ AC_DEFUN([LIBVIRT_CHECK_EXTERNAL_PROGRAMS], [ then AC_MSG_ERROR("xsltproc is required to build libvirt") fi - AC_PATH_PROGS([RST2HTML], [rst2html rst2html.py rst2html-3], []) + + dnl Drop the rst2html (aka HTML4) variants once we + dnl stop supporting Ubuntu 16.04 (Xenial) + AC_PATH_PROGS([RST2HTML], [rst2html5 rst2html5.py rst2html5-3 rst2html rst2html.py rst2html-3], []) if test -z "$RST2HTML" then - AC_MSG_ERROR("rst2html is required to build libvirt") + AC_MSG_ERROR("rst2html5/rst2html is required to build libvirt") fi AC_PATH_PROG([AUGPARSE], [augparse], [/usr/bin/augparse]) AC_PROG_MKDIR_P -- 2.23.0

2 1

[libvirt] [PATCH] scripts: ignore remote protocol checks if pdwtags crashes
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

On Debian 10, pdwtags reliably segfaults when parsing the libvirt remote protocol files. This crash was previously ignored by 'make check' because of the way we piped the pdwtags output to the perl post-processing scripts. When this was converted to use python it mistakenly started being a fatal error. We need to explicitly ignore pdwtags output if it exited with non-zero return code. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/check-remote-protocol.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py index 201166fd9e..25caa19563 100644 --- a/scripts/check-remote-protocol.py +++ b/scripts/check-remote-protocol.py @@ -86,8 +86,12 @@ out, err = pdwtagsproc.communicate() out = out.decode("utf-8") err = err.decode("utf-8") -if out == "" and err != "": - print("WARNING: no output, pdwtags appears broken:", file=sys.stderr) +if out == "" or pdwtagsproc.returncode != 0: + if out == "": + print("WARNING: no output, pdwtags appears broken:", file=sys.stderr) + else: + print("WARNING: exit code %d, pdwtags appears broken:" % + pdwtagsproc.returncode, file=sys.stderr) for l in err.strip().split("\n"): print("WARNING: %s" % l, file=sys.stderr) print("WARNING: skipping the remote protocol test", file=sys.stderr) -- 2.23.0

2 3

[libvirt] [PATCH] docs: switch to use rst2html5 instead of rst2html
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

Now that we don't have to support CentOS 7's python2-docutils, we can use the rst2html5 tool instead, which generates HTML5 output instead of HTML4 output. This matches what we used for the original HTML docs since commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Jul 26 18:01:25 2017 +0100 docs: switch to using HTML5 doctype declaration Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- m4/virt-external-programs.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-external-programs.m4 b/m4/virt-external-programs.m4 index ed634a4c73..a23c69d54b 100644 --- a/m4/virt-external-programs.m4 +++ b/m4/virt-external-programs.m4 @@ -33,7 +33,7 @@ AC_DEFUN([LIBVIRT_CHECK_EXTERNAL_PROGRAMS], [ then AC_MSG_ERROR("xsltproc is required to build libvirt") fi - AC_PATH_PROGS([RST2HTML], [rst2html rst2html.py rst2html-3], []) + AC_PATH_PROGS([RST2HTML], [rst2html5 rst2html5.py rst2html5-3], []) if test -z "$RST2HTML" then AC_MSG_ERROR("rst2html is required to build libvirt") -- 2.23.0

2 2

[libvirt] [PATCH 00/17] docs: remove all use of POD for man pages in favour of RST
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

As part of the goal to eliminate Perl from libvirt, this gets rid of the use of POD format for man pages. There's nothing especially bad about POD as a markup language compared to other lightweight markup languages like RST or Markdown. It hasn't found widespread usage outside of the Perl world though, and so switching from POD to RST brings a language which likely has more familiarity to contributors. This also nicely aligns with our use of RST of web pages, and indeed in this series things are setup so that all the man pages get published on the main libvirt.org website. Over time this will hopefuly draw search engines traffic to libvirt.org instead of random 3rd party websites hosting various out of date copies of the man pages. Reviewing the individual RST files is likely a very unpleasant task, especially the enourmous virsh man page. Most of the conversion work was automated with pod2rst, followed by lots of editting to cleanup its output. virsh had some further automated processing done to create headers for each command. It is probably more useful to review the rendered man page output and/or websites to see that it looks sane when read. Daniel P. Berrangé (17): src: update keycodemapdb submodule rpm: move pod2man & rst2html deps outside the autotools conditional rpm: use python3-docutils as the direct dep docs: introduce rst2man as a mandatory tool for building docs docs: describe the basic RST structure for a man page docs: convert libvirtd man page from pod to rst docs: convert virtlockd man page from pod to rst docs: convert virtlogd man page from pod to rst docs: convert virt-host-validate man page from pod to rst docs: convert virt-pki-validate man page from pod to rst docs: convert virt-xml-validate man page from pod to rst docs: convert virt-sanlock-cleanup man page from pod to rst docs: convert virt-login-shell man page from pod to rst docs: convert virt-admin man page from pod to rst docs: convert virsh man page from pod to rst docs: convert virkeycode*/virkeyname* man pages from pod to rst docs: remove build recipes related to pod2man usage docs/Makefile.am | 118 + docs/docs.html.in | 3 + docs/manpages/index.rst | 37 + docs/manpages/libvirtd.rst | 259 + docs/manpages/virsh.rst | 7096 +++++++++++++++++ docs/manpages/virt-admin.rst | 610 ++ docs/manpages/virt-host-validate.rst | 95 + docs/manpages/virt-login-shell.rst | 144 + docs/manpages/virt-pki-validate.rst | 89 + docs/manpages/virt-sanlock-cleanup.rst | 79 + .../manpages/virt-xml-validate.rst | 107 +- docs/manpages/virtlockd.rst | 177 + docs/manpages/virtlogd.rst | 179 + docs/styleguide.rst | 86 + libvirt.spec.in | 7 +- m4/virt-external-programs.m4 | 5 + src/Makefile.am | 18 - src/keycodemapdb | 2 +- src/locking/Makefile.inc.am | 18 - src/locking/virtlockd.pod | 165 - src/logging/Makefile.inc.am | 13 - src/logging/virtlogd.pod | 165 - src/remote/Makefile.inc.am | 15 - src/remote/libvirtd.pod | 235 - src/util/Makefile.inc.am | 47 +- tools/Makefile.am | 68 - tools/virsh.pod | 5526 ------------- tools/virt-admin.pod | 497 -- tools/virt-host-validate.pod | 68 - tools/virt-login-shell.pod | 112 - tools/virt-pki-validate.pod | 61 - tools/virt-sanlock-cleanup.pod | 49 - 32 files changed, 9052 insertions(+), 7098 deletions(-) create mode 100644 docs/manpages/index.rst create mode 100644 docs/manpages/libvirtd.rst create mode 100644 docs/manpages/virsh.rst create mode 100644 docs/manpages/virt-admin.rst create mode 100644 docs/manpages/virt-host-validate.rst create mode 100644 docs/manpages/virt-login-shell.rst create mode 100644 docs/manpages/virt-pki-validate.rst create mode 100644 docs/manpages/virt-sanlock-cleanup.rst rename tools/virt-xml-validate.pod => docs/manpages/virt-xml-validate.rst (53%) create mode 100644 docs/manpages/virtlockd.rst create mode 100644 docs/manpages/virtlogd.rst delete mode 100644 src/locking/virtlockd.pod delete mode 100644 src/logging/virtlogd.pod delete mode 100644 src/remote/libvirtd.pod delete mode 100644 tools/virsh.pod delete mode 100644 tools/virt-admin.pod delete mode 100644 tools/virt-host-validate.pod delete mode 100644 tools/virt-login-shell.pod delete mode 100644 tools/virt-pki-validate.pod delete mode 100644 tools/virt-sanlock-cleanup.pod -- 2.23.0

2 19

[libvirt] [PATCH 0/2] spec: Update Fedora minimum version & librbd / librados development package names
by Fabiano Fidêncio 11 Dec '19

11 Dec '19

Fedora 29 has reached its EOL on November 26th 2019; librbd1-devel has been replaced by librbd-devel; librados2-devel has been replaced by librados; Fabiano Fidêncio (2): spec: Update Fedora minimum supported version spec: Adjust librbd / librados dependency names libvirt.spec.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.23.0

2 6

[libvirt] [jenkins-ci PATCH] Update comment for virt-manager
by Andrea Bolognani 11 Dec '19

11 Dec '19

We have Python 3 on CentOS 7 now, so the existing comment is no longer accurate. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/playbooks/build/projects/virt-manager.yml | 4 +--- jenkins/projects/virt-manager.yaml | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/guests/playbooks/build/projects/virt-manager.yml b/guests/playbooks/build/projects/virt-manager.yml index c0d4294..9184a74 100644 --- a/guests/playbooks/build/projects/virt-manager.yml +++ b/guests/playbooks/build/projects/virt-manager.yml @@ -1,9 +1,7 @@ --- - set_fact: name: virt-manager - # virt-manager is Python 3 only, so it can't be built on CentOS 7; - # Ubuntu 16.04 has Python 3 but not the libxml2 bindings, so it can't - # build the project either + # CentOS 7 and Ubuntu 16.04 have Python 3 but not the libxml2 bindings machines: - libvirt-debian-9 - libvirt-debian-10 diff --git a/jenkins/projects/virt-manager.yaml b/jenkins/projects/virt-manager.yaml index 3dc8e2e..4524831 100644 --- a/jenkins/projects/virt-manager.yaml +++ b/jenkins/projects/virt-manager.yaml @@ -1,9 +1,7 @@ --- - project: name: virt-manager - # virt-manager is Python 3 only, so it can't be built on CentOS 7; - # Ubuntu 16.04 has Python 3 but not the libxml2 bindings, so it can't - # build the project either + # CentOS 7 and Ubuntu 16.04 have Python 3 but not the libxml2 bindings machines: - libvirt-debian-9 - libvirt-debian-10 -- 2.23.0

1 0

[libvirt] [PATCH v4 0/4] qemu: block: implement optional removal of committed snapshot images
by Pavel Mores 10 Dec '19

10 Dec '19

This version incorporates Peter's feedback to v3. Pavel Mores (4): qemu: block: propagate the delete flag to where it can actually be used qemu: block: use the delete flag to delete snapshot images if requested qemu: block: store the delete flag in libvirtd's status XML qemu: block: enable the snapshot image deletion feature src/qemu/qemu_blockjob.c | 50 ++++++++++++++++++- src/qemu/qemu_blockjob.h | 4 +- src/qemu/qemu_domain.c | 4 ++ src/qemu/qemu_driver.c | 12 ++++- .../blockjob-blockdev-in.xml | 1 + 5 files changed, 67 insertions(+), 4 deletions(-) -- 2.21.0

2 9