- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/6] PCI hostdev partial assignment support
by Daniel Henrique Barboza 13 Dec '19

13 Dec '19

changes from previous version [1]: - do not overload address type='none'. A new address type called 'unassigned' is introduced; - there is no unassigned' flag being created in virDomainHostdevDef. The logic added by new address type is enough; - do not allow function zero of multifunction devices to be unassigned. Nothing too special to discuss in this cover letter. More details can be found at the discussions of the previous version [1]. Commit messages of the patches have more background info as well. [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01099.html Daniel Henrique Barboza (6): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line and alias virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> utils: PCI multifunction detection helpers domain_conf.c: don't allow function zero to be unassigned docs/formatdomain.html.in | 14 +++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 20 ++++- src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 6 ++ src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 88 +++++++++++++++++-- src/util/virhostdev.h | 3 + src/util/virpci.c | 17 ++++ src/util/virpci.h | 2 + .../hostdev-pci-address-unassigned.args | 31 +++++++ .../hostdev-pci-address-unassigned.xml | 42 +++++++++ ...pci-multifunction-zero-unassigned-fail.xml | 42 +++++++++ tests/qemuxml2argvtest.c | 8 ++ .../hostdev-pci-address-unassigned.xml | 58 ++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/virpcimock.c | 9 +- 21 files changed, 351 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction-zero-unassigned-fail.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

2 9

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 13 Dec '19

13 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

2 1

[libvirt] [PATCH 0/2] configure: Provide OpenRC scripts for sub-daemons
by Michal Privoznik 13 Dec '19

13 Dec '19

Tested on my Gentoo and it works (TM). I've copied dependencies from systemd unit files. I was also thinking about providing a dummy init script that would do nothing but depend on the rest of sub-daemon init files for convenience: /etc/init.d/libvirt-dummy start (the name is still WIP) But I'm not sure if we want that - after we drop libvirtd we can use libvirtd script just for that. But if somebody wants it, I can write and post it as a follow up patch. Michal Prívozník (2): configure: Provide OpenRC scripts for sub-daemons news: Document init scripts docs/news.xml | 11 ++++++ m4/virt-init-script.m4 | 8 +++- src/Makefile.am | 56 +++++++++++++++++++++++++++- src/interface/Makefile.inc.am | 11 ++++++ src/interface/virtinterfaced.init.in | 26 +++++++++++++ src/libxl/Makefile.inc.am | 10 +++++ src/libxl/virtxend.init.in | 26 +++++++++++++ src/lxc/Makefile.inc.am | 10 +++++ src/lxc/virtlxcd.init.in | 26 +++++++++++++ src/network/Makefile.inc.am | 10 +++++ src/network/virtnetworkd.init.in | 26 +++++++++++++ src/node_device/Makefile.inc.am | 11 ++++++ src/node_device/virtnodedevd.init.in | 26 +++++++++++++ src/nwfilter/Makefile.inc.am | 11 ++++++ src/nwfilter/virtnwfilterd.init.in | 26 +++++++++++++ src/qemu/Makefile.inc.am | 10 +++++ src/qemu/virtqemud.init.in | 26 +++++++++++++ src/remote/Makefile.inc.am | 30 +++++++++++++++ src/remote/libvirtd.confd | 18 +++++++++ src/remote/libvirtd.init.in | 29 ++++++++++++++ src/remote/virtproxyd.confd | 10 +++++ src/remote/virtproxyd.init.in | 28 ++++++++++++++ src/secret/Makefile.inc.am | 10 +++++ src/secret/virtsecretd.init.in | 26 +++++++++++++ src/storage/Makefile.inc.am | 10 +++++ src/storage/virtstoraged.init.in | 26 +++++++++++++ src/vbox/Makefile.inc.am | 10 +++++ src/vbox/virtvboxd.init.in | 26 +++++++++++++ src/vz/Makefile.inc.am | 10 +++++ src/vz/virtvzd.init.in | 26 +++++++++++++ 30 files changed, 587 insertions(+), 2 deletions(-) create mode 100644 src/interface/virtinterfaced.init.in create mode 100644 src/libxl/virtxend.init.in create mode 100644 src/lxc/virtlxcd.init.in create mode 100644 src/network/virtnetworkd.init.in create mode 100644 src/node_device/virtnodedevd.init.in create mode 100644 src/nwfilter/virtnwfilterd.init.in create mode 100644 src/qemu/virtqemud.init.in create mode 100644 src/remote/libvirtd.confd create mode 100644 src/remote/libvirtd.init.in create mode 100644 src/remote/virtproxyd.confd create mode 100644 src/remote/virtproxyd.init.in create mode 100644 src/secret/virtsecretd.init.in create mode 100644 src/storage/virtstoraged.init.in create mode 100644 src/vbox/virtvboxd.init.in create mode 100644 src/vz/virtvzd.init.in -- 2.23.0

2 4

[libvirt] [PATCH RESEND 0/4] Add support for Hygon Dhyana CPU
by Yingle Hou 13 Dec '19

13 Dec '19

As a Joint Venture between AMD and Haiguang Information Technology Co., Ltd., Hygon aims to provide x86 server processor in China market. The first generation processor Dhyana (family 18h) shares similar architecture with AMD family 17h. As Dhyana support in QEMU already have been merged in qemu-4.1.0 [1], to add Dhyana support in libvirt, we have added a new Dhyana CPU model file x86_Dhyana.xml in cpu_map directory, and also we have added a series of Dhyana test files. We have tested the patches on Hygon Dhyana machine with the result that it has successfully worked as expected. Reference: [1] https://patchwork.kernel.org/patch/10902889/ Yingle Hou (4): cpu: Remove the verification conditions of the model in the x86 signatures cpu: Add new Dhyana CPU model cputest: Add CPUID data for Hygon Dhyana 7185 32-core Processor domaincapstest: Add CPU model Dhyana to QEMU src/cpu/cpu_x86.c | 2 +- src/cpu_map/Makefile.inc.am | 1 + src/cpu_map/index.xml | 3 + src/cpu_map/x86_Dhyana.xml | 70 + src/cpu_map/x86_vendors.xml | 1 + tests/cputest.c | 1 + ...86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml | 7 + ...x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml | 9 + .../x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml | 16 + .../x86_64-cpuid-Hygon-C86-7185-32-core-host.xml | 17 + .../x86_64-cpuid-Hygon-C86-7185-32-core-json.xml | 12 + .../x86_64-cpuid-Hygon-C86-7185-32-core.json | 1631 ++++++++++++++++++++ .../x86_64-cpuid-Hygon-C86-7185-32-core.sig | 4 + .../x86_64-cpuid-Hygon-C86-7185-32-core.xml | 54 + tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + 20 files changed, 1833 insertions(+), 1 deletion(-) create mode 100644 src/cpu_map/x86_Dhyana.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.json create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.xml -- 1.8.3.1

2 9

[libvirt] [PATCH] docs: remove link to virsh cmd ref & app dev guide
by Daniel P. Berrangé 13 Dec '19

13 Dec '19

Both the application developer guide and virsh command reference are unmaintained for best part of 8 years, and so horrifically out of date. This does not give a good impression to people reading the docs. Now that we are publishing the man pages online, those are a better doc to read for virsh. We can also highlight the API reference instead of the app dev guide. The virsh command reference & app dev guide will still exist on the web root, but will not be linked to. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/docs.html.in | 48 +++++++++++++++++++++-------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/docs/docs.html.in b/docs/docs.html.in index b592f7d51f..004f099a9f 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -54,11 +54,27 @@ <div class="panel"> <h2>Application development</h2> <dl> - <dt><a href="devguide.html">Development Guide</a></dt> - <dd>A guide and reference for developing with libvirt</dd> - - <dt><a href="virshcmdref.html">Virsh Commands</a></dt> - <dd>Command reference for virsh</dd> + <dt><a href="html/index.html">API reference</a></dt> + <dd>Reference manual for the C public API, split in + <a href="html/libvirt-libvirt-common.html">common</a>, + <a href="html/libvirt-libvirt-domain.html">domain</a>, + <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, + <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, + <a href="html/libvirt-virterror.html">error</a>, + <a href="html/libvirt-libvirt-event.html">event</a>, + <a href="html/libvirt-libvirt-host.html">host</a>, + <a href="html/libvirt-libvirt-interface.html">interface</a>, + <a href="html/libvirt-libvirt-network.html">network</a>, + <a href="html/libvirt-libvirt-nodedev.html">node device</a>, + <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, + <a href="html/libvirt-libvirt-secret.html">secret</a>, + <a href="html/libvirt-libvirt-storage.html">storage</a>, + <a href="html/libvirt-libvirt-stream.html">stream</a> + and + <a href="html/index-admin.html">admin</a>, + <a href="html/index-qemu.html">QEMU</a>, + <a href="html/index-lxc.html">LXC</a> libs + </dd> <dt><a href="bindings.html">Language bindings and API modules</a></dt> <dd>Bindings of the libvirt API for @@ -97,28 +113,6 @@ <dt><a href="cgroups.html">CGroups</a></dt> <dd>Control groups integration</dd> - <dt><a href="html/index.html">API reference</a></dt> - <dd>Reference manual for the C public API, split in - <a href="html/libvirt-libvirt-common.html">common</a>, - <a href="html/libvirt-libvirt-domain.html">domain</a>, - <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, - <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, - <a href="html/libvirt-virterror.html">error</a>, - <a href="html/libvirt-libvirt-event.html">event</a>, - <a href="html/libvirt-libvirt-host.html">host</a>, - <a href="html/libvirt-libvirt-interface.html">interface</a>, - <a href="html/libvirt-libvirt-network.html">network</a>, - <a href="html/libvirt-libvirt-nodedev.html">node device</a>, - <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, - <a href="html/libvirt-libvirt-secret.html">secret</a>, - <a href="html/libvirt-libvirt-storage.html">storage</a>, - <a href="html/libvirt-libvirt-stream.html">stream</a> - and - <a href="html/index-admin.html">admin</a>, - <a href="html/index-qemu.html">QEMU</a>, - <a href="html/index-lxc.html">LXC</a> libs - </dd> - <dt><a href="drivers.html">Drivers</a></dt> <dd>Hypervisor specific driver information</dd> -- 2.21.0

2 1

[libvirt] [dockerfiles PATCH] Drop Dockerfile for mips cross-builds on Debian sid
by Andrea Bolognani 13 Dec '19

13 Dec '19

The Debian project has dropped support for the architecture. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfiles maintainance rule. Text diff below. buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1010 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 buildenv-libvirt-debian-sid-cross-mips.zip diff --git a/buildenv-libvirt-debian-sid-cross-mips.zip b/buildenv-libvirt-debian-sid-cross-mips.zip deleted file mode 100644 index 287fa12..0000000 --- a/buildenv-libvirt-debian-sid-cross-mips.zip +++ /dev/null @@ -1,112 +0,0 @@ -FROM debian:sid - -RUN export DEBIAN_FRONTEND=noninteractive && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - augeas-lenses \ - augeas-tools \ - autoconf \ - automake \ - autopoint \ - bash \ - bash-completion \ - ca-certificates \ - ccache \ - chrony \ - dnsmasq-base \ - dwarves \ - ebtables \ - flake8 \ - gcc \ - gdb \ - gettext \ - git \ - iproute2 \ - kmod \ - libc-dev-bin \ - libtool \ - libtool-bin \ - libxml2-utils \ - locales \ - lsof \ - lvm2 \ - make \ - meson \ - net-tools \ - nfs-common \ - ninja-build \ - numad \ - open-iscsi \ - parted \ - patch \ - perl \ - pkgconf \ - policykit-1 \ - python3 \ - python3-docutils \ - python3-setuptools \ - qemu-utils \ - radvd \ - screen \ - scrub \ - strace \ - sudo \ - vim \ - xsltproc \ - zfs-fuse && \ - apt-get autoremove -y && \ - apt-get autoclean -y && \ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ - dpkg-reconfigure locales - -RUN export DEBIAN_FRONTEND=noninteractive && \ - dpkg --add-architecture mips && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - gcc-mips-linux-gnu \ - libacl1-dev:mips \ - libapparmor-dev:mips \ - libattr1-dev:mips \ - libaudit-dev:mips \ - libavahi-client-dev:mips \ - libblkid-dev:mips \ - libc6-dev:mips \ - libcap-ng-dev:mips \ - libcurl4-gnutls-dev:mips \ - libdbus-1-dev:mips \ - libdevmapper-dev:mips \ - libfuse-dev:mips \ - libglib2.0-dev:mips \ - libglusterfs-dev:mips \ - libgnutls28-dev:mips \ - libiscsi-dev:mips \ - libncurses-dev:mips \ - libnl-3-dev:mips \ - libnl-route-3-dev:mips \ - libnuma-dev:mips \ - libparted-dev:mips \ - libpcap0.8-dev:mips \ - libpciaccess-dev:mips \ - librbd-dev:mips \ - libreadline-dev:mips \ - libsanlock-dev:mips \ - libsasl2-dev:mips \ - libselinux1-dev:mips \ - libssh-gcrypt-dev:mips \ - libssh2-1-dev:mips \ - libtirpc-dev:mips \ - libudev-dev:mips \ - libxml2-dev:mips \ - libyajl-dev:mips \ - xfslibs-dev:mips && \ - apt-get autoremove -y && \ - apt-get autoclean -y - -ENV LANG "en_US.UTF-8" - -ENV ABI "mips-linux-gnu" -ENV CONFIGURE_OPTS "--host=mips-linux-gnu \ - --target=mips-linux-gnu" -ENV PKG_CONFIG_LIBDIR "/usr/lib/mips-linux-gnu/pkgconfig" -- 2.23.0

1 0

[libvirt] [PATCH] gitlab: Move mips job to Debian 9
by Andrea Bolognani 13 Dec '19

13 Dec '19

Support for the mips architecture has been dropped from Debian sid. Move the mipsel job from Debian 9 to Debian sid at the same time to keep things balanced. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3915a37a90..ea49c6178b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -17,9 +17,9 @@ debian-9-cross-mips64el: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips64el:latest -debian-9-cross-mipsel: +debian-9-cross-mips: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mipsel:latest + image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips:latest debian-10-cross-aarch64: <<: *job_definition @@ -41,6 +41,6 @@ debian-sid-cross-i686: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-i686:latest -debian-sid-cross-mips: +debian-sid-cross-mipsel: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mips:latest + image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mipsel:latest -- 2.23.0

2 1

[libvirt] [PATCH 0/2] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR bits for TAA
by Jiri Denemark 13 Dec '19

13 Dec '19

CVE-2019-11135 TAA_NO and TSX_CTRL are new IA32_ARCH_CAPABILITIES MSR bits related to the TSX Asynchronous Abort (TAA) vulnerability. See [1] and [2] for details about the issue and mitigations. [1] https://software.intel.com/security-software-guidance/insights/deep-dive-in… [2] https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.… Jiri Denemark (2): cpu_map: Add TAA_NO bit for IA32_ARCH_CAPABILITIES MSR cpu_map: Add TSX_CTRL bit for IA32_ARCH_CAPABILITIES MSR src/cpu_map/x86_features.xml | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.24.1

2 3

[libvirt] [PATCH] qemu: snapshot: Fix libvirtd crash in snapshot-revert
by Lin Ma 13 Dec '19

13 Dec '19

When reverting a running domain to a snapshot(active state), We need to use the FORCE flag for snapshot-revert if current domain configuration is different from the target domain configuration, and this will start a new qemu instance for the target domain. In this situation, if there is existing connection to the domain, say Spice or VNC through virt-manager, Then the libvirtd would crash during snapshot revert because: Both of snapshot revert worker and new worker job 'remoteDispatchDomainOpenGraphicsFd' are waiting for mon->msg->finished in qemuMonitorSend(), We know if IO process resulted in an error with a message, Libvirtd main thread calls qemuMonitorIO() to wakeup the waiter. Then mon->msg will be set to NULL in qemuMonitorSend() once the worker GraphicsFD is woken up, which causes snapshot revert worker dereferences this null pointer. Not sure whether this scenario makes sense, But at least the libvirtd should not crash, So fix it. Thread 6 "libvirtd" hit Breakpoint 1, qemuMonitorSend 987 if (mon->lastError.code != VIR_ERR_OK) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONSendFileHandle #3 in qemuMonitorSendFileHandle #4 in qemuMonitorOpenGraphics #5 in qemuDomainOpenGraphicsFD #6 in virDomainOpenGraphicsFD #7 in remoteDispatchDomainOpenGraphicsFd #8 in remoteDispatchDomainOpenGraphicsFdHelper #9 in virNetServerProgramDispatchCall #10 in virNetServerProgramDispatch #11 in virNetServerProcessMsg #12 in virNetServerHandleJob #13 in virThreadPoolWorker #14 in virThreadHelper #15 in start_thread #16 in clone (gdb) c Continuing. Thread 2 "libvirtd" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fbd20fe2700 (LWP 19014)] 0x00007fbd1c3be838 in qemuMonitorSend (mon=mon@entry=0x7fbd1804a940, msg=msg@entry=0x7fbd20fe15b0) at ../../src/qemu/qemu_monitor.c:1001 1001 while (!mon->msg->finished) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONCommand #3 in qemuMonitorJSONGetChardevInfo #4 in qemuMonitorGetChardevInfo #5 in qemuProcessWaitForMonitor #6 in qemuProcessLaunch #7 in qemuProcessStart #8 in qemuDomainRevertToSnapshot #9 in virDomainRevertToSnapshot #10 in remoteDispatchDomainRevertToSnapshot #11 in remoteDispatchDomainRevertToSnapshotHelper #12 in virNetServerProgramDispatchCall #13 in virNetServerProgramDispatch #14 in virNetServerProcessMsg #15 in virNetServerHandleJob #16 in virThreadPoolWorker #17 in virThreadHelper #18 in start_thread #19 in clone Signed-off-by: Lin Ma <lma(a)suse.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index ea3e62dc8e..a8344e698b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -994,7 +994,7 @@ qemuMonitorSend(qemuMonitorPtr mon, "mon=%p msg=%s fd=%d", mon, mon->msg->txBuffer, mon->msg->txFD); - while (!mon->msg->finished) { + while (mon->msg && !mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unable to wait on monitor condition")); -- 2.23.0

4 4

[libvirt] [dockerfiles PATCH 0/2] Refresh and add openSUSE Leap 15.1
by Andrea Bolognani 13 Dec '19

13 Dec '19

Pushed under the Dockerfile refresh rule. Text diffs are provided. Andrea Bolognani (2): Refresh Dockerfiles after recent changes Add openSUSE Leap 15.1 Dockerfile for libvirt buildenv-libosinfo-centos-7.zip | Bin 570 -> 1659 bytes buildenv-libosinfo-centos-8.zip | Bin 586 -> 589 bytes buildenv-libvirt-centos-7.zip | Bin 758 -> 1878 bytes buildenv-libvirt-centos-8.zip | Bin 791 -> 793 bytes buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 1016 -> 1021 bytes buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 1009 -> 1014 bytes buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-10-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-10-cross-mips.zip | Bin 1003 -> 1011 bytes buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 1007 -> 1016 bytes buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 1019 -> 1024 bytes buildenv-libvirt-debian-10-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-10.zip | Bin 904 -> 908 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 1048 -> 1053 bytes buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 1039 -> 1045 bytes buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 1045 -> 1050 bytes buildenv-libvirt-debian-9-cross-mips.zip | Bin 1039 -> 1044 bytes buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 1051 -> 1056 bytes buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 1043 -> 1048 bytes buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 1053 -> 1057 bytes buildenv-libvirt-debian-9-cross-s390x.zip | Bin 1040 -> 1045 bytes buildenv-libvirt-debian-9.zip | Bin 934 -> 938 bytes buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 1015 -> 1020 bytes buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 1009 -> 1013 bytes buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-sid-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1006 -> 1010 bytes ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 1011 -> 1016 bytes buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 1018 -> 1023 bytes buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-sid.zip | Bin 904 -> 908 bytes buildenv-libvirt-opensuse-151.zip | Bin 0 -> 761 bytes buildenv-libvirt-ubuntu-1604.zip | Bin 939 -> 942 bytes buildenv-libvirt-ubuntu-1804.zip | Bin 941 -> 943 bytes 36 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 buildenv-libvirt-opensuse-151.zip -- 2.23.0

1 2