- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] vircgroupv2devices: Avoid double close on map FD
by Michal Privoznik 06 Jan '20

06 Jan '20

*** BLURB HERE *** Michal Prívozník (2): vircgroupv2devices: Unexport virCgroupV2DevicesAttachProg() vircgroupv2devices: Avoid double close on map FD src/libvirt_private.syms | 1 - src/util/vircgroupv2devices.c | 29 +++++------------------------ src/util/vircgroupv2devices.h | 5 ----- 3 files changed, 5 insertions(+), 30 deletions(-) -- 2.24.1

2 3

[libvirt] [PATCH] qemu: backup: Move capability check after inactive check
by Peter Krempa 06 Jan '20

06 Jan '20

Inactive VM doesn't have qemuCaps set thus we'd never properly report that VM backups are supported only for running VMs. Move the capability check after the active check. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_backup.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index c0445e0869..86b10a2b8a 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -750,12 +750,6 @@ qemuBackupBegin(virDomainObjPtr vm, virCheckFlags(VIR_DOMAIN_BACKUP_BEGIN_REUSE_EXTERNAL, -1); - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("incremental backup is not supported yet")); - return -1; - } - if (!(def = virDomainBackupDefParseString(backupXML, priv->driver->xmlopt, 0))) return -1; @@ -793,6 +787,12 @@ qemuBackupBegin(virDomainObjPtr vm, goto endjob; } + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("incremental backup is not supported yet")); + goto endjob; + } + if (priv->backup) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("another backup job is already running")); -- 2.24.1

2 1

[libvirt] [PATCH] util: time: Fix comment for virTimeFieldsNow
by Peter Krempa 06 Jan '20

06 Jan '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Trivial. diff --git a/src/util/virtime.c b/src/util/virtime.c index 54466b2f39..13f899cb91 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -223,7 +223,7 @@ int virTimeMillisNow(unsigned long long *now) /** - * virTimeFieldsNowRaw: + * virTimeFieldsNow: * @fields: filled with current time fields * * Retrieves the current time, in broken-down field format. -- 2.24.1

1 0

[libvirt] stream does not work in non-block mode with event loop implementation on Fibers
by senid senid 06 Jan '20

06 Jan '20

*libvirt_stream_event_add_callback* creates *passthrough* variable using *rb_ary_new2* and pass it to *virStreamEventAddCallback* at *ext/libvirt/stream.c:272*. After that ruby garbage collector removes this variable (I think because there is no references for *passthrough* in ruby code). https://bugzilla.redhat.com/show_bug.cgi?id=1787914#

1 0

[libvirt] [PATCH 00/23] Take 64 gnulib modules, eliminate 14, to give 50 remaining
by Daniel P. Berrangé 06 Jan '20

06 Jan '20

In the last days before the xmas break I took some time to eliminate 14 more gnulib modules, bringing us down to just 50 left to go. They're getting harder to eliminate as we go on, but to give some hints, I've annotated every module in bootstrap.conf with a suggested replacement strategy. Daniel P. Berrangé (23): build: set min version for CLang to 3.4 / XCode CLang to 5.1 docs: expand macOS platform support coverage travis: add macOS Xcode 11.3 testing util: add note about event file descriptors on Windows src: always pull in glib/gstdio.h header src: switch to use g_setenv/g_unsetenv util: add compat wrapper for g_fsync src: use g_fsync for portability util: introduce virFileDataSync src: use g_lstat() instead of lstat() src: switch from fnmatch to g_pattern_match_simple src: replace clock_gettime()/gettimeofday() with g_get_real_time() src: replace last_component() with g_path_get_basename() util: replace IS_ABSOLUTE_FILE_NAME with g_path_is_absolute src: replace mdir_name() with g_path_get_dirname() src: remove unused imports of dirname.h src: replace getcwd() with g_get_current_dir() util: use realpath/g_canonicalize_filename util: replace gethostname() with g_get_hostname() src: replace WSAStartup with g_networking_init() src: replace strptime()/timegm()/mktime() with GDateTime APIs set bootstrap: remove now unused gnulib modules bootstrap: annotate with info about desired replacement .travis.yml | 15 ++ bootstrap.conf | 173 +++++++++++++++--------- build-aux/syntax-check.mk | 4 +- config-post.h | 18 ++- docs/platforms.html.in | 13 +- include/libvirt/libvirt-event.h | 4 + m4/virt-glib.m4 | 2 +- src/conf/domain_conf.c | 32 ++--- src/conf/moment_conf.c | 7 +- src/conf/node_device_conf.c | 6 +- src/esx/esx_vi_types.c | 71 +--------- src/internal.h | 4 +- src/libvirt.c | 25 +--- src/libvirt_private.syms | 2 + src/libxl/libxl_driver.c | 21 +-- src/locking/lock_driver_sanlock.c | 6 +- src/node_device/node_device_udev.c | 12 +- src/nwfilter/nwfilter_dhcpsnoop.c | 2 +- src/qemu/qemu_backup.c | 5 +- src/qemu/qemu_command.c | 1 - src/qemu/qemu_domain.c | 14 +- src/qemu/qemu_driver.c | 7 +- src/qemu/qemu_firmware.c | 4 +- src/qemu/qemu_tpm.c | 33 +---- src/remote/libvirtd.conf.in | 8 +- src/rpc/virnetsaslcontext.c | 11 +- src/rpc/virnetsocket.c | 5 +- src/rpc/virnettlscontext.c | 10 +- src/security/security_dac.c | 2 +- src/security/virt-aa-helper.c | 8 +- src/storage/storage_backend_disk.c | 9 +- src/storage/storage_driver.c | 1 - src/storage/storage_util.c | 11 +- src/test/test_driver.c | 51 ++----- src/util/glibcompat.c | 13 ++ src/util/glibcompat.h | 6 + src/util/iohelper.c | 2 +- src/util/vircgroupv1.c | 4 +- src/util/virevent.c | 7 + src/util/virfile.c | 49 ++++--- src/util/virfile.h | 2 + src/util/virlog.c | 22 +-- src/util/virmdev.c | 12 +- src/util/virnetdev.c | 5 +- src/util/virpci.c | 17 ++- src/util/virstoragefile.c | 13 +- src/util/virsystemd.c | 4 +- src/util/virtime.c | 22 +-- src/util/virutil.c | 12 +- src/vbox/vbox_XPCOMCGlue.c | 4 +- src/vmware/vmware_conf.c | 7 +- src/vz/vz_sdk.c | 10 +- tests/eventtest.c | 18 +-- tests/libxlxml2domconfigtest.c | 4 +- tests/lxcxml2xmltest.c | 2 +- tests/qemudomaincheckpointxml2xmltest.c | 2 +- tests/qemudomainsnapshotxml2xmltest.c | 2 +- tests/qemufirmwaretest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumemlocktest.c | 2 +- tests/qemusecuritytest.c | 4 +- tests/qemuvhostusertest.c | 2 +- tests/qemuxml2argvtest.c | 24 ++-- tests/qemuxml2xmltest.c | 4 +- tests/securityselinuxhelper.c | 4 +- tests/testutils.c | 15 +- tests/testutils.h | 6 +- tests/testutilsqemu.c | 4 +- tests/vircgrouptest.c | 16 +-- tests/virconfdata/libvirtd.conf | 8 +- tests/virconfdata/libvirtd.out | 8 +- tests/virfilemock.c | 12 +- tests/virfiletest.c | 4 +- tests/virhostdevtest.c | 2 +- tests/virnettlscontexttest.c | 2 +- tests/virnettlssessiontest.c | 2 +- tests/virpcimock.c | 3 +- tests/virpcitest.c | 2 +- tests/virportallocatortest.c | 2 +- tests/virstoragetest.c | 1 - tests/virsystemdtest.c | 46 +++---- tests/virtimetest.c | 4 +- tools/virsh-domain.c | 10 +- tools/virt-login-shell-helper.c | 17 ++- tools/vsh.c | 27 +--- tools/vsh.h | 1 - 86 files changed, 470 insertions(+), 602 deletions(-) -- 2.24.1

3 31

[libvirt] [PATCH 00/11] qemu: backup: Fixes and improvements
by Peter Krempa 06 Jan '20

06 Jan '20

I've got a report of pull-mode backup not working properly. While investigating I've found out few other problems and one regression caused by a recent patch. All of those are fixed below. Additionally the last 3 patches are RFC and were created based on the discussion on qemu-block and I don't really intend to push them right away. At least until the discussion there is over: https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00416.html Peter Krempa (11): qemu: block: Use proper asyncJob when waiting for completion of blockdev-create qemu: Reset the node-name allocator in qemuDomainObjPrivateDataClear qemu: backup: Configure backup store image with backing file qemu: backup: Move deletion of backup images to job termination qemu: blockjob: Remove infrastructure for remembering to delete image qemu: backup: Properly propagate async job type when cancelling the job qemu: process: Terminate backup job on VM destroy schemas: backup: Remove pointless <choice> for 'name' of backup disk RFC: conf: backup: Allow configuration of names exported via NBD qemu: backup: Implement support for backup disk export name configuration qemu: backup: Implement support for backup disk bitmap name configuration docs/formatbackup.html.in | 9 +++ docs/schemas/domainbackup.rng | 16 ++-- src/conf/backup_conf.c | 11 +++ src/conf/backup_conf.h | 2 + src/qemu/qemu_backup.c | 77 +++++++++++++------ src/qemu/qemu_backup.h | 10 ++- src/qemu/qemu_block.c | 4 +- src/qemu/qemu_blockjob.c | 20 +---- src/qemu/qemu_blockjob.h | 2 - src/qemu/qemu_domain.c | 10 +-- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 8 +- .../backup-pull-seclabel.xml | 2 +- .../backup-pull-seclabel.xml | 2 +- .../qemustatusxml2xmldata/backup-pull-in.xml | 1 - 15 files changed, 110 insertions(+), 66 deletions(-) -- 2.23.0

4 29

[libvirt] [PATCH] Cleaning up pools is not always ideal
by ebenner 06 Jan '20

06 Jan '20

Libvirt cleans up pools that error out by deactivating them. When using LVM this is not very useful. We rather would have our own system handle any real failures and to many situations where errors are meaningless and unimportant cause Libvirt to disable our pools continuously causing lots of grief. This patch is what we use to add a config option to disable this behavior. An example of one of the issues we encountered requiring this patch is a race condition between Libvirt and LVM. Pool refreshes will hand if LVM is having an action performed, then Libvirt will continue when LVM finishes. When a pool is being refreshed while an LV is being removed, the refresh hangs as expected, when the removal is completed the refresh continues. Afterwards when the refresh goes to refresh the specific LV it errors because it cannot be found and the entire pool is disabled. Bellow are two commands when run together reliably recreates the issue. while :; do lvcreate /dev/vgpool --name TEST -L 100G && lvremove -f /dev/vgpool/TEST; done while :; do virsh pool-refresh vgpool; done I am aware this is not the most elegant solution here and am up for suggestions for resolving the underlying issue, however we never need our pools to be disabled because of an error and I am sure there are other's who's usecase may be similar. --- src/remote/libvirtd.conf.in | 7 +++++++ src/storage/storage_driver.c | 38 ++++++++++++++++++++++++++++++++---- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/src/remote/libvirtd.conf.in b/src/remote/libvirtd.conf.in index 34741183cc..5600c26eca 100644 --- a/src/remote/libvirtd.conf.in +++ b/src/remote/libvirtd.conf.in @@ -506,3 +506,10 @@ # potential infinite waits blocking libvirt. # #ovs_timeout = 5 + +################################################################### +# This decides whether to disable pools that errors in some way such as during a refresh +# This can negatively affect LVM pools. 1 = disable the pools, 2 = don't disable the pools +# Do not use this if you are not using only LVM pools +# +cleanup_pools = 1 diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 6bbf52f729..93ebcd662c 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -55,6 +55,7 @@ VIR_LOG_INIT("storage.storage_driver"); static virStorageDriverStatePtr driver; +static int cleanup_pools = -1; static int storageStateCleanup(void); @@ -74,6 +75,20 @@ static void storageDriverUnlock(void) virMutexUnlock(&driver->lock); } +static int cleanupPools(void) +{ + if (cleanup_pools == -1) { + g_autoptr(virConf) libvirtConf = NULL; + virConfLoadConfig(&libvirtConf, "libvirtd.conf"); + + if (!virConfGetValueInt(libvirtConf, "cleanup_pools", &cleanup_pools) + || (cleanup_pools != 0 && cleanup_pools != 1)) + cleanup_pools = 1; + } + + return cleanup_pools; +} + static void storagePoolRefreshFailCleanup(virStorageBackendPtr backend, @@ -81,14 +96,26 @@ storagePoolRefreshFailCleanup(virStorageBackendPtr backend, const char *stateFile) { virErrorPtr orig_err; - virErrorPreserveLast(&orig_err); virStoragePoolObjClearVols(obj); if (stateFile) unlink(stateFile); - if (backend->stopPool) - backend->stopPool(obj); + + if (!cleanupPools()) { + virStoragePoolDefPtr def = virStoragePoolObjGetDef(obj); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to refresh storage pool '%s'. Would have disabled this pool but clean_pools = 0: %s"), + def->name, virGetLastErrorMessage()); + } else { + virStoragePoolDefPtr def = virStoragePoolObjGetDef(obj); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to refresh storage pool '%s'. Disabled this pool because clean_pools = 1: %s"), + def->name, virGetLastErrorMessage()); + if (backend->stopPool) { + backend->stopPool(obj); + } + } virErrorRestore(&orig_err); } @@ -101,7 +128,10 @@ storagePoolRefreshImpl(virStorageBackendPtr backend, virStoragePoolObjClearVols(obj); if (backend->refreshPool(obj) < 0) { storagePoolRefreshFailCleanup(backend, obj, stateFile); - return -1; + if (!cleanupPools()) + return 0; + else + return -1; } return 0; -- 2.24.1

1 0

[libvirt] [PATCH v2 00/12] Various bhyve driver improvements for FreeBSD
by Ryan Moeller 05 Jan '20

05 Jan '20

The main changes are: * Add support for standard hooks in bhyve backend: - prepare - start - started - stopped - release * Some code cleanup & general housekeeping in bhyve backend * Add support for reboot in bhyve backend, both from within the VM and from the host Ryan Moeller (12): Add hooks for bhyve backend Fix build errors on FreeBSD Simplify bhyve driver caps helpers Remove redundant parameter to virBhyveProcessStart() Factor out conn Fix indentation Eliminate rc variable Make bhyveMonitor a virClass Don't bother seeking to the end of a file opened O_APPEND Add reboot support for bhyve backend Fix bhyvexml2argvtest Add missing virtlogd.init for OpenRC src/bhyve/bhyve_command.c | 40 ++++----- src/bhyve/bhyve_command.h | 4 +- src/bhyve/bhyve_driver.c | 67 ++++++++++---- src/bhyve/bhyve_driver.h | 4 +- src/bhyve/bhyve_monitor.c | 165 +++++++++++++++++++++++------------ src/bhyve/bhyve_monitor.h | 2 + src/bhyve/bhyve_process.c | 106 +++++++++++++++------- src/bhyve/bhyve_process.h | 4 +- src/conf/virnetworkobj.c | 7 +- src/logging/Makefile.inc.am | 10 +++ src/logging/virtlogd.init.in | 14 +++ src/util/virhook.c | 15 ++++ src/util/virhook.h | 11 +++ tests/bhyvexml2argvtest.c | 4 +- 14 files changed, 319 insertions(+), 134 deletions(-) create mode 100644 src/logging/virtlogd.init.in -- 2.23.0

3 22

[libvirt] [PATCH] virsh: Add a completer for `domifaddr` --source parameter.
by Julio Faracco 04 Jan '20

04 Jan '20

The command `domifaddr` can use three different sources to grab IP address of a Virtual Machine: lease, agent and arp. This parameter does not have a completer function to return source options. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- tools/virsh-completer-domain.c | 17 +++++++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain-monitor.c | 1 + 3 files changed, 23 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 0311ee50d0..c8709baa38 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -296,3 +296,20 @@ virshDomainShutdownModeCompleter(vshControl *ctl, return virshCommaStringListComplete(mode, modes); } + + +char ** +virshDomainIfAddrSourceCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags) +{ + const char *sources[] = {"lease", "agent", "arp", NULL}; + const char *source = NULL; + + virCheckFlags(0, NULL); + + if (vshCommandOptStringQuiet(ctl, cmd, "source", &source) < 0) + return NULL; + + return virshCommaStringListComplete(source, sources); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index 083ab327cc..f5e5625051 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -53,3 +53,8 @@ char ** virshDomainDeviceAliasCompleter(vshControl *ctl, char ** virshDomainShutdownModeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshDomainIfAddrSourceCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 30b186ffd1..1d1f87eb9e 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2346,6 +2346,7 @@ static const vshCmdOptDef opts_domifaddr[] = { {.name = "source", .type = VSH_OT_STRING, .flags = VSH_OFLAG_NONE, + .completer = virshDomainIfAddrSourceCompleter, .help = N_("address source: 'lease', 'agent', or 'arp'")}, {.name = NULL} }; -- 2.20.1

3 4

[libvirt] [PULL 0/3] Block patches
by Stefan Hajnoczi 03 Jan '20

03 Jan '20

The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 15:55:20 +0000) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 725fe5d10dbd4259b1853b7d253cef83a3c0d22a: virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh (2019-12-19 16:20:25 +0000) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Li Hangjing (1): virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh Stefan Hajnoczi (2): virtio-blk: deprecate SCSI passthrough docs: fix rst syntax errors in unbuilt docs docs/arm-cpu-features.rst | 6 +++--- docs/virtio-net-failover.rst | 4 ++-- docs/virtio-pmem.rst | 19 ++++++++++--------- hw/block/dataplane/virtio-blk.c | 2 +- qemu-deprecated.texi | 11 +++++++++++ 5 files changed, 27 insertions(+), 15 deletions(-) -- 2.23.0

2 4