- Devel - libvirt List Archives

[PATCH] virauth: Verify virConnectAuth::cb is set in virAuthGetPasswordPath()
by Michal Privoznik 18 May '26

18 May '26

From: Michal Privoznik <mprivozn(a)redhat.com> Simirarly to virAuthGetUsernamePath() check whether callback used to collect credentials is actually set before calling it. This bug is easily reproducible, for instance as: int credtype[] = { VIR_CRED_PASSPHRASE }; virConnectPtr conn = virConnectOpenAuth("esx://root@example.com/", &(virConnectAuth){ .credtype = credtype, .ncredtype = 1, .cb = NULL }, 0); Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virauth.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/util/virauth.c b/src/util/virauth.c index fd4b13de7a..2820220897 100644 --- a/src/util/virauth.c +++ b/src/util/virauth.c @@ -229,6 +229,12 @@ virAuthGetPasswordPath(const char *path, return NULL; } + if (!auth->cb) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("Missing authentication callback")); + return NULL; + } + prompt = g_strdup_printf(_("Enter %1$s's password for %2$s"), username, hostname); if (!(cred = virAuthAskCredential(auth, prompt, false))) -- 2.53.0

2 1

[PATCH v7 0/4] nwfilter: add nwfilter nftables driver
by Dion Bosschieter 18 May '26

18 May '26

This series aims to implement nftables as a backend driver for the nwfilter feature. The idea is that it will replace the ebiptables driver and provide an easy way for users to switch from one driver to another. The 1st patch introduces the new nwfilter driver. After which nwfilter allows users to choose it in the 2nd patch. The third patch introduces unit testing of the new nftables driver. Finally the last patch introduces a new element to the nwfilterbinding XML which is used to detect and run a cleanup on the old firewall rules defined via the previous used nwfilter firewall backend. - Implemented very basic nwfilter.conf reading, choosing a nwfilter driver based on the name of the drivers (nftables/ebiptables). Defaults to the nftables driver, based on the firewall_backend_priority meson option, following the bridge driver logic. - Implemented nft tracing and counters usable via nwfilter.conf options "enable_trace" and "enable_counters" - Resolves issue https://gitlab.com/libvirt/libvirt/-/issues/603, benchmarks showed that the amount of iifname jumps for each interface in the root chains is the cause for this. Switched the nftables driver towards a vmap (verdict map) so we can have 1 rule that jumps to the correct root input/output chain per interface. Which improves throughput as when the number of interface check and jump rules increases the throughput decreases. The issue describes the interface matching works using the interface name and the majority of the effort is the strncpy, this patch also switches nftables to an interface_index compare instead. However, just using the interface_index is not enough, the amount of oif and iif jump rules causes quite the performance degradation, the vmap instead solves this. - Split rules into separate tables: "libvirt_nwfilter_ethernet" and "libvirt_nwfilter_inet" to preserve existing firewall behavior. - Reworked chain logic for clarity with root -input/-output chains per interface. input in the VM interface is filtered in the -input chain(s), output out of the VM inteface is filtered in the -output chain(s). - Stuck with prerouting and postrouting as hooks for input / output on the _ethernet and _inet table. This makes it easier to merge the tables in the future. Saving management of two tables and decreasing the amount of tables a packet sees. Currently ebtables filtering happens via PREROUTING and POSTROUTING hooks, while ip/ip6tables filtering happens in the output/forward hooks. - Stuck with 2 tables for compatibility reasons with eb iptables, unifying into 1 table will break users firewall definitions, which depend on being able to do accepts on ethernet rules (which currently get defined via ebtables) and additional filtering via the ip rules (which currently get defined via ip(6)tables). The nwfilter_nftables_driver keeps splitting the ethernet and inet rules in seperate tables "libvirt-nwfilter-ethernet" and "libvirt-nwfilter-other". - Rewrote chain logic, so it is easier to understand, input in the VM interface is filtered in the -input chain(s), output out of the VM inteface is filtered in the -output chain(s). _ethernet and _inet table follow the same style and hook in the same way. - Simplified conntrack handling: rules with accept+conntrack are duplicated to the opposite chain for symmetric behavior, to support the existing ebiptables logic. - Firewall updates continue use tmp names for atomic replacement. Unsupported nwfilter features (for now): - IPSets (potential future support via nft sets) - Reject due to filtering in pre/postrouting, using drop instead of reject, copying logic from existing ebiptables ebtables actions Future improvements: - Use `nft -f` for atomic rule application. - Optional single-table mode via nwfilter.conf. - Optimize boot phase with chain hash comparison. --- Changes in v7: - Add backend XML element to virnwfilterbinding, to support switching from nwfilter firewall backend Changes in v6: - Add STP support - Add GARP support - Remove comment "priority=%" leftover from debugging Changes in v5: - Fix rarp support via nft raw payload expression Changes in v4: - Fix rarp nft commands "arp saddr ether" "arp daddr ether" - Filter chain creation, don't create unnecessary chains - Apply danpb seperate argument suggestion - Fix table not existing errors in drop all rules - Fix table not existing errors in apply basic rules Changes in v3: - Renamed -other to -inet - Renamed - to _ in table names - Updated rule / chain sorting on ethernet table to to copy ebtables logic - Fix possible broken revert path - Fix remove rules not working in some cases, EBUSY - Shared functions camel case commit - Rename config option - Add extra config params, enable_trace, enable_counters This required passing the config struct to the ebip/nft nwfilter drivers - Add extra augeaus files Changes in v2: - Rename {ebip,nf}tables specific test files in 1 directory instead of seperating them in different directories. - Added default nwfilter.conf file in git, documented including augeas files - Replaced hardcoding of default driver based on existing firewall_backend_priority meson option. - Added nwfilter_driver_conf.{h,c} for configuration handling, to match the common pattern used in other drivers. Dion Bosschieter (4): nwfilter: add nwfilter nftables driver nwfilter: allow use of nftables nwfilter driver via nwfilter.conf nwfilter: add unit tests and test data for nwfilter nftables driver nwfilter: add used firewall backend to nwfilterbinding libvirt.spec.in | 7 + po/POTFILES | 2 + src/conf/schemas/nwfilterbinding.rng | 7 + src/conf/virnwfilterbindingdef.c | 17 +- src/conf/virnwfilterbindingdef.h | 1 + src/conf/virnwfilterobj.h | 20 - src/nwfilter/libvirtd_nwfilter.aug | 45 + src/nwfilter/meson.build | 38 + src/nwfilter/nwfilter.conf.in | 50 + src/nwfilter/nwfilter_driver.c | 67 +- src/nwfilter/nwfilter_driver_conf.c | 214 + src/nwfilter/nwfilter_driver_conf.h | 69 + src/nwfilter/nwfilter_ebiptables_driver.c | 4 +- src/nwfilter/nwfilter_ebiptables_driver.h | 2 +- src/nwfilter/nwfilter_gentech_driver.c | 144 +- src/nwfilter/nwfilter_gentech_driver.h | 5 +- src/nwfilter/nwfilter_nftables_driver.c | 2884 ++++++++++++++ src/nwfilter/nwfilter_nftables_driver.h | 28 + src/nwfilter/nwfilter_tech_driver.h | 3 +- src/nwfilter/test_libvirtd_nwfilter.aug.in | 7 + tests/meson.build | 2 + tests/nwfilternftablestest.c | 426 ++ .../ah-ipv6-linux.nftables.args | 298 ++ .../ah-linux.nftables.args | 292 ++ .../all-ipv6-linux.nftables.args | 280 ++ .../all-linux.nftables.args | 274 ++ .../arp-linux.nftables.args | 285 ++ .../comment-linux.nftables.args | 502 +++ .../conntrack-linux.nftables.args | 190 + .../esp-ipv6-linux.nftables.args | 298 ++ .../esp-linux.nftables.args | 292 ++ .../example-1-linux.nftables.args | 252 ++ .../example-2-linux.nftables.args | 352 ++ .../hex-data-linux.nftables.args | 368 ++ .../icmp-direction-linux.nftables.args | 226 ++ .../icmp-direction2-linux.nftables.args | 226 ++ .../icmp-direction3-linux.nftables.args | 176 + .../icmp-linux.nftables.args | 248 ++ .../icmpv6-linux.nftables.args | 316 ++ .../igmp-linux.nftables.args | 292 ++ .../ip-linux.nftables.args | 199 + .../ipt-no-macspoof-linux.nftables.args | 166 + .../ipv6-linux.nftables.args | 481 +++ .../iter1-linux.nftables.args | 292 ++ .../iter2-linux.nftables.args | 3532 +++++++++++++++++ .../iter3-linux.nftables.args | 410 ++ .../mac-linux.nftables.args | 176 + .../rarp-linux.nftables.args | 207 + .../sctp-ipv6-linux.nftables.args | 316 ++ .../sctp-linux.nftables.args | 316 ++ .../stp-linux.nftables.args | 233 ++ .../target-linux.nftables.args | 454 +++ .../target2-linux.nftables.args | 302 ++ .../tcp-ipv6-linux.nftables.args | 316 ++ .../tcp-linux.nftables.args | 452 +++ .../udp-ipv6-linux.nftables.args | 316 ++ .../udp-linux.nftables.args | 316 ++ .../udplite-ipv6-linux.nftables.args | 298 ++ .../udplite-linux.nftables.args | 292 ++ .../vlan-linux.nftables.args | 257 ++ tests/nwfilterxml2nftfirewalltest.c | 432 ++ .../filter-vars.xml | 1 + .../simple-backend.xml | 10 + tests/virnwfilterbindingxml2xmltest.c | 1 + 64 files changed, 18865 insertions(+), 119 deletions(-) create mode 100644 src/nwfilter/libvirtd_nwfilter.aug create mode 100644 src/nwfilter/nwfilter.conf.in create mode 100644 src/nwfilter/nwfilter_driver_conf.c create mode 100644 src/nwfilter/nwfilter_driver_conf.h create mode 100644 src/nwfilter/nwfilter_nftables_driver.c create mode 100644 src/nwfilter/nwfilter_nftables_driver.h create mode 100644 src/nwfilter/test_libvirtd_nwfilter.aug.in create mode 100644 tests/nwfilternftablestest.c create mode 100755 tests/nwfilterxml2firewalldata/ah-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/ah-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/all-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/all-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/arp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/comment-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/conntrack-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/esp-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/esp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/example-1-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/example-2-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/hex-data-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/icmp-direction-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/icmp-direction2-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/icmp-direction3-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/icmp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/icmpv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/igmp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/ip-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/ipt-no-macspoof-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/iter1-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/iter2-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/iter3-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/mac-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/rarp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/sctp-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/sctp-linux.nftables.args create mode 100644 tests/nwfilterxml2firewalldata/stp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/target-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/target2-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/tcp-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/tcp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/udp-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/udp-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/udplite-ipv6-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/udplite-linux.nftables.args create mode 100755 tests/nwfilterxml2firewalldata/vlan-linux.nftables.args create mode 100644 tests/nwfilterxml2nftfirewalltest.c create mode 100644 tests/virnwfilterbindingxml2xmldata/simple-backend.xml -- 2.43.0

1 4

[PATCH] util: typedparam: Fix sentinel handling in template validator
by Yaroslav Borbat 15 May '26

15 May '26

From: Yaroslav Borbat <yaroslav.752(a)gmail.com> virTypedParamsValidateTemplate() iterated templates with an inverted sentinel condition and counted entries incorrectly. This caused valid params to be rejected as unsupported, e.g. migration parameter 'disks_uri'. Fixes: a650af5002a7477cab649c44fff58bbbc909b8a8 Signed-off-by: Yaroslav Borbat <yaroslav.752(a)gmail.com> --- src/util/virtypedparam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c index 92f25cea39..530136978b 100644 --- a/src/util/virtypedparam.c +++ b/src/util/virtypedparam.c @@ -213,7 +213,7 @@ virTypedParamsValidateTemplate(virTypedParameterPtr params, /* we need to copy the list of templates because * 'virTypedParamsValidateInternal' will need to sort it */ - while (*templates[ntemplates++].name == '\0') + while (*templates[ntemplates++].name != '\0') ; templ_copy = g_new0(virTypedParamValidationTemplate, ntemplates); -- 2.54.0

1 0

[PATCH 0/3] virsh: Don't expect keyboard input from completers
by Michal Privoznik 15 May '26

15 May '26

See 3/3 for in depth explanation. After this, there's still one problem - the ssh transport (tcp+ssh://...) because virNetSocketNewConnectSSH() does not really ask for virConnectAuthCallbackPtr. There should be a way to fix it though: from bash script parse URI and append ?no_tty=1 at the end of URI. This directs virNetSocketNewConnectSSH() to execute SSH binary with BatchMode=yes which is documented to suppress keyboard interaction. If we find this ^^ needed I can try to write a patch. But for now, let's fix other transports. Michal Prívozník (3): virnetsshsession: Don't check for auth callbacks in virNetSSHAuthenticatePassword() virnetlibsshsession: Check later for auth callback in virNetLibsshAuthenticatePassword() virsh: Provide no auth callbacks for bash completer src/rpc/virnetlibsshsession.c | 14 +++++++------- src/rpc/virnetsshsession.c | 7 ------- tools/virsh.c | 10 +++++++++- 3 files changed, 16 insertions(+), 15 deletions(-) -- 2.53.0

4 8

[PATCH v2 0/5] resctrl: add energy monitoring via PERF_PKG_MON
by Jedrzej Wasiukiewicz 15 May '26

15 May '26

Linux kernel 7.0 introduced PERF_PKG_MON support in resctrl filesystem which exposes per-workload energy and performance monitoring. This series enables per-VM energy monitoring via core_energy (Joules) and activity (Farads) counters. Energy monitors can be configured through new <energytune> element under <cputune> following earlier cachetune and memorytune patterns. Design notes: Energy values from resctrl are floating-point. I added separate dvals/ndvals pair to virResctrlMonitorStats to handle them. I kept them in a single struct for easier integration with performance counters (integers and floats within same monitor) that might be integrated in another patch. The new XML element is <energytune> under <cputune> following earlier pattern for resctrl features (cachetune, memorytune). Energytune doesn't currently support the "tuning" part, only monitoring. I added it as energytune for consistency with cache and memory features, keeping all resctrl handling under cputune. This also makes sense with current resctrl architecture - all monitoring groups are part of an allocation group. This approach allows for easy opt-in/out on the monitoring features. Changes since v1 (RFC): - Split into 5 patches (see below) - Changed VIR_INFO/VIR_WARN to VIR_DEBUG - Tightened energyMonitorFeature to <choice> of core_energy/activity instead of regex - Renamed test case energytune-basic -> energytune - Minor comment cleanups in virresctrl.h Jedrzej Wasiukiewicz (5): util: add PERF_PKG_MON energy monitoring support in virresctrl conf: report energy monitoring in host capabilities conf: add energytune to domain XML qemu: resctrl energy counters via domstats NEWS: document resctrl energy monitoring NEWS.rst | 6 + docs/formatdomain.rst | 20 +++ include/libvirt/libvirt-domain.h | 65 ++++++++ src/conf/capabilities.c | 42 +++++ src/conf/capabilities.h | 6 + src/conf/domain_conf.c | 99 ++++++++++++ src/conf/schemas/capability.rng | 27 ++++ src/conf/schemas/domaincommon.rng | 19 +++ src/conf/virconftypes.h | 2 + src/qemu/qemu_driver.c | 70 ++++++++- src/util/virresctrl.c | 180 ++++++++++++++++++---- src/util/virresctrl.h | 10 +- tests/genericxml2xmlindata/energytune.xml | 32 ++++ tests/genericxml2xmltest.c | 1 + 14 files changed, 542 insertions(+), 37 deletions(-) create mode 100644 tests/genericxml2xmlindata/energytune.xml -- 2.34.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

2 8

[PATCH v4 0/2] Fix VMWare domain tracking
by Martin Kletzander 15 May '26

15 May '26

v4: - Add forgotten test XML changes - Add explicit documentation about the UUID stability changing - Do not mess up whitespaces in the NEWS v3: - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XO3I… - Remove leftover comment - Parse both UUIDs and leave the legacy one in <hwuuid> - Fix the callback for VMX parsing v2: - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ODGB… - ESX driver has an opt-in for the legacy behaviour just in case anynone needs that, although hopefully that should not be the case. The opt-in does not exist in the vmware driver or the vmx tests, there the v1 behaviour is kept in which vc.uuid is preferred, but uuid.bios is a fallback. v1: - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WEKR… Martin Kletzander (2): esx: Track VMs by instanceUuid instead of UUID NEWS: Add information about VMWare domains having different UUIDs NEWS.rst | 10 +++++ docs/drvesx.rst | 24 ++++++++++++ src/esx/esx_driver.c | 43 +++++++++++++++------- src/esx/esx_util.c | 11 ++++++ src/esx/esx_util.h | 1 + src/esx/esx_vi.c | 32 ++++++++++++++-- src/esx/esx_vi.h | 3 ++ src/vmx/vmx.c | 12 +++++- tests/vmx2xmldata/case-insensitive-1.xml | 1 + tests/vmx2xmldata/case-insensitive-2.xml | 1 + tests/vmx2xmldata/esx-in-the-wild-1.xml | 1 + tests/vmx2xmldata/esx-in-the-wild-10.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-11.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-12.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-13.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-14.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-15.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-16.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-17.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-2.xml | 1 + tests/vmx2xmldata/esx-in-the-wild-3.xml | 1 + tests/vmx2xmldata/esx-in-the-wild-4.xml | 1 + tests/vmx2xmldata/esx-in-the-wild-5.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-6.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-7.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-8.xml | 3 +- tests/vmx2xmldata/esx-in-the-wild-9.xml | 3 +- tests/vmx2xmldata/fusion-in-the-wild-1.xml | 1 + tests/vmx2xmldata/gsx-in-the-wild-1.xml | 1 + tests/vmx2xmldata/gsx-in-the-wild-2.xml | 1 + tests/vmx2xmldata/gsx-in-the-wild-3.xml | 1 + tests/vmx2xmldata/gsx-in-the-wild-4.xml | 1 + 32 files changed, 153 insertions(+), 33 deletions(-) -- 2.54.0

2 3

Re: [PATCH] qemu: Introduce VIR_DOMAIN_EVENT_ID_CHANNEL_LIFECYCLE
by Peter Krempa 15 May '26

15 May '26

[re-added list], please keep conversation on the list by using 'reply-all' On Fri, May 15, 2026 at 13:03:42 +0200, Lucas Kornicki wrote: > Thanks Peter > > On 5/15/26 10:59, Peter Krempa wrote: > > On Wed, May 13, 2026 at 12:20:31 +0200, Lucas Kornicki wrote: > > > Add a generic domain event that fires when libvirt detects a state > > > change on any virtio-serial channel of a domain (connected / > > > disconnected). The existing VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE > > > event is restricted to the QEMU guest agent channel > > > ("org.qemu.guest_agent.0"), making it impossible for management > > > applications to observe lifecycle transitions of other channels > > > (custom guest agents, SPICE, etc.) without polling the domain XML > > > status file. > > > > > > The new event is emitted for every virtio-serial channel, including > > > the guest agent channel, and carries the affected channels name. > > > > > > The hypervisor must support virtio-serial port state notifications > > > (e.g. QEMU's VSERPORT_CHANGE event) for the event to be delivered. > > > > > > Forward-port of the v2 series originally posted to libvirt-devel in > > > 2016 by Matt Broadstone<mbroadst(a)gmail.com>. > > I'd expect that authorship is preserved if you forward port the patch. > > Did you change it substantially? Did the original author include a > > 'signed-off-by' tag? > > There was no sign off. > I started working on this before I became aware of the original patch, > so I just hand picked most of the boilerplate that comes along with a new > event. Ah I see. IMO your authorship is okay then. I'd perhaps suggest rewording it to "Some parts were lifted from original post to ..." > If you want I can rewrite the author to Matt but what about the sign-off? No for the authorship and definitely no for sign-off, we can't conjure that one for someone without > > > > Signed-off-by: Lucas Kornicki<lucas.kornicki(a)nutanix.com> > > > --- > > > examples/c/misc/event-test.c | 57 +++++++++++++++++ > > > include/libvirt/libvirt-domain.h | 65 ++++++++++++++++++++ > > > src/conf/domain_event.c | 95 +++++++++++++++++++++++++++++ > > > src/conf/domain_event.h | 12 ++++ > > > src/libvirt_private.syms | 2 + > > > src/qemu/qemu_driver.c | 8 +++ > > > src/qemu/qemu_process.c | 17 ++++-- > > Please seaprate the implementation in the qemu driver from teh other > > changes which add the public side of the event. > > > By public you mean the remote / virsh parts below and not the public > headers? > Those would be hard to do without. No, virsh and public API needs to go together because there are compile time checks that enforce them. The tree still has to compile after each patch. > > Also, the conflicting commit (bbc7d1a2a0d58788520a97a2be439c94a0153d3c) > seems to combine those parts the same way I am doing here. That is correct. What I meant is splitting off the part where you make the qemu driver emit the events. Thus IIRC everything this patch does under src/qemu. > > > > src/remote/remote_daemon_dispatch.c | 34 +++++++++++ > > > src/remote/remote_driver.c | 34 +++++++++++ > > > src/remote/remote_protocol.x | 16 ++++- > > > src/remote_protocol-structs | 8 +++ > > > tools/virsh-domain-event.c | 35 +++++++++++ > > > 12 files changed, 377 insertions(+), 6 deletions(-) > > [...] One thing I likely forgot to mention is that you should also add compile time check which forces that the _LAST parts of the both events mirrot themselves for now so that if anyone adds another field to either of them they stay in sync.

1 0

[PATCH 0/2] bhyve: add agent support
by Roman Bogorodskiy 15 May '26

15 May '26

Roman Bogorodskiy (2): qemu: move qemu_agent.c to hypervisor/ bhyve: add agent support po/POTFILES | 2 +- src/bhyve/bhyve_domain.c | 32 +++++ src/bhyve/bhyve_domain.h | 14 ++ src/bhyve/bhyve_driver.c | 180 +++++++++++++++++++++++++- src/bhyve/bhyve_process.c | 118 +++++++++++++++++ src/bhyve/bhyve_process.h | 4 + src/hypervisor/meson.build | 1 + src/{qemu => hypervisor}/qemu_agent.c | 20 ++- src/{qemu => hypervisor}/qemu_agent.h | 3 +- src/libvirt_private.syms | 32 +++++ src/qemu/meson.build | 1 - src/qemu/qemu_process.c | 3 +- tests/qemuagenttest.c | 2 +- tests/qemumonitortestutils.c | 6 +- tests/qemumonitortestutils.h | 2 +- 15 files changed, 405 insertions(+), 15 deletions(-) rename src/{qemu => hypervisor}/qemu_agent.c (99%) rename src/{qemu => hypervisor}/qemu_agent.h (98%) -- 2.52.0

2 4

[PATCH 0/9] Fix stream event opaque data leak and improve debugging
by Peter Krempa 15 May '26

15 May '26

This series fixes a leak of the 'opaque' pointer registered as private data for virStream Event callback. This manifests itself as leak of connections to virtstoraged in modular deployments if e.g. virsh vol-upload is used. The rest of the series adds various VIR_DEBUG statements and logging of class name and reference count for virObject(Un)Ref. Peter Krempa (9): remote_driver: Don't leak opaque pointer passed to 'virStreamEventAddCallback' libvirt_probes: Fix alignment of 'virobject' probe points util: probe: Add 'PROBE_DEBUG' util: object: Downgrade PROBE points to PROBE_DEBUG util: object: Add class name to the Ref/Unref/Dispose debug messages daemonRemoveClientStream: Add debug log remoteClientFree: Add debug log of parameters virNetClientStreamEventRemoveCallback: Add debug log util: virobject: Add debug refcounting output src/libvirt_probes.d | 12 +++++------ src/remote/remote_daemon_dispatch.c | 5 +++++ src/remote/remote_daemon_stream.c | 5 +++-- src/remote/remote_driver.c | 9 +++++++- src/rpc/virnetclientstream.c | 4 ++++ src/util/virobject.c | 33 +++++++++++++++++++++++++---- src/util/virprobe.h | 14 ++++++++++++ 7 files changed, 69 insertions(+), 13 deletions(-) -- 2.54.0

2 11

[PATCH v3 0/2] Fix VMWare domain tracking
by Martin Kletzander 15 May '26

15 May '26

v3: - Remove leftover comment - Parse both UUIDs and leave the legacy one in <hwuuid> - Fix the callback for VMX parsing v2: - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ODGB… - ESX driver has an opt-in for the legacy behaviour just in case anynone needs that, although hopefully that should not be the case. The opt-in does not exist in the vmware driver or the vmx tests, there the v1 behaviour is kept in which vc.uuid is preferred, but uuid.bios is a fallback. v1: - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WEKR… Martin Kletzander (2): esx: Track VMs by instanceUuid instead of UUID NEWS: Add information about VMWare domains having different UUIDs NEWS.rst | 9 +++++ docs/drvesx.rst | 9 +++++ src/esx/esx_driver.c | 43 ++++++++++++++++-------- src/esx/esx_util.c | 11 ++++++ src/esx/esx_util.h | 1 + src/esx/esx_vi.c | 32 +++++++++++++++--- src/esx/esx_vi.h | 3 ++ src/vmx/vmx.c | 12 +++++-- tests/vmx2xmldata/esx-in-the-wild-10.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-11.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-12.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-13.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-14.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-15.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-16.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-17.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-5.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-6.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-7.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-8.xml | 2 +- tests/vmx2xmldata/esx-in-the-wild-9.xml | 2 +- 21 files changed, 113 insertions(+), 33 deletions(-) -- 2.54.0

2 7