- Devel - libvirt List Archives

[libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions
by Daniel P. Berrangé 20 Apr '20

20 Apr '20

This is the bare minimum patches required to let libvirt compile with the latest virtualbox SDK for 6.0 and 6.1. Since I do not use virtualbox this is compile tested only. This will at least give users something to try and provide feedback on. In addition currently EOL versions of virtualbox are dropped. Daniel P. Berrangé (10): vbox: remove support for version 5.0 API vbox: remove version 5.0 CAPI header vbox: remove support for version 5.1 API vbox: remove version 5.1 CAPI header vbox: remove unused support for Windows MSCOM vbox: add version 6.0 CAPI header vbox: add support for version 6.0 SDK vbox: add version 6.1 CAPI header vbox: add support for version 6.1 SDK docs: add news about virtualbox version support changes docs/news.xml | 22 + po/POTFILES.in | 1 - src/vbox/Makefile.inc.am | 16 +- .../{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} | 14959 +++--- .../{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} | 37642 +++++++++------- src/vbox/vbox_MSCOMGlue.c | 779 - src/vbox/vbox_MSCOMGlue.h | 45 - src/vbox/{vbox_V5_0.c => vbox_V6_0.c} | 6 +- src/vbox/{vbox_V5_1.c => vbox_V6_1.c} | 6 +- src/vbox/vbox_XPCOMCGlue.h | 2 +- src/vbox/vbox_common.h | 10 +- src/vbox/vbox_driver.c | 2 +- src/vbox/vbox_glue.c | 28 - src/vbox/vbox_glue.h | 28 - src/vbox/vbox_storage.c | 10 +- src/vbox/vbox_tmpl.c | 104 +- src/vbox/vbox_uniformed_api.h | 6 +- 17 files changed, 31851 insertions(+), 21815 deletions(-) rename src/vbox/{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} (85%) rename src/vbox/{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} (73%) delete mode 100644 src/vbox/vbox_MSCOMGlue.c delete mode 100644 src/vbox/vbox_MSCOMGlue.h rename src/vbox/{vbox_V5_0.c => vbox_V6_0.c} (68%) rename src/vbox/{vbox_V5_1.c => vbox_V6_1.c} (68%) delete mode 100644 src/vbox/vbox_glue.c delete mode 100644 src/vbox/vbox_glue.h -- 2.25.2

2 11

[PATCH 0/3] Enable net devices in node-dev driver again
by Michal Privoznik 20 Apr '20

20 Apr '20

If the kernel doesn't have CONFIG_NET_DEVLINK then net devices are not listed in nodedev-list. See 2/3 for more info. Michal Prívozník (3): virNetDevGetFamilyId: Change signature virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal virnetdev.c: Use g_auto*() src/util/virnetdev.c | 412 +++++++++++++++++-------------------------- 1 file changed, 157 insertions(+), 255 deletions(-) -- 2.25.3

2 6

[PATCH 0/2] Include lease time option into DHCP settings
by Julio Faracco 20 Apr '20

20 Apr '20

This series is based on latest series from Alberto. It includes a new entry called <leasetime/> under <dhcp/> scope to add a default lease time for range and host options for dnsmasq. There is no point to configure both separately. If they are defined (range and/or host), they should have the same lease time value. This series includes some test cases to cover lease time XML syntax also. Julio Faracco (2): conf: Add <leasetime/> option for <dhcp/> settings tests: Add tests for <leasetime/> to cover dnsmasq settings docs/schemas/basictypes.rng | 9 +++ docs/schemas/network.rng | 11 ++++ src/conf/network_conf.c | 62 ++++++++++++++++++- src/conf/network_conf.h | 14 +++++ src/libvirt_private.syms | 2 + src/network/bridge_driver.c | 37 ++++++++++- src/util/virdnsmasq.c | 40 ++++++------ src/util/virdnsmasq.h | 1 + .../networkxml2confdata/leasetime-hours.conf | 16 +++++ tests/networkxml2confdata/leasetime-hours.xml | 12 ++++ .../leasetime-infinite.conf | 16 +++++ .../leasetime-infinite.xml | 12 ++++ .../leasetime-minutes.conf | 16 +++++ .../networkxml2confdata/leasetime-minutes.xml | 12 ++++ .../leasetime-seconds.conf | 16 +++++ .../networkxml2confdata/leasetime-seconds.xml | 12 ++++ tests/networkxml2conftest.c | 4 ++ tests/networkxml2xmlin/leasetime-hours.xml | 12 ++++ tests/networkxml2xmlin/leasetime-infinite.xml | 12 ++++ tests/networkxml2xmlin/leasetime-minutes.xml | 12 ++++ tests/networkxml2xmlin/leasetime-seconds.xml | 12 ++++ tests/networkxml2xmlout/leasetime-hours.xml | 14 +++++ .../networkxml2xmlout/leasetime-infinite.xml | 14 +++++ tests/networkxml2xmlout/leasetime-minutes.xml | 14 +++++ tests/networkxml2xmlout/leasetime-seconds.xml | 14 +++++ tests/networkxml2xmltest.c | 4 ++ 26 files changed, 376 insertions(+), 24 deletions(-) create mode 100644 tests/networkxml2confdata/leasetime-hours.conf create mode 100644 tests/networkxml2confdata/leasetime-hours.xml create mode 100644 tests/networkxml2confdata/leasetime-infinite.conf create mode 100644 tests/networkxml2confdata/leasetime-infinite.xml create mode 100644 tests/networkxml2confdata/leasetime-minutes.conf create mode 100644 tests/networkxml2confdata/leasetime-minutes.xml create mode 100644 tests/networkxml2confdata/leasetime-seconds.conf create mode 100644 tests/networkxml2confdata/leasetime-seconds.xml create mode 100644 tests/networkxml2xmlin/leasetime-hours.xml create mode 100644 tests/networkxml2xmlin/leasetime-infinite.xml create mode 100644 tests/networkxml2xmlin/leasetime-minutes.xml create mode 100644 tests/networkxml2xmlin/leasetime-seconds.xml create mode 100644 tests/networkxml2xmlout/leasetime-hours.xml create mode 100644 tests/networkxml2xmlout/leasetime-infinite.xml create mode 100644 tests/networkxml2xmlout/leasetime-minutes.xml create mode 100644 tests/networkxml2xmlout/leasetime-seconds.xml -- 2.24.1

3 7

[libvirt-ci PATCH] README: Fix "maintainance" typo
by Erik Skultety 20 Apr '20

20 Apr '20

Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. guests/README.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/README.markdown b/guests/README.markdown index ed9be06..7dbefed 100644 --- a/guests/README.markdown +++ b/guests/README.markdown @@ -18,7 +18,7 @@ There are two steps to bringing up a guest: post-installation configuration steps required to make the newly-created guest usable and ready to be used for building `$project`; -Once those steps have been performed, maintainance will involve running: +Once those steps have been performed, maintenance will involve running: lcitool update $guest $project -- 2.25.2

1 0

[PATCH] Add 'permissive' option for PCI devices
by Marek Marczykowski-Górecki 19 Apr '20

19 Apr '20

From: Simon Gaiser <simon(a)invisiblethingslab.com> By setting the permissive flag the guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain it. Signed-off-by: Simon Gaiser <simon(a)invisiblethingslab.com> Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- docs/formatdomain.html.in | 3 +++ docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 12 ++++++++++++ src/conf/domain_conf.h | 1 + src/libxl/libxl_conf.c | 1 + 5 files changed, 22 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6f43976815..79a5176ccd 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5051,6 +5051,9 @@ or hot-plugging the device and <code>virNodeDeviceReAttach</code> (or <code>virsh nodedev-reattach</code>) after hot-unplug or stopping the guest. + When <code>permissive</code> is "yes" the pci config space access + will not be filtered. This might be a security issue. The default + is "no". </dd> <dt><code>scsi</code></dt> <dd>For SCSI devices, user is responsible to make sure the device diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 65d6580434..9389eec3d8 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -3064,6 +3064,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <interleave> <element name="source"> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8e8146374c..607cae61d4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8419,6 +8419,7 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, virDomainHostdevSubsysSCSIVHostPtr scsihostsrc = &def->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDevPtr mdevsrc = &def->source.subsys.u.mdev; g_autofree char *managed = NULL; + g_autofree char *permissive = NULL; g_autofree char *sgio = NULL; g_autofree char *rawio = NULL; g_autofree char *backendStr = NULL; @@ -8434,6 +8435,11 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if ((managed = virXMLPropString(node, "managed")) != NULL) ignore_value(virStringParseYesNo(managed, &def->managed)); + if ((permissive = virXMLPropString(node, "permissive")) != NULL) { + if (STREQ(permissive, "yes")) + def->permissive = true; + } + sgio = virXMLPropString(node, "sgio"); rawio = virXMLPropString(node, "rawio"); model = virXMLPropString(node, "model"); @@ -25942,6 +25948,8 @@ virDomainActualNetDefFormat(virBufferPtr buf, virDomainHostdevDefPtr hostdef = virDomainNetGetActualHostdev(def); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAddLit(buf, " permissive='yes'"); } if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", @@ -26130,6 +26138,8 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAsprintf(buf, "<interface type='%s'", typeStr); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAddLit(buf, " permissive='yes'"); if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", virTristateBoolTypeToString(def->trustGuestRxFilters)); @@ -27914,6 +27924,8 @@ virDomainHostdevDefFormat(virBufferPtr buf, if (def->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virBufferAsprintf(buf, " managed='%s'", def->managed ? "yes" : "no"); + if (def->permissive) + virBufferAddLit(buf, " permissive='yes'"); if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && scsisrc->sgio) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index aad3f82db7..b81a3ce901 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -345,6 +345,7 @@ struct _virDomainHostdevDef { bool missing; bool readonly; bool shareable; + bool permissive; union { virDomainHostdevSubsys subsys; virDomainHostdevCaps caps; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index b3f67f817a..55f2a09e3e 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -2249,6 +2249,7 @@ libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev) pcidev->bus = pcisrc->addr.bus; pcidev->dev = pcisrc->addr.slot; pcidev->func = pcisrc->addr.function; + pcidev->permissive = hostdev->permissive; return 0; } -- 2.21.1

2 1

[libvirt PATCH] util: Do not include sys/wait.h on Win32
by Jiri Denemark 17 Apr '20

17 Apr '20

This fixes build on mingw broken by my previous commit 36e125296a. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed. src/util/virdaemon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 6182ca3c21..31cc24e703 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -22,7 +22,9 @@ #include <sys/types.h> #include <sys/stat.h> -#include <sys/wait.h> +#ifndef WIN32 +# include <sys/wait.h> +#endif #include <fcntl.h> #include <unistd.h> #include <stdbool.h> -- 2.26.1

1 0

[PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst
by Boris Fiuczynski 17 Apr '20

17 Apr '20

Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) -- 2.25.1

3 5

[PATCH 0/3] qemu: Fix restoring a domain from a block device
by Michal Privoznik 17 Apr '20

17 Apr '20

*** BLURB HERE *** Michal Prívozník (3): selinux: Don't remember label for restore path security: Introduce virSecurityManagerDomainSetIncomingPathLabel qemu: Label restore path outside of secdriver transactions src/libvirt_private.syms | 1 + src/qemu/qemu_security.c | 7 +++++++ src/security/security_driver.h | 4 ++++ src/security/security_manager.c | 29 +++++++++++++++++++++++++++++ src/security/security_manager.h | 4 ++++ src/security/security_selinux.c | 23 +++++++++++++++++------ src/security/security_stack.c | 21 +++++++++++++++++++++ 7 files changed, 83 insertions(+), 6 deletions(-) -- 2.24.1

2 8

[PATCH 0/2] docs: Further adjustments to pci-addresses.rst
by Boris Fiuczynski 17 Apr '20

17 Apr '20

Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (2): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) -- 2.25.1

3 11

[libvirt PATCH] util: Fix virDaemonForkIntoBackground
by Jiri Denemark 17 Apr '20

17 Apr '20

This commit partially reverts commit c360ea28dc267802690e129fbad08ca2f22a44e9 Refs: v6.2.0-rc1-1-gc360ea28dc Author: Rafael Fonseca <r4f4rfs(a)gmail.com> AuthorDate: Fri Mar 27 18:40:47 2020 +0100 Commit: Michal Prívozník <mprivozn(a)redhat.com> CommitDate: Mon Mar 30 09:48:22 2020 +0200 util: virdaemon: fix compilation on mingw The daemons are not supported on Win32 and therefore were not compiled in that platform. However, with the daemon code sharing, all the code in utils *is* compiled and it failed because `waitpid`, `fork`, and `setsid` are not available. So, as before, let's not build them on Win32 and make the code more portable by using existing vir* wrappers. Not compiling virDaemonForkIntoBackground on Win32 is good, but the second part of the original patch incorrectly replaced waitpid and fork with our virProcessWait and virFork APIs. These APIs are more than just simple wrappers and we don't want any of the extra functionality. Especially virFork would reset any setup made before virDaemonForkIntoBackground is called, such as logging, signal handling, etc. As a result of the change the additional fix in v6.2.0-67-ga87e4788d2 (util: virdaemon: fix waiting for child processes) is no longer needed and it is effectively reverted by this commit. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virdaemon.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 99530fd146..6182ca3c21 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -20,7 +20,9 @@ #include <config.h> +#include <sys/types.h> #include <sys/stat.h> +#include <sys/wait.h> #include <fcntl.h> #include <unistd.h> #include <stdbool.h> @@ -30,8 +32,6 @@ #include "virfile.h" #include "virlog.h" #include "viralloc.h" -#include "virprocess.h" -#include "vircommand.h" #include "configmake.h" @@ -44,7 +44,7 @@ virDaemonForkIntoBackground(const char *argv0) if (virPipeQuiet(statuspipe) < 0) return -1; - pid_t pid = virFork(); + pid_t pid = fork(); switch (pid) { case 0: { @@ -73,7 +73,7 @@ virDaemonForkIntoBackground(const char *argv0) if (setsid() < 0) goto cleanup; - nextpid = virFork(); + nextpid = fork(); switch (nextpid) { case 0: /* grandchild */ return statuspipe[1]; @@ -97,14 +97,15 @@ virDaemonForkIntoBackground(const char *argv0) default: { /* parent */ - int exitstatus = 0; + int got, exitstatus = 0; int ret; char status; VIR_FORCE_CLOSE(statuspipe[1]); /* We wait to make sure the first child forked successfully */ - if (virProcessWait(pid, &exitstatus, 0) < 0 || + if ((got = waitpid(pid, &exitstatus, 0)) < 0 || + got != pid || exitstatus != 0) { goto error; } -- 2.26.1

2 1