- Devel - libvirt List Archives

[libvirt-ci PATCH 0/4] Add Fedora 32, drop Fedora 30
by Andrea Bolognani 30 Apr '20

30 Apr '20

Fedora 32 was released earlier this week, and Fedora 30 goes EOL the next one. Andrea Bolognani (4): guests: Add Fedora 32 Start building on Fedora 32 Stop building on Fedora 30 guests: Remove Fedora 30 guests/host_vars/libvirt-fedora-30/docker.yml | 2 - guests/host_vars/libvirt-fedora-32/docker.yml | 2 + .../install.yml | 2 +- .../main.yml | 2 +- guests/inventory | 2 +- guests/playbooks/build/jobs/defaults.yml | 4 +- guests/playbooks/build/projects/gtk-vnc.yml | 2 +- guests/playbooks/build/projects/libosinfo.yml | 2 +- .../playbooks/build/projects/libvirt-dbus.yml | 4 +- .../build/projects/libvirt-sandbox.yml | 4 +- .../playbooks/build/projects/libvirt-tck.yml | 4 +- guests/playbooks/build/projects/libvirt.yml | 2 +- .../build/projects/osinfo-db-tools.yml | 2 +- .../playbooks/build/projects/virt-manager.yml | 6 +- .../playbooks/build/projects/virt-viewer.yml | 2 +- jenkins/jobs/defaults.yaml | 4 +- jenkins/new.xml | 6423 ++++++++++++++++ jenkins/old.xml | 6435 +++++++++++++++++ jenkins/projects/gtk-vnc.yaml | 2 +- jenkins/projects/libosinfo.yaml | 2 +- jenkins/projects/libvirt-dbus.yaml | 4 +- jenkins/projects/libvirt-sandbox.yaml | 4 +- jenkins/projects/libvirt-tck.yaml | 4 +- jenkins/projects/libvirt.yaml | 2 +- jenkins/projects/osinfo-db-tools.yaml | 2 +- jenkins/projects/virt-manager.yaml | 6 +- jenkins/projects/virt-viewer.yaml | 2 +- 27 files changed, 12895 insertions(+), 37 deletions(-) delete mode 100644 guests/host_vars/libvirt-fedora-30/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-32/docker.yml rename guests/host_vars/{libvirt-fedora-30 => libvirt-fedora-32}/install.yml (66%) rename guests/host_vars/{libvirt-fedora-30 => libvirt-fedora-32}/main.yml (97%) create mode 100644 jenkins/new.xml create mode 100644 jenkins/old.xml -- 2.25.4

2 7

[libvirt-python PATCH 0/3] gitlab: introduce CI jobs for validating python build
by Daniel P. Berrangé 30 Apr '20

30 Apr '20

This introduces GitLab CI to the python module. Traditional Jenkins has validated the python build across all distros, using libvirt git. This tested one axis - a variety of python versions - but failed to test the other interesting axis - a variety of libvirt versions. This new CI setup fixes that mistake validating both axis and in the process uncovered a bug in Ubuntu 1804. Daniel P. Berrangé (3): test: workaround missing VIR_TYPED_PARAM enums in API definition gitlab: introduce CI jobs testing git master & distro libvirt travis: delete redundant configuration .gitlab-ci.yml | 172 ++++++++++++++++++++++++++++++++++ .travis.yml | 55 ----------- ci/libvirt-centos-7.dkr | 85 +++++++++++++++++ ci/libvirt-centos-8.dkr | 64 +++++++++++++ ci/libvirt-debian-10.dkr | 55 +++++++++++ ci/libvirt-debian-9.dkr | 58 ++++++++++++ ci/libvirt-debian-sid.dkr | 55 +++++++++++ ci/libvirt-fedora-30.dkr | 52 ++++++++++ ci/libvirt-fedora-31.dkr | 52 ++++++++++ ci/libvirt-fedora-rawhide.dkr | 53 +++++++++++ ci/libvirt-opensuse-151.dkr | 54 +++++++++++ ci/libvirt-ubuntu-1604.dkr | 58 ++++++++++++ ci/libvirt-ubuntu-1804.dkr | 58 ++++++++++++ ci/refresh | 21 +++++ sanitytest.py | 6 +- 15 files changed, 842 insertions(+), 56 deletions(-) create mode 100644 .gitlab-ci.yml delete mode 100644 .travis.yml create mode 100644 ci/libvirt-centos-7.dkr create mode 100644 ci/libvirt-centos-8.dkr create mode 100644 ci/libvirt-debian-10.dkr create mode 100644 ci/libvirt-debian-9.dkr create mode 100644 ci/libvirt-debian-sid.dkr create mode 100644 ci/libvirt-fedora-30.dkr create mode 100644 ci/libvirt-fedora-31.dkr create mode 100644 ci/libvirt-fedora-rawhide.dkr create mode 100644 ci/libvirt-opensuse-151.dkr create mode 100644 ci/libvirt-ubuntu-1604.dkr create mode 100644 ci/libvirt-ubuntu-1804.dkr create mode 100755 ci/refresh -- 2.25.4

2 9

[libvirt-ci PATCH] guests: introduce libvirt-dist and libvirt-minimal projects
by Daniel P. Berrangé 30 Apr '20

30 Apr '20

The language bindings have traditionally built against a full libvirt, however, this is serious overkill because all they should really need most of the time is access to the main API, and the test driver if they want to run functional tests. The full libvirt build with virt drivers is only needed for integration testing which most bindings won't do. Thus this introduces a new project "libvirt-minimal" which lists the bare minimum dependencies required to build libvirt. Taking libvirt-perl as an example, if creating a container using the current "libvirt,libvirt-perl" project set, the result with 1.4 GB in size for Fedora 31. With the "libvirt-minimal,libvirt-perl" set, the size is just 777 MB. Some projects also wish to have the ability to build against the distro provided libvirt instead of the latest git master, and for this purpose a "libvirt-dist" project is defined which pulls in the package needed for building against the distro libvirt. In the lcitool dockerfile command, there is a check that the requested project is configured against the requested host. These new projects are not listed against any host, because we don't want them installed by default in the VMs. Thus the dockerfile check is no longer valid and is removed. Whomever is invoking lcitool knows what combination they want and whether it will work. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 7 ------- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt-dist.yml | 3 +++ guests/vars/projects/libvirt-minimal.yml | 13 +++++++++++++ 4 files changed, 21 insertions(+), 7 deletions(-) create mode 100644 guests/vars/projects/libvirt-dist.yml create mode 100644 guests/vars/projects/libvirt-minimal.yml diff --git a/guests/lcitool b/guests/lcitool index 0c89e13..abc87d2 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -1007,13 +1007,6 @@ class Application: for project in projects: if project.rfind("+mingw") >= 0: raise Exception("Obsolete syntax, please use --cross-arch") - if project not in facts["projects"]: - raise Exception( - "Host {} doesn't support project {}".format( - host, - project, - ) - ) varmap = self._dockerfile_build_varmap(facts, mappings, pip_mappings, projects, cross_arch) self._dockerfile_format(facts, cross_arch, varmap) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 753f0fe..a9ab3d5 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -450,6 +450,11 @@ mappings: rpm: libuuid-devel cross-policy-deb: foreign + libvirt-devel: + rpm: libvirt-devel + deb: libvirt-dev + pkg: libvirt + libxml2: deb: libxml2-dev pkg: libxml2 diff --git a/guests/vars/projects/libvirt-dist.yml b/guests/vars/projects/libvirt-dist.yml new file mode 100644 index 0000000..aa95f23 --- /dev/null +++ b/guests/vars/projects/libvirt-dist.yml @@ -0,0 +1,3 @@ +--- +packages: + - libvirt-devel diff --git a/guests/vars/projects/libvirt-minimal.yml b/guests/vars/projects/libvirt-minimal.yml new file mode 100644 index 0000000..9402c4f --- /dev/null +++ b/guests/vars/projects/libvirt-minimal.yml @@ -0,0 +1,13 @@ +--- +packages: + - glib2 + - gnutls + - libnl3 + - libnlroute3 + - libpcap + - libtirpc + - libxml2 + - python3-docutils + - rpcgen + - xmllint + - xsltproc -- 2.25.4

2 3

Live migration garp
by Ignazio Cassano 30 Apr '20

30 Apr '20

Hello All, I am facing issues under openstack rocky with last libvirt available on centos 7. There is an open discussione here: https://bugs.launchpad.net/neutron/+bug/1866139 About sending garp when an instance live migrate. What must send garp ? The problem is this: when live migrate a vm from a node to another it stops to responds to ping requests. It starts to respond only when it send a network request for example when its chrony daemon pools a server. Anyone could help me, please? Best Regards Ignazio

2 2

Re: Libvirt Application Development Guide
by Daniel P. Berrangé 30 Apr '20

30 Apr '20

Replying again to re-add the mailing list On Thu, Apr 30, 2020 at 08:56:12AM +0000, charalambous s. (sc3n17) wrote: > Hello Daniel, > > Thank you for getting back to me! > > I understand that the state of the document was perhaps not as polished > as one would like, however it was immensely helpful to me when developing > my project. If it is not too difficult / costly, I personally would prefer > if it was left up, since there aren't really any alternatives that are as > useful. I do understand however that if I'm the only person that has used > it in recent times, it may not be worth the effort. Since you say it was useful to you, it is likely useful to other people as well. Based on this I've temporarily re-enabled the cronjob that was publishing it at: https://libvirt.org/docs/libvirt-appdev-guide-python/en-US/html/ I only re-enabled it for the python appdev guide, not the even older C appdev guide. I'll see about moving the cronjob into GitLab CI so we have a more formal publishing approach. This will mean we can validate it when we accept merge requests for the content too. > Personally, I feel that the guide was good enough to guide me in > the right direction when using the library, and the examples > provided were useful in getting an idea of what was going on. A > section of my project report is a short list of improvements that > could be made to the guide, so if you do decide to reinstate it, > I could help with improving some sections a little bit. Since it lacks any current maintainer, we'd be happy if anyone wants to volunteer to contribute improvements to it, whether little or large! Thankyou for your interest in, and feedback to, the libvirt project. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

Libvirt Application Development Guide
by charalambous s. (sc3n17) 30 Apr '20

30 Apr '20

Hello, For my third year project, I've developed a piece of software in python, making use of the Libvirt application development guide for python. I'm currently writing a report that references it. I've noticed that you seem to have removed the guide from the libvirt site - has it been moved somewhere else, or deleted entirely? Will it be reinstated at some point, or is this a permanent change? Thank you in advance and Best Regards, Stephanos Charalambous

2 1

[libvirt-jenkins-ci PATCH] guests: allow for container image inheritance
by Daniel P. Berrangé 30 Apr '20

30 Apr '20

Currently when creating a Dockerfile for a container, we include the full set of base packages, along with the packages for the project itself. If building a Perl binding, this would require us to install the base package, libvirt packages and Perl packages. With the use of the "--inherit libvirt-fedora-30" arg, it is possible to have a dockerfile that only adds the Perl packages, getting everything else from the parent image. For example, a full Dockerfile for libvirt-go would thus be: FROM libvirt-centos-7:latest RUN yum install -y \ golang && \ yum autoremove -y && \ yum clean all -y Note there is no need to set ENV either, as that's inherited from the parent container. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/lcitool | 108 ++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 98 insertions(+), 10 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 689a8cf..b3afb6a 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -396,6 +396,12 @@ class Application: help="target architecture for cross compiler", ) + def add_inherit_arg(parser): + parser.add_argument( + "-i", "--inherit", + help="inherit from an intermediate container image", + ) + def add_wait_arg(parser): parser.add_argument( "-w", "--wait", @@ -442,6 +448,7 @@ class Application: add_hosts_arg(dockerfileparser) add_projects_arg(dockerfileparser) add_cross_arch_arg(dockerfileparser) + add_inherit_arg(dockerfileparser) def _execute_playbook(self, playbook, hosts, projects, git_revision): base = Util.get_base() @@ -644,11 +651,11 @@ class Application: with open(keyfile, "r") as r: return r.read().rstrip() - def _dockerfile_build_varmap(self, facts, mappings, pip_mappings, projects, cross_arch): + def _dockerfile_build_varmap(self, facts, mappings, pip_mappings, projects, cross_arch, needbase): if facts["package_format"] == "deb": - varmap = self._dockerfile_build_varmap_deb(facts, mappings, pip_mappings, projects, cross_arch) + varmap = self._dockerfile_build_varmap_deb(facts, mappings, pip_mappings, projects, cross_arch, needbase) if facts["package_format"] == "rpm": - varmap = self._dockerfile_build_varmap_rpm(facts, mappings, pip_mappings, projects, cross_arch) + varmap = self._dockerfile_build_varmap_rpm(facts, mappings, pip_mappings, projects, cross_arch, needbase) varmap["package_manager"] = facts["package_manager"] varmap["cc"] = facts["cc"] @@ -662,7 +669,7 @@ class Application: return varmap - def _dockerfile_build_varmap_deb(self, facts, mappings, pip_mappings, projects, cross_arch): + def _dockerfile_build_varmap_deb(self, facts, mappings, pip_mappings, projects, cross_arch, needbase): package_format = facts["package_format"] package_manager = facts["package_manager"] os_name = facts["os_name"] @@ -682,7 +689,10 @@ class Application: # We need to add the base project manually here: the standard # machinery hides it because it's an implementation detail - for project in projects + ["base"]: + pkgprojects = projects + if needbase: + pkgprojects = projects + ["base"] + for project in pkgprojects: for package in self._projects.get_packages(project): cross_policy = "native" for key in cross_keys: @@ -730,7 +740,7 @@ class Application: return varmap - def _dockerfile_build_varmap_rpm(self, facts, mappings, pip_mappings, projects, cross_arch): + def _dockerfile_build_varmap_rpm(self, facts, mappings, pip_mappings, projects, cross_arch, needbase): package_format = facts["package_format"] package_manager = facts["package_manager"] os_name = facts["os_name"] @@ -744,7 +754,10 @@ class Application: # We need to add the base project manually here: the standard # machinery hides it because it's an implementation detail - for project in projects + ["base"]: + pkgprojects = projects + if needbase: + pkgprojects = projects + ["base"] + for project in pkgprojects: for package in self._projects.get_packages(project): for key in keys: if key in mappings[package]: @@ -791,7 +804,7 @@ class Application: return varmap - def _dockerfile_format(self, facts, cross_arch, varmap): + def _dockerfile_base_format(self, facts, cross_arch, varmap): package_format = facts["package_format"] package_manager = facts["package_manager"] os_name = facts["os_name"] @@ -931,6 +944,74 @@ class Application: ENV CONFIGURE_OPTS "--host={cross_abi}" """).format(**varmap)) + def _dockerfile_child_format(self, facts, cross_arch, inherit, varmap): + package_format = facts["package_format"] + package_manager = facts["package_manager"] + os_name = facts["os_name"] + os_version = facts["os_version"] + + print("FROM {}".format(inherit)) + + commands = [] + + if package_format == "deb": + commands.extend([ + "export DEBIAN_FRONTEND=noninteractive", + "{package_manager} update", + "{package_manager} install --no-install-recommends -y {pkgs}", + "{package_manager} autoremove -y", + "{package_manager} autoclean -y", + ]) + elif package_format == "rpm": + commands.extend([ + "{package_manager} install -y {pkgs}", + ]) + + # openSUSE doesn't seem to have a convenient way to remove all + # unnecessary packages, but CentOS and Fedora do + if os_name == "OpenSUSE": + commands.extend([ + "{package_manager} clean --all", + ]) + else: + commands.extend([ + "{package_manager} autoremove -y", + "{package_manager} clean all -y", + ]) + + + script = "\nRUN " + (" && \\\n ".join(commands)) + "\n" + sys.stdout.write(script.format(**varmap)) + + if cross_arch: + cross_commands = [] + + # Intentionally a separate RUN command from the above + # so that the common packages of all cross-built images + # share a Docker image layer. + if package_format == "deb": + cross_commands.extend([ + "export DEBIAN_FRONTEND=noninteractive", + "{package_manager} update", + "{package_manager} install --no-install-recommends -y {cross_pkgs}", + "{package_manager} autoremove -y", + "{package_manager} autoclean -y", + ]) + elif package_format == "rpm": + cross_commands.extend([ + "{package_manager} install -y {cross_pkgs}", + "{package_manager} clean all -y", + ]) + + cross_script = "\nRUN " + (" && \\\n ".join(cross_commands)) + "\n" + sys.stdout.write(cross_script.format(**varmap)) + + if "pip_pkgs" in varmap: + sys.stdout.write(textwrap.dedent(""" + RUN pip3 install {pip_pkgs} + """).format(**varmap)) + + def _action_dockerfile(self, args): mappings = self._projects.get_mappings() pip_mappings = self._projects.get_pip_mappings() @@ -947,6 +1028,7 @@ class Application: os_version = facts["os_version"] os_full = os_name + os_version cross_arch = args.cross_arch + inherit = args.inherit if package_format not in ["deb", "rpm"]: raise Exception("Host {} doesn't support Dockerfiles".format(host)) @@ -983,8 +1065,14 @@ class Application: ) ) - varmap = self._dockerfile_build_varmap(facts, mappings, pip_mappings, projects, cross_arch) - self._dockerfile_format(facts, cross_arch, varmap) + needbase = True + if inherit is not None: + needbase = False + varmap = self._dockerfile_build_varmap(facts, mappings, pip_mappings, projects, cross_arch, needbase) + if inherit is None: + self._dockerfile_base_format(facts, cross_arch, varmap) + else: + self._dockerfile_child_format(facts, cross_arch, inherit, varmap) def run(self): args = self._parser.parse_args() -- 2.24.1

2 5

Re: [PATCH] qemu: fix code format problem
by yubihong 30 Apr '20

30 Apr '20

OK, Michal. I will do this job later, thanks for your advice. > On 4/26/20 1:56 PM, yubihong wrote: > > There are some code format problems in src/libvirt-domain.c. This > > patch fixes these problems. > > > >>From 55cd85345b2dc50f44c1e382563482d40142382b Mon Sep 17 00:00:00 > > 2001 > > From: yubihong <yubihong(a)huawei.com> > > Date: Fri, 24 Apr 2020 17:44:43 +0800 > > Subject: [PATCH] qemu: fix code format problem > > > > Signed-off-by:Yu Bihong <yubihong(a)huawei.com> > > --- > > src/libvirt-domain.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index > > a12809c..d659f1b > > 100644 > > --- a/src/libvirt-domain.c > > +++ b/src/libvirt-domain.c > > @@ -8194,11 +8194,11 @@ virDomainAttachDevice(virDomainPtr domain, > > const char *xml) > > virCheckReadOnlyGoto(conn->flags, error); > > > > if (conn->driver->domainAttachDevice) { > > - int ret; > > - ret = conn->driver->domainAttachDevice(domain, xml); > > - if (ret < 0) > > - goto error; > > - return ret; > > + int ret; > > + ret = conn->driver->domainAttachDevice(domain, xml); > > + if (ret < 0) > > + goto error; > > + return ret; > > } > > > > virReportUnsupportedError(); > > @@ -8299,9 +8299,9 @@ virDomainDetachDevice(virDomainPtr domain, > const > > char *xml) > > if (conn->driver->domainDetachDevice) { > > int ret; > > ret = conn->driver->domainDetachDevice(domain, xml); > > - if (ret < 0) > > - goto error; > > - return ret; > > + if (ret < 0) > > + goto error; > > + return ret; > > } > > > > virReportUnsupportedError(); > > -- > > 1.8.3.1 > > > > This patch doesn't apply cleanly. Can you please resend using git-send-email > as our documentation suggest? > > https://libvirt.org/submitting-patches.html > > The idea looks good, but I guess there are more places in the file that are > misaligned. Might be worth extending your patch and include them. > > Michal

1 0

[libvirt-ci PATCH] vars: Add python3-wheel to the base package dependencies
by Erik Skultety 29 Apr '20

29 Apr '20

On platforms where we need to install meson from pip, one will very likely see something similar to this when building a container from the generated Dockerfile: Collecting meson==0.49.0 Downloading <url>/meson-0.49.0.tar.gz (1.3MB) 100% |################################| 1.3MB 874kB/s Building wheels for collected packages: meson Running setup.py bdist_wheel for meson ... error error: invalid command 'bdist_wheel' ---------------------------------------- Failed building wheel for meson Running setup.py clean for meson Failed to build meson Pip is missing the 'wheel' package necessary to build a wheel from sources, if it fails to do that, it falls back to the good old: $ setup.py install meson which succeeds and no harm was done. However, seeing an error in the log always raises eyebrows, so let's fix that very simply by installing the 'wheel' package which is available on all supported platforms. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Alternatively, we could use --no-cache-dir with pip install, but I'm not sure whether it would be enough with new versions of pip. I still feel like installing the 'wheel' package explicitly is a more transparent and safe fix even though we don't benefit from the resulting meson wheel package inside containers at all. guests/vars/mappings.yml | 4 ++++ guests/vars/projects/base.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 753f0fe..4a19fb4 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -909,6 +909,10 @@ mappings: default: python3-setuptools FreeBSD: py37-setuptools + python3-wheel: + default: python3-wheel + FreeBSD: py37-wheel + qemu-img: default: qemu-utils rpm: qemu-img diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 29c10b4..81c4462 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -28,6 +28,7 @@ packages: - python3 - python3-pip - python3-setuptools + - python3-wheel - rpmbuild - screen - strace -- 2.25.3

2 1

[libvirt-jenkins-ci PATCH] guests: Run libvirt-dbus test suite on Fedora 31
by Andrea Bolognani 29 Apr '20

29 Apr '20

This was left out by mistake. Fixes: f7ffff9cd9cc250ac32d7e343c15b4697e931a68 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/playbooks/build/projects/libvirt-dbus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml b/guests/playbooks/build/projects/libvirt-dbus.yml index e29d74b..4cf435d 100644 --- a/guests/playbooks/build/projects/libvirt-dbus.yml +++ b/guests/playbooks/build/projects/libvirt-dbus.yml @@ -19,6 +19,7 @@ - libvirt-debian-10 - libvirt-debian-sid - libvirt-fedora-30 + - libvirt-fedora-31 - libvirt-fedora-rawhide - libvirt-opensuse-151 - libvirt-ubuntu-1804 -- 2.25.4

1 0