- Devel - libvirt List Archives

libvirt 6.4.0 is available
by Daniel Veillard 02 Jun '20

02 Jun '20

I made the release earlier, it is tagged in git and signed source tarball and rpm are available at the usual place: https://libvirt.org/sources/ I didn't push an RC2 this week end as there was no code change from RC1 only a bug fix made its way yesterday. I also pushed a python binding 6.4.0 release that can be found at: https://libvirt.org/sources/python/ There isn't that much detail about the release in the news file, obviously a decent amount of bug fixes and improvements though: Improvements: - qemu: stricter validation for disk type='lun' The 'lun' type is meant for SCSI command passthrough, which can't be achieved if qemu's block layer features are used. Disk type='lun' is now allowed only when the format is 'raw' and no other block layer features are requested. Bug fixes: - qemu: fixed regression in network device hotplug with new qemu versions Starting from QEMU-5.0 it's required to conform to strict schema when hotplugging network devices. Libvirt didn't conform to the schema so in versions prior to 6.4.0 network device hotplug fails in certain cases. This version fixes it and adds stricter testing to prevent further issues. Thanks everybody for your help with this release, enjoy and stay safe ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[PATCH 0/3] Rmove support of tftp storage protocol
by Han Han 02 Jun '20

02 Jun '20

Let's drop tftp support since it is ususabled before or after QEMU v2.8 [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1372143 Han Han (3): docs: Remove tftp protocol support from docs src: Remove tftp network storage support news: Remove support for tftp storage protocol docs/formatdomain.html.in | 10 +--------- docs/news.xml | 11 +++++++++++ docs/schemas/domaincommon.rng | 1 - src/libxl/libxl_conf.c | 1 - src/libxl/xen_xl.c | 1 - src/qemu/qemu_block.c | 3 --- src/qemu/qemu_command.c | 1 - src/qemu/qemu_domain.c | 11 ----------- src/qemu/qemu_driver.c | 3 --- src/util/virstoragefile.c | 6 ------ src/util/virstoragefile.h | 1 - 11 files changed, 12 insertions(+), 37 deletions(-) -- 2.25.0

4 9

[libvirt PATCH] maint: Post-release version bump to 6.5.0
by Andrea Bolognani 02 Jun '20

02 Jun '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 73dc9f841c..6c8ac2f04b 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [6.4.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [6.5.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] if test $srcdir = "." then diff --git a/docs/news.xml b/docs/news.xml index f040d18f96..18d96af048 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -42,6 +42,14 @@ --> <libvirt> + <release version="v6.5.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v6.4.0" date="2020-06-02"> <section title="New features"> <change> -- 2.25.4

1 0

[libvirt PATCH] news: Update for libvirt 6.4.0
by Andrea Bolognani 02 Jun '20

02 Jun '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 104babbae7..956af3036b 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,24 @@ <libvirt> <release version="v6.4.0" date="unreleased"> <section title="New features"> + <change> + <summary> + qemu: Add support for pvscsi controllers + </summary> + <description> + pvscsi is the VMware paravirtualized SCSI controller, which has been + supported in QEMU for a number of years. + </description> + </change> + <change> + <summary> + cpu: Report model information for ARM CPUs + </summary> + <description> + <code>virsh capabilities</code> will now include information about + the host CPU when run on ARM machines. + </description> + </change> </section> <section title="Improvements"> <change> @@ -71,6 +89,33 @@ further issues. </description> </change> + <change> + <summary> + remote: Look up libxl driver correctly + </summary> + <description> + This makes <code>xen://</code> connection URIs usable in split daemon + mode. + </description> + </change> + <change> + <summary> + systemd: Start libvirtd after firewalld/iptables services + </summary> + <description> + This solves an issue where iptables rules and chains created by + libvirtd would get removed by a service started after it. + </description> + </change> + <change> + <summary> + network: Re-create iptables chains on firewalld restart + </summary> + <description> + firewalld resets all iptables rules and chains on restart, and this + includes deleting those created by libvirt. + </description> + </change> </section> </release> <release version="v6.3.0" date="2020-05-05"> -- 2.25.4

2 1

[PATCH] qemu: hotplug: Fix the condition check for net->downscript
by Yi Wang 01 Jun '20

01 Jun '20

From: Liao Pingfang <liao.pingfang(a)zte.com.cn> According to the context, here we are checking net->downscript's validity, Signed-off-by: Liao Pingfang <liao.pingfang(a)zte.com.cn> --- src/qemu/qemu_hotplug.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index d1a2be1..8c99dfc 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4672,9 +4672,8 @@ qemuDomainRemoveNetDevice(virQEMUDriverPtr driver, virDomainNetReleaseActualDevice(conn, vm->def, net); else VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); - } else if (net->type == VIR_DOMAIN_NET_TYPE_ETHERNET) { - if (net->script) - virNetDevRunEthernetScript(net->ifname, net->downscript); + } else if (net->type == VIR_DOMAIN_NET_TYPE_ETHERNET && net->downscript) { + virNetDevRunEthernetScript(net->ifname, net->downscript); } virDomainNetDefFree(net); return 0; -- 2.9.5

2 2

[libvirt PATCH] docs: use multiple header levels in virtiofs doc
by Daniel P. Berrangé 01 Jun '20

01 Jun '20

The heading overline should only be used for the overall document title, any subsequent headings should be underline only. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/kbase/virtiofs.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 18d568af1b..dea8e79f83 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -4,7 +4,6 @@ Sharing files with Virtio-FS .. contents:: -========= Virtio-FS ========= @@ -14,7 +13,6 @@ is designed to offer local file system semantics and performance. See https://virtio-fs.gitlab.io/ -========== Host setup ========== @@ -45,7 +43,6 @@ Either of the following: # virsh allocpages 2M 1024 -=========== Guest setup =========== @@ -132,7 +129,6 @@ Guest setup Note: this requires virtiofs support in the guest kernel (Linux v5.4 or later) -=================== Optional parameters =================== -- 2.26.2

2 1

[libvirt PATCH] docs: Fixed incorrect XML attribute name in virtio kbase
by Ján Tomko 01 Jun '20

01 Jun '20

From: Jaak Ristioja <jaak(a)ristioja.ee> Signed-off-by: Jaak Ristioja <jaak(a)ristioja.ee> --- Pushed by danpb under the trivial rule from https://gitlab.com/libvirt/libvirt/-/merge_requests/2 docs/kbase/virtiofs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 68fbafcf37..18d568af1b 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -143,5 +143,5 @@ More optional elements can be specified <driver type='virtiofs' queue='1024'/> <binary path='/usr/libexec/virtiofsd' xattr='on'> <cache mode='always'/> - <lock posix_lock='on' flock='on'/> + <lock posix='on' flock='on'/> </binary> -- 2.25.4

1 0

[PATCH 0/6] Add Security Guest doc and check for capabilities cache validation
by Boris Fiuczynski 28 May '20

28 May '20

This series introduces the concept of a 'Secure Guest' feature which covers on s390 IBM Secure Execution and on x86 AMD Secure Encrypted Virtualization. Besides adding documentation for IBM Secure Execution it also adds checks during validation of the qemu capabilities cache. These checks per architecture can be performed for IBM Secure Execution on s390 and AMD Secure Encrypted Virtualization on AMD x86 CPUs (both checks implemented in this series). For s390 the verification consists of: - checking if /sys/firmware/uv is available: meaning the HW facility is available and the host OS supports it; - checking if the kernel cmdline contains 'prot_virt=1': meaning the host OS wants to use the feature. For AMD Secure Encrypted Virtualization the verification consists of: - checking if /sys/module/kvm_amd/parameters/sev contains the value '1': meaning SEV is enabled in the host kernel; - checking if the kernel cmdline contains 'mem_encrypt=on': meaning SME memory encryption feature on the host is enabled Whenever the availability of the feature does not match the secure guest flag in the cache then libvirt will re-build it in order to pick up the new set of capabilities available. Additionally, this series adds the same aforementioned checks to the virt-host-validate tool to facilitate the manual verification process for users. Boris Fiuczynski (2): tools: secure guest check on s390 in virt-host-validate tools: secure guest check for AMD in virt-host-validate Paulo de Rezende Pinatti (3): util: introduce a parser for kernel cmdline arguments qemu: check if s390 secure guest support is enabled qemu: check if AMD secure guest support is enabled Viktor Mihajlovski (1): docs: Describe protected virtualization guest setup docs/kbase.html.in | 3 + docs/kbase/launch_security_sev.rst | 9 +- docs/kbase/s390_protected_virt.rst | 189 +++++++++++++++++++++++++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 83 +++++++++++++ src/util/virutil.c | 173 ++++++++++++++++++++++++++ src/util/virutil.h | 18 +++ tests/utiltest.c | 130 ++++++++++++++++++++ tools/virt-host-validate-common.c | 90 +++++++++++++- tools/virt-host-validate-common.h | 5 + tools/virt-host-validate-qemu.c | 4 + 11 files changed, 701 insertions(+), 5 deletions(-) create mode 100644 docs/kbase/s390_protected_virt.rst -- 2.25.1

4 28

[PATCH v2] qemu: Skip pre-creation of NVMe disks
by Michal Privoznik 28 May '20

28 May '20

Upon migration with disks, libvirt determines if each disk exists on the destination and tries to pre-create missing ones. Well, NVMe disks can't be pre-created, but they can be checked for presence. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1823639 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-May/msg00253.html but I've taken what I'm suggesting in a BZ comment and posting it as a patch. src/qemu/qemu_migration.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 02e8271e42..7ee5b5eda8 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -315,6 +315,7 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, for (i = 0; i < nbd->ndisks; i++) { virDomainDiskDefPtr disk; const char *diskSrcPath; + g_autofree char *nvmePath = NULL; VIR_DEBUG("Looking up disk target '%s' (capacity=%llu)", nbd->disks[i].target, nbd->disks[i].capacity); @@ -326,7 +327,12 @@ qemuMigrationDstPrecreateStorage(virDomainObjPtr vm, goto cleanup; } - diskSrcPath = virDomainDiskGetSource(disk); + if (disk->src->type == VIR_STORAGE_TYPE_NVME) { + virPCIDeviceAddressGetSysfsFile(&disk->src->nvme->pciAddr, &nvmePath); + diskSrcPath = nvmePath; + } else { + diskSrcPath = virDomainDiskGetSource(disk); + } /* Skip disks we don't want to migrate and already existing disks. */ if (!qemuMigrationAnyCopyDisk(disk, nmigrate_disks, migrate_disks) || -- 2.26.2

2 1

[PATCH] news: Document 'netdev_add' regression and disk type='lun' changes
by Peter Krempa 28 May '20

28 May '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/news.xml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 67fb85377d..104babbae7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -46,8 +46,31 @@ <section title="New features"> </section> <section title="Improvements"> + <change> + <summary> + qemu: stricter validation for disk type='lun' + </summary> + <description> + The 'lun' type is meant for SCSI command passthrough, which can't be + achieved if qemu's block layer features are used. Disk type='lun' is now + allowed only when the format is 'raw' and no other block layer features + are requested. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + qemu: fixed regression in network device hotplug with new qemu versions + </summary> + <description> + Starting from QEMU-5.0 it's required to conform to strict schema when + hotplugging network devices. Libvirt didn't conform to the schema so + in versions prior to 6.4.0 network device hotplug fails in certain + cases. This version fixes it and adds stricter testing to prevent + further issues. + </description> + </change> </section> </release> <release version="v6.3.0" date="2020-05-05"> -- 2.26.2

2 1