- Devel - libvirt List Archives

[PATCH] docs/compiling: Add note on how to check minimum meson version
by Peter Krempa 16 Mar '21

16 Mar '21

Give guidance on how to check minimum meson version for a given package. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/140 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/compiling.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/compiling.rst b/docs/compiling.rst index 62519b6bdb..7746f20bed 100644 --- a/docs/compiling.rst +++ b/docs/compiling.rst @@ -18,6 +18,11 @@ the build directory is different from the source directory: The *meson* script can be given options to change its default behaviour. +**Note:** Please ensure that you have the appropriate minimal ``meson`` version +installed in your build environment. The minimal version for a specific package +can be checked in the top level ``meson.build`` file in the ``meson_version`` +field. + To get the complete list of the options run the following command: :: -- 2.29.2

3 2

[PATCH 0/2] Fix calling of virNetworkUpdate() driver callback
by Michal Privoznik 16 Mar '21

16 Mar '21

See 2/2 for explanation. BUT, I am not fully convinced about changing XDR though. In my testing it did not really show to be that backward compatible. I did the following tests: 1) run libvirtd unpatched, 2) run libvirtd with just arguments if the callback fixed (i.e. just the first hunk of 2/2), 3) run libvirtd with patch 2/2 as is And also, I repeated the same for split daemon using qemu:///system and network:///system URIs. I've tested the following command: virsh net-update default add dns-txt '<txt name="example" value="example value"/>' and if I got the following error message: Operation not supported: can't update 'ip' section of network 'default' I knew that arguments are swapped (because 'add' command has value 3, 'dns-txt' section has value 11 and 'ip' section has value 3). >From the results I've constructed the following tables: | libvirtd (case 1) | libvirtd + swap (case 2) | libvirtd + RPC (case 3) --------------+-------------------+--------------------------+------------------------ client | 1 | 0 | 0 client + swap | 0 | 1 | 1 client + RPC | 0 | 1 | 1 Both client and libvirtd were tested for all three cases as described above; 1 means success (API returned without an error), 0 means the error message from above was observed. For libvirtd I've tested just qemu:///system, because network:///system has to yield the same results. For split daemon (SD) case: qemu:///system | SD (case 1) | SD + swap (case 2) | SD + RPC (case 3) --------------+-------------+--------------------+------------------ client | 0 | 0 | 0 client + swap | 1 | 1 | 1 client + RPC | 1 | 1 | 1 network:///system | SD (case 1) | SD + swap (case 2) | SD + RPC (case 3) --------------+-------------+--------------------+------------------ client | 1 | 0 | 0 client + swap | 0 | 1 | 1 client + RPC | 0 | 1 | 1 Therefore, what I am trying to say is, there is no case where plain swap (= case 2) would not help and including RPC change (= case 3) would help. Maybe I'm missing something? Michal Prívozník (2): lib: Debug print all arguments of virNetworkUpdate() lib: Fix calling of virNetworkUpdate() driver callback src/libvirt-network.c | 6 +++--- src/remote/remote_protocol.x | 7 ++++++- src/remote_protocol-structs | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) -- 2.26.2

2 6

[PATCH] qemu_process: Use accessor for def->mem.total_memory
by Michal Privoznik 16 Mar '21

16 Mar '21

When connecting to the monitor, a timeout is calculated that is bigger the more memory guest has (because QEMU has to allocate and possibly zero out the memory and what not, empirically deducted). However, when computing the timeout the @total_memory mmember is accessed directly even though virDomainDefGetMemoryTotal() should have been used. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 800b7b197d..f6da5afb48 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2077,7 +2077,7 @@ qemuConnectMonitor(virQEMUDriverPtr driver, virDomainObjPtr vm, int asyncJob, * handing them over to qemu. This can be very time * consuming. Therefore, add a second to timeout for each * 1GiB of guest RAM. */ - timeout = vm->def->mem.total_memory / (1024 * 1024); + timeout = virDomainDefGetMemoryTotal(vm->def) / (1024 * 1024); ignore_value(virTimeMillisNow(&priv->monStart)); -- 2.26.2

2 1

[PATCH] coding-style: Don't encourage virXXXPtr typedefs
by Michal Privoznik 16 Mar '21

16 Mar '21

We don't like virXXXPtr typedefs really and they are going away shortly, possibly. Do not encourage new code to put in the typedefs. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/coding-style.rst | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/coding-style.rst b/docs/coding-style.rst index 22de86a657..470c61860f 100644 --- a/docs/coding-style.rst +++ b/docs/coding-style.rst @@ -53,13 +53,10 @@ Struct type names All structs should have a 'vir' prefix in their typedef name, and each following word should have its first letter in uppercase. The struct name should be the same as the typedef - name with a leading underscore. A second typedef should be - given for a pointer to the struct with a 'Ptr' suffix. - + name with a leading underscore. :: typedef struct _virHashTable virHashTable; - typedef virHashTable *virHashTablePtr; struct _virHashTable { ... }; @@ -426,11 +423,11 @@ Conditional expressions For readability reasons new code should avoid shortening comparisons to 0 for numeric types. Boolean and pointer -comparisions may be shortened. All long forms are okay: +comparisons may be shortened. All long forms are okay: :: - virFooPtr foos = NULL; + virFoo *foos = NULL; size nfoos = 0; bool hasFoos = false; -- 2.26.2

2 1

[PATCH] meson: Don't check for addr2line
by Michal Privoznik 15 Mar '21

15 Mar '21

In the past, we used to have this oomtrace.pl script that attempted to print the stack trace of where an OOM error occurred and it used addr2line for that. But since v5.8.0-rc1~189 we don't really care about OOM anymore and the script is long gone so there's no need to check for addr2line program either. Fixes: 2c52ecd96086b4643b99b4570b5823d40ce2787b Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index c81c6ab205..69a7b4c88e 100644 --- a/meson.build +++ b/meson.build @@ -925,7 +925,6 @@ endforeach # optional programs optional_programs = [ - 'addr2line', 'augparse', 'dmidecode', 'dnsmasq', -- 2.26.2

2 1

[PATCH v2 00/13] deprecations: remove many old deprecations
by Daniel P. Berrangé 15 Mar '21

15 Mar '21

This is an update to https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07558.html The following features have been deprecated for well over the 2 release cycle we promise ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0) ``-vnc acl`` (since 4.0.0) ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1) ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0) ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0) ``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta= tus (since 4.0) ``query-cpus`` (since 2.12.0) ``query-cpus-fast`` ``arch`` output member (since 3.0.0) ``query-events`` (since 4.0) chardev client socket with ``wait`` option (since 4.0) ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s= ince 4.0.0) ``ide-drive`` (since 4.2) ``scsi-disk`` (since 4.2) AFAICT, libvirt has ceased to use all of these too. These patches all have reviews now, and I'll send a pull request tomorrow for soft freeze unless I hear from subsystem maintainers with any negative feedback. In v2: - Dropped -usbdevice removal, as that's spun off into separate debate - Fixed misplaced hunk in scsi-disk patch - Fixed non-default iotest jobs in dirty-bitmap code Daniel P. Berrang=C3=A9 (13): ui, monitor: remove deprecated VNC ACL option and HMP commands monitor: raise error when 'pretty' option is used with HMP monitor: remove 'query-events' QMP command migrate: remove QMP/HMP commands for speed, downtime and cache size machine: remove 'query-cpus' QMP command machine: remove 'arch' field from 'query-cpus-fast' QMP command chardev: reject use of 'wait' flag for socket client chardevs hw/ide: remove 'ide-drive' device hw/scsi: remove 'scsi-disk' device block: remove 'encryption_key_missing' flag from QAPI block: remove dirty bitmaps 'status' field block: remove 'dirty-bitmaps' field from 'BlockInfo' struct block: remove support for using "file" driver with block/char devices block/dirty-bitmap.c | 38 -- block/file-posix.c | 17 +- block/qapi.c | 6 - chardev/char-socket.c | 12 +- docs/devel/migration.rst | 2 +- docs/qdev-device-use.txt | 2 +- docs/rdma.txt | 2 +- docs/system/deprecated.rst | 108 ----- docs/system/removed-features.rst | 109 +++++ docs/xbzrle.txt | 5 - hmp-commands-info.hx | 13 - hmp-commands.hx | 121 ------ hw/core/machine-hmp-cmds.c | 8 +- hw/core/machine-qmp-cmds.c | 120 ------ hw/i386/pc.c | 2 - hw/ide/qdev.c | 38 -- hw/ppc/mac_newworld.c | 13 - hw/ppc/mac_oldworld.c | 13 - hw/scsi/scsi-disk.c | 62 --- hw/sparc64/sun4u.c | 15 - include/block/dirty-bitmap.h | 1 - include/monitor/hmp.h | 4 - migration/migration.c | 45 --- migration/ram.c | 2 +- monitor/hmp-cmds.c | 34 -- monitor/misc.c | 187 --------- monitor/monitor.c | 4 +- monitor/qmp-cmds-control.c | 24 -- qapi/block-core.json | 64 +-- qapi/control.json | 45 --- qapi/machine.json | 181 +-------- qapi/migration.json | 98 ----- qemu-options.hx | 5 +- scripts/device-crash-test | 2 - softmmu/vl.c | 1 - tests/acceptance/pc_cpu_hotplug_props.py | 2 +- tests/acceptance/x86_cpu_model_versions.py | 2 +- tests/migration/guestperf/engine.py | 18 +- tests/qemu-iotests/051 | 4 - tests/qemu-iotests/051.pc.out | 20 - tests/qemu-iotests/124 | 4 - tests/qemu-iotests/181 | 2 +- tests/qemu-iotests/184.out | 6 +- tests/qemu-iotests/191.out | 48 +-- tests/qemu-iotests/194 | 4 +- tests/qemu-iotests/194.out | 4 +- tests/qemu-iotests/226.out | 10 +- tests/qemu-iotests/236 | 2 +- tests/qemu-iotests/236.out | 42 +- tests/qemu-iotests/246 | 3 +- tests/qemu-iotests/246.out | 66 +-- tests/qemu-iotests/254 | 2 +- tests/qemu-iotests/254.out | 9 +- tests/qemu-iotests/257.out | 378 ++++++------------ tests/qemu-iotests/260 | 5 +- tests/qemu-iotests/273.out | 15 +- .../tests/migrate-bitmaps-postcopy-test | 6 +- tests/qtest/migration-test.c | 48 --- tests/qtest/numa-test.c | 6 +- tests/qtest/qmp-test.c | 6 +- tests/qtest/test-hmp.c | 6 +- tests/qtest/test-x86-cpuid-compat.c | 4 +- tests/qtest/vhost-user-test.c | 8 +- ui/vnc.c | 38 -- 64 files changed, 370 insertions(+), 1801 deletions(-) --=20 2.30.2

2 15

[libvirt PATCH v3 00/10] ci: Add helper script
by Andrea Bolognani 15 Mar '21

15 Mar '21

Changes from [v2]: * address review feedback; * wrap more Makefile functionality; * split into smaller, easier to review patches. Changes from [v1]: * implement (partial) support for running builds and spawning shells inside the container; * make the code more maintainable by using a couple of classes. [v2] https://listman.redhat.com/archives/libvir-list/2021-February/msg00922.html [v1] https://listman.redhat.com/archives/libvir-list/2021-February/msg00900.html Andrea Bolognani (10): syntax-check: Allow exceptions for sc_prohibit_nonreentrant ci: Fix name for ci-test target in help output ci: Add helper script ci: Implement 'refresh' helper action ci: Implement 'list-images' helper action ci: Implement 'shell' helper action ci: Implement 'build' helper action ci: Implement 'test' helper action ci: Delete refresh scripts ci: Discourage users from using the Makefile directly build-aux/syntax-check.mk | 1 + ci/Makefile | 13 +- ci/cirrus/refresh | 22 ---- ci/containers/refresh | 41 ------ ci/helper | 260 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 273 insertions(+), 64 deletions(-) delete mode 100755 ci/cirrus/refresh delete mode 100755 ci/containers/refresh create mode 100755 ci/helper -- 2.26.2

2 16

[libvirt PATCH 0/2] Coverity diaries
by Ján Tomko 15 Mar '21

15 Mar '21

two minor bug fixes Ján Tomko (2): cmdList: mark title as autofree nss: findLease: do not leak path tools/nss/libvirt_nss.c | 4 +++- tools/virsh-domain-monitor.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.29.2

2 3

[libvirt PATCH 0/9] docs: Convert html.in to rst (volume 1)
by Erik Skultety 15 Mar '21

15 Mar '21

'#itsfriday' Erik Skultety (9): docs: html.in: Convert aclpolkit to rst docs: html.in: Convert api_extension to rst docs: html.in: Convert api to rst docs: html.in: Convert apps to rst docs: html.in: Convert architecture to rst docs: html.in: Convert auditlog to rst docs: html.in: Convert auth to rst docs: html.in: Convert bindings to rst docs: html.in: Convert 'compiling' to rst docs/aclpolkit.html.in | 523 ------------------------------------- docs/aclpolkit.rst | 310 ++++++++++++++++++++++ docs/api.html.in | 380 --------------------------- docs/api.rst | 265 +++++++++++++++++++ docs/api_extension.html.in | 376 -------------------------- docs/api_extension.rst | 291 +++++++++++++++++++++ docs/apps.html.in | 488 ---------------------------------- docs/apps.rst | 348 ++++++++++++++++++++++++ docs/architecture.html.in | 82 ------ docs/architecture.rst | 83 ++++++ docs/auditlog.html.in | 375 -------------------------- docs/auditlog.rst | 321 +++++++++++++++++++++++ docs/auth.html.in | 368 -------------------------- docs/auth.rst | 343 ++++++++++++++++++++++++ docs/bindings.html.in | 101 ------- docs/bindings.rst | 62 +++++ docs/compiling.html.in | 115 -------- docs/compiling.rst | 95 +++++++ docs/meson.build | 18 +- 19 files changed, 2127 insertions(+), 2817 deletions(-) delete mode 100644 docs/aclpolkit.html.in create mode 100644 docs/aclpolkit.rst delete mode 100644 docs/api.html.in create mode 100644 docs/api.rst delete mode 100644 docs/api_extension.html.in create mode 100644 docs/api_extension.rst delete mode 100644 docs/apps.html.in create mode 100644 docs/apps.rst delete mode 100644 docs/architecture.html.in create mode 100644 docs/architecture.rst delete mode 100644 docs/auditlog.html.in create mode 100644 docs/auditlog.rst delete mode 100644 docs/auth.html.in create mode 100644 docs/auth.rst delete mode 100644 docs/bindings.html.in create mode 100644 docs/bindings.rst delete mode 100644 docs/compiling.html.in create mode 100644 docs/compiling.rst -- 2.29.2

2 21

[libvirt PATCH v2 0/4] qemu: Only raise memlock limit if necessary
by Andrea Bolognani 15 Mar '21

15 Mar '21

This feature has been requested by KubeVirt developers and will make it possible for them to make some VFIO-related features, such as migration and hotplug, work correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1916346 Changes from [v1]: * prep patches have been pushed; * parsing /proc file is now explicitly restricted to Linux only and only uses safe libvirt helpers; * the qemu.conf knob has been dropped in favor of adopting a behavior that should work correctly in all scenarios. [v1] https://listman.redhat.com/archives/libvir-list/2021-March/msg00293.html Andrea Bolognani (4): util: Try to get limits from /proc qemu: Don't ignore virProcessGetMaxMemLock() errors qemu: Refactor qemuDomainAdjustMaxMemLock() qemu: Only raise memlock limit if necessary src/qemu/qemu_domain.c | 36 +++++++++------ src/util/virprocess.c | 102 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+), 13 deletions(-) -- 2.26.2

2 10