- Devel - libvirt List Archives

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VII
by Tim Wiederhake 06 May '21

06 May '21

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainAudioIOCommon: Change type of format to virDomainAudioFormat virDomainAudioCommonParse: Use virXMLProp* virDomainMemballoonDef: Change type of model to virDomainMemballoonModel virDomainMemballoonDefParseXML: Use virXMLProp* virDomainShmemDef: Change type of model to virDomainShmemModel virDomainShmemDef: Change type of role to virDomainShmemRole virDomainShmemDefParseXML: Use virXMLProp* conf: domain: Register autoptr cleanup function for virDomainDeviceDef virDomainShmemDef: Use g_auto* virDomainRedirFilterUSBDevDefParseXML: Use virXMLProp* src/conf/domain_conf.c | 268 ++++++++++----------------------- src/conf/domain_conf.h | 9 +- src/libxl/libxl_conf.c | 8 +- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_hotplug.c | 4 +- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_validate.c | 5 + src/security/virt-aa-helper.c | 4 + 9 files changed, 100 insertions(+), 206 deletions(-) -- 2.26.3

3 22

[libvirt PATCH v3 0/4] Refactor more XML parsing boilerplate code, part VI
by Tim Wiederhake 06 May '21

06 May '21

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg01184.html V2: https://listman.redhat.com/archives/libvir-list/2021-April/msg01238.html Changes since V2: * Rebased * Prepended patches to fix issues in the function * Removed superfluous "VIR_XML_PROP_NONE" Tim Wiederhake (4): virDomainFSDefParseXML: Remove unused variables virDomainGraphicsDefParseXMLSpice: Fix variable type virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory virDomainGraphicsDefParseXMLSpice: Use virXMLProp* src/conf/domain_conf.c | 195 +++++++++++++++++------------------------ 1 file changed, 80 insertions(+), 115 deletions(-) -- 2.26.3

3 6

[PATCH RFC v5 00/12] Add riscv kvm accel support
by Yifei Jiang 06 May '21

06 May '21

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux (lastest version v17). This series depends on above pending changes which haven't yet been accepted, so this QEMU patch series is treated as RFC patches until that dependency has been dealt with. Several steps to use this: 1. Build emulation $ ./configure --target-list=riscv64-softmmu $ make -j$(nproc) 2. Build kernel https://github.com/kvm-riscv/linux 3. Build QEMU VM Cross built in riscv toolchain. $ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path> $ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path> $ ./configure --target-list=riscv64-softmmu --enable-kvm \ --cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \ --disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \ --disable-libxml2 $ make -j$(nproc) 4. Start emulation $ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \ -name guest=riscv-hyp,debug-threads=on \ -smp 4 \ -bios ./fw_jump.bin \ -kernel ./Image \ -drive file=./hyp.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" 5. Start kvm-acceled QEMU VM in emulation $ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \ -name guest=riscv-guset \ -smp 2 \ -bios none \ -kernel ./Image \ -drive file=./guest.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" Changes since RFC v4 - Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17. - Remove time scaling support as software solution is incomplete. Because it will cause unacceptable performance degradation. and We will post a better solution. - Revise according to Alistair's review comments. - Remove compile time XLEN checks in kvm_riscv_reg_id - Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share it between RV32 and RV64. - Add kvm-stub.c for reduce unnecessary compilation checks. - Add riscv_setup_direct_kernel() to direct boot kernel for KVM. Changes since RFC v3 - Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15. - Add time scaling support(New patches 13, 14 and 15). - Fix the bug that guest vm can't reboot. Changes since RFC v2 - Fix checkpatch error at target/riscv/sbi_ecall_interface.h. - Add riscv migration support. Changes since RFC v1 - Add separate SBI ecall interface header. - Add riscv32 kvm accel support. Yifei Jiang (12): linux-header: Update linux/kvm.h target/riscv: Add target/riscv/kvm.c to place the public kvm interface target/riscv: Implement function kvm_arch_init_vcpu target/riscv: Implement kvm_arch_get_registers target/riscv: Implement kvm_arch_put_registers target/riscv: Support start kernel directly by KVM hw/riscv: PLIC update external interrupt by KVM when kvm enabled target/riscv: Handle KVM_EXIT_RISCV_SBI exit target/riscv: Add host cpu type target/riscv: Add kvm_riscv_get/put_regs_timer target/riscv: Implement virtual time adjusting with vm state changing target/riscv: Support virtual time context synchronization hw/intc/sifive_plic.c | 29 +- hw/riscv/boot.c | 11 + hw/riscv/virt.c | 7 + include/hw/riscv/boot.h | 1 + linux-headers/linux/kvm.h | 97 +++++ meson.build | 2 + target/riscv/cpu.c | 17 + target/riscv/cpu.h | 10 + target/riscv/kvm-stub.c | 30 ++ target/riscv/kvm.c | 605 +++++++++++++++++++++++++++++ target/riscv/kvm_riscv.h | 25 ++ target/riscv/machine.c | 14 + target/riscv/meson.build | 1 + target/riscv/sbi_ecall_interface.h | 72 ++++ 14 files changed, 912 insertions(+), 9 deletions(-) create mode 100644 target/riscv/kvm-stub.c create mode 100644 target/riscv/kvm.c create mode 100644 target/riscv/kvm_riscv.h create mode 100644 target/riscv/sbi_ecall_interface.h -- 2.19.1

4 20

[PATCH 0/2] Couple of XML parsing fixes
by Michal Privoznik 05 May '21

05 May '21

Pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/297747756 Michal Prívozník (2): virDomainChrSourceDefParseXML: Fix attribute names for nmdm type virDomainVideoDriverDefParseXML: Allow zero value for @vgaconf src/conf/domain_conf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.26.3

2 4

[libvirt PATCH] gitlab: enable debug output for test suite
by Daniel P. Berrangé 05 May '21

05 May '21

When CI jobs fail on the test suite, we don't see much helpful information by default: stderr: TEST: bhyvexml2argvtest ......!!.............!......!........... 40 ........................!...... 71 FAIL Some tests failed. Run them using: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=7-8,22,29,65 /tmp/cirrus-ci-build/build/meson-private/dist-build/tests/bhyvexml2argvtest Following the instructions to re-run the test with VIR_TEST_DEBUG=1 is great if running locally, but quite unfriendly for CI. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Compare before: https://gitlab.com/libvirt/libvirt/-/jobs/1237988893 and after: https://gitlab.com/berrange/libvirt/-/jobs/1238324746 .gitlab-ci.yml | 2 ++ ci/cirrus/build.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 35ec626113..89f618e678 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -11,6 +11,8 @@ stages: export CCACHE_DIR="$CCACHE_BASEDIR/ccache" export CCACHE_MAXSIZE="500M" export PATH="$CCACHE_WRAPPERSDIR:$PATH" + export VIR_TEST_VERBOSE="1" + export VIR_TEST_DEBUG="1" # Common templates diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index 2d3c46a77c..f7ef5c2d13 100644 --- a/ci/cirrus/build.yml +++ b/ci/cirrus/build.yml @@ -9,6 +9,8 @@ env: PKG_CONFIG_PATH: "@PKG_CONFIG_PATH@" PYTHON: "@PYTHON@" MAKE: "@MAKE@" + VIR_TEST_VERBOSE: "1" + VIR_TEST_DEBUG: "1" build_task: install_script: -- 2.31.1

2 1

[PATCH] virDomainVideoDriverDefParseXML: Fix use of uninitialized variable
by Peter Krempa 05 May '21

05 May '21

Commit fc7e1b2f03cfe2a5f3fce737390548505382d8ed which refactored the video driver parse helper introduced a use of uninitialized variable, which caused test failure at least when compiled with clang. Pass 'def->vgaconf' directly to virXMLPropEnum. 'def' needs to be converted to use g_autofree to handle error scenarios. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed under the build-breaker fix rule. src/conf/domain_conf.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 64f525fc08..d5d8bd0a01 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14313,8 +14313,7 @@ static virDomainVideoDriverDef * virDomainVideoDriverDefParseXML(xmlNodePtr node, xmlXPathContextPtr ctxt) { - virDomainVideoDriverDef *def; - unsigned int val; + g_autofree virDomainVideoDriverDef *def = NULL; xmlNodePtr driver = NULL; VIR_XPATH_NODE_AUTORESTORE(ctxt) @@ -14323,15 +14322,14 @@ virDomainVideoDriverDefParseXML(xmlNodePtr node, if (!(driver = virXPathNode("./driver", ctxt))) return NULL; + def = g_new0(virDomainVideoDriverDef, 1); + if (virXMLPropEnum(driver, "vgaconf", virDomainVideoVGAConfTypeFromString, - VIR_XML_PROP_NONZERO, &val) < 0) + VIR_XML_PROP_NONZERO, &def->vgaconf) < 0) return NULL; - def = g_new0(virDomainVideoDriverDef, 1); - def->vgaconf = val; - - return def; + return g_steal_pointer(&def); } static virDomainVideoDef * -- 2.30.2

1 0

[libvirt PATCH 0/8] ci: Refresh contents, update list of targets
by Andrea Bolognani 05 May '21

05 May '21

This brings our pipeline in sync with the current status of the libvirt-ci repository. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/296773363 Andrea Bolognani (8): ci: Remove Fedora Rawhide dwarf4 hack ci: Rename CentOS Stream 8 and openSUSE Leap 15.2 containers ci: Refresh contents ci: Add openSUSE Tumbleweed ci: Add FreeBSD 13 ci: Add Fedora 34 ci: Drop Fedora 32 ci: Drop CentOS 7 .gitlab-ci.yml | 88 +++++------ ci/cirrus/freebsd-12.vars | 2 +- .../{freebsd-12.vars =3D> freebsd-13.vars} | 4 +- ci/cirrus/freebsd-current.vars | 2 +- ci/cirrus/macos-11.vars | 2 +- ci/containers/centos-7.Dockerfile | 138 ------------------ ci/containers/centos-8.Dockerfile | 2 +- ....Dockerfile =3D> centos-stream-8.Dockerfile} | 10 +- .../debian-10-cross-aarch64.Dockerfile | 4 +- .../debian-10-cross-armv6l.Dockerfile | 4 +- .../debian-10-cross-armv7l.Dockerfile | 4 +- ci/containers/debian-10-cross-i686.Dockerfile | 4 +- ci/containers/debian-10-cross-mips.Dockerfile | 4 +- .../debian-10-cross-mips64el.Dockerfile | 4 +- .../debian-10-cross-mipsel.Dockerfile | 4 +- .../debian-10-cross-ppc64le.Dockerfile | 4 +- .../debian-10-cross-s390x.Dockerfile | 4 +- ci/containers/debian-10.Dockerfile | 4 +- .../debian-sid-cross-aarch64.Dockerfile | 4 +- .../debian-sid-cross-armv6l.Dockerfile | 4 +- .../debian-sid-cross-armv7l.Dockerfile | 4 +- .../debian-sid-cross-i686.Dockerfile | 4 +- .../debian-sid-cross-mips64el.Dockerfile | 4 +- .../debian-sid-cross-mipsel.Dockerfile | 4 +- .../debian-sid-cross-ppc64le.Dockerfile | 4 +- .../debian-sid-cross-s390x.Dockerfile | 4 +- ci/containers/debian-sid.Dockerfile | 4 +- ci/containers/fedora-33.Dockerfile | 4 +- ...ora-32.Dockerfile =3D> fedora-34.Dockerfile} | 8 +- .../fedora-rawhide-cross-mingw32.Dockerfile | 4 +- .../fedora-rawhide-cross-mingw64.Dockerfile | 4 +- ci/containers/fedora-rawhide.Dockerfile | 4 +- ...ockerfile =3D> opensuse-leap-152.Dockerfile} | 6 +- ...kerfile =3D> opensuse-tumbleweed.Dockerfile} | 15 +- ci/containers/ubuntu-1804.Dockerfile | 4 +- ci/containers/ubuntu-2004.Dockerfile | 4 +- 36 files changed, 117 insertions(+), 260 deletions(-) copy ci/cirrus/{freebsd-12.vars =3D> freebsd-13.vars} (79%) delete mode 100644 ci/containers/centos-7.Dockerfile rename ci/containers/{centos-stream.Dockerfile =3D> centos-stream-8.Dockerfi= le} (89%) rename ci/containers/{fedora-32.Dockerfile =3D> fedora-34.Dockerfile} (93%) copy ci/containers/{opensuse-152.Dockerfile =3D> opensuse-leap-152.Dockerfil= e} (94%) rename ci/containers/{opensuse-152.Dockerfile =3D> opensuse-tumbleweed.Docke= rfile} (88%) --=20 2.26.3

2 9

[PATCH v1 0/4] libxl: fix affinity assignment
by Olaf Hering 05 May '21

05 May '21

Olaf Hering (4): libxl: remove obsolete VIR_LIBXL_EVENT_CONST libxl: remove obsolete check for result of xc_get_max_cpus libxl: remove obsolete libxlDomainSetVcpuAffinities function libxl: set vcpu affinity during domain creation src/libxl/libxl_conf.c | 53 ++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_domain.c | 48 +----------------------------------- src/libxl/libxl_domain.h | 18 +------------- src/libxl/libxl_driver.c | 6 +---- 4 files changed, 56 insertions(+), 69 deletions(-)

2 10

[PATCH v2] docs: cputune is also supported by the xen driver
by Olaf Hering 05 May '21

05 May '21

Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles a domain/cputune/vcpupin element in domU.xml. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 282176c4f4..fa5c14febc 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -744,8 +744,8 @@ CPU Tuning of element ``vcpu`` is not specified, the vCPU is pinned to all the physical CPUs by default. It contains two required attributes, the attribute ``vcpu`` specifies vCPU id, and the attribute ``cpuset`` is same as attribute - ``cpuset`` of element ``vcpu``. (NB: Only qemu driver support) :since:`Since - 0.9.0` + ``cpuset`` of element ``vcpu``. + :since:`QEMU driver support since 0.9.0, Xen driver support since 0.9.1` ``emulatorpin`` The optional ``emulatorpin`` element specifies which of host physical CPUs the "emulator", a subset of a domain not including vCPU or iothreads will be

2 1

[PATCH v1] docs: cputune is also supported by the xen driver
by Olaf Hering 04 May '21

04 May '21

Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles a domain/cputune/vcpupin element in domU.xml. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 282176c4f4..0328fe488b 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -744,8 +744,8 @@ CPU Tuning of element ``vcpu`` is not specified, the vCPU is pinned to all the physical CPUs by default. It contains two required attributes, the attribute ``vcpu`` specifies vCPU id, and the attribute ``cpuset`` is same as attribute - ``cpuset`` of element ``vcpu``. (NB: Only qemu driver support) :since:`Since - 0.9.0` + ``cpuset`` of element ``vcpu``. (NB: Only qemu and xen driver support) + :since:`Since 0.9.0` ``emulatorpin`` The optional ``emulatorpin`` element specifies which of host physical CPUs the "emulator", a subset of a domain not including vCPU or iothreads will be

2 1