- Devel - libvirt List Archives

[libvirt PATCH 0/2] fix disk XML formatting for qemuDomainBlockCopy API
by Pavel Hrdina 01 Jun '21

01 Jun '21

Pavel Hrdina (2): domain_conf: extract disk driver source bits to its own function virDomainDiskDefParseSource: parse source bits from driver element src/conf/domain_conf.c | 52 ++++++++++++++++++++++++++++++------------ 1 file changed, 37 insertions(+), 15 deletions(-) -- 2.31.1

2 3

[libvirt PATCH 00/26] meson: Various fixes and improvements
by Andrea Bolognani 01 Jun '21

01 Jun '21

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056 Andrea Bolognani (26): spec: Be explicit about more features meson: Whitespace tweaks meson: Don't use 'required: true' meson: Drop curl workaround meson: Drop netinet workaround meson: Use get_pkgconfig_variable('cflags') meson: Use built-in pcap detection meson: Make libm a required dependency meson: Drop numactl_version meson: Fix vstorage detection meson: Fix sanlock detection meson: Rewrite polkit check meson: Tweak XDR check meson: Fix disabling netcf meson: Rewrite firewalld check meson: Fix firewalld check meson: Rewrite libacl check meson: Use dependency() when possible meson: Rewrite apparmor_profiles check meson: Turn apparmor_profiles into a feature meson: Switch to autodetection for apparmor_profiles meson: Switch to autodetection for driver_remote meson: Switch to autodetection for driver_test meson: Style tweaks meson: Reorganize summary meson: Don't include warning flags in summary libvirt.spec.in | 3 + meson.build | 301 +++++++++++++++++++------------------ meson_options.txt | 6 +- mingw-libvirt.spec.in | 2 + src/locking/meson.build | 4 +- src/qemu/qemu_namespace.c | 2 +- src/util/virfile.c | 8 +- src/util/virnetdevbridge.c | 18 --- 8 files changed, 166 insertions(+), 178 deletions(-) -- 2.31.1

2 32

Release of libvirt-7.4.0
by Jiri Denemark 01 Jun '21

01 Jun '21

The 7.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any other feedback. Your work is greatly appreciated. * Removed features * qemu: Remove support for QEMU < 2.11 In accordance with our platform support policy, the oldest supported QEMU version is now bumped from 1.5 to 2.11. * New features * qemu: Add support for hotplugging ``<transient/>`` disks The disk hotplug code in the qemu driver now can handle hotplug of disks with automatically added overlay. * qemu: Add support for sharing base image of ``<transient/>`` disks Users can use ``<transient shareBacking='yes'/>`` to tell the qemu driver to never open the base image in write mode thus multiple VMs can share the same image. Note that the disk will be hotplugged during startup. * Improvements * Add win-dmp crashdump format New ``win-dmp`` format for ``virDomainCoreDumpWithFormat`` API and/or virsh ``dump --format`` was introduced. * Bug fixes * Allow 0 offset in XML schema for ``<slice type='storage' offset='0' size='321'/>`` Having a 0 offset so that the size of the image can be limited is a valid configuration so it was allowed in the XML schema. Enjoy. Jirka

1 0

[libvirt PATCH] docs: introduce stubs for new libvirt Go packages
by Daniel P. Berrangé 01 Jun '21

01 Jun '21

Currently we expose libvirt Go packages at libvirt.org/libvirt-go libvirt.org/libvirt-go-xml These packages have not supported Go modules historically and when we tried to introduce modules, we hit the problem that we're not using semver for versioning. The only way around this is to introduce new packages under a different namespace, that will have the exact same code, but be tagged with a different version numbering scheme. This change proposes: libvirt.org/go/libvirt libvirt.org/go/libvirtxml Note the hyphen is removed so that the import basename matches the Go package name. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- The corresponding repos exist https://gitlab.com/libvirt/libvirt-go-module https://gitlab.com/libvirt/libvirt-go-xml-module but I'm leaving them empty until we've completed this release, then I'll populate with content matching 7.4.0, minus the existing tags. This change should also wait until after the release. docs/go/libvirt.rst | 13 +++++++++++ docs/go/libvirtxml.rst | 10 ++++++++ docs/go/meson.build | 53 ++++++++++++++++++++++++++++++++++++++++++ docs/meson.build | 1 + 4 files changed, 77 insertions(+) create mode 100644 docs/go/libvirt.rst create mode 100644 docs/go/libvirtxml.rst create mode 100644 docs/go/meson.build diff --git a/docs/go/libvirt.rst b/docs/go/libvirt.rst new file mode 100644 index 0000000000..46250691c1 --- /dev/null +++ b/docs/go/libvirt.rst @@ -0,0 +1,13 @@ +======================= +Libvirt Go Language API +======================= + +The `Go <https://golang.org/>`__ package ``libvirt.org/go/libvirt`` provides +`CGo <https://golang.org/cmd/cgo/>`__ binding from the OS native Libvirt API. + +In general the Go representation is a direct 1-1 mapping from native API +concepts to Go, so the native API documentation should serve as a reference +for most behaviour. + +For details of Go specific behaviour consult the +`Go package documentation <https://pkg.go.dev/libvirt.org/go/libvirt>`__. diff --git a/docs/go/libvirtxml.rst b/docs/go/libvirtxml.rst new file mode 100644 index 0000000000..7583433f56 --- /dev/null +++ b/docs/go/libvirtxml.rst @@ -0,0 +1,10 @@ +========================== +Libvirt Go XML parsing API +========================== + +The `Go <https://golang.org/>`__ package ``libvirt.org/go/libvirtxml`` provides +annotated Go struct definitions for parsing (and formatting) XML documents used +with libvirt APIs. + +For details of Go specific behaviour consult the +`Go package documentation <https://pkg.go.dev/libvirt.org/go/libvirtxml>`__. diff --git a/docs/go/meson.build b/docs/go/meson.build new file mode 100644 index 0000000000..99fa1b074a --- /dev/null +++ b/docs/go/meson.build @@ -0,0 +1,53 @@ +docs_go_files = [ + 'libvirt', + 'libvirtxml', +] + +html_xslt_gen_xslt = subsite_xsl +html_xslt_gen_install_dir = docs_html_dir / 'go' +html_xslt_gen = [] + +foreach name : docs_go_files + rst_file = '@0@.rst'.format(name) + + html_xslt_gen += { + 'name': name, + 'file': docs_rst2html_gen.process(rst_file), + 'source': 'docs/go' / rst_file, + } +endforeach + +# keep the XSLT processing code block in sync with docs/meson.build + +# --- begin of XSLT processing --- + +foreach data : html_xslt_gen + html_filename = data['name'] + '.html' + + html_file = custom_target( + html_filename, + input: data.get('file', data['name'] + '.html.in'), + output: html_filename, + command: [ + xsltproc_prog, + '--stringparam', 'pagesrc', data.get('source', ''), + '--stringparam', 'builddir', meson.build_root(), + '--stringparam', 'timestamp', docs_timestamp, + '--nonet', + html_xslt_gen_xslt, + '@INPUT@', + ], + depends: data.get('depends', []), + depend_files: [ page_xsl ], + capture: true, + install: true, + install_dir: html_xslt_gen_install_dir, + ) + + install_web_deps += html_file + install_web_files += html_file.full_path() + ':' + html_xslt_gen_install_dir +endforeach + +html_xslt_gen = [] + +# --- end of XSLT processing --- diff --git a/docs/meson.build b/docs/meson.build index f550629d8e..d7afdbd323 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -296,6 +296,7 @@ html_xslt_gen = [] # --- end of XSLT processing --- subdir('fonts') +subdir('go') subdir('html') subdir('internals') subdir('js') -- 2.31.1

2 1

[PATCH] NEWS: disks: Mention <transient> improvements and <slice> XML fix
by Peter Krempa 01 Jun '21

01 Jun '21

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8358cbd369..66ce95d7cb 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -20,6 +20,17 @@ v7.4.0 (unreleased) * **New features** + * qemu: Add support for hotplugging ``<transient/>`` disks + + The disk hotplug code in the qemu driver now can handle hotplug of disks + with automatically added overlay. + + * qemu: Add support for sharing base image of ``<transient/>`` disks + + Users can use ``<transient shareBacking='yes'/>`` to tell the qemu driver to + never open the base image in write mode thus multiple VMs can share the + same image. Note that the disk will be hotplugged during startup. + * **Improvements** * Add win-dmp crashdump format @@ -29,6 +40,10 @@ v7.4.0 (unreleased) * **Bug fixes** + * Allow 0 offset in XML schema for ``<slice type='storage' offset='0' size='321'/>`` + + Having a 0 offset so that the size of the image can be limited is a + valid configuration so it was allowd in the XML schema. v7.3.0 (2021-05-03) =================== -- 2.31.1

2 1

[PATCH] qemuProcessSetupDisksTransientSnapshot: Skip enabling transientOverlayCreated flag
by Masayoshi Mizuma 01 Jun '21

01 Jun '21

From: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com> QEMU_DOMAIN_DISK_PRIVATE(disk)->transientOverlayCreated flag gets true unexpectedly on qemuProcessSetupDisksTransientSnapshot() when the disk has <transient shareBacking='yes'> option. The flag should be enabled on qemuDomainAttachDiskGeneric() after the overlay setup is completed. Skip enabling transientOverlayCreated for the disk here. Fixes: 75871da0ecb8b552f9e304d0f83e216839bbf82d Signed-off-by: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com> --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9b069fe7ce..c37687f249 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7039,7 +7039,8 @@ qemuProcessSetupDisksTransientSnapshot(virDomainObj *vm, for (i = 0; i < vm->def->ndisks; i++) { virDomainDiskDef *domdisk = vm->def->disks[i]; - if (!domdisk->transient) + if (!domdisk->transient || + domdisk->transientShareBacking == VIR_TRISTATE_BOOL_YES) continue; QEMU_DOMAIN_DISK_PRIVATE(domdisk)->transientOverlayCreated = true; -- 2.27.0

2 1

[libvirt PATCH 00/10] remote: various refactoring & bugs for remote driver
by Daniel P. Berrangé 27 May '21

27 May '21

This is in prep for switching to use the modular daemons by default. In testing that setup I hit a couple of minor bugs. Daniel P. Berrangé (10): remote: use absolute path to check for daemons remote: stop checking for errors from socket allocations remote: move open flags enum to sockets header remote: consistently use flags for passing ro/user/autostart props remote: change socket helper to return full daemon path remote: don't populate daemon path if autostart is not required rpc: remove "spawnDaemon" parameter remote: move proxy/mode defaults after URI parsing remote: fix regression connecting to remote session daemon remote: use virtproxyd if no URI is given src/admin/admin_remote.c | 2 +- src/locking/lock_driver_lockd.c | 1 - src/logging/log_manager.c | 1 - src/lxc/lxc_monitor.c | 2 +- src/qemu/qemu_migration.c | 3 +- src/remote/remote_daemon_dispatch.c | 4 +- src/remote/remote_driver.c | 135 ++++++++++++---------------- src/remote/remote_sockets.c | 95 +++++++++++++------- src/remote/remote_sockets.h | 15 ++-- src/remote/remote_ssh_helper.c | 16 ++-- src/rpc/virnetclient.c | 5 +- src/rpc/virnetclient.h | 3 +- src/rpc/virnetsocket.c | 26 ++---- src/rpc/virnetsocket.h | 3 +- tests/virnetsockettest.c | 4 +- 15 files changed, 157 insertions(+), 158 deletions(-) -- 2.31.1

3 15

Entering freeze for libvirt-7.4.0
by Jiri Denemark 27 May '21

27 May '21

I have just tagged v7.4.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

2 3

[libvirt PATCH 0/2] Revert mdev autostart support
by Jonathon Jongsma 27 May '21

27 May '21

As Daniel Berrange mentioned, the method of supporting autostart for node devices was not consistent with other libvirt objects. This patch series reverts this feature before it gets into a release. I will submit a follow-up patch soon which adds the feature back with a consistent API. Jonathon Jongsma (2): Partial Revert of "tests: nodedevxml2xmltest: test more mdev files" nodedev: Revert auto-start property for mdevs docs/formatnode.html.in | 10 --------- docs/schemas/nodedev.rng | 11 ---------- src/conf/node_device_conf.c | 21 +------------------ src/conf/node_device_conf.h | 12 ----------- src/libvirt_private.syms | 2 -- src/node_device/node_device_driver.c | 7 +------ .../mdevctl-list-multiple.out.xml | 4 ---- tests/nodedevschemadata/mdev_autostart.xml | 10 --------- tests/nodedevschemadata/mdev_manual.xml | 10 --------- ...v_3627463d_b7f0_4fea_b468_f1da537d301b.xml | 10 +-------- tests/nodedevxml2xmlout/mdev_autostart.xml | 11 ---------- ...v_d069d019_36ea_4111_8f0a_8c9a70e21366.xml | 1 - ...v_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml | 1 - ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml | 11 +--------- ...v_fedc4916_1ca8_49ac_b176_871d16c13076.xml | 1 - tests/nodedevxml2xmlout/mdev_manual.xml | 11 ---------- tests/nodedevxml2xmltest.c | 2 -- 17 files changed, 4 insertions(+), 131 deletions(-) delete mode 100644 tests/nodedevschemadata/mdev_autostart.xml delete mode 100644 tests/nodedevschemadata/mdev_manual.xml mode change 100644 => 120000 tests/nodedevxml2xmlout/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml delete mode 100644 tests/nodedevxml2xmlout/mdev_autostart.xml mode change 100644 => 120000 tests/nodedevxml2xmlout/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml delete mode 100644 tests/nodedevxml2xmlout/mdev_manual.xml -- 2.31.1

3 8

[PATCH for 7.4.0] virCapabilitiesHostNUMAInitReal: Don't jump over cleanup
by Michal Privoznik 27 May '21

27 May '21

In one of my recent commits I've done some renaming. But whilst doing so I also mistakenly replaced 'goto cleanup' with 'return -1' in virCapabilitiesHostNUMAInitReal() which was incorrect. Fixes: fe25224fdaa53bbeceed3ddeef1b3a150665e656 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 1290c9c15d..2f9a1e7d1f 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -1623,7 +1623,7 @@ virCapabilitiesHostNUMAInitReal(virCapsHostNUMA *caps) } if (virCapabilitiesGetNUMADistances(n, &distances, &ndistances) < 0) - return -1; + goto cleanup; if (virCapabilitiesGetNUMAPagesInfo(n, &pageinfo, &npageinfo) < 0) goto cleanup; -- 2.31.1

2 1