- Devel - libvirt List Archives

[PATCH] meson: Detect rst2html5 and rst2man only when needed
by Ivan Teterevkov 13 Jan '22

13 Jan '22

Detect these commands in docs/meson.build, i.e. only when users enable documentation. Signed-off-by: Ivan Teterevkov <ivan.teterevkov(a)nutanix.com> --- docs/meson.build | 41 +++++++++++++++++++++++++++++++++++++++++ meson.build | 31 ------------------------------- 2 files changed, 41 insertions(+), 31 deletions(-) diff --git a/docs/meson.build b/docs/meson.build index 3e912f21ad..50c12cc3c2 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -171,6 +171,47 @@ docs_lxc_api_xml = docs_api_generated[1] docs_qemu_api_xml = docs_api_generated[2] docs_admin_api_xml = docs_api_generated[3] +docs_programs_groups = [ + { 'name': 'rst2html5', 'prog': [ 'rst2html5', 'rst2html5.py', 'rst2html5-3' ] }, + { 'name': 'rst2man', 'prog': [ 'rst2man', 'rst2man.py', 'rst2man-3' ] }, +] + +foreach item : docs_programs_groups + prog = find_program(item.get('prog'), dirs: libvirt_sbin_path) + varname = item.get('name').underscorify() + conf.set_quoted(varname.to_upper(), prog.path()) + set_variable('@0@_prog'.format(varname), prog) +endforeach + +# There are two versions of rst2html5 in the wild: one is the version +# coming from the docutils package, and the other is the one coming +# from the rst2html5 package. These versions are subtly different, +# and the libvirt documentation can only be successfully generated +# using the docutils version. Every now and then, users will report +# build failures that can be traced back to having the wrong version +# installed. +# +# The only reliable way to tell the two binaries apart seems to be +# looking look at their version information: the docutils version +# will report +# +# rst2html5 (Docutils ..., Python ..., on ...) +# +# whereas the rst2html5 version will report +# +# rst2html5 ... (Docutils ..., Python ..., on ...) +# +# with the additional bit of information being the version number for +# the rst2html5 package itself. +# +# Use this knowledge to detect the version that we know doesn't work +# for building libvirt and reject it +rst2html5_version = run_command(rst2html5_prog, '--version') +rst2html5_version = rst2html5_version.stdout().split(' ') +if rst2html5_version[1] != '(Docutils' + error('Please uninstall the rst2html5 package and install the docutils package') +endif + docs_rst2html5_gen = generator( rst2html5_prog, output: '@BASENAME@.html.in', diff --git a/meson.build b/meson.build index 214a3f05eb..0d98f13d5e 100644 --- a/meson.build +++ b/meson.build @@ -788,8 +788,6 @@ required_programs = [ required_programs_groups = [ { 'name': 'rpcgen', 'prog': [ 'rpcgen', 'portable-rpcgen' ] }, - { 'name': 'rst2html5', 'prog': [ 'rst2html5', 'rst2html5.py', 'rst2html5-3' ] }, - { 'name': 'rst2man', 'prog': [ 'rst2man', 'rst2man.py', 'rst2man-3' ] }, ] if host_machine.system() == 'freebsd' @@ -810,35 +808,6 @@ foreach item : required_programs_groups set_variable('@0@_prog'.format(varname), prog) endforeach -# There are two versions of rst2html5 in the wild: one is the version -# coming from the docutils package, and the other is the one coming -# from the rst2html5 package. These versions are subtly different, -# and the libvirt documentation can only be successfully generated -# using the docutils version. Every now and then, users will report -# build failures that can be traced back to having the wrong version -# installed. -# -# The only reliable way to tell the two binaries apart seems to be -# looking look at their version information: the docutils version -# will report -# -# rst2html5 (Docutils ..., Python ..., on ...) -# -# whereas the rst2html5 version will report -# -# rst2html5 ... (Docutils ..., Python ..., on ...) -# -# with the additional bit of information being the version number for -# the rst2html5 package itself. -# -# Use this knowledge to detect the version that we know doesn't work -# for building libvirt and reject it -rst2html5_version = run_command(rst2html5_prog, '--version') -rst2html5_version = rst2html5_version.stdout().split(' ') -if rst2html5_version[1] != '(Docutils' - error('Please uninstall the rst2html5 package and install the docutils package') -endif - # optional programs optional_programs = [ -- 2.35.0-rc0

2 1

[PATCH] NEWS: Mention propagation of sub-cluster allocation on snapshots and block-copy
by Peter Krempa 13 Jan '22

13 Jan '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d9fd50a067..c6970814b1 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -57,6 +57,13 @@ v8.0.0 (unreleased) * libxl: Implement the virDomainGetMessages API + * qemu: Preserve qcow2 sub-cluster allocation state after external snapshots and block-copy + + The new image which is installed as an overlay on top of the current chain + when taking an external snapshot, or the target of a block copy operation + now enables sub-cluster allocation (``extended_l2``) if the original + image has the option enabled. + * **Bug fixes** * qemu: Fix device hot-unplug with ``libvirt-7.9`` or ``libvirt-7.10`` used with ``qemu-6.2`` -- 2.31.1

2 1

Entering freeze for libvirt-8.0.0
by Jiri Denemark 13 Jan '22

13 Jan '22

I have just tagged v8.0.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

2 2

[PATCH] docs: tpm: Clarify omission or removal of active_pcr_banks node
by Stefan Berger 13 Jan '22

13 Jan '22

Add a sentence to the active_pcr_banks node documentation that clarifies that when the active_pcr_banks node is removed from the XML or when it is omitted that the set of active PCR banks is not changed anymore. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2039246 Signed-off-by: Stefan Berger <stefanb(a)linux.ibm.com> --- docs/formatdomain.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d4f30bb8af..a84be77c37 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -7640,6 +7640,8 @@ Example: usage of the TPM Emulator of a TPM 2.0 to activate. Valid names are for example sha1, sha256, sha384, and sha512. If this node is provided, the set of PCR banks are activated before every start of a VM and this step is logged in the swtpm's log. + If this node is removed or omitted then libvirt will not modify the + active PCR banks upon VM start but leave them at their last configuration. This attribute requires that swtpm_setup v0.7 or later is installed and may not have any effect otherwise. The selection of PCR banks only works with the ``emulator`` backend. since:`Since 7.10.0` -- 2.31.1

2 1

[PATCH] NEWS: Document my contributions for upcoming release
by Michal Privoznik 13 Jan '22

13 Jan '22

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index b5893627e3..32ab0c801e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -90,6 +90,24 @@ v8.0.0 (unreleased) </qemu:capabilities> </domain> + * Fix sparse streams with split daemon + + In split daemon scenario, when a client connected to a hypervisor driver + using sparse streams (e.g. ``virsh vol-download --sparse``) would make the + hypervisor daemon enter an infinite loop without any data transfer. This is + now fixed. + + * Build no longer requires RPC library + + Code and its cross dependencies were fixed so that build without remote + driver and thus an RPC library (like ``tirpc``) fails no more. + + * virnetdevopenvswitch: Fix 'burst' value passed to ovs-vsctl + + When a ``<bandwidth/>`` was defined for an TAP device that's plugged into an + OvS bridge values passed to the OvS were incorrectly recalculated resulting + in slightly different limits being applied. + v7.10.0 (2021-12-01) ==================== -- 2.34.1

2 1

[PATCH] rpc: Emit a warning when applying RPC throttling
by Ivan Teterevkov 13 Jan '22

13 Jan '22

Whenever the number of outstanding requests being served reaches max_client_requests, the RPC server applies RX throttling and temporarily stops receiving incoming data. Consequently, it stops receiving the keep-alive responses from the client and eventually may cause a connection timeout on the server-side. This patch emits a warning message in such cases so that the users may root-cause the connection timeout and reconfigure max_client_requests depending on their application. Signed-off-by: Ivan Teterevkov <ivan.teterevkov(a)nutanix.com> --- src/rpc/virnetserverclient.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 7050430e17..9d86e1ba3e 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1293,6 +1293,10 @@ static virNetMessage *virNetServerClientDispatchRead(virNetServerClient *client) client->rx->buffer = g_new0(char, client->rx->bufferLength); client->nrequests++; } + } else { + VIR_WARN("Applying RPC throttling, consider increasing " + "max_client_requests (client->nrequests_max=%zu)", + client->nrequests_max); } virNetServerClientUpdateEvent(client); -- 2.35.0-rc0

1 0

[PATCH] Fix missing-field-initializers error
by huangy81＠chinatelecom.cn 12 Jan '22

12 Jan '22

From: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn> When compile libvirt via ninja tool with default configuration, it report the error message as the following: "missing initializer for field 'path' of 'virTPMBinaryInfo'". So initialize the 'path' field in 'virTPMBinaryInfo' with 'NULL'. Signed-off-by: Hyman Huang(黄勇) <huangy81(a)chinatelecom.cn> --- src/util/virtpm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virtpm.c b/src/util/virtpm.c index cf4c7c4..a02d933 100644 --- a/src/util/virtpm.c +++ b/src/util/virtpm.c @@ -122,13 +122,16 @@ typedef struct _virTPMBinaryInfo { static virTPMBinaryInfo swtpmBinaries[VIR_TPM_BINARY_LAST] = { [VIR_TPM_BINARY_SWTPM] = { + .path = NULL, .parm = "socket", .capsParse = virTPMSwtpmFeatureTypeFromString, }, [VIR_TPM_BINARY_SWTPM_SETUP] = { + .path = NULL, .capsParse = virTPMSwtpmSetupFeatureTypeFromString, }, [VIR_TPM_BINARY_SWTPM_IOCTL] = { + .path = NULL, }, }; -- 1.8.3.1

3 4

[PATCH for 8.0 0/3] Fix creation of snapshots without libvirt metadata
by Peter Krempa 12 Jan '22

12 Jan '22

After a recent unreleased refactor we don't remove the temporary snapshot object from the list when finishing a snapshot without metadata thus we should fix it before releasing a buggy release. This patchset fixes it by not adding it into the list in the first place. Peter Krempa (3): virdomainmomentobjlist.h: Convert to modern header style conf: moment: Export helpers to create the virDomainMoment wrapper qemuSnapshotCreate: Don't insert snapshot into list with VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA src/conf/virdomainmomentobjlist.c | 4 +- src/conf/virdomainmomentobjlist.h | 121 +++++++++++++++++++----------- src/libvirt_private.syms | 2 + src/qemu/qemu_snapshot.c | 25 +++--- 4 files changed, 97 insertions(+), 55 deletions(-) -- 2.31.1

2 6

[PATCH v4] report error when virProcessGetStatInfo() is unable to parse data
by Ani Sinha 12 Jan '22

12 Jan '22

Currently virProcessGetStatInfo() always returns success and only logs error when it is unable to parse the data. Make this function actually report the error and return a negative value in this error scenario. Fix the callers so that they do not override the error generated. Also fix non-linux implementation of this function so as to report error. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/ch/ch_driver.c | 2 -- src/qemu/qemu_driver.c | 7 +------ src/util/virprocess.c | 17 +++++++++++++---- 3 files changed, 14 insertions(+), 12 deletions(-) changelog: v4: on freebsd error on the logs is a problem appaently. try to fix that. v3: fix non linux implementation v2: fix callers diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 53e0872207..3cbc668489 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -1073,8 +1073,6 @@ chDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d3d76c003f..65ac5ef367 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1359,8 +1359,6 @@ qemuDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } @@ -2521,8 +2519,6 @@ qemuDomainGetInfo(virDomainPtr dom, if (virDomainObjIsActive(vm)) { if (virProcessGetStatInfo(&(info->cpuTime), NULL, NULL, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot read cputime for domain")); goto cleanup; } } @@ -10530,8 +10526,7 @@ qemuDomainMemoryStatsInternal(virQEMUDriver *driver, } if (virProcessGetStatInfo(NULL, NULL, &rss, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot get RSS for domain")); + virResetLastError(); } else { stats[ret].tag = VIR_DOMAIN_MEMORY_STAT_RSS; stats[ret].val = rss; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index b559a4257e..cbb31441cc 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1779,12 +1779,20 @@ virProcessGetStatInfo(unsigned long long *cpuTime, long rss = 0; int cpu = 0; - if (!proc_stat || - virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_UTIME], NULL, 10, &usertime) < 0 || + if (!proc_stat) { + VIR_WARN("Unable to get proc stats from the kernel"); + return 0; + } + + if (virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_UTIME], NULL, 10, &usertime) < 0 || virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_STIME], NULL, 10, &systime) < 0 || virStrToLong_l(proc_stat[VIR_PROCESS_STAT_RSS], NULL, 10, &rss) < 0 || virStrToLong_i(proc_stat[VIR_PROCESS_STAT_PROCESSOR], NULL, 10, &cpu) < 0) { - VIR_WARN("cannot parse process status data"); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse process status data for pid '%d/%d'"), + (int) pid, (int) tid); + + return -1; } /* We got jiffies @@ -1881,7 +1889,8 @@ virProcessGetStatInfo(unsigned long long *cpuTime G_GNUC_UNUSED, pid_t pid G_GNUC_UNUSED, pid_t tid G_GNUC_UNUSED) { - errno = ENOSYS; + virReportSystemError(ENOSYS, "%s", + _("Process statistics data is not supported on this platform")); return -1; } -- 2.25.1

2 4

[PATCH v3] report error when virProcessGetStatInfo() is unable to parse data
by Ani Sinha 12 Jan '22

12 Jan '22

Currently virProcessGetStatInfo() always returns success and only logs error when it is unable to parse the data. Make this function actually report the error and return a negative value in this error scenario. Fix the callers so that they do not override the error generated. Also fix non-linux implementation of this function so as to report error. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/ch/ch_driver.c | 2 -- src/qemu/qemu_driver.c | 7 +------ src/util/virprocess.c | 9 +++++++-- 3 files changed, 8 insertions(+), 10 deletions(-) changelog: v3: fix non-linux implementation v2: fix callers diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 53e0872207..3cbc668489 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -1073,8 +1073,6 @@ chDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d3d76c003f..9a17c93b08 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1359,8 +1359,6 @@ qemuDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } @@ -2521,8 +2519,6 @@ qemuDomainGetInfo(virDomainPtr dom, if (virDomainObjIsActive(vm)) { if (virProcessGetStatInfo(&(info->cpuTime), NULL, NULL, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot read cputime for domain")); goto cleanup; } } @@ -10530,8 +10526,7 @@ qemuDomainMemoryStatsInternal(virQEMUDriver *driver, } if (virProcessGetStatInfo(NULL, NULL, &rss, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot get RSS for domain")); + return -1; } else { stats[ret].tag = VIR_DOMAIN_MEMORY_STAT_RSS; stats[ret].val = rss; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index b559a4257e..709ec616de 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1784,7 +1784,11 @@ virProcessGetStatInfo(unsigned long long *cpuTime, virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_STIME], NULL, 10, &systime) < 0 || virStrToLong_l(proc_stat[VIR_PROCESS_STAT_RSS], NULL, 10, &rss) < 0 || virStrToLong_i(proc_stat[VIR_PROCESS_STAT_PROCESSOR], NULL, 10, &cpu) < 0) { - VIR_WARN("cannot parse process status data"); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse process status data for pid '%d/%d'"), + (int) pid, (int) tid); + + return -1; } /* We got jiffies @@ -1881,7 +1885,8 @@ virProcessGetStatInfo(unsigned long long *cpuTime G_GNUC_UNUSED, pid_t pid G_GNUC_UNUSED, pid_t tid G_GNUC_UNUSED) { - errno = ENOSYS; + virReportSystemError(ENOSYS, "%s", + _("Process statistics data is not supported on this platform")); return -1; } -- 2.25.1

2 3