- Devel - libvirt List Archives

[libvirt PATCHv2 0/3] remove transitional virtio-input-host support
by Ján Tomko 18 Jan '22

18 Jan '22

*** BLURB HERE *** Ján Tomko (3): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- src/qemu/qemu_validate.c | 26 +++++-------------- .../virtio-non-transitional.x86_64-3.1.0.args | 4 +-- ...virtio-non-transitional.x86_64-latest.args | 4 +-- .../virtio-non-transitional.xml | 3 --- .../virtio-transitional.x86_64-3.1.0.args | 3 +-- .../virtio-transitional.x86_64-latest.args | 3 +-- .../qemuxml2argvdata/virtio-transitional.xml | 3 --- .../virtio-non-transitional.x86_64-latest.xml | 11 +------- .../virtio-transitional.x86_64-latest.xml | 6 +---- 11 files changed, 12 insertions(+), 55 deletions(-) -- 2.31.1

2 4

[libvirt PATCH 0/2] remove transitional virtio-input-host support
by Ján Tomko 18 Jan '22

18 Jan '22

Ján Tomko (2): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- .../qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../qemuxml2argvdata/virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-latest.args | 2 +- 6 files changed, 4 insertions(+), 8 deletions(-) -- 2.31.1

2 4

[PATCH] remote: systemd: Remove unix sockets from filesystem when disabling a '.socket' unit
by Peter Krempa 18 Jan '22

18 Jan '22

The existence of the unix socket path is used by the remote driver to determine whether modular daemons are in use, so if the socket file stays behind and the user decided to switch from modular to monolithic daemon which was socket activated, the remote driver will insist on picking '/var/run/libvirt/virtqemud-sock', even when it's no longer in use: # systemctl start libvirtd.service # virsh list Id Name State -------------------- # systemctl stop libvirtd.service Warning: Stopping libvirtd.service, but it can still be activated by: libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket # systemctl start virtqemud.socket # virsh list Id Name State -------------------- # systemctl stop virtqemud.socket # systemctl start libvirtd.service # virsh list error: failed to connect to the hypervisor error: Failed to connect socket to '/var/run/libvirt/virtqemud-sock': Connection refused # virsh -c 'qemu:///system?socket=/var/run/libvirt/libvirt-sock' list Id Name State -------------------- Fix this by instructing systemd to delete the socket file when deactivating the unit file for the socket. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/remote/libvirtd.socket.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/libvirtd.socket.in b/src/remote/libvirtd.socket.in index 85b4aa800a..0f349656f5 100644 --- a/src/remote/libvirtd.socket.in +++ b/src/remote/libvirtd.socket.in @@ -9,6 +9,7 @@ Before=@service@.service ListenStream=@runstatedir@/libvirt/@sockprefix@-sock Service=@service@.service SocketMode=@mode@ +RemoveOnStop=yes [Install] WantedBy=sockets.target -- 2.34.1

5 7

[PATCH v5 00/13] virdnsmasq: Lookup DNSMASQ in PATH
by Michal Privoznik 18 Jan '22

18 Jan '22

v5 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html diff to v4: - Switched to virCommandSetDryRun() in commit 10/13, because using a separate script was conflicting with ASAN. Tried to debug, failed miserably. - Extended error message from patch 11/13 to include virGetLastErrorMessage() (because if a test fails one simply doesn't access libvirt log in the CI). Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary() meson.build | 1 - src/libvirt_private.syms | 1 - src/util/virdnsmasq.c | 84 ++++++------------------------------- src/util/virdnsmasq.h | 1 - tests/meson.build | 1 + tests/networkxml2conftest.c | 47 ++++++++++++++++++--- tests/virdnsmasqmock.c | 19 +++++++++ 7 files changed, 75 insertions(+), 79 deletions(-) create mode 100644 tests/virdnsmasqmock.c -- 2.34.1

2 14

[PATCH] virDomainDeviceInfoParseXML: Reject '0' value for ACPI index
by Peter Krempa 18 Jan '22

18 Jan '22

Value of '0' is treated equivalently to when it's not provided by the user. Reject an explicit '0' provided by the user as it would get ignored. In this rare case we can make the XML parser more strict, as libvirt would never format the '<acpi/>' element if the index is '0' thus there are no libvirt-generated XMLs we'd not load back, as of such this is identical to rejecting it in the validation phase. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037146 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a805f7f6a3..393f9d9478 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6786,7 +6786,7 @@ virDomainDeviceInfoParseXML(virDomainXMLOption *xmlopt, } if ((acpi = virXPathNode("./acpi", ctxt))) { - if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONE, + if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONZERO, &info->acpiIndex) < 0) goto cleanup; } -- 2.34.1

2 1

[PATCH v4 00/13] virdnsmasq: Lookup DNSMASQ in PATH
by Michal Privoznik 18 Jan '22

18 Jan '22

v4 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00498.html diff to v3: - Removed even more code - Switched from virCommandDryRun to a python script, per Andrea's request - Reordered patches so that the mock doesn't need to redirect stat() - Renamed mock - Removed exec() of 'dnsmasq --help' Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary() meson.build | 1 - src/libvirt_private.syms | 1 - src/util/virdnsmasq.c | 84 ++++++------------------------------- src/util/virdnsmasq.h | 1 - tests/dnsmasqmock.py | 13 ++++++ tests/meson.build | 1 + tests/networkxml2conftest.c | 13 +++--- tests/virdnsmasqmock.c | 19 +++++++++ 8 files changed, 54 insertions(+), 79 deletions(-) create mode 100755 tests/dnsmasqmock.py create mode 100644 tests/virdnsmasqmock.c -- 2.34.1

3 21

[libvirt PATCH] qemu: Log which API is trying to acquire a job
by Jiri Denemark 18 Jan '22

18 Jan '22

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domainjob.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index c8fe8ad555..1ecde5af86 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -827,9 +827,11 @@ qemuDomainObjBeginJobInternal(virQEMUDriver *driver, unsigned long long duration = 0; unsigned long long agentDuration = 0; unsigned long long asyncDuration = 0; + const char *currentAPI = virThreadJobGet(); - VIR_DEBUG("Starting job: job=%s agentJob=%s asyncJob=%s " + VIR_DEBUG("Starting job: API=%s job=%s agentJob=%s asyncJob=%s " "(vm=%p name=%s, current job=%s agentJob=%s async=%s)", + NULLSTR(currentAPI), qemuDomainJobTypeToString(job), qemuDomainAgentJobTypeToString(agentJob), qemuDomainAsyncJobTypeToString(asyncJob), @@ -931,13 +933,14 @@ qemuDomainObjBeginJobInternal(virQEMUDriver *driver, if (priv->job.asyncJob && priv->job.asyncStarted) asyncDuration = now - priv->job.asyncStarted; - VIR_WARN("Cannot start job (%s, %s, %s) for domain %s; " + VIR_WARN("Cannot start job (%s, %s, %s) in API %s for domain %s; " "current job is (%s, %s, %s) " "owned by (%llu %s, %llu %s, %llu %s (flags=0x%lx)) " "for (%llus, %llus, %llus)", qemuDomainJobTypeToString(job), qemuDomainAgentJobTypeToString(agentJob), qemuDomainAsyncJobTypeToString(asyncJob), + NULLSTR(currentAPI), obj->def->name, qemuDomainJobTypeToString(priv->job.active), qemuDomainAgentJobTypeToString(priv->job.agentActive), -- 2.34.1

2 1

[PATCH 0/2] qemuDomainPinIOThread: Update live definition after process pinning
by Peter Krempa 18 Jan '22

18 Jan '22

see 2/2 Peter Krempa (2): qemuDomainPinIOThread: Copy the cpu bitmap instead of re-parsing it qemuDomainPinIOThread: Update live definition after process pinning src/qemu/qemu_driver.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) -- 2.34.1

3 4

[libvirt PATCH 0/6] util: virnetdev: use g_auto for virCommand
by Ján Tomko 18 Jan '22

18 Jan '22

Refactor some functions to remove more manual virCommand freeing. virNetDevBandwidthSet is left untouched. Ján Tomko (6): util: midonet: use g_auto for virCommand util: virNetDevBandwidthUpdateRate: refactor util: virNetDevBandwidthManipulateFilter: use g_auto util: virNetDevBandwidthClear: use g_auto util: refactor virNetDevBandwidthPlug util: refactor virNetDevBandwidthUnplug src/util/virnetdevbandwidth.c | 128 +++++++++++++--------------------- src/util/virnetdevmidonet.c | 20 ++---- 2 files changed, 53 insertions(+), 95 deletions(-) -- 2.31.1

2 7

[libvirt PATCH 0/6] util: openvswitch: cleanup
by Ján Tomko 18 Jan '22

18 Jan '22

Rearrange some code and remove 'cmd' variable reuse to get rid of manual 'virCommandFree' in functions using g_auto. Ján Tomko (6): util: openvswitch: move InterfaceClear{Rx,Tx}Qos util: openvswitch: unexport InterfaceClear{Rx,Tx}Qos util: openvswitch: split out virNetDevOpenvswitchInterfaceSetTxQos util: openvswitch: split out virNetDevOpenvswitchInterfaceSetRxQos util: openvswitch: do not reuse cmd in InterfaceSetTxQos util: openvswitch: do not reuse cmd in InterfaceClearTxQos src/libvirt_private.syms | 2 - src/util/virnetdevopenvswitch.c | 406 +++++++++++++++++--------------- src/util/virnetdevopenvswitch.h | 7 - 3 files changed, 213 insertions(+), 202 deletions(-) -- 2.31.1

2 7