- Devel - libvirt List Archives

Re: [Libvir] Patch to attach/detach virtual devices on a running domain
by michel.ponceau＠bull.net 21 Nov '06

21 Nov '06

There is a bug in GetNetworkID(): return(ret) with ret=list[i], after free(list). It leads to process abort on free(xref) in caller XMLDevID(). I corrected this by replacing: ret = list[i]; by: ret = malloc(16); if (ret != NULL) strcpy(ret, list[i]); Our tests were successful afterwards. Daniel Veillard <veillard(a)redhat.com> 20/11/2006 16:50 Veuillez répondre à veillard Pour : michel.ponceau(a)bull.net cc : libvir-list(a)redhat.com Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain On Thu, Nov 16, 2006 at 12:19:13PM -0500, Daniel Veillard wrote: > On Tue, Nov 14, 2006 at 10:05:47AM -0500, Daniel Veillard wrote: > > 5/ virDomainXMLDevID does direct acces to xs_directory() and xs_read(), > > that's not proper it should not call xenStore directly that need to > > be cleaned up, define one high level function exported from > > xs_internal.[ch] and call that but no direct access should be done > > that leads to unmaintainable code. > > That still need to be isolated, I added a TODO in src/xml.c to this effect. Okay I have done it, as a new function xenStoreDomainGetNetworkID() from xs_internal.[ch] Could you check out the version from CVS and verify I didn't added any regression ? thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] Patch to attach/detach virtual devices on a running domain
by michel.ponceau＠bull.net 20 Nov '06

20 Nov '06

This patch adds to Libvirt-0.1.8 the two functions described in my preceding mail. It has been tested in our Bull environment. Michel Ponceau 02/10/2006 17:27 Pour : libvir-list(a)redhat.com cc : Objet : Proposal for virtual devices described in XML Proposal modified after comments from Daniel P. Berrange: /* Create a virtual device attachment to backend */ int virDomainAttachDevice(virDomainPtr domain, char *xml); /* Destroy a virtual device attachment to backend */ int virDomainDetachDevice(virDomainPtr domain, char *xml); /* @domain: pointer to domain object * @xml: pointer to XML description of one device * Returns 0 in case of success, -1 in case of failure. */ The XML is in same form as the part of domain description for a single device, either <disk.../disk> or <interface.../interface>. In Detach function, the device is identified by its target name for "disk", and its MAC address for "interface". When the MAC address has not been assigned by Libvirt user at device creation, it must be retrieved from Xen using virDomainGetXMLDesc function.

3 4

[Libvir] [PATCH 0/6] Inactive domain support
by Daniel P. Berrange 16 Nov '06

16 Nov '06

The following series of patches is an update of my previous patches for supporting inactive domains in libvirt. A rough highlight of changes since last time: - Can override /etc/xen by setting LIBVIRT_XM_CONFIG_DIR env variable for people who move it to non-standard location - Several memory corruption bugs in config file refresh were solved - Fixed booting with paravirt framebuffer + grub - Added support for new APIs to python binding - Removed logic for supressing 404 errors (already merged earlier) - More complete device handling support (now creates network devices) Previous posting was here: http://www.redhat.com/archives/libvir-list/2006-September/msg00003.html Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 23

[Libvir] Request and proposition about hardware capabilities in virNodeInfo
by Philippe Berthault 16 Nov '06

16 Nov '06

Hello, To administrate virtual machines by using livbvirt, we need to known if the underlying hardware platform supports hvm (Intel-VT or AMD-V) or not. Currently, this information is returned by the "xm info" command of Xen in the "xen_caps" line but there is no equivalent in libvirt. So we propose to add this information in libvirt API. There is three possibilities for doing that: 1) Add one or several fields in the virNodeInfo structure returned by the virNodeGetInfo() function. These fields would be either strings such as strings returned by "xm info" or either bit fields with one bit per hardware capability. 2) Add one or several specific functions returning a boolean value for each hardware capability we want to test. 3) Add a specific function which returns either a bit fields of all the hardware capabilities or a structure such as virNodeInfo but far more complete. The problem with the proposition #1 is that the size of the virNodeInfo structure is changed. This implies for all libvirt users to recompile their programs linked with libvirt to avoid a 'core dump' at the execution. This is the reason why propositions 2 and 3 exist. NB: On an IA32 system, we can check flags in /proc/cpuinfo but on an IA64 platform with Montecito processors, there is no information about hardware capabilities in /proc/cpuinfo and the only way to known if the hardware supports hvm is by using the 'xm info' command. What is your opinion about these propositions ? Regards.

3 3

Re: [Libvir] Patch to attach/detach virtual devices on a running domain
by michel.ponceau＠bull.net 15 Nov '06

15 Nov '06

I cannot see the bug in virParseXMLDevice. The 'error' label sequence is ended by 'goto cleanup', and 'cleanup' sequence calls xmlFreeDoc(xml). Is it not the way to free the xmlDocPtr object 'xml'? Maybe I should reverse the sequence order to be more clear, as follows: + goto cleanup; +error: + free(buf.content); + buf.content = NULL; +cleanup: + if (xml != NULL) + xmlFreeDoc(xml); + return buf.content; "Daniel P. Berrange" <berrange(a)redhat.com> 14/11/2006 19:36 Veuillez répondre à "Daniel P. Berrange" Pour : michel.ponceau(a)bull.net cc : libvir-list(a)redhat.com Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain On Tue, Nov 14, 2006 at 03:34:05PM +0100, michel.ponceau(a)bull.net wrote: > This patch adds to Libvirt-0.1.8 the two functions described in my > preceding mail. It has been tested in our Bull environment. This looks good to me - only one small bug I see - in the virParseXMLDevice function there is a memory leak. If you take 'goto errror' path through the function, then the xmlDocPtr object will never be free'd. Thanks for taking the time to implement all this ! Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

1 0

[Libvir] [PATCH] Fixed integer wraparound in python binding
by Daniel P. Berrange 15 Nov '06

15 Nov '06

The attached patch fixes a problem with integrate wraparound in the python bindings. THe problem is thus: - the memory & max-memory fields in the virDomainInfo struct are of type 'unsigned long'. - The python bindings, however, then stick this into a python 'Int' which is signed. Now, on 64-bit this is not an issue. For DomU guests on 32-bit it is not an issue either, but for Dom0 XenD sets the max-memory field to be 2^32-1 whcih causes wraparound when converting to python int. This patch simply switches the python binding over to using a python Long which is 64 bits on all platforms. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] Support non-bridged network configs
by Daniel P. Berrange 15 Nov '06

15 Nov '06

The current code for parsing/serializing VIFs only really deals with the default bridged networking config for Xen. So if one uses network-route or network-nat it completely breaks. There is also no support for dealing with IP address in the XML / SEXPR. The attached patch fixes both of these issues, so we should be able to deal with any of the standard Xen networking configs. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Patch to attach/detach virtual devices on a running domain
by michel.ponceau＠bull.net 14 Nov '06

14 Nov '06

About your comments on virDomainXMLDevID() added in xml.c : 4/ For disks, it gets the target dev attribute, attached to a source either physical (if <disk type='block'>, <source dev=...>) or file (if <disk type='file'>, <source file=...>). Do you mean that it does not work in second case? 5/ In current xml.c (Libvirt-0.1.8), xs_directory() is directly accessed from virDomainGetXMLDevices() and virDomainGetXMLInterfaces(), xs_read() is directly accessed from virDomainGetXMLDeviceInfo(). Is this to be also changed, and "#include <xs.h>" removed from xml.c? Daniel Veillard <veillard(a)redhat.com> 14/11/2006 16:05 Veuillez répondre à veillard Pour : michel.ponceau(a)bull.net cc : libvir-list(a)redhat.com Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain On Tue, Nov 14, 2006 at 03:34:05PM +0100, michel.ponceau(a)bull.net wrote: > This patch adds to Libvirt-0.1.8 the two functions described in my > preceding mail. It has been tested in our Bull environment. There have been no negative comments to the interfaces proposed, so I guess we can assume that is okay, I'm still a bit vary of using XML for the Detach operation, but this avoid having to add the concept of device object at the API level right now, and keep things a bit simpler. Okay, here is a few remarks on the content of the patch: 1/ DOS end of lines in the patch, in general it's safer to do the diffs and code changes on a Unix box to avoid troubles :-) 2/ The public functions call directly the xenDaemon... implementation routines, that's not proper, everything need to go though the driver indirection, i.e. the driver structures need to be extended and the new functions need to be registered that way 3/ // type of code comments are banned in my code, sorry :-) 4/ virDomainXMLDevID() seems a bit weak, for example it seems to work only on disk registered though a physical device, though I think there is a need for (un)registering file based domU devices. For vif I wonder if the test on the mac address is really the only way to select the proper device, that's probably sufficient. 5/ virDomainXMLDevID does direct acces to xs_directory() and xs_read(), that's not proper it should not call xenStore directly that need to be cleaned up, define one high level function exported from xs_internal.[ch] and call that but no direct access should be done that leads to unmaintainable code. and a couple of tiny things left and right, which I can take care of. Basically 1/ 2/ 3/ are not blockers, I can fix those, for 4/ the limitations need at least to be documented, better fixed. 5/ really need to be fixed. I'm not against starting to work now to integrate that patch but I need 5 (and preferably 4/) to be fixed, if you agree I will work on the other points in parallel,

2 1

[Libvir] Conflict between libvirt 0.1.8 and Xen 3.0.3
by Philippe Berthault 14 Nov '06

14 Nov '06

There is a conflit between libvirt 0.1.8 and the latest release 3.0.3 of Xen. With Xen 3.0.3 release, the virsh vcpuinfo command (or virDomainGetVcpus API) always returns the 0 as physical CPU used by any vCPU. Example: #: xm vcpu-list VM1 Name ID VCPUs CPU State Time(s) CPU Affinity VM1 4 0 0 -b- 50.3 0 VM1 4 1 0 -b- 17.3 any cpu VM1 4 2 1 -b- 34.2 1 VM1 4 3 1 -b- 21.8 any cpu #: virsh vcpuinfo VM1 VCPU: 0 CPU: 0 ... VCPU: 1 CPU: 0 ... VCPU: 2 CPU: 0 ... VCPU: 3 CPU: 0 The same libvirt release 0.1.8 used with an older release of Xen gives a correct result. I currently investigate the problem but perhaps anyone has an idea of the origin of this problem.

2 1

[Libvir] announce: gnome-applet-vm 0.1.2
by Karel Zak 13 Nov '06

13 Nov '06

I have just pushed out a new 0.1.2 version of the VM Applet. The changes/features are: - removed dependence on dbus libs - improved collaboration with virt-manager (you have use the latest version of virt-manager) - fixed few minor bugs Web page: http://people.redhat.com/kzak/gnome-applet-vm/ TODO for next release(s): - finalize support for more hypervisors (the applet should be able to monitor cluster of VM machines on more hosts in same time) - alarm on important changes (domain create, destrory, ...) - keep track of important changes I welcome your feedback! Send me your comments, ideas for enhancements or bug reports. Karel -- Karel Zak <kzak(a)redhat.com>

1 0