- Devel - libvirt List Archives

[Libvir] Fix handling of config files with duplicate named guests
by Daniel P. Berrange 19 Dec '06

19 Dec '06

The code for managing config files in /etc/xen assumed that the filename of the config matched the name of the guest defined inside. One might thing this a reasonable assumption, but in the wild I've had reports from users whom have various config files for the same guest, but with different settings. This caused some really wierd behaviour in the current code base. virt-manager display would alternate displaying each config upon refresh! Now, our API requires that there is only one config per name, so we can't expose this to the UI. The attached patch, thus simply detects when we have more than one config with same named guest, and hides the duplicates. The way it does this is to change the way we cache configs. Previously we had a single hash table mapping relative filenames to virConfPtr objects, with the implicit assumption that relative filename == guest name. With the attached patch we now maintain two hash tables. The first maps fully qualified pathnames to virConfPtr objects, the second maps guest names to the first filename found for that name. Thus when querying details for a guest, we first resolve the guest name to its filename, and then lookup the virConfPtr object associated with this filename. This isn't perfect, but its a hell of alot better than current code, so I want to commit it as is and figure out more improvement later. There is no ABI issue here, so we can iterate over impl at will. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 4

[Libvir] Still can't run a simple python test libvirt !
by Omer Khalid 19 Dec '06

19 Dec '06

Hi, I am still unable to run my simple libvirt test! I checked out the code from libvirt cvs and following the instructions till 'make install'. It all went well. So then I ran my simply python test, as shown here (http://www.libvirt.org/python.html) It keeps on giving me the following error. [root@lcgctb9 libvirt]# python testLibvirt.py Traceback (most recent call last): File "testLibvirt.py", line 1, in ? import virt ImportError: No module named virt I have verified that the library is linked by the following: [root@lcgctb9 libvirt]# pkg-config libvirt --libs -L/usr/local/lib -lvirt -lxenstore [root@lcgctb9 libvirt]# pkg-config --variable=prefix libvirt /usr/local I really appreciate your help! Regards Omer -- --------------------------------------------------------------- CERN – European Organization for Nuclear Research Information Technology Department CH-1211 Geneva 23 Phone: +41 (0) 22 767 7996 Fax: +41 (0) 22 767 4900 E-mail : Omer.Khalid(a)cern.ch Homepage: http://cern.ch/Omer.Khalid

2 4

[Libvir] [PATCH] Inactive domain management for Xen 3.0.4
by Daniel P. Berrange 13 Dec '06

13 Dec '06

So, my previous set of patches for inactive domain management deal with the problem for Xen 3.0.3 or earlier. In 3.0.4 we now have lifecycle management support, which means we no longer need to scan /etc/xen config files if running against a new XenD. We choose between Xend & scanning /etc/xen files based on the condition 'xendConfigVersion >= 3'. The attached patch adds 5 new entry points to xend_internal.c xenDaemonListDefinedDomains xenDaemonNumOfDefinedDomains xenDaemonDomainCreate xenDaemonDomainDefineXML xenDaemonDomainUndefine These let you enumerate inactive domains, define new ones, delete old ones. Secondly, the patch modifies a number of existing methods to work against inactive domains too. Previously they'd unconditionally pass if the domain id was < 0. Now, if xendConfigVersion is >= 3, then they will know that XenD supports inactive domains & thus work for inactive guests too. xenDaemonDomainGetMaxMemory xenDaemonDomainSetMaxMemory xenDaemonDomainSetMemory xenDaemonDomainGetInfo xenDaemonDomainSetVcpus xenDaemonDomainDumpXML The methods for setting mem,max memory & vcpu count all required further bug fixes to Xend which have been sent upstream & hopefully merged soon. Finally, the patch changes the xendConfigVersion to be lookedup just once when initially connecting to XenD. Since we need this version info very frequently now, it was causing too much unnneccessary overload calling it every time. internal.h | 1 xend_internal.c | 270 +++++++++++++++++++++++++++++++++++++++++++++----------- xend_internal.h | 8 + xm_internal.c | 9 - 4 files changed, 227 insertions(+), 61 deletions(-) Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Libvirt Build problems
by Omer Khalid 13 Dec '06

13 Dec '06

Hi, I am trying to build libvirt on SL4 (kernal = 2.6.12.6-xen3_12.1_rhel4.1). I tried both snapshot tar ball and the cvs checked out version. With the tar ball, after running the ./configure script, make file is created. But make file fails and complains the following: libvirt.c:24:16: xs.h: No such file or directory In file included from libvirt.c:28: xen_internal.h:15:26: xen/dom0_ops.h: No such file or directory make[2]: *** [libvirt.lo] Error 1 make[2]: Leaving directory `/root/virtualization/libvirt2/libvirt-0.1.9/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/root/virtualization/libvirt2/libvirt-0.1.9' make: *** [all] Error 2 While with the cvs version, the script ./autogen.sh fails to create a make file. I am running Python 2.3.4 and gcc version 3.4.6 20060404 (Red Hat 3.4.6-3). Any help would be much appreciated. Best Regards Omer -- --------------------------------------------------------------- CERN – European Organization for Nuclear Research Information Technology Department CH-1211 Geneva 23 Phone: +41 (0) 22 767 7996 Fax: +41 (0) 22 767 4900 E-mail : Omer.Khalid(a)cern.ch

2 8

[Libvir] Update XML -> SEXPR conversion for new PVFB syntax
by Daniel P. Berrange 13 Dec '06

13 Dec '06

Previously I sent a patch to handle parsing of the new PVFB syntax. This patch provides the counterpart - generating the new syntax when creating paravirt guests. We only enable the new style syntax if using xendConfigVersion 3 or later (ie, 3.0.4), and only for PV guests. HVM and older PV guests still use old style syntax. In this I also added support for vnclisten & vncpasswd parameters mapped to the 'listen' and 'passwd' attributes on the XML <graphics> tag. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 3

[Libvir] [PATCH] Support parsing of new SEXPR for PVFB
by Daniel P. Berrange 05 Dec '06

05 Dec '06

The paravirt framebuffer patches for Xen finally got merged into upstream xen-devel. In doing so, however, the syntax of the SEXPR for configuring them changed completely. The existing framebuffer suppoirt in libvirt thus only works with the 3.0.3 tree + PVFB patches. For 3.0.4 we need to work with the new scheme. Fortunately, in 3.0.4 the xend_config_version flag is bumped from 2 -> 3, so we have an easy value to hook off. The attached patch thus adds support for parsing an SEXPR looking like (device (vfb (vncunused 1) (vnclisten 127.0.0.1) (vncpasswd 123456) (type vnc) ) ) And generating the <graphics type='vnc' port='5903'/> XML tag to match. (A later patch will add support for the reverse direction) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Release of libvirt-0.1.9
by Daniel Veillard 29 Nov '06

29 Nov '06

A lot of improvement and bug fixes have accumulated in the last month, so it was clearly time for a new release: ftp://libvirt.org/libvirt/libvirt-0.1.9.tar.gz * python bindings: release interpeter lock when calling C (Daniel Berrange) * don't raise HTTP error when looking informations for a domain * some refactoring to use the driver for all entry points * better error reporting (Daniel Berrange) * fix OS reporting when running as non-root * provide XML parsing errors * extension of the test framework (Daniel Berrange) * fix the reconnect regression test * python bindings: Domain instances now link to the Connect to avoid garbage collection and disconnect * separate the notion of maximum memory and current use at the XML level * Fix a memory leak (Daniel Berrange) * add support for shareable drives * add support for non-bridge style networking configs for guests(Daniel Berrange) * python bindings: fix unsigned long marshalling (Daniel Berrange) * new config APIs virConfNew() and virConfSetValue() to build configs from scratch * hot plug device support based on Michel Ponceau patch * added support for inactive domains, new APIs, various associated cleanup (Daniel Berrange) * special device model for HVM guests (Daniel Berrange) * add API to dump core of domains (but requires a patched xend) * pygrub bootloader informations take over <os> informations * updated the localization strings thanks to everybody who helped for this new release, with bug reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] vif-nat network setup
by Tomas Kouba 23 Nov '06

23 Nov '06

Hello, is it possible to setup a NAT-ed network with libvir? My dom0 is configured so that it does a router for domUs and it also does NAT for domUs. I can set this up manually but now I would like to install some other domUs automatically with virt-install. I see that it uses libvir to create new domain from the XML description so it should be easy to add some option that would configure the XML, but I cannot find if the XML supports NAT setup. If I try 'virsh dumpxml' when the domU runs I get this: Unimplemented block at xend_internal.c:1667 <domain type='xen' id='1'> <name>ce</name> <uuid>400be3cf7cedc1d388de8796a85daff1</uuid> <os> <type>linux</type> <kernel>/boot/vmlinuz-2.6.18-prep</kernel> <initrd>/boot/initrd-2.6.18-prep.img</initrd> <root>/dev/sda1</root> <cmdline>fastboot ro root=/dev/sda1</cmdline> </os> <memory>131072</memory> <vcpu>1</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices>  <console tty='/dev/pts/2'/> </devices> </domain> Thanks for any answer. -- Tomas Kouba

3 3

[Libvir] virDomainDump() API (equivalent to xm dump) in libvirt?
by Lon Hohberger 22 Nov '06

22 Nov '06

There's already one for saving live domains: int virDomainSave(virDomainPtr domain, const char *to); Why not use a similar API for a function which does the equivalent of 'xm dump' ? int virDomainDump(virDomainPtr domain, const char *to, int flags); Create a kernel dump of the domain in the path contained in *to. This API must fail if the domain is not in a panicked/crashed state. If you set the lowest-bit in flags, however, you can override this behavior: if the lowest bit is set, the domain will first be crashed (similar to SysRq-C) - then a dump will be taken from that. Why? In the event that a cluster node needs to fence a Xen domain (or other management tools, to be sure), we could use the API to generate a core of the domain (if it panicked) to help debug the problem prior to restarting the domain. The 'crash-before-dump' bit is just something someone might want to use at some point; I don't think it is absolutely necessary - but it doesn't hurt anything either. -- Lon

4 12

Re: [Libvir] Patch to attach/detach virtual devices on a running domain
by michel.ponceau＠bull.net 21 Nov '06

21 Nov '06

There is a bug in GetNetworkID(): return(ret) with ret=list[i], after free(list). It leads to process abort on free(xref) in caller XMLDevID(). I corrected this by replacing: ret = list[i]; by: ret = malloc(16); if (ret != NULL) strcpy(ret, list[i]); Our tests were successful afterwards. Daniel Veillard <veillard(a)redhat.com> 20/11/2006 16:50 Veuillez répondre à veillard Pour : michel.ponceau(a)bull.net cc : libvir-list(a)redhat.com Objet : Re: [Libvir] Patch to attach/detach virtual devices on a running domain On Thu, Nov 16, 2006 at 12:19:13PM -0500, Daniel Veillard wrote: > On Tue, Nov 14, 2006 at 10:05:47AM -0500, Daniel Veillard wrote: > > 5/ virDomainXMLDevID does direct acces to xs_directory() and xs_read(), > > that's not proper it should not call xenStore directly that need to > > be cleaned up, define one high level function exported from > > xs_internal.[ch] and call that but no direct access should be done > > that leads to unmaintainable code. > > That still need to be isolated, I added a TODO in src/xml.c to this effect. Okay I have done it, as a new function xenStoreDomainGetNetworkID() from xs_internal.[ch] Could you check out the version from CVS and verify I didn't added any regression ? thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1